- 02 Dec, 2013 40 commits
-
-
mark.lam@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=123809. Reviewed by Geoffrey Garen. Source/JavaScriptCore: Also fixed build when disabling the DISASSEMBLER. Added some needed #if's and some comments. * assembler/LinkBuffer.cpp: (JSC::LinkBuffer::finalizeCodeWithDisassembly): * dfg/DFGDisassembler.cpp: * dfg/DFGDisassembler.h: (JSC::DFG::Disassembler::Disassembler): (JSC::DFG::Disassembler::setStartOfCode): (JSC::DFG::Disassembler::setForBlockIndex): (JSC::DFG::Disassembler::setForNode): (JSC::DFG::Disassembler::setEndOfMainPath): (JSC::DFG::Disassembler::setEndOfCode): (JSC::DFG::Disassembler::dump): (JSC::DFG::Disassembler::reportToProfiler): * disassembler/Disassembler.cpp: * disassembler/X86Disassembler.cpp: * jit/FPRInfo.h: * jit/GPRInfo.h: * jit/JITDisassembler.cpp: * jit/JITDisassembler.h: (JSC::JITDisassembler::JITDisassembler): (JSC::JITDisassembler::setStartOfCode): (JSC::JITDisassembler::setForBytecodeMainPath): (JSC::JITDisassembler::setForBytecodeSlowPath): (JSC::JITDisassembler::setEndOfSlowPath): (JSC::JITDisassembler::setEndOfCode): (JSC::JITDisassembler::dump): (JSC::JITDisassembler::reportToProfiler): Source/WTF: * wtf/Platform.h: - Ensure that the ASSEMBLER is enabled when the DISASSEMBLER is enabled. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125110 Reviewed by Darin Adler. FrameLoader::loadProgressingStatusChanged() might be called while the Frame has a null FrameView. It’s unclear how to reproduce, but there’s no harm in a null check. * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadProgressingStatusChanged): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
enrica@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125119 Reviewed by Tim Horton. * Shared/EditorState.h: * Shared/NativeWebKeyboardEvent.h: * Shared/NativeWebMouseEvent.h: * Shared/NativeWebTouchEvent.h: * Shared/mac/RemoteLayerBackingStore.h: * Shared/mac/RemoteLayerTreePropertyApplier.mm: * UIProcess/Launcher/mac/ProcessLauncherMac.mm: * UIProcess/PageClient.h: * UIProcess/ios/TiledCoreAnimationDrawingAreaProxyIOS.mm: * UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm: * UIProcess/mac/SecItemShimProxy.messages.in: * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: * WebProcess/WebPage/WebPage.cpp: * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125123 Reviewed by Andreas Kling. * UIProcess/API/C/WKContext.h: * UIProcess/API/C/WKContextConnectionClient.h: * UIProcess/API/C/WKContextDownloadClient.h: * UIProcess/API/C/WKContextHistoryClient.h: * UIProcess/API/C/WKContextInjectedBundleClient.h: * UIProcess/API/C/WKOriginDataManager.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125121 Reviewed by Andreas Kling. * UIProcess/API/C/WKContext.h: * UIProcess/API/C/WKContextConnectionClient.h: Added. * UIProcess/API/C/WKContextDownloadClient.h: Added. * UIProcess/API/C/WKContextHistoryClient.h: Added. * UIProcess/API/C/WKContextInjectedBundleClient.h: Added. * WebKit2.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124556 Reviewed by Anders Carlsson. * UIProcess/WebContextUserMessageCoders.h: (WebKit::WebContextUserMessageEncoder::encode): (WebKit::WebContextUserMessageDecoder::decode): * UIProcess/WebPageGroup.cpp: (WebKit::WebPageGroup::addProcess): (WebKit::WebPageGroup::disconnectProcess): * UIProcess/WebPageGroup.h: (WebKit::WebPageGroup::sendToAllProcessesInGroup): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage): * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::disconnect): (WebKit::WebProcessProxy::webPageGroup): (WebKit::WebProcessProxy::addWebPageGroup): * UIProcess/WebProcessProxy.h: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::webPageGroup): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125120 Reviewed by Andreas Kling. * Shared/API/c/WKConnectionRef.h: * UIProcess/API/C/WKCookieManager.h: * UIProcess/API/C/WKDatabaseManager.h: * UIProcess/API/C/WKGeolocationManager.h: * UIProcess/API/C/WKIconDatabase.h: * UIProcess/API/C/WKNotificationProvider.h: * UIProcess/API/C/WKPageContextMenuClient.h: * UIProcess/API/C/WKPageFindClient.h: * UIProcess/API/C/WKPageFindMatchesClient.h: * UIProcess/API/C/WKPageFormClient.h: * UIProcess/API/C/WKPageLoaderClient.h: * UIProcess/API/C/WKPagePolicyClient.h: * UIProcess/API/C/WKPageUIClient.h: * WebProcess/InjectedBundle/API/c/WKBundle.h: * WebProcess/InjectedBundle/API/c/WKBundlePageBanner.h: * WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h: * WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h: * WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h: * WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h: * WebProcess/InjectedBundle/API/c/WKBundlePageFullScreenClient.h: * WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h: * WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h: * WebProcess/InjectedBundle/API/c/WKBundlePagePolicyClient.h: * WebProcess/InjectedBundle/API/c/WKBundlePageResourceLoadClient.h: * WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
samuel_white@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124561 Reviewed by Chris Fleizach. Added test to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should and updated existing test that has exposes this new attribute. * platform/mac/accessibility/bounds-for-range-expected.txt: * platform/mac/accessibility/search-predicate-element-count-expected.txt: Added. * platform/mac/accessibility/search-predicate-element-count.html: Added. Added ability to fetch the number of elements that match a specific criteria. This will enable VoiceOver to interface with WebKit much more dynamically. We can now get an idea of how many interesting elements exist on a page, and then fetch them in chunks as needed. Test: platform/mac/accessibility/search-predicate-element-count.html * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isAccessibilityTextSearchMatch): * accessibility/AccessibilityObject.h: (WebCore::AccessibilitySearchCriteria::AccessibilitySearchCriteria): * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (accessibilitySearchCriteriaForSearchPredicateParameterizedAttribute): (-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should. * DumpRenderTree/AccessibilityUIElement.cpp: (uiElementCountForSearchPredicateCallback): (uiElementForSearchPredicateCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: (AccessibilityUIElement::uiElementCountForSearchPredicate): * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::uiElementCountForSearchPredicate): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (searchPredicateParameterizedAttributeForSearchCriteria): (AccessibilityUIElement::uiElementCountForSearchPredicate): (AccessibilityUIElement::uiElementForSearchPredicate): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::uiElementCountForSearchPredicate): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::searchPredicateParameterizedAttributeForSearchCriteria): (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): (WTR::AccessibilityUIElement::uiElementForSearchPredicate): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bjonesbe@adobe.com authored
https://bugs.webkit.org/show_bug.cgi?id=124619 Reviewed by Dirk Schulze. Source/WebCore: Implement support for doing layout with the new circle shape syntax, inclduing basic animation support. Tests: fast/shapes/shape-outside-floats/shape-outside-floats-circle-000.html fast/shapes/shape-outside-floats/shape-outside-floats-circle-001.html fast/shapes/shape-outside-floats/shape-outside-floats-circle-002.html fast/shapes/shape-outside-floats/shape-outside-floats-circle-003.html fast/shapes/shape-outside-floats/shape-outside-floats-circle-004.html fast/shapes/shape-outside-floats/shape-outside-floats-circle-005.html * css/BasicShapeFunctions.cpp: (WebCore::floatValueForCenterCoordinate): Used by both the CSS Shapes layout code and the clip path code. * css/BasicShapeFunctions.h: * css/CSSBasicShapes.cpp: (WebCore::buildCircleString): Update to use appendLiteral, and remove call to reserveCapacity - if we find that it's actually slow when doing performance tests, we can hopefully do something smarter and less ugly than that. * css/CSSParser.cpp: (WebCore::CSSParser::parseShapeRadius): Fix a logic error that caused the radius keywords not to work properly. * rendering/shapes/Shape.cpp: (WebCore::Shape::createShape): Convert new circle to a layout shape. * rendering/style/BasicShapes.cpp: (WebCore::BasicShape::canBlend): Ignore circles with values that cannot be interpolated. (WebCore::BasicShapeCircle::floatValueForRadiusInBox): Convert circle radius keywords to a float value. (WebCore::BasicShapeCircle::path): (WebCore::BasicShapeCircle::blend): * rendering/style/BasicShapes.h: (WebCore::BasicShapeCenterCoordinate::canBlend): (WebCore::BasicShapeRadius::canBlend): LayoutTests: Add a few tests for the new circle syntax. The old tests in LayoutTests/csswg will be removed when the old syntax is removed. Also update existing shape-inside, animation, and clip-path tests to test the new syntax. * animations/resources/animation-test-helpers.js: (parseBasicShape): * LayoutTests/animations/resources/animation-test-helpers.js: * LayoutTests/css3/masking/clip-path-animation-expected.txt: * LayoutTests/css3/masking/clip-path-animation.html: * LayoutTests/css3/masking/clip-path-circle-filter.html: * LayoutTests/css3/masking/clip-path-circle-overflow-hidden.html: * LayoutTests/css3/masking/clip-path-circle-overflow.html: * LayoutTests/css3/masking/clip-path-circle-relative-overflow.html: * LayoutTests/css3/masking/clip-path-circle.html: * LayoutTests/css3/masking/clip-path-restore.html: * LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt: * LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt: * LayoutTests/fast/shapes/parsing/parsing-test-utils.js: * LayoutTests/fast/shapes/shape-inside/shape-inside-animation-expected.txt: * LayoutTests/fast/shapes/shape-inside/shape-inside-animation.html: * LayoutTests/fast/shapes/shape-inside/shape-inside-calc-crash-expected.txt: * LayoutTests/fast/shapes/shape-inside/shape-inside-calc-crash.html: * LayoutTests/fast/shapes/shape-inside/shape-inside-circle-padding.html: * LayoutTests/fast/shapes/shape-inside/shape-inside-circle.html: * LayoutTests/fast/shapes/shape-inside/shape-inside-dynamic-nested.html: * LayoutTests/fast/shapes/shape-inside/shape-inside-empty-expected.html: * LayoutTests/fast/shapes/shape-inside/shape-inside-empty.html: * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: * fast/shapes/shape-outside-floats/shape-outside-animation.html: * fast/shapes/shape-outside-floats/shape-outside-floats-circle-000-expected.html: Added. * fast/shapes/shape-outside-floats/shape-outside-floats-circle-000.html: Added. * fast/shapes/shape-outside-floats/shape-outside-floats-circle-001-expected.html: Added. * fast/shapes/shape-outside-floats/shape-outside-floats-circle-001.html: Added. * fast/shapes/shape-outside-floats/shape-outside-floats-circle-002-expected.html: Added. * fast/shapes/shape-outside-floats/shape-outside-floats-circle-002.html: Added. * fast/shapes/shape-outside-floats/shape-outside-floats-circle-003-expected.html: Added. * fast/shapes/shape-outside-floats/shape-outside-floats-circle-003.html: Added. * fast/shapes/shape-outside-floats/shape-outside-floats-circle-004-expected.html: Added. * fast/shapes/shape-outside-floats/shape-outside-floats-circle-004.html: Added. * fast/shapes/shape-outside-floats/shape-outside-floats-circle-005-expected.html: Added. * fast/shapes/shape-outside-floats/shape-outside-floats-circle-005.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py https://bugs.webkit.org/show_bug.cgi?id=124714 Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-02 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (write_test_result): * Scripts/webkitpy/layout_tests/models/test_failures.py: (TestFailure.write_failure): (FailureText): (FailureText.write_failure): (FailureAudio): (FailureAudio.write_failure): (FailureCrash.write_failure): (FailureMissingResult): (FailureTextMismatch): (FailureMissingImageHash.write_failure): (FailureMissingImage.write_failure): (FailureImageHashMismatch.write_failure): (FailureReftestMismatch.write_failure): (FailureReftestMismatchDidNotOccur.write_failure): (FailureMissingAudio): (FailureAudioMismatch): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=124703 Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-02 Reviewed by Ryosuke Niwa. Remove the stderr_write attribute from this class in checker and replace its use with calls to a logging module logger. We Should use logging module instead of writing to stderr directly. * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger. (check_webkit_style_configuration): (CheckerDispatcher.dispatch): Remove FIXME comment. (StyleProcessorConfiguration): (StyleProcessorConfiguration.__init__): (StyleProcessorConfiguration.write_style_error): * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification. There is an "ERROR" prefix in log messiges from now. (StyleProcessorConfigurationTest): (StyleProcessorConfigurationTest._style_checker_configuration): (StyleProcessorConfigurationTest.test_init): (StyleProcessorConfigurationTest.test_write_style_error_emacs): (StyleProcessorConfigurationTest.test_write_style_error_vs7): (StyleProcessor_EndToEndTest.with): (StyleProcessor_EndToEndTest.test_init): (StyleProcessor_EndToEndTest.test_process): (StyleProcessor_CodeCoverageTest.setUp): * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger. (DefaultStyleErrorHandler.__call__): * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification. There is an "ERROR" prefix in log messiges from now. (DefaultStyleErrorHandlerTest): (DefaultStyleErrorHandlerTest.setUp): (DefaultStyleErrorHandlerTest._mock_increment_error_count): (DefaultStyleErrorHandlerTest._style_checker_configuration): (DefaultStyleErrorHandlerTest._check_initialized): (DefaultStyleErrorHandlerTest.test_non_reportable_error): (DefaultStyleErrorHandlerTest.test_max_reports_per_category): (DefaultStyleErrorHandlerTest.test_line_numbers): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125115 Reviewed by Andreas Kling. * WebKit2.xcodeproj/project.pbxproj: * WebProcess/InjectedBundle/API/c/WKBundlePage.h: * WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h: Added. * WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h: Added. * WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h: Added. * WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h: Added. * WebProcess/InjectedBundle/API/c/WKBundlePageFullScreenClient.h: Added. * WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h: Added. * WebProcess/InjectedBundle/API/c/WKBundlePagePolicyClient.h: Added. * WebProcess/InjectedBundle/API/c/WKBundlePageResourceLoadClient.h: Added. * WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125114 Reviewed by Anders Carlsson. Source/WebCore: Test: crypto/subtle/hmac-check-algorithm.html * crypto/algorithms/CryptoAlgorithmHMAC.cpp: (WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches): Check it. LayoutTests: * crypto/subtle/hmac-check-algorithm-expected.txt: Added. * crypto/subtle/hmac-check-algorithm.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125110 Reviewed by Darin Adler. It’s possible to have a null m_originatingProgressFrame when the heartbeat timer fires. On the surface this seems impossible because the only time m_originatingProgressFrame is cleared out the heartbeat timer is also stopped. But there’s likely still a race condition in multi-threaded environments. There’s no harm in null-checking m_originatingProgressFrame before accessing its loader. * loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressHeartbeatTimerFired): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125107 Reviewed by Mark Hahnenberg. Just killing dead code. * jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_negate): (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emitSlow_op_urshift): (JSC::JIT::emitSlow_op_bitand): (JSC::JIT::emitSlow_op_inc): (JSC::JIT::emitSlow_op_dec): (JSC::JIT::emitSlow_op_mod): (JSC::JIT::emit_op_mod): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::emitSlow_op_div): * jit/JITArithmetic32_64.cpp: (JSC::JIT::emitSlow_op_negate): (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emitRightShiftSlowCase): (JSC::JIT::emitSlow_op_bitand): (JSC::JIT::emitSlow_op_bitor): (JSC::JIT::emitSlow_op_bitxor): (JSC::JIT::emitSlow_op_inc): (JSC::JIT::emitSlow_op_dec): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitSlow_op_div): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_strcat): (JSC::JIT::emitSlow_op_get_callee): (JSC::JIT::emitSlow_op_create_this): (JSC::JIT::emitSlow_op_to_this): (JSC::JIT::emitSlow_op_to_primitive): (JSC::JIT::emitSlow_op_not): (JSC::JIT::emitSlow_op_bitxor): (JSC::JIT::emitSlow_op_bitor): (JSC::JIT::emitSlow_op_stricteq): (JSC::JIT::emitSlow_op_nstricteq): (JSC::JIT::emitSlow_op_to_number): * jit/JITOpcodes32_64.cpp: (JSC::JIT::emitSlow_op_to_primitive): (JSC::JIT::emitSlow_op_not): (JSC::JIT::emitSlow_op_stricteq): (JSC::JIT::emitSlow_op_nstricteq): (JSC::JIT::emitSlow_op_to_number): (JSC::JIT::emitSlow_op_get_callee): (JSC::JIT::emitSlow_op_create_this): (JSC::JIT::emitSlow_op_to_this): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=125085 Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-02 Reviewed by Sam Weinig. * Scripts/webkit2/messages.py: (generate_message_handler): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=124982 Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-12-02 Reviewed by Benjamin Poulain. Adding new Platform files that are missing in the trunk. * PlatformNix.cmake: * nix/public/AudioDestinationConsumer.h: Added. (Nix::AudioDestinationConsumer::~AudioDestinationConsumer): * nix/public/MediaConstraints.h: Added. * nix/public/MediaStream.h: Added. * nix/public/MediaStreamAudioSource.h: Added. * nix/public/MediaStreamCenter.h: Added. * nix/public/MediaStreamSource.h: Added. * nix/public/PrivatePtr.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125106 Reviewed by Sam Weinig. Only some functions in PageCache.cpp null-check the CachedPages in HistoryItems. Every part that manipulates the CachedPage should. * history/PageCache.cpp: (WebCore::PageCache::markPagesForVistedLinkStyleRecalc): (WebCore::PageCache::markPagesForFullStyleRecalc): (WebCore::PageCache::markPagesForDeviceScaleChanged): (WebCore::PageCache::markPagesForCaptionPreferencesChanged): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=125049 Patch by Brian J. Burg <burg@cs.washington.edu> on 2013-12-02 Reviewed by Joseph Pecoraro. Add a JavaScript file type, extension, and checker (JSChecker). Use TextChecker for JavaScript tests, libraries, website resources, etc. and use JSChecker for files within WebInspectorUI/UserInterface. Amended tests for TextChecker to reflect the rule above. * Scripts/webkitpy/style/checker.py: (_all_categories): Add categories defined by JSChecker. (FileType): Add file type for JS and re-number the enum. (CheckerDispatcher._file_type): Detect .js files as JavaScript. (CheckerDispatcher._create_checker): Create a JSChecker or TextChecker depending on the file's path. * Scripts/webkitpy/style/checker_unittest.py: (CheckerDispatcherDispatchTest.assert_checker_js): Added. (CheckerDispatcherDispatchTest.test_js_paths): Added. (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths that end in .js but should be checked with TextChecker. * Scripts/webkitpy/style/checkers/js.py: Added. (JSChecker): (JSChecker.__init__): (JSChecker.check): * Scripts/webkitpy/style/checkers/js_unittest.py: Added. (JSTestCase): (JSTestCase.assertNoError): (JSTestCase.assertNoError.error_for_test): (JSTestCase.assertError): (JSTestCase.assertError.error_for_test): (JSTestCase.test_no_error): (JSTestCase.test_error): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zoltan@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=124903 Reviewed by David Hyatt. Source/WebCore: In this patch I added support for inset shape parsing for CSS Shapes. Inset is defined by CSS Shapes Level 1 (http://dev.w3.org/csswg/css-shapes-1/#supported-basic-shapes). Inset is going to be used by shape-outside (bug #124905), and eventually by shape-inside. No new tests, I updated existing tests to cover the changes. * css/BasicShapeFunctions.cpp: (WebCore::valueForBasicShape): Add support for inset. (WebCore::basicShapeForValue): Add support for inset. * css/CSSBasicShapes.cpp: (WebCore::buildInsetString): Create inset css string. (WebCore::CSSBasicShapeInset::cssText): Convert inset shape to a CSS string. (WebCore::CSSBasicShapeInset::equals): Compare two inset rectangles. (WebCore::CSSBasicShapeInset::serializeResolvingVariables): Create an inset string, with CSS variables resolved. (WebCore::CSSBasicShapeInset::hasVariableReference): Determine if this inset has any CSS Variable references. * css/CSSBasicShapes.h: Add inset class. (WebCore::CSSBasicShapeInset::create): (WebCore::CSSBasicShapeInset::top): (WebCore::CSSBasicShapeInset::right): (WebCore::CSSBasicShapeInset::bottom): (WebCore::CSSBasicShapeInset::left): (WebCore::CSSBasicShapeInset::topLeftRadius): (WebCore::CSSBasicShapeInset::topRightRadius): (WebCore::CSSBasicShapeInset::bottomRightRadius): (WebCore::CSSBasicShapeInset::bottomLeftRadius): (WebCore::CSSBasicShapeInset::setTop): (WebCore::CSSBasicShapeInset::setRight): (WebCore::CSSBasicShapeInset::setBottom): (WebCore::CSSBasicShapeInset::setLeft): (WebCore::CSSBasicShapeInset::setTopLeftRadius): (WebCore::CSSBasicShapeInset::setTopRightRadius): (WebCore::CSSBasicShapeInset::setBottomRightRadius): (WebCore::CSSBasicShapeInset::setBottomLeftRadius): (WebCore::CSSBasicShapeInset::CSSBasicShapeInset): * css/CSSParser.cpp: (WebCore::completeBorderRadii): Move static function before parseInsetBorderRadius. (WebCore::CSSParser::parseInsetRoundedCorners): I added this helper function for parsing the rounded corners (WebCore::CSSParser::parseBasicShapeInset): Parse inset. (WebCore::CSSParser::parseBasicShape): Add call to parse inset. * css/CSSParser.h: * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Add constructor for LengthSize. (WebCore::CSSPrimitiveValue::init): Initialize LengthSize. * css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::create): Add support for creating PrimitiveValue from LengthSize. * css/CSSValuePool.h: (WebCore::CSSValuePool::createValue): Add support for LengthSize. * platform/LengthSize.h: (WebCore::LengthSize::blend): Add blend for LengthSize. * rendering/shapes/ShapeInsideInfo.cpp: (WebCore::ShapeInsideInfo::isEnabledFor): Keep inset disabled for shape-inside now. * rendering/style/BasicShapes.cpp: (WebCore::BasicShapeInset::path): Calculate path for an inset. (WebCore::BasicShapeInset::blend): Blend two insets. * rendering/style/BasicShapes.h: Add higher level inset. (WebCore::BasicShapeInset::create): (WebCore::BasicShapeInset::top): (WebCore::BasicShapeInset::right): (WebCore::BasicShapeInset::bottom): (WebCore::BasicShapeInset::left): (WebCore::BasicShapeInset::topLeftRadius): (WebCore::BasicShapeInset::topRightRadius): (WebCore::BasicShapeInset::bottomRightRadius): (WebCore::BasicShapeInset::bottomLeftRadius): (WebCore::BasicShapeInset::setTop): (WebCore::BasicShapeInset::setRight): (WebCore::BasicShapeInset::setBottom): (WebCore::BasicShapeInset::setLeft): (WebCore::BasicShapeInset::setTopLeftRadius): (WebCore::BasicShapeInset::setTopRightRadius): (WebCore::BasicShapeInset::setBottomRightRadius): (WebCore::BasicShapeInset::setBottomLeftRadius): (WebCore::BasicShapeInset::BasicShapeInset): LayoutTests: * fast/shapes/parsing/parsing-shape-inside-expected.txt: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * fast/shapes/parsing/parsing-shape-outside-expected.txt: * fast/shapes/parsing/parsing-test-utils.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124874 <rdar://problem/15349468> Reviewed by Simon Fraser. We use PlatformCALayer::clone for CSS reflections, so implement it. Also, since many reflections testcases also use masks, working on this revealed that masks weren't working, because we weren't flushing mask layers. * Shared/mac/RemoteLayerTreePropertyApplier.mm: (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer): * Shared/mac/RemoteLayerTreeTransaction.mm: (WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties): (WebKit::RemoteLayerTreeTransaction::LayerProperties::encode): (WebKit::RemoteLayerTreeTransaction::LayerProperties::decode): Rename maskLayer->maskLayerID since it's a LayerID. * UIProcess/mac/RemoteLayerTreeHost.mm: (WebKit::RemoteLayerTreeHost::commit): Don't try to look up the layer if it's null. * Shared/mac/RemoteLayerTreeTransaction.h: (WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged): * Shared/mac/RemoteLayerTreeTransaction.mm: (WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties): Keep track of all properties that have ever been changed on a layer. * WebProcess/WebPage/mac/PlatformCALayerRemote.cpp: (PlatformCALayerRemote::create): (PlatformCALayerRemote::PlatformCALayerRemote): (PlatformCALayerRemote::clone): Copy all of the layer properties from the original to the clone, and mark all properties that have ever been modified as needing to be flushed to the UI process. (PlatformCALayerRemote::recursiveBuildTransaction): Flush our mask layer, if we have one. (PlatformCALayerRemote::setMask): * WebProcess/WebPage/mac/PlatformCALayerRemote.h: Store the mask layer we're given. Our owning GraphicsLayer will hold on to it for us. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125105 Reviewed by Sam Weinig. Source/WebCore: Tests: crypto/subtle/aes-kw-key-manipulation.html crypto/subtle/aes-kw-wrap-unwrap-aes.html * WebCore.xcodeproj/project.pbxproj: Added new files. * crypto/CryptoAlgorithmIdentifier.h: (WebCore::CryptoAlgorithmIdentifier): Added AES-KW. It's not standardized yet, but there appears to be a consensus that it will be specified. * bindings/js/JSCryptoAlgorithmDictionary.cpp: (WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt): (WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt): (WebCore::JSCryptoAlgorithmDictionary::createParametersForSign): (WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify): (WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest): (WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey): (WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey): (WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits): (WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey): (WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey): Added AES-KW cases everywhere. * bindings/js/JSCryptoKeySerializationJWK.cpp: (WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm): (WebCore::JSCryptoKeySerializationJWK::keySizeIsValid): (WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON): Support importing/exporting AES-KW keys in JWK. * bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::importKey): (WebCore::JSSubtleCrypto::exportKey): (WebCore::JSSubtleCrypto::wrapKey): (WebCore::JSSubtleCrypto::unwrapKey): Added some accidentally forgotten std::moves. * crypto/algorithms/CryptoAlgorithmAES_KW.cpp: Added. * crypto/algorithms/CryptoAlgorithmAES_KW.h: Added. * crypto/mac/CryptoAlgorithmAES_KWMac.cpp: Added. * crypto/keys/CryptoKeyAES.cpp: (WebCore::CryptoKeyAES::CryptoKeyAES): Allow AES-KW as valid algorithm for AES keys. * crypto/mac/CryptoAlgorithmRegistryMac.cpp: (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register AES-KW. LayoutTests: * crypto/subtle/aes-kw-key-manipulation-expected.txt: Added. * crypto/subtle/aes-kw-key-manipulation.html: Added. * crypto/subtle/aes-kw-wrap-unwrap-aes-expected.txt: Added. * crypto/subtle/aes-kw-wrap-unwrap-aes.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125104 Reviewed by Sam Weinig. Add multiple versions of the WKPageLoaderClient struct. In a subsequent patch, WKPageLoaderClient and kWKPageLoaderClientCurrentVersion will be deprecated. Instead, users of the API are supposed to explicitly choose a version and a versioned struct. * Shared/APIClient.h: Add a new API::Client class with a new ClientTraits template that uses std::tuple for versions. * Shared/APIClientTraits.cpp: * Shared/APIClientTraits.h: Remove WKPageLoaderClient interface sizes. * UIProcess/API/C/WKPage.cpp: (WKPageSetPageLoaderClient): Add an explicit cast to WKPageLoaderClientBase. In an upcoming patch, WKPageSetPageLoaderClient will be changed to take a WKPageLoaderClientBase instead. * UIProcess/API/C/WKPageLoaderClient.h: Add new versions. * UIProcess/API/Cocoa/WKBrowsingContextController.mm: (setUpPageLoaderClient): Use an explicit version. * UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didStartProvisionalLoadForFrame): (WebKit::WebLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame): (WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame): (WebKit::WebLoaderClient::didCommitLoadForFrame): (WebKit::WebLoaderClient::didFinishDocumentLoadForFrame): (WebKit::WebLoaderClient::didFinishLoadForFrame): (WebKit::WebLoaderClient::didFailLoadWithErrorForFrame): (WebKit::WebLoaderClient::didSameDocumentNavigationForFrame): (WebKit::WebLoaderClient::didReceiveTitleForFrame): (WebKit::WebLoaderClient::didFirstLayoutForFrame): (WebKit::WebLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame): (WebKit::WebLoaderClient::didLayout): (WebKit::WebLoaderClient::didRemoveFrameFromHierarchy): (WebKit::WebLoaderClient::didDisplayInsecureContentForFrame): (WebKit::WebLoaderClient::didRunInsecureContentForFrame): (WebKit::WebLoaderClient::didDetectXSSForFrame): (WebKit::WebLoaderClient::canAuthenticateAgainstProtectionSpaceInFrame): (WebKit::WebLoaderClient::didReceiveAuthenticationChallengeInFrame): (WebKit::WebLoaderClient::didStartProgress): (WebKit::WebLoaderClient::didChangeProgress): (WebKit::WebLoaderClient::didFinishProgress): (WebKit::WebLoaderClient::processDidBecomeUnresponsive): (WebKit::WebLoaderClient::interactionOccurredWhileProcessUnresponsive): (WebKit::WebLoaderClient::processDidBecomeResponsive): (WebKit::WebLoaderClient::processDidCrash): (WebKit::WebLoaderClient::didChangeBackForwardList): (WebKit::WebLoaderClient::shouldGoToBackForwardListItem): (WebKit::WebLoaderClient::willGoToBackForwardListItem): (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy): Go through client.base everywhere. * UIProcess/WebLoaderClient.h: Add API::ClientTraits specialization. Change WebLoaderClient to derive from API::Client<WKPageLoaderClientBase>. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeLoaderClient): This now takes a WKPageLoaderClientBase*. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mhahnenberg@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125092 Reviewed by Filip Pizlo. This can be slow, especially with full debug builds. It should just symlink the VM into the bundle by default and do a full copy only when asked. * Scripts/run-jsc-stress-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdakin@apple.com authored
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124801 Reviewed by Filip Pizlo. * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl command on Windows so that stress tests can run. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdakin@apple.com authored
don't move on rubber-band https://bugs.webkit.org/show_bug.cgi?id=124745 Reviewed by Tim Horton. Source/WebCore: New setting backgroundShouldExtendBeyondPage() will cause the tile cache to have a margin, and it will also cause fixed elements and backgrounds to stick to the viewport on scroll instead of sticking to the document. * WebCore.exp.in: * page/FrameView.cpp: (WebCore::FrameView::scrollBehaviorForFixedElements): * page/Settings.in: * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): Source/WebKit: Keep Windows happy. * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Source/WebKit2: Add SPI to enable the new setting. * Shared/WebPreferencesStore.h: * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetBackgroundShouldExtendBeyondPage): (WKPreferencesGetBackgroundShouldExtendBeyondPage): * UIProcess/API/C/WKPreferencesPrivate.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=125021 Patch by Roger Zanoni <rogerzanoni@gmail.com> on 2013-12-02 Reviewed by Eric Carlson. Also, changing iterator variable names from iter to it and initializing an 'end' variable in each loop instead of evaluating 'collection.end()' multiple times. No new tests, covered by existing ones. * Modules/mediastream/MediaStream.cpp: (WebCore::MediaStream::cloneMediaStreamTrackVector): (WebCore::MediaStream::haveTrackWithSource): (WebCore::MediaStream::getTrackById): (WebCore::MediaStream::trackDidEnd): (WebCore::MediaStream::scheduledEventTimerFired): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mhahnenberg@apple.com authored
* Scripts/run-jsc-stress-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124872 Reviewed by Brent Fulgham. setLayerTreeStateIsFrozen is the mechanism used to ensure that layer property changes (including new backing store) aren't committed while e.g. the page is reconfigured for printing. * WebProcess/WebPage/mac/RemoteLayerTreeContext.h: * WebProcess/WebPage/mac/RemoteLayerTreeContext.mm: (WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext): (WebKit::RemoteLayerTreeContext::flushLayers): (WebKit::RemoteLayerTreeContext::setIsFlushingSuspended): * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mhahnenberg@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124549 Reviewed by Filip Pizlo. * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation of grep -i -q * Scripts/run-javascriptcore-tests: Pass through the --tarball flag. * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. We now also copy whatever VM was specified, along with its associated framework, into this directory. All of the generated scripts now are completely relative within the results directory. This allows run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a tarball of the generated results directory. Also refactored several portions of the script into separate functions to make it easier to run them conditionally depending on which mode we're running in. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=124620 Patch by Rob Buis <rob.buis@samsung.com> on 2013-12-02 Reviewed by Dirk Schulze. Source/WebCore: Implement parsing of the new ellipse shape syntax. This closely follows the patch for the new circle syntax (https://bugs.webkit.org/show_bug.cgi?id=124618), with some refactoring of functionality shared by both. Updated existing parsing tests to cover this. * css/BasicShapeFunctions.cpp: (WebCore::BasicShapeRadiusToCSSValue): (WebCore::valueForBasicShape): (WebCore::CSSValueToBasicShapeRadius): (WebCore::basicShapeForValue): * css/CSSBasicShapes.cpp: (WebCore::buildEllipseString): (WebCore::CSSBasicShapeEllipse::cssText): (WebCore::CSSBasicShapeEllipse::equals): (WebCore::buildDeprecatedEllipseString): (WebCore::CSSDeprecatedBasicShapeEllipse::cssText): (WebCore::CSSDeprecatedBasicShapeEllipse::equals): * css/CSSBasicShapes.h: (WebCore::CSSDeprecatedBasicShapeEllipse::create): (WebCore::CSSDeprecatedBasicShapeEllipse::centerX): (WebCore::CSSDeprecatedBasicShapeEllipse::centerY): (WebCore::CSSDeprecatedBasicShapeEllipse::radiusX): (WebCore::CSSDeprecatedBasicShapeEllipse::radiusY): (WebCore::CSSDeprecatedBasicShapeEllipse::setCenterX): (WebCore::CSSDeprecatedBasicShapeEllipse::setCenterY): (WebCore::CSSDeprecatedBasicShapeEllipse::setRadiusX): (WebCore::CSSDeprecatedBasicShapeEllipse::setRadiusY): (WebCore::CSSDeprecatedBasicShapeEllipse::CSSDeprecatedBasicShapeEllipse): * css/CSSParser.cpp: (WebCore::CSSParser::parseBasicShapeEllipse): (WebCore::CSSParser::parseDeprecatedBasicShapeEllipse): (WebCore::CSSParser::parseBasicShape): * css/CSSParser.h: * rendering/shapes/Shape.cpp: (WebCore::Shape::createShape): * rendering/style/BasicShapes.cpp: (WebCore::DeprecatedBasicShapeEllipse::path): (WebCore::DeprecatedBasicShapeEllipse::blend): (WebCore::BasicShapeEllipse::path): (WebCore::BasicShapeEllipse::blend): * rendering/style/BasicShapes.h: (WebCore::BasicShapeEllipse::centerX): (WebCore::BasicShapeEllipse::centerY): (WebCore::BasicShapeEllipse::radiusX): (WebCore::BasicShapeEllipse::radiusY): (WebCore::BasicShapeEllipse::setCenterX): (WebCore::BasicShapeEllipse::setCenterY): (WebCore::BasicShapeEllipse::setRadiusX): (WebCore::BasicShapeEllipse::setRadiusY): (WebCore::BasicShapeEllipse::BasicShapeEllipse): (WebCore::DeprecatedBasicShapeEllipse::create): (WebCore::DeprecatedBasicShapeEllipse::DeprecatedBasicShapeEllipse): LayoutTests: Test that the new ellipse syntax is properly parsed. * fast/shapes/parsing/parsing-shape-inside-expected.txt: * fast/shapes/parsing/parsing-shape-outside-expected.txt: * fast/shapes/parsing/parsing-test-utils.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
graouts@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125069 Reviewed by Joseph Pecoraro. Fix a regression introduced in http://trac.webkit.org/changeset/159286. We should only offset the frame of the popover in the y-axis if the target edge is on the x-axis, and vice versa. We also remove the needsToDrawBackground check since it incorrectly disregarded the anchor point. We now always draw the background which is a lot safer and guarantees we'll always draw an adequate frame and anchor point. * UserInterface/Popover.js: (WebInspector.Popover.prototype._update): (WebInspector.Popover.prototype._bestMetricsForEdge): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125084 Build fix. * crypto/CommonCryptoUtilities.h: * crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: * crypto/mac/CryptoKeyRSAMac.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=124811 Patch by Brendan Long <b.long@cablelabs.com> on 2013-12-02 Reviewed by Eric Carlson. Source/WebCore: No new tests because this is just refactoring. * html/track/TrackListBase.cpp: (TrackListBase::TrackListBase): Replace event code with a GenericEventQueue. (TrackListBase::scheduleTrackEvent): Factor out duplicate code in schedule{Add,Remove}TrackEvent functions. (TrackListBase::scheduleAddTrackEvent): Same. (TrackListBase::scheduleRemoveTrackEvent): Same. (TrackListBase::scheduleChangeEvent): Use GenericEventQueue. * html/track/TrackListBase.h: Replace event code with GenericEventQueue. LayoutTests: * platform/mac/TestExpectations: Unskip onremovetrack test which was fixed a long time ago. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125084 Build fix. * WebCore.xcodeproj/project.pbxproj: Fix an automatic merge failure by re-adding CryptoAlgorithmRsaOaepParams.h. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=124875 <rdar://problem/15446024> Reviewed by Simon Fraser. * WebProcess/WebPage/mac/GraphicsLayerCARemote.h: Image-as-layer-contents is not implemented for the remote layer tree. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vjaquez@igalia.com authored
https://bugs.webkit.org/show_bug.cgi?id=125082 Reviewed by Philippe Normand. No new tests, no behavior changes. * platform/graphics/gstreamer/VideoSinkGStreamer.cpp: (webkit_video_sink_class_init): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
graouts@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=125072 Reviewed by Joseph Pecoraro. Add a new WebInspector.Rect.prototype.pad() method which does not alter the rectangle it's called and returns a new rect much like .inset(). I've checked all call sites and there was no reuse of the rectangle that was padded so this patch won't have any side effects. * UserInterface/Breakpoint.js: (WebInspector.Breakpoint.prototype._showEditBreakpointPopover): * UserInterface/CSSStyleDeclarationTextEditor.js: * UserInterface/Geometry.js: (WebInspector.Rect.prototype.pad): * UserInterface/LayerTreeSidebarPanel.js: (WebInspector.LayerTreeSidebarPanel.prototype._updatePopoverForSelectedNode): * UserInterface/SourceCodeTextEditor.js: (WebInspector.SourceCodeTextEditor.prototype._showPopover): * UserInterface/TimelineDataGrid.js: (WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vjaquez@igalia.com authored
https://bugs.webkit.org/show_bug.cgi?id=125077 Remove the method's unused parameter. Remove the GStreamer 0.10.22 run-time validation, since we are using GStreamer 1.0 officially. Remove the creation of a spurious Bin for the video sink, since either the fpssink or the webkitsink are valid sink elements. Change fpsink to a GRefPtr. Now, createVideoSink() returns a simple pointer to the created sink element. Reviewed by Philippe Normand. No new tests, no behavior changes. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: (WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink): (WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount): (WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount): * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-