1. 18 Mar, 2007 1 commit
    • hyatt's avatar
      WebCore: · 0fa2fbcf
      hyatt authored
              Move frame borders out of WebKit and into WebCore.
      
              Reviewed by aroben, olliej
      
              * bridge/mac/FrameViewMac.mm:
              * css/html4.css:
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
              (WebCore::HTMLFrameSetElement::mapToEntry):
              (WebCore::HTMLFrameSetElement::parseMappedAttribute):
              (WebCore::HTMLFrameSetElement::attach):
              * html/HTMLFrameSetElement.h:
              (WebCore::HTMLFrameSetElement::hasBorderColor):
              * page/FrameView.cpp:
              (WebCore::FrameViewPrivate::FrameViewPrivate):
              * page/FrameView.h:
              * page/mac/WebCoreFrameBridge.h:
              * platform/graphics/IntRect.h:
              (WebCore::IntRect::topLeft):
              (WebCore::IntRect::topRight):
              (WebCore::IntRect::bottomLeft):
              (WebCore::IntRect::bottomRight):
              * rendering/RenderFrame.cpp:
              (WebCore::RenderFrame::viewCleared):
              * rendering/RenderFrameSet.cpp:
              (WebCore::borderStartEdgeColor):
              (WebCore::borderEndEdgeColor):
              (WebCore::RenderFrameSet::paintColumnBorder):
              (WebCore::RenderFrameSet::paintRowBorder):
              (WebCore::RenderFrameSet::paint):
              * rendering/RenderFrameSet.h:
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::viewCleared):
              * rendering/RenderView.cpp:
              (WebCore::RenderView::repaintViewRectangle):
      
      WebKit:
      
              Move frame borders out of WebKit and into WebCore.
      
              Reviewed by aroben, olliej
      
              * WebCoreSupport/WebFrameBridge.mm:
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebFrameView.mm:
              (-[WebFrameView drawRect:]):
              (-[WebFrameView setFrameSize:]):
              * WebView/WebFrameViewInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fa2fbcf
  2. 17 Mar, 2007 10 commits
    • hyatt's avatar
      Make onload do an explicit paint when a top-level document is ready... · 563ba091
      hyatt authored
              Make onload do an explicit paint when a top-level document is ready (to ensure that a first paint always
              happens before any timers set by the onload can fire).
      
              Reviewed by aroben
      
              * dom/Document.cpp:
              (WebCore::Document::implicitClose):
              * platform/ScrollView.h:
              * platform/mac/ScrollViewMac.mm:
              (WebCore::ScrollView::update):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      563ba091
    • hyatt's avatar
      Tweaks to prevent timers from starving user input or painting. · b26bd0ed
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b26bd0ed
    • ggaren's avatar
      Reviewed by Beth Dakin. · 6690f93b
      ggaren authored
              Fixed <rdar://problem/5070967> REGRESSION (r20211): Repro crash when 
              closing View Source window
              
              I award myself 0 points, and may God have mercy on my soul.
      
              * bindings/js/kjs_proxy.cpp:
              (WebCore::KJSProxy::~KJSProxy):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6690f93b
    • kjk's avatar
      Not reviewed - gdk build fix. · bb68af03
      kjk authored
              * platform/gdk/TemporaryLinkStubs.cpp:
              (Pasteboard::writeURL):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb68af03
    • hyatt's avatar
      Fix tiny PLT regression. Don't examine the border/background data for... · 0fd84c8d
      hyatt authored
              Fix tiny PLT regression.  Don't examine the border/background data for RenderImage when images change
              unless we actually have a border/background.
      
              Reviewed by Brady
      
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::imageChanged):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fd84c8d
    • sullivan's avatar
      Reviewed by Tim Hatcher · 999e46ff
      sullivan authored
              
              Discovered while working on <rdar://problem/5070334> that many WebView calls will crash if called
              after -[WebView close] has executed because _private->page is deferenced after it's been set to 0. 
              It might be silly/wrong to call these methods after -close, but obviously it shouldn't crash. Made
              each use of _private->page robust against nil-dereferencing.
      
              * WebView/WebView.mm:
              (-[WebView _loadBackForwardListFromOtherView:]):
              (-[WebView _updateWebCoreSettingsFromPreferences:]):
              (-[WebView _setDashboardBehavior:to:]):
              (-[WebView _dashboardBehavior:]):
              (-[WebView goBack]):
              (-[WebView goForward]):
              (-[WebView goToBackForwardItem:]):
              (-[WebView canGoBack]):
              (-[WebView canGoForward]):
              (-[WebView setTabKeyCyclesThroughElements:]):
              (-[WebView tabKeyCyclesThroughElements]):
              (-[WebView setEditable:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      999e46ff
    • zimmermann's avatar
      Reviewed by Sam Weinig. · 58a0542e
      zimmermann authored
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=13046 (CSS styles on hover and focus are broken for <use>)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=12838 (SVG <use> CSS styles broken)
      Added test: svg/custom/use-css-events.svg
      
      In general this fixes the peepo.co.uk website.
      
      Forgot to pass the actual StyleChange to the recalcStyle() function,
      when calling it on the shadow tree root element.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58a0542e
    • thatcher's avatar
      JavaScriptCore: · e8882bef
      thatcher authored
              Reviewed by Mark Rowe.
      
              Made Version.xcconfig smarter when building for different configurations.
              Now uses the 522+ OpenSource version for Debug and Release, while using the
              full 522.4 version for Production builds. The system prefix is also computed
              based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.
      
              * Configurations/JavaScriptCore.xcconfig:
              * Configurations/Version.xcconfig:
      
      JavaScriptGlue:
      
              Reviewed by Mark Rowe.
      
              Made Version.xcconfig smarter when building for different configurations.
              Now uses the 522+ OpenSource version for Debug and Release, while using the    
              full 522.4 version for Production builds. The system prefix is also computed
              based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.
      
              * Configurations/JavaScriptGlue.xcconfig:
              * Configurations/Version.xcconfig:
      
      WebCore:
      
              Reviewed by Mark Rowe.
      
              Made Version.xcconfig smarter when building for different configurations.
              Now uses the 522+ OpenSource version for Debug and Release, while using the
              full 522.4 version for Production builds. The system prefix is also computed
              based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.
      
              * Configurations/Version.xcconfig:
              * Configurations/WebCore.xcconfig:
      
      WebKit:
      
              Reviewed by Mark Rowe.
      
              Made Version.xcconfig smarter when building for different configurations.
              Now uses the 522+ OpenSource version for Debug and Release, while using the
              full 522.4 version for Production builds. The system prefix is also computed
              based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.
      
              * Configurations/Version.xcconfig:
              * Configurations/WebKit.xcconfig:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8882bef
    • antti's avatar
      LayoutTests: · 8a2eb6b0
      antti authored
              Reviewed by Adele.
              
              Test for http://bugs.webkit.org/show_bug.cgi?id=12595
              REGRESSION: Can't add item to cart at lnt.com (JS type error)
              <rdar://problem/4722863>
              
              Expanded version of Darin's test case. 
      
              * fast/forms/old-names-expected.txt: Added.
              * fast/forms/old-names.html: Added.
      
      WebCore:
      
              Reviewed by Adele.
      
              Fix http://bugs.webkit.org/show_bug.cgi?id=12595
              REGRESSION: Can't add item to cart at lnt.com (JS type error)
              <rdar://problem/4722863>
              
              Emulate Firefox behavior where form elements accessed by a name
              can be accessed with that name later even if the name changes or
              even if element is removed from the document.
              
              This is loosely based on Darin's earlier patch for the same problem but
              is much less expansive. It takes somewhat different approach to more closely
              mimic Firefox behavior. Includes expanded test case.
      
              * bindings/js/JSHTMLFormElementCustom.cpp:
              (WebCore::JSHTMLFormElement::canGetItemsForName):
                  Use new the HTMLFormElement::getNamedElements() method
              (WebCore::JSHTMLFormElement::nameGetter):
                  Use new the HTMLFormElement::getNamedElements() method
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::HTMLFormElement):
              (WebCore::HTMLFormElement::~HTMLFormElement):
              (WebCore::HTMLFormElement::elementForAlias):
              (WebCore::HTMLFormElement::addElementAlias):
                  Maintain a map of known element aliases
              (WebCore::HTMLFormElement::getNamedElements):
                  Get a list of elements matching the name, based both their
                  current names and known aliases (earlier names).
                  Keep the alias list in sync.
              * html/HTMLFormElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a2eb6b0
    • adele's avatar
      LayoutTests: · 31872c80
      adele authored
              Reviewed by Hyatt.
      
              Updated test for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox
              http://bugs.webkit.org/show_bug.cgi?id=12725
      
              * fast/forms/listbox-onchange-expected.txt:
              * fast/forms/listbox-onchange.html:
      
      WebCore:
      
              Reviewed by Hyatt.
      
              Fix for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox
              http://bugs.webkit.org/show_bug.cgi?id=12725
      
              Test: updated fast/forms/listbox-onchange.html
      
              Added HTMLSelectElement::saveLastSelection that is called before changing a selection that could result
              in onChange being called.  m_lastOnChangeIndex and m_lastOnChangeSelection no longer have to be up-to date all the time, 
              they just have to be up-to-date before we execute an action that may trigger onChange.
      
              * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelectedState): Added.
                The HTMLSelectElement will only set an option's selected state with this method.  This ensures
                that notifyOptionSelected won't get called when the call originates from the select element.
              * html/HTMLOptionElement.h:
      
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::deselectItems): Calls setSelectedState.
              (WebCore::HTMLSelectElement::setSelectedIndex): ditto. Don't update the last selection variables here.  Scroll to the new selection.
               The scrolling call used to only be in notifyOptionSelected.  There's no reason we shouldn't scroll when the selection is set through
               the HTMLSelectElement.
              (WebCore::HTMLSelectElement::setValue): Call setSelectedIndex to update all options selected state.
              (WebCore::HTMLSelectElement::restoreState): Call setSelectedState.
              (WebCore::HTMLSelectElement::selectAll): Call saveLastSelection before making the selection, and calling onChange.
              (WebCore::HTMLSelectElement::recalcListItems): Call setSelectedState.  Don't need to save selection here anymore, 
               since it will get saved before we call onChange.
              (WebCore::HTMLSelectElement::reset): ditto.
              (WebCore::HTMLSelectElement::dispatchFocusEvent): Added. Call saveLastSelection for menu lists, since onChange can be fired
               on blur.
              (WebCore::HTMLSelectElement::dispatchBlurEvent): Call menuListOnChange.
              (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Call saveLastSelection before showing the popup window.
              (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):  Call saveLastSelection during mousedown (to prepare for an 
               onchange during mouseup, or after autoscroll).
              (WebCore::HTMLSelectElement::updateListBoxSelection): Call setSelectedState.
      
              (WebCore::HTMLSelectElement::menuListOnChange): Added. Compares the m_lastOnChangeIndex to the selectedIndex().
              (WebCore::HTMLSelectElement::listBoxOnChange): Move the m_lastOnChangeSelection creation to saveLastSelection.
              (WebCore::HTMLSelectElement::saveLastSelection): Added. Sets m_lastOnChangeIndex or m_lastOnChangeSelection.
              * html/HTMLSelectElement.h:
              * platform/PopupMenu.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31872c80
  3. 16 Mar, 2007 17 commits
  4. 15 Mar, 2007 12 commits
    • beidson's avatar
      Reviewed by Oliver · 8695b238
      beidson authored
              A few platform specific tweaks
      
              * platform/cf/RetainPtr.h:
              (WebCore::RetainPtr::releaseRef): Fixed releaseRef to work with CF
              
              * platform/network/ResourceHandle.h: Added a "releaseRef" style call
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8695b238
    • mjs's avatar
      Not reviewed. · 01cbe0c4
      mjs authored
              
              - build fix
      
              * wtf/TCSystemAlloc.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01cbe0c4
    • mjs's avatar
      JavaScriptCore: · dc3fe3ae
      mjs authored
              Reviewed by Geoff and Steve.
              
              - fix some portability issues with TCMalloc.
      
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * kjs/config.h:
              * wtf/FastMalloc.cpp:
              (WTF::SizeClass):
              (WTF::InitSizeClasses):
              (WTF::TCMalloc_PageHeap::Split):
              (WTF::TCMalloc_PageHeap::RegisterSizeClass):
              (WTF::TCMalloc_Central_FreeList::length):
              (WTF::TCMalloc_ThreadCache::InitTSD):
              (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
              * wtf/TCSpinLock.h:
              * wtf/TCSystemAlloc.cpp:
              (TryVirtualAlloc):
              (TCMalloc_SystemAlloc):
      
      WebCore:
      
              Reviewed by Geoff and Steve.
      
              * config.h: Remove unneeded hack.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc3fe3ae
    • justing's avatar
      LayoutTests: · 0def9d84
      justing authored
              Reviewed by john
              
              <rdar://problem/5062376> 
              REGRESSION: In Mail and Gmail, can't change alignment to text after it has been applied
      
              * editing/execCommand/5062376-expected.checksum: Added.
              * editing/execCommand/5062376-expected.png: Added.
              * editing/execCommand/5062376-expected.txt: Added.
              * editing/execCommand/5062376.html: Added.
      
      WebCore:
      
              Reviewed by john
              
              <rdar://problem/5062376> 
              REGRESSION: In Mail and Gmail, can't change alignment to text after it has been applied
              
              Bring back the remove step in applyBlockStyle.  It's 
              necessary because addBlockStyleIfNeeded assumes that 
              the properties it adds aren't already on the block that 
              it adds them to.
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle): 
              Bring back the remove step (added a testcase).
              Don't do the add step if m_removeOnly is true (no testcase
              because there aren't any clients using removeOnly functionality
              to remove styles yet, only styled elemets).
              Moved the code for creating new blocks up one level
              to this function so that we can pass blocks to removeCSSStyle.
              When converting VisiblePositions to indices and vice versa,
              use the highest node in the shadow tree if we're in one as
              the scope (working on a testcase).
              (WebCore::ApplyStyleCommand::addBlockStyle): Moved code to
              applyBlockStyle.
              * editing/ApplyStyleCommand.h: 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0def9d84
    • beidson's avatar
      LayoutTests: · d82d99fe
      beidson authored
              Reviewed by Adele
      
              <rdar://problem/4429701>
              Implements a port blocking black list that matches Firefox's
      
              The layout test attempts to load an image at an invalid domain name on each
              of the black listed ports.  Using dumpResourceLoadCallbacks(), DRT is able
              to see the error codes for each resource.  A successful test shows the blocked
              error for each image load except for the few that are standard or should 
              succeed due to exemptions.
      
              * security/block-test-expected.txt: Added.
              * security/block-test.html: Added.
      
      WebCore:
      
              Reviewed by Maciej
      
              <rdar://problem/4429701>
              Implements a port blocking black list that matches Firefox's
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::blockedError): Call through to the client for blockedError 
              * loader/FrameLoader.h:
      
              * loader/FrameLoaderClient.h: Get the "port blocked" error for the current platform
      
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::wasBlocked): ResourceHandleClient method to pass on the didFail(error)
              (WebCore::ResourceLoader::blockedError): Following the pattern of "CancelledError()", get the 
                error to fail with for the didFail() call
              * loader/ResourceLoader.h:
      
              * platform/graphics/svg/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyFrameLoaderClient::blockedError): Added stub
      
              * platform/network/ResourceHandle.cpp:
              (WebCore::ResourceHandle::create): If the port is blocked, create the handle but schedule it for
                deferred failure on a timer
              (WebCore::ResourceHandle::scheduleBlockedFailure): Do the timer scheduling
              (WebCore::ResourceHandle::fireBlockedFailure): Fire the timer here
              (WebCore::ResourceHandle::portAllowed): Implements checking of Mozilla's
              * platform/network/ResourceHandle.h:
              * platform/network/ResourceHandleClient.h:
              (WebCore::ResourceHandleClient::wasBlocked): Virtual for clients to get the "blocked" message
      
      WebKit:
      
              Reviewed by Maciej
      
              <rdar://problem/4429701>
              Implements a port blocking black list that matches Firefox's
      
              * English.lproj/Localizable.strings: Added localizable string for port blocked error code
      
              * Misc/WebKitErrors.h:
              * Misc/WebKitErrors.m:
              (registerErrors): Add new port blocked error code to WebKitErrorDomain
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::cancelledError): Fixed coding style
              (WebFrameLoaderClient::blockedError): Return a ResourceError with the new custom error code
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d82d99fe
    • thatcher's avatar
      Yet another build fix. · bf6a206a
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf6a206a
    • thatcher's avatar
      Finally a real build fix. · b2fdc30b
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2fdc30b
    • thatcher's avatar
      Yet another build fix. Sigh. · c062a608
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c062a608
    • thatcher's avatar
      Another build fix attempt. · 1582e732
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1582e732
    • thatcher's avatar
      Attempt to fix the build. · 5fc4a4ed
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fc4a4ed
    • thatcher's avatar
      Build fix. · 9b31b4fe
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b31b4fe
    • bdakin's avatar
      Reviewed by Hyatt. · d7b88aec
      bdakin authored
              Fix for <rdar://problem/5065396> REGRESSION: leaks in 
              RenderBlock::layoutInlineChildren seen on buildbot
      
              This leak appeared after http://trac.webkit.org/projects/webkit/
              changeset/20188. This change shifted line boxes around in 
              removeChild(). But since removeChild() calls 
              setNeedsLayoutAndMinMaxRecalc(), all of the line boxes will be 
              removed once we actually lay out anyway. So this patch fixes the 
              leak by deleting the line boxes instead of shifting them around. 
      
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::outdentParagraph): Call into 
              updateLayout(). This fixes an assertion I got in editing/
              execCommand/4976800.html This is very similar to the line box fix I 
              made recently (http://trac.webkit.org/projects/webkit/changeset/
              20177). We need to update layout before relying on VisiblePositions 
              after removing a node.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::deleteLinesForBlock): New helper function 
              since this functionality is needed in three places now.
              (WebCore::RenderBlock::makeChildrenNonInline): Call into new 
              deleteLinesForBlock().
              (WebCore::RenderBlock::removeChild): Same.
              * rendering/RenderBlock.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7b88aec