1. 01 Oct, 2013 1 commit
    • graouts@apple.com's avatar
      Console buttons don’t show after page reload · 0f949982
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116515
      
      Reviewed by Darin Adler.
      
      The correct display of navigation items in the ContentBrowser is contingent on
      the ContentViewContainer's _backForwardList being up-to-date when the navigation
      items are retrieved from it. However, when the main resource changes (in this case
      the user refreshes the browser), calls are made to ContentViewContainer's
      closeAllContentViewsOfPrototype() which may modify the _backForwardList but doesn't
      necessarily notify of a change to the currentContentView since we may be still showing
      the same view in case it wasn't directly related to the main resource, for instance
      the console log.
      
      We now check if the _backForwardList is changed as a result of calling
      closeAllContentViewsOfPrototype() and in that case also dispatch the
      CurrentContentViewDidChange event which will restore the correct state
      for the back/forward buttons and navigation items of the navigation bar.
      
      * UserInterface/ContentViewContainer.js:
      (WebInspector.ContentViewContainer.prototype.closeAllContentViewsOfPrototype):
      Track changes to the _backForwardList and dispatch the CurrentContentViewDidChange
      event in case such changes happened.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f949982
  2. 30 Sep, 2013 3 commits
    • graouts@apple.com's avatar
      Web Inspector: rows in the Layer sidebar panel may have the incorrect background color · c24920f7
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122108
      
      Reviewed by Darin Adler.
      
      The LayerTreeDataGrid is a custom DataGrid subclass which exposes a .setChildren() method
      used to sort chidren without DOM order manipulation, for performance reason. However, since
      the way the alternating background color is usually implemented is based on the built-in
      CSS pseudo-classes working with DOM order, the background colors of nodes in the LayerTreeDataGrid
      can be incorrect depending on the sort order and the number of nodes. To fix this, we now manually
      set "even" and "odd" CSS classes on those nodes when they're sorted such that we have a chance
      to style them as intended.
      
      * UserInterface/LayerTreeDataGrid.js:
      (WebInspector.LayerTreeDataGrid.prototype._updateChildren):
      Check if the data grid node index is even or odd and reflect this via an exclusive "even"
      or "odd" CSS class name.
      
      * UserInterface/LayerTreeSidebarPanel.css:
      (.layer-tree.panel .data-container tbody > tr.even):
      (.layer-tree.panel .data-container tbody > tr.odd):
      Apply alternating colors based on the exclusive "even" and "odd" CSS class names as applied in
      WebInspector.LayerTreeDataGrid.prototype._updateChildren().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c24920f7
    • graouts@apple.com's avatar
      Web Inspector: Popover displaying "reasons for compositing" may remain on... · f39127ff
      graouts@apple.com authored
      Web Inspector: Popover displaying "reasons for compositing" may remain on screen after selected layer is removed
      https://bugs.webkit.org/show_bug.cgi?id=117575
      
      Ensure the popover attached to the selected data grid node is updated when the
      content or sort order of the Layer sidebar panel is updated.
      
      Reviewed by Darin Adler.
      
      * UserInterface/LayerTreeSidebarPanel.js:
      (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f39127ff
    • graouts@apple.com's avatar
      Web Inspector: nodes can be dragged from the console log · 9b15e9df
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122105
      
      Reviewed by Darin Adler.
      
      Catch "dragstart" events targeting nodes hosted in a DOMTreeOutline within the console
      log view and prevent the default logic to trigger so that these nodes can't be dragged
      off the console as it wouldn't make sense to.
      
      * UserInterface/DOMTreeOutline.js:
      (WebInspector.DOMTreeOutline):
      Create a class property to allow the CSS class name to be used in WebInspector.LogContentView.
      
      * UserInterface/LogContentView.js:
      (WebInspector.LogContentView):
      (WebInspector.LogContentView.prototype._ondragstart):
      Track the "dragstart" events in their capture phase such that, if the event target is
      a DOM node hosted in a DOMTreeOutline, we can prevent the event from propagating and
      cancel its default behavior such that no dragging at all is performed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b15e9df
  3. 26 Sep, 2013 3 commits
  4. 24 Sep, 2013 4 commits
  5. 23 Sep, 2013 1 commit
    • timothy@apple.com's avatar
      Hook up the initiator info and show it in the Resource details sidebar. · 66f4abb7
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121741
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/FrameResourceManager.js:
      (WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
      (WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
      (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
      (WebInspector.FrameResourceManager.prototype._initiatorSourceCodeLocationFromPayload):
      * UserInterface/NetworkObserver.js:
      (WebInspector.NetworkObserver.prototype.requestWillBeSent):
      (WebInspector.NetworkObserver.prototype.requestServedFromMemoryCache):
      * UserInterface/Resource.js:
      (WebInspector.Resource):
      (WebInspector.Resource.prototype.get initiatorSourceCodeLocation):
      * UserInterface/ResourceDetailsSidebarPanel.js:
      (WebInspector.ResourceDetailsSidebarPanel):
      (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshURL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66f4abb7
  6. 20 Sep, 2013 3 commits
    • timothy@apple.com's avatar
      Parse MIME-types and strip them down to the base type when needed. · bf725158
      timothy@apple.com authored
      The use of charset in a MIME-type interferes with our type maps,
      preventing the right syntax highlighting mode and pretty printing.
      
      https://bugs.webkit.org/show_bug.cgi?id=121723
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/ConsolePrompt.js:
      (WebInspector.ConsolePrompt):
      * UserInterface/FontResourceContentView.js:
      * UserInterface/Resource.js:
      (WebInspector.Resource.Type.fromMIMEType):
      (WebInspector.Resource.prototype.get mimeTypeComponents):
      (WebInspector.Resource.prototype.get syntheticMIMEType):
      (WebInspector.Resource.prototype.get contentURL):
      (WebInspector.Resource.prototype.updateForResponse):
      * UserInterface/ResourceDetailsSidebarPanel.js:
      (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):
      * UserInterface/SourceMapResource.js:
      (WebInspector.SourceMapResource.prototype.requestContentFromBackend):
      * UserInterface/SyntaxHighlightingSupport.js:
      (WebInspector.syntaxHighlightStringAsDocumentFragment):
      * UserInterface/TextEditor.js:
      (WebInspector.TextEditor.prototype.set mimeType):
      * UserInterface/Utilities.js:
      (parseMIMEType): Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf725158
    • timothy@apple.com's avatar
      Web Inspector: Fix keyboard shortcuts for other platforms · 79bfe8ab
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120657
      
      Patch by Marcelo Morais <m.morais@samsung.com> on 2013-09-20
      Reviewed by Timothy Hatcher.
      
      Handling keyboard shortcuts according to the current platform.
      
      * UserInterface/InspectorFrontendHostStub.js:
      (.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
      (.WebInspector.InspectorFrontendHostStub.prototype.platform): Added. Return the
      current platform.
      * UserInterface/KeyboardShortcut.js:
      (WebInspector.KeyboardShortcut.Modifier.get CommandOrControl): Added. Created keyboard
      modifier to return Control or Command key according to current platform.
      * UserInterface/ContentBrowser.js:
      (WebInspector.ContentBrowser): Returning Control or Command key for keyboard
      shortcuts according to current platform.
      * UserInterface/DebuggerSidebarPanel.js:
      (WebInspector.DebuggerSidebarPanel): Ditto.
      * UserInterface/FindBanner.js:
      (WebInspector.FindBanner): Ditto.
      * UserInterface/JavaScriptLogViewController.js:
      (WebInspector.JavaScriptLogViewController): Ditto.
      * UserInterface/LogContentView.js:
      (WebInspector.LogContentView): Ditto.
      * UserInterface/Main.js:
      (WebInspector.contentLoaded): Ditto.
      * UserInterface/ResourceSidebarPanel.js:
      (WebInspector.ResourceSidebarPanel): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79bfe8ab
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed gardening. Teach WebInspectorUI.vcxproj folder to · b9fcb6d0
      bfulgham@apple.com authored
      ignore Visual Studio's local user settings file.
      
      * WebInspectorUI.vcxproj: Added property svn:ignore.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9fcb6d0
  7. 18 Sep, 2013 1 commit
  8. 17 Sep, 2013 1 commit
  9. 16 Sep, 2013 3 commits
  10. 13 Sep, 2013 1 commit
    • kov@webkit.org's avatar
      [GTK] Move to the new web inspector · 86b826a5
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120647
      
      Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-09-13
      Reviewed by Carlos Garcia Campos.
      
      .:
      
      * GNUmakefile.am: include the new WebInspectorUI GNUmakefile.am.
      
      Source/WebCore:
      
      No tests for the new inspector UI as of yet.
      
      * GNUmakefile.am: no longer install the deprecated inspector UI files.
      * WebCore.exp.in: add SchemeRegistry symbol that is now used.
      
      Source/WebInspectorUI:
      
      * GNUmakefile.am: Added. Generate the GResource source and link it into libWebCore.
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/InspectorClientGtk.cpp:
      (WebKit::InspectorClient::openInspectorFrontend): update paths to the internal resource ones.
      (WebKit::InspectorClient::inspectorFilesPath): ditto.
      * tests/testwebinspector.c:
      (consoleMessageCallback): the new inspector currently emits an error when loading, so add it to
      the list of messages which are not considered failures.
      * webkit/webkitglobals.cpp:
      (webkitInit): register resource as a local scheme; currently used by the inspector.
      
      Source/WebKit2:
      
      * GNUmakefile.am: bundle the remote inspector page list HTML into libwebkit2gtk as a GResource.
      * UIProcess/API/gtk/tests/GNUmakefile.am: no need to set WEBKIT_INSPECTOR_PATH anymore.
      * UIProcess/API/gtk/tests/InspectorTestServer.cpp:
      (main): ditto.
      * UIProcess/API/gtk/tests/TestInspector.cpp:
      (beforeAll): ditto.
      * UIProcess/API/gtk/tests/TestInspectorServer.cpp:
      (testInspectorServerPageList): update paths to the internal resource ones.
      * UIProcess/InspectorServer/WebInspectorServer.h:
      * UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
      (WebKit::WebInspectorServer::platformResourceForPath): ditto.
      (WebKit::WebInspectorServer::buildPageList): ditto.
      * UIProcess/WebInspectorProxy.cpp:
      (WebKit::isMainInspectorPage): factor out checking for the inspector main resource, to make
      the code more readable.
      (WebKit::decidePolicyForNavigationAction): use SchemeRegistry to figure out whether the
      request is for a local resource instead of KURL::isLocalFile() to allow using schemes
      other than file:// for the inspector resources.
      * UIProcess/gtk/WebInspectorProxyGtk.cpp:
      (WebKit::WebInspectorProxy::inspectorPageURL): use the new internal resource URL; since it's now
      static we no longer need to generate and store the string.
      (WebKit::WebInspectorProxy::inspectorBaseURL): ditto.
      * WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
      (WebKit::WebInspector::localizedStringsURL): use the new internal resource URL.
      * UIProcess/gtk/WebContextGtk.cpp:
      (WebKit::WebContext::platformInitializeWebProcess): register resource as a local scheme.
      
      Tools:
      
      * GtkLauncher/main.c:
      (main): no longer set WEBKIT_INSPECTOR_PATH.
      * MiniBrowser/gtk/main.c:
      (main): ditto.
      * Scripts/old-run-webkit-tests:
      (openDumpTool): ditto.
      * Scripts/run-gtk-tests: ditto.
      * Scripts/webkitpy/port/gtk.py:
      (GtkPort.setup_environ_for_server): ditto.
      
      LayoutTests:
      
      * platform/gtk/TestExpectations: the new inspector UI does not support the current
      inspector testing harness so keep it skipped, a new one will eventually be landed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86b826a5
  11. 12 Sep, 2013 3 commits
  12. 11 Sep, 2013 1 commit
    • ggaren@apple.com's avatar
      Removed some unused functions from the debugger interface · 1f96f80f
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121194
      
      Reviewed by Joseph Pecoraro.
      
      We plan to use the "evaluate" API and debugger activation property access for all the features we need.
      
      Source/WebCore: 
      
      * inspector/JavaScriptCallFrame.idl: These are the interfaces I removed.
      
      * bindings/js/JSJavaScriptCallFrameCustom.cpp:
      * inspector/InjectedScript.cpp:
      * inspector/InjectedScript.h:
      * inspector/InjectedScriptSource.js:
      * inspector/Inspector.json:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::setScriptSource):
      * inspector/InspectorDebuggerAgent.h:
      * inspector/JavaScriptCallFrame.idl:
      * inspector/front-end/RemoteObject.js:
      (WebInspector.RemoteObject.prototype.):
      (WebInspector.RemoteObject.prototype.setPropertyValue): These files are mechanical removals of code that used
      or implemented the interfaces I removed.
      
      Source/WebInspectorUI: 
      
      * UserInterface/InspectorBackendCommands.js: Updated by script.
      
      LayoutTests: 
      
      * inspector/debugger/debugger-change-variable-expected.txt: Removed.
      * inspector/debugger/debugger-change-variable.html: Removed. This test was failing
      because we don't support this API.
      
      * platform/mac/inspector/console/command-line-api-expected.txt: This test changed line numbers
      because I changed inspector .js files.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f96f80f
  13. 07 Sep, 2013 1 commit
  14. 06 Sep, 2013 1 commit
  15. 05 Sep, 2013 5 commits
    • commit-queue@webkit.org's avatar
      Web Inspector: Breakpoint Action JS Editor has line wrapping issues with long no-space lines · 04560146
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120822
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-09-05
      Reviewed by Timothy Hatcher.
      
      * UserInterface/BreakpointActionView.css:
      (.breakpoint-action-eval-editor > .CodeMirror):
      (.breakpoint-action-eval-editor > .CodeMirror-scroll):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04560146
    • commit-queue@webkit.org's avatar
      Web Inspector: Edit Breakpoint popover sometimes appears misplaced in top left · 070bbf8e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120804
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-09-05
      Reviewed by Timothy Hatcher.
      
      Grab the bounding rect immediately, instead of grabbing it from the element
      after the user has selected the "Edit Breakpoint" context menu item. When
      the popover was misplaced it was when using an element had been removed or
      replaced in the DOM, and caused a bogus bounding client rect.
      
      * UserInterface/Breakpoint.js:
      (WebInspector.Breakpoint.prototype.editBreakpoint):
      (WebInspector.Breakpoint.prototype._showEditBreakpointPopover):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      070bbf8e
    • commit-queue@webkit.org's avatar
      Web Inspector: Remove harmless assert, triggered hitting breakpoint in auto... · fe6f5965
      commit-queue@webkit.org authored
      Web Inspector: Remove harmless assert, triggered hitting breakpoint in auto prettyprinted code on reload
      https://bugs.webkit.org/show_bug.cgi?id=120332
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-09-05
      Reviewed by Timothy Hatcher.
      
      * UserInterface/TextEditor.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe6f5965
    • joepeck@webkit.org's avatar
      Web Inspector: Breakpoint Actions · 572a17e2
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120576
      
      Reviewed by Timothy Hatcher.
      
      Give the CodeMirror editor for JavaScript Breakpoint Actions JS Runtime
      completions (like window, document, etc.).
      
      The logic was inside of JavaScriptLogViewController but was already
      entirely independent. Factor it out into its own class and plug it into
      CodeMirrorCompletionController as a "CompletionsProvider".
      
      Because the class hooks into a global event to reset some state, make
      it a singleton, so new instances are not leaked.
      
      * UserInterface/Main.html:
      * UserInterface/Main.js:
      (WebInspector.loaded):
      * UserInterface/RuntimeManager.js: Added.
      (WebInspector.RuntimeManager):
      (WebInspector.RuntimeManager.prototype.evalCallback):
      (WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
      Move eval in window to new RuntimeManager. A slightly cleaner place to this
      since it is used both by the console and JS completions provider.
      
      * UserInterface/CodeMirrorCompletionController.js:
      (WebInspector.CodeMirrorCompletionController):
      (WebInspector.CodeMirrorCompletionController.prototype.setExtendedCompletionProvider):
      (WebInspector.CodeMirrorCompletionController.prototype._completeAtCurrentPosition):
      Allow a completions provider plugin to completions controller. If one
      is available, this supercedes the delegate extend completions path.
      
      * UserInterface/BreakpointActionView.js:
      * UserInterface/ConsolePrompt.js:
      (WebInspector.ConsolePrompt):
      Use the new JS completions provider to get runtime JS completions.
      NOTE: ConsolePrompt still needs the delegate path for SQL completions.
      
      * UserInterface/JavaScriptLogViewController.js:
      (WebInspector.JavaScriptLogViewController):
      (WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
      * UserInterface/JavaScriptRuntimeCompletionProvider.js: Added.
      (WebInspector.JavaScriptRuntimeCompletionProvider):
      (get WebInspector.JavaScriptRuntimeCompletionProvider.prototype.):
      (get WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded):
      Move the JS completions code to a new class. No changes needed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      572a17e2
    • joepeck@webkit.org's avatar
      Web Inspector: Breakpoint Actions · 8dbc7b8e
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120576
      
      Reviewed by Timothy Hatcher.
      
      * UserInterface/Breakpoint.js:
      (WebInspector.Breakpoint):
      (WebInspector.Breakpoint.prototype.get actions):
      (WebInspector.Breakpoint.prototype.get options):
      (WebInspector.Breakpoint.prototype.get info):
      (WebInspector.Breakpoint.prototype._serializableActions):
      Saving, restoring, and serialization.
      
      (WebInspector.Breakpoint.prototype.createAction):
      (WebInspector.Breakpoint.prototype.recreateAction):
      (WebInspector.Breakpoint.prototype.removeAction):
      (WebInspector.Breakpoint.prototype.breakpointActionDidChange):
      Modifying _actions ivar.
      
      (WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
      (WebInspector.Breakpoint.prototype._popoverActionsCreateAddActionButton):
      (WebInspector.Breakpoint.prototype._popoverActionsAddActionButtonClicked):
      (WebInspector.Breakpoint.prototype._popoverActionsInsertBreakpointActionView):
      (WebInspector.Breakpoint.prototype.breakpointActionViewAppendActionView):
      (WebInspector.Breakpoint.prototype.breakpointActionViewRemoveActionView):
      (WebInspector.Breakpoint.prototype.breakpointActionViewResized):
      Popover UI containing breakpoint action views and converting to and from
      having no actions.
      
      (WebInspector.Breakpoint.prototype.willDismissPopover):
      Cleanup some ivars when the popover dismisses.
      
      * UserInterface/Breakpoint.css:
      (.popover .edit-breakpoint-popover-content.wide):
      Wider setting when there are actions in the popover.
      
      (.popover .edit-breakpoint-popover-content > table > tr > th):
      Keep the title labels at the top of their section.
      
      * UserInterface/BreakpointAction.js:
      (WebInspector.BreakpointAction):
      (WebInspector.BreakpointAction.prototype.get breakpoint):
      (WebInspector.BreakpointAction.prototype.get type):
      (WebInspector.BreakpointAction.prototype.get data):
      (WebInspector.BreakpointAction.prototype.set data):
      (WebInspector.BreakpointAction.prototype.get info):
      Very basic BreakpointAction class. Notifies Breakpoint on data changes.
      Type changes are not allowed, instead just create a new BreakpointAction.
      
      * UserInterface/BreakpointActionView.css: Added.
      (.breakpoint-action-block-header):
      (.breakpoint-action-remove-button):
      (.breakpoint-action-remove-button:active):
      (.breakpoint-action-append-button):
      (.breakpoint-action-block-body):
      (.breakpoint-action-block-body > input):
      (.breakpoint-action-eval-editor):
      (.breakpoint-action-eval-editor > .CodeMirror):
      (.breakpoint-action-eval-editor > .CodeMirror-scroll):
      * UserInterface/BreakpointActionView.js: Added.
      (WebInspector.BreakpointActionView):
      (WebInspector.BreakpointActionView.displayStringForType):
      (WebInspector.BreakpointActionView.prototype.get action):
      (WebInspector.BreakpointActionView.prototype.get element):
      (WebInspector.BreakpointActionView.prototype._pickerChanged):
      (WebInspector.BreakpointActionView.prototype._appendActionButtonClicked):
      (WebInspector.BreakpointActionView.prototype._removeActionButtonClicked):
      (WebInspector.BreakpointActionView.prototype._updateBody.switch.break):
      (WebInspector.BreakpointActionView.prototype._logInputChanged):
      (WebInspector.BreakpointActionView.prototype._codeMirrorBlurred):
      (WebInspector.BreakpointActionView.prototype._codeMirrorViewportChanged):
      UI and form controls for individual breakpoint actions. The view
      wraps a single BreakpointAction, and for any actions that could affect
      other views the delegate is notified.
      
      * UserInterface/DebuggerManager.js:
      (WebInspector.DebuggerManager):
      (WebInspector.DebuggerManager.prototype._debuggerBreakpointActionType):
      When sending to the backend, make sure to send protocol enums.
      
      * UserInterface/Popover.js:
      (WebInspector.Popover.prototype.update):
      Update the popover when content changes.
      
      * UserInterface/Images/BreakpointActionAdd.svg: Added.
      * UserInterface/Images/BreakpointActionRemove.svg: Added.
      * UserInterface/InspectorBackendCommands.js:
      * UserInterface/Main.html:
      * Localizations/en.lproj/localizedStrings.js:
      Misc. New strings, images, includes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dbc7b8e
  16. 03 Sep, 2013 1 commit
    • graouts@apple.com's avatar
      Web Inspector: exceptions triggered from console evaluation do not pause the debugger · f779c401
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120460
      
      Source/WebCore:
      
      Reviewed by Timothy Hatcher.
      
      * inspector/InjectedScriptSource.js:
      Explicitly set a sourceURL such that the frontend may identify injected script when
      processing call frames in order to hide such code from the debugger.
      
      Source/WebInspectorUI:
      
      We used to preclude any debugging from errors stemming from code evaluated in the console
      as we would always set the doNotPauseOnExceptionsAndMuteConsole parameter to "false" when
      calling JavaScriptLogViewController._evaluateInInspectedWindow(). However, it is desirable
      to allow debugging code ran from the console.
      
      We now allow debugging in such a scenario and we filter out call frames coming from the
      Web Inspector injected script as well as the call frame for the console prompt such that
      we only pause in the debugger in case the exception is in code under the console prompt
      and not the console code prompt itself.
      
      Additionally, to prevent stepping out to call frames we may have filtered out, we disable
      the "step out" button in cases where there are no further frames in the frontend to go out to.
      
      Reviewed by Timothy Hatcher.
      
      * UserInterface/DebuggerManager.js:
      (WebInspector.DebuggerManager.prototype.debuggerDidPause):
      Filter out call frames that have a URL coming from Web Inspector injected script by looking
      for a URL starting with the "__WebInspector" prefix. If we determine that there are no call
      frames left after filtering, we resume code evaluation such that we only pause in the debugger
      when the exception is in code evluated under the console prompt.
      
      * UserInterface/DebuggerSidebarPanel.js:
      (WebInspector.DebuggerSidebarPanel):
      (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
      (WebInspector.DebuggerSidebarPanel.prototype._debuggerActiveCallFrameDidChange):
      Monitor any change to the active call frame such that we may tie the state of the
      "step out" button to the availability of a call frame to step out to in the filtered
      list set on the DebuggerManager.
      
      * UserInterface/JavaScriptLogViewController.js:
      (WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
      Set the doNotPauseOnExceptionsAndMuteConsole to "false" when calling _evaluateInInspectedWindow()
      in order to allow pausing on exceptions coming from code evalued in the console. Also, explicitly
      set a sourceURL for the script to evaluate such that we may identify its origin when filtering
      call frames stemming from inspector code.
      
      * UserInterface/ResourceSidebarPanel.js:
      (WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
      Filter out any script resource starting with the Web Inspector-specific "__WebInspector" prefix
      so that injected script does not show up.
      
      LayoutTests:
      
      Reviewed by Timothy Hatcher.
      
      * platform/mac/inspector/console/command-line-api-expected.txt:
      Take into account the addition of a sourceURL to inspector/InjectedScriptSource.js.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f779c401
  17. 30 Aug, 2013 6 commits
    • bfulgham@apple.com's avatar
      Source/WebInspectorUI: [Windows] Correct windows build. Get rid of unnecessary... · 455b8805
      bfulgham@apple.com authored
      Source/WebInspectorUI: [Windows] Correct windows build. Get rid of unnecessary pre-build step. We don't build anything
      in this project, just copy some files into the WebKit resource folder. This was fooling the
      build system into thinking something failed, resulting in a build error.
      
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Remove reference to WebInspectorUIPreBuild.cmd
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
      * WebInspectorUI.vcxproj/WebInspectorUIPreBuild.cmd: Removed.
      
      Source/WebKit: [Windows] Unreviewed build correction.
      Update project dependencies so that build logs on machines will include output from the
      WebInspectorUI project.
      
      * WebKit.vcxproj/WebKit.sln:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      455b8805
    • bfulgham@apple.com's avatar
      Source/WebInspectorUI: [Windows] Build correction after dependency change. · eeb0caa8
      bfulgham@apple.com authored
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Remove circular dependency on
      WebKit, and control this at the solution level. The prior change broke external
      builders.
      
      Source/WebKit: [Windows] Unreviewed build fix after r154917
      
      * WebKit.vcxproj/WebKit.sln: Establish build dependency from WebInspectorUI against
      WebKit. Remove reverse dependency.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eeb0caa8
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed build gardening. · e3b2e5ae
      bfulgham@apple.com authored
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Adjust build dependencies so
      that WebInspectorUI 'builds' after WebKit so that the expected resource directory
      structure is always in place.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3b2e5ae
    • joepeck@webkit.org's avatar
      Web Inspector: Breakpoints should have Automatically Continue Option · d8be1361
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120187
      
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      Tests: inspector-protocol/debugger/removeBreakpoint.html
             inspector-protocol/debugger/setBreakpoint-autoContinue.html
             inspector-protocol/debugger/setBreakpoint-column.html
             inspector-protocol/debugger/setBreakpoint-condition.html
             inspector-protocol/debugger/setBreakpoint.html
      
      * inspector/Inspector.json:
      Convert the "condition" argument of setBreakpoint and setBreakpointByUrl
      to a BreakpointOptions object with optional properties. One of which
      is "condition" and a new option "autoContinue".
      
      * bindings/js/ScriptDebugServer.h:
      * bindings/js/ScriptDebugServer.cpp:
      (WebCore::ScriptDebugServer::hasBreakpoint):
      (WebCore::ScriptDebugServer::pauseIfNeeded):
      Automatically continue if the breakpoint was hit and has autoContinue.
      
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::buildObjectForBreakpointCookie):
      (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
      (WebCore::InspectorDebuggerAgent::setBreakpoint):
      (WebCore::InspectorDebuggerAgent::continueToLocation):
      (WebCore::InspectorDebuggerAgent::didParseSource):
      * inspector/ScriptBreakpoint.h:
      (WebCore::ScriptBreakpoint::ScriptBreakpoint):
      Handle the new incoming BreakpointOptions type, and set the
      autoContinue state on ScriptBreakpoints.
      
      * inspector/front-end/DebuggerModel.js:
      (WebInspector.DebuggerModel.prototype.setBreakpointByURL):
      (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
      Update old front-end to be compatible with the new API.
      
      Source/WebInspectorUI:
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/Breakpoint.css:
      (#edit-breakpoint-popoover-auto-continue):
      Misc. changes for UI.
      
      * UserInterface/Breakpoint.js:
      (WebInspector.Breakpoint):
      (WebInspector.Breakpoint.prototype.get autoContinue):
      (WebInspector.Breakpoint.prototype.set autoContinue):
      (WebInspector.Breakpoint.prototype.get options):
      (WebInspector.Breakpoint.prototype.get info):
      General maintenance of the autoContinue state.
      
      (WebInspector.Breakpoint.prototype._popoverToggleEnabledCheckboxChanged):
      (WebInspector.Breakpoint.prototype._popoverToggleAutoContinueCheckboxChanged):
      (WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
      Edit Breakpoint UI for setting autoContinue state.
      
      * UserInterface/InspectorBackend.js:
      (InspectorBackendClass.prototype.registerCommand):
      (InspectorBackendClass.prototype._supports):
      Extension to check if a BackendCommands method supports a particular param.
      
      * UserInterface/DebuggerManager.js:
      (WebInspector.DebuggerManager):
      (WebInspector.DebuggerManager.prototype._setBreakpoint):
      * UserInterface/InspectorBackendCommands.js:
      Change to backend agent calls for the new protocol API.
      
      LayoutTests:
      
      * http/tests/inspector-protocol/resources/InspectorTest.js:
      (InspectorTest.checkForError):
      Helper for checking for, and logging, protocol error responses.
      
      * inspector/debugger/set-breakpoint.html:
      Update this test for the protocol change.
      
      * inspector-protocol/debugger/removeBreakpoint-expected.txt: Added.
      * inspector-protocol/debugger/removeBreakpoint.html: Added.
      * inspector-protocol/debugger/resources/breakpoint.js: Added.
      * inspector-protocol/debugger/setBreakpoint-autoContinue-expected.txt: Added.
      * inspector-protocol/debugger/setBreakpoint-autoContinue.html: Added.
      * inspector-protocol/debugger/setBreakpoint-column.html: Renamed from LayoutTests/inspector-protocol/debugger/column-breakpoint.html.
      * inspector-protocol/debugger/setBreakpoint-column.txt: Renamed from LayoutTests/inspector-protocol/debugger/column-breakpoint-expected.txt.
      * inspector-protocol/debugger/setBreakpoint-condition-expected.txt: Added.
      * inspector-protocol/debugger/setBreakpoint-condition.html: Added.
      * inspector-protocol/debugger/setBreakpoint-expected.txt: Added.
      * inspector-protocol/debugger/setBreakpoint.html: Added.
      Protocol tests for setting breakpoints. These test different aspects of
      the Debugger domain (setBreakpoint variants and removeBreakpoint).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8be1361
    • timothy@apple.com's avatar
      Make incrementing and decrementing numbers by 0.1 require the control key, and... · 80a737e6
      timothy@apple.com authored
      Make incrementing and decrementing numbers by 0.1 require the control key, and not near zero numbers.
      
      https://bugs.webkit.org/show_bug.cgi?id=120492
      <rdar://problem/13738935> Incrementing and decrementing numbers near zero is annoying compared to earlier releases
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/CodeMirrorAdditions.js:
      (alterNumber): Remove near zero check.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80a737e6
    • timothy@apple.com's avatar
      Only modify numbers if they are identified by CodeMirror as a number. · 63667844
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120484
      
      <rdar://problem/13877085> REGRESSION: Alt-up and Alt-down don't work when cursor is in unit
      <rdar://problem/13058697> PARITY: Option-Up arrow in "translate3d" should not modify number to make" translate4d"
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/CodeMirrorAdditions.js:
      (CodeMirror.prototype.alterNumberInRange): Correctly preserve the selection, even if it differs from
      the range passed in.
      (alterNumber): Find number tokens and pass those to alterNumberInRange.
      (alterNumber.findNumberToken): Added. Helper.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63667844
  18. 29 Aug, 2013 1 commit