1. 21 Feb, 2006 25 commits
    • ap's avatar
      Reviewed by Darin. · 0f59636c
      ap authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=7409
                Some minor fixes to http tests.
      
      LayoutTests:
      
              * http/conf/httpd.conf: don't define CustomLog and ErrorLog - these are now 
              passed from run-webkit-tests.
              * http/tests/favicon.ico: Added.
              * http/tests/incremental/slow-utf8-text.text: Remove an unused variable,
              * http/tests/incremental/split-hex-entities.html: Ditto.
              * http/tests/xmlhttprequest/interactive-state.cgi: Ditto.
      
      WebKitTools:
      
              * Scripts/run-webkit-tests: Pass CustomLog and ErrorLog directives to httpd.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f59636c
    • kdecker's avatar
      Reviewed by Darin. · e398dcd6
      kdecker authored
              Backed out my previous check in. Since these methods are internal to WebKit (and not private)
              it's perfectly OK for them to remain as categories. 
              * ChangeLog:
              * WebView/WebPreferences.m:
              (-[WebPreferences _integerValueForKey:]):
              (-[WebPreferences _setIntegerValue:forKey:]):
              (-[WebPreferences _floatValueForKey:]):
              (-[WebPreferences _setFloatValue:forKey:]):
              (-[WebPreferences _boolValueForKey:]):
              (-[WebPreferences _setBoolValue:forKey:]):
              * WebView/WebPreferencesPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e398dcd6
    • adele's avatar
      Reviewed by Hyatt. · 590ce138
      adele authored
              - Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7330
              baselinePosition is wrong for new text field when empty
      
              * fast/forms/input-baseline-expected.checksum: Added.
              * fast/forms/input-baseline-expected.png: Added.
              * fast/forms/input-baseline-expected.txt: Added.
              * fast/forms/input-baseline.html: Added.
              * fast/inline-block/contenteditable-baseline-expected.checksum: Added.
              * fast/inline-block/contenteditable-baseline-expected.png: Added.
              * fast/inline-block/contenteditable-baseline-expected.txt: Added.
              * fast/inline-block/contenteditable-baseline.html: Added.
      
              Reviewed by Hyatt.
      
              Tests:
              * fast/forms/input-baseline.html
              * fast/inline-block/contenteditable-baseline.html
      
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7330
              baselinePosition is wrong for new text field when empty
      
              * rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfLastLineBox):  
               If we're dealing with an empty contenteditable block, then we've added height to the block to make room for the caret, 
               and there are no children to give us the baseline.  Instead, compute the baseline for the block itself, and factor in the border and the padding.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      590ce138
    • vicki's avatar
      Reviewed by Adele. · 916502e0
      vicki authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7363
              REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail
      
              Add a nil check for the renderer, and refetch the renderer for the old focus node
              after dispatching the event. 
      
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::setFocusNode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      916502e0
    • eseidel's avatar
      2006-02-21 Eric Seidel <eseidel@apple.com> · 29b54346
      eseidel authored
              Reviewed by ggaren.
      
              Add grammarWrapper.cpp to work around visual studio bug plaguing buildbot.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29b54346
    • kdecker's avatar
      Reviewed by Timo O. · 4e818c44
      kdecker authored
              Moved these (already private) methods into the private WebPreferences header.
              Slightly better style than sprinkling the code with categories. 
              
              * WebView/WebPreferences.m:
              (-[WebPreferences _integerValueForKey:]): Moved to WebPreferences (WebPrivate).
              (-[WebPreferences _floatValueForKey:]): Ditto.
              (-[WebPreferences _boolValueForKey:]): Ditto.
              (-[WebPreferences _setBoolValue:forKey:]): Ditto.
              (-[WebPreferences _setFloatValue:forKey:]): Ditto.
              (-[WebPreferences _setIntegerValue:forKey:]): Ditto.
              * WebView/WebPreferencesPrivate.h: Added the above methods.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e818c44
    • ggaren's avatar
      Accidentally wrote "Release" instead of "Debug" in my last patch. · e9b278f4
      ggaren authored
              * quality/leakhunting.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9b278f4
    • eseidel's avatar
      2006-02-21 Eric Seidel <eseidel@apple.com> · 3831c7fa
      eseidel authored
              Reviewed by ggaren.
      
              * kjs/testkjs.cpp: #if out timeval code on win32
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3831c7fa
    • ap's avatar
      Reviewed by Darin. · 3c1c8bcf
      ap authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=6197
                Would like to use locally installed Apache for testing.
      
              Added two run-webkit-tests options:
                --http (--nohttp)  - whether to launch Apache (defaults to yes);
                --port - which port to listen on (defaults to 8000).
      
              Tests in LayoutTests/http are not run directly, and Apache is used instead.
              For example, http/tests/xmlhttprequest/post-content-type.html is loaded as
              http://127.0.0.1:8000/xmlhttprequest/post-content-type.html.
      
              Also added support for .shtml and .text files. Text files give an empty 
              *-expected.txt, but a correct image.
      
              Apache only listens on the loopback interface. It writes logs to /tmp/WebKit.
      
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c1c8bcf
    • darin's avatar
      Reviewed by Darin. · 8a633fbd
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7397
                TCPageMap.h would not compile for me because string.h was missing
      
              * kxmlcore/TCPageMap.h: Added <string.h> include.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a633fbd
    • darin's avatar
      Reviewed by John Sullivan. · 45d8ba10
      darin authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=7404
                remove a bunch of extra implementsCall overrides
      
              * JavaScriptCore.xcodeproj/project.pbxproj: Sorted files.
      
              * kjs/internal.h: Made InternalFunctionImp::callAsFunction pure virtual so that
              we'll get a compile error if some derived class neglects to implement it.
      
              * kjs/function.cpp: (KJS::FunctionImp::FunctionImp): Remove unneeded initialization
              of param, which is an OwnPtr so it gets initialized by default.
      
              * bindings/runtime_method.cpp:
              * bindings/runtime_method.h:
              * kjs/array_object.cpp:
              * kjs/array_object.h:
              * kjs/bool_object.cpp:
              * kjs/bool_object.h:
              * kjs/date_object.cpp:
              * kjs/date_object.h:
              * kjs/error_object.cpp:
              * kjs/error_object.h:
              * kjs/function.cpp:
              * kjs/function.h:
              * kjs/function_object.cpp:
              * kjs/function_object.h:
              * kjs/math_object.cpp:
              * kjs/math_object.h:
              * kjs/number_object.cpp:
              * kjs/number_object.h:
              * kjs/object_object.cpp:
              * kjs/object_object.h:
              * kjs/regexp_object.cpp:
              * kjs/regexp_object.h:
              * kjs/string_object.cpp:
              * kjs/string_object.h:
              Removed many rendundant implementations of implementsCall from subclasses of
              InternalFunctionImp.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45d8ba10
    • darin's avatar
      Suggested by Mark Rowe. · a3380497
      darin authored
              * Scripts/run-webkit-tests: Don't include the number of excluded leaks when
              reporting leak counts.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3380497
    • darin's avatar
      - fixed build · deb9c8c7
      darin authored
              * kjs/internal.cpp: (KJS::InternalFunctionImp::implementsCall):
              Oops, fixed name.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      deb9c8c7
    • darin's avatar
      Change suggested by Mitz. · 45120a16
      darin authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=7402
                REGRESSION: Methods do not execute
      
              * kjs/internal.h: Add implementsHasCall to InternalFunctionImp.
              * kjs/internal.cpp: (KJS::InternalFunctionImp::implementsHasCall):
              Return true. All the classes derived from InternalFunctionImp need
              to return true from this -- later we can remove all the extra
              implementations too.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45120a16
    • mjs's avatar
      Rubber Stamped by Hyatt. · ed59c7ee
      mjs authored
              - renamed STATIC, FIXED, RELATIVE, ABSOLUTE to StaticPosition, FixedPosition, etc
              
              This avoids conflicting with win32 headers.
      
              * css/css_computedstyle.cpp:
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::adjustRenderStyle):
              (WebCore::CSSStyleSelector::applyProperty):
              * editing/htmlediting.cpp:
              (WebCore::isSpecialElement):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::updateFirstLetter):
              * rendering/render_box.cpp:
              (WebCore::RenderBox::setStyle):
              (WebCore::RenderBox::absolutePosition):
              (WebCore::RenderBox::computeAbsoluteRepaintRect):
              * rendering/render_flow.cpp:
              (WebCore::RenderFlow::getAbsoluteRepaintRect):
              * rendering/render_layer.cpp:
              (WebCore::RenderLayer::convertToLayerCoords):
              (WebCore::RenderLayer::calculateClipRects):
              (WebCore::RenderLayer::calculateRects):
              * rendering/render_object.cpp:
              (WebCore::RenderObject::markContainingBlocksForLayout):
              (WebCore::RenderObject::containingBlock):
              (WebCore::RenderObject::setStyle):
              (WebCore::RenderObject::container):
              * rendering/render_style.cpp:
              (WebCore::RenderStyle::diff):
              * rendering/render_style.h:
              (khtml::):
              (khtml::RenderStyle::initialPosition):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed59c7ee
    • mjs's avatar
      Rubber Stamped by Hyatt. · 975fa95a
      mjs authored
              - remove KWQSignalStubs.cpp from project.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      975fa95a
    • mjs's avatar
      Platform build fix, not reviewed. · 28af6b39
      mjs authored
              - undef min and max, and include <algorithm> so std::min works
      
              * rendering/font.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28af6b39
    • mjs's avatar
      - fix build breakage caused by last-minute change to my patch · fb1763f8
      mjs authored
              * kjs/lookup.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb1763f8
    • mjs's avatar
      LayoutTests: · 268b51a5
      mjs authored
              Reviewed by Geoff and Darin.
              
              Patch from Maks Orlovich, based on work by David Faure, hand-applied and 
              significantly reworked by me.
              
              - Patch: give internal function names (KJS merge)
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6279
              
              Updated test results, now showing correct function string.
      
              * fast/dom/xmlhttprequest-get-expected.txt:
              * fast/js/kde/function-expected.txt:
              * fast/js/kde/inbuilt_function_tostring-expected.txt:
      
      WebCore:
      
              Reviewed by Geoff and Darin.
              
              Patch from Maks Orlovich, based on work by David Faure, hand-applied and 
              significantly reworked by me.
              
              - Patch: give internal function names (KJS merge)
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6279
      
              * khtml/ecma/kjs_binding.h:
              * khtml/ecma/kjs_html.cpp:
              (KJS::HTMLElementFunction::HTMLElementFunction):
              * kwq/WebCoreScriptDebugger.mm:
              (-[WebCoreScriptCallFrame functionName]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      268b51a5
    • ggaren's avatar
      Some quick proof-reading of the patch I just landed -- no review · 0fa3a531
      ggaren authored
              necessary.
      
              * quality/leakhunting.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fa3a531
    • mjs's avatar
      Reviewed by Geoff and Darin. · 3e13aa6b
      mjs authored
              
              Patch from Maks Orlovich, based on work by David Faure, hand-applied and 
              significantly reworked by me.
              
              - Patch: give internal function names (KJS merge)
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6279
      
              * tests/mozilla/expected.html: Updated for newly fixed test.
      
              * kjs/array_object.cpp:
              (ArrayProtoFunc::ArrayProtoFunc):
              * kjs/array_object.h:
              * kjs/bool_object.cpp:
              (BooleanPrototype::BooleanPrototype):
              (BooleanProtoFunc::BooleanProtoFunc):
              * kjs/bool_object.h:
              * kjs/date_object.cpp:
              (KJS::DateProtoFunc::DateProtoFunc):
              (KJS::DateObjectImp::DateObjectImp):
              (KJS::DateObjectFuncImp::DateObjectFuncImp):
              * kjs/error_object.cpp:
              (ErrorPrototype::ErrorPrototype):
              (ErrorProtoFunc::ErrorProtoFunc):
              * kjs/error_object.h:
              * kjs/function.cpp:
              (KJS::FunctionImp::FunctionImp):
              (KJS...
      3e13aa6b
    • ggaren's avatar
      Reviewed by Darin, Geoff. · 2e6c8fd0
      ggaren authored
              Added a page about leakhunting, based on the info Sullivan gave in two blogposts about it. (posts 20 and 24)
      
              Added this page to the menu, adding in an extra section header
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e6c8fd0
    • darin's avatar
      Reviewed by Eric. · c4cd8e4e
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7331
                CSS parser leaks when parsing incorrect CSS
      
              * css/css_base.h:
              (WebCore::CSSSelector::append): Replaced recursive implementation
              with an iterative one.
              (WebCore::StyleBaseImpl::StyleBaseImpl): Changed to be a Shared, not
              a TreeShared; parents now ref children as needed. This change was
              vital to fix the storage leaks. Also removed unused multiLength bool.
              (WebCore::StyleBaseImpl::parent): Added. Needed now that there's no
              TreeShared base class.
              (WebCore::StyleBaseImpl::setParent): Ditto.
              (WebCore::StyleBaseImpl::insertedIntoParent): Added. Hook for
              notification when added to a parent -- used by import style rules.
              (WebCore::StyleListImpl::StyleListImpl): Changed to use a Vector instead
              of a QPtrList for children. Slower for dynamic insert and remove for the
              DOM API, faster and more efficient for everything else.
              * css/css_base.cpp:
              (WebCore::StyleListImpl::append): Now calls insertedIntoParent
              and uses Vector.
              (WebCore::StyleListImpl::insert): Added. Calls insertedIntoParent.
              (WebCore::StyleListImpl::remove): Added. 
      
              * css/css_grammar.y: Removed obsolete "don't inline" stuff. Changed all
              code that creates new objects to use new functions on CSSParser. For
              CSSSelector, ValueList, Function, and Value, this means using new
              functions with a "floating" concept, but for reference-counted classes
              this just means asking the CSSParser to create the object instead of
              calling new. Remove all explicit "delete", which is now handled by the
              parser instead, which works when the Bison-generated parser fails too,
              not just when it hits error rules in the grammar.
      
              * css/css_ruleimpl.h:
              * css/css_ruleimpl.cpp:
              (WebCore::CSSImportRuleImpl::CSSImportRuleImpl): Remove call to init()
              which kicks off style sheet loading. We now do that when we are added to
              our parent instead of construction time. Also removed unused constructor.
              (WebCore::CSSImportRuleImpl::insertedIntoParent): Replaced init() with this
              function that does much the same thing at a different time. Changed code
              that sets m_loading to do it in a simple way that doesn't need a big comment.
              (WebCore::CSSMediaRuleImpl::insertRule): Use RefPtr.
      
              * css/css_stylesheetimpl.cpp:
              (StyleSheetImpl::StyleSheetImpl): Pass 0 for parent explicitly since the
              empty constructor was removed in the other patch.
              (CSSStyleSheetImpl::CSSStyleSheetImpl): Remove code to set up m_lstChildren;
              that's now handled by the base class.
              (CSSStyleSheetImpl::insertRule): Use length() instead of m_listChildren->count()
              and insert instead of m_lstChildren->insert. Also use RefPtr for the result of
              parseRule.
              (CSSStyleSheetImpl::addRule): Use length() instead of m_lstChildren->count().
              (CSSStyleSheetImpl::deleteRule): Use length() instead of checking the result of
              take() for 0. Use remove() instead of m_lstChildren->take().
              (CSSStyleSheetImpl::parseString): Use setStrictParsing instead of going at the
              strictParsing data member directly.
              (CSSStyleSheetImpl::isLoading): Use length() and item() instead of
              m_lstChildren->first() and m_lstChildren->next().
      
              * css/css_valueimpl.h: Add an include of QPtrList now that it's not used in
              any included file. Also added a constructor for CSSValueImpl, now that StyleBaseImpl
              has no empty constructor.
              * css/css_valueimpl.cpp:
              (WebCore::CSSMutableStyleDeclarationImpl::setProperty): Use useStrictParsing()
              instead of looking at the strictParsing data member directly.
              (WebCore::CSSMutableStyleDeclarationImpl::parseDeclaration): Ditto.
              (WebCore::CSSMutableStyleDeclarationImpl::setLengthProperty): Ditto.
              (WebCore::CSSMutableStyleDeclarationImpl::setCssText): Ditto.
      
              * css/cssparser.h:
              (WebCore::ValueList): Changed to use a Vector and an index rather
              than using a QPtrList.
              (WebCore::CSSParser): Changed parseRule to return a PassRefPtr, removed the
              createStyleDeclaration function since that's now handled by createStyleRule,
              made clearProperties be private, and added a suite of functions to create the
              objects formerly made with "new" in the Bison grammar. Also put the Units enum
              here in the header, and added an operator so they can be or'ed together while
              staying with the enum type so we can use Units instead of int for a function arg.
              * css/cssparser.cpp:
              (WebCore::ValueList::~ValueList): Changed to use Vector.
              (WebCore::CSSParser::CSSParser): Removed initializer for rule now that it's a RefPtr.
              (WebCore::CSSParser::~CSSParser): Added code to delete all the items in the sets that
              track floating objects. Also removed an unneeded check before callling clearProperties.
              (WebCore::CSSParser::parseSheet): Removed "delete rule" since rule is now a RefPtr.
              (WebCore::CSSParser::parseRule): Changed code to use rule.release() since rule is now
              a RefPtr and this function now returns a PassRefPtr.
              (WebCore::CSSParser::parseValue): Removed "delete rule" since rule is now a RefPtr.
              (WebCore::CSSParser::parseColor): Ditto.
              (WebCore::CSSParser::parseDeclaration): Ditto.
              (WebCore::CSSParser::validUnit): Made this a static class member instead of a local
              function so it can be used by the SVG parser code. Also updated to use the new ValueList
              class that uses Vector.
              (WebCore::CSSParser::parse4Values): Updated to new ValueList.
              (WebCore::CSSParser::parseContent): Ditto.
              (WebCore::skipCommaInDashboardRegion): Ditto.
              (WebCore::CSSParser::parseDashboardRegions): Ditto.
              (WebCore::CSSParser::parseShape): Ditto.
              (WebCore::CSSParser::parseColorFromValue): Ditto.
              (WebCore::BorderImageParseContext::commitBorderImage): Ditto.
              (WebCore::CSSParser::createFloatingSelector): Added. Puts selector into floating set.
              (WebCore::CSSParser::sinkFloatingSelector): Added. Removes from floating set.
              (WebCore::CSSParser::createFloatingValueList): Added. Puts list into floating set.
              (WebCore::CSSParser::sinkFloatingValueList): Added. Removes from floating set.
              (WebCore::CSSParser::createFloatingFunction): Added. Puts function into floating set.
              (WebCore::CSSParser::sinkFloatingFunction): Added. Removes from floating set.
              (WebCore::CSSParser::sinkFloatingValue): Added. Removes function from floating set if
              value contains a function pointer.
              (WebCore::CSSParser::createMediaList): Added. Puts list in a vector of RefPtrs kept
              by the parser, so the object won't end up floating.
              (WebCore::CSSParser::createImportRule): Ditto.
              (WebCore::CSSParser::createMediaRule): Ditto.
              (WebCore::CSSParser::createRuleList): Ditto.
              (WebCore::CSSParser::createStyleRule): Ditto. The properties come from the parser's
              global state instead of from a parameter.
      
              * khtml/xsl/xsl_stylesheetimpl.h:
              * khtml/xsl/xsl_stylesheetimpl.cpp:
              (WebCore::XSLStyleSheetImpl::XSLStyleSheetImpl): Initialize the new m_stylesheetDocTaken
              bool to false. Also remove code to set up m_lstChildren since the base class takes care
              of that now.
              (WebCore::XSLStyleSheetImpl::~XSLStyleSheetImpl): Only call xmlFreeDoc if the document
              was not taken by libxslt. We used to leak XSLStyleSheetImpl objects, which is why we
              didn't notice this before; we'll try to double free without this change.
              (WebCore::XSLStyleSheetImpl::isLoading): Use length() and item() instead of
              m_lstChildren->first() and m_lstChildren->next().
              (WebCore::XSLStyleSheetImpl::clearDocuments): Ditto.
              (WebCore::XSLStyleSheetImpl::parseString): Only call xmlFreeDoc if the document was not
              taken by libxslt. Also set m_stylesheetDocTaken for the new document.
              (WebCore::XSLStyleSheetImpl::loadChildSheet): Use RefPtr and append instead of
              m_lstChildren->append.
              (WebCore::XSLStyleSheetImpl::compileStyleSheet): Set m_stylesheetDocTaken to true if
              xsltParseStylesheetDoc is successful, since the stylesheet then owns the document.
              (WebCore::XSLStyleSheetImpl::locateStylesheetSubResource): Use length() and item()
              instead of m_lstChildren->first() and m_lstChildren->next().
              (WebCore::XSLStyleSheetImpl::markAsProcessed): Set m_stylesheetDocTaken, since when
              this is called, the document is returned to libxslt which then attaches it to a
              stylesheet or parent document.
      
              * ksvg2/css/KSVGCSSParser.cpp: Changed to compile as separate
              file instead of being included in cssparser.cpp.
              (WebCore::CSSParser::parseSVGPaint): Take out unnnecessary check
              of number of args. Everything works fine without that check, and
              otherwise I'd have to change it for the change in data structure.
              (WebCore::CSSParser::parseSVGColor): Ditto.
              * WebCore.xcodeproj/project.pbxproj: Added KSVGCSSParser.cpp.
      
              - fixed another leak found by run-webkit-leaks --leaks
      
              * kwq/KWQLoader.mm: (KWQServeRequest): Delete the job if we can't do the I/O, because
              the caller is passing ownership to us.
      
              - updated other code to use new Vector insert and remove
      
              * khtml/html/HTMLFormElementImpl.cpp:
              (WebCore::removeFromVector): Changed to use Vector's remove.
              (WebCore::HTMLFormElementImpl::registerFormElement): Changed to use Vector's insert.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4cd8e4e
    • ggaren's avatar
      Reviewed by Darin, with help from Eric, Maciej. · e359e0b7
      ggaren authored
              - More changes to support super-accurate JS iBench. Doesn't work on 
              Windows. (Doesn't break Windows, either.) I've filed [http://bugzilla.
              opendarwin.org/show_bug.cgi?id= 7399] about that. 
      
              * kjs/interpreter.cpp:
              (KJS::Interpreter::evaluate): Print line numbers with exception output
              * kjs/testkjs.cpp: Changed " *" to "* " because Eric says that's the 
              way we roll with .cpp files.
              (StopWatch::StopWatch): New class. Provides microsecond-accurate 
              timings.
              (StopWatch::~StopWatch):
              (StopWatch::start):
              (StopWatch::stop):
              (StopWatch::getElapsedMS):
              (TestFunctionImp::callAsFunction): Added missing return statement. 
              Fixed up "run" to use refactored helper functions. Removed bogus 
              return statement from "quit" case. Made "print" output to stdout 
              instead of stderr because that makes more sense, and PERL handles 
              stdout better.
              (main): Factored out KXMLCore unit tests. Removed custom exception 
              printing code because the interpreter prints exceptions for you. Added 
              a "delete" call for the GlobalImp we allocate.
              (testIsInteger): New function, result of refacotring.
              (createStringWithContentsOfFile): New function, result of refactoring. 
              Renamed "code" to "buffer" to match factored-out-ness.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e359e0b7
    • darin's avatar
      LayoutTests: · b7b4513b
      darin authored
              - test http://bugzilla.opendarwin.org/show_bug.cgi?id=6831
                contentEditable outline darkens as caret moves
      
              * editing/selection/move-by-character-6.html: Added.
              * editing/selection/move-by-character-6-expected.txt: Added.
              * editing/selection/move-by-character-6-expected.checksum: Added.
              * editing/selection/move-by-character-6-expected.png: Added.
      
      WebCore:
      
              Collaborated with Graham Dennis <Graham.Dennis@gmail.com> on this.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6831
                contentEditable outline darkens as caret moves
      
              Test: editing/selection/move-by-character-6.html
      
              The trick was to draw the focus ring clipped to a list of rectangles instead
              of clipped to exactly one.
      
              * kwq/KWQPainter.h: Move Color parameter from initFocusRing to drawFocusRing.
              * kwq/KWQPainter.mm:
              (WebCore::QPainterPrivate::QPainterPrivate): Change focusRingPath from
              an NSBezierPath to a CGMutablePathRef.
              (WebCore::QPainterPrivate::~QPainterPrivate): Ditto.
              (WebCore::QPainter::initFocusRing): Removed color parameter, and made a
              CGPath instead of an NSBezierPath.
              (WebCore::QPainter::addFocusRingRect): CGPath instead of NSBezierPath.
              (WebCore::QPainter::drawFocusRing): Added color parameter, and changed to
              use new bridge method to draw the focus ring.
              (WebCore::QPainter::clearFocusRing): CGPath instead of NSBezierPath.
      
              * kwq/WebCoreGraphicsBridge.h:
              * kwq/WebCoreGraphicsBridge.m:
              (-[WebCoreGraphicsBridge drawFocusRingWithPath:radius:color:]):
              Replaced setFocusRingStyle: method with this one.
      
              * rendering/render_flow.cpp: (WebCore::RenderFlow::paintFocusRing):
              * rendering/render_object.cpp: (WebCore::RenderObject::paintOutline):
              Pass color to drawFocusRing instead of initFocusRing.
      
              - fixed message on exit from the other patch I just landed
      
              * platform/mac/CursorMac.mm:
              (WebCore::leakNamedCursor): Renamed and made this leak intentionally.
      
      WebKit:
      
              Collaborated with Graham Dennis <Graham.Dennis@gmail.com> on this.
      
              - WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6831
                contentEditable outline darkens as caret moves
      
              * WebCoreSupport/WebGraphicsBridge.m:
              (-[WebGraphicsBridge drawFocusRingWithPath:radius:color:]):
              Replaced the old bridge function that set up style with this one that renders a path.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7b4513b
  2. 20 Feb, 2006 7 commits
    • darin's avatar
      Reviewed by Hyatt. · 644b75ef
      darin authored
              - moved Cursor into the platform directory from KWQ
              - removed a lot of other unneeded stuff from KWQ
      
              * platform/Cursor.h: Added.
              * platform/mac/CursorMac.mm: Added.
              * platform/mac/CursorWin.cpp: Added.
      
              * kwq/KWQBuffer.cpp: Removed.
              * kwq/KWQBuffer.h: Removed.
              * kwq/KWQCursor.h: Removed.
              * kwq/KWQCursor.mm: Removed.
              * kwq/KWQIODevice.h: Removed.
              * kwq/KWQKCursor.h: Removed.
              * kwq/KWQKCursor.mm: Removed.
              * kwq/KWQKDebug.h: Removed.
              * kwq/KWQSignalStubs.cpp: Removed.
      
              * ForwardingHeaders/kcursor.h: Removed.
              * ForwardingHeaders/kdebug.h: Removed.
              * ForwardingHeaders/qbuffer.h: Removed.
      
              * kwq/KWQEvent.h: Removed unused constants and types QCustomEvent,
              QFocusEvent, QHideEvent, QShowEvent, QContextMenuEvent, and QResizeEvent.
      
              * kwq/KWQLoader.h: Removed KWQLoader class since signals are no longer needed.
              * kwq/KWQLoader.mm: Ditto.
      
              * kwq/KWQNamespace.h: Removed DontClip, ShowPrefix, WordBreak, LayoutDirection,
              LeftToRight, RightToLeft, RasterOp, CopyROP, OrROP, and XorROP.
      
              * kwq/KWQObject.h: Removed blockSignals, sender, _signalsBlocked, _sender,
              and KWQObjectSenderScope.
              * kwq/KWQObject.cpp:
              (QObject::QObject): Removed _signalsBlocked.
              (QObject::connect): Removed special-case signals to not complain about.
              All of them were either unused, converted to non-signal functions, or in one
              case (slotScrollBarMoved) turned into a FIXME.
      
              * kwq/KWQPainter.h: Removed rasterOp and setRasterOp.
              * kwq/KWQPainter.mm: Ditto.
      
              * kwq/KWQSignal.h:
              * kwq/KWQSignal.cpp: (KWQSignal::disconnect): Removed special cases for
              various signals; all are now using plain function calls instead.
      
              * kwq/KWQSlot.h:
              * kwq/KWQSlot.cpp: Removed slots that are no longer needed because they
              are using plain function calls instead of signals.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              Updated for changed files.
      
              * bridge/mac/FrameViewMac.mm: Moved the contents of KWQKHTMLView.cpp in here.
              * bridge/mac/KWQKHTMLView.cpp: Removed.
      
              * bridge/mac/MacFrame.h: Removed signals, changed setStatusBarText to take
              String instead of QString.
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::MacFrame): Removed signals.
              (WebCore::MacFrame::setStatusBarText): Changed parameter type.
              (WebCore::MacFrame::openURLFromPageCache): Removed parameter from started function.
              (WebCore::MacFrame::khtmlMouseMoveEvent): Changed from QCursor() to pointerCursor().
      
              * dom/DocumentImpl.h:
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::DocumentImpl): Removed signals.
              (WebCore::DocumentImpl::implicitOpen): Ditto.
              (WebCore::DocumentImpl::determineParseMode): Removed a use of kdDebug.
              (WebCore::DocumentImpl::finishedParsing): Added. Does a setParsing(false) and then
              calls finishedParsing on the frame. Replaces the old finishedParsing signal.
      
              * dom/xml_tokenizer.h:
              * dom/xml_tokenizer.cpp: Removed the finishedParsing signal since it's not just
              a function on the document.
              (WebCore::XMLTokenizer::finish): Call the function instead of emitting the signal.
      
              * khtml/html/htmlparser.h:
              * khtml/html/htmlparser.cpp: Moved the parser inside the WebCore namespace.
      
              * khtml/html/htmltokenizer.h:
              * khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::end): Updated
              to call finishedParsing function on document rather than emitting a signal.
      
              * kwq/KWQComboBox.mm:
              (-[KWQPopUpButton becomeFirstResponder]): Use QEvent instead of QFocusEvent.
              (-[KWQPopUpButton resignFirstResponder]): Ditto.
              * kwq/KWQFileButton.mm: (KWQFileButton::focusChanged): Ditto.
              * kwq/KWQListBox.mm:
              (-[KWQTableView becomeFirstResponder]): Ditto.
              (-[KWQTableView resignFirstResponder]): Ditto.
              * kwq/KWQSlider.mm:
              (-[KWQSlider becomeFirstResponder]): Ditto.
              (-[KWQSlider resignFirstResponder]): Ditto.
              * kwq/KWQTextArea.mm:
              (-[KWQTextAreaTextView becomeFirstResponder]): Ditto.
              (-[KWQTextAreaTextView resignFirstResponder]): Ditto.
              * kwq/KWQTextField.mm:
              (-[KWQTextFieldController setHasFocus:]): Ditto.
      
              * kwq/KWQTextStream.h: Removed the mode parameter from the QTextStream constructor.
              Removed the QTextIStream and QTextOStream classes.
              * kwq/KWQTextStream.cpp: (QTextStream::QTextStream): Removed the mode parameter.
      
              * loader/CachedCSSStyleSheet.h: Changed to take a ByteArray instead of a QBuffer.
              * loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::data): Ditto.
              * loader/CachedImage.h: Ditto.
              * loader/CachedImage.cpp: (WebCore::CachedImage::data): Ditto.
              * loader/CachedObject.h: Ditto.
              * loader/CachedScript.h: Ditto.
              * loader/CachedScript.cpp: (WebCore::CachedScript::data): Ditto.
              * loader/CachedXBLDocument.h: Ditto.
              * loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::data): Ditto.
              * loader/CachedXSLStyleSheet.h:
              * loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::data): Ditto.
      
              * loader/DocLoader.cpp: (WebCore::DocLoader::setLoadInProgress): Added a call
              to loadDone on the frame. Replaces the requestFailed and requestDone signals.
      
              * loader/DocLoader.h: Removed include of <qbuffer.h>.
      
              * loader/Request.h:
              * loader/Request.cpp: Updated to use ByteArray instead of QBuffer.
      
              * loader/loader.h: Removed unused signals.
              * loader/loader.cpp:
              (WebCore::Loader::Loader): Removed use of KWQLoader.
              (WebCore::Loader::~Loader): Ditto.
              (WebCore::Loader::load): Removed code to emit unused requestStarted signal.
              (WebCore::Loader::slotFinished): Removed code to emit requestFailed and
              requestDone signals, now handled by DocLoader::setLoadInProgress(false).
              (WebCore::Loader::slotReceivedResponse): Use ByteArray instead of QBuffer.
              (WebCore::Loader::slotData): Ditto.
      
              * page/Frame.h: Removed setURLCursor, urlCursor, slotRestoreData, slotIncZoom,
              slotDecZoom, slotLoadImages, slotPartRemoved, slotActiveFrameChanged,
              slotChildURLRequest, slotShowDocument, slotAutoScroll, slotPrintFrame, slotSelectAll,
              slotProgressUpdate, slotJobPercent, slotJobSpeed.connectChild, disconnectChild,
              and changed a number of others from slots to plain old functions.
              * page/Frame.cpp:
              (WebCore::Frame::Frame): Don't connect to loader signals.
              (WebCore::Frame::~Frame): Don't disconnect from loader signals.
              (WebCore::Frame::didOpenURL): Call started function instead of emitting
              started signal. Don't connect to speed and percent signals (which never
              existed in WebCore anyway).
              (WebCore::Frame::stopLoading): Call finishedParsing function instead of
              calling slotFinishedParsing.
              (WebCore::Frame::executeScript): Removed redundant checks and let
              submitFormAgain do the checking.
              (WebCore::Frame::clear): Removed code to disconnect from finishedParsing
              signal; we now use a function. Also removed loop that calls disconnectChild,
              becase again we use functions now instead of signals.
              (WebCore::Frame::setDocument): Remove code to disconnect and connect to the
              finishedParsing signal.
              (WebCore::Frame::begin): Remove code to connect to the finishedParsing signal.
              (WebCore::Frame::finishedParsing): Moved code that does setParsing(false) into
              the document class. Also renamed from slotFinishedParsing.
              (WebCore::Frame::loadDone): Renamed from slotLoaderRequestDone.
              (WebCore::Frame::checkCompleted): Changed to call the completed function instead
              of emitting one of the two completed signals.
              (WebCore::Frame::loadSubframe): Removed call to connectChild because we now use
              functions instead of signals. Also change the call to completed to pass false
              instead of true.
              (WebCore::Frame::submitFormAgain): Change function around so we are less likely
              to leak if something strange happens inside submitForm.
              (WebCore::Frame::submitForm): Remove code to connect signal. We now call
              submitFormAgain from inside the completed function.
              (WebCore::Frame::parentCompleted): Renamed from slotParentCompleted. No longer
              a slot, now called from completed.
              (WebCore::Frame::childCompleted): Renamed from slotChildCompleted.
              (WebCore::Frame::setJSStatusBarText): Removed "emit" from function call. Changed
              to use String instead of QString.
              (WebCore::Frame::setJSDefaultStatusBarText): Ditto.
              (WebCore::Frame::sendResizeEvent): Changed to send DOM event directly instead of
              creating a QResizeEvent to send along to the FrameView.
              (WebCore::Frame::scrollToAnchor): Changed to not pass a parameter to the started
              function, which no longer takes one.
              (WebCore::Frame::frameDetached): Removed code that calls disconnectChild, since
              we no longer use signals.
              (WebCore::Frame::completed): Added. Calls childCompleted, parentCompleted, and
              submitFormAgain.
              (WebCore::Frame::setStatusBarText): Added.
              (WebCore::Frame::started): Added. Sets the complete flag to false for the frame
              and all its ancestors, which is what slotChildStarted did recursively.
      
              * page/FramePrivate.h: Removed m_activeFrame and changed m_kjsStatusBarText and
              m_kjsDefaultStatusBarText to String from QString.
      
              * page/FrameView.h: Removed resizeEvent, focusInEvent, focusOutEvent, and
              slotPaletteChanged. Changed cleared from a signal to a private function and
              slotScrollBarMoved to a private function named scrollBarMoved.
              * page/FrameView.cpp:
              (WebCore::FrameView::FrameView): Removed connect call here that was connecting
              a signal that's nonexistent in WebCore; we'll want to rig it up later.
              (WebCore::FrameView::~FrameView): Added a call to setQWidget(0) here to replace
              something that was done with a signal before.
              (WebCore::FrameView::clear): Call cleared as a function rather than a signal.
              (WebCore::selectCursor): Changed to use Cursor instead of QCursor.
              (WebCore::FrameView::scrollBarMoved): Renamed this function, which is never called.
              Added a FIXME about calling it.
              (WebCore::FrameView::cleared): Added. Calls viewCleared on the owner part, which
              used to be done with a signal.
      
              * platform/Widget.h: Changed to Cursor from QCursor.
              * platform/mac/WidgetMac.mm: (WebCore::Widget::setCursor): Ditto.
      
              * rendering/render_frames.h:
              * rendering/render_frames.cpp:
              (WebCore::RenderFrameSet::userResize): Removed cursor-setting code here. We might
              want to use resize cursors for frames again, but it was mostly disabled anyway and
              it's not clear which cursors to use.
              (WebCore::RenderPart::setWidget): Removed code to connect to the cleared signal.
              Instead, FrameView takes care of it directly.
              (WebCore::RenderPart::viewCleared): Renamed from slotViewCleared.
              (WebCore::RenderFrame::viewCleared): Ditto.
              (WebCore::RenderPartObject::viewCleared): Ditto.
      
              * rendering/render_image.cpp:
              (WebCore::RenderImage::imageChanged): Removed use of WordBreak, which doesn't exist
              in WebCore text rendering.
              (WebCore::RenderImage::paint): Ditto.
      
              * rendering/render_list.cpp: (RenderListMarker::paint): Removed use of DontClip, which
              doesn't exist in WebCore text rendering. Also removed incorrect use of references to
              temporaries for the ". " and " ." strings.
      
              * rendering/render_object.cpp:
              (WebCore::RenderObject::drawBorder): Removed call to setRasterOp since it is a no-op
              in WebCore's painter. Added a FIXME.
              (WebCore::RenderObject::information): Remove mode parameter to QTextStream.
      
              * rendering/render_replaced.h: Removed slotWidgetDestructed, made setQWidget public,
              * rendering/render_replaced.cpp:
              (WebCore::RenderWidget::setQWidget): Removed code to connect slotWidgetDestructed to
              the destroyed signal. Instead FrameView calls setQWidget(0) on us.
              (WebCore::RenderWidget::eventFilter): Removed use of QFocusEvent::reason, which is
              never "popup" in WebCore.
      
              * WebCore+SVG/kdom.h:
              * css/css_stylesheetimpl.cpp:
              * css/css_valueimpl.cpp:
              * css/cssparser.cpp:
              * kcanvas/KCanvasCreator.cpp:
              * kcanvas/KCanvasResources.cpp:
              * kcanvas/RenderPath.cpp:
              * khtml/ecma/xmlserializer.cpp:
              * khtml/html/html_baseimpl.cpp:
              * khtml/xsl/xsl_stylesheetimpl.cpp:
              * ksvg2/svg/SVGPathSegLinetoImpl.cpp:
              * ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
              * ksvg2/svg/SVGTransformImpl.cpp:
              * platform/StringImpl.cpp:
              * rendering/RenderBlock.cpp:
              * rendering/render_box.cpp:
              * rendering/render_canvas.cpp:
              * rendering/render_flow.cpp:
              * rendering/render_form.cpp:
              * rendering/render_layer.cpp:
              * rendering/render_style.cpp:
              Removed includes of <kdebug.h>.
      
              * css/css_base.cpp: (CSSSelector::selectorText):
              * khtml/ecma/kjs_binding.cpp:
              (KJS::ScriptInterpreter::wasRunByUserGesture):
              * khtml/ecma/kjs_css.cpp:
              (KJS::DOMCSSRule::putValueProperty):
              * khtml/ecma/kjs_dom.cpp:
              (KJS::DOMNode::getValueProperty):
              (KJS::DOMNode::putValueProperty):
              (KJS::DOMDocument::getValueProperty):
              * khtml/ecma/kjs_events.cpp:
              (KJS::DOMEvent::getValueProperty):
              (KJS::DOMUIEvent::getValueProperty):
              (KJS::DOMMouseEvent::getValueProperty):
              (KJS::DOMKeyboardEvent::getValueProperty):
              (KJS::Clipboard::getValueProperty):
              (KJS::Clipboard::putValueProperty):
              * khtml/ecma/kjs_html.cpp:
              (KJS::HTMLDocument::getValueProperty):
              (KJS::KJS::HTMLDocument::putValueProperty):
              (KJS::HTMLElement::anchorGetter):
              (KJS::HTMLElement::areaGetter):
              (KJS::KJS::HTMLElementFunction::callAsFunction):
              * khtml/ecma/kjs_navigator.cpp:
              (KJS::Navigator::getValueProperty):
              * khtml/ecma/kjs_traversal.cpp:
              (KJS::DOMNodeIterator::getValueProperty):
              (KJS::DOMTreeWalker::getValueProperty):
              * khtml/ecma/kjs_window.cpp:
              (KJS::Screen::getValueProperty):
              (KJS::Window::scheduleClose):
              (KJS::Window::isSafeScript):
              (KJS::Window::clear):
              (KJS::LocationFunc::callAsFunction):
              (KJS::History::getValueProperty):
              * ksvg2/svg/SVGAnimateColorElementImpl.cpp:
              (SVGAnimateColorElementImpl::handleTimerEvent):
              * ksvg2/svg/SVGAnimateElementImpl.cpp:
              (SVGAnimateElementImpl::handleTimerEvent):
              * ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
              (SVGAnimateTransformElementImpl::handleTimerEvent):
              * ksvg2/svg/SVGAnimationElementImpl.cpp:
              (SVGAnimationElementImpl::parseMappedAttribute):
              * ksvg2/svg/SVGCursorElementImpl.cpp:
              * ksvg2/svg/SVGDocumentImpl.cpp:
              (WebCore::SVGDocumentImpl::finishedParsing):
              * ksvg2/svg/SVGLengthImpl.cpp:
              (SVGLengthImpl::updateValueInSpecifiedUnits):
              Removed use of kdWarning, kdDebug, etc.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      644b75ef
    • mjs's avatar
      Reviewed by Darin. · cced322a
      mjs authored
              - port QString to win32
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * platform/QString.cpp:
              (strncasecmp):
              (QString::mid):
              (freeHandle):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cced322a
    • eseidel's avatar
      2006-02-20 Eric Seidel <eseidel@apple.com> · 0e6df1fc
      eseidel authored
              Reviewed by hyatt.
      
              Fix "Copy ICU DLLs..." phase.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e6df1fc
    • eseidel's avatar
      2006-02-20 Eric Seidel <eseidel@apple.com> · cc3b6845
      eseidel authored
              Reviewed by darin.
      
              <rdar://problem/4449442> GMAIL: XMLHttpRequest does not correctly report "Interactive" state on receipt of load data
              Also cleaned up spacing a little.
      
              No layout test possible (local loads are non incremental).
      
              * xml/xmlhttprequest.cpp:
              (WebCore::XMLHttpRequest::changeState):
              (WebCore::XMLHttpRequest::slotData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc3b6845
    • thatcher's avatar
      * Makefile.shared: Remove use of XcodeOptionStringNoConfig. We don't need it · 6a131623
      thatcher authored
        because commands like "make debug" have a side effect of setting the current
        configuration anyway.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a131623
    • darin's avatar
      Reviewed by Maciej. · 0298d12c
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7318
                REGRESSION: Timer bug causes gif animation and (html and JS) page forwarding to fail
      
              Timers were stopping firing after a while.
      
              My testing makes this look like a CFRunLoopTimer bug, and it would be nice to reproduce
              this with a standalone test and report it to the CF team, but in the mean time, change
              to create a new timer each time instead of reusing the existing timer.
      
              * platform/mac/SharedTimerMac.cpp:
              (WebCore::setSharedTimerFiredFunction): Added an assertion.
              (WebCore::setSharedTimerFireTime): Destroy the existing timer and create a new one every time.
              Also create a non-repeating timer rather than a repeating timer.
              (WebCore::stopSharedTimer): Destroy the existing timer rather than setting its fire date
              far into the future.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0298d12c
    • mjs's avatar
      Reviewed by Darin. · 80dc6cb7
      mjs authored
              - Added install-win-extras script which installs some extra 
              programs and libraries, and does Windows first-time setup.
      
              * Scripts/build-webkit: Add a newline between build results.
              * Scripts/install-win-extras: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80dc6cb7
  3. 19 Feb, 2006 7 commits
    • darin's avatar
      * WebKitSystemInterface.h: Added WKDrawFocusRing. · c3d23ead
      darin authored
              * libWebKitSystemInterface.a: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3d23ead
    • darin's avatar
      WebCore: · 3d938e6d
      darin authored
              Reviewed by Maciej.
      
              - cut out a little unneeded bridge code
      
              * bridge/mac/WebCoreFrameBridge.h: Removed frame name from createWindowWithURL: method
              and changed it to return a page bridge. Also made createModalDialogWithURL: method
              return a page bridge. Removed the mainFrame and webView methods.
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge nextFrameWithWrap:]): Use page to get to main frame.
              (-[WebCoreFrameBridge setFrameNamespace:]): Ditto.
              (-[WebCoreFrameBridge frameNamespace]): Ditto.
              (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Ditto.
              (-[WebCoreFrameBridge _frameInAnyWindowNamed:sourceFrame:]): Ditto.
              (-[WebCoreFrameBridge findFrameNamed:]): Ditto.
              (-[WebCoreFrameBridge installInFrame:]): Ditto.
      
              * bridge/mac/WebCorePageBridge.h: Added outerView method to replace webView method
              on the frame bridge.
      
              * bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
              Update to use a page bridge instead of frame bridge.
      
      WebKit:
      
              Reviewed by Maciej.
      
              - cut out a little unneeded bridge code
      
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge webView]): Added. Helper, since the WebCore side of the bridge no longer
              has this method.
              (-[WebFrameBridge createWindowWithURL:]): Removed the frameName parameter -- this is now
              handled on the WebCore side. Also return a page bridge instead of a frame bridge.
              (-[WebFrameBridge createModalDialogWithURL:]): Changed to return a page bridge instead of
              a frame bridge.
      
              * WebView/WebFrame.m: (-[WebFrame webView]): Change to get the webView from the page bridge
              instead of the frame bridge, since it's a per-page thing.
      
              * WebView/WebView.m: Removed init method since it just does what the default does (calls
              initWithFrame: with a zero rect).
              (-[WebView initWithCoder:]): Added checking so that if the obejcts have the wrong type
              we will fail gracefully instead of hitting "method not found" and the like.
              (-[WebView setPreferencesIdentifier:]): Fix storage leak. The WebPreferences object was
              not released.
              (-[WebView mainFrame]): Removed excess "return nil".
              (-[WebView _pageBridge]): Added. Helper to let you go from the WebView to the bridge
              from outside the WebView class.
              * WebView/WebViewInternal.h: Put _pageBridge into an internal header.
      
              * WebCoreSupport/WebPageBridge.m: (-[WebPageBridge outerView]): Added. Replaces "webView"
              as public method to tell the WebCore side about the view everything's embedded in.
      
              - other cleanup
      
              * WebCoreSupport/WebPageBridge.h: Removed some unneeded declarations.
      
              * Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]):
              Rearrange code so it doesn't have to get the main frame twice.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d938e6d
    • darin's avatar
      - renamed ERROR to LOG_ERROR to fix build · d91fb24d
      darin authored
                presumably Maciej had this change and forgot to land it
      
              * kjs/collector.cpp: Removed now-unneeded #undef ERROR.
              * kxmlcore/Assertions.h: Renamed ERROR to LOG_ERROR.
              * kxmlcore/FastMalloc.cpp: Changed MESSAGE macro to use LOG_ERROR.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d91fb24d
    • mjs's avatar
      Rubber-stamped by Anders. · b707f64a
      mjs authored
              
              - renamed ERROR to LOG_ERROR because some operating systems define ERROR in a system header
      
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::passMouseDownEventToWidget):
              * bridge/mac/WebCoreFrameBridge.mm:
              (aeDescFromJSValue):
              (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
              * css/css_computedstyle.cpp:
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
              * editing/Selection.cpp:
              (WebCore::Selection::toRange):
              * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
              (WebCore::KCanvasFEBlendQuartz::getCIFilter):
              (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
              * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
              (WebCore::KRenderingDeviceQuartz::createResource):
              * khtml/xsl/xslt_processorimpl.cpp:
              (DOM::parseErrorFunc):
              * kwq/KWQFontMetrics.mm:
              (QFontMetrics::ascent):
              (QFontMetrics::descent):
              (QFontMetrics::lineSpacing):
              (QFontMetrics::xHeight):
              (QFontMetrics::width):
              (QFontMetrics::floatWidth):
              (QFontMetrics::checkSelectionPoint):
              * kwq/KWQKConfigBase.mm:
              (KConfig::readEntry):
              (KConfig::readNumEntry):
              (KConfig::readUnsignedNumEntry):
              * kwq/KWQLineEdit.mm:
              (KWQNSTextAlignmentForAlignmentFlags):
              * kwq/KWQObject.cpp:
              (QObject::connect):
              * kwq/KWQPainter.mm:
              (WebCore::QPainter::restore):
              (WebCore::QPainter::drawFocusRing):
              * kwq/KWQRegExp.cpp:
              (QRegExp::KWQRegExpPrivate::compile):
              (QRegExp::match):
              * kwq/KWQSignal.cpp:
              (KWQSignal::connect):
              (KWQSignal::disconnect):
              * kwq/KWQSlot.cpp:
              (KWQSlot::KWQSlot):
              * kwq/KWQTextCodec.cpp:
              (KWQTextDecoder::createICUConverter):
              (KWQTextDecoder::convertUsingICU):
              * kwq/WebCoreTextRendererFactory.mm:
              (-[WebCoreTextRendererFactory fontWithFamilies:traits:size:]):
              (-[WebCoreTextRendererFactory isFontFixedPitch:]):
              (-[WebCoreTextRendererFactory rendererWithFont:]):
              * page/Frame.cpp:
              (WebCore::Frame::paint):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b707f64a
    • ap's avatar
      Reviewed by Darin. · 06d08722
      ap authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=7308
                DumpRenderTree should be able to load files via HTTP
      
              * DumpRenderTree/DumpRenderTree.m: (dumpRenderTree):
              Handle tests starting with "http://" as real URLs, not file system paths.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06d08722
    • ap's avatar
      Reviewed by Maciej. · 79c6219a
      ap authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7357
                REGRESSION: Warnings from WebKit scripts if PBXProductDirectory is undefined
      
              * Scripts/webkitdirs.pm: only call chomp if PBXProductDirectory is configured.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79c6219a
    • mjs's avatar
      Fix bogus line in ChangeLog. · f4f9fcb8
      mjs authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4f9fcb8
  4. 18 Feb, 2006 1 commit
    • mjs's avatar
      Reviewed by Dave Hyatt. · 9677c5ea
      mjs authored
              - fix win32 build
      
              * css/css_grammar.y: 
              * khtml/html/html_objectimpl.cpp: #ifdef out all bindings code
              (WebCore::HTMLAppletElementImpl::~HTMLAppletElementImpl):
              (WebCore::HTMLAppletElementImpl::detach):
              (WebCore::HTMLEmbedElementImpl::~HTMLEmbedElementImpl):
              (WebCore::HTMLEmbedElementImpl::detach):
              (WebCore::HTMLObjectElementImpl::~HTMLObjectElementImpl):
              (WebCore::HTMLObjectElementImpl::detach):
              * khtml/html/html_objectimpl.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9677c5ea