1. 13 May, 2011 27 commits
    • dcheng@chromium.org's avatar
      2011-05-13 Daniel Cheng <dcheng@chromium.org> · 0eb6dc60
      dcheng@chromium.org authored
              Reviewed by Tony Chang.
      
              Improve drag start logic
              https://bugs.webkit.org/show_bug.cgi?id=59409
      
              Add a new test to test drag start edge cases on Mac (because of a non-zero text drag delay)
              as well as rebase an existing test.
      
              * fast/css/user-drag-none.html: Text nodes are no longer draggable.
              * platform/mac/editing/pasteboard/drag-selections-to-contenteditable-expected.txt: Added.
              * platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html: Added.
      2011-05-13  Daniel Cheng  <dcheng@chromium.org>
      
              Reviewed by Tony Chang.
      
              Improve drag start logic
              https://bugs.webkit.org/show_bug.cgi?id=59409
      
              Rewrite and simplify the dragging logic to better match IE, Firefox, and the behavior
              defined in the spec. Among other things:
              - draggableNode() no longer returns text nodes when dragging anchors.
              - When starting a drag over an image in a selection, prefer to drag the selection.
              - Several redundant hit tests have been removed.
              - Minor refactoring to make the logic easier to follow.
      
              Test: platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html
      
              * WebCore.xcodeproj/project.pbxproj:
              * page/DragController.cpp:
              (WebCore::DragController::draggableNode):
              (WebCore::DragController::startDrag):
              * page/DragController.h:
              * page/DragState.h:
              (WebCore::DragState::shouldDispatchEvents):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::EventHandler):
              (WebCore::EventHandler::eventMayStartDrag):
              (WebCore::EventHandler::updateDragSourceActionsAllowed):
              (WebCore::EventHandler::updateDragAndDrop):
              (WebCore::EventHandler::cancelDragAndDrop):
              (WebCore::EventHandler::dragHysteresisExceeded):
              (WebCore::EventHandler::dragSourceEndedAt):
              (WebCore::ExactlyOneBitSet):
              (WebCore::EventHandler::handleDrag):
              * page/EventHandler.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0eb6dc60
    • oliver@apple.com's avatar
      2011-05-13 Oliver Hunt <oliver@apple.com> · d369c8cd
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Make GC validation more aggressive
              https://bugs.webkit.org/show_bug.cgi?id=60802
      
              This patch makes the checks performed under GC_VALIDATION
              much more aggressive, and adds the checks to more places
              in order to allow us to catch GC bugs much closer to the
              point of failure.
      
              * JavaScriptCore.exp:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * debugger/DebuggerActivation.cpp:
              (JSC::DebuggerActivation::visitChildren):
              * heap/MarkedBlock.cpp:
              (JSC::MarkedBlock::MarkedBlock):
              * heap/MarkedSpace.cpp:
              * runtime/Arguments.cpp:
              (JSC::Arguments::visitChildren):
              * runtime/Executable.cpp:
              (JSC::EvalExecutable::visitChildren):
              (JSC::ProgramExecutable::visitChildren):
              (JSC::FunctionExecutable::visitChildren):
              * runtime/Executable.h:
              * runtime/GetterSetter.cpp:
              (JSC::GetterSetter::visitChildren):
              * runtime/GetterSetter.h:
              * runtime/JSAPIValueWrapper.h:
              (JSC::JSAPIValueWrapper::createStructure):
              (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
              * runtime/JSActivation.cpp:
              (JSC::JSActivation::visitChildren):
              * runtime/JSArray.cpp:
              (JSC::JSArray::visitChildren):
              * runtime/JSCell.cpp:
              (JSC::slowValidateCell):
              * runtime/JSCell.h:
              (JSC::JSCell::JSCell::unvalidatedStructure):
              (JSC::JSCell::JSCell::JSCell):
              * runtime/JSFunction.cpp:
              (JSC::JSFunction::visitChildren):
              * runtime/JSGlobalObject.cpp:
              (JSC::JSGlobalObject::visitChildren):
              (JSC::slowValidateCell):
              * runtime/JSONObject.h:
              * runtime/JSObject.cpp:
              (JSC::JSObject::visitChildren):
              * runtime/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::visitChildren):
              * runtime/JSPropertyNameIterator.h:
              * runtime/JSStaticScopeObject.cpp:
              (JSC::JSStaticScopeObject::visitChildren):
              * runtime/JSString.h:
              (JSC::RopeBuilder::JSString):
              * runtime/JSWrapperObject.cpp:
              (JSC::JSWrapperObject::visitChildren):
              * runtime/NativeErrorConstructor.cpp:
              (JSC::NativeErrorConstructor::visitChildren):
              * runtime/PropertyMapHashTable.h:
              (JSC::PropertyMapEntry::PropertyMapEntry):
              * runtime/RegExpObject.cpp:
              (JSC::RegExpObject::visitChildren):
              * runtime/ScopeChain.cpp:
              (JSC::ScopeChainNode::visitChildren):
              * runtime/ScopeChain.h:
              (JSC::ScopeChainNode::ScopeChainNode):
              * runtime/Structure.cpp:
              (JSC::Structure::Structure):
              (JSC::Structure::addPropertyTransition):
              (JSC::Structure::visitChildren):
              * runtime/Structure.h:
              (JSC::JSCell::classInfo):
              * runtime/StructureChain.cpp:
              (JSC::StructureChain::visitChildren):
              * runtime/StructureChain.h:
              * runtime/WriteBarrier.h:
              (JSC::validateCell):
              (JSC::JSCell):
              (JSC::JSGlobalObject):
              (JSC::WriteBarrierBase::set):
              (JSC::WriteBarrierBase::setMayBeNull):
              (JSC::WriteBarrierBase::setEarlyValue):
              (JSC::WriteBarrierBase::get):
              (JSC::WriteBarrierBase::operator*):
              (JSC::WriteBarrierBase::operator->):
              (JSC::WriteBarrierBase::unvalidatedGet):
              (JSC::WriteBarrier::WriteBarrier):
              * wtf/Assertions.h:
      2011-05-13  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              Make GC validation more aggressive
              https://bugs.webkit.org/show_bug.cgi?id=60802
      
              This makes GC_VALIDATION much more aggressive in webcore,
              adding logic to every visitChildren method to ensure that
              the structure still has correct flags.
      
              Additionally every function generated for the dom bindings
              makes use of the new GC_VALIDATION object assertions to further
              ensure that the object appears to be sensible.
      
              * bindings/js/JSAttrCustom.cpp:
              (WebCore::JSAttr::visitChildren):
              * bindings/js/JSAudioContextCustom.cpp:
              (WebCore::JSAudioContext::visitChildren):
              * bindings/js/JSCSSRuleCustom.cpp:
              (WebCore::JSCSSRule::visitChildren):
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              (WebCore::JSCSSStyleDeclaration::visitChildren):
              * bindings/js/JSCanvasRenderingContextCustom.cpp:
              (WebCore::JSCanvasRenderingContext::visitChildren):
              * bindings/js/JSDOMGlobalObject.cpp:
              (WebCore::JSDOMGlobalObject::visitChildren):
              (WebCore::JSDOMGlobalObject::setInjectedScript):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::visitChildren):
              * bindings/js/JSDOMWindowShell.cpp:
              (WebCore::JSDOMWindowShell::visitChildren):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::JSEventListener):
              * bindings/js/JSEventListener.h:
              (WebCore::JSEventListener::jsFunction):
              * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
              (WebCore::JSJavaScriptAudioNode::visitChildren):
              * bindings/js/JSMessageChannelCustom.cpp:
              (WebCore::JSMessageChannel::visitChildren):
              * bindings/js/JSMessagePortCustom.cpp:
              (WebCore::JSMessagePort::visitChildren):
              * bindings/js/JSNamedNodeMapCustom.cpp:
              (WebCore::JSNamedNodeMap::visitChildren):
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::JSNode::visitChildren):
              * bindings/js/JSNodeFilterCustom.cpp:
              (WebCore::JSNodeFilter::visitChildren):
              * bindings/js/JSNodeIteratorCustom.cpp:
              (WebCore::JSNodeIterator::visitChildren):
              * bindings/js/JSSVGElementInstanceCustom.cpp:
              (WebCore::JSSVGElementInstance::visitChildren):
              * bindings/js/JSSharedWorkerCustom.cpp:
              (WebCore::JSSharedWorker::visitChildren):
              * bindings/js/JSStyleSheetCustom.cpp:
              (WebCore::JSStyleSheet::visitChildren):
              * bindings/js/JSTreeWalkerCustom.cpp:
              (WebCore::JSTreeWalker::visitChildren):
              * bindings/js/JSWebGLRenderingContextCustom.cpp:
              (WebCore::JSWebGLRenderingContext::visitChildren):
              * bindings/js/JSWorkerContextCustom.cpp:
              (WebCore::JSWorkerContext::visitChildren):
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              (WebCore::JSXMLHttpRequest::visitChildren):
              * bindings/js/JSXPathResultCustom.cpp:
              (WebCore::JSXPathResult::visitChildren):
              * bindings/scripts/CodeGeneratorJS.pm:
      2011-05-13  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              Make GC validation more aggressive
              https://bugs.webkit.org/show_bug.cgi?id=60802
      
              Add GC_VALIDATION calls to all the JSNPObject methods.
      
              * WebProcess/Plugins/Netscape/JSNPObject.cpp:
              (WebKit::JSNPObject::invalidate):
              (WebKit::JSNPObject::callMethod):
              (WebKit::JSNPObject::callObject):
              (WebKit::JSNPObject::callConstructor):
              (WebKit::JSNPObject::getCallData):
              (WebKit::JSNPObject::getConstructData):
              (WebKit::JSNPObject::getOwnPropertySlot):
              (WebKit::JSNPObject::getOwnPropertyDescriptor):
              (WebKit::JSNPObject::put):
              (WebKit::JSNPObject::getOwnPropertyNames):
              (WebKit::JSNPObject::propertyGetter):
              (WebKit::JSNPObject::methodGetter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d369c8cd
    • mnaganov@chromium.org's avatar
      2011-05-13 Mikhail Naganov <mnaganov@chromium.org> · c2bcfc8b
      mnaganov@chromium.org authored
              Web Inspector: Unreviewed image glyph position fix in CSS after r85588.
      
              * inspector/front-end/heapProfiler.css:
              (.heapshot-help-status-bar-item .glyph):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2bcfc8b
    • abarth@webkit.org's avatar
      2011-05-13 Adam Barth <abarth@webkit.org> · 56813fa6
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              iframe sandbox doesn't properly block popups
              https://bugs.webkit.org/show_bug.cgi?id=60784
      
              Test that we block popup windows from inside sandbox.
      
              * http/tests/security/no-popup-from-sandbox-expected.txt: Added.
              * http/tests/security/no-popup-from-sandbox-top-expected.txt: Added.
              * http/tests/security/no-popup-from-sandbox-top.html: Added.
              * http/tests/security/no-popup-from-sandbox.html: Added.
      2011-05-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              iframe sandbox doesn't properly block popups
              https://bugs.webkit.org/show_bug.cgi?id=60784
      
              Previously, we weren't implementing this requirement from the spec:
      
              "This flag also prevents content from creating new auxiliary browsing
              contexts, e.g. using the target attribute or the window.open() method."
      
              Tests: http/tests/security/no-popup-from-sandbox-top.html
                     http/tests/security/no-popup-from-sandbox.html
      
              * loader/PolicyChecker.cpp:
              (WebCore::PolicyChecker::checkNewWindowPolicy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56813fa6
    • rniwa@webkit.org's avatar
      2011-05-13 Ryosuke Niwa <rniwa@webkit.org> · 91cc070e
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              click event shouldn't fire when the target is ever removed in mouseup
              https://bugs.webkit.org/show_bug.cgi?id=60600
      
              Added tests to ensure WebKit does not fire click event when the target node
              is removed in mouseup event.
      
              * fast/events/remove-target-in-mouseup-deep-expected.txt: Added.
              * fast/events/remove-target-in-mouseup-deep.html: Added.
              * fast/events/remove-target-in-mouseup-expected.txt: Added.
              * fast/events/remove-target-in-mouseup-insertback-expected.txt: Added.
              * fast/events/remove-target-in-mouseup-insertback.html: Added.
              * fast/events/remove-target-in-mouseup-twice-expected.txt: Added.
              * fast/events/remove-target-in-mouseup-twice.html: Added.
              * fast/events/remove-target-in-mouseup.html: Added.
      2011-05-13  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              click event shouldn't fire when the target is ever removed in mouseup
              https://bugs.webkit.org/show_bug.cgi?id=60600
      
              Fixed the bug by invalidating m_clickNode when it or one of its ancestors has been removed
              from the document. New behavior matches Internet Explorer and Firefox.
      
              Tests: fast/events/remove-target-in-mouseup-deep.html
                     fast/events/remove-target-in-mouseup-insertback.html
                     fast/events/remove-target-in-mouseup-twice.html
                     fast/events/remove-target-in-mouseup.html
      
              * dom/Document.cpp:
              (WebCore::Document::nodeChildrenWillBeRemoved): Calls EventHandler::nodeWillBeRemoved.
              (WebCore::Document::nodeWillBeRemoved): Calls EventHandler::nodeWillBeRemoved.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::nodeWillBeRemoved): Added; invalidates m_clickNode when m_clickNode
              or one of its ancestor is removed from the document.
              * page/EventHandler.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91cc070e
    • ap@apple.com's avatar
      Reviewed by Joseph Pecoraro. · 05fdb04b
      ap@apple.com authored
              Hide appcache status bar items
              https://bugs.webkit.org/show_bug.cgi?id=60799
      
              We have a number of non-trivial bugs that make these more misleading than helpful to developers.
      
              * inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView):
              Just hide the items for now. Removing all support code would be complicated, and not helpful.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05fdb04b
    • abarth@webkit.org's avatar
      2011-05-13 Adam Barth <abarth@webkit.org> · c46976c3
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              indexedDB is visible inside iframe sandbox
              https://bugs.webkit.org/show_bug.cgi?id=60785
      
              * http/tests/security/no-indexeddb-from-sandbox-expected.txt: Added.
              * http/tests/security/no-indexeddb-from-sandbox.html: Added.
      2011-05-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              indexedDB is visible inside iframe sandbox
              https://bugs.webkit.org/show_bug.cgi?id=60785
      
              We're supposed to return a null indexedDB factory when inside an iframe
              sandbox.
      
              Test: http/tests/security/no-indexeddb-from-sandbox.html
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::webkitIndexedDB):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c46976c3
    • aroben@apple.com's avatar
      Fix manual tests that got broken by the move of WebCore into Source · 23768d21
      aroben@apple.com authored
      * manual-tests/plugins/object-clipping.html:
      * manual-tests/pointer-events.html:
      * manual-tests/video-waiting-seeking.html:
      Updated some paths.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23768d21
    • commit-queue@webkit.org's avatar
      2011-05-13 Nat Duca <nduca@chromium.org> · 920a1b69
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              [chromium] compositing tests are failing
              https://bugs.webkit.org/show_bug.cgi?id=60738
      
              Remove supression for previously failing compositor tests.
      
              * platform/chromium/test_expectations.txt:
      2011-05-13  Nat Duca  <nduca@chromium.org>
      
              Reviewed by James Robinson.
      
              [chromium] compositing tests are failing
              https://bugs.webkit.org/show_bug.cgi?id=60738
      
              Bind texture before setting its filtering state.
      
              * platform/graphics/chromium/LayerTilerChromium.cpp:
              (WebCore::LayerTilerChromium::updateFromPixels):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      920a1b69
    • ap@apple.com's avatar
      Reviewed by Dan Bernstein. · e3f870c8
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=60787
              Add some assertions to ApplicationCacheGroup
      
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Check that count doesn't underflow.
              (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
              (WebCore::ApplicationCacheGroup::stopLoading): Check that we are the handle's client before
              resetting it.
              (WebCore::ApplicationCacheGroup::update): Check that there isn't a stale current handle or
              resource hanging around.
              (WebCore::ApplicationCacheGroup::didFail): Check that the handle is either manifest or current one.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3f870c8
    • weinig@apple.com's avatar
      2011-05-13 Sam Weinig <sam@webkit.org> · c5b2001d
      weinig@apple.com authored
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * src/AutoFillPopupMenuClient.cpp:
              * src/PlatformBridge.cpp:
              * src/WebPopupMenuImpl.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * Api/qgraphicswebview.cpp:
              * WebCoreSupport/ChromeClientQt.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * WebCoreSupport/GtkAdjustmentWatcher.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * WebCoreSupport/WebChromeClient.cpp:
              * WebCoreSupport/WebDragClient.cpp:
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              * WebFrame.cpp:
              (WebFrame::setPrinting):
              * WebView.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * WebView/WebClipView.mm:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Replace #includes in FrameView.h of Frame.h and Page.h
                with Color.h, wtf/text/WTFString.h, and the new AdjustViewSizeOrNot.h
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * GNUmakefile.list.am:
              * WebCore.exp.in:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * accessibility/AccessibilityRenderObject.cpp:
              * accessibility/AccessibilityScrollView.cpp:
              * accessibility/chromium/AXObjectCacheChromium.cpp:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              * css/MediaQueryMatcher.cpp:
              * dom/Range.cpp:
              * editing/SpellingCorrectionController.cpp:
              * history/CachedFrame.cpp:
              * html/HTMLBodyElement.cpp:
              * html/canvas/WebGLRenderingContext.cpp:
              * html/parser/HTMLParserScheduler.cpp:
              * page/AdjustViewSizeOrNot.h: Added.
              * page/EditorClient.h:
              * page/Frame.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::forceLayoutForPagination):
              * page/FrameView.h:
              * page/PrintContext.cpp:
              (WebCore::PrintContext::begin):
              (WebCore::PrintContext::end):
              * page/chromium/FrameChromium.cpp:
              * page/win/FrameCGWin.cpp:
              * page/win/FrameWin.cpp:
              * platform/efl/PopupMenuEfl.cpp:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
              * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
              * platform/gtk/WidgetGtk.cpp:
              * plugins/IFrameShimSupport.cpp:
              * rendering/RenderBlock.cpp:
              * rendering/RenderBoxModelObject.cpp:
              * rendering/RenderFrameBase.cpp:
              * rendering/RenderIFrame.cpp:
              * rendering/RenderMenuList.cpp:
              * rendering/RenderTextControlSingleLine.cpp:
              * rendering/RenderWidget.cpp:
              * svg/SVGSVGElement.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * WebProcess/Plugins/PluginView.cpp:
              * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
              * WebProcess/WebPage/WebContextMenu.cpp:
              * WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5b2001d
    • leviw@chromium.org's avatar
      2011-05-13 Levi Weintraub <leviw@chromium.org> · 649a5eb7
      leviw@chromium.org authored
              Reviewed by Eric Seidel.
      
              Switch paintCollapsedBorder to use IntRect
              https://bugs.webkit.org/show_bug.cgi?id=60739
      
              Updating the last offending paint function that takes four ints
              instead of an IntRect.
      
              No new tests as this is simple refactoring.
      
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::paint):
              (WebCore::RenderTableCell::paintCollapsedBorder):
              * rendering/RenderTableCell.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      649a5eb7
    • inferno@chromium.org's avatar
      2011-05-13 Abhishek Arya <inferno@chromium.org> · 28ed1a04
      inferno@chromium.org authored
              Reviewed by Dave Hyatt.
      
              Regression(r75823): Revert initialization back to the first RenderBlock
              in the parent chain.
              https://bugs.webkit.org/show_bug.cgi?id=60780
      
              Test: fast/block/float/float-not-removed-crash.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
              In r75823, I forgot to initialize parentBlock, when the original code
              did and Hyatt did mention in c#5. Now, initializing parentBlock to the
              first RenderBlock in the parent chain.
      2011-05-13  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              Tests that we do not crash when trying to access a deleted float.
              https://bugs.webkit.org/show_bug.cgi?id=60780
      
              * fast/block/float/float-not-removed-crash-expected.txt: Added.
              * fast/block/float/float-not-removed-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28ed1a04
    • podivilov@chromium.org's avatar
      2011-05-05 Pavel Podivilov <podivilov@chromium.org> · 0100aa66
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: TextEditor should support editing a range.
              https://bugs.webkit.org/show_bug.cgi?id=59688
      
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
              (WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
              (WebInspector.TextEditorMainPanel.prototype.setEditableRange):
              (WebInspector.TextEditorMainPanel.prototype.clearEditableRange):
              (WebInspector.TextEditorMainPanel.prototype._splitChunkOnALine):
              (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
              (WebInspector.TextEditorMainChunk):
              (WebInspector.TextEditorMainChunk.prototype.set expanded):
              (WebInspector.TextEditorMainChunk.prototype.set readOnly):
              (WebInspector.TextEditorMainChunk.prototype.get readOnly):
              (WebInspector.TextEditorMainChunk.prototype._updateElementReadOnlyState):
              * inspector/front-end/textViewer.css:
              (.text-editor-read-only):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0100aa66
    • podivilov@chromium.org's avatar
      2011-05-05 Pavel Podivilov <podivilov@chromium.org> · f06f4cf6
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix source mapping for formatted scripts.
              https://bugs.webkit.org/show_bug.cgi?id=60263
      
              * inspector/debugger/resources/obfuscated.js:
              (formatted1):
              (formatted2):
              * inspector/debugger/script-formatter.html:
      2011-05-05  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix source mapping for formatted scripts.
              https://bugs.webkit.org/show_bug.cgi?id=60263
      
              Source mapping is broken for script chunks that are already formatted at the beginning
              and at the end of the script (see script-formatter.html).
      
              * inspector/front-end/ScriptFormatter.js:
              (WebInspector.ScriptFormatter.prototype._didFormatContent):
              (WebInspector.FormattedSourceMapping):
              (WebInspector.FormattedSourceMapping.prototype.originalToFormatted):
              (WebInspector.FormattedSourceMapping.prototype.formattedToOriginal):
              (WebInspector.FormattedSourceMapping.prototype._convertPosition):
              * inspector/front-end/ScriptFormatterWorker.js:
              (onmessage):
              (HTMLScriptFormatter.prototype.format):
              * inspector/front-end/SourceFile.js:
              (WebInspector.FormattedSourceFile.prototype._didRequestContent):
              (WebInspector.SourceMappingForFormattedSourceFile):
              (WebInspector.SourceMappingForFormattedSourceFile.prototype.scriptLocationToSourceLine):
              (WebInspector.SourceMappingForFormattedSourceFile.prototype.sourceLineToScriptLocation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f06f4cf6
    • aroben@apple.com's avatar
      Tell ScrollView's child Widgets that their frame rects have changed when its own frame rect changes · 9f9a70a7
      aroben@apple.com authored
      r79167 moved some code from setFrameRect to setBoundsSize, including a call to
      frameRectsChanged. This was done because positionScrollbarLayers, which is called by
      frameRectsChanged, only needs to be called when the bounds change, not when the frame rect
      changes. But the recursive calls inside frameRectsChanged *do* need to be called when the
      frame rect changes.
      
      This patch moves the positionScrollbarLayers call out of frameRectsChanged, since it needs
      to be called at different times from frameRectsChanged. Then it restores the
      frameRectsChanged call to setFrameRect, which fixes the bug.
      
      Test: platform/win/plugins/iframe-inside-overflow.html
      
      Fixes <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION (r79167): Windowed
      plugins in Google Reader don't move when the article list is scrolled
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore:
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::updateScrollbars): Added a positionScrollbarLayers call here now that
      frameRectsChanged doesn't call it for us. Also added a FIXME because it seems strange to
      call frameRectsChanged here when our frame rect hasn't changed.
      (WebCore::ScrollView::setFrameRect): Added back the frameRectsChanged call that was removed
      in r79167.
      (WebCore::ScrollView::setBoundsSize): Replaced a frameRectsChanged call with a call to
      positionScrollbarLayers. We were only calling frameRectsChanged here in order to get
      positionScrollbarLayers to be called.
      (WebCore::ScrollView::frameRectsChanged): Removed the call to positionScrollbarLayers. All
      callers of frameRectsChanged have been updated to call positionScrollbarLayers if needed.
      
      Tools:
      
      Add a plugin test that dumps the plugin window's rect
      
      * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
      (DumpWindowRect::DumpWindowRect): Just call up to the base class.
      (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
      harness window and log it.
      
      * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
      
      LayoutTests:
      
      Add a test for windowed plugins inside iframes inside scrolled overflow areas
      
      * platform/win/plugins/iframe-inside-overflow-expected.txt: Added.
      * platform/win/plugins/iframe-inside-overflow.html: Added.
      (loaded): Scrolls the div and tells the plugin to start its test (which will cause its
      window rect to be logged).
      * platform/win/plugins/resources/dump-window-rect-iframe.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f9a70a7
    • mrobinson@webkit.org's avatar
      2011-05-13 Martin Robinson <mrobinson@igalia.com> · 800f02d5
      mrobinson@webkit.org authored
              Reviewed by Eric Seidel.
      
              [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=59765
      
              Move the keybinding code form WebKit1/WebKit2 to this utility class. This code is
              almost directly moved from the WebKit layer.
      
              No new tests. This is covered by the editing tests.
      
              * GNUmakefile.list.am:
              * platform/gtk/KeyBindingTranslator.cpp: Added.
              (WebCore::backspaceCallback):Added.
              (WebCore::selectAllCallback):Added.
              (WebCore::cutClipboardCallback):Added.
              (WebCore::copyClipboardCallback):Added.
              (WebCore::pasteClipboardCallback):Added.
              (WebCore::toggleOverwriteCallback):Added.
              (WebCore::popupMenuCallback):Added.
              (WebCore::showHelpCallback):Added.
              (WebCore::deleteFromCursorCallback):Added.
              (WebCore::moveCursorCallback):Added.
              (WebCore::KeyBindingTranslator::KeyBindingTranslator):Added.
              (WebCore::KeyBindingTranslator::getEditorCommandsForKeyEvent):Added.
              * platform/gtk/KeyBindingTranslator.h: Added.
              (WebCore::KeyBindingTranslator::addPendingEditorCommand):Added.
      2011-05-13  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Eric Seidel.
      
              [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=59765
      
              Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
              class we can now share the code with WebKit2.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::executePendingEditorCommands): Updated to reflect the fact that
              the command vector now contains WTF::string.
              (WebKit::EditorClient::handleKeyboardEvent): Use the new helper utility class.
              (WebKit::EditorClient::EditorClient):
              * WebCoreSupport/EditorClientGtk.h: Remove unnecessary member. Add the utility class.
      2011-05-13  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Eric Seidel.
      
              [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=59765
      
              Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
              class we can now share the code with WebKit2.
      
              * UIProcess/API/gtk/PageClientImpl.cpp:
              (WebKit::PageClientImpl::PageClientImpl): No longer need to initialize keybinding code.
              (WebKit::PageClientImpl::getEditorCommandsForKeyEvent): Use the new utility class.
              * UIProcess/API/gtk/PageClientImpl.h: Remove unnecessary members. Add utility class member.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      800f02d5
    • zecke@webkit.org's avatar
      [android] Forward declare types for PlatformWidget and DragImage · 42ff713f
      zecke@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=59890
      
      This is fixing the compilation of files that include Widget.h or
      DragImage.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42ff713f
    • podivilov@chromium.org's avatar
      2011-05-06 Pavel Podivilov <podivilov@chromium.org> · b5fbb0bf
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix incremental html highlight.
              https://bugs.webkit.org/show_bug.cgi?id=60163
      
              SourceTokenizers for html, js, and css are declared to be stateless. However they store some state in
              various ways (like using _internalJavaScriptTokenizer field in html tokenizer, or modifying "static"
              initialCondition object via condition link). This all worked because of another bug in tokenizers registry
              that always returned new tokenizer object.
              For incremental highlighting, we need to be able to stringify tokenizers state and then restore the
              state from string. That's why we need tokenizers to be truly stateless.
      
              * inspector/front-end/DOMSyntaxHighlighter.js:
              (WebInspector.DOMSyntaxHighlighter.prototype.syntaxHighlightNode):
              * inspector/front-end/SourceCSSTokenizer.js:
              (WebInspector.SourceCSSTokenizer):
              (WebInspector.SourceCSSTokenizer.prototype.createInitialCondition):
              * inspector/front-end/SourceCSSTokenizer.re2js:
              * inspector/front-end/SourceHTMLTokenizer.js:
              (WebInspector.SourceHTMLTokenizer):
              (WebInspector.SourceHTMLTokenizer.prototype.createInitialCondition):
              (WebInspector.SourceHTMLTokenizer.prototype.set line):
              (WebInspector.SourceHTMLTokenizer.prototype.get _internalJavaScriptTokenizer):
              (WebInspector.SourceHTMLTokenizer.prototype.get _internalCSSTokenizer):
              (WebInspector.SourceHTMLTokenizer.prototype.scriptStarted):
              (WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted):
              (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
              * inspector/front-end/SourceHTMLTokenizer.re2js:
              * inspector/front-end/SourceJavaScriptTokenizer.js:
              (WebInspector.SourceJavaScriptTokenizer):
              (WebInspector.SourceJavaScriptTokenizer.prototype.createInitialCondition):
              * inspector/front-end/SourceJavaScriptTokenizer.re2js:
              * inspector/front-end/SourceTokenizer.js:
              (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
              * inspector/front-end/TextEditorHighlighter.js:
              (WebInspector.TextEditorHighlighter.prototype._highlightLines):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5fbb0bf
    • aroben@apple.com's avatar
      Build fix after r86418 · adbfa1ec
      aroben@apple.com authored
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
      Made the destructor public so that this class can be used with
      [Pass]OwnPtr.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adbfa1ec
    • hans@chromium.org's avatar
      2011-05-11 Hans Wennborg <hans@chromium.org> · 4d38a498
      hans@chromium.org authored
              Reviewed by Tony Gentilcore.
      
              IndexedDB: Fix integer comparison bug in LevelDB coding routines
              https://bugs.webkit.org/show_bug.cgi?id=60623
      
              Fix the code for comparing two int64_t variables.
              Also remove faulty line in ObjectStoreNamesKey::encode which was
              uncovered by the unit test in this patch.
      
              Very hard to cover with layout tests; covered by unit test.
      
              * storage/IDBLevelDBCoding.cpp:
              (WebCore::IDBLevelDBCoding::compareInts):
              (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
              (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
              (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
              (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
              (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
              (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
              (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
              (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
              (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
      2011-05-11  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Tony Gentilcore.
      
              IndexedDB: Fix integer comparison bug in LevelDB coding routines
              https://bugs.webkit.org/show_bug.cgi?id=60623
      
              Unit test for comparison of encoded keys.
      
              * tests/IDBLevelDBCodingTest.cpp:
              (IDBLevelDBCoding::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d38a498
    • commit-queue@webkit.org's avatar
      2011-05-13 Andrew Wason <rectalogic@rectalogic.com> · 02bc8e08
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              GraphicsContext3DQt.cpp fails to compile
              https://bugs.webkit.org/show_bug.cgi?id=60740
      
              * platform/graphics/qt/GraphicsContext3DQt.cpp:
              (WebCore::GraphicsContext3D::GraphicsContext3D):
               Change order of initializers.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02bc8e08
    • hans@chromium.org's avatar
      2011-05-05 Hans Wennborg <hans@chromium.org> · f9c19cc4
      hans@chromium.org authored
              Reviewed by Steve Block.
      
              IndexedDB: Transaction rollback prevented by open SQLite statement
              https://bugs.webkit.org/show_bug.cgi?id=60032
      
              Add test for veryfing that transaction roll-back works, even with a
              previously opened cursor still around.
      
              * storage/indexeddb/transaction-rollback-expected.txt: Added.
              * storage/indexeddb/transaction-rollback.html: Added.
      2011-05-05  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Steve Block.
      
              IndexedDB: Transaction rollback prevented by open SQLite statement
              https://bugs.webkit.org/show_bug.cgi?id=60032
      
              Let the IDBTransactionbackendImpl keep track of all open cursors, and
              "close" them (i.e. finalizing the underlying SQLiteStatement) before
              committing or rolling back the transaction. This fixes the problem
              with opened cursors preventing transaction rollback.
      
              Test: storage/indexeddb/transaction-rollback.html
      
              * storage/IDBBackingStore.h:
              * storage/IDBCursorBackendImpl.cpp:
              (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
              (WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl):
              (WebCore::IDBCursorBackendImpl::close):
              * storage/IDBCursorBackendImpl.h:
              * storage/IDBLevelDBBackingStore.cpp:
              * storage/IDBSQLiteBackingStore.cpp:
              * storage/IDBTransactionBackendImpl.cpp:
              (WebCore::IDBTransactionBackendImpl::abort):
              (WebCore::IDBTransactionBackendImpl::registerOpenCursor):
              (WebCore::IDBTransactionBackendImpl::unregisterOpenCursor):
              (WebCore::IDBTransactionBackendImpl::commit):
              (WebCore::IDBTransactionBackendImpl::closeOpenCursors):
              * storage/IDBTransactionBackendImpl.h:
              * storage/IDBTransactionBackendInterface.h:
              (WebCore::IDBTransactionBackendInterface::registerOpenCursor):
              (WebCore::IDBTransactionBackendInterface::unregisterOpenCursor):
      2011-05-05  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Steve Block.
      
              IndexedDB: Transaction rollback prevented by open SQLite statement
              https://bugs.webkit.org/show_bug.cgi?id=60032
      
              Implement two new methods in IDBTransactionBackendInterface.
      
              * src/IDBTransactionBackendProxy.cpp:
              (WebKit::IDBTransactionBackendProxy::registerOpenCursor):
              (WebKit::IDBTransactionBackendProxy::unregisterOpenCursor):
              * src/IDBTransactionBackendProxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9c19cc4
    • paroga@webkit.org's avatar
      2011-05-13 Patrick Gansterer <paroga@webkit.org> · 9f514e70
      paroga@webkit.org authored
              Reviewed by Adam Barth.
      
              Enable OwnPtr strict mode in MediaPlayer
              https://bugs.webkit.org/show_bug.cgi?id=59466
      
              Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
              Also fix the templete argument of OwnPtr for the m_private member variable.
      
              * platform/graphics/MediaPlayer.cpp:
              (WebCore::MediaPlayer::MediaPlayer):
              (WebCore::MediaPlayer::loadWithNextMediaEngine):
              * platform/graphics/MediaPlayer.h:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
              (WebCore::MediaPlayerPrivateAVFoundationObjC::create):
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivateGStreamer::create):
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
              * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivateQTKit::create):
              * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
              (WebCore::MediaPlayerPrivatePhonon::create):
              * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
              * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
              (WebCore::MediaPlayerPrivateQt::create):
              * platform/graphics/qt/MediaPlayerPrivateQt.h:
              * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::create):
              * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
              (WebCore::MediaPlayerPrivate::create):
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
              * platform/graphics/wince/MediaPlayerPrivateWinCE.h:
      2011-05-13  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Adam Barth.
      
              Enable OwnPtr strict mode in MediaPlayer
              https://bugs.webkit.org/show_bug.cgi?id=59466
      
              Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
              Also fix the templete argument of OwnPtr for the m_private member variable.
      
              * src/WebMediaPlayerClientImpl.cpp:
              (WebKit::WebMediaPlayerClientImpl::create):
              * src/WebMediaPlayerClientImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f514e70
    • ap@apple.com's avatar
      2011-05-13 Alexey Proskuryakov <ap@apple.com> · ba3782cc
      ap@apple.com authored
              Unreviewed test changes.
      
              Web Inspector: Show Error Messages for Application Cache Errors
              https://bugs.webkit.org/show_bug.cgi?id=41642
      
              * http/tests/appcache/404-resource-expected.txt:
              * http/tests/appcache/manifest-redirect-expected.txt:
              * http/tests/appcache/origin-quota-expected.txt:
              * http/tests/appcache/resource-redirect-2-expected.txt:
              * http/tests/appcache/resource-redirect-expected.txt:
              * http/tests/appcache/wrong-content-type-expected.txt:
              * http/tests/appcache/wrong-signature-2-expected.txt:
              * http/tests/appcache/wrong-signature-expected.txt:
      2011-05-13  Alexey Proskuryakov  <ap@apple.com>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: Show Error Messages for Application Cache Errors
              https://bugs.webkit.org/show_bug.cgi?id=41642
      
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::didReceiveResponse):
              (WebCore::ApplicationCacheGroup::didFail):
              (WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
              (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
              (WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota):
              Added console error logging.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba3782cc
    • psolanki@apple.com's avatar
      2011-05-12 Pratik Solanki <psolanki@apple.com> · 8b666474
      psolanki@apple.com authored
              Reviewed by Antti Koivisto.
      
              Part of WebCore should use CFNetwork-based loader on Mac
              https://bugs.webkit.org/show_bug.cgi?id=51836
      
              Fixes for warnings and other minor cleanups when we enable USE_CFNETWORK on Mac.
      
              * platform/network/cf/ResourceErrorCF.cpp:
              (WebCore::ResourceError::cfStreamError):
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::allowsAnyHTTPSCertificateHosts):
              (WebCore::clientCerts):
              (WebCore::willSendRequest):
              (WebCore::didReceiveResponse):
              (WebCore::didReceiveData):
              (WebCore::didSendBodyData):
              (WebCore::shouldUseCredentialStorageCallback):
              (WebCore::didFinishLoading):
              (WebCore::didFail):
              (WebCore::didReceiveChallenge):
              (WebCore::makeFinalRequest):
              (WebCore::ResourceHandle::willLoadFromCache):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b666474
    • psolanki@apple.com's avatar
      2011-05-12 Pratik Solanki <psolanki@apple.com> · 0a504439
      psolanki@apple.com authored
              Reviewed by Antti Koivisto.
      
              Part of WebCore should use CFNetwork-based loader on Mac
              https://bugs.webkit.org/show_bug.cgi?id=51836
      
              Implement ResourceHandle::schedule()/unschedule() based on CF for Mac.
      
              * WebCore.exp.in:
              * platform/cf/SchedulePair.h:
              * platform/mac/SchedulePairMac.mm:
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::ResourceHandle::schedule):
              (WebCore::ResourceHandle::unschedule):
      2011-05-12  Pratik Solanki  <psolanki@apple.com>
      
              Reviewed by Antti Koivisto.
      
              Part of WebCore should use CFNetwork-based loader on Mac
              https://bugs.webkit.org/show_bug.cgi?id=51836
      
              Use CFRunLoop when using CFNetwork.
      
              * WebView/WebView.mm:
              (-[WebView scheduleInRunLoop:forMode:]):
              (-[WebView unscheduleFromRunLoop:forMode:]):
      2011-05-12  Pratik Solanki  <psolanki@apple.com>
      
              Reviewed by Antti Koivisto.
      
              Part of WebCore should use CFNetwork-based loader on Mac
              https://bugs.webkit.org/show_bug.cgi?id=51836
      
              Use CFRunLoop when using CFNetwork.
      
              * WebProcess/WebPage/mac/WebPageMac.mm:
              (WebKit::WebPage::platformInitialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a504439
  2. 12 May, 2011 13 commits
    • psolanki@apple.com's avatar
      2011-05-12 Pratik Solanki <psolanki@apple.com> · 7c5455c6
      psolanki@apple.com authored
              Reviewed by Antti Koivisto.
      
              Part of WebCore should use CFNetwork-based loader on Mac
              https://bugs.webkit.org/show_bug.cgi?id=51836
      
              Implement mac specific Authentication functions when using CFNetwork.
      
              * WebCore.exp.in:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/network/ResourceHandle.h:
              * platform/network/cf/AuthenticationCF.cpp:
              (WebCore::AuthenticationChallenge::authenticationClient):
              (WebCore::createCF):
              (WebCore::core):
              * platform/network/cf/AuthenticationCF.h:
              * platform/network/cf/AuthenticationChallenge.h:
              * platform/network/mac/AuthenticationMac.mm:
              (WebCore::core):
              (WebCore::mac):
              * platform/network/mac/CredentialStorageMac.mm:
      2011-05-12  Pratik Solanki  <psolanki@apple.com>
      
              Reviewed by Antti Koivisto.
      
              Part of WebCore should use CFNetwork-based loader on Mac
              https://bugs.webkit.org/show_bug.cgi?id=51836
      
              Include AuthenticationCF.h header file.
      
              * Misc/WebDownload.mm:
              * Plugins/WebBaseNetscapePluginView.mm:
              * WebCoreSupport/WebFrameLoaderClient.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c5455c6
    • commit-queue@webkit.org's avatar
      2011-05-12 Ben Wells <benwells@chromium.org> · c37dc208
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              RGBA colors in outlines show overpainting at the corners
              https://bugs.webkit.org/show_bug.cgi?id=58999
      
              Converted the new tests to be text tests with pixel results
              (using dumpAsText(true)).
              Updated test_expectations comments to be more helpful and accurate and split
              new expectations into two groups for skia / chromium-mac as chromium-mac can be
              rebaselined now.
      
              * fast/borders/outline-alpha-block-expected.txt: Added.
              * fast/borders/outline-alpha-block.html:
              * fast/borders/outline-alpha-inline-expected.txt: Added.
              * fast/borders/outline-alpha-inline.html:
              * platform/chromium/test_expectations.txt:
              * platform/mac/fast/borders/outline-alpha-block-expected.txt: Removed.
              * platform/mac/fast/borders/outline-alpha-inline-expected.txt: Removed.
      2011-05-12  Ben Wells  <benwells@chromium.org>
      
              Reviewed by Simon Fraser.
      
              RGBA colors in outlines show overpainting at the corners
              https://bugs.webkit.org/show_bug.cgi?id=58999
      
              Added FIXMEs near temporary $if !USE(SKIA)s, referencing bug 60342.
      
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::paintOutline):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::paintOutline):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c37dc208
    • adele@apple.com's avatar
      Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser) · ff72a0db
      adele@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=60685
      
      Reviewed by Darin Adler and Adam Barth.
      
      Source/WebCore: 
      
      Detect the Solar Walk application so we can add targeted parser quirks.
      
      * WebCore.exp.in:
      * platform/RuntimeApplicationChecks.cpp: (WebCore::applicationIsSolarWalk):
      * platform/RuntimeApplicationChecks.h:
      
      Source/WebKit: 
      
      * WebKit.xcodeproj/project.pbxproj: Added Misc/SolarWalkQuirksUserScript.js and copy it to Resources during the build phase. 
      
      Source/WebKit/mac: 
      
      Solar Walk uses a self closing title tag, so to match the behavior of the old parser, 
      we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed.
      
      * Misc/SolarWalkQuirksUserScript.js: Added.
      * WebView/WebView.mm:
      (needsSolarWalkQuirksScript):
      (leakSolarWalkQuirksUserScriptContents):
      (-[WebView _injectSolarWalkQuirksScript]):
      (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff72a0db
    • jpu@apple.com's avatar
      2011-05-12 Jia Pu <jpu@apple.com> · a2f77992
      jpu@apple.com authored
              Reviewed by Darin Adler.
      
              Regression caused by changeset 86281
              https://bugs.webkit.org/show_bug.cgi?id=60712
      
              Changed wording in some tests to reflect AppKit UI change.
      
              * manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html:
              * manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html:
      2011-05-12  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Regression caused by changeset 86281
              https://bugs.webkit.org/show_bug.cgi?id=60712
              <rdar://problem/9427970>
      
              Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
              So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
              returns. So we don't need to use the condition to coordinate between these two function. In fact,
              all callbacks are delivered on main thread. We don't really need any locking here.
      
              Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
              been removed.
      
              * WebCoreSupport/CorrectionPanel.h:
              * WebCoreSupport/CorrectionPanel.mm:
              (CorrectionPanel::CorrectionPanel):
              (CorrectionPanel::show):
              (CorrectionPanel::dismiss):
              (CorrectionPanel::dismissInternal):
              (CorrectionPanel::handleAcceptedReplacement):
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::dismissCorrectionPanelSoon):
      2011-05-12  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Regression caused by changeset 86281
              https://bugs.webkit.org/show_bug.cgi?id=60712
              <rdar://problem/9427970>
      
              Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
              So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
              returns. So we don't need to use the condition to coordinate between these two function. In fact,
              all callbacks are delivered on main thread. We don't really need any locking here.
      
              Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
              been removed.
      
              * UIProcess/API/mac/PageClientImpl.mm:
              (WebKit::PageClientImpl::dismissCorrectionPanelSoon):
              * UIProcess/mac/CorrectionPanel.h:
              * UIProcess/mac/CorrectionPanel.mm:
              (WebKit::CorrectionPanel::CorrectionPanel):
              (WebKit::CorrectionPanel::show):
              (WebKit::CorrectionPanel::dismiss):
              (WebKit::CorrectionPanel::dismissInternal):
              (WebKit::CorrectionPanel::handleAcceptedReplacement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2f77992
    • dbates@webkit.org's avatar
      2011-05-12 Daniel Bates <dbates@rim.com> · 6245322a
      dbates@webkit.org authored
              Attempt to fix the build after changeset 86391<http://trac.webkit.org/changeset/86391>
              (https://bugs.webkit.org/show_bug.cgi?id=60681).
      
              * page/PluginHalter.cpp:
              (WebCore::PluginHalter::PluginHalter): Substitute m_client for client in ASSERT_ARG since client is now of type PassOwnPtr
              so it becomes 0 when assigned to another variable.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6245322a
    • paroga@webkit.org's avatar
      2011-05-12 Patrick Gansterer <paroga@webkit.org> · ece87828
      paroga@webkit.org authored
              Reviewed by Darin Adler.
      
              Rename SimpleFontData::scaledFontData to createScaledFontData
              https://bugs.webkit.org/show_bug.cgi?id=60723
      
              * platform/graphics/SimpleFontData.h:
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
              * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
              * platform/graphics/mac/SimpleFontDataMac.mm:
              * platform/graphics/pango/SimpleFontDataPango.cpp:
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              * platform/graphics/win/SimpleFontDataWin.cpp:
              * platform/graphics/wince/SimpleFontDataWinCE.cpp:
              * platform/graphics/wx/SimpleFontDataWx.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ece87828
    • leviw@chromium.org's avatar
      2011-05-12 Levi Weintraub <leviw@chromium.org> · b80b4638
      leviw@chromium.org authored
              Reviewed by Simon Fraser.
      
              Switch paintOutline to use IntRect
              https://bugs.webkit.org/show_bug.cgi?id=60718
      
              Switching paintOutline to use an IntRect instead of 4 ints.
      
              No new tests as this is just refactoring.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintObject):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::paintOutline):
              * rendering/RenderObject.h:
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::paint):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::paintObject):
              * rendering/svg/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::paint):
              * rendering/svg/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::paint):
              * rendering/svg/RenderSVGPath.cpp:
              (WebCore::RenderSVGPath::paint):
              * rendering/svg/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::paint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b80b4638
    • andersca@apple.com's avatar
      Address review comment by Dan Bernstein. · c4c99be1
      andersca@apple.com authored
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4c99be1
    • andersca@apple.com's avatar
      2011-05-12 Anders Carlsson <andersca@apple.com> · 36727c6f
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
      
              Crash when a plug-in tries to load a resource from the application cache
              https://bugs.webkit.org/show_bug.cgi?id=60735
              <rdar://problem/8216142>
      
              When loading application cache resources from disk, we would never restore the
              HTTP status code, which means that resources would always have a 0 status code.
              This led to the plug-in stream loader canceling the load, something which the application
              cache loading machinery couldn't deal and thus would crash.
      
              Fix the reading of the HTTP status code, and make the loader more robust against
              application cache loads being canceled.
      
              Unfortunately, I couldn't come up with a test for this because I couldn't find a reliable way
              to force the application cache to be read from disk, so all resources would have valid values.
      
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::loadCache):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36727c6f
    • eae@chromium.org's avatar
      2011-05-12 Emil A Eklund <eae@chromium.org> · be9be86e
      eae@chromium.org authored
              Reviewed by Darin Adler.
      
              Convert RenderBox::setLocation, setLogicalLocation and setLogicalSize to IntPoint/IntSize
              https://bugs.webkit.org/show_bug.cgi?id=60585
      
              Refactoring, covered by existing tests.
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::positionLineBox):
              * rendering/RenderBox.h:
              (WebCore::RenderBox::setLogicalLocation):
              (WebCore::RenderBox::setLogicalSize):
              (WebCore::RenderBox::setLocation):
              * rendering/RenderFrameSet.cpp:
              (WebCore::RenderFrameSet::positionFrames):
              (WebCore::RenderFrameSet::positionFramesWithFlattening):
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::layout):
              * rendering/RenderScrollbarPart.cpp:
              (WebCore::RenderScrollbarPart::paintIntoRect):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::adjustLogicalHeightForCaption):
              (WebCore::RenderTable::layout):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::layoutRows):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::layout):
              * rendering/svg/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBox::layoutRootBox):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be9be86e
    • enne@google.com's avatar
      2011-05-12 Adrienne Walker <enne@google.com> · 56d3618d
      enne@google.com authored
              Reviewed by James Robinson.
      
              [chromium] show-composited-layer-tree crashes on null ptr deref
              https://bugs.webkit.org/show_bug.cgi?id=60734
      
              The tiler is created lazily, so it won't not be around for the first
              dumpLayerProperties call.
      
              * platform/graphics/chromium/ContentLayerChromium.cpp:
              (WebCore::ContentLayerChromium::dumpLayerProperties):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56d3618d
    • paroga@webkit.org's avatar
      2011-05-12 Patrick Gansterer <paroga@webkit.org> · 03df15be
      paroga@webkit.org authored
              Reviewed by Adam Barth.
      
              Enable OwnPtr strict mode in PluginHalter
              https://bugs.webkit.org/show_bug.cgi?id=60681
      
              Pass PluginHalterClient as (Pass)OwnPtr to Page and PluginHalter.
      
              * WebCore.exp.in:
              * page/Page.cpp:
              (WebCore::Page::Page):
              (WebCore::Page::PageClients::PageClients):
              * page/Page.h:
              * page/PluginHalter.cpp:
              (WebCore::PluginHalter::PluginHalter):
              * page/PluginHalter.h:
      2011-05-12  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Adam Barth.
      
              Enable OwnPtr strict mode in PluginHalter
              https://bugs.webkit.org/show_bug.cgi?id=60681
      
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
      2011-05-12  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Adam Barth.
      
              Enable OwnPtr strict mode in PluginHalter
              https://bugs.webkit.org/show_bug.cgi?id=60681
      
              * WebView.cpp:
              (WebView::initWithFrame):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03df15be
    • dbates@webkit.org's avatar
      2011-05-12 Daniel Bates <dbates@rim.com> · ee1c625e
      dbates@webkit.org authored
              Reviewed by Adele Peterson.
      
              Frame's noResize attribute can not be set by JavaScript
              https://bugs.webkit.org/show_bug.cgi?id=14845
      
              Tests that frame resizing is allowed and disallowed depending on the value of the noResize property.
      
              Also, tests to ensure that frame resizing is allowed and disallowed when programmatically
              removing and adding the noresize attribute, respectively.
      
              * fast/frames/frame-inherit-noresize-from-frameset-expected.txt: Added.
              * fast/frames/frame-inherit-noresize-from-frameset.html: Added. See <https://bugs.webkit.org/show_bug.cgi?id=57604>.
              * fast/frames/frame-programmatic-noresize-expected.txt: Added.
              * fast/frames/frame-programmatic-noresize.html: Added.
              * fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Added.
              * fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html: Added.
              * fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Added.
              * fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html: Added.
              * fast/frames/resources/frame-programmatic-resize.js: Added.
              (setTestFrameById):
              (deltaWidth):
              (shouldAllowFrameResize):
              (shouldDisallowFrameResize):
              (shouldDisallowFrameResizeAfterProcessingFrame):
              (shouldAllowFrameResizeAfterProcessingFrame):
              (checkTestFrameWidthEquals):
              (resizeTestFrameBy):
              (log):
              (description):
      2011-05-12  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Adele Peterson.
      
              Frame's noResize attribute can not be set by JavaScript
              https://bugs.webkit.org/show_bug.cgi?id=14845
      
              Tests: fast/frames/frame-inherit-noresize-from-frameset.html
                     fast/frames/frame-programmatic-noresize.html
                     fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
                     fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html
      
              Implements support to programmatically allow and disallow frame resizing.
      
              Currently, HTMLFrameElement::parseMappedAttribute() is hardcoded to disallow frame resize (i.e.
              m_noResize = true) when either the noresize DOM attribute is specified (or existed at some
              point in time) or the value of the noResize attribute is modified. Instead we should allow/disallow
              frame resize depending on the presence of the noresize DOM attribute/the value of the noResize
              attribute.
      
              * html/HTMLFrameElement.cpp:
              (WebCore::HTMLFrameElement::HTMLFrameElement):
              (WebCore::HTMLFrameElement::noResize): Made this a non-inline function since this
              code path isn't performance critical.
              (WebCore::HTMLFrameElement::attach): Removed code to inherit noresize attribute from
              parent <frameset> since this functionality is part of RenderFrameSet::computeEdgeInfo().
              (WebCore::HTMLFrameElement::parseMappedAttribute):
              * html/HTMLFrameElement.h:
              * rendering/RenderFrame.cpp:
              (WebCore::RenderFrame::updateFromElement): Added.
              * rendering/RenderFrame.h:
              * rendering/RenderFrameSet.cpp:
              (WebCore::RenderFrameSet::notifyFrameEdgeInfoChanged): Added.
              * rendering/RenderFrameSet.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee1c625e