1. 13 May, 2011 1 commit
    • dcheng@chromium.org's avatar
      2011-05-13 Daniel Cheng <dcheng@chromium.org> · 0eb6dc60
      dcheng@chromium.org authored
              Reviewed by Tony Chang.
      
              Improve drag start logic
              https://bugs.webkit.org/show_bug.cgi?id=59409
      
              Add a new test to test drag start edge cases on Mac (because of a non-zero text drag delay)
              as well as rebase an existing test.
      
              * fast/css/user-drag-none.html: Text nodes are no longer draggable.
              * platform/mac/editing/pasteboard/drag-selections-to-contenteditable-expected.txt: Added.
              * platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html: Added.
      2011-05-13  Daniel Cheng  <dcheng@chromium.org>
      
              Reviewed by Tony Chang.
      
              Improve drag start logic
              https://bugs.webkit.org/show_bug.cgi?id=59409
      
              Rewrite and simplify the dragging logic to better match IE, Firefox, and the behavior
              defined in the spec. Among other things:
              - draggableNode() no longer returns text nodes when dragging anchors.
              - When starting a drag over an image in a selection, prefer to drag the selection.
              - Several redundant hit tests have been removed.
              - Minor refactoring to make the logic easier to follow.
      
              Test: platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html
      
              * WebCore.xcodeproj/project.pbxproj:
              * page/DragController.cpp:
              (WebCore::DragController::draggableNode):
              (WebCore::DragController::startDrag):
              * page/DragController.h:
              * page/DragState.h:
              (WebCore::DragState::shouldDispatchEvents):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::EventHandler):
              (WebCore::EventHandler::eventMayStartDrag):
              (WebCore::EventHandler::updateDragSourceActionsAllowed):
              (WebCore::EventHandler::updateDragAndDrop):
              (WebCore::EventHandler::cancelDragAndDrop):
              (WebCore::EventHandler::dragHysteresisExceeded):
              (WebCore::EventHandler::dragSourceEndedAt):
              (WebCore::ExactlyOneBitSet):
              (WebCore::EventHandler::handleDrag):
              * page/EventHandler.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0eb6dc60
  2. 11 May, 2011 1 commit
    • jpu@apple.com's avatar
      2011-05-11 Jia Pu <jpu@apple.com> · fd2014cc
      jpu@apple.com authored
              Reviewed by Darin Adler.
      
              Autocorrection persists after deleting and retyping the same word at same location.
              https://bugs.webkit.org/show_bug.cgi?id=60555
              <rdar://problem/9373915>
      
              See WebCore/ChangeLog for detail.
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac/editing/spelling/delete-autocorrected-word-2-expected.png: Added.
              * platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt: Added.
              * platform/mac/editing/spelling/delete-autocorrected-word-2.html: Added.
      2011-05-11  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Autocorrection persists after deleting and retyping the same word at same location.
              https://bugs.webkit.org/show_bug.cgi?id=60555
              <rdar://problem/9373915>
      
              This patch intends to alleviate the issue of repetitively applying the same autocorrection
              when user delete and retype the same word at the same location. This scenario is especially
              common when autocorrection modifies the first letter of the word.
      
              This patch consists following major changes:
              1. Added a new marker type, DeletedAutocorrection. This marker is added to the whitespace that
                 precedes a deleted autocorrection. If the user later types the same original word at after
                 this whitespace, the autocorrection will not be applied again.
              2. In DeleteSelectionCommand, added code to notify SpellingCorrectionController about the
                 autocorrection that has just been deleted.
              3. In Editor and SpellingCorrectionController, added code to apply the marker and to suppress
                 autocorrection when necessary.
              4. The change in CompositeEditCommand::replaceTextInNode is necessary for preserving markers.
                 Otherwise, we will loose the DeletedAutocorrection on the whitespace, when inserting text
                 after the whitespace.
      
              Test: platform/mac/editing/spelling/delete-autocorrected-word-2.html
      
              * dom/DocumentMarker.h: Added new marker type DeletedAutocorrection.
              (WebCore::DocumentMarker::AllMarkers::AllMarkers):
              * dom/DocumentMarkerController.cpp:
              (WebCore::DocumentMarkerController::markersInRange): Support querying multiple marker types.
              * dom/DocumentMarkerController.h:
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::replaceTextInNodeAndPreserveMarkers):
              (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
              (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
              * editing/CompositeEditCommand.h:
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
              (WebCore::DeleteSelectionCommand::fixupWhitespace):
              (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection): Extracting
                 the original string if we are deleting an autocorrection.
              (WebCore::DeleteSelectionCommand::doApply): Notify editor about the deleted autocorrection and its position.
              * editing/DeleteSelectionCommand.h:
              * editing/Editor.cpp:
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Moved all logic of determining
                 when to suppress an autocorrection into SpellingCorrectionController.
              (WebCore::Editor::deletedAutocorrectionAtPosition):
              * editing/Editor.h:
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/SpellingCorrectionController.cpp:
              (WebCore::SpellingCorrectionController::respondToAppliedEditing):
              (WebCore::SpellingCorrectionController::deletedAutocorrectionAtPosition):
              (WebCore::SpellingCorrectionController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
              (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
              * editing/SpellingCorrectionController.h:
              (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
              * editing/visible_units.cpp:
              (WebCore::isStartOfWord):
              * editing/visible_units.h:
              * manual-tests/autocorrection/spell-checking-after-reversion.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd2014cc
  3. 10 May, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-05-10 Chang Shu <cshu@webkit.org> · ccc67626
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Convert editing/inserting/typing-tab-designmode-forms.html to dumpAsText
              https://bugs.webkit.org/show_bug.cgi?id=60554
      
              * editing/inserting/typing-tab-designmode-forms-expected.txt: Added.
              * editing/inserting/typing-tab-designmode-forms.html:
              * platform/chromium-linux/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
              * platform/chromium-mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
              * platform/chromium-win/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
              * platform/chromium-win/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
              * platform/gtk/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
              * platform/gtk/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
              * platform/mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccc67626
  4. 09 May, 2011 1 commit
  5. 03 May, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-05-03 Ryosuke Niwa <rniwa@webkit.org> · 828bb6b4
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              WebKit allows selection that crosses the shadow boundary of a readonly input element
              https://bugs.webkit.org/show_bug.cgi?id=60000
      
              Added pixel tests to ensure WebKit doesn't create a selection that spans across
              the shadow DOM boundary of a readonly input element. Also rebaselined a test that
              previously exhibited this behavior.
      
              * editing/selection/resources/select-across-readonly-input.js: Added.
              (moveMouseToMiddleOfElement):
              * editing/selection/select-across-readonly-input-1.html: Added.
              * editing/selection/select-across-readonly-input-2.html: Added.
              * editing/selection/select-across-readonly-input-3.html: Added.
              * editing/selection/select-across-readonly-input-4.html: Added.
              * editing/selection/select-across-readonly-input-5.html: Added.
              * platform/mac/editing/selection/select-across-readonly-input-1-expected.png: Added.
              * platform/mac/editing/selection/select-across-readonly-input-1-expected.txt: Added.
              * platform/mac/editing/selection/select-across-readonly-input-2-expected.png: Added.
              * platform/mac/editing/selection/select-across-readonly-input-2-expected.txt: Added.
              * platform/mac/editing/selection/select-across-readonly-input-3-expected.png: Added.
              * platform/mac/editing/selection/select-across-readonly-input-3-expected.txt: Added.
              * platform/mac/editing/selection/select-across-readonly-input-4-expected.png: Added.
              * platform/mac/editing/selection/select-across-readonly-input-4-expected.txt: Added.
              * platform/mac/editing/selection/select-across-readonly-input-5-expected.png: Added.
              * platform/mac/editing/selection/select-across-readonly-input-5-expected.txt: Added.
              * platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
      2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKit allows selection that crosses the shadow boundary of a readonly input element
              https://bugs.webkit.org/show_bug.cgi?id=60000
      
              The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
              Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
              in its validation process.
      
              Tests: editing/selection/select-across-readonly-input-1.html
                     editing/selection/select-across-readonly-input-2.html
                     editing/selection/select-across-readonly-input-3.html
                     editing/selection/select-across-readonly-input-4.html
                     editing/selection/select-across-readonly-input-5.html
      
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries.
              (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
              * editing/VisibleSelection.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      828bb6b4
  6. 02 May, 2011 1 commit
  7. 22 Apr, 2011 1 commit
  8. 20 Apr, 2011 1 commit
  9. 19 Apr, 2011 1 commit
    • tony@chromium.org's avatar
      2011-04-19 Tony Chang <tony@chromium.org> · 01910772
      tony@chromium.org authored
              Fixing pngs with bad checksum crcs.  There was a 64bit specific bug
              in computing crcs of checksums embedded in png files.  During that
              time, these images were checked in.  Just fixing with the correct
              crcs (the image result itself is unchanged).
      
              * platform/gtk/fast/block/positioning/complex-positioned-movement-expected.png:
              * platform/gtk/fast/text/decorations-transformed-expected.png:
              * platform/mac/compositing/images/content-image-change-expected.png:
              * platform/mac/editing/inserting/editable-inline-element-expected.png:
              * platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.png:
              * platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.png:
              * platform/mac/fast/borders/bidi-002-expected.png:
              * platform/mac/fast/borders/bidi-004-expected.png:
              * platform/mac/fast/borders/bidi-009a-expected.png:
              * platform/mac/fast/box-shadow/inset-expected.png:
              * platform/mac/fast/inline/positioned-object-between-replaced-elements-expected.png:
              * platform/mac/fast/overflow/trailing-float-linebox-expected.png:
              * platform/mac/fullscreen/full-screen-zIndex-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01910772
  10. 12 Apr, 2011 1 commit
  11. 11 Apr, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-04-11 Jia Pu <jpu@apple.com> · 76bec615
      commit-queue@webkit.org authored
              Reviewed by Adele Peterson.
      
              Shouldn't carry out autocorrection when start typing a new word
              https://bugs.webkit.org/show_bug.cgi?id=58241
              <rdar://problem/9264736>
      
              See WebCore/ChangeLog for detail.
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Added.
              * platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1.html: Added.
              * platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Added.
              * platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2.html: Added.
      2011-04-11  Jia Pu  <jpu@apple.com>
      
              Reviewed by Adele Peterson.
      
              Shouldn't carry out autocorrection when start typing a new word
              https://bugs.webkit.org/show_bug.cgi?id=58241
              <rdar://problem/9264736>
      
              Tests: platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1.html
                     platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2.html
      
              In TypingCommand::markMisspellingsAfterTyping(), we want to call Editor::markMisspellingsAfterTypingToWord()
              only when the typing command is an insertion command, and preceding word contains at least one non-whitespace
              character.
      
              * editing/Editor.cpp:
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              * editing/Editor.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::markMisspellingsAfterTyping):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76bec615
  12. 08 Apr, 2011 2 commits
    • rniwa@webkit.org's avatar
      2011-04-08 Ryosuke Niwa <rniwa@webkit.org> · 4f635d62
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              dump-as-markup conversion: editing/pasteboard/paste-text-at-tabspan-001.html and paste-text-at-tabspan-002.html
              https://bugs.webkit.org/show_bug.cgi?id=58081
      
              Converted paste-text-at-tabspan-001.html and paste-text-at-tabspan-002.html to dump-as-markup tests.
              Also explained what to expect in each test.
      
              * editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Added.
              * editing/pasteboard/paste-text-at-tabspan-001.html:
              * editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Added.
              * editing/pasteboard/paste-text-at-tabspan-002.html:
              * platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
              * platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
              * platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
              * platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
              * platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
              * platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
              * platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.png: Removed.
              * platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
              * platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
              * platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
              * platform/qt/editing/pasteboard/paste-text-at-tabspan-001-expected.txt: Removed.
              * platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.checksum: Removed.
              * platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.png: Removed.
              * platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f635d62
    • rniwa@webkit.org's avatar
      2011-04-08 Ryosuke Niwa <rniwa@webkit.org> · 8d2e1c50
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              dump-as-markup conversion: editing/pasteboard/5065605.html and display-block-on-spans.html
              https://bugs.webkit.org/show_bug.cgi?id=58074
      
              Converted 5065605.html and display-block-on-spans.html to dump-as-markup tests.
      
              * editing/pasteboard/5065605-expected.txt: Added.
              * editing/pasteboard/5065605.html:
              * editing/pasteboard/display-block-on-spans-expected.txt: Added.
              * editing/pasteboard/display-block-on-spans.html:
              * platform/chromium-linux/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/5065605-expected.png: Removed.
              * platform/chromium-linux/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/5065605-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/5065605-expected.txt: Removed.
              * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/gtk/editing/pasteboard/5065605-expected.png: Removed.
              * platform/gtk/editing/pasteboard/5065605-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/gtk/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/gtk/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
              * platform/mac-leopard/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/mac-leopard/editing/pasteboard/5065605-expected.png: Removed.
              * platform/mac-leopard/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/mac-leopard/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/mac/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/5065605-expected.png: Removed.
              * platform/mac/editing/pasteboard/5065605-expected.txt: Removed.
              * platform/mac/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/mac/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
              * platform/qt/editing/pasteboard/5065605-expected.txt: Removed.
              * platform/qt/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d2e1c50
  13. 07 Apr, 2011 2 commits
    • rniwa@webkit.org's avatar
      2011-04-07 Ryosuke Niwa <rniwa@webkit.org> · 6683441a
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              dump-as-markup conversion: editing/pasteboard/paste-text-001.html and paste-text-011.html
              https://bugs.webkit.org/show_bug.cgi?id=58078
      
              Converted the tests.
      
              * editing/pasteboard/paste-text-001-expected.txt: Added.
              * editing/pasteboard/paste-text-001.html:
              * editing/pasteboard/paste-text-011-expected.txt: Added.
              * editing/pasteboard/paste-text-011.html:
              * platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png: Removed.
              * platform/chromium-linux/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-001-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-001-expected.txt: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/paste-text-001-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/gtk/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/gtk/editing/pasteboard/paste-text-011-expected.txt: Removed.
              * platform/mac-leopard/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/mac-leopard/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/mac/editing/pasteboard/paste-text-001-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/paste-text-001-expected.png: Removed.
              * platform/mac/editing/pasteboard/paste-text-001-expected.txt: Removed.
              * platform/mac/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/mac/editing/pasteboard/paste-text-011-expected.txt: Removed.
              * platform/qt/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/qt/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/qt/editing/pasteboard/paste-text-011-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6683441a
    • rniwa@webkit.org's avatar
      2011-04-07 Ryosuke Niwa <rniwa@webkit.org> · f2c5f86c
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Convert insert-div-021.html to a dump-as-markup test
              https://bugs.webkit.org/show_bug.cgi?id=58019
      
              Converted the test.
      
              * editing/inserting/insert-div-021-expected.txt: Added.
              * editing/inserting/insert-div-021.html:
              * platform/chromium-linux/editing/inserting/insert-div-021-expected.checksum: Removed.
              * platform/chromium-linux/editing/inserting/insert-div-021-expected.png: Removed.
              * platform/chromium-win/editing/inserting/insert-div-021-expected.checksum: Removed.
              * platform/chromium-win/editing/inserting/insert-div-021-expected.png: Removed.
              * platform/chromium-win/editing/inserting/insert-div-021-expected.txt: Removed.
              * platform/gtk/editing/inserting/insert-div-021-expected.checksum: Removed.
              * platform/gtk/editing/inserting/insert-div-021-expected.png: Removed.
              * platform/gtk/editing/inserting/insert-div-021-expected.txt: Removed.
              * platform/mac/editing/inserting/insert-div-021-expected.checksum: Removed.
              * platform/mac/editing/inserting/insert-div-021-expected.png: Removed.
              * platform/mac/editing/inserting/insert-div-021-expected.txt: Removed.
              * platform/qt/editing/inserting/insert-div-021-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2c5f86c
  14. 30 Mar, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-03-30 Jia Pu <jpu@apple.com> · 2bc9780b
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Autocorrection panel isn't positioned correctly in Safari (mac) when the zooming is not 1x.
              https://bugs.webkit.org/show_bug.cgi?id=57353
              <rdar://problem/9163983>
      
              Updated following test in response to recent change in AppKit spell checker.
      
              * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
              * platform/mac/editing/spelling/delete-autocorrected-word-1.html:
      2011-03-30  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Autocorrection panel isn't positioned correctly in Safari (mac) when the zooming is not 1x.
              https://bugs.webkit.org/show_bug.cgi?id=57353
              <rdar://problem/9163983>
      
              We use Range::textQuads() instead of Range::boundingRect() to compute the position of correction
              panel. The latter function compensates for zooming, which we don't need in this case. We also
              dismiss correction panel when zooming factor is changed. This is done in Frame::setPageAndTextZoomFactors().
      
              * WebCore.exp.in:
              * dom/Range.cpp:
              (WebCore::Range::textQuads):
              * dom/Range.h:
              * editing/Editor.cpp:
              (WebCore::Editor::windowRectForRange):
              * editing/Editor.h:
              * page/Frame.cpp:
              (WebCore::Frame::setPageAndTextZoomFactors):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bc9780b
  15. 24 Mar, 2011 1 commit
    • enrica@apple.com's avatar
      Source/WebCore: Repeated copy and paste-in-place operation results in increasingly verbose HTML. · f8d20922
      enrica@apple.com authored
      <rdar://problem/8690506>
      https://bugs.webkit.org/show_bug.cgi?id=56874
              
      Reviewed by Darin Adler.
      
      When we calculate the style to apply at the insertion point we compare the initial
      style at the insertion point against the style calculated at the span we wrap the
      copied markup fragment with. We could end up with a series of unnecessary spans
      to remove the initial style that simply grow our markup.
      The consists in moving the insertion point outside any inline element that could
      affect the fragment being inserted when we are not pasting and matching the style.
      
      Test: editing/pasteboard/paste-text-with-style.html
      
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::isInlineNodeWithStyle): Added.
      (WebCore::ReplaceSelectionCommand::doApply): Added logic to change the insertion
      point according to the new rules.
      
      LayoutTests: Repeated copy and paste-in-place operation results in increasingly verbose HTML.
      <rdar://problem/8690506>
      https://bugs.webkit.org/show_bug.cgi?id=56874
      
      Reviewed by Darin Adler.
      
      * editing/pasteboard/paste-text-with-style-expected.txt: Added.
      * editing/pasteboard/paste-text-with-style.html: Added.
      The following are new results for existing tests that now produce
      a different markup.
      * platform/mac/editing/pasteboard/5065605-expected.txt:
      * platform/mac/editing/pasteboard/display-block-on-spans-expected.txt:
      * platform/mac/editing/pasteboard/paste-text-011-expected.txt:
      * platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
      * platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8d20922
  16. 23 Mar, 2011 2 commits
    • mihaip@chromium.org's avatar
      2011-03-23 Mihai Parparita <mihaip@chromium.org> · e8379623
      mihaip@chromium.org authored
              Fix more tests for Chromium Snow Leopard by promoting chromium-mac/
              results to mac-leopard/ where possible.
      
              * platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum.
              * platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png.
              * platform/chromium-mac-leopard/fast/box-shadow/box-shadow-transformed-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum.
              * platform/chromium-mac-leopard/fast/box-shadow/box-shadow-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png.
              * platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Removed.
              * platform/chromium-mac/css1/text_properties/text_indent-expected.png: Removed.
              * platform/chromium-mac/css1/units/length_units-expected.checksum: Removed.
              * platform/chromium-mac/css1/units/length_units-expected.png: Removed.
              * platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum:
              * platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png:
              * platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum:
              * platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
              * platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
              * platform/chromium-mac/media/media-document-audio-repaint-expected.png:
              * platform/mac-leopard/css1/text_properties/text_indent-expected.checksum:
              * platform/mac-leopard/css1/text_properties/text_indent-expected.png:
              * platform/mac-leopard/css1/units/length_units-expected.checksum:
              * platform/mac-leopard/css1/units/length_units-expected.png:
              * platform/mac-leopard/fast/css-generated-content/table-row-before-after-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.checksum.
              * platform/mac-leopard/fast/css-generated-content/table-row-before-after-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.png.
              * platform/mac-leopard/fast/multicol/scrolling-overflow-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/scrolling-overflow-expected.checksum.
              * platform/mac-leopard/fast/multicol/scrolling-overflow-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png.
              * platform/mac/css1/text_properties/text_indent-expected.checksum:
              * platform/mac/css1/text_properties/text_indent-expected.png:
              * platform/mac/css1/units/length_units-expected.checksum:
              * platform/mac/css1/units/length_units-expected.png:
              * platform/mac/editing/selection/inline-closest-leaf-child-expected.checksum:
              * platform/mac/editing/selection/inline-closest-leaf-child-expected.png:
              * platform/mac/fast/box-shadow/box-shadow-transformed-expected.checksum:
              * platform/mac/fast/box-shadow/box-shadow-transformed-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8379623
    • mihaip@chromium.org's avatar
      2011-03-23 Mihai Parparita <mihaip@chromium.org> · cb97abfe
      mihaip@chromium.org authored
              Update pixel results for Snow Leopard after r80755. Where possible,
              chromium-mac results were promoted to mac-leopard, except for cases
              where Chromium behavior due to bug 52335 or form control rendering.
      
              * platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum.
              * platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/block/margin-collapse/103-expected.png.
              * platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum.
              * platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png.
              * platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum.
              * platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png.
              * platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Removed.
              * platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Removed.
              * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum: Removed.
              * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Removed.
              * platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Removed.
              * platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Removed.
              * platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Removed.
              * platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Removed.
              * platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum:
              * platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png:
              * platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum: Removed.
              * platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Removed.
              * platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
              * platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
              * platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum: Removed.
              * platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Removed.
              * platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Removed.
              * platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Removed.
              * platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Removed.
              * platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.png: Removed.
              * platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Removed.
              * platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
              * platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Removed.
              * platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Removed.
              * platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Removed.
              * platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Removed.
              * platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Removed.
              * platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Removed.
              * platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Removed.
              * platform/chromium-mac/editing/selection/caret-rtl-expected.png: Removed.
              * platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Removed.
              * platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Removed.
              * platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
              * platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
              * platform/chromium-mac/fast/css/ex-after-font-variant-expected.checksum: Removed.
              * platform/chromium-mac/fast/css/ex-after-font-variant-expected.png: Removed.
              * platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.checksum: Removed.
              * platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png: Removed.
              * platform/chromium-mac/fast/lists/008-expected.checksum: Removed.
              * platform/chromium-mac/fast/lists/008-expected.png: Removed.
              * platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Removed.
              * platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Removed.
              * platform/chromium-mac/fast/overflow/overflow-rtl-expected.checksum: Removed.
              * platform/chromium-mac/fast/overflow/overflow-rtl-expected.png: Removed.
              * platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.checksum: Removed.
              * platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png: Removed.
              * platform/chromium-mac/fast/replaced/width100percent-radio-expected.checksum: Removed.
              * platform/chromium-mac/fast/replaced/width100percent-radio-expected.png: Removed.
              * platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Removed.
              * platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Removed.
              * platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
              * platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
              * platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
              * platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
              * platform/mac-leopard/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum:
              * platform/mac-leopard/css2.1/t040302-c61-ex-len-00-b-a-expected.png:
              * platform/mac-leopard/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum:
              * platform/mac-leopard/css2.1/t040302-c61-rel-len-00-b-ag-expected.png:
              * platform/mac-leopard/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum:
              * platform/mac-leopard/css2.1/t100801-c544-valgn-01-d-ag-expected.png:
              * platform/mac-leopard/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum:
              * platform/mac-leopard/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png:
              * platform/mac-leopard/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum:
              * platform/mac-leopard/css2.1/t1507-c526-font-sz-02-b-a-expected.png:
              * platform/mac-leopard/css2.1/t1601-c547-indent-00-b-a-expected.checksum:
              * platform/mac-leopard/css2.1/t1601-c547-indent-00-b-a-expected.png:
              * platform/mac-leopard/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum:
              * platform/mac-leopard/css2.1/t1604-c541-word-sp-00-b-a-expected.png:
              * platform/mac-leopard/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum:
              * platform/mac-leopard/css2.1/t1604-c542-letter-sp-00-b-a-expected.png:
              * platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum:
              * platform/mac-leopard/editing/selection/caret-rtl-2-expected.png:
              * platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum:
              * platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.png:
              * platform/mac-leopard/editing/selection/caret-rtl-expected.checksum:
              * platform/mac-leopard/editing/selection/caret-rtl-expected.png:
              * platform/mac-leopard/editing/selection/caret-rtl-right-expected.checksum:
              * platform/mac-leopard/editing/selection/caret-rtl-right-expected.png:
              * platform/mac-leopard/fast/css/ex-after-font-variant-expected.checksum:
              * platform/mac-leopard/fast/css/ex-after-font-variant-expected.png:
              * platform/mac-leopard/fast/css/non-standard-checkbox-size-expected.checksum:
              * platform/mac-leopard/fast/css/non-standard-checkbox-size-expected.png:
              * platform/mac-leopard/fast/lists/008-expected.checksum:
              * platform/mac-leopard/fast/lists/008-expected.png:
              * platform/mac-leopard/fast/media/mq-relative-constraints-08-expected.checksum:
              * platform/mac-leopard/fast/media/mq-relative-constraints-08-expected.png:
              * platform/mac-leopard/fast/overflow/overflow-rtl-expected.checksum:
              * platform/mac-leopard/fast/overflow/overflow-rtl-expected.png:
              * platform/mac-leopard/fast/replaced/width100percent-checkbox-expected.checksum:
              * platform/mac-leopard/fast/replaced/width100percent-checkbox-expected.png:
              * platform/mac-leopard/fast/replaced/width100percent-radio-expected.checksum:
              * platform/mac-leopard/fast/replaced/width100percent-radio-expected.png:
              * platform/mac-leopard/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum:
              * platform/mac-leopard/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
              * platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum:
              * platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png:
              * platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum:
              * platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png:
              * platform/mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum:
              * platform/mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png:
              * platform/mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum:
              * platform/mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png:
              * platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
              * platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
              * platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum:
              * platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png:
              * platform/mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum:
              * platform/mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png:
              * platform/mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum:
              * platform/mac/css2.1/t1601-c547-indent-00-b-a-expected.png:
              * platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum:
              * platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png:
              * platform/mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum:
              * platform/mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png:
              * platform/mac/editing/selection/caret-ltr-2-expected.checksum:
              * platform/mac/editing/selection/caret-ltr-2-expected.png:
              * platform/mac/editing/selection/caret-ltr-2-left-expected.checksum:
              * platform/mac/editing/selection/caret-ltr-2-left-expected.png:
              * platform/mac/editing/selection/caret-ltr-expected.checksum:
              * platform/mac/editing/selection/caret-ltr-expected.png:
              * platform/mac/editing/selection/caret-ltr-right-expected.checksum:
              * platform/mac/editing/selection/caret-ltr-right-expected.png:
              * platform/mac/editing/selection/caret-rtl-2-expected.checksum:
              * platform/mac/editing/selection/caret-rtl-2-expected.png:
              * platform/mac/editing/selection/caret-rtl-2-left-expected.checksum:
              * platform/mac/editing/selection/caret-rtl-2-left-expected.png:
              * platform/mac/editing/selection/caret-rtl-expected.checksum:
              * platform/mac/editing/selection/caret-rtl-expected.png:
              * platform/mac/editing/selection/caret-rtl-right-expected.checksum:
              * platform/mac/editing/selection/caret-rtl-right-expected.png:
              * platform/mac/fast/block/margin-collapse/103-expected.checksum:
              * platform/mac/fast/block/margin-collapse/103-expected.png:
              * platform/mac/fast/css/ex-after-font-variant-expected.checksum:
              * platform/mac/fast/css/ex-after-font-variant-expected.png:
              * platform/mac/fast/css/non-standard-checkbox-size-expected.checksum:
              * platform/mac/fast/css/non-standard-checkbox-size-expected.png:
              * platform/mac/fast/lists/008-expected.checksum:
              * platform/mac/fast/lists/008-expected.png:
              * platform/mac/fast/media/mq-relative-constraints-08-expected.checksum:
              * platform/mac/fast/media/mq-relative-constraints-08-expected.png:
              * platform/mac/fast/overflow/overflow-rtl-expected.checksum:
              * platform/mac/fast/overflow/overflow-rtl-expected.png:
              * platform/mac/fast/replaced/width100percent-checkbox-expected.checksum:
              * platform/mac/fast/replaced/width100percent-checkbox-expected.png:
              * platform/mac/fast/replaced/width100percent-radio-expected.checksum:
              * platform/mac/fast/replaced/width100percent-radio-expected.png:
              * platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum:
              * platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
              * platform/mac/tables/mozilla/bugs/bug1318-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug1318-expected.png:
              * platform/mac/tables/mozilla/bugs/bug4527-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug4527-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb97abfe
  17. 21 Mar, 2011 2 commits
    • tony@chromium.org's avatar
      2011-03-21 Tony Chang <tony@chromium.org> · fd0810d8
      tony@chromium.org authored
              Reviewed by Eric Seidel.
      
              Convert fake-drag into a dumpAsText test and remove 1s timeout
              https://bugs.webkit.org/show_bug.cgi?id=56674
      
              This test was added with eventSender, so there was no leapForward
              at the time.  Also convert to dumpAsText while I'm here.
      
              * editing/selection/fake-drag.html:
              * platform/chromium-linux/editing/selection/fake-drag-expected.checksum: Removed.
              * platform/chromium-linux/editing/selection/fake-drag-expected.png: Removed.
              * platform/chromium-win/editing/selection/fake-drag-expected.checksum: Removed.
              * platform/chromium-win/editing/selection/fake-drag-expected.png: Removed.
              * platform/chromium-win/editing/selection/fake-drag-expected.txt:
              * platform/gtk/editing/selection/fake-drag-expected.checksum: Removed.
              * platform/gtk/editing/selection/fake-drag-expected.png: Removed.
              * platform/gtk/editing/selection/fake-drag-expected.txt: Removed.
              * platform/mac-leopard/editing/selection/fake-drag-expected.checksum: Removed.
              * platform/mac-leopard/editing/selection/fake-drag-expected.png: Removed.
              * platform/mac/editing/selection/fake-drag-expected.checksum: Removed.
              * platform/mac/editing/selection/fake-drag-expected.png: Removed.
              * platform/mac/editing/selection/fake-drag-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd0810d8
    • commit-queue@webkit.org's avatar
      2011-03-21 Chang Shu <cshu@webkit.org> · f52c4946
      commit-queue@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              REGRESSION (r79953): Can't type in MS Outlook 2011
              https://bugs.webkit.org/show_bug.cgi?id=56665
      
              Restore the expected result before r79953. r79953 changed behavior slightly in function
              finishedLoadingWithDataSource in file mac/WebView/WebHTMLRepresentation.mm, where
              core(webFrame)->editor()->applyEditingStyleToBodyElement() was called but not before r79953
              or after this patch.
      
              * platform/mac/editing/selection/designmode-no-caret-expected.txt:
      2011-03-21  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              REGRESSION (r79953): Can't type in MS Outlook 2011
              https://bugs.webkit.org/show_bug.cgi?id=56665
      
              r79953 removed the WebView level editablity which is persistent no matter whether
              underlying document itself is changed and editability gets lost. The resolution is to
              set this WebView editable value to WebCore. This avoids the callback from WebCore to
              WebKit which was the main goal in r79953 to improve performance.
      
              * WebCore.exp.in:
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::isReadOnly):
              * dom/Node.cpp:
              (WebCore::Node::isContentEditable):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::setSelectionFromNone):
              * page/DragController.cpp:
              (WebCore::DragController::operationForLoad):
              * page/Page.cpp:
              (WebCore::Page::Page):
              * page/Page.h:
              (WebCore::Page::setEditable):
              (WebCore::Page::isEditable):
      2011-03-21  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              REGRESSION (r79953): Can't type in MS Outlook 2011
              https://bugs.webkit.org/show_bug.cgi?id=56665
      
              r79953 removed the WebView level editablity which is persistent no matter whether
              underlying document itself is changed and editability gets lost. The resolution is to
              set this WebView editable value to WebCore. This avoids the callback from WebCore to
              WebKit which was the main goal in r79953 to improve performance.
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_get_editable):
              (webkit_web_view_set_editable):
      2011-03-21  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              REGRESSION (r79953): Can't type in MS Outlook 2011
              https://bugs.webkit.org/show_bug.cgi?id=56665
      
              r79953 removed the WebView level editablity which is persistent no matter whether
              underlying document itself is changed and editability gets lost. The resolution is to
              set this WebView editable value to WebCore. This avoids the callback from WebCore to
              WebKit which was the main goal in r79953 to improve performance.
      
              * WebView/WebView.mm:
              (-[WebView setEditable:]):
              (-[WebView isEditable]):
      2011-03-21  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              REGRESSION (r79953): Can't type in MS Outlook 2011
              https://bugs.webkit.org/show_bug.cgi?id=56665
      
              r79953 removed the WebView level editablity which is persistent no matter whether
              underlying document itself is changed and editability gets lost. The resolution is to
              set this WebView editable value to WebCore. This avoids the callback from WebCore to
              WebKit which was the main goal in r79953 to improve performance.
      
              * Api/qwebpage.cpp:
              (QWebPage::setContentEditable):
              (QWebPage::isContentEditable):
      2011-03-21  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              REGRESSION (r79953): Can't type in MS Outlook 2011
              https://bugs.webkit.org/show_bug.cgi?id=56665
      
              r79953 removed the WebView level editablity which is persistent no matter whether
              underlying document itself is changed and editability gets lost. The resolution is to
              set this WebView editable value to WebCore. This avoids the callback from WebCore to
              WebKit which was the main goal in r79953 to improve performance.
      
              * WebFrame.cpp:
              (wxWebFrame::MakeEditable):
              (wxWebFrame::IsEditable):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f52c4946
  18. 17 Mar, 2011 1 commit
  19. 14 Mar, 2011 3 commits
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · aea439d1
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              EventHandler calls shouldChangeSelection needlessly
              https://bugs.webkit.org/show_bug.cgi?id=56324
      
              Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and
              avoided calling shouldChangeSelection and setSelection when the existing
              selection is identical to that of new selection.
      
              * page/EventHandler.cpp:
              (WebCore::setSelectionIfNeeded): Extracted.
              (WebCore::setNonDirectionalSelectionIfNeeded): Extracted.
              (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above.
              (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto.
              (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto.
              (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto.
              (WebCore::EventHandler::updateSelectionForMouseDrag): Ditto.
              (WebCore::EventHandler::handleMouseReleaseEvent): Ditto.
      2011-03-14  Anton Muhin  <antonm@chromium.org>
      
              Reviewed by Adam Barth.
      
              [v8] Rework object group building.
              https://bugs.webkit.org/show_bug.cgi?id=55399
      
              Instead of going top-down (from owner to owned elements), go up---from objects
              to their group ids.  That fits better to v8's object grouping model and guarantees
              that each wrapper belongs to the single group.
      
              Alas, this cannot be implemented for one kind of objects---CSSProperties.
      
              Part of core GC algorithm and tested extensively by exisiting layout tests.
      
              * platform/chromium/test_expectations.txt: Temporary suppress text differences.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aea439d1
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · 1de9ea46
      rniwa@webkit.org authored
              Mac pixel rebaselines for r81053.
      
              * platform/mac/editing/selection/drag-select-1-expected.checksum:
              * platform/mac/editing/selection/drag-select-1-expected.png:
              * platform/mac/editing/selection/fake-drag-expected.checksum:
              * platform/mac/editing/selection/fake-drag-expected.png:
              * platform/mac/fast/text/atsui-rtl-override-selection-expected.checksum:
              * platform/mac/fast/text/atsui-rtl-override-selection-expected.png:
              * platform/mac/svg/custom/mouse-move-on-svg-container-expected.checksum:
              * platform/mac/svg/custom/mouse-move-on-svg-container-expected.png:
              * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
              * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
              * platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
              * platform/mac/svg/custom/mouse-move-on-svg-root-expected.png:
              * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
              * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1de9ea46
    • rniwa@webkit.org's avatar
      2011-03-11 Ryosuke Niwa <rniwa@webkit.org> · f018c464
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              Selection uses first mousemove's localRect instead of that of mousedown
              https://bugs.webkit.org/show_bug.cgi?id=56213
      
              Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent
              using the mouse coordinates of the mousedown event that started the drag.
      
              Test: editing/selection/drag-select-rapidly.html
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMouseDraggedEvent):
      2011-03-11  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Tony Chang.
      
              Selection uses first mousemove's localRect instead of that of mousedown
              https://bugs.webkit.org/show_bug.cgi?id=56213
      
              Added a test to ensure the selection start is computed using the mouse coordinates passed down
              to the corresponding mousedown event instead of that of the first mousemove event.
      
              The test is co-authored by Evan Martin.
      
              * editing/selection/anchor-focus2-expected.txt: Editing delegate changes.
              * editing/selection/anchor-focus3-expected.txt: Ditto.
              * editing/selection/drag-select-rapidly-expected.txt: Added.
              * editing/selection/drag-select-rapidly.html: Added.
              * platform/mac/editing/selection/drag-select-1-expected.txt: Selects the correct range of text.
              * platform/mac/editing/selection/fake-drag-expected.txt: Ditto.
              * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f018c464
  20. 11 Mar, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-03-11 Ryosuke Niwa <rniwa@webkit.org> · 5aeaf45c
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              drag-text-delay.html should be a dump as text test
              https://bugs.webkit.org/show_bug.cgi?id=56223
      
              Converted the test to a dump as text. Also reorganized the test code and added more descriptions.
      
              * editing/selection/drag-text-delay-expected.txt:
              * editing/selection/drag-text-delay.html:
              * platform/chromium-linux/editing/selection/drag-text-delay-expected.checksum: Removed.
              * platform/chromium-linux/editing/selection/drag-text-delay-expected.png: Removed.
              * platform/chromium-win/editing/selection/drag-text-delay-expected.checksum: Removed.
              * platform/chromium-win/editing/selection/drag-text-delay-expected.png: Removed.
              * platform/chromium-win/editing/selection/drag-text-delay-expected.txt: Removed.
              * platform/gtk/editing/selection/drag-text-delay-expected.checksum: Removed.
              * platform/gtk/editing/selection/drag-text-delay-expected.png: Removed.
              * platform/gtk/editing/selection/drag-text-delay-expected.txt: Removed.
              * platform/mac/editing/selection/drag-text-delay-expected.checksum: Removed.
              * platform/mac/editing/selection/drag-text-delay-expected.png: Removed.
              * platform/mac/editing/selection/drag-text-delay-expected.txt:
              * platform/win/editing/selection/drag-text-delay-expected.checksum: Removed.
              * platform/win/editing/selection/drag-text-delay-expected.png: Removed.
              * platform/win/editing/selection/drag-text-delay-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5aeaf45c
  21. 10 Mar, 2011 2 commits
    • ap@apple.com's avatar
      2011-03-10 Alexey Proskuryakov <ap@apple.com> · e0460fd0
      ap@apple.com authored
              Reviewed by Dan Bernstein.
      
              Backspace deletes all non-BMP symbols at once, and then some
              https://bugs.webkit.org/show_bug.cgi?id=55971
              <rdar://problem/8725312>
      
              * platform/mac/editing/input/insert-delete-smp-symbol-expected.txt: Added.
              * platform/mac/editing/input/insert-delete-smp-symbol.html: Added.
      2011-03-10  Alexey Proskuryakov  <ap@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Backspace deletes all non-BMP symbols at once, and then some
              https://bugs.webkit.org/show_bug.cgi?id=55971
              <rdar://problem/8725312>
      
              Test: platform/mac/editing/input/insert-delete-smp-symbol.html
      
              * rendering/RenderText.cpp:
              (WebCore::isMark): This matches what Core Foundation does for all characters that I tested.
              (WebCore::RenderText::previousOffsetForBackwardDeletion): Changed to use isMark().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0460fd0
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=47157 · 6dab2580
      hyatt@apple.com authored
              
      Reviewed by Simon Fraser.
      
      CSS2.1 test suite failures because the ex unit is broken with the Ahem font.
              
      Remove the code that tries to also include the maxX of the glyph bounds for the
      'x' glyph, since it just causes the x-height to be way too large in cases where the 'x' glyph extends
      below the baseline.
      
      Remove the Apple Symbol hack for ex units, since the person who added that was confused by another
      issue, namely that CGFontGetXHeight wasn't being properly multiplied by the pointSize.  That's why
      the value was too small.  Patched the code to just multiply by pointSize and took out the hack.
              
      Fix causes many tests in the css2.1 directory to progress, so no new tests required.  Many other
      layout tests change because the xHeight for Lucida Grande gets smaller by a little bit, and radio
      buttons use ex horizontal margins by default.
      
      Source/WebCore: 
      
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::platformInit):
      
      LayoutTests: 
      
      * platform/mac/accessibility/radio-button-group-members-expected.txt:
      * platform/mac/css1/box_properties/acid_test-expected.txt:
      * platform/mac/css1/font_properties/font_size-expected.txt:
      * platform/mac/css1/text_properties/line_height-expected.txt:
      * platform/mac/css1/text_properties/text_indent-expected.txt:
      * platform/mac/css1/units/length_units-expected.txt:
      * platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
      * platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt:
      * platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
      * platform/mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt:
      * platform/mac/css2.1/t100801-c544-valgn-01-d-ag-expected.txt:
      * platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
      * platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.txt:
      * platform/mac/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
      * platform/mac/css2.1/t1601-c547-indent-00-b-a-expected.txt:
      * platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.txt:
      * platform/mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt:
      * platform/mac/editing/selection/caret-ltr-2-expected.txt:
      * platform/mac/editing/selection/caret-ltr-2-left-expected.txt:
      * platform/mac/editing/selection/caret-ltr-expected.txt:
      * platform/mac/editing/selection/caret-ltr-right-expected.txt:
      * platform/mac/editing/selection/caret-rtl-2-expected.txt:
      * platform/mac/editing/selection/caret-rtl-2-left-expected.txt:
      * platform/mac/editing/selection/caret-rtl-expected.txt:
      * platform/mac/editing/selection/caret-rtl-right-expected.txt:
      * platform/mac/fast/block/basic/011-expected.txt:
      * platform/mac/fast/block/margin-collapse/103-expected.txt:
      * platform/mac/fast/css/ex-after-font-variant-expected.txt:
      * platform/mac/fast/css/non-standard-checkbox-size-expected.txt:
      * platform/mac/fast/forms/001-expected.txt:
      * platform/mac/fast/forms/basic-inputs-expected.txt:
      * platform/mac/fast/forms/box-shadow-override-expected.txt:
      * platform/mac/fast/forms/checkbox-radio-onchange-expected.txt:
      * platform/mac/fast/forms/file-input-disabled-expected.txt:
      * platform/mac/fast/forms/form-element-geometry-expected.txt:
      * platform/mac/fast/forms/formmove-expected.txt:
      * platform/mac/fast/forms/formmove2-expected.txt:
      * platform/mac/fast/forms/indeterminate-expected.txt:
      * platform/mac/fast/forms/input-appearance-height-expected.txt:
      * platform/mac/fast/forms/input-value-expected.txt:
      * platform/mac/fast/forms/minWidthPercent-expected.txt:
      * platform/mac/fast/forms/radio-attr-order-expected.txt:
      * platform/mac/fast/forms/radio-nested-labels-expected.txt:
      * platform/mac/fast/forms/radio_checked-expected.txt:
      * platform/mac/fast/forms/radio_checked_dynamic-expected.txt:
      * platform/mac/fast/inline/positionedLifetime-expected.txt:
      * platform/mac/fast/lists/008-expected.txt:
      * platform/mac/fast/lists/008-vertical-expected.txt:
      * platform/mac/fast/media/mq-relative-constraints-08-expected.txt:
      * platform/mac/fast/overflow/overflow-rtl-expected.txt:
      * platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt:
      * platform/mac/fast/parser/bad-xml-slash-expected.txt:
      * platform/mac/fast/replaced/replaced-breaking-expected.txt:
      * platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
      * platform/mac/fast/replaced/width100percent-radio-expected.txt:
      * platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
      * platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
      * platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
      * platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
      * platform/mac/svg/custom/alignment-baseline-modes-expected.txt:
      * platform/mac/svg/custom/dominant-baseline-modes-expected.txt:
      * platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
      * platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
      * platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
      * platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
      * svg/custom/invalid-text-content-expected.png:
      * svg/custom/text-zoom-expected.png:
      * svg/custom/use-clipped-transform-expected.png:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dab2580
  22. 08 Mar, 2011 1 commit
    • tony@chromium.org's avatar
      2011-03-08 Tony Chang <tony@chromium.org> · 4be37173
      tony@chromium.org authored
              Unreviewed, remove png layout test results that don't have
              corresponding checksum files.  I checked a few of these and they
              were cases where the .checksum was removed and the .png forgotten.
      
              * platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
              * platform/gtk/fast/encoding/utf-16-no-bom-expected.png: Removed.
              * platform/gtk/svg/hixie/error/004-expected.png: Removed.
              * platform/gtk/svg/hixie/error/005-expected.png: Removed.
              * platform/mac-leopard/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
              * platform/mac-leopard/fast/encoding/utf-16-no-bom-expected.png: Removed.
              * platform/mac-leopard/svg/hixie/error/004-expected.png: Removed.
              * platform/mac-leopard/svg/hixie/error/005-expected.png: Removed.
              * platform/mac/editing/selection/contenteditable-click-outside-expected.png: Removed.
              * platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
              * platform/mac/fast/dynamic/8952-reduction-expected.png: Removed.
              * platform/mac/fast/encoding/utf-16-no-bom-expected.png: Removed.
              * platform/mac/fast/js/Plug-ins-expected.png: Removed.
              * platform/mac/fast/table/row-height-recalc2-expected.png: Removed.
              * platform/mac/svg/hixie/error/004-expected.png: Removed.
              * platform/mac/svg/hixie/error/005-expected.png: Removed.
              * platform/qt/fast/table/row-height-recalc2-expected.png: Removed.
              * platform/win/fast/table/row-height-recalc2-expected.png: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4be37173
  23. 03 Mar, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-03-03 Jia Pu <jpu@apple.com> · 574fd037
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              On Mac OS X, spelling suggestion panel stops showing up after change set 80121
              https://bugs.webkit.org/show_bug.cgi?id=55628
      
              Rebaselined tests affected by changeset 80121.
      
              * platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
              * platform/mac/editing/spelling/autocorrection-delete-expected.txt:
              * platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
              * platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
              * platform/mac/editing/spelling/autocorrection-simple-expected.txt:
              * platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
              * platform/mac/editing/spelling/click-autocorrected-word.html:
              * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
              * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum:
              * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
              * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
              * platform/mac/editing/spelling/delete-into-autocorrected-word.html:
              * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.checksum:
              * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
              * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
              * platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
              * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.checksum:
              * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
              * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
              * platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
              * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.checksum:
              * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
              * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
              * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:
              * platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt:
      2011-03-03  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              On Mac OS X, spelling suggestion panel stops showing up after change set 80121
              https://bugs.webkit.org/show_bug.cgi?id=55628
      
              Removed a call to stopCorrectionPanelTimer() to fix a regression introduced by changeset 80121.
      
              * editing/Editor.cpp:
              (WebCore::Editor::appliedEditing):
              * manual-tests/autocorrection/autocorrection-contraction.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      574fd037
  24. 02 Mar, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-03-01 Ryosuke Niwa <rniwa@webkit.org> · 1714e2e0
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Assertion failure after removing a selection in keydown handler
              https://bugs.webkit.org/show_bug.cgi?id=51389
      
              Added tests to ensure WebKit updates offset properly when deleting date
              to editing/selection/character-data-mutation.html.
      
              Added a test to ensure WebKit clears composition marks inside an input
              element when the value is set programatically.
      
              Many tests are rebaselined due to selection changed caused by the patch
              and additional respondToChangedSelection calls.
      
              * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
              * editing/deleting/delete-by-word-001-expected.txt:
              * editing/deleting/delete-by-word-002-expected.txt:
              * editing/deleting/delete-ligature-001-expected.txt:
              * editing/deleting/delete-ligature-002-expected.txt:
              * editing/deleting/delete-ligature-003-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/skip-virama-001-expected.txt:
              * editing/execCommand/createLink-expected.txt:
              * editing/execCommand/hilitecolor-expected.txt:
              * editing/execCommand/outdent-nested-lists-1-expected.txt:
              * editing/execCommand/unlink-expected.txt:
              * editing/input/setting-input-value-cancel-ime-composition-expected.txt: Added.
              * editing/input/setting-input-value-cancel-ime-composition.html: Added.
              * editing/inserting/insert-thai-characters-001-expected.txt:
              * editing/pasteboard/copy-in-password-field-expected.txt:
              * editing/pasteboard/paste-into-anchor-text-expected.txt:
              * editing/selection/character-data-mutation-expected.txt:
              * editing/selection/character-data-mutation.html:
              * editing/style/remove-underline-from-stylesheet-expected.txt:
              * editing/style/style-3690704-fix-expected.txt:
              * editing/style/typing-style-003-expected.txt:
              * editing/undo/redo-style-expected.txt:
              * platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt:
              * platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
              * platform/mac/editing/deleting/delete-3608430-fix-expected.txt:
              * platform/mac/editing/deleting/delete-3608445-fix-expected.txt:
              * platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
              * platform/mac/editing/deleting/delete-3775172-fix-expected.txt:
              * platform/mac/editing/deleting/delete-3800834-fix-expected.txt:
              * platform/mac/editing/deleting/delete-3857753-fix-expected.txt:
              * platform/mac/editing/deleting/delete-3928305-fix-expected.txt:
              * platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
              * platform/mac/editing/deleting/delete-after-span-ws-001-expected.txt:
              * platform/mac/editing/deleting/delete-and-undo-expected.txt:
              * platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-012-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-013-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-014-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-015-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-016-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
              * platform/mac/editing/deleting/delete-block-table-expected.txt:
              * platform/mac/editing/deleting/delete-br-007-expected.txt:
              * platform/mac/editing/deleting/delete-character-001-expected.txt:
              * platform/mac/editing/deleting/delete-hr-expected.txt:
              * platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
              * platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
              * platform/mac/editing/deleting/delete-listitem-001-expected.txt:
              * platform/mac/editing/deleting/delete-listitem-002-expected.txt:
              * platform/mac/editing/deleting/delete-selection-001-expected.txt:
              * platform/mac/editing/deleting/delete-tab-001-expected.txt:
              * platform/mac/editing/deleting/delete-tab-002-expected.txt:
              * platform/mac/editing/deleting/delete-tab-003-expected.txt:
              * platform/mac/editing/deleting/delete-tab-004-expected.txt:
              * platform/mac/editing/deleting/delete-trailing-ws-001-expected.txt:
              * platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
              * platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
              * platform/mac/editing/deleting/delete-ws-fixup-003-expected.txt:
              * platform/mac/editing/deleting/delete-ws-fixup-004-expected.txt:
              * platform/mac/editing/deleting/forward-delete-expected.txt:
              * platform/mac/editing/deleting/list-item-1-expected.txt:
              * platform/mac/editing/deleting/paragraph-in-preserveNewline-expected.txt:
              * platform/mac/editing/deleting/whitespace-pre-1-expected.txt:
              * platform/mac/editing/execCommand/find-after-replace-expected.txt:
              * platform/mac/editing/execCommand/insertHorizontalRule-expected.txt:
              * platform/mac/editing/execCommand/paste-1-expected.txt:
              * platform/mac/editing/execCommand/paste-2-expected.txt:
              * platform/mac/editing/input/5576619-expected.txt:
              * platform/mac/editing/input/emacs-ctrl-o-expected.txt:
              * platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
              * platform/mac/editing/input/text-input-controller-expected.txt:
              * platform/mac/editing/inserting/4278698-expected.txt:
              * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
              * platform/mac/editing/inserting/insert-3654864-fix-expected.txt:
              * platform/mac/editing/inserting/insert-3851164-fix-expected.txt:
              * platform/mac/editing/inserting/insert-after-delete-001-expected.txt:
              * platform/mac/editing/inserting/insert-br-003-expected.txt:
              * platform/mac/editing/inserting/insert-br-006-expected.txt:
              * platform/mac/editing/inserting/insert-br-007-expected.txt:
              * platform/mac/editing/inserting/insert-br-008-expected.txt:
              * platform/mac/editing/inserting/insert-br-009-expected.txt:
              * platform/mac/editing/inserting/insert-br-at-tabspan-002-expected.txt:
              * platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
              * platform/mac/editing/inserting/insert-div-003-expected.txt:
              * platform/mac/editing/inserting/insert-div-006-expected.txt:
              * platform/mac/editing/inserting/insert-div-007-expected.txt:
              * platform/mac/editing/inserting/insert-div-008-expected.txt:
              * platform/mac/editing/inserting/insert-div-024-expected.txt:
              * platform/mac/editing/inserting/insert-div-025-expected.txt:
              * platform/mac/editing/inserting/insert-space-in-empty-doc-expected.txt:
              * platform/mac/editing/inserting/insert-tab-003-expected.txt:
              * platform/mac/editing/inserting/insert-text-at-tabspan-001-expected.txt:
              * platform/mac/editing/inserting/insert-text-at-tabspan-002-expected.txt:
              * platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
              * platform/mac/editing/inserting/multiple-lines-selected-expected.txt:
              * platform/mac/editing/inserting/paragraph-separator-03-expected.txt:
              * platform/mac/editing/inserting/redo-expected.txt:
              * platform/mac/editing/inserting/return-key-with-selection-003-expected.txt:
              * platform/mac/editing/inserting/typing-001-expected.txt:
              * platform/mac/editing/inserting/typing-002-expected.txt:
              * platform/mac/editing/inserting/typing-003-expected.txt:
              * platform/mac/editing/inserting/typing-around-br-001-expected.txt:
              * platform/mac/editing/inserting/typing-around-image-001-expected.txt:
              * platform/mac/editing/pasteboard/4076267-2-expected.txt:
              * platform/mac/editing/pasteboard/4076267-3-expected.txt:
              * platform/mac/editing/pasteboard/4076267-expected.txt:
              * platform/mac/editing/pasteboard/4700297-expected.txt:
              * platform/mac/editing/pasteboard/8145-3-expected.txt:
              * platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
              * platform/mac/editing/pasteboard/cut-text-001-expected.txt:
              * platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
              * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
              * platform/mac/editing/pasteboard/interchange-newline-1-expected.txt:
              * platform/mac/editing/pasteboard/interchange-newline-2-expected.txt:
              * platform/mac/editing/pasteboard/merge-end-1-expected.txt:
              * platform/mac/editing/pasteboard/merge-end-2-expected.txt:
              * platform/mac/editing/pasteboard/merge-end-3-expected.txt:
              * platform/mac/editing/pasteboard/merge-end-4-expected.txt:
              * platform/mac/editing/pasteboard/merge-end-5-expected.txt:
              * platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
              * platform/mac/editing/pasteboard/merge-end-borders-expected.txt:
              * platform/mac/editing/pasteboard/merge-end-list-expected.txt:
              * platform/mac/editing/pasteboard/merge-end-table-expected.txt:
              * platform/mac/editing/pasteboard/paste-line-endings-007-expected.txt:
              * platform/mac/editing/pasteboard/paste-line-endings-008-expected.txt:
              * platform/mac/editing/pasteboard/paste-line-endings-009-expected.txt:
              * platform/mac/editing/pasteboard/paste-line-endings-010-expected.txt:
              * platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
              * platform/mac/editing/pasteboard/paste-pre-001-expected.txt:
              * platform/mac/editing/pasteboard/paste-pre-002-expected.txt:
              * platform/mac/editing/pasteboard/paste-table-003-expected.txt:
              * platform/mac/editing/pasteboard/paste-table-cells-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-001-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-002-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-003-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-004-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-005-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-008-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-009-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-019-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
              * platform/mac/editing/pasteboard/paste-xml-expected.txt:
              * platform/mac/editing/pasteboard/pasting-object-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-003-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-004-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-006-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
              * platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
              * platform/mac/editing/selection/replace-selection-1-expected.txt:
              * platform/mac/editing/selection/select-all-iframe-expected.txt:
              * platform/mac/editing/spelling/spelling-expected.txt:
              * platform/mac/editing/style/relative-font-size-change-002-expected.txt:
              * platform/mac/editing/style/relative-font-size-change-003-expected.txt:
              * platform/mac/editing/style/smoosh-styles-001-expected.txt:
              * platform/mac/editing/style/style-3681552-fix-001-expected.txt:
              * platform/mac/editing/style/style-3681552-fix-002-expected.txt:
              * platform/mac/editing/style/style-boundary-002-expected.txt:
              * platform/mac/editing/style/style-boundary-003-expected.txt:
              * platform/mac/editing/style/style-boundary-005-expected.txt:
              * platform/mac/editing/style/typing-style-001-expected.txt:
              * platform/mac/editing/style/typing-style-002-expected.txt:
              * platform/mac/editing/style/unbold-in-bold-expected.txt:
              * platform/mac/editing/undo/4063751-expected.txt:
              * platform/mac/editing/undo/redo-typing-001-expected.txt:
              * platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-combined-delete-expected.txt:
              * platform/mac/editing/undo/undo-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-delete-expected.txt:
              * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-forward-delete-expected.txt:
              * platform/mac/editing/undo/undo-misspellings-expected.txt:
              * platform/mac/editing/undo/undo-typing-001-expected.txt:
              * platform/mac/editing/unsupported-content/list-type-after-expected.txt:
              * platform/mac/editing/unsupported-content/list-type-before-expected.txt:
              * platform/mac/editing/unsupported-content/table-type-after-expected.txt:
              * platform/mac/editing/unsupported-content/table-type-before-expected.txt:
              * platform/mac/fast/dom/delete-contents-expected.txt:
      2011-03-01  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              Assertion failure after removing a selection in keydown handler
              https://bugs.webkit.org/show_bug.cgi?id=51389
      
              The bug was caused by textWillBeReplaced's not always updating selection, and
              shouldRemovePositionAfterAdoptingTextReplacement's not moving the end offset when it's
              at the end of replaced data.
      
              Fixed the bug by always updating selection in textWillBeReplaced and fixing the condition
              to move the offset in shouldRemovePositionAfterAdoptingTextReplacement. Also added a call
              to setSelection instead of directly modifying m_selection to notify all the clients.
              Namely, the call to EditorClient::respondToChangedSelection is required for
              setting-input-value-cancel-ime-composition.html.
      
              Note that we must update layout before calling setSelection because setSelection calls
              setFocusedNodeIfNeeded and it requires layout to be up-to-date. Without this call, tests
              such as fast/forms/input-appearance-maxlength.html hits an assertion in Node::isFocusable.
      
              Test: editing/input/setting-input-value-cancel-ime-composition.html
      
              * editing/SelectionController.cpp:
              (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): When replacing text, the offset
              of the selection end must be updated even if it was at the end of the replaced text.
              e.g. removing "world" from "hello world] WebKit" should result in "hello ] WebKit" not
              "hello  WebK[it". Note we don't move the offset if no text is removed because appending
              "world" to "hello ]" should result in "hello ]world" not "hello world]".
              (WebCore::SelectionController::textWillBeReplaced): Calls setSelection to update
              the selection instead of modifying m_selection directly.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1714e2e0
  25. 01 Mar, 2011 3 commits
    • rniwa@webkit.org's avatar
      2011-03-01 Ryosuke Niwa <rniwa@webkit.org> · 7a6ef1f6
      rniwa@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Fix a bug in platform/mac/editing/input/selection-change-closes-typing.html
              https://bugs.webkit.org/show_bug.cgi?id=55523
      
              The marked text is at offset 0 with length 1, not at offset 1 with length 0.
      
              * platform/mac/editing/input/selection-change-closes-typing.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a6ef1f6
    • commit-queue@webkit.org's avatar
      2011-03-01 Jia Pu <jpu@apple.com> · 5396fd99
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Remove CorrectionIndicator markers sooner.
              https://bugs.webkit.org/show_bug.cgi?id=54893
              <rdar://problem/8997524>
      
              See WebCore/ChangeLog for detail.
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/editing/spelling/autocorrection-simple-expected.checksum:
              * platform/mac/editing/spelling/autocorrection-simple-expected.png:
              * platform/mac/editing/spelling/autocorrection-simple-expected.txt:
              * platform/mac/editing/spelling/autocorrection-simple.html:
              * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum:
              * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
              * platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.checksum: Added.
              * platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png: Added.
              * platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt: Copied from LayoutTests/platform/mac/editing/spelling/autocorrection-simple-expected.txt.
              * platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html: Copied from LayoutTests/platform/mac/editing/spelling/autocorrection-simple.html.
      2011-03-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Remove CorrectionIndicator markers sooner.
              https://bugs.webkit.org/show_bug.cgi?id=54893
              <rdar://problem/8997524>
      
              Test: platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html
      
              This patch changes the autocorrection behavior on Mac OS X. We want to remove CorrectionIndicator
              marker after any editing command if the command:
              1. is not a SpellingCorrectionCommand itself.
              2. is not the command that triggers the autocorrection.
              This is achieved by adding shouldRetainAutocorrectionIndicator() function to EditCommand. This function returns
              false for all commands derived from EditCommand, except SpellingCorrectionCommand and TypingCommand. This function
              always returns true for SpellingCorrectionCommand. For TypingCommand, the return value is determined by member
              variable m_shouldRetainAutocorrectionIndicator, which can be modified by passing option into the TypingCommand's
              public functions.
      
              To avoid constantly searching marker list, we use variable DocumentMarkerController::m_absentMarkerTypeCache
              to cache whether there is any marker of a particular type.
      
              This patch also fixes two minor existing bugs.
      
              1. We used to show reversion panel for word with CorrectionIndicator marker. This is incorrect because
              CorrectionIndicator marker can be removed from corrected words. Since all autocorrected words have Replacement
              marker unless the whole word is deleted, the correct behavior is to show reversion panel for word with Replacement
              marker, since all autocorrected words have such marker. However, since we don't want to show the reversion panel
              if an autocorrected word has been edited, we also check to see if the Replacement marker's description is null.
      
              This works as following:
              When we apply an autocorrection, we add Replacement marker to corrected word, and store original word
              as the marker's description. If the user edited the corrected word afterward, we set description to null.
              So when we decide whether to show a reversion panel, we not only check for the existence of Replacement
              marker, but also check if description is null.
      
              2. Fixed an assertion violation in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited(), which would
              occur when deleting the first character in an editable area.
      
              * dom/DocumentMarker.h: Added m_possiblyExistingMarkerTypes to allow quickly checking whether a marker type is
                 completely in from the document.
      
              * dom/DocumentMarkerController.cpp: Most of the functions listed here are optimized for early return by checking
                 the return value of possiblyHasMarkers() at beginning.
              (WebCore::DocumentMarkerController::possiblyHasMarkers):
              (WebCore::DocumentMarkerController::DocumentMarkerController):
              (WebCore::DocumentMarkerController::detach):
              (WebCore::DocumentMarkerController::removeMarkers):
              (WebCore::DocumentMarkerController::addMarker):
              (WebCore::DocumentMarkerController::copyMarkers):
              (WebCore::DocumentMarkerController::markerContainingPoint):
              (WebCore::DocumentMarkerController::renderedRectsForMarkers):
              (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair):
              (WebCore::DocumentMarkerController::repaintMarkers):
              (WebCore::DocumentMarkerController::shiftMarkers):
              (WebCore::DocumentMarkerController::setMarkersActive):
              (WebCore::DocumentMarkerController::hasMarkers):
              (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
              * dom/DocumentMarkerController.h:
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply):
              (WebCore::EditCommand::shouldRetainAutocorrectionIndicator):
              (WebCore::EditCommand::setShouldRetainAutocorrectionIndicator):
              * editing/EditCommand.h:
              * editing/Editor.cpp:
              (WebCore::Editor::respondToChangedSelection):
              (WebCore::Editor::appliedEditing):
              (WebCore::Editor::insertTextWithoutSendingTextEvent):
              (WebCore::Editor::insertLineBreak):
              (WebCore::Editor::insertParagraphSeparator):
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
              (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
              * editing/Editor.h:
              * editing/EditorCommand.cpp:
              (WebCore::executeInsertLineBreak):
              (WebCore::executeInsertParagraph):
              (WebCore::executeInsertText):
              * editing/SpellingCorrectionCommand.cpp:
              (WebCore::SpellingCorrectionCommand::shouldRetainAutocorrectionIndicator):
              * editing/SpellingCorrectionCommand.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::TypingCommand):
              (WebCore::TypingCommand::deleteSelection):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection):
              (WebCore::TypingCommand::insertText):
              (WebCore::TypingCommand::insertLineBreak):
              (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
              (WebCore::TypingCommand::insertParagraphSeparator):
              * editing/TypingCommand.h:
              (WebCore::TypingCommand::create):
              (WebCore::TypingCommand::shouldRetainAutocorrectionIndicator):
              (WebCore::TypingCommand::setShouldRetainAutocorrectionIndicator):
              * manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5396fd99
    • kalman@chromium.org's avatar
      2011-02-28 Benjamin Kalman <kalman@chromium.org> · 62a859a9
      kalman@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Make editing/selection/extend-selection-home-end test match other extend-selection with granularity tests
              https://bugs.webkit.org/show_bug.cgi?id=55422
      
              The other extend-selection tests which test a granularity just call into resources/extend-selection.js with the
              granularity they're testing.  The lineboundary test didn't due to RTL bugs in lineboundary, but these have now
              been fixed.
      
              * editing/selection/extend-selection-home-end-expected.txt:
              * editing/selection/extend-selection-home-end.html:
              * platform/mac/editing/selection/extend-selection-home-end-expected.txt:
              * platform/win/editing/selection/extend-selection-home-end-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62a859a9
  26. 28 Feb, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-02-28 Chang Shu <cshu@webkit.org> · 83c267fc
      commit-queue@webkit.org authored
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Updated expected results after the change that syncs the WebKit isEditable
              and WebCore isContentEditable.
      
              * platform/mac/editing/selection/designmode-no-caret-expected.txt:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Frame::isContentEditable is currently based on two things: Editor::clientIsEditable and
              Document::inDesignMode. In fact, it should only rely on Document::inDesignMode. As a result,
              Editor::clientIsEditable and its client-side implementation can be removed.
      
              * WebCore.exp.in:
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::isReadOnly):
              * editing/Editor.cpp:
              * editing/Editor.h:
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::setSelectionFromNone):
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::isContentEditable):
              (WebCore::HTMLElement::isContentRichlyEditable):
              * page/DragController.cpp:
              (WebCore::DragController::operationForLoad):
              * page/EditorClient.h:
              * page/Frame.cpp:
              * page/Frame.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation.
      
              * src/EditorClientImpl.cpp:
              * src/EditorClientImpl.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation.
      
              * WebCoreSupport/EditorClientEfl.cpp:
              * WebCoreSupport/EditorClientEfl.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              * WebCoreSupport/EditorClientGtk.h:
              * webkit/webkitwebview.cpp:
              (webkit_web_view_init):
              (webkit_web_view_get_editable):
              (webkit_web_view_set_editable):
              * webkit/webkitwebviewprivate.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation.
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              * WebCoreSupport/EditorClientHaiku.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
      
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              * WebView/WebView.mm:
              (-[WebView setEditable:]):
              (-[WebView isEditable]):
              * WebView/WebViewData.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::QWebPagePrivate):
              (QWebPage::setContentEditable):
              (QWebPage::isContentEditable):
              * Api/qwebpage_p.h:
              * WebCoreSupport/EditorClientQt.cpp:
              * WebCoreSupport/EditorClientQt.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation.
      
              * WebCoreSupport/WebEditorClient.cpp:
              * WebCoreSupport/WebEditorClient.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation.
      
              * WebCoreSupport/EditorClientWinCE.cpp:
              * WebCoreSupport/EditorClientWinCE.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
      
              * WebFrame.cpp:
              (wxWebFrame::wxWebFrame):
              (wxWebFrame::MakeEditable):
              (wxWebFrame::IsEditable):
              * WebFrame.h:
              * WebKitSupport/EditorClientWx.cpp:
              * WebKitSupport/EditorClientWx.h:
              * WebView.cpp:
              (wxWebView::wxWebView):
              * WebView.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83c267fc
  27. 17 Feb, 2011 1 commit
  28. 15 Feb, 2011 2 commits
    • kalman@chromium.org's avatar
      2011-02-15 Benjamin Kalman <kalman@chromium.org> · 95d674c6
      kalman@chromium.org authored
              Reviewed by Darin Adler.
      
              Clean up results for editing/selection/extend-selection-home-end layout test
              https://bugs.webkit.org/show_bug.cgi?id=54508
      
              Line up results in columns, remove unused pixel test results from qt.
      
              * editing/selection/extend-selection-home-end-expected.txt:
              * editing/selection/extend-selection-home-end.html:
              * platform/mac/editing/selection/extend-selection-home-end-expected.txt:
              * platform/qt/editing/selection/extend-selection-home-end-expected.checksum: Removed.
              * platform/qt/editing/selection/extend-selection-home-end-expected.png: Removed.
              * platform/win/editing/selection/extend-selection-home-end-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95d674c6
    • darin@apple.com's avatar
      Autocorrection should respect undo. · 74ce5090
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52221
      <rdar://problem/8663399>
      
      Patch by Jia Pu <jpu@apple.com> on 2011-02-15
      Reviewed by Darin Adler.
      
      Rebaselined tests affected by code change.
      
      * platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
      * platform/mac/editing/spelling/autocorrection-delete-expected.txt:
      * platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
      * platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
      * platform/mac/editing/spelling/autocorrection-simple-expected.txt:
      * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74ce5090
  29. 03 Feb, 2011 1 commit
    • mitz@apple.com's avatar
      Reversion should not be marked as misspelled. · d157c068
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=53255
      
      Source/WebCore: 
      
      Patch by Jia Pu <jpu@apple.com> on 2011-02-03
      This patch includes fix for reported bug, and also some housekeeping changes.
      
      To implement desired behavior, we need:
      1. Add a new marker type, SpellCheckingExemption, since now we distingusish between text
         that shouldn't be spellchecked and text shouldn't be autocorrected.
      2. Make sure that there is no pending correction panel when we enter markAllMisspellingsAndBadGrammarInRanges().
         Otherwise the spell checking code in that function may interfere with autocorrection. This
         is achieved by explicitly applying pending correction when user types space, line break or
         paragraph break.
      
      Housekeeping code changes include:
      1. Change manual-tests that were broken by relocated WebCore directory.
      2. Use TextIterator in various DocumentMarkerController functions instead of using
         Node::traverseNextNode() directly.
      3. Allow passing multiple marker types into DocumentMarkerController::removeMarkers() and
         DocumentMarkerController::hasMarkers() to improve clarity and efficiency.
      4. Fixes of minor bugs that were exposed previously.
      
      * WebCore.exp.in: Change signature of DocumentMarkerController::removeMarkers().
      
      * dom/DocumentMarker.h: Added new marker type SpellCheckingExemption.
      
      * dom/DocumentMarkerController.cpp:
      (WebCore::DocumentMarkerController::removeMarkers): Use TextIterator to scan the range to be
         consistent with addMarker() function. Allow passing in multiple marker types in one call.
         Added a boolean argument to specify the behavior when removing markers that partially
         overlap the specified range.
      (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Allow passing in
         multiple marker types in one call.
      (WebCore::DocumentMarkerController::hasMarkers): Use TextIterator to scan the range to be
         consistent with addMarker() function. Allow passing in multiple marker types in one call.
      
      * dom/DocumentMarkerController.h: Allow passing in multiple marker types to removeMarkers()
         and hasMarkers(). Added a boolean argument to removeMarkers() to specify the behavior when
         removing markers that partially overlap the specified range.
      
      * editing/Editor.cpp:
      (WebCore::markerTypesForAutocorrection): Add SpellCheckingExemption marker when apply correction.
      (WebCore::markerTypesForReplacement): Ditto.
      (WebCore::Editor::respondToChangedSelection): Reordered call to dismissCorrectionPanel() and
         setSelection() to make sure there is no pending correction when entering
         markAllMisspellingsAndBadGrammarInRanges().
      (WebCore::Editor::appliedEditing): Only remove CorrectionIndicator markers when the command
         is a top level command to improve efficiency.
      (WebCore::Editor::insertTextWithoutSendingTextEvent): Added code to applying pending correction.
      (WebCore::Editor::insertLineBreak): Ditto.
      (WebCore::Editor::insertParagraphSeparator): Ditto.
      (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Don't mark mispelling if the
         text carries SpellCheckingExemption marker.
      (WebCore::Editor::correctionPanelTimerFired): Reset correction panel if the returned suggestion
         from spellchecker is an empty string.
      (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
         Use new DocumentMarkerController::removeMarkers() to replace custom implemenation to improve
         efficiency and readability.
      (WebCore::Editor::applyCorrectionPanelInfo): Remove the code that set caret position after
         applying correction, since it's unnecessary. Also, store pre-correction string together with
         the marker for reversion panel to use.
      (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate): Apply pending correction.
      (WebCore::Editor::changeSelectionAfterCommand): Moved marker removal code to Editor::appliedEditing()
         where we have access to EditCommand object.
      
      * editing/Editor.h: Added new function applyAutocorrectionAfterTypingIfAppropriate().
      
      * manual-tests/autocorrection/autocorrection-cancelled-by-ESC.html: Change manual-tests that
         were broken by relocated WebCore directory.
      
      * manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Ditto.
      
      * manual-tests/autocorrection/autocorrection-contraction.html: Ditto.
      
      * manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html: Ditto.
      
      * manual-tests/autocorrection/delete-to-dismiss-reversion.html: Ditto.
      
      * manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html: Ditto.
      
      * manual-tests/autocorrection/dismiss-multiple-guesses.html: Ditto.
      
      * manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html: Ditto.
      
      * manual-tests/autocorrection/select-from-multiple-guesses.html: Ditto.
      
      * manual-tests/autocorrection/spell-checking-after-reversion.html: Added.
      
      * manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html: Change manual-tests that
         were broken by relocated WebCore directory.
      
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paintDocumentMarkers): Code clean-up to be more concise.
      
      LayoutTests: 
      
      Patch by Jia Pu <jpu@apple.com> on 2011-02-03
      Rebaselined tests broken by https://bugs.webkit.org/show_bug.cgi?id=51389
      
      * platform/mac/editing/spelling/autocorrection-contraction-expected.png:
      * platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
      * platform/mac/editing/spelling/autocorrection-delete-expected.png:
      * platform/mac/editing/spelling/autocorrection-delete-expected.txt:
      * platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.png:
      * platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
      * platform/mac/editing/spelling/autocorrection-removing-underline-expected.png:
      * platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
      * platform/mac/editing/spelling/autocorrection-simple-expected.checksum:
      * platform/mac/editing/spelling/autocorrection-simple-expected.png:
      * platform/mac/editing/spelling/autocorrection-simple-expected.txt:
      * platform/mac/editing/spelling/autocorrection-simple.html:
      * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png:
      * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d157c068
  30. 31 Jan, 2011 1 commit
    • chang.shu@nokia.com's avatar
      2011-01-31 Chang Shu <chang.shu@nokia.com> · b04bc61a
      chang.shu@nokia.com authored
              Reviewed by Ryosuke Niwa.
      
              Convert the test case to dumpAsText test so the expected result is cross-platform.
              https://bugs.webkit.org/show_bug.cgi?id=53437
      
              * editing/deleting/5168598-expected.txt: Added.
              * editing/deleting/5168598.html:
              * platform/chromium-linux/editing/deleting/5168598-expected.checksum: Removed.
              * platform/chromium-linux/editing/deleting/5168598-expected.png: Removed.
              * platform/chromium-win/editing/deleting/5168598-expected.checksum: Removed.
              * platform/chromium-win/editing/deleting/5168598-expected.png: Removed.
              * platform/chromium-win/editing/deleting/5168598-expected.txt: Removed.
              * platform/mac-leopard/editing/deleting/5168598-expected.checksum: Removed.
              * platform/mac-leopard/editing/deleting/5168598-expected.png: Removed.
              * platform/mac/editing/deleting/5168598-expected.checksum: Removed.
              * platform/mac/editing/deleting/5168598-expected.png: Removed.
              * platform/mac/editing/deleting/5168598-expected.txt: Removed.
              * platform/qt/editing/deleting/5168598-expected.checksum: Removed.
              * platform/qt/editing/deleting/5168598-expected.png: Removed.
              * platform/qt/editing/deleting/5168598-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b04bc61a