1. 13 May, 2011 24 commits
    • jocelyn.turcotte@nokia.com's avatar
      [Qt] Fix build on MSVC. · 0e9846f4
      jocelyn.turcotte@nokia.com authored
      Reviewed by nobody, build fix.
      
      qobject_cast<> requires the class to be exported on MSVC,
      removing it since the code that needs it is commented out for
      the same reason.
      
      * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
      (tst_QDeclarativeWebView::elementAreaAt):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e9846f4
    • jocelyn.turcotte@nokia.com's avatar
      [Qt] Fix build on MSVC by only enabling tst_MIMESniffing on linux. · 9737b0aa
      jocelyn.turcotte@nokia.com authored
      Reviewed by nobody, build fix.
      
      * tests/tests.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9737b0aa
    • mrobinson@webkit.org's avatar
      2011-05-13 Martin Robinson <mrobinson@igalia.com> · 800f02d5
      mrobinson@webkit.org authored
              Reviewed by Eric Seidel.
      
              [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=59765
      
              Move the keybinding code form WebKit1/WebKit2 to this utility class. This code is
              almost directly moved from the WebKit layer.
      
              No new tests. This is covered by the editing tests.
      
              * GNUmakefile.list.am:
              * platform/gtk/KeyBindingTranslator.cpp: Added.
              (WebCore::backspaceCallback):Added.
              (WebCore::selectAllCallback):Added.
              (WebCore::cutClipboardCallback):Added.
              (WebCore::copyClipboardCallback):Added.
              (WebCore::pasteClipboardCallback):Added.
              (WebCore::toggleOverwriteCallback):Added.
              (WebCore::popupMenuCallback):Added.
              (WebCore::showHelpCallback):Added.
              (WebCore::deleteFromCursorCallback):Added.
              (WebCore::moveCursorCallback):Added.
              (WebCore::KeyBindingTranslator::KeyBindingTranslator):Added.
              (WebCore::KeyBindingTranslator::getEditorCommandsForKeyEvent):Added.
              * platform/gtk/KeyBindingTranslator.h: Added.
              (WebCore::KeyBindingTranslator::addPendingEditorCommand):Added.
      2011-05-13  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Eric Seidel.
      
              [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=59765
      
              Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
              class we can now share the code with WebKit2.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::executePendingEditorCommands): Updated to reflect the fact that
              the command vector now contains WTF::string.
              (WebKit::EditorClient::handleKeyboardEvent): Use the new helper utility class.
              (WebKit::EditorClient::EditorClient):
              * WebCoreSupport/EditorClientGtk.h: Remove unnecessary member. Add the utility class.
      2011-05-13  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Eric Seidel.
      
              [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=59765
      
              Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
              class we can now share the code with WebKit2.
      
              * UIProcess/API/gtk/PageClientImpl.cpp:
              (WebKit::PageClientImpl::PageClientImpl): No longer need to initialize keybinding code.
              (WebKit::PageClientImpl::getEditorCommandsForKeyEvent): Use the new utility class.
              * UIProcess/API/gtk/PageClientImpl.h: Remove unnecessary members. Add utility class member.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      800f02d5
    • antonm@chromium.org's avatar
      2011-05-13 Steve VanDeBogart <vandebo@chromium.org> · 5ed523f8
      antonm@chromium.org authored
              Unreviewed.
      
              Update expectations for GPU tests that use shadows after fix (Skia rev 1297).
              https://bugs.webkit.org/show_bug.cgi?id=60742
      
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ed523f8
    • zherczeg@webkit.org's avatar
      2011-05-13 Zoltan Herczeg <zherczeg@webkit.org> · 338e1fb6
      zherczeg@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              Missing 2nd #EOF if WebProcess is killed.
              https://bugs.webkit.org/show_bug.cgi?id=60761
      
              If the WebProcess is killed, only one #EOF is yielded
              by WebKitTestRunner. However, run-webkit-test wait for
              a second #EOF, which signals the finishing of pixel dump.
              Since this never happens, run-webkit-test waits forever.
      
              * WebKitTestRunner/TestInvocation.cpp:
              (WTR::TestInvocation::dump):
              (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
              * WebKitTestRunner/TestInvocation.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      338e1fb6
    • zecke@webkit.org's avatar
      [android] Forward declare types for PlatformWidget and DragImage · 42ff713f
      zecke@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=59890
      
      This is fixing the compilation of files that include Widget.h or
      DragImage.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42ff713f
    • zecke@webkit.org's avatar
      [android] OS(ANDROID) does not imply PLATFORM(ANDROID) · e156cd77
      zecke@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=59888
      
      It is possible to build QtWebKit and others for OS(ANDROID). Let
      the buildsystem decide which platform is to be build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e156cd77
    • ossy@webkit.org's avatar
      [Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests. · 735b62a0
      ossy@webkit.org authored
      * platform/qt-wk2/Skipped: Add 4 failing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      735b62a0
    • podivilov@chromium.org's avatar
      2011-05-06 Pavel Podivilov <podivilov@chromium.org> · b5fbb0bf
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix incremental html highlight.
              https://bugs.webkit.org/show_bug.cgi?id=60163
      
              SourceTokenizers for html, js, and css are declared to be stateless. However they store some state in
              various ways (like using _internalJavaScriptTokenizer field in html tokenizer, or modifying "static"
              initialCondition object via condition link). This all worked because of another bug in tokenizers registry
              that always returned new tokenizer object.
              For incremental highlighting, we need to be able to stringify tokenizers state and then restore the
              state from string. That's why we need tokenizers to be truly stateless.
      
              * inspector/front-end/DOMSyntaxHighlighter.js:
              (WebInspector.DOMSyntaxHighlighter.prototype.syntaxHighlightNode):
              * inspector/front-end/SourceCSSTokenizer.js:
              (WebInspector.SourceCSSTokenizer):
              (WebInspector.SourceCSSTokenizer.prototype.createInitialCondition):
              * inspector/front-end/SourceCSSTokenizer.re2js:
              * inspector/front-end/SourceHTMLTokenizer.js:
              (WebInspector.SourceHTMLTokenizer):
              (WebInspector.SourceHTMLTokenizer.prototype.createInitialCondition):
              (WebInspector.SourceHTMLTokenizer.prototype.set line):
              (WebInspector.SourceHTMLTokenizer.prototype.get _internalJavaScriptTokenizer):
              (WebInspector.SourceHTMLTokenizer.prototype.get _internalCSSTokenizer):
              (WebInspector.SourceHTMLTokenizer.prototype.scriptStarted):
              (WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted):
              (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
              * inspector/front-end/SourceHTMLTokenizer.re2js:
              * inspector/front-end/SourceJavaScriptTokenizer.js:
              (WebInspector.SourceJavaScriptTokenizer):
              (WebInspector.SourceJavaScriptTokenizer.prototype.createInitialCondition):
              * inspector/front-end/SourceJavaScriptTokenizer.re2js:
              * inspector/front-end/SourceTokenizer.js:
              (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
              * inspector/front-end/TextEditorHighlighter.js:
              (WebInspector.TextEditorHighlighter.prototype._highlightLines):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5fbb0bf
    • ossy@webkit.org's avatar
      [NRWT] chromium-linux tests shouldn't run on other platforms · e191da4f
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=60162
      
      Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-05-13
      Reviewed by Csaba Osztrogonác.
      
      Remove _tests_for_other_platforms defs because r82753
      implemented it properly in the baseclass in webkit.py.
      
      * Scripts/webkitpy/layout_tests/port/gtk.py:
      * Scripts/webkitpy/layout_tests/port/qt.py:
      * Scripts/webkitpy/layout_tests/port/win.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e191da4f
    • aroben@apple.com's avatar
      Build fix after r86418 · adbfa1ec
      aroben@apple.com authored
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
      Made the destructor public so that this class can be used with
      [Pass]OwnPtr.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adbfa1ec
    • ossy@webkit.org's avatar
      [Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests. · 70884c9c
      ossy@webkit.org authored
      * platform/qt-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70884c9c
    • ossy@webkit.org's avatar
      [Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests. · f530706b
      ossy@webkit.org authored
      * platform/qt-arm/Skipped:
      * platform/qt-mac/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f530706b
    • hans@chromium.org's avatar
      2011-05-11 Hans Wennborg <hans@chromium.org> · 4d38a498
      hans@chromium.org authored
              Reviewed by Tony Gentilcore.
      
              IndexedDB: Fix integer comparison bug in LevelDB coding routines
              https://bugs.webkit.org/show_bug.cgi?id=60623
      
              Fix the code for comparing two int64_t variables.
              Also remove faulty line in ObjectStoreNamesKey::encode which was
              uncovered by the unit test in this patch.
      
              Very hard to cover with layout tests; covered by unit test.
      
              * storage/IDBLevelDBCoding.cpp:
              (WebCore::IDBLevelDBCoding::compareInts):
              (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
              (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
              (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
              (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
              (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
              (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
              (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
              (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
              (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
      2011-05-11  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Tony Gentilcore.
      
              IndexedDB: Fix integer comparison bug in LevelDB coding routines
              https://bugs.webkit.org/show_bug.cgi?id=60623
      
              Unit test for comparison of encoded keys.
      
              * tests/IDBLevelDBCodingTest.cpp:
              (IDBLevelDBCoding::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d38a498
    • commit-queue@webkit.org's avatar
      2011-05-13 Andrew Wason <rectalogic@rectalogic.com> · 02bc8e08
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              GraphicsContext3DQt.cpp fails to compile
              https://bugs.webkit.org/show_bug.cgi?id=60740
      
              * platform/graphics/qt/GraphicsContext3DQt.cpp:
              (WebCore::GraphicsContext3D::GraphicsContext3D):
               Change order of initializers.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02bc8e08
    • antonm@chromium.org's avatar
      2011-02-08 Anton Muhin <antonm@chromium.org> · b904ab59
      antonm@chromium.org authored
             Reviewed by Adam Barth and Alexey Proskuryakov.
      
             Propagate security origin of parent document into HTML documents created with DOMImplementation
             https://bugs.webkit.org/show_bug.cgi?id=53611
      
             This restores invariant that JS wrappers residing in the same JS context should come
             from the same security origin.
      
             Absence of regressions is covered by the current tests.  Different security origin of
             DOMImplementation is difficult to check with layout tests as DOMImplementation
             resides in the same JS context as parent document and therefore there are no security origin checks.
             This is observable however in C++.
      
             * Android.jscbindings.mk:
             * CMakeLists.txt:
             * WebCore.gypi:
             * WebCore.pro:
             * WebCore.vcproj/WebCore.vcproj:
             * WebCore.xcodeproj/project.pbxproj:
             * bindings/v8/V8GCController.cpp:
             (WebCore::NodeGrouperVisitor::visitDOMWrapper):
             * dom/DOMImplementation.cpp:
             (WebCore::DOMImplementation::DOMImplementation):
             (WebCore::DOMImplementation::createDocument):
             * dom/DOMImplementation.h:
             (WebCore::DOMImplementation::create):
             (WebCore::DOMImplementation::documentDestroyed):
             (WebCore::DOMImplementation::parentDocument):
             * dom/DOMImplementation.idl:
             * dom/Document.cpp:
             (WebCore::Document::~Document):
             (WebCore::Document::implementation):
             * dom/Document.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b904ab59
    • hans@chromium.org's avatar
      2011-05-05 Hans Wennborg <hans@chromium.org> · f9c19cc4
      hans@chromium.org authored
              Reviewed by Steve Block.
      
              IndexedDB: Transaction rollback prevented by open SQLite statement
              https://bugs.webkit.org/show_bug.cgi?id=60032
      
              Add test for veryfing that transaction roll-back works, even with a
              previously opened cursor still around.
      
              * storage/indexeddb/transaction-rollback-expected.txt: Added.
              * storage/indexeddb/transaction-rollback.html: Added.
      2011-05-05  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Steve Block.
      
              IndexedDB: Transaction rollback prevented by open SQLite statement
              https://bugs.webkit.org/show_bug.cgi?id=60032
      
              Let the IDBTransactionbackendImpl keep track of all open cursors, and
              "close" them (i.e. finalizing the underlying SQLiteStatement) before
              committing or rolling back the transaction. This fixes the problem
              with opened cursors preventing transaction rollback.
      
              Test: storage/indexeddb/transaction-rollback.html
      
              * storage/IDBBackingStore.h:
              * storage/IDBCursorBackendImpl.cpp:
              (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
              (WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl):
              (WebCore::IDBCursorBackendImpl::close):
              * storage/IDBCursorBackendImpl.h:
              * storage/IDBLevelDBBackingStore.cpp:
              * storage/IDBSQLiteBackingStore.cpp:
              * storage/IDBTransactionBackendImpl.cpp:
              (WebCore::IDBTransactionBackendImpl::abort):
              (WebCore::IDBTransactionBackendImpl::registerOpenCursor):
              (WebCore::IDBTransactionBackendImpl::unregisterOpenCursor):
              (WebCore::IDBTransactionBackendImpl::commit):
              (WebCore::IDBTransactionBackendImpl::closeOpenCursors):
              * storage/IDBTransactionBackendImpl.h:
              * storage/IDBTransactionBackendInterface.h:
              (WebCore::IDBTransactionBackendInterface::registerOpenCursor):
              (WebCore::IDBTransactionBackendInterface::unregisterOpenCursor):
      2011-05-05  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Steve Block.
      
              IndexedDB: Transaction rollback prevented by open SQLite statement
              https://bugs.webkit.org/show_bug.cgi?id=60032
      
              Implement two new methods in IDBTransactionBackendInterface.
      
              * src/IDBTransactionBackendProxy.cpp:
              (WebKit::IDBTransactionBackendProxy::registerOpenCursor):
              (WebKit::IDBTransactionBackendProxy::unregisterOpenCursor):
              * src/IDBTransactionBackendProxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9c19cc4
    • gyuyoung.kim@samsung.com's avatar
      2011-05-13 Gyuyoung Kim <gyuyoung.kim@samsung.com> · 8df6bfdc
      gyuyoung.kim@samsung.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [EFL] Move ewk_view_dpi_get() to ewk_util.cpp
              https://bugs.webkit.org/show_bug.cgi?id=60753
      
              Move ewk_view_dpi_get() to ewk_util.cpp
      
              * ewk/ewk_private.h:
              * ewk/ewk_util.cpp:
              (ewk_util_dpi_get):
              * ewk/ewk_view.cpp:
              (_ewk_view_viewport_attributes_compute):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8df6bfdc
    • sergio@webkit.org's avatar
      2011-05-13 Sergio Villar Senin <svillar@igalia.com> · 20657cef
      sergio@webkit.org authored
              Unreviewed, new GTK+ test expectations after r86352.
      
              * platform/gtk/svg/custom/stroke-opacity-update-expected.png: Added.
              * platform/gtk/svg/custom/stroke-opacity-update-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20657cef
    • sergio@webkit.org's avatar
      2011-05-13 Sergio Villar Senin <svillar@igalia.com> · fb22be44
      sergio@webkit.org authored
              Unreviewed, new GTK+ test expectations.
      
              * platform/gtk/fast/borders/outline-alpha-block-expected.png:
              * platform/gtk/fast/borders/outline-alpha-block-expected.txt:
              * platform/gtk/fast/borders/outline-alpha-inline-expected.png:
              * platform/gtk/fast/borders/outline-alpha-inline-expected.txt:
              * platform/gtk/svg/custom/fill-opacity-update-expected.png:
              * platform/gtk/svg/custom/fill-opacity-update-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb22be44
    • paroga@webkit.org's avatar
      2011-05-13 Patrick Gansterer <paroga@webkit.org> · 9f514e70
      paroga@webkit.org authored
              Reviewed by Adam Barth.
      
              Enable OwnPtr strict mode in MediaPlayer
              https://bugs.webkit.org/show_bug.cgi?id=59466
      
              Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
              Also fix the templete argument of OwnPtr for the m_private member variable.
      
              * platform/graphics/MediaPlayer.cpp:
              (WebCore::MediaPlayer::MediaPlayer):
              (WebCore::MediaPlayer::loadWithNextMediaEngine):
              * platform/graphics/MediaPlayer.h:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
              (WebCore::MediaPlayerPrivateAVFoundationObjC::create):
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivateGStreamer::create):
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
              * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivateQTKit::create):
              * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
              (WebCore::MediaPlayerPrivatePhonon::create):
              * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
              * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
              (WebCore::MediaPlayerPrivateQt::create):
              * platform/graphics/qt/MediaPlayerPrivateQt.h:
              * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::create):
              * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
              (WebCore::MediaPlayerPrivate::create):
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
              * platform/graphics/wince/MediaPlayerPrivateWinCE.h:
      2011-05-13  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Adam Barth.
      
              Enable OwnPtr strict mode in MediaPlayer
              https://bugs.webkit.org/show_bug.cgi?id=59466
      
              Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
              Also fix the templete argument of OwnPtr for the m_private member variable.
      
              * src/WebMediaPlayerClientImpl.cpp:
              (WebKit::WebMediaPlayerClientImpl::create):
              * src/WebMediaPlayerClientImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f514e70
    • ap@apple.com's avatar
      2011-05-13 Alexey Proskuryakov <ap@apple.com> · ba3782cc
      ap@apple.com authored
              Unreviewed test changes.
      
              Web Inspector: Show Error Messages for Application Cache Errors
              https://bugs.webkit.org/show_bug.cgi?id=41642
      
              * http/tests/appcache/404-resource-expected.txt:
              * http/tests/appcache/manifest-redirect-expected.txt:
              * http/tests/appcache/origin-quota-expected.txt:
              * http/tests/appcache/resource-redirect-2-expected.txt:
              * http/tests/appcache/resource-redirect-expected.txt:
              * http/tests/appcache/wrong-content-type-expected.txt:
              * http/tests/appcache/wrong-signature-2-expected.txt:
              * http/tests/appcache/wrong-signature-expected.txt:
      2011-05-13  Alexey Proskuryakov  <ap@apple.com>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: Show Error Messages for Application Cache Errors
              https://bugs.webkit.org/show_bug.cgi?id=41642
      
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::didReceiveResponse):
              (WebCore::ApplicationCacheGroup::didFail):
              (WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
              (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
              (WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota):
              Added console error logging.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba3782cc
    • psolanki@apple.com's avatar
      2011-05-12 Pratik Solanki <psolanki@apple.com> · 8b666474
      psolanki@apple.com authored
              Reviewed by Antti Koivisto.
      
              Part of WebCore should use CFNetwork-based loader on Mac
              https://bugs.webkit.org/show_bug.cgi?id=51836
      
              Fixes for warnings and other minor cleanups when we enable USE_CFNETWORK on Mac.
      
              * platform/network/cf/ResourceErrorCF.cpp:
              (WebCore::ResourceError::cfStreamError):
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::allowsAnyHTTPSCertificateHosts):
              (WebCore::clientCerts):
              (WebCore::willSendRequest):
              (WebCore::didReceiveResponse):
              (WebCore::didReceiveData):
              (WebCore::didSendBodyData):
              (WebCore::shouldUseCredentialStorageCallback):
              (WebCore::didFinishLoading):
              (WebCore::didFail):
              (WebCore::didReceiveChallenge):
              (WebCore::makeFinalRequest):
              (WebCore::ResourceHandle::willLoadFromCache):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b666474
    • psolanki@apple.com's avatar
      2011-05-12 Pratik Solanki <psolanki@apple.com> · 0a504439
      psolanki@apple.com authored
              Reviewed by Antti Koivisto.
      
              Part of WebCore should use CFNetwork-based loader on Mac
              https://bugs.webkit.org/show_bug.cgi?id=51836
      
              Implement ResourceHandle::schedule()/unschedule() based on CF for Mac.
      
              * WebCore.exp.in:
              * platform/cf/SchedulePair.h:
              * platform/mac/SchedulePairMac.mm:
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::ResourceHandle::schedule):
              (WebCore::ResourceHandle::unschedule):
      2011-05-12  Pratik Solanki  <psolanki@apple.com>
      
              Reviewed by Antti Koivisto.
      
              Part of WebCore should use CFNetwork-based loader on Mac
              https://bugs.webkit.org/show_bug.cgi?id=51836
      
              Use CFRunLoop when using CFNetwork.
      
              * WebView/WebView.mm:
              (-[WebView scheduleInRunLoop:forMode:]):
              (-[WebView unscheduleFromRunLoop:forMode:]):
      2011-05-12  Pratik Solanki  <psolanki@apple.com>
      
              Reviewed by Antti Koivisto.
      
              Part of WebCore should use CFNetwork-based loader on Mac
              https://bugs.webkit.org/show_bug.cgi?id=51836
      
              Use CFRunLoop when using CFNetwork.
      
              * WebProcess/WebPage/mac/WebPageMac.mm:
              (WebKit::WebPage::platformInitialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a504439
  2. 12 May, 2011 16 commits
    • psolanki@apple.com's avatar
      2011-05-12 Pratik Solanki <psolanki@apple.com> · 7c5455c6
      psolanki@apple.com authored
              Reviewed by Antti Koivisto.
      
              Part of WebCore should use CFNetwork-based loader on Mac
              https://bugs.webkit.org/show_bug.cgi?id=51836
      
              Implement mac specific Authentication functions when using CFNetwork.
      
              * WebCore.exp.in:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/network/ResourceHandle.h:
              * platform/network/cf/AuthenticationCF.cpp:
              (WebCore::AuthenticationChallenge::authenticationClient):
              (WebCore::createCF):
              (WebCore::core):
              * platform/network/cf/AuthenticationCF.h:
              * platform/network/cf/AuthenticationChallenge.h:
              * platform/network/mac/AuthenticationMac.mm:
              (WebCore::core):
              (WebCore::mac):
              * platform/network/mac/CredentialStorageMac.mm:
      2011-05-12  Pratik Solanki  <psolanki@apple.com>
      
              Reviewed by Antti Koivisto.
      
              Part of WebCore should use CFNetwork-based loader on Mac
              https://bugs.webkit.org/show_bug.cgi?id=51836
      
              Include AuthenticationCF.h header file.
      
              * Misc/WebDownload.mm:
              * Plugins/WebBaseNetscapePluginView.mm:
              * WebCoreSupport/WebFrameLoaderClient.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c5455c6
    • commit-queue@webkit.org's avatar
      2011-05-12 Ben Wells <benwells@chromium.org> · c37dc208
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              RGBA colors in outlines show overpainting at the corners
              https://bugs.webkit.org/show_bug.cgi?id=58999
      
              Converted the new tests to be text tests with pixel results
              (using dumpAsText(true)).
              Updated test_expectations comments to be more helpful and accurate and split
              new expectations into two groups for skia / chromium-mac as chromium-mac can be
              rebaselined now.
      
              * fast/borders/outline-alpha-block-expected.txt: Added.
              * fast/borders/outline-alpha-block.html:
              * fast/borders/outline-alpha-inline-expected.txt: Added.
              * fast/borders/outline-alpha-inline.html:
              * platform/chromium/test_expectations.txt:
              * platform/mac/fast/borders/outline-alpha-block-expected.txt: Removed.
              * platform/mac/fast/borders/outline-alpha-inline-expected.txt: Removed.
      2011-05-12  Ben Wells  <benwells@chromium.org>
      
              Reviewed by Simon Fraser.
      
              RGBA colors in outlines show overpainting at the corners
              https://bugs.webkit.org/show_bug.cgi?id=58999
      
              Added FIXMEs near temporary $if !USE(SKIA)s, referencing bug 60342.
      
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::paintOutline):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::paintOutline):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c37dc208
    • commit-queue@webkit.org's avatar
      2011-05-12 Ryuan Choi <ryuan.choi@samsung.com> · b10b1084
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [EFL] Remove unused option of EWeblauncher
              https://bugs.webkit.org/show_bug.cgi?id=60747
      
              Remove sudo-workaround option.
              This option is not used and make other option wrong.
      
              * EWebLauncher/main.c:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b10b1084
    • lforschler@apple.com's avatar
      2011-05-12 Lucas Forschler <lforschler@apple.com> · bb0670ad
      lforschler@apple.com authored
              Reviewed by Stephanie Lewis.
      
              Fix config.json to address missing WK2 builder/tester config.
              Fix naming of machines (xserve not macpro)
      
              * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb0670ad
    • abarth@webkit.org's avatar
      2011-05-12 Adam Barth <abarth@webkit.org> · 3f7ded3b
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Chromium] Add a WebSetting to control DNS prefetch
              https://bugs.webkit.org/show_bug.cgi?id=60736
      
              DNS prefetch got disabled in Chrome accidentially in
              http://trac.webkit.org/changeset/74041.  This patch adds a WebSettings
              API so we can enable it again.
      
              * public/WebSettings.h:
              * src/WebSettingsImpl.cpp:
              (WebKit::WebSettingsImpl::setDNSPrefetchingEnabled):
              * src/WebSettingsImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f7ded3b
    • weinig@apple.com's avatar
      2011-05-12 Sam Weinig <sam@webkit.org> · 13914dd3
      weinig@apple.com authored
              Reviewed by Gavin Barraclough.
      
              WebProcess sandbox denies file:/// accesses after you navigate to a nonexistent file
              <rdar://problem/9427752>
              https://bugs.webkit.org/show_bug.cgi?id=60745
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
              Don't attempt to re-use a non-existent committed sandbox extension. This can
              happen when the previous load was file: url, but did not require an extension,
              such as an error page.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13914dd3
    • commit-queue@webkit.org's avatar
      2011-05-12 David Grogan <dgrogan@chromium.org> · 560ea591
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              make layout tests in storage/domstorage/events more deterministic
              https://bugs.webkit.org/show_bug.cgi?id=60299
      
              Instead of counting the number of storage events fired between two
              setTimeout(0) events, specify the number of events to wait for and wait up to
              1 second for them.
      
              * storage/domstorage/events/resources/eventTestHarness.js:
              (runAfterNStorageEvents):
              (countStorageEvents.onTimeout):
              (countStorageEvents):
              (testStorages.allDone):
              * storage/domstorage/events/script-tests/basic-body-attribute.js:
              (step1):
              (step2):
              (step3):
              (step4):
              (step5):
              * storage/domstorage/events/script-tests/basic-setattribute.js:
              (step1):
              (step2):
              (step3):
              (step4):
              (step5):
              * storage/domstorage/events/script-tests/basic.js:
              (test):
              (step1):
              (step2):
              (step3):
              (step4):
              (step5):
              * storage/domstorage/events/script-tests/case-sensitive.js:
              (test):
              (step1):
              (step2):
              * storage/domstorage/events/script-tests/documentURI.js:
              (test):
              (step1):
              (step2):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      560ea591
    • adele@apple.com's avatar
      Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser) · ff72a0db
      adele@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=60685
      
      Reviewed by Darin Adler and Adam Barth.
      
      Source/WebCore: 
      
      Detect the Solar Walk application so we can add targeted parser quirks.
      
      * WebCore.exp.in:
      * platform/RuntimeApplicationChecks.cpp: (WebCore::applicationIsSolarWalk):
      * platform/RuntimeApplicationChecks.h:
      
      Source/WebKit: 
      
      * WebKit.xcodeproj/project.pbxproj: Added Misc/SolarWalkQuirksUserScript.js and copy it to Resources during the build phase. 
      
      Source/WebKit/mac: 
      
      Solar Walk uses a self closing title tag, so to match the behavior of the old parser, 
      we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed.
      
      * Misc/SolarWalkQuirksUserScript.js: Added.
      * WebView/WebView.mm:
      (needsSolarWalkQuirksScript):
      (leakSolarWalkQuirksUserScriptContents):
      (-[WebView _injectSolarWalkQuirksScript]):
      (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff72a0db
    • jpu@apple.com's avatar
      2011-05-12 Jia Pu <jpu@apple.com> · a2f77992
      jpu@apple.com authored
              Reviewed by Darin Adler.
      
              Regression caused by changeset 86281
              https://bugs.webkit.org/show_bug.cgi?id=60712
      
              Changed wording in some tests to reflect AppKit UI change.
      
              * manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html:
              * manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html:
      2011-05-12  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Regression caused by changeset 86281
              https://bugs.webkit.org/show_bug.cgi?id=60712
              <rdar://problem/9427970>
      
              Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
              So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
              returns. So we don't need to use the condition to coordinate between these two function. In fact,
              all callbacks are delivered on main thread. We don't really need any locking here.
      
              Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
              been removed.
      
              * WebCoreSupport/CorrectionPanel.h:
              * WebCoreSupport/CorrectionPanel.mm:
              (CorrectionPanel::CorrectionPanel):
              (CorrectionPanel::show):
              (CorrectionPanel::dismiss):
              (CorrectionPanel::dismissInternal):
              (CorrectionPanel::handleAcceptedReplacement):
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::dismissCorrectionPanelSoon):
      2011-05-12  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Regression caused by changeset 86281
              https://bugs.webkit.org/show_bug.cgi?id=60712
              <rdar://problem/9427970>
      
              Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
              So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
              returns. So we don't need to use the condition to coordinate between these two function. In fact,
              all callbacks are delivered on main thread. We don't really need any locking here.
      
              Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
              been removed.
      
              * UIProcess/API/mac/PageClientImpl.mm:
              (WebKit::PageClientImpl::dismissCorrectionPanelSoon):
              * UIProcess/mac/CorrectionPanel.h:
              * UIProcess/mac/CorrectionPanel.mm:
              (WebKit::CorrectionPanel::CorrectionPanel):
              (WebKit::CorrectionPanel::show):
              (WebKit::CorrectionPanel::dismiss):
              (WebKit::CorrectionPanel::dismissInternal):
              (WebKit::CorrectionPanel::handleAcceptedReplacement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2f77992
    • dbates@webkit.org's avatar
      2011-05-12 Daniel Bates <dbates@rim.com> · 6245322a
      dbates@webkit.org authored
              Attempt to fix the build after changeset 86391<http://trac.webkit.org/changeset/86391>
              (https://bugs.webkit.org/show_bug.cgi?id=60681).
      
              * page/PluginHalter.cpp:
              (WebCore::PluginHalter::PluginHalter): Substitute m_client for client in ASSERT_ARG since client is now of type PassOwnPtr
              so it becomes 0 when assigned to another variable.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6245322a
    • commit-queue@webkit.org's avatar
      2011-05-12 Gregg Tavares <gman@chromium.org> · ccdde132
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              Add option to select GraphicsContext3D implementation.
              https://bugs.webkit.org/show_bug.cgi?id=60297
      
              * Source/WebKit/chromium/DEPS:
              * Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccdde132
    • atwilson@chromium.org's avatar
      Unreviewed expectations tweaks for chromium. · f7be5262
      atwilson@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7be5262
    • paroga@webkit.org's avatar
      2011-05-12 Patrick Gansterer <paroga@webkit.org> · ece87828
      paroga@webkit.org authored
              Reviewed by Darin Adler.
      
              Rename SimpleFontData::scaledFontData to createScaledFontData
              https://bugs.webkit.org/show_bug.cgi?id=60723
      
              * platform/graphics/SimpleFontData.h:
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
              * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
              * platform/graphics/mac/SimpleFontDataMac.mm:
              * platform/graphics/pango/SimpleFontDataPango.cpp:
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              * platform/graphics/win/SimpleFontDataWin.cpp:
              * platform/graphics/wince/SimpleFontDataWinCE.cpp:
              * platform/graphics/wx/SimpleFontDataWx.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ece87828
    • leviw@chromium.org's avatar
      2011-05-12 Levi Weintraub <leviw@chromium.org> · b80b4638
      leviw@chromium.org authored
              Reviewed by Simon Fraser.
      
              Switch paintOutline to use IntRect
              https://bugs.webkit.org/show_bug.cgi?id=60718
      
              Switching paintOutline to use an IntRect instead of 4 ints.
      
              No new tests as this is just refactoring.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintObject):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::paintOutline):
              * rendering/RenderObject.h:
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::paint):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::paintObject):
              * rendering/svg/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::paint):
              * rendering/svg/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::paint):
              * rendering/svg/RenderSVGPath.cpp:
              (WebCore::RenderSVGPath::paint):
              * rendering/svg/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::paint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b80b4638
    • tkent@chromium.org's avatar
      2011-05-12 Kent Tamura <tkent@chromium.org> · b22b6131
      tkent@chromium.org authored
              [Chromium] Update test expectations for r86224.
      
              * platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
              * platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
              * platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
              * platform/chromium-mac/fast/forms/validation-message-appearance-expected.png: Removed.
              * platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.png: Added.
              * platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b22b6131
    • andersca@apple.com's avatar
      Address review comment by Dan Bernstein. · c4c99be1
      andersca@apple.com authored
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4c99be1