1. 26 Mar, 2013 40 commits
    • jamesr@google.com's avatar
      Compile fix - OS(WINDOWS), not OS(WIN). · 0d1b0ee3
      jamesr@google.com authored
      * wtf/ProcessID.h:
      (WTF::getCurrentProcessID):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d1b0ee3
    • dgrogan@chromium.org's avatar
      IndexedDB: Histogram cause of LevelDB write errors · 309eb62d
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113350
      
      Reviewed by Tony Chang.
      
      Add histogram for source of LevelDB errors on Write in addition to
      Open.
      
      No new tests - no good way to test histogram code.
      
      * platform/leveldb/LevelDBDatabase.cpp:
      (WebCore::histogramLevelDBError):
      (WebCore):
      (WebCore::LevelDBDatabase::open):
      (WebCore::LevelDBDatabase::write):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      309eb62d
    • cfleizach@apple.com's avatar
      WebKit does not expose @required or @aria-required as AXRequired on select elements · 1f897272
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113339
      
      Reviewed by Tim Horton.
      
      Source/WebCore: 
      
      Make sure button types can return the AXRequired attribute.
      
      Tests: platform/mac/accessibility/aria-required-popup-button.html
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/aria-required-popup-button-expected.txt: Added.
      * platform/mac/accessibility/aria-required-popup-button.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f897272
    • jamesr@google.com's avatar
      Fix compile for OS(WIN) != PLATFORM(WIN) · 38a1e325
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113356
      
      Reviewed by Tim Horton.
      
      * wtf/ProcessID.h:
      (WTF::getCurrentProcessID):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38a1e325
    • fpizlo@apple.com's avatar
      REGRESSION: Sometimes, operations on proven strings ignore changes to the string prototype · f0d8277b
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113353
      <rdar://problem/13510778>
      
      Source/JavaScriptCore: 
      
      Reviewed by Mark Hahnenberg and Geoffrey Garen.
              
      ToString should call speculateStringObject() even if you know that it's a string object, since
      it calls it to also get the watchpoint. Note that even with this change, if you do
      Phantom(Check:StringObject:@a), it might get eliminated just because we proved that @a is a
      string object (thereby eliminating the prototype watchpoint); that's fine since ToString is
      MustGenerate and never decays to Phantom.
      
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compileToStringOnCell):
      (JSC::DFG::SpeculativeJIT::speculateStringObject):
      (JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):
      * dfg/DFGSpeculativeJIT.h:
      (SpeculativeJIT):
      (JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):
      
      LayoutTests: 
      
      Reviewed by Mark Hahnenberg and Geoffrey Garen.
      
      * fast/js/jsc-test-list:
      * fast/js/dfg-phantom-base-expected.txt: Added.
      * fast/js/dfg-phantom-base.html: Added.
      * fast/js/dfg-to-string-toString-becomes-bad-with-check-structure-expected.txt: Added.
      * fast/js/dfg-to-string-toString-becomes-bad-with-check-structure.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0d8277b
    • dino@apple.com's avatar
      When a primary plugin is restarted, also start similar plugins · cf69686e
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113265
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      If we detect a primary plugin that is snapshotted, we immediately restart it.
      When this happens, we should also restart any other plugins that
      match the same origin and type. This allows sites with a lot of
      (geometrically) nearby plugins to behave as if they are a single big plugin.
      
      Tests: plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html
             plugins/snapshotting/autoplay-similar-to-dominant.html
      
      * WebCore.exp.in: Export mimeTypeFromURL.
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Use loadedMimeType helper.
      (WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): New method, which copied the
          existing code from userDidClickSnapshot.
      (WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Move the similar plugin detection
          out into another function and call it.
      (WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Call restartSimilarPlugIns.
      (WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Use loadedMimeType helper.
      * html/HTMLPlugInImageElement.h: Declaration of restartSimilarPlugIns.
      (WebCore::HTMLPlugInImageElement::loadedMimeType): New helper method since this
          code was being often duplicated.
      
      Source/WebKit2:
      
      Remember the origin of the primary plugin, so that we can
      autostart anything that is similar.
      
      * WebProcess/WebCoreSupport/WebPlugInClient.cpp:
      (WebKit::WebPlugInClient::WebPlugInClient): Keep a pointer to the WebPage.
      (WebKit::WebPlugInClient::shouldAutoStartFromOrigin): Pass the page onto the process.
      * WebProcess/WebCoreSupport/WebPlugInClient.h:
      (WebPlugInClient): New member variable for the WebPage we were created with.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::determinePrimarySnapshottedPlugIn): Remember the origin information
          for the primary plugin.
      (WebKit::WebPage::matchesPrimaryPlugIn): Returns true if we're seeing something that
          looks like the primary plugin.
      * WebProcess/WebPage/WebPage.h: New method matchesPrimaryPlugIn.
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::shouldPlugInAutoStartFromOrigin): Check if the page thinks this is
          the primary plugin.
      * WebProcess/WebProcess.h: Accept a reference to the page in shouldPlugInAutoStartFromOrigin.
      
      LayoutTests:
      
      Two new tests. The first has one big plugin (that should be detected as the primary)
      and then a few smaller versions (which should autostart along with the primary).
      The second has one big plugin, and then adds a similar one after a short delay.
      
      * platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-after-delay-expected.txt: Added.
      * platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-expected.txt: Added.
      * plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html: Added.
      * plugins/snapshotting/autoplay-similar-to-dominant.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf69686e
    • mhahnenberg@apple.com's avatar
      REGRESSION(r144131): It made fast/js/regress/string-repeat-arith.html assert on 32 bit · 0e269132
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112106
      
      Rubber stamped by Filip Pizlo.
      
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32): Get rid of the case for constants because
      we would have done constant folding anyways on a ValueToInt32.
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::fillSpeculateBoolean): Fixed a random compile error with this flag enabled.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e269132
    • zoltan@webkit.org's avatar
      Unreviewed. Fix test after r146938. Since CSS Exclusions is still an... · 95572ae6
      zoltan@webkit.org authored
      Unreviewed. Fix test after r146938. Since CSS Exclusions is still an experimental feature, shape-inside-on-nested-container-with-unresolved-height.html
      test should enable CSS Exclusions for the testrunners first.  
      
      * fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Set CSSExclisions enabled for DRT/WTR.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95572ae6
    • alokp@chromium.org's avatar
      Unreviewed gardening. · 062a284b
      alokp@chromium.org authored
      Marked compositing/rtl/rtl-iframe-* tests as ImageOnlyFailure instead of Failure.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      062a284b
    • bfulgham@webkit.org's avatar
      [Windows, WinCairo] Scroll offset being applied to plugins during print operations. · f6463f7a
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39889
      
      Reviewed by Anders Carlsson.
      
      This must be tested manually. See the issue for details.
      
      * plugins/win/PluginViewWin.cpp:
      (WebCore::PluginView::paintWindowedPluginIntoContext):
      Revise the Windows implementation of the PluginView class
      paintWindowedPluginIntoContext to use the containing window
      position when computing the plugin's position for printing.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6463f7a
    • wangxianzhu@chromium.org's avatar
      Non-paintsContent fixed position layer should not cause slow scrolling · 50666458
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113238
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Added NotCompositedForNoVisibleContent in ViewportConstrainedNotCompositedReason and set it in RLC.
      
      Test: compositing/layer-creation/fixed-position-no-content-scroll-reason.html
      
      * rendering/RenderLayer.h: Add NotCompositedForNoVisibleContent.
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::requiresCompositingForPosition): Set NotCompositedForNoVisibleContent reason when the fixed position layer has no visible content.
      
      LayoutTests:
      
      * compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt: Added.
      * compositing/layer-creation/fixed-position-no-content-scroll-reason.html: Copied from LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html. Test case for the bug.
      * compositing/layer-creation/fixed-position-in-view-dynamic.html: Set background of fixed layer to distinguish out-of-view case from no-content case.
      * compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Ditto.
      * compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html: Ditto.
      * platform/chromium/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.
      * platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50666458
    • alokp@chromium.org's avatar
      Unreviewed gardening. · 0b992bb7
      alokp@chromium.org authored
      Marked compositing/iframes/scrolling-iframe.html flaky on all platforms.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b992bb7
    • zoltan@webkit.org's avatar
      [CSS Exclusions] The radius of a circle should be computed based on the shorter available dimension · fda9d1d6
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113255
      
      Reviewed by Julien Chaffraix.
      
      When we decide what should be the radius of a circle, we should choose the smallest available space. For instance when the
      width or height is not resolvable for the circle we should not have a radius for it. This change modifies the behavior to
      use the smaller available space, so we won't render unnecessary circle shapes.
      
      Source/WebCore: 
      
      Test: fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html
      
      * rendering/ExclusionShape.cpp:
      (WebCore::ExclusionShape::createExclusionShape):
      
      LayoutTests: 
      
      * fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fda9d1d6
    • timothy@apple.com's avatar
      Make the Web Inspector console work in strict mode with JavaScriptCore. · da73879a
      timothy@apple.com authored
      https://webkit.org/b/65829
      rdar://problem/11271238
      
      Reviewed by Joseph Pecoraro.
      
      * inspector/InjectedScriptSource.js:
      (InjectedScript.prototype._evaluateOn): Don't use 'eval' parameter (it isn't
      allowed in strict mode). Swap window.eval with our known eval instead.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da73879a
    • jamesr@google.com's avatar
      Clean up last failing expectations from solid color layer patch. · 9d65243a
      jamesr@google.com authored
      * platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
      * platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
      * platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
      * platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
      * platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
      * platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
      * platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
      * platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
      * platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
      * platform/chromium-win/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
      * platform/chromium/TestExpectations:
      * platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d65243a
    • rniwa@webkit.org's avatar
      Heap-use-after-free regression · 0330737c
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113337
      
      Reviewed by Abhishek Arya and Alexey Proskuryakov.
      
      Source/WebCore: 
      
      Use RefPtr instead of raw pointer in m_associatedFormControls.
      
      * dom/Document.cpp:
      (WebCore::Document::didAssociateFormControlsTimerFired):
      * dom/Document.h:
      (Document):
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::didAssociateFormControls):
      * page/ChromeClient.h:
      (WebCore::ChromeClient::didAssociateFormControls):
      
      Source/WebKit/chromium: 
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::didAssociateFormControls):
      * src/ChromeClientImpl.h:
      (ChromeClientImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0330737c
    • commit-queue@webkit.org's avatar
      [BlackBerry] Include accelerated compositing layers in screen captures. · 6f270615
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113335
      
      Patch by Mike Lattanzio <mlattanzio@blackberry.com> on 2013-03-26
      Reviewed by Rob Buis.
      
      PR# 280374
      Include accelerated compositing layers in screen captures.
      Reviewed Internally By: Jakob Petsovits
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::render):
      (BlackBerry::WebKit::BackingStorePrivate::renderContents):
      (BlackBerry::WebKit::BackingStore::drawContents):
      * Api/BackingStore_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f270615
    • fpizlo@apple.com's avatar
      JSC_enableProfiler=true should also cause JSGlobalData to save the profiler output somewhere · a6734fcb
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113144
      
      Reviewed by Geoffrey Garen.
              
      Forgot to include Geoff's requested change in the original commit.
      
      * profiler/ProfilerDatabase.cpp:
      (Profiler):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6734fcb
    • fpizlo@apple.com's avatar
      JSC_enableProfiler=true should also cause JSGlobalData to save the profiler output somewhere · 7183460c
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113144
      
      Source/JavaScriptCore: 
      
      Reviewed by Geoffrey Garen.
              
      Added the ability to save profiler output with JSC_enableProfiler=true. It will save it
      to the current directory, or JSC_PROFILER_PATH if the latter was specified.
              
      This works by saving the Profiler::Database either when it is destroyed or atexit(),
      whichever happens first.
              
      This allows use of the profiler from any WebKit client.
      
      * jsc.cpp:
      (jscmain):
      * profiler/ProfilerDatabase.cpp:
      (Profiler):
      (JSC::Profiler::Database::Database):
      (JSC::Profiler::Database::~Database):
      (JSC::Profiler::Database::registerToSaveAtExit):
      (JSC::Profiler::Database::addDatabaseToAtExit):
      (JSC::Profiler::Database::removeDatabaseFromAtExit):
      (JSC::Profiler::Database::performAtExitSave):
      (JSC::Profiler::Database::removeFirstAtExitDatabase):
      (JSC::Profiler::Database::atExitCallback):
      * profiler/ProfilerDatabase.h:
      (JSC::Profiler::Database::databaseID):
      (Database):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      
      Source/WTF: 
      
      Reviewed by Geoffrey Garen.
              
      I got tired of the fact that getpid(2) is not a syscall on Windows (unless you do
      _getpid() I believe), so I wrote a header that abstracts it. I also changed existing
      code that uses getpid() to use WTF::getCurrentProcessID().
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/CMakeLists.txt:
      * wtf/MetaAllocator.cpp:
      (WTF::MetaAllocator::dumpProfile):
      * wtf/ProcessID.h: Added.
      (WTF):
      (WTF::getCurrentProcessID):
      * wtf/text/StringImpl.cpp:
      (WTF::StringStats::printStats):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7183460c
    • ap@apple.com's avatar
      Follow-up to: · efab0e3d
      ap@apple.com authored
              <rdar://problem/13194263> Crashes in NetworkProcess due to threading issues
              https://bugs.webkit.org/show_bug.cgi?id=113256
      
              Reviewed by Mark Rowe.
      
              * NetworkProcess/NetworkResourceLoader.h: Added some forgotten OVERRIDEs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efab0e3d
    • commit-queue@webkit.org's avatar
      [BlackBerry] Set mouse document position for mouse event in updateCursor · 0e61ec9b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109094
      
      Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-26
      Reviewed by Rob Buis.
      
      Internally Reviewed by Jakob Petsovits.
      
      Mouse content position should be in document coordinate.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::updateCursor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e61ec9b
    • ap@apple.com's avatar
      <rdar://problem/13194263> Crashes in NetworkProcess due to threading issues · cd1fa45e
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=113256
      
              Reviewed by Brady Eidson.
      
              Added a new code path in ResourceHandle/ResourceHandleClient that doesn't need
              blocking calls. Implemented it for NSURLConnection by changing NSOperationQueue
              version to forward calls to main thread.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd1fa45e
    • timothy_horton@apple.com's avatar
      [wk2] Don't send intrinsic content size updates more than once per runloop · 9ea07bb5
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113258
      <rdar://problem/13492038>
      
      Reviewed by Simon Fraser.
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
      Only start the zero-delay timer if it's not already active.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ea07bb5
    • csaavedra@igalia.com's avatar
      Convert test from UTF-16 to UTF-8 · 5f297c9e
      csaavedra@igalia.com authored
      Rubber stamped by James Robinson.
      
      * fast/dom/34176.html: Convert from little endian UTF-16 to UTF-8
      to make git diff happy.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f297c9e
    • jparent@chromium.org's avatar
      Flakiness dashboard: simplify logic around which tests to show. · 7c901662
      jparent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113250
      
      Reviewed by Ojan Vafai.
      
      The different filters for showing results are only used for layout
      tests, otherwise, we show everything.
      
      Change the defaults to false (what layout tests used), and only
      look at the values when viewing layout tests.
      
      * TestResultServer/static-dashboards/flakiness_dashboard.js:
      (htmlForTestsWithExpectationsButNoFailures):
      (shouldHideTest):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c901662
    • alokp@chromium.org's avatar
      Rebaseline text output for opaque GraphicsLayers · 5b2faeab
      alokp@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109507
      
      Unreviewed rebaseline.
      
      * platform/chromium-linux-x86/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Removed.
      * platform/chromium-linux/compositing/overflow/composited-scrolling-paint-phases-expected.txt:
      * platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
      * platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
      * platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
      * platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-mac/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt.
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
      * platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-win/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt.
      * platform/chromium/TestExpectations:
      * platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
      * platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
      * platform/chromium/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
      * platform/chromium/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
      * platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
      * platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
      * platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
      * platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
      * platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
      * platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b2faeab
    • tony@chromium.org's avatar
      Autogenerate the scrollAnimatorEnabled setting in Settings.in · 82972d0f
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113253
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Convert scrollAnimatorEnabled into an autogenerated setting. This involves renaming
      the setter from setEnableScrollAnimator(bool) to setScrollAnimatorEnabled(bool) and
      updating the callers. I didn't change any WebKit API methods.
      
      Also remove the code in InternalSettings since it's never used and will now be
      autogenerated with proper resetting code.
      
      No new tests, this is a refactor and should compile.
      
      * page/Settings.cpp:
      (WebCore::Settings::Settings): Remove code that is now autogenerated.
      * page/Settings.h:
      (Settings): Remove code that is now autogenerated.
      * page/Settings.in: Add entry for scrollAnimatorEnabled.
      * testing/InternalSettings.cpp: Remove unused code.
      * testing/InternalSettings.h: Remove unused code.
      * testing/InternalSettings.idl: Remove unused code.
      
      Source/WebKit/chromium:
      
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::setEnableScrollAnimator): Update call to WebCore to use setScrollAnimatorEnabled(bool).
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebview.cpp:
      (webkit_web_view_update_settings): Update call to WebCore to use setScrollAnimatorEnabled(bool).
      (webkit_web_view_settings_notify): Update call to WebCore to use setScrollAnimatorEnabled(bool).
      
      Source/WebKit/qt:
      
      * Api/qwebsettings.cpp:
      (QWebSettingsPrivate::apply): Update call to WebCore to use setScrollAnimatorEnabled(bool).
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::setUseFixedLayout): Update call to WebCore to use setScrollAnimatorEnabled(bool).
      (WebKit::WebPage::updatePreferences): Update call to WebCore to use setScrollAnimatorEnabled(bool).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82972d0f
    • rafaelw@chromium.org's avatar
      Remove stray newline. This newline is messing up mozilla's test harness · 7fb5e702
      rafaelw@chromium.org authored
      and we share this file with them via html5lib.
      
      * html5lib/resources/template.dat:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fb5e702
    • commit-queue@webkit.org's avatar
      [BlackBerry] In RSSFilterStream, don't swallow headers when there's no body · 95e1ba28
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113334
      
      Patch by Joe Mason <jmason@blackberry.com> on 2013-03-26
      Reviewed by Rob Buis.
      
      RIM PR 316345
      
      When receiving an HTTP response that has a Content-Type header such as text/xml, but no
      body, RSSFilterStream::notifyHeadersReceived reads the Content-Type as "potential RSS", and
      calls saveHeaders. It expects to sniff the body in notifyDataReceived to see if it's RSS,
      and then call sendSavedHeaders to pass on the headers. But since there is no body,
      notifyDataReceived is never called. So call sendSavedHeaders in notifyClose too (it will not
      send them again if they were already sent.)
      
      * platform/network/blackberry/rss/RSSFilterStream.cpp:
      (WebCore::RSSFilterStream::notifyClose):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95e1ba28
    • commit-queue@webkit.org's avatar
      Update bots on test-results.appspot · db5d7e2f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113333
      
      Patch by Isaac Levy <ilevy@google.com> on 2013-03-26
      Reviewed by Ojan Vafai.
      
      * TestResultServer/static-dashboards/builders.jsonp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db5d7e2f
    • commit-queue@webkit.org's avatar
      Web Inspector: Faster drawer animation. · c3cb279b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113330
      
      250ms -> 100ms
      
      Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-26
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/inspector.css:
      (.animate #main):
      (.animate #floating-status-bar-container):
      (.animate #drawer):
      (.animate #bottom-status-bar-container > *):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3cb279b
    • tony@chromium.org's avatar
      [chromium] Expose setSelectionIncludesAltImageText in WebSettings · 35db81ac
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113316
      
      Reviewed by Dimitri Glazkov.
      
      Enabling this setting allows plain text clipboard content to include alt
      text like on Firefox and IE10.
      
      * public/WebSettings.h:
      (WebSettings):
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::setSelectionIncludesAltImageText):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35db81ac
    • rniwa@webkit.org's avatar
      Remove some entries since those tests have been passing. · 9f73ae37
      rniwa@webkit.org authored
      Also update the test expectations for the bug 113227 flaky since they're passing most of the time.
      
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f73ae37
    • abecsi@webkit.org's avatar
      [Qt][WK2] Fails to start QtWebProcess.exe if installed in a path containing spaces · f5389721
      abecsi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113328
      
      Reviewed by Jocelyn Turcotte.
      
      Downstream bugreport: https://bugreports.qt-project.org/browse/QTBUG-30249
      
      We use QProcess::start() with a commandline string to start the web process
      and the string is treated by QProcess as a whitespace delimeted list of the
      command and the arguments, thus we have to escape the path to the process
      binaries so that if the path contains spaces we still run the appropriate
      command.
      
      * UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
      (WebKit::ProcessLauncher::launchProcess):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5389721
    • abecsi@webkit.org's avatar
      [Qt][WK2] QML WebView asserts when double clicking a link · 86ae9002
      abecsi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113329
      
      Reviewed by Jocelyn Turcotte.
      
      Downstream bugreport: https://bugreports.qt-project.org/browse/QTBUG-30288
      
      Remove an erroneous assert which is no longer valid if
      mouse gestures are enabled.
      
      * UIProcess/qt/QtWebPageEventHandler.cpp:
      (WebKit::QtWebPageEventHandler::handleInputEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86ae9002
    • timothy_horton@apple.com's avatar
      [wk2] Don't send intrinsic content size updates more than once per runloop · 07ab50b1
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113258
      <rdar://problem/13492038>
      
      Reviewed by Anders Carlsson.
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
      (TiledCoreAnimationDrawingArea):
      Add a zero-delay timer for intrinsic content size updates.
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
      Add a zero-delay timer for intrinsic content size updates.
      (WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
      Start our new one-shot zero-delay timer.
      (WebKit::TiledCoreAnimationDrawingArea::updateIntrinsicContentSizeTimerFired):
      Inform the WebPage that the intrinsic content size has changed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07ab50b1
    • bfulgham@webkit.org's avatar
      [WinCairo] Unreviewed Build fix. · a869baca
      bfulgham@webkit.org authored
      * platform/graphics/win/FontCustomPlatformDataCairo.h:
      (FontCustomPlatformData): Correct signature in header to match
      required implementation.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a869baca
    • anilsson@rim.com's avatar
      [BlackBerry] Scrolling up and down can cause the screen to flash black · cd289bab
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113269
      
      Reviewed by Rob Buis.
      
      PR 296106
      
      Source/WebCore:
      
      The LayerRenderer should never clear before drawing the layers, from
      now on that's the responsibility of the caller.
      
      Only manually testable.
      
      * platform/graphics/blackberry/LayerRenderer.cpp:
      (WebCore::LayerRenderer::setViewport):
      * platform/graphics/blackberry/LayerRendererClient.h:
      (LayerRendererClient):
      
      Source/WebKit/blackberry:
      
      Various flaws in the code could conspire to make the screen cleared to
      black before rendering the web page. This only happened when the
      BackingStore was inactive, and the LayerTiler takes on the job of
      drawing the root layer. When tiles are missing, this made the
      "checkerboard" effect especially noticeable since black color was seen
      where the tile should have been. It would be better to clear to the web
      page background color.
      
      This was actually the intent of the code, but when the document
      background color was invalid, we would still use it instead of the
      background color from settings. Also, the LayerRenderer would clear to
      black when WebPageCompositorPrivate::drawsRootLayer() was true.
      
      Fixed by falling back to the settings background color when the
      document background color is invalid, and removing the clearing code
      from the LayerRenderer entirely. The appropriate clear already happens
      near the beginning of BackingStorePrivate::blitVisibleContents().
      
      Also slightly cleaned up the code for managing the background color.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::setLoadState):
      (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
      (BlackBerry::WebKit::WebPagePrivate::updateBackgroundColor):
      (WebKit):
      (BlackBerry::WebKit::WebPagePrivate::documentBackgroundColor):
      * Api/WebPageCompositor.cpp:
      * Api/WebPageCompositor_p.h:
      (WebPageCompositorPrivate):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd289bab
    • allan.jensen@digia.com's avatar
      [Qt] editing/pasteboard/can-read-in-dragstart-event.html and... · 7bc0f8b1
      allan.jensen@digia.com authored
      [Qt] editing/pasteboard/can-read-in-dragstart-event.html and /can-read-in-copy-and-cut-events.html are crashing
      https://bugs.webkit.org/show_bug.cgi?id=113126
      
      Reviewed by Jocelyn Turcotte.
      
      Source/WebCore:
      
      Make it possible to read from a writable Clipboard.
      
      Test: editing/pasteboard/can-read-in-copy-and-cut-events.html
      
      * platform/qt/ClipboardQt.cpp:
      (WebCore::ClipboardQt::getData):
      (WebCore::ClipboardQt::types):
      (WebCore::ClipboardQt::files):
      (WebCore::ClipboardQt::readClipboardData):
      (WebCore::ClipboardQt::hasData):
      (WebCore::ClipboardQt::items):
      * platform/qt/ClipboardQt.h:
      (ClipboardQt):
      
      LayoutTests:
      
      Unskip now working editing/pasteboard/can-read-in-copy-and-cut-events.html.
      The other test still needs better drag-and-drop support in DRT.
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bc0f8b1
    • bfulgham@webkit.org's avatar
      [WinCairo] Unreviewed build correction. · 7e43ef59
      bfulgham@webkit.org authored
      * platform/graphics/win/FontCustomPlatformDataCairo.cpp:
      (WebCore::FontCustomPlatformData::fontPlatformData): Update
      method signature to match CG variant.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e43ef59