1. 07 Apr, 2013 7 commits
    • ddkilzer@apple.com's avatar
      Remove the rest of SVG_DOM_OBJC_BINDINGS · 0cd46787
      ddkilzer@apple.com authored
      <http://webkit.org/b/114112>
      
      Reviewed by Geoffrey Garen.
      
      .:
      
      * Source/autotools/SetupWebKitFeatures.m4:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      - Remove references to ENABLE_SVG_DOM_OBJC_BINDINGS.
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      - Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
      
      Source/WebCore:
      
      * Configurations/WebCore.xcconfig:
      - Remove EXCLUDED_SOURCE_FILE_NAMES_SVG_DOM_OBJC_BINDINGS.  Note
        that DOMHTMLIFrameElementPrivate.h should not have been in
        this list because the class contained methods other than just
        -getSVGDocument.
      
      * WebCore.xcodeproj/project.pbxproj:
      - Remove DOMHTMLFrameElementPrivate.h since the only method it
        contained was -[DOMHTMLFrameElement getSVGDocument], which was
        part of the SVG DOM Objective-C bindings.
      
      * bindings/objc/DOM.mm:
      (kitClass):
      * bindings/objc/DOMEvents.mm:
      (kitClass):
      * bindings/objc/ExceptionHandlers.mm:
      (WebCore::raiseDOMException):
      - Remove code in ENABLE(SVG_DOM_OBJC_BINDINGS).
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/AboutDataEnableFeatures.in:
      - Remove reference to SVG_DOM_OBJC_BINDINGS.
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      - Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
      
      Source/WTF:
      
      * wtf/FeatureDefines.h:
      - Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
      
      Tools:
      
      * Scripts/webkitperl/FeatureList.pm:
      - Remove --svg-dom-objc-bindings switch.
      * qmake/mkspecs/features/features.pri:
      - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cd46787
    • oliver@apple.com's avatar
      Inspector should display information about non-object exceptions · 5683d16e
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114123
      
      Reviewed by Adele Peterson.
      
      Source/JavaScriptCore:
      
      Make sure we store the right stack information, even when throwing
      a primitive.
      
      * interpreter/CallFrame.h:
      (JSC::ExecState::clearSupplementaryExceptionInfo):
      (ExecState):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::addStackTraceIfNecessary):
      (JSC::Interpreter::throwException):
      
      Source/WebCore:
      
      Make use of the stack trace for line information when we're reporting
      an exception
      
      * bindings/js/JSDOMBinding.cpp:
      (WebCore::reportException):
      
      LayoutTests:
      
      All these tests throw primitives as exceptions, and now they have source
      and line number information
      
      * fast/dom/exception-getting-event-handler-expected.txt:
      * fast/dom/javascript-url-exception-isolation-expected.txt:
      * fast/dom/nested-script-exceptions-expected.txt:
      * fast/events/onerror-no-constructor-expected.txt:
      * fast/events/window-onerror13-expected.txt:
      * fast/events/window-onerror16-expected.txt:
      * fast/events/window-onerror2-expected.txt:
      * fast/events/window-onerror8-expected.txt:
      * fast/js/uncaught-exception-line-number-expected.txt:
      * fast/sub-pixel/inline-block-with-padding-expected.txt:
      * platform/mac/fast/AppleScript/001-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5683d16e
    • robert@webkit.org's avatar
      table element may get larger when its contents are recreated · 882cee02
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111342
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Remove anonymous table section wrappers when destroying their children.
      
      Test: fast/table/anonymous-table-section-removed.html
      
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
      
      LayoutTests:
      
      * fast/table/anonymous-table-section-removed-expected.txt: Added.
      * fast/table/anonymous-table-section-removed.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      882cee02
    • paroga@webkit.org's avatar
      [WIN] Fix build without precompiled header after r145827. · b85be7ec
      paroga@webkit.org authored
      * platform/ContextMenuItem.h:
      * platform/PlatformMenuDescription.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b85be7ec
    • paroga@webkit.org's avatar
      Fix compilation of LocaleWin with !ENABLE(CALENDAR_PICKER) && !ENABLE(DATE_AND_TIME_INPUT_TYPES) · 784b70c7
      paroga@webkit.org authored
      * platform/text/win/LocaleWin.cpp:
      (WebCore::LocaleWin::ensureShortMonthLabels):
      (WebCore):
      (WebCore::LocaleWin::ensureMonthLabels):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      784b70c7
    • paroga@webkit.org's avatar
      [WIN] Fix build without precompiled header after r144216. · cb273ca5
      paroga@webkit.org authored
      * platform/network/cf/FormDataStreamCFNet.h:
      * platform/network/mac/FormDataStreamMac.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb273ca5
    • commit-queue@webkit.org's avatar
      Source/WebCore: [EFL] --minimal build fails with error:... · d036cc8c
      commit-queue@webkit.org authored
      Source/WebCore: [EFL] --minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
      https://bugs.webkit.org/show_bug.cgi?id=114089
      
      Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
      Reviewed by Chris Fleizach.
      
      Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::setSelection):
      * editing/FrameSelection.h:
      (WebCore):
      
      Tools: [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
      https://bugs.webkit.org/show_bug.cgi?id=114089
      
      Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
      Reviewed by Chris Fleizach.
      
      Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
      * DumpRenderTree/AccessibilityController.cpp:
      * DumpRenderTree/AccessibilityUIElement.cpp:
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (DumpRenderTreeChrome::DumpRenderTreeChrome):
      * DumpRenderTree/efl/DumpRenderTreeChrome.h:
      (DumpRenderTreeChrome):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d036cc8c
  2. 06 Apr, 2013 19 commits
    • benjamin@webkit.org's avatar
      Get rid of skia · 436c40d4
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114108
      
      Reviewed by Anders Carlsson.
      
      * platform/graphics/filters/skia/*: Removed.
      * platform/graphics/skia/*: Removed.
      * platform/image-decoders/skia/*: Removed.
      * platform/image-encoders/skia/*: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      436c40d4
    • benjamin@webkit.org's avatar
      Remove the chromium code from platform/graphics/mac · 676049f6
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114107
      
      Reviewed by Anders Carlsson.
      
      * platform/graphics/mac/FontCacheMac.mm:
      (WebCore::FontCache::getFontDataForCharacters):
      (WebCore::FontCache::createFontPlatformData):
      * platform/graphics/mac/FontComplexTextMac.cpp:
      (WebCore::Font::selectionRectForComplexText):
      (WebCore::Font::drawComplexText):
      (WebCore::Font::floatWidthForComplexText):
      (WebCore::Font::offsetForPositionForComplexText):
      * platform/graphics/mac/FontMac.mm:
      (WebCore::hasBrokenCTFontGetVerticalTranslationsForGlyphs):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      676049f6
    • benjamin@webkit.org's avatar
      Clean platform/graphics/cg of the chromium bits · e9f8cde6
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114106
      
      Reviewed by Anders Carlsson.
      
      * platform/graphics/cg/BitmapImageCG.cpp:
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::roundToDevicePixels):
      * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
      (GraphicsContextPlatformPrivate):
      * platform/graphics/cg/ImageBufferCG.cpp:
      * platform/graphics/cg/ImageCG.cpp:
      * platform/graphics/cg/PathCG.cpp:
      * platform/graphics/cg/PatternCG.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9f8cde6
    • timothy@apple.com's avatar
      Remove InjectedScriptHost.evaluateReturnsEvalFunction. · ca0a9402
      timothy@apple.com authored
      https://webkit.org/b/114099
      
      Source/WebCore:
      
      * inspector/InjectedScriptHost.h:
      (InjectedScriptHost):
      * inspector/InjectedScriptHost.idl:
      * inspector/InjectedScriptSource.js:
      (InjectedScript.prototype._evaluateOn):
      
      LayoutTests:
      
      Reviewed by Joseph Pecoraro.
      
      * inspector/console/command-line-api-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca0a9402
    • benjamin@webkit.org's avatar
      Remove the chromium code from WebCore/platform/mac · 473b21d5
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114104
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-06
      Reviewed by Sam Weinig.
      
      * platform/mac/NSScrollerImpDetails.h:
      (WebCore::isScrollbarOverlayAPIAvailable):
      * platform/mac/NSScrollerImpDetails.mm:
      * platform/mac/ScrollAnimatorMac.mm:
      (-[WebScrollbarPainterDelegate layer]):
      (WebCore::scrollAnimationEnabledForSystem):
      * platform/mac/ScrollElasticityController.mm:
      (WebCore):
      * platform/mac/ScrollbarThemeMac.h:
      (ScrollbarThemeMac):
      * platform/mac/ScrollbarThemeMac.mm:
      (WebCore::ScrollbarTheme::nativeTheme):
      (WebCore::ScrollbarThemeMac::paint):
      (WebCore):
      * platform/mac/ThemeMac.mm:
      (WebCore::ThemeMac::ensuredView):
      * platform/mac/WebCoreNSCellExtras.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      473b21d5
    • benjamin@webkit.org's avatar
      Remove the Chromium code from Mac's FontPlatformData · aac92bbe
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114103
      
      Reviewed by Sam Weinig.
      
      * platform/graphics/FontPlatformData.h:
      (WebCore):
      (FontPlatformData):
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      (WebCore::FontPlatformData::FontPlatformData):
      (WebCore::FontPlatformData::platformDataInit):
      (WebCore::FontPlatformData::platformDataAssign):
      (WebCore::FontPlatformData::setFont):
      (WebCore::FontPlatformData::ctFont):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aac92bbe
    • oliver@apple.com's avatar
      Unify the many and varied stack trace mechanisms, and make the result sane. · e47f99da
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114072
      
      Reviewed by Filip Pizlo.
      
      Source/JavaScriptCore:
      
      Makes JSC::StackFrame record the bytecode offset and other necessary data
      rather than requiring us to perform eager evaluation of the line number, etc.
      Then remove most of the users of retrieveLastCaller, as most of them were
      using it to create a stack trace in a fairly incomplete and inefficient way.
      
      StackFrame now also has a couple of helpers to get the line and column info.
      
      * API/JSContextRef.cpp:
      (JSContextCreateBacktrace):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::emitDebugHook):
      * interpreter/Interpreter.cpp:
      (JSC):
      (JSC::Interpreter::dumpRegisters):
      (JSC::Interpreter::unwindCallFrame):
      (JSC::getBytecodeOffsetForCallFrame):
      (JSC::getCallerInfo):
      (JSC::StackFrame::line):
      (JSC::StackFrame::column):
      (JSC::StackFrame::expressionInfo):
      (JSC::StackFrame::toString):
      (JSC::Interpreter::getStackTrace):
      (JSC::Interpreter::addStackTraceIfNecessary):
      (JSC::Interpreter::retrieveCallerFromVMCode):
      * interpreter/Interpreter.h:
      (StackFrame):
      (Interpreter):
      * runtime/Error.cpp:
      (JSC::throwError):
      * runtime/JSGlobalData.h:
      (JSC):
      (JSGlobalData):
      * runtime/JSGlobalObject.cpp:
      (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
      
      Source/WebCore:
      
      Now that we've fleshed out the StackFrames from Interpreter::getStackTrace
      WebCore can just ask us for a stack trace rather than implementing its own
      stack walking.
      
      * bindings/js/ScriptCallStackFactory.cpp:
      (WebCore::createScriptCallStack):
      * inspector/ScriptCallFrame.cpp:
      (WebCore::ScriptCallFrame::isEqual):
      * inspector/ScriptCallFrame.h:
      (ScriptCallFrame):
      (WebCore::ScriptCallFrame::columnNumber):
      
      Tools:
      
      The commandline jsc executable no longer requires arguments, so
      I've made run-jsc work without them.
      
      * Scripts/run-jsc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e47f99da
    • weinig@apple.com's avatar
      Removed v8 bindings hooks from IDL files · 007c2427
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114091
      
      Patch by Geoffrey Garen <ggaren@apple.com> on 2013-04-06
      Reviewed by Anders Carlsson and Sam Weinig.
      
      Source/JavaScriptCore: 
      
      * heap/HeapStatistics.h:
      
      Source/WebCore: 
      
      * Modules/encryptedmedia/MediaKeySession.idl:
      * Modules/filesystem/DOMWindowFileSystem.idl:
      * Modules/filesystem/WorkerContextFileSystem.idl:
      * Modules/gamepad/NavigatorGamepad.idl:
      * Modules/geolocation/NavigatorGeolocation.idl:
      * Modules/indexeddb/DOMWindowIndexedDatabase.idl:
      * Modules/indexeddb/WorkerContextIndexedDatabase.idl:
      * Modules/mediastream/DOMWindowMediaStream.idl:
      * Modules/mediastream/NavigatorMediaStream.idl:
      * Modules/notifications/DOMWindowNotifications.idl:
      * Modules/notifications/NotificationCenter.idl:
      * Modules/notifications/WorkerContextNotifications.idl:
      * Modules/quota/DOMWindowQuota.idl:
      * Modules/speech/DOMWindowSpeech.idl:
      * Modules/webaudio/AudioBufferSourceNode.idl:
      * Modules/webaudio/AudioContext.idl:
      * Modules/webaudio/AudioParam.idl:
      * Modules/webaudio/DOMWindowWebAudio.idl:
      * Modules/webdatabase/DOMWindowWebDatabase.idl:
      * Modules/webdatabase/WorkerContextWebDatabase.idl:
      * Modules/websockets/DOMWindowWebSocket.idl:
      * Modules/websockets/WorkerContextWebSocket.idl:
      * bindings/js/JSDOMBinding.cpp:
      * bindings/js/ScriptController.h:
      (ScriptController):
      * bindings/scripts/test/TestNode.idl:
      * bindings/scripts/test/TestObj.idl:
      * css/CSSFontFaceLoadEvent.idl:
      * css/CSSHostRule.idl:
      * css/CSSRule.idl:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSStyleSheet.idl:
      * css/CSSValue.idl:
      * css/FontLoader.idl:
      * css/StyleSheet.idl:
      * css/WebKitCSSRegionRule.idl:
      * dom/Clipboard.idl:
      * dom/CustomElementConstructor.idl:
      * dom/CustomEvent.idl:
      * dom/DOMNamedFlowCollection.idl:
      * dom/DOMStringMap.idl:
      * dom/DataTransferItemList.idl:
      * dom/Document.idl:
      * dom/DocumentFragment.idl:
      * dom/Element.idl:
      * dom/Event.idl:
      * dom/EventTarget.idl:
      * dom/MessageChannel.idl:
      * dom/MouseEvent.idl:
      * dom/MutationRecord.idl:
      * dom/NamedNodeMap.idl:
      * dom/Node.idl:
      * dom/NodeList.idl:
      * dom/RequestAnimationFrameCallback.idl:
      * dom/ShadowRoot.idl:
      * dom/Text.idl:
      * history/HistoryItem.cpp:
      (WebCore::HistoryItem::encodeBackForwardTreeNode):
      (WebCore::HistoryItem::decodeBackForwardTree):
      * html/DOMSettableTokenList.idl:
      * html/DOMTokenList.idl:
      * html/HTMLAllCollection.idl:
      * html/HTMLAppletElement.idl:
      * html/HTMLCollection.idl:
      * html/HTMLDialogElement.idl:
      * html/HTMLDivElement.idl:
      * html/HTMLDocument.idl:
      * html/HTMLElement.idl:
      * html/HTMLEmbedElement.idl:
      * html/HTMLFormControlsCollection.idl:
      * html/HTMLFormElement.idl:
      * html/HTMLImageElement.idl:
      * html/HTMLInputElement.idl:
      * html/HTMLMediaElement.idl:
      * html/HTMLObjectElement.idl:
      * html/HTMLOptionsCollection.idl:
      * html/HTMLSelectElement.idl:
      * html/HTMLSpanElement.idl:
      * html/HTMLStyleElement.idl:
      * html/HTMLTemplateElement.idl:
      * html/HTMLTrackElement.idl:
      * html/HTMLUnknownElement.idl:
      * html/MediaKeyError.idl:
      * html/MediaKeyEvent.idl:
      * html/MicroDataItemValue.idl:
      * html/canvas/CanvasRenderingContext2D.idl:
      * html/canvas/DOMPath.idl:
      * html/shadow/HTMLContentElement.idl:
      * html/shadow/HTMLShadowElement.idl:
      * html/track/TextTrack.idl:
      * inspector/InjectedScriptHost.idl:
      * inspector/InspectorIndexedDBAgent.cpp:
      (WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
      (WebCore::InspectorIndexedDBAgent::requestDatabase):
      (WebCore::InspectorIndexedDBAgent::requestData):
      (WebCore::InspectorIndexedDBAgent::clearObjectStore):
      (WebCore):
      * loader/EmptyClients.h:
      (EmptyFrameLoaderClient):
      * loader/FrameLoaderClient.h:
      (FrameLoaderClient):
      * page/Console.idl:
      * page/DOMWindow.idl:
      * page/DOMWindowPagePopup.idl:
      * page/History.idl:
      * page/Location.idl:
      * platform/graphics/skia/PatternSkia.cpp:
      (WebCore::Pattern::platformDestroy):
      (WebCore::Pattern::platformPattern):
      * testing/Internals.cpp:
      (WebCore::Internals::serializeObject):
      (WebCore::Internals::deserializeBuffer):
      
      Source/WTF: 
      
      * wtf/ArrayBuffer.h:
      (WTF):
      (WTF::ArrayBufferContents::ArrayBufferContents):
      (WTF::ArrayBufferContents::transfer):
      (ArrayBufferContents):
      (ArrayBuffer):
      (WTF::ArrayBufferContents::~ArrayBufferContents):
      * wtf/Platform.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      007c2427
    • zandobersek@gmail.com's avatar
      Remove the USE(SKIA_ON_MAC_CHROMIUM) guards · ccac1ab8
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114084
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore: 
      
      Remove the USE(SKIA_ON_MAC_CHROMIUM) guards. The guards were enabled only
      for the Chromium port via the features.gypi file that was removed in r147714.
      
      * platform/graphics/FloatPoint.h:
      (FloatPoint):
      * platform/graphics/FloatRect.h:
      (FloatRect):
      * platform/graphics/FloatSize.h:
      (FloatSize):
      * platform/graphics/FontPlatformData.cpp:
      (WebCore):
      * platform/graphics/FontPlatformData.h:
      (FontPlatformData):
      (WebCore::FontPlatformData::hash):
      * platform/graphics/IntPoint.h:
      (IntPoint):
      * platform/graphics/IntRect.h:
      (IntRect):
      (WebCore):
      * platform/graphics/IntSize.h:
      (IntSize):
      * platform/graphics/SimpleFontData.h:
      (SimpleFontData):
      (WebCore::SimpleFontData::widthForGlyph):
      * platform/graphics/cg/FloatPointCG.cpp:
      * platform/graphics/cg/FloatRectCG.cpp:
      * platform/graphics/cg/FloatSizeCG.cpp:
      * platform/graphics/cg/IntPointCG.cpp:
      * platform/graphics/cg/IntRectCG.cpp:
      * platform/graphics/cg/IntSizeCG.cpp:
      * platform/graphics/mac/FontCustomPlatformData.cpp:
      (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
      (WebCore::createFontCustomPlatformData):
      * platform/graphics/mac/FontCustomPlatformData.h:
      (WebCore::FontCustomPlatformData::FontCustomPlatformData):
      (FontCustomPlatformData):
      
      Source/WebKit/blackberry: 
      
      * WebCoreSupport/AboutDataUseFeatures.in: Remove the SKIA_ON_MAC_(CHROME|CHROMIUM) reference.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccac1ab8
    • robert@webkit.org's avatar
      REGRESSION(r142152): Text wraps in menu · 4a019977
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113706
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
      line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
      from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)
      
      LayoutTests:
      
      * fast/inline/inline-with-empty-inline-children-expected.txt:
      * fast/inline/inline-with-empty-inline-children.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a019977
    • ggaren@apple.com's avatar
      Rolled out 147820 and 147818 because they caused plugins tests to ASSERT · 51a9926e
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114094
      
      Reviewed by Anders Carlsson.
      
      Source/JavaScriptCore: 
      
      * API/JSContextRef.cpp:
      (JSContextCreateBacktrace):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::emitDebugHook):
      * interpreter/Interpreter.cpp:
      (JSC):
      (JSC::Interpreter::dumpRegisters):
      (JSC::Interpreter::unwindCallFrame):
      (JSC::getLineNumberForCallFrame):
      (JSC::getCallerInfo):
      (JSC::Interpreter::getStackTrace):
      (JSC::Interpreter::addStackTraceIfNecessary):
      (JSC::Interpreter::retrieveCallerFromVMCode):
      * interpreter/Interpreter.h:
      (StackFrame):
      (JSC::StackFrame::toString):
      (JSC::StackFrame::friendlyLineNumber):
      (Interpreter):
      * runtime/Error.cpp:
      (JSC::throwError):
      * runtime/JSGlobalData.h:
      (JSC):
      (JSGlobalData):
      * runtime/JSGlobalObject.cpp:
      (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
      
      Source/WebCore: 
      
      * bindings/js/ScriptCallStackFactory.cpp:
      (WebCore::createScriptCallStack):
      * inspector/ScriptCallFrame.cpp:
      (WebCore::ScriptCallFrame::isEqual):
      * inspector/ScriptCallFrame.h:
      (ScriptCallFrame):
      (WebCore::ScriptCallFrame::lineNumber):
      
      Tools: 
      
      * Scripts/run-jsc:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51a9926e
    • andersca@apple.com's avatar
      Remove VisitedLinks.{cpp|h} · b929df99
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114095
      
      Reviewed by Geoffrey Garen.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/VisitedLinks.cpp: Removed.
      * platform/VisitedLinks.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b929df99
    • andersca@apple.com's avatar
      Another build fix. · c2e2c9f0
      andersca@apple.com authored
      Actually remove the right files from WebCore.vcxproj.
      
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2e2c9f0
    • andersca@apple.com's avatar
      Fix build. · c0be7fd4
      andersca@apple.com authored
      ThreadableLoaderClientWrapper was still calling didReceiveCachedMetadata; I didn't notice it
      because the file was not in the Xcode project so I went ahead and added it.
      
      * WebCore.xcodeproj/project.pbxproj:
      * loader/ThreadableLoaderClientWrapper.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0be7fd4
    • andersca@apple.com's avatar
      Remove dead CachedMetadata code · aaa40dd2
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114093
      
      Reviewed by Geoffrey Garen.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * loader/CachedMetadata.cpp: Removed.
      * loader/CachedMetadata.h: Removed.
      * loader/ResourceLoader.h:
      (ResourceLoader):
      * loader/SubresourceLoader.cpp:
      * loader/SubresourceLoader.h:
      (SubresourceLoader):
      * loader/ThreadableLoaderClient.h:
      * loader/WorkerThreadableLoader.cpp:
      * loader/WorkerThreadableLoader.h:
      (MainThreadBridge):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::reportMemoryUsage):
      * loader/cache/CachedResource.h:
      (WebCore):
      (CachedResource):
      * platform/network/ResourceHandle.cpp:
      * platform/network/ResourceHandle.h:
      (ResourceHandle):
      * platform/network/ResourceHandleClient.h:
      (ResourceHandleClient):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aaa40dd2
    • andersca@apple.com's avatar
      Remove more dead Chromium code · 5fb14b6d
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114090
      
      Reviewed by Alp Toker.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/StatsCounter.cpp: Removed.
      * platform/StatsCounter.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fb14b6d
    • paroga@webkit.org's avatar
      Build fix for WinCE after r143046. · 2b1fd505
      paroga@webkit.org authored
      * platform/graphics/wince/ImageWinCE.cpp:
      (WebCore::Image::drawPattern):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b1fd505
    • paroga@webkit.org's avatar
      [WinCE] Do not call missing method createDragImageFromImage() · d08db733
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110421
      
      Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-06
      
      * platform/win/ClipboardWin.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d08db733
    • paroga@webkit.org's avatar
      [WinCE] Compile missing NetworkStorageSession methods · 8cd7c650
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110419
      
      Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-05
      
      * PlatformWinCE.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cd7c650
  3. 05 Apr, 2013 14 commits
    • kangil.han@samsung.com's avatar
      Prefer prefix ++/-- operators for non-primitive types · d97b4ea1
      kangil.han@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114033
      
      Reviewed by Alexey Proskuryakov.
      
      Post ++/-- creates a copy of current value and it is not necessary, so use prefix instead.
      
      * bindings/js/Dictionary.cpp:
      (WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
      (WebCore::Dictionary::getOwnPropertyNames):
      * bindings/js/ScriptCallStackFactory.cpp:
      (WebCore::createScriptCallStack):
      * dom/ContainerNode.cpp:
      (WebCore::willRemoveChildren):
      * dom/Range.cpp:
      (WebCore::Range::processAncestorsAndTheirSiblings):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::detachChildren):
      * platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
      (WebCore):
      (WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paintDocumentMarkers):
      * xml/XPathFunctions.cpp:
      (WebCore::XPath::Function::setArguments):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d97b4ea1
    • hmuller@adobe.com's avatar
      [CSS Exclusions] Add support for the simple case of shape-margin polygonal shape-outside · 2a8e9f3b
      hmuller@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113726
      
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Add support for computing the shape-outside shape-margin boundary for a polygon.
      This change is similar to the one added for padding polygons, see bug 112592.
      The algorithm used for computing the margin boundary is is provisional. It works
      correctly for convex polygons and will work correctly for non self-intersecting
      polygons whose margin boundary is the same shape as the original polygon.
      
      Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html
             fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon.html
             fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon.html
      
      * rendering/ExclusionPolygon.cpp:
      (WebCore::appendArc): Generalized this method a little, to deal with margin and padding connecting arcs.
      (WebCore::computeShapePaddingBounds): Pass the new appendArc() parameter.
      (WebCore::computeShapeMarginBounds): Compute the margin boundary for a polygon, per the constraints summarized above.
      (WebCore::ExclusionPolygon::getExcludedIntervals): Use the margin polygon for this computation.
      
      LayoutTests:
      
      Verify that shape-outside layout works correctly on floats, when shape-margin is specifed.
      
      * fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt: Added.
      * fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html: Added.
      * fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon-expected.html: Added.
      * fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon.html: Added.
      * fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon-expected.html: Added.
      * fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a8e9f3b
    • aestes@apple.com's avatar
      Returning NULL from willSendRequest should cancel a load from the memory cache · 0c8e191b
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114075
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      When a resource is loaded from the memory cache and the client does not
      implement the didLoadResourceFromMemoryCache delegate method, WebKit
      synthesizes the typical sequence of resource load callbacks. One of
      these is willSendRequest, which gives the client the opportunity to
      modify the request. We should respect these modifications.
      
      Handling any arbitrary modification is difficult given where in the
      loading process we check the memory cache (see <http://webkit.org/b/113251>),
      but we can handle the common case where the client cancels the load by
      returning a NULL request.
      
      Test: fast/loader/willsendrequest-returns-null-for-memory-cache-load.html
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::willLoadMediaElementURL): Passed request to sendRemainingDelegateMessages.
      (WebCore::FrameLoader::commitProvisionalLoad): Ditto.
      (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
      (WebCore::FrameLoader::loadedResourceFromMemoryCache): Added an out
      parameter to pass back a request potentially modified by
      requestFromDelegate, which is also passed to sendRemainingDelegateMessages.
      * loader/FrameLoader.h:
      * loader/ResourceLoadNotifier.cpp:
      (WebCore::ResourceLoadNotifier::dispatchDidFailLoading): Added a
      function to dispatch didFailLoading and to call the correct InspectorInstrumentation.
      (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages): If the
      request is NULL, call dispatchDidFailLoading and return. This matches
      the delegate callback sequence of a non memory cache load that is
      cancelled by willSendRequest.
      * loader/ResourceLoadNotifier.h:
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
      Return false if the memory cache load is cancelled by the client.
      (WebCore::CachedResourceLoader::requestResource): Return early if
      shouldContinueAfterNotifyingLoadedFromMemoryCache is false.
      
      LayoutTests:
      
      * fast/loader/resources/cached-image.html: Added.
      * fast/loader/willsendrequest-returns-null-for-memory-cache-load-expected.txt: Added.
      * fast/loader/willsendrequest-returns-null-for-memory-cache-load.html: Added.
      * platform/wk2/TestExpectations: Expect the test to fail in WKTR due to <http://webkit.org/b/114074>.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c8e191b
    • cfleizach@apple.com's avatar
      AX: VoiceOver can't press on items · c0bb1500
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114071
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      The AXScrollToVisibleAction should not be used on earlier Mac versions because
      it confuses VoiceOver.
      
      Updated existing tests.
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper accessibilityActionNames]):
      
      LayoutTests:
      
      * platform/mac-future/accessibility: Added.
      * platform/mac-future/accessibility/press-action-is-first-expected.txt: Added.
      * platform/mac/accessibility/press-action-is-first-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0bb1500
    • andersca@apple.com's avatar
      Stop building Objective-C bindings for the SVG DOM · 8b914b1d
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114076
      
      Reviewed by Geoffrey Garen.
      
      The DOM SVG Objective-C bindings have never been exposed as API, and not building them cuts WebCore build by 10%.
      
      Source/WebCore:
      
      * Configurations/FeatureDefines.xcconfig:
      * Configurations/WebCore.xcconfig:
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/objc/DOM.mm:
      (WebCore::createElementClassMap):
      (kitClass):
      * bindings/objc/DOMCSS.mm:
      (kitClass):
      * bindings/objc/DOMEvents.mm:
      * bindings/objc/DOMSVG.h: Removed.
      * bindings/objc/DOMSVGException.h: Removed.
      * bindings/objc/DOMSVGPathSegInternal.mm: Removed.
      * bindings/objc/ExceptionHandlers.mm:
      * html/HTMLEmbedElement.idl:
      * html/HTMLFrameElement.idl:
      * html/HTMLIFrameElement.idl:
      * html/HTMLObjectElement.idl:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      * MigrateHeaders.make:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b914b1d
    • oliver@apple.com's avatar
      Unify the many and varied stack trace mechanisms, and make the result sane. · 3980d396
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114072
      
      Reviewed by Filip Pizlo.
      
      Source/JavaScriptCore:
      
      Makes JSC::StackFrame record the bytecode offset and other necessary data
      rather than requiring us to perform eager evaluation of the line number, etc.
      Then remove most of the users of retrieveLastCaller, as most of them were
      using it to create a stack trace in a fairly incomplete and inefficient way.
      
      StackFrame now also has a couple of helpers to get the line and column info.
      
      * API/JSContextRef.cpp:
      (JSContextCreateBacktrace):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::emitDebugHook):
      * interpreter/Interpreter.cpp:
      (JSC):
      (JSC::Interpreter::dumpRegisters):
      (JSC::Interpreter::unwindCallFrame):
      (JSC::getBytecodeOffsetForCallFrame):
      (JSC::getCallerInfo):
      (JSC::StackFrame::line):
      (JSC::StackFrame::column):
      (JSC::StackFrame::expressionInfo):
      (JSC::StackFrame::toString):
      (JSC::Interpreter::getStackTrace):
      (JSC::Interpreter::addStackTraceIfNecessary):
      (JSC::Interpreter::retrieveCallerFromVMCode):
      * interpreter/Interpreter.h:
      (StackFrame):
      (Interpreter):
      * runtime/Error.cpp:
      (JSC::throwError):
      * runtime/JSGlobalData.h:
      (JSC):
      (JSGlobalData):
      * runtime/JSGlobalObject.cpp:
      (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
      
      Source/WebCore:
      
      Now that we've fleshed out the StackFrames from Interpreter::getStackTrace
      WebCore can just ask us for a stack trace rather than implementing its own
      stack walking.
      
      * bindings/js/ScriptCallStackFactory.cpp:
      (WebCore::createScriptCallStack):
      * inspector/ScriptCallFrame.cpp:
      (WebCore::ScriptCallFrame::isEqual):
      * inspector/ScriptCallFrame.h:
      (ScriptCallFrame):
      (WebCore::ScriptCallFrame::columnNumber):
      
      Tools:
      
      The commandline jsc executable no longer requires arguments, so
      I've made run-jsc work without them.
      
      * Scripts/run-jsc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3980d396
    • bdakin@apple.com's avatar
      Setting a header or footer should cause a relayout · fc6af6b0
      bdakin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114070
      
      Reviewed by Sam Weinig.
      
      Mark the RenderView as needing layout in order to adjust everything for the new 
      header/footer.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::setHeaderHeight):
      (WebCore::FrameView::setFooterHeight):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc6af6b0
    • cfleizach@apple.com's avatar
      AX: Make SVG Group containers accessible elements · b2b0b4d9
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113939
      
      Reviewed by Simon Fraser.
      
      Source/WebCore: 
      
      SVG group containers are currently not exposed in the AX tree. 
      When an SVG element has a <title> child, that is not being used for the AX label.
      When hit-testing, from Accessibility, SVG groups are never returned.
      
      All these issues are fixed for Mac and iOS.
      There are two tests because right now iOS skips all the top-level accessibility tests
      due to fundamental architectural differences.
      
      Tests: accessibility/svg-group-element-with-title.html
             platform/iphone-simulator/accessibility/svg-group-element-with-title.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::alternativeText):
      (WebCore::AccessibilityNodeObject::accessibilityDescription):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityHitTest):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
      (-[WebAccessibilityObjectWrapper isSVGGroupElement]):
      (-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
      (-[WebAccessibilityObjectWrapper accessibilityClickPoint]):
      * rendering/HitTestRequest.h:
          Add a new option, AccessibilityHitTest, that will allow us to override normal behavior.
      * rendering/svg/RenderSVGContainer.cpp:
      (WebCore::RenderSVGContainer::nodeAtFloatPoint):
         Allow a SVG group to be the node at a point, for accessibility hit tests.
      
      Tools: 
      
      Implement axController.elementAtPoint for iOS.
      Implement a correct version of clickPoint for iOS.
      
      * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
      (AccessibilityController::elementAtPoint):
      * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
      (AccessibilityUIElement::clickPointX):
      (AccessibilityUIElement::clickPointY):
      
      LayoutTests: 
      
      * accessibility/svg-group-element-with-title-expected.txt: Added.
      * accessibility/svg-group-element-with-title.html: Added.
      * platform/iphone-simulator/accessibility/svg-group-element-with-title-expected.txt: Added.
      * platform/iphone-simulator/accessibility/svg-group-element-with-title.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2b0b4d9
    • cfleizach@apple.com's avatar
      WebSpeech: event.elapsedTime is always 1364484608 · 16399b98
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114045
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      We were calculating elapsed time incorrectly.
      
      Test: platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html
      
      * Modules/speech/SpeechSynthesis.cpp:
      (WebCore::SpeechSynthesis::fireEvent):
      
      LayoutTests:
      
      * platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time-expected.txt: Added.
      * platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16399b98
    • cfleizach@apple.com's avatar
      WebSpeech: crash at WebCore::SpeechSynthesis::speak · e73c07ab
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113937
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      Protect against the case when invalid data is passed in.
      
      Test: platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html
      
      * Modules/speech/SpeechSynthesis.cpp:
      (WebCore::SpeechSynthesis::speak):
      * Modules/speech/SpeechSynthesisUtterance.cpp:
      (WebCore::SpeechSynthesisUtterance::setVoice):
      
      LayoutTests:
      
      * platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt: Added.
      * platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e73c07ab
    • antti@apple.com's avatar
      Throttle compositing layer flushes during page loading · a6775c18
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113786
      
      Reviewed by Simon Fraser.
              
      Page content can change rapidly during page loading triggering excessive layer flushes and repainting. We should avoid this unnecessary work.
              
      This patch reduces layer flushes (and painting) during loading by 50-70% on many popular pages.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::loadProgressingStatusChanged):        
      * loader/FrameLoader.h:
      * loader/ProgressTracker.cpp:
      (WebCore::ProgressTracker::ProgressTracker):
      (WebCore::ProgressTracker::reset):
      (WebCore::ProgressTracker::progressStarted):
      (WebCore::ProgressTracker::finalProgressComplete):
      (WebCore::ProgressTracker::isLoadProgressing):
      (WebCore::ProgressTracker::progressHeartbeatTimerFired):
      * loader/ProgressTracker.h:
              
          Track if the document load is progressing. This is done with a heartbeat timer that checks every 100ms if we have received more than 1k of data.
          If four heartbeats pass without progress then we consider the load stalled.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::resetDeferredRepaintDelay):
              
          Disable throttling temporary on user interaction so the page stays as responsive as possible even during loading.
      
      (WebCore::FrameView::updateLayerFlushThrottling):
              
          Enable throttling when the load is progressing, disable otherwise.
      
      * page/FrameView.h:
      * platform/graphics/GraphicsLayer.h:
      (WebCore::GraphicsLayer::canThrottleLayerFlush):
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
      (WebCore::GraphicsLayerCA::canThrottleLayerFlush):
              
          Don't throttle if new tiles have been added by the tile controller. They may have stale content and need to be flushed immediately.
      
      (WebCore::GraphicsLayerCA::noteLayerPropertyChanged):
              
          Set the new TilesAdded change flag.
      
      * platform/graphics/ca/GraphicsLayerCA.h:
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::notifyFlushRequired):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::RenderLayerCompositor):
      (WebCore::RenderLayerCompositor::notifyFlushRequired):
      (WebCore::RenderLayerCompositor::scheduleLayerFlushNow):
              
          Factor the actual flush scheduling to private function.
      
      (WebCore::RenderLayerCompositor::scheduleLayerFlush):
              
          Mark the compositor for flush and return without flushing if the flushes are currently being throttled.
      
      (WebCore::RenderLayerCompositor::flushPendingLayerChanges):
              
          After a flush, start the throtting timer (currently 0.5s) coalescing the subsequent flushes.
      
      (WebCore::RenderLayerCompositor::didChangeVisibleRect):
              
          Do immediately flush if needed.
      
      (WebCore::RenderLayerCompositor::setLayerFlushThrottlingEnabled):
              
          Flush immediately if disabled.
      
      (WebCore::RenderLayerCompositor::disableLayerFlushThrottlingTemporarilyForInteraction):
      (WebCore::RenderLayerCompositor::isThrottlingLayerFlushes):
      (WebCore::RenderLayerCompositor::startLayerFlushTimerIfNeeded):
      (WebCore::RenderLayerCompositor::layerFlushTimerFired):
              
          Flush when the timer fires timer.
      
      * rendering/RenderLayerCompositor.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6775c18
    • benjamin@webkit.org's avatar
      Clean the chromium bits of WebCore's WebDatabase · a4946bc1
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114010
      
      Reviewed by Ryosuke Niwa.
      
      * Modules/webdatabase/AbstractDatabaseServer.h:
      * Modules/webdatabase/ChangeVersionWrapper.cpp:
      (WebCore::ChangeVersionWrapper::performPreflight):
      (WebCore::ChangeVersionWrapper::performPostflight):
      * Modules/webdatabase/Database.cpp:
      * Modules/webdatabase/Database.h:
      (Database):
      * Modules/webdatabase/DatabaseBackend.cpp:
      (WebCore::DatabaseBackend::openAndVerifyVersion):
      * Modules/webdatabase/DatabaseBackendBase.cpp:
      (WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
      (WebCore::DatabaseBackendBase::performOpenAndVerify):
      (WebCore::DatabaseBackendBase::getActualVersionForTransaction):
      (WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):
      * Modules/webdatabase/DatabaseBackendBase.h:
      (DatabaseBackendBase):
      * Modules/webdatabase/DatabaseBackendSync.cpp:
      (WebCore::DatabaseBackendSync::openAndVerifyVersion):
      * Modules/webdatabase/DatabaseContext.cpp:
      (WebCore::DatabaseContext::databaseExceededQuota):
      * Modules/webdatabase/DatabaseManager.cpp:
      * Modules/webdatabase/DatabaseManager.h:
      (DatabaseManager):
      * Modules/webdatabase/DatabaseServer.cpp:
      (WebCore::DatabaseServer::initialize):
      (WebCore::DatabaseServer::setClient):
      (WebCore::DatabaseServer::databaseDirectoryPath):
      (WebCore::DatabaseServer::setDatabaseDirectoryPath):
      (WebCore::DatabaseServer::openDatabase):
      * Modules/webdatabase/DatabaseServer.h:
      * Modules/webdatabase/DatabaseSync.cpp:
      (WebCore::DatabaseSync::changeVersion):
      * Modules/webdatabase/DatabaseTracker.cpp:
      (WebCore::DatabaseTracker::canEstablishDatabase):
      (WebCore::DatabaseTracker::retryCanEstablishDatabase):
      * Modules/webdatabase/DatabaseTracker.h:
      (WebCore):
      (DatabaseTracker):
      * Modules/webdatabase/SQLStatementBackend.cpp:
      (WebCore::SQLStatementBackend::execute):
      (WebCore::SQLStatementBackend::setDatabaseDeletedError):
      (WebCore::SQLStatementBackend::setVersionMismatchedError):
      (WebCore::SQLStatementBackend::setFailureDueToQuota):
      * Modules/webdatabase/SQLStatementBackend.h:
      (SQLStatementBackend):
      * Modules/webdatabase/SQLTransaction.cpp:
      (WebCore::SQLTransaction::deliverTransactionCallback):
      (WebCore::SQLTransaction::deliverStatementCallback):
      * Modules/webdatabase/SQLTransactionBackend.cpp:
      (WebCore::SQLTransactionBackend::executeSQL):
      (WebCore::SQLTransactionBackend::openTransactionAndPreflight):
      (WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):
      (WebCore::SQLTransactionBackend::nextStateForCurrentStatementError):
      (WebCore::SQLTransactionBackend::postflightAndCommit):
      (WebCore::SQLTransactionBackend::acquireOriginLock):
      (WebCore::SQLTransactionBackend::releaseOriginLockIfNeeded):
      * Modules/webdatabase/SQLTransactionBackend.h:
      (SQLTransactionBackend):
      * Modules/webdatabase/SQLTransactionBackendSync.cpp:
      (WebCore::SQLTransactionBackendSync::begin):
      (WebCore::SQLTransactionBackendSync::commit):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4946bc1
    • ggaren@apple.com's avatar
      Made USE(JSC) unconditional · 95708e2b
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114058
      
      Reviewed by Anders Carlsson.
      
      ../JavaScriptCore: 
      
      * config.h:
      
      ../ThirdParty: 
      
      * gtest/include/gtest/internal/gtest-port.h:
      
      ../WebCore: 
      
      * Modules/webdatabase/Database.cpp:
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeIfJavaScriptURL):
      * bindings/js/JavaScriptCallFrame.cpp:
      * bindings/js/JavaScriptCallFrame.h:
      * bindings/scripts/InFilesCompiler.pm:
      (generateHeadersHeader):
      * css/MediaQueryListListener.cpp:
      (WebCore::MediaQueryListListener::queryChanged):
      * dom/ContainerNode.cpp:
      (WebCore::dispatchChildRemovalEvents):
      * dom/EventListener.h:
      (EventListener):
      (WebCore::EventListener::visitJSFunction):
      * dom/EventTarget.h:
      (EventTarget):
      (WebCore):
      (WebCore::EventTarget::visitJSEventListeners):
      * dom/Node.cpp:
      * dom/Node.h:
      * dom/ScriptExecutionContext.cpp:
      (WebCore):
      (WebCore::ScriptExecutionContext::globalData):
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext):
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::createImageBuffer):
      * html/HTMLImageLoader.cpp:
      (WebCore::HTMLImageLoader::notifyFinished):
      * inspector/InjectedScriptHost.h:
      (InjectedScriptHost):
      (WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::didCommitLoadImpl):
      * page/Frame.cpp:
      * page/Settings.cpp:
      (WebCore):
      (WebCore::Settings::shouldRespectPriorityInCSSAttributeSetters):
      * page/Settings.h:
      (Settings):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::start):
      (WebCore::PluginView::stop):
      (WebCore::PluginView::performRequest):
      (WebCore::PluginView::npObject):
      (WebCore):
      (WebCore::PluginView::bindingInstance):
      (WebCore::PluginView::privateBrowsingStateChanged):
      * plugins/PluginView.h:
      (PluginView):
      * plugins/PluginViewBase.h:
      (PluginViewBase):
      (WebCore::PluginViewBase::scriptObject):
      * plugins/PluginViewNone.cpp:
      (WebCore):
      (WebCore::PluginView::bindingInstance):
      * plugins/qt/PluginViewQt.cpp:
      (WebCore::PluginView::dispatchNPEvent):
      (WebCore::PluginView::setNPWindowIfNeeded):
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::dropProtection):
      
      ../WebKit/efl: 
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_script_execute):
      
      ../WebKit/qt: 
      
      * Api/qwebscriptworld.cpp:
      (QWebScriptWorld::QWebScriptWorld):
      
      ../WebKit2: 
      
      * Shared/linux/WebMemorySamplerLinux.cpp:
      (WebKit::WebMemorySampler::sampleWebKit):
      * config.h:
      
      ../WTF: 
      
      * wtf/ThreadRestrictionVerifier.h:
      (WTF):
      * wtf/WTFThreadData.cpp:
      (WTF::WTFThreadData::WTFThreadData):
      (WTF::WTFThreadData::~WTFThreadData):
      * wtf/WTFThreadData.h:
      (WTFThreadData):
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::~StringImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95708e2b
    • roger_fong@apple.com's avatar
      Unreviewed. More VS2010 solution makefile fixes. · 76a2eba1
      roger_fong@apple.com authored
      <rdar://problem/13588964>
      
      * WTF.vcxproj/WTF.make:
      * JavaScriptCore.vcxproj/JavaScriptCore.make:
      * WebCore.vcxproj/WebCore.make:
      * WebKit.vcxproj/WebKit.make:
      * win/tools/WinTools.make:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76a2eba1