1. 23 Jan, 2009 40 commits
    • hyatt@apple.com's avatar
      2009-01-23 David Hyatt <hyatt@apple.com> · 0c305637
      hyatt@apple.com authored
              Make toRenderBox a non-member function.  Rename toConstRenderBox to just also be called toRenderBox.
      
              Reviewed by Oliver Hunt
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::sizingBox):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::getUpperLeftCorner):
              (WebCore::ContainerNode::getLowerRightCorner):
              * dom/Element.cpp:
              (WebCore::Element::scrollByUnits):
              * dom/Position.cpp:
              (WebCore::endsOfNodeAreVisuallyDistinctPositions):
              (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
              (WebCore::Position::isCandidate):
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
              * editing/EditorCommand.cpp:
              (WebCore::verticalScrollDistance):
              * editing/TextIterator.cpp:
              (WebCore::shouldEmitExtraNewlineForNode):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::isKeyboardFocusable):
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLFormControlElement::isFocusable):
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::width):
              (WebCore::HTMLFrameElementBase::height):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMouseDraggedEvent):
              (WebCore::EventHandler::autoscrollTimerFired):
              (WebCore::EventHandler::updateAutoscrollRenderer):
              (WebCore::EventHandler::stopAutoscrollTimer):
              (WebCore::EventHandler::scrollOverflow):
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
              * page/animation/AnimationBase.cpp:
              (WebCore::blendFunc):
              * rendering/InlineBox.cpp:
              (WebCore::InlineBox::adjustPosition):
              * rendering/InlineBox.h:
              (WebCore::InlineBox::renderBox):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::clearFloats):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::offsetFromContainer):
              (WebCore::RenderBox::computeAbsoluteRepaintRect):
              (WebCore::RenderBox::containingBlockWidthForPositioned):
              (WebCore::RenderBox::containingBlockHeightForPositioned):
              (WebCore::RenderBox::calcAbsoluteHorizontal):
              (WebCore::RenderBox::calcAbsoluteVertical):
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
              (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
              * rendering/RenderBox.h:
              (WebCore::toRenderBox):
              (WebCore::RenderBox::previousSiblingBox):
              (WebCore::RenderBox::nextSiblingBox):
              (WebCore::RenderBox::parentBox):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::absoluteClippedOverflowRect):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::updateLayerPosition):
              (WebCore::RenderLayer::resize):
              (WebCore::RenderLayer::boundingBox):
              * rendering/RenderObject.cpp:
              (WebCore::addLayers):
              (WebCore::RenderObject::removeLayers):
              (WebCore::RenderObject::moveLayers):
              (WebCore::RenderObject::findNextLayer):
              (WebCore::RenderObject::enclosingLayer):
              (WebCore::RenderObject::setNeedsLayout):
              (WebCore::RenderObject::setNeedsPositionedMovementLayout):
              (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
              (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
              (WebCore::RenderObject::computeAbsoluteRepaintRect):
              (WebCore::RenderObject::localToAbsolute):
              (WebCore::RenderObject::absoluteToLocal):
              (WebCore::RenderObject::localToAbsoluteQuad):
              (WebCore::RenderObject::offsetFromContainer):
              (WebCore::RenderObject::removeFromObjectLists):
              (WebCore::RenderObject::destroy):
              (WebCore::RenderObject::updateHitTestResult):
              (WebCore::RenderObject::addDashboardRegions):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::layoutRows):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::hitTestMediaControlPart):
              (WebCore::RenderTheme::baselinePosition):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::hitTestMediaControlPart):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::externalRepresentation):
              * rendering/bidi.cpp:
              (WebCore::inlineWidth):
              (WebCore::RenderBlock::computeHorizontalPositionsForLine):
              (WebCore::requiresLineBox):
              (WebCore::RenderBlock::findNextLineBreak):
              * svg/SVGLength.cpp:
              (WebCore::SVGLength::PercentageOfViewport):
              * wml/WMLAElement.cpp:
              (WebCore::WMLAElement::isKeyboardFocusable):
              * wml/WMLInputElement.cpp:
              (WebCore::isInputFocusable):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c305637
    • cfleizach@apple.com's avatar
      2009-01-23 Chris Fleizach <cfleizach@apple.com> · 16989217
      cfleizach@apple.com authored
              Reviewed by Beth Dakin.
      
              Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
              https://bugs.webkit.org/show_bug.cgi?id=23509
        
              Add null checking around next/previous sentence retrieval in AX code
      
              * page/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::nextSentenceEndPosition):
              (WebCore::AccessibilityObject::previousSentenceStartPosition):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16989217
    • adele@apple.com's avatar
      2009-01-23 Adele Peterson <adele@apple.com> · a422eff1
      adele@apple.com authored
              Build fix.
      
              Use new linesBoundingBox method instead of
              boundingBoxWidth and boundingBoxHeight for RenderText objects.
      
              * WebView/WebRenderNode.mm: (copyRenderNode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a422eff1
    • kevino@webkit.org's avatar
      wx build fix, add missing include dir. · 2e2d84fe
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e2d84fe
    • ddkilzer@apple.com's avatar
      2009-01-23 David Kilzer <ddkilzer@apple.com> · 479d2c2d
      ddkilzer@apple.com authored
              * Scripts/do-webcore-rename: Removed 10 header guard renames that
              had already been fixed, and updated 4 renames whose original values
              had changed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      479d2c2d
    • ddkilzer@apple.com's avatar
      Added missing comma to copyright. · 74e52cf7
      ddkilzer@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74e52cf7
    • hyatt@apple.com's avatar
    • hyatt@apple.com's avatar
    • hyatt@apple.com's avatar
    • hyatt@apple.com's avatar
      Add new repaint test for hover regression. · d4860050
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4860050
    • hyatt@apple.com's avatar
      2009-01-23 David Hyatt <hyatt@apple.com> · 651c2e87
      hyatt@apple.com authored
              Fix for <rdar://problem/6518850> REGRESSION: hover feedback not showing on many sites
      
              Inline flow repainting was broken because it relied on width() and height().  Give RenderFlow a linesBoundingBox
              method for obtaining a reasonable bounding box to use for repainting.  Eliminate the methods from RenderInline
              since compacts/run-ins need them too, so putting them on RenderFlow is necessary.
      
              For consistency, change RenderText's version of these methods into the single linesBoundingBox method as
              well.
      
              Reviewed by Oliver Hunt
      
              * WebCore.base.exp:
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::getUpperLeftCorner):
              (WebCore::ContainerNode::getLowerRightCorner):
              * dom/Position.cpp:
              (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::containingBlockHeightForPositioned):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::absoluteClippedOverflowRect):
              (WebCore::RenderFlow::linesBoundingBox):
              * rendering/RenderFlow.h:
              * rendering/RenderInline.cpp:
              * rendering/RenderInline.h:
              (WebCore::RenderInline::offsetWidth):
              (WebCore::RenderInline::offsetHeight):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::updateLayerPosition):
              * rendering/RenderText.cpp:
              (WebCore::RenderText::linesBoundingBox):
              * rendering/RenderText.h:
              * rendering/RenderTreeAsText.cpp:
              (WebCore::operator<<):
              * rendering/SVGRenderTreeAsText.cpp:
              (WebCore::write):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      651c2e87
    • hyatt@apple.com's avatar
      Fix RenderFlow. Botched the application of my patch. · e0c06711
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0c06711
    • hyatt@apple.com's avatar
      2009-01-23 David Hyatt <hyatt@apple.com> · ee16394f
      hyatt@apple.com authored
              Move layer() into RenderBox and make it non-virtual.  Move all of the scrolling functions from RenderObject
              to RenderBox and devirtualize as many as possible.  Clean up styleWillChange to factor code specific to
              RenderBox and RenderBlock into their appropriate subclasses.  Stubbed out an empty styleWillChange on
              RenderText, since none of the work done in styleWillChange was relevant to text nodes.
      
              Reviewed by Sam Weinig
      
              * dom/Document.cpp:
              (WebCore::Document::elementFromPoint):
              (WebCore::Document::renderView):
              (WebCore::Document::prepareMouseEvent):
              * dom/Document.h:
              * dom/Element.cpp:
              (WebCore::Element::scrollByUnits):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::contains):
              * html/HTMLMarqueeElement.cpp:
              (WebCore::HTMLMarqueeElement::start):
              (WebCore::HTMLMarqueeElement::stop):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::topRenderer):
              (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
              (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
              * page/AccessibilityRenderObject.h:
              * page/EventHandler.cpp:
              (WebCore::scrollAndAcceptEvent):
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::handleMouseDraggedEvent):
              (WebCore::EventHandler::updateSelectionForMouseDrag):
              (WebCore::EventHandler::autoscrollTimerFired):
              (WebCore::EventHandler::updateAutoscrollRenderer):
              (WebCore::EventHandler::stopAutoscrollTimer):
              (WebCore::EventHandler::scrollOverflow):
              (WebCore::EventHandler::handleWheelEvent):
              (WebCore::EventHandler::hoverTimerFired):
              * page/Frame.cpp:
              (WebCore::Frame::clearTimers):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::styleWillChange):
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::styleWillChange):
              (WebCore::RenderBox::verticalScrollbarWidth):
              (WebCore::RenderBox::horizontalScrollbarHeight):
              (WebCore::RenderBox::scroll):
              (WebCore::RenderBox::canBeProgramaticallyScrolled):
              (WebCore::RenderBox::autoscroll):
              (WebCore::RenderBox::panScroll):
              (WebCore::RenderBox::offsetFromContainer):
              (WebCore::RenderBox::computeAbsoluteRepaintRect):
              * rendering/RenderBox.h:
              (WebCore::RenderBox::layer):
              (WebCore::RenderBox::requiresLayer):
              (WebCore::RenderBox::stopAutoscroll):
              (WebCore::RenderBox::hasAutoVerticalScrollbar):
              (WebCore::RenderBox::hasAutoHorizontalScrollbar):
              (WebCore::RenderBox::scrollsOverflow):
              (WebCore::RenderBox::scrollsOverflowX):
              (WebCore::RenderBox::scrollsOverflowY):
              (WebCore::RenderBox::includeVerticalScrollbarSize):
              (WebCore::RenderBox::includeHorizontalScrollbarSize):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::absoluteClippedOverflowRect):
              (WebCore::RenderFlow::addFocusRingRects):
              * rendering/RenderForeignObject.cpp:
              * rendering/RenderForeignObject.h:
              (WebCore::RenderForeignObject::requiresLayer):
              * rendering/RenderInline.cpp:
              * rendering/RenderInline.h:
              (WebCore::RenderInline::requiresLayer):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::childrenClipRect):
              (WebCore::RenderLayer::selfClipRect):
              * rendering/RenderListBox.cpp:
              * rendering/RenderListBox.h:
              * rendering/RenderObject.cpp:
              (WebCore::addLayers):
              (WebCore::RenderObject::removeLayers):
              (WebCore::RenderObject::moveLayers):
              (WebCore::RenderObject::findNextLayer):
              (WebCore::RenderObject::enclosingLayer):
              (WebCore::RenderObject::setNeedsLayout):
              (WebCore::RenderObject::setNeedsPositionedMovementLayout):
              (WebCore::RenderObject::computeAbsoluteRepaintRect):
              (WebCore::RenderObject::styleWillChange):
              (WebCore::RenderObject::localToAbsolute):
              (WebCore::RenderObject::absoluteToLocal):
              (WebCore::RenderObject::localToAbsoluteQuad):
              (WebCore::RenderObject::offsetFromContainer):
              (WebCore::RenderObject::destroy):
              * rendering/RenderObject.h:
              * rendering/RenderPath.cpp:
              * rendering/RenderPath.h:
              (WebCore::RenderPath::requiresLayer):
              * rendering/RenderReplica.h:
              (WebCore::RenderReplica::requiresLayer):
              * rendering/RenderSVGContainer.cpp:
              * rendering/RenderSVGContainer.h:
              (WebCore::RenderSVGContainer::requiresLayer):
              * rendering/RenderSVGHiddenContainer.cpp:
              * rendering/RenderSVGHiddenContainer.h:
              (WebCore::RenderSVGHiddenContainer::requiresLayer):
              * rendering/RenderSVGImage.cpp:
              * rendering/RenderSVGImage.h:
              (WebCore::RenderSVGImage::requiresLayer):
              * rendering/RenderSVGInline.h:
              (WebCore::RenderSVGInline::requiresLayer):
              * rendering/RenderSVGInlineText.h:
              (WebCore::RenderSVGInlineText::requiresLayer):
              * rendering/RenderSVGText.cpp:
              * rendering/RenderSVGText.h:
              (WebCore::RenderSVGText::requiresLayer):
              * rendering/RenderScrollbarPart.h:
              (WebCore::RenderScrollbarPart::requiresLayer):
              * rendering/RenderSlider.cpp:
              (WebCore::RenderSlider::setCurrentPosition):
              * rendering/RenderTableCell.cpp:
              * rendering/RenderTableCell.h:
              (WebCore::RenderTableCell::requiresLayer):
              * rendering/RenderTableCol.h:
              (WebCore::RenderTableCol::requiresLayer):
              * rendering/RenderTableRow.h:
              (WebCore::RenderTableRow::requiresLayer):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::layoutRows):
              * rendering/RenderText.h:
              (WebCore::RenderText::styleWillChange):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::autoscroll):
              (WebCore::RenderTextControl::scroll):
              * rendering/RenderTextControl.h:
              * rendering/RenderTreeAsText.cpp:
              (WebCore::write):
              (WebCore::externalRepresentation):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee16394f
    • andersca@apple.com's avatar
      2009-01-23 Anders Carlsson <andersca@apple.com> · 23b2fec3
      andersca@apple.com authored
              Fix 64-bit build.
              
              * Plugins/Hosted/ProxyInstance.mm:
              (WebKit::proxyClass):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23b2fec3
    • andersca@apple.com's avatar
      2009-01-23 Anders Carlsson <andersca@apple.com> · 1f9f82ec
      andersca@apple.com authored
              Fix GCC 4.0 build.
              
              * Configurations/Base.xcconfig:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f9f82ec
    • andersca@apple.com's avatar
      2009-01-23 Anders Carlsson <andersca@apple.com> · 386ad727
      andersca@apple.com authored
              Fix tyop.
              
              * editing/markup.cpp:
              (WebCore::joinMarkups):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      386ad727
    • darin@apple.com's avatar
      2009-01-23 Darin Adler <darin@apple.com> · 78ab31a2
      darin@apple.com authored
              Try to fix WX build.
      
              * runtime/JSGlobalObjectFunctions.h: Include <wtf/unicode/Unicode.h>
              for the definition of UChar.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78ab31a2
    • andersca@apple.com's avatar
      2009-01-23 Anders Carlsson <andersca@apple.com> · 3c1e6d90
      andersca@apple.com authored
              Reviewed by Darin Adler.
      
              * Configurations/Base.xcconfig:
              Fix GCC 4.0 build.
              
              * editing/markup.cpp:
              (WebCore::joinMarkups):
              Pass a const reference to the vector.
              
              * html/HTMLElement.cpp:
              * platform/text/String.cpp:
              Add comments indicating that these functions are for use in the debugger.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c1e6d90
    • andersca@apple.com's avatar
      2009-01-23 Anders Carlsson <andersca@apple.com> · bd1a951f
      andersca@apple.com authored
              * Configurations/Base.xcconfig:
              GCC 4.0 build fix.
              
              * runtime/JSNumberCell.h:
              64-bit build fix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd1a951f
    • darin@chromium.org's avatar
      2009-01-23 Darin Fisher <darin@chromium.org> · 0deb6b8b
      darin@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=23506
              Upstream Chromium's image decoders for use with PLATFORM(SKIA)
      
              * platform/image-decoders/skia/BMPImageDecoder.cpp: Added.
              * platform/image-decoders/skia/BMPImageDecoder.h: Added.
              * platform/image-decoders/skia/BMPImageReader.cpp: Added.
              * platform/image-decoders/skia/BMPImageReader.h: Added.
              * platform/image-decoders/skia/GIFImageDecoder.cpp:
              (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate):
              (WebCore::GIFImageDecoderPrivate::decode):
              (WebCore::GIFImageDecoderPrivate::getColorMap):
              (WebCore::GIFImageDecoder::GIFImageDecoder):
              (WebCore::GIFImageDecoder::isSizeAvailable):
              (WebCore::GIFImageDecoder::frameCount):
              (WebCore::GIFImageDecoder::frameBufferAtIndex):
              (WebCore::GIFImageDecoder::clearFrameBufferCache):
              (WebCore::GIFImageDecoder::decode):
              (WebCore::GIFImageDecoder::sizeNowAvailable):
              (WebCore::GIFImageDecoder::initFrameBuffer):
              (WebCore::GIFImageDecoder::prepEmptyFrameBuffer):
              (WebCore::GIFImageDecoder::haveDecodedRow):
              (WebCore::GIFImageDecoder::frameComplete):
              * platform/image-decoders/skia/GIFImageDecoder.h:
              (WebCore::GIFImageDecoder::filenameExtension):
              (WebCore::GIFImageDecoder::frameDurationAtIndex):
              (WebCore::GIFImageDecoder::):
              * platform/image-decoders/skia/GIFImageReader.cpp:
              (GIFImageReader::do_lzw):
              (GIFImageReader::read):
              * platform/image-decoders/skia/GIFImageReader.h:
              * platform/image-decoders/skia/ICOImageDecoder.cpp: Added.
              * platform/image-decoders/skia/ICOImageDecoder.h: Added.
              * platform/image-decoders/skia/ImageDecoder.h:
              (WebCore::RefCountedNativeImageSkia::create):
              (WebCore::RefCountedNativeImageSkia::bitmap):
              (WebCore::RefCountedNativeImageSkia::RefCountedNativeImageSkia):
              (WebCore::RGBA32Buffer::):
              (WebCore::RGBA32Buffer::RGBA32Buffer):
              (WebCore::RGBA32Buffer::~RGBA32Buffer):
              (WebCore::RGBA32Buffer::operator=):
              (WebCore::RGBA32Buffer::clear):
              (WebCore::RGBA32Buffer::copyBitmapData):
              (WebCore::RGBA32Buffer::bitmap):
              (WebCore::RGBA32Buffer::setSize):
              (WebCore::RGBA32Buffer::width):
              (WebCore::RGBA32Buffer::height):
              (WebCore::RGBA32Buffer::rect):
              (WebCore::RGBA32Buffer::status):
              (WebCore::RGBA32Buffer::duration):
              (WebCore::RGBA32Buffer::disposalMethod):
              (WebCore::RGBA32Buffer::hasAlpha):
              (WebCore::RGBA32Buffer::setRect):
              (WebCore::RGBA32Buffer::setStatus):
              (WebCore::RGBA32Buffer::setDuration):
              (WebCore::RGBA32Buffer::setDisposalMethod):
              (WebCore::RGBA32Buffer::setHasAlpha):
              (WebCore::RGBA32Buffer::setRGBA):
              (WebCore::ImageDecoder::ImageDecoder):
              (WebCore::ImageDecoder::~ImageDecoder):
              (WebCore::ImageDecoder::setData):
              (WebCore::ImageDecoder::isSizeAvailable):
              (WebCore::ImageDecoder::size):
              (WebCore::ImageDecoder::frameCount):
              (WebCore::ImageDecoder::repetitionCount):
              (WebCore::ImageDecoder::supportsAlpha):
              (WebCore::ImageDecoder::failed):
              (WebCore::ImageDecoder::setFailed):
              (WebCore::ImageDecoder::clearFrameBufferCache):
              (WebCore::ImageDecoder::setSize):
              (WebCore::ImageDecoder::isOverSize):
              * platform/image-decoders/skia/JPEGImageDecoder.cpp:
              (WebCore::JPEGImageReader::JPEGImageReader):
              (WebCore::JPEGImageReader::decode):
              (WebCore::JPEGImageDecoder::isSizeAvailable):
              (WebCore::JPEGImageDecoder::outputScanlines):
              * platform/image-decoders/skia/JPEGImageDecoder.h:
              (WebCore::JPEGImageDecoder::filenameExtension):
              (WebCore::JPEGImageDecoder::supportsAlpha):
              (WebCore::JPEGImageDecoder::reader):
              * platform/image-decoders/skia/PNGImageDecoder.cpp:
              (WebCore::PNGImageReader::close):
              (WebCore::PNGImageDecoder::PNGImageDecoder):
              (WebCore::PNGImageDecoder::isSizeAvailable):
              (WebCore::PNGImageDecoder::frameBufferAtIndex):
              (WebCore::PNGImageDecoder::decode):
              (WebCore::PNGImageDecoder::decodingFailed):
              (WebCore::PNGImageDecoder::headerAvailable):
              (WebCore::rowAvailable):
              (WebCore::PNGImageDecoder::rowAvailable):
              (WebCore::PNGImageDecoder::pngComplete):
              * platform/image-decoders/skia/PNGImageDecoder.h:
              (WebCore::PNGImageDecoder::filenameExtension):
              (WebCore::PNGImageDecoder::reader):
              * platform/image-decoders/skia/XBMImageDecoder.cpp: Added.
              * platform/image-decoders/skia/XBMImageDecoder.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0deb6b8b
    • andersca@apple.com's avatar
      2009-01-23 Anders Carlsson <andersca@apple.com> · 2ca8b7c5
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Turn on -Wmissing-prototypes and fix the resulting warnings.
      
              * Configurations/Base.xcconfig:
              * History/WebHistory.mm:
              (timeIntervalForBeginningOfDay):
              * History/WebHistoryItem.mm:
              (historyItemWrappers):
              * Misc/WebNSPasteboardExtras.mm:
              (imageFromElement):
              * WebView/WebFrame.mm:
              * WebView/WebScriptDebugger.mm:
              (toNSString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ca8b7c5
    • andersca@apple.com's avatar
      2009-01-23 Anders Carlsson <andersca@apple.com> · d8dda094
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Turn on -Wmissing-prototypes and fix the resulting warnings.
              
              * Configurations/Base.xcconfig:
              * bindings/js/JSHistoryCustom.cpp:
              (WebCore::nonCachingStaticBackFunctionGetter):
              (WebCore::nonCachingStaticForwardFunctionGetter):
              (WebCore::nonCachingStaticGoFunctionGetter):
              * bindings/js/JSLocationCustom.cpp:
              (WebCore::nonCachingStaticReplaceFunctionGetter):
              (WebCore::nonCachingStaticReloadFunctionGetter):
              (WebCore::nonCachingStaticAssignFunctionGetter):
              (WebCore::JSLocation::customGetOwnPropertySlot):
              * bindings/objc/DOMRGBColor.mm:
              (WebCore::getWrapperForRGB):
              (WebCore::setWrapperForRGB):
              (WebCore::removeWrapperForRGB):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bridge/c/c_instance.cpp:
              (JSC::Bindings::globalExceptionString):
              * bridge/runtime_object.cpp:
              (JSC::callRuntimeConstructor):
              * css/CSSParser.cpp:
              (WebCore::parseGradientColorStop):
              * css/CSSPrimitiveValue.cpp:
              (WebCore::scaleFactorForConversion):
              * css/CSSStyleSelector.cpp:
              (WebCore::operator >):
              (WebCore::operator <=):
              (WebCore::getTransformOperationType):
              * dom/make_names.pl:
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::updatePositionForTextRemoval):
              * editing/EditorCommand.cpp:
              (WebCore::valueBackColor):
              (WebCore::valueFontName):
              (WebCore::valueFontSize):
              (WebCore::valueFontSizeDelta):
              (WebCore::valueForeColor):
              * editing/VisiblePosition.cpp:
              (WebCore::canonicalizeCandidate):
              * editing/htmlediting.cpp:
              * editing/markup.cpp:
              (WebCore::joinMarkups):
              * html/HTMLElement.cpp:
              (WebCore::inlineTagList):
              (WebCore::blockTagList):
              * html/HTMLMediaElement.cpp:
              (WebCore::serializeTimeOffset):
              (WebCore::parseTimeOffset):
              * page/mac/FrameMac.mm:
              (WebCore::regExpForLabels):
              * platform/Arena.cpp:
              * platform/graphics/Color.cpp:
              (WebCore::colorFloatToRGBAByte):
              * platform/graphics/cg/ImageSourceCG.cpp:
              (WebCore::imageSourceOptions):
              * platform/graphics/cg/PathCG.cpp:
              (WebCore::CGPathApplierToPathApplier):
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::initFontData):
              * platform/mac/PlatformMouseEventMac.mm:
              * platform/text/String.cpp:
              * rendering/RenderBlock.cpp:
              (WebCore::continuationOutlineTable):
              (WebCore::getHeightForLineCount):
              * rendering/RenderView.cpp:
              (WebCore::rendererAfterPosition):
              * rendering/RootInlineBox.cpp:
              (WebCore::isEditableLeaf):
              * rendering/SVGRenderTreeAsText.cpp:
              (WebCore::hasFractions):
              * rendering/style/RenderStyle.cpp:
              (WebCore::positionedObjectMoved):
              * svg/SVGFont.cpp:
              (WebCore::floatWidthUsingSVGFontCallback):
              (WebCore::floatWidthMissingGlyphCallback):
              (WebCore::drawTextUsingSVGFontCallback):
              (WebCore::drawTextMissingGlyphCallback):
              * svg/SVGTransformable.cpp:
              (WebCore::parseTransformParamList):
              * svg/graphics/SVGPaintServerGradient.cpp:
              (WebCore::operator<<):
              * xml/XPathGrammar.y:
              * xml/XSLTExtensions.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8dda094
    • eric@webkit.org's avatar
      No review, removing an empty file. · 48c6aaee
      eric@webkit.org authored
              Remove RemoveNodeAttributeCommand since it was empty.
      
              * WebCore.pro:
              * WebCore.scons:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * editing/RemoveNodeAttributeCommand.cpp: Removed.
              * editing/RemoveNodeAttributeCommand.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48c6aaee
    • andersca@apple.com's avatar
      2009-01-23 Anders Carlsson <andersca@apple.com> · 8c52c948
      andersca@apple.com authored
              Reviewed by Sam Weinig.
              
              Turn on -Wmissing-prototypes and fix the warnings.
              
              * API/JSClassRef.cpp:
              (clearReferenceToPrototype):
              * Configurations/Base.xcconfig:
              * runtime/Collector.cpp:
              (JSC::getPlatformThreadRegisters):
              * runtime/ExceptionHelpers.cpp:
              (JSC::createError):
              * runtime/JSGlobalObjectFunctions.h:
              * runtime/JSNumberCell.h:
              * runtime/UString.cpp:
              (JSC::initializeStaticBaseString):
              (JSC::createRep):
              * wtf/FastMalloc.cpp:
              * wtf/Threading.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c52c948
    • beidson@apple.com's avatar
      2009-01-23 Brady Eidson <beidson@apple.com> · 80c19358
      beidson@apple.com authored
              Rubberstamped by Sam Weinig
      
              Rework ScriptCachedPageData to ScriptCachedFrameData to more accurately reflect its true purpose
      
              * GNUmakefile.am:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
      
              * bindings/js/ScriptCachedFrameData.cpp: Copied from bindings/js/ScriptCachedPageData.cpp.
              (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
              (WebCore::ScriptCachedFrameData::domWindow):
              (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
              (WebCore::ScriptCachedFrameData::restore):
              (WebCore::ScriptCachedFrameData::clear):
              * bindings/js/ScriptCachedFrameData.h: Copied from bindings/js/ScriptCachedPageData.h.
              * bindings/js/ScriptCachedPageData.cpp: Removed.
              * bindings/js/ScriptCachedPageData.h: Removed.
      
              * history/CachedPage.cpp:
              (WebCore::CachedPage::CachedPage):
              (WebCore::CachedPage::restore):
              * history/CachedPage.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80c19358
    • sfalken@apple.com's avatar
      Fix build. · 2e67647f
      sfalken@apple.com authored
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::baselinePosition):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e67647f
    • darin@chromium.org's avatar
      2009-01-23 Darin Fisher <darin@chromium.org> · 72f91a6b
      darin@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=23506
              Copy existing ImageDecoder.h in preparation for landing Skia changes on top.
      
              * platform/image-decoders/skia/ImageDecoder.h: Copied from platform/image-decoders/ImageDecoder.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72f91a6b
    • darin@chromium.org's avatar
      2009-01-23 Darin Fisher <darin@chromium.org> · 08f6e9c1
      darin@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=23506
              Copy existing image-decoders in preparation for landing Skia changes on top.
      
              * platform/image-decoders/skia: Added.
              * platform/image-decoders/skia/GIFImageDecoder.cpp: Copied from platform/image-decoders/gif/GIFImageDecoder.cpp.
              * platform/image-decoders/skia/GIFImageDecoder.h: Copied from platform/image-decoders/gif/GIFImageDecoder.h.
              * platform/image-decoders/skia/GIFImageReader.cpp: Copied from platform/image-decoders/gif/GIFImageReader.cpp.
              * platform/image-decoders/skia/GIFImageReader.h: Copied from platform/image-decoders/gif/GIFImageReader.h.
              * platform/image-decoders/skia/JPEGImageDecoder.cpp: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.cpp.
              * platform/image-decoders/skia/JPEGImageDecoder.h: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.h.
              * platform/image-decoders/skia/PNGImageDecoder.cpp: Copied from platform/image-decoders/png/PNGImageDecoder.cpp.
              * platform/image-decoders/skia/PNGImageDecoder.h: Copied from platform/image-decoders/png/PNGImageDecoder.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08f6e9c1
    • ap@webkit.org's avatar
      Reviewed by Oliver Hunt. · a3e375d5
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=23478
              Add a test for application test resource loading failure
      
              * http/tests/appcache/404-resource-expected.txt: Added.
              * http/tests/appcache/404-resource.html: Added.
              * http/tests/appcache/resources/404-resource.manifest: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3e375d5
    • zecke@webkit.org's avatar
      Build fix in RenderThemeGtk for RenderBox usage. · d29acbac
      zecke@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d29acbac
    • ap@webkit.org's avatar
      2009-01-23 David Levin <levin@chromium.org> · 748c0244
      ap@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Bug 22720: Make XMLHttpRequest work in Workers
              <https://bugs.webkit.org/show_bug.cgi?id=22720>
      
              Add copy/adopt for ResourceResponse(Base)/ResourceRequest(Base) to allow the
              data to be passed across threads.
      
              No observable change in behavior, so no test.
      
              * platform/network/FormData.cpp:
              (WebCore::FormData::deepCopy):
              * platform/network/FormData.h:
              * platform/network/HTTPHeaderMap.cpp:
              (WebCore::HTTPHeaderMap::copyData):
              (WebCore::HTTPHeaderMap::adopt):
              * platform/network/HTTPHeaderMap.h:
              * platform/network/ResourceRequestBase.cpp:
              (WebCore::ResourceRequestBase::adopt):
              (WebCore::ResourceRequestBase::copyData):
              * platform/network/ResourceRequestBase.h:
              * platform/network/ResourceResponseBase.cpp:
              (WebCore::ResourceResponseBase::adopt):
              (WebCore::ResourceResponseBase::copyData):
              * platform/network/ResourceResponseBase.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      748c0244
    • ap@webkit.org's avatar
      2009-01-23 Dmitry Titov <dimich@chromium.org> · 1f622057
      ap@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              https://bugs.webkit.org/show_bug.cgi?id=23374
              Add WorkerRunLoop to encapsulate message queue and timer heap.
              This is first half (timer heap is added as separate patch).
      
              * GNUmakefile.am: Added WorkerRunLoop.cpp to the build.
              * WebCore.vcproj/WebCore.vcproj: Same as above.
              * WebCore.xcodeproj/project.pbxproj: Same as above
              * dom/WorkerContext.cpp:
              (WebCore::WorkerContext::postTask):
              * dom/WorkerContext.h:
              * dom/WorkerMessagingProxy.cpp:
              (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
              (WebCore::WorkerMessagingProxy::workerThreadCreated):
              * dom/WorkerRunLoop.cpp: Added.
              (WebCore::WorkerRunLoop::run): Runs the loop until terminate() is called.
              (WebCore::WorkerRunLoop::terminate): Causes the loop to exit.
              (WebCore::WorkerRunLoop::postTask): Adds a task to the internal queue.
              * dom/WorkerRunLoop.h: Added.
              (WebCore::WorkerRunLoop::WorkerRunLoop):
              * dom/WorkerThread.cpp:
              (WebCore::WorkerThread::workerThread):
              (WebCore::WorkerThread::stop):
              * dom/WorkerThread.h:
              (WebCore::WorkerThread::runLoop):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f622057
    • treat@webkit.org's avatar
      Redo previous patch http://trac.webkit.org/changeset/34260 which fixes a · 127f05ff
      treat@webkit.org authored
      huge memory leak by ensuring that the timer is fired one last time on
      application tear down thus triggering the GCController thereby freeing
      JavaScript objects as well as triggering other timer based tear down methods.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      127f05ff
    • ap@webkit.org's avatar
      Reviewed by Oliver Hunt. · 24a6418d
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=23459
              Workers are not properly terminated if execution hasn't begun yet
      
              Doesn't affect observable behavior, so test case is not possible.
      
              * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Call forbidExecution() if
              it couldn't be called earlier.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24a6418d
    • ariya@webkit.org's avatar
      2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com> · 8c4352ce
      ariya@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Make the test more robust by taking into account the platform-specific
              cursor flashing time.
      
              * tests/qwebframe/tst_qwebframe.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c4352ce
    • ariya@webkit.org's avatar
      2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com> · 65754418
      ariya@webkit.org authored
              [Qt] Fix the build after RenderBox refactoring in r40153.
      
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::baselinePosition):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65754418
    • ariya@webkit.org's avatar
      2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com> · 1adeb34c
      ariya@webkit.org authored
              Rubber-stamped by Alexey Proskuryakov.
      
              Fix the build after RenderBox refactoring in r40153.
      
              * plugins/PluginView.cpp:
              (WebCore::PluginView::invalidateWindowlessPluginRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1adeb34c
    • ariya@webkit.org's avatar
      2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com> · 9339bf8b
      ariya@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Simplify the assertion.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::getWindowsContext):
              (WebCore::GraphicsContext::releaseWindowsContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9339bf8b
    • hyatt@apple.com's avatar
      bdcc7214
    • hyatt@apple.com's avatar
      2009-01-22 David Hyatt <hyatt@apple.com> · 55fe6bdd
      hyatt@apple.com authored
              Move the border and padding methods from RenderObject to RenderBox.
      
              Reviewed by Oliver Hunt
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::createDeletionUI):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::hitTestResultAtPoint):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesVertically):
              * rendering/InlineFlowBox.h:
              (WebCore::InlineFlowBox::borderLeft):
              (WebCore::InlineFlowBox::borderRight):
              (WebCore::InlineFlowBox::paddingLeft):
              (WebCore::InlineFlowBox::paddingRight):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::clearFloats):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paddingTop):
              (WebCore::RenderBox::paddingBottom):
              (WebCore::RenderBox::paddingLeft):
              (WebCore::RenderBox::paddingRight):
              (WebCore::RenderBox::calcHeight):
              (WebCore::RenderBox::containingBlockWidthForPositioned):
              (WebCore::RenderBox::containingBlockHeightForPositioned):
              (WebCore::RenderBox::calcAbsoluteHorizontal):
              (WebCore::RenderBox::calcAbsoluteHorizontalValues):
              (WebCore::RenderBox::calcAbsoluteVertical):
              (WebCore::RenderBox::calcAbsoluteVerticalValues):
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
              (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
              * rendering/RenderBox.h:
              (WebCore::RenderBox::borderTop):
              (WebCore::RenderBox::borderBottom):
              (WebCore::RenderBox::borderLeft):
              (WebCore::RenderBox::borderRight):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
              * rendering/RenderObject.h:
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::textBlockWidth):
              (WebCore::RenderTextControl::calcHeight):
              (WebCore::RenderTextControl::calcPrefWidths):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::preferredContentWidth):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::operator<<):
              * rendering/RenderView.cpp:
              (WebCore::RenderView::repaintViewRectangle):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55fe6bdd