1. 29 Nov, 2012 40 commits
    • fpizlo@apple.com's avatar
      It should be easy to find code blocks in debug dumps · 0bfcc38a
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103623
      
      Source/JavaScriptCore: 
      
      Reviewed by Goeffrey Garen.
      
      This gives CodeBlock a relatively strong, but also relatively compact, hash. We compute
      it lazily so that it only impacts run-time when debug support is enabled. We stringify
      it smartly so that it's short and easy to type. We base it on the source code so that
      the optimization level is irrelevant. And, we use SHA1 since it's already in our code
      base. Now, when a piece of code wants to print some debugging to say that it's operating
      on some code block, it can use this CodeBlockHash instead of memory addresses.
      
      This also takes CodeBlock debugging into the new world of print() and dataLog(). In
      particular, CodeBlock::dump() corresponds to the thing you want printed if you do:
      
      dataLog("I heart ", *myCodeBlock);
      
      Probably, you want to just print some identifying information at this point rather than
      the full bytecode dump. So, the existing CodeBlock::dump() has been renamed to
      CodeBlock::dumpBytecode(), and CodeBlock::dump() now prints the CodeBlockHash plus just
      a few little tidbits.
              
      Here's an example of CodeBlock::dump() output:
              
      EkILzr:[0x103883a00, BaselineFunctionCall]
              
      EkILzr is the CodeBlockHash. 0x103883a00 is the CodeBlock's address in memory. The other
      part is self-explanatory.
      
      Finally, this new notion of CodeBlockHash is available for other purposes like bisecting
      breakage. As such CodeBlockHash has all of the comparison operator overloads. When
      bisecting in DFGDriver.cpp, you can now say things like:
              
      if (codeBlock->hash() < CodeBlockHash("CAAAAA"))
          return false;
              
      And yes, CAAAAA is near the median hash, and the largest one is smaller than E99999. Such
      is life when you use base 62 to encode a 32-bit number.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * bytecode/CallLinkInfo.h:
      (CallLinkInfo):
      (JSC::CallLinkInfo::specializationKind):
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::hash):
      (JSC):
      (JSC::CodeBlock::dumpAssumingJITType):
      (JSC::CodeBlock::dump):
      (JSC::CodeBlock::dumpBytecode):
      (JSC::CodeBlock::CodeBlock):
      (JSC::CodeBlock::finalizeUnconditionally):
      (JSC::CodeBlock::resetStubInternal):
      (JSC::CodeBlock::reoptimize):
      (JSC::ProgramCodeBlock::jettison):
      (JSC::EvalCodeBlock::jettison):
      (JSC::FunctionCodeBlock::jettison):
      (JSC::CodeBlock::shouldOptimizeNow):
      (JSC::CodeBlock::tallyFrequentExitSites):
      (JSC::CodeBlock::dumpValueProfiles):
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::specializationKind):
      (CodeBlock):
      (JSC::CodeBlock::getJITType):
      * bytecode/CodeBlockHash.cpp: Added.
      (JSC):
      (JSC::CodeBlockHash::CodeBlockHash):
      (JSC::CodeBlockHash::dump):
      * bytecode/CodeBlockHash.h: Added.
      (JSC):
      (CodeBlockHash):
      (JSC::CodeBlockHash::CodeBlockHash):
      (JSC::CodeBlockHash::hash):
      (JSC::CodeBlockHash::operator==):
      (JSC::CodeBlockHash::operator!=):
      (JSC::CodeBlockHash::operator<):
      (JSC::CodeBlockHash::operator>):
      (JSC::CodeBlockHash::operator<=):
      (JSC::CodeBlockHash::operator>=):
      * bytecode/CodeBlockWithJITType.h: Added.
      (JSC):
      (CodeBlockWithJITType):
      (JSC::CodeBlockWithJITType::CodeBlockWithJITType):
      (JSC::CodeBlockWithJITType::dump):
      * bytecode/CodeOrigin.cpp: Added.
      (JSC):
      (JSC::CodeOrigin::inlineDepthForCallFrame):
      (JSC::CodeOrigin::inlineDepth):
      (JSC::CodeOrigin::inlineStack):
      (JSC::InlineCallFrame::hash):
      * bytecode/CodeOrigin.h:
      (InlineCallFrame):
      (JSC::InlineCallFrame::specializationKind):
      (JSC):
      * bytecode/CodeType.cpp: Added.
      (WTF):
      (WTF::printInternal):
      * bytecode/CodeType.h:
      (WTF):
      * bytecode/ExecutionCounter.cpp:
      (JSC::ExecutionCounter::dump):
      * bytecode/ExecutionCounter.h:
      (ExecutionCounter):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseCodeBlock):
      * dfg/DFGDisassembler.cpp:
      (JSC::DFG::Disassembler::dump):
      * dfg/DFGGraph.cpp:
      (JSC::DFG::Graph::dumpCodeOrigin):
      * dfg/DFGOSRExitCompiler.cpp:
      * dfg/DFGOperations.cpp:
      * dfg/DFGRepatch.cpp:
      (JSC::DFG::generateProtoChainAccessStub):
      (JSC::DFG::tryCacheGetByID):
      (JSC::DFG::tryBuildGetByIDList):
      (JSC::DFG::emitPutReplaceStub):
      (JSC::DFG::emitPutTransitionStub):
      (JSC::DFG::dfgLinkClosureCall):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::dumpCallFrame):
      * jit/JITCode.cpp: Added.
      (WTF):
      (WTF::printInternal):
      * jit/JITCode.h:
      (JSC::JITCode::jitType):
      (WTF):
      * jit/JITDisassembler.cpp:
      (JSC::JITDisassembler::dump):
      (JSC::JITDisassembler::dumpForInstructions):
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::privateCompilePutByIdTransition):
      (JSC::JIT::privateCompilePatchGetArrayLength):
      (JSC::JIT::privateCompileGetByIdProto):
      (JSC::JIT::privateCompileGetByIdSelfList):
      (JSC::JIT::privateCompileGetByIdProtoList):
      (JSC::JIT::privateCompileGetByIdChainList):
      (JSC::JIT::privateCompileGetByIdChain):
      (JSC::JIT::privateCompileGetByVal):
      (JSC::JIT::privateCompilePutByVal):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::privateCompilePutByIdTransition):
      (JSC::JIT::privateCompilePatchGetArrayLength):
      (JSC::JIT::privateCompileGetByIdProto):
      (JSC::JIT::privateCompileGetByIdSelfList):
      (JSC::JIT::privateCompileGetByIdProtoList):
      (JSC::JIT::privateCompileGetByIdChainList):
      (JSC::JIT::privateCompileGetByIdChain):
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      * runtime/CodeSpecializationKind.cpp: Added.
      (WTF):
      (WTF::printInternal):
      * runtime/CodeSpecializationKind.h:
      (JSC::specializationFromIsCall):
      (JSC):
      (JSC::specializationFromIsConstruct):
      (WTF):
      * runtime/Executable.cpp:
      (JSC::ExecutableBase::hashFor):
      (JSC):
      (JSC::NativeExecutable::hashFor):
      (JSC::ScriptExecutable::hashFor):
      * runtime/Executable.h:
      (ExecutableBase):
      (NativeExecutable):
      (ScriptExecutable):
      (JSC::ScriptExecutable::source):
      
      Source/WTF: 
      
      Reviewed by Geoffrey Garen.
      
      Changed RawPointer to accept both const void* and void*, and use the former internally.
              
      Cleaned up SHA1 so that the functionality already used internally for self-testing is
      available via the API. This includes addBytes(CString) and computing hex digests.
      
      * wtf/RawPointer.h:
      (WTF::RawPointer::RawPointer):
      (RawPointer):
      (WTF::RawPointer::value):
      * wtf/SHA1.cpp:
      (WTF::expectSHA1):
      (WTF::SHA1::hexDigest):
      (WTF::SHA1::computeHexDigest):
      * wtf/SHA1.h:
      (WTF::SHA1::addBytes):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bfcc38a
    • commit-queue@webkit.org's avatar
      Node::isDescendantOf contains logic that duplicates isDocumentNode · ce1a6e23
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103698
      
      Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-29
      Reviewed by Hajime Morita.
      
      Instead of checking for documents with node->document() == node just
      use node->isDocumentNode().
      
      * dom/Node.cpp:
      (WebCore::Node::isDescendantOf):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce1a6e23
    • ap@apple.com's avatar
      [WK2] Forward cookie jar calls to NetworkProcess · 043d6115
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103457
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      PlatformCookieJar.h functions are now used in WebKit2.
      
      * loader/CookieJar.cpp:
      (WebCore::cookies):
      (WebCore::setCookies):
      (WebCore::cookiesEnabled):
      (WebCore::cookieRequestHeaderFieldValue):
      (WebCore::getRawCookies):
      (WebCore::deleteCookie):
      (WebCore::getHostnamesWithCookies):
      (WebCore::deleteCookiesForHostname):
      (WebCore::deleteAllCookies):
      Use a strategy instead of going to PlatformCookieJar directly.
      
      * platform/Cookie.h: (Cookie): Added a default constructor, so that Cookie could be
      sent over IPC.
      
      * platform/CookiesStrategy.h: Added functions for cookie jar.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/PlatformStrategiesEfl.cpp:
      (PlatformStrategiesEfl::cookiesForDOM):
      (PlatformStrategiesEfl::setCookiesFromDOM):
      (PlatformStrategiesEfl::cookiesEnabled):
      (PlatformStrategiesEfl::cookieRequestHeaderFieldValue):
      (PlatformStrategiesEfl::getRawCookies):
      (PlatformStrategiesEfl::deleteCookie):
      (PlatformStrategiesEfl::getHostnamesWithCookies):
      (PlatformStrategiesEfl::deleteCookiesForHostname):
      (PlatformStrategiesEfl::deleteAllCookies):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/PlatformStrategiesGtk.cpp:
      (PlatformStrategiesGtk::cookiesForDOM):
      (PlatformStrategiesGtk::setCookiesFromDOM):
      (PlatformStrategiesGtk::cookiesEnabled):
      (PlatformStrategiesGtk::cookieRequestHeaderFieldValue):
      (PlatformStrategiesGtk::getRawCookies):
      (PlatformStrategiesGtk::deleteCookie):
      (PlatformStrategiesGtk::getHostnamesWithCookies):
      (PlatformStrategiesGtk::deleteCookiesForHostname):
      (PlatformStrategiesGtk::deleteAllCookies):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebPlatformStrategies.h:
      (WebPlatformStrategies):
      * WebCoreSupport/WebPlatformStrategies.mm:
      (WebPlatformStrategies::cookiesForDOM):
      (WebPlatformStrategies::setCookiesFromDOM):
      (WebPlatformStrategies::cookiesEnabled):
      (WebPlatformStrategies::cookieRequestHeaderFieldValue):
      (WebPlatformStrategies::getRawCookies):
      (WebPlatformStrategies::deleteCookie):
      (WebPlatformStrategies::getHostnamesWithCookies):
      (WebPlatformStrategies::deleteCookiesForHostname):
      (WebPlatformStrategies::deleteAllCookies):
      (WebPlatformStrategies::getPluginInfo):
      (WebPlatformStrategies::bufferForType):
      WebKit1 strategy just uses PlatformCookieJar.
      
      Source/WebKit/qt:
      
      * WebCoreSupport/PlatformStrategiesQt.cpp:
      (PlatformStrategiesQt::cookiesForDOM):
      (PlatformStrategiesQt::setCookiesFromDOM):
      (PlatformStrategiesQt::cookiesEnabled):
      (PlatformStrategiesQt::cookieRequestHeaderFieldValue):
      (PlatformStrategiesQt::getRawCookies):
      (PlatformStrategiesQt::deleteCookie):
      (PlatformStrategiesQt::getHostnamesWithCookies):
      (PlatformStrategiesQt::deleteCookiesForHostname):
      (PlatformStrategiesQt::deleteAllCookies):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebPlatformStrategies.cpp:
      (WebPlatformStrategies::cookiesForDOM):
      (WebPlatformStrategies::setCookiesFromDOM):
      (WebPlatformStrategies::cookiesEnabled):
      (WebPlatformStrategies::cookieRequestHeaderFieldValue):
      (WebPlatformStrategies::getRawCookies):
      (WebPlatformStrategies::deleteCookie):
      (WebPlatformStrategies::getHostnamesWithCookies):
      (WebPlatformStrategies::deleteCookiesForHostname):
      (WebPlatformStrategies::deleteAllCookies):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/PlatformStrategiesWinCE.cpp:
      (PlatformStrategiesWinCE::cookiesForDOM):
      (PlatformStrategiesWinCE::setCookiesFromDOM):
      (PlatformStrategiesWinCE::cookiesEnabled):
      (PlatformStrategiesWinCE::cookieRequestHeaderFieldValue):
      (PlatformStrategiesWinCE::getRawCookies):
      (PlatformStrategiesWinCE::deleteCookie):
      (PlatformStrategiesWinCE::getHostnamesWithCookies):
      (PlatformStrategiesWinCE::deleteCookiesForHostname):
      (PlatformStrategiesWinCE::deleteAllCookies):
      
      Source/WebKit2:
      
      * NetworkProcess/NetworkConnectionToWebProcess.messages.in:
      Added messages to maniputate CookieJar in network process.
      
      * NetworkProcess/NetworkConnectionToWebProcess.h:
      * NetworkProcess/NetworkConnectionToWebProcess.cpp: Removed unnecessary WebCore:: prefixes,
      this file has a using direcive.
      (WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
      (WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
      (WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
      (WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
      (WebKit::NetworkConnectionToWebProcess::getRawCookies):
      (WebKit::NetworkConnectionToWebProcess::deleteCookie):
      (WebKit::NetworkConnectionToWebProcess::getHostnamesWithCookies):
      (WebKit::NetworkConnectionToWebProcess::deleteCookiesForHostname):
      (WebKit::NetworkConnectionToWebProcess::deleteAllCookies):
      Added implementations that use PlatformCookieJar in the network process.
      
      * Scripts/webkit2/messages.py: (struct_or_class):
      * Shared/WebCoreArgumentCoders.h:
      * Shared/WebCoreArgumentCoders.cpp:
      (CoreIPC::::encode):
      (CoreIPC::::decode):
      Added support for Cookie.
      
      * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::WebPlatformStrategies::cookiesForDOM):
      (WebKit::WebPlatformStrategies::setCookiesFromDOM):
      (WebKit::WebPlatformStrategies::cookiesEnabled):
      (WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
      (WebKit::WebPlatformStrategies::getRawCookies):
      (WebKit::WebPlatformStrategies::deleteCookie):
      (WebKit::WebPlatformStrategies::getHostnamesWithCookies):
      (WebKit::WebPlatformStrategies::deleteCookiesForHostname):
      (WebKit::WebPlatformStrategies::deleteAllCookies):
      When using the network process, forward cookie calls to it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      043d6115
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r136167. · 75d085f9
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/136167
      https://bugs.webkit.org/show_bug.cgi?id=103701
      
      Win debug build failure (Requested by zhenyao on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-29
      
      * platform/graphics/chromium/LazyDecodingPixelRef.cpp:
      (WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
      * platform/graphics/chromium/LazyDecodingPixelRef.h:
      (LazyDecodingPixelRef):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75d085f9
    • dpranke@chromium.org's avatar
      webkitpy: autoinstaller is failing on windows · fb581094
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103699
      
      Unreviewed, build fix.
      
      We're attempting to create directories with forward slashes in them;
      this is a no-no on windows.
      
      * Scripts/webkitpy/common/system/autoinstall.py:
      (AutoInstaller._create_scratch_directory_inner):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb581094
    • dgrogan@chromium.org's avatar
      IndexedDB: Propagate more leveldb errors to script · 440efccf
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103580
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      LevelDBDatabase used a single return value to indicate both I/O problems
      and a missing key. Now an out variable is used to indicate if the
      requested key was found. The return value is used to report corruption
      or disk error.
      
      This is a small step toward propagating low level errors everywhere
      possible. So far only one scenario will newly cause script to receive
      an error: when leveldb has trouble looking for existing keys during an
      objectstore->add.
      
      * Modules/indexeddb/IDBBackingStore.cpp:
      (WebCore::getInt):
      (WebCore::getVarInt):
      (WebCore::getString):
      (WebCore::IDBBackingStore::getKeyGeneratorCurrentNumber):
      (WebCore::IDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
      (WebCore::IDBBackingStore::keyExistsInObjectStore):
      * Modules/indexeddb/IDBBackingStore.h:
      (IDBBackingStore):
      * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
      (WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
      (WebCore::IDBObjectStoreBackendImpl::putInternal):
      (WebCore::IDBObjectStoreBackendImpl::generateKey):
      (WebCore::IDBObjectStoreBackendImpl::updateKeyGenerator):
      * Modules/indexeddb/IDBObjectStoreBackendImpl.h:
      (IDBObjectStoreBackendImpl):
      * platform/leveldb/LevelDBDatabase.cpp:
      (WebCore::LevelDBDatabase::safeGet):
      * platform/leveldb/LevelDBDatabase.h:
      (LevelDBDatabase):
      * platform/leveldb/LevelDBTransaction.cpp:
      (WebCore::LevelDBTransaction::safeGet):
      (WebCore):
      (WebCore::LevelDBTransaction::get):
      * platform/leveldb/LevelDBTransaction.h:
      (LevelDBTransaction):
      
      Source/WebKit/chromium:
      
      * tests/IDBFakeBackingStore.h:
       Update method signatures.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      440efccf
    • commit-queue@webkit.org's avatar
      Instantiate snapshot plugins in a PluginProcess with muted audio · 52857948
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101536
      
      Patch by Kiran Muppala <cmuppala@apple.com> on 2012-11-29
      Reviewed by Anders Carlsson.
      
      Plugins created for generation of a snapshot should be instantiated in a separate process with
      muted audio so that any sound generated during the snapshot process is not audible to the user.
      
      * Configurations/WebKit2.xcconfig: Add CoreAudio to the list of linked frameworks.
      * PluginProcess/PluginProcess.h: Add PluginProcess::Type enum with values for regular and
      snapshot process types. Provide DefaultHash and IsInteger template specializations for the enum
      so that PluginProcessConnectionManager can store it in a HashMap.
      * PluginProcess/mac/PluginProcessMac.mm:
      (WebKit::muteAudio):
      (WebKit::PluginProcess::platformInitialize): Mute audio if the process creation parameters indicate
      that the plugin process type is snapshot process.
      * Shared/Plugins/PluginProcessCreationParameters.cpp:
      (WebKit::PluginProcessCreationParameters::encode):
      (WebKit::PluginProcessCreationParameters::decode):
      * Shared/Plugins/PluginProcessCreationParameters.h: Add processType process creation parameter.
      * UIProcess/Plugins/PluginProcessManager.cpp:
      (WebKit::PluginProcessManager::getPluginProcessConnection): Add process type parameter.
      (WebKit::PluginProcessManager::getSitesWithData): Forward message to regular plugin process only.
      (WebKit::PluginProcessManager::clearSiteData): Forward message to regular plugin process only.
      (WebKit::PluginProcessManager::pluginProcessWithPath): Add process type parameter.
      (WebKit::PluginProcessManager::getOrCreatePluginProcess): Ditto.
      * UIProcess/Plugins/PluginProcessManager.h:
      * UIProcess/Plugins/PluginProcessProxy.cpp:
      (WebKit::PluginProcessProxy::create): Add process type parameter.
      (WebKit::PluginProcessProxy::PluginProcessProxy): Ditto.
      (WebKit::PluginProcessProxy::didClose): Include process type with the plugin process crashed message.
      (WebKit::PluginProcessProxy::didFinishLaunching): Set process type process creation parameter.
      * UIProcess/Plugins/PluginProcessProxy.h:
      (WebKit::PluginProcessProxy::processType):
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::getPluginProcessConnection): Pass along process type parameter to
      PluginProcessManager.
      * UIProcess/WebProcessProxy.h:
      (WebProcessProxy):
      * UIProcess/WebProcessProxy.messages.in: Add process type parameter to GetPluginProcessConnection message.
      * WebProcess/Plugins/PluginProcessConnection.cpp:
      (WebKit::PluginProcessConnection::PluginProcessConnection): Add process type parameter.
      * WebProcess/Plugins/PluginProcessConnection.h:
      (WebKit::PluginProcessConnection::create): Ditto.
      (WebKit::PluginProcessConnection::processType): Ditto.
      * WebProcess/Plugins/PluginProcessConnectionManager.cpp:
      (WebKit::PluginProcessConnectionManager::getPluginProcessConnection): Add process type parameter.
      (WebKit::PluginProcessConnectionManager::removePluginProcessConnection): Use process type in addition to
      plugin path to find the connection to remove.
      (WebKit::PluginProcessConnectionManager::pluginProcessCrashed): Add process type parameter.
      * WebProcess/Plugins/PluginProcessConnectionManager.h:
      * WebProcess/Plugins/PluginProxy.cpp:
      (WebKit::PluginProxy::create): Ditto.
      (WebKit::PluginProxy::PluginProxy): Ditto.
      (WebKit::PluginProxy::initialize): Add process type parameter in call to
      PluginProcessConnectionManager::getPluginProcessConnection.
      * WebProcess/Plugins/PluginProxy.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin): Determine process type based on display state of plugin element and
      pass it to PluginProxy::create.
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::pluginProcessCrashed): Pass along process type parameter to
      PluginProcessConnectionManager.
      * WebProcess/WebProcess.h:
      * WebProcess/WebProcess.messages.in: Add process type parameter to PluginProcessCrashed message.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52857948
    • dpranke@chromium.org's avatar
      Fix python unit tests after r136158 (android port tests failing) · 42971050
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103581
      
      Unreviewed, build fix.
      
      The unit tests apparently weren't ran for this patch; we failed
      to update the mock executive calls out to adb to determine various
      aspects of the environment, and were failing to create drivers.
      
      * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
      (MockRunCommand.mock_run_command_fn):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42971050
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r136171. · 328738c6
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/136171
      https://bugs.webkit.org/show_bug.cgi?id=103695
      
      Likely caused ReOpenedWithID and ReOpenedWithURL to fail in
      linux/chromeos (Requested by zhenyao on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-29
      
      Source/WebCore:
      
      * inspector/InspectorClient.h:
      (WebCore::InspectorClient::startMainThreadMonitoring):
      (WebCore::InspectorClient::stopMainThreadMonitoring):
      * inspector/InspectorController.cpp:
      * inspector/InspectorController.h:
      (InspectorController):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::willProcessTaskImpl):
      (WebCore::InspectorInstrumentation::didProcessTaskImpl):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      (WebCore::InspectorInstrumentation::willProcessTask):
      (WebCore):
      (WebCore::InspectorInstrumentation::didProcessTask):
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::start):
      (WebCore::InspectorTimelineAgent::stop):
      
      Source/WebKit/chromium:
      
      * src/InspectorClientImpl.cpp:
      (WebKit::InspectorClientImpl::startMainThreadMonitoring):
      (WebKit):
      (WebKit::InspectorClientImpl::stopMainThreadMonitoring):
      (WebKit::InspectorClientImpl::willProcessTask):
      (WebKit::InspectorClientImpl::didProcessTask):
      * src/InspectorClientImpl.h:
      (InspectorClientImpl):
      * src/WebDevToolsAgentImpl.cpp:
      (WebKit::WebDevToolsAgentImpl::attach):
      (WebKit::WebDevToolsAgentImpl::detach):
      * src/WebDevToolsAgentImpl.h:
      (WebDevToolsAgentImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      328738c6
    • andersca@apple.com's avatar
      Initialize m_xpcConnection to null if the identifier doesn't have an XPC connection · 44383d87
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103689
      
      Reviewed by Darin Adler.
      
      * Platform/CoreIPC/mac/ConnectionMac.cpp:
      (CoreIPC::Connection::platformInitialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44383d87
    • commit-queue@webkit.org's avatar
      Optimization in image decoding. · cc901f18
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88424
      
      Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-29
      Reviewed by Brent Fulgham.
      
      Reduce branching and multiplications in JPEG image decoding loops and functions.
      Code is moved to the template functions with scale and color space template parameters
      because they were reason of branches inside loops. With templated funtions compiler
      will generate separate instance of function for every set of parameters removing
      unreachable code in every condition where constant value is used.
      
      Rebase and update of original patch by Misha Tyutyunik <michael.tyuytunik@nokia.com> .
      
      Thanks to Noel Gordon for his help in cleaning up remaining issues.
      
      Covered by existing tests.
      
      * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
      (WebCore):
      (WebCore::setPixel):
      (WebCore::JPEGImageDecoder::outputScanlines):
      * platform/image-decoders/jpeg/JPEGImageDecoder.h:
      (JPEGImageDecoder):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc901f18
    • haraken@chromium.org's avatar
      Unreviewed, rolling out r135862. · 1ae5d4c8
      haraken@chromium.org authored
      http://trac.webkit.org/changeset/135862
      https://bugs.webkit.org/show_bug.cgi?id=103367
      
      We've been observing 'Fatal error in
      v8::V8::AddMessageListener()' in bots
      
      * bindings/v8/V8Binding.cpp:
      (WebCore::v8NonStringValueToWebCoreString):
      * bindings/v8/V8StringResource.cpp:
      (WebCore::int32ToWebCoreStringFast):
      (WebCore::int32ToWebCoreString):
      * bindings/v8/V8StringResource.h:
      (WebCore::V8StringResource::V8StringResource):
      (WebCore::V8StringResource::prepareBase):
      (WebCore::V8StringResource::setString):
      (V8StringResource):
      (WebCore::V8StringResource::toString):
      (WebCore::::prepare):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ae5d4c8
    • pfeldman@chromium.org's avatar
      Web Inspector: optimize repaint regions upon text editing · 547d9937
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103674
      
      Reviewed by Vsevolod Vlasov.
      
      There is a lot happening that makes repaint area larger than it should be,
      namely unnecessary tabbed pane and navigator updates.
      
      * inspector/front-end/NavigatorView.js:
      (WebInspector.NavigatorView.prototype._updateScriptTitle):
      * inspector/front-end/TabbedPane.js:
      (WebInspector.TabbedPaneTab.prototype.set title):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      547d9937
    • commit-queue@webkit.org's avatar
      [chromium] Remove deprecated API since it is no longer used · ba55292e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103570
      
      Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-11-29
      Reviewed by Adam Barth.
      
      Remove WebPluginContainer::setIsAcceptingTouchEvents, since this is not used anymore,
      in favour of WebPluginContainer::requestTouchEventType.
      
      * public/WebPluginContainer.h:
      (WebPluginContainer):
      * src/WebPluginContainerImpl.cpp:
      * src/WebPluginContainerImpl.h:
      (WebPluginContainerImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba55292e
    • commit-queue@webkit.org's avatar
      Unused parameters on plugins/npapi.cpp · 4b5696ff
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103676
      
      Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-29
      Reviewed by Kentaro Hara.
      
      Because 'instance' and 'menu' are not used when !PLATFORM(QT) || !defined(XP_MACOSX),
      use UNUSED_PARAM macro to fix build warning -Wunused-parameter
      
      * plugins/npapi.cpp:
      (NPN_PopUpContextMenu):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b5696ff
    • commit-queue@webkit.org's avatar
      REGRESSION(r134693): Compilation error on @supports grammar code · 3b4faaa4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103678
      
      Patch by Pablo Flouret <pablof@motorola.com> on 2012-11-29
      Reviewed by Tony Chang.
      
      Coming from https://bugs.webkit.org/show_bug.cgi?id=102295
      
      No new tests, compile fix.
      
      * css/CSSGrammar.y.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b4faaa4
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r136175 and r136177. · 0ed31ee7
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/136175
      http://trac.webkit.org/changeset/136177
      https://bugs.webkit.org/show_bug.cgi?id=103683
      
      Changes did not correct Windows build. (Requested by bfulgham
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-29
      
      * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ed31ee7
    • christophe.dumez@intel.com's avatar
      [CoordinatedGraphics] Use OwnPtr for LayerMap's layers in LayerTreeRenderer · 61e8885b
      christophe.dumez@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103650
      
      Reviewed by Noam Rosenthal.
      
      We currently store raw pointers to WebCore::GraphicsLayer in the LayerMap
      meaning that we need to delete them manually. This patch leverages smart
      pointers and stores layers as OwnPtr in the LayerMap so that the layers
      are owned by the HashMap and we don't have to handle memory manually.
      
      * UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
      (WebKit::LayerTreeRenderer::adjustPositionForFixedLayers):
      (WebKit::LayerTreeRenderer::setLayerChildren):
      (WebKit::LayerTreeRenderer::deleteLayer):
      (WebKit::LayerTreeRenderer::ensureLayer):
      * UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61e8885b
    • andersca@apple.com's avatar
      Add a minimumLayoutWidth WKView property · 3d26164c
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103660
      <rdar://problem/11791729>
      
      Reviewed by Beth Dakin.
      
      When minimumLayoutWidth is set to a positive value, the WKView will update its intrinsic content size given the layout width.
      
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::intrinsicContentSizeDidChange):
      Call the WKView.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView intrinsicContentSize]):
      Override the intrinsicContentSize getter.
      
      (-[WKView _setIntrinsicContentSize:]):
      Update the intrinsic content size and mark it as invalid.
      
      (-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
      By default, the WKView should have no intrinsic size.
      
      (-[WKView minimumLayoutWidth]):
      (-[WKView setMinimumLayoutWidth:]):
      Call through to the WebPageProxy object.
      
      * UIProcess/API/mac/WKViewPrivate.h:
      Add the SPI here.
      
      * UIProcess/DrawingAreaProxy.h:
      (WebKit::DrawingAreaProxy::minimumLayoutWidthDidChange):
      (WebKit::DrawingAreaProxy::didUpdateGeometry):
      (WebKit::DrawingAreaProxy::intrinsicContentSizeDidChange):
      Add empty stubs.
      
      * UIProcess/DrawingAreaProxy.messages.in:
      Update the DidUpdateGeometry signature and add IntrinsicContentSizeDidChange.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy):
      Initialize the minimum layout width.
      
      (WebKit::WebPageProxy::setMinimumLayoutWidth):
      Update the minimum layout width and call the drawing area proxy.
      
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::minimumLayoutWidth):
      Add getter.
      
      * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
      (TiledCoreAnimationDrawingAreaProxy):
      * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
      (WebKit::TiledCoreAnimationDrawingAreaProxy::minimumLayoutWidthDidChange):
      Update the geometry if needed.
      
      (WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
      Update the intrinsic content size.
      
      (WebKit::TiledCoreAnimationDrawingAreaProxy::intrinsicContentSizeDidChange):
      Call through to WebPageProxy::intrinsicContentSizeDidChange.
      
      (WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
      Pass along the minimum layout width.
      
      * UIProcess/mac/WebPageProxyMac.mm:
      (WebKit::WebPageProxy::intrinsicContentSizeDidChange):
      Call through to the page client.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::contentsSizeChanged):
      Call DrawingArea::mainFrameContentSizeChanged.
      
      * WebProcess/WebPage/DrawingArea.h:
      (WebKit::DrawingArea::mainFrameContentSizeChanged):
      Add empty stub.
      
      (WebKit::DrawingArea::updateGeometry):
      Update signature.
      
      * WebProcess/WebPage/DrawingArea.messages.in:
      Add minimumLayoutWidth to UpdateGeometry.
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
      If the content size change is not coming from updateGeometry, send an InstrinsicContentSizeDidChange message.
      
      (WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
      If m_minimumLayoutWidth is positive, do an initial layout pass to figure out the height of the page and then do another
      layout with the viewport set to that height.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d26164c
    • bfulgham@webkit.org's avatar
      [Windows, WinCairo] Unreviewed build correction. Correct debug · 8f8207ff
      bfulgham@webkit.org authored
      build case on build machine.
      
      * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f8207ff
    • zmo@google.com's avatar
      Unreviewed. Rolled DEPS. · ec13e224
      zmo@google.com authored
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-29
      
      * DEPS:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec13e224
    • bfulgham@webkit.org's avatar
      [Windows, WinCairo] Unreviewed build correction. Hide the · 7e7ca2ca
      bfulgham@webkit.org authored
      unexported 'notSolidColor' symbol when testing against
      the BitmapImage class to avoid having to deal with a
      debug-only symbol in the Windows export definition file.
      
      * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e7ca2ca
    • simon.fraser@apple.com's avatar
      Avoid painting lots of small rects in WebLayer painting · 1a4c1920
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103673
      
      Reviewed by Tim Horton.
      
      r109186 added code in drawLayerContents() to enumerate over the rects in
      the CALayer's dirty region, and paint them individually. This was done
      to help performance on the IE Maze Solver test.
      
      On large, complex pages like Facebook, the overhead of traversing the
      RenderLayer tree for painting is such that it's better to paint a single,
      or fewer rects rather than lots of little ones.
      
      So adopt a heuristic similar to that in DrawingArea, where if the
      combined area of the small rects is 75% or more of the combined rect,
      just paint the combined rect. Also paint the combined rect if there
      are more than 5 individual rects.
      
      I verified that this preserves the optimization for IE Maze Solver.
      
      * platform/graphics/mac/WebLayer.mm:
      (drawLayerContents):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a4c1920
    • zhajiang@rim.com's avatar
      [BlackBerry] window.open can load url twice which can cause security and timing issues · 19fbb9d4
      zhajiang@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103670
      
      Patch by Jacky Jiang <zhajiang@rim.com>.
      Reviewed by Yong Li.
      
      PR: 252234
      When we call window.open() in JS, DOMWindow will create a window and
      change the url to load the resources. However, during the window
      creation, we dispatch an OpenWindow event with the url to browser side
      and browser side loads the url thereafter as well.
      DOMWindow::createWindow() is only required to create the window not to
      load url as far as I can tell. This is unneccessary and can cause
      unexpected issues. So just pass an empty url instead to avoid
      the double-load issue.
      
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::createWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19fbb9d4
    • andersca@apple.com's avatar
      CoreIPC::Connection should retain its xpc_connection_t · af8acc83
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103671
      <rdar://problem/12717331>
      
      Reviewed by Beth Dakin.
      
      * Platform/CoreIPC/mac/ConnectionMac.cpp:
      (CoreIPC::Connection::platformInitialize):
      Retain the xpc_connection_t object here to balance the xpc_object_release in platformInvalidate.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af8acc83
    • commit-queue@webkit.org's avatar
      Source/WebCore: Web Inspector: Web Inspector: Make main-thread monitoring go... · b0336b7c
      commit-queue@webkit.org authored
      Source/WebCore: Web Inspector: Web Inspector: Make main-thread monitoring go through InspectorController.
      https://bugs.webkit.org/show_bug.cgi?id=103550
      
      Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-11-29
      Reviewed by Pavel Feldman.
      
      InspectorInstrumentation was a wrong path.
      
      * inspector/InspectorClient.h: Remove start/stop methods.
      * inspector/InspectorController.cpp:
      Dispatch main thread activity notifications.
      * inspector/InspectorController.h: Ditto.
      * inspector/InspectorInstrumentation.cpp: Remove dispatching.
      * inspector/InspectorInstrumentation.h: Ditto.
      * inspector/InspectorTimelineAgent.cpp:
      Do not subscribe for notifications explicitly.
      
      Source/WebKit/chromium: Web Inspector: Make main-thread monitoring go through InspectorController.
      https://bugs.webkit.org/show_bug.cgi?id=103550
      
      Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-11-29
      Reviewed by Pavel Feldman.
      
      InspectorInstrumentation was a wrong path
      
      * src/InspectorClientImpl.cpp: Remove TaskObserver implementation, and
      listen/unlisten methods.
      * src/InspectorClientImpl.h: Ditto.
      * src/WebDevToolsAgentImpl.cpp:
      (WebKit::WebDevToolsAgentImpl::attach):
      Subscribe for main thread activity events.
      (WebKit::WebDevToolsAgentImpl::detach):
      Unsubscribe for main thread activity events.
      (WebKit::WebDevToolsAgentImpl::willProcessTask): Implement TaskObserver
      interface. Froward to InspectorController.
      (WebKit::WebDevToolsAgentImpl::didProcessTask): Ditto.
      * src/WebDevToolsAgentImpl.h: Implement TaskObserver interface.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0336b7c
    • abarth@webkit.org's avatar
      [V8] DOM callbacks shouldn't reimplement ScopedPersistent they should use it · 2445508d
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103662
      
      Reviewed by Eric Seidel.
      
      This patch replaces yet another instance of the ScopedPersistent
      pattern with ScopedPersistent.
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateCallbackHeader):
      (GenerateCallbackImplementation):
      * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
      (WebCore::V8SQLStatementErrorCallback::handleEvent):
      * bindings/v8/custom/V8MutationCallbackCustom.cpp:
      (WebCore::V8MutationCallback::handleEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2445508d
    • commit-queue@webkit.org's avatar
      Make LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it · 52261e06
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103555
      
      Patch by Min Qin <qinmin@chromium.org> on 2012-11-29
      Reviewed by Stephen White.
      
      Expose LazyDecodingPixelRef to the cc thread by inheriting from skia::LazyPixelRef.
      No test added for now as impl side paiting is still WIP.
      
      * platform/graphics/chromium/LazyDecodingPixelRef.cpp:
      (WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
      (WebCore::LazyDecodingPixelRef::PrepareToDecode):
      (WebCore):
      (WebCore::LazyDecodingPixelRef::Decode):
      * platform/graphics/chromium/LazyDecodingPixelRef.h:
      (LazyDecodingPixelRef):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52261e06
    • jchaffraix@webkit.org's avatar
      Unreviewed build fix. · 33d35304
      jchaffraix@webkit.org authored
      * WebCore.gypi:
      The new file is GridTrackSize.h not GridTrackSizes.h. For some reason, the
      EWS didn't complain.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33d35304
    • zmo@google.com's avatar
      Unreviewed, WebKit gardening. · 3643cec9
      zmo@google.com authored
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3643cec9
    • jknotten@chromium.org's avatar
      Use GeolocationController's last geoposition as cached position. · 98d7737a
      jknotten@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103540
      
      Reviewed by Benjamin Poulain.
      
      The page's GeolocationController mediates access to the
      GeolocationClient for multiple frames' Geolocation instances. This
      patch changes the position cache to be on the GeolocationController
      rather than on the Geolocation instance.
      
      This fixes a bug where if one frame has has received a fresh
      position, then a request for a cached position from a second frame
      does not succeed because the Geolocation instance in the second
      frame's position cache hasn't received the position update that
      went to the first frame.
      
      Source/WebCore:
      
      Test: fast/dom/Geolocation/cached-position-iframe.html
      
      * Modules/geolocation/Geolocation.cpp:
      (WebCore::Geolocation::makeCachedPositionCallbacks):
      (WebCore::Geolocation::haveSuitableCachedPosition):
      (WebCore::Geolocation::positionChanged):
      * Modules/geolocation/Geolocation.h:
      * Modules/geolocation/GeolocationController.h:
      (GeolocationController):
      
      LayoutTests:
      
      * fast/dom/Geolocation/cached-position-iframe-expected.txt: Added.
      * fast/dom/Geolocation/cached-position-iframe.html: Added.
      * fast/dom/Geolocation/resources/cached-position-iframe-inner.html: Added.
      * fast/dom/Geolocation/script-tests/cached-position-iframe.js: Added.
      (window.onmessage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98d7737a
    • commit-queue@webkit.org's avatar
      Web Inspector: Allow sorting in NMI snapshot grid view · 08230bb4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102955
      
      Patch by Alexei Filippov <alph@chromium.org> on 2012-11-29
      Reviewed by Yury Semikhatsky.
      
      * English.lproj/localizedStrings.js:
      * inspector/front-end/NativeMemorySnapshotView.js:
      (WebInspector.NativeSnapshotDataGrid.prototype.sortingChanged):
      (WebInspector.NativeSnapshotDataGrid.prototype._sortingFunction):
      (WebInspector.NativeSnapshotNode):
      (WebInspector.NativeSnapshotNode.prototype._storeState):
      (WebInspector.NativeSnapshotNode.prototype._restoreState):
      (WebInspector.NativeSnapshotNode.prototype.uid):
      (WebInspector.NativeSnapshotNode.prototype._createSizeCell):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08230bb4
    • commit-queue@webkit.org's avatar
      [BlackBerry] Modifying GeoClientBlackBerry to switch between high and low accuracy · e7236b71
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103666
      
      Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-29
      Reviewed by Yong Li.
      
      Internally reviewed by Yong Li.
      
      PR 243420
      
      Updating GeolocationClientBlackBerry to switch accuracy when GeolocationController
      calls setEnableHighAccuracy.
      
      * WebCoreSupport/GeolocationClientBlackBerry.cpp:
      (GeolocationClientBlackBerry::startUpdating):
      (GeolocationClientBlackBerry::setEnableHighAccuracy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7236b71
    • zmo@google.com's avatar
      Unreviewed, WebKit gardening. · b53f17cf
      zmo@google.com authored
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b53f17cf
    • schenney@chromium.org's avatar
      [Chromium] Skia rebaseline after we made kSrc_Mode go faster · 4cfe5431
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      Some of these are still crashing on Debug.
      
      * platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
      * platform/chromium-mac-lion/svg/carto.net/colourpicker-expected.png:
      * platform/chromium-mac-lion/svg/custom/invalid-uri-stroke-expected.png:
      * platform/chromium-mac-lion/svg/wicd/test-scalable-background-image1-expected.png:
      * platform/chromium-mac-lion/svg/zoom/page/zoom-mask-with-percentages-expected.png:
      * platform/chromium-mac-snowleopard/svg/carto.net/colourpicker-expected.png:
      * platform/chromium-mac-snowleopard/svg/custom/invalid-uri-stroke-expected.png:
      * platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
      * platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
      * platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
      * platform/chromium-mac/svg/carto.net/colourpicker-expected.png:
      * platform/chromium-mac/svg/custom/gradient-stop-corner-cases-expected.png:
      * platform/chromium-mac/svg/custom/invalid-uri-stroke-expected.png:
      * platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png:
      * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
      * platform/chromium-win-xp/svg/carto.net: Added.
      * platform/chromium-win-xp/svg/carto.net/colourpicker-expected.png: Added.
      * platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.png:
      * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
      * platform/chromium-win/svg/custom/invalid-uri-stroke-expected.png:
      * platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
      * platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cfe5431
    • bfulgham@webkit.org's avatar
      [Windows, WinCairo] Unreviewed build fix. Build was failing · 0b963528
      bfulgham@webkit.org authored
      because the export definition file included a debug-only
      symbol.  It's not needed and shouldn't be included for export.
      
      * win/WebKit2.def: Don't require notSolidColor to be exported.
      * win/WebKit2CFLite.def: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b963528
    • peter@chromium.org's avatar
      run-perf-tests --chromium-android should not require adb in my path · a05010ff
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103581
      
      Reviewed by Eric Seidel.
      
      Remove the need to have "adb" available in the path for Layout and Performance
      tests. We'll determine the versions of the "adb" version in path (if any) and
      the one provided in the Chromium Android checkout. Unless the "adb" available
      in the path is newer, the provided version will be used.
      
      Some other minor nits addressed:
      - The path_to_forwarder/path_to_md5sum should not be in the "private overrides"
        section, as they're not overriding anything and are used by the driver.
      - Make _restart_adb_as_root slightly more robust by waiting for the device
        to come back online regardless of the output.
      
      * Scripts/webkitpy/layout_tests/port/chromium_android.py:
      (ChromiumAndroidPort.__init__):
      (ChromiumAndroidPort.check_build):
      (ChromiumAndroidPort.path_to_adb):
      (ChromiumAndroidPort):
      (ChromiumAndroidPort.path_to_forwarder):
      (ChromiumAndroidPort.path_to_md5sum):
      (ChromiumAndroidPort._path_to_helper):
      (ChromiumAndroidPort._determine_adb_version):
      (ChromiumAndroidPort._get_devices):
      (ChromiumAndroidDriver.__init__):
      (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
      (ChromiumAndroidDriver._push_executable):
      (ChromiumAndroidDriver._restart_adb_as_root):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a05010ff
    • commit-queue@webkit.org's avatar
      [BlackBerry] Do not adjust scroll position on viewport resizes that are not... · ad248366
      commit-queue@webkit.org authored
      [BlackBerry] Do not adjust scroll position on viewport resizes that are not orientation change related
      https://bugs.webkit.org/show_bug.cgi?id=103659
      
      Patch by Andrew Lo <anlo@rim.com> on 2012-11-29
      Reviewed by Rob Buis.
      Internally reviewed by Gen Mak.
      
      Internal PR253893.
      Only adjust scroll position during an orientation change
      when setting viewport size.
      We don't want the scroll position jumping around when opening
      & closing the VKB.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad248366
    • schenney@chromium.org's avatar
      [Chromium] Rebaseline after removed double drawing of clipped hairlines at edges · 7d28f638
      schenney@chromium.org authored
      Unreviewed expectations update
      
      * platform/chromium-linux-x86/svg/hixie/perf/003-expected.png: Removed.
      * platform/chromium-mac-lion/fast/repaint/list-marker-expected.png: Added.
      * platform/chromium-mac-lion/svg/hixie/perf/001-expected.png: Added.
      * platform/chromium-mac-lion/svg/hixie/perf/002-expected.png: Added.
      * platform/chromium-mac-lion/svg/hixie/perf/003-expected.png:
      * platform/chromium-mac-lion/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
      * platform/chromium-mac-lion/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
      * platform/chromium-mac-snowleopard/fast/repaint/list-marker-expected.png:
      * platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
      * platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
      * platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
      * platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
      * platform/chromium-mac/fast/repaint/list-marker-expected.png:
      * platform/chromium-mac/svg/hixie/perf/001-expected.png:
      * platform/chromium-mac/svg/hixie/perf/002-expected.png:
      * platform/chromium-mac/svg/hixie/perf/003-expected.png:
      * platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
      * platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
      * platform/chromium-win/fast/repaint/list-marker-expected.png:
      * platform/chromium-win/svg/hixie/perf/001-expected.png:
      * platform/chromium-win/svg/hixie/perf/002-expected.png:
      * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
      * platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
      * platform/gtk/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
      * platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
      * svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d28f638
    • schenney@chromium.org's avatar
      [Chromium] Rebaseline after SK_DISABLE_EXTRACTSUBSET_OPAQUE_FIX was removed · 3ebb324f
      schenney@chromium.org authored
      Unreviewed test expectations update.
      
      * platform/chromium-linux-x86/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Removed.
      * platform/chromium-linux-x86/svg/custom/clip-mask-negative-scale-expected.png: Removed.
      * platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.png:
      * platform/chromium-mac-lion/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
      * platform/chromium-mac-lion/fast/borders/border-image-rotate-transform-expected.png: Added.
      * platform/chromium-mac-lion/fast/forms/select-style-expected.png: Added.
      * platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png: Added.
      * platform/chromium-mac-lion/svg/custom/focus-ring-expected.png: Added.
      * platform/chromium-mac-lion/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
      * platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/select-style-expected.png:
      * platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
      * platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
      * platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
      * platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
      * platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
      * platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
      * platform/chromium-mac/fast/forms/select-style-expected.png:
      * platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
      * platform/chromium-mac/svg/custom/focus-ring-expected.png:
      * platform/chromium-mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
      * platform/chromium-win-xp/svg/custom/clip-mask-negative-scale-expected.png: Removed.
      * platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
      * platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:
      * platform/chromium-win/fast/borders/borderRadiusDashed06-expected.png:
      * platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
      * platform/chromium-win/svg/custom/focus-ring-expected.png:
      * platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ebb324f