1. 14 Jan, 2003 3 commits
    • darin's avatar
      Reviewed by Maciej. · 0bb44c36
      darin authored
      	- first cut at XML parsing with expat
      
              * khtml/khtml_part.cpp: (KHTMLPart::begin): Remove APPLE_CHANGES and use the XML
      	code for text/xml documents.
      
              * WebCore.pbproj/project.pbxproj: Added the ForwardingHeaders to the project.
      	Added new QXml files, removed old ones.
      
              * kwq/KWQXml.h: Removed.
              * kwq/KWQXml.mm: Removed.
      
              * kwq/KWQXmlAttributes.h: Added.
              * kwq/KWQXmlAttributes.mm: Added.
              * kwq/KWQXmlDefaultHandler.h: Added.
              * kwq/KWQXmlDefaultHandler.mm: Added.
              * kwq/KWQXmlSimpleReader.h: Added.
              * kwq/KWQXmlSimpleReader.mm: Added.
      
              * kwq/KWQString.h: Add fromUtf8 functions.
              * kwq/KWQString.mm: (QString::fromUtf8): Added. Simple implementation just
      	calls fromStringWithEncoding. We may need something more efficient later,
      	at least for all-ASCII text.
      
      	- other changes
      
              * khtml/khtml_part.h: Fix spelling of occurrence.
      
              * khtml/misc/decoder.cpp: (Decoder::decode): Turn on Japanese auto-detect.
      	It doesn't seem to work yet, but this does no harm.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bb44c36
    • rjw's avatar
      Fix for 3139120. This patch was contributed by Mitz Pettel. It correctly · 2028aa44
      rjw authored
              handles the visually ordered encodings.  The patch also picks up changes
              from kde that accounts for european numbers correctly in bidiReorderLine().
      
              Reviewed by Dave.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2028aa44
    • darin's avatar
      Reviewed by Trey, John, and Maciej, and given the seal of approval by Don. · 31d40d53
      darin authored
      	- fixed 3143317 -- plug-in supplied URLs cause correspondingly named files in /tmp to be deleted
      	- fixed 3143330 -- plug-in supplied URLs can overwrite files used in other windows by same plug-in
      
              * Plugins.subproj/WebBaseNetscapePluginStream.h: Make path be a char * rather than an NSString.
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream dealloc]): Use unlink() to delete the temporary file we made.
      	Since we created the file, we know it doesn't have any fancy stuff like a resource fork.
              (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Create the file with mkstemp instead of
      	trying to come up with our own filename. This eliminates the need to delete an old file (because we
      	are guaranteed the file is new) and also mkstemp opens the file for us, so we just need to write
      	the contents.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for above changes.
      
              - unrelated change to help with other bug analysis
      
              * WebView.subproj/WebBaseResourceHandleDelegate.m: Added assertions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31d40d53
  2. 13 Jan, 2003 4 commits
    • cblu's avatar
      WebFoundation: · bd135e16
      cblu authored
      	Fix for checking and creating proper download filenames.
      
              Reviewed by mjs, kocienda, trey.
      
              * CacheLoader.subproj/WebResourceResponse.h:
              * CacheLoader.subproj/WebResourceResponse.m: removed the filename method. That is now a category in WebKit
              * CacheLoader.subproj/WebResourceResponsePrivate.h:
              * Misc.subproj/WebNSStringExtras.h:
              * Misc.subproj/WebNSStringExtras.m:
              (-[NSString _web_filenameByFixingIllegalCharacters]): new, turns "/" into "-", strips leading dots
              * ProtocolHandlers.subproj/WebHTTPProtocolHandler.m:
              (-[WebHTTPProtocolHandler setResponseMetadata:]): don't parse out the content disposition. This is done in WebKit.
      
      WebKit:
      
      	Fix for checking and creating proper download filenames.
      
              Reviewed by mjs, kocienda, trey.
      
              * WebKit.pbproj/project.pbxproj:
              * WebView.subproj/WebControllerPolicyDelegate.h: changes for renamed savePathForResponse:andRequest: method
              * WebView.subproj/WebDefaultPolicyDelegate.m: changes for renamed savePathForResponse:andRequest: method
              (-[WebDefaultPolicyDelegate savePathForResponse:andRequest:]): renamed
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient continueAfterContentPolicy:response:]): changes for renamed savePathForResponse:andRequest: method
      
      WebBrowser:
      
      	Fix for checking and creating proper download filenames.
      
              Reviewed by mjs, kocienda, trey.
      
              * BrowserDocument.m:
              (-[BrowserDocument pageName]): call _web_filenameByFixingIllegalCharacters on the web page title when saving the document
              * BrowserWebController.m:
              (-[BrowserWebController savePathForResponse:andRequest:]): renamed, removed temporary that checks for invalid filename. That work is done in WebKit.
              * HTMLSourceDocument.m:
              (-[HTMLSourceDocument displayName]): call suggestedFilenameForSaving
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd135e16
    • darin's avatar
      * kjs/ustring.h: Fix spelling of occurrence. · b87b8515
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b87b8515
    • darin's avatar
      Reviewed by Ken. · 908cf2a7
      darin authored
      	- fixed 3143781 -- submitting the same form twice doesn't work properly
      	(example at directory.apple.com)
      
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Only run the "don't submit the same
      	form twice" logic when the form is one that affects the frame that the form is in.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      908cf2a7
    • darin's avatar
      Reviewed by Maciej. · 60414e6b
      darin authored
      	- turned more recursion into iteration, and fixed some backwards stuff
      
              * kjs/grammar.y: Use the normal idiom for CaseClauses and FormalParameterList
      	rather than using append().
              * kjs/grammar.cpp: Regenerated.
      
              * kjs/nodes.h: Change ClauseListNode and ParameterNode to use the normal idiom,
      	and got rid of append methods. Also added friend declarations and calls to reverseList().
              * kjs/nodes.cpp:
              (StatListNode::ref): Iteration, not recursion.
              (StatListNode::deref): Iteration, not recursion.
              (StatListNode::execute): Iteration, not recursion.
              (StatListNode::processVarDecls): Iteration, not recursion.
              (CaseClauseNode::reverseList): Added.
              (ClauseListNode::ref): Iteration, not recursion.
              (ClauseListNode::deref): Iteration, not recursion.
              (ClauseListNode::processVarDecls): Iteration, not recursion.
              (CaseBlockNode::reverseLists): Added.
              (ParameterNode::ref): Iteration, not recursion.
              (ParameterNode::deref): Iteration, not recursion.
              (FuncDeclNode::reverseParameterList): Added.
              (FuncExprNode::reverseParameterList): Added.
              (SourceElementsNode::ref): Iteration, not recursion.
              (SourceElementsNode::deref): Iteration, not recursion.
              (SourceElementsNode::execute): Use variable name of n to match other functions.
              (SourceElementsNode::processFuncDecl): Ditto.
              (SourceElementsNode::processVarDecls): Ditto.
      
              * kjs/nodes2string.cpp:
              (SourceStream::operator<<): Used a switch statement for a bit of added clarity.
              (ElementNode::streamTo): Iteration, not recursion.
              (PropertyValueNode::streamTo): Iteration, not recursion.
              (ArgumentListNode::streamTo): Iteration, not recursion.
              (StatListNode::streamTo): Iteration, not recursion, and fixed order.
              (VarDeclListNode::streamTo): Iteration, not recursion.
              (ClauseListNode::streamTo): Used for statement to match other functions.
              (CaseBlockNode::streamTo): Used for statement to match other functions.
              (ParameterNode::streamTo): Iteration, not recursion.
              (SourceElementsNode::streamTo): Iteration, not recursion, and fixed order that has been
      	backwards since I changed how this works in nodes.cpp.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60414e6b
  3. 12 Jan, 2003 7 commits
    • darin's avatar
      * WebCorePrefix.h: Needed to touch this file since we now have plain C source (expat). · 767b3718
      darin authored
              * kwq/KWQKHTMLPart.cpp: Reformatted a bit.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      767b3718
    • darin's avatar
      Reviewed by Maciej. · 68877da7
      darin authored
      	- first step towards integrating expat for XML support: make it compile and link
      
              * kwq/KWQXml.mm: (QXmlSimpleReader::parse): Put in a placeholder that calls expat.
      	Mainly just used to make sure we link.
      
              * WebCore.pbproj/project.pbxproj: Added expat files.
      
              * expat/COPYING: Added.
              * expat/Changes: Added.
              * expat/MANIFEST: Added.
              * expat/README: Added.
              * expat/expat_config.h: Added.
              * expat/lib/ascii.h: Added.
              * expat/lib/asciitab.h: Added.
              * expat/lib/expat.h: Added.
              * expat/lib/iasciitab.h: Added.
              * expat/lib/internal.h: Added.
              * expat/lib/latin1tab.h: Added.
              * expat/lib/nametab.h: Added.
              * expat/lib/utf8tab.h: Added.
              * expat/lib/xmlparse.c: Added.
              * expat/lib/xmlrole.c: Added.
              * expat/lib/xmlrole.h: Added.
              * expat/lib/xmltok.c: Added.
              * expat/lib/xmltok.h: Added.
              * expat/lib/xmltok_impl.c: Added.
              * expat/lib/xmltok_impl.h: Added.
              * expat/lib/xmltok_ns.c: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68877da7
    • darin's avatar
      Reviewed by John. · f9855741
      darin authored
      	- fixed 3144882 -- pretend to be WinIE for abcnews.com
      
              * WebView.subproj/WebControllerPrivate.h: Add an enum, UserAgentStringType, with values
      	Safari, MacIE, and WinIE. Also add NumUserAgentStringTypes and turn the userAgent and
      	userAgentWhenPretendingToBeMacIE strings into an array indexed by type.
      
              * WebView.subproj/WebController.m:
              (-[WebController setApplicationNameForUserAgent:]): Use a loop to discard the user agent
      	strings, since we have an array now.
              (-[WebController userAgentForURL:]): Change user agent algorithm to check two strings rather
      	than once against the spoof table, allowing two dots in the "domain name", which is needed
      	for "abcnews.go.com". Get a user agent string type from the table rather than just a boolean
      	"pretend to be MacIE". Store a string per type rather than one for normalcy and one for MacIE.
      	Add a case for WinIE to the user agent computations.
      
      	* English.lproj/StringsNotToBeLocalized.txt: Update for change above.
      
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebControllerPrivate dealloc]): Use a loop to discard the user agent strings, since we have
      	an array now.
              (-[WebController _defaultsDidChange]): Ditto.
      
              * WebView.subproj/WebUserAgentSpoofTable.gperf: Add a UserAgentStringType field to the struct.
      	Add MacIE to each existing table entry, and add a new one that says WinIE for abcnews.go.com.
      
              * Makefile.am: Pass "-F ,0" to gperf so that we don't get warnings compiling empty entries
      	in the hash table.
      
              * WebView.subproj/WebUserAgentSpoofTable.c: Re-generated.
      
              - other changes
      
              * WebView.subproj/WebHTMLView.m: Removed some old, dead, #if 0'd code.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9855741
    • darin's avatar
      Reviewed by John. · ffcf8970
      darin authored
      	- changes inspired by things I noticed reviewing diffs vs. KDE when preparing the tarball
      
              * kjs/function.cpp: (GlobalFuncImp::call): Use strtol when strtoll is
      	not available. Do #ifndef NDEBUG, not #if !NDEBUG.
              * kjs/function.h: Do #ifndef NDEBUG, not #if !NDEBUG.
              * kjs/internal.cpp:
              (InterpreterImp::initGlobalObject): Do #ifndef NDEBUG, not #if !NDEBUG.
              (KJS::printInfo): Remove case for ListType and remove default case that just
      	ends up suppressing the "missing case" warning and does no good.
              * kjs/interpreter.cpp: (Interpreter::evaluate): Do #ifndef NDEBUG, not #if !NDEBUG.
              * kjs/nodes.cpp:
              (Node::finalCheck): Fix accidentally-deleted code in an ifdef we never compile.
              (FunctionCallNode::evaluate): Remove bogus XXX comment. Maciej put this comment in,
              and together we determined it's not needed.
              (TypeOfNode::evaluate): Ditto.
              * kjs/object.cpp: Remove assert that refers to ListType.
              * kjs/value.h: Remove ListType.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffcf8970
    • darin's avatar
      Reviewed by Dave. · d8d3bd9d
      darin authored
      	- minor cleanup of plug-in-related classes in ECMA directory
      
              * khtml/ecma/kjs_navigator.cpp: Remove unneeded PluginBase member functions
      	ref() and deref(). Instead just make Plugin and MimeType both derive from
      	PluginBase and remove APPLE_CHANGES.
              (Navigator::getValueProperty): Don't use "Konqueror" for the fallback.
      	Just return Undefined() for that case since we will never reach it anyway.
      
      	- simplify the logic in khtmlMoveMouseEvent so it's easier to decipher
      
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): By merging two
      	identical if statements, the logic of this function becomes much clearer.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8d3bd9d
    • darin's avatar
      Reviewed by Dave. · 50560aa1
      darin authored
      	- fixed a bunch of places where KHTML did !x == y instead of !(x == y) or x != y.
      
              * khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule):
              * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
              * khtml/misc/loader.cpp: (Cache::requestImage), (Cache::requestStyleSheet):
              * khtml/rendering/render_flow.cpp: (RenderFlow::setStyle):
      	Changed !x == y to x != y. In each case, there's a reason that this does not create
      	any problem in practice, which is why we didn't rush to get this in for beta 1.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50560aa1
    • darin's avatar
      Reviewed by John. · 895eae19
      darin authored
      	- fixed 3144789 -- reproducible crash in KHTMLParser::freeBlock on a page at www.library.arizona.edu
      
              * khtml/html/htmlparser.cpp: (KHTMLParser::finished): Call freeBlock here rather than
      	waiting until the parser is destroyed. This fixes the bug because when the parser is
              destroyed, the document is already destroyed, so we have a dangling current pointer to an
      	already-destroyed node.
      
      	- fixed 3142024 -- crash/hang/assert on java.sun.com in HTMLTokenizer
      
      	The bug was caused by an erroneous clicked signal that was being emitted by
      	QListBox at just the wrong time.
      
              * kwq/KWQListBox.h: Added _changingSelection boolean.
              * kwq/KWQListBox.mm: (QListBox::QListBox): Set _changingSelection to false.
              (QListBox::setSelected): Set _changingSelection to true.
              (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Only emit the "clicked"
      	signal if _changingSelection is false.
      
              * khtml/html/htmltokenizer.h: Add debug-only boolean inWrite.
              * khtml/html/htmltokenizer.cpp: (HTMLTokenizer::HTMLTokenizer): Set inWrite to false.
      	(HTMLTokenizer::write): Set inWrite to true.
      	(HTMLTokenizer::~HTMLTokenizer): Assert that inWrite is not true.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      895eae19
  4. 11 Jan, 2003 2 commits
    • darin's avatar
      Reviewed by John. · ffe35f4f
      darin authored
      	- fixed 3144479 -- put TITLE from links in status bar
      
              * WebKit.exp: Add _WebElementLinkTitleKey and also sort this file.
      
              * WebCoreSupport.subproj/WebImageRenderer.m: Need to touch a file to get the above
      	to have any effect, so update the copyright date here.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffe35f4f
    • darin's avatar
      Reviewed by Dave. · c935e41a
      darin authored
      	- fixed 3136944 -- mouseover feedback over non-mapped part of image map claims
      	link to current page
      
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
      	Change code so we won't call completeURL and complete a null ATTR_HREF (which is distinct
      	from an empty ATTR_HREF). Did a similar cleanup on the image code.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c935e41a
  5. 10 Jan, 2003 1 commit
    • darin's avatar
      JavaScriptCore: · 33188225
      darin authored
              * JavaScriptCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove CFHumanReadableCopyright, remove NSPrincipalClass.
      
              * English.lproj/InfoPlist.strings: Updated to match above changes.
      
      WebFoundation:
      
              * WebFoundation.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove NSHumanReadableCopyright, remove NSPrincipalClass.
      
              * English.lproj/InfoPlist.strings: Update to match above.
      
      WebCore:
      
              * WebCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove NSHumanReadableCopyright, remove NSPrincipalClass, remove SKIP_INSTALL
      	that was in the Info plist instead of project settings.
      
              * English.lproj/InfoPlist.strings: Update to match above.
      
      WebKit:
      
              * WebKit.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove CFHumanReadableCopyright, remove NSPrincipalClass.
      
              * English.lproj/InfoPlist.strings: Updated to match above changes.
      
      WebBrowser:
      
              * WebBrowser.pbproj/project.pbxproj: Add 2003 to copyright, bump versions
      	to 0.8.1 and 52u to keep up with the branch.
      
              * English.lproj/InfoPlist.strings: Update to match above.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33188225
  6. 09 Jan, 2003 11 commits
    • darin's avatar
      Lets call this 51u, not 50u. · adb2832b
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adb2832b
    • darin's avatar
      WebKit: · 066636cc
      darin authored
              Reviewed by Maciej.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      WebBrowser:
      
              Reviewed by Maciej.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
              * English.lproj/Localizable.strings: Regenerate.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      066636cc
    • rjw's avatar
      Fixed 3143361. This was a regression introduced with some image · a48249a4
      rjw authored
              rendering optimizations.  Don't bypass the tiling code path if
              the image needs to be rendered out-of-phase.
      
              Reviewed by hyatt.
      
              * WebCoreSupport.subproj/WebImageRenderer.m:
              (-[WebImageRenderer tileInRect:fromPoint:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a48249a4
    • darin's avatar
      Reviewed by Chris. · 7b10f2ff
      darin authored
      	- second pass on 3143332 - we still need a test case to be sure this is right
      
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
      	Check for "/". Also report the failure instead of just hanging on forever.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b10f2ff
    • darin's avatar
      Reviewed by Richard. · 88b01630
      darin authored
              - fixed 3143332 -- if path returned is empty string (or "." or "..") it will trash the /tmp symlink
      
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
              Check for empty string, ".", and "..", and don't create files by those names.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88b01630
    • trey's avatar
      WebKit: · 38b5508b
      trey authored
      	3143294 - need short-term bulletproofing of download code against bad filenames
      
      	We protect against a download location that is not an absolute path.
      
              Reviewed by Darin
      
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient continueAfterContentPolicy:response:]):
      	Bail on download if we don't have a abs path to write to.
      
      WebBrowser:
      
      	3143294 - need short-term bulletproofing of download code against bad filenames
      
      	We protect against slashes and leading periods, as well as handling empty filenames.
      
              Reviewed by Darin
      
              * BrowserWebController.m:
              (-[BrowserWebController saveFilenameForResponse:andRequest:]):
      	Check results of [response filename] carefully
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38b5508b
    • mjs's avatar
      Reviewed by Dave. · 3de55bfc
      mjs authored
      	- fixed Radar 3143013 - hang trying to load spiny.com/software
      
              * khtml/rendering/render_table.cpp:
              (RenderTable::layoutRows): Check for the render root as a loop
      	termination condition, to avoid an infinite loop for an absolute
      	but non-fixed table cell.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3de55bfc
    • hyatt's avatar
      The "flow-mode" quirk for lists is just that - a quirk, and should · f5cec5e3
      hyatt authored
      	not be applied when in strict mode.
      
      	Fixes diveintomark.org's navigation bar on the front page (issue #2
      	on his list).
      
              Reviewed by darin and maciej
      
              * khtml/css/html4.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5cec5e3
    • hyatt's avatar
      Finish the KONQBLOCK removal and make sure that table rows and · 6d17fb2b
      hyatt authored
      	cells encountered inside stray content cause the stray content to
      	close so that the rows and cells can be part of the table.
      
      	This fixes the versiontracker bug.  #3142319.
      
              Reviewed by darin.
      
              * khtml/html/htmlparser.cpp:
              (KHTMLParser::reset):
              (isTableRelatedTag):
              (KHTMLParser::insertNode):
              (KHTMLParser::popOneBlock):
              * khtml/html/htmlparser.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d17fb2b
    • trey's avatar
      3142201 - home directory nuked during power download session · 66177e0b
      trey authored
      	We add checks for various error cases that could combine to cause this problem.  While we
      	never got a reproducible case, we are confident that this is the only file removal done
      	in the download code, and its ability to wreak havoc has been clipped.
      
              Reviewed by Richard.
      
              * Downloads.subproj/WebDownloadHandler.m:
              (-[WebDownloadHandler cleanUpAfterFailure]):  Only nuke the partial download if in fact we created
      	a new download file.  Never nuke a directory.
              (-[WebDownloadHandler createFileIfNecessary]):  Don't add "." to the foo-1 filenames we generate
      	if the original filename doesn't have any extension.
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient continueAfterContentPolicy:response:]):
      	If the policyDelegate gives us a nil filename, just stop the whole load, instead of trying to
      	overwrite the user's home directory.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66177e0b
    • hyatt's avatar
      Revert the redundancy that dirk noticed. · 5066da21
      hyatt authored
      	Fixing issue #3 on diveintomark.org's list, which actually involved
      	merging calcAbsoluteVertical to KHTML's trunk and then fixing
      	a math error in the bottom computation.
      
              Reviewed by NOBODY (OOPS!).
      
              * khtml/html/html_baseimpl.cpp:
              (HTMLBodyElementImpl::parseAttribute):
              * khtml/rendering/render_box.cpp:
              (RenderBox::calcAbsoluteVertical):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5066da21
  7. 08 Jan, 2003 6 commits
  8. 05 Jan, 2003 6 commits