1. 12 Jul, 2009 1 commit
    • bfulgham@webkit.org's avatar
      WebCore: · 0b68bb9d
      bfulgham@webkit.org authored
      2009-07-12  Keishi Hattori  <casey.hattori@gmail.com>
      
              Reviewed by Timothy Hatcher.
      
              Refactor ConsoleMessage to add MessageType attribute.
              https://bugs.webkit.org/show_bug.cgi?id=20625
      
              * bindings/js/JSCustomXPathNSResolver.cpp:
              (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::printErrorMessage):
              * dom/Document.cpp:
              (WebCore::Document::reportException):
              (WebCore::Document::addMessage):
              * dom/Document.h:
              * dom/ScriptExecutionContext.h:
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::reportErrorToConsole):
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              (WebCore::ConsoleMessage::addToConsole):
              (WebCore::ConsoleMessage::isEqual):
              * inspector/ConsoleMessage.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::addMessageToConsole):
              (WebCore::InspectorController::startGroup):
              (WebCore::InspectorController::endGroup):
              (WebCore::InspectorController::addProfileFinishedMessageToConsole):
              (WebCore::InspectorController::addStartProfilingMessageToConsole):
              (WebCore::InspectorController::count):
              * inspector/InspectorController.h:
              * inspector/front-end/Console.js:
              (WebInspector.Console.prototype.addMessage):
              (WebInspector.ConsoleMessage): Added type property.
              (WebInspector.ConsoleMessage.prototype.toMessageElement):
              (WebInspector.ConsoleMessage.prototype.toString):
              (WebInspector.ConsoleMessage.prototype.isEqual):
              (WebInspector.ConsoleCommandResult):
              (WebInspector.ConsoleGroup.prototype.addMessage):
              (WebInspector.ConsoleGroup.prototype._titleClicked):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype._addTip):
              (WebInspector.Resource.prototype._checkWarning):
              * inspector/front-end/inspector.css: Changed ".console-group-title-level" to ".console-group-title"
              * inspector/front-end/inspector.js:
              (WebInspector.addMessageToConsole):
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::printAccessDeniedMessage):
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::addMessageToConsole):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::reportLocalLoadFailed):
              (WebCore::FrameLoader::shouldAllowNavigation):
              * page/ChromeClient.h:
              * page/Console.cpp:
              (WebCore::printMessageSourceAndLevelPrefix):
              (WebCore::Console::addMessage):
              (WebCore::Console::error):
              (WebCore::Console::log):
              (WebCore::Console::dir):
              (WebCore::Console::trace):
              (WebCore::Console::assertCondition):
              (WebCore::Console::timeEnd):
              (WebCore::Console::warn):
              * page/Console.h: Added MessageType enum.
              (WebCore::):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::postMessageTimerFired):
              * page/XSSAuditor.cpp:
              (WebCore::XSSAuditor::canEvaluate):
              (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
              (WebCore::XSSAuditor::canLoadObject):
              * svg/SVGDocumentExtensions.cpp:
              (WebCore::SVGDocumentExtensions::reportWarning):
              (WebCore::SVGDocumentExtensions::reportError):
              * wml/WMLErrorHandling.cpp:
              (WebCore::reportWMLError):
              * workers/GenericWorkerTask.h: Added GenericWorkerTask8 for the extra argument.
              (WebCore::GenericWorkerTask8::create):
              (WebCore::GenericWorkerTask8::GenericWorkerTask8):
              (WebCore::GenericWorkerTask8::performTask):
              (WebCore::createCallbackTask):
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::addMessage):
              (WebCore::WorkerContext::importScripts):
              * workers/WorkerContext.h:
              * workers/WorkerMessagingProxy.cpp:
              (WebCore::postConsoleMessageTask):
              (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
              * workers/WorkerMessagingProxy.h:
              * workers/WorkerObjectProxy.h:
              * xml/XMLHttpRequest.cpp:
              (WebCore::reportUnsafeUsage):
              (WebCore::XMLHttpRequest::didFinishLoading):
              * xml/XSLTProcessor.cpp:
              (WebCore::XSLTProcessor::parseErrorFunc):
      
      WebKit/mac:
      
      2009-07-12  Keishi Hattori  <casey.hattori@gmail.com>
      
              Reviewed by Timothy Hatcher.
      
              Refactor ConsoleMessage to add MessageType attribute.
              https://bugs.webkit.org/show_bug.cgi?id=20625
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::addMessageToConsole):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b68bb9d
  2. 10 Jul, 2009 1 commit
    • ddkilzer@apple.com's avatar
      2009-07-10 Shinichiro Hamaji <hamaji@chromium.org> · 9c4dacca
      ddkilzer@apple.com authored
              Reviewed by David Kilzer.
      
              WebKit needs a style linting tool
              https://bugs.webkit.org/show_bug.cgi?id=25884
      
              Fix bunch of style issues by autofix of cpplint.
              This patch is created to demonstrate the autofix of cpplint.py.
      
              No new testcases because it's a style fix
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseMediaQuery):
              (WebCore::CSSParser::validUnit):
              (WebCore::CSSParser::parseValue):
              (WebCore::skipCommaInDashboardRegion):
              (WebCore::CSSParser::parseDashboardRegions):
              (WebCore::ShadowParseContext::commitValue):
              (WebCore::ShadowParseContext::commitLength):
              (WebCore::ShadowParseContext::commitColor):
              (WebCore::BorderImageParseContext::commitNumber):
              (WebCore::BorderImageParseContext::commitWidth):
              (WebCore::BorderImageParseContext::commitRule):
              (WebCore::BorderImageParseContext::commitBorderImage):
              (WebCore::CSSParser::lex):
              (WebCore::CSSParser::text):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * css/MediaList.cpp:
              (WebCore::MediaList::deleteMedium):
              * css/MediaQuery.h:
              * css/MediaQueryEvaluator.cpp:
              (WebCore::parseAspectRatio):
              * css/MediaQueryEvaluator.h:
              * css/MediaQueryExp.h:
              (WebCore::MediaQueryExp::operator==):
              * css/WebKitCSSMatrix.h:
              * dom/Comment.h:
              * dom/Document.cpp:
              (WebCore::Document::setFocusedNode):
              * dom/Document.h:
              (WebCore::Document::setHasDashboardRegions):
              * dom/DocumentFragment.cpp:
              (WebCore::DocumentFragment::nodeName):
              * dom/DocumentFragment.h:
              * dom/DynamicNodeList.h:
              * dom/EditingText.h:
              * dom/Element.cpp:
              (WebCore::Element::dispatchAttrAdditionEvent):
              * dom/NamedAttrMap.cpp:
              (WebCore::NamedNodeMap::item):
              * dom/Node.cpp:
              (WebCore::Node::nodeValue):
              (WebCore::Node::nodeIndex):
              * dom/NodeRareData.h:
              (WebCore::NodeListsNodeData::create):
              * dom/Notation.h:
              * dom/ProcessingInstruction.h:
              * dom/Range.cpp:
              (WebCore::Range::processContents):
              * dom/StyledElement.cpp:
              (WebCore::toHex):
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback):
              (WebCore::PendingCallbacks::PendingStartElementNSCallback::call):
              (WebCore::PendingCallbacks::):
              (WebCore::OffsetBuffer::readOutBytes):
              (WebCore::handleElementNamespaces):
              (WebCore::handleElementAttributes):
              (WebCore::attributesStartElementNsHandler):
              * dom/XMLTokenizerQt.cpp:
              (WebCore::attributesStartElementNsHandler):
              (WebCore::XMLTokenizer::parseStartElement):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyInlineStyle):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::removeNode):
              * editing/Editor.cpp:
              (WebCore::Editor::pasteAsPlainText):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::directionOfEnclosingBlock):
              * editing/SmartReplaceICU.cpp:
              (WebCore::addAllCodePoints):
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::icon):
              (WebCore::HistoryItem::adoptVisitCounts):
              * html/CanvasStyle.cpp:
              (WebCore::CanvasStyle::applyFillColor):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::setActive):
              (WebCore::HTMLAnchorElement::isLiveLink):
              * html/HTMLAppletElement.h:
              * html/HTMLAudioElement.h:
              * html/HTMLBRElement.h:
              * html/HTMLBaseElement.h:
              * html/HTMLBaseFontElement.h:
              * html/HTMLDListElement.h:
              * html/HTMLDirectoryElement.h:
              * html/HTMLFieldSetElement.cpp:
              (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::reset):
              * html/HTMLHRElement.cpp:
              (WebCore::HTMLHRElement::parseMappedAttribute):
              * html/HTMLHeadElement.h:
              * html/HTMLHtmlElement.h:
              * html/HTMLImageElement.h:
              (WebCore::HTMLImageElement::setLoadManually):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::selection):
              * html/HTMLIsIndexElement.h:
              * html/HTMLMarqueeElement.cpp:
              * html/HTMLMediaElement.h:
              (WebCore::HTMLMediaElement::):
              * html/HTMLMenuElement.h:
              * html/HTMLMetaElement.h:
              * html/HTMLModElement.h:
              * html/HTMLOListElement.h:
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::childrenChanged):
              * html/HTMLParamElement.h:
              * html/HTMLQuoteElement.h:
              * html/HTMLStyleElement.h:
              * html/HTMLTableCaptionElement.h:
              * html/HTMLTableCellElement.h:
              * html/HTMLTableColElement.h:
              * html/HTMLTableSectionElement.cpp:
              (WebCore::HTMLTableSectionElement::deleteRow):
              * html/HTMLTitleElement.h:
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseNonHTMLText):
              (WebCore::HTMLTokenizer::parseEntity):
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::write):
              * html/HTMLUListElement.h:
              * html/HTMLVideoElement.h:
              * html/TimeRanges.h:
              (WebCore::TimeRanges::Range::Range):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::enableResourceTracking):
              (WebCore::InspectorController::disableResourceTracking):
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::newInspectorJSONObject):
              * page/Console.cpp:
              (WebCore::Console::addMessage):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::defaultKeyboardEventHandler):
              * page/Frame.cpp:
              (WebCore::Frame::jsDefaultStatusBarText):
              * page/android/DragControllerAndroid.cpp:
              (WebCore::DragController::dragOperation):
              * page/android/EventHandlerAndroid.cpp:
              (WebCore::EventHandler::tabsToAllControls):
              (WebCore::EventHandler::eventActivatedView):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
              * page/gtk/DragControllerGtk.cpp:
              (WebCore::DragController::dragOperation):
              * page/qt/DragControllerQt.cpp:
              * page/win/DragControllerWin.cpp:
              (WebCore::DragController::isCopyKeyDown):
              * page/win/FrameWin.h:
              * rendering/RenderSlider.cpp:
              (WebCore::RenderSlider::mouseEventOffsetToThumb):
              * rendering/style/RenderStyle.h:
              (WebCore::InheritedFlags::setVerticalAlignLength):
              (WebCore::InheritedFlags::setUnicodeBidi):
              (WebCore::InheritedFlags::setCursor):
              * rendering/style/RenderStyleConstants.h:
              (WebCore::):
              * rendering/style/SVGRenderStyleDefs.h:
              * rendering/style/StyleInheritedData.h:
              (WebCore::StyleInheritedData::operator!=):
              * storage/DatabaseTask.h:
              * svg/GradientAttributes.h:
              * svg/LinearGradientAttributes.h:
              * svg/PatternAttributes.h:
              * svg/RadialGradientAttributes.h:
              * svg/SVGAnimatedPathData.h:
              * svg/SVGAnimatedPoints.h:
              * svg/SVGAnimationElement.h:
              * svg/SVGClipPathElement.h:
              * svg/SVGElementInstance.h:
              * svg/SVGFEBlendElement.cpp:
              (WebCore::SVGFEBlendElement::build):
              * svg/SVGFEBlendElement.h:
              * svg/SVGFEColorMatrixElement.cpp:
              (WebCore::SVGFEColorMatrixElement::build):
              * svg/SVGFEComponentTransferElement.cpp:
              (WebCore::SVGFEComponentTransferElement::build):
              * svg/SVGFECompositeElement.cpp:
              (WebCore::SVGFECompositeElement::build):
              * svg/SVGFEDiffuseLightingElement.cpp:
              (WebCore::SVGFEDiffuseLightingElement::build):
              * svg/SVGFEDisplacementMapElement.cpp:
              (WebCore::SVGFEDisplacementMapElement::build):
              * svg/SVGFEDistantLightElement.h:
              * svg/SVGFEFloodElement.cpp:
              (WebCore::SVGFEFloodElement::build):
              * svg/SVGFEFloodElement.h:
              * svg/SVGFEFuncAElement.h:
              * svg/SVGFEFuncBElement.h:
              * svg/SVGFEFuncGElement.h:
              * svg/SVGFEFuncRElement.h:
              * svg/SVGFEGaussianBlurElement.cpp:
              (WebCore::SVGFEGaussianBlurElement::build):
              * svg/SVGFEImageElement.cpp:
              (WebCore::SVGFEImageElement::build):
              * svg/SVGFEMergeElement.cpp:
              (WebCore::SVGFEMergeElement::build):
              * svg/SVGFEOffsetElement.cpp:
              (WebCore::SVGFEOffsetElement::build):
              * svg/SVGFEPointLightElement.h:
              * svg/SVGFESpecularLightingElement.cpp:
              (WebCore::SVGFESpecularLightingElement::build):
              * svg/SVGFESpotLightElement.h:
              * svg/SVGFETileElement.cpp:
              (WebCore::SVGFETileElement::build):
              * svg/SVGLineElement.cpp:
              (WebCore::SVGLineElement::parseMappedAttribute):
              * svg/SVGList.h:
              * svg/SVGListTraits.h:
              (WebCore::):
              * svg/SVGMPathElement.h:
              * svg/SVGMetadataElement.h:
              * svg/SVGParserUtilities.cpp:
              (WebCore::SVGPathParser::parseSVG):
              (WebCore::SVGPathParser::calculateArc):
              * svg/SVGPathElement.h:
              * svg/SVGPathSegClosePath.h:
              * svg/SVGSVGElement.h:
              * svg/SVGSetElement.h:
              * svg/SVGSwitchElement.h:
              * svg/SVGTextPathElement.cpp:
              (WebCore::SVGTextPathElement::parseMappedAttribute):
              * svg/SVGTextPathElement.h:
              * svg/SVGTitleElement.h:
              * svg/SVGTransformable.cpp:
              (WebCore::):
              * svg/SVGViewSpec.cpp:
              (WebCore::):
              * svg/animation/SMILTime.cpp:
              (WebCore::operator+):
              (WebCore::operator-):
              (WebCore::operator*):
              * svg/animation/SVGSMILElement.h:
              * svg/graphics/SVGResource.cpp:
              (WebCore::clientMap):
              * wml/WMLPostfieldElement.cpp:
              (WebCore::WMLPostfieldElement::value):
              * wml/WMLSetvarElement.cpp:
              (WebCore::WMLSetvarElement::value):
              * workers/WorkerRunLoop.cpp:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::dropProtection):
              * xml/XPathPath.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c4dacca
  3. 07 Jul, 2009 1 commit
  4. 26 Jun, 2009 1 commit
  5. 22 Jun, 2009 2 commits
    • weinig@apple.com's avatar
      WebCore: · 0ce8f4e3
      weinig@apple.com authored
      2009-06-22  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Mark Rowe.
      
              Add event handler attribute getter/setters to HTMLBodyElement
              as specified in HTML 5.
      
              - Removes erroneous inclusion of the onresize and onunload event
              handler attributes in Element and Document.
      
              * dom/Document.cpp:
              (WebCore::Document::getWindowAttributeEventListener):
              * dom/Document.h:
              * dom/Document.idl:
              * dom/Element.idl:
              * dom/Node.cpp:
              * dom/Node.h: onblur, onerror, onfocus, and onload all need to be declared
              virtual, since their behavior for HTMLBodyElement differs from the base
              implementation.
              * html/HTMLBodyElement.cpp:
              (WebCore::HTMLBodyElement::onblur):
              (WebCore::HTMLBodyElement::setOnblur):
              (WebCore::HTMLBodyElement::onerror):
              (WebCore::HTMLBodyElement::setOnerror):
              (WebCore::HTMLBodyElement::onfocus):
              (WebCore::HTMLBodyElement::setOnfocus):
              (WebCore::HTMLBodyElement::onload):
              (WebCore::HTMLBodyElement::setOnload):
              (WebCore::HTMLBodyElement::onbeforeunload):
              (WebCore::HTMLBodyElement::setOnbeforeunload):
              (WebCore::HTMLBodyElement::onmessage):
              (WebCore::HTMLBodyElement::setOnmessage):
              (WebCore::HTMLBodyElement::onoffline):
              (WebCore::HTMLBodyElement::setOnoffline):
              (WebCore::HTMLBodyElement::ononline):
              (WebCore::HTMLBodyElement::setOnonline):
              (WebCore::HTMLBodyElement::onresize):
              (WebCore::HTMLBodyElement::setOnresize):
              (WebCore::HTMLBodyElement::onstorage):
              (WebCore::HTMLBodyElement::setOnstorage):
              (WebCore::HTMLBodyElement::onunload):
              (WebCore::HTMLBodyElement::setOnunload):
              * html/HTMLBodyElement.h:
              * html/HTMLBodyElement.idl:
      
      LayoutTests:
      
      2009-06-22  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Mark Rowe.
      
              Add event handler attribute getter/setters to HTMLBodyElement
              as specified in HTML 5.
      
              * fast/dom/event-attribute-availability-expected.txt:
              * fast/dom/resources/event-attribute-availability.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ce8f4e3
    • levin@chromium.org's avatar
      WebCore: · b742833e
      levin@chromium.org authored
      2009-06-22  David Levin  <levin@chromium.org>
      
              Reviewed by David Hyatt and Eric Seidel.
      
              REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
              https://bugs.webkit.org/show_bug.cgi?id=26326
      
              Test: scrollbars/scrollbar-crash-on-refresh.html
      
              * dom/Document.cpp:
              (WebCore::Document::detach):
              Gives the FrameView a change to do any necessary cleanup on
              Document::detach() which is where the renderArena gets detroyed.
              * page/FrameView.cpp:
              (WebCore::FrameView::detachCustomScrollbars):
              Gets rid of any custom scrollbars (if the docment supplied them).
              * page/FrameView.h:
              * platform/Scrollbar.h:
              (WebCore::Scrollbar::isCustomScrollbar):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::destroy):
              Removed the check for document()->frame().  If frame() is 0 in this code,
              then the call to animation() is also incorrect (since it does document()->frame()->animation()).
              * rendering/RenderScrollbar.h:
              (WebCore::RenderScrollbar::isCustomScrollbar):
      
      LayoutTests:
      
      2009-06-22  David Levin  <levin@chromium.org>
      
              Reviewed by David Hyatt and Eric Seidel.
      
              REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
              https://bugs.webkit.org/show_bug.cgi?id=26326
      
              Test that refreshing an iframe with custom scrollbars works without crashing.
      
              * scrollbars/resources/page-with-custom-scrollbars.html: Added.
              * scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
              * scrollbars/scrollbar-crash-on-refresh.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b742833e
  6. 19 Jun, 2009 1 commit
  7. 17 Jun, 2009 1 commit
    • levin@chromium.org's avatar
      WebCore: · afb42f96
      levin@chromium.org authored
      2009-06-17  David Levin  <levin@chromium.org>
      
              Reviewed by NOBODY, layout tests fix.
      
              https://bugs.webkit.org/show_bug.cgi?id=26326
              This reverts commit r44751.
      
              Once that change was checked scrollbars/scrollbar-orientation.html started
              crashing on Windows.
      
              * dom/Document.cpp:
              (WebCore::Document::detach):
              * page/FrameView.cpp:
              * page/FrameView.h:
              * platform/Scrollbar.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::destroy):
              * rendering/RenderScrollbar.h:
      
      LayoutTests:
      
      2009-06-17  David Levin  <levin@chromium.org>
      
              Reviewed by NOBODY, layout tests fix.
      
              https://bugs.webkit.org/show_bug.cgi?id=26326
              This reverts commit r44751.
      
              Once that change was checked scrollbars/scrollbar-orientation.html started
              crashing on Windows.
      
              * scrollbars/resources/page-with-custom-scrollbars.html: Removed.
              * scrollbars/scrollbar-crash-on-refresh-expected.txt: Removed.
              * scrollbars/scrollbar-crash-on-refresh.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afb42f96
  8. 16 Jun, 2009 1 commit
    • levin@chromium.org's avatar
      WebCore: · 4a0090f7
      levin@chromium.org authored
      2009-06-16  David Levin  <levin@chromium.org>
      
              Reviewed by David Hyatt.
      
              REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
              https://bugs.webkit.org/show_bug.cgi?id=26326
      
              Test: scrollbars/scrollbar-crash-on-refresh.html
      
              * dom/Document.cpp:
              (WebCore::Document::detach):
              Gives the FrameView a change to do any necessary cleanup on
              Document::detach() which is where the renderArena gets detroyed.
              * page/FrameView.cpp:
              (WebCore::FrameView::detachCustomScrollbars):
              Gets rid of any custom scrollbars (if the docment supplied them).
              * page/FrameView.h:
              * platform/Scrollbar.h:
              (WebCore::Scrollbar::isCustomScrollbar):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::destroy):
              Removed the check for document()->frame().  If frame() is 0 in this code,
              then the call to animation() is also incorrect (since it does document()->frame()->animation()).
              * rendering/RenderScrollbar.h:
              (WebCore::RenderScrollbar::isCustomScrollbar):
      
      LayoutTests:
      
      2009-06-16  David Levin  <levin@chromium.org>
      
              Reviewed by David Hyatt.
      
              REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
              https://bugs.webkit.org/show_bug.cgi?id=26326
      
              Test that refreshing an iframe with custom scrollbars works without crashing.
      
              * scrollbars/resources/page-with-custom-scrollbars.html: Added.
              * scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
              * scrollbars/scrollbar-crash-on-refresh.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a0090f7
  9. 11 Jun, 2009 1 commit
  10. 06 Jun, 2009 1 commit
  11. 30 May, 2009 1 commit
    • weinig@apple.com's avatar
      WebCore: · 6dfb60ca
      weinig@apple.com authored
      2009-05-29  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=26091
              Make storage events match the current spec.
              - Storage event listeners are added to the window.
              - Storage events are dispatched to the window.
      
              Updated existing tests.
      
              * dom/Document.cpp:
              (WebCore::Document::dispatchWindowEvent):
              * dom/Document.h:
              * dom/Node.cpp:
              * dom/Node.h:
              * html/HTMLBodyElement.cpp:
              (WebCore::HTMLBodyElement::parseMappedAttribute):
              * storage/LocalStorageArea.cpp:
              (WebCore::LocalStorageArea::dispatchStorageEvent):
              * storage/SessionStorageArea.cpp:
              (WebCore::SessionStorageArea::dispatchStorageEvent):
      
      LayoutTests:
      
      2009-05-29  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=26091
              Make storage events match the current spec.
              - Storage event listeners are added to the window.
              - Storage events are dispatched to the window.
      
              * storage/domstorage/localstorage/iframe-events.html:
              * storage/domstorage/localstorage/index-get-and-set.html:
              * storage/domstorage/localstorage/resources/iframe-events-second.html:
              * storage/domstorage/localstorage/simple-events.html:
              * storage/domstorage/sessionstorage/iframe-events.html:
              * storage/domstorage/sessionstorage/index-get-and-set.html:
              * storage/domstorage/sessionstorage/resources/iframe-events-second.html:
              * storage/domstorage/sessionstorage/simple-events.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dfb60ca
  12. 29 May, 2009 1 commit
  13. 26 May, 2009 1 commit
  14. 22 May, 2009 2 commits
    • abarth@webkit.org's avatar
      WebCore: · 67646793
      abarth@webkit.org authored
      2009-05-22  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Maciej Stachowiak.
      
              https://bugs.webkit.org/show_bug.cgi?id=25955
      
              Remove the policyBaseURL parameter from setCookie.  This parameter is
              redundant with the document parameter.
      
              * WebCore.base.exp:
              * WebCore.order:
              * dom/Document.cpp:
              (WebCore::Document::setCookie):
              * platform/CookieJar.h:
              * platform/mac/CookieJar.mm:
              (WebCore::setCookies):
              * platform/network/ResourceRequestBase.cpp:
              (WebCore::ResourceRequestBase::firstPartyForCookies):
              (WebCore::ResourceRequestBase::setFirstPartyForCookies):
              * platform/network/chromium/CookieJarChromium.cpp:
              (WebCore::setCookies):
              * platform/network/curl/CookieJarCurl.cpp:
              (WebCore::setCookies):
              * platform/network/soup/CookieJarSoup.cpp:
              (WebCore::setCookies):
              * platform/network/win/CookieJarCFNetWin.cpp:
              (WebCore::setCookies):
              * platform/network/win/CookieJarWin.cpp:
              (WebCore::setCookies):
              * platform/qt/CookieJarQt.cpp:
              (WebCore::setCookies):
      
      WebKit/mac:
      
      2009-05-22  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Maciej Stachowiak.
      
              https://bugs.webkit.org/show_bug.cgi?id=25955
      
              Remove the policyBaseURL parameter from setCookie.  This parameter is
              redudant with the document parameter.
      
              * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
              (WebKit::NetscapePluginInstanceProxy::setCookies):
              * Plugins/WebNetscapePluginView.mm:
              (-[WebNetscapePluginView setVariable:forURL:value:length:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67646793
    • abarth@webkit.org's avatar
      2009-05-22 Adam Barth <abarth@webkit.org> · 622d9dff
      abarth@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Rename policyBaseURL and mainDocumentURL to firstPartyForCookies.  The
              previous names were confusing and inaccurate.
      
              * WebCore.order:
              * dom/Document.cpp:
              (WebCore::Document::setCookie):
              * dom/Document.h:
              (WebCore::Document::firstPartyForCookies):
              (WebCore::Document::setFirstPartyForCookies):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::begin):
              (WebCore::FrameLoader::updateFirstPartyForCookies):
              (WebCore::FrameLoader::setFirstPartyForCookies):
              (WebCore::FrameLoader::open):
              (WebCore::FrameLoader::addExtraFieldsToRequest):
              (WebCore::FrameLoader::loadResourceSynchronously):
              * loader/FrameLoader.h:
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::willSendRequest):
              * platform/CookieJar.h:
              * platform/mac/CookieJar.mm:
              (WebCore::setCookies):
              * platform/network/ResourceRequestBase.cpp:
              (WebCore::ResourceRequestBase::adopt):
              (WebCore::ResourceRequestBase::copyData):
              (WebCore::ResourceRequestBase::firstPartyForCookies):
              (WebCore::ResourceRequestBase::setFirstPartyForCookies):
              (WebCore::equalIgnoringHeaderFields):
              * platform/network/ResourceRequestBase.h:
              * platform/network/cf/ResourceRequestCFNet.cpp:
              (WebCore::ResourceRequest::doUpdatePlatformRequest):
              (WebCore::ResourceRequest::doUpdateResourceRequest):
              * platform/network/chromium/CookieJarChromium.cpp:
              (WebCore::setCookies):
              * platform/network/mac/ResourceRequestMac.mm:
              (WebCore::ResourceRequest::doUpdateResourceRequest):
              (WebCore::ResourceRequest::doUpdatePlatformRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      622d9dff
  15. 20 May, 2009 1 commit
    • xan@webkit.org's avatar
      2009-05-20 Xan Lopez <xlopez@igalia.com> · 68f851df
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Implement AtkObject::focus-event and
              AtkObject::state-changed:focused signal emission.
      
              Adds a new handleFocusedUIElementChangedWithRenderers, only in the
              GTK port, called at the same point than
              handleFocusedUIElementChanged but with two parameters, the old and
              the newly focused RenderObjects. We need this, since the ATK
              signals require us to pass the objects involved in the focus
              change as arguments.
      
              * accessibility/AXObjectCache.h:
              * accessibility/gtk/AXObjectCacheAtk.cpp:
              (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
              * dom/Document.cpp:
              (WebCore::Document::setFocusedNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68f851df
  16. 19 May, 2009 1 commit
    • ap@webkit.org's avatar
      Reviewed by Darin Adler and Brady Eidson. · 142736a7
      ap@webkit.org authored
              REGRESSION (r42446?): UA Profiler in http://stevesouders.com/ua/ stalls
      
              The problem was that Document::removeAllEventListeners() was called for a wrong document
              when a CachedFrame was destroyed.
      
              Cannot be tested automatically, because DRT doesn't have a b/f cache.
      
              * dom/Document.cpp: (WebCore::Document::domWindow): Make sure that this doesn't return an
              unrelated window even if document's m_frame pointer is stale.
      
              * history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Added a FIXME about strange behavior.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      142736a7
  17. 18 May, 2009 1 commit
  18. 14 May, 2009 1 commit
  19. 07 May, 2009 2 commits
    • zimmermann@webkit.org's avatar
      Reviewed by Dave Hyatt. · b75da289
      zimmermann@webkit.org authored
      Fixes: https://bugs.webkit.org/show_bug.cgi?id=25617
      
      Fix memory/performance regression because of too much form control related abstraction just for WMLs sake.
      
      Remove FormControlElement and FormControlElementWithState base classes, as the overhead is too high for the
      gain. HTML has no benefit of that kind of abstraction, so we're going to move the functionality to Element directly.
      
      The functions now living in FormControlElement(WithState) lived in Node/Element/HTMLFormControlElement before.
      This patches moves all of them in a central place in Element.h, as virtual functions with an inline default implementation.
      To avoid confusion like isEnabled() living on Node, before the creation of the FormControlElement abstraction layer, all
      methods are renamed to clarify where they belong to. (Detailed list in ChangeLog)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b75da289
    • beidson@apple.com's avatar
      2009-05-07 Brady Eidson <beidson@apple.com> · a19606b4
      beidson@apple.com authored
              Reviewed by Darin Adler and Alexey Proskuryakov.
      
              <rdar://problem/6863795> Exception occurs in Mail when attempting to create signatures due to <head> element creation
      
              * dom/Document.cpp:
              (WebCore::Document::implicitClose): Check shouldCreateImplicitHead() before creating it.
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::handleError): Check shouldCreateImplicitHead() before creating it.
              (WebCore::HTMLParser::bodyCreateErrorCheck): Ditto.
              (WebCore::shouldCreateImplicitHead): For Tiger/Leopard when running under Mail, the implicit <head> shouldn't be created.
              * html/HTMLParser.h:
              (WebCore::shouldCreateImplicitHead): Inline implementation for non-Tiger/Leopard platforms
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a19606b4
  20. 05 May, 2009 2 commits
    • eric@webkit.org's avatar
      2009-05-05 Jungshik Shin <jshin@chromium.org> · 19fc198c
      eric@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              http://bugs.webkit.org/show_bug.cgi?id=25487
      
              For euc-kr and other 8bit Korean encodings
              (similar to euc-kr/windows-949), make document.charset return
              EUC-KR instead of windows-949. The latter is not recognized by
              Korean web servers.
      
              Add domName method to TextEncoding to deal with cases where
              our internal encoding name does not match what's widely recognized
              by web servers. Currently, the only case is 'windows-949' (internal
              name) vs 'EUC-KR'.
      
              Test: fast/encoding/euckr-name.html
      
              * dom/Document.cpp:
              (WebCore::Document::encoding): Call TextEncoding.domName() instead
              of TextEncoding.name().
              * platform/text/TextEncoding.cpp:
              (WebCore::TextEncoding::domName): For the canonical name 'windows-949',
              return 'EUC-KR'. Otherwise, just return the canonical name.
              * platform/text/TextEncoding.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19fc198c
    • ap@webkit.org's avatar
      Reviewed by Dave Hyatt. · d0295906
      ap@webkit.org authored
              <rdar://problem/6576889> REGRESSION (r35185): Cannot watch Flash movies on omg.yahoo.com
      
              The problem was caused by missing <head> element - we used to create it when moving a
              misplaced <style> element, but we now handle those in place. Other browsers always create
              a <head> element.
      
              There is no guarantee that a <head> element always exists - first, it can be removed with
              removeChild or innerHTML, and also, we don't currently create it for frameset documents, or
              for manually created ones (e.g. ImageDocument).
      
              Test: fast/parser/head-element-for-yahoo-player.html
      
      WebKit:
              * dom/Document.cpp: (WebCore::Document::implicitClose): Create a <head> element for about:blank.
              A removed comment talked about rdar://3758785, but that problem doesn't re-occur even if this
              code is removed completely.
      
              * html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::checkDTD): No longer allow <script>
              elements as children of <html>. This isn't directly related to this bug, but it was easier
              to fix both at once (IE and Firefox both don't allow such mispositioned <script> elements).
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::handleError): Move <script> to <head> if <body> hasn't been created yet.
              Create a <head> it a <body> is created implicitly to contain some other element.
              (WebCore::HTMLParser::bodyCreateErrorCheck): Ensure that a <head> exists when <body> is
              explicitly present in source.
              (WebCore::HTMLParser::createHead): Do the work even if <html> element hasn't been created yet.
      
      LayoutTests:
              * fast/parser/head-element-for-yahoo-player-expected.txt: Added.
              * fast/parser/head-element-for-yahoo-player.html: Added.
              Test the regression case (a misplaced <style> that used to create <head> implicitly).
      
              * editing/selection/select-all-005.html: Use a new index when selecting the body.
      
              * fast/dom/Document/document-write-doctype-expected.txt:
              * fast/dom/Document/resources/document-write-doctype.js:
              Removed checks for "Gecko quirk" of implicitly adding HEAD - that not a quirk, but standard
              behavior per HTML5.
      
              * editing/execCommand/create-list-1-expected.txt:
              * platform/mac/editing/deleting/4845371-expected.txt:
              * platform/mac/editing/deleting/4866671-expected.txt:
              * platform/mac/editing/deleting/4875189-expected.txt:
              * platform/mac/editing/deleting/5026848-1-expected.txt:
              * platform/mac/editing/deleting/5026848-2-expected.txt:
              * platform/mac/editing/deleting/5026848-3-expected.txt:
              * platform/mac/editing/deleting/5032066-expected.txt:
              * platform/mac/editing/deleting/5091898-expected.txt:
              * platform/mac/editing/deleting/5099303-expected.txt:
              * platform/mac/editing/deleting/5115601-expected.txt:
              * platform/mac/editing/deleting/5126166-expected.txt:
              * platform/mac/editing/deleting/5156801-2-expected.txt:
              * platform/mac/editing/deleting/5168598-expected.txt:
              * platform/mac/editing/deleting/5272440-expected.txt:
              * platform/mac/editing/deleting/5300379-expected.txt:
              * platform/mac/editing/deleting/5390681-expected.txt:
              * platform/mac/editing/deleting/5408255-expected.txt:
              * platform/mac/editing/deleting/5433862-2-expected.txt:
              * platform/mac/editing/deleting/5483370-expected.txt:
              * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
              * platform/mac/editing/deleting/delete-block-table-expected.txt:
              * platform/mac/editing/deleting/delete-hr-expected.txt:
              * platform/mac/editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/mac/editing/deleting/merge-endOfParagraph-expected.txt:
              * platform/mac/editing/deleting/merge-no-br-expected.txt:
              * platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
              * platform/mac/editing/execCommand/4641880-1-expected.txt:
              * platform/mac/editing/execCommand/4641880-2-expected.txt:
              * platform/mac/editing/execCommand/4747450-expected.txt:
              * platform/mac/editing/execCommand/4786404-1-expected.txt:
              * platform/mac/editing/execCommand/4786404-2-expected.txt:
              * platform/mac/editing/execCommand/4916402-expected.txt:
              * platform/mac/editing/execCommand/4916541-expected.txt:
              * platform/mac/editing/execCommand/4916583-expected.txt:
              * platform/mac/editing/execCommand/4920488-expected.txt:
              * platform/mac/editing/execCommand/4920742-1-expected.txt:
              * platform/mac/editing/execCommand/4924441-expected.txt:
              * platform/mac/editing/execCommand/5049671-expected.txt:
              * platform/mac/editing/execCommand/5080333-1-expected.txt:
              * platform/mac/editing/execCommand/5080333-2-expected.txt:
              * platform/mac/editing/execCommand/5119244-expected.txt:
              * platform/mac/editing/execCommand/5120591-expected.txt:
              * platform/mac/editing/execCommand/5136770-expected.txt:
              * platform/mac/editing/execCommand/5142012-1-expected.txt:
              * platform/mac/editing/execCommand/5142012-2-expected.txt:
              * platform/mac/editing/execCommand/5142012-3-expected.txt:
              * platform/mac/editing/execCommand/5144139-1-expected.txt:
              * platform/mac/editing/execCommand/5164796-expected.txt:
              * platform/mac/editing/execCommand/5207369-expected.txt:
              * platform/mac/editing/execCommand/5210032-expected.txt:
              * platform/mac/editing/execCommand/5432254-1-expected.txt:
              * platform/mac/editing/execCommand/5432254-2-expected.txt:
              * platform/mac/editing/execCommand/5481523-expected.txt:
              * platform/mac/editing/execCommand/5482524-expected.txt:
              * platform/mac/editing/execCommand/5569741-expected.txt:
              * platform/mac/editing/execCommand/5573879-expected.txt:
              * platform/mac/editing/execCommand/5700414-1-expected.txt:
              * platform/mac/editing/execCommand/5700414-2-expected.txt:
              * platform/mac/editing/execCommand/insert-list-empty-div-expected.txt:
              * platform/mac/editing/input/5576619-expected.txt:
              * platform/mac/editing/inserting/12882-expected.txt:
              * platform/mac/editing/inserting/4840662-expected.txt:
              * platform/mac/editing/inserting/4875189-1-expected.txt:
              * platform/mac/editing/inserting/4875189-2-expected.txt:
              * platform/mac/editing/inserting/4959067-expected.txt:
              * platform/mac/editing/inserting/4960120-1-expected.txt:
              * platform/mac/editing/inserting/4960120-2-expected.txt:
              * platform/mac/editing/inserting/5002441-expected.txt:
              * platform/mac/editing/inserting/5058163-2-expected.txt:
              * platform/mac/editing/inserting/5156401-2-expected.txt:
              * platform/mac/editing/inserting/5549929-2-expected.txt:
              * platform/mac/editing/inserting/5549929-3-expected.txt:
              * platform/mac/editing/inserting/5607069-2-expected.txt:
              * platform/mac/editing/inserting/5607069-3-expected.txt:
              * platform/mac/editing/inserting/editable-html-element-expected.txt:
              * platform/mac/editing/inserting/editable-inline-element-expected.txt:
              * platform/mac/editing/inserting/edited-whitespace-1-expected.txt:
              * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
              * platform/mac/editing/pasteboard/4806874-expected.txt:
              * platform/mac/editing/pasteboard/4861080-expected.txt:
              * platform/mac/editing/pasteboard/4944770-1-expected.txt:
              * platform/mac/editing/pasteboard/4944770-2-expected.txt:
              * platform/mac/editing/pasteboard/4947130-expected.txt:
              * platform/mac/editing/pasteboard/4989774-expected.txt:
              * platform/mac/editing/pasteboard/5027857-expected.txt:
              * platform/mac/editing/pasteboard/5032095-expected.txt:
              * platform/mac/editing/pasteboard/5065605-expected.txt:
              * platform/mac/editing/pasteboard/5071074-2-expected.txt:
              * platform/mac/editing/pasteboard/5071074-expected.txt:
              * platform/mac/editing/pasteboard/5075944-2-expected.txt:
              * platform/mac/editing/pasteboard/5075944-3-expected.txt:
              * platform/mac/editing/pasteboard/5075944-expected.txt:
              * platform/mac/editing/pasteboard/5134759-expected.txt:
              * platform/mac/editing/pasteboard/5156401-1-expected.txt:
              * platform/mac/editing/pasteboard/5247341-expected.txt:
              * platform/mac/editing/pasteboard/5387578-expected.txt:
              * platform/mac/editing/pasteboard/5478250-expected.txt:
              * platform/mac/editing/pasteboard/5483567-expected.txt:
              * platform/mac/editing/pasteboard/5601583-1-expected.txt:
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
              * platform/mac/editing/pasteboard/input-field-1-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
              * platform/mac/editing/pasteboard/merge-start-blockquote-expected.txt:
              * platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt:
              * platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * platform/mac/editing/pasteboard/select-element-1-expected.txt:
              * platform/mac/editing/selection/13804-expected.txt:
              * platform/mac/editing/selection/14971-expected.txt:
              * platform/mac/editing/selection/4397952-expected.txt:
              * platform/mac/editing/selection/4818145-expected.txt:
              * platform/mac/editing/selection/4866671-expected.txt:
              * platform/mac/editing/selection/4889598-expected.txt:
              * platform/mac/editing/selection/4895428-1-expected.txt:
              * platform/mac/editing/selection/4895428-2-expected.txt:
              * platform/mac/editing/selection/4895428-3-expected.txt:
              * platform/mac/editing/selection/4895428-4-expected.txt:
              * platform/mac/editing/selection/4932260-1-expected.txt:
              * platform/mac/editing/selection/4932260-2-expected.txt:
              * platform/mac/editing/selection/4932260-3-expected.txt:
              * platform/mac/editing/selection/4947387-expected.txt:
              * platform/mac/editing/selection/4960116-expected.txt:
              * platform/mac/editing/selection/4975120-expected.txt:
              * platform/mac/editing/selection/4983858-expected.txt:
              * platform/mac/editing/selection/5007143-2-expected.txt:
              * platform/mac/editing/selection/5007143-expected.txt:
              * platform/mac/editing/selection/5057506-2-expected.txt:
              * platform/mac/editing/selection/5057506-expected.txt:
              * platform/mac/editing/selection/5076323-1-expected.txt:
              * platform/mac/editing/selection/5076323-2-expected.txt:
              * platform/mac/editing/selection/5076323-3-expected.txt:
              * platform/mac/editing/selection/5081257-1-expected.txt:
              * platform/mac/editing/selection/5081257-2-expected.txt:
              * platform/mac/editing/selection/5099303-expected.txt:
              * platform/mac/editing/selection/5109817-expected.txt:
              * platform/mac/editing/selection/5136696-expected.txt:
              * platform/mac/editing/selection/5195166-1-expected.txt:
              * platform/mac/editing/selection/5195166-2-expected.txt:
              * platform/mac/editing/selection/5234383-1-expected.txt:
              * platform/mac/editing/selection/5234383-2-expected.txt:
              * platform/mac/editing/selection/5240265-expected.txt:
              * platform/mac/editing/selection/5333725-expected.txt:
              * platform/mac/editing/selection/5354455-1-expected.txt:
              * platform/mac/editing/selection/addRange-expected.txt:
              * platform/mac/editing/selection/caret-before-select-expected.txt:
              * platform/mac/editing/selection/contains-boundaries-expected.txt:
              * platform/mac/editing/selection/drag-select-1-expected.txt:
              * platform/mac/editing/selection/editable-html-element-expected.txt:
              * platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt:
              * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt:
              * platform/mac/editing/selection/mixed-editability-6-expected.txt:
              * platform/mac/editing/selection/mixed-editability-7-expected.txt:
              * platform/mac/editing/selection/move-by-sentence-linebreak-expected.txt:
              * platform/mac/editing/selection/select-all-005-expected.txt:
              * platform/mac/editing/selection/table-caret-1-expected.txt:
              * platform/mac/editing/selection/table-caret-2-expected.txt:
              * platform/mac/editing/selection/table-caret-3-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
              * platform/mac/editing/style/4916887-expected.txt:
              * platform/mac/editing/style/5017613-1-expected.txt:
              * platform/mac/editing/style/5017613-2-expected.txt:
              * platform/mac/editing/style/5046875-1-expected.txt:
              * platform/mac/editing/style/5046875-2-expected.txt:
              * platform/mac/editing/style/5065910-expected.txt:
              * platform/mac/editing/style/5084241-expected.txt:
              * platform/mac/editing/style/5091898-expected.txt:
              * platform/mac/editing/style/5228141-expected.txt:
              * platform/mac/editing/style/5279521-expected.txt:
              * platform/mac/editing/style/font-family-with-space-expected.txt:
              * platform/mac/editing/style/fontsize-1-expected.txt:
              * platform/mac/editing/style/highlight-expected.txt:
              * platform/mac/editing/style/non-inheritable-styles-expected.txt:
              * platform/mac/editing/undo/5378473-expected.txt:
              * platform/mac/fast/block/float/relative-painted-twice-expected.txt:
              * platform/mac/fast/dom/delete-contents-expected.txt:
              * platform/mac/fast/events/context-no-deselect-expected.txt:
              * platform/mac/fast/events/label-focus-expected.txt:
              * platform/mac/fast/forms/input-appearance-focus-expected.txt:
              * platform/mac/fast/forms/input-text-click-inside-expected.txt:
              * platform/mac/fast/forms/input-text-click-outside-expected.txt:
              * platform/mac/fast/forms/input-text-double-click-expected.txt:
              * platform/mac/fast/forms/input-text-drag-down-expected.txt:
              * platform/mac/fast/forms/input-text-option-delete-expected.txt:
              * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
              * platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/mac/fast/forms/textfield-overflow-expected.txt:
              * platform/mac/fast/inline/25277-2-expected.txt:
              * platform/mac/fast/inline/25277-expected.txt:
              * platform/mac/fast/lists/drag-into-marker-expected.txt:
              * platform/mac/fast/overflow/overflow-focus-ring-expected.txt:
              * platform/mac/fast/repaint/4776765-expected.txt:
              * platform/mac/fast/repaint/selection-after-delete-expected.txt:
              * platform/mac/fast/repaint/selection-after-remove-expected.txt:
              * platform/qt/editing/deleting/4845371-expected.txt:
              * platform/qt/editing/deleting/4866671-expected.txt:
              * platform/qt/editing/deleting/4875189-expected.txt:
              * platform/qt/editing/deleting/5026848-1-expected.txt:
              * platform/qt/editing/deleting/5026848-2-expected.txt:
              * platform/qt/editing/deleting/5026848-3-expected.txt:
              * platform/qt/editing/deleting/5032066-expected.txt:
              * platform/qt/editing/deleting/5091898-expected.txt:
              * platform/qt/editing/deleting/5099303-expected.txt:
              * platform/qt/editing/deleting/5115601-expected.txt:
              * platform/qt/editing/deleting/5126166-expected.txt:
              * platform/qt/editing/deleting/5144139-2-expected.txt:
              * platform/qt/editing/deleting/5156801-2-expected.txt:
              * platform/qt/editing/deleting/5168598-expected.txt:
              * platform/qt/editing/deleting/5272440-expected.txt:
              * platform/qt/editing/deleting/5300379-expected.txt:
              * platform/qt/editing/deleting/5390681-expected.txt:
              * platform/qt/editing/deleting/5408255-expected.txt:
              * platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
              * platform/qt/editing/deleting/delete-block-table-expected.txt:
              * platform/qt/editing/deleting/delete-hr-expected.txt:
              * platform/qt/editing/deleting/delete-link-1-expected.txt:
              * platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * platform/qt/editing/deleting/delete-to-select-table-expected.txt:
              * platform/qt/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
              * platform/qt/editing/deleting/merge-no-br-expected.txt:
              * platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
              * platform/qt/editing/execCommand/4641880-1-expected.txt:
              * platform/qt/editing/execCommand/4641880-2-expected.txt:
              * platform/qt/editing/execCommand/4747450-expected.txt:
              * platform/qt/editing/execCommand/4786404-1-expected.txt:
              * platform/qt/editing/execCommand/4786404-2-expected.txt:
              * platform/qt/editing/execCommand/4916402-expected.txt:
              * platform/qt/editing/execCommand/4916541-expected.txt:
              * platform/qt/editing/execCommand/4916583-expected.txt:
              * platform/qt/editing/execCommand/4920488-expected.txt:
              * platform/qt/editing/execCommand/4920742-1-expected.txt:
              * platform/qt/editing/execCommand/4924441-expected.txt:
              * platform/qt/editing/execCommand/5049671-expected.txt:
              * platform/qt/editing/execCommand/5062376-expected.txt:
              * platform/qt/editing/execCommand/5080333-1-expected.txt:
              * platform/qt/editing/execCommand/5080333-2-expected.txt:
              * platform/qt/editing/execCommand/5119244-expected.txt:
              * platform/qt/editing/execCommand/5120591-expected.txt:
              * platform/qt/editing/execCommand/5136770-expected.txt:
              * platform/qt/editing/execCommand/5142012-1-expected.txt:
              * platform/qt/editing/execCommand/5142012-2-expected.txt:
              * platform/qt/editing/execCommand/5142012-3-expected.txt:
              * platform/qt/editing/execCommand/5144139-1-expected.txt:
              * platform/qt/editing/execCommand/5164796-expected.txt:
              * platform/qt/editing/execCommand/5207369-expected.txt:
              * platform/qt/editing/execCommand/5210032-expected.txt:
              * platform/qt/editing/execCommand/5432254-1-expected.txt:
              * platform/qt/editing/execCommand/5432254-2-expected.txt:
              * platform/qt/editing/execCommand/insert-list-empty-div-expected.txt:
              * platform/qt/editing/inserting/12882-expected.txt:
              * platform/qt/editing/inserting/4840662-expected.txt:
              * platform/qt/editing/inserting/4875189-1-expected.txt:
              * platform/qt/editing/inserting/4875189-2-expected.txt:
              * platform/qt/editing/inserting/4959067-expected.txt:
              * platform/qt/editing/inserting/4960120-1-expected.txt:
              * platform/qt/editing/inserting/4960120-2-expected.txt:
              * platform/qt/editing/inserting/5002441-expected.txt:
              * platform/qt/editing/inserting/5058163-2-expected.txt:
              * platform/qt/editing/inserting/5156401-2-expected.txt:
              * platform/qt/editing/inserting/editable-html-element-expected.txt:
              * platform/qt/editing/inserting/editable-inline-element-expected.txt:
              * platform/qt/editing/inserting/edited-whitespace-1-expected.txt:
              * platform/qt/editing/inserting/editing-empty-divs-expected.txt:
              * platform/qt/editing/inserting/insert-before-link-1-expected.txt:
              * platform/qt/editing/pasteboard/4806874-expected.txt:
              * platform/qt/editing/pasteboard/4840662-expected.txt:
              * platform/qt/editing/pasteboard/4944770-1-expected.txt:
              * platform/qt/editing/pasteboard/4989774-expected.txt:
              * platform/qt/editing/pasteboard/5027857-expected.txt:
              * platform/qt/editing/pasteboard/5032095-expected.txt:
              * platform/qt/editing/pasteboard/5065605-expected.txt:
              * platform/qt/editing/pasteboard/5071074-2-expected.txt:
              * platform/qt/editing/pasteboard/5071074-expected.txt:
              * platform/qt/editing/pasteboard/5075944-2-expected.txt:
              * platform/qt/editing/pasteboard/5075944-3-expected.txt:
              * platform/qt/editing/pasteboard/5075944-expected.txt:
              * platform/qt/editing/pasteboard/5134759-expected.txt:
              * platform/qt/editing/pasteboard/5156401-1-expected.txt:
              * platform/qt/editing/pasteboard/5245519-expected.txt:
              * platform/qt/editing/pasteboard/5247341-expected.txt:
              * platform/qt/editing/pasteboard/5387578-expected.txt:
              * platform/qt/editing/pasteboard/5478250-expected.txt:
              * platform/qt/editing/pasteboard/5483567-expected.txt:
              * platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
              * platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
              * platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
              * platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * platform/qt/editing/selection/13804-expected.txt:
              * platform/qt/editing/selection/4397952-expected.txt:
              * platform/qt/editing/selection/4818145-expected.txt:
              * platform/qt/editing/selection/4866671-expected.txt:
              * platform/qt/editing/selection/4889598-expected.txt:
              * platform/qt/editing/selection/4895428-2-expected.txt:
              * platform/qt/editing/selection/4895428-3-expected.txt:
              * platform/qt/editing/selection/4932260-1-expected.txt:
              * platform/qt/editing/selection/4932260-2-expected.txt:
              * platform/qt/editing/selection/4932260-3-expected.txt:
              * platform/qt/editing/selection/4960116-expected.txt:
              * platform/qt/editing/selection/4983858-expected.txt:
              * platform/qt/editing/selection/5007143-2-expected.txt:
              * platform/qt/editing/selection/5007143-expected.txt:
              * platform/qt/editing/selection/5076323-1-expected.txt:
              * platform/qt/editing/selection/5076323-2-expected.txt:
              * platform/qt/editing/selection/5076323-3-expected.txt:
              * platform/qt/editing/selection/5081257-1-expected.txt:
              * platform/qt/editing/selection/5081257-2-expected.txt:
              * platform/qt/editing/selection/5099303-expected.txt:
              * platform/qt/editing/selection/5136696-expected.txt:
              * platform/qt/editing/selection/5195166-1-expected.txt:
              * platform/qt/editing/selection/5195166-2-expected.txt:
              * platform/qt/editing/selection/5234383-1-expected.txt:
              * platform/qt/editing/selection/5234383-2-expected.txt:
              * platform/qt/editing/selection/5240265-expected.txt:
              * platform/qt/editing/selection/addRange-expected.txt:
              * platform/qt/editing/selection/caret-before-select-expected.txt:
              * platform/qt/editing/selection/editable-html-element-expected.txt:
              * platform/qt/editing/selection/mixed-editability-6-expected.txt:
              * platform/qt/editing/selection/mixed-editability-7-expected.txt:
              * platform/qt/editing/selection/move-by-sentence-linebreak-expected.txt:
              * platform/qt/editing/selection/select-all-005-expected.txt:
              * platform/qt/editing/selection/table-caret-1-expected.txt:
              * platform/qt/editing/selection/table-caret-2-expected.txt:
              * platform/qt/editing/selection/table-caret-3-expected.txt:
              * platform/qt/editing/style/4916887-expected.txt:
              * platform/qt/editing/style/5017613-1-expected.txt:
              * platform/qt/editing/style/5017613-2-expected.txt:
              * platform/qt/editing/style/5046875-1-expected.txt:
              * platform/qt/editing/style/5046875-2-expected.txt:
              * platform/qt/editing/style/5065910-expected.txt:
              * platform/qt/editing/style/5084241-expected.txt:
              * platform/qt/editing/style/5228141-expected.txt:
              * platform/qt/editing/style/5279521-expected.txt:
              * platform/qt/editing/style/font-family-with-space-expected.txt:
              * platform/qt/editing/style/fontsize-1-expected.txt:
              * platform/qt/editing/style/highlight-expected.txt:
              * platform/qt/editing/style/non-inheritable-styles-expected.txt:
              * platform/qt/editing/undo/5378473-expected.txt:
              * platform/qt/fast/dom/delete-contents-expected.txt:
              * platform/qt/fast/events/label-focus-expected.txt:
              * platform/qt/fast/forms/input-appearance-focus-expected.txt:
              * platform/qt/fast/forms/input-maxlength-2-expected.txt:
              * platform/qt/fast/forms/input-text-click-inside-expected.txt:
              * platform/qt/fast/forms/input-text-option-delete-expected.txt:
              * platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/qt/fast/forms/textfield-overflow-expected.txt:
              * platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
              * platform/qt/fast/repaint/4776765-expected.txt:
              * platform/qt/fast/repaint/selection-after-delete-expected.txt:
              * platform/qt/fast/repaint/selection-after-remove-expected.txt:
              * platform/win/editing/deleting/5168598-expected.txt:
              * platform/win/editing/inserting/4960120-1-expected.txt:
              * platform/win/editing/inserting/5607069-2-expected.txt:
              * platform/win/editing/inserting/5607069-3-expected.txt:
              * platform/win/editing/inserting/typing-tab-designmode-forms-expected.txt:
              * platform/win/editing/pasteboard/4806874-expected.txt:
              * platform/win/editing/selection/4895428-3-expected.txt:
              * platform/win/editing/selection/5136696-expected.txt:
              * platform/win/editing/selection/drag-select-1-expected.txt:
              * platform/win/fast/events/context-no-deselect-expected.txt:
              * platform/win/fast/events/label-focus-expected.txt:
              * platform/win/fast/forms/input-appearance-focus-expected.txt:
              * platform/win/fast/forms/input-text-click-inside-expected.txt:
              * platform/win/fast/forms/input-text-click-outside-expected.txt:
              * platform/win/fast/forms/input-text-double-click-expected.txt:
              * platform/win/fast/forms/input-text-drag-down-expected.txt:
              * platform/win/fast/forms/input-text-option-delete-expected.txt:
              * platform/win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
              * platform/win/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/win/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/win/fast/forms/textfield-overflow-expected.txt:
              Updated BODY element index in test output (for some tests, it increased because of the
              implicitly added <head>, and for others, it decreased because mispositoned <script> is being
              moved into <head>).
      
              * webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
              * webarchive/archive-empty-frame-dom-expected.webarchive:
              Updated to include the implicitly added <head> elements.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0295906
  21. 04 May, 2009 1 commit
    • darin@apple.com's avatar
      WebCore: · 9a925fa1
      darin@apple.com authored
      2009-05-04  Darin Adler  <darin@apple.com>
      
              Reviewed by Eric Seidel.
      
              Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
              and NamedMappedAttrMap.h include of MappedAttribute.h
              https://bugs.webkit.org/show_bug.cgi?id=24924
      
              Make compiles faster, and debugging info smaller.
      
              * GNUmakefile.am: Added new source files.
              * WebCore.pro: Ditto.
              * WebCore.scons: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
      
              * bindings/js/JSHTMLCollectionCustom.cpp:
              (WebCore::toJS): Updated for new collection type names.
      
              * dom/Document.cpp:
              (WebCore::Document::createAttribute): Added. No longer inline.
              (WebCore::Document::images): Updated for new collection type names.
              (WebCore::Document::applets): Ditto.
              (WebCore::Document::embeds): Ditto.
              (WebCore::Document::plugins): Ditto.
              (WebCore::Document::objects): Ditto.
              (WebCore::Document::scripts): Ditto.
              (WebCore::Document::links): Ditto.
              (WebCore::Document::forms): Ditto.
              (WebCore::Document::anchors): Ditto.
              (WebCore::Document::all): Ditto.
              (WebCore::Document::windowNamedItems): Ditto.
              (WebCore::Document::documentNamedItems): Ditto.
              (WebCore::Document::nameCollectionInfo): Ditto.
      
              * dom/Document.h: Changed around includes and forward declarations.
              Updated for changes to collection types.
      
              * dom/NamedMappedAttrMap.h: Removed include of MappedAttribute.h.
      
              * html/CollectionCache.cpp: Copied from WebCore/html/HTMLCollection.cpp.
              Contains the class that used to be HTMLCollection::CollectionInfo.
              * html/CollectionCache.h: Copied from WebCore/html/HTMLCollection.h.
              Ditto.
      
              * html/CollectionType.h: Copied from WebCore/html/HTMLCollection.h.
              Has the enum that used to be HTMLCollection::Type.
      
              * html/HTMLCollection.cpp:
              (WebCore::HTMLCollection::HTMLCollection): Update for collection type change.
              (WebCore::HTMLCollection::create): Ditto.
              (WebCore::HTMLCollection::resetCollectionInfo): Ditto.
              (WebCore::HTMLCollection::itemAfter): Ditto.
              * html/HTMLCollection.h: Ditto.
      
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::children): Updated for new collection type names.
              * html/HTMLFormCollection.cpp:
              (WebCore::HTMLFormCollection::formCollectionInfo): Ditto.
              (WebCore::HTMLFormCollection::HTMLFormCollection): Ditto.
              * html/HTMLFormCollection.h: Ditto.
              * html/HTMLFormElement.h: Ditto.
              * html/HTMLMapElement.cpp:
              (WebCore::HTMLMapElement::areas): Ditto.
              * html/HTMLNameCollection.cpp:
              (WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.
              * html/HTMLNameCollection.h:
              (WebCore::HTMLNameCollection::create): Ditto.
              * html/HTMLSelectElement.h:
              (WebCore::HTMLSelectElement::collectionInfo): Ditto.
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::tBodies):Ditto.
              * html/HTMLTableRowElement.cpp:
              (WebCore::HTMLTableRowElement::cells):Ditto.
              * html/HTMLTableRowsCollection.cpp:
              (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): Ditto.
              * html/HTMLTableSectionElement.cpp:
              (WebCore::HTMLTableSectionElement::rows): Ditto.
      
              * bindings/js/JSDOMWindowBase.cpp: Added newly-needed includes.
              * bindings/js/JSHTMLFrameSetElementCustom.cpp: Ditto.
              * css/CSSStyleSelector.cpp: Ditto.
              * dom/Element.cpp: Ditto.
              * dom/InputElement.cpp: Ditto.
              * dom/NamedAttrMap.cpp: Ditto.
              * dom/NamedMappedAttrMap.cpp: Ditto.
              * dom/Node.cpp: Ditto.
              * dom/StyledElement.cpp: Ditto.
              * dom/StyledElement.h: Ditto.
              * editing/ApplyStyleCommand.cpp: Ditto.
              * editing/DeleteSelectionCommand.cpp: Ditto.
              * editing/Editor.cpp: Ditto.
              * editing/EditorCommand.cpp: Ditto.
              * editing/InsertParagraphSeparatorCommand.cpp: Ditto.
              * editing/ReplaceSelectionCommand.cpp: Ditto.
              * editing/markup.cpp: Ditto.
              * html/CanvasRenderingContext2D.cpp: Ditto.
              * html/HTMLAnchorElement.cpp: Ditto.
              * html/HTMLAppletElement.cpp: Ditto.
              * html/HTMLAreaElement.cpp: Ditto.
              * html/HTMLBRElement.cpp: Ditto.
              * html/HTMLBaseElement.cpp: Ditto.
              * html/HTMLBodyElement.cpp: Ditto.
              * html/HTMLButtonElement.cpp: Ditto.
              * html/HTMLCanvasElement.cpp: Ditto.
              * html/HTMLDivElement.cpp: Ditto.
              * html/HTMLEmbedElement.cpp: Ditto.
              * html/HTMLFontElement.cpp: Ditto.
              * html/HTMLFormControlElement.cpp: Ditto.
              * html/HTMLFormElement.cpp: Ditto.
              * html/HTMLFrameElement.cpp: Ditto.
              * html/HTMLFrameElementBase.cpp: Ditto.
              * html/HTMLFrameSetElement.cpp: Ditto.
              * html/HTMLHRElement.cpp: Ditto.
              * html/HTMLIFrameElement.cpp: Ditto.
              * html/HTMLImageElement.cpp: Ditto.
              * html/HTMLInputElement.cpp: Ditto.
              * html/HTMLIsIndexElement.cpp: Ditto.
              * html/HTMLKeygenElement.cpp: Ditto.
              * html/HTMLLIElement.cpp: Ditto.
              * html/HTMLLinkElement.cpp: Ditto.
              * html/HTMLMarqueeElement.cpp: Ditto.
              * html/HTMLMetaElement.cpp: Ditto.
              * html/HTMLOListElement.cpp: Ditto.
              * html/HTMLObjectElement.cpp: Ditto.
              * html/HTMLOptionElement.cpp: Ditto.
              * html/HTMLParagraphElement.cpp: Ditto.
              * html/HTMLParamElement.cpp: Ditto.
              * html/HTMLPlugInElement.cpp: Ditto.
              * html/HTMLPreElement.cpp: Ditto.
              * html/HTMLScriptElement.cpp: Ditto.
              * html/HTMLSelectElement.cpp: Ditto.
              * html/HTMLStyleElement.cpp: Ditto.
              * html/HTMLTableCaptionElement.cpp: Ditto.
              * html/HTMLTableCellElement.cpp: Ditto.
              * html/HTMLTableColElement.cpp: Ditto.
              * html/HTMLTablePartElement.cpp: Ditto.
              * html/HTMLTextAreaElement.cpp: Ditto.
              * html/HTMLTokenizer.cpp: Ditto.
              * html/HTMLUListElement.cpp: Ditto.
              * html/HTMLVideoElement.cpp: Ditto.
              * html/HTMLViewSourceDocument.cpp: Ditto.
              * loader/ImageDocument.cpp: Ditto.
              * page/Frame.cpp: Ditto.
              * rendering/RenderTreeAsText.cpp: Ditto.
              * svg/SVGAElement.cpp: Ditto.
              * svg/SVGAnimateMotionElement.cpp: Ditto.
              * svg/SVGAnimateTransformElement.cpp: Ditto.
              * svg/SVGAnimationElement.cpp: Ditto.
              * svg/SVGCircleElement.cpp: Ditto.
              * svg/SVGClipPathElement.cpp: Ditto.
              * svg/SVGCursorElement.cpp: Ditto.
              * svg/SVGElement.cpp: Ditto.
              * svg/SVGEllipseElement.cpp: Ditto.
              * svg/SVGExternalResourcesRequired.cpp: Ditto.
              * svg/SVGFitToViewBox.cpp: Ditto.
              * svg/SVGFontFaceElement.cpp: Ditto.
              * svg/SVGFontFaceUriElement.cpp: Ditto.
              * svg/SVGForeignObjectElement.cpp: Ditto.
              * svg/SVGGlyphElement.cpp: Ditto.
              * svg/SVGGradientElement.cpp: Ditto.
              * svg/SVGImageElement.cpp: Ditto.
              * svg/SVGLangSpace.cpp: Ditto.
              * svg/SVGLineElement.cpp: Ditto.
              * svg/SVGLinearGradientElement.cpp: Ditto.
              * svg/SVGMarkerElement.cpp: Ditto.
              * svg/SVGMaskElement.cpp: Ditto.
              * svg/SVGPathElement.cpp: Ditto.
              * svg/SVGPatternElement.cpp: Ditto.
              * svg/SVGPolyElement.cpp: Ditto.
              * svg/SVGRadialGradientElement.cpp: Ditto.
              * svg/SVGRectElement.cpp: Ditto.
              * svg/SVGSVGElement.cpp: Ditto.
              * svg/SVGScriptElement.cpp: Ditto.
              * svg/SVGStopElement.cpp: Ditto.
              * svg/SVGStyleElement.cpp: Ditto.
              * svg/SVGStyledElement.cpp: Ditto.
              * svg/SVGStyledTransformableElement.cpp: Ditto.
              * svg/SVGTests.cpp: Ditto.
              * svg/SVGTextContentElement.cpp: Ditto.
              * svg/SVGTextElement.cpp: Ditto.
              * svg/SVGTextPathElement.cpp: Ditto.
              * svg/SVGTextPositioningElement.cpp: Ditto.
              * svg/SVGURIReference.cpp: Ditto.
              * svg/SVGUseElement.cpp: Ditto.
              * svg/SVGViewElement.cpp: Ditto.
              * svg/animation/SVGSMILElement.cpp: Ditto.
              * xml/XPathStep.cpp: Ditto.
      
      WebKit/mac:
      
      2009-05-04  Darin Adler  <darin@apple.com>
      
              Reviewed by Eric Seidel.
      
              Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
              and NamedMappedAttrMap.h include of MappedAttribute.h
              https://bugs.webkit.org/show_bug.cgi?id=24924
      
              * WebView/WebFrame.mm: Added include of CSSMutableStyleDeclaration.h
              and ScriptValue.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a925fa1
  22. 01 May, 2009 1 commit
    • dglazkov@chromium.org's avatar
      WebCore: · 8ac9b855
      dglazkov@chromium.org authored
      2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
              This is the only resource-related information that is available in InspectorController
              and is missing in the FrameLoaderClient.
      
              https://bugs.webkit.org/show_bug.cgi?id=25347
      
              * WebCore.xcodeproj/project.pbxproj: Made ScriptSource private.
              * dom/Document.cpp: Made a call to a client along with the call to the InspectorController.
              (WebCore::Document::resourceRetrievedByXMLHttpRequest):
              * loader/EmptyClients.h: Added stub implementation.
              (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
              * loader/FrameLoader.cpp: Call initiating dispatches.
              (WebCore::FrameLoader::resourceRetrievedByXMLHttpRequest):
              * loader/FrameLoader.h:
              * loader/FrameLoaderClient.h:
      
      WebKit/gtk:
      
      2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
      
              https://bugs.webkit.org/show_bug.cgi?id=25347
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
              * WebCoreSupport/FrameLoaderClientGtk.h:
      
      WebKit/mac:
      
      2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
      
              https://bugs.webkit.org/show_bug.cgi?id=25347
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
      
      WebKit/qt:
      
      2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
      
              https://bugs.webkit.org/show_bug.cgi?id=25347
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::dispatchDidLoadResourceByXMLHttpRequest):
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      WebKit/win:
      
      2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
      
              https://bugs.webkit.org/show_bug.cgi?id=25347
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
              * WebCoreSupport/WebFrameLoaderClient.h:
      
      WebKit/wx:
      
      2009-05-01  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
      
              https://bugs.webkit.org/show_bug.cgi?id=25347
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::dispatchDidLoadResourceByXMLHttpRequest):
              * WebKitSupport/FrameLoaderClientWx.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ac9b855
  23. 30 Apr, 2009 2 commits
  24. 27 Apr, 2009 1 commit
    • weinig@apple.com's avatar
      2009-04-27 Sam Weinig <sam@webkit.org> · f23f7715
      weinig@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Move more window event related code into DOMWindow.
      
              * dom/Document.cpp:
              (WebCore::Document::implicitClose):
              (WebCore::Document::setWindowAttributeEventListener):
              (WebCore::Document::dispatchWindowEvent):
              (WebCore::Document::dispatchLoadEvent):
              * dom/Document.h:
              * dom/Element.cpp:
              * dom/Element.h:
              * dom/Node.cpp:
              * dom/Node.h:
              * html/HTMLBodyElement.cpp:
              (WebCore::HTMLBodyElement::parseMappedAttribute):
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::parseMappedAttribute):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::stopLoading):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
              (WebCore::DOMWindow::postMessageTimerFired):
              (WebCore::DOMWindow::dispatchEvent):
              (WebCore::DOMWindow::dispatchEventWithDocumentAsTarget):
              (WebCore::DOMWindow::dispatchLoadEvent):
              (WebCore::DOMWindow::dispatchUnloadEvent):
              (WebCore::DOMWindow::dispatchBeforeUnloadEvent):
              * page/DOMWindow.h:
              * page/Frame.cpp:
              (WebCore::Frame::shouldClose):
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::parseMappedAttribute):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f23f7715
  25. 24 Apr, 2009 1 commit
    • dglazkov@chromium.org's avatar
      2009-04-24 Dimitri Glazkov <dglazkov@chromium.org> · 26789aac
      dglazkov@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=25370
              Introduce ScriptEventListener to refactor away direct references to
              JSLazyEventListener in WebCore code.
      
              * GNUmakefile.am: Added ScriptEventListener to project.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * bindings/js/JSDOMGlobalObject.cpp: Removed unused JSLazyEventListener include.
              * bindings/js/JSLazyEventListener.cpp: Moved createAttributeEventListener helpers
                  to ScriptEventListener.
              * bindings/js/JSLazyEventListener.h: Ditto.
              * bindings/js/ScriptController.cpp: Removed unused JSLazyEventListener include.
              * bindings/js/ScriptEventListener.cpp: Added.
              * bindings/js/ScriptEventListener.h: Added.
              * bindings/v8/ScriptEventListener.cpp: Added.
              * bindings/v8/ScriptEventListener.h: Added.
              * dom/Document.cpp: Renamed JSLazyEventListener include to ScriptEventListener.
              * html/HTMLBodyElement.cpp: Ditto.
              * html/HTMLButtonElement.cpp: Ditto.
              * html/HTMLElement.cpp: Ditto.
              * html/HTMLFormElement.cpp: Ditto.
              * html/HTMLFrameElementBase.cpp: Ditto.
              * html/HTMLFrameSetElement.cpp: Ditto.
              * html/HTMLImageElement.cpp: Ditto.
              * html/HTMLInputElement.cpp: Ditto.
              * html/HTMLObjectElement.cpp: Ditto.
              * html/HTMLScriptElement.cpp: Ditto.
              * html/HTMLSelectElement.cpp: Ditto.
              * html/HTMLTextAreaElement.cpp: Ditto.
              * svg/SVGElement.cpp: Ditto.
              * svg/SVGSVGElement.cpp: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26789aac
  26. 19 Apr, 2009 2 commits
    • mitz@apple.com's avatar
      - fix release builds · 977b3443
      mitz@apple.com authored
              * dom/Document.cpp:
              (WebCore::Document::executeScriptSoonTimerFired):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      977b3443
    • mitz@apple.com's avatar
      WebCore: · 73169a1a
      mitz@apple.com authored
              Reviewed by Mark Rowe.
      
              - fix <rdar://problem/6734365> REGRESSION eBay "Save this search" link
                does nothing the second time search results are opened
      
              Test: fast/dom/HTMLScriptElement/nested-execution.html
      
              Instead of executing scripts as soon as they finish loading, which may
              happen synchronously during execution of another script, defer their
              execution until the next run loop iteration, using a queue that is
              similar to the HTML5 notion of the "list of scripts that will execute as
              soon as possible", and in my testing was consistent with how Firefox
              behaved.
      
              * dom/Document.cpp:
              (WebCore::Document::Document): Initialize m_executeScriptSoonTimer.
              (WebCore::Document::~Document): deref() script elements in
              m_scriptsToExecuteSoon.
              (WebCore::Document::executeScriptSoonTimerFired): Added. Executes the
              scripts in m_scriptsToExecuteSoon and deref()s them.
              (WebCore::Document::executeScriptSoon): Added. Appends to
              m_scriptsToExecuteSoon and ref()s the script element, which keeps the
              ScriptElementData alive as well.
              * dom/Document.h:
              * dom/ScriptElement.cpp:
              (WebCore::ScriptElementData::ScriptElementData): Initialize m_requested.
              (WebCore::ScriptElementData::requestScript): Set m_requested to true, to
              prevent further load requests.
              (WebCore::ScriptElementData::execute): Added. Moved the code from
              notifyFinished() which should not execute synchronously here, to be
              called by the Document on a 0-interval timer.
              (WebCore::ScriptElementData::notifyFinished): Moved the code to
              dispatch events and evaluate the script, which should not execute
              synchronously, out of here.
              (WebCore::ScriptElementData::ignoresLoadRequest): Changed to test for
              m_requested instead of m_cachedScript, because the latter is cleared
              before the script is evaluated.
              * dom/ScriptElement.h:
      
      LayoutTests:
      
              Reviewed by Mark Rowe.
      
              - test and updated tests for <rdar://problem/6734365> eBay "Save this
                search" link does nothing the second time search results are opened
      
              * fast/dom/HTMLScriptElement/nested-execution-expected.txt: Added.
              * fast/dom/HTMLScriptElement/nested-execution.html: Added.
              * fast/dom/HTMLScriptElement/resources/nested-execution.js: Added.
              * fast/dom/HTMLScriptElement/script-reexecution.html:
              * fast/dom/HTMLScriptElement/script-set-src.html:
              * fast/dom/script-element-gc.html:
              * fast/loader/local-JavaScript-from-local.html:
              * svg/dom/SVGScriptElement/script-reexecution.svg:
              * svg/dom/SVGScriptElement/script-set-href.svg:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73169a1a
  27. 18 Apr, 2009 1 commit
  28. 17 Apr, 2009 1 commit
    • ggaren@apple.com's avatar
      2009-04-17 Geoffrey Garen <ggaren@apple.com> · 15903b14
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
              Unbounded memory growth when churning elements with anonymous event handler functions
              
              Some refactoring of "inline" event listeners.
              
              Renames:
                  dispatchEventForType => dispatchEvent
                  setWindowInlineEventListenerForTypeAndAttribute => setWindowInlineEventListener
                  removeInlineEventListenerForType => clearInlineEventListener
                  setInlineEventListenerForType => setInlineEventListener
                  inlineEventListenerForType => getInlineEventListener
      
              * bindings/js/JSLazyEventListener.cpp:
              (WebCore::eventParameterName):
              (WebCore::JSLazyEventListener::JSLazyEventListener):
              (WebCore::createInlineEventListener):
              * bindings/js/JSLazyEventListener.h: Added two helper functions for
              creating "inline" event listeners. These replace Document::createEventListener,
              and abstract the creation of JS event listeners for DOM attributes out
              of the DOM. Removed legacy JSProtectedEventListener constructor code for
              adding the event listener's function to a map, since lazy event listeners
              don't have functions at construction time.
      
              * dom/Document.cpp:
              (WebCore::Document::setFocusedNode):
              * dom/Document.h:
              (WebCore::Document::isSVGDocument):
              * dom/Element.cpp:
              (WebCore::Element::setWindowInlineEventListener):
              * dom/Element.h: Updated for renames. Nixed Document::createEventListener,
              mentioned above. Moved setWindowInlineEventListenerForTypeAndAttribute
              to Element, for simplicity.
      
              * dom/InputElement.cpp:
              (WebCore::InputElement::setValueFromRenderer):
              * dom/Node.cpp:
              (WebCore::Node::dispatchFocusEvent):
              (WebCore::Node::dispatchBlurEvent):
              (WebCore::Node::dispatchEvent):
              (WebCore::Node::clearInlineEventListener):
              (WebCore::Node::setInlineEventListener):
              (WebCore::Node::getInlineEventListener):
              (WebCore::Node::onabort):
              (WebCore::Node::setOnabort):
              (WebCore::Node::etc.):
              * dom/Node.h: Updated for renames.
              
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplacementFragment::ReplacementFragment): Updated for renames.
              
              Updated these files for renames, and to use the new createInlineEventListener
              helper function:
      
              * html/HTMLBodyElement.cpp:
              (WebCore::HTMLBodyElement::parseMappedAttribute):
              * html/HTMLButtonElement.cpp:
              (WebCore::HTMLButtonElement::parseMappedAttribute):
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::parseMappedAttribute):
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLFormControlElement::onChange):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::prepareSubmit):
              (WebCore::HTMLFormElement::reset):
              (WebCore::HTMLFormElement::parseMappedAttribute):
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::parseMappedAttribute):
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::parseMappedAttribute):
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::parseMappedAttribute):
              * html/HTMLImageLoader.cpp:
              (WebCore::HTMLImageLoader::dispatchLoadEvent):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::parseMappedAttribute):
              (WebCore::HTMLInputElement::onSearch):
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::loadInternal):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::parseMappedAttribute):
              * html/HTMLScriptElement.cpp:
              (WebCore::HTMLScriptElement::parseMappedAttribute):
              (WebCore::HTMLScriptElement::dispatchLoadEvent):
              (WebCore::HTMLScriptElement::dispatchErrorEvent):
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::parseMappedAttribute):
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::parseMappedAttribute):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::notifyFinished):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::mouseButtonListener):
              * page/DOMWindow.cpp:
              * page/DOMWindow.h:
              (WebCore::DOMWindow::eventListeners):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::canMouseDownStartSelect):
              (WebCore::EventHandler::canMouseDragExtendSelect):
              (WebCore::EventHandler::sendScrollEvent):
              * page/Page.cpp:
              (WebCore::networkStateChanged):
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::valueChanged):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::selectionChanged):
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::parseMappedAttribute):
              * svg/SVGElementInstance.cpp:
              * svg/SVGImageLoader.cpp:
              (WebCore::SVGImageLoader::dispatchLoadEvent):
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::parseMappedAttribute):
              * svg/SVGScriptElement.cpp:
              (WebCore::SVGScriptElement::dispatchErrorEvent):
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::defaultEventHandler):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15903b14
  29. 16 Apr, 2009 2 commits
    • ggaren@apple.com's avatar
      2009-04-16 Geoffrey Garen <ggaren@apple.com> · 13e3791d
      ggaren@apple.com authored
              Reviewed by Sam Weinig.
      
              More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
              Unbounded memory growth when churning elements with anonymous event handler functions
              
              Some cleanup in event handling code.
      
              * bindings/js/JSDOMGlobalObject.cpp:
              * bindings/js/JSDOMGlobalObject.h: Removed findJSProtectedEventListener
              and findJSProtectedEventListener because they are now unused.
      
              * bindings/js/JSEventListener.cpp:
              * bindings/js/JSEventListener.h:
              (WebCore::JSEventListener::clearGlobalObject):
              * bindings/js/JSLazyEventListener.cpp:
              (WebCore::JSLazyEventListener::JSLazyEventListener):
              (WebCore::JSLazyEventListener::~JSLazyEventListener):
              (WebCore::JSLazyEventListener::globalObject):
              * bindings/js/JSLazyEventListener.h:
              (WebCore::JSLazyEventListener::clearGlobalObject): Nixed JSProtectedEventListener,
              and merged it with JSLazyEventListener, the only remaining event listener
              that still GC-protects its function and global object.
      
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::ScriptController):
              * bindings/js/ScriptController.h:
              (WebCore::ScriptController::setEventHandlerLineNumber):
              (WebCore::ScriptController::eventHandlerLineNumber): Renamed handlerLineno =>
              handlerLineNumber, because anything less would be uncivilized. Removed
              createInlineEventListener because it mostly did irrelevent work, so it
              just got in the way of understanding how event handler creation works.
      
              * dom/Document.cpp:
              (WebCore::Document::createEventListener):
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::XMLTokenizer::startElementNs):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::processToken): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13e3791d
    • ggaren@apple.com's avatar
      2009-04-16 Geoffrey Garen <ggaren@apple.com> · cb77b977
      ggaren@apple.com authored
              Reviewed by Eric Seidel and Adam Roben.
      
              More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
              Unbounded memory growth when churning elements with anonymous event handler functions
              
              Simplified some EventHandler creation code.
              
              Removed a pile of code whose sole purpose was to allow SVG event handlers
              to supply a parameter named "evt" instead of the normal "event", and
              replaced it with a single parameter to JSLazyEventListener's constructor
              specifying the parameter name to use.
      
              * bindings/js/JSDOMWindowBase.h:
              * bindings/js/JSLazyEventListener.cpp:
              (WebCore::JSLazyEventListener::JSLazyEventListener):
              (WebCore::JSLazyEventListener::parseCode):
              * bindings/js/JSLazyEventListener.h:
              (WebCore::JSLazyEventListener::create):
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::createInlineEventListener):
              * bindings/js/ScriptController.h:
              * dom/Document.cpp:
              (WebCore::Document::createEventListener):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb77b977
  30. 13 Apr, 2009 2 commits
    • ggaren@apple.com's avatar
      2009-04-13 Geoffrey Garen <ggaren@apple.com> · bc6ef281
      ggaren@apple.com authored
              Reviewed by Sam Weinig.
      
              Moved storage for window event listeners into the window object.
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::addEventListener):
              (WebCore::JSDOMWindow::removeEventListener): Add / remove window event
              listeners to / from the window object.
      
              * dom/Document.cpp:
              (WebCore::Document::removeAllEventListeners):
              (WebCore::Document::clear):
              (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute): Moved
              a bunch of code to the DOMWindow class, and left behind a few calls through
              to DOMWindow, to support legacy clients. (Eventually, these will go away, too.)
      
              * dom/Document.h: ditto.
      
              * dom/Node.cpp:
              (WebCore::Node::dispatchGenericEvent):
              (WebCore::Node::dispatchWindowEvent): Dipatch window events on the window
              object, not the document.
      
              * dom/Node.h:
              * dom/RegisteredEventListener.h: Moved RegisteredEventListenerVector
              declaration, since it's required in more places now.
      
              * history/CachedFrame.cpp:
              (WebCore::CachedFrame::clear): Updated for rename. Also, remove event
              listeners before detaching and clearing the document's window pointer,
              since the the document needs its window pointer in order to tell the window
              to clear its event listeners.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::stopLoading):
              (WebCore::FrameLoader::canCachePageContainingThisFrame):
              (WebCore::FrameLoader::logCanCacheFrameDecision): Updated for rename, and
              movement of window event listeners into the window.
      
              * loader/ImageDocument.cpp:
              (WebCore::ImageDocument::createDocumentStructure): Updated for movement
              of window event listeners into the window.
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::handleEvent):
              (WebCore::DOMWindow::addEventListener):
              (WebCore::DOMWindow::removeEventListener):
              (WebCore::DOMWindow::removeAllEventListeners):
              (WebCore::DOMWindow::hasEventListener):
              (WebCore::DOMWindow::setInlineEventListenerForType):
              (WebCore::DOMWindow::removeInlineEventListenerForType):
              (WebCore::DOMWindow::inlineEventListenerForType):
              (WebCore::DOMWindow::addPendingFrameUnloadEventCount):
              (WebCore::DOMWindow::removePendingFrameUnloadEventCount):
              (WebCore::DOMWindow::addPendingFrameBeforeUnloadEventCount):
              (WebCore::DOMWindow::removePendingFrameBeforeUnloadEventCount):
              * page/DOMWindow.h: Moved a bunch of code to the DOMWindow class, from the Document.
      
              * page/Frame.cpp:
              (WebCore::Frame::shouldClose): Updated for movement of window event listeners into the window.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc6ef281
    • hyatt@apple.com's avatar
      2009-04-13 David Hyatt <hyatt@apple.com> · 094f41bd
      hyatt@apple.com authored
              Reviewed by Darin Adler and Dan Bernstein.
      
              Assertion in updateStyleForAllDocuments.  Make sure to unscheduleStyleRecalc when an object goes into
              the page cache.  Disallow scheduling of style recalcs on a document that is already in the page cache.
              Schedule a style recalc if needed when an object comes out of the page cache.
      
              * dom/Document.cpp:
              (WebCore::Document::scheduleStyleRecalc):
              (WebCore::Document::setInPageCache):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      094f41bd
  31. 10 Apr, 2009 2 commits