1. 12 Jul, 2009 11 commits
    • bfulgham@webkit.org's avatar
      WebCore: · 0b68bb9d
      bfulgham@webkit.org authored
      2009-07-12  Keishi Hattori  <casey.hattori@gmail.com>
      
              Reviewed by Timothy Hatcher.
      
              Refactor ConsoleMessage to add MessageType attribute.
              https://bugs.webkit.org/show_bug.cgi?id=20625
      
              * bindings/js/JSCustomXPathNSResolver.cpp:
              (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::printErrorMessage):
              * dom/Document.cpp:
              (WebCore::Document::reportException):
              (WebCore::Document::addMessage):
              * dom/Document.h:
              * dom/ScriptExecutionContext.h:
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::reportErrorToConsole):
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              (WebCore::ConsoleMessage::addToConsole):
              (WebCore::ConsoleMessage::isEqual):
              * inspector/ConsoleMessage.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::addMessageToConsole):
              (WebCore::InspectorController::startGroup):
              (WebCore::InspectorController::endGroup):
              (WebCore::InspectorController::addProfileFinishedMessageToConsole):
              (WebCore::InspectorController::addStartProfilingMessageToConsole):
              (WebCore::InspectorController::count):
              * inspector/InspectorController.h:
              * inspector/front-end/Console.js:
              (WebInspector.Console.prototype.addMessage):
              (WebInspector.ConsoleMessage): Added type property.
              (WebInspector.ConsoleMessage.prototype.toMessageElement):
              (WebInspector.ConsoleMessage.prototype.toString):
              (WebInspector.ConsoleMessage.prototype.isEqual):
              (WebInspector.ConsoleCommandResult):
              (WebInspector.ConsoleGroup.prototype.addMessage):
              (WebInspector.ConsoleGroup.prototype._titleClicked):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype._addTip):
              (WebInspector.Resource.prototype._checkWarning):
              * inspector/front-end/inspector.css: Changed ".console-group-title-level" to ".console-group-title"
              * inspector/front-end/inspector.js:
              (WebInspector.addMessageToConsole):
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::printAccessDeniedMessage):
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::addMessageToConsole):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::reportLocalLoadFailed):
              (WebCore::FrameLoader::shouldAllowNavigation):
              * page/ChromeClient.h:
              * page/Console.cpp:
              (WebCore::printMessageSourceAndLevelPrefix):
              (WebCore::Console::addMessage):
              (WebCore::Console::error):
              (WebCore::Console::log):
              (WebCore::Console::dir):
              (WebCore::Console::trace):
              (WebCore::Console::assertCondition):
              (WebCore::Console::timeEnd):
              (WebCore::Console::warn):
              * page/Console.h: Added MessageType enum.
              (WebCore::):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::postMessageTimerFired):
              * page/XSSAuditor.cpp:
              (WebCore::XSSAuditor::canEvaluate):
              (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
              (WebCore::XSSAuditor::canLoadObject):
              * svg/SVGDocumentExtensions.cpp:
              (WebCore::SVGDocumentExtensions::reportWarning):
              (WebCore::SVGDocumentExtensions::reportError):
              * wml/WMLErrorHandling.cpp:
              (WebCore::reportWMLError):
              * workers/GenericWorkerTask.h: Added GenericWorkerTask8 for the extra argument.
              (WebCore::GenericWorkerTask8::create):
              (WebCore::GenericWorkerTask8::GenericWorkerTask8):
              (WebCore::GenericWorkerTask8::performTask):
              (WebCore::createCallbackTask):
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::addMessage):
              (WebCore::WorkerContext::importScripts):
              * workers/WorkerContext.h:
              * workers/WorkerMessagingProxy.cpp:
              (WebCore::postConsoleMessageTask):
              (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
              * workers/WorkerMessagingProxy.h:
              * workers/WorkerObjectProxy.h:
              * xml/XMLHttpRequest.cpp:
              (WebCore::reportUnsafeUsage):
              (WebCore::XMLHttpRequest::didFinishLoading):
              * xml/XSLTProcessor.cpp:
              (WebCore::XSLTProcessor::parseErrorFunc):
      
      WebKit/mac:
      
      2009-07-12  Keishi Hattori  <casey.hattori@gmail.com>
      
              Reviewed by Timothy Hatcher.
      
              Refactor ConsoleMessage to add MessageType attribute.
              https://bugs.webkit.org/show_bug.cgi?id=20625
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::addMessageToConsole):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b68bb9d
    • bfulgham@webkit.org's avatar
      2009-07-12 Nate Chapin <japhet@chromium.org> · b304a430
      bfulgham@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Upstream UndetectableHTMLCollection.idl as HTMLAllCollection.idl.
      
              https://bugs.webkit.org/show_bug.cgi?id=27132
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/DOMObjectsInclude.h:
              * bindings/v8/DerivedSourcesAllInOne.cpp:
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::getTemplate):
              (WebCore::V8DOMWrapper::instantiateV8Object):
              * bindings/v8/V8Index.cpp:
              * bindings/v8/V8Index.h:
              * dom/HTMLAllCollection.idl: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b304a430
    • bfulgham@webkit.org's avatar
      2009-07-12 Joseph Pecoraro <joepeck02@gmail.com> · 4a890df3
      bfulgham@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Inspector: Duplicate Computation in Autocompletion
              https://bugs.webkit.org/show_bug.cgi?id=26778
      
              * inspector/front-end/TextPrompt.js:
              (WebInspector.TextPrompt.prototype._completionsReady):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a890df3
    • eric.carlson@apple.com's avatar
      2009-07-12 Eric Carlson <eric.carlson@apple.com> · 6b3a34c1
      eric.carlson@apple.com authored
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=27197
              QuickTime supports data: urls, add a layout test.
      
              * media/audio-data-url-expected.txt: Added.
              * media/audio-data-url.html: Added.
                  New test.
      
              * platform/gtk/Skipped:
                  Skip the new test.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b3a34c1
    • mitz@apple.com's avatar
      WebCore: · 4c1ff326
      mitz@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              https://bugs.webkit.org/show_bug.cgi?id=27196
              Rename bidi.cpp to RenderBlockLineLayout.cpp and remove bidi.h
      
              * GNUmakefile.am: Updated.
              * WebCore.gypi: Updated.
              * WebCore.pro: Updated.
              * WebCore.vcproj/WebCore.vcproj: Updated.
              * WebCore.xcodeproj/project.pbxproj: Updated.
              * WebCoreSources.bkl: Updated.
              * rendering/RenderBlock.h: Removed unnecessary forward declaration and
                  updated comments.
              * rendering/RenderBlockLineLayout.cpp: Copied from WebCore/rendering/bidi.cpp.
                  Removed unnecessary #include statements.
              (WebCore::BidiRun::BidiRun): Moved here from bidi.h.
              (WebCore::RenderBlock::layoutInlineChildren): Removed outdated comment.
              * rendering/bidi.cpp: Removed.
              * rendering/bidi.h: Removed.
      
      WebKitTools:
      
              Reviewed by Maciej Stachowiak.
      
              https://bugs.webkit.org/show_bug.cgi?id=27196
              Update check-for-global-initializers for the renaming for bidi.cpp to
              RenderBlockLineLayout.cpp
      
              * Scripts/check-for-global-initializers:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c1ff326
    • mitz@apple.com's avatar
      Windows build fix · ba6bf2b1
      mitz@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba6bf2b1
    • mitz@apple.com's avatar
      Reviewed by Sam Weinig. · 74384b24
      mitz@apple.com authored
              - Image cleanup
      
              * platform/graphics/BitmapImage.cpp:
              (WebCore::BitmapImage::destroyDecodedData): Use the data() accessor
              instead of the m_data member.
              (WebCore::BitmapImage::dataChanged): Ditto.
              * platform/graphics/Image.h: Re-ordered #includes and class
              declarations. Removed the drawPatternCallback() declaration. Made member
              variables private.
              * platform/graphics/cg/ImageCG.cpp:
              (WebCore::drawPatternCallback): Changed this from a member function to a
              static function.
              * platform/graphics/cg/PDFDocumentImage.cpp:
              (WebCore::PDFDocumentImage::dataChanged): Use the data() accessor
              instead of the m_data member.
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::dataChanged): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74384b24
    • abarth@webkit.org's avatar
      2009-07-12 Daniel Bates <dbates@intudata.com> · 322a3394
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=27189
              
              Fixes insufficient check in XSSAuditor::canSetBaseElementURL that caused 
              XSSAuditor to incorrectly block HTML Base elements whose base path coincided 
              with the URL of the page.
      
              Test: http/tests/security/xssAuditor/base-href-safe3.html
      
              * page/XSSAuditor.cpp:
              (WebCore::XSSAuditor::canSetBaseElementURL): Changed conditional to only call 
              XSSAuditor::findInRequest() if the host in the page URL disagrees with the host 
              in the base element URL.
      
      2009-07-12  Daniel Bates  <dbates@intudata.com>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=27189
              
              Tests that XSSAuditor does not block HTML Base elements whose path has the 
              same host as the page.
      
              * http/tests/security/xssAuditor/base-href-safe3-expected.txt: Added.
              * http/tests/security/xssAuditor/base-href-safe3.html: Added.
              * http/tests/security/xssAuditor/resources/base-href/base-href-safe3.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      322a3394
    • darin@apple.com's avatar
      2009-07-12 Darin Adler <darin@apple.com> · 12d0cf13
      darin@apple.com authored
              Reviewed by Dan Bernstein.
      
              Text searching with ICU should take the user's default locale into account
              https://bugs.webkit.org/show_bug.cgi?id=27184
              rdar://problem/6812121
      
              No simple way to test this since it's dependent on user locale.
              After this, the user's default locale is used only on Mac.
      
              * editing/TextIterator.cpp:
              (WebCore::createSearcher): Pass result of the currentSearchLocaleID
              function as the locale.
      
              * platform/text/TextBreakIteratorInternalICU.h: Added declaration of
              currentSearchLocaleID function.
      
              * platform/text/android/TextBreakIteratorInternalICU.cpp:
              (WebCore::currentSearchLocaleID): Added. Returns the empty string.
              * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
              (WebCore::currentSearchLocaleID): Ditto.
              * platform/text/gtk/TextBreakIteratorInternalICUGtk.cpp:
              (WebCore::currentSearchLocaleID): Ditto.
      
              * platform/text/mac/TextBreakIteratorInternalICUMac.mm:
              (WebCore::textBreakLocalePreference): Added. Returns the value of
              the AppleTextBreakLocale preference.
              (WebCore::topLanguagePreference): Added. Returns the value of the
              first item in the AppleLanguages preference.
              (WebCore::canonicalLanguageIdentifier): Added. Cover for the
              CFLocaleCreateCanonicalLanguageIdentifierFromString function.
              (WebCore::getLocale): Added. Transfers the locale from a CFStringRef
              into a buffer.
              (WebCore::getSearchLocale): Added. Calls topLanguagePreference,
              canonicalLanguageIdentifier, and getLocale.
              (WebCore::currentSearchLocaleID): Added. Calls getSearchLocale once.
              (WebCore::getTextBreakLocale): Changed to call
              textBreakLocalePreference, topLanguagePreference,
              canonicalLanguageIdentifier, and getLocale.
      
              * platform/text/win/TextBreakIteratorInternalICUWin.cpp:
              (WebCore::currentSearchLocaleID): Added. Returns the empty string.
              * platform/wx/TemporaryLinkStubs.cpp:
              (WebCore::currentSearchLocaleID): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12d0cf13
    • xan@webkit.org's avatar
      2009-07-12 Xan Lopez <xlopez@igalia.com> · 393cdb46
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Bump version in preparation for 1.1.11 release.
      
              * configure.ac:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      393cdb46
    • xan@webkit.org's avatar
      2009-07-12 Xan Lopez <xlopez@igalia.com> · 2badd161
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              https://bugs.webkit.org/show_bug.cgi?id=25415
              [GTK][ATK] Please implement support for get_text_at_offset
      
              Create a PangoLayout that properly represents the visual
              appearance of the text in the web page so that the line boundary
              modes of getText{At,Before,After}Offset work correctly.
      
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (UTF16ToUTF8):
              (g_substr):
              (convertUniCharToUTF8):
              (getPangoLayoutForAtk):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2badd161
  2. 11 Jul, 2009 10 commits
    • oliver@apple.com's avatar
      Bug 27187 - Match Gecko behaviour for canvas path mutation APIs on an empty path · 574ca638
      oliver@apple.com authored
      <https://bugs.webkit.org/show_bug.cgi?id=27187>
      
      Reviewed by Simon Fraser
      
      Simple API change, check for the empty path and add appropriate point if necessary.
      
      Test: fast/canvas/canvas-modify-emptyPath.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      574ca638
    • eric.carlson@apple.com's avatar
      2009-07-11 Eric Carlson <eric.carlson@apple.com> · 1434736d
      eric.carlson@apple.com authored
              Reviewed by Antti Koivisto.
      
              HTMLMediaElement.canPlayType "maybe" and "probably" reversed
              https://bugs.webkit.org/show_bug.cgi?id=27186
      
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivate::supportsType):
                  Return "probably" if type has codecs parameter.
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::supportsType):
                  Ditto.
      
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
              (WebCore::MediaPlayerPrivate::supportsType):
                  Ditto.
      
      2009-07-11  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Antti Koivisto.
      
              HTMLMediaElement.canPlayType "maybe" and "probably" reversed
              https://bugs.webkit.org/show_bug.cgi?id=27186
      
              * media/video-can-play-type-expected.txt:
              * media/video-can-play-type.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1434736d
    • mrowe@apple.com's avatar
      Versioning. · 06e77ff5
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06e77ff5
    • beidson@apple.com's avatar
      2009-07-11 Brady Eidson <beidson@apple.com> · 3328b50d
      beidson@apple.com authored
              Reviewed by Mark Rowe.
      
              A worker-thread inspired follow-up for:
              https://bugs.webkit.org/show_bug.cgi?id=26496 and <rdar://problem/7046520>
              REGRESSION: XHR stream connection blocks iFrame loading and resource downloading
      
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::loadRequestAsynchronously): Don't perform the XHR compensation when the XHR
                is running on a worker thread. Accessing the global Cache data structures from a non-main thread is
                not currently supported.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3328b50d
    • simon.fraser@apple.com's avatar
      2009-07-11 Simon Fraser <simon.fraser@apple.com> · c563b67b
      simon.fraser@apple.com authored
              Enable support for accelerated compositing and 3d transforms on Leopard.
              <https://bugs.webkit.org/show_bug.cgi?id=20166>
              <rdar://problem/6120614>
      
              Reviewed by Oliver Hunt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c563b67b
    • hausmann@webkit.org's avatar
      2009-07-11 Simon Hausmann <hausmann@webkit.org> · 2dd02f46
      hausmann@webkit.org authored
              Fix the Qt build after r45724.
      
              * bridge/qt/qt_instance.cpp:
              (JSC::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp):
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dd02f46
    • abarth@webkit.org's avatar
      WebCore: · 289aa9c5
      abarth@webkit.org authored
      2009-07-10  Daniel Bates  <dbates@intudata.com>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=26921
      
              Implements support for HTML entities, so XSSAuditor can protect against attacks
              encoded with HTML entities.
      
              Tests: http/tests/security/xssAuditor/inline-event-HTML-entities.html
                     http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char.html
                     http/tests/security/xssAuditor/javascript-link-HTML-entities-named.html
                     http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char.html
                     http/tests/security/xssAuditor/javascript-link-HTML-entities.html
                     http/tests/security/xssAuditor/link-onclick-entities.html
                     http/tests/security/xssAuditor/script-tag-entities.html
                     http/tests/security/xssAuditor/script-tag-with-source-entities.html
      
              * page/XSSAuditor.cpp:
              (WebCore::XSSAuditor::canEvaluate):
              (WebCore::XSSAuditor::canEvaluateJavaScriptURL):
              (WebCore::XSSAuditor::decodeURL): Modified to call WebCore::XSSAuditor::decodeHTMLEntities
              to decode HTML entities.
              (WebCore::XSSAuditor::decodeHTMLEntities): Added method to decode HTML entities.
              (WebCore::XSSAuditor::findInRequest):
              * page/XSSAuditor.h:
      
      LayoutTests:
      
      2009-07-10  Daniel Bates  <dbates@intudata.com>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=26921
      
              Tests protection against HTML entities encoded attacks.
      
              * http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt: Added.
              * http/tests/security/xssAuditor/inline-event-HTML-entities.html: Added.
              * http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt: Added.
              * http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char.html: Added.
              * http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt: Added.
              * http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt: Added.
              * http/tests/security/xssAuditor/javascript-link-HTML-entities-named.html: Added.
              * http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Added.
              * http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char.html: Added.
              * http/tests/security/xssAuditor/javascript-link-HTML-entities.html: Added.
              * http/tests/security/xssAuditor/link-onclick-entities-expected.txt: Added.
              * http/tests/security/xssAuditor/link-onclick-entities.html: Added.
              * http/tests/security/xssAuditor/script-tag-entities-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-entities.html: Added.
              * http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-with-source-entities.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      289aa9c5
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/27173> svn-apply: Fix typo in git command used to find deleted files · 91fc31b2
      ddkilzer@apple.com authored
              Reviewed by Eric Seidel.
      
              * Scripts/svn-apply:
              (scmWillDeleteFile): Changed 'head' to 'HEAD'.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91fc31b2
    • ddkilzer@apple.com's avatar
      Bug 27007: Build fixes when ICONDATABASE is disabled · 8c80d4f2
      ddkilzer@apple.com authored
              <https://bugs.webkit.org/show_bug.cgi?id=27007>
      
              Reviewed by Sam Weinig.
      
      WebCore:
      
              * WebCore.xcodeproj/project.pbxproj: Added IconDatabaseNone.cpp
              to the project.
              * loader/icon/IconDatabase.cpp: Added
              #if ENABLE(ICONDATABASE)/#endif macro guard.
              * loader/icon/IconDatabase.h: Removed three public methods from
              #if ENABLE(ICONDATABASE)/#endif macro so that they may be
              stubbed out in IconDatabaseNone.cpp.
              * loader/icon/IconDatabaseNone.cpp: Added
              #if !ENABLE(ICONDATABASE)/#endif macro guard.
              (WebCore::IconDatabase::importIconURLForPageURL): Added.
              (WebCore::IconDatabase::importIconDataForIconURL): Added.
              (WebCore::IconDatabase::shouldStopThreadActivity): Added.
      
      WebKit/mac:
      
              * Misc/WebIconDatabase.mm:
              (defaultClient): Return 0 if ICONDATABASE is disabled.
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchDidReceiveIcon): Commented out
              the body of the method if ICONDATABASE is disabled.
              (WebFrameLoaderClient::registerForIconNotification): Ditto.
              * WebCoreSupport/WebIconDatabaseClient.mm: Added #if
              ENABLE(ICONDATABASE)/#endif guard to source.
              * WebView/WebView.mm:
              (-[WebView setFrameLoadDelegate:]): Wrapped code that starts the
              icon database machinery in #if ENABLE(ICONDATABASE)/#endif.
              (-[WebView _registerForIconNotification:]): Wrapped method in
              #if ENABLE(ICONDATABASE)/#endif guard.
              (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Ditto.
              * WebView/WebViewInternal.h: Wrapped methods in #if
              ENABLE(ICONDATABASE)/#endif guard.
              (-[WebView _registerForIconNotification:]):
              (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c80d4f2
    • abarth@webkit.org's avatar
      WebCore: · b9872cc8
      abarth@webkit.org authored
      2009-07-10  Daniel Bates  <dbates@intudata.com>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27151
      
              Fixes issue where JavaScript URLs that contain null- and non-null control characters can
              bypass XSSAuditor.
      
              Tests: http/tests/security/xssAuditor/javascript-link-control-char.html
                     http/tests/security/xssAuditor/javascript-link-null-char.html
                     http/tests/security/xssAuditor/javascript-link.html
      
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluate): Separated out logic for JavaScript URLs from 
              inline scripts. For JavaScript URLs, calls XSSAuditor::canEvaluateJavaScriptURL.
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::evaluate): Made similar changes to evaluate() as in
              bindings/js/ScriptController.cpp.
              * page/XSSAuditor.cpp:
              (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Separated out logic for JavaScript URLs
              into its own method.
              * page/XSSAuditor.h:
      
      LayoutTests:
      
      2009-07-10  Daniel Bates  <dbates@intudata.com>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27151
      
              Tests prevention of JavaScript URLs that contain null- and non-null control characters.
      
              * http/tests/security/xssAuditor/javascript-link-control-char-expected.txt: Added.
              * http/tests/security/xssAuditor/javascript-link-control-char.html: Added.
              * http/tests/security/xssAuditor/javascript-link-expected.txt: Added.
              * http/tests/security/xssAuditor/javascript-link-null-char-expected.txt: Added.
              * http/tests/security/xssAuditor/javascript-link-null-char.html: Added.
              * http/tests/security/xssAuditor/javascript-link.html: Added.
              * http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9872cc8
  3. 10 Jul, 2009 19 commits
    • jmalonzo@webkit.org's avatar
      2009-07-10 Jan Michael Alonzo <jmalonzo@webkit.org> · 2336a366
      jmalonzo@webkit.org authored
              Skip tests in the Gtk port that
              - are dependent on eventSender
              - require platform-specific results
              - regressed (with links to the regression bug report)
              - failing (due to missing/incomplete implementation)
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2336a366
    • ddkilzer@apple.com's avatar
      2009-07-10 Shinichiro Hamaji <hamaji@chromium.org> · 9c4dacca
      ddkilzer@apple.com authored
              Reviewed by David Kilzer.
      
              WebKit needs a style linting tool
              https://bugs.webkit.org/show_bug.cgi?id=25884
      
              Fix bunch of style issues by autofix of cpplint.
              This patch is created to demonstrate the autofix of cpplint.py.
      
              No new testcases because it's a style fix
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseMediaQuery):
              (WebCore::CSSParser::validUnit):
              (WebCore::CSSParser::parseValue):
              (WebCore::skipCommaInDashboardRegion):
              (WebCore::CSSParser::parseDashboardRegions):
              (WebCore::ShadowParseContext::commitValue):
              (WebCore::ShadowParseContext::commitLength):
              (WebCore::ShadowParseContext::commitColor):
              (WebCore::BorderImageParseContext::commitNumber):
              (WebCore::BorderImageParseContext::commitWidth):
              (WebCore::BorderImageParseContext::commitRule):
              (WebCore::BorderImageParseContext::commitBorderImage):
              (WebCore::CSSParser::lex):
              (WebCore::CSSParser::text):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * css/MediaList.cpp:
              (WebCore::MediaList::deleteMedium):
              * css/MediaQuery.h:
              * css/MediaQueryEvaluator.cpp:
              (WebCore::parseAspectRatio):
              * css/MediaQueryEvaluator.h:
              * css/MediaQueryExp.h:
              (WebCore::MediaQueryExp::operator==):
              * css/WebKitCSSMatrix.h:
              * dom/Comment.h:
              * dom/Document.cpp:
              (WebCore::Document::setFocusedNode):
              * dom/Document.h:
              (WebCore::Document::setHasDashboardRegions):
              * dom/DocumentFragment.cpp:
              (WebCore::DocumentFragment::nodeName):
              * dom/DocumentFragment.h:
              * dom/DynamicNodeList.h:
              * dom/EditingText.h:
              * dom/Element.cpp:
              (WebCore::Element::dispatchAttrAdditionEvent):
              * dom/NamedAttrMap.cpp:
              (WebCore::NamedNodeMap::item):
              * dom/Node.cpp:
              (WebCore::Node::nodeValue):
              (WebCore::Node::nodeIndex):
              * dom/NodeRareData.h:
              (WebCore::NodeListsNodeData::create):
              * dom/Notation.h:
              * dom/ProcessingInstruction.h:
              * dom/Range.cpp:
              (WebCore::Range::processContents):
              * dom/StyledElement.cpp:
              (WebCore::toHex):
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback):
              (WebCore::PendingCallbacks::PendingStartElementNSCallback::call):
              (WebCore::PendingCallbacks::):
              (WebCore::OffsetBuffer::readOutBytes):
              (WebCore::handleElementNamespaces):
              (WebCore::handleElementAttributes):
              (WebCore::attributesStartElementNsHandler):
              * dom/XMLTokenizerQt.cpp:
              (WebCore::attributesStartElementNsHandler):
              (WebCore::XMLTokenizer::parseStartElement):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyInlineStyle):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::removeNode):
              * editing/Editor.cpp:
              (WebCore::Editor::pasteAsPlainText):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::directionOfEnclosingBlock):
              * editing/SmartReplaceICU.cpp:
              (WebCore::addAllCodePoints):
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::icon):
              (WebCore::HistoryItem::adoptVisitCounts):
              * html/CanvasStyle.cpp:
              (WebCore::CanvasStyle::applyFillColor):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::setActive):
              (WebCore::HTMLAnchorElement::isLiveLink):
              * html/HTMLAppletElement.h:
              * html/HTMLAudioElement.h:
              * html/HTMLBRElement.h:
              * html/HTMLBaseElement.h:
              * html/HTMLBaseFontElement.h:
              * html/HTMLDListElement.h:
              * html/HTMLDirectoryElement.h:
              * html/HTMLFieldSetElement.cpp:
              (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::reset):
              * html/HTMLHRElement.cpp:
              (WebCore::HTMLHRElement::parseMappedAttribute):
              * html/HTMLHeadElement.h:
              * html/HTMLHtmlElement.h:
              * html/HTMLImageElement.h:
              (WebCore::HTMLImageElement::setLoadManually):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::selection):
              * html/HTMLIsIndexElement.h:
              * html/HTMLMarqueeElement.cpp:
              * html/HTMLMediaElement.h:
              (WebCore::HTMLMediaElement::):
              * html/HTMLMenuElement.h:
              * html/HTMLMetaElement.h:
              * html/HTMLModElement.h:
              * html/HTMLOListElement.h:
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::childrenChanged):
              * html/HTMLParamElement.h:
              * html/HTMLQuoteElement.h:
              * html/HTMLStyleElement.h:
              * html/HTMLTableCaptionElement.h:
              * html/HTMLTableCellElement.h:
              * html/HTMLTableColElement.h:
              * html/HTMLTableSectionElement.cpp:
              (WebCore::HTMLTableSectionElement::deleteRow):
              * html/HTMLTitleElement.h:
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseNonHTMLText):
              (WebCore::HTMLTokenizer::parseEntity):
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::write):
              * html/HTMLUListElement.h:
              * html/HTMLVideoElement.h:
              * html/TimeRanges.h:
              (WebCore::TimeRanges::Range::Range):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::enableResourceTracking):
              (WebCore::InspectorController::disableResourceTracking):
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::newInspectorJSONObject):
              * page/Console.cpp:
              (WebCore::Console::addMessage):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::defaultKeyboardEventHandler):
              * page/Frame.cpp:
              (WebCore::Frame::jsDefaultStatusBarText):
              * page/android/DragControllerAndroid.cpp:
              (WebCore::DragController::dragOperation):
              * page/android/EventHandlerAndroid.cpp:
              (WebCore::EventHandler::tabsToAllControls):
              (WebCore::EventHandler::eventActivatedView):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
              * page/gtk/DragControllerGtk.cpp:
              (WebCore::DragController::dragOperation):
              * page/qt/DragControllerQt.cpp:
              * page/win/DragControllerWin.cpp:
              (WebCore::DragController::isCopyKeyDown):
              * page/win/FrameWin.h:
              * rendering/RenderSlider.cpp:
              (WebCore::RenderSlider::mouseEventOffsetToThumb):
              * rendering/style/RenderStyle.h:
              (WebCore::InheritedFlags::setVerticalAlignLength):
              (WebCore::InheritedFlags::setUnicodeBidi):
              (WebCore::InheritedFlags::setCursor):
              * rendering/style/RenderStyleConstants.h:
              (WebCore::):
              * rendering/style/SVGRenderStyleDefs.h:
              * rendering/style/StyleInheritedData.h:
              (WebCore::StyleInheritedData::operator!=):
              * storage/DatabaseTask.h:
              * svg/GradientAttributes.h:
              * svg/LinearGradientAttributes.h:
              * svg/PatternAttributes.h:
              * svg/RadialGradientAttributes.h:
              * svg/SVGAnimatedPathData.h:
              * svg/SVGAnimatedPoints.h:
              * svg/SVGAnimationElement.h:
              * svg/SVGClipPathElement.h:
              * svg/SVGElementInstance.h:
              * svg/SVGFEBlendElement.cpp:
              (WebCore::SVGFEBlendElement::build):
              * svg/SVGFEBlendElement.h:
              * svg/SVGFEColorMatrixElement.cpp:
              (WebCore::SVGFEColorMatrixElement::build):
              * svg/SVGFEComponentTransferElement.cpp:
              (WebCore::SVGFEComponentTransferElement::build):
              * svg/SVGFECompositeElement.cpp:
              (WebCore::SVGFECompositeElement::build):
              * svg/SVGFEDiffuseLightingElement.cpp:
              (WebCore::SVGFEDiffuseLightingElement::build):
              * svg/SVGFEDisplacementMapElement.cpp:
              (WebCore::SVGFEDisplacementMapElement::build):
              * svg/SVGFEDistantLightElement.h:
              * svg/SVGFEFloodElement.cpp:
              (WebCore::SVGFEFloodElement::build):
              * svg/SVGFEFloodElement.h:
              * svg/SVGFEFuncAElement.h:
              * svg/SVGFEFuncBElement.h:
              * svg/SVGFEFuncGElement.h:
              * svg/SVGFEFuncRElement.h:
              * svg/SVGFEGaussianBlurElement.cpp:
              (WebCore::SVGFEGaussianBlurElement::build):
              * svg/SVGFEImageElement.cpp:
              (WebCore::SVGFEImageElement::build):
              * svg/SVGFEMergeElement.cpp:
              (WebCore::SVGFEMergeElement::build):
              * svg/SVGFEOffsetElement.cpp:
              (WebCore::SVGFEOffsetElement::build):
              * svg/SVGFEPointLightElement.h:
              * svg/SVGFESpecularLightingElement.cpp:
              (WebCore::SVGFESpecularLightingElement::build):
              * svg/SVGFESpotLightElement.h:
              * svg/SVGFETileElement.cpp:
              (WebCore::SVGFETileElement::build):
              * svg/SVGLineElement.cpp:
              (WebCore::SVGLineElement::parseMappedAttribute):
              * svg/SVGList.h:
              * svg/SVGListTraits.h:
              (WebCore::):
              * svg/SVGMPathElement.h:
              * svg/SVGMetadataElement.h:
              * svg/SVGParserUtilities.cpp:
              (WebCore::SVGPathParser::parseSVG):
              (WebCore::SVGPathParser::calculateArc):
              * svg/SVGPathElement.h:
              * svg/SVGPathSegClosePath.h:
              * svg/SVGSVGElement.h:
              * svg/SVGSetElement.h:
              * svg/SVGSwitchElement.h:
              * svg/SVGTextPathElement.cpp:
              (WebCore::SVGTextPathElement::parseMappedAttribute):
              * svg/SVGTextPathElement.h:
              * svg/SVGTitleElement.h:
              * svg/SVGTransformable.cpp:
              (WebCore::):
              * svg/SVGViewSpec.cpp:
              (WebCore::):
              * svg/animation/SMILTime.cpp:
              (WebCore::operator+):
              (WebCore::operator-):
              (WebCore::operator*):
              * svg/animation/SVGSMILElement.h:
              * svg/graphics/SVGResource.cpp:
              (WebCore::clientMap):
              * wml/WMLPostfieldElement.cpp:
              (WebCore::WMLPostfieldElement::value):
              * wml/WMLSetvarElement.cpp:
              (WebCore::WMLSetvarElement::value):
              * workers/WorkerRunLoop.cpp:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::dropProtection):
              * xml/XPathPath.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c4dacca
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/27167> bugzilla-tool: hide help for unsupported commands · 2edf14c4
      ddkilzer@apple.com authored
              Reviewed by Eric Seidel.
      
              When bugzilla-tool -h|--help is invoked in an svn working
              directory, don't print help for commands that are only supported
              on git working directories.
      
              * Scripts/bugzilla-tool:
              (Command.__init__): Added requires_local_commits argument with a
              default of False.  Set self.requires_local_commits attribute.
              (PostCommitsAsPatchesToBug.execute): Removed
              SCM.supports_local_commits() check since this is now handled by
              BugzillaTool.main().
              (PostCommitsAsPatchesToBug.__init__): Added
              requires_local_commits=True argument to Command.__init__().
              (BugzillaTool.commands_usage): Don't print help for commands if
              they require local commits and the current SCM doesn't support
              them.
              (BugzillaTool.main): If command_object requires local commits
              and the current SCM doesn't, exit with an error message.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2edf14c4
    • simon.fraser@apple.com's avatar
      2009-07-10 Simon Fraser <simon.fraser@apple.com> · 7507c6a3
      simon.fraser@apple.com authored
              Reviewed by John Sullivan.
      
              Flashing as hardware layers are created and destroyed in some content
              <rdar://problem/7032246>
      
              There's a window of time between the end of one runloop cycle, after CA layers changes
              have been committed, and the window display at the start of the next cycle when
              CA may push updates to the screen before AppKit has drawn the view contents. If
              we know that we need to do drawing synchronization (which we do when content moves
              between a layer and the view), then we need to call -disableScreenUpdatesUntilFlush
              from the existing runloop observer that is set up when layers need repainting to
              ensure that layer updates don't reach the screen before view-based painting does.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView drawRect:]):
              Tweak the comments
      
              * WebView/WebView.mm:
              (viewUpdateRunLoopObserverCallBack):
              (-[WebView _scheduleViewUpdate]):
              Add a big comment to explain the timing of things.
              Call -disableScreenUpdatesUntilFlush when the view _needsOneShotDrawingSynchronization.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7507c6a3
    • eric.carlson@apple.com's avatar
      2009-07-10 Eric Carlson <eric.carlson@apple.com> · ad70c0ee
      eric.carlson@apple.com authored
              Reviewed by Simon Fraser.
      
              <rdar://problem/7049066>.
              Update SnowLeopard media controller layout.
      
              * css/mediaControlsQT.css:
                  Update for new layout.
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::movieLoadType):
                  Added to replace isStreaming.
              * html/HTMLMediaElement.h:
                  Declare movieLoadType, remove isStreaming.
      
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlStatusDisplayElement::update):
                  Use movieLoadType instead of isStreaming.
              (WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):
                  MediaControlElement is the base class, not HTMLInputElement.
              (WebCore::MediaControlStatusDisplayElement::rendererIsNeeded):
                  Ditto.
              (WebCore::MediaControlRewindButtonElement::rendererIsNeeded):
                  Don't display rewind button for live streams.
              (WebCore::MediaControlReturnToRealtimeButtonElement::rendererIsNeeded):
                  MediaControlInputElement is the base class, not HTMLInputElement.
              * rendering/MediaControlElements.h:
      
              * rendering/RenderThemeMac.h:
              * rendering/RenderThemeMac.mm:
              (WebCore::getMediaUIPartStateFlags):
                  New, return wkDrawMediaUIPart flags.
              (WebCore::RenderThemeMac::paintMediaFullscreenButton):
              (WebCore::RenderThemeMac::paintMediaMuteButton):
              (WebCore::RenderThemeMac::paintMediaPlayButton):
              (WebCore::RenderThemeMac::paintMediaSeekBackButton):
              (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
              (WebCore::RenderThemeMac::paintMediaSliderTrack):
              (WebCore::RenderThemeMac::paintMediaSliderThumb):
              (WebCore::RenderThemeMac::paintMediaRewindButton):
              (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
              (WebCore::RenderThemeMac::paintMediaControlsBackground):
              (WebCore::RenderThemeMac::paintMediaCurrentTime):
              (WebCore::RenderThemeMac::paintMediaTimeRemaining):
                  Use getMediaUIPartStateFlags.
      
      2009-07-10  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Simon Fraser.
      
              Update WebKitSystemInterface for <rdar://problem/7049066>.
      
              * WebKitSystemInterface.h:
              * libWebKitSystemInterfaceLeopard.a:
              * libWebKitSystemInterfaceSnowLeopard.a:
              * libWebKitSystemInterfaceTiger.a:
      
      2009-07-10  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Simon Fraser.
      
              <rdar://problem/7049066>.
              Update media tests for new SnowLeopard controller layout.
      
              * platform/mac/media/controls-after-reload-expected.txt:
              * platform/mac/media/controls-styling-expected.txt:
              * platform/mac/media/video-empty-source-expected.txt:
              * platform/mac/media/video-zoom-controls-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad70c0ee
    • abarth@webkit.org's avatar
      Reverted 45741. Tests failed. · 0d91a8f6
      abarth@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d91a8f6
    • pkasting@chromium.org's avatar
      2009-07-10 Peter Kasting <pkasting@google.com> · 262e8898
      pkasting@chromium.org authored
              https://bugs.webkit.org/show_bug.cgi?id=19562
              Disable a failing layout test caused by the patch for this bug until
              I have time to determine that the obvious fix is correct.
      
              * fast/dom/domListEnumeration.html: Removed.
              * fast/dom/domListEnumeration.html-disabled: Copied from LayoutTests/fast/dom/domListEnumeration.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      262e8898
    • abarth@webkit.org's avatar
      2009-07-10 Daniel Bates <dbates@intudata.com> · f1e99309
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27151
              
              Fixes issue where JavaScript URLs that contain null- and non-null control characters can
              bypass XSSAuditor.
      
              Tests: http/tests/security/xssAuditor/javascript-link-control-char.html
                     http/tests/security/xssAuditor/javascript-link-null-char.html
                     http/tests/security/xssAuditor/javascript-link.html
      
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluate): Separated out logic for JavaScript URLs from 
              inline scripts. For JavaScript URLs, calls XSSAuditor::canEvaluateJavaScriptURL.
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::evaluate): Made similar changes to evaluate() as in 
              bindings/js/ScriptController.cpp.
              * page/XSSAuditor.cpp:
              (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Separated out logic for JavaScript URLs
              into its own method.
              * page/XSSAuditor.h:
      
      2009-07-10  Daniel Bates  <dbates@intudata.com>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27151
      
              Tests prevention of JavaScript URLs that contain null- and non-null control characters.
      
              * http/tests/security/xssAuditor/javascript-link-control-char-expected.txt: Added.
              * http/tests/security/xssAuditor/javascript-link-control-char.html: Added.
              * http/tests/security/xssAuditor/javascript-link-expected.txt: Added.
              * http/tests/security/xssAuditor/javascript-link-null-char-expected.txt: Added.
              * http/tests/security/xssAuditor/javascript-link-null-char.html: Added.
              * http/tests/security/xssAuditor/javascript-link.html: Added.
              * http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1e99309
    • abarth@webkit.org's avatar
      WebKit/mac: · b983b969
      abarth@webkit.org authored
      2009-07-10  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig with the power of Grayskull.
      
              Enable XSSAuditor by default.
      
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
      
      WebKit/win:
      
      2009-07-10  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig with the power of Grayskull.
      
              Enable XSSAuditor by default.
      
              * WebPreferences.cpp:
              (WebPreferences::initializeDefaultSettings):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b983b969
    • pkasting@chromium.org's avatar
      WebCore: · 023b7783
      pkasting@chromium.org authored
      2009-07-10  Michelangelo De Simone  <micdesim@gmail.com>
      
              Reviewed by Adele Peterson.
      
              https://bugs.webkit.org/show_bug.cgi?id=19562
              Added build stuff and stub for the ValidityState class, part of HTML5
              section Forms:
              http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#validitystate
      
              Test: fast/forms/ValidityState-001.html
      
              * DerivedSources.cpp: Fix aimed to include ValidityState files
              * DerivedSources.make: ditto
              * GNUmakefile.am: ditto
              * WebCore.gypi: ditto
              * WebCore.pro: ditto
              * WebCore.vcproj/WebCore.vcproj: ditto
              * WebCore.xcodeproj/project.pbxproj: ditto
              * WebCoreSources.bkl: ditto
              * html/HTMLButtonElement.idl: "validity" attribute
              * html/HTMLFieldSetElement.idl: ditto
              * html/HTMLFormControlElement.cpp: object getter
              (WebCore::HTMLFormControlElement::validity):
              * html/HTMLFormControlElement.h: ditto
              * html/HTMLInputElement.idl: "validity" attribute
              * html/HTMLSelectElement.idl: ditto
              * html/HTMLTextAreaElement.idl: ditto
              * html/ValidityState.cpp: Added.
              (WebCore::ValidityState::ValidityState):
              (WebCore::ValidityState::valid): validation flag
              * html/ValidityState.h: Added.
              (WebCore::ValidityState::create): creation routine
              (WebCore::ValidityState::control): ValidityState's parent getter
              (WebCore::ValidityState::valueMissing): validation flag
              (WebCore::ValidityState::typeMismatch): ditto
              (WebCore::ValidityState::patternMismatch): ditto
              (WebCore::ValidityState::tooLong): ditto
              (WebCore::ValidityState::rangeUnderflow): ditto
              (WebCore::ValidityState::rangeOverflow): ditto
              (WebCore::ValidityState::stepMismatch): ditto
              (WebCore::ValidityState::customError): ditto
              * html/ValidityState.idl: Added.
      
      LayoutTests:
      
      2009-07-10  Michelangelo De Simone  <micdesim@gmail.com>
      
              Reviewed by Adele Peterson.
      
              https://bugs.webkit.org/show_bug.cgi?id=19562
              Minimal test case for ValidityState; more tests are going to be added
              along with specific validation routines.
      
              * fast/forms/ValidityState-001-expected.txt: Added.
              * fast/forms/ValidityState-001.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      023b7783
    • mrowe@apple.com's avatar
      Versioning. · 37d9b138
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37d9b138
    • mrowe@apple.com's avatar
      Second part of the "make Windows happier" dance. · e822eb72
      mrowe@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e822eb72
    • mrowe@apple.com's avatar
      Try and make the Windows build happy. · 5b28db12
      mrowe@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b28db12
    • beidson@apple.com's avatar
      2009-07-10 Brady Eidson <beidson@apple.com> · 081fcc85
      beidson@apple.com authored
              Style cleanup over my last patch.
      
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::~XMLHttpRequest):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      081fcc85
    • kmccullough@apple.com's avatar
      JavaScriptCore: · e97cd03f
      kmccullough@apple.com authored
      2009-07-10  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              * debugger/Debugger.h: Made this function virtual for use in WebCore's
              WebInspector.
      
      WebCore:
      
      2009-07-10  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              * inspector/JavaScriptCallFrame.cpp:
              (WebCore::JavaScriptCallFrame::dynamicGlobalObject):
              * inspector/JavaScriptCallFrame.h: New helper method, used below.
      
              * inspector/JavaScriptDebugServer.cpp:
              (WebCore::JavaScriptDebugServer::detach): In the special case
              where we detach from a window currently executing JavaScript,
              manually tear down our representation of the JavaScript
              call stack, since we won't get any more callbacks from JavaScriptCore
              to automatically tear it down. It's too bad that WebCore is
              responsible for this kind of tracking -- in the future, it would
              be nice if more of the breakpoint handling was inside of JavaScriptCore.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e97cd03f
    • beidson@apple.com's avatar
      2009-07-10 Brady Eidson <beidson@apple.com> · bdcf0228
      beidson@apple.com authored
              Reviewed by Antti Koivisto.
      
              https://bugs.webkit.org/show_bug.cgi?id=26496 and <rdar://problem/7046520>
              REGRESSION: XHR stream connection blocks iFrame loading and resource downloading
      
              With this test we ended up going over the maximum-connections-per-host limit that CFNetwork expected.
              When that happened, the first request that was over the limit ended up in a bizarre state where it 
              wasn't fully serviced until after the long running XHR was complete.
      
              Loader and Loader::Host work together to try to not exceed the max-connection limit but non-cache
              resources - such as XHR - could still end up causing this limit to be exceeded.
      
              This fix adds a workaround specifically for XHR while we hash out a more thorough solution that will
              handle this at the resource handle level.
      
              * loader/loader.cpp:
              (WebCore::Loader::nonCacheRequestInFlight):
              (WebCore::Loader::nonCacheRequestComplete):
              (WebCore::Loader::Host::Host):
              (WebCore::Loader::Host::nonCacheRequestInFlight):
              (WebCore::Loader::Host::nonCacheRequestComplete):
              (WebCore::Loader::Host::servePendingRequests): Take nonCacheRequestsInFlight into account.
              * loader/loader.h:
              (WebCore::Loader::Host::processingResource): Take nonCacheRequestsInFlight into account.
      
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::XMLHttpRequest):
              (WebCore::XMLHttpRequest::~XMLHttpRequest): 
              (WebCore::XMLHttpRequest::loadRequestAsynchronously): Bump the nonCacheRequestInFlight count.
              (WebCore::XMLHttpRequest::didFail): Decrement that count if the Loader was notified.
              (WebCore::XMLHttpRequest::didFinishLoading): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdcf0228
    • yael.aharon@nokia.com's avatar
      2009-07-10 Yael Aharon <yael.aharon@nokia.com> · f96d2640
      yael.aharon@nokia.com authored
              Reviewed by Holger Freyther.
      
              https://bugs.webkit.org/show_bug.cgi?id=27136
      
              Fix a bug where webkit hangs when executing infinite JavaScript loop.
      
              * Api/qwebpage.cpp:
              * Api/qwebpage.h:
              * WebCoreSupport/ChromeClientQt.cpp:
              * tests/qwebpage/tst_qwebpage.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f96d2640
    • bfulgham@webkit.org's avatar
      2009-07-10 Kwang Yul Seo <skyul@company100.net> · ead6aafe
      bfulgham@webkit.org authored
              Reviewed by Darin Adler.
      
              ParserArenaDeletable should override delete
              https://bugs.webkit.org/show_bug.cgi?id=26790
      
              ParserArenaDeletable overrides new, but it does not override delete.
              ParserArenaDeletable must be freed by fastFree
              because it is allocated by fastMalloc.
      
              * parser/NodeConstructors.h:
              (JSC::ParserArenaDeletable::operator delete):
              * parser/Nodes.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ead6aafe
    • antti@apple.com's avatar
      2009-07-10 Antti Koivisto <antti@apple.com> · 19a5181c
      antti@apple.com authored
              Try to unbreak non-Mac build.
      
              * page/ChromeClient.h:
              (WebCore::ChromeClient::formDidFocus):
              (WebCore::ChromeClient::formDidBlur):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19a5181c