Commits · 0b4b53999d81e7b357a10a2f6754bab507b514ee · App_Technologies / webkit

07 Jan, 2008 28 commits

Rubber stamped by David Kilzer. · 0b4b5399

darin@apple.com authored Jan 07, 2008

        - get rid of empty fpconst.cpp

        * GNUmakefile.am: Remove fpconst.cpp.
        * JavaScriptCore.pri: Ditto.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
        * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
        * JavaScriptCoreSources.bkl: Ditto.

        * kjs/fpconst.cpp: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0b4b5399

Rubberstamped by Oliver. · 758e900e

zimmermann@webkit.org authored Jan 07, 2008

Fix all SVG layout tests now that DRT works again reliable for SVG pixel tests.

Move all *-expected.txt files into platform/mac (as most contain text, and other measured values)
Leave only -expected.txt files there which dump as text.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

758e900e

Reviewed by David Kilzer. · 3b4d9cc5

darin@apple.com authored Jan 07, 2008

        - fix alignment problem with NaN and Inf globals

        * kjs/fpconst.cpp: Move the contents of this file from here back to
        value.cpp. The reason this was in a separate file is that the DARWIN
        version of this used a declaration of the globals with a different
        type to avoid creating "init routines". That's no longer necessary for
        DARWIN and was never necessary for the non-DARWIN code path.
        To make this patch easy to merge, I didn't actually delete this file
        yet. We'll do that in a separate changeset.

        * kjs/value.cpp: If C99's NAN and INFINITY are present, then use them,
        othrewise use the union trick from fpconst.cpp. I think it would be
        better to eliminate KJS::NaN and KJS::Inf and just use NAN and INFINITY
        directly or std::numeric_limits<double>::quiet_nan() and
        std::numeric_limits<double>::infinity(). But when I tried that, it
        slowed down SunSpider. Someone else could do that cleanup if they
        could do it without slowing down the engine.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3b4d9cc5

- Updated to run a test whose failure was only a build bot state issue. · 10793db1

kmccullough@apple.com authored Jan 07, 2008

 
        * platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10793db1

Fix for bug 13095, CSS3 multiple backgrounds don't work on table cells. · cbd1b3c6

hyatt@apple.com authored Jan 07, 2008

        Reviewed by Dan

        * rendering/RenderBox.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cbd1b3c6

* platform/win/Skipped: Skip the culprit, not the victim. · 91770c05
aroben@apple.com authored Jan 07, 2008
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
91770c05

Windows build fix · fe6c4259

aroben@apple.com authored Jan 07, 2008

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added
        JavaScript.h to the project.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
        Copy JavaScript.h to WEBKITOUTPUTDIR.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fe6c4259

Reviewed by Darin. · 81877173

timothy@apple.com authored Jan 07, 2008

        Fix Mac build.

        * API/JSNode.c:
        * API/JSNode.h:
        * API/JSNodeList.c:
        * API/JSNodeList.h:
        * API/JavaScript.h:
        * API/JavaScriptCore.h:
        * API/minidom.c:
        * JavaScriptCore.xcodeproj/project.pbxproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

81877173

* platform/win/Skipped: Added a few more failures. · 48e760c8
aroben@apple.com authored Jan 07, 2008
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
48e760c8

Remove a now incorrect Windows-specific result · 1992ea77

aroben@apple.com authored Jan 07, 2008

        This should have been done as part of r29187

        * platform/win/fast/dom/wrapper-classes-expected.txt: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1992ea77

Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244 · 5cbaa97a

zimmermann@webkit.org authored Jan 07, 2008

DRT doesn't handle platform specific pixel test results correctly.

<test>-expected.txt files and <test>-expected.png files may now live
in different directories (ie. a cross-platform <test>-expected.txt file
and a platform-specific <test>-expected.png file).


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5cbaa97a

2008-01-07 Alp Toker <alp@atoker.com> · baab9e7f

alp@webkit.org authored Jan 07, 2008

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=16029
        JavaScriptCore.h is not suitable for platforms other than Mac OS X

        Introduce a new JavaScriptCore/JavaScript.h public API header. This
        should be used by all new portable code using the JavaScriptCore API.

        JavaScriptCore/JavaScriptCore.h will remain for compatibility with
        existing applications that depend on it including JSStringRefCF.h
        which isn't portable.

        Also add minidom to the GTK+/autotools build since we can now support
        it on all platforms.

        * API/JSNode.h:
        * API/JSNodeList.h:
        * API/JavaScript.h: Added.
        * API/JavaScriptCore.h:
        * ForwardingHeaders/JavaScriptCore/JavaScript.h: Added.
        * GNUmakefile.am:
        * JavaScriptCore.xcodeproj/project.pbxproj:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

baab9e7f

* Fix indention · 82bb235f

zecke@webkit.org authored Jan 07, 2008


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

82bb235f

* The ContextMenuController is going to live longer than the ContextMenu. It is · 6984ed10

zecke@webkit.org authored Jan 07, 2008

going to live as long as the WebCore::Page is around where the ContextMenu, specially
in the case of a SubMenu, is gone before we popup the menu.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6984ed10

* Fix SubMenu handling · d4ffabbf

zecke@webkit.org authored Jan 07, 2008

* Do not connect to the activated signal if we are a separator or submenu
* Change our type from ActionType to SubMenuType when we have a submenu
* Initialize the SubMenu


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d4ffabbf

* Qt and Gtk must know if a ContextMenuItem is checkable. Add a new... · 1aee922b

zecke@webkit.org authored Jan 07, 2008

* Qt and Gtk must know if a ContextMenuItem is checkable. Add a new ContextMenuItemType for checkable
  actions.
* Use this information in the Gtk platform to create a GtkCheckMenuItem when needed.
* Update the ContextMenuController to accept CheckableActionTypes as well.
* Change ContextMenu.cpp to use the CheckableActionType. The information if a item is checkable
  was extracted from ContextMenu::checkOrEnableIfNeeded.
* Update the Qt and Windows port.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1aee922b

WebKitTools: · 425dfd5e

kmccullough@apple.com authored Jan 07, 2008

        Reviewed by Darin.

        - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
        DRT did not correctly handle printing the '\0' char.  Now it does.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (dumpFramesAsText):
        (dump):

LayoutTests:

        Reviewed by Darin.

        - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing.
        Since they pass now, the two tests are removed from the Skipped list.

        * platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

425dfd5e

2008-01-07 Luca Bruno <lethalman88@gmail.com> · ed4bd09a

alp@webkit.org authored Jan 07, 2008

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=16745
        [GTK] Context menu doesn't feel or look native - no icons

        Use GTK+ stock icons for menu items where possible.

        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::gtkStockIDFromContextMenuAction):
        (WebCore::ContextMenuItem::createNativeMenuItem):
        (WebCore::ContextMenuItem::setAction):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ed4bd09a

Reviewed by John Sullivan. · df0149aa

mitz@apple.com authored Jan 07, 2008

        - make the ATSUI code path work with custom fonts rather than crash

        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/mac/FontMac.mm:
        (WebCore::initializeATSUStyle):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

df0149aa

Build fix for the Windows build. MSVC wants to see the full · 0d6335b1

hausmann@webkit.org authored Jan 07, 2008

declaration of arguments even when just passing them through.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0d6335b1

Added the missing parameters to make it possible to do POST operations from the public API. · 36034c0b

hausmann@webkit.org authored Jan 07, 2008

This is ugly though as it also requires including qnetworkaccessmanager.h. It would be nicer if the
two extra arguments were in QNetworkRequest :-/

Signed-off-by: Lars

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

36034c0b

abort() now emits the signals, so disconnect them before you abort() · 5f52eb51
hausmann@webkit.org authored Jan 07, 2008
```
Signed-off-by: Simon


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
5f52eb51

Use a faster and safer way of flattening the form data. · 1c95aaf1

hausmann@webkit.org authored Jan 07, 2008

Signed-off-by: Lars


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1c95aaf1

Ported of the network backend of the Qt platform to Qt 4.4's new networking API. · 0ad8f5ec
hausmann@webkit.org authored Jan 07, 2008
```
Signed-off-by: Lars


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
0ad8f5ec

* Remove m_dirtyRegion as it is not used as we pass every dirty region · 900e8143

hausmann@webkit.org authored Jan 07, 2008

  directly to the ChromeClient

Signed-off-by: Lars


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

900e8143

* Move the QWebPagePrivate methods up to the other private ones · 1b5282b0

hausmann@webkit.org authored Jan 07, 2008

Signed-off-by: Simon


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1b5282b0

* Add reimplemented comments for the methods reimplemented in QWebView and QWebPage. · c76b1eb3
hausmann@webkit.org authored Jan 07, 2008
```
Signed-off-by: Simon


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
c76b1eb3

* This layout is not needed anymore as Widget::invalidateRect will not · e58ebaec

hausmann@webkit.org authored Jan 07, 2008

  draw anymore.

Signed-off-by: Lars


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e58ebaec

06 Jan, 2008 12 commits

Reviewed by Sam. · a6f133e2

eric@webkit.org authored Jan 07, 2008

        Abstract all DateObject.set* functions in preparation for fixing:
        http://bugs.webkit.org/show_bug.cgi?id=16753

        SunSpider had random changes here and there but was overall a wash.

        * kjs/date_object.cpp:
        (KJS::fillStructuresUsingTimeArgs):
        (KJS::setNewValueFromTimeArgs):
        (KJS::setNewValueFromDateArgs):
        (KJS::DateProtoFuncSetMilliSeconds::callAsFunction):
        (KJS::DateProtoFuncSetUTCMilliseconds::callAsFunction):
        (KJS::DateProtoFuncSetSeconds::callAsFunction):
        (KJS::DateProtoFuncSetUTCSeconds::callAsFunction):
        (KJS::DateProtoFuncSetMinutes::callAsFunction):
        (KJS::DateProtoFuncSetUTCMinutes::callAsFunction):
        (KJS::DateProtoFuncSetHours::callAsFunction):
        (KJS::DateProtoFuncSetUTCHours::callAsFunction):
        (KJS::DateProtoFuncSetDate::callAsFunction):
        (KJS::DateProtoFuncSetUTCDate::callAsFunction):
        (KJS::DateProtoFuncSetMonth::callAsFunction):
        (KJS::DateProtoFuncSetUTCMonth::callAsFunction):
        (KJS::DateProtoFuncSetFullYear::callAsFunction):
        (KJS::DateProtoFuncSetUTCFullYear::callAsFunction):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a6f133e2

Reviewed by Oliver. · 6f9c1ed0

zimmermann@webkit.org authored Jan 06, 2008

Small CG paint server cleanups - use more GraphicsContext method where possible.p


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6f9c1ed0

Reviewed by Dan. · f1f4f840

zimmermann@webkit.org authored Jan 06, 2008

Add new helper function isArabicChar - SVG Fonts support needs it.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f1f4f840

WebCore: · 424f2336

andrew@webkit.org authored Jan 06, 2008

        Reviewed by Darin.
        
        DOMRange doesn't correctly re-size when inserting items (Acid3)
        http://bugs.webkit.org/show_bug.cgi?id=16764
        
        Update the offset for the range when inserting items into the range.

        Test: fast/dom/Range/range-modifycontents.html

        * dom/Range.cpp:
        (WebCore::Range::insertNode):

LayoutTests:

        Reviewed by Darin.
        
        DOMRange doesn't correctly re-size when inserting items (Acid3)
        http://bugs.webkit.org/show_bug.cgi?id=16764
        
        Update the offset for the range when inserting items into the range.

        * fast/dom/Range/range-modifycontents-expected.txt: Added.
        * fast/dom/Range/range-modifycontents.html: Added.
        * fast/dom/Range/resources/range-modifycontents.js: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

424f2336

Add missing expected result. · f2a10d24

weinig@apple.com authored Jan 06, 2008

        * fast/dom/TreeWalker/TreeWalker-currentNode-expected.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f2a10d24

Reviewed by darin. · b741b6c6

eric@webkit.org authored Jan 06, 2008

        Make attr selectors case-insensitive for certain HTML attributes
        http://bugs.webkit.org/show_bug.cgi?id=15470

        Test: fast/css/html-attr-case-sensitivity.html

        * css/CSSStyleSelector.cpp:
        (WebCore::addLocalNameToSet):
        (WebCore::createHtmlCaseInsensitiveAttributesSet):
        (WebCore::htmlAttributeHasCaseInsensitiveValue):
        (WebCore::CSSStyleSelector::checkOneSelector):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b741b6c6

Reviewed by Darin. · b9eec0ce

ap@webkit.org authored Jan 06, 2008

        http://bugs.webkit.org/show_bug.cgi?id=16731
        Incorrect node type for whitespace when setting innerHTML in an XHTML document

        Test: fast/dom/xhtml-fragment-whitespace.xhtml

        * dom/XMLTokenizer.cpp: (WebCore::parseXMLDocumentFragment):
        Use balancedCharactersHandler for ignorable whitespace.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b9eec0ce

Reviewed by Darin. · 0f33b066

ap@webkit.org authored Jan 06, 2008

        http://bugs.webkit.org/show_bug.cgi?id=16701
        <rdar://problem/5666580> REGRESSION: URL-encoded space (%20) in livejournal url
        causes page load error

        Test: http/tests/misc/location-with-space.php

        * platform/network/cf/ResourceRequestCFNet.cpp:
        (WebCore::ResourceRequest::doUpdatePlatformRequest): Do update its URL, too.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0f33b066

2008-01-06 Alp Toker <alp@atoker.com> · 79cf1ba4

alp@webkit.org authored Jan 06, 2008

        Reviewed by Mark Rowe.

        Use $(EXEEXT) to account for the .exe extension in the GTK+ Windows
        build. (This is already done correctly in DerivedSources.make.) Issue
        noticed by Mikkel when building in Cygwin.

        Add a missing slash. This was a hack from the qmake build system that
        isn't necessary with autotools.

        * GNUmakefile.am:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

79cf1ba4

Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests. · 2139a613

mrowe@apple.com authored Jan 06, 2008

Reviewed by Alp Toker.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(processWork): Process pending work.
(webViewLoadFinished): Schedule processing of pending work.
* DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2139a613

WebCore: · 4c9ad010

andrew@webkit.org authored Jan 06, 2008

        Reviewed by Darin.
        
        DOMRange.cloneContents does not work (Acid3 bug)
        http://bugs.webkit.org/show_bug.cgi?id=16748
        
        When cloning an empty range, return an empty DocmentFragment instead of
        null or undefined.

        Test: fast/dom/Range/range-clone-empty.html

        * dom/Range.cpp:
        (WebCore::Range::processContents):

LayoutTests:

        Reviewed by Darin.
        
        DOMRange.cloneContents does not work (Acid3 bug)
        http://bugs.webkit.org/show_bug.cgi?id=16748
        
        When cloning an empty range, return an empty DocmentFragment instead of
        null or undefined.

        * fast/dom/Range/range-clone-empty-expected.txt: Added.
        * fast/dom/Range/range-clone-empty.html: Added.
        * fast/dom/Range/resources/range-clone-empty.js: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4c9ad010

2008-01-06 Luca Bruno <lethalman88@gmail.com> · 98284980

alp@webkit.org authored Jan 06, 2008

        Reviewed by Alp Toker.

        Remove curl handles immediately if the timer is not running.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::cancel):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

98284980