1. 15 Nov, 2013 11 commits
    • timothy_horton@apple.com's avatar
      Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons · 0a9adbdb
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124399
      
      Reviewed by Gustavo Noronha Silva.
      
      Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
      with the icons adjusted to have solid backgrounds, to not be squished, and to not
      intersect the ring, similar to the Mac icons.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
      (documentReady.hideButton):
      (documentReady):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
      (table.queue-grid tr.platform.linux-gtk img.logo):
      (table.queue-grid tr.platform.linux-efl img.logo):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a9adbdb
    • commit-queue@webkit.org's avatar
      Fixed incorrectly placed NETWORK_PROCESS guard in NetworkConnectionToWebProcess.cpp · 002680e1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124398
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-15
      Reviewed by Brady Eidson.
      
      * NetworkProcess/NetworkConnectionToWebProcess.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      002680e1
    • stavila@adobe.com's avatar
      [CSS Regions] Implement visual overflow for first & last regions · 81613fc9
      stavila@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118665
      
      Source/WebCore:
      
      In order to properly propagate the visual overflow of elements flowed inside regions,
      the responsiblity of painting and hit-testing content inside flow threads has been
      moved to the flow thread layer's level.
      Each region keeps the associated overflow with each box in the RenderBoxRegionInfo
      structure, including one for the flow thread itself. This data is used during
      painting and hit-testing.
      
      Reviewed by David Hyatt.
      
      Tests: fast/regions/overflow-first-and-last-regions-in-container-hidden.html
             fast/regions/overflow-first-and-last-regions.html
             fast/regions/overflow-nested-regions.html
             fast/regions/overflow-region-float.html
             fast/regions/overflow-region-inline.html
             fast/regions/overflow-region-transform.html
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::setLayoutOverflow):
      (WebCore::InlineFlowBox::setVisualOverflow):
      * rendering/InlineFlowBox.h:
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::addOverflowFromChildren):
      (WebCore::RenderBlock::paint):
      (WebCore::RenderBlock::paintObject):
      (WebCore::RenderBlock::estimateRegionRangeForBoxChild):
      (WebCore::RenderBlock::updateRegionRangeForBoxChild):
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::hasNextPage):
      (WebCore::RenderBlockFlow::relayoutForPagination):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlockFlow::positionNewFloatOnLine):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::borderBoxRectInRegion):
      (WebCore::RenderBox::computeRectForRepaint):
      (WebCore::RenderBox::addLayoutOverflow):
      (WebCore::RenderBox::addVisualOverflow):
      (WebCore::RenderBox::isUnsplittableForPagination):
      (WebCore::RenderBox::overflowRectForPaintRejection):
      * rendering/RenderBox.h:
      (WebCore::RenderBox::canHaveOutsideRegionRange):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
      (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      * rendering/RenderBoxModelObject.h:
      * rendering/RenderBoxRegionInfo.h:
      (WebCore::RenderBoxRegionInfo::createOverflow):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::objectShouldPaintInFlowRegion):
      (WebCore::RenderFlowThread::mapFromLocalToFlowThread):
      (WebCore::RenderFlowThread::mapFromFlowThreadToLocal):
      (WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):
      (WebCore::RenderFlowThread::flipForWritingModeLocalCoordinates):
      (WebCore::RenderFlowThread::addRegionsOverflowFromChild):
      (WebCore::RenderFlowThread::addRegionsVisualOverflow):
      (WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
      * rendering/RenderFlowThread.h:
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateLayerPositions):
      (WebCore::expandClipRectForRegionAndReflection):
      (WebCore::expandClipRectForDescendantsAndReflection):
      (WebCore::RenderLayer::paintLayer):
      (WebCore::RenderLayer::paintLayerContents):
      (WebCore::RenderLayer::updatePaintingInfoForFragments):
      (WebCore::RenderLayer::paintForegroundForFragments):
      (WebCore::RenderLayer::hitTest):
      (WebCore::RenderLayer::hitTestLayer):
      (WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
      (WebCore::RenderLayer::calculateClipRects):
      (WebCore::RenderLayer::parentClipRects):
      (WebCore::RenderLayer::calculateRects):
      (WebCore::RenderLayer::intersectsDamageRect):
      (WebCore::RenderLayer::updateDescendantsLayerListsIfNeeded):
      (WebCore::RenderLayer::repaintIncludingDescendants):
      (WebCore::RenderLayer::paintNamedFlowThreadInsideRegion):
      (WebCore::RenderLayer::paintFlowThreadIfRegion):
      (WebCore::RenderLayer::hitTestFlowThreadIfRegion):
      * rendering/RenderLayer.h:
      (WebCore::ClipRect::inflateX):
      (WebCore::ClipRect::inflateY):
      (WebCore::ClipRect::inflate):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::computeCompositingRequirements):
      * rendering/RenderListItem.cpp:
      (WebCore::RenderListItem::addOverflowFromChildren):
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
      (WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
      * rendering/RenderMultiColumnSet.h:
      * rendering/RenderNamedFlowFragment.cpp:
      (WebCore::RenderNamedFlowFragment::createStyle):
      (WebCore::RenderNamedFlowFragment::namedFlowThread):
      * rendering/RenderNamedFlowFragment.h:
      * rendering/RenderOverflow.h:
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::flowThreadPortionOverflowRect):
      (WebCore::RenderRegion::flowThreadPortionLocation):
      (WebCore::RenderRegion::regionContainerLayer):
      (WebCore::RenderRegion::overflowRectForFlowThreadPortion):
      (WebCore::RenderRegion::computeOverflowFromFlowThread):
      (WebCore::RenderRegion::repaintFlowThreadContent):
      (WebCore::RenderRegion::repaintFlowThreadContentRectangle):
      (WebCore::RenderRegion::insertedIntoTree):
      (WebCore::RenderRegion::ensureOverflowForBox):
      (WebCore::RenderRegion::rectFlowPortionForBox):
      (WebCore::RenderRegion::addLayoutOverflowForBox):
      (WebCore::RenderRegion::addVisualOverflowForBox):
      (WebCore::RenderRegion::layoutOverflowRectForBox):
      (WebCore::RenderRegion::visualOverflowRectForBox):
      (WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):
      * rendering/RenderRegion.h:
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::shouldPaint):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::paint):
      
      LayoutTests:
      
      Rebased some tests due to regions layers changes.
      Updated some tests to increase clarity. Some of them were only passing because two
      regions were close together and the fact that an element was being painted
      inside the wrong region was not visible. Floats are now also unsplittable.
              - bottom-overflow-out-of-first-region
              - float-pushed-width-change-2
              - float-pushed-width-change
              - webkit-flow-float-unable-to-push
      
      Changed top-overflow-out-of-second-region to reftest.
      
      Added new tests for testing the visual overflow in different situations
      (transformed, inline, opacity, floating).
      
      Reviewed by David Hyatt.
      
      * fast/regions/bottom-overflow-out-of-first-region-expected.html:
      * fast/regions/bottom-overflow-out-of-first-region.html:
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html:
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html:
      * fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
      * fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
      * fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
      * fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
      * fast/regions/float-pushed-width-change-2-expected.html:
      * fast/regions/float-pushed-width-change-2.html:
      * fast/regions/float-pushed-width-change-expected.html:
      * fast/regions/float-pushed-width-change.html:
      * fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Added.
      * fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Added.
      * fast/regions/layers/regions-promoted-to-layers-expected.txt: Added.
      * fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Added.
      * fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Added.
      * fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Added.
      * fast/regions/outline-sides-in-region-expected.html:
      * fast/regions/outline-sides-in-region.html:
      * fast/regions/overflow-first-and-last-regions-expected.html: Added.
      * fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html: Added.
      * fast/regions/overflow-first-and-last-regions-in-container-hidden.html: Added.
      * fast/regions/overflow-first-and-last-regions.html: Added.
      * fast/regions/overflow-last-region-expected.html: Removed.
      * fast/regions/overflow-last-region.html: Removed.
      * fast/regions/overflow-nested-regions-expected.html: Added.
      * fast/regions/overflow-nested-regions.html: Added.
      * fast/regions/overflow-region-float-expected.html: Added.
      * fast/regions/overflow-region-float.html: Added.
      * fast/regions/overflow-region-inline-expected.html: Added.
      * fast/regions/overflow-region-inline.html: Added.
      * fast/regions/overflow-region-transform-expected.html: Added.
      * fast/regions/overflow-region-transform.html: Added.
      * fast/regions/overflow-scrollable-rotated-fragment-expected.html:
      * fast/regions/overflow-scrollable-rotated-fragment.html:
      * fast/regions/top-overflow-out-of-second-region-expected.html: Copied from LayoutTests/fast/regions/top-overflow-out-of-second-region.html.
      * fast/regions/top-overflow-out-of-second-region.html:
      * fast/regions/webkit-flow-float-unable-to-push-expected.html:
      * fast/regions/webkit-flow-float-unable-to-push.html:
      * platform/gtk/fast/regions/text-region-split-vertical-rl-expected.txt: Removed.
      * platform/mac-wk2/TestExpectations:
      * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
      * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81613fc9
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 6408b319
      m.pakula@samsung.com authored
      Update TestExpectations files with failing tests.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6408b319
    • commit-queue@webkit.org's avatar
      [GStreamer] Add support for Media Source API · 4ce17731
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99065
      
      Source/WebCore:
      
      The patch integrate a Media Source player for the GStreamer backend. The implementented architecture is:
      - MediaPlayerPrivateGStreamer engine is modified to support Media Source URIs (change blob:// to mediasourceblob://), in addition to the existing support for web (http/https/blob) URIs
      - Similar to the existing WebKitWebSrc gstreamer element that handles web URIs, a new gstreamer element named WebKitMediaSrc is implemented to handle Media Source URIs
      - WebKitMediaSrc registers its URI protocol handler, allowing uridecodebin to dynamically create the appropriate source element.
      - The WebKitMediaSrc element creates a bin with 2 appsrc: One for Audio and One for Video. Pads are dynamically linked at the reception of first video and audio buffers.
      
      Patch by Stephane Jadaud <sjadaud@sii.fr> on 2013-11-15
      Reviewed by Philippe Normand.
      
      Tests: Activate http/tests/media/media-source and media/media-source tests
      
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::initializeGStreamerAndRegisterWebKitElements):
      (WebCore::MediaPlayerPrivateGStreamer::load):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
      * platform/graphics/gstreamer/MediaSourceGStreamer.cpp: Added.
      (WebCore::MediaSourceGStreamer::open):
      (WebCore::MediaSourceGStreamer::MediaSourceGStreamer):
      (WebCore::MediaSourceGStreamer::~MediaSourceGStreamer):
      (WebCore::MediaSourceGStreamer::addSourceBuffer):
      (WebCore::MediaSourceGStreamer::setDuration):
      (WebCore::MediaSourceGStreamer::markEndOfStream):
      (WebCore::MediaSourceGStreamer::unmarkEndOfStream):
      * platform/graphics/gstreamer/MediaSourceGStreamer.h: Added.
      * platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp: Added.
      (WebCore::SourceBufferPrivateGStreamer::SourceBufferPrivateGStreamer):
      (WebCore::SourceBufferPrivateGStreamer::append):
      (WebCore::SourceBufferPrivateGStreamer::abort):
      (WebCore::SourceBufferPrivateGStreamer::removedFromMediaSource):
      * platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h: Added.
      * platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp: Added.
      (webKitMediaSrcAddSrc):
      (webkit_media_src_init):
      (webKitMediaSrcFinalize):
      (webKitMediaSrcSetProperty):
      (webKitMediaSrcGetProperty):
      (webKitMediaVideoSrcStop):
      (webKitMediaAudioSrcStop):
      (webKitMediaVideoSrcStart):
      (webKitMediaAudioSrcStart):
      (webKitMediaSrcChangeState):
      (webKitMediaSrcQueryWithParent):
      (webKitMediaSrcUriGetType):
      (webKitMediaSrcGetProtocols):
      (webKitMediaSrcGetUri):
      (webKitMediaSrcSetUri):
      (webKitMediaSrcUriHandlerInit):
      (webKitMediaVideoSrcNeedDataMainCb):
      (webKitMediaAudioSrcNeedDataMainCb):
      (webKitMediaVideoSrcNeedDataCb):
      (webKitMediaAudioSrcNeedDataCb):
      (webKitMediaVideoSrcEnoughDataMainCb):
      (webKitMediaAudioSrcEnoughDataMainCb):
      (webKitMediaVideoSrcEnoughDataCb):
      (webKitMediaAudioSrcEnoughDataCb):
      (webKitMediaVideoSrcSeekMainCb):
      (webKitMediaAudioSrcSeekMainCb):
      (webKitMediaVideoSrcSeekDataCb):
      (webKitMediaAudioSrcSeekDataCb):
      (webKitMediaSrcSetMediaPlayer):
      (webKitMediaSrcSetPlayBin):
      (MediaSourceClientGstreamer::MediaSourceClientGstreamer):
      (MediaSourceClientGstreamer::~MediaSourceClientGstreamer):
      (MediaSourceClientGstreamer::didReceiveDuration):
      (MediaSourceClientGstreamer::didReceiveData):
      (MediaSourceClientGstreamer::didFinishLoading):
      (MediaSourceClientGstreamer::didFail):
      * platform/graphics/gstreamer/WebKitMediaSourceGStreamer.h: Added.
      
      Tools:
      
      Patch by Stephane Jadaud <sjadaud@sii.fr> on 2013-11-15
      Reviewed by Philippe Normand.
      
      * Scripts/webkitperl/FeatureList.pm:
      
      LayoutTests:
      
      Patch by Stephane Jadaud <sjadaud@sii.fr> on 2013-11-15
      Reviewed by Philippe Normand.
      
      * platform/gtk/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ce17731
    • berto@igalia.com's avatar
      [EFL] Leak in ewk_frame_certificate_status_get() · 17edd465
      berto@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124401
      
      Reviewed by Carlos Garcia Campos.
      
      The SoupMessage object is being leaked. In in this case that
      object is not even necessary since ResourceRequest already
      provides a way to get the soup flags directly.
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_certificate_status_get):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17edd465
    • ossy@webkit.org's avatar
      Cleanup the build from unused parameters in WebKit2 · ba99c3ca
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124201
      
      Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-15
      Reviewed by Darin Adler.
      
      * Shared/Plugins/Netscape/PluginInformation.cpp:
      (WebKit::getPluginModuleInformation):
      * UIProcess/API/C/WKBatteryManager.cpp:
      (WKBatteryManagerSetProvider):
      (WKBatteryManagerProviderDidChangeBatteryStatus):
      (WKBatteryManagerProviderUpdateBatteryStatus):
      * UIProcess/API/C/WKBatteryStatus.cpp:
      (WKBatteryStatusCreate):
      * UIProcess/API/C/WKColorPickerResultListener.cpp:
      (WKColorPickerResultListenerSetColor):
      * UIProcess/API/C/WKContext.cpp:
      (WKContextGetBatteryManager):
      (WKContextGetDatabaseManager):
      (WKContextGetNetworkInfoManager):
      * UIProcess/API/C/WKDatabaseManager.cpp:
      (WKDatabaseManagerSetClient):
      (WKDatabaseManagerGetDatabasesByOrigin):
      (WKDatabaseManagerGetDatabaseOrigins):
      (WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
      (WKDatabaseManagerDeleteDatabasesForOrigin):
      (WKDatabaseManagerDeleteAllDatabases):
      (WKDatabaseManagerSetQuotaForOrigin):
      * UIProcess/API/C/WKNetworkInfo.cpp:
      (WKNetworkInfoCreate):
      * UIProcess/API/C/WKNetworkInfoManager.cpp:
      (WKNetworkInfoManagerSetProvider):
      (WKNetworkInfoManagerProviderDidChangeNetworkInformation):
      * UIProcess/API/C/WKOpenPanelParameters.cpp:
      (WKOpenPanelParametersCopyCapture):
      * UIProcess/API/C/WKVibration.cpp:
      (WKVibrationSetProvider):
      * UIProcess/API/efl/EwkView.cpp:
      (EwkView::createNewPage):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::setVisibilityState):
      (WebKit::WebPageProxy::unavailablePluginButtonClicked):
      * UIProcess/efl/ViewClientEfl.cpp:
      (WebKit::ViewClientEfl::didChangeContentsPosition):
      (WebKit::ViewClientEfl::didRenderFrame):
      (WebKit::ViewClientEfl::didChangeViewportAttributes):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setDatabaseQuota):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::createWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba99c3ca
    • graouts@apple.com's avatar
      Web Inspector: New color picker · d26f595c
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124354
      
      Reviewed by Timothy Hatcher.
      
      Beginning of a new color picker. The focus of this new picker is to let you pick from
      a color wheel as the primary mean of color picking, with additional slider controls for
      the brightness and the opacity, better matching the default OS X color picker. This is the
      basis for a color picker that will evolve to support the following:
      
      - editable CSS value label (http://webkit.org/b/124356)
      - picking a color anywhere on screen (http://webkit.org/b/124357)
      - swatches based on other colors in page (http://webkit.org/b/124358)
      
      Note also that the color wheel has not been tested on Retina displays
      (see http://webkit.org/b/124355).
      
      * UserInterface/CSSColorPicker.css: Removed.
      * UserInterface/CSSColorPicker.js: Removed.
      Previous color picker, now removed in favor of the new ColorPicker class.
      
      * UserInterface/CSSStyleDeclarationTextEditor.js:
      Adopt new class name for the color picker, add a little padding to the popover
      target frame and set the base color after the picker has been presented.
      
      * UserInterface/Color.js:
      (WebInspector.Color.prototype._hslToRGB):
      Simplified math.
      
      (WebInspector.Color.rgb2hsv):
      (WebInspector.Color.hsv2rgb):
      New utilities to deal with HSV colors used in the ColorWheel.
      
      * UserInterface/ColorPicker.css: Added.
      
      * UserInterface/ColorPicker.js: Added.
      (WebInspector.ColorPicker):
      (WebInspector.ColorPicker.prototype.get element):
      (WebInspector.ColorPicker.prototype.set brightness):
      (WebInspector.ColorPicker.prototype.set opacity):
      (WebInspector.ColorPicker.prototype.get color):
      
      (WebInspector.ColorPicker.prototype.set color):
      We set the _dontUpdateColor flag here such that we don't attempt to
      notify about a color change at this point in case the selected color
      is too saturated to be represented accurately on the color wheel and
      we would end up changing the color by virtue of presenting the popover.
      
      (WebInspector.ColorPicker.prototype.colorWheelColorDidChange):
      (WebInspector.ColorPicker.prototype.sliderValueDidChange):
      (WebInspector.ColorPicker.prototype._updateColor):
      (WebInspector.ColorPicker.prototype._updateSliders):
      
      * UserInterface/ColorWheel.css: Added.
      
      * UserInterface/ColorWheel.js: Added.
      The ColorWheel makes use of three different <canvas> elements to draw itself.
      The "raw" canvas is used to draw the raw, un-tinted color wheel with poor
      aliasing. The "raw" canvas is only drawn when the dimension is changed.
      The "tinted" canvas is used to draw the "raw" canvas with a black overlay
      based on the brightness set on the wheel. The "final" canvas, the only <canvas>
      element attached to the DOM, is used to draw the "tinted" canvas into a circle
      clip of a slightly narrower radius so that the drawn image is visually more pleasing
      and can be displayed above virtually any background color.
      
      We use color math to generate the color wheel, courtesy of Dean Jackson, and also to
      figure out where to position the crosshair for the provided base color as well as
      the opposite operation where we get the color under the mouse pointer.
      
      The color wheel fires a single delegate method call colorWheelColorDidChange(colorWheel),
      the colors themselves being retrieved via the public properties tintedColor and rawColor.
      
      (WebInspector.ColorWheel):
      (WebInspector.ColorWheel.prototype.set dimension):
      (WebInspector.ColorWheel.prototype.get element):
      (WebInspector.ColorWheel.prototype.get brightness):
      (WebInspector.ColorWheel.prototype.set brightness):
      (WebInspector.ColorWheel.prototype.get tintedColor):
      (WebInspector.ColorWheel.prototype.set tintedColor):
      (WebInspector.ColorWheel.prototype.get rawColor):
      (WebInspector.ColorWheel.prototype.handleEvent):
      (WebInspector.ColorWheel.prototype._handleMousedown):
      (WebInspector.ColorWheel.prototype._handleMousemove):
      (WebInspector.ColorWheel.prototype._handleMouseup):
      (WebInspector.ColorWheel.prototype._pointInCircleForEvent):
      (WebInspector.ColorWheel.prototype._pointInCircleForEvent.angleFromCenterToPoint):
      (WebInspector.ColorWheel.prototype._pointInCircleForEvent.pointOnCircumference):
      (WebInspector.ColorWheel.prototype._updateColorForMouseEvent):
      (WebInspector.ColorWheel.prototype._setCrosshairPosition):
      (WebInspector.ColorWheel.prototype._tintedColorToPointAndBrightness):
      (WebInspector.ColorWheel.prototype._drawRawCanvas):
      (WebInspector.ColorWheel.prototype._colorAtPointWithBrightness):
      (WebInspector.ColorWheel.prototype._drawTintedCanvas):
      (WebInspector.ColorWheel.prototype._draw):
      
      * UserInterface/Images/SliderThumb.png: Added.
      * UserInterface/Images/SliderThumb@2x.png: Added.
      * UserInterface/Images/SliderThumbPressed.png: Added.
      * UserInterface/Images/SliderThumbPressed@2x.png: Added.
      Supporting artwork for the new Slider class.
      
      * UserInterface/Main.html:
      Remove the previous color picker class and add the new one, as well as the new Slider class.
      
      * UserInterface/Slider.css: Added.
      
      * UserInterface/Slider.js: Added.
      New slider to match the look of the sliders used in the native OS X color picker. The most
      interesting feature of these sliders is that they can be transformed using CSS in any way
      and will still operate correctly due to always converting the mouse coordinates in the page
      coordinate system to the coordinate system local to the backing element. For instance, the
      color picker uses two sliders transformed to be displayed vertically.
      
      As it stands these slides only support values between 0 and 1 and fire a single delegate
      method call sliderValueDidChange(slider, newValue).
      
      (WebInspector.Slider):
      (WebInspector.Slider.prototype.get element):
      (WebInspector.Slider.prototype.get value):
      (WebInspector.Slider.prototype.set value):
      (WebInspector.Slider.prototype.handleEvent):
      (WebInspector.Slider.prototype._handleMousedown):
      (WebInspector.Slider.prototype._handleMousemove):
      (WebInspector.Slider.prototype._handleMouseup):
      (WebInspector.Slider.prototype._localPointForEvent):
      (WebInspector.Slider.prototype.get _maxX):
      
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
      Update file names for the new color picker.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d26f595c
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · eda0878f
      m.pakula@samsung.com authored
      Mark flaky and incorrectly passing tests.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Removed wrong test expectation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eda0878f
    • calvaris@igalia.com's avatar
      [GTK] Bumping GStreamer version to 1.2.1 for the dependencies · edbc9d25
      calvaris@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124360
      
      Reviewed by Philippe Normand.
      
      Tools:
      
      * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
      
      LayoutTests:
      
      * platform/gtk/TestExpectations: Flagged
      media/video-canvas-drawing-output.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edbc9d25
    • commit-queue@webkit.org's avatar
      [EFL] Layout tests with international text properties need to be rebaselined. · 3608dfdd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124389
      
      Unreviewed, EFL rabaseline.
      
      EFL international text rebaselined after r147668.
      Move some expectation files to efl common place because those files in wk1 are
      in exact accordance with files in wk2, and then delete the files in wk1 and wk2.
      
      Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-15
      
      * platform/efl-wk1/fast/text/international/003-expected.txt: Removed.
      * platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
      * platform/efl-wk2/TestExpectations:
      * platform/efl/fast/text/international/002-expected.txt:
      * platform/efl/fast/text/international/003-expected.txt:
      Renamed from LayoutTests/platform/efl-wk2/fast/text/international/003-expected.txt.
      * platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt:
      Renamed from LayoutTests/platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3608dfdd
  2. 14 Nov, 2013 29 commits
    • bfulgham@apple.com's avatar
      [Win] Improve support for command line builds of 64-bit JSC · 4afad6e5
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124380
      
      Patch by Brent Fulgham <bfulgham@apple.com> on 2013-11-14
      Reviewed by David Kilzer.
      
      * Scripts/webkitdirs.pm:
      (argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
      'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
      (determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
      what the "$configurationForVisualStudio" value is for.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4afad6e5
    • ap@apple.com's avatar
      Update WebCrypto tests · df32d58c
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124388
      
      Reviewed by Anders Carlsson.
      
      Updated tests for newer common.js. Changed some tests from just dumping results
      to comparing them to known expected ones. Fixed a syntax error in
      aes-cbc-invalid-length.html, so it now actually runs.
      
      * crypto/subtle/resources/common.js: Update to a new version from Blink, because
      it's much nicer than the old one, and it's good to be compatible at test level.
      Moved crypto.subtle definition from webkitSubtle here to avoid repeating it in all
      tests. Added a quick and dirty Promise.all implementation.
      
      * crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-192-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-256-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
      * crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html:
      * crypto/subtle/aes-cbc-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-generate-key.html:
      * crypto/subtle/aes-cbc-import-jwk-expected.txt:
      * crypto/subtle/aes-cbc-import-jwk.html:
      * crypto/subtle/aes-cbc-invalid-length-expected.txt:
      * crypto/subtle/aes-cbc-invalid-length.html:
      * crypto/subtle/aes-cbc-wrong-key-class.html:
      * crypto/subtle/aes-export-key-expected.txt:
      * crypto/subtle/aes-export-key.html:
      * crypto/subtle/argument-conversion-expected.txt:
      * crypto/subtle/argument-conversion.html:
      * crypto/subtle/hmac-export-key-expected.txt:
      * crypto/subtle/hmac-export-key.html:
      * crypto/subtle/hmac-generate-key.html:
      * crypto/subtle/hmac-import-jwk-expected.txt:
      * crypto/subtle/hmac-import-jwk.html:
      * crypto/subtle/hmac-sign-verify-empty-key-expected.txt:
      * crypto/subtle/hmac-sign-verify-empty-key.html:
      * crypto/subtle/hmac-sign-verify-expected.txt:
      * crypto/subtle/hmac-sign-verify.html:
      * crypto/subtle/import-jwk-expected.txt:
      * crypto/subtle/import-jwk.html:
      * crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt:
      * crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html:
      * crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt:
      * crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html:
      * crypto/subtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt:
      * crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html:
      * crypto/subtle/sha-1-expected.txt:
      * crypto/subtle/sha-1.html:
      * crypto/subtle/sha-224-expected.txt:
      * crypto/subtle/sha-224.html:
      * crypto/subtle/sha-256-expected.txt:
      * crypto/subtle/sha-256.html:
      * crypto/subtle/sha-384-expected.txt:
      * crypto/subtle/sha-384.html:
      * crypto/subtle/sha-512-expected.txt:
      * crypto/subtle/sha-512.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df32d58c
    • commit-queue@webkit.org's avatar
      XMLSerializer escapes < > & correctly inside <script> and <style> tags. · d9eb969a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123914
      
      Patch by Victor Costan <costan@gmail.com> on 2013-11-14
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Test: fast/dom/XMLSerializer-entities.html
      
      * editing/MarkupAccumulator.cpp:
      (WebCore::MarkupAccumulator::serializeNodesWithNamespaces): vim removed some whitespace.
      (WebCore::MarkupAccumulator::entityMaskForText): Fixed the returned value for <script> etc in XML.
      
      LayoutTests:
      
      * fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: fix incorrect expectations.
      * fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml: use CDATA consistently.
      * fast/dom/XMLSerializer-entities-expected.txt: Added.
      * fast/dom/XMLSerializer-entities.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9eb969a
    • bjonesbe@adobe.com's avatar
      ASSERTION FAILED:... · 40a09c02
      bjonesbe@adobe.com authored
      ASSERTION FAILED: rangesIntersect(m_renderer.pixelSnappedLogicalTopForFloat(floatingObject), m_renderer.pixelSnappedLogicalBottomForFloat(floatingObject), m_lineTop, m_lineBottom) ../../Source/WebCore/rendering/FloatingObjects.cpp(463)
      https://bugs.webkit.org/show_bug.cgi?id=124375
      
      Reviewed by Alexandru Chiculita.
      
      When moving the placed floats tree over to LayoutUnit, I forgot to
      update these asserts, which causes issues on ports with subpixel
      layout enabled.
      
      No new tests, no behavior change.
      
      * rendering/FloatingObjects.cpp:
      (WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
      (WebCore::::collectIfNeeded):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40a09c02
    • commit-queue@webkit.org's avatar
      Clean up sequence handling in Blob constructor · 933bf408
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124343
      
      Patch by Victor Costan <costan@gmail.com> on 2013-11-14
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      Added test case to LayoutTests/fast/files/blob-constructor.html
      
      * bindings/js/JSBlobCustom.cpp:
      (WebCore::JSBlobConstructor::constructJSBlob):
          Handle exceptions in sequences, eliminate double type-checking for
          ArrayBuffer, ArrayBufferView and Blob parts.
      
      LayoutTests:
      
      * fast/files/blob-constructor-expected.txt:
      * fast/files/script-tests/blob-constructor.js:
          Add test with sequence that throws an error on property access.
      (get Object):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      933bf408
    • mitz@apple.com's avatar
      [Cocoa] WKBrowsingContextController's policy client implementation... · d40e29d9
      mitz@apple.com authored
      [Cocoa] WKBrowsingContextController's policy client implementation over-releases WKURLRequests and WKURLResponses
      https://bugs.webkit.org/show_bug.cgi?id=124386
      
      Reviewed by Sam Weinig.
      
      * UIProcess/API/mac/WKBrowsingContextController.mm:
      (setUpPagePolicyClient): Changed to release the Cocoa objects we copy out of the WK objects
      passed into the client callbacks, but not the WK objects themselves, which are not owned by
      the callbacks.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d40e29d9
    • oliver@apple.com's avatar
      Make CLoop easier to build, and make it work · 7c1eb76c
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124359
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      Add --cloop to build-jsc, build-webkit and friends.
      
      Also make CLoop build and work again - This meant adding a
      couple of missing ENABLE(DFG_JIT) blocks, and fixing a few
      other references.
      
      * Configurations/FeatureDefines.xcconfig:
      * bytecode/BytecodeLivenessAnalysis.cpp:
      (JSC::computeUsesForBytecodeOffset):
      (JSC::computeDefsForBytecodeOffset):
      * bytecode/DFGExitProfile.cpp:
      * dfg/DFGCapabilities.cpp:
      * dfg/DFGCompilationKey.cpp:
      * dfg/DFGCompilationMode.cpp:
      * jit/JITExceptions.cpp:
      (JSC::genericUnwind):
      
      Source/WebCore:
      
      Add cloop configuration info to WebCore FeatureDefines
      so that it's consistent with JSC
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WTF:
      
      Make building with the CLoop forcibly enabled manually
      disable the JITs
      
      * wtf/Platform.h:
      
      Tools:
      
      Add --cloop support to forcibly enable to CLoop build
      
      * Scripts/build-jsc:
      * Scripts/build-webkit:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c1eb76c
    • aestes@apple.com's avatar
      Replace calls to deprecated CFPropertyList functions in WebKit2 · 0948cfb1
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124384
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/cf/WebPageProxyCF.cpp:
      (WebKit::WebPageProxy::sessionStateData): Replaced CFPropertyListWriteToStream() with CFPropertyListWrite().
      (WebKit::WebPageProxy::restoreFromSessionStateData): Replaced CFPropertyListCreateFromXMLData() with CFPropertyListCreateWithData().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0948cfb1
    • timothy_horton@apple.com's avatar
      Change Fail->Failure in some recent expectations. · 16cf6054
      timothy_horton@apple.com authored
      Suddenly, everything is clear.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16cf6054
    • lforschler@apple.com's avatar
      Add webkit slave. · a3af40cb
      lforschler@apple.com authored
      Unreviewed.
      
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3af40cb
    • timothy_horton@apple.com's avatar
      http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow,... · 650c6280
      timothy_horton@apple.com authored
      http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, frequently > 30 second timeout
      https://bugs.webkit.org/show_bug.cgi?id=124373
      
      * platform/mac/TestExpectations:
      Mark test as flaky on Mountain Lion Release bot.
      Marking as slow seems to have no effect on the notifyDone timeout, just the outer timeouts.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      650c6280
    • commit-queue@webkit.org's avatar
      [Cairo] Avoid extra copy when drawing images · b4822a07
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124209
      
      Patch by Aloisio Almeida Jr <aloisio.almeida@openbossa.org> on 2013-11-14
      Reviewed by Martin Robinson.
      
      To solve the bug #58309 a cairo subsurface is being used to limit the
      source image boundaries.
      In many cases, when a cairo subsurface is used for drawing an image,
      it occurs an image copy, causing performance penalty. In the case of
      the function PlatformContextCairo::drawSurfaceToContext, the image
      copy always happens.
      So, we should use the subsurface only when it's really necessary.
      In cases where we're drawing the whole image, the subsurface is
      unnecessary.
      
      The proposed patch avoid the use of subsurfaces when sampling the whole
      image.
      
      No new tests. It's an enhancement. Already covered by existing tests.
      
      * platform/graphics/cairo/PlatformContextCairo.cpp:
      (WebCore::PlatformContextCairo::drawSurfaceToContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4822a07
    • timothy_horton@apple.com's avatar
      build.webkit.org/dashboard can’t open different results in two new tabs · ce8889fb
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124383
      
      Reviewed by Alexey Proskuryakov.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
      (BuildbotQueueView.prototype.revisionLinksForIteration):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
      (StatusLineView.prototype._clicked):
      Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
      real pseudo-target and instead acts as a named target and will end up causing all link clicks
      to open in the same secondary tab).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce8889fb
    • commit-queue@webkit.org's avatar
      generate-message-receiver.py can't handle nested #ifs · 94dae52d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121877
      
      Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-11-14
      Reviewed by Darin Adler.
      
      parser.py was modifieded to collect and combine conditions of nested #ifs.
      messages_unittest.py extended to check these modifications.
      
      * Scripts/webkit2/messages_unittest.py:
      (LoadSomething):
      (std):
      (AddEvent):
      (LoadSomethingElse):
      * Scripts/webkit2/parser.py:
      (combine_condition):
      (bracket_if_needed):
      (parse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94dae52d
    • andersca@apple.com's avatar
      Reimplement getDayBoundaries using NSCalendar on 10.9 · 0fd28da9
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124379
      
      Reviewed by Dan Bernstein.
      
      * History/WebHistory.mm:
      (getDayBoundaries):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fd28da9
    • ap@apple.com's avatar
      Implement raw format for WebCrypto key export · 32fdefdd
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124376
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Tests: crypto/subtle/aes-export-key.html
             crypto/subtle/hmac-export-key.html
      
      A CryptoKey just exports its native CryptoKeyData, which will also work nicely for
      JWK format soon. For spki and pkcs8, we'll need to figure out the best way to
      utilize platform library support for ASN.1, but we are not there yet.
      
      * bindings/js/JSSubtleCryptoCustom.cpp:
      (WebCore::JSSubtleCrypto::exportKey):
      * crypto/CryptoKey.h:
      * crypto/SubtleCrypto.idl:
      * crypto/keys/CryptoKeyAES.cpp:
      (WebCore::CryptoKeyAES::exportData):
      * crypto/keys/CryptoKeyAES.h:
      * crypto/keys/CryptoKeyHMAC.cpp:
      (WebCore::CryptoKeyHMAC::exportData):
      * crypto/keys/CryptoKeyHMAC.h:
      
      * crypto/keys/CryptoKeyRSA.h:
      * crypto/mac/CryptoKeyRSAMac.cpp:
      (WebCore::CryptoKeyRSA::exportData):
      Added a dummy implementation for RSA.
      
      LayoutTests: 
      
      * crypto/subtle/aes-export-key-expected.txt: Added.
      * crypto/subtle/aes-export-key.html: Added.
      * crypto/subtle/hmac-export-key-expected.txt: Added.
      * crypto/subtle/hmac-export-key.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32fdefdd
    • mitz@apple.com's avatar
      [Cocoa] WKAction keys are not exported · 4617b9e6
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124378
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/API/mac/WKBrowsingContextController.mm: Made the keys constant pointers.
      * UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Exported the keys.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4617b9e6
    • commit-queue@webkit.org's avatar
      Web Inspector: Simply generated domain dispatch methods for domains with few commands · 416e3e9d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124374
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-11-14
      Reviewed by Timothy Hatcher.
      
      * inspector/CodeGeneratorInspector.py:
      (Generator.go):
      (Generator.process_command):
      * inspector/CodeGeneratorInspectorStrings.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      416e3e9d
    • betravis@adobe.com's avatar
      [CSS Shapes] Accept the new <box> value for shape-outside · edfb6516
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124227
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      The shape-outside property can now be set to the box values [margin/border/padding/content]-box.
      This patch adds the parsing code required to accept the new values, and the layout code
      to create a rectangle shape that has the size and position of the appropriate box.
      
      Tests: fast/shapes/shape-outside-floats/shape-outside-boxes-001.html
             fast/shapes/shape-outside-floats/shape-outside-boxes-002.html
             fast/shapes/shape-outside-floats/shape-outside-boxes-003.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::ComputedStyleExtractor::propertyValue): Output the new box values.
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue): Accept the new box values.
      * css/CSSValueKeywords.in: Add margin-box value.
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::ApplyPropertyShape::applyValue): Accept the new box values.
      * rendering/RenderBoxModelObject.h:
      (WebCore::RenderBoxModelObject::borderLogicalWidth): Added new utility methods to help
      with box sizing.
      (WebCore::RenderBoxModelObject::borderLogicalHeight): Ditto.
      (WebCore::RenderBoxModelObject::paddingLogicalWidth): Ditto.
      (WebCore::RenderBoxModelObject::paddingLogicalHeight): Ditto.
      * rendering/shapes/Shape.cpp:
      (WebCore::Shape::createShape): You can create a shape from a box's dimensions, rather
      than always using a BasicShape or RasterShape value.
      * rendering/shapes/Shape.h:
      * rendering/shapes/ShapeInfo.cpp:
      (WebCore::::computedShape): Create the appropriate shape based on the box values.
      * rendering/shapes/ShapeInfo.h:
      (WebCore::ShapeInfo::setShapeSize): Adjust for the box size when using a box value.
      (WebCore::ShapeInfo::logicalTopOffset): Ditto.
      (WebCore::ShapeInfo::logicalLeftOffset): Ditto.
      * rendering/shapes/ShapeInsideInfo.cpp:
      (WebCore::ShapeInsideInfo::isEnabledFor): Enable for the box values.
      * rendering/shapes/ShapeOutsideInfo.cpp:
      (WebCore::ShapeOutsideInfo::isEnabledFor): Disable for shape-inside.
      * rendering/style/ShapeValue.h:
      (WebCore::ShapeValue::createBoxValue): Create the appropriate shape value for a box.
      (WebCore::ShapeValue::box): Return the box value for this ShapeValue.
      (WebCore::ShapeValue::ShapeValue): Create a ShapeValue from a box value.
      
      LayoutTests:
      
      Test the different box values with different writing modes.
      
      * fast/shapes/parsing/parsing-shape-inside-expected.html: Adding box values as invalid.
      * fast/shapes/parsing/parsing-shape-inside.html: Ditto.
      * fast/shapes/parsing/parsing-shape-outside-expected.html: Adding box values as valid.
      * fast/shapes/parsing/parsing-shape-outside.html: Ditto.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-001-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-001.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-002-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-002.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-003-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-boxes-003.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edfb6516
    • jer.noble@apple.com's avatar
      Flaky Test: media/video-fast-seek.html · 61593d79
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124298
      
      Reviewed by Eric Carlson.
      
      Don't check for the precise results of currentTime, as MediaTime -> double
      rounding will occasionally result in errors.
      
      * media/video-fast-seek-expected.txt:
      * media/video-fast-seek.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61593d79
    • andersca@apple.com's avatar
      Stop using deprecated NSPropertyListSerialization methods · 831bbe53
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124377
      
      Reviewed by Mark Rowe.
      
      * History/WebHistory.mm:
      (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
      * Plugins/Hosted/NetscapePluginHostManager.mm:
      (WebKit::NetscapePluginHostManager::spawnPluginHost):
      (WebKit::NetscapePluginHostManager::instantiatePlugin):
      * Plugins/Hosted/NetscapePluginHostProxy.mm:
      (WKPCIdentifierInfo):
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::enumerate):
      (WebKit::NetscapePluginInstanceProxy::marshalValue):
      (WebKit::NetscapePluginInstanceProxy::marshalValues):
      (WebKit::NetscapePluginInstanceProxy::demarshalValue):
      (WebKit::NetscapePluginInstanceProxy::demarshalValues):
      * Plugins/Hosted/ProxyInstance.mm:
      (WebKit::ProxyInstance::getPropertyNames):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      831bbe53
    • timothy_horton@apple.com's avatar
      fullscreen/anonymous-block-merge-crash.html often times out in WebKit1 · f6b179b7
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124318
      
      * platform/mac/TestExpectations:
      Used the wrong kind of failure for a notifyDone timeout.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6b179b7
    • bdakin@apple.com's avatar
      Rubber-stamped by Tim Horton. · 079d6fd7
      bdakin@apple.com authored
      Post-checkin review comment! StickToViewportBounds sounds better and more accurate 
      than StickToWindowBounds.
      
      * platform/ScrollTypes.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      079d6fd7
    • bfulgham@apple.com's avatar
      Unreviewed build failure; update MediaPlayerPrivateAVFFoundationCF::seekToTime after r159208. · 4d1ad22f
      bfulgham@apple.com authored
      After r159208, seekToTime takes tolerance parameters.
      
      Patch by Jer Noble <jer.noble@apple.com> on 2013-11-13
      
      * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
      (WebCore::MediaPlayerPrivateAVFoundationCF::seekToTime):
      (WebCore::AVFWrapper::seekToTime):
      * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d1ad22f
    • timothy_horton@apple.com's avatar
      http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow,... · 7cfe8de7
      timothy_horton@apple.com authored
      http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, frequently > 30 second timeout
      https://bugs.webkit.org/show_bug.cgi?id=124373
      
      * platform/mac/TestExpectations:
      Mark test as slow on Mountain Lion Release bot.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cfe8de7
    • bdakin@apple.com's avatar
      Add a new mode where fixed elements don't constrain their positions during a · 817d70e7
      bdakin@apple.com authored
      rubber band
      https://bugs.webkit.org/show_bug.cgi?id=124260
      
      Reviewed by Tim Horton.
      
      This patch adds a new enum called ScrollBehaviorForFixedElements, which has
      two values, StickToDocumentBounds or StickToWindowBounds. StickToDocumentBounds 
      corresponds to our current behavior, where fixed elements constrain 
      their positions during a rubber-band so that they stay stuck to the document.
      The new mode, StickToWindowBounds, will cause fixed elements to always stay
      fixed relative to the window.
      
      scrollOffsetForFixedPosition() now takes a new parameter for the fixed behavior
      so that it knows whether or not to constrain the position.
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollOffsetForFixedPosition):
              
      Right now, just return StickToDocumentBounds and retain existing behavior.
      (WebCore::FrameView::scrollBehaviorForFixedElements):
      * page/FrameView.h:
      
      The scrolling thread needs to know about the fixed element scroll behavior,
      so this code makes ScrollingStateScrollingNodes keep track of that 
      information to pass over to the scrolling thread.
      * page/scrolling/ScrollingStateScrollingNode.cpp:
      (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
      (WebCore::ScrollingStateScrollingNode::setScrollBehaviorForFixedElements):
      * page/scrolling/ScrollingStateScrollingNode.h:
      * page/scrolling/ScrollingTreeScrollingNode.cpp:
      (WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
      (WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
      * page/scrolling/ScrollingTreeScrollingNode.h:
      (WebCore::ScrollingTreeScrollingNode::scrollBehaviorForFixedElements):
      * page/scrolling/mac/ScrollingCoordinatorMac.h:
      * page/scrolling/mac/ScrollingCoordinatorMac.mm:
      (WebCore::ScrollingCoordinatorMac::frameViewRootLayerDidChange):
      (WebCore::ScrollingCoordinatorMac::setScrollBehaviorForFixedElementsForNode):
      * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
      (WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
              
      Here is the new enum.
      * platform/ScrollTypes.h:
              
      Another place where we only want to constrain scroll position if that is the
      mode we are in.
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::customPositionForVisibleRectComputation):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      817d70e7
    • ap@apple.com's avatar
      [Mac] HMAC sign/verify crashes when key is empty · 46bab23a
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124372
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      Test: crypto/subtle/hmac-sign-verify-empty-key.html
      
      * crypto/mac/CryptoAlgorithmHMACMac.cpp: (WebCore::calculateSignature): Give it
      a non-null pointer then.
      
      LayoutTests: 
      
      * crypto/subtle/hmac-sign-verify-empty-key-expected.txt: Added.
      * crypto/subtle/hmac-sign-verify-empty-key.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46bab23a
    • msaboff@apple.com's avatar
      REGRESSION (r159276): Fix lots of crashes for arm_traditional architecture. · f4bf72dc
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124365
      
      Reviewed by Oliver Hunt.
      
      Crashes were caused by a mixup between regular registers and temporary registers in ARM_EXTRA_GPRS.
      
      * llint/LowLevelInterpreter32_64.asm: Warning, t3 != a3. It's safer to use an implementation using aX
      registers like the MIPS one for cCallX macros.
      * offlineasm/arm.rb: Rearrange ARM_EXTRA_GPRS according to the new register distribution in LLINT.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4bf72dc
    • andersca@apple.com's avatar
      Remove duplicate entry. · 4986631c
      andersca@apple.com authored
      * Scripts/webkitpy/common/config/contributors.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4986631c