1. 13 Mar, 2013 3 commits
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · 0a135163
      kadam@inf.u-szeged.hu authored
      * platform/qt/TestExpectations: Adding failure expectation for the SVG test after r145541.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a135163
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Unskipp some passing compositing tests. · 4dddfc3b
      kadam@inf.u-szeged.hu authored
      * platform/qt-5.0-wk1/TestExpectations:
      * platform/qt-5.0-wk1/compositing/direct-image-compositing-expected.png: Added.
      * platform/qt-5.0-wk1/compositing/direct-image-compositing-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/fixed-in-composited-expected.png: Added.
      * platform/qt-5.0-wk1/compositing/geometry/fixed-in-composited-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/geometry/video-fixed-scrolling-expected.png: Added.
      * platform/qt-5.0-wk1/compositing/geometry/video-fixed-scrolling-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
      * platform/qt-5.0-wk1/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/iframes/page-cache-layer-tree-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/layer-creation/scroll-partial-update-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
      * platform/qt-5.0-wk1/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/overflow/overflow-auto-with-touch-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/overflow/overflow-overlay-with-touch-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/overflow/scroll-ancestor-update-expected.png: Added.
      * platform/qt-5.0-wk1/compositing/overflow/scroll-ancestor-update-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/overflow/scrolling-without-painting-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/overflow/textarea-scroll-touch-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/overflow/updating-scrolling-content-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/plugins/no-backing-store-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/plugins/small-to-large-composited-plugin-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
      * platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
      * platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
      * platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
      * platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/self-painting-layers-expected.png: Added.
      * platform/qt-5.0-wk1/compositing/self-painting-layers-expected.txt: Added.
      * platform/qt-5.0-wk1/compositing/video/video-poster-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4dddfc3b
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 331b181c
      zandobersek@gmail.com authored
      Adding expectations for a couple of flaky crashers on the debug builder.
      Adding flaky failure expectations for a couple of SVG animations tests.
      Adding failure expectation for the SVG test introduced in 145541, failing due to disabled subpixel layout.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      331b181c
  2. 12 Mar, 2013 37 commits
    • vsevik@chromium.org's avatar
      Unreviewed inspector test fix. · 486600ca
      vsevik@chromium.org authored
      * http/tests/inspector/resource-tree/resource-request-content-after-loading-and-clearing-cache.html:
      * inspector/datagrid-autosize.html:
      * inspector/debugger/breakpoint-manager-listeners-count.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      486600ca
    • antti@apple.com's avatar
      Basic child obscuration test for backgrounds · b898f848
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111701
      
      Source/WebCore:
      
      Reviewed by Simon Fraser.
      
      Test: fast/repaint/obscured-background-no-repaint.html
      
      We can easily detect some simple cases where a background image is fully obscured by an opaque child.
      
      This avoids unncessary painting and image decoding. It is especially helpful for cases like about.com home
      page where a fully obscured 'loading' spinner keeps triggering frequent complex repaints (gif animations
      progress by getting painted and stop if they are not).
      
      This could be made way more sophisticated. The checking could also be done per-layout rather per-paint.
      Even this simple approach gets hit surprisingly often in real world sites.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::backgroundIsObscured):
      
          Before painting background test if any single child renderer fully obscures it.
      
      (WebCore::RenderBox::backgroundIsOpaqueInRect):
      * rendering/RenderBox.h:
      
      LayoutTests:
      
      Reviewed by Simon Fraser.
      
      * fast/repaint/obscured-background-no-repaint-expected.txt: Added.
      * fast/repaint/obscured-background-no-repaint.html: Added.
      * fast/repaint/resources/animated.gif: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b898f848
    • jparent@chromium.org's avatar
      Cleanup: Move flatten-trie to loader. · 2bba4647
      jparent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112196
      
      Reviewed by Dirk Pranke.
      
      flatten-trie is used only by the loader, so move it there and make it
      private, rather than global in dashbaord_base. Moved the corresponding
      unit test from flakiness_dashboard_unittests to loader_unittests.
      
      * TestResultServer/static-dashboards/dashboard_base.js:
      * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
      * TestResultServer/static-dashboards/loader.js:
      (.):
      * TestResultServer/static-dashboards/loader_unittests.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bba4647
    • ggaren@apple.com's avatar
      Unreviewed attempted Windows build fix after http://trac.webkit.org/changeset/145592. · 496b5d21
      ggaren@apple.com authored
      * wtf/SchedulePair.cpp:
      * wtf/SchedulePair.h:
      (WTF::SchedulePair::SchedulePair): Since linking is failing,
      try inlining this function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      496b5d21
    • hayato@chromium.org's avatar
      [Crash] Touch Events retargeting causes crashes on chrome on android. · 170d7e12
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112210
      
      Reviewed by Dimitri Glazkov.
      
      Added null-check for TouchEvent's touches(), targetTouches() and changedTouches().
      
      No new tests - no new functionality.
      
      * dom/EventRetargeter.cpp:
      (WebCore::EventRetargeter::adjustForTouchEvent):
      (WebCore::EventRetargeter::adjustTouchList):
      * dom/EventRetargeter.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      170d7e12
    • ch.dumez@sisa.samsung.com's avatar
      [EFL][WK2] ewk_popup_menu_close() does not work as intended · c78041ee
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=110209
      
      Reviewed by Laszlo Gombos.
      
      ewk_popup_menu_close() is called by the browser to notify WebKit that
      the popup menu was closed. However, the implementation was calling
      EwkView::closePopupMenu() which was asking the browser to close the
      popup menu via an Evas smart function. This patch fixes the behavior
      and ewk_popup_menu_close() now calls WKPopupMenuListenerSetSelection()
      C API so that the WebProcess is notified that the popup menu was
      hidden.
      
      * UIProcess/API/efl/ewk_popup_menu.cpp:
      (EwkPopupMenu::close):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c78041ee
    • commit-queue@webkit.org's avatar
      Unreviewed. Rolled Chromium DEPS to r187688. Requested by · 3faacfa1
      commit-queue@webkit.org authored
      "James Robinson" <jamesr@chromium.org> via sheriffbot.
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12
      
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3faacfa1
    • ggaren@apple.com's avatar
      2013-03-12 Geoffrey Garen <ggaren@apple.com> · d2a3aae8
      ggaren@apple.com authored
              Unreviewed attempted Windows build fix after http://trac.webkit.org/changeset/145592.
      
              * platform/RunLoopTimer.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2a3aae8
    • rniwa@webkit.org's avatar
      Update test expectation for the bug 111521. · 658c3b65
      rniwa@webkit.org authored
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      658c3b65
    • commit-queue@webkit.org's avatar
      Coordinated Graphics: Remove CoordinatedGraphicsLayer::setRootLayer(). · ce3c938b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111835
      
      Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-12
      Reviewed by Luiz Agostini.
      
      Source/WebCore:
      
      This patch removes CoordinatedGraphicsLayer::setRootLayer() because
      CoordinatedGraphicsScene already knows which layer is root.
      
      No new tests, no behavior change.
      
      * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
      * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
      (CoordinatedGraphicsLayer):
      * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
      (WebCore::CoordinatedGraphicsScene::setLayerState):
      * platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
      (WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
      
      Source/WebKit2:
      
      Amend CoordinatedLayerTreeHost because
      CoordinatedGraphicsLayer::setRootLayer() is removed.
      
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
      (WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce3c938b
    • commit-queue@webkit.org's avatar
      Enable GPU-GPU texture copy in texImage2D() for HTMLVideoElement if hardware... · 61d597de
      commit-queue@webkit.org authored
      Enable GPU-GPU texture copy in texImage2D() for HTMLVideoElement if hardware accelerated video decode is in use
      https://bugs.webkit.org/show_bug.cgi?id=111126
      
      Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-03-12
      Reviewed by Kenneth Russell.
      
      Source/WebCore:
      
      In texImage2D() for HTMLVideoElement in WebGL, it is possible to do a GPU-GPU texture copy instead of CPU readback
      and upload when videoFrame is in the form of textures. Each platform port needs to implement the interface
      copyVideoTextureToPlatformTexture() defined in MediaPlayer.h to make it work.
      
      Already covered by current tests.
      
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::copyVideoTextureToPlatformTexture):
      * html/HTMLVideoElement.h:
      (HTMLVideoElement):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::videoFrameToImage): Move some security check to upper level.
      (WebCore::WebGLRenderingContext::texImage2D): Add the fast GPU-GPU textures copy path for HTMLVideoElement and some security check.
      (WebCore::WebGLRenderingContext::texSubImage2D): Add some security check.
      * html/canvas/WebGLTexture.cpp:
      (WebCore::WebGLTexture::isValid): Added to check if the texture is defined at the given level.
      * html/canvas/WebGLTexture.h:
      (WebGLTexture):
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::MediaPlayer::copyVideoTextureToPlatformTexture): Added to do the GPU-GPU textures copy.
      * platform/graphics/MediaPlayer.h:
      (MediaPlayer):
      * platform/graphics/MediaPlayerPrivate.h:
      (WebCore::MediaPlayerPrivateInterface::copyVideoTextureToPlatformTexture):
      
      Source/WebKit/chromium:
      
      * public/WebMediaPlayer.h:
      (WebKit::WebMediaPlayer::copyVideoTextureToPlatformTexture):
      * src/WebMediaPlayerClientImpl.cpp:
      (WebKit::WebMediaPlayerClientImpl::copyVideoTextureToPlatformTexture): do a GPU-GPU textures copy if possible.
      * src/WebMediaPlayerClientImpl.h:
      (WebMediaPlayerClientImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61d597de
    • jamesr@google.com's avatar
      Update a few chromium test expectations. · cdf941f7
      jamesr@google.com authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdf941f7
    • timothy_horton@apple.com's avatar
      Typo in earlier Windows build fix. Unreviewed. · e0e5c375
      timothy_horton@apple.com authored
      * WTF.vcproj/WTF.vcproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0e5c375
    • timothy_horton@apple.com's avatar
      WTF uses macros for exports. Try to fix the Windows build. Unreviewed. · e1ef8d5f
      timothy_horton@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1ef8d5f
    • abarth@webkit.org's avatar
      [Chromium] WebFrame event listener APIs are unused and can be removed · e6b383af
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112189
      
      Reviewed by Darin Fisher.
      
      As far as I can tell, there are no callers for these APIs. They appear
      to have been added for out-of-process postMessages, but those are now
      implemented using a different mechanism.
      
      * public/WebFrame.h:
      (WebFrame):
      * src/WebFrameImpl.cpp:
      * src/WebFrameImpl.h:
      (WebFrameImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6b383af
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r145280. · e8610f08
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/145280
      https://bugs.webkit.org/show_bug.cgi?id=112217
      
      This patch broke chromium WebGL conformance tests (Requested
      by shawnsingh on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12
      
      * platform/graphics/gpu/DrawingBuffer.cpp:
      (WebCore::DrawingBuffer::reset):
      * platform/graphics/gpu/DrawingBuffer.h:
      (DrawingBuffer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8610f08
    • oliver@apple.com's avatar
      Unbreak api tests · 05fca67f
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05fca67f
    • dino@apple.com's avatar
      Don't send events to plugins that are being snapshotted · c3e382a2
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112215
      <rdar://problem/13386224>
      
      Reviewed by Tim Horton.
      
      If a plugin is in the process of being snapshotted, do not forward it
      any events. This avoids the case where we can accidentally capture some
      custom mouse pointers, as well as trigger a plugin menu.
      
      The next step will be to detect if the event should stop the snapshotting
      (restart the plugin).
      
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::defaultEventHandler): Return early if the plugin is snapshotting.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3e382a2
    • dino@apple.com's avatar
      Primary plugin hit detection needs to run after plugin creation · d6cfa868
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112206
      
      Reviewed by Tim Horton.
      
      On some pages, the plugins are created after the page has loaded, and
      thus our heuristic to determine the primary plugin fails. Run this
      heuristic more often: after each PluginView is created. It already exits
      early if it has found a primary. But we also need to make sure that it
      doesn't run before load.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::addPluginView): Run detection when view is added.
      (WebKit::WebPage::didFinishLoad): Remember that we have loaded.
      (WebKit::WebPage::determinePrimarySnapshottedPlugIn): Look at the PluginViews to see if we have a plugin.
      (WebKit::WebPage::resetPrimarySnapshottedPlugIn): Reset both flags.
      * WebProcess/WebPage/WebPage.h:
      (WebPage): New member variable, m_readyToFindPrimarySnapshottedPlugin.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6cfa868
    • timothy_horton@apple.com's avatar
      Unreviewed attempted Windows build fix after http://trac.webkit.org/changeset/145592. · 96011df4
      timothy_horton@apple.com authored
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      
      * WTF.vcproj/WTF.vcproj:
      * WTF.vcxproj/WTF.vcxproj:
      * WTF.vcxproj/WTF.vcxproj.filters:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96011df4
    • commit-queue@webkit.org's avatar
      Fix Gamepad::axes and Gamepad::buttons to avoid calling std::copy(..., ..., 0) · 532aa992
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89510
      
      Patch by James Robinson <jamesr@chromium.org> on 2013-03-12
      Reviewed by Kenneth Russell.
      
      Source/WebCore:
      
      WTF::Vector::begin() returns 0 when the vector has length zero. On windows, the debug implementation of
      std::copy() is unhappy with 0 as a third parameter even when the first and second parameters are equal.
      
      Covered by gamepad/gamepad-polling-access.html
      
      * Modules/gamepad/Gamepad.cpp:
      (WebCore::Gamepad::axes):
      (WebCore::Gamepad::buttons):
      
      LayoutTests:
      
      Remove expectation now that test passes.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      532aa992
    • fpizlo@apple.com's avatar
      Array.prototype.sort should at least try to be PTIME even when the array is in some bizarre mode · a8fe925e
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112187
      <rdar://problem/13393550>
      
      Source/JavaScriptCore: 
      
      Reviewed by Michael Saboff and Gavin Barraclough.
              
      If we have an array-like object in crazy mode passed into Array.prototype.sort, and its length is large,
      then first copy all elements into a separate, compact, un-holy array and sort that. Then copy back.
      This means that sorting will be at works O(n^2) in the actual number of things in the array, rather than
      O(n^2) in the array's length.
      
      * runtime/ArrayPrototype.cpp:
      (JSC::attemptFastSort):
      (JSC::performSlowSort):
      (JSC):
      (JSC::arrayProtoFuncSort):
      
      LayoutTests: 
      
      Reviewed by Michael Saboff and Gavin Barraclough.
              
      If your Array.prototype.sort is not sufficiently smart, this test will never complete.
      But if it is, it'll complete instantly.
      
      * fast/js/array-sort-small-sparse-array-with-large-length-expected.txt: Added.
      * fast/js/array-sort-small-sparse-array-with-large-length.html: Added.
      * fast/js/jsc-test-list:
      * fast/js/script-tests/array-sort-small-sparse-array-with-large-length.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8fe925e
    • bdakin@apple.com's avatar
      WKView -printOperationWithPrintInfo:forFrame: doesn’t use the print info that is · 4b0f09f6
      bdakin@apple.com authored
      passed in
      https://bugs.webkit.org/show_bug.cgi?id=112212
      -and corresponding-
      <rdar://problem/12994883>
      
      Reviewed by Anders Carlsson.
      
      We should call [NSPrintOperation printOperationWithView: printInfo:] to use the 
      printInfo parameter instead of [NSPrintOperation printOperationWithView:] which 
      will just use the sharedPrintInfo.
      * UIProcess/API/mac/WKView.mm:
      (-[WKView printOperationWithPrintInfo:forFrame:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b0f09f6
    • abarth@webkit.org's avatar
      [Chromium] Remove last vestigates of WEBKIT_USING_V8 · d4bd1349
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112203
      
      Reviewed by James Robinson.
      
      These macros are no longer referenced anywhere and can be removed.
      
      * chromium/public/WebCommon.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4bd1349
    • jamesr@google.com's avatar
      Update chromium pixel baselines for mesa blend fix in chromium r187688 · eb0037be
      jamesr@google.com authored
      * platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
      * platform/chromium-linux/compositing/culling/filter-occlusion-blur-expected.png: Removed.
      * platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png: Removed.
      * platform/chromium-linux/compositing/direct-image-compositing-expected.png:
      * platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
      * platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
      * platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
      * platform/chromium-linux/compositing/geometry/video-fixed-scrolling-expected.png:
      * platform/chromium-linux/compositing/geometry/video-opacity-overlay-expected.png:
      * platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
      * platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
      * platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
      * platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
      * platform/chromium-linux/compositing/reflections/load-video-in-reflection-expected.png:
      * platform/chromium-linux/compositing/reflections/nested-reflection-anchor-point-expected.png:
      * platform/chromium-linux/compositing/reflections/transform-inside-reflection-expected.png:
      * platform/chromium-linux/compositing/self-painting-layers-expected.png:
      * platform/chromium-linux/compositing/transitions/scale-transition-no-start-expected.png:
      * platform/chromium-linux/compositing/visibility/visibility-image-layers-expected.png: Removed.
      * platform/chromium-linux/compositing/visibility/visibility-simple-video-layer-expected.png: Removed.
      * platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
      * platform/chromium-linux/css3/filters/custom/effect-color-check-expected.png: Added.
      * platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
      * platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
      * platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
      * platform/chromium-linux/css3/filters/effect-blur-hw-expected.png: Removed.
      * platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.png: Removed.
      * platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png: Removed.
      * platform/chromium-linux/css3/filters/effect-combined-hw-expected.png:
      * platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png: Removed.
      * platform/chromium-linux/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
      * platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Removed.
      * platform/chromium-linux/css3/filters/effect-reference-ordering-hw-expected.png: Removed.
      * platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png: Removed.
      * platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png: Removed.
      * platform/chromium-linux/css3/filters/filter-change-repaint-composited-expected.png: Removed.
      * platform/chromium-linux/css3/filters/filter-change-repaint-expected.png: Removed.
      * platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png:
      * platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-expected.png:
      * platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
      * platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
      * platform/chromium-linux/platform/chromium/compositing/3d-corners-expected.png:
      * platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
      * platform/chromium-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
      * platform/chromium-linux/platform/chromium/compositing/video-frame-size-change-expected.png:
      * platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Added.
      * platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Added.
      * platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
      * platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
      * platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
      * platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
      * platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
      * platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
      * platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
      * platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
      * platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
      * platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
      * platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
      * platform/chromium-mac-lion/compositing/color-matching/image-color-matching-expected.png:
      * platform/chromium-mac-lion/compositing/direct-image-compositing-expected.png:
      * platform/chromium-mac-lion/compositing/geometry/clipping-foreground-expected.png:
      * platform/chromium-mac-lion/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
      * platform/chromium-mac-lion/compositing/geometry/layer-due-to-layer-children-expected.png:
      * platform/chromium-mac-lion/compositing/geometry/video-fixed-scrolling-expected.png:
      * platform/chromium-mac-lion/compositing/geometry/video-opacity-overlay-expected.png:
      * platform/chromium-mac-lion/compositing/layers-inside-overflow-scroll-expected.png:
      * platform/chromium-mac-lion/compositing/overflow/overflow-compositing-descendant-expected.png:
      * platform/chromium-mac-lion/compositing/overflow/scroll-ancestor-update-expected.png:
      * platform/chromium-mac-lion/compositing/reflections/animation-inside-reflection-expected.png:
      * platform/chromium-mac-lion/compositing/reflections/load-video-in-reflection-expected.png:
      * platform/chromium-mac-lion/compositing/reflections/nested-reflection-anchor-point-expected.png:
      * platform/chromium-mac-lion/compositing/reflections/transform-inside-reflection-expected.png:
      * platform/chromium-mac-lion/compositing/self-painting-layers-expected.png:
      * platform/chromium-mac-lion/compositing/transitions/scale-transition-no-start-expected.png:
      * platform/chromium-mac-lion/platform/chromium/compositing/video-frame-size-change-expected.png:
      * platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Added.
      * platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/compositing/overflow/scroll-ancestor-update-expected.png.
      * platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
      * platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
      * platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png:
      * platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
      * platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
      * platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
      * platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-expected.png:
      * platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
      * platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
      * platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
      * platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png:
      * platform/chromium-mac-snowleopard/compositing/geometry/clipping-foreground-expected.png:
      * platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
      * platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png:
      * platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png:
      * platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png:
      * platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
      * platform/chromium-mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png:
      * platform/chromium-mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png:
      * platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
      * platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png:
      * platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png:
      * platform/chromium-mac-snowleopard/compositing/reflections/transform-inside-reflection-expected.png:
      * platform/chromium-mac-snowleopard/compositing/self-painting-layers-expected.png:
      * platform/chromium-mac-snowleopard/compositing/transitions/scale-transition-no-start-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/compositing/video-frame-size-change-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png.
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Added.
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
      * platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
      * platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png:
      * platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
      * platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
      * platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png:
      * platform/chromium-mac/compositing/culling/filter-occlusion-blur-expected.png:
      * platform/chromium-mac/compositing/culling/filter-occlusion-blur-large-expected.png:
      * platform/chromium-mac/compositing/direct-image-compositing-expected.png:
      * platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
      * platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-expected.png:
      * platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
      * platform/chromium-mac/compositing/geometry/video-fixed-scrolling-expected.png:
      * platform/chromium-mac/compositing/geometry/video-opacity-overlay-expected.png:
      * platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png:
      * platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
      * platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png:
      * platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
      * platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png:
      * platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
      * platform/chromium-mac/compositing/reflections/transform-inside-reflection-expected.png:
      * platform/chromium-mac/compositing/self-painting-layers-expected.png:
      * platform/chromium-mac/compositing/transitions/scale-transition-no-start-expected.png:
      * platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png:
      * platform/chromium-mac/compositing/visibility/visibility-simple-video-layer-expected.png:
      * platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
      * platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
      * platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
      * platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png:
      * platform/chromium-mac/css3/filters/effect-blur-hw-expected.png:
      * platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png:
      * platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
      * platform/chromium-mac/css3/filters/effect-combined-hw-expected.png:
      * platform/chromium-mac/css3/filters/effect-contrast-hw-expected.png:
      * platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png:
      * platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
      * platform/chromium-mac/css3/filters/effect-reference-ordering-hw-expected.png:
      * platform/chromium-mac/css3/filters/filter-change-repaint-composited-expected.png: Added.
      * platform/chromium-mac/css3/filters/filter-change-repaint-expected.png: Added.
      * platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png:
      * platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png:
      * platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
      * platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
      * platform/chromium-mac/platform/chromium/compositing/3d-corners-expected.png:
      * platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
      * platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png:
      * platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
      * platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
      * platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
      * platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.png:
      * platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Added.
      * platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Added.
      * platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
      * platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
      * platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
      * platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
      * platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
      * platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
      * platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
      * platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-expected.png:
      * platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
      * platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
      * platform/chromium/TestExpectations:
      * platform/chromium/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
      * platform/chromium/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
      * platform/efl-wk2/compositing/geometry/clipping-foreground-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/clipping-foreground-expected.png.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb0037be
    • timothy_horton@apple.com's avatar
      Try to fix the Windows build. · 565ab752
      timothy_horton@apple.com authored
      Not reviewed.
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      565ab752
    • esprehn@chromium.org's avatar
      Remove TextIterator.cpp's isAllCollapsibleWhitespace · f9ea74a4
      esprehn@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112200
      
      Reviewed by Ryosuke Niwa.
      
      Remove isAllCollapsibleWhitespace since nothing uses it.
      
      * editing/TextIterator.cpp: Remove isAllCollapsibleWhitespace.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9ea74a4
    • betravis@adobe.com's avatar
      [css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData · 28fba076
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=110995
      
      Reviewed by Julien Chaffraix.
      
      This patch moves ExclusionShapeInsideInfo into the RenderBlockRareData struct,
      which enables us to move away from the global ExclusionShapeInsideInfo map.
      Some additional refactoring was done to remove ExclusionShapeInsideInfo's
      dependency on InlineIterator, which depended on RenderBlock. This work required
      adding a new LineSegmentIterator struct.
      
      Refactoring, no new tests.
      
      * rendering/ExclusionShapeInsideInfo.cpp:
      (WebCore):
      (WebCore::LineSegmentRange::LineSegmentRange): Moving the InlineIterator
      constructor to the .cpp file, as InlineIterator is now forward declared in
      the .h file.
      (WebCore::ExclusionShapeInsideInfo::isEnabledFor): Moving isEnabledFor to
      the .cpp file, as RenderBlock is now forward declared in the .h file.
      * rendering/ExclusionShapeInsideInfo.h:
      (WebCore):
      (LineSegmentIterator): A simple struct for containing segment positions for
      layout.
      (WebCore::LineSegmentIterator::LineSegmentIterator): Constructor.
      (LineSegmentRange): Transitioning to store LineSegmentIterator.
      (WebCore::LineSegmentRange::LineSegmentRange): Ditto.
      (ExclusionShapeInsideInfo):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::willBeDestroyed): Destroying a block will now destroy
      its ExclusionShapeInsideInfo, so there is no need to remove it from the map.
      (WebCore):
      (WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Use
      the RenderBlockRareData struct rather than the global map.
      * rendering/RenderBlock.h:
      (WebCore):
      (WebCore::RenderBlock::ensureExclusionShapeInsideInfo): Ensure an info struct
      is present if the shape-inside style is set.
      (WebCore::RenderBlock::exclusionShapeInsideInfo): Look up the info struct for
      the current block.
      (WebCore::RenderBlock::setExclusionShapeInsideInfo): Update the info struct
      for the current block.
      (RenderBlockRareData): Add the ExclusionShapeInsideInfo member. Move the struct
      declaration to be public, so that the OwnPtr reference can properly delete it.
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::constructBidiRunsForLine): Construct the appropriate offsets during
      layout based on the stored LineSegmentIterators.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28fba076
    • timothy_horton@apple.com's avatar
      Unreviewed, disabling tests for Win EWS. · 920e2b0c
      timothy_horton@apple.com authored
      win-ews obviously cannot keep up with running tests, it's >300 behind.
      Probably doesn't help that its (likely) running tests serially.
      
      * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      (WinEWS):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      920e2b0c
    • ggaren@apple.com's avatar
      Try to fix the Windows build. · 8fe66771
      ggaren@apple.com authored
      Not reviewed.
      
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
      Export a thing.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fe66771
    • jamesr@google.com's avatar
      Build fix for r145592 - update gyp files to refer to new file locations. · 6ce57853
      jamesr@google.com authored
      Source/WebCore:
      
      * WebCore.gypi:
      
      Source/WTF:
      
      * WTF.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ce57853
    • benjamin@webkit.org's avatar
      Add a single character cache to WidthCache · af38aab1
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112084
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-12
      Reviewed by Geoffrey Garen.
      
      More than half of the values stored in WidthCache are values
      for a single character.
      
      Previously, we were creating a new SmallStringKey for each one of
      them, causing a lot of extra memory operations even for the simple
      cases.
      
      This patch adds a second map, m_singleCharMap, to simplify the
      computation for the common case of a single char TextRun.
      
      * platform/graphics/WidthCache.h:
      (WebCore::WidthCache::clear):
      (WidthCache):
      (WebCore::WidthCache::addSlowCase):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af38aab1
    • timothy_horton@apple.com's avatar
      Add a --build-directory argument to delete-stale-build-files · 4037b0b7
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112198
      
      Reviewed by Ryosuke Niwa.
      
      * BuildSlaveSupport/delete-stale-build-files:
      (main): Add --build-directory argument.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4037b0b7
    • pdr@google.com's avatar
      Replace static_casts for SVG transformable and locatable elements · 1443d415
      pdr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111651
      
      Reviewed by Abhishek Arya.
      
      toSVGStyledTransformableElement and toSVGStyledLocatableElement are preferred over
      static_casts because bad casts can be caught on our testing infrastructure. This patch
      replaces all static_casts for SVGStyledTransformableElement and SVGStyledLocatableElement
      with toSVGStyledTransformableElement and toSVGStyledLocatableElement, respectively.
      
      No new tests as this is covered with existing tests.
      
      * rendering/svg/RenderSVGResourceClipper.cpp:
      (WebCore::RenderSVGResourceClipper::pathOnlyClipping):
      * rendering/svg/RenderSVGResourceContainer.cpp:
      (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
      * rendering/svg/RenderSVGShape.cpp:
      (WebCore::RenderSVGShape::updateShapeFromElement):
      (WebCore::RenderSVGShape::layout):
      (WebCore::RenderSVGShape::nonScalingStrokeTransform):
      (WebCore::RenderSVGShape::shouldGenerateMarkerPositions):
      * rendering/svg/RenderSVGTransformableContainer.cpp:
      (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
      * svg/SVGAnimatedLength.cpp:
      (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
      
          This was an unnecessary cast and has been removed.
      
      * svg/SVGElement.cpp:
      (WebCore::SVGElement::getBoundingBox):
      * svg/SVGLocatable.cpp:
      (WebCore::SVGLocatable::getTransformToElement):
      * svg/SVGStyledLocatableElement.h:
      (WebCore):
      (WebCore::toSVGStyledLocatableElement):
      * svg/SVGStyledTransformableElement.h:
      (WebCore):
      (WebCore::toSVGStyledTransformableElement):
      
          It makes the code cleaner to pass Node* in here, rather than converting the Node*
          to an SVGElement* before calling this function. The same was not necessary for
          SVGStyledLocatable.
      
      * svg/SVGSVGElement.h:
      (WebCore):
      (WebCore::toSVGSVGElement):
      
          This code has been cleaned up. During the review of this patch, a similar cleanup
          was done in toSVGStyledTransformableElement.
      
      * svg/SVGUseElement.cpp:
      (WebCore::SVGUseElement::toClipPath):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1443d415
    • abarth@webkit.org's avatar
      Unreviewed. Rolled Chromium DEPS to r187660. Requested by · 71d6397f
      abarth@webkit.org authored
      "Adam Barth" <abarth@webkit.org> via sheriffbot.
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12
      
      * DEPS:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71d6397f
    • inferno@chromium.org's avatar
      Replace static_casts with to* helper functions. · 64b344e7
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112164
      
      Reviewed by Philip Rogers.
      
      to* helper functions are preferred over static_cast calls since they
      help to catch bad casts easily on the testing infrastructure.
      
      Source/WebCore:
      
      * css/ElementRuleCollector.cpp:
      (WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
      * platform/gtk/PasteboardGtk.cpp:
      (WebCore::getURLForImageNode):
      (WebCore::Pasteboard::writeImage):
      * platform/gtk/RenderThemeGtk.cpp:
      (WebCore::getMediaElementFromRenderObject):
      * platform/qt/RenderThemeQtMobile.cpp:
      (WebCore::RenderThemeQtMobile::checkMultiple):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::title):
      (WebCore::HitTestResult::absoluteImageURL):
      (WebCore::HitTestResult::absolutePDFURL):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::resize):
      (WebCore::RenderLayer::hitTest):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::valueChanged):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::addPDFURLRect):
      * rendering/RenderPart.cpp:
      (WebCore::RenderPart::requiresAcceleratedCompositing):
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::checkRegionStyle):
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::computePreferredLogicalWidths):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::isEnabled):
      (WebCore::RenderTheme::isSpinUpButtonPartPressed):
      (WebCore::RenderTheme::isHovered):
      (WebCore::RenderTheme::isSpinUpButtonPartHovered):
      (WebCore::RenderTheme::paintSliderTicks):
      * rendering/RenderThemeWinCE.cpp:
      (WebCore::mediaElementParent):
      * rendering/RenderTreeAsText.cpp:
      (WebCore::isEmptyOrUnstyledAppleStyleSpan):
      (WebCore::RenderTreeAsText::writeRenderObject):
      (WebCore::writeRenderRegionList):
      * rendering/svg/SVGRenderTreeAsText.cpp:
      (WebCore::writeSVGResourceContainer):
      
      Source/WebKit/win:
      
      * DOMHTMLClasses.cpp:
      (DOMHTMLElement::idName):
      (DOMHTMLElement::innerText):
      (DOMHTMLElement::setInnerText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64b344e7
    • oliver@apple.com's avatar
      Appease MSVC · 1bc7e968
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bc7e968