Skip to content

GitLab

W
webkit
Switch branch/tag
  1. 05 May, 2008 11 commits
  3. 04 May, 2008 9 commits
  5. 03 May, 2008 6 commits
  7. 02 May, 2008 14 commits
    • andersca@apple.com's avatar
      WebCore: · 2601b732
      andersca@apple.com authored 
      2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Turns out calling locationInWindow on keyboard events will not throw an exception,
        but the point returned is completely bogus, so remove coordinates from the keyboard event struct.
        
        * bridge/npapi.h:
        (_NPCocoaEvent::):

WebKit/mac:

2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Various Cocoa event model and 64-bit plug-in fixes.
        
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
        Set click count.
        
        (WebNetscapePluginEventHandlerCocoa::flagsChanged):
        (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
        Don't try to get the mouse location for keyboard events.
        
        * Plugins/WebPluginPackage.m:
        (-[WebPluginPackage initWithPath:]):
        Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2601b732
    • andersca@apple.com's avatar
      2008-05-02 Anders Carlsson <andersca@apple.com> · db0ed043
      andersca@apple.com authored 
              Reviewed by Mark.

        Add an "x86_64" make rule.
        
        * Makefile.shared:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db0ed043
    • alp@webkit.org's avatar
      2008-05-02 Benjamin Otte <otte@gnome.org> · daef1936
      alp@webkit.org authored 
              Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18856
        [GTK] variable initialization missing

        Not initializing the m_needsXEmbed variable could have very funny
        results. Most often those results would be crashes.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::PluginView):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      daef1936
    • alp@webkit.org's avatar
      2008-05-02 Jan Michael Alonzo <jmalonzo@unpluggable.com> · d06c7c97
      alp@webkit.org authored 
              Reviewed by Eric.

        https://bugs.webkit.org/show_bug.cgi?id=18811
        Enable dashboard and offline web apps in autotools


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d06c7c97
    • ap@webkit.org's avatar
      Reviewed by Geoffrey Garen. · 7f250f84
      ap@webkit.org authored 
              Get rid of static data in nodes.cpp (well, at least of non-debug one).

        No measurable change on SunSpider.

        * kjs/InitializeThreading.cpp:
        (KJS::initializeThreadingOnce):
        * kjs/nodes.cpp:
        (KJS::newTrackedObjects):
        (KJS::trackedObjectExtraRefCounts):
        (KJS::initializeNodesThreading):
        (KJS::ParserRefCounted::ParserRefCounted):
        (KJS::ParserRefCounted::ref):
        (KJS::ParserRefCounted::deref):
        (KJS::ParserRefCounted::refcount):
        (KJS::ParserRefCounted::deleteNewObjects):
        * kjs/nodes.h:
        Made newTrackedObjects and trackedObjectExtraRefCounts per-thread.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f250f84
    • andersca@apple.com's avatar
      WebCore: · 8cd7f654
      andersca@apple.com authored 
      2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Name the event union so it will work in plain C.

        * bridge/npapi.h:
        (_NPCocoaEvent::):

WebKit/mac:

2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        The event union is now named.
        
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::drawRect):
        (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
        (WebNetscapePluginEventHandlerCocoa::flagsChanged):
        (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
        (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
        (WebNetscapePluginEventHandlerCocoa::focusChanged):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cd7f654
    • andersca@apple.com's avatar
      2008-05-02 Anders Carlsson <andersca@apple.com> · 1aafb665
      andersca@apple.com authored 
              Reviewed by Mark.

        Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
        
        Call preflightAndReturnError on the bundle, which will check if any of the architectures
        in the bundle match the current architecture.
        
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _initWithPath:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1aafb665
    • ap@webkit.org's avatar
      Reviewed by Darin. · 6b40fecd
      ap@webkit.org authored 
              Move call stack depth counter to global object.

        * kjs/ExecState.h: (KJS::ExecState::functionCallDepth): Added a recursion depth counter to
        per-thread data.
        * kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init): Initialize PerThreadData.functionCallDepth.
        * kjs/JSGlobalObject.h: (KJS::JSGlobalObject::perThreadData): Made the result non-const.

        * kjs/object.cpp:
        (KJS::throwStackSizeExceededError): Moved throwError to a separate function, since it is now
        the only thing in JSObject::call that needs a PIC branch.
        (KJS::JSObject::call): Use a per-thread variable instead of local static for recursion depth
        tracking.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b40fecd
    • mitz@apple.com's avatar
      Reviewed by Adam Roben. · c68fbd48
      mitz@apple.com authored 
              - add an option to svn-apply to set the reviewer name in change logs

        * Scripts/svn-apply: Added a [-r|--reviewer name] option.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c68fbd48
    • mitz@apple.com's avatar
      WebCore: · b74d5ba6
      mitz@apple.com authored 
              Reviewed by John Sullivan.

        - render text shadows with zero offset, as the shadow can be seen behind
          the text if the text is translucent

        Test: fast/text/shadow-no-blur.html

        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawComplexText): Removed the isEmpty() condition on the
        shadow offset. Since isEmpty() is also true for sizes that have one or
        more non-positive components, this also ensures that subpixel
        antialiasing of the text is maintained with shadows in all directions.
        (WebCore::Font::drawGlyphs): Ditto.
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): Ditto.

LayoutTests:

        Reviewed by John Sullivan.

        - add pixel test for text shadows with zero blur and various offsets,
          including zero offset

        * fast/text/shadow-no-blur.html: Added.
        * platform/mac/fast/text/shadow-no-blur-expected.checksum: Added.
        * platform/mac/fast/text/shadow-no-blur-expected.png: Added.
        * platform/mac/fast/text/shadow-no-blur-expected.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b74d5ba6
    • hausmann@webkit.org's avatar
      2008-05-02 Tor Arne Vestbø <tavestbo@trolltech.com> · 7b9e3957
      hausmann@webkit.org authored 
      Updated Qt layout-tests to match changes in font metrics.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b9e3957
    • hausmann@webkit.org's avatar
      Ariya Hidayat <ariya.hidayat@trolltech.com> · cefb559d
      hausmann@webkit.org authored 
      Build the Qt port with SVG Use and As Image support.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cefb559d
    • hausmann@webkit.org's avatar
      Ariya Hidayat <ariya.hidayat@trolltech.com> · 6765a390
      hausmann@webkit.org authored 
      Fixed potential crash on SVG animation (added more checks to the assert).


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6765a390
    • hausmann@webkit.org's avatar
      Benjamin Meyer <bmeyer@trolltech.com> · de911162
      hausmann@webkit.org authored 
      Doc: Mention that you have to enable plugins in QWebSettings for them to work.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de911162