1. 21 Nov, 2012 28 commits
    • loislo@chromium.org's avatar
      Web Inspector: NMI add instrumentation to widely used ActiveDOMObjects.... · 08cddc42
      loislo@chromium.org authored
      Web Inspector: NMI add instrumentation to widely used ActiveDOMObjects. XMLHttpRequest, Prerenderer, HTMLMediaElement and DOMTimer.
      https://bugs.webkit.org/show_bug.cgi?id=102818
      
      Reviewed by Vsevolod Vlasov.
      
      Our test bot counts pointers which don't match with objects allocated by tcmalloc.
      This counter becomes nonzero after instrumenting ActiveDOMObject class.
      It happens because it is the base class for many other classes (~30).
      And almost all these classes use multiple inheritance.
      
      * dom/Document.cpp:
      (WebCore::Document::reportMemoryUsage):
      * dom/DocumentEventQueue.cpp:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::reportMemoryUsage):
      (WebCore):
      * html/HTMLMediaElement.h:
      * loader/Prerenderer.cpp:
      (WebCore::Prerenderer::reportMemoryUsage):
      (WebCore):
      * loader/Prerenderer.h:
      (Prerenderer):
      * page/DOMTimer.cpp:
      (WebCore::DOMTimer::reportMemoryUsage):
      (WebCore):
      * page/DOMTimer.h:
      (DOMTimer):
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::reportMemoryUsage):
      (WebCore):
      * xml/XMLHttpRequest.h:
      (XMLHttpRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08cddc42
    • commit-queue@webkit.org's avatar
      [V8] Add context checks to WorldContextHandle and V8DOMWindowShell · 2f4c4b10
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101573
      
      Patch by Dan Carney <dcarney@google.com> on 2012-11-21
      Reviewed by Adam Barth.
      
      Added a bunch of assertions to ensure the problems with IndexedDB
      contexts cannot reemerge.
      
      No new tests. No change in functionality.
      
      * bindings/v8/V8DOMWindowShell.cpp:
      (WebCore):
      (WebCore::V8DOMWindowShell::assertContextHasCorrectPrototype):
      * bindings/v8/V8DOMWindowShell.h:
      (V8DOMWindowShell):
      (WebCore::V8DOMWindowShell::isolated):
      * bindings/v8/WorldContextHandle.cpp:
      (WebCore::WorldContextHandle::WorldContextHandle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f4c4b10
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, unskip a now passing test, update an expected file. · 4886f987
      ossy@webkit.org authored
      * platform/qt-5.0/TestExpectations:
      * platform/qt-5.0/editing/selection/click-left-of-rtl-wrapping-text-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4886f987
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, unskip now passing tests. · 77e29ef8
      ossy@webkit.org authored
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77e29ef8
    • yurys@chromium.org's avatar
      Unreviewed. Mark css3/filters/effect-reference-ordering-hw.html as crashing after crrev.com/168998 · 5c97f803
      yurys@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c97f803
    • commit-queue@webkit.org's avatar
      WebMediaStreamComponent: Add assignment and copy operators · d7e8a11a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102915
      
      Patch by Harald Alvestrand <hta@google.com> on 2012-11-21
      Reviewed by Adam Barth.
      
      Source/Platform:
      
      * chromium/public/WebMediaStreamComponent.h:
      (WebKit::WebMediaStreamComponent::WebMediaStreamComponent):
      (WebKit::WebMediaStreamComponent::operator=):
      (WebMediaStreamComponent):
      
      Source/WebCore:
      
      Tests that use this functionality are being submitted to Chrome.
      
      * platform/chromium/support/WebMediaStreamComponent.cpp:
      (WebKit::WebMediaStreamComponent::assign):
      (WebKit):
      * platform/chromium/support/WebMediaStreamDescriptor.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7e8a11a
    • haraken@chromium.org's avatar
      [V8] Remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK() · 0b32dbe4
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102917
      
      Reviewed by Adam Barth.
      
      Now EXCEPTION_BLOCK() and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
      are equivalent. We can remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK().
      To make a code generate change smaller, this patch also renames
      STRING_TO_V8PARAMETER_EXCEPTION_BLOCK_VOID() to EXCEPTION_BLOCK_VOID().
      I will rename these macros in a follow-up patch.
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateEventConstructorCallback):
      (ConvertToV8Parameter):
      * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
      (WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):
      * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
      (WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):
      * bindings/scripts/test/V8/V8TestEventConstructor.cpp:
      (WebCore::V8TestEventConstructor::constructorCallback):
      * bindings/scripts/test/V8/V8TestInterface.cpp:
      (WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
      (WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetter):
      (WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
      (WebCore::V8TestInterface::constructorCallback):
      * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
      (WebCore::V8TestNamedConstructorConstructorCallback):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
      (WebCore::TestObjV8Internal::stringAttrAttrSetter):
      (WebCore::TestObjV8Internal::reflectedStringAttrAttrSetter):
      (WebCore::TestObjV8Internal::reflectedURLAttrAttrSetter):
      (WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetter):
      (WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
      (WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
      (WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
      (WebCore::TestObjV8Internal::longMethodWithArgsCallback):
      (WebCore::TestObjV8Internal::objMethodWithArgsCallback):
      (WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
      (WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
      (WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
      (WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
      (WebCore::TestObjV8Internal::overloadedMethod1Callback):
      (WebCore::TestObjV8Internal::overloadedMethod3Callback):
      (WebCore::TestObjV8Internal::overloadedMethod11Callback):
      (WebCore::TestObjV8Internal::overloadedMethod12Callback):
      (WebCore::TestObjV8Internal::strictFunctionCallback):
      (WebCore::TestObjV8Internal::variadicStringMethodCallback):
      * bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
      (WebCore::V8TestOverloadedConstructors::constructor4Callback):
      * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
      (WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
      * bindings/v8/V8BindingMacros.h:
      * bindings/v8/V8StringResource.h:
      (V8Parameter):
      * bindings/v8/custom/V8ConsoleCustom.cpp:
      (WebCore::V8Console::profileCallback):
      (WebCore::V8Console::profileEndCallback):
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::handlePostMessageCallback):
      * bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
      (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):
      * bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
      (WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):
      * bindings/v8/custom/V8HistoryCustom.cpp:
      (WebCore::V8History::pushStateCallback):
      (WebCore::V8History::replaceStateCallback):
      * bindings/v8/custom/V8IntentCustom.cpp:
      (WebCore::V8Intent::constructorCallbackCustom):
      * bindings/v8/custom/V8SQLTransactionCustom.cpp:
      (WebCore::V8SQLTransaction::executeSqlCallback):
      * bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
      (WebCore::V8SQLTransactionSync::executeSqlCallback):
      * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
      (WebCore::V8WebGLRenderingContext::getExtensionCallback):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b32dbe4
    • haraken@chromium.org's avatar
      [V8] Move V8DOMWindowShell::initializeV8IfNeeded() to V8Initializer · 964c7e04
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102899
      
      Reviewed by Adam Barth.
      
      This is an incremental step to kill WorkerContextExecutionProxy.
      As commented by abarth in bug 97066, we move
      V8DOMWindowShell::initializeV8IfNeeded() to V8Initializer.
      This patch renames initializeV8IfNeeded() to initializeMainThreadIfNeeded()
      because we will add initializeWorkerIfNeeded() in a follow-up patch.
      
      No tests. No change in behavior.
      
      * UseV8.cmake:
      * WebCore.gypi:
      * bindings/v8/V8DOMWindowShell.cpp:
      (WebCore::V8DOMWindowShell::initializeIfNeeded):
      * bindings/v8/V8Initializer.cpp: Added.
      (WebCore):
      (WebCore::findFrame):
      (WebCore::reportFatalError):
      (WebCore::reportUncaughtException):
      (WebCore::reportUnsafeJavaScriptAccess):
      (WebCore::V8Initializer::initializeMainThreadIfNeeded):
      * bindings/v8/V8Initializer.h: Added.
      (WebCore):
      (V8Initializer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      964c7e04
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, unskip a now passing test. · 70178f02
      ossy@webkit.org authored
      * platform/qt-5.0-wk2/TestExpectations:
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70178f02
    • gyuyoung.kim@samsung.com's avatar
      [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default · c848932d
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=101526
      
      .:
      
      Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-21
      Reviewed by Kenneth Rohde Christiansen.
      
      Separate out ENABLE_WEBGL. It is not ready to be enabled by default.
      
      * Source/cmake/OptionsEfl.cmake:
      
      Tools:
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
      
      * Scripts/webkitperl/FeatureList.pm:
      * TestWebKitAPI/CMakeLists.txt: No include KURL.cpp because of API test crash.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c848932d
    • apavlov@chromium.org's avatar
      Turn -webkit-text-emphasis into a shorthand property · b1905670
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102879
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      -webkit-text-emphasis value is no longer empty.
      
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::getPropertyValue): Reconstruct the -webkit-text-emphasis value based on the longhands.
      
      LayoutTests:
      
      Update expected results.
      
      * fast/css/parsing-text-emphasis-expected.txt:
      * fast/css/parsing-text-emphasis.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1905670
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX · 34ed90c5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102867
      
      Patch by Jongseok Yang <js45.yang@samsung.com> on 2012-11-21
      Reviewed by Gyuyoung Kim.
      
      Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX.
      
      ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word
      because ewk_view_setting_encoding_custom_set triggers the "reload" operation.
      And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings.
      
      Source/WebKit2:
      
      * UIProcess/API/efl/ewk_view.cpp:
      (ewk_view_encoding_custom_get):
      (ewk_view_encoding_custom_set):
      * UIProcess/API/efl/ewk_view.h:
      * UIProcess/API/efl/tests/test_ewk2_view.cpp:
      (TEST_F):
      
      Tools:
      
      * MiniBrowser/efl/main.c:
      (on_key_down):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34ed90c5
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, unskip now passing tests. · b38ae543
      ossy@webkit.org authored
      * platform/qt-5.0-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b38ae543
    • haraken@chromium.org's avatar
      Unreviewed. Build fix. · 8c4b1c0c
      haraken@chromium.org authored
      * bindings/v8/custom/V8BlobCustom.cpp:
      (WebCore::V8Blob::constructorCallbackCustom):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c4b1c0c
    • haraken@chromium.org's avatar
      [V8] Rename v8/custom/*Constructor.cpp to v8/custom/*Custom.cpp · 87288d3f
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102881
      
      Reviewed by Adam Barth.
      
      Writing constructorCallback()s in *Custom.cpp is a convention of
      custom bindings of JSC and V8. We can rename v8/custom/*Constructor.cpp
      to v8/custom/*Custom.cpp.
      
      No tests. No change in behavior.
      
      * UseV8.cmake: This file is already out of sync.
      * WebCore.gypi:
      * bindings/v8/custom/V8IntentCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp.
      (WebCore):
      (WebCore::V8Intent::constructorCallbackCustom):
      * bindings/v8/custom/V8MessageChannelCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MessageChannelConstructor.cpp.
      (WebCore):
      (WebCore::V8MessageChannel::constructorCallbackCustom):
      * bindings/v8/custom/V8WebKitPointCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitPointConstructor.cpp.
      (WebCore):
      (WebCore::V8WebKitPoint::constructorCallbackCustom):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87288d3f
    • commit-queue@webkit.org's avatar
      [V8] Inspector does not callback IDB methods in context · 6bcd0b33
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101725
      
      Patch by Dan Carney <dcarney@google.com> on 2012-11-21
      Reviewed by Adam Barth.
      
      Inserted v8 context before calling out to IDB.
      
      No new tests.
      
      * inspector/InspectorIndexedDBAgent.cpp:
      (WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
      (WebCore::InspectorIndexedDBAgent::requestDatabase):
      (WebCore::InspectorIndexedDBAgent::requestData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bcd0b33
    • commit-queue@webkit.org's avatar
      REGRESSION(134048): TiledBackingStore must create tiles when the contents rect is changed. · fc53c246
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102035
      
      Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
      Reviewed by Kenneth Rohde Christiansen.
      
      Before r134048, the visibleRect contained information of both the viewport and
      the contents rect. Now the visible rect is related to only the viewport. So
      TiledBackingStore::coverWithTilesIfNeeded() early returns even if the contents
      rect is changed, because changing the contents rect is independent on changing
      both a trajectory vector and the visible rect.
      
      * platform/graphics/TiledBackingStore.cpp:
      (WebCore::TiledBackingStore::coverWithTilesIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc53c246
    • dgrogan@chromium.org's avatar
      IndexedDB: remove setVersion from inspector tests · 4a0fc515
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102850
      
      Reviewed by Vsevolod Vlasov.
      
      setVersion was contained so the conversion to upgradeneeded was
      straightforward.
      
      * http/tests/inspector/indexeddb/database-data-expected.txt:
      * http/tests/inspector/indexeddb/database-structure-expected.txt:
      * http/tests/inspector/indexeddb/indexeddb-test.js:
      (.request.onsuccess.onSuccess.request.onupgradeneeded):
      (.request.onsuccess.onSuccess.request.onsuccess):
      (.request.onsuccess):
      (doWithVersionTransaction):
      * http/tests/inspector/indexeddb/resources-panel-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a0fc515
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r135307. · 25f4d96d
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/135307
      https://bugs.webkit.org/show_bug.cgi?id=102905
      
      Jussi said this doesn't definitively fix things, so revert for
      now. (Requested by rakuco on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21
      
      * animations/resources/stop-animation-on-suspend-subframe.html:
      * animations/stop-animation-on-suspend.html:
      * platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt: Added.
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt-arm/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25f4d96d
    • vsevik@chromium.org's avatar
      Web Inspector: Request preview tuning: enable json preview for text/html XHRs · 39fe71ca
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102892
      
      Reviewed by Alexander Pavlov.
      
      * inspector/front-end/RequestPreviewView.js:
      (WebInspector.RequestPreviewView.prototype._jsonView):
      (WebInspector.RequestPreviewView.prototype._htmlView):
      (WebInspector.RequestPreviewView.prototype._createPreviewView):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39fe71ca
    • haraken@chromium.org's avatar
      [V8] Remove manually written v8::TryCatches in custom bindings · 1ebe789a
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102883
      
      Reviewed by Adam Barth.
      
      We can replace them with the EXCEPTION_BLOCK() macro or its friends.
      
      No new tests. This patch shouldn't change any behavior.
      
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::handlePostMessageCallback):
      * bindings/v8/custom/V8DocumentCustom.cpp:
      (WebCore::V8Document::evaluateCallback):
      * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
      (WebCore::V8HTMLOptionsCollection::addCallback):
      * bindings/v8/custom/V8HistoryCustom.cpp:
      (WebCore::V8History::pushStateCallback):
      (WebCore::V8History::replaceStateCallback):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ebe789a
    • haraken@chromium.org's avatar
      Unreviewed, rolling out r135358. · 1da3c132
      haraken@chromium.org authored
      http://trac.webkit.org/changeset/135358
      https://bugs.webkit.org/show_bug.cgi?id=102881
      
      It broke Chromium/Linux build
      
      * UseV8.cmake:
      * WebCore.gypi:
      * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementCustom.cpp.
      (WebCore):
      (WebCore::v8HTMLImageElementConstructorCallback):
      (WebCore::V8HTMLImageElementConstructor::GetTemplate):
      * bindings/v8/custom/V8HTMLImageElementConstructor.h: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementCustom.h.
      (WebCore):
      (V8HTMLImageElementConstructor):
      * bindings/v8/custom/V8IntentConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp.
      (WebCore):
      (WebCore::V8Intent::constructorCallbackCustom):
      * bindings/v8/custom/V8MessageChannelConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp.
      (WebCore):
      (WebCore::V8MessageChannel::constructorCallbackCustom):
      * bindings/v8/custom/V8WebKitPointConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitPointCustom.cpp.
      (WebCore):
      (WebCore::V8WebKitPoint::constructorCallbackCustom):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1da3c132
    • commit-queue@webkit.org's avatar
      Unused parameters on ScrollingCoordinator.cpp · 0df4842a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102884
      
      Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-21
      Reviewed by Kentaro Hara.
      
      Because the 'scrollingLayerPositionAction' parameter is not used when !USE(ACCELERATED_COMPOSITING),
      use UNUSED_PARAM macro to fix build warning -Wunused-parameter
      
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0df4842a
    • haraken@chromium.org's avatar
      [V8] Replace V8Parameter::prepare() with V8Parameter::operator=() · 9f11c6cf
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102870
      
      Reviewed by Adam Barth.
      
      This is an incremental step for V8Parameter refactoring.
      By replacing V8Parameter::prepare() with V8Parameter::operator=(),
      we can make EXCEPTION_BLOCK() and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
      equivalent (except for a return value).
      
      Tests: fast/workers/worker-constructor.html
             storage/websql/sql-error-codes.html
             inspector/console/alert-toString-exception.html
             http/tests/websocket/tests/hybi/send-throw.html
      
      * bindings/v8/V8BindingMacros.h:
      * bindings/v8/V8StringResource.h:
      (WebCore::V8Parameter::V8Parameter):
      (V8Parameter):
      (WebCore::=):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f11c6cf
    • haraken@chromium.org's avatar
      [V8] Rename v8/custom/*Constructor.cpp to v8/custom/*Custom.cpp · 9c1149e9
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102881
      
      Reviewed by Adam Barth.
      
      Writing constructorCallback()s in *Custom.cpp is a convention of
      custom bindings of JSC and V8. We can rename v8/custom/*Constructor.cpp
      to v8/custom/*Custom.cpp.
      
      No tests. No change in behavior.
      
      * UseV8.cmake: This file is already out of sync.
      * WebCore.gypi:
      * bindings/v8/custom/V8HTMLImageElementCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp.
      (WebCore):
      (WebCore::v8HTMLImageElementConstructorCallback):
      (WebCore::V8HTMLImageElementConstructor::GetTemplate):
      * bindings/v8/custom/V8HTMLImageElementCustom.h: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.h.
      (WebCore):
      (V8HTMLImageElementConstructor):
      * bindings/v8/custom/V8IntentCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp.
      (WebCore):
      (WebCore::V8Intent::constructorCallbackCustom):
      * bindings/v8/custom/V8MessageChannelCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MessageChannelConstructor.cpp.
      (WebCore):
      (WebCore::V8MessageChannel::constructorCallbackCustom):
      * bindings/v8/custom/V8WebKitPointCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitPointConstructor.cpp.
      (WebCore):
      (WebCore::V8WebKitPoint::constructorCallbackCustom):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c1149e9
    • commit-queue@webkit.org's avatar
      Web Inspector: [Canvas] throttle wait icon in the ui · f0e6cc8e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102685
      
      Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-21
      Reviewed by Vsevolod Vlasov.
      
      Do not show the wait icon for small operations during the replay to reduce flickering.
      
      * inspector/front-end/CanvasProfileView.js:
      (WebInspector.CanvasProfileView.prototype._enableWaitIcon):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0e6cc8e
    • yurys@chromium.org's avatar
      Unreviewed. Updated test expectations. · c1b1e422
      yurys@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1b1e422
    • commit-queue@webkit.org's avatar
      Enable datalist UI for input types datetime and datetime-local · 8318dce5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102882
      
      Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-21
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      Enabling datalist UI for input types datetime and datetime-local.
      
      No new tests yet. Tests will be added later in Bug 102888.
      
      * platform/text/PlatformLocale.cpp:
      (WebCore::Locale::formatDateTime): Support datetime and datetime-local types.
      * rendering/RenderThemeChromiumCommon.cpp:
      (WebCore::RenderThemeChromiumCommon::supportsDataListUI): Add datetime and datetimelocal to the list.
      
      LayoutTests:
      
      Removed expectation of failure.
      
      * platform/chromium/fast/forms/datalist/input-list-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8318dce5
  2. 20 Nov, 2012 12 commits
    • haraken@chromium.org's avatar
      [V8] Remove v8/custom/V8XMLHttpRequestConstructor.cpp · c2504e9e
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102876
      
      Reviewed by Sam Weinig.
      
      It doesn't make sense to have one custom cpp file for
      XXX::constructorCallback() only. We can move XXX::constructorCallback()
      in v8/custom/V8XXXConstructor.cpp to v8/custom/V8XXXCustom.cpp
      and thus remove v8/custom/V8XXXConstructor.cpp.
      
      Note: Some XXX::constructorCallback()s are already written in
      v8/custom/V8XXXCustom.cpp. JSC already has almost all
      XXX::constructorCallback()s in js/JSXXXCustom.cpp.
      
      No tests. No change in behavior.
      
      * UseV8.cmake:
      * WebCore.gypi:
      * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: Removed.
      * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
      (WebCore::V8XMLHttpRequest::constructorCallbackCustom):
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2504e9e
    • yurys@chromium.org's avatar
      Unreviewed. Fixed webkit_lint complaints about overlapping entries in Chromium TestExpectations. · 53e6fafa
      yurys@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53e6fafa
    • ossy@webkit.org's avatar
      [Qt] Unreviewed morning gardening, skip a new security · 24fd9577
      ossy@webkit.org authored
      timeouting test to paint the bots green.
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24fd9577
    • haraken@chromium.org's avatar
      Unreviewed. Rebaselined run-bindings-tests. · 9fe36c4b
      haraken@chromium.org authored
      * bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
      * bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp:
      * bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
      * bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp:
      * bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
      * bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp:
      * bindings/scripts/test/CPP/WebDOMTestException.cpp:
      * bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
      * bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:
      * bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:
      * bindings/scripts/test/CPP/WebDOMTestNode.cpp:
      * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
      * bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.cpp:
      * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetter):
      (WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetter):
      (WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
      (WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
      (WebCore::TestObjV8Internal::withScriptStateVoidCallback):
      (WebCore::TestObjV8Internal::withScriptStateObjCallback):
      (WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
      (WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateCallback):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fe36c4b
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r133859. · ebdffaf4
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/133859
      https://bugs.webkit.org/show_bug.cgi?id=102875
      
      This patch makes API test broken (Requested by gyuyoung on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20
      
      .:
      
      * Source/cmake/OptionsEfl.cmake:
      
      Tools:
      
      * Scripts/webkitperl/FeatureList.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ebdffaf4
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Remove unnecessary #include in API test · 0e673390
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102674
      
      Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-20
      Reviewed by Laszlo Gombos.
      
      Removed duplicated header files from the API test cases.
      Now, EWK2UnitTestBase.h includes the basic header files,
      so test cases may only include this one and add the addtional
      header files if necessary.
      
      * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
      * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
      * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp:
      * UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
      * UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
      * UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
      * UIProcess/API/efl/tests/test_ewk2_context.cpp:
      * UIProcess/API/efl/tests/test_ewk2_context_history_callbacks.cpp:
      * UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
      * UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
      * UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
      * UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:
      * UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
      * UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
      * UIProcess/API/efl/tests/test_ewk2_intents.cpp:
      * UIProcess/API/efl/tests/test_ewk2_object.cpp:
      * UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp:
      * UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp:
      * UIProcess/API/efl/tests/test_ewk2_settings.cpp:
      * UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
      * UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
      * UIProcess/API/efl/tests/test_ewk2_view.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e673390
    • commit-queue@webkit.org's avatar
      [EFL][WK2][WTR] Unskip passed cases under css3/device-adapt/opera/ · f891e710
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102868
      
      Unreviewed, EFL gardening.
      
      As BUG 102517 has been resolved, we can move those from EFL common to WK1 only.
      
      Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-20
      
      * platform/efl-wk1/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f891e710
    • weinig@apple.com's avatar
      Simplify WebConnection by removing its underlying CoreIPC::Connection · b59f55fc
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=102771
      
      Reviewed by Anders Carlsson.
      
      Instead of having WebConnection subclasses own the CoreIPC::Connection,
      move back to having the WebProcess and WebProcessProxy own it (and be
      its Connection::Client) and use the new MessageReceiver class to vend
      messages to the WebConnection.
      
      * Shared/WebConnection.cpp:
      (WebKit::WebConnection::WebConnection):
      (WebKit::WebConnection::postMessage):
      (WebKit::WebConnection::didClose):
      (WebKit::WebConnection::didReceiveMessage):
      * Shared/WebConnection.h:
      Make WebConnection both a MessageReceiver and MessageSender
      and add virtual functions for derived classes to fill in.
      
      * UIProcess/WebConnectionToWebProcess.cpp:
      (WebKit::WebConnectionToWebProcess::create):
      (WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):
      (WebKit::WebConnectionToWebProcess::invalidate):
      (WebKit::WebConnectionToWebProcess::decodeMessageBody):
      (WebKit::WebConnectionToWebProcess::connection):
      (WebKit::WebConnectionToWebProcess::destinationID):
      (WebKit::WebConnectionToWebProcess::hasValidConnection):
      * UIProcess/WebConnectionToWebProcess.h:
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::~WebProcessProxy):
      (WebKit::WebProcessProxy::fromConnection):
      (WebKit::WebProcessProxy::disconnect):
      (WebKit::WebProcessProxy::addMessageReceiver):
      (WebKit::WebProcessProxy::didClose):
      (WebKit::WebProcessProxy::didReceiveInvalidMessage):
      (WebKit::WebProcessProxy::didFinishLaunching):
      * UIProcess/WebProcessProxy.h:
      (WebKit::WebProcessProxy::connection):
      (WebProcessProxy):
      (WebKit::WebProcessProxy::webConnection):
      * WebProcess/WebConnectionToUIProcess.cpp:
      (WebKit::WebConnectionToUIProcess::create):
      (WebKit::WebConnectionToUIProcess::WebConnectionToUIProcess):
      (WebKit):
      (WebKit::WebConnectionToUIProcess::invalidate):
      (WebKit::WebConnectionToUIProcess::connection):
      (WebKit::WebConnectionToUIProcess::destinationID):
      (WebKit::WebConnectionToUIProcess::hasValidConnection):
      * WebProcess/WebConnectionToUIProcess.h:
      (WebConnectionToUIProcess):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initialize):
      (WebKit::WebProcess::terminate):
      * WebProcess/WebProcess.h:
      (WebKit::WebProcess::connection):
      (WebKit::WebProcess::webConnectionToUIProcess):
      Move the CoreIPC::Connection back to the processes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b59f55fc
    • haraken@chromium.org's avatar
      [V8] Introduce constructorCallbackCustom() · 78cdbc0e
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102763
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Currently custom constructors have the following code:
      
        v8::Handle<v8::Value> V8XXX::constructorCallback(const v8::Arguments& args) {
          INC_STATS("DOM.XXX.Constructor");
          if (!args.IsConstructCall())
            return throwTypeError("DOM object constructor cannot be called as a function.", args.GetIsolate());
          if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)
            return args.Holder();
      
          /* body of the constructor */;
        }
      
      To avoid duplicating the same logic in all custom constructors,
      this patch changes the generated code as follows:
      
        // Generated automatically
        v8::Handle<v8::Value> V8XXX::constructorCallback(const v8::Arguments& args) {
          INC_STATS("DOM.XXX.Constructor");
          ${maybeObserveFeature}  // Newly supported for custom constructors.
          if (!args.IsConstructCall())
            return throwTypeError("DOM object constructor cannot be called as a function.", args.GetIsolate());
          if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)
            return args.Holder();
      
          V8XXX::constructorCallbackCustom(args);
        }
      
        // Written manually
        v8::Handle<v8::Value> V8XXX::constructorCallback(const v8::Arguments& args) {
          /* body of the constructor */;
        }
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateHeader):
      (HasCustomConstructor):
      (GenerateCustomConstructorCallback):
      (GenerateImplementation):
      * bindings/scripts/test/V8/V8TestEventConstructor.cpp:
      (WebCore::V8TestEventConstructor::constructorCallback):
      * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
      (WebCore::V8TestNamedConstructorConstructorCallback):
      * bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
      (WebCore::V8TestOverloadedConstructors::constructorCallback):
      * bindings/v8/custom/V8ArrayBufferCustom.cpp:
      (WebCore::V8ArrayBuffer::constructorCallbackCustom):
      * bindings/v8/custom/V8AudioContextCustom.cpp:
      (WebCore::V8AudioContext::constructorCallbackCustom):
      * bindings/v8/custom/V8BlobCustom.cpp:
      (WebCore::V8Blob::constructorCallbackCustom):
      * bindings/v8/custom/V8DOMFormDataCustom.cpp:
      (WebCore::V8DOMFormData::constructorCallbackCustom):
      * bindings/v8/custom/V8DataViewCustom.cpp:
      (WebCore::V8DataView::constructorCallbackCustom):
      * bindings/v8/custom/V8IntentConstructor.cpp:
      (WebCore::V8Intent::constructorCallbackCustom):
      * bindings/v8/custom/V8MessageChannelConstructor.cpp:
      (WebCore::V8MessageChannel::constructorCallbackCustom):
      * bindings/v8/custom/V8MutationObserverCustom.cpp:
      (WebCore::V8MutationObserver::constructorCallbackCustom):
      * bindings/v8/custom/V8WebKitPointConstructor.cpp:
      (WebCore::V8WebKitPoint::constructorCallbackCustom):
      * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
      (WebCore::V8XMLHttpRequest::constructorCallbackCustom):
      
      LayoutTests:
      
      Updated a test result.
      
      * platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78cdbc0e
    • commit-queue@webkit.org's avatar
      REGRESSION(r135263): Fix a wrong argument for udat_close · c4e6a7aa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102856
      
      Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-20
      Reviewed by Kent Tamura.
      
      Fixed a bug that passed wrong pointer to udat_close.
      
      No new tests. No changes in behavior.
      
      * platform/text/LocaleICU.cpp:
      (WebCore::LocaleICU::initializeDateTimeFormat): Close correct object.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4e6a7aa
    • gyuyoung.kim@samsung.com's avatar
      Add Samsung to security vendor member list · 1d09c96b
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=102863
      
      Reviewed by Sam Weinig.
      
      * security/security-group-members.html: Add Samsung members.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d09c96b
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Add Ewk_Window_Features API and related UI callbacks · 92981272
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99114
      
      Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-20
      Reviewed by Gyuyoung Kim.
      
      Source/WebKit2:
      
      Added Ewk_Window_Features API so that we can create new windows
      with various window features such as location, size, toolbar, menubar,
      statusbar, locationbar, scrollbar, resizable, and fullscreen.
      
      UI client callbacks related to window features also implemented
      so that it is possible to retrieve the window object property values.
      
      * PlatformEfl.cmake:
      * UIProcess/API/efl/EWebKit2.h:
      * UIProcess/API/efl/EwkViewCallbacks.h:
      (EwkViewCallbacks):
      * UIProcess/API/efl/EwkViewImpl.cpp:
      (EwkViewImpl::windowFeatures):
      (EwkViewImpl::createNewPage):
      (EwkViewImpl::closePage):
      * UIProcess/API/efl/EwkViewImpl.h:
      (EwkViewImpl):
      * UIProcess/API/efl/ewk_view.h:
      * UIProcess/efl/PageUIClientEfl.cpp:
      (WebKit::PageUIClientEfl::createNewPage):
      (WebKit::PageUIClientEfl::toolbarsAreVisible):
      (WebKit):
      (WebKit::PageUIClientEfl::setToolbarsAreVisible):
      (WebKit::PageUIClientEfl::menuBarIsVisible):
      (WebKit::PageUIClientEfl::setMenuBarIsVisible):
      (WebKit::PageUIClientEfl::statusBarIsVisible):
      (WebKit::PageUIClientEfl::setStatusBarIsVisible):
      (WebKit::PageUIClientEfl::isResizable):
      (WebKit::PageUIClientEfl::setIsResizable):
      (WebKit::PageUIClientEfl::PageUIClientEfl):
      * UIProcess/efl/PageUIClientEfl.h:
      (PageUIClientEfl):
      
      Tools:
      
      Implemented window_create and window_close smartcallback functions.
      
      * MiniBrowser/efl/main.c:
      (on_window_create):
      (on_window_close):
      (window_create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92981272