1. 11 Nov, 2006 5 commits
    • ap's avatar
      2006-11-11 Nikolas Zimmermann <zimmermann@kde.org> · 08a5a1ee
      ap authored
              Reviewed by aroben and ap, landed by ap.
      
              Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468
      
              Group graphics related files in platform/graphics.
              Move certain files from certain subdirectories
              into platform/graphics/{win,mac,cg,gdk,qt}
      
              * CMakeLists.txt:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/AffineTransform.cpp: Removed.
              * platform/AffineTransform.h: Removed.
              * platform/Color.cpp: Removed.
              * platform/Color.h: Removed.
              * platform/FloatPoint.cpp: Removed.
              * platform/FloatPoint.h: Removed.
              * platform/FloatRect.cpp: Removed.
              * platform/FloatRect.h: Removed.
              * platform/FloatSize.cpp: Removed.
              * platform/FloatSize.h: Removed.
              * platform/Icon.h: Removed.
              * platform/Image.cpp: Removed.
              * platform/Image.h: Removed.
              * platform/ImageSource.h: Removed.
              * platform/IntPoint.h: Removed.
              * platform/IntRect.cpp: Removed.
              * platform/IntRect.h: Removed.
              * platform/IntSize.h: Removed.
              * platform/IntSizeHash.h: Removed.
              * platform/Path.cpp: Removed.
              * platform/Path.h: Removed.
              * platform/Pen.cpp: Removed.
              * platform/Pen.h: Removed.
              * platform/cairo/AffineTransformCairo.cpp: Removed.
              * platform/cairo/GraphicsContextCairo.cpp: Removed.
              * platform/cairo/ImageCairo.cpp: Removed.
              * platform/cairo/ImageSourceCairo.cpp: Removed.
              * platform/cairo/cairo/AUTHORS: Removed.
              * platform/cairo/cairo/COPYING: Removed.
              * platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
              * platform/cairo/cairo/COPYING-MPL-1.1: Removed.
              * platform/cairo/cairo/INSTALL: Removed.
              * platform/cairo/cairo/NEWS: Removed.
              * platform/cairo/cairo/README: Removed.
              * platform/cairo/cairo/TODO: Removed.
              * platform/cairo/cairo/src/Makefile.in: Removed.
              * platform/cairo/cairo/src/cairo-arc-private.h: Removed.
              * platform/cairo/cairo/src/cairo-arc.c: Removed.
              * platform/cairo/cairo/src/cairo-array.c: Removed.
              * platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
              * platform/cairo/cairo/src/cairo-atsui.h: Removed.
              * platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
              * platform/cairo/cairo/src/cairo-beos.h: Removed.
              * platform/cairo/cairo/src/cairo-cache-private.h: Removed.
              * platform/cairo/cairo/src/cairo-cache.c: Removed.
              * platform/cairo/cairo/src/cairo-clip-private.h: Removed.
              * platform/cairo/cairo/src/cairo-clip.c: Removed.
              * platform/cairo/cairo/src/cairo-color.c: Removed.
              * platform/cairo/cairo/src/cairo-debug.c: Removed.
              * platform/cairo/cairo/src/cairo-debug.h: Removed.
              * platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-directfb.h: Removed.
              * platform/cairo/cairo/src/cairo-features.h: Removed.
              * platform/cairo/cairo/src/cairo-features.h.in: Removed.
              * platform/cairo/cairo/src/cairo-fixed.c: Removed.
              * platform/cairo/cairo/src/cairo-font-options.c: Removed.
              * platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
              * platform/cairo/cairo/src/cairo-font-subset.c: Removed.
              * platform/cairo/cairo/src/cairo-font.c: Removed.
              * platform/cairo/cairo/src/cairo-ft-font.c: Removed.
              * platform/cairo/cairo/src/cairo-ft-private.h: Removed.
              * platform/cairo/cairo/src/cairo-ft.h: Removed.
              * platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-glitz.h: Removed.
              * platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
              * platform/cairo/cairo/src/cairo-gstate.c: Removed.
              * platform/cairo/cairo/src/cairo-hash-private.h: Removed.
              * platform/cairo/cairo/src/cairo-hash.c: Removed.
              * platform/cairo/cairo/src/cairo-hull.c: Removed.
              * platform/cairo/cairo/src/cairo-image-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-matrix.c: Removed.
              * platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
              * platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-output-stream.c: Removed.
              * platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
              * platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
              * platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
              * platform/cairo/cairo/src/cairo-path-data.c: Removed.
              * platform/cairo/cairo/src/cairo-path-fill.c: Removed.
              * platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
              * platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
              * platform/cairo/cairo/src/cairo-path.c: Removed.
              * platform/cairo/cairo/src/cairo-pattern.c: Removed.
              * platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-pdf.h: Removed.
              * platform/cairo/cairo/src/cairo-pen.c: Removed.
              * platform/cairo/cairo/src/cairo-platform.h: Removed.
              * platform/cairo/cairo/src/cairo-png.c: Removed.
              * platform/cairo/cairo/src/cairo-polygon.c: Removed.
              * platform/cairo/cairo/src/cairo-private.h: Removed.
              * platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-ps.h: Removed.
              * platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
              * platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-quartz.h: Removed.
              * platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-quartz2.h: Removed.
              * platform/cairo/cairo/src/cairo-region.c: Removed.
              * platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
              * platform/cairo/cairo/src/cairo-slope.c: Removed.
              * platform/cairo/cairo/src/cairo-spline.c: Removed.
              * platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
              * platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
              * platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
              * platform/cairo/cairo/src/cairo-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-svg.h: Removed.
              * platform/cairo/cairo/src/cairo-traps.c: Removed.
              * platform/cairo/cairo/src/cairo-unicode.c: Removed.
              * platform/cairo/cairo/src/cairo-wideint.c: Removed.
              * platform/cairo/cairo/src/cairo-wideint.h: Removed.
              * platform/cairo/cairo/src/cairo-win32-font.c: Removed.
              * platform/cairo/cairo/src/cairo-win32-private.h: Removed.
              * platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-win32.h: Removed.
              * platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
              * platform/cairo/cairo/src/cairo-xcb.h: Removed.
              * platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
              * platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
              * platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
              * platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
              * platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
              * platform/cairo/cairo/src/cairo-xlib.h: Removed.
              * platform/cairo/cairo/src/cairo.c: Removed.
              * platform/cairo/cairo/src/cairo.h: Removed.
              * platform/cairo/cairo/src/cairoint.h: Removed.
              * platform/cairo/cairo/src/test-fallback-surface.c: Removed.
              * platform/cairo/cairo/src/test-fallback-surface.h: Removed.
              * platform/cairo/cairo/src/test-meta-surface.c: Removed.
              * platform/cairo/cairo/src/test-meta-surface.h: Removed.
              * platform/cairo/cairo/src/test-paginated-surface.c: Removed.
              * platform/cairo/cairo/src/test-paginated-surface.h: Removed.
              * platform/cairo/pixman/AUTHORS: Removed.
              * platform/cairo/pixman/COPYING: Removed.
              * platform/cairo/pixman/README: Removed.
              * platform/cairo/pixman/src/Makefile.in: Removed.
              * platform/cairo/pixman/src/fbcompose.c: Removed.
              * platform/cairo/pixman/src/fbedge.c: Removed.
              * platform/cairo/pixman/src/fbedgeimp.h: Removed.
              * platform/cairo/pixman/src/fbmmx.c: Removed.
              * platform/cairo/pixman/src/fbmmx.h: Removed.
              * platform/cairo/pixman/src/fbpict.c: Removed.
              * platform/cairo/pixman/src/fbpict.h: Removed.
              * platform/cairo/pixman/src/fbtrap.c: Removed.
              * platform/cairo/pixman/src/icblt.c: Removed.
              * platform/cairo/pixman/src/icbltone.c: Removed.
              * platform/cairo/pixman/src/iccolor.c: Removed.
              * platform/cairo/pixman/src/icformat.c: Removed.
              * platform/cairo/pixman/src/icimage.c: Removed.
              * platform/cairo/pixman/src/icimage.h: Removed.
              * platform/cairo/pixman/src/icint.h: Removed.
              * platform/cairo/pixman/src/icpixels.c: Removed.
              * platform/cairo/pixman/src/icrect.c: Removed.
              * platform/cairo/pixman/src/icrop.h: Removed.
              * platform/cairo/pixman/src/icstipple.c: Removed.
              * platform/cairo/pixman/src/ictransform.c: Removed.
              * platform/cairo/pixman/src/ictrap.c: Removed.
              * platform/cairo/pixman/src/ictri.c: Removed.
              * platform/cairo/pixman/src/icutil.c: Removed.
              * platform/cairo/pixman/src/pixman-remap.h: Removed.
              * platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
              * platform/cairo/pixman/src/pixman.h: Removed.
              * platform/cairo/pixman/src/pixregion.c: Removed.
              * platform/cairo/pixman/src/pixregionint.h: Removed.
              * platform/cairo/pixman/src/renderedge.c: Removed.
              * platform/cairo/pixman/src/renderedge.h: Removed.
              * platform/cairo/pixman/src/slim_internal.h: Removed.
              * platform/cairo/rgb24-hacks.txt: Removed.
              * platform/cairo/scale-removal.txt: Removed.
              * platform/cg/AffineTransformCG.cpp: Removed.
              * platform/cg/FloatPointCG.cpp: Removed.
              * platform/cg/FloatRectCG.cpp: Removed.
              * platform/cg/FloatSizeCG.cpp: Removed.
              * platform/cg/GraphicsContextCG.cpp: Removed.
              * platform/cg/GraphicsContextPlatformPrivate.h: Removed.
              * platform/cg/ImageCG.cpp: Removed.
              * platform/cg/ImageSourceCG.cpp: Removed.
              * platform/cg/IntPointCG.cpp: Removed.
              * platform/cg/IntRectCG.cpp: Removed.
              * platform/cg/IntSizeCG.cpp: Removed.
              * platform/cg/PDFDocumentImage.cpp: Removed.
              * platform/cg/PDFDocumentImage.h: Removed.
              * platform/cg/PathCG.cpp: Removed.
              * platform/gdk/ImageGdk.cpp: Removed.
              * platform/mac/ColorMac.mm: Removed.
              * platform/mac/FloatPointMac.mm: Removed.
              * platform/mac/FloatRectMac.mm: Removed.
              * platform/mac/FloatSizeMac.mm: Removed.
              * platform/mac/GraphicsContextMac.mm:
              * platform/mac/IconMac.mm: Removed.
              * platform/mac/ImageMac.mm: Removed.
              * platform/mac/IntPointMac.mm: Removed.
              * platform/mac/IntRectMac.mm: Removed.
              * platform/mac/IntSizeMac.mm: Removed.
              * platform/qt/AffineTransformQt.cpp: Removed.
              * platform/qt/ColorQt.cpp: Removed.
              * platform/qt/FloatPointQt.cpp: Removed.
              * platform/qt/FloatRectQt.cpp: Removed.
              * platform/qt/IconQt.cpp: Removed.
              * platform/qt/ImageQt.cpp: Removed.
              * platform/qt/ImageSourceQt.cpp: Removed.
              * platform/qt/IntPointQt.cpp: Removed.
              * platform/qt/IntRectQt.cpp: Removed.
              * platform/qt/IntSizeQt.cpp: Removed.
              * platform/qt/PathQt.cpp: Removed.
              * platform/win/ImageWin.cpp: Removed.
              * platform/win/IntPointWin.cpp: Removed.
              * platform/win/IntRectWin.cpp: Removed.
              * platform/win/IntSizeWin.cpp: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08a5a1ee
    • gdennis's avatar
      Build fix. · d1f21df8
      gdennis authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1f21df8
    • gdennis's avatar
      WebCore: · 513de063
      gdennis authored
              Reviewed by hyatt.
      
              A layout test was added when this bug was fixed, so none needed now.
              
              Cleanup after:
              REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
              http://bugs.webkit.org/show_bug.cgi?id=11570
              
              * rendering/RenderStyle.h:
              (WebCore::RenderStyle::isSpace): Removed.
              * rendering/RenderText.cpp:
              (WebCore::isSpace): Added.
              (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      513de063
    • gdennis's avatar
      WebCore: · d2cf99ed
      gdennis authored
              Reviewed by mitz.
              
              REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
              http://bugs.webkit.org/show_bug.cgi?id=11570
      
              * rendering/RenderStyle.h:
              (WebCore::RenderStyle::isSpace): Added.
              * rendering/RenderText.cpp:
              (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths, 
              treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'
      
      LayoutTests:
      
              Reviewed by mitz.
      
              REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
              http://bugs.webkit.org/show_bug.cgi?id=11570
      
              * fast/text/whitespace/nbsp-mode-and-linewraps-expected.checksum: Added.
              * fast/text/whitespace/nbsp-mode-and-linewraps-expected.png: Added.
              * fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt: Added.
              * fast/text/whitespace/nbsp-mode-and-linewraps.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2cf99ed
    • ap's avatar
      Reviewed by Maciej. · 371ebcdf
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=11508
              Undisable some warnings for JSImmediate.h
      
              Fix suggested by Don Gibson.
      
              * kjs/JSImmediate.h:
              Re-enable all MSVC warnings, move the remaining runtime checks
              to compile-time.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      371ebcdf
  2. 10 Nov, 2006 17 commits
    • bdash's avatar
      2006-11-10 Zalan Bujtas <zalan.bujtas@nokia.com> · 880df151
      bdash authored
              Reviewed by Maciej.
      
              Added s60/symbian platform defines.
              http://bugs.webkit.org/show_bug.cgi?id=11540
      
              * wtf/Platform.h:
      2006-11-10  Zalan Bujtas <zalan.bujtas@nokia.com>
      
              Reviewed by Maciej.
      
              Added basic types for symbian platform.
              http://bugs.webkit.org/show_bug.cgi?id=11540
      
              * config.h:
              * platform/AtomicString.h:
              (WebCore::AtomicString::AtomicString):
              (WebCore::AtomicString::operator TPtrC):
              * platform/DeprecatedString.cpp:
              (WebCore::initializeHandleNodeBlock):
              * platform/DeprecatedString.h: char _internalBuffer has to be in front of
                the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with
                bitfields and breaks byte aligment
              * platform/FloatPoint.h:
              * platform/FloatRect.h:
              * platform/IntPoint.h:
              * platform/IntRect.h:
              * platform/IntSize.h:
              * platform/PlatformString.h:
              (WebCore::String::operator TPtrC):
              (WebCore::String::des):
              * platform/StringImpl.h:
              * platform/symbian/DeprecatedStringSymbian.cpp: Added.
              (WebCore::DeprecatedString::setBufferFromDes):
              (WebCore::DeprecatedString::fromDes):
              (WebCore::DeprecatedString::des):
              (WebCore::DeprecatedString::des8):
              * platform/symbian/FloatPointSymbian.cpp: Added.
              (WebCore::FloatPoint::FloatPoint):
              (WebCore::FloatPoint::operator TPoint):
              * platform/symbian/FloatRectSymbian.cpp: Added.
              (WebCore::FloatRect::FloatRect):
              (WebCore::FloatRect::operator TRect):
              (WebCore::FloatRect::rect):
              * platform/symbian/IntPointSymbian.cpp: Added.
              (WebCore::IntPoint::IntPoint):
              (WebCore::IntPoint::operator TPoint):
              * platform/symbian/IntRectSymbian.cpp: Added.
              (WebCore::IntRect::IntRect):
              (WebCore::IntRect::operator TRect):
              (WebCore::IntRect::Rect):
              * platform/symbian/IntSizeSymbian.cpp: Added.
              (WebCore::IntSize::IntSize):
              (WebCore::IntSize::operator TSize):
              * platform/symbian/StringImplSymbian.cpp: Added.
              (WebCore::StringImpl::StringImpl):
              (WebCore::StringImpl::des):
              * platform/symbian/StringSymbian.cpp: Added.
              (WebCore::String::String):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      880df151
    • bdash's avatar
      2006-11-10 Zack Rusin <zack@kde.org> · c51d730c
      bdash authored
              Reviewed by Anders.
      
              Adjust to the changes Brady made in the Qt code.
      
              * loader/qt/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
              * loader/qt/FrameLoaderClientQt.h:
      2006-11-10  Zack Rusin  <zack@kde.org>
      
              Reviewed by Anders.
      
              Making the Qt code work after refactorings in WebCore.
      
              * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::checkLoaded):
              * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c51d730c
    • justing's avatar
      LayoutTests: · 5745f955
      justing authored
              Reviewed by harrison
              
              <rdar://problem/4069359>
              Deleting hyperlink text, then typing uses link typing style but loses the link itself
      
              * editing/deleting/delete-link-1-expected.checksum: Added.
              * editing/deleting/delete-link-1-expected.png: Added.
              * editing/deleting/delete-link-1-expected.txt: Added.
              * editing/deleting/delete-link-1.html: Added.
              * editing/inserting/insert-before-link-1-expected.checksum: Added.
              * editing/inserting/insert-before-link-1-expected.png: Added.
              * editing/inserting/insert-before-link-1-expected.txt: Added.
              * editing/inserting/insert-before-link-1.html: Added.
      
      WebCore:
      
              Reviewed by harrison
              
              <rdar://problem/4069359>
              Deleting hyperlink text, then typing uses link typing style but loses the link itself
              
              The removed anchor element needs to stick around temporarily, in the same way
              that the typing style hangs off the caret until the user moves it.  Also text
              insertion around anchors didn't match TextEdit.
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added.
              (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
              * editing/DeleteSelectionCommand.h:
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply): Clear the removed anchor after any top level
              editing command that doesn't preserve the typing style (matches TextEdit).
              * editing/Editor.cpp:
              (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call 
              setSelection with a message telling it to clear the typing style 
              (and the saved anchor) here.  Save/restore the saved anchor because of this.
              * editing/Editor.h:
              (WebCore::Editor::removedAnchor): Getter.
              (WebCore::Editor::setRemovedAnchor): Setter.
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor
              if one exists.
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::setSelection): Clear the removed anchor whenever
              we make a selection change that clears the typing style.
              (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
              * editing/htmlediting.cpp:
              (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and
              made some changes to match TextEdit's behavior.  First, insert content
              inside the anchor when the caret is after it, unless the caret is at the
              end of the document, or if the caret is before it and at the start of a 
              paragraph.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5745f955
    • thatcher's avatar
      Versioning. · 1d121c61
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d121c61
    • thatcher's avatar
      Reviewed by Hyatt. · 50c2a620
      thatcher authored
              Check for BHIDDEN in isVisible() also.
      
              * rendering/RenderStyle.h:
              (WebCore::BorderValue::isVisible):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50c2a620
    • thatcher's avatar
      Reviewed by Adam. · 96cb9c10
      thatcher authored
              <rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders
      
              Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().
      
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
              * rendering/RenderStyle.h:
              (WebCore::BorderValue::isVisible):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96cb9c10
    • thatcher's avatar
      Build fix. · 77ef664c
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77ef664c
    • thatcher's avatar
      f64d5abd
    • aroben's avatar
      Rubberstamped by Anders. · 8e9c8169
      aroben authored
              Back out some accidentally-committed changes from r17711.
      
              * page/Frame.cpp:
              (WebCore::Frame::command):
              (WebCore::FramePrivate::FramePrivate):
              * page/Frame.h:
              * page/FramePrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e9c8169
    • mjs's avatar
      Reviewed by Anders. · 3fb91842
      mjs authored
              
              - remove some unnecessary uses of WebDataProtocol
      
              * WebView/WebDataSource.mm: Remove the unneeded include.
              * WebView/WebView.mm:
              (+[WebView _canHandleRequest:]): Don't bother to check for unreachable URL here.
              Any request that has one will be an applewebdata: request, which will pass the check anyway.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fb91842
    • andersca's avatar
      WebCore: · 846d857a
      andersca authored
              Reviewed by Geoff.
      
              Add more commands, make toggleBold and toggleItalic executable commands.
      
              * WebCore.exp:
              * editing/Editor.cpp:
              (WebCore::execCopy):
              (WebCore::execCut):
              (WebCore::execDelete):
              (WebCore::execForwardDelete):
              (WebCore::execPaste):
              (WebCore::execSelectAll):
              (WebCore::execToggleBold):
              (WebCore::execToggleItalic):
              (WebCore::enabled):
              (WebCore::canPaste):
              (WebCore::hasEditableSelection):
              (WebCore::hasEditableRangeSelection):
              (WebCore::hasRangeSelection):
              (WebCore::hasRichlyEditableSelection):
              (WebCore::CommandEntry::):
              * editing/Editor.h:
      
      WebKit:
      
              Reviewed by Geoff.
      
              Update for changes to WebCore
              * WebView/WebHTMLView.m:
              (-[NSArray _applyStyleToSelection:withUndoAction:]):
              (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
              (-[NSArray _toggleBold]):
              (-[NSArray _toggleItalic]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      846d857a
    • ggaren's avatar
      Fixed platform #ifs · 57ca08d1
      ggaren authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57ca08d1
    • andersca's avatar
      WebCore: · 8fbad2f6
      andersca authored
              Reviewed by Maciej, Geoff.
      
              Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
              the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.
      
              * WebCore.exp:
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              * editing/Editor.cpp:
              (WebCore::execMoveBackward):
              (WebCore::execMoveBackwardAndModifySelection):
              (WebCore::execMoveDown):
              (WebCore::execMoveDownAndModifySelection):
              (WebCore::execMoveForward):
              (WebCore::execMoveForwardAndModifySelection):
              (WebCore::execMoveLeft):
              (WebCore::execMoveLeftAndModifySelection):
              (WebCore::execMoveRight):
              (WebCore::execMoveRightAndModifySelection):
              (WebCore::execMoveToBeginningOfDocument):
              (WebCore::execMoveToBeginningOfDocumentAndModifySelection):
              (WebCore::execMoveToBeginningOfSentence):
              (WebCore::execMoveToBeginningOfSentenceAndModifySelection):
              (WebCore::execMoveToBeginningOfLine):
              (WebCore::execMoveToBeginningOfLineAndModifySelection):
              (WebCore::execMoveToBeginningOfParagraph):
              (WebCore::execMoveToBeginningOfParagraphAndModifySelection):
              (WebCore::execMoveToEndOfDocument):
              (WebCore::execMoveToEndOfDocumentAndModifySelection):
              (WebCore::execMoveToEndOfSentence):
              (WebCore::execMoveToEndOfSentenceAndModifySelection):
              (WebCore::execMoveToEndOfLine):
              (WebCore::execMoveToEndOfLineAndModifySelection):
              (WebCore::execMoveToEndOfParagraph):
              (WebCore::execMoveToEndOfParagraphAndModifySelection):
              (WebCore::execMoveParagraphBackwardAndModifySelection):
              (WebCore::execMoveParagraphForwardAndModifySelection):
              (WebCore::execMoveUp):
              (WebCore::execMoveUpAndModifySelection):
              (WebCore::execMoveWordBackward):
              (WebCore::execMoveWordBackwardAndModifySelection):
              (WebCore::execMoveWordForward):
              (WebCore::execMoveWordForwardAndModifySelection):
              (WebCore::execMoveWordLeft):
              (WebCore::execMoveWordLeftAndModifySelection):
              (WebCore::execMoveWordRight):
              (WebCore::execMoveWordRightAndModifySelection):
              (WebCore::enabledAnySelection):
              (WebCore::createCommandMap):
              (WebCore::CommandEntry::):
              (WebCore::Editor::execCommand):
              * editing/Editor.h:
      
      WebKit:
      
              Reviewed by Maciej, Geoff.
      
              Call execCommand directly here instead of going through the bridge.
              
              * WebView/WebHTMLView.m:
              (-[NSArray moveBackward:]):
              (-[NSArray moveBackwardAndModifySelection:]):
              (-[NSArray moveDown:]):
              (-[NSArray moveDownAndModifySelection:]):
              (-[NSArray moveForward:]):
              (-[NSArray moveForwardAndModifySelection:]):
              (-[NSArray moveLeft:]):
              (-[NSArray moveLeftAndModifySelection:]):
              (-[NSArray moveRight:]):
              (-[NSArray moveRightAndModifySelection:]):
              (-[NSArray moveToBeginningOfDocument:]):
              (-[NSArray moveToBeginningOfDocumentAndModifySelection:]):
              (-[NSArray moveToBeginningOfSentence:]):
              (-[NSArray moveToBeginningOfSentenceAndModifySelection:]):
              (-[NSArray moveToBeginningOfLine:]):
              (-[NSArray moveToBeginningOfLineAndModifySelection:]):
              (-[NSArray moveToBeginningOfParagraph:]):
              (-[NSArray moveToBeginningOfParagraphAndModifySelection:]):
              (-[NSArray moveToEndOfDocument:]):
              (-[NSArray moveToEndOfDocumentAndModifySelection:]):
              (-[NSArray moveToEndOfSentence:]):
              (-[NSArray moveToEndOfSentenceAndModifySelection:]):
              (-[NSArray moveToEndOfLine:]):
              (-[NSArray moveToEndOfLineAndModifySelection:]):
              (-[NSArray moveToEndOfParagraph:]):
              (-[NSArray moveToEndOfParagraphAndModifySelection:]):
              (-[NSArray moveParagraphBackwardAndModifySelection:]):
              (-[NSArray moveParagraphForwardAndModifySelection:]):
              (-[NSArray moveUp:]):
              (-[NSArray moveUpAndModifySelection:]):
              (-[NSArray moveWordBackward:]):
              (-[NSArray moveWordBackwardAndModifySelection:]):
              (-[NSArray moveWordForward:]):
              (-[NSArray moveWordForwardAndModifySelection:]):
              (-[NSArray moveWordLeft:]):
              (-[NSArray moveWordLeftAndModifySelection:]):
              (-[NSArray moveWordRight:]):
              (-[NSArray moveWordRightAndModifySelection:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fbad2f6
    • beidson's avatar
      WebCore: · 0e1906f8
      beidson authored
              Reviewed by Darin
      
              Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
      
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
              * bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
              * loader/FrameLoaderClient.h:
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::sharedIconDatabase):
              (WebCore::IconDatabase::~IconDatabase):
              * loader/icon/IconDatabase.h:
              (WebCore::IconDatabase::isPrivateBrowsingEnabled):
              (WebCore::IconDatabase::enabled):
              * loader/icon/IconLoader.cpp:
              (WebCore::IconLoader::finishLoading):
              * loader/mac/FrameLoaderMac.mm:
      
      WebKit:
      
              Reviewed by Darin
        
              Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
      
              * Misc/WebIconDatabase.m:
              (-[WebIconDatabase init]):
              (-[WebIconDatabase iconForURL:withSize:cache:]):
              (-[WebIconDatabase iconURLForURL:]):
              (-[WebIconDatabase defaultIconWithSize:]):
              (-[WebIconDatabase defaultIconForURL:withSize:]):
              (-[WebIconDatabase retainIconForURL:]):
              (-[WebIconDatabase releaseIconForURL:]):
              (-[WebIconDatabase setDelegate:]):
              (-[WebIconDatabase removeAllIcons]):
              (-[WebIconDatabase isIconExpiredForIconURL:]):
              (-[WebIconDatabase _isEnabled]):
              (-[WebIconDatabase _setIconData:forIconURL:]):
              (-[WebIconDatabase _setHaveNoIconForIconURL:]):
              (-[WebIconDatabase _setIconURL:forURL:]):
              (-[WebIconDatabase _hasEntryForIconURL:]):
              (-[WebIconDatabase _applicationWillTerminate:]):
              (-[WebIconDatabase _resetCachedWebPreferences:]):
              (-[WebIconDatabase _convertToWebCoreFormat]):
              (webGetNSImage):
              * Misc/WebIconDatabaseInternal.h: Added.
              * Misc/WebIconDatabasePrivate.h:
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchDidReceiveIcon):
              * WebCoreSupport/WebIconDatabaseBridge.h: Removed.
              * WebCoreSupport/WebIconDatabaseBridge.m: Removed.
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e1906f8
    • andersca's avatar
      WebCore: · 799c7160
      andersca authored
              Reviewed and landed by Anders.
      
              Adjust platform Qt/KDE code to the recent loader
              changes. 
      
              * CMakeLists.txt:
              * loader/DocumentLoader.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::createEmptyDocument):
              * loader/FrameLoader.h:
              * loader/FrameLoaderClient.h:
              * loader/qt/DocumentLoaderQt.cpp: Added.
              (WebCore::canonicalizedTitle):
              (WebCore::DocumentLoader::DocumentLoader):
              (WebCore::DocumentLoader::frameLoader):
              (WebCore::DocumentLoader::~DocumentLoader):
              (WebCore::DocumentLoader::URL):
              (WebCore::DocumentLoader::unreachableURL):
              (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
              (WebCore::DocumentLoader::isStopping):
              (WebCore::DocumentLoader::clearErrors):
              (WebCore::DocumentLoader::stopLoading):
              (WebCore::DocumentLoader::setupForReplace):
              (WebCore::DocumentLoader::commitIfReady):
              (WebCore::DocumentLoader::finishedLoading):
              (WebCore::DocumentLoader::setCommitted):
              (WebCore::DocumentLoader::isCommitted):
              (WebCore::DocumentLoader::setLoading):
              (WebCore::DocumentLoader::isLoading):
              (WebCore::DocumentLoader::doesProgressiveLoad):
              (WebCore::DocumentLoader::setupForReplaceByMIMEType):
              (WebCore::DocumentLoader::updateLoading):
              (WebCore::DocumentLoader::setFrame):
              (WebCore::DocumentLoader::attachToFrame):
              (WebCore::DocumentLoader::detachFromFrame):
              (WebCore::DocumentLoader::prepareForLoadStart):
              (WebCore::DocumentLoader::loadingStartedTime):
              (WebCore::DocumentLoader::setIsClientRedirect):
              (WebCore::DocumentLoader::isClientRedirect):
              (WebCore::DocumentLoader::setPrimaryLoadComplete):
              (WebCore::DocumentLoader::isLoadingInAPISense):
              (WebCore::DocumentLoader::stopRecordingResponses):
              (WebCore::DocumentLoader::title):
              (WebCore::DocumentLoader::triggeringAction):
              (WebCore::DocumentLoader::setTriggeringAction):
              (WebCore::DocumentLoader::setOverrideEncoding):
              (WebCore::DocumentLoader::overrideEncoding):
              (WebCore::DocumentLoader::setTitle):
              (WebCore::DocumentLoader::URLForHistory):
              * loader/qt/FrameLoaderClientQt.cpp: Added.
              (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
              (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt):
              (WebCore::FrameLoaderClientQt::detachFrameLoader):
              (WebCore::FrameLoaderClientQt::hasWebView):
              (WebCore::FrameLoaderClientQt::hasFrameView):
              (WebCore::FrameLoaderClientQt::hasBackForwardList):
              (WebCore::FrameLoaderClientQt::resetBackForwardList):
              (WebCore::FrameLoaderClientQt::provisionalItemIsTarget):
              (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache):
              (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache):
              (WebCore::FrameLoaderClientQt::privateBrowsingEnabled):
              (WebCore::FrameLoaderClientQt::makeDocumentView):
              (WebCore::FrameLoaderClientQt::makeRepresentation):
              (WebCore::FrameLoaderClientQt::forceLayout):
              (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML):
              (WebCore::FrameLoaderClientQt::updateHistoryForCommit):
              (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation):
              (WebCore::FrameLoaderClientQt::updateHistoryForReload):
              (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad):
              (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad):
              (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect):
              (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
              (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset):
              (WebCore::FrameLoaderClientQt::resetAfterLoadError):
              (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError):
              (WebCore::FrameLoaderClientQt::willCloseDocument):
              (WebCore::FrameLoaderClientQt::detachedFromParent1):
              (WebCore::FrameLoaderClientQt::detachedFromParent2):
              (WebCore::FrameLoaderClientQt::detachedFromParent3):
              (WebCore::FrameLoaderClientQt::detachedFromParent4):
              (WebCore::FrameLoaderClientQt::loadedFromPageCache):
              (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
              (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad):
              (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect):
              (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
              (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
              (WebCore::FrameLoaderClientQt::dispatchWillClose):
              (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
              (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
              (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
              (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
              (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
              (WebCore::FrameLoaderClientQt::dispatchShow):
              (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
              (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
              (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource):
              (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache):
              (WebCore::FrameLoaderClientQt::isLoadingFromPageCache):
              (WebCore::FrameLoaderClientQt::revertToProvisionalState):
              (WebCore::FrameLoaderClientQt::clearUnarchivingState):
              (WebCore::FrameLoaderClientQt::progressStarted):
              (WebCore::FrameLoaderClientQt::progressCompleted):
              (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
              (WebCore::FrameLoaderClientQt::willChangeTitle):
              (WebCore::FrameLoaderClientQt::didChangeTitle):
              (WebCore::FrameLoaderClientQt::finishedLoading):
              (WebCore::FrameLoaderClientQt::finalSetupForReplace):
              (WebCore::FrameLoaderClientQt::setDefersLoading):
              (WebCore::FrameLoaderClientQt::isArchiveLoadPending):
              (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad):
              (WebCore::FrameLoaderClientQt::clearArchivedResources):
              (WebCore::FrameLoaderClientQt::canShowMIMEType):
              (WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
              (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
              (WebCore::FrameLoaderClientQt::frameLoadCompleted):
              (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState):
              (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
              (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent):
              (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll):
              (WebCore::FrameLoaderClientQt::didFinishLoad):
              (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement):
              (WebCore::FrameLoaderClientQt::setTitle):
              (WebCore::FrameLoaderClientQt::userAgent):
              * loader/qt/FrameLoaderClientQt.h: Added.
              * loader/qt/FrameLoaderQt.cpp:
              (WebCore::FrameLoader::submitForm):
              (WebCore::FrameLoader::overrideMediaType):
              (WebCore::FrameLoader::getHistoryLength):
              (WebCore::FrameLoader::referrer):
              (WebCore::FrameLoader::detachFromParent):
              (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
              (WebCore::FrameLoader::goBackOrForward):
              (WebCore::FrameLoader::historyURL):
              (WebCore::FrameLoader::didFirstLayout):
              (WebCore::FrameLoader::canGoBackOrForward):
              (WebCore::FrameLoader::partClearedInBegin):
              (WebCore::FrameLoader::saveDocumentState):
              (WebCore::FrameLoader::restoreDocumentState):
              (WebCore::FrameLoader::didChangeTitle):
              (WebCore::FrameLoader::redirectDataToPlugin):
              (WebCore::PolicyCheck::PolicyCheck):
              (WebCore::PolicyCheck::clear):
              (WebCore::PolicyCheck::set):
              (WebCore::PolicyCheck::call):
              (WebCore::PolicyCheck::clearRequest):
              * loader/qt/NavigationActionQt.cpp: Added.
              (WebCore::navigationType):
              (WebCore::NavigationAction::NavigationAction):
              * loader/qt/ResourceLoaderQt.cpp: Added.
              (WebCore::ResourceLoader::ResourceLoader):
              (WebCore::ResourceLoader::~ResourceLoader):
              (WebCore::ResourceLoader::setDefersLoading):
              (WebCore::ResourceLoader::cancel):
              (WebCore::ResourceLoader::loadsBlocked):
              * platform/MimeTypeRegistry.cpp:
              (WebCore::initialiseSupportedImageMIMETypes):
              * platform/network/qt/ResourceHandleManager.cpp:
              (WebCore::ResourceHandleManager::slotResult):
              (WebCore::ResourceHandleManager::cancel):
              * platform/qt/ChromeClientQt.cpp: Added.
              (WebCore::rootWindowForFrame):
              (WebCore::ChromeClientQt::ChromeClientQt):
              (WebCore::ChromeClientQt::~ChromeClientQt):
              (WebCore::ChromeClientQt::setWindowRect):
              (WebCore::ChromeClientQt::windowRect):
              (WebCore::ChromeClientQt::pageRect):
              (WebCore::ChromeClientQt::scaleFactor):
              (WebCore::ChromeClientQt::focus):
              (WebCore::ChromeClientQt::unfocus):
              (WebCore::ChromeClientQt::createWindow):
              (WebCore::ChromeClientQt::createModalDialog):
              (WebCore::ChromeClientQt::show):
              (WebCore::ChromeClientQt::canRunModal):
              (WebCore::ChromeClientQt::runModal):
              (WebCore::ChromeClientQt::setToolbarsVisible):
              (WebCore::ChromeClientQt::toolbarsVisible):
              (WebCore::ChromeClientQt::setStatusbarVisible):
              (WebCore::ChromeClientQt::statusbarVisible):
              (WebCore::ChromeClientQt::setScrollbarsVisible):
              (WebCore::ChromeClientQt::scrollbarsVisible):
              (WebCore::ChromeClientQt::setMenubarVisible):
              (WebCore::ChromeClientQt::menubarVisible):
              (WebCore::ChromeClientQt::setResizable):
              * platform/qt/ChromeClientQt.h: Added.
              * platform/qt/EditorClientQt.cpp:
              (WebCore::EditorClientQt::shouldBeginEditing):
              (WebCore::EditorClientQt::shouldEndEditing):
              (WebCore::EditorClientQt::shouldApplyStyle):
              (WebCore::EditorClientQt::didBeginEditing):
              (WebCore::EditorClientQt::respondToChangedContents):
              (WebCore::EditorClientQt::didEndEditing):
              * platform/qt/EditorClientQt.h:
              * platform/qt/FrameQt.cpp:
              (WebCore::FrameQt::FrameQt):
              (WebCore::FrameQt::~FrameQt):
              (WebCore::FrameQt::keyEvent):
              * platform/qt/FrameQt.h:
              * platform/qt/FrameQtClient.cpp:
              (WebCore::FrameQtClientDefault::openURL):
              (WebCore::FrameQtClientDefault::didReceiveData):
              (WebCore::FrameQtClientDefault::receivedAllData):
              * platform/qt/ImageQt.cpp:
              * platform/qt/MimeTypeRegistryQt.cpp: Added.
              (WebCore::getMIMETypeForUTI):
              (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
              * platform/qt/PageQt.cpp:
              * platform/qt/PlatformKeyboardEventQt.cpp:
              (WebCore::keyIdentifierForQtKeyCode):
              * platform/qt/ScreenQt.cpp:
              * platform/qt/TemporaryLinkStubs.cpp:
              (WebCore::TextField::TextField):
              (WebCore::screenDepth):
              (WebCore::screenDepthPerComponent):
              (WebCore::screenIsMonochrome):
              (WebCore::screenRect):
              (WebCore::screenAvailableRect):
      
      WebKitQt:
      
              Reviewed and landed by Anders.
      
              Adjusting to the recent loader changes, making it compile
              and work.
      
              * QtLauncher/main.cpp:
              (main):
              * WebKitPart/WebKitPart.cpp:
              (WebKitPart::closeUrl):
              (WebKitPart::initView):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      799c7160
    • beidson's avatar
      Reviewed by Mitz · 8a637fe3
      beidson authored
              http://bugs.webkit.org/show_bug.cgi?id=11554
              Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
              in case the icon load fails after some data has been received. 
      
              * loader/icon/IconLoader.cpp:
              (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB
              on error.  Also, as a loader re-factoring sanity check, added an assertion
              (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon 
              is already committed to the DB.  Skip doing that step twice.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a637fe3
    • oliver's avatar
      2006-11-09 Oliver Hunt <oliver@apple.com> · 02dbc5fe
      oliver authored
              Reviewed by Brady.
      
              Pulled MIME type handling out of WebFrameBridge and added
              a general C++ class to store/query MIME info
              Added an Obj-C bridge to provide WebKit with access to the
              MimeTypeRegistry for non-Obj-C++ classes.
              
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              * bridge/mac/WebMimeTypeRegistryBridge.h: Added.
              * bridge/mac/WebMimeTypeRegistryBridge.mm: Added.
              (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]):
              (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]):
              (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]):
              (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]):
              (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
              * platform/Image.cpp:
              (WebCore::Image::supportsType):
              * platform/Image.h:
              * platform/MimeTypeRegistry.cpp: Added.
              (WebCore::initialiseSupportedImageMIMETypes):
              (WebCore::initialiseSupportedNonImageMimeTypes):
              (WebCore::initialiseMimeTypeRegistry):
              (WebCore::MimeTypeRegistry::isSupportedImageMIMEType):
              (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType):
              (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType):
              (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes):
              (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes):
              (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
              * platform/MimeTypeRegistry.h: Added.
              * platform/mac/ImageMac.mm:
              * platform/mac/MimeTypeRegistryMac.mm: Added.
              (WebCore::getMIMETypeForUTI):
              (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
              
              Updated to make use of MimeTypeRegistry/bridge
      
              * Misc/WebNSPasteboardExtras.m:
              (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
              * WebView/WebDataSource.mm:
              (-[WebDataSource _documentFragmentWithArchive:]):
              * WebView/WebHTMLRepresentation.m:
              (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
              (+[WebHTMLRepresentation supportedImageMIMETypes]):
              * WebView/WebHTMLView.m:
              (-[WebHTMLView _imageExistsAtPaths:]):
              (-[WebHTMLView _documentFragmentWithPaths:]):
              
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02dbc5fe
  3. 09 Nov, 2006 10 commits
    • mjs's avatar
      Reviewed by Oliver. · bd754cb2
      mjs authored
              - rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search
              for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size
              for you and use vsnprintf.
      
              * bindings/js/kjs_window.cpp:
              (KJS::Window::isSafeScript):
              * css/cssparser.cpp:
              (WebCore::CSSParser::parseColorFromValue):
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::addCSSColor):
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::handleError):
              * ksvg2/css/SVGCSSParser.cpp:
              (WebCore::CSSParser::parseSVGPaint):
              (WebCore::CSSParser::parseSVGColor):
              * ksvg2/svg/SVGPathSegArc.h:
              (WebCore::SVGPathSegArcAbs::toString):
              (WebCore::SVGPathSegArcRel::toString):
              * ksvg2/svg/SVGPathSegCurvetoCubic.h:
              (WebCore::SVGPathSegCurvetoCubicAbs::toString):
              (WebCore::SVGPathSegCurvetoCubicRel::toString):
              * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
              (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
              (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
              * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
              (WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
              (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
              * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
              (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
              (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
              * ksvg2/svg/SVGPathSegLineto.h:
              (WebCore::SVGPathSegLinetoAbs::toString):
              (WebCore::SVGPathSegLinetoRel::toString):
              * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
              (WebCore::SVGPathSegLinetoHorizontalAbs::toString):
              (WebCore::SVGPathSegLinetoHorizontalRel::toString):
              * ksvg2/svg/SVGPathSegLinetoVertical.h:
              (WebCore::SVGPathSegLinetoVerticalAbs::toString):
              (WebCore::SVGPathSegLinetoVerticalRel::toString):
              * ksvg2/svg/SVGPathSegMoveto.h:
              (WebCore::SVGPathSegMovetoAbs::toString):
              (WebCore::SVGPathSegMovetoRel::toString):
              * ksvg2/svg/SVGPolyElement.cpp:
              (WebCore::SVGPolyElement::notifyAttributeChange):
              * ksvg2/svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::closeRenderer):
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
              * loader/icon/SQLDatabase.cpp:
              (WebCore::SQLDatabase::setSynchronous):
              * platform/Color.cpp:
              (WebCore::Color::name):
              * platform/DeprecatedString.cpp:
              (WebCore::DeprecatedString::setNum):
              (WebCore::DeprecatedString::format):
              * platform/DeprecatedString.h:
              * platform/PlatformString.h:
              * platform/String.cpp:
              (WebCore::String::format):
              (WebCore::String::number):
              * platform/mac/KeyEventMac.mm:
              (WebCore::keyIdentifierForKeyEvent):
              * platform/win/KeyEventWin.cpp:
              (WebCore::keyIdentifierForWindowsKeyCode):
              * rendering/RenderListMarker.cpp:
              (WebCore::RenderListMarker::calcMinMaxWidth):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd754cb2
    • mjs's avatar
      Reviewed by Anders. · c7cd95ba
      mjs authored
              - fixed "Regression: Can't log into gmail.com"
              - fixed "iBench doesn't report results - tests run but no number is recorded"
              
              * platform/network/cf/FormDataStreamCFNet.cpp:
              (WebCore::setHTTPBody): Removed extra ! character.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7cd95ba
    • beidson's avatar
      Reviewed by Darin · 1681cebf
      beidson authored
              <rdar://problem/4829080>
              More loader re-factoring cleanup - WebFramePolicyListener was over-released
      
              * WebCoreSupport/WebFrameLoaderClient.h: Changed vanilla ptr to a RetainPtr<> 
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto
              (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto
              (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto
              (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto
              (WebFrameLoaderClient::setUpPolicyListener): Ditto
              (-[WebFramePolicyListener receivedPolicyDecision:]): Ditto 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1681cebf
    • bdakin's avatar
      Reviewed by Hyatt. · 7238cee6
      bdakin authored
              Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in 
              WebCore::RenderBlock::skipWhitespace
      
              Note that this will still crash on Debug builds because it will hit 
              an assertion failure in editing. (One of the reasons there is no 
              layout test along with this fix.) There is definitely some editing 
              wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
              id=10144 for updates on the assertion failure bug.
      
              * rendering/RootInlineBox.cpp:
              (WebCore::RootInlineBox::childRemoved): It is possible for a 
              prevRootBox and its prevRootBox to share a lineBreakObj. So instead 
              of just clearing the lineBreakObj of the prevRootBox, cycle through 
              all prevRootBoxs with the same lineBreakObj.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7238cee6
    • thatcher's avatar
      Build fix. · 1055ec77
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1055ec77
    • aroben's avatar
      LayoutTests: · 69263753
      aroben authored
              Reviewed by Geoff.
      
              New test to keep the mistake I made in r17680 from happening again.
      
              * fast/block/margin-collapse/negative-margins-expected.checksum: Added.
              * fast/block/margin-collapse/negative-margins-expected.png: Added.
              * fast/block/margin-collapse/negative-margins-expected.txt: Added.
              * fast/block/margin-collapse/negative-margins.html: Added.
      
      WebCore:
      
              Reviewed by Geoff.
      
              Fix the change in behavior I caused in r17680 with my build fix.
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::maxTopMargin):
              (WebCore::RenderObject::maxBottomMargin):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69263753
    • andersca's avatar
      WebCore: · 3a621288
      andersca authored
              Reviewed by Adam, Oliver.
      
              Move more functions to Editor.
      
              * bridge/EditorClient.h:
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              * bridge/mac/WebCoreFrameBridge.h:
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply):
              (WebCore::EditCommand::unapply):
              (WebCore::EditCommand::reapply):
              * editing/Editor.cpp:
              (WebCore::Editor::respondToChangedContents):
              (WebCore::dispatchEditableContentChangedEvents):
              (WebCore::Editor::appliedEditing):
              (WebCore::Editor::unappliedEditing):
              (WebCore::Editor::reappliedEditing):
              * editing/Editor.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::typingAddedToOpenCommand):
              * page/Frame.cpp:
              * page/Frame.h:
      
      WebKit:
      
              Reviewed by Adam, Oliver.
      
              Update for changes to WebCore. Pass a specific WebFrame to WebEditorClient
              instead of just passing the WebView.
              
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::WebEditorClient):
              (WebEditorClient::setWebFrame):
              (WebEditorClient::isContinuousSpellCheckingEnabled):
              (WebEditorClient::spellCheckerDocumentTag):
              (WebEditorClient::shouldDeleteRange):
              (WebEditorClient::shouldShowDeleteInterface):
              (WebEditorClient::shouldApplyStyle):
              (WebEditorClient::shouldBeginEditing):
              (WebEditorClient::shouldEndEditing):
              (WebEditorClient::didBeginEditing):
              (WebEditorClient::respondToChangedContents):
              (WebEditorClient::didEndEditing):
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
              (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a621288
    • darin's avatar
      * rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef. · 186987da
      darin authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      186987da
    • aliceli1's avatar
      Reviewed by Beth Dakin. · 8b1f83f4
      aliceli1 authored
              Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
              All existing layout tests pass
      
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::deleteRow):
              check lastSection before deleting row
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b1f83f4
    • darin's avatar
      - improved version of last night's build fix (should not do using namespace in a header) · 6cfaa576
      darin authored
              * rendering/RenderObject.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::maxTopMargin):
              (WebCore::RenderObject::maxBottomMargin):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cfaa576
  4. 08 Nov, 2006 8 commits
    • mjs's avatar
      Reviewed by Geoff. · 4ad0f382
      mjs authored
              
              - added ResourceError class and didFailWithError client method
      
              * WebCore.xcodeproj/project.pbxproj:
              * loader/icon/IconLoader.cpp:
              (WebCore::IconLoader::didFailWithError):
              (WebCore::IconLoader::didFinishLoading):
              * loader/icon/IconLoader.h:
              * loader/loader.cpp:
              (WebCore::Loader::receivedAllData):
              (WebCore::Loader::didFailWithError):
              * loader/loader.h:
              * loader/mac/SubresourceLoaderMac.mm:
              (WebCore::SubresourceLoader::didFail):
              (WebCore::SubresourceLoader::didCancel):
              * platform/cf/RetainPtr.h:
              (WebCore::):
              (WebCore::adoptCFReference):
              (WebCore::RetainPtr::RetainPtr):
              (WebCore::::adopt):
              * platform/network/ResourceError.cpp: Added.
              * platform/network/ResourceError.h: Added.
              (WebCore::ResourceError::ResourceError):
              (WebCore::ResourceError::domain):
              (WebCore::ResourceError::errorCode):
              (WebCore::ResourceError::failingURL):
              (WebCore::ResourceError::localizedDescription):
              (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
              * platform/network/ResourceHandle.cpp:
              * platform/network/ResourceHandle.h:
              * platform/network/ResourceHandleClient.h:
              (WebCore::ResourceHandleClient::didFailWithError):
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::didFail):
              (WebCore::ResourceHandle::cancel):
              * platform/network/mac/ResourceErrorMac.mm: Added.
              (-[NSError WebCore]):
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::ResourceHandle::reportError):
              * xml/xmlhttprequest.cpp:
              (WebCore::XMLHttpRequest::didFailWithError):
              (WebCore::XMLHttpRequest::didFinishLoading):
              * xml/xmlhttprequest.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ad0f382
    • bdash's avatar
      2006-11-08 Krzysztof Kowalczyk <kkowalczyk@gmail.com> · 383c9530
      bdash authored
              Reviewed by Maciej.
      
              Linux\Gdk fixes.
      
              * platform/gdk/ChromeClientGdk.h:
              (WebCore::ChromeClientGdk::~ChromeClientGdk):
              * platform/gdk/CursorGdk.cpp:
              (WebCore::Cursor::Cursor):
              (WebCore::moveCursor):
              * platform/gdk/FrameGdk.cpp:
              (WebCore::FrameGdk::FrameGdk):
              (WebCore::FrameGdk::submitForm):
              (WebCore::FrameGdk::urlSelected):
              * platform/gdk/PageGdk.cpp:
              * platform/gdk/ScreenClientGdk.h: Added.
              (WebCore::ScreenClientGdk::~ScreenClientGdk):
              * platform/gdk/ScreenGdk.cpp:
              (WebCore::ScreenClientGdk::depth):
              (WebCore::ScreenClientGdk::depthPerComponent):
              (WebCore::ScreenClientGdk::isMonochrome):
              (WebCore::ScreenClientGdk::rect):
              (WebCore::ScreenClientGdk::usableRect):
              * platform/gdk/TemporaryLinkStubs.cpp:
              (FrameGdk::historyURL):
              (ChromeClientGdk::windowRect):
              (ChromeClientGdk::setWindowRect):
              (ChromeClientGdk::pageRect):
              (ChromeClientGdk::scaleFactor):
              (ChromeClientGdk::focus):
              (ChromeClientGdk::unfocus):
              (ChromeClientGdk::createWindow):
              (ChromeClientGdk::createModalDialog):
              (ChromeClientGdk::show):
              (ChromeClientGdk::canRunModal):
              (ChromeClientGdk::runModal):
              (ChromeClientGdk::setToolbarsVisible):
              (ChromeClientGdk::toolbarsVisible):
              (ChromeClientGdk::setStatusbarVisible):
              (ChromeClientGdk::statusbarVisible):
              (ChromeClientGdk::setScrollbarsVisible):
              (ChromeClientGdk::scrollbarsVisible):
              (ChromeClientGdk::setMenubarVisible):
              (ChromeClientGdk::menubarVisible):
              (ChromeClientGdk::setResizable):
              * platform/network/ResourceHandleInternal.h:
              (WebCore::ResourceHandleInternal::client):
              * platform/network/gdk/ResourceHandleManager.cpp:
              (WebCore::writeCallback):
              (WebCore::ResourceHandleManager::downloadTimerCallback):
              (WebCore::ResourceHandleManager::remove):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      383c9530
    • aroben's avatar
      Build fix. · 45d9e2bd
      aroben authored
              * rendering/RenderObject.h:
              (WebCore::RenderObject::maxTopMargin):
              (WebCore::RenderObject::maxBottomMargin):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45d9e2bd
    • ggaren's avatar
      Reviewed by Anders Carlsson. · e9494d5f
      ggaren authored
              Made Screen a good platform citizen by removing its reference to Page. This
              made a class unnecessary, so all screen fuctions are stand-alone now.
      
              * bindings/js/kjs_window.cpp: Removed unnecessary subtractions
              when computing the screen's available dimensions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9494d5f
    • weinig's avatar
      Reviewed by Mitz. · 20fc850f
      weinig authored
              Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
              Cleanup RenderObject
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::operator delete):
              (WebCore::RenderObject::createObject):
              (WebCore::RenderObjectCounter::~RenderObjectCounter):
              (WebCore::RenderObject::RenderObject):
              (WebCore::RenderObject::isDescendantOf):
              (WebCore::RenderObject::isRoot):
              (WebCore::RenderObject::addChild):
              (WebCore::RenderObject::removeChildNode):
              (WebCore::RenderObject::removeChild):
              (WebCore::RenderObject::appendChildNode):
              (WebCore::RenderObject::insertChildNode):
              (WebCore::RenderObject::nextInPreOrder):
              (WebCore::RenderObject::nextInPreOrderAfterChildren):
              (WebCore::RenderObject::previousInPreOrder):
              (WebCore::RenderObject::isEditable):
              (WebCore::RenderObject::nextEditable):
              (WebCore::RenderObject::previousEditable):
              (WebCore::RenderObject::firstLeafChild):
              (WebCore::RenderObject::lastLeafChild):
              (WebCore::RenderObject::addLayers):
              (WebCore::RenderObject::removeLayers):
              (WebCore::RenderObject::moveLayers):
              (WebCore::RenderObject::findNextLayer):
              (WebCore::RenderObject::enclosingLayer):
              (WebCore::RenderObject::updateFirstLetter):
              (WebCore::RenderObject::offsetParent):
              (WebCore::RenderObject::scroll):
              (WebCore::RenderObject::hasStaticX):
              (WebCore::RenderObject::setNeedsLayout):
              (WebCore::RenderObject::setChildNeedsLayout):
              (WebCore::RenderObject::markContainingBlocksForLayout):
              (WebCore::RenderObject::containingBlock):
              (WebCore::RenderObject::containingBlockWidth):
              (WebCore::RenderObject::containingBlockHeight):
              (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
              (WebCore::RenderObject::drawBorderArc):
              (WebCore::RenderObject::drawBorder):
              (WebCore::RenderObject::paintBorderImage):
              (WebCore::RenderObject::paintBorder):
              (WebCore::RenderObject::absoluteRects):
              (WebCore::RenderObject::addPDFURLRect):
              (WebCore::RenderObject::addFocusRingRects):
              (WebCore::RenderObject::paintOutline):
              (WebCore::RenderObject::repaint):
              (WebCore::RenderObject::repaintRectangle):
              (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
              (WebCore::RenderObject::repaintObjectsBeforeLayout):
              (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
              (WebCore::RenderObject::information):
              (WebCore::RenderObject::dump):
              (WebCore::selectStartNode):
              (WebCore::RenderObject::shouldSelect):
              (WebCore::RenderObject::draggableNode):
              (WebCore::RenderObject::createAnonymousBlock):
              (WebCore::RenderObject::handleDynamicFloatPositionChange):
              (WebCore::RenderObject::setStyle):
              (WebCore::RenderObject::setStyleInternal):
              (WebCore::RenderObject::updateBackgroundImages):
              (WebCore::RenderObject::absolutePosition):
              (WebCore::RenderObject::caretRect):
              (WebCore::RenderObject::paddingTop):
              (WebCore::RenderObject::paddingBottom):
              (WebCore::RenderObject::paddingLeft):
              (WebCore::RenderObject::paddingRight):
              (WebCore::RenderObject::tabWidth):
              (WebCore::RenderObject::container):
              (WebCore::RenderObject::removeFromObjectLists):
              (WebCore::RenderObject::destroy):
              (WebCore::RenderObject::arenaDelete):
              (WebCore::RenderObject::hitTest):
              (WebCore::RenderObject::setInnerNode):
              (WebCore::RenderObject::nodeAtPoint):
              (WebCore::RenderObject::verticalPositionHint):
              (WebCore::RenderObject::getVerticalPosition):
              (WebCore::RenderObject::lineHeight):
              (WebCore::RenderObject::invalidateVerticalPositions):
              (WebCore::RenderObject::recalcMinMaxWidths):
              (WebCore::RenderObject::scheduleRelayout):
              (WebCore::RenderObject::setInlineBoxWrapper):
              (WebCore::RenderObject::firstLineStyle):
              (WebCore::RenderObject::getPseudoStyle):
              (WebCore::RenderObject::getTextDecorationColors):
              (WebCore::RenderObject::addDashboardRegions):
              (WebCore::RenderObject::collectDashboardRegions):
              (WebCore::RenderObject::avoidsFloats):
              (WebCore::RenderObject::findCounter):
              (WebCore::RenderObject::backslashAsCurrencySymbol):
              (WebCore::RenderObject::imageChanged):
              (WebCore::RenderObject::previousOffset):
              (WebCore::RenderObject::nextOffset):
              (WebCore::RenderObject::inlineBox):
              * rendering/RenderObject.h:
              (WebCore::):
              (WebCore::RenderObject::renderName):
              (WebCore::RenderObject::parent):
              (WebCore::RenderObject::previousSibling):
              (WebCore::RenderObject::nextSibling):
              (WebCore::RenderObject::firstChild):
              (WebCore::RenderObject::lastChild):
              (WebCore::RenderObject::getOverflowClipRect):
              (WebCore::RenderObject::getClipRect):
              (WebCore::RenderObject::getBaselineOfFirstLineBox):
              (WebCore::RenderObject::setEdited):
              (WebCore::RenderObject::setStaticX):
              (WebCore::RenderObject::setStaticY):
              (WebCore::RenderObject::setPreviousSibling):
              (WebCore::RenderObject::setNextSibling):
              (WebCore::RenderObject::setParent):
              (WebCore::RenderObject::isInlineBlockOrInlineTable):
              (WebCore::RenderObject::isRenderView):
              (WebCore::RenderObject::childrenInline):
              (WebCore::RenderObject::setChildrenInline):
              (WebCore::RenderObject::isAnonymousBlock):
              (WebCore::RenderObject::isDragging):
              (WebCore::RenderObject::needsLayout):
              (WebCore::RenderObject::setMinMaxKnown):
              (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc):
              (WebCore::RenderObject::setPositioned):
              (WebCore::RenderObject::setRelPositioned):
              (WebCore::RenderObject::setFloating):
              (WebCore::RenderObject::setInline):
              (WebCore::RenderObject::setShouldPaintBackgroundOrBorder):
              (WebCore::RenderObject::setReplaced):
              (WebCore::RenderObject::PaintInfo::PaintInfo):
              (WebCore::RenderObject::paintBackgroundExtended):
              (WebCore::RenderObject::calcWidth):
              (WebCore::RenderObject::updateFromElement):
              (WebCore::RenderObject::RepaintInfo::RepaintInfo):
              (WebCore::RenderObject::setOverrideSize):
              (WebCore::RenderObject::setPos):
              (WebCore::RenderObject::setWidth):
              (WebCore::RenderObject::setHeight):
              (WebCore::RenderObject::absolutePositionForContent):
              (WebCore::RenderObject::overflowHeight):
              (WebCore::RenderObject::overflowWidth):
              (WebCore::RenderObject::setOverflowHeight):
              (WebCore::RenderObject::setOverflowWidth):
              (WebCore::RenderObject::overflowLeft):
              (WebCore::RenderObject::overflowTop):
              (WebCore::RenderObject::overflowRect):
              (WebCore::RenderObject::stopAutoscroll):
              (WebCore::RenderObject::collapsedMarginTop):
              (WebCore::RenderObject::collapsedMarginBottom):
              (WebCore::RenderObject::maxTopMargin):
              (WebCore::RenderObject::maxBottomMargin):
              (WebCore::RenderObject::):
              (WebCore::RenderObject::setTable):
              (WebCore::RenderObject::isFloatingOrPositioned):
              (WebCore::RenderObject::containsFloat):
              (WebCore::RenderObject::setSelectionState):
              (WebCore::RenderObject::SelectionInfo::SelectionInfo):
              (WebCore::RenderObject::lowestPosition):
              (WebCore::RenderObject::rightmostPosition):
              (WebCore::RenderObject::leftmostPosition):
              (WebCore::RenderObject::calcVerticalMargins):
              (WebCore::RenderObject::font):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20fc850f
    • darin's avatar
      LayoutTests: · 2a7db559
      darin authored
              Reviewed by Anders.
      
              - added test for option-tab
      
              * fast/events/option-tab.html: Added.
              * fast/events/option-tab-expected.txt: Added.
      
      WebCore:
      
              Reviewed by Anders.
      
              - added event parameters to focus-related functions so we can
                implement the "option-tab to all links" behavior without relying
                on a global "current event" -- also makes it work with DOM events
      
              * page/Frame.h: Removed unneeded includes. Moved some functions
              that were misplaced into the appropriate sections.
              * page/Frame.cpp:
              (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
              PlatformKeyboardEvent to the DOM keyboard event class.
              (WebCore::Frame::tabsToLinks): Added event parameter.
              (WebCore::Frame::tabsToAllControls): Ditto.
              (WebCore::scanForForm): Fixed code that incorrectly assumes
              that an iframe is an HTMLFrameElement (no longer true since Geoff
              changed the class hierarchy a bit).
              (WebCore::Frame::hitTestResultAtPoint): Ditto.
      
              * bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
              that were misplaced into the appropriate sections.
              * bridge/mac/FrameMac.mm:
              (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
              a PlatformKeyboardEvent.
              (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
              and pass event into next/previousFocusNode.
              (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
              the AppKit current event, if it's a keyboard event. Really just a hack that's
              needed to preserve some code we can remove once we deal with the last NSView-
              based form control.
              (WebCore::isKeyboardOptionTab): Added.
              (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
              option (alt) key is down.
              (WebCore::FrameMac::tabsToAllControls): Ditto.
              (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
              call resetMultipleFormSubmissionProtection() explicitly instead.
              (WebCore::FrameMac::mouseDown): Ditto.
      
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
              assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
              changed the class hierarchy a bit).
              (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
              prepareForUserAction() to call resetMultipleFormSubmissionProtection()
              explicitly instead.
      
              * page/FrameView.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::advanceFocus): Changed function to take an
              event parameter, and decide the direction based on the shift key
              modifier instead of a passed-in boolean.
      
              * dom/Document.h:
              * dom/Document.cpp:
              (WebCore::Document::nextFocusNode): Added event parameter.
              (WebCore::Document::previousFocusNode): Ditto.
              * dom/Node.h:
              * dom/Node.cpp:
              (WebCore::Node::isKeyboardFocusable): Ditto.
              * html/HTMLAnchorElement.h:
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
              * html/HTMLGenericFormElement.h:
              * html/HTMLGenericFormElement.cpp:
              (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
              * html/HTMLInputElement.h:
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
              (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
              * html/HTMLSelectElement.h:
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
              * html/HTMLTextAreaElement.h:
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::defaultEventHandler): Pass event to the
              advanceFocus function.
      
              * platform/TextField.h:
              * platform/mac/TextFieldMac.mm: Removed the non-search field code.
      
              * platform/mac/WebCoreTextField.h:
              * platform/mac/WebCoreTextField.mm: Removed the non-search field code.
              (-[WebCoreTextFieldController controlTextDidChange:]): Removed the
              call to FrameMac::handleKeyboardOptionTabInView, which is no longer
              needed since the default handler in HTMLInputElement takes care of
              option-tab.
      
              * platform/mac/SliderMac.mm:
              (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
              and pass event into tabsToAllControls.
              (Slider::focusPolicy): Ditto.
      
              * rendering/RenderLineEdit.cpp:
              (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
              (WebCore::RenderLineEdit::updateFromElement): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a7db559
    • darin's avatar
      Reviewed by Anders. · 976f4940
      darin authored
              - same change as below, only tested this time
      
              * DumpRenderTree/DumpRenderTree.m: (main): Explicitly turn "tab to links"
              mode off. I think we need to do this because WebPreferences saves things
              for us automatically. It would be good to turn that off for DumpRenderTree,
              but for now lets handle this like the other preferences (set it explicitly
              each time).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      976f4940
    • darin's avatar
      Reviewed by Anders. · b8213767
      darin authored
              * DumpRenderTree/DumpRenderTree.m: (main): Get rid of code to turn on
              "tab to links" mode. No current tests depend on this, and there's a new
              test I want to land that depends on the default setting.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8213767