1. 29 Oct, 2012 25 commits
    • kling@webkit.org's avatar
      Don't expose implementation details of StylePropertySet storage. · 07fe5a0a
      kling@webkit.org authored
      <http://webkit.org/b/100644>
      
      Reviewed by Antti Koivisto.
      
      Add a StylePropertySet::PropertyReference class, now returned by propertyAt(index).
      This will allow us to refactor the internal storage of StylePropertySet without
      breaking its API.
      
      A PropertyReference is a simple inlinable wrapper around a StylePropertySet&/index pair.
      
      * css/CSSComputedStyleDeclaration.cpp:
      * css/CSSParser.cpp:
      * css/CSSParser.h:
      * css/SVGCSSParser.cpp:
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::asText):
      (WebCore::StylePropertySet::mergeAndOverrideOnConflict):
      (WebCore::StylePropertySet::findPropertyWithId):
      (WebCore::StylePropertySet::reportMemoryUsage):
      * css/StylePropertySet.h:
      (StylePropertySet):
      (PropertyReference):
      (WebCore::StylePropertySet::PropertyReference::PropertyReference):
      (WebCore::StylePropertySet::PropertyReference::id):
      (WebCore::StylePropertySet::PropertyReference::isImportant):
      (WebCore::StylePropertySet::PropertyReference::isInherited):
      (WebCore::StylePropertySet::PropertyReference::cssName):
      (WebCore::StylePropertySet::PropertyReference::cssText):
      (WebCore::StylePropertySet::PropertyReference::value):
      (WebCore::StylePropertySet::PropertyReference::propertyInternal):
      (WebCore::StylePropertySet::propertyAt):
      (WebCore::StylePropertySet::propertyAtInternal):
      (WebCore):
      * css/StyleResolver.cpp:
      (WebCore::attributeStylesEqual):
      (WebCore::StyleResolver::applyProperties):
      (WebCore::StyleResolver::resolveVariables):
      * editing/ApplyStyleCommand.cpp:
      * editing/EditingStyle.cpp:
      (WebCore::EditingStyle::mergeStyle):
      (WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
      * editing/Editor.cpp:
      * editing/markup.cpp:
      * page/Frame.cpp:
      * svg/SVGFontFaceElement.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07fe5a0a
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r132782. · cbde819f
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/132782
      https://bugs.webkit.org/show_bug.cgi?id=100653
      
      It made 400+ tests fail and 180 tests flakey on Qt (Requested
      by Ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-29
      
      Tools:
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
      
      LayoutTests:
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbde819f
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r132736. · 28fab5ba
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/132736
      https://bugs.webkit.org/show_bug.cgi?id=100652
      
      It broke all plugin related tests on GTK and on Qt (Requested
      by Ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-29
      
      * wtf/text/WTFString.cpp:
      (WTF::String::fromUTF8):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28fab5ba
    • tkent@chromium.org's avatar
      [Chromium] Merge LocalizedNumberICUTest into LocaleICUTest · 4a676a6c
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100648
      
      Reviewed by Kentaro Hara.
      
      LocalizedNumberICU was removed some months ago, and its features were
      merged to LocaleICU. We merge the test too.
      
      * WebKit.gypi: Remove LocalizedNumberICUTest.cpp
      * tests/LocaleICUTest.cpp:
      Move a #if because some headers are used unconditionally.
      (testDecimalSeparator): Moved from LocalizedNumberICUTest.cpp.
      (TEST_F): Ditto.
      (testNumberIsReversible): Ditto.
      (testNumbers): Ditto.
      * tests/LocalizedNumberICUTest.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a676a6c
    • allan.jensen@digia.com's avatar
      [Qt] Flaky security tests · e726b583
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100388
      
      Reviewed by Jocelyn Turcotte.
      
      Tools:
      
      Disable text output and load a blank URL to ensure the documentLoader is cleared
      before we start dumping text for the new page. Otherwise messages from the old page
      may end up in the text output of the new test.
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
      
      LayoutTests:
      
      Unskip no longer flaky tests.
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e726b583
    • jochen@chromium.org's avatar
      [chromium] remove remaining usages of webkit_support from the TestRunner library · 1afbceee
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100344
      
      Reviewed by Adam Barth.
      
      The most important part is to not rely on calling out to gdk/X11 to
      translate keycodes to hardware keycodes, as this is not possible inside
      the sandbox.
      
      * DumpRenderTree/DumpRenderTree.gypi:
      * DumpRenderTree/chromium/DRTTestRunner.h:
      (WebKit):
      (webkit_support):
      * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
      (WebTestDelegate):
      * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
      * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
      (WebTestRunner):
      (WebTestRunner::EventSender::doDragDrop):
      (WebTestRunner::EventSender::updateClickCountForButton):
      (WebTestRunner::EventSender::mouseDown):
      (WebTestRunner::EventSender::mouseUp):
      (WebTestRunner::EventSender::mouseMoveTo):
      (WebTestRunner::EventSender::keyDown):
      (WebTestRunner::EventSender::replaySavedEvents):
      (WebTestRunner::EventSender::contextClick):
      (WebTestRunner::EventSender::beginDragWithFiles):
      (WebTestRunner::EventSender::sendCurrentTouchEvent):
      (WebTestRunner::EventSender::handleMouseWheel):
      (WebTestRunner::EventSender::gestureEvent):
      (WebTestRunner::EventSender::gestureFlingCancel):
      (WebTestRunner::EventSender::gestureFlingStart):
      * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added.
      (WebTestRunner):
      (WebTestRunner::NativeKeyCodeForWindowsKeyCode):
      * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.
      (WebTestRunner):
      * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
      (TestDelegate):
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
      * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
      (WebTestInterfaces::Internal):
      (WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond):
      (WebTestRunner):
      (WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path):
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::getCurrentTimeInMillisecond):
      (WebViewHost::getAbsoluteWebStringFromUTF8Path):
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1afbceee
    • jocelyn.turcotte@digia.com's avatar
      [WK2] Enable delegated scrolling as soon as the FrameView is created when using fixed layout · 2a01b626
      jocelyn.turcotte@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100383
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Scroll requests and PageTransitionViewportReady messages depend on
      delegated scrolling being set properly on the FrameView to behave
      properly. Since we were waiting for the viewport information to be
      ready before setting the flag this could cause those messages to be avoided.
      
      This patch takes most of the flag set by setResizesToContentsUsingLayoutSize
      and apply them as soon as possible in WebPage::setUseFixedLayout and
      WebFrameLoaderClient::transitionToCommittedForNewPage.
      
      The behavior should be the same except for the following settings which are
      now set outside of USE(TILED_BACKING_STORE) if we're using fixed layout:
      - setAcceleratedCompositingForFixedPositionEnabled
      - setFixedElementsLayoutRelativeToFrame
      - setFixedPositionCreatesStackingContext
      
      This fixes the tst_QQuickWebView::scrollRequest auto test and improves the
      reliability of the loadVisuallyCommitted signal with pages loaded from disk.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::sendViewportAttributesChanged):
      (WebKit::WebPage::setUseFixedLayout):
      (WebKit::WebPage::setFixedLayoutSize):
      * WebProcess/WebPage/WebPage.h:
      (WebPage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a01b626
    • podivilov@chromium.org's avatar
      2012-10-29 Pavel Podivilov <podivilov@google.com> · 7f5e172c
      podivilov@chromium.org authored
              [Chromium] Test expectation update.
      
              Unreviewed, mark recently added audiobuffersource-loop-points.html test as failing on windows.
      
              * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f5e172c
    • tkent@chromium.org's avatar
      [Chromium] Rename LocalizedDateICUTest.cpp to LocaleICUTest.cpp · 6e29cdbf
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100643
      
      Reviewed by Kentaro Hara.
      
      LocalizedDateICU was removed some months ago, and LocalizedDateICUTest
      actually had tests for LocaleICU.
      
      * WebKit.gypi:
      * tests/LocaleICUTest.cpp:
      - Renamed from Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp.
      - Rename LocalizedDateICUTest class to LocaleICUTest.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e29cdbf
    • tkent@chromium.org's avatar
      Move LocaleWin.{cpp,h} to platform/text/win/ · 353f517d
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100641
      
      Reviewed by Kentaro Hara.
      
      We have platform/text/win/ directory. Windows-specific files should be
      in it.
      Note that these files are used only in Chromium-win for now.
      
      No new tests. This doesn't change any behavior.
      
      * WebCore.gyp/WebCore.gyp: Fix path names.
      * WebCore.gypi: Ditto.
      * platform/text/win/LocaleWin.cpp: Renamed from Source/WebCore/platform/text/LocaleWin.cpp.
      * platform/text/win/LocaleWin.h: Renamed from Source/WebCore/platform/text/LocaleWin.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      353f517d
    • rakuco@webkit.org's avatar
      Unreviewed build fix after r132709. · 21f152bd
      rakuco@webkit.org authored
      * Shared/WebMemorySampler.cpp: Include unistd.h for getpid(3).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21f152bd
    • tkent@chromium.org's avatar
      [Chromium-linux] Fix build. · 6388b4d1
      tkent@chromium.org authored
      * tests/LocalizedNumberICUTest.cpp:
      (testNumberIsReversible): Rename an argument.
      (testDecimalSeparator): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6388b4d1
    • tkent@chromium.org's avatar
      Rename Localizer to Locale · 0c53f9c8
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100634
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      - Rename Localizer class to Locale
      - Rename localizer with locale in variable names
      - Rename localizer with locale in function names
      
      No new tests. This doesn't make any behavior changes.
      
      * dom/Document.h:
      (WebCore): Declare Locale instead of Localizer.
      (Document):
      - Rename getCachedLocalizer to getCachedLocale.
      - Rename LocaleToLocalizerMap to LocaleIdentifierToLocaleMap.
      - Rename m_localizerCache to m_localeCache.
      * dom/Document.cpp:
      (WebCore::Document::getCachedLocale): Follow renamings.
      * dom/Element.h:
      (WebCore): Declare Locale instead of Localizer.
      (Element): Rename localizer() to locale().
      * dom/Element.cpp:
      (WebCore::Element::locale): Follow renamings.
      
      * html/BaseDateAndTimeInputType.cpp:
      (WebCore::BaseDateAndTimeInputType::localizeValue): Ditto.
      (WebCore::BaseDateAndTimeInputType::convertFromVisibleValue): Ditto.
      * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Ditto.
      * html/DateInputType.cpp:
      (WebCore::DateInputType::fixedPlaceholder): Ditto.
      (WebCore::DateInputType::setupLayoutParameters): Ditto.
      * html/DateTimeInputType.cpp:
      (WebCore::DateTimeInputType::setupLayoutParameters): Ditto.
      * html/DateTimeLocalInputType.cpp:
      (WebCore::DateTimeLocalInputType::setupLayoutParameters): Ditto.
      * html/MonthInputType.cpp:
      (WebCore::MonthInputType::setupLayoutParameters): Ditto.
      * html/NumberInputType.cpp:
      (WebCore::NumberInputType::localizeValue): Ditto.
      (WebCore::NumberInputType::convertFromVisibleValue): Ditto.
      * html/TimeInputType.cpp:
      (WebCore::TimeInputType::localizeValue): Ditto.
      (WebCore::TimeInputType::setupLayoutParameters): Ditto.
      
      * html/shadow/DateTimeEditElement.h:
      (WebCore): Declare Locale instead of Localizer.
      (LayoutParameters): Rename localizer data member to locale.
      (WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters): Follow renamings.
      * html/shadow/DateTimeEditElement.cpp:
      (WebCore::DateTimeEditBuilder::visitField): Ditto.
      * html/shadow/DateTimeNumericFieldElement.h:
      (DateTimeNumericFieldElement): Rename localizerForOwner to localeForOwner.
      * html/shadow/DateTimeNumericFieldElement.cpp:
      (WebCore::DateTimeNumericFieldElement::formatValue): Follow renamings.
      (WebCore::DateTimeNumericFieldElement::handleKeyboardEvent): Ditto.
      (WebCore::DateTimeNumericFieldElement::localeForOwner): Ditto.
      * page/PagePopupClient.h:
      (WebCore): Declare Locale instead of Localizer.
      (PagePopupClient): Rename localizer member function to locale.
      * page/PagePopupController.cpp:
      (WebCore::PagePopupController::localizeNumberString): Follow renamings.
      
      * platform/text/PlatformLocale.cpp: Rename the Localizer class to Locale.
      (DateTimeStringBuilder):
      (WebCore::DateTimeStringBuilder::DateTimeStringBuilder):
      (WebCore::Locale::~Locale):
      (WebCore::Locale::setLocaleData): Renamed from setLocalizerData.
      (WebCore::Locale::convertToLocalizedNumber):
      (WebCore::Locale::detectSignAndGetDigitRange):
      (WebCore::Locale::matchedDecimalSymbolIndex):
      (WebCore::Locale::convertFromLocalizedNumber):
      (WebCore::Locale::localizedDecimalSeparator):
      (WebCore::Locale::dateTimeFormatWithSeconds):
      (WebCore::Locale::dateTimeFormatWithoutSeconds):
      (WebCore::Locale::formatDateTime):
      * platform/text/PlatformLocale.h: Update the ifndef macro.
      (Locale): Renamed from Localizer. Also, renamed the followings:
       - initializeLocalizerData -> initializeLocaleData
       - setLocalizerData -> setLocaleData
       - m_hasLocalizerData -> m_hasLocaleData
      (WebCore::Locale::Locale):
      (WebCore::Locale::createDefault):
      * platform/text/LocaleICU.cpp: Follow renamings.
      * platform/text/LocaleICU.h: Ditto.
      * platform/text/LocaleNone.cpp: Ditto.
      * platform/text/LocaleWin.cpp: Ditto.
      * platform/text/LocaleWin.h: Ditto.
      * platform/text/mac/LocaleMac.h: Ditto.
      * platform/text/mac/LocaleMac.mm: Ditto.
      
      Source/WebKit/chromium:
      
      * src/ColorChooserUIController.h:
      (ColorChooserUIController):
      Rename m_localizer to m_locale, and follow other renamings.
      * src/ColorChooserUIController.cpp:
      (WebKit::ColorChooserUIController::ColorChooserUIController): Follow renamings.
      (WebKit::ColorChooserUIController::locale): Ditto.
      * src/DateTimeChooserImpl.h:
      (DateTimeChooserImpl):
      Rename m_localizer to m_locale, and follow other renamings.
      * src/DateTimeChooserImpl.cpp:
      (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): Follow renamings.
      (WebKit::DateTimeChooserImpl::writeDocument): Ditto.
      (WebKit::DateTimeChooserImpl::locale): Ditto.
      * tests/LocaleMacTest.cpp:
      (LocaleMacTest::formatTime): Ditto.
      (testNumberIsReversible): Ditto.
      * tests/LocalizedNumberICUTest.cpp:
      (testNumberIsReversible): Ditto.
      (testDecimalSeparator): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c53f9c8
    • mkwst@chromium.org's avatar
      Web Inspector: Error messages lines in console are 1px taller than regular messages · eedd4655
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100521
      
      Reviewed by Pavel Feldman.
      
      The inspector is adding a 1px bottom border to list elements inside
      a disclosure list. This is unnecessary in the current layout; it's
      causing console messages with stack traces to be one pixel taller than
      other console messages, which this patch fixes.
      
      As a drive-by, this patch also adjusts the disclosure triangle's
      position to match.
      
      * inspector/front-end/inspector.css:
      (.outline-disclosure li):
      (.outline-disclosure li.parent::before):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eedd4655
    • mkwst@chromium.org's avatar
      Web Inspector: The bubble for repeated errors is misplaced. · 85a6730f
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100525
      
      Reviewed by Pavel Feldman.
      
      The repeated-message bubble is displayed as an inline-block element,
      which works well as long as no stack trace is present. If present, the
      message is wrapped in an 'ol' element displayed as a block, which pushes
      itself down to the next line.
      
      To avoid that issue, this patch switches the wrapper element to flexbox,
      glorious flexbox.
      
      * inspector/front-end/inspector.css:
      (.console-message .bubble):
      (.repeated-message .outline-disclosure):
      (.filter-all .console-log-level.repeated-message, .filter-logs .console-log-level.repeated-message):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85a6730f
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update. · 7a70ee47
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99818
      
      The failure of month-multiple-fields-keyboard-events.html on SnowLeopard
      and XP is expected.
      
      - OS X SnowLeopard
        The month forma is "yyyy MMMM" on SnowLoepard though it's "MMMM yyyy"
        on other platforms.
      
      - Windows XP
        It doesn't support the lang-attribute-aware-form-control-UI testing
      feature.
      
      * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt.
      * platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a70ee47
    • commit-queue@webkit.org's avatar
      [EFL] Skip 2 tests failing due to missing drag'n drop support · 46131ea6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100638
      
      Unreviewed EFL gardening.
      
      Skip 2 test cases failing due to missing drag'n drop support
      in EFL port.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-29
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46131ea6
    • commit-queue@webkit.org's avatar
      [EFL] Skip 2 jquery tests crashing after r132757 · e34b24c0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100637
      
      Unreviewed EFL gardening.
      
      Skip 2 jquery test cases that started crashing after
      r132757.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-29
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e34b24c0
    • apavlov@chromium.org's avatar
      Web Inspector: [Styles] Handle non-parsedOk properties as inactive ones · 4f3532d2
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100119
      
      Reviewed by Vsevolod Vlasov.
      
      Source/WebCore:
      
      Test: inspector/styles/inactive-properties.html
      
      * inspector/front-end/StylesSidebarPane.js:
      (WebInspector.StylesSidebarPane.createExclamationMark):
      (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
      * inspector/front-end/elementsPanel.css:
      (.styles-section.computed-style .properties li.not-parsed-ok):
      (.styles-section.computed-style .properties li.not-parsed-ok img.exclamation-mark):
      (.styles-section .properties .not-parsed-ok):
      
      LayoutTests:
      
      * http/tests/inspector/elements-test.js:
      (initialize_ElementTest.InspectorTest.dumpStyleTreeItem):
      * inspector/styles/inactive-properties-expected.txt: Added.
      * inspector/styles/inactive-properties.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f3532d2
    • eric@webkit.org's avatar
      Technical Articles should link to an old talk I gave · 4941ebe5
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100624
      
      Reviewed by Adam Barth.
      
      * coding/technical-articles.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4941ebe5
    • jonathan.dong@torchmobile.com.cn's avatar
      Unreviewed. Add jonathan.dong@torchmobile.com.cn as a committer. · 575931e6
      jonathan.dong@torchmobile.com.cn authored
      https://bugs.webkit.org/show_bug.cgi?id=100629
      
      
      * Scripts/webkitpy/common/config/committers.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      575931e6
    • kkristof@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · c5ab690b
      kkristof@inf.u-szeged.hu authored
      Skip some tests because SHADOW_DOM is disabled on Qt.
      Unskip another one that doesn't exist already.
      
      Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-29
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5ab690b
    • eric@webkit.org's avatar
      Make rendering tables with <colgroups> twice as fast by avoiding walking the... · 1670728d
      eric@webkit.org authored
      Make rendering tables with <colgroups> twice as fast by avoiding walking the DOM for colgroups 4 times for each cell
      https://bugs.webkit.org/show_bug.cgi?id=100630
      
      Reviewed by Ojan Vafai.
      
      This is not a complete fix.  Our rendering of this large tables still takes 7.8 seconds
      on my retina MBP (down from 14.3s before this change).
      It's very expensive to walk the DOM each time we call RenderTable::colElement
      so this caches the RenderTableCol* in a vector for easier walking.
      We invalidate the cache any time a RenderTableCol is added or removed from the
      rendering sub-tree to avoid holding a bad pointer.
      
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::RenderTable):
      (WebCore::RenderTable::invalidateCachedColumns):
      (WebCore):
      (WebCore::RenderTable::addColumn):
      (WebCore::RenderTable::removeColumn):
      (WebCore::RenderTable::updateColumnCache):
      (WebCore::RenderTable::slowColElement):
      * rendering/RenderTable.h:
      (RenderTable):
      * rendering/RenderTableCol.cpp:
      (WebCore::RenderTableCol::insertedIntoTree):
      (WebCore):
      (WebCore::RenderTableCol::willBeRemovedFromTree):
      * rendering/RenderTableCol.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1670728d
    • tkent@chromium.org's avatar
      Unreviewed. Rolled DEPS. · cd65b9f9
      tkent@chromium.org authored
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd65b9f9
    • tkent@chromium.org's avatar
      Rename Localizer.{cpp,h} to PlatformLocale.{cpp,h} · fe8acbf9
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100627
      
      Reviewed by Yuta Kitamura.
      
      Source/WebCore:
      
      We'd like to rename Localizer class to Locale class. However we use
      PlatformLocale.cpp and PlatformLocale.h as their file names because
      <locale.h> exists in the C standard.  In this patch, we rename only file
      names. We're going to rename the class name later.
      
      No new tests. This doesn't make any behavior change.
      
      * platform/text/PlatformLocale.h: Renamed from Source/WebCore/platform/text/Localizer.h.
      * platform/text/PlatformLocale.cpp: Renamed from Source/WebCore/platform/text/Localizer.cpp.
      Follow the Localizer.h -> PlatformLocale.cpp renaming.
      
      * CMakeLists.txt: Follow the file name renaming.
      * GNUmakefile.list.am: Ditto.
      * Target.pri: Ditto.
      * WebCore.gypi: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      * dom/Document.cpp: Ditto.
      * html/BaseDateAndTimeInputType.cpp: Ditto.
      * html/BaseMultipleFieldsDateAndTimeInputType.cpp: Ditto.
      * html/DateInputType.cpp: Ditto.
      * html/DateTimeInputType.cpp: Ditto.
      * html/DateTimeLocalInputType.cpp: Ditto.
      * html/MonthInputType.cpp: Ditto.
      * html/NumberInputType.cpp: Ditto.
      * html/TimeInputType.cpp: Ditto.
      * html/shadow/DateTimeEditElement.cpp: Ditto.
      * html/shadow/DateTimeNumericFieldElement.cpp: Ditto.
      * page/PagePopupController.cpp: Ditto.
      * platform/text/LocaleICU.h: Ditto.
      * platform/text/LocaleNone.cpp: Ditto.
      * platform/text/LocaleWin.h: Ditto.
      * platform/text/mac/LocaleMac.h: Ditto.
      
      Source/WebKit/chromium:
      
      * src/ColorChooserUIController.h: Follow the file name renaming.
      * src/DateTimeChooserImpl.cpp: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe8acbf9
  2. 28 Oct, 2012 15 commits
    • commit-queue@webkit.org's avatar
      [WK2] Fix the incorrect use of preprocessor statement in API header. · 734571e9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100610
      
      Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-28
      Reviewed by Timothy Hatcher.
      
      Remove the preprocessor statement to check 'ENABLE_INSPECTOR' feature
      from the WKPage.h.
      
      * UIProcess/API/C/WKPage.cpp:
      (WKPageGetInspector):
      * UIProcess/API/C/WKPage.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      734571e9
    • shinyak@chromium.org's avatar
      The shadow element is not reprojected to a nested ShadowRoot. · d972dbe0
      shinyak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99228
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      We support shadow reprojection; elements distributed to <shadow> element can be reprojected to <content> now.
      
      First, we have a distribution vector for each InsertionPoint, even if InsertionPoint is a shadow insertion point.
      And we update a node-distribution map. Basically We're creating a map from node to InsertionPoint in ElementShadow.
      If a node can be distributed to several InsertionPoint (e.g. in case reprojection happens),
      the InsertionPoint in older ShadowDOM is chosen.
      
      We also fix ComposedShadowTreeWalker to consider shadow reprojection.
      
      Tests: fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection.html
             fast/dom/shadow/shadow-reprojection-click.html
             fast/dom/shadow/shadow-reprojection-dynamic.html
             fast/dom/shadow/shadow-reprojection-fallback.html
             fast/dom/shadow/shadow-reprojection.html
             fast/dom/shadow/shadow-reprojection2.html
      
      * css/StyleResolver.cpp:
      (WebCore::shouldResetStyleInheritance): Now context.insertionPoint() returns the final insertion point where
      a node is distributed. So we don't have to trace shadow insertion point anymore here.
      (WebCore::StyleResolver::styleForElement): Since a direct child of ShadowRoot can be distributed now. In that case,
      we don't have any parentElement. The parent node is a ShadowRoot in that case.
      * dom/ComposedShadowTreeWalker.cpp:
      (WebCore::nodeCanBeDistributed): If a node can be distributed, returns true.
      (WebCore):
      (WebCore::resolveReprojection): Resolves content-reprojection and shadow-reprojection both.
      (WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
      (WebCore::ComposedShadowTreeWalker::traverseParent):
      (WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost): A case ShadowRoot is assigned
      to some InsertionPoint should be handled with in traverseSiblingOrBackToInsertionPoint. So we remove it.
      (WebCore::AncestorChainWalker::parent): Now we have a case that a direct child of ShadowRoot can be distributed.
      In that case, we should not update m_distributedNode.
      * dom/ElementShadow.cpp:
      (WebCore::ElementShadow::insertionPointFor): Since we have a distribution vector for each InsertionPoint,
      we don't have a special case that a ShadowRoot is assigned to some InsertionPoint. Actually the existing code
      is not correct now due to shadow reprojection.
      * html/shadow/ContentDistributor.cpp:
      (WebCore::ContentDistributor::populate): Populate a POOL. If a node is InsertionPoint, we fill it with the
      distributed nodes.
      (WebCore):
      (WebCore::ContentDistributor::distribute): Since we want to make a distribution vector for each InsertionPoint,
      we have to resolve a shadow InsertionPoint
      (WebCore::ContentDistributor::distributeNodeChildrenTo):
      * html/shadow/ContentDistributor.h:
      (ContentDistributor):
      * html/shadow/HTMLShadowElement.h:
      (WebCore::toHTMLShadowElement):
      (WebCore):
      * html/shadow/InsertionPoint.h:
      (WebCore::parentNodeForDistribution):
      (WebCore::parentElementForDistribution):
      (WebCore):
      
      LayoutTests:
      
      * fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection-expected.txt: Added.
      * fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection.html: Added. A walker test case for elements distributed
      to shadow element are reprojected.
      * fast/dom/shadow/composed-shadow-tree-walker.html:
      * fast/dom/shadow/content-reprojection-complex.html:
      * fast/dom/shadow/content-reprojection-fallback-expected.html:
      * fast/dom/shadow/content-reprojection-fallback-reprojection-expected.html:
      * fast/dom/shadow/shadow-reprojection-click-expected.txt: Added.
      * fast/dom/shadow/shadow-reprojection-click.html: Added. Does some interactive with a shadow-reprojected node.
      * fast/dom/shadow/shadow-reprojection-dynamic-expected.html: Added.
      * fast/dom/shadow/shadow-reprojection-dynamic.html: Added. Adds dynamically elements shadow-reprojected.
      * fast/dom/shadow/shadow-reprojection-expected.html: Added.
      * fast/dom/shadow/shadow-reprojection-fallback-expected.html: Added.
      * fast/dom/shadow/shadow-reprojection-fallback.html: Added. A test case for fallback elements of a shadow element
      are reprojected.
      * fast/dom/shadow/shadow-reprojection-prohibited-expected.html: Removed.
      * fast/dom/shadow/shadow-reprojection-prohibited.html: Removed.
      * fast/dom/shadow/shadow-reprojection.html: Added. A basic test case.
      * fast/dom/shadow/shadow-reprojection2-expected.html: Added.
      * fast/dom/shadow/shadow-reprojection2.html: Added. Another basic test case.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d972dbe0
    • fpizlo@apple.com's avatar
      DFG should be able to emit effectful structure checks · 99f3762d
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=99260
      
      Reviewed by Oliver Hunt.
      
      This change allows us to find out if an array access that has gone polymorphic
      is operating over known structures - i.e. the primordial array structures of the
      global object that the code block containing the array access belongs to. We
      term this state "OriginalArray" for short. The fact that the access has gone
      polymorphic means that the array profile will not be able to report the set of
      structures it had seen - but if it can tell us that all of the structures were
      primordial then it just so happens that we can deduce what the structure set
      would have been by just querying the code block's global object. This allows us
      to emit an ArrayifyToStructure instead of an Arrayify if we find that we need to
      do conversions. The fast path of an ArrayifyToStructure is exactly like the fast
      path of a CheckStructure and is mostly subject to the same optimizations. It
      also burns one fewer registers.
              
      Essentially the notion of OriginalArray is a super cheap way of getting the
      array profile to tell us a structure set instead of a singleton structure.
      Currently, the array profile can only tell us the structure seen at an array
      access if there was exactly one structure. If there were multiple structures, it
      won't tell us anything other than the array modes and other auxiliary profiling
      data (whether there were stores to holes, for example). With OriginalArray, we
      cheaply get a structure set if all of the structures were primordial for the
      code block's global object, since in that case the array mode set (ArrayModes)
      can directly tell us the structure set. In the future, we might consider adding
      complete structure sets to the array profiles, but I suspect that we would hit
      diminishing returns if we did so - it would only help if we have array accesses
      that are both polymorphic and are cross-global-object accesses (rare) or if the
      arrays had named properties or other structure transitions that are unrelated to
      indexing type (also rare).
              
      This also does away with Arrayify (and the new ArrayifyToStructure) returning
      the butterfly pointer. This turns out to be faster and easier to CSE.
              
      And, this also changes constant folding to be able to eliminate CheckStructure,
      ForwardCheckStructure, and ArrayifyToStructure in addition to being able to
      transform them into structure transition watchpoints. This is great for
      ArrayifyToStructure because then CSE and CFA know that there is no side effect.
      Converting CheckStructure and ForwardCheckStructure to also behave this way is
      just a matter of elegance.
              
      This has no performance impact right now. It's intended to alleviate some of the
      regressions seen in the early implementation of
      https://bugs.webkit.org/show_bug.cgi?id=98606.
      
      * bytecode/ArrayProfile.cpp:
      (JSC::ArrayProfile::computeUpdatedPrediction):
      * bytecode/ArrayProfile.h:
      (JSC):
      (JSC::ArrayProfile::ArrayProfile):
      (ArrayProfile):
      (JSC::ArrayProfile::usesOriginalArrayStructures):
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
      * dfg/DFGAbstractState.cpp:
      (JSC::DFG::AbstractState::execute):
      * dfg/DFGArrayMode.cpp:
      (JSC::DFG::ArrayMode::fromObserved):
      (JSC::DFG::ArrayMode::alreadyChecked):
      (JSC::DFG::arrayClassToString):
      * dfg/DFGArrayMode.h:
      (JSC::DFG::ArrayMode::withProfile):
      (JSC::DFG::ArrayMode::isJSArray):
      (ArrayMode):
      (JSC::DFG::ArrayMode::isJSArrayWithOriginalStructure):
      (JSC::DFG::ArrayMode::supportsLength):
      (JSC::DFG::ArrayMode::arrayModesWithIndexingShape):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::getArrayMode):
      (JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
      (JSC::DFG::ByteCodeParser::handleGetByOffset):
      * dfg/DFGCSEPhase.cpp:
      (JSC::DFG::CSEPhase::checkStructureElimination):
      (JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
      (JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
      (JSC::DFG::CSEPhase::checkArrayElimination):
      (JSC::DFG::CSEPhase::getScopeRegistersLoadElimination):
      * dfg/DFGConstantFoldingPhase.cpp:
      (JSC::DFG::ConstantFoldingPhase::foldConstants):
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::fixupNode):
      (JSC::DFG::FixupPhase::checkArray):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::hasStructure):
      (JSC::DFG::Node::hasArrayMode):
      (JSC::DFG::Node::arrayMode):
      * dfg/DFGNodeType.h:
      (DFG):
      * dfg/DFGPredictionPropagationPhase.cpp:
      (JSC::DFG::PredictionPropagationPhase::propagate):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
      (JSC::DFG::SpeculativeJIT::arrayify):
      * dfg/DFGSpeculativeJIT.h:
      (SpeculativeJIT):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::isOriginalArrayStructure):
      * runtime/Structure.cpp:
      (JSC::Structure::nonPropertyTransition):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99f3762d
    • commit-queue@webkit.org's avatar
      Webkit adds a boundary to the Content-Type: text/plain POST header · 6e1f0a37
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100445
      
      Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-10-28
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      Fixed a bug where an empty boundary parameter was added to Content-Type
      header when POSTing forms with enctype=text/plain.
      
      Test: http/tests/misc/form-post-textplain.html
      
      * loader/FormSubmission.cpp:
      (WebCore::FormSubmission::populateFrameLoadRequest): Add boundary parameter to
      Content-Type only when a boundary string is generated.
      
      LayoutTests:
      
      Fixed test failure and added a test case for Content-Type header.
      
      * http/tests/misc/form-post-textplain-expected.txt:
      * http/tests/misc/form-post-textplain.html:
      * http/tests/misc/resources/form-post-textplain.php:
      Added a test case for testing Content-Type POST header.
      Also fixed existing test case that attempted to test newline in the input value.
      LF in the input value is replaced with CRLF durling the construction of the form data set.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e1f0a37
    • fpizlo@apple.com's avatar
      There should not be blind spots in array length array profiling · eef132ec
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100620
      
      Reviewed by Oliver Hunt.
      
      I don't think this has any performance impact. But it's good to not have random
      programs occasionally emit a GetById for array length accesses.
      
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::compileGetByIdHotPath):
      (JSC::JIT::privateCompilePatchGetArrayLength):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::compileGetByIdHotPath):
      (JSC::JIT::privateCompilePatchGetArrayLength):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eef132ec
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update · b593b968
      tkent@chromium.org authored
      Rebaseline for http://trac.webkit.org/changeset/132753
      
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b593b968
    • pdr@google.com's avatar
      Cache calcMode() value for SVG animations. · 35f7ea4b
      pdr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=99694
      
      Reviewed by Eric Seidel.
      
      This patch refactors SVGAnimationElement::calcMode() to return a cached value instead
      of recalculating its value on every call. On a simple test of 100 rectangles with 100
      animations each, calls to calcMode() account for 3% of the total animation. After this
      patch, calcMode() no longer appears in animation profiles at all.
      
      No new tests as this functionality is covered by existing tests.
      
      * svg/SVGAnimateMotionElement.cpp:
      (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
      
          The default calcMode for all animation types is linear except AnimateMotion,
          which defaults to CalcModePaced.
          See: http://www.w3.org/TR/SVG/single-page.html#animate-CalcModeAttribute
      
      * svg/SVGAnimationElement.cpp:
      (WebCore::SVGAnimationElement::SVGAnimationElement):
      (WebCore::SVGAnimationElement::isSupportedAttribute):
      (WebCore::SVGAnimationElement::parseAttribute):
      (WebCore::SVGAnimationElement::setCalcMode):
      * svg/SVGAnimationElement.h:
      (WebCore::SVGAnimationElement::calcMode):
      (WebCore::SVGAnimationElement::setCalcMode):
      (SVGAnimationElement):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35f7ea4b
    • dglazkov@chromium.org's avatar
      Get rid of StyleResolver state related to unknown pseudo-elements. · 43989c4a
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100582
      
      Reviewed by Eric Seidel.
      
      All of the state, related to unknown pseudo-elements is already understood at the time of collecting rules.
      We can just get rid of most of this code in StyleResolver.
      
      At the time of matching rules, we know for certain that only rules that contain unknown pseudo-elements,
      or are UA rules, or are explicitly invited by a TreeScope will match. So we can just return early in many cases.
      
      No change in behavior, covered by existing tests.
      
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkSelector): Removed now-unnecessary param.
      (WebCore::SelectorChecker::checkOneSelector): Ditto.
      * css/SelectorChecker.h:
      (SelectorChecker): Ditto.
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::StyleResolver): Ditto.
      (MatchingUARulesScope): Moved class definition here, since we now use it in a different place.
      (WebCore::StyleResolver::collectMatchingRules): Changed the logic to stop matching rules that definitely won't match in a different scope.
      (WebCore::StyleResolver::collectMatchingRulesForList): Removed code that's now unnecesssary.
      (WebCore::StyleResolver::checkSelector): Removed now-unnecessary param.
      (WebCore::StyleResolver::checkRegionSelector): Removed weird dead code.
      * css/StyleResolver.h:
      (StyleResolver): Removed now-unnecessary member.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43989c4a
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r132696. · 1c0c7a7c
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/132696
      https://bugs.webkit.org/show_bug.cgi?id=100609
      
      Needs a bit more clean-up on Chrome Web UI side. (Requested by
      dglazkov on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-28
      
      Source/WebCore:
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::updateFirstLetter):
      * rendering/RenderListBox.h:
      * rendering/RenderObjectChildList.cpp:
      (WebCore::RenderObjectChildList::updateBeforeAfterContent):
      
      LayoutTests:
      
      * fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
      * fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
      * fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:
      * fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
      * fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
      * fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html:
      * fast/forms/pseudo-elements-expected.html: Removed.
      * fast/forms/pseudo-elements.html: Removed.
      * fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
      * fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
      * fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html:
      * fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
      * fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
      * fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html:
      * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c0c7a7c
    • fpizlo@apple.com's avatar
      Unreviewed, make always-true enum-to-int comparisons use casts. · e8ef080d
      fpizlo@apple.com authored
      * dfg/DFGFPRInfo.h:
      (JSC::DFG::FPRInfo::debugName):
      * dfg/DFGGPRInfo.h:
      (JSC::DFG::JSValueSource::tagGPR):
      (JSC::DFG::GPRInfo::toIndex):
      (JSC::DFG::GPRInfo::debugName):
      * runtime/JSTypeInfo.h:
      (JSC::TypeInfo::TypeInfo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8ef080d
    • commit-queue@webkit.org's avatar
      [EFL][WK2][AC] Viewport size does not change when the window size changes · ca148d55
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100573
      
      Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-28
      Reviewed by Kenneth Rohde Christiansen.
      
      The viewport size is set when we create the window the first time
      and does not change automatically afterwards. When we change the window size,
      we need to explicitly change the viewport size as well.
      
      * UIProcess/API/efl/EwkViewImpl.cpp:
      (EwkViewImpl::createGLSurface):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca148d55
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update · a5728982
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100128
      
      Rebaseline for http://trac.webkit.org/changeset/132718 and crrev.com/164515.
      
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5728982
    • fpizlo@apple.com's avatar
      OSR exit compilation should defend against argument recoveries from code... · c071eaaf
      fpizlo@apple.com authored
      OSR exit compilation should defend against argument recoveries from code blocks that are no longer on the inline stack
      https://bugs.webkit.org/show_bug.cgi?id=100601
      
      Reviewed by Oliver Hunt.
      
      This happened to me while I was fixing bugs for https://bugs.webkit.org/show_bug.cgi?id=100599.
      I'm not sure how to reproduce this.
      
      * dfg/DFGAssemblyHelpers.h:
      (JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
      (AssemblyHelpers):
      * dfg/DFGOSRExitCompiler32_64.cpp:
      (JSC::DFG::OSRExitCompiler::compileExit):
      * dfg/DFGOSRExitCompiler64.cpp:
      (JSC::DFG::OSRExitCompiler::compileExit):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c071eaaf
    • ossy@webkit.org's avatar
      [Qt] Unreviewed weekend gardening, skip a failing test, update expected files. · 1db4549f
      ossy@webkit.org authored
      * platform/qt-5.0-wk2/TestExpectations:
      * platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
      * platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
      * platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
      * platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
      * platform/qt-5.0-wk2/http/tests/navigation/postredirect-basic-expected.txt: Added.
      * platform/qt-5.0-wk2/http/tests/navigation/postredirect-goback1-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1db4549f
    • ossy@webkit.org's avatar
      Unreviewed build fix for breakage to minimal bot caused by r132742. · 9e5ec9d9
      ossy@webkit.org authored
      Patch by Noam Rosenthal <noam.rosenthal@nokia.com> on 2012-10-27
      
      * WebProcess/WebPage/LayerTreeHost.h:
      (LayerTreeHost):
          Added appropriate ENABLE(REQUEST_ANIMATION_FRAME) flag.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e5ec9d9