1. 09 May, 2013 2 commits
    • ch.dumez@sisa.samsung.com's avatar
      Add support for [NoInterfaceObject] Web IDL extended attribute · 077c4e77
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115714
      
      Reviewed by Kentaro Hara.
      
      .:
      
      Update GENERATE_BINDINGS macro to take an additional _window_constructors_file
      optional argument.
      
      * Source/cmake/WebKitMacros.cmake:
      
      Source/WebCore:
      
      *Constructor attributes on the global DOMWindow object are now automatically
      generated for each non-callback interface that is not declared with the
      [NoInterfaceObject] extended attribute. It is thus no longer needed for
      developers to manually add *Constructor attributes for their new interfaces
      unless they wish to register an "extra" constructor for their interface.
      
      This patch does not modify at all the behavior on JS side. To achieve this,
      [NoInterfaceObject] extended attribute is added to interfaces that should
      not have it according to specification (e.g. History, Location, ...).
      This can be improved later as the behavior should not change with this
      patch.
      
      No new tests, no behavior change.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * Modules/battery/BatteryManager.idl:
      * Modules/encryptedmedia/MediaKeyMessageEvent.idl:
      * Modules/encryptedmedia/MediaKeyNeededEvent.idl:
      * Modules/encryptedmedia/MediaKeySession.idl:
      * Modules/encryptedmedia/MediaKeys.idl:
      * Modules/filesystem/DOMFileSystem.idl:
      * Modules/filesystem/DOMFileSystemSync.idl:
      * Modules/filesystem/DirectoryEntry.idl:
      * Modules/filesystem/DirectoryEntrySync.idl:
      * Modules/filesystem/DirectoryReader.idl:
      * Modules/filesystem/DirectoryReaderSync.idl:
      * Modules/filesystem/Entry.idl:
      * Modules/filesystem/EntryArray.idl:
      * Modules/filesystem/EntryArraySync.idl:
      * Modules/filesystem/EntrySync.idl:
      * Modules/filesystem/FileEntry.idl:
      * Modules/filesystem/FileEntrySync.idl:
      * Modules/filesystem/FileWriter.idl:
      * Modules/filesystem/FileWriterSync.idl:
      * Modules/filesystem/Metadata.idl:
      * Modules/gamepad/Gamepad.idl:
      * Modules/gamepad/GamepadList.idl:
      * Modules/geolocation/Coordinates.idl:
      * Modules/geolocation/Geolocation.idl:
      * Modules/geolocation/Geoposition.idl:
      * Modules/geolocation/PositionError.idl:
      * Modules/indexeddb/DOMWindowIndexedDatabase.idl:
      * Modules/indexeddb/IDBAny.idl:
      * Modules/mediasource/MediaSource.idl:
      * Modules/mediasource/SourceBuffer.idl:
      * Modules/mediasource/SourceBufferList.idl:
      * Modules/mediastream/DOMWindowMediaStream.idl: Removed.
      * Modules/mediastream/MediaStream.idl:
      * Modules/mediastream/MediaStreamTrack.idl:
      * Modules/mediastream/MediaStreamTrackEvent.idl:
      * Modules/mediastream/NavigatorUserMediaError.idl:
      * Modules/mediastream/RTCDTMFSender.idl:
      * Modules/mediastream/RTCDTMFToneChangeEvent.idl:
      * Modules/mediastream/RTCDataChannel.idl:
      * Modules/mediastream/RTCDataChannelEvent.idl:
      * Modules/mediastream/RTCIceCandidateEvent.idl:
      * Modules/mediastream/RTCPeerConnection.idl:
      * Modules/mediastream/RTCStatsReport.idl:
      * Modules/mediastream/RTCStatsResponse.idl:
      * Modules/networkinfo/NetworkInfoConnection.idl:
      * Modules/notifications/DOMWindowNotifications.idl:
      * Modules/notifications/NotificationCenter.idl:
      * Modules/quota/StorageInfo.idl:
      * Modules/quota/StorageQuota.idl:
      * Modules/speech/DOMWindowSpeech.idl: Removed.
      * Modules/speech/DOMWindowSpeechSynthesis.idl:
      * Modules/speech/SpeechGrammar.idl:
      * Modules/speech/SpeechGrammarList.idl:
      * Modules/speech/SpeechRecognition.idl:
      * Modules/speech/SpeechRecognitionAlternative.idl:
      * Modules/speech/SpeechRecognitionError.idl:
      * Modules/speech/SpeechRecognitionEvent.idl:
      * Modules/speech/SpeechRecognitionResult.idl:
      * Modules/speech/SpeechRecognitionResultList.idl:
      * Modules/speech/SpeechSynthesis.idl:
      * Modules/speech/SpeechSynthesisVoice.idl:
      * Modules/webaudio/AnalyserNode.idl:
      * Modules/webaudio/AudioBuffer.idl:
      * Modules/webaudio/AudioBufferSourceNode.idl:
      * Modules/webaudio/AudioContext.idl:
      * Modules/webaudio/AudioDestinationNode.idl:
      * Modules/webaudio/AudioListener.idl:
      * Modules/webaudio/AudioNode.idl:
      * Modules/webaudio/AudioParam.idl:
      * Modules/webaudio/AudioSourceNode.idl:
      * Modules/webaudio/BiquadFilterNode.idl:
      * Modules/webaudio/ChannelMergerNode.idl:
      * Modules/webaudio/ChannelSplitterNode.idl:
      * Modules/webaudio/ConvolverNode.idl:
      * Modules/webaudio/DOMWindowWebAudio.idl: Removed.
      * Modules/webaudio/DelayNode.idl:
      * Modules/webaudio/DynamicsCompressorNode.idl:
      * Modules/webaudio/GainNode.idl:
      * Modules/webaudio/MediaElementAudioSourceNode.idl:
      * Modules/webaudio/MediaStreamAudioDestinationNode.idl:
      * Modules/webaudio/MediaStreamAudioSourceNode.idl:
      * Modules/webaudio/OfflineAudioContext.idl:
      * Modules/webaudio/OscillatorNode.idl:
      * Modules/webaudio/PannerNode.idl:
      * Modules/webaudio/ScriptProcessorNode.idl:
      * Modules/webaudio/WaveShaperNode.idl:
      * Modules/webaudio/WaveTable.idl:
      * Modules/webdatabase/DOMWindowWebDatabase.idl:
      * Modules/webdatabase/Database.idl:
      * Modules/webdatabase/DatabaseSync.idl:
      * Modules/webdatabase/SQLError.idl:
      * Modules/webdatabase/SQLResultSet.idl:
      * Modules/webdatabase/SQLResultSetRowList.idl:
      * Modules/webdatabase/SQLTransaction.idl:
      * Modules/webdatabase/SQLTransactionSync.idl:
      * Modules/websockets/DOMWindowWebSocket.idl: Removed.
      * Modules/websockets/WebSocket.idl:
      * PlatformBlackBerry.cmake:
      * UseJSC.cmake:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/scripts/IDLAttributes.txt:
      * bindings/scripts/IDLParser.pm:
      (parseTypedef):
      * bindings/scripts/preprocess-idls.pl:
      (GenerateConstructorAttribute):
      (getFileContents):
      (getPartialInterfaceNameFromIDL):
      (isCallbackInterfaceFromIDL):
      (trim):
      (getInterfaceExtendedAttributesFromIDL):
      * css/CSSFontFaceLoadEvent.idl:
      * css/CSSFontFaceRule.idl:
      * css/CSSSupportsRule.idl:
      * css/CSSUnknownRule.idl:
      * css/DOMWindowCSS.idl:
      * css/FontLoader.idl:
      * css/MediaQueryList.idl:
      * css/MediaQueryListListener.idl:
      * css/StyleMedia.idl:
      * dom/CustomElementConstructor.idl:
      * dom/DOMError.idl:
      * dom/DOMNamedFlowCollection.idl:
      * dom/DataTransferItem.idl:
      * dom/DataTransferItemList.idl:
      * dom/EventListener.idl:
      * dom/EventTarget.idl:
      * dom/NodeIterator.idl:
      * dom/ShadowRoot.idl:
      * dom/TreeWalker.idl:
      * dom/WebKitNamedFlow.idl:
      * fileapi/FileException.idl:
      * fileapi/FileReaderSync.idl:
      * html/HTMLAudioElement.idl:
      * html/HTMLDetailsElement.idl:
      * html/HTMLOptionElement.idl:
      * html/MediaError.idl:
      * html/MediaKeyError.idl:
      * html/MicroDataItemValue.idl:
      * html/RadioNodeList.idl:
      * html/ValidityState.idl:
      * html/canvas/CanvasRenderingContext.idl:
      * html/canvas/DOMPath.idl:
      * html/canvas/EXTDrawBuffers.idl:
      * html/canvas/EXTTextureFilterAnisotropic.idl:
      * html/canvas/OESElementIndexUint.idl:
      * html/canvas/OESStandardDerivatives.idl:
      * html/canvas/OESTextureFloat.idl:
      * html/canvas/OESTextureHalfFloat.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/WebGLCompressedTextureATC.idl:
      * html/canvas/WebGLCompressedTexturePVRTC.idl:
      * html/canvas/WebGLCompressedTextureS3TC.idl:
      * html/canvas/WebGLContextAttributes.idl:
      * html/canvas/WebGLDebugRendererInfo.idl:
      * html/canvas/WebGLDebugShaders.idl:
      * html/canvas/WebGLDepthTexture.idl:
      * html/canvas/WebGLLoseContext.idl:
      * html/canvas/WebGLVertexArrayObjectOES.idl:
      * html/track/AudioTrack.idl:
      * html/track/AudioTrackList.idl:
      * html/track/TextTrackRegionList.idl:
      * html/track/VideoTrack.idl:
      * html/track/VideoTrackList.idl:
      * inspector/InjectedScriptHost.idl:
      * inspector/InspectorFrontendHost.idl:
      * inspector/JavaScriptCallFrame.idl:
      * inspector/ScriptProfile.idl:
      * inspector/ScriptProfileNode.idl:
      * loader/appcache/DOMApplicationCache.idl:
      * page/AbstractView.idl:
      * page/BarInfo.idl:
      * page/Console.idl:
      * page/Crypto.idl:
      * page/DOMSecurityPolicy.idl:
      * page/DOMWindow.idl:
      * page/History.idl:
      * page/Location.idl:
      * page/MemoryInfo.idl:
      * page/Navigator.idl:
      * page/PagePopupController.idl:
      * page/Performance.idl:
      * page/PerformanceEntry.idl:
      * page/PerformanceEntryList.idl:
      * page/PerformanceMark.idl:
      * page/PerformanceMeasure.idl:
      * page/PerformanceNavigation.idl:
      * page/PerformanceResourceTiming.idl:
      * page/PerformanceTiming.idl:
      * page/Screen.idl:
      * page/SpeechInputResult.idl:
      * page/SpeechInputResultList.idl:
      * page/WorkerNavigator.idl:
      * page/make_settings.pl:
      (generateInternalSettingsIdlFile):
      * svg/ElementTimeControl.idl:
      * svg/SVGAnimationElement.idl:
      * svg/SVGExternalResourcesRequired.idl:
      * svg/SVGFilterPrimitiveStandardAttributes.idl:
      * svg/SVGFitToViewBox.idl:
      * svg/SVGLangSpace.idl:
      * svg/SVGLocatable.idl:
      * svg/SVGStyledElement.idl:
      * svg/SVGTests.idl:
      * svg/SVGTransformable.idl:
      * svg/SVGURIReference.idl:
      * testing/InternalSettings.idl:
      * testing/Internals.idl:
      * testing/MallocStatistics.idl:
      * testing/TypeConversions.idl:
      * workers/AbstractWorker.idl:
      * workers/DedicatedWorkerContext.idl:
      * workers/SharedWorker.idl:
      * workers/SharedWorkerContext.idl:
      * workers/WorkerContext.idl:
      * workers/WorkerLocation.idl:
      * xml/XPathExpression.idl:
      * xml/XPathNSResolver.idl:
      
      Tools:
      
      Update BindingsTests.generate_supplemental_dependency() to pass an
      additional windowConstructorsFile argument to preprocess-idls.pl.
      
      * Scripts/webkitpy/bindings/main.py:
      (BindingsTests.generate_supplemental_dependency):
      (BindingsTests.main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      077c4e77
    • commit-queue@webkit.org's avatar
      Fix some compiler warnings (miscellaneous) · f116f0e4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80790
      
      Patch by Rob Buis <rbuis@rim.com> on 2013-05-08
      Reviewed by Brent Fulgham.
      
      Get rid of the following warning for BlackBerry:
      
      NavigatorContentUtils.cpp:60:78: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      
      by not compiling any of the code to add protocols to the protocol whitelist.
      
      * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
      (WebCore::initProtocolHandlerWhitelist):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f116f0e4
  2. 08 May, 2013 1 commit
    • xingnan.wang@intel.com's avatar
      Heap-use-after-free in WebCore::AudioNodeOutput::pull · dc262021
      xingnan.wang@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111362
      
      Reviewed by Chris Rogers.
      
      * Modules/webaudio/AudioBuffer.cpp:
      (WebCore::AudioBuffer::createFromAudioFileData):
      * Modules/webaudio/AudioNodeInput.cpp:
      (WebCore::AudioNodeInput::AudioNodeInput):
      (WebCore::AudioNodeInput::updateInternalBus):
      * Modules/webaudio/AudioNodeInput.h:
      (AudioNodeInput):
      * Modules/webaudio/AudioNodeOutput.cpp:
      (WebCore::AudioNodeOutput::AudioNodeOutput):
      (WebCore::AudioNodeOutput::updateInternalBus):
      (WebCore::AudioNodeOutput::pull):
      (WebCore::AudioNodeOutput::bus):
      * Modules/webaudio/AudioNodeOutput.h:
      (AudioNodeOutput):
      * Modules/webaudio/OfflineAudioDestinationNode.cpp:
      (WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
      * Modules/webaudio/OfflineAudioDestinationNode.h:
      (OfflineAudioDestinationNode):
      * platform/audio/AudioBus.cpp:
      (WebCore::AudioBus::createBufferFromRange):
      (WebCore::AudioBus::createBySampleRateConverting):
      (WebCore::AudioBus::createByMixingToMono):
      * platform/audio/AudioBus.h:
      (AudioBus):
      * platform/audio/AudioFileReader.h:
      (WebCore):
      * platform/audio/AudioResampler.cpp:
      (WebCore::AudioResampler::AudioResampler):
      (WebCore::AudioResampler::configureChannels):
      * platform/audio/AudioResampler.h:
      (AudioResampler):
      * platform/audio/HRTFElevation.cpp:
      (WebCore::getConcatenatedImpulseResponsesForSubject):
      (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
      * platform/audio/MultiChannelResampler.cpp:
      * platform/audio/Reverb.cpp:
      (WebCore::Reverb::initialize):
      * platform/audio/Reverb.h:
      (Reverb):
      * platform/audio/efl/AudioBusEfl.cpp:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
      (AudioFileReader):
      (WebCore::AudioFileReader::createBus):
      (WebCore::createBusFromAudioFile):
      (WebCore::createBusFromInMemoryAudioFile):
      * platform/audio/gtk/AudioBusGtk.cpp:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/audio/mac/AudioBusMac.mm:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/audio/mac/AudioFileReaderMac.cpp:
      (WebCore::AudioFileReader::createBus):
      (WebCore::createBusFromAudioFile):
      (WebCore::createBusFromInMemoryAudioFile):
      * platform/audio/mac/AudioFileReaderMac.h:
      (AudioFileReader):
      * platform/audio/qt/AudioBusQt.cpp:
      (WebCore::AudioBus::loadPlatformResource):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc262021
  3. 05 May, 2013 2 commits
    • weinig@apple.com's avatar
      Remove empty function SQLiteFileSystem::registerSQLiteVFS() and its callers · dd40da6a
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115619
      
      Reviewed by Dan Bernstein.
      
      * Modules/webdatabase/DatabaseTracker.cpp:
      * platform/sql/SQLiteFileSystem.cpp:
      * platform/sql/SQLiteFileSystem.h:
      * storage/StorageTracker.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd40da6a
    • andersca@apple.com's avatar
      Remove the Vector::append overload that takes a Vector · 9201299b
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115535
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      Use Vector::appendVector instead.
      
      * Modules/indexeddb/IDBBackingStore.cpp:
      (WebCore::IDBBackingStore::putRecord):
      (WebCore::IDBBackingStore::putIndexDataForRecord):
      * Modules/indexeddb/IDBLevelDBCoding.cpp:
      (WebCore::IDBLevelDBCoding::encodeStringWithLength):
      (WebCore::IDBLevelDBCoding::encodeIDBKey):
      (WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
      (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
      (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
      (WebCore::IDBLevelDBCoding::DataVersionKey::encode):
      (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
      (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
      (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
      (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
      (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
      (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
      (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
      (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
      (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
      (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
      (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
      (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
      * Modules/webaudio/AudioContext.cpp:
      (WebCore::AudioContext::clear):
      (WebCore::AudioContext::scheduleNodeDeletion):
      * accessibility/AccessibilityARIAGrid.cpp:
      (WebCore::AccessibilityARIAGrid::addTableCellChild):
      * accessibility/AccessibilityTable.cpp:
      (WebCore::AccessibilityTable::cells):
      * css/RuleFeature.cpp:
      (WebCore::RuleFeatureSet::add):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::addToMatchedPropertiesCache):
      * dom/DocumentStyleSheetCollection.cpp:
      (WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
      (WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
      * dom/Range.cpp:
      (WebCore::Range::getBorderAndTextQuads):
      * html/FormController.cpp:
      (WebCore::FormController::getReferencedFilePaths):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::setLineDash):
      * html/parser/HTMLFormattingElementList.cpp:
      (WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
      * html/track/WebVTTToken.h:
      (WebCore::WebVTTToken::addNewClass):
      (WebCore::WebVTTToken::addNewAnnotation):
      * page/CaptionUserPreferencesMac.mm:
      (WebCore::CaptionUserPreferencesMac::preferredLanguages):
      * platform/FileChooser.cpp:
      (WebCore::FileChooserSettings::acceptTypes):
      * platform/SharedBufferChunkReader.cpp:
      (WebCore::SharedBufferChunkReader::nextChunk):
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::MediaPlayer::getSitesInMediaCache):
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::updateSublayerList):
      * platform/mac/PasteboardMac.mm:
      (WebCore::createWritableTypesForImage):
      (WebCore::writableTypesForImage):
      (WebCore::Pasteboard::writeSelectionForTypes):
      * platform/network/FormDataBuilder.cpp:
      (WebCore::FormDataBuilder::generateUniqueBoundaryString):
      * plugins/PluginDatabase.cpp:
      (WebCore::PluginDatabase::defaultPluginDirectories):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::constructBidiRunsForSegment):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::OverlapMap::popCompositingContainer):
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::splitColumn):
      * svg/SVGGlyphMap.h:
      (WebCore::SVGGlyphMap::collectGlyphsForString):
      * xml/XPathNodeSet.h:
      (WebCore::XPath::NodeSet::append):
      
      Source/WebKit2:
      
      Use Vector::appendVector instead.
      
      * NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
      (WebKit::NetworkBlobRegistry::registerBlobURL):
      * NetworkProcess/SchedulableLoader.cpp:
      (WebKit::SchedulableLoader::SchedulableLoader):
      * Platform/CoreIPC/Connection.cpp:
      (CoreIPC::Connection::SyncMessageState::dispatchMessages):
      * UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
      (WebKit::PluginInfoStore::pluginsDirectories):
      
      Source/WTF:
      
      The Vector::append overload that takes a Vector conflicts with rvalues in C++11, so remove it and
      replace calls to it with calls to appendVector.
      
      * wtf/Vector.h:
      (Vector):
      
      Tools:
      
      Use Vector::appendVector instead.
      
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (concatenateAttributeAndValue):
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
      (WTR::concatenateAttributeAndValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9201299b
  4. 30 Apr, 2013 2 commits
    • ch.dumez@sisa.samsung.com's avatar
      Stop using "in" keyword in IDL files · b2986f1d
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115418
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      Stop using "in" keyword in IDL files as this is no longer part of the
      Web IDL specification and it brings no additional information.
      
      For now, the IDL parser will still accept the "in" keyword for operation
      argument to not break anything. However, we should remove support for it
      later on.
      
      No new tests, no behavior change.
      
      * Modules/battery/BatteryManager.idl:
      * Modules/encryptedmedia/MediaKeySession.idl:
      * Modules/encryptedmedia/MediaKeys.idl:
      * Modules/filesystem/DOMWindowFileSystem.idl:
      * Modules/filesystem/DirectoryEntry.idl:
      * Modules/filesystem/DirectoryEntrySync.idl:
      * Modules/filesystem/DirectoryReader.idl:
      * Modules/filesystem/EntriesCallback.idl:
      * Modules/filesystem/Entry.idl:
      * Modules/filesystem/EntryArray.idl:
      * Modules/filesystem/EntryArraySync.idl:
      * Modules/filesystem/EntryCallback.idl:
      * Modules/filesystem/EntrySync.idl:
      * Modules/filesystem/ErrorCallback.idl:
      * Modules/filesystem/FileCallback.idl:
      * Modules/filesystem/FileEntry.idl:
      * Modules/filesystem/FileSystemCallback.idl:
      * Modules/filesystem/FileWriter.idl:
      * Modules/filesystem/FileWriterCallback.idl:
      * Modules/filesystem/FileWriterSync.idl:
      * Modules/filesystem/MetadataCallback.idl:
      * Modules/filesystem/WorkerContextFileSystem.idl:
      * Modules/gamepad/GamepadList.idl:
      * Modules/geolocation/Geolocation.idl:
      * Modules/geolocation/PositionCallback.idl:
      * Modules/geolocation/PositionErrorCallback.idl:
      * Modules/indexeddb/IDBCursor.idl:
      * Modules/indexeddb/IDBDatabase.idl:
      * Modules/indexeddb/IDBFactory.idl:
      * Modules/indexeddb/IDBIndex.idl:
      * Modules/indexeddb/IDBKeyRange.idl:
      * Modules/indexeddb/IDBObjectStore.idl:
      * Modules/indexeddb/IDBRequest.idl:
      * Modules/indexeddb/IDBTransaction.idl:
      * Modules/mediasource/MediaSource.idl:
      * Modules/mediasource/SourceBuffer.idl:
      * Modules/mediasource/SourceBufferList.idl:
      * Modules/mediastream/MediaStream.idl:
      * Modules/mediastream/MediaStreamTrack.idl:
      * Modules/mediastream/NavigatorMediaStream.idl:
      * Modules/mediastream/NavigatorUserMediaErrorCallback.idl:
      * Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
      * Modules/mediastream/RTCDTMFSender.idl:
      * Modules/mediastream/RTCDataChannel.idl:
      * Modules/mediastream/RTCErrorCallback.idl:
      * Modules/mediastream/RTCIceCandidate.idl:
      * Modules/mediastream/RTCPeerConnection.idl:
      * Modules/mediastream/RTCSessionDescription.idl:
      * Modules/mediastream/RTCSessionDescriptionCallback.idl:
      * Modules/mediastream/RTCStatsCallback.idl:
      * Modules/mediastream/RTCStatsReport.idl:
      * Modules/mediastream/RTCStatsResponse.idl:
      * Modules/navigatorcontentutils/NavigatorContentUtils.idl:
      * Modules/networkinfo/NetworkInfoConnection.idl:
      * Modules/notifications/Notification.idl:
      * Modules/notifications/NotificationCenter.idl:
      * Modules/notifications/NotificationPermissionCallback.idl:
      * Modules/quota/StorageErrorCallback.idl:
      * Modules/quota/StorageInfo.idl:
      * Modules/quota/StorageQuota.idl:
      * Modules/quota/StorageQuotaCallback.idl:
      * Modules/quota/StorageUsageCallback.idl:
      * Modules/speech/SpeechGrammarList.idl:
      * Modules/speech/SpeechRecognition.idl:
      * Modules/speech/SpeechRecognitionResult.idl:
      * Modules/speech/SpeechRecognitionResultList.idl:
      * Modules/speech/SpeechSynthesisUtterance.idl:
      * Modules/vibration/NavigatorVibration.idl:
      * Modules/webaudio/AnalyserNode.idl:
      * Modules/webaudio/AudioBuffer.idl:
      * Modules/webaudio/AudioBufferCallback.idl:
      * Modules/webaudio/AudioBufferSourceNode.idl:
      * Modules/webaudio/AudioContext.idl:
      * Modules/webaudio/AudioListener.idl:
      * Modules/webaudio/AudioNode.idl:
      * Modules/webaudio/AudioParam.idl:
      * Modules/webaudio/BiquadFilterNode.idl:
      * Modules/webaudio/OfflineAudioContext.idl:
      * Modules/webaudio/OscillatorNode.idl:
      * Modules/webaudio/PannerNode.idl:
      * Modules/webdatabase/DOMWindowWebDatabase.idl:
      * Modules/webdatabase/Database.idl:
      * Modules/webdatabase/DatabaseCallback.idl:
      * Modules/webdatabase/DatabaseSync.idl:
      * Modules/webdatabase/SQLResultSetRowList.idl:
      * Modules/webdatabase/SQLStatementCallback.idl:
      * Modules/webdatabase/SQLStatementErrorCallback.idl:
      * Modules/webdatabase/SQLTransaction.idl:
      * Modules/webdatabase/SQLTransactionCallback.idl:
      * Modules/webdatabase/SQLTransactionErrorCallback.idl:
      * Modules/webdatabase/SQLTransactionSync.idl:
      * Modules/webdatabase/SQLTransactionSyncCallback.idl:
      * Modules/webdatabase/WorkerContextWebDatabase.idl:
      * Modules/websockets/WebSocket.idl:
      * bindings/scripts/test/TestCallback.idl:
      * bindings/scripts/test/TestCustomNamedGetter.idl:
      * bindings/scripts/test/TestDomainSecurity.idl:
      * bindings/scripts/test/TestEventTarget.idl:
      * bindings/scripts/test/TestInterface.idl:
      * bindings/scripts/test/TestMediaQueryListListener.idl:
      * bindings/scripts/test/TestNamedConstructor.idl:
      * bindings/scripts/test/TestObj.idl:
      * bindings/scripts/test/TestOverloadedConstructors.idl:
      * bindings/scripts/test/TestSerializedScriptValueInterface.idl:
      * bindings/scripts/test/TestSupplemental.idl:
      * bindings/scripts/test/TestTypedArray.idl:
      * bindings/scripts/test/TestTypedefs.idl:
      * css/CSSHostRule.idl:
      * css/CSSMediaRule.idl:
      * css/CSSPrimitiveValue.idl:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSStyleSheet.idl:
      * css/CSSSupportsRule.idl:
      * css/CSSValueList.idl:
      * css/FontLoader.idl:
      * css/MediaList.idl:
      * css/MediaQueryList.idl:
      * css/MediaQueryListListener.idl:
      * css/StyleMedia.idl:
      * css/StyleSheetList.idl:
      * css/WebKitCSSKeyframesRule.idl:
      * css/WebKitCSSMatrix.idl:
      * dom/CharacterData.idl:
      * dom/ClientRectList.idl:
      * dom/Clipboard.idl:
      * dom/CompositionEvent.idl:
      * dom/CustomEvent.idl:
      * dom/DOMImplementation.idl:
      * dom/DOMNamedFlowCollection.idl:
      * dom/DOMStringList.idl:
      * dom/DataTransferItem.idl:
      * dom/DataTransferItemList.idl:
      * dom/DeviceMotionEvent.idl:
      * dom/DeviceOrientationEvent.idl:
      * dom/Document.idl:
      * dom/DocumentFragment.idl:
      * dom/Element.idl:
      * dom/Event.idl:
      * dom/EventListener.idl:
      * dom/EventTarget.idl:
      * dom/HashChangeEvent.idl:
      * dom/KeyboardEvent.idl:
      * dom/MessageEvent.idl:
      * dom/MessagePort.idl:
      * dom/MouseEvent.idl:
      * dom/MutationEvent.idl:
      * dom/MutationObserver.idl:
      * dom/NamedNodeMap.idl:
      * dom/Node.idl:
      * dom/NodeFilter.idl:
      * dom/NodeList.idl:
      * dom/OverflowEvent.idl:
      * dom/PropertyNodeList.idl:
      * dom/Range.idl:
      * dom/RequestAnimationFrameCallback.idl:
      * dom/ShadowRoot.idl:
      * dom/StringCallback.idl:
      * dom/Text.idl:
      * dom/TextEvent.idl:
      * dom/TouchEvent.idl:
      * dom/TouchList.idl:
      * dom/UIEvent.idl:
      * dom/WebKitNamedFlow.idl:
      * dom/WheelEvent.idl:
      * fileapi/Blob.idl:
      * fileapi/FileList.idl:
      * fileapi/FileReader.idl:
      * fileapi/FileReaderSync.idl:
      * html/DOMFormData.idl:
      * html/DOMTokenList.idl:
      * html/DOMURL.idl:
      * html/HTMLAllCollection.idl:
      * html/HTMLAudioElement.idl:
      * html/HTMLButtonElement.idl:
      * html/HTMLCanvasElement.idl:
      * html/HTMLCollection.idl:
      * html/HTMLDocument.idl:
      * html/HTMLElement.idl:
      * html/HTMLFieldSetElement.idl:
      * html/HTMLFormControlsCollection.idl:
      * html/HTMLInputElement.idl:
      * html/HTMLKeygenElement.idl:
      * html/HTMLMediaElement.idl:
      * html/HTMLObjectElement.idl:
      * html/HTMLOptionElement.idl:
      * html/HTMLOptionsCollection.idl:
      * html/HTMLOutputElement.idl:
      * html/HTMLPropertiesCollection.idl:
      * html/HTMLSelectElement.idl:
      * html/HTMLTableElement.idl:
      * html/HTMLTableRowElement.idl:
      * html/HTMLTableSectionElement.idl:
      * html/HTMLTextAreaElement.idl:
      * html/MediaController.idl:
      * html/TimeRanges.idl:
      * html/canvas/ArrayBuffer.idl:
      * html/canvas/CanvasGradient.idl:
      * html/canvas/CanvasRenderingContext2D.idl:
      * html/canvas/DOMPath.idl:
      * html/canvas/DataView.idl:
      * html/canvas/EXTDrawBuffers.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/canvas/Uint8ClampedArray.idl:
      * html/canvas/WebGLDebugShaders.idl:
      * html/canvas/WebGLRenderingContext.idl:
      * html/track/AudioTrackList.idl:
      * html/track/TextTrack.idl:
      * html/track/TextTrackCue.idl:
      * html/track/TextTrackCueList.idl:
      * html/track/TextTrackList.idl:
      * html/track/TextTrackRegionList.idl:
      * html/track/VideoTrackList.idl:
      * inspector/InjectedScriptHost.idl:
      * inspector/InspectorFrontendHost.idl:
      * inspector/JavaScriptCallFrame.idl:
      * loader/appcache/DOMApplicationCache.idl:
      * page/Console.idl:
      * page/Crypto.idl:
      * page/DOMSecurityPolicy.idl:
      * page/DOMSelection.idl:
      * page/DOMWindow.idl:
      * page/EventSource.idl:
      * page/History.idl:
      * page/Location.idl:
      * page/PagePopupController.idl:
      * page/Performance.idl:
      * page/PerformanceEntryList.idl:
      * page/SpeechInputResultList.idl:
      * plugins/DOMMimeTypeArray.idl:
      * plugins/DOMPlugin.idl:
      * plugins/DOMPluginArray.idl:
      * storage/Storage.idl:
      * storage/StorageEvent.idl:
      * svg/ElementTimeControl.idl:
      * svg/SVGAngle.idl:
      * svg/SVGColor.idl:
      * svg/SVGDocument.idl:
      * svg/SVGElementInstanceList.idl:
      * svg/SVGFEDropShadowElement.idl:
      * svg/SVGFEGaussianBlurElement.idl:
      * svg/SVGFEMorphologyElement.idl:
      * svg/SVGFilterElement.idl:
      * svg/SVGLength.idl:
      * svg/SVGLengthList.idl:
      * svg/SVGLocatable.idl:
      * svg/SVGMarkerElement.idl:
      * svg/SVGMatrix.idl:
      * svg/SVGNumberList.idl:
      * svg/SVGPaint.idl:
      * svg/SVGPathElement.idl:
      * svg/SVGPathSegList.idl:
      * svg/SVGPoint.idl:
      * svg/SVGPointList.idl:
      * svg/SVGSVGElement.idl:
      * svg/SVGStringList.idl:
      * svg/SVGStyledElement.idl:
      * svg/SVGTests.idl:
      * svg/SVGTextContentElement.idl:
      * svg/SVGTransform.idl:
      * svg/SVGTransformList.idl:
      * testing/InternalSettings.idl:
      * testing/Internals.idl:
      * workers/AbstractWorker.idl:
      * workers/DedicatedWorkerContext.idl:
      * workers/SharedWorker.idl:
      * workers/Worker.idl:
      * workers/WorkerContext.idl:
      * xml/DOMParser.idl:
      * xml/XMLHttpRequest.idl:
      * xml/XMLHttpRequestUpload.idl:
      * xml/XMLSerializer.idl:
      * xml/XPathEvaluator.idl:
      * xml/XPathExpression.idl:
      * xml/XPathNSResolver.idl:
      * xml/XPathResult.idl:
      * xml/XSLTProcessor.idl:
      
      Source/WebKit/win:
      
      Remove "in" keyword from IDL files as this is no longer part of the Web
      IDL specification.
      
      * Interfaces/DOMEvents.idl:
      * Interfaces/DOMPrivate.idl:
      * Interfaces/DOMWindow.idl:
      
      Tools:
      
      Remove "in" keyword from IDL files as this is no longer part of the Web
      IDL specification.
      
      * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
      * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
      * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
      * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
      * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
      * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2986f1d
    • ch.dumez@sisa.samsung.com's avatar
      Replace "Optional" extended attribute by proper Web IDL "optional" keyword · 3463b187
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115380
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      Replace [Optional] with standard WebIDL optional type prefix:
      http://dev.w3.org/2006/webapi/WebIDL/#dfn-optional-argument
      
      The default behavior now matches WebIDL: [Optional] => optional
      
      Two cases where WebKit has extended bindings behavior still
      require a non-standard IDL attribute:
      [Optional=DefaultIsNullString] => [Default=NullString] optional
      [Optional=DefaultIsUndefined] => [Default=Undefined] optional
      
      Based on corresponding Blink patch from Joshua Bell for compatibility.
      
      No new tests, no behavior change.
      
      * Modules/battery/BatteryManager.idl:
      * Modules/encryptedmedia/MediaKeySession.idl:
      * Modules/encryptedmedia/MediaKeys.idl:
      * Modules/filesystem/DOMWindowFileSystem.idl:
      * Modules/filesystem/DirectoryEntry.idl:
      * Modules/filesystem/DirectoryReader.idl:
      * Modules/filesystem/Entry.idl:
      * Modules/filesystem/FileEntry.idl:
      * Modules/filesystem/FileWriter.idl:
      * Modules/filesystem/WorkerContextFileSystem.idl:
      * Modules/gamepad/GamepadList.idl:
      * Modules/geolocation/Geolocation.idl:
      * Modules/indexeddb/IDBCursor.idl:
      * Modules/indexeddb/IDBDatabase.idl:
      * Modules/indexeddb/IDBFactory.idl:
      * Modules/indexeddb/IDBIndex.idl:
      * Modules/indexeddb/IDBKeyRange.idl:
      * Modules/indexeddb/IDBObjectStore.idl:
      * Modules/indexeddb/IDBRequest.idl:
      * Modules/indexeddb/IDBTransaction.idl:
      * Modules/mediasource/MediaSource.idl:
      * Modules/mediasource/SourceBufferList.idl:
      * Modules/mediastream/MediaStream.idl:
      * Modules/mediastream/MediaStreamTrack.idl:
      * Modules/mediastream/NavigatorMediaStream.idl:
      * Modules/mediastream/RTCDTMFSender.idl:
      * Modules/mediastream/RTCDataChannel.idl:
      * Modules/mediastream/RTCPeerConnection.idl:
      * Modules/mediastream/RTCStatsResponse.idl:
      * Modules/networkinfo/NetworkInfoConnection.idl:
      * Modules/notifications/Notification.idl:
      * Modules/notifications/NotificationCenter.idl:
      * Modules/quota/StorageInfo.idl:
      * Modules/quota/StorageQuota.idl:
      * Modules/speech/SpeechGrammarList.idl:
      * Modules/speech/SpeechRecognition.idl:
      * Modules/speech/SpeechSynthesisUtterance.idl:
      * Modules/webaudio/AudioContext.idl:
      * Modules/webaudio/AudioNode.idl:
      * Modules/webdatabase/DOMWindowWebDatabase.idl:
      * Modules/webdatabase/Database.idl:
      * Modules/webdatabase/DatabaseSync.idl:
      * Modules/webdatabase/SQLTransaction.idl:
      * Modules/webdatabase/WorkerContextWebDatabase.idl:
      * Modules/websockets/WebSocket.idl:
      * bindings/scripts/CodeGeneratorJS.pm:
      (GetFunctionLength):
      (GenerateFunctionParametersCheck):
      (GenerateArgumentsCountCheck):
      (GenerateParametersCheck):
      (GenerateConstructorDefinition):
      * bindings/scripts/IDLAttributes.txt:
      * bindings/scripts/IDLParser.pm:
      (parseOptionalOrRequiredArgument):
      * bindings/scripts/test/TestEventTarget.idl:
      * bindings/scripts/test/TestInterface.idl:
      * bindings/scripts/test/TestNamedConstructor.idl:
      * bindings/scripts/test/TestObj.idl:
      * bindings/scripts/test/TestSerializedScriptValueInterface.idl:
      * bindings/scripts/test/TestTypedefs.idl: optional cannot be used in a typedef.
      * css/CSSHostRule.idl:
      * css/CSSMediaRule.idl:
      * css/CSSPrimitiveValue.idl:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSStyleSheet.idl:
      * css/CSSSupportsRule.idl:
      * css/CSSValueList.idl:
      * css/FontLoader.idl:
      * css/MediaList.idl:
      * css/MediaQueryList.idl:
      * css/MediaQueryListListener.idl:
      * css/StyleMedia.idl:
      * css/StyleSheetList.idl:
      * css/WebKitCSSKeyframesRule.idl:
      * css/WebKitCSSMatrix.idl:
      * dom/CharacterData.idl:
      * dom/ClientRectList.idl:
      * dom/Clipboard.idl:
      * dom/CompositionEvent.idl:
      * dom/CustomEvent.idl:
      * dom/DOMImplementation.idl:
      * dom/DOMStringList.idl:
      * dom/DataTransferItem.idl:
      * dom/DataTransferItemList.idl:
      * dom/DeviceMotionEvent.idl:
      * dom/DeviceOrientationEvent.idl:
      * dom/Document.idl:
      * dom/Element.idl:
      * dom/Event.idl:
      * dom/EventTarget.idl:
      * dom/HashChangeEvent.idl:
      * dom/KeyboardEvent.idl:
      * dom/MessageEvent.idl:
      * dom/MessagePort.idl:
      * dom/MouseEvent.idl:
      * dom/MutationEvent.idl:
      * dom/NamedNodeMap.idl:
      * dom/Node.idl:
      * dom/NodeFilter.idl:
      * dom/NodeList.idl:
      * dom/OverflowEvent.idl:
      * dom/Range.idl:
      * dom/ShadowRoot.idl:
      * dom/Text.idl:
      * dom/TextEvent.idl:
      * dom/TouchEvent.idl:
      * dom/UIEvent.idl:
      * dom/WebKitNamedFlow.idl:
      * dom/WheelEvent.idl:
      * fileapi/Blob.idl:
      * fileapi/FileReader.idl:
      * fileapi/FileReaderSync.idl:
      * html/DOMFormData.idl:
      * html/DOMTokenList.idl:
      * html/HTMLAllCollection.idl:
      * html/HTMLAudioElement.idl:
      * html/HTMLCanvasElement.idl:
      * html/HTMLCollection.idl:
      * html/HTMLDocument.idl:
      * html/HTMLElement.idl:
      * html/HTMLFormControlsCollection.idl:
      * html/HTMLInputElement.idl:
      * html/HTMLMediaElement.idl:
      * html/HTMLOptionElement.idl:
      * html/HTMLOptionsCollection.idl:
      * html/HTMLSelectElement.idl:
      * html/HTMLTableElement.idl:
      * html/HTMLTableRowElement.idl:
      * html/HTMLTableSectionElement.idl:
      * html/HTMLTextAreaElement.idl:
      * html/MediaController.idl:
      * html/canvas/ArrayBuffer.idl:
      * html/canvas/CanvasGradient.idl:
      * html/canvas/CanvasRenderingContext2D.idl:
      * html/canvas/DOMPath.idl:
      * html/canvas/DataView.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/canvas/Uint8ClampedArray.idl:
      * html/track/AudioTrackList.idl:
      * html/track/TextTrack.idl:
      * html/track/TextTrackCue.idl:
      * html/track/TextTrackList.idl:
      * html/track/VideoTrackList.idl:
      * loader/appcache/DOMApplicationCache.idl:
      * page/DOMSelection.idl:
      * page/DOMWindow.idl:
      * page/EventSource.idl:
      * page/History.idl:
      * page/Location.idl:
      * page/Performance.idl:
      * plugins/DOMMimeTypeArray.idl:
      * plugins/DOMPlugin.idl:
      * plugins/DOMPluginArray.idl:
      * storage/StorageEvent.idl:
      * svg/ElementTimeControl.idl:
      * svg/SVGDocument.idl:
      * svg/SVGElementInstanceList.idl:
      * svg/SVGFEDropShadowElement.idl:
      * svg/SVGFEGaussianBlurElement.idl:
      * svg/SVGFEMorphologyElement.idl:
      * svg/SVGFilterElement.idl:
      * svg/SVGLocatable.idl:
      * svg/SVGMarkerElement.idl:
      * svg/SVGPathElement.idl:
      * svg/SVGSVGElement.idl:
      * svg/SVGStyledElement.idl:
      * svg/SVGTests.idl:
      * svg/SVGTextContentElement.idl:
      * testing/Internals.idl:
      * workers/AbstractWorker.idl:
      * workers/DedicatedWorkerContext.idl:
      * workers/SharedWorker.idl:
      * workers/Worker.idl:
      * workers/WorkerContext.idl:
      * xml/DOMParser.idl:
      * xml/XMLHttpRequest.idl:
      * xml/XMLHttpRequestUpload.idl:
      * xml/XMLSerializer.idl:
      * xml/XPathEvaluator.idl:
      * xml/XPathExpression.idl:
      * xml/XPathNSResolver.idl:
      * xml/XPathResult.idl:
      * xml/XSLTProcessor.idl:
      
      Source/WebKit/win:
      
      Replace [Optional] by optional.
      
      * Interfaces/DOMWindow.idl:
      
      Tools:
      
      Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
      keyword.
      
      * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3463b187
  5. 29 Apr, 2013 1 commit
  6. 28 Apr, 2013 1 commit
    • ch.dumez@sisa.samsung.com's avatar
      Get rid of [Callback] IDL extended attribute for parameters · 3b2e1744
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115250
      
      Reviewed by Kentaro Hara.
      
      Remove the WebKit-specific [Callback] extended attribute and make the bindings
      generator smart enough to know when a parameter is of callback type on its
      own.
      
      No new tests, no behavior change.
      
      * DerivedSources.make: Use WebCore/Modules as IDL include path instead of using
      subdirs. The generator will search recursively anyway and the list of subdirs was
      incomplete.
      * Modules/filesystem/DOMWindowFileSystem.idl:
      * Modules/filesystem/DirectoryEntry.idl:
      * Modules/filesystem/DirectoryReader.idl:
      * Modules/filesystem/Entry.idl:
      * Modules/filesystem/FileEntry.idl:
      * Modules/filesystem/WorkerContextFileSystem.idl:
      * Modules/mediastream/NavigatorMediaStream.idl:
      * Modules/mediastream/RTCPeerConnection.idl:
      * Modules/notifications/Notification.idl:
      * Modules/notifications/NotificationCenter.idl:
      * Modules/quota/StorageInfo.idl:
      * Modules/quota/StorageQuota.idl:
      * Modules/webaudio/AudioContext.idl:
      * Modules/webdatabase/DOMWindowWebDatabase.idl:
      * Modules/webdatabase/Database.idl:
      * Modules/webdatabase/DatabaseSync.idl:
      * Modules/webdatabase/SQLTransaction.idl:
      * Modules/webdatabase/WorkerContextWebDatabase.idl:
      * bindings/gobject/GNUmakefile.am: Add missing IDL include dirs.
      * bindings/scripts/CodeGenerator.pm:
      (IsWrapperType):
      (IsCallbackInterface):
      * bindings/scripts/CodeGeneratorGObject.pm:
      (SkipFunction):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateParametersCheckExpression):
      (GenerateParametersCheck):
      * bindings/scripts/IDLAttributes.txt: Remove "Callback" extended attribute.
      * bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
      (WebDOMTestCallback::callbackWithArrayParam):
      (WebDOMTestCallback::callbackWithSerializedScriptValueParam):
      (WebDOMTestCallback::callbackWithNonBoolReturnType):
      (WebDOMTestCallback::callbackRequiresThisToPass):
      * bindings/scripts/test/CPP/WebDOMTestCallback.h:
      (WebDOMTestCallback):
      * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
      (WebDOMTestObj::convert1):
      (WebDOMTestObj::convert2):
      (WebDOMTestObj::convert4):
      (WebDOMTestObj::convert5):
      * bindings/scripts/test/CPP/WebDOMTestObj.h:
      * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
      (WebDOMTestSerializedScriptValueInterface::acceptTransferList):
      (WebDOMTestSerializedScriptValueInterface::multiTransferList):
      * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
      (WebDOMTestSerializedScriptValueInterface):
      * bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
      (WebDOMTestTypedefs::multiTransferList):
      * bindings/scripts/test/CPP/WebDOMTestTypedefs.h:
      (WebDOMTestTypedefs):
      * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
      (webkit_dom_test_callback_callback_with_array_param):
      (webkit_dom_test_callback_callback_with_serialized_script_value_param):
      (webkit_dom_test_callback_callback_with_non_bool_return_type):
      (webkit_dom_test_callback_callback_requires_this_to_pass):
      * bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
      * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
      (webkit_dom_test_obj_convert1):
      (webkit_dom_test_obj_convert2):
      (webkit_dom_test_obj_convert4):
      (webkit_dom_test_obj_convert5):
      * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
      * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
      (webkit_dom_test_serialized_script_value_interface_accept_transfer_list):
      (webkit_dom_test_serialized_script_value_interface_multi_transfer_list):
      * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
      * bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
      (webkit_dom_test_typedefs_multi_transfer_list):
      * bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
      * bindings/scripts/test/JS/JSTestCallback.cpp:
      (WebCore::JSTestCallback::callbackWithArrayParam):
      (WebCore::JSTestCallback::callbackWithSerializedScriptValueParam):
      (WebCore::JSTestCallback::callbackRequiresThisToPass):
      * bindings/scripts/test/JS/JSTestCallback.h:
      (JSTestCallback):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::jsTestObjPrototypeFunctionConvert1):
      (WebCore::jsTestObjPrototypeFunctionConvert2):
      (WebCore::jsTestObjPrototypeFunctionConvert4):
      (WebCore::jsTestObjPrototypeFunctionConvert5):
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
      (WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
      (WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
      (WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):
      * bindings/scripts/test/JS/JSTestTypedefs.cpp:
      (WebCore::jsTestTypedefsPrototypeFunctionMultiTransferList):
      * bindings/scripts/test/ObjC/DOMTestCallback.h:
      * bindings/scripts/test/ObjC/DOMTestCallback.mm:
      (-[DOMTestCallback callbackWithArrayParam:]):
      (-[DOMTestCallback callbackWithSerializedScriptValueParam:strArg:]):
      (-[DOMTestCallback callbackWithNonBoolReturnType:]):
      (-[DOMTestCallback callbackRequiresThisToPass:testNodeParam:]):
      * bindings/scripts/test/ObjC/DOMTestObj.h:
      * bindings/scripts/test/ObjC/DOMTestObj.mm:
      (-[DOMTestObj convert1:]):
      (-[DOMTestObj convert2:]):
      (-[DOMTestObj convert4:]):
      (-[DOMTestObj convert5:]):
      * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
      * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
      (-[DOMTestSerializedScriptValueInterface acceptTransferList:transferList:]):
      (-[DOMTestSerializedScriptValueInterface multiTransferList:tx:second:txx:]):
      * bindings/scripts/test/ObjC/DOMTestTypedefs.h:
      * bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
      (-[DOMTestTypedefs multiTransferList:tx:second:txx:]):
      * bindings/scripts/test/TestCallback.idl: Use valid types instead of Class1, Class2, ...
      so that the bindings generator does not complain about not being able to resolve
      them.
      * bindings/scripts/test/TestObj.idl: Use valid parameter types instead of 'a', 'b', 'd', 'e'
      so that the bindings generator does not complain about them.
      * bindings/scripts/test/TestSerializedScriptValueInterface.idl:
      * bindings/scripts/test/TestTypedefs.idl:
      * css/FontLoader.idl:
      * dom/DataTransferItem.idl:
      * page/DOMWindow.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b2e1744
  7. 26 Apr, 2013 2 commits
    • akling@apple.com's avatar
      Web Audio: Remove reduplicative addInput() in AnalyserNode. · 46a98e66
      akling@apple.com authored
      <http://webkit.org/b/115244>
      
      From Blink r149155 by <james.wei@intel.com>:
      
      The parent class BasicInspectorNode already called addInput() and addOutput().
      So it is reduplicative to call them in AnalyserNode.
      
      * Modules/webaudio/AnalyserNode.cpp:
      (WebCore::AnalyserNode::AnalyserNode):
      * Modules/webaudio/AudioBasicInspectorNode.cpp:
      (WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
      * Modules/webaudio/AudioBasicInspectorNode.h:
      (AudioBasicInspectorNode):
      * Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
      (WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46a98e66
    • ch.dumez@sisa.samsung.com's avatar
      Add support for Web IDL partial interfaces to the bindings generator · 1939ee3d
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115228
      
      Reviewed by Kentaro Hara.
      
      Add support for Web IDL partial interfaces to the bindings generator:
      http://dev.w3.org/2006/webapi/WebIDL/#dfn-partial-interface
      
      Also drop support for the the WebKit-specific [Supplemental] extended
      attribute and use partial interfaces instead in existing IDL files.
      
      No new tests, no behavior change.
      
      * Modules/battery/NavigatorBattery.idl:
      * Modules/filesystem/DOMWindowFileSystem.idl:
      * Modules/filesystem/DataTransferItemFileSystem.idl:
      * Modules/filesystem/HTMLInputElementFileSystem.idl:
      * Modules/filesystem/WorkerContextFileSystem.idl:
      * Modules/gamepad/NavigatorGamepad.idl:
      * Modules/geolocation/NavigatorGeolocation.idl:
      * Modules/indexeddb/DOMWindowIndexedDatabase.idl:
      * Modules/indexeddb/WorkerContextIndexedDatabase.idl:
      * Modules/mediastream/DOMWindowMediaStream.idl:
      * Modules/mediastream/NavigatorMediaStream.idl:
      * Modules/navigatorcontentutils/NavigatorContentUtils.idl:
      * Modules/networkinfo/NavigatorNetworkInfoConnection.idl:
      * Modules/notifications/DOMWindowNotifications.idl:
      * Modules/notifications/WorkerContextNotifications.idl:
      * Modules/quota/DOMWindowQuota.idl:
      * Modules/quota/NavigatorStorageQuota.idl:
      * Modules/quota/WorkerNavigatorStorageQuota.idl:
      * Modules/speech/DOMWindowSpeech.idl:
      * Modules/speech/DOMWindowSpeechSynthesis.idl:
      * Modules/vibration/NavigatorVibration.idl:
      * Modules/webaudio/DOMWindowWebAudio.idl:
      * Modules/webdatabase/DOMWindowWebDatabase.idl:
      * Modules/webdatabase/WorkerContextWebDatabase.idl:
      * Modules/websockets/DOMWindowWebSocket.idl:
      * Modules/websockets/WorkerContextWebSocket.idl:
      * bindings/scripts/IDLAttributes.txt:
      * bindings/scripts/IDLParser.pm:
      (parsePartialDefinition):
      * bindings/scripts/generate-bindings.pl:
      * bindings/scripts/preprocess-idls.pl:
      (getPartialInterfaceNameFromIDLFile):
      * bindings/scripts/test/TestSupplemental.idl:
      * page/DOMWindowPagePopup.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1939ee3d
  8. 25 Apr, 2013 2 commits
    • commit-queue@webkit.org's avatar
      Sec-WebSocket-Extensions header field must not appear more than once in an HTTP response. · 054b5ed1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115128
      
      Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-04-25
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      According to WebSocket specification Sec-WebSocket-Extensions header field
      must not appear more than once in an HTTP response. It is ok if it appears
      more than once in client request. Also add a check for invalid UTF-8
      characters when parsing Sec-WebSocket-Extensions quoted string.
      
      Test: http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header.html
      
      * Modules/websockets/WebSocketExtensionParser.cpp:
      (WebCore::WebSocketExtensionParser::consumeQuotedString): Return false if there is
      invalid character in the quoted string being parsed.
      * Modules/websockets/WebSocketHandshake.cpp:
      (WebCore::WebSocketHandshake::readHTTPHeaders): Check if Sec-WebSocket-Extensions
      appears more than once in header response. Abort handshake if it does.
      
      LayoutTests:
      
      * http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header-expected.txt: Added.
      * http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header.html: Added.
      * http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header_wsh.py: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      054b5ed1
    • ch.dumez@sisa.samsung.com's avatar
      Add support for Web IDL callback interfaces to the bindings generator · fbc14455
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115179
      
      Reviewed by Kentaro Hara.
      
      Add support in the bindings generator for Web IDL callback interfaces:
      http://dev.w3.org/2006/webapi/WebIDL/#dfn-callback-interface
      
      Drop support for the WebKit-specific [Callback] extended attributes
      on Web IDL interfaces and update existing IDL files to use proper
      callback interfaces instead.
      
      No new tests, no behavior change.
      
      * Modules/filesystem/EntriesCallback.idl:
      * Modules/filesystem/EntryCallback.idl:
      * Modules/filesystem/ErrorCallback.idl:
      * Modules/filesystem/FileCallback.idl:
      * Modules/filesystem/FileSystemCallback.idl:
      * Modules/filesystem/FileWriterCallback.idl:
      * Modules/filesystem/MetadataCallback.idl:
      * Modules/geolocation/PositionCallback.idl:
      * Modules/geolocation/PositionErrorCallback.idl:
      * Modules/mediastream/NavigatorUserMediaErrorCallback.idl:
      * Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
      * Modules/mediastream/RTCErrorCallback.idl:
      * Modules/mediastream/RTCSessionDescriptionCallback.idl:
      * Modules/mediastream/RTCStatsCallback.idl:
      * Modules/notifications/NotificationPermissionCallback.idl:
      * Modules/quota/StorageErrorCallback.idl:
      * Modules/quota/StorageQuotaCallback.idl:
      * Modules/quota/StorageUsageCallback.idl:
      * Modules/webaudio/AudioBufferCallback.idl:
      * Modules/webdatabase/DatabaseCallback.idl:
      * Modules/webdatabase/SQLStatementCallback.idl:
      * Modules/webdatabase/SQLStatementErrorCallback.idl:
      * Modules/webdatabase/SQLTransactionCallback.idl:
      * Modules/webdatabase/SQLTransactionErrorCallback.idl:
      * Modules/webdatabase/SQLTransactionSyncCallback.idl:
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateInterface):
      * bindings/scripts/IDLParser.pm:
      (parseCallbackRestOrInterface):
      * bindings/scripts/test/TestCallback.idl:
      * dom/RequestAnimationFrameCallback.idl:
      * dom/StringCallback.idl:
      * html/VoidCallback.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbc14455
  9. 24 Apr, 2013 2 commits
  10. 23 Apr, 2013 1 commit
    • commit-queue@webkit.org's avatar
      WebSocket: Return type of send() should be void if hybi-10 protocol is chosen · a0c86a09
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65850
      
      Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-04-23
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      WebSocket API draft changed the return type of send() from boolean to void based on Simon
      Pieters' post to WHATWG. Firefox 8 and IE 10 already follow the specification, hence it should
      make sense for us to do the same when hybi protocol is used.
      
      Original patch by Yuta Kitamura  <yutak@chromium.org>
      
      Tests: http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)
             http/tests/websocket/tests/hybi/send-after-close-on-unload.html (updated)
      
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::send):
      * Modules/websockets/WebSocket.h:
      * Modules/websockets/WebSocket.idl:
      
      LayoutTests:
      
      Update tests and test results because WebSocket.send() now returns undefined when
      the hybi WebSocket protocol is used.
      
      * http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
      * http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy-expected.txt:
      * http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
      * http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
      * http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt:
      * http/tests/websocket/tests/hybi/send-after-close-on-unload.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0c86a09
  11. 22 Apr, 2013 1 commit
    • benjamin@webkit.org's avatar
      Remove the memory instrumentation code · 9d72cb0b
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114931
      
      Reviewed by Andreas Kling.
      
      .: 
      
      * Source/autotools/symbols.filter:
      
      Source/JavaScriptCore: 
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
      
      Source/WebCore: 
      
      The Memory Instrumentation code is unfinished and has already
      become out of sync the objects it is supposed to represent.
      
      The current approach does not seem maintainable, it is better to
      remove it before someone gets hurt.
      
      By removing the code, the binary become 1240976 bytes smaller.
      Yep, almost 1 Mb, bringing WebCore to the size it has 5 months ago :)
      
      * MostWebCoreFiles: remove the support for memory instrumentation.
      
      Source/WebKit: 
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      Source/WebKit/mac: 
      
      * WebView/WebRenderLayer.mm:
      
      Source/WebKit/win: 
      
      * WebKit.vcproj/WebKitExports.def.in:
      
      Source/WTF: 
      
      On Mac x86_64, the code removal cause the binary to be
      9224 bytes smaller.
      
      * GNUmakefile.list.am:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.vcxproj/WTF.vcxproj:
      * WTF.vcxproj/WTF.vcxproj.filters:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/CMakeLists.txt:
      * wtf/Forward.h:
      * wtf/ListHashSet.h:
      (ListHashSet):
      (ListHashSetNodeAllocator):
      (WTF::ListHashSetNodeAllocator::pool):
      (WTF::ListHashSetNodeAllocator::pastPool):
      * wtf/MemoryInstrumentation.cpp: Removed.
      * wtf/MemoryInstrumentation.h: Removed.
      * wtf/MemoryInstrumentationArrayBufferView.h: Removed.
      * wtf/MemoryInstrumentationHashCountedSet.h: Removed.
      * wtf/MemoryInstrumentationHashMap.h: Removed.
      * wtf/MemoryInstrumentationHashSet.h: Removed.
      * wtf/MemoryInstrumentationListHashSet.h: Removed.
      * wtf/MemoryInstrumentationSequence.h: Removed.
      * wtf/MemoryInstrumentationString.h: Removed.
      * wtf/MemoryInstrumentationVector.h: Removed.
      * wtf/MemoryObjectInfo.h: Removed.
      * wtf/text/AtomicString.h:
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::isASCIILiteral):
      * wtf/text/WTFString.h:
      
      Tools: 
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: Removed.
      
      LayoutTests: 
      
      * inspector/profiler/memory-instrumentation-cached-images-expected.txt: Removed.
      * inspector/profiler/memory-instrumentation-cached-images.html: Removed.
      * inspector/profiler/memory-instrumentation-canvas-expected.txt: Removed.
      * inspector/profiler/memory-instrumentation-canvas.html: Removed.
      * inspector/profiler/memory-instrumentation-external-array-expected.txt: Removed.
      * inspector/profiler/memory-instrumentation-external-array.html: Removed.
      * inspector/profiler/memory-instrumentation-external-string-expected.txt: Removed.
      * inspector/profiler/memory-instrumentation-external-string.html: Removed.
      * inspector/profiler/memory-instrumentation-test.js: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d72cb0b
  12. 17 Apr, 2013 3 commits
    • oliver@apple.com's avatar
      Automate generation of toJS function for classes that need to report extra memory usage · abe8f4be
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114768
      
      Reviewed by Geoff Garen.
      
      Only really used by AudioBuffer for now.  The other classes that need it can be
      trivially refactored at a later date.
      
      * Modules/webaudio/AudioBuffer.idl:
      * bindings/js/JSAudioBufferCustom.cpp:
      * bindings/js/JSDOMBinding.h:
      (WebCore):
      (HasMemoryCost):
      (NoType):
      (BaseMixin):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateImplementation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abe8f4be
    • leoyang@rim.com's avatar
      Lots of unused parameter warnings in filesystem code · a30cf776
      leoyang@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114747
      
      Reviewed by Carlos Garcia Campos.
      
      Comment out or remove unused parameter identifiers.
      
      No functionalities changed, no new tests.
      
      * Modules/filesystem/DOMFileSystem.cpp: Comment out |snapshot| because
      it is referred in the comments inside the function.
      (WebCore):
      * Modules/filesystem/DOMFileSystemSync.cpp: Ditto.
      (WebCore):
      * Modules/filesystem/FileWriter.cpp: Remove unused |ec|.
      (WebCore::FileWriter::abort):
      * Modules/filesystem/FileWriterSync.cpp:
      (WebCore::FileWriterSync::didWrite): Remove unused |bytes|.
      * platform/AsyncFileSystemCallbacks.h:
      (WebCore::AsyncFileSystemCallbacks::didOpenFileSystem): Comment out unused parameters
      because the function is inlined.
      (WebCore::AsyncFileSystemCallbacks::didCreateSnapshotFile): Ditto.
      (WebCore::AsyncFileSystemCallbacks::didReadDirectoryEntry): Ditto.
      (WebCore::AsyncFileSystemCallbacks::didReadDirectoryEntries): Ditto.
      (WebCore::AsyncFileSystemCallbacks::didCreateFileWriter): Ditto.
      * platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
      (WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread): Remove unused |client|.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a30cf776
    • mjs@apple.com's avatar
      Replace JSC-specific IDL extended attributes with generic (JSC+V8) ones, now... · bfd58303
      mjs@apple.com authored
      Replace JSC-specific IDL extended attributes with generic (JSC+V8) ones, now that the distinction no longer matters
      https://bugs.webkit.org/show_bug.cgi?id=114712
      
      Reviewed by Dan Bernstein.
      
      No behavior change expected.
      
      * bindings/scripts/IDLAttributes.txt: Remove the JSFoo attributes
      that have bare Foo equivalents.
      * bindings/scripts/CodeGeneratorJS.pm: Remove support for JSFoo
      aliases.
      (GetGenerateIsReachable):
      (GetCustomIsReachable):
      (ShouldGenerateToJSDeclaration):
      (ShouldGenerateToJSImplementation):
      (HasCustomConstructor):
      (HasCustomGetter):
      (HasCustomSetter):
      (HasCustomMethod):
      
      Replace JSFoo attributes with equivalen Foo attributs in all files
      below:
              
      * Modules/geolocation/Geolocation.idl:
      * Modules/indexeddb/IDBDatabase.idl:
      * Modules/indexeddb/IDBObjectStore.idl:
      * Modules/webaudio/DOMWindowWebAudio.idl:
      * Modules/websockets/DOMWindowWebSocket.idl:
      * Modules/websockets/WorkerContextWebSocket.idl:
      * css/CSSRule.idl:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSValue.idl:
      * css/MediaList.idl:
      * css/StyleMedia.idl:
      * css/StyleSheet.idl:
      * dom/MessagePort.idl:
      * dom/MutationObserver.idl:
      * dom/Node.idl:
      * fileapi/Blob.idl:
      * html/HTMLDocument.idl:
      * html/HTMLTemplateElement.idl:
      * html/canvas/ArrayBuffer.idl:
      * html/canvas/CanvasRenderingContext.idl:
      * html/canvas/DataView.idl:
      * html/canvas/EXTDrawBuffers.idl:
      * html/canvas/EXTTextureFilterAnisotropic.idl:
      * html/canvas/OESElementIndexUint.idl:
      * html/canvas/OESStandardDerivatives.idl:
      * html/canvas/OESTextureFloat.idl:
      * html/canvas/OESTextureHalfFloat.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/WebGLCompressedTextureATC.idl:
      * html/canvas/WebGLCompressedTexturePVRTC.idl:
      * html/canvas/WebGLCompressedTextureS3TC.idl:
      * html/canvas/WebGLDebugRendererInfo.idl:
      * html/canvas/WebGLDebugShaders.idl:
      * html/canvas/WebGLDepthTexture.idl:
      * html/canvas/WebGLLoseContext.idl:
      * html/track/TextTrack.idl:
      * html/track/TextTrackCue.idl:
      * html/track/TextTrackList.idl:
      * loader/appcache/DOMApplicationCache.idl:
      * page/BarInfo.idl:
      * page/Console.idl:
      * page/DOMSelection.idl:
      * page/DOMWindow.idl:
      * page/History.idl:
      * page/Location.idl:
      * page/MemoryInfo.idl:
      * page/Navigator.idl:
      * page/Screen.idl:
      * page/WorkerNavigator.idl:
      * plugins/DOMMimeTypeArray.idl:
      * plugins/DOMPluginArray.idl:
      * storage/Storage.idl:
      * workers/AbstractWorker.idl:
      * workers/SharedWorker.idl:
      * workers/Worker.idl:
      * workers/WorkerContext.idl:
      * workers/WorkerLocation.idl:
      * xml/XMLHttpRequestUpload.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfd58303
  13. 16 Apr, 2013 2 commits
  14. 15 Apr, 2013 1 commit
    • mjs@apple.com's avatar
      Remove V8-specific extended attributes from IDL files · 27089042
      mjs@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114523
      
      Reviewed by Geoffrey Garen.
      
      No tests because no behavior change is expected.
      
      * Modules/encryptedmedia/MediaKeyMessageEvent.idl:
      * Modules/encryptedmedia/MediaKeyNeededEvent.idl:
      * Modules/encryptedmedia/MediaKeySession.idl:
      * Modules/encryptedmedia/MediaKeys.idl:
      * Modules/filesystem/HTMLInputElementFileSystem.idl:
      * Modules/indexeddb/IDBAny.idl:
      * Modules/mediasource/MediaSource.idl:
      * Modules/mediasource/SourceBuffer.idl:
      * Modules/mediasource/SourceBufferList.idl:
      * Modules/mediastream/MediaStream.idl:
      * Modules/webaudio/AudioDestinationNode.idl:
      * html/track/TextTrackCue.idl:
      * html/track/TextTrackCueList.idl:
      * html/track/TextTrackList.idl:
      * html/track/TextTrackRegion.idl:
      * html/track/TextTrackRegionList.idl:
      * html/track/TrackEvent.idl:
      * storage/Storage.idl:
      * svg/SVGDocument.idl:
      * svg/SVGElement.idl:
      * workers/WorkerContext.idl:
      * xml/XMLHttpRequest.idl:
      * xml/XPathNSResolver.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27089042
  15. 13 Apr, 2013 1 commit
    • weinig@apple.com's avatar
      Make Frame's ScriptController an OwnPtr and remove the #include · 123e4aae
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114105
      
      Reviewed by Dean Jackson.
      
      Source/WebCore: 
      
      * Modules/websockets/WebSocket.cpp:
      * bindings/generic/BindingSecurity.cpp:
      * bindings/js/JSEventListener.cpp:
      * bindings/js/JSLazyEventListener.cpp:
      * bindings/js/PageScriptDebugServer.cpp:
      * bindings/js/ScriptEventListener.cpp:
      * bindings/js/ScriptState.cpp:
      * bindings/objc/DOM.mm:
      * bindings/objc/DOMAbstractView.mm:
      * bindings/objc/DOMInternal.mm:
      * dom/DocumentStyleSheetCollection.cpp:
      * dom/EventTarget.cpp:
      * dom/ScriptElement.cpp:
      * history/CachedFrame.cpp:
      * html/HTMLCanvasElement.cpp:
      * html/HTMLDocument.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLFormElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/HTMLPlugInImageElement.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * inspector/InspectorAgent.cpp:
      * inspector/InspectorController.cpp:
      * inspector/InspectorFrontendClientLocal.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.cpp:
      * inspector/InspectorOverlay.cpp:
      * inspector/InspectorPageAgent.cpp:
      * inspector/PageRuntimeAgent.cpp:
      * loader/DocumentWriter.cpp:
      * loader/NavigationScheduler.cpp:
      * loader/SubframeLoader.cpp:
      * loader/cache/CachedResourceLoader.cpp:
      * page/DOMWindow.cpp:
      * page/EventSource.cpp:
      * page/Frame.cpp:
      * page/Frame.h:
      * page/Navigator.cpp:
      * page/Page.cpp:
      * page/PageGroup.cpp:
      * xml/XMLHttpRequest.cpp:
      * xml/XMLTreeViewer.cpp:
      
      Source/WebKit/mac: 
      
      * Plugins/Hosted/HostedNetscapePluginStream.mm:
      * Plugins/WebNetscapePluginStream.mm:
      * Plugins/WebPluginContainerCheck.mm:
      * WebCoreSupport/WebGeolocationClient.mm:
      * WebCoreSupport/WebInspectorClient.mm:
      * WebView/WebFrame.mm:
      
      Source/WebKit2: 
      
      * Shared/WebHitTestResult.cpp:
      * Shared/WebHitTestResult.h:
      * UIProcess/Plugins/PlugInAutoStartProvider.cpp:
      * UIProcess/WebContext.h:
      * UIProcess/WebPageProxy.h:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/Netscape/NPJSObject.cpp:
      * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.h:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/Storage/StorageAreaImpl.cpp:
      * WebProcess/Storage/StorageAreaMap.cpp:
      * WebProcess/WebPage/WebFrame.cpp:
      * WebProcess/WebPage/WebPage.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      123e4aae
  16. 12 Apr, 2013 1 commit
    • oliver@apple.com's avatar
      make the codegenerator actually emit polymorphism check in the "no vtable" path · e9a731ba
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114533
      
      Reviewed by David Kilzer.
      
      Make the "no vtable" check correct so that we actually plant a polymorphism
      check.  Update a few interfaces to have the correct validation attributes.
      
      * Modules/webdatabase/SQLTransaction.idl:
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateImplementation):
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      (WebCore::toJS):
      * bindings/scripts/test/TestInterface.idl:
      * html/track/TextTrackCue.idl:
      * svg/SVGAnimatedAngle.idl:
      * svg/SVGAnimatedBoolean.idl:
      * svg/SVGAnimatedEnumeration.idl:
      * svg/SVGAnimatedInteger.idl:
      * svg/SVGAnimatedLength.idl:
      * svg/SVGAnimatedLengthList.idl:
      * svg/SVGAnimatedNumber.idl:
      * svg/SVGAnimatedNumberList.idl:
      * svg/SVGAnimatedPreserveAspectRatio.idl:
      * svg/SVGAnimatedRect.idl:
      * svg/SVGAnimatedString.idl:
      * svg/SVGAnimatedTransformList.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9a731ba
  17. 11 Apr, 2013 1 commit
    • oliver@apple.com's avatar
      Add more type validation to debug builds · 239499fd
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114478
      
      Reviewed by Mark Hahnenberg.
      
      Source/WebCore:
      
      Add a bunch more type checks to the JS DOM bindings.
      
      * Modules/mediastream/MediaStream.idl:
      * Modules/webaudio/AudioDestinationNode.idl:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMBinding.h:
      (WebCore::getExistingWrapper):
      (WebCore):
      (WebCore::createNewWrapper):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GetNativeTypeForConversions):
      (GetGnuVTableRefForInterface):
      (GetGnuVTableNameForInterface):
      (GetGnuMangledNameForInterface):
      (GetGnuVTableOffsetForType):
      (GetWinVTableRefForInterface):
      (GetWinVTableNameForInterface):
      (GetWinMangledNameForInterface):
      (GetNamespaceForInterface):
      (GetImplementationLacksVTableForInterface):
      (GetSkipVTableValidationForInterface):
      (GenerateImplementation):
      * bindings/scripts/IDLAttributes.txt:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * dom/Clipboard.idl:
      * dom/DOMStringMap.idl:
      * dom/MutationRecord.idl:
      * dom/NodeList.idl:
      * html/DOMTokenList.idl:
      * html/track/TextTrack.idl:
      * inspector/ScriptProfileNode.idl:
      * storage/Storage.idl:
      * xml/XPathNSResolver.idl:
      
      Source/WTF:
      
      Add BINDING_VALIDATION flag and make RELEASE_ASSERT use UNLIKELY.
      
      * wtf/Assertions.h:
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      239499fd
  18. 10 Apr, 2013 1 commit
  19. 09 Apr, 2013 2 commits
    • commit-queue@webkit.org's avatar
      [WebSocket] Ignore incoming message in CLOSING state · 92c18ef3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85934
      
      Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-04-09
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      Change WebSocket implementation to suit the new WebSocket API, which
      states that we should ignore messages in CLOSING state.
      
      No new tests, updating existing tests.
      
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::didReceiveMessage):
      
      LayoutTests:
      
      * http/tests/websocket/tests/hybi/client-close-expected.txt: Rebaseline.
      * http/tests/websocket/tests/hybi/client-close.html: Change expected results.
      * http/tests/websocket/tests/hybi/client-close_wsh.py: Embed message in close frame
      instead of using regular message sending call.
      * http/tests/websocket/tests/hybi/fragmented-frames.html: Call WebSocket.close()
      only after receiving all messages from server.
      * http/tests/websocket/tests/hybi/unmasked-frames.html: Remove extra
      WebSocket.close() call that caused regression.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92c18ef3
    • commit-queue@webkit.org's avatar
      [WK2] Remove build warnings for unused parameters · d19b7347
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114234
      
      Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-09
      Reviewed by Andreas Kling.
      
      Fix build warnings -Wunused-parameter.
      
      Source/WebCore:
      
      * Modules/indexeddb/IDBBackingStore.cpp:
      (WebCore::IDBBackingStore::openInMemory):
      * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
      (WebCore::CreateIndexAbortOperation::perform):
      (WebCore::DeleteIndexAbortOperation::perform):
      (WebCore::CreateObjectStoreAbortOperation::perform):
      (WebCore::DeleteObjectStoreAbortOperation::perform):
      (WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
      * Modules/indexeddb/IDBLevelDBCoding.cpp:
      (WebCore::IDBLevelDBCoding::decodeBool):
      (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
      * Modules/indexeddb/IDBLevelDBCoding.h:
      (WebCore::IDBLevelDBCoding::encodeIntSafely):
      * bindings/js/IDBBindingUtilities.cpp:
      (WebCore::canSet):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
      (WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
      * platform/leveldb/LevelDBDatabase.cpp:
      (WebCore::ComparatorAdapter::FindShortestSeparator):
      (WebCore::ComparatorAdapter::FindShortSuccessor):
      
      Source/WebKit2:
      
      * UIProcess/Storage/StorageManager.cpp:
      (WebKit::StorageManager::SessionStorageNamespace::cloneTo):
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::requestNetworkingStatistics):
      (WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
      * WebProcess/Storage/StorageAreaProxy.cpp:
      (WebKit::StorageAreaProxy::removeItem):
      (WebKit::StorageAreaProxy::clear):
      (WebKit::StorageAreaProxy::dispatchSessionStorageEvent):
      (WebKit::StorageAreaProxy::dispatchLocalStorageEvent):
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
      (WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::didFinishLoad):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d19b7347
  20. 08 Apr, 2013 2 commits
    • benjamin@webkit.org's avatar
      Remove HTML Notification · de455ba7
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114231
      
      Reviewed by Ryosuke Niwa.
      
      Source/JavaScriptCore: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore: 
      
      The feature is dead. It was only kept in the tree because of chromium.
      
      * Configurations/FeatureDefines.xcconfig:
      * Modules/notifications/Notification.cpp:
      (WebCore):
      (WebCore::Notification::Notification):
      * Modules/notifications/Notification.h:
      (Notification):
      * Modules/notifications/NotificationCenter.h:
      (NotificationCenter):
      * Modules/notifications/NotificationCenter.idl:
      * page/FeatureObserver.h:
      
      Source/WebKit/blackberry: 
      
      * WebCoreSupport/AboutDataEnableFeatures.in:
      
      Source/WebKit/mac: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      (WebCore::NotificationPresenterClientQt::displayNotification):
      (WebCore::NotificationPresenterClientQt::cancel):
      (WebCore::NotificationPresenterClientQt::notificationClicked):
      (WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
      (WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
      (WebCore::NotificationPresenterClientQt::dumpShowText):
      
      Source/WebKit2: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WTF: 
      
      * wtf/FeatureDefines.h:
      
      Tools: 
      
      * qmake/mkspecs/features/features.pri:
      
      LayoutTests: 
      
      * fast/notifications/notifications-with-permission-expected.txt:
      * fast/notifications/notifications-with-permission.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de455ba7
    • ap@apple.com's avatar
      <rdar://problem/12834449> Crashes in WebSocketChannel::processFrame when processing a ping · 9729b33f
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=114178
      
              Reviewed by Brady Eidson.
      
              No test, I could never reproduce even manually.
      
              Calling enqueueRawFrame() could change incoming buffer, so a subsequent skipBuffer()
              would operate on wrong assumptions. This happened because enqueueRawFrame() actually
              tried to process the queue, and send failure sometimed clears m_buffer.
      
              Fixing this by decoupling enqueuing from sending, and making sure that skipBuffer()
              in ping frame processing case is performed at a safe time.
      
              * Modules/websockets/WebSocketChannel.cpp:
              (WebCore::WebSocketChannel::send):
              (WebCore::WebSocketChannel::startClosingHandshake):
              (WebCore::WebSocketChannel::processFrame):
              (WebCore::WebSocketChannel::enqueueTextFrame):
              (WebCore::WebSocketChannel::enqueueRawFrame):
              (WebCore::WebSocketChannel::enqueueBlobFrame):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9729b33f
  21. 06 Apr, 2013 1 commit
    • weinig@apple.com's avatar
      Removed v8 bindings hooks from IDL files · 007c2427
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114091
      
      Patch by Geoffrey Garen <ggaren@apple.com> on 2013-04-06
      Reviewed by Anders Carlsson and Sam Weinig.
      
      Source/JavaScriptCore: 
      
      * heap/HeapStatistics.h:
      
      Source/WebCore: 
      
      * Modules/encryptedmedia/MediaKeySession.idl:
      * Modules/filesystem/DOMWindowFileSystem.idl:
      * Modules/filesystem/WorkerContextFileSystem.idl:
      * Modules/gamepad/NavigatorGamepad.idl:
      * Modules/geolocation/NavigatorGeolocation.idl:
      * Modules/indexeddb/DOMWindowIndexedDatabase.idl:
      * Modules/indexeddb/WorkerContextIndexedDatabase.idl:
      * Modules/mediastream/DOMWindowMediaStream.idl:
      * Modules/mediastream/NavigatorMediaStream.idl:
      * Modules/notifications/DOMWindowNotifications.idl:
      * Modules/notifications/NotificationCenter.idl:
      * Modules/notifications/WorkerContextNotifications.idl:
      * Modules/quota/DOMWindowQuota.idl:
      * Modules/speech/DOMWindowSpeech.idl:
      * Modules/webaudio/AudioBufferSourceNode.idl:
      * Modules/webaudio/AudioContext.idl:
      * Modules/webaudio/AudioParam.idl:
      * Modules/webaudio/DOMWindowWebAudio.idl:
      * Modules/webdatabase/DOMWindowWebDatabase.idl:
      * Modules/webdatabase/WorkerContextWebDatabase.idl:
      * Modules/websockets/DOMWindowWebSocket.idl:
      * Modules/websockets/WorkerContextWebSocket.idl:
      * bindings/js/JSDOMBinding.cpp:
      * bindings/js/ScriptController.h:
      (ScriptController):
      * bindings/scripts/test/TestNode.idl:
      * bindings/scripts/test/TestObj.idl:
      * css/CSSFontFaceLoadEvent.idl:
      * css/CSSHostRule.idl:
      * css/CSSRule.idl:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSStyleSheet.idl:
      * css/CSSValue.idl:
      * css/FontLoader.idl:
      * css/StyleSheet.idl:
      * css/WebKitCSSRegionRule.idl:
      * dom/Clipboard.idl:
      * dom/CustomElementConstructor.idl:
      * dom/CustomEvent.idl:
      * dom/DOMNamedFlowCollection.idl:
      * dom/DOMStringMap.idl:
      * dom/DataTransferItemList.idl:
      * dom/Document.idl:
      * dom/DocumentFragment.idl:
      * dom/Element.idl:
      * dom/Event.idl:
      * dom/EventTarget.idl:
      * dom/MessageChannel.idl:
      * dom/MouseEvent.idl:
      * dom/MutationRecord.idl:
      * dom/NamedNodeMap.idl:
      * dom/Node.idl:
      * dom/NodeList.idl:
      * dom/RequestAnimationFrameCallback.idl:
      * dom/ShadowRoot.idl:
      * dom/Text.idl:
      * history/HistoryItem.cpp:
      (WebCore::HistoryItem::encodeBackForwardTreeNode):
      (WebCore::HistoryItem::decodeBackForwardTree):
      * html/DOMSettableTokenList.idl:
      * html/DOMTokenList.idl:
      * html/HTMLAllCollection.idl:
      * html/HTMLAppletElement.idl:
      * html/HTMLCollection.idl:
      * html/HTMLDialogElement.idl:
      * html/HTMLDivElement.idl:
      * html/HTMLDocument.idl:
      * html/HTMLElement.idl:
      * html/HTMLEmbedElement.idl:
      * html/HTMLFormControlsCollection.idl:
      * html/HTMLFormElement.idl:
      * html/HTMLImageElement.idl:
      * html/HTMLInputElement.idl:
      * html/HTMLMediaElement.idl:
      * html/HTMLObjectElement.idl:
      * html/HTMLOptionsCollection.idl:
      * html/HTMLSelectElement.idl:
      * html/HTMLSpanElement.idl:
      * html/HTMLStyleElement.idl:
      * html/HTMLTemplateElement.idl:
      * html/HTMLTrackElement.idl:
      * html/HTMLUnknownElement.idl:
      * html/MediaKeyError.idl:
      * html/MediaKeyEvent.idl:
      * html/MicroDataItemValue.idl:
      * html/canvas/CanvasRenderingContext2D.idl:
      * html/canvas/DOMPath.idl:
      * html/shadow/HTMLContentElement.idl:
      * html/shadow/HTMLShadowElement.idl:
      * html/track/TextTrack.idl:
      * inspector/InjectedScriptHost.idl:
      * inspector/InspectorIndexedDBAgent.cpp:
      (WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
      (WebCore::InspectorIndexedDBAgent::requestDatabase):
      (WebCore::InspectorIndexedDBAgent::requestData):
      (WebCore::InspectorIndexedDBAgent::clearObjectStore):
      (WebCore):
      * loader/EmptyClients.h:
      (EmptyFrameLoaderClient):
      * loader/FrameLoaderClient.h:
      (FrameLoaderClient):
      * page/Console.idl:
      * page/DOMWindow.idl:
      * page/DOMWindowPagePopup.idl:
      * page/History.idl:
      * page/Location.idl:
      * platform/graphics/skia/PatternSkia.cpp:
      (WebCore::Pattern::platformDestroy):
      (WebCore::Pattern::platformPattern):
      * testing/Internals.cpp:
      (WebCore::Internals::serializeObject):
      (WebCore::Internals::deserializeBuffer):
      
      Source/WTF: 
      
      * wtf/ArrayBuffer.h:
      (WTF):
      (WTF::ArrayBufferContents::ArrayBufferContents):
      (WTF::ArrayBufferContents::transfer):
      (ArrayBufferContents):
      (ArrayBuffer):
      (WTF::ArrayBufferContents::~ArrayBufferContents):
      * wtf/Platform.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      007c2427
  22. 05 Apr, 2013 7 commits
    • cfleizach@apple.com's avatar
      WebSpeech: event.elapsedTime is always 1364484608 · 16399b98
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114045
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      We were calculating elapsed time incorrectly.
      
      Test: platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html
      
      * Modules/speech/SpeechSynthesis.cpp:
      (WebCore::SpeechSynthesis::fireEvent):
      
      LayoutTests:
      
      * platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time-expected.txt: Added.
      * platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16399b98
    • cfleizach@apple.com's avatar
      WebSpeech: crash at WebCore::SpeechSynthesis::speak · e73c07ab
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113937
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      Protect against the case when invalid data is passed in.
      
      Test: platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html
      
      * Modules/speech/SpeechSynthesis.cpp:
      (WebCore::SpeechSynthesis::speak):
      * Modules/speech/SpeechSynthesisUtterance.cpp:
      (WebCore::SpeechSynthesisUtterance::setVoice):
      
      LayoutTests:
      
      * platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt: Added.
      * platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e73c07ab
    • benjamin@webkit.org's avatar
      Clean the chromium bits of WebCore's WebDatabase · a4946bc1
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114010
      
      Reviewed by Ryosuke Niwa.
      
      * Modules/webdatabase/AbstractDatabaseServer.h:
      * Modules/webdatabase/ChangeVersionWrapper.cpp:
      (WebCore::ChangeVersionWrapper::performPreflight):
      (WebCore::ChangeVersionWrapper::performPostflight):
      * Modules/webdatabase/Database.cpp:
      * Modules/webdatabase/Database.h:
      (Database):
      * Modules/webdatabase/DatabaseBackend.cpp:
      (WebCore::DatabaseBackend::openAndVerifyVersion):
      * Modules/webdatabase/DatabaseBackendBase.cpp:
      (WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
      (WebCore::DatabaseBackendBase::performOpenAndVerify):
      (WebCore::DatabaseBackendBase::getActualVersionForTransaction):
      (WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):
      * Modules/webdatabase/DatabaseBackendBase.h:
      (DatabaseBackendBase):
      * Modules/webdatabase/DatabaseBackendSync.cpp:
      (WebCore::DatabaseBackendSync::openAndVerifyVersion):
      * Modules/webdatabase/DatabaseContext.cpp:
      (WebCore::DatabaseContext::databaseExceededQuota):
      * Modules/webdatabase/DatabaseManager.cpp:
      * Modules/webdatabase/DatabaseManager.h:
      (DatabaseManager):
      * Modules/webdatabase/DatabaseServer.cpp:
      (WebCore::DatabaseServer::initialize):
      (WebCore::DatabaseServer::setClient):
      (WebCore::DatabaseServer::databaseDirectoryPath):
      (WebCore::DatabaseServer::setDatabaseDirectoryPath):
      (WebCore::DatabaseServer::openDatabase):
      * Modules/webdatabase/DatabaseServer.h:
      * Modules/webdatabase/DatabaseSync.cpp:
      (WebCore::DatabaseSync::changeVersion):
      * Modules/webdatabase/DatabaseTracker.cpp:
      (WebCore::DatabaseTracker::canEstablishDatabase):
      (WebCore::DatabaseTracker::retryCanEstablishDatabase):
      * Modules/webdatabase/DatabaseTracker.h:
      (WebCore):
      (DatabaseTracker):
      * Modules/webdatabase/SQLStatementBackend.cpp:
      (WebCore::SQLStatementBackend::execute):
      (WebCore::SQLStatementBackend::setDatabaseDeletedError):
      (WebCore::SQLStatementBackend::setVersionMismatchedError):
      (WebCore::SQLStatementBackend::setFailureDueToQuota):
      * Modules/webdatabase/SQLStatementBackend.h:
      (SQLStatementBackend):
      * Modules/webdatabase/SQLTransaction.cpp:
      (WebCore::SQLTransaction::deliverTransactionCallback):
      (WebCore::SQLTransaction::deliverStatementCallback):
      * Modules/webdatabase/SQLTransactionBackend.cpp:
      (WebCore::SQLTransactionBackend::executeSQL):
      (WebCore::SQLTransactionBackend::openTransactionAndPreflight):
      (WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):
      (WebCore::SQLTransactionBackend::nextStateForCurrentStatementError):
      (WebCore::SQLTransactionBackend::postflightAndCommit):
      (WebCore::SQLTransactionBackend::acquireOriginLock):
      (WebCore::SQLTransactionBackend::releaseOriginLockIfNeeded):
      * Modules/webdatabase/SQLTransactionBackend.h:
      (SQLTransactionBackend):
      * Modules/webdatabase/SQLTransactionBackendSync.cpp:
      (WebCore::SQLTransactionBackendSync::begin):
      (WebCore::SQLTransactionBackendSync::commit):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4946bc1
    • ggaren@apple.com's avatar
      Made USE(JSC) unconditional · 95708e2b
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114058
      
      Reviewed by Anders Carlsson.
      
      ../JavaScriptCore: 
      
      * config.h:
      
      ../ThirdParty: 
      
      * gtest/include/gtest/internal/gtest-port.h:
      
      ../WebCore: 
      
      * Modules/webdatabase/Database.cpp:
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeIfJavaScriptURL):
      * bindings/js/JavaScriptCallFrame.cpp:
      * bindings/js/JavaScriptCallFrame.h:
      * bindings/scripts/InFilesCompiler.pm:
      (generateHeadersHeader):
      * css/MediaQueryListListener.cpp:
      (WebCore::MediaQueryListListener::queryChanged):
      * dom/ContainerNode.cpp:
      (WebCore::dispatchChildRemovalEvents):
      * dom/EventListener.h:
      (EventListener):
      (WebCore::EventListener::visitJSFunction):
      * dom/EventTarget.h:
      (EventTarget):
      (WebCore):
      (WebCore::EventTarget::visitJSEventListeners):
      * dom/Node.cpp:
      * dom/Node.h:
      * dom/ScriptExecutionContext.cpp:
      (WebCore):
      (WebCore::ScriptExecutionContext::globalData):
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext):
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::createImageBuffer):
      * html/HTMLImageLoader.cpp:
      (WebCore::HTMLImageLoader::notifyFinished):
      * inspector/InjectedScriptHost.h:
      (InjectedScriptHost):
      (WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::didCommitLoadImpl):
      * page/Frame.cpp:
      * page/Settings.cpp:
      (WebCore):
      (WebCore::Settings::shouldRespectPriorityInCSSAttributeSetters):
      * page/Settings.h:
      (Settings):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::start):
      (WebCore::PluginView::stop):
      (WebCore::PluginView::performRequest):
      (WebCore::PluginView::npObject):
      (WebCore):
      (WebCore::PluginView::bindingInstance):
      (WebCore::PluginView::privateBrowsingStateChanged):
      * plugins/PluginView.h:
      (PluginView):
      * plugins/PluginViewBase.h:
      (PluginViewBase):
      (WebCore::PluginViewBase::scriptObject):
      * plugins/PluginViewNone.cpp:
      (WebCore):
      (WebCore::PluginView::bindingInstance):
      * plugins/qt/PluginViewQt.cpp:
      (WebCore::PluginView::dispatchNPEvent):
      (WebCore::PluginView::setNPWindowIfNeeded):
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::dropProtection):
      
      ../WebKit/efl: 
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_script_execute):
      
      ../WebKit/qt: 
      
      * Api/qwebscriptworld.cpp:
      (QWebScriptWorld::QWebScriptWorld):
      
      ../WebKit2: 
      
      * Shared/linux/WebMemorySamplerLinux.cpp:
      (WebKit::WebMemorySampler::sampleWebKit):
      * config.h:
      
      ../WTF: 
      
      * wtf/ThreadRestrictionVerifier.h:
      (WTF):
      * wtf/WTFThreadData.cpp:
      (WTF::WTFThreadData::WTFThreadData):
      (WTF::WTFThreadData::~WTFThreadData):
      * wtf/WTFThreadData.h:
      (WTFThreadData):
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::~StringImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95708e2b
    • benjamin@webkit.org's avatar
      Remove the chromium code for WebCore's indexeddb module · 61ca2688
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114004
      
      Reviewed by Ryosuke Niwa.
      
      * Modules/indexeddb/IDBBackingStore.cpp:
      (WebCore::IDBBackingStore::IDBBackingStore):
      * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
      (WebCore::IDBDatabaseBackendImpl::openConnection):
      (WebCore::IDBDatabaseBackendImpl::close):
      * Modules/indexeddb/IDBFactoryBackendInterface.cpp:
      * Modules/indexeddb/IDBTracing.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61ca2688
    • benjamin@webkit.org's avatar
      Remove the chromium code from the filesystem module · 6de4420b
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114002
      
      Reviewed by Ryosuke Niwa.
      
      * Modules/filesystem/DOMFileSystemBase.cpp:
      (WebCore::DOMFileSystemBase::createFileSystemURL):
      * Modules/filesystem/FileSystemType.h:
      * Modules/filesystem/LocalFileSystem.cpp:
      * Modules/filesystem/LocalFileSystem.h:
      (LocalFileSystem):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6de4420b
    • benjamin@webkit.org's avatar
      Remove the chromium directories from WebCore/Modules · 8f5a46f1
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114000
      
      Reviewed by Ryosuke Niwa.
      
      First step in cleaning the code: remove the chromium-specific files.
      
      * Modules/filesystem/chromium/DOMFileSystemChromium.cpp: Removed.
      * Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp: Removed.
      * Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp: Removed.
      * Modules/filesystem/chromium/DraggedIsolatedFileSystem.h: Removed.
      * Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Removed.
      * Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Removed.
      * Modules/speech/chromium/SpeechSynthesisChromium.cpp: Removed.
      * Modules/webdatabase/chromium/DatabaseObserver.h: Removed.
      * Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp: Removed.
      * Modules/webdatabase/chromium/QuotaTracker.cpp: Removed.
      * Modules/webdatabase/chromium/QuotaTracker.h: Removed.
      * Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f5a46f1
  23. 04 Apr, 2013 1 commit
    • andersca@apple.com's avatar
      Prune unneeded header #includes · 0920f1b1
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113973
      
      Reviewed by Geoffrey Garen.
      
      Reduce the amount of headers included by other headers by:
      - Moving implicit and explicit constructors and destructors into .cpp files so member variable constructors/destructors
        don't have to be declared.
      - Move CachedResourceClient subclasses out into separate headers so that their respective CachedResource subclasses don't
        have to be included by the classes that derive from those subclasses.
      - Remove headers that were never needed in the first place.
      
      * Modules/webaudio/AudioContext.h:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMWindowCustom.cpp:
      * css/CSSFontFaceSource.h:
      * html/canvas/CanvasPattern.cpp:
      (WebCore::CanvasPattern::create):
      (WebCore::CanvasPattern::CanvasPattern):
      (WebCore::CanvasPattern::~CanvasPattern):
      * html/canvas/CanvasPattern.h:
      (WebCore::CanvasPattern::pattern):
      (WebCore::CanvasPattern::originClean):
      * html/parser/HTMLScriptRunner.h:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/TextTrackLoader.h:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      * loader/cache/CachedFontClient.h: Added.
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      * loader/cache/CachedResourceHandle.cpp:
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::setResource):
      * loader/cache/CachedResourceHandle.h:
      (WebCore::CachedResourceHandleBase::get):
      (WebCore::CachedResourceHandleBase::operator!):
      (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
      (WebCore::CachedResourceHandleBase::operator=):
      (WebCore::CachedResourceHandle::CachedResourceHandle):
      (WebCore::CachedResourceHandle::get):
      (WebCore::CachedResourceHandle::operator->):
      (WebCore::CachedResourceHandle::operator=):
      (WebCore::CachedResourceHandle::operator==):
      (WebCore::CachedResourceHandle::operator!=):
      (WebCore::operator==):
      (WebCore::operator!=):
      * loader/cache/CachedSVGDocument.h:
      * loader/cache/CachedSVGDocumentReference.h:
      * loader/cache/CachedSVGDocumentClient.h: Added.
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      * loader/cache/CachedStyleSheetClient.h:
      * platform/PlatformScreen.h:
      * platform/audio/HRTFElevation.cpp:
      * platform/audio/HRTFKernel.cpp:
      (WebCore::HRTFKernel::fftSize):
      * platform/audio/HRTFKernel.h:
      * platform/audio/ReverbConvolverStage.cpp:
      (WebCore::ReverbConvolverStage::~ReverbConvolverStage):
      * platform/audio/ReverbConvolverStage.h:
      * platform/graphics/FontPlatformData.h:
      * platform/graphics/GraphicsContext3D.h:
      * platform/graphics/Path.cpp:
      * platform/graphics/Path.h:
      * platform/graphics/Pattern.cpp:
      * platform/graphics/Pattern.h:
      * platform/graphics/filters/FilterOperation.cpp:
      (WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
      (WebCore::ReferenceFilterOperation::~ReferenceFilterOperation):
      (WebCore::ReferenceFilterOperation::setCachedSVGDocumentReference):
      * platform/graphics/filters/FilterOperation.h:
      * platform/graphics/transforms/AffineTransform.h:
      * plugins/DOMMimeType.h:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/style/StyleCachedShader.h:
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      * svg/SVGUseElement.h:
      * xml/parser/XMLDocumentParser.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0920f1b1