1. 09 May, 2013 1 commit
    • ch.dumez@sisa.samsung.com's avatar
      Add support for [NoInterfaceObject] Web IDL extended attribute · 077c4e77
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115714
      
      Reviewed by Kentaro Hara.
      
      .:
      
      Update GENERATE_BINDINGS macro to take an additional _window_constructors_file
      optional argument.
      
      * Source/cmake/WebKitMacros.cmake:
      
      Source/WebCore:
      
      *Constructor attributes on the global DOMWindow object are now automatically
      generated for each non-callback interface that is not declared with the
      [NoInterfaceObject] extended attribute. It is thus no longer needed for
      developers to manually add *Constructor attributes for their new interfaces
      unless they wish to register an "extra" constructor for their interface.
      
      This patch does not modify at all the behavior on JS side. To achieve this,
      [NoInterfaceObject] extended attribute is added to interfaces that should
      not have it according to specification (e.g. History, Location, ...).
      This can be improved later as the behavior should not change with this
      patch.
      
      No new tests, no behavior change.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * Modules/battery/BatteryManager.idl:
      * Modules/encryptedmedia/MediaKeyMessageEvent.idl:
      * Modules/encryptedmedia/MediaKeyNeededEvent.idl:
      * Modules/encryptedmedia/MediaKeySession.idl:
      * Modules/encryptedmedia/MediaKeys.idl:
      * Modules/filesystem/DOMFileSystem.idl:
      * Modules/filesystem/DOMFileSystemSync.idl:
      * Modules/filesystem/DirectoryEntry.idl:
      * Modules/filesystem/DirectoryEntrySync.idl:
      * Modules/filesystem/DirectoryReader.idl:
      * Modules/filesystem/DirectoryReaderSync.idl:
      * Modules/filesystem/Entry.idl:
      * Modules/filesystem/EntryArray.idl:
      * Modules/filesystem/EntryArraySync.idl:
      * Modules/filesystem/EntrySync.idl:
      * Modules/filesystem/FileEntry.idl:
      * Modules/filesystem/FileEntrySync.idl:
      * Modules/filesystem/FileWriter.idl:
      * Modules/filesystem/FileWriterSync.idl:
      * Modules/filesystem/Metadata.idl:
      * Modules/gamepad/Gamepad.idl:
      * Modules/gamepad/GamepadList.idl:
      * Modules/geolocation/Coordinates.idl:
      * Modules/geolocation/Geolocation.idl:
      * Modules/geolocation/Geoposition.idl:
      * Modules/geolocation/PositionError.idl:
      * Modules/indexeddb/DOMWindowIndexedDatabase.idl:
      * Modules/indexeddb/IDBAny.idl:
      * Modules/mediasource/MediaSource.idl:
      * Modules/mediasource/SourceBuffer.idl:
      * Modules/mediasource/SourceBufferList.idl:
      * Modules/mediastream/DOMWindowMediaStream.idl: Removed.
      * Modules/mediastream/MediaStream.idl:
      * Modules/mediastream/MediaStreamTrack.idl:
      * Modules/mediastream/MediaStreamTrackEvent.idl:
      * Modules/mediastream/NavigatorUserMediaError.idl:
      * Modules/mediastream/RTCDTMFSender.idl:
      * Modules/mediastream/RTCDTMFToneChangeEvent.idl:
      * Modules/mediastream/RTCDataChannel.idl:
      * Modules/mediastream/RTCDataChannelEvent.idl:
      * Modules/mediastream/RTCIceCandidateEvent.idl:
      * Modules/mediastream/RTCPeerConnection.idl:
      * Modules/mediastream/RTCStatsReport.idl:
      * Modules/mediastream/RTCStatsResponse.idl:
      * Modules/networkinfo/NetworkInfoConnection.idl:
      * Modules/notifications/DOMWindowNotifications.idl:
      * Modules/notifications/NotificationCenter.idl:
      * Modules/quota/StorageInfo.idl:
      * Modules/quota/StorageQuota.idl:
      * Modules/speech/DOMWindowSpeech.idl: Removed.
      * Modules/speech/DOMWindowSpeechSynthesis.idl:
      * Modules/speech/SpeechGrammar.idl:
      * Modules/speech/SpeechGrammarList.idl:
      * Modules/speech/SpeechRecognition.idl:
      * Modules/speech/SpeechRecognitionAlternative.idl:
      * Modules/speech/SpeechRecognitionError.idl:
      * Modules/speech/SpeechRecognitionEvent.idl:
      * Modules/speech/SpeechRecognitionResult.idl:
      * Modules/speech/SpeechRecognitionResultList.idl:
      * Modules/speech/SpeechSynthesis.idl:
      * Modules/speech/SpeechSynthesisVoice.idl:
      * Modules/webaudio/AnalyserNode.idl:
      * Modules/webaudio/AudioBuffer.idl:
      * Modules/webaudio/AudioBufferSourceNode.idl:
      * Modules/webaudio/AudioContext.idl:
      * Modules/webaudio/AudioDestinationNode.idl:
      * Modules/webaudio/AudioListener.idl:
      * Modules/webaudio/AudioNode.idl:
      * Modules/webaudio/AudioParam.idl:
      * Modules/webaudio/AudioSourceNode.idl:
      * Modules/webaudio/BiquadFilterNode.idl:
      * Modules/webaudio/ChannelMergerNode.idl:
      * Modules/webaudio/ChannelSplitterNode.idl:
      * Modules/webaudio/ConvolverNode.idl:
      * Modules/webaudio/DOMWindowWebAudio.idl: Removed.
      * Modules/webaudio/DelayNode.idl:
      * Modules/webaudio/DynamicsCompressorNode.idl:
      * Modules/webaudio/GainNode.idl:
      * Modules/webaudio/MediaElementAudioSourceNode.idl:
      * Modules/webaudio/MediaStreamAudioDestinationNode.idl:
      * Modules/webaudio/MediaStreamAudioSourceNode.idl:
      * Modules/webaudio/OfflineAudioContext.idl:
      * Modules/webaudio/OscillatorNode.idl:
      * Modules/webaudio/PannerNode.idl:
      * Modules/webaudio/ScriptProcessorNode.idl:
      * Modules/webaudio/WaveShaperNode.idl:
      * Modules/webaudio/WaveTable.idl:
      * Modules/webdatabase/DOMWindowWebDatabase.idl:
      * Modules/webdatabase/Database.idl:
      * Modules/webdatabase/DatabaseSync.idl:
      * Modules/webdatabase/SQLError.idl:
      * Modules/webdatabase/SQLResultSet.idl:
      * Modules/webdatabase/SQLResultSetRowList.idl:
      * Modules/webdatabase/SQLTransaction.idl:
      * Modules/webdatabase/SQLTransactionSync.idl:
      * Modules/websockets/DOMWindowWebSocket.idl: Removed.
      * Modules/websockets/WebSocket.idl:
      * PlatformBlackBerry.cmake:
      * UseJSC.cmake:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/scripts/IDLAttributes.txt:
      * bindings/scripts/IDLParser.pm:
      (parseTypedef):
      * bindings/scripts/preprocess-idls.pl:
      (GenerateConstructorAttribute):
      (getFileContents):
      (getPartialInterfaceNameFromIDL):
      (isCallbackInterfaceFromIDL):
      (trim):
      (getInterfaceExtendedAttributesFromIDL):
      * css/CSSFontFaceLoadEvent.idl:
      * css/CSSFontFaceRule.idl:
      * css/CSSSupportsRule.idl:
      * css/CSSUnknownRule.idl:
      * css/DOMWindowCSS.idl:
      * css/FontLoader.idl:
      * css/MediaQueryList.idl:
      * css/MediaQueryListListener.idl:
      * css/StyleMedia.idl:
      * dom/CustomElementConstructor.idl:
      * dom/DOMError.idl:
      * dom/DOMNamedFlowCollection.idl:
      * dom/DataTransferItem.idl:
      * dom/DataTransferItemList.idl:
      * dom/EventListener.idl:
      * dom/EventTarget.idl:
      * dom/NodeIterator.idl:
      * dom/ShadowRoot.idl:
      * dom/TreeWalker.idl:
      * dom/WebKitNamedFlow.idl:
      * fileapi/FileException.idl:
      * fileapi/FileReaderSync.idl:
      * html/HTMLAudioElement.idl:
      * html/HTMLDetailsElement.idl:
      * html/HTMLOptionElement.idl:
      * html/MediaError.idl:
      * html/MediaKeyError.idl:
      * html/MicroDataItemValue.idl:
      * html/RadioNodeList.idl:
      * html/ValidityState.idl:
      * html/canvas/CanvasRenderingContext.idl:
      * html/canvas/DOMPath.idl:
      * html/canvas/EXTDrawBuffers.idl:
      * html/canvas/EXTTextureFilterAnisotropic.idl:
      * html/canvas/OESElementIndexUint.idl:
      * html/canvas/OESStandardDerivatives.idl:
      * html/canvas/OESTextureFloat.idl:
      * html/canvas/OESTextureHalfFloat.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/WebGLCompressedTextureATC.idl:
      * html/canvas/WebGLCompressedTexturePVRTC.idl:
      * html/canvas/WebGLCompressedTextureS3TC.idl:
      * html/canvas/WebGLContextAttributes.idl:
      * html/canvas/WebGLDebugRendererInfo.idl:
      * html/canvas/WebGLDebugShaders.idl:
      * html/canvas/WebGLDepthTexture.idl:
      * html/canvas/WebGLLoseContext.idl:
      * html/canvas/WebGLVertexArrayObjectOES.idl:
      * html/track/AudioTrack.idl:
      * html/track/AudioTrackList.idl:
      * html/track/TextTrackRegionList.idl:
      * html/track/VideoTrack.idl:
      * html/track/VideoTrackList.idl:
      * inspector/InjectedScriptHost.idl:
      * inspector/InspectorFrontendHost.idl:
      * inspector/JavaScriptCallFrame.idl:
      * inspector/ScriptProfile.idl:
      * inspector/ScriptProfileNode.idl:
      * loader/appcache/DOMApplicationCache.idl:
      * page/AbstractView.idl:
      * page/BarInfo.idl:
      * page/Console.idl:
      * page/Crypto.idl:
      * page/DOMSecurityPolicy.idl:
      * page/DOMWindow.idl:
      * page/History.idl:
      * page/Location.idl:
      * page/MemoryInfo.idl:
      * page/Navigator.idl:
      * page/PagePopupController.idl:
      * page/Performance.idl:
      * page/PerformanceEntry.idl:
      * page/PerformanceEntryList.idl:
      * page/PerformanceMark.idl:
      * page/PerformanceMeasure.idl:
      * page/PerformanceNavigation.idl:
      * page/PerformanceResourceTiming.idl:
      * page/PerformanceTiming.idl:
      * page/Screen.idl:
      * page/SpeechInputResult.idl:
      * page/SpeechInputResultList.idl:
      * page/WorkerNavigator.idl:
      * page/make_settings.pl:
      (generateInternalSettingsIdlFile):
      * svg/ElementTimeControl.idl:
      * svg/SVGAnimationElement.idl:
      * svg/SVGExternalResourcesRequired.idl:
      * svg/SVGFilterPrimitiveStandardAttributes.idl:
      * svg/SVGFitToViewBox.idl:
      * svg/SVGLangSpace.idl:
      * svg/SVGLocatable.idl:
      * svg/SVGStyledElement.idl:
      * svg/SVGTests.idl:
      * svg/SVGTransformable.idl:
      * svg/SVGURIReference.idl:
      * testing/InternalSettings.idl:
      * testing/Internals.idl:
      * testing/MallocStatistics.idl:
      * testing/TypeConversions.idl:
      * workers/AbstractWorker.idl:
      * workers/DedicatedWorkerContext.idl:
      * workers/SharedWorker.idl:
      * workers/SharedWorkerContext.idl:
      * workers/WorkerContext.idl:
      * workers/WorkerLocation.idl:
      * xml/XPathExpression.idl:
      * xml/XPathNSResolver.idl:
      
      Tools:
      
      Update BindingsTests.generate_supplemental_dependency() to pass an
      additional windowConstructorsFile argument to preprocess-idls.pl.
      
      * Scripts/webkitpy/bindings/main.py:
      (BindingsTests.generate_supplemental_dependency):
      (BindingsTests.main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      077c4e77
  2. 08 May, 2013 1 commit
    • zandobersek@gmail.com's avatar
      [GTK] Plumb the Automake build system for the Battery Status API feature · 90142ec9
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115718
      
      Reviewed by Martin Robinson.
      
      .: 
      
      * Source/autotools/FindDependencies.m4: Check for the upower-glib dependency if the feature is enabled.
      * Source/autotools/PrintBuildConfiguration.m4: Print out the feature status.
      * Source/autotools/ReadCommandLineArguments.m4: Check for the --enable-battery-status option. The deafult,
      when the option is not given, is to disable the feature.
      * Source/autotools/SetupWebKitFeatures.m4: Treat the ENABLE_BATTERY_STATUS define as configurable.
      * Source/autotools/symbols.filter: Export a couple of symbols that are used in the WebCore internals library.
      
      Source/WebCore: 
      
      No new tests - no new functionality. The feature is not enabled yet, though all the relevant tests
      pass when it is.
      
      * GNUmakefile.am: Add the Modules/battery directory to the list of search paths for header inclusions.
      Include the same directory under the IDL_PATH variable so the IDL files it contains are processed.
      List these IDL files using a wildcard under the EXTRA_DIST list.
      * GNUmakefile.list.am: Add the build targets for the module source files, IDLs and resulting JS bindings.
      * bindings/gobject/GNUmakefile.am: Add the build targets for the GObject DOM bindings.
      
      Tools: 
      
      * Scripts/webkitdirs.pm:
      (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
      through the --(enable|disable)-battery-status flag passed to configure.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90142ec9
  3. 07 May, 2013 1 commit
    • antti@apple.com's avatar
      Remove SelectRuleFeatureSet · d77f33af
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115757
      
      Reviewed by Benjamin Poulain.
      
      This is dead code.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/Element.cpp:
      (WebCore::Element::attributeChanged):
      (WebCore):
      (WebCore::Element::didAffectSelector):
      * dom/Element.h:
      (Element):
      * dom/ElementShadow.h:
      (WebCore::ElementShadow::invalidateDistribution):
      * html/shadow/ContentDistributor.cpp:
      (WebCore::ContentDistributor::ContentDistributor):
      (WebCore):
      * html/shadow/ContentDistributor.h:
      (ContentDistributor):
      * html/shadow/InsertionPoint.cpp:
      (WebCore::InsertionPoint::insertedInto):
      (WebCore::InsertionPoint::removedFrom):
      * html/shadow/InsertionPoint.h:
      (InsertionPoint):
      * html/shadow/SelectRuleFeatureSet.cpp: Removed.
      * html/shadow/SelectRuleFeatureSet.h: Removed.
      * testing/Internals.cpp:
      (WebCore):
      * testing/Internals.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d77f33af
  4. 06 May, 2013 1 commit
  5. 04 May, 2013 1 commit
  6. 03 May, 2013 1 commit
    • antti@apple.com's avatar
      Remove HTMLShadowElement · 5c894cda
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115555
      
      Reviewed by Andreas Kling.
      
      This is not used internally.
      
      * CMakeLists.txt:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/ComposedShadowTreeWalker.cpp:
      * dom/NodeRenderingContext.cpp:
      * html/HTMLElementsAllInOne.cpp:
      * html/HTMLTagNames.in:
      * html/InputType.cpp:
      (WebCore::InputType::destroyShadowSubtree):
      * html/shadow/ContentDistributor.cpp:
      (WebCore::ContentDistributor::distribute):
      * html/shadow/HTMLShadowElement.cpp: Removed.
      * html/shadow/HTMLShadowElement.h: Removed.
      * html/shadow/HTMLShadowElement.idl: Removed.
      * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c894cda
  7. 02 May, 2013 2 commits
  8. 29 Apr, 2013 2 commits
    • andersca@apple.com's avatar
      Get rid of StorageTask · 41d72935
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115313
      
      Reviewed by Andreas Kling.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * storage/StorageSyncManager.cpp:
      * storage/StorageTask.cpp: Removed.
      * storage/StorageTask.h: Removed.
      * storage/StorageThread.cpp:
      (WebCore::StorageThread::threadEntryPoint):
      (WebCore::StorageThread::dispatch):
      (WebCore::StorageThread::terminate):
      * storage/StorageThread.h:
      (StorageThread):
      * storage/StorageTracker.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41d72935
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix make distcheck. · 835101e7
      carlosgc@webkit.org authored
      Source/JavaScriptCore:
      
      * GNUmakefile.list.am: Add missing headers files to compilation
      and offlineasm/sh4.rb script.
      
      Source/WebCore:
      
      * GNUmakefile.am: Add missing scripts to EXTRA_DIST.
      * GNUmakefile.list.am: Add missing files to compilation.
      
      Source/WebKit2:
      
      * GNUmakefile.list.am: Add missing header files to compilation.
      
      Source/WTF:
      
      * GNUmakefile.list.am: Add missing header file to compilation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      835101e7
  9. 28 Apr, 2013 1 commit
    • rniwa@webkit.org's avatar
      StaticHashSetNodeList is unnecessary · 9db31906
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115219
      
      Reviewed by Antonio Gomes.
      
      Source/WebCore: 
      
      Moved Document::nodesFromRect into Internals::nodesFromRect per
      https://chromium.googlesource.com/chromium/blink/+/78207c5c34383fbb807bb9347deb67168f09bb04.
      
      Also made TouchAdjustment functions use HashListSet directly instead of wrapping it inside
      a StaticHashSetNodeList since there was no need to use the latter.
      
      With these two changes, I deleted StaticHashSetNodeList.
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/Document.cpp:
      (WebCore):
      * dom/Document.h:
      (Document):
      * dom/StaticHashSetNodeList.cpp: Removed.
      * dom/StaticHashSetNodeList.h: Removed.
      * page/EventHandler.cpp:
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
      (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
      * page/TouchAdjustment.cpp:
      (WebCore::TouchAdjustment::compileSubtargetList):
      (WebCore::TouchAdjustment::compileZoomableSubtargets):
      (WebCore::findBestClickableCandidate):
      (WebCore::findBestContextMenuCandidate):
      (WebCore::findBestZoomableArea):
      * page/TouchAdjustment.h:
      (WebCore):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      
      Source/WebKit: 
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      Source/WebKit/win: 
      
      * WebKit.vcproj/WebKitExports.def.in:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9db31906
  10. 25 Apr, 2013 1 commit
  11. 24 Apr, 2013 1 commit
  12. 23 Apr, 2013 1 commit
    • rniwa@webkit.org's avatar
      logicalLeftSelectionGap and logicalRightSelectionGap call availableLogicalWidth() multiple times · cc2cc4ee
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113479
      
      Reviewed by David Hyatt.
      
      Introduced LogicalSelectionOffsetCaches to cache the containing blocks and their logical left and right
      selection offsets in computing selection gaps. An instance of this class stores the containing block for
      each position type and caches their logical selection offsets when none of their block ancestors up until
      its nearest selection root do no have any floating objects or regions and exclusions.
      
      When blockSelectionGaps recurses to another level, it creates a new cache instance by "inheriting"
      (like RenderStyle) from the old cache, overriding those containing blocks that are replaced by "this".
      
      This eliminates the need to traverse containing block ancestors in RenderBlock::logicalLeftSelectionOffset
      and RenderBlock::logicalRightSelectionOffset, and improves WebKit's performance by roughly 20%.
      
      Performance Tests: Interactive/SelectAll.html
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.xcodeproj/project.pbxproj:
      
      * rendering/LogicalSelectionOffsetCaches.h: Added.
      (WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject): Moved from RenderObject.h.
      (WebCore::isNonRenderBlockInline): Ditto.
      (WebCore::containingBlockForFixedPosition): Extracted from RenderObject::containingBlock.
      (WebCore::containingBlockForAbsolutePosition): Ditto.
      (WebCore::containingBlockForObjectInFlow): Ditto.
      
      (WebCore::LogicalSelectionOffsetCaches): Added.
      (WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::ContainingBlockInfo): Added.
      (WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock): Added. m_hasFloatsOrRegions is
      or'ed with itself when ContainingBlockInfo is copy constructed since m_hasFloatsOrRegions needs be true
      for a block when any of its containing block ancestors have floats or regions.
      (WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::block): Added.
      (WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::cache): Added.
      (WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalLeftSelectionOffset): Added. Caches
      the logical selection offset if it hasn't.
      (WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalRightSelectionOffset): Ditto.
      
      (WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches): The first constructor is used
      for a selection root. The second one is used for inheriting from another cache. In the latter case,
      copy all containing block information except ones that need to be overridden by this block.
      (WebCore::LogicalSelectionOffsetCaches::containingBlockInfo): Returns a ContainingBlockInfo based on
      object's position value.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::selectionGapRectsForRepaint):
      (WebCore::RenderBlock::paintSelection):
      (WebCore::RenderBlock::selectionGaps):
      (WebCore::RenderBlock::inlineSelectionGaps):
      (WebCore::RenderBlock::blockSelectionGaps): Exit before instantiating a new LogicalSelectionOffsetCaches
      if there is no child to recurse.
      (WebCore::RenderBlock::blockSelectionGap):
      (WebCore::RenderBlock::logicalLeftSelectionGap):
      (WebCore::RenderBlock::logicalRightSelectionGap):
      (WebCore::RenderBlock::logicalLeftSelectionOffset): Use LogicalSelectionOffsetCaches to get its containing
      block and its logical selection offset.
      (WebCore::RenderBlock::logicalRightSelectionOffset): Ditto.
      
      * rendering/RenderBlock.h:
      (WebCore::RenderBlock):
      
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::containingBlock): Extracted code into LogicalSelectionOffsetCaches.h.
      
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::lineSelectionGap):
      
      * rendering/RootInlineBox.h:
      (WebCore::RootInlineBox):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc2cc4ee
  13. 22 Apr, 2013 2 commits
    • benjamin@webkit.org's avatar
      Remove the memory instrumentation code · 9d72cb0b
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114931
      
      Reviewed by Andreas Kling.
      
      .: 
      
      * Source/autotools/symbols.filter:
      
      Source/JavaScriptCore: 
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
      
      Source/WebCore: 
      
      The Memory Instrumentation code is unfinished and has already
      become out of sync the objects it is supposed to represent.
      
      The current approach does not seem maintainable, it is better to
      remove it before someone gets hurt.
      
      By removing the code, the binary become 1240976 bytes smaller.
      Yep, almost 1 Mb, bringing WebCore to the size it has 5 months ago :)
      
      * MostWebCoreFiles: remove the support for memory instrumentation.
      
      Source/WebKit: 
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      Source/WebKit/mac: 
      
      * WebView/WebRenderLayer.mm:
      
      Source/WebKit/win: 
      
      * WebKit.vcproj/WebKitExports.def.in:
      
      Source/WTF: 
      
      On Mac x86_64, the code removal cause the binary to be
      9224 bytes smaller.
      
      * GNUmakefile.list.am:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.vcxproj/WTF.vcxproj:
      * WTF.vcxproj/WTF.vcxproj.filters:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/CMakeLists.txt:
      * wtf/Forward.h:
      * wtf/ListHashSet.h:
      (ListHashSet):
      (ListHashSetNodeAllocator):
      (WTF::ListHashSetNodeAllocator::pool):
      (WTF::ListHashSetNodeAllocator::pastPool):
      * wtf/MemoryInstrumentation.cpp: Removed.
      * wtf/MemoryInstrumentation.h: Removed.
      * wtf/MemoryInstrumentationArrayBufferView.h: Removed.
      * wtf/MemoryInstrumentationHashCountedSet.h: Removed.
      * wtf/MemoryInstrumentationHashMap.h: Removed.
      * wtf/MemoryInstrumentationHashSet.h: Removed.
      * wtf/MemoryInstrumentationListHashSet.h: Removed.
      * wtf/MemoryInstrumentationSequence.h: Removed.
      * wtf/MemoryInstrumentationString.h: Removed.
      * wtf/MemoryInstrumentationVector.h: Removed.
      * wtf/MemoryObjectInfo.h: Removed.
      * wtf/text/AtomicString.h:
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::isASCIILiteral):
      * wtf/text/WTFString.h:
      
      Tools: 
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: Removed.
      
      LayoutTests: 
      
      * inspector/profiler/memory-instrumentation-cached-images-expected.txt: Removed.
      * inspector/profiler/memory-instrumentation-cached-images.html: Removed.
      * inspector/profiler/memory-instrumentation-canvas-expected.txt: Removed.
      * inspector/profiler/memory-instrumentation-canvas.html: Removed.
      * inspector/profiler/memory-instrumentation-external-array-expected.txt: Removed.
      * inspector/profiler/memory-instrumentation-external-array.html: Removed.
      * inspector/profiler/memory-instrumentation-external-string-expected.txt: Removed.
      * inspector/profiler/memory-instrumentation-external-string.html: Removed.
      * inspector/profiler/memory-instrumentation-test.js: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d72cb0b
    • zandobersek@gmail.com's avatar
      [GTK] Set up libPlatform.la · 25d930a1
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114168
      
      Reviewed by Martin Robinson.
      
      .: 
      
      * GNUmakefile.am: Define the platform_cppflags and platform_sources variables.
      
      Source/Platform: 
      
      * GNUmakefile.am: Set up the libPlatform.la static library to build the source files listed in platform_sources.
      As with the libPlatformGtk.la library, only the Source/WebCore/platform and its subdirectories are allowed to be
      searched for headers to include, providing a convenient way to detect any platform violations. These directories
      are listed in the platform_webcore_cppflags variable.
      
      Source/WebCore: 
      
      No new tests - no new functionality.
      
      * GNUmakefile.am: Also add the LevelDB-specific cppflags to the platform_cppflags if required as the LevelDB
      code is now built into the new libPlatform.la library.
      * GNUmakefile.list.am: Build a small set of non-GTK-specific platform source files that are already free of
      platform violations into the new libPlatform.la library.
      
      Source/WebKit/gtk: 
      
      * GNUmakefile.am: Add the new libPlatform.la library to the libwebkitgtk library.
      
      Source/WebKit2: 
      
      * GNUmakefile.am: Add the new libPlatform.la library to the libwebkitgtk library. Link the WebKitPluginProcess
      executable against libPlatform.la as well.
      
      Tools: 
      
      * GNUmakefile.am: Link the DumpRenderTree executable against both libPlatform.la and libPlatformGtk.la libraries.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25d930a1
  14. 21 Apr, 2013 1 commit
    • krit@webkit.org's avatar
      [Part 4] Parse the custom() function in -webkit-filter: parse the matN() functions · efd4ebf1
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71444
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Custom filter parameters should support mat2 to mat4 value functions. Added parsing
      and style resolving bits to support the matrix function values. A later patch will
      add the matrices to the shader program.
      
      https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters
      
      Modified existing tests to cover changes.
      
      * GNUmakefile.list.am: Added WebKitCSSMatFunctionValue to individual build systems.
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::valueForCustomFilterMatParameter):
      (WebCore):
      (WebCore::valueForCustomFilterParameter):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseTransform):
      (WebCore::CSSParser::parseMatValue):
      (WebCore):
      (WebCore::CSSParser::parseCustomFilterParameters):
      * css/CSSParser.h:
      (WebCore):
      * css/CSSValue.cpp:
      (WebCore::CSSValue::reportMemoryUsage):
      (WebCore::CSSValue::equals):
      (WebCore::CSSValue::cssText):
      (WebCore::CSSValue::destroy):
      (WebCore::CSSValue::cloneForCSSOM):
      * css/CSSValue.h:
      (WebCore::CSSValue::isWebKitCSSMatFunctionValue):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::parseCustomFilterArrayParameter):
      (WebCore::StyleResolver::parseCustomFilterParameter):
      * css/StyleResolver.h:
      (StyleResolver):
      * css/WebKitCSSMatFunctionValue.cpp:
      (WebCore::WebKitCSSMatFunctionValue::WebKitCSSMatFunctionValue):
      (WebCore::WebKitCSSMatFunctionValue::customCssText):
      (WebCore::WebKitCSSMatFunctionValue::cloneForCSSOM):
      (WebCore::WebKitCSSMatFunctionValue::equals):
      (WebCore::WebKitCSSMatFunctionValue::reportDescendantMemoryUsage):
      * css/WebKitCSSMatFunctionValue.h:
      (WebKitCSSMatFunctionValue):
      (WebCore::WebKitCSSMatFunctionValue::create):
      * platform/graphics/filters/CustomFilterArrayParameter.h:
      (WebCore::CustomFilterArrayParameter::create):
      (WebCore::CustomFilterArrayParameter::CustomFilterArrayParameter):
      * platform/graphics/filters/CustomFilterParameter.h:
      (CustomFilterParameter):
      * platform/graphics/filters/CustomFilterRenderer.cpp:
      (WebCore::CustomFilterRenderer::bindProgramParameters):
      
      LayoutTests:
      
      Added tests for mat2 to mat4 parameter functions on custom fiter function and
      parameter descriptor.
      
      * css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt:
      * css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt:
      * css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt:
      * css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt:
      * css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js:
      * css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js:
      * css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js:
      * css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efd4ebf1
  15. 20 Apr, 2013 1 commit
    • krit@webkit.org's avatar
      [Part 5] Parse color value for custom() function parameters · e6947f2c
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114902
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Custom filter parameters should support color values. Added parsing
      and style resolving bits to support color values. A later patch will
      add the color values to the shader program.
      
      https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters
      
      Modified existing tests to cover changes.
      
      * GNUmakefile.list.am: Added CustomFilterColorParameter to support color values
          as custom filter parameters.
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::valueForCustomFilterColorParameter):
      (WebCore):
      (WebCore::valueForCustomFilterParameter):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseCustomFilterParameters):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::parseCustomFilterColorParameter):
      (WebCore):
      (WebCore::StyleResolver::parseCustomFilterParameter):
      * css/StyleResolver.h:
      (StyleResolver):
      * platform/graphics/filters/CustomFilterColorParameter.h: Added.
      (WebCore):
      (WebCore::blendFunc):
      (CustomFilterColorParameter):
      (WebCore::CustomFilterColorParameter::create):
      (WebCore::CustomFilterColorParameter::blend):
      (WebCore::CustomFilterColorParameter::color):
      (WebCore::CustomFilterColorParameter::setColor):
      (WebCore::CustomFilterColorParameter::operator==):
      (WebCore::CustomFilterColorParameter::CustomFilterColorParameter):
      (WebCore::CustomFilterColorParameter::~CustomFilterColorParameter):
      * platform/graphics/filters/CustomFilterParameter.h:
      (CustomFilterParameter):
      * platform/graphics/filters/CustomFilterRenderer.cpp:
      (WebCore::CustomFilterRenderer::bindProgramParameters):
      
      LayoutTests:
      
      Added tests for color parameters on custom fiter function and parameter descriptor.
      
      * css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt:
      * css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt:
      * css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt:
      * css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt:
      * css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js:
      * css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js:
      * css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js:
      * css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6947f2c
  16. 19 Apr, 2013 3 commits
    • commit-queue@webkit.org's avatar
      Add interfaces and stubs for audio and video tracks · 159869e5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113965
      
      Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-19
      Reviewed by Jer Noble.
      
      No new tests because there's no implementations, so there's nothing
      interesting to test.
      
      * CMakeLists.txt: Add AudioTrack, VideoTrack, AudioTrackList and VideoTrackList.
      * DerivedSources.cpp: Same.
      * DerivedSources.make: Same.
      * DerivedSources.pri: Same.
      * GNUmakefile.list.am: Same.
      * Target.pri: Same.
      * UseJSC.cmake: Same.
      * WebCore.vcproj/WebCore.vcproj: Same.
      * WebCore.xcodeproj/project.pbxproj: Same.
      * bindings/gobject/GNUmakefile.am: Same.
      * bindings/js/JSAudioTrackCustom.cpp: Added, based on JSTestTrackCustom
      * bindings/js/JSAudioTrackListCustom.cpp: Same.
      * bindings/js/JSBindingsAllInOne.cpp: Add AudioTrack, VideoTrack, AudioTrackList and VideoTrackList.
      * bindings/js/JSVideoTrackCustom.cpp: Added, based on JSTestTrackCustom
      * bindings/js/JSVideoTrackListCustom.cpp: Same.
      * dom/EventTarget.h: Make AudioTrackList and VideoTrackList event targets.
      * dom/EventTargetFactory.in: Same.
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement): Add m_audioTracks and m_videoTracks
      (WebCore::HTMLMediaElement::~HTMLMediaElement): Clear clients for audio and video tracks
      (WebCore::HTMLMediaElement::audioTrackEnabledChanged): Added.
      (WebCore::HTMLMediaElement::videoTrackSelectedChanged): Added.
      (WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack): Added, based on mediaPlayerDidAddTextTrack
      (WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack): Same.
      (WebCore::HTMLMediaElement::mediaPlayerDidRemoveAudioTrack): Added, based on mediaPlayerDidRemoveTextTrack
      (WebCore::HTMLMediaElement::mediaPlayerDidRemoveVideoTrack): Same.
      (WebCore::HTMLMediaElement::addAudioTrack): Added, based on addTextTrack
      (WebCore::HTMLMediaElement::addVideoTrack): Same.
      (WebCore::HTMLMediaElement::removeAudioTrack): Added, based on removeTextTrack
      (WebCore::HTMLMediaElement::removeVideoTrack): Added, based on removeTextTrack
      (WebCore::HTMLMediaElement::removeAllInbandTracks): Remove audio and video tracks too
      (WebCore::HTMLMediaElement::audioTracks): Added, based on textTracks
      (WebCore::HTMLMediaElement::videoTracks): Added, based on textTracks
      (WebCore::HTMLMediaElement::reportMemoryUsage): Add audio and video tracks
      * html/HTMLMediaElement.h: Add audioTracks and videoTracks and related functions
      * html/HTMLMediaElement.idl: Add audioTracks and videoTracks
      * html/track/AudioTrack.cpp: Added, based on TextTrack and InbandTextTrack.
      * html/track/AudioTrack.h: Same.
      * html/track/AudioTrack.idl: Added.
      * html/track/AudioTrackList.cpp: Added, based on TextTrackList
      * html/track/AudioTrackList.h: Same.
      * html/track/AudioTrackList.idl: Added.
      * html/track/TextTrackList.h: Add missing OVERRIDE on interfaceName()
      * html/track/VideoTrack.cpp: Added, based on TextTrack and InbandTextTrack.
      * html/track/VideoTrack.h: Same.
      * html/track/VideoTrack.idl: Added.
      * html/track/VideoTrackList.cpp: Added, based on TextTrackList
      * html/track/VideoTrackList.h: Same.
      * html/track/VideoTrackList.idl: Added.
      * platform/graphics/AudioTrackPrivate.h: Added, based on InbandTextTrackPrivate.h
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::MediaPlayer::addAudioTrack): Added, based on addTextTrack
      (WebCore::MediaPlayer::removeAudioTrack): Added, based on removeTextTrack
      (WebCore::MediaPlayer::addVideoTrack): Added, based on addTextTrack
      (WebCore::MediaPlayer::removeVideoTrack): Added, based on removeTextTrack
      * platform/graphics/MediaPlayer.h:
      (WebCore::MediaPlayerClient::mediaPlayerDidAddAudioTrack): Added, based on mediaPlayerDidAddTextTrack
      (WebCore::MediaPlayerClient::mediaPlayerDidAddVideoTrack): Same
      (WebCore::MediaPlayerClient::mediaPlayerDidRemoveAudioTrack): Added, based on mediaPlayerDidRemoveTextTrack
      (WebCore::MediaPlayerClient::mediaPlayerDidRemoveVideoTrack): Same
      * platform/graphics/VideoTrackPrivate.h: Added, based on InbandTextTrackPrivate.h
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      159869e5
    • krit@webkit.org's avatar
      Refactor transform code in StyleResolver · d0eaf727
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114874
      
      Reviewed by Andreas Kling.
      
      Move transform code frome StyleResolver into own files.
      
      Refactoring, no changes in functionality.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::applyProperty):
      (WebCore::StyleResolver::parseCustomFilterTransformParameter):
      * css/StyleResolver.h:
      * css/TransformFunctions.cpp: Added.
      (WebCore):
      (WebCore::transformOperationType):
      (WebCore::convertToFloatLength):
      (WebCore::transformsForValue):
      * css/TransformFunctions.h: Added.
      (WebCore):
      * css/WebKitCSSMatrix.cpp:
      (WebCore::WebKitCSSMatrix::setMatrixValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0eaf727
    • commit-queue@webkit.org's avatar
      Remove unmaintained feature REQUEST_AUTOCOMPLETE · 37eff9d8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114846
      
      Patch by Dan Beam <dbeam@chromium.org> on 2013-04-19
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      * GNUmakefile.list.am: Remove AutocompleteErrorEvent.h include.
      * bindings/generic/RuntimeEnabledFeatures.cpp:
      (WebCore): Remove requestAutocomplete() runtime feature.
      * bindings/generic/RuntimeEnabledFeatures.h:
      (RuntimeEnabledFeatures): Remove requestAutocomplete() runtime feature.
      * dom/AutocompleteErrorEvent.h: Removed.
      * dom/AutocompleteErrorEvent.idl: Removed.
      * dom/EventNames.h: Remove `autocomplete` and `autocompleteerror` event names.
      (WebCore):
      * dom/EventNames.in: Remove `autocomplete` and `autocompleteerror` event names.
      * html/HTMLAttributeNames.in: Remove `onautocomplete` and `onautocompleteerror` form attributes.
      * html/HTMLFormElement.cpp: Remove requestAutocomplete() related code.
      (WebCore::HTMLFormElement::HTMLFormElement): Remove timer and event queue for requestAutocomplete() related events.
      (WebCore::HTMLFormElement::parseAttribute): Remove parsing of `onautocomplete` and `onautocompleterror`.
      * html/HTMLFormElement.h: Remove requestAutocomplete() related members.
      (HTMLFormElement):
      * html/HTMLFormElement.idl: Remove public requestAutocomplete() API method.
      * loader/EmptyClients.cpp: Remove stub implementation.
      (WebCore):
      * loader/EmptyClients.h: Remove stub interface.
      (EmptyFrameLoaderClient):
      * loader/FrameLoaderClient.h: Remove didRequestAutocomplete() from interface.
      (FrameLoaderClient):
      * page/DOMWindow.idl: Remove `AutocompleteErrorEvent` from window DOM interface.
      
      Source/WTF:
      
      * wtf/FeatureDefines.h: Remove REQUEST_AUTOCOMPLETE as a feature definition.
      
      LayoutTests:
      
      * fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Removed.
      * fast/events/constructors/autocomplete-error-event-constructor.html: Removed.
      * fast/events/event-creation.html: Remove AutocompleteErrorEvent test code.
      * fast/forms/form-request-autocomplete-expected.txt: Removed.
      * fast/forms/form-request-autocomplete.html: Removed.
      * fast/js/constructor-length.html: Remove AutocompleteErrorEvent test code.
      * fast/js/script-tests/global-constructors.js: Remove AutocompleteErrorEvent constructor.
      * platform/blackberry/fast/js/constructor-length-expected.txt: Remove test expectations.
      * platform/gtk/fast/js/constructor-length-expected.txt: Remove test expectations.
      * platform/mac/fast/js/constructor-length-expected.txt: Remove test expectations.
      * platform/qt/fast/js/constructor-length-expected.txt: Remove test expectations.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37eff9d8
  17. 16 Apr, 2013 1 commit
  18. 15 Apr, 2013 1 commit
  19. 13 Apr, 2013 2 commits
    • krit@webkit.org's avatar
      Rename StyleBuilder to DeprecatedStyleBuilder · 7df5d5f9
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114532
      
      Reviewed by Benjamin Poulain.
      
      The StyleBuilder code is hard to read and maintain. People should
      not add new properties to this class. To make this clear, this
      patch renames the class to DeprecatedStyleBuilder.
      
      Pure refactoring, no change in functionality.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * css/CSSAllInOne.cpp:
      * css/DeprecatedStyleBuilder.cpp: Renamed from Source/WebCore/css/StyleBuilder.cpp.
      * css/DeprecatedStyleBuilder.h: Renamed from Source/WebCore/css/StyleBuilder.h.
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::StyleResolver):
      (WebCore::StyleResolver::applyProperty):
      (WebCore::StyleResolver::reportMemoryUsage):
      * css/StyleResolver.h:
      (StyleResolver):
      * rendering/style/RenderStyle.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7df5d5f9
    • zandobersek@gmail.com's avatar
      Unreviewed GTK build fix after r148305. · b6ead50b
      zandobersek@gmail.com authored
      * GNUmakefile.list.am: Adding the TrackListBase build targets to the build.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6ead50b
  20. 12 Apr, 2013 3 commits
    • carlosgc@webkit.org's avatar
      [GTK] Split GtkAuthenticationDialog in two widgets · f3e04808
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103644
      
      Reviewed by Xan Lopez.
      
      Source/WebCore:
      
      The current GtkAuthenticationDialog implements both the common
      logic and widgets to implement a real GtkDialog and a widget to be
      embedded in any container. WebKit1 uses a GtkDialog while WebKit2
      embeds the dialog in the WebView. This patch splits the code to
      leave in Platform only the code that is actually common, leaving
      the widget implementation to the WebKit layer, using a dialog in
      WebKit1 and embedding auth widget in the WebView in WebKit2.
      
      * GNUmakefile.list.am: Add new files to compilation.
      * platform/gtk/GtkAuthenticationDialog.cpp: Removed.
      * platform/gtk/GtkAuthenticationDialog.h: Removed.
      * platform/gtk/WebKitAuthenticationWidget.cpp: Added.
      (_WebKitAuthenticationWidgetPrivate):
      (packTwoColumnLayoutInBox):
      (createLabel):
      (createEntry):
      (webkitAuthenticationWidgetInitialize):
      (webkitAuthenticationWidgetFinalize):
      (webkit_authentication_widget_init):
      (webkit_authentication_widget_class_init):
      (webkitAuthenticationWidgetNew):
      (webkitAuthenticationWidgetCreateCredential):
      (webkitAuthenticationWidgetGetChallenge):
      * platform/gtk/WebKitAuthenticationWidget.h: Added.
      (_WebKitAuthenticationWidget):
      (_WebKitAuthenticationWidgetClass):
      
      Source/WebKit/gtk:
      
      * GNUmakefile.am: Add new files to compilation.
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
      Use helper createAuthenticationDialog() to create and show the
      auth dialog.
      * webkit/webkitauthenticationdialog.cpp: Added.
      (authenticationDialogResponseCallback):
      (createAuthenticationDialog):
      * webkit/webkitauthenticationdialog.h: Added.
      * webkit/webkitsoupauthdialog.cpp:
      (sessionAuthenticate): Ditto.
      
      Source/WebKit2:
      
      * GNUmakefile.list.am: Add new files to compilation.
      * UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.cpp: Removed.
      * UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.h: Removed.
      * UIProcess/API/gtk/WebKitAuthenticationDialog.cpp: Added.
      (webkitAuthenticationDialogAuthenticate): Use the
      AuthenticationChallengeProxy to authenticate and destroy the dialog.
      (okButtonClicked): Call webkitAuthenticationDialogAuthenticate()
      with the credential.
      (cancelButtonClicked): Call
      webkitAuthenticationDialogAuthenticate() with a NULL credential to
      continue without credential.
      (webkitAuthenticationDialogInitialize): Build the UI.
      (webkitAuthenticationDialogDraw): Draw a background.
      (webkitAuthenticationDialogMap): Grab default button.
      (webkitAuthenticationDialogConstructed): Create a GtkStyleContext
      with the GtkWindow path to draw the widget background like a real
      dialog.
      (webkit_authentication_dialog_class_init):
      (webkitAuthenticationDialogNew): Create a new
      WebKitAuthenticationDialog widget.
      * UIProcess/API/gtk/WebKitAuthenticationDialog.h: Added.
      * UIProcess/API/gtk/WebKitLoaderClient.cpp:
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkitWebViewHandleAuthenticationChallenge): Create a
      WebKitAuthenticationDialog widget and pass add it to the
      container.
      * UIProcess/API/gtk/WebKitWebViewBase.cpp:
      (_WebKitWebViewBasePrivate): Updated to use the widget directly.
      (webkitWebViewChildIsInternalWidget): Ditto.
      (webkitWebViewBaseAddAuthenticationDialog): Ditto.
      (webkitWebViewBaseCancelAuthenticationDialog): Ditto.
      (webkitWebViewBaseContainerRemove): Ditto.
      (webkitWebViewBaseContainerForall): Ditto.
      (resizeWebKitWebViewBaseFromAllocation): Ditto.
      (webkitWebViewBaseFocus): Ditto.
      (webkitWebViewBaseDestroy): Destroy the auth widget is present.
      (webkit_web_view_base_class_init): Add implementation for
      GtkWidgetClass::destroy.
      * UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
      
      Tools:
      
      * gtk/generate-gtkdoc:
      (get_webkit2_options): Do not generate api docs for
      WebKitAuthenticationDialog which is private in WebKit2.
      (get_webkit1_options): Do not generate api docs for
      webkitauthenticationdialog which is private in WebKit1.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3e04808
    • ap@apple.com's avatar
      Move CachedRawResourceClient into a separate file · cb953664
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=114491
      
              Reviewed by Mark Rowe.
      
              * GNUmakefile.list.am:
              * Target.pri:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
              * loader/DocumentLoader.cpp:
              * loader/DocumentLoader.h:
              * loader/DocumentThreadableLoader.h:
              * loader/archive/cf/LegacyWebArchive.cpp:
              * loader/cache/CachedRawResource.cpp:
              * loader/cache/CachedRawResource.h:
              * loader/cache/CachedRawResourceClient.h: Added.
              * loader/icon/IconLoader.h:
              * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb953664
    • ap@apple.com's avatar
      Reduce includes of CachedSVGDocument.h · 07c37ba8
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=114489
      
              Reviewed by Jon Honeycutt.
      
              * loader/cache/CachedSVGDocumentReference.cpp: Added.
              * loader/cache/CachedSVGDocumentReference.h:
              Moved function implementations to newly added .cpp file, and removed an include
              of CachedSVGDocument.h.
      
              * css/WebKitCSSSVGDocumentValue.h: Just removed an unnecessary include.
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * Target.pri:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07c37ba8
  21. 11 Apr, 2013 1 commit
    • rniwa@webkit.org's avatar
      Remove ResourceLoadInfo · fbdf3b6d
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113302
      
      Reviewed by Benjamin Poulain.
      
      Co-authored by Christophe Dumez.
      
      Removed ResourceLoadInfo since it had been only used by Chromium port.
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.order:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::buildObjectForResourceResponse):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::loadResourceSynchronously):
      * platform/network/ResourceLoadInfo.h: Removed.
      * platform/network/ResourceResponseBase.cpp:
      (WebCore):
      (WebCore::ResourceResponseBase::reportMemoryUsage):
      * platform/network/ResourceResponseBase.h:
      (ResourceResponseBase):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbdf3b6d
  22. 08 Apr, 2013 2 commits
    • zandobersek@gmail.com's avatar
      Remove the unused LayoutTestSupport class · d3dafbaf
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114170
      
      Reviewed by Alexey Proskuryakov.
      
      The LayoutTestSupport class is not used by any port anywhere in the code and should be removed.
      
      No new tests - no changes in functionality.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/LayoutTestSupport.cpp: Removed.
      * platform/LayoutTestSupport.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3dafbaf
    • zandobersek@gmail.com's avatar
      Remove WebCore::(enable|disable)SecureTextInput methods · d8a93601
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114126
      
      Reviewed by Alexey Proskuryakov.
      
      Remove the enableSecureTextInput and disableSecureTextInput methods and all the codepaths leading to them.
      These were used only by the Chromium port and are as such not required anymore.
      
      No new tests - no changes in functionality.
      
      * GNUmakefile.list.am:
      * WebCore.order:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/Document.cpp:
      (WebCore::Document::Document):
      * dom/Document.h:
      (Document):
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::focusedOrActiveStateChanged):
      * editing/FrameSelection.h:
      (FrameSelection):
      * html/PasswordInputType.cpp:
      * html/PasswordInputType.h:
      (PasswordInputType):
      * page/Frame.cpp:
      (WebCore::Frame::setDocument):
      * platform/SecureTextInput.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8a93601
  23. 06 Apr, 2013 3 commits
  24. 05 Apr, 2013 2 commits
    • commit-queue@webkit.org's avatar
      REGRESSION(r145279): Build fails while linking when MEDIA_STREAM is enabled · 6394346e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113294
      
      Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-05
      Reviewed by Xan Lopez.
      
      In r145279 NamedGetter extended attribute is added to
      RTCStatsResponse.idl which makes the code generator to add
      prototypes for JSRTCStatsResponse::nameGetter and
      JSRTCStatsResponse::canGetItemsForName to the generated
      JSRTCStatsResponse header, but they are not implemented
      anywhere. We need to provide a JSRTCStatsResponseCustom file with
      the implementation of both functions.
      
      * GNUmakefile.list.am: Add JSRTCStatsResponseCustom.cpp to
      compilation.
      * Target.pri: Ditto.
      * UseJSC.cmake: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
      * bindings/js/JSRTCStatsResponseCustom.cpp: Added.
      (WebCore):
      (WebCore::JSRTCStatsResponse::canGetItemsForName):
      (WebCore::JSRTCStatsResponse::nameGetter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6394346e
    • benjamin@webkit.org's avatar
      Remove WTFURL from WebKit · fee685df
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113994
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
      Reviewed by Ryosuke Niwa.
      
      .: 
      
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/WebCore: 
      
      * GNUmakefile.list.am:
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/KURL.cpp:
      (WebCore):
      (WebCore::KURL::reportMemoryUsage):
      (WebCore::KURL::isSafeToSendToAnotherThread):
      * platform/KURL.h:
      (KURL):
      (WebCore):
      * platform/KURLWTFURL.cpp: Removed.
      * platform/KURLWTFURLImpl.h: Removed.
      * platform/cf/KURLCFNet.cpp:
      (WebCore::KURL::KURL):
      (WebCore::KURL::createCFURL):
      (WebCore):
      * platform/mac/KURLMac.mm:
      (WebCore::KURL::KURL):
      (WebCore::KURL::createCFURL):
      
      Source/WebKit/blackberry: 
      
      * WebCoreSupport/AboutDataUseFeatures.in:
      
      Source/WTF: 
      
      Painful, but that is for the best now :(
      
      * GNUmakefile.list.am:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/MemoryInstrumentationParsedURL.h: Removed.
      * wtf/url/api/ParsedURL.cpp: Removed.
      * wtf/url/api/ParsedURL.h: Removed.
      * wtf/url/api/URLBuffer.h: Removed.
      * wtf/url/api/URLQueryCharsetConverter.h: Removed.
      * wtf/url/api/URLString.cpp: Removed.
      * wtf/url/api/URLString.h: Removed.
      * wtf/url/src/RawURLBuffer.h: Removed.
      * wtf/url/src/URLCanon.h: Removed.
      * wtf/url/src/URLCanonEtc.cpp: Removed.
      * wtf/url/src/URLCanonFilesystemurl.cpp: Removed.
      * wtf/url/src/URLCanonFileurl.cpp: Removed.
      * wtf/url/src/URLCanonHost.cpp: Removed.
      * wtf/url/src/URLCanonICU.cpp: Removed.
      * wtf/url/src/URLCanonIP.cpp: Removed.
      * wtf/url/src/URLCanonInternal.cpp: Removed.
      * wtf/url/src/URLCanonInternal.h: Removed.
      * wtf/url/src/URLCanonMailto.cpp: Removed.
      * wtf/url/src/URLCanonPath.cpp: Removed.
      * wtf/url/src/URLCanonPathurl.cpp: Removed.
      * wtf/url/src/URLCanonQuery.cpp: Removed.
      * wtf/url/src/URLCanonRelative.cpp: Removed.
      * wtf/url/src/URLCanonStdURL.cpp: Removed.
      * wtf/url/src/URLCharacterTypes.cpp: Removed.
      * wtf/url/src/URLCharacterTypes.h: Removed.
      * wtf/url/src/URLComponent.h: Removed.
      * wtf/url/src/URLFile.h: Removed.
      * wtf/url/src/URLParse.cpp: Removed.
      * wtf/url/src/URLParse.h: Removed.
      * wtf/url/src/URLParseFile.cpp: Removed.
      * wtf/url/src/URLParseInternal.h: Removed.
      * wtf/url/src/URLSegments.cpp: Removed.
      * wtf/url/src/URLSegments.h: Removed.
      * wtf/url/src/URLUtil.cpp: Removed.
      * wtf/url/src/URLUtil.h: Removed.
      * wtf/url/src/URLUtilInternal.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fee685df
  25. 04 Apr, 2013 2 commits
    • andersca@apple.com's avatar
      Prune unneeded header #includes · 0920f1b1
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113973
      
      Reviewed by Geoffrey Garen.
      
      Reduce the amount of headers included by other headers by:
      - Moving implicit and explicit constructors and destructors into .cpp files so member variable constructors/destructors
        don't have to be declared.
      - Move CachedResourceClient subclasses out into separate headers so that their respective CachedResource subclasses don't
        have to be included by the classes that derive from those subclasses.
      - Remove headers that were never needed in the first place.
      
      * Modules/webaudio/AudioContext.h:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMWindowCustom.cpp:
      * css/CSSFontFaceSource.h:
      * html/canvas/CanvasPattern.cpp:
      (WebCore::CanvasPattern::create):
      (WebCore::CanvasPattern::CanvasPattern):
      (WebCore::CanvasPattern::~CanvasPattern):
      * html/canvas/CanvasPattern.h:
      (WebCore::CanvasPattern::pattern):
      (WebCore::CanvasPattern::originClean):
      * html/parser/HTMLScriptRunner.h:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/TextTrackLoader.h:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      * loader/cache/CachedFontClient.h: Added.
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      * loader/cache/CachedResourceHandle.cpp:
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::setResource):
      * loader/cache/CachedResourceHandle.h:
      (WebCore::CachedResourceHandleBase::get):
      (WebCore::CachedResourceHandleBase::operator!):
      (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
      (WebCore::CachedResourceHandleBase::operator=):
      (WebCore::CachedResourceHandle::CachedResourceHandle):
      (WebCore::CachedResourceHandle::get):
      (WebCore::CachedResourceHandle::operator->):
      (WebCore::CachedResourceHandle::operator=):
      (WebCore::CachedResourceHandle::operator==):
      (WebCore::CachedResourceHandle::operator!=):
      (WebCore::operator==):
      (WebCore::operator!=):
      * loader/cache/CachedSVGDocument.h:
      * loader/cache/CachedSVGDocumentReference.h:
      * loader/cache/CachedSVGDocumentClient.h: Added.
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      * loader/cache/CachedStyleSheetClient.h:
      * platform/PlatformScreen.h:
      * platform/audio/HRTFElevation.cpp:
      * platform/audio/HRTFKernel.cpp:
      (WebCore::HRTFKernel::fftSize):
      * platform/audio/HRTFKernel.h:
      * platform/audio/ReverbConvolverStage.cpp:
      (WebCore::ReverbConvolverStage::~ReverbConvolverStage):
      * platform/audio/ReverbConvolverStage.h:
      * platform/graphics/FontPlatformData.h:
      * platform/graphics/GraphicsContext3D.h:
      * platform/graphics/Path.cpp:
      * platform/graphics/Path.h:
      * platform/graphics/Pattern.cpp:
      * platform/graphics/Pattern.h:
      * platform/graphics/filters/FilterOperation.cpp:
      (WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
      (WebCore::ReferenceFilterOperation::~ReferenceFilterOperation):
      (WebCore::ReferenceFilterOperation::setCachedSVGDocumentReference):
      * platform/graphics/filters/FilterOperation.h:
      * platform/graphics/transforms/AffineTransform.h:
      * plugins/DOMMimeType.h:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/style/StyleCachedShader.h:
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      * svg/SVGUseElement.h:
      * xml/parser/XMLDocumentParser.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0920f1b1
    • ch.dumez@sisa.samsung.com's avatar
      [Cairo] Fix canvas drawing of SVG-based patterns and remove NativeImageCairo · 2e39cc2b
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113929
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Make (Pass)NativeImagePtr typedefs to (Pass)RefPtr<cairo_surface_t> instead
      of NativeImageCairo*. Now that we switch to using smart pointers,
      NativeImageCairo is removed as it made no sense to make it ref counted when
      it merely held a single ref counted member.
      
      Now that Cairo is using smart pointers for (Pass)NativeImagePtr, this patch
      also enables the implementation of SVGImage::nativeImageForCurrentFrame()
      for USE(CAIRO) as well. This effectively fixes canvas drawing of SVG-based
      patterns for Cairo-based ports.
      
      No new tests, covered by svg/canvas/canvas-pattern-svg.html.
      
      * GNUmakefile.list.am: Remove NativeImageCairo.* for GTK.
      
      * PlatformEfl.cmake: Remove NativeImageCairo.* for EFL.
      
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      Remove NativeImageCairo.* for Win.
      
      * platform/graphics/BitmapImage.cpp:
      (WebCore::FrameData::reportMemoryUsage):
      Update MemoryClassInfo::addRawBuffer() call now that m_frame is a RefPtr
      for USE(CAIRO).
      
      * platform/graphics/BitmapImage.h:
      (BitmapImage):
      Remove factory method taking a cairo_surface_t* in argument. This is useless
      now that PassNativeImagePtr is a typedef to PassRefPtr<cairo_surface_t> and
      there is already a factory method taking a PassNativeImagePtr in argument.
      
      * platform/graphics/NativeImagePtr.h:
      (WebCore):
      Make PassNativeImagePtr a typedef to PassRefPtr<cairo_surface_t> and
      NativeImagePtr a typedef to RefPtr<cairo_surface_t>, instead of
      NativeImageCairo*. Moving to smart pointers is needed to enable implementation
      of SVGImage::nativeImageForCurrentFrame() for Cairo.
      
      * platform/graphics/cairo/BitmapImageCairo.cpp:
      (WebCore::BitmapImage::BitmapImage):
      (WebCore::BitmapImage::draw):
      (WebCore::BitmapImage::checkForSolidColor):
      (WebCore::FrameData::clear):
      * platform/graphics/cairo/GraphicsContext3DCairo.cpp:
      (WebCore::GraphicsContext3D::ImageExtractor::extractImage):
      * platform/graphics/cairo/ImageCairo.cpp:
      (WebCore::Image::drawPattern):
      Update Cairo graphics code to reflect the (Pass)NativeImagePtr type changes.
      
      * platform/graphics/cairo/NativeImageCairo.cpp: Removed.
      * platform/graphics/cairo/NativeImageCairo.h: Removed.
      
      * platform/graphics/cairo/PatternCairo.cpp:
      (WebCore::Pattern::createPlatformPattern):
      * platform/graphics/efl/GraphicsContext3DEfl.cpp:
      (WebCore::GraphicsContext3D::ImageExtractor::extractImage):
      * platform/graphics/efl/ImageEfl.cpp:
      (WebCore::BitmapImage::getEvasObject):
      * platform/graphics/gtk/ImageGtk.cpp:
      (WebCore::BitmapImage::getGdkPixbuf):
      * platform/graphics/texmap/TextureMapperGL.cpp:
      (WebCore::BitmapTextureGL::updateContents):
      * platform/graphics/win/ImageCairoWin.cpp:
      (WebCore::BitmapImage::create):
      (WebCore::BitmapImage::drawFrameMatchingSourceSize):
      * platform/gtk/DragImageGtk.cpp:
      (WebCore::createDragImageFromImage):
      * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
      (WebCore::ImageFrame::asNewNativeImage):
      * platform/win/DragImageCairoWin.cpp:
      (WebCore::createDragImageFromImage):
      Update code to reflect the (Pass)NativeImagePtr type changes.
      
      * svg/graphics/SVGImage.cpp:
      (WebCore):
      * svg/graphics/SVGImage.h:
      Enable SVGImage::nativeImageForCurrentFrame() for USE(CAIRO).
      
      Source/WebKit:
      
      Remove outdated symbols now that NativeImageCairo was removed.
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      Source/WebKit/efl:
      
      Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
      instead of NativeImageCairo*.
      
      * ewk/ewk_history.cpp:
      (ewk_history_item_icon_surface_get):
      (ewk_history_item_icon_object_add):
      * ewk/ewk_settings.cpp:
      (ewk_settings_icon_database_icon_surface_get):
      (ewk_settings_icon_database_icon_object_get):
      
      Source/WebKit/gtk:
      
      Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
      instead of NativeImageCairo*.
      
      * webkit/webkitfavicondatabase.cpp:
      (getIconPixbufSynchronously):
      
      Source/WebKit/win:
      
      Remove outdated symbols now that NativeImageCairo was removed.
      
      * WebKit.vcproj/WebKitExports.def.in:
      
      Source/WebKit2:
      
      Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
      instead of NativeImageCairo*.
      
      * Shared/gtk/ArgumentCodersGtk.cpp:
      (CoreIPC::decodeImage):
      * UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp:
      (WKIconDatabaseTryGetCairoSurfaceForURL):
      * UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
      (getIconSurfaceSynchronously):
      
      LayoutTests:
      
      Add EFL / GTK pixels results for svg/canvas/canvas-pattern-svg.html now that
      the test passes for cairo-based ports.
      
      * platform/efl/svg/canvas/canvas-pattern-svg-expected.png: Added.
      * platform/gtk/svg/canvas/canvas-pattern-svg-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e39cc2b
  26. 28 Mar, 2013 1 commit
    • zandobersek@gmail.com's avatar
      [GTK] Build GTK-specific, non-layer-violating source code into... · f12ef742
      zandobersek@gmail.com authored
      [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
      https://bugs.webkit.org/show_bug.cgi?id=112546
      
      Reviewed by Martin Robinson.
      
      .: 
      
      * GNUmakefile.am: Define the new platform_webcore_cppflags.
      
      Source/Platform: 
      
      * GNUmakefile.am: Only specify the very minimal set of inclusion directories, containing the Source/WebCore/platform
      directory and its subdirectories. This will allow only for the WebCore-independent GTK-specific sources to be built into
      libPlatformGtk.la. Also include the GTK, libsecret and libsoup dependencies' cflags amongst the libPlatformGtk's
      CPPFLAGS.
      * GNUmakefile.list.am: Removed. The build targets are now listed (and will be listed until the migration) in the
      GNUmakefile.list.am under Source/WebCore, following the common sense of specifying the build target in the
      GNUmakefile.list.am placed in the same framework directory in which the source file is located.
      
      Source/WebCore: 
      
      No new tests - no new functionality.
      
      * GNUmakefile.am: Passing the DATA_DIR value through the cppflags is not required anymore as the affected source is now
      built into libPlatformGtk.la.
      * GNUmakefile.list.am: Build the GTK-specific source files that are already independent of WebCore into the
      libPlatformGtk.la by assigning the build targets listing to the platformgtk_sources variable.
      * platform/gtk/GtkVersioning.c: Renamed from Source/Platform/gtk/GtkVersioning.c.
      * platform/gtk/GtkVersioning.h: Renamed from Source/Platform/gtk/GtkVersioning.h.
      
      Source/WebKit/gtk: 
      
      * GNUmakefile.am: The GtkVersioning.c file has moved back under Source/WebCore/platform.
      
      Source/WebKit2: 
      
      * GNUmakefile.am: Reference the platform_webcore_cppflags and GTK, libsecret and libsoup dependencies' cflags amongst the
      libPlatformGtk2's CPPFLAGS.
      * Scripts/generate-forwarding-headers.pl: Remove the Platform framework from the list of the frameworks to be searched
      for forwarding headers, it's at the moment not necessary to be included.
      * Shared/gtk/ArgumentCodersGtk.cpp: Adjust the forwarding header for GtkVersioning.h that's been moved back under the
      WebCore framework.
      * Shared/gtk/WebEventFactory.cpp: Ditto.
      * UIProcess/API/gtk/WebKitWebViewBase.cpp: Ditto.
      * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Ditto.
      
      Tools: 
      
      * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
      moved back to Source/WebCore/platform. Fix an indentation issue as well.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f12ef742
  27. 26 Mar, 2013 1 commit
    • ch.dumez@sisa.samsung.com's avatar
      Code duplication between HTTPParsers and HTTPValidation · 3855a916
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113283
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      Merged isValidHTTPToken() from HTTPValidation.h and isRFC2616Token() from
      HTTPParsers.h. They were doing exactly the same thing and their
      implementation was almost the same.
      
      Removed HTTPValidation.* and moved remaining code to HTTPParsers.* as this
      seems like the proper place and it seems odd to keep HTTPValidation for
      just one function.
      
      No new tests, no behavior change for layout tests.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/network/HTTPParsers.cpp:
      (WebCore::isValidHTTPHeaderValue):
      (WebCore):
      (WebCore::isValidHTTPToken): Implementation is slightly simplified based on
      isValidHTTPToken() from HTTPValidation.cpp. (c >= 0x80 || c == 0x7F) is
      replaced by (c >= 0x7F). (c <= 0x1F ||  c == ' ' || c == '\t') is replaced
      by (c <= 0x20). Those expressions are shorter but equivalent.
      (WebCore::contentDispositionType):
      * platform/network/HTTPParsers.h:
      * platform/network/HTTPValidation.cpp: Removed.
      * platform/network/HTTPValidation.h: Removed.
      * xml/XMLHttpRequest.cpp: Stop including HTTPValidation.h.
      
      Source/WebKit/chromium:
      
      * src/AssociatedURLLoader.cpp: Include HTTPParsers.h instead
      of HTTPValidation.h to use isValidHTTPToken().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3855a916