1. 09 May, 2013 5 commits
    • ch.dumez@sisa.samsung.com's avatar
      Add support for [NoInterfaceObject] Web IDL extended attribute · 077c4e77
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115714
      
      Reviewed by Kentaro Hara.
      
      .:
      
      Update GENERATE_BINDINGS macro to take an additional _window_constructors_file
      optional argument.
      
      * Source/cmake/WebKitMacros.cmake:
      
      Source/WebCore:
      
      *Constructor attributes on the global DOMWindow object are now automatically
      generated for each non-callback interface that is not declared with the
      [NoInterfaceObject] extended attribute. It is thus no longer needed for
      developers to manually add *Constructor attributes for their new interfaces
      unless they wish to register an "extra" constructor for their interface.
      
      This patch does not modify at all the behavior on JS side. To achieve this,
      [NoInterfaceObject] extended attribute is added to interfaces that should
      not have it according to specification (e.g. History, Location, ...).
      This can be improved later as the behavior should not change with this
      patch.
      
      No new tests, no behavior change.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * Modules/battery/BatteryManager.idl:
      * Modules/encryptedmedia/MediaKeyMessageEvent.idl:
      * Modules/encryptedmedia/MediaKeyNeededEvent.idl:
      * Modules/encryptedmedia/MediaKeySession.idl:
      * Modules/encryptedmedia/MediaKeys.idl:
      * Modules/filesystem/DOMFileSystem.idl:
      * Modules/filesystem/DOMFileSystemSync.idl:
      * Modules/filesystem/DirectoryEntry.idl:
      * Modules/filesystem/DirectoryEntrySync.idl:
      * Modules/filesystem/DirectoryReader.idl:
      * Modules/filesystem/DirectoryReaderSync.idl:
      * Modules/filesystem/Entry.idl:
      * Modules/filesystem/EntryArray.idl:
      * Modules/filesystem/EntryArraySync.idl:
      * Modules/filesystem/EntrySync.idl:
      * Modules/filesystem/FileEntry.idl:
      * Modules/filesystem/FileEntrySync.idl:
      * Modules/filesystem/FileWriter.idl:
      * Modules/filesystem/FileWriterSync.idl:
      * Modules/filesystem/Metadata.idl:
      * Modules/gamepad/Gamepad.idl:
      * Modules/gamepad/GamepadList.idl:
      * Modules/geolocation/Coordinates.idl:
      * Modules/geolocation/Geolocation.idl:
      * Modules/geolocation/Geoposition.idl:
      * Modules/geolocation/PositionError.idl:
      * Modules/indexeddb/DOMWindowIndexedDatabase.idl:
      * Modules/indexeddb/IDBAny.idl:
      * Modules/mediasource/MediaSource.idl:
      * Modules/mediasource/SourceBuffer.idl:
      * Modules/mediasource/SourceBufferList.idl:
      * Modules/mediastream/DOMWindowMediaStream.idl: Removed.
      * Modules/mediastream/MediaStream.idl:
      * Modules/mediastream/MediaStreamTrack.idl:
      * Modules/mediastream/MediaStreamTrackEvent.idl:
      * Modules/mediastream/NavigatorUserMediaError.idl:
      * Modules/mediastream/RTCDTMFSender.idl:
      * Modules/mediastream/RTCDTMFToneChangeEvent.idl:
      * Modules/mediastream/RTCDataChannel.idl:
      * Modules/mediastream/RTCDataChannelEvent.idl:
      * Modules/mediastream/RTCIceCandidateEvent.idl:
      * Modules/mediastream/RTCPeerConnection.idl:
      * Modules/mediastream/RTCStatsReport.idl:
      * Modules/mediastream/RTCStatsResponse.idl:
      * Modules/networkinfo/NetworkInfoConnection.idl:
      * Modules/notifications/DOMWindowNotifications.idl:
      * Modules/notifications/NotificationCenter.idl:
      * Modules/quota/StorageInfo.idl:
      * Modules/quota/StorageQuota.idl:
      * Modules/speech/DOMWindowSpeech.idl: Removed.
      * Modules/speech/DOMWindowSpeechSynthesis.idl:
      * Modules/speech/SpeechGrammar.idl:
      * Modules/speech/SpeechGrammarList.idl:
      * Modules/speech/SpeechRecognition.idl:
      * Modules/speech/SpeechRecognitionAlternative.idl:
      * Modules/speech/SpeechRecognitionError.idl:
      * Modules/speech/SpeechRecognitionEvent.idl:
      * Modules/speech/SpeechRecognitionResult.idl:
      * Modules/speech/SpeechRecognitionResultList.idl:
      * Modules/speech/SpeechSynthesis.idl:
      * Modules/speech/SpeechSynthesisVoice.idl:
      * Modules/webaudio/AnalyserNode.idl:
      * Modules/webaudio/AudioBuffer.idl:
      * Modules/webaudio/AudioBufferSourceNode.idl:
      * Modules/webaudio/AudioContext.idl:
      * Modules/webaudio/AudioDestinationNode.idl:
      * Modules/webaudio/AudioListener.idl:
      * Modules/webaudio/AudioNode.idl:
      * Modules/webaudio/AudioParam.idl:
      * Modules/webaudio/AudioSourceNode.idl:
      * Modules/webaudio/BiquadFilterNode.idl:
      * Modules/webaudio/ChannelMergerNode.idl:
      * Modules/webaudio/ChannelSplitterNode.idl:
      * Modules/webaudio/ConvolverNode.idl:
      * Modules/webaudio/DOMWindowWebAudio.idl: Removed.
      * Modules/webaudio/DelayNode.idl:
      * Modules/webaudio/DynamicsCompressorNode.idl:
      * Modules/webaudio/GainNode.idl:
      * Modules/webaudio/MediaElementAudioSourceNode.idl:
      * Modules/webaudio/MediaStreamAudioDestinationNode.idl:
      * Modules/webaudio/MediaStreamAudioSourceNode.idl:
      * Modules/webaudio/OfflineAudioContext.idl:
      * Modules/webaudio/OscillatorNode.idl:
      * Modules/webaudio/PannerNode.idl:
      * Modules/webaudio/ScriptProcessorNode.idl:
      * Modules/webaudio/WaveShaperNode.idl:
      * Modules/webaudio/WaveTable.idl:
      * Modules/webdatabase/DOMWindowWebDatabase.idl:
      * Modules/webdatabase/Database.idl:
      * Modules/webdatabase/DatabaseSync.idl:
      * Modules/webdatabase/SQLError.idl:
      * Modules/webdatabase/SQLResultSet.idl:
      * Modules/webdatabase/SQLResultSetRowList.idl:
      * Modules/webdatabase/SQLTransaction.idl:
      * Modules/webdatabase/SQLTransactionSync.idl:
      * Modules/websockets/DOMWindowWebSocket.idl: Removed.
      * Modules/websockets/WebSocket.idl:
      * PlatformBlackBerry.cmake:
      * UseJSC.cmake:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/scripts/IDLAttributes.txt:
      * bindings/scripts/IDLParser.pm:
      (parseTypedef):
      * bindings/scripts/preprocess-idls.pl:
      (GenerateConstructorAttribute):
      (getFileContents):
      (getPartialInterfaceNameFromIDL):
      (isCallbackInterfaceFromIDL):
      (trim):
      (getInterfaceExtendedAttributesFromIDL):
      * css/CSSFontFaceLoadEvent.idl:
      * css/CSSFontFaceRule.idl:
      * css/CSSSupportsRule.idl:
      * css/CSSUnknownRule.idl:
      * css/DOMWindowCSS.idl:
      * css/FontLoader.idl:
      * css/MediaQueryList.idl:
      * css/MediaQueryListListener.idl:
      * css/StyleMedia.idl:
      * dom/CustomElementConstructor.idl:
      * dom/DOMError.idl:
      * dom/DOMNamedFlowCollection.idl:
      * dom/DataTransferItem.idl:
      * dom/DataTransferItemList.idl:
      * dom/EventListener.idl:
      * dom/EventTarget.idl:
      * dom/NodeIterator.idl:
      * dom/ShadowRoot.idl:
      * dom/TreeWalker.idl:
      * dom/WebKitNamedFlow.idl:
      * fileapi/FileException.idl:
      * fileapi/FileReaderSync.idl:
      * html/HTMLAudioElement.idl:
      * html/HTMLDetailsElement.idl:
      * html/HTMLOptionElement.idl:
      * html/MediaError.idl:
      * html/MediaKeyError.idl:
      * html/MicroDataItemValue.idl:
      * html/RadioNodeList.idl:
      * html/ValidityState.idl:
      * html/canvas/CanvasRenderingContext.idl:
      * html/canvas/DOMPath.idl:
      * html/canvas/EXTDrawBuffers.idl:
      * html/canvas/EXTTextureFilterAnisotropic.idl:
      * html/canvas/OESElementIndexUint.idl:
      * html/canvas/OESStandardDerivatives.idl:
      * html/canvas/OESTextureFloat.idl:
      * html/canvas/OESTextureHalfFloat.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/WebGLCompressedTextureATC.idl:
      * html/canvas/WebGLCompressedTexturePVRTC.idl:
      * html/canvas/WebGLCompressedTextureS3TC.idl:
      * html/canvas/WebGLContextAttributes.idl:
      * html/canvas/WebGLDebugRendererInfo.idl:
      * html/canvas/WebGLDebugShaders.idl:
      * html/canvas/WebGLDepthTexture.idl:
      * html/canvas/WebGLLoseContext.idl:
      * html/canvas/WebGLVertexArrayObjectOES.idl:
      * html/track/AudioTrack.idl:
      * html/track/AudioTrackList.idl:
      * html/track/TextTrackRegionList.idl:
      * html/track/VideoTrack.idl:
      * html/track/VideoTrackList.idl:
      * inspector/InjectedScriptHost.idl:
      * inspector/InspectorFrontendHost.idl:
      * inspector/JavaScriptCallFrame.idl:
      * inspector/ScriptProfile.idl:
      * inspector/ScriptProfileNode.idl:
      * loader/appcache/DOMApplicationCache.idl:
      * page/AbstractView.idl:
      * page/BarInfo.idl:
      * page/Console.idl:
      * page/Crypto.idl:
      * page/DOMSecurityPolicy.idl:
      * page/DOMWindow.idl:
      * page/History.idl:
      * page/Location.idl:
      * page/MemoryInfo.idl:
      * page/Navigator.idl:
      * page/PagePopupController.idl:
      * page/Performance.idl:
      * page/PerformanceEntry.idl:
      * page/PerformanceEntryList.idl:
      * page/PerformanceMark.idl:
      * page/PerformanceMeasure.idl:
      * page/PerformanceNavigation.idl:
      * page/PerformanceResourceTiming.idl:
      * page/PerformanceTiming.idl:
      * page/Screen.idl:
      * page/SpeechInputResult.idl:
      * page/SpeechInputResultList.idl:
      * page/WorkerNavigator.idl:
      * page/make_settings.pl:
      (generateInternalSettingsIdlFile):
      * svg/ElementTimeControl.idl:
      * svg/SVGAnimationElement.idl:
      * svg/SVGExternalResourcesRequired.idl:
      * svg/SVGFilterPrimitiveStandardAttributes.idl:
      * svg/SVGFitToViewBox.idl:
      * svg/SVGLangSpace.idl:
      * svg/SVGLocatable.idl:
      * svg/SVGStyledElement.idl:
      * svg/SVGTests.idl:
      * svg/SVGTransformable.idl:
      * svg/SVGURIReference.idl:
      * testing/InternalSettings.idl:
      * testing/Internals.idl:
      * testing/MallocStatistics.idl:
      * testing/TypeConversions.idl:
      * workers/AbstractWorker.idl:
      * workers/DedicatedWorkerContext.idl:
      * workers/SharedWorker.idl:
      * workers/SharedWorkerContext.idl:
      * workers/WorkerContext.idl:
      * workers/WorkerLocation.idl:
      * xml/XPathExpression.idl:
      * xml/XPathNSResolver.idl:
      
      Tools:
      
      Update BindingsTests.generate_supplemental_dependency() to pass an
      additional windowConstructorsFile argument to preprocess-idls.pl.
      
      * Scripts/webkitpy/bindings/main.py:
      (BindingsTests.generate_supplemental_dependency):
      (BindingsTests.main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      077c4e77
    • commit-queue@webkit.org's avatar
      [GTK][AC] Buildfix after r149694 · 5802dccc
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115797
      
      Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-05-09
      Reviewed by Gustavo Noronha Silva.
      
      Source/WebCore:
      
      Some interfaces, such as a return value and parameters of functions are changed.
      
      No new tests since no functionality changed.
      
      * platform/graphics/clutter/GraphicsLayerClutter.cpp:
      (WebCore::animationHasStepsTimingFunction):
      (WebCore::GraphicsLayerClutter::timingFunctionForAnimationValue):
      (WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
      (WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
      (WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
      (WebCore::GraphicsLayerClutter::setAnimationEndpoints):
      (WebCore::GraphicsLayerClutter::setAnimationKeyframes):
      * platform/graphics/clutter/GraphicsLayerClutter.h:
      (GraphicsLayerClutter):
      
      Tools:
      
      Add CLUTTER_LIBS for linking TestWebCore.
      
      * TestWebKitAPI/GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5802dccc
    • commit-queue@webkit.org's avatar
      Fix some compiler warnings (miscellaneous) · f116f0e4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80790
      
      Patch by Rob Buis <rbuis@rim.com> on 2013-05-08
      Reviewed by Brent Fulgham.
      
      Get rid of the following warning for BlackBerry:
      
      NavigatorContentUtils.cpp:60:78: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      
      by not compiling any of the code to add protocols to the protocol whitelist.
      
      * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
      (WebCore::initProtocolHandlerWhitelist):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f116f0e4
    • commit-queue@webkit.org's avatar
      [Windows] The function seekFile() is not implemented. · 554c4caa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115246
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-05-08
      Reviewed by Brent Fulgham.
      
      Implemented seekFile() function for Windows.
      
      * platform/win/FileSystemWin.cpp:
      (WebCore::seekFile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      554c4caa
    • commit-queue@webkit.org's avatar
      Web Inspector: Fix a typo in Settings.js · 65771b50
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115849
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-08
      Reviewed by Joseph Pecoraro.
      
      No new tests, no behavior change.
      
      * inspector/front-end/Settings.js:
      (WebInspector.Settings):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65771b50
  2. 08 May, 2013 25 commits
    • rniwa@webkit.org's avatar
      SecurityOrigin doesn’t need to forward declare or include Document · 16042552
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115847
      
      Reviewed by Alexey Proskuryakov.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/fc7a88caa9c41f3471d8994a530643e5225f82fc.
      
      Removed unused Document forward declaration+include from SecurityOrigin.
      
      * page/SecurityOrigin.cpp:
      * page/SecurityOrigin.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16042552
    • ddkilzer@apple.com's avatar
      BUILD FIX: Don't use adoptCF() with NSDictionary * object · 9ba121f5
      ddkilzer@apple.com authored
      Fixes the following build failure:
      
          In file included from Source/WebCore/platform/network/mac/ResourceErrorMac.mm:27:
          In file included from Source/WebCore/platform/network/cf/ResourceError.h:31:
          /usr/local/include/wtf/RetainPtr.h:81:13: error: static_assert failed "Don't use adoptCF with Objective-C pointer types, use adoptNS."
                      static_assert(!std::is_convertible<T, id>::value, "Don't use adoptCF with Objective-C pointer types, use adoptNS.");
                      ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          /usr/local/include/wtf/RetainPtr.h:274:16: note: in instantiation of member function 'WTF::RetainPtr<NSDictionary *>::RetainPtr' requested here
                  return RetainPtr<T>(AdoptCF, o);
                         ^
          Source/WebCore/platform/network/mac/ResourceErrorMac.mm:214:44: note: in instantiation of function template specialization 'WTF::adoptCF<NSDictionary *>' requested here
                  RetainPtr<NSDictionary> userInfo = adoptCF((NSDictionary *) CFErrorCopyUserInfo(error));
                                                     ^
          1 error generated.
      
      * platform/network/mac/ResourceErrorMac.mm:
      (WebCore::ResourceError::nsError): Switch from adoptCF() to
      adoptNS().  This is in USE(CFNETWORK) code, so it's not
      exercised on the Mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ba121f5
    • lforschler@apple.com's avatar
      Versioning. · eaa06c70
      lforschler@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaa06c70
    • rniwa@webkit.org's avatar
      Remove Editor::setSelectionOffsets · 730528a4
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115831
      
      Reviewed by Andreas Kling.
      
      Removed the function added in r120985 for Chromium Android port.
      
      * editing/Editor.cpp:
      * editing/Editor.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      730528a4
    • rniwa@webkit.org's avatar
      Potential use-after-free of Frame · 6385f35f
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115774
      
      Reviewed by Simon Fraser.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/c5b4a6db82e8280c7fc55ee3dc3a84c6b026e66e.
      
      * page/Frame.cpp:
      (WebCore::Frame::setPrinting):
      (WebCore::Frame::setPageAndTextZoomFactors):
      (WebCore::Frame::deviceOrPageScaleFactorChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6385f35f
    • roger_fong@apple.com's avatar
      Unreviewed build fix, AppleWin port. · 8dfa4a97
      roger_fong@apple.com authored
      * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
      * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
      (WebCore::MediaPlayerPrivateAVFoundation::seek):
      (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
      (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
      (WebCore):
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
      (MediaPlayerPrivateAVFoundation):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dfa4a97
    • xingnan.wang@intel.com's avatar
      Heap-use-after-free in WebCore::AudioNodeOutput::pull · dc262021
      xingnan.wang@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111362
      
      Reviewed by Chris Rogers.
      
      * Modules/webaudio/AudioBuffer.cpp:
      (WebCore::AudioBuffer::createFromAudioFileData):
      * Modules/webaudio/AudioNodeInput.cpp:
      (WebCore::AudioNodeInput::AudioNodeInput):
      (WebCore::AudioNodeInput::updateInternalBus):
      * Modules/webaudio/AudioNodeInput.h:
      (AudioNodeInput):
      * Modules/webaudio/AudioNodeOutput.cpp:
      (WebCore::AudioNodeOutput::AudioNodeOutput):
      (WebCore::AudioNodeOutput::updateInternalBus):
      (WebCore::AudioNodeOutput::pull):
      (WebCore::AudioNodeOutput::bus):
      * Modules/webaudio/AudioNodeOutput.h:
      (AudioNodeOutput):
      * Modules/webaudio/OfflineAudioDestinationNode.cpp:
      (WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
      * Modules/webaudio/OfflineAudioDestinationNode.h:
      (OfflineAudioDestinationNode):
      * platform/audio/AudioBus.cpp:
      (WebCore::AudioBus::createBufferFromRange):
      (WebCore::AudioBus::createBySampleRateConverting):
      (WebCore::AudioBus::createByMixingToMono):
      * platform/audio/AudioBus.h:
      (AudioBus):
      * platform/audio/AudioFileReader.h:
      (WebCore):
      * platform/audio/AudioResampler.cpp:
      (WebCore::AudioResampler::AudioResampler):
      (WebCore::AudioResampler::configureChannels):
      * platform/audio/AudioResampler.h:
      (AudioResampler):
      * platform/audio/HRTFElevation.cpp:
      (WebCore::getConcatenatedImpulseResponsesForSubject):
      (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
      * platform/audio/MultiChannelResampler.cpp:
      * platform/audio/Reverb.cpp:
      (WebCore::Reverb::initialize):
      * platform/audio/Reverb.h:
      (Reverb):
      * platform/audio/efl/AudioBusEfl.cpp:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
      (AudioFileReader):
      (WebCore::AudioFileReader::createBus):
      (WebCore::createBusFromAudioFile):
      (WebCore::createBusFromInMemoryAudioFile):
      * platform/audio/gtk/AudioBusGtk.cpp:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/audio/mac/AudioBusMac.mm:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/audio/mac/AudioFileReaderMac.cpp:
      (WebCore::AudioFileReader::createBus):
      (WebCore::createBusFromAudioFile):
      (WebCore::createBusFromInMemoryAudioFile):
      * platform/audio/mac/AudioFileReaderMac.h:
      (AudioFileReader):
      * platform/audio/qt/AudioBusQt.cpp:
      (WebCore::AudioBus::loadPlatformResource):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc262021
    • commit-queue@webkit.org's avatar
      [BlackBerry] Fix usage of BlackBerry::Platform::String · e7e3b6c9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115781
      
      Patch by Eli Fidler <efidler@blackberry.com> on 2013-05-08
      Reviewed by Rob Buis.
      
      BlackBerry PRs 304193 and 327181
      Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
      
      We currently have a problem where we're passing UTF-8 encoded data into
      the char* constructors of BlackBerry::Platform::String. This means the string
      thinks its data is not UTF-8.
      
      Source/WebCore:
      
      * platform/blackberry/ClipboardBlackBerry.cpp:
      (WebCore::ClipboardBlackBerry::setData):
      (WebCore::ClipboardBlackBerry::writeURL):
      (WebCore::ClipboardBlackBerry::writePlainText):
      * platform/blackberry/CookieManager.cpp:
      (WebCore::CookieManager::getRawCookies):
      (WebCore::CookieManager::getBackingStoreCookies):
      * platform/blackberry/CookieParser.cpp:
      (WebCore::CookieParser::CookieParser):
      (WebCore::CookieParser::parseOneCookie):
      * platform/blackberry/CursorBlackBerry.cpp:
      (WebCore::Cursor::Cursor):
      * platform/blackberry/PlatformBlob.cpp:
      (WebCore::PlatformBlob::nextDataItem):
      * platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
      (WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):
      * platform/graphics/blackberry/ImageBlackBerry.cpp:
      (WebCore::Image::loadPlatformResource):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::MediaPlayerPrivate::load):
      (WebCore::MediaPlayerPrivate::notifyChallengeResult):
      (WebCore::toWebMediaStreamSource):
      (WebCore::toWebMediaStreamDescriptor):
      * platform/network/blackberry/NetworkManager.cpp:
      (WebCore::NetworkManager::startJob):
      * platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
      (WebCore::SocketStreamHandle::SocketStreamHandle):
      * platform/network/blackberry/rss/RSSFilterStream.cpp:
      (WebCore::RSSFilterStream::notifyStatusReceived):
      (WebCore::RSSFilterStream::notifyHeadersReceived):
      (WebCore::RSSFilterStream::convertContentToHtml):
      (WebCore::RSSFilterStream::charset):
      (WebCore::RSSFilterStream::removeHeader):
      (WebCore::RSSFilterStream::updateHeader):
      (WebCore::RSSFilterStream::updateRSSHeaders):
      * platform/network/blackberry/rss/RSSFilterStream.h:
      * platform/text/blackberry/StringBlackBerry.cpp:
      (WTF::String::operator BlackBerry::Platform::String):
      
      Source/WebKit/blackberry:
      
      * Api/JavaScriptVariant.cpp:
      (BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
      * Api/WebKitTextCodec.cpp:
      (BlackBerry::WebKit::base64Encode):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPage::loadFile):
      (BlackBerry::WebKit::WebPage::textEncoding):
      (BlackBerry::WebKit::WebPage::textHasAttribute):
      (BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
      * Api/WebPage.h:
      * Api/WebSettings.cpp:
      (BlackBerry::WebKit::WebSettings::standardSettings):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
      * WebKitSupport/DefaultTapHighlight.cpp:
      (WebKit):
      (BlackBerry::WebKit::DefaultTapHighlight::draw):
      (BlackBerry::WebKit::DefaultTapHighlight::hide):
      
      Tools:
      
      * DumpRenderTree/blackberry/DumpRenderTree.cpp:
      (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
      (BlackBerry::WebKit::dumpHistoryItem):
      * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
      (TestRunner::setUserStyleSheetLocation):
      * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
      (LoadHTMLStringItem::invoke):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7e3b6c9
    • andersca@apple.com's avatar
      Assert at compile time that we don't pass Objective-C object pointers to adoptCF · a9882265
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115823
      
      Reviewed by Geoffrey Garen.
      
      Source/WebCore:
      
      * platform/graphics/ca/mac/TileController.mm:
      (WebCore::TileController::TileController):
      Use adoptNS for CALayer.
      
      Source/WebKit2:
      
      Fix adoptNS/adoptCF mismatches. For the adopt(leakRef()) case we'd ideally want a static_pointer_cast overload for RetainPtr,
      but this will do for now.
      
      * Shared/mac/ArgumentCodersMac.mm:
      (CoreIPC::decode):
      
      Source/WTF:
      
      static_assert in adoptCF that the object passed in is not an Objective-C object.
      * wtf/RetainPtr.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9882265
    • eric.carlson@apple.com's avatar
      TextTrackCue should support empty content · 9967e55e
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115821
      
      Reviewed by Jer Noble.
      
      Source/WebCore:
      
      Test: media/track/track-cue-empty-text-crash.html
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlTextTrackContainerElement::updateDisplay): Don't bother trying to render
          cues with no content.
      
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCue::getCueAsHTML): Return early if there isn't a node tree.
      (WebCore::TextTrackCue::createCueRenderingTree): Ditto.
      (WebCore::TextTrackCue::determineTextDirection): Ditto.
      (WebCore::TextTrackCue::updateDisplayTree): Return early if there isn't a cue rendering tree.
      
      LayoutTests:
      
      * media/track/track-cue-empty-text-crash-expected.txt: Added.
      * media/track/track-cue-empty-text-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9967e55e
    • roger_fong@apple.com's avatar
      Unreviewed AppleWin build fix. · ca5848fe
      roger_fong@apple.com authored
      * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
      (MediaPlayerPrivateAVFoundationCF):
      (WebCore::MediaPlayerPrivateAVFoundationCF::currentTrack):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca5848fe
    • zandobersek@gmail.com's avatar
      [GTK] Plumb the Automake build system for the Battery Status API feature · 90142ec9
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115718
      
      Reviewed by Martin Robinson.
      
      .: 
      
      * Source/autotools/FindDependencies.m4: Check for the upower-glib dependency if the feature is enabled.
      * Source/autotools/PrintBuildConfiguration.m4: Print out the feature status.
      * Source/autotools/ReadCommandLineArguments.m4: Check for the --enable-battery-status option. The deafult,
      when the option is not given, is to disable the feature.
      * Source/autotools/SetupWebKitFeatures.m4: Treat the ENABLE_BATTERY_STATUS define as configurable.
      * Source/autotools/symbols.filter: Export a couple of symbols that are used in the WebCore internals library.
      
      Source/WebCore: 
      
      No new tests - no new functionality. The feature is not enabled yet, though all the relevant tests
      pass when it is.
      
      * GNUmakefile.am: Add the Modules/battery directory to the list of search paths for header inclusions.
      Include the same directory under the IDL_PATH variable so the IDL files it contains are processed.
      List these IDL files using a wildcard under the EXTRA_DIST list.
      * GNUmakefile.list.am: Add the build targets for the module source files, IDLs and resulting JS bindings.
      * bindings/gobject/GNUmakefile.am: Add the build targets for the GObject DOM bindings.
      
      Tools: 
      
      * Scripts/webkitdirs.pm:
      (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
      through the --(enable|disable)-battery-status flag passed to configure.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90142ec9
    • roger_fong@apple.com's avatar
      Unreviewed. AppleWin VS2010 build fix. · 492ef0ee
      roger_fong@apple.com authored
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      492ef0ee
    • darin@apple.com's avatar
      REGRESSION(r149700): fast/css-generated-content/close-quote-negative-depth.html · 50056dc0
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115776
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      I changed depth to more closely match what is in the CSS3 specification.
      There may be a more optimal way to make it work, but this seems the most straightforward.
      
      * rendering/RenderQuote.cpp:
      (WebCore::RenderQuote::RenderQuote): Initialize m_depth to -1 because that depth
      is consistent with the empty string that is the initial value of the text. The
      real depth will be calculated when the node is attached.
      (WebCore::RenderQuote::originalText): Removed the "depth - 1" logic that
      used to be done for close quotes. Instead, the updateDepth function now correctly
      subtracts one for the close quote itself, not just afterward. Also added an early
      exit when the depth is negative; these changes together fix the bug.
      (WebCore::RenderQuote::attachQuote): Added a call to updateDepth even for the render
      quote head, we now need that to set the depth either to 0 or to -1.
      (WebCore::RenderQuote::detachQuote): Removed code to set m_depth to 0;  if we are not
      resetting the text then m_depth should be left matching the text, otherwise updateDepth
      might not do its job correctly if the quote is later re-attached. What matters is that
      m_depth and the text are in sync.
      (WebCore::RenderQuote::updateDepth): Changed updating logic in two ways. First,
      compute the depth in a local variable rather than computing it in a data member
      after first saving off the old value of the data member. That's clearer style.
      Second, add the code to change negative depths to zero when propagating to the
      next quote in the chain, which matches how the standard is written, and decrement
      the depth of the close quote itself, not the quote after the close quote.
      
      LayoutTests:
      
      * TestExpectations: Expect success again on this test.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50056dc0
    • eric.carlson@apple.com's avatar
      Prevent crash when track is deleted during video element deletion. · 75f7f350
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106183
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Test: media/track/track-remove-crash.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::removedFrom): Set m_inActiveDocument to false so we
          do not process text track cues or dispatch related events.
      
      LayoutTests:
      
      * media/track/track-remove-crash-expected.txt: Added.
      * media/track/track-remove-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75f7f350
    • eric.carlson@apple.com's avatar
      [Mac] Unreviewed buildfix after r149741. · 4d896aff
      eric.carlson@apple.com authored
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d896aff
    • eric.carlson@apple.com's avatar
      [Mac] Inband text tracks are not in track menu on Lion · 15972ccc
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115740
      
      Reviewed by Dean Jackson.
      
      Source/WebCore: 
      
      No new tests, covered by existing tests.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_legacyWebKitClosedCaptionsVisible.
      (WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_closedCaptionsVisible
          to false immediately, it will be reset to the appropriate value if necessary.
      (WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
      (WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
      * html/HTMLMediaElement.h:
      
      * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Remove 
          HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT) requirement. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
          AVFOUNDATION_MEDIA_SELECTION_GROUP
      * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Ditto.
      
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: 
      (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Ditto.
      (WebCore::MediaPlayerPrivateAVFoundation::seek): Ditto.
      (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
      (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Ditto.
      (WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Ditto.
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:  Ditto.
      
      * platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h:  Ditto.
      * platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
      (WebCore::InbandTextTrackPrivateLegacyAVFObjC::kind): Don't look at media characteristics, 
          a legacy CC track is always Captions.
      (WebCore::InbandTextTrackPrivateLegacyAVFObjC::isClosedCaptions): Ditto.
      (WebCore::InbandTextTrackPrivateLegacyAVFObjC::containsOnlyForcedSubtitles): Ditto.
      (WebCore::InbandTextTrackPrivateLegacyAVFObjC::isMainProgramContent): Ditto.
      (WebCore::InbandTextTrackPrivateLegacyAVFObjC::isEasyToRead): Ditto.
      (WebCore::InbandTextTrackPrivateLegacyAVFObjC::label): Use different AVFoundation API on 10.7.
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): AVFOUNDATION_TEXT_TRACK_SUPPORT ->
          AVFOUNDATION_MEDIA_SELECTION_GROUP.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
          AVFOUNDATION_MEDIA_SELECTION_GROUP.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Support legacy CC tracks
          only on 10.8. AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP
      (WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Ditto.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): AVFOUNDATION_TEXT_TRACK_SUPPORT -> 
          AVFOUNDATION_MEDIA_SELECTION_GROUP
      
      Source/WTF: 
      
      * wtf/Platform.h: AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP
      
      LayoutTests: 
      
      * platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15972ccc
    • sergio@webkit.org's avatar
      Allow blank spaces before colon (:) on CSS variable definition · 421fb6d5
      sergio@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115802
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Test: css3/css-variable-definition.html
      
      Modified the grammar to allow blank spaces before the colon on CSS
      variable definitions.
      
      * css/CSSGrammar.y.in:
      
      LayoutTests:
      
      New test to check that spaces are allowed before the color on CSS
      variable definitions.
      
      * css3/css-variable-definition-expected.html: Added.
      * css3/css-variable-definition.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      421fb6d5
    • kov@webkit.org's avatar
      [GStreamer] Does memory buffering even with preload set to none · 90b020fe
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115754
      
      Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-08
      Reviewed by Philippe Normand.
      
      Covered by existing tests.
      
      Revision 148840 fixed on-disk buffering being done when preload is set to none,
      but memory buffering is still being done. That is because setting the state to
      paused causes GStreamer to start loading the media, to gather information. Only
      doing that when committing the load avoids that while maintaining the tested
      behaviour unchanged.
      
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::MediaPlayerPrivateGStreamer::load): move setting pause state to commitLoad.
      (WebCore::MediaPlayerPrivateGStreamer::commitLoad): see above.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90b020fe
    • akling@apple.com's avatar
      SVGStyledElement::getPresentationAttribute() does not need to be virtual. · 912f12d6
      akling@apple.com authored
      From Blink r149888 by <cevans@chromium.org>
      <http://src.chromium.org/viewvc/blink?view=revision&revision=149888>
      
      * svg/SVGStyledElement.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      912f12d6
    • allan.jensen@digia.com's avatar
      Crash when loading link to audio file · 34682f98
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115794
      
      Reviewed by Jocelyn Turcotte.
      
      Do not access a null pointer frame.
      
      * loader/appcache/ApplicationCacheHost.cpp:
      (WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34682f98
    • ch.dumez@sisa.samsung.com's avatar
      Remove unused [TransferList] extended attribute · 8f462759
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115788
      
      Reviewed by Kentaro Hara.
      
      Remove [TransferList] extended attribute and corresponding tests as it has no
      effect on the generated JSC bindings.
      
      No new tests, no behavior change.
      
      * bindings/scripts/IDLAttributes.txt:
      * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
      * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
      (WebDOMTestSerializedScriptValueInterface):
      * bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
      * bindings/scripts/test/CPP/WebDOMTestTypedefs.h:
      (WebDOMTestTypedefs):
      * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
      * bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
      (WebCore):
      (WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
      (JSTestSerializedScriptValueInterfacePrototype):
      (JSTestSerializedScriptValueInterfaceConstructor):
      * bindings/scripts/test/JS/JSTestTypedefs.cpp:
      (WebCore):
      * bindings/scripts/test/JS/JSTestTypedefs.h:
      (WebCore):
      * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
      * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
      * bindings/scripts/test/ObjC/DOMTestTypedefs.h:
      * bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
      * bindings/scripts/test/TestSerializedScriptValueInterface.idl:
      * bindings/scripts/test/TestTypedefs.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f462759
    • commit-queue@webkit.org's avatar
      Make optional arguments in CanvasRenderingContext2D match the spec. · 787c90e9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115723
      
      Patch by Dongseong Hwang <dongseong.hwang@intel.com> on 2013-05-08
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      WebKit r98985 set many arguments optional although the canvas spec[1] does not
      indicate. So this patch corrects CanvasRenderingContext2D.idl to match the spec.
      
      [1] http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas/
      
      Covered by existing tests:
        canvas/philip/tests/2d.missingargs.html
        fast/canvas/canvas-overloads-strokeRect.html
        inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html
      
      * html/canvas/CanvasRenderingContext2D.idl:
      
      LayoutTests:
      
      When tests use <canvas> API with not enough arguments, TypeError
      exception is fired now. So three tests are changed to match the canvas
      spec.
      
      * fast/canvas/canvas-overloads-strokeRect-expected.txt:
      * fast/canvas/script-tests/canvas-overloads-strokeRect.js:
      * platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      787c90e9
    • rniwa@webkit.org's avatar
      Remove unused method and de-virtualize others in Element.h · 39395fa9
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115770
      
      Reviewed by Andreas Kling.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/c2c2ff9cb69f46f5cc9d289b2bfbdb8ab5bd3e49
      
      The de-virtualization possibilities were noted whilst "FINALizing" the Node
      hierarchy. If a method is successfully marked FINAL but then fails when marked
      OVERRIDE as well, the method by definition does not need to be virtual.
      
      * WebCore.exp.in:
      * dom/Element.h:
      (WebCore::Element::hasAuthorShadowRoot):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39395fa9
    • darin@apple.com's avatar
      Source/WebCore: Use adoptCF and adoptNS in more places · f00480b5
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115657
      
      Reviewed by Sam Weinig.
      
      This is similar to my last set of changes, but covers code that I missed with
      global replace using the Safari Xcode workspace.
      
      * platform/cf/win/CertificateCFWin.cpp:
      (WebCore::copyCertificateToData):
      * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
      (WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges):
      (WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable):
      (WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
      (WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeLoaded):
      (WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes):
      (WebCore::mimeTypeCache):
      (WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
      (WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged):
      (WebCore::AVFWrapper::createAssetForURL):
      (WebCore::AVFWrapper::createPlayer):
      (WebCore::AVFWrapper::createPlayerItem):
      (WebCore::AVFWrapper::setAsset):
      (WebCore::AVFWrapper::platformLayer):
      (WebCore::AVFWrapper::createAVCFVideoLayer):
      (WebCore::AVFWrapper::createImageGenerator):
      * platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
      (WebCore::InbandTextTrackPrivateLegacyAVFObjC::language):
      * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
      (toCACFTimingFunction):
      (PlatformCAAnimation::PlatformCAAnimation):
      (PlatformCAAnimation::setFromValue):
      (PlatformCAAnimation::setToValue):
      (PlatformCAAnimation::setValues):
      (PlatformCAAnimation::setKeyTimes):
      (PlatformCAAnimation::setTimingFunctions):
      * platform/graphics/ca/win/PlatformCALayerWin.cpp:
      (PlatformCALayer::PlatformCALayer):
      (PlatformCALayer::setBackgroundColor):
      (PlatformCALayer::setBorderColor):
      * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
      (PlatformCALayerWinInternal::PlatformCALayerWinInternal):
      (PlatformCALayerWinInternal::addTile):
      * platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
      (WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost):
      * platform/graphics/gstreamer/PlatformVideoWindowMac.mm:
      (PlatformVideoWindow::PlatformVideoWindow):
      * platform/graphics/win/FontCustomPlatformData.cpp:
      (WebCore::FontCustomPlatformData::fontPlatformData):
      * platform/graphics/win/FontPlatformDataCGWin.cpp:
      (WebCore::getPostScriptName):
      (WebCore::FontPlatformData::platformDataInit):
      * platform/graphics/win/GraphicsContextCGWin.cpp:
      (WebCore::GraphicsContext::drawWindowsBitmap):
      * platform/graphics/win/ImageCGWin.cpp:
      (WebCore::BitmapImage::create):
      * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
      (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
      * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
      (WebCore::MediaPlayerPrivateQuickTimeVisualContext::rfc2616DateStringFromTime):
      (WebCore::QTCFDictionaryCreateWithDataCallback):
      (WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
      * platform/graphics/win/WKCAImageQueue.cpp:
      (WebCore::WKCAImageQueue::WKCAImageQueue):
      * platform/image-decoders/ImageDecoder.h:
      (WebCore::ImageDecoder::qcmsOutputDeviceProfile):
      * platform/network/cf/AuthenticationCF.cpp:
      (WebCore::core):
      * platform/network/cf/CookieJarCFNet.cpp:
      (WebCore::cookieDomain):
      (WebCore::cookieName):
      (WebCore::cookiePath):
      (WebCore::cookieValue):
      (WebCore::filterCookies):
      (WebCore::setCookiesFromDOM):
      (WebCore::cookiesForDOM):
      (WebCore::cookieRequestHeaderFieldValue):
      (WebCore::getRawCookies):
      (WebCore::deleteCookie):
      (WebCore::getHostnamesWithCookies):
      (WebCore::deleteCookiesForHostname):
      * platform/network/curl/ResourceHandleManager.cpp:
      (WebCore::certificatePath):
      * platform/win/ClipboardUtilitiesWin.cpp:
      (WebCore::urlFromPath):
      (WebCore::getURL):
      * platform/win/LocalizedStringsWin.cpp:
      (WebCore::createWebKitBundle):
      (WebCore::localizedString):
      * platform/win/SearchPopupMenuWin.cpp:
      (WebCore::SearchPopupMenuWin::saveRecentSearches):
      (WebCore::SearchPopupMenuWin::loadRecentSearches):
      * plugins/mac/PluginPackageMac.cpp:
      (WebCore::stringListFromResourceId):
      (WebCore::PluginPackage::fetchInfo):
      (WebCore::PluginPackage::load):
      * plugins/mac/PluginViewMac.mm:
      (WebCore::PluginView::platformStart):
      * rendering/RenderThemeSafari.cpp:
      (WebCore::RenderThemeSafari::platformFocusRingColor):
      (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
      (WebCore::RenderThemeSafari::paintSliderTrack):
      Use adoptCF and adoptNS throughout.
      
      Source/WebKit/win: Use adoptCF and adoptNS in more places
      https://bugs.webkit.org/show_bug.cgi?id=115657
      
      Reviewed by Sam Weinig.
      
      This is similar to my last set of changes, but covers code that I missed with
      global replace using the Safari Xcode workspace.
      
      * CFDictionaryPropertyBag.cpp:
      (CFDictionaryPropertyBag::Write):
      * WebCache.cpp:
      (WebCache::statistics):
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
      * WebCoreSupport/WebInspectorClient.cpp:
      (WebInspectorClient::openInspectorFrontend):
      (WebInspectorFrontendClient::localizedStringsURL):
      * WebDatabaseManager.cpp:
      (WebDatabaseManager::dispatchDidModifyDatabase):
      * WebDownloadCFNet.cpp:
      (WebDownload::init):
      (WebDownload::initWithRequest):
      (WebDownload::initToResumeWithBundle):
      (WebDownload::cancelForResume):
      (WebDownload::useCredential):
      (WebDownload::didReceiveAuthenticationChallenge):
      * WebError.cpp:
      (WebError::sslPeerCertificate):
      * WebHistory.cpp:
      (createUserInfoFromArray):
      (createUserInfoFromHistoryItem):
      (WebHistory::WebHistory):
      (WebHistory::loadFromURL):
      (WebHistory::loadHistoryGutsFromURL):
      (WebHistory::saveToURL):
      (WebHistory::saveHistoryGuts):
      (WebHistory::removeAllItems):
      (WebHistory::removeItem):
      (WebHistory::addItem):
      (WebHistory::itemForURL):
      (WebHistory::addItemToDateCaches):
      (getDayBoundaries):
      * WebIconDatabase.cpp:
      (postDidAddIconNotification):
      * WebLocalizableStrings.cpp:
      (cfBundleForStringsBundle):
      * WebMutableURLRequest.cpp:
      (WebMutableURLRequest::mutableCopy):
      * WebPreferences.cpp:
      (cfNumber):
      (WebPreferences::initializeDefaultSettings):
      (WebPreferences::valueForKey):
      (WebPreferences::setStringValue):
      (WebPreferences::load):
      (WebPreferences::migrateWebKitPreferencesToCFPreferences):
      (WebPreferences::setPreferenceForTest):
      * WebView.cpp:
      (WebView::setCacheModel):
      (WebView::notifyPreferencesChanged):
      Use adoptCF and adoptNS.
      
      Source/WebKit2: Use adoptCF and adoptNS in more places
      https://bugs.webkit.org/show_bug.cgi?id=115657
      
      Reviewed by Sam Weinig.
      
      * Shared/Downloads/cfnet/DownloadCFNet.cpp:
      (WebKit::Download::useCredential):
      (WebKit::Download::start):
      (WebKit::Download::startWithHandle):
      (WebKit::Download::cancel):
      (WebKit::Download::didDecideDestination):
      Use adoptCF and adoptNS.
      
      Tools: Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
      https://bugs.webkit.org/show_bug.cgi?id=115657
      
      Reviewed by Sam Weinig.
      
      This is similar to my last set of changes, but covers code that I missed with
      global replace using the Safari Xcode workspace.
      
      * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
      (convertWebResourceDataToString):
      (convertWebResourceResponseToDictionary):
      (createXMLStringFromWebArchiveData):
      * DumpRenderTree/cg/ImageDiffCG.cpp:
      (createImageFromStdin):
      (createDifferenceImage):
      (main):
      * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
      (printPNG):
      (dumpBitmap):
      * DumpRenderTree/cg/PixelDumpSupportCG.h:
      (BitmapContext::BitmapContext):
      * DumpRenderTree/mac/MockWebNotificationProvider.mm:
      (-[MockWebNotificationProvider init]):
      * DumpRenderTree/mac/PixelDumpSupportMac.mm:
      (createBitmapContext):
      * DumpRenderTree/mac/TestRunnerMac.mm:
      (TestRunner::addDisallowedURL):
      (TestRunner::applicationCacheDiskUsageForOrigin):
      (TestRunner::localStorageDiskUsageForOrigin):
      (TestRunner::clearApplicationCacheForOrigin):
      (TestRunner::deleteLocalStorageForOrigin):
      (TestRunner::copyDecodedHostName):
      (TestRunner::copyEncodedHostName):
      (TestRunner::queueLoad):
      (TestRunner::setDomainRelaxationForbiddenForURLScheme):
      (TestRunner::setMockGeolocationPositionUnavailableError):
      (TestRunner::setUserStyleSheetLocation):
      (TestRunner::setValueForUser):
      (TestRunner::overridePreference):
      (TestRunner::setPersistentUserStyleSheetLocation):
      (TestRunner::execCommand):
      (TestRunner::findString):
      (TestRunner::isCommandEnabled):
      (TestRunner::addOriginAccessWhitelistEntry):
      (TestRunner::removeOriginAccessWhitelistEntry):
      (TestRunner::addUserScript):
      (TestRunner::addUserStyleSheet):
      (TestRunner::evaluateInWebInspector):
      (TestRunner::evaluateScriptInIsolatedWorld):
      (TestRunner::apiTestNewWindowDataLoadBaseURL):
      (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
      (TestRunner::authenticateSession):
      (TestRunner::grantWebNotificationPermission):
      (TestRunner::denyWebNotificationPermission):
      * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
      (createCFURLResponseFromResponseData):
      * DumpRenderTree/mac/WorkQueueItemMac.mm:
      (LoadItem::invoke):
      (LoadHTMLStringItem::invoke):
      (ScriptItem::invoke):
      * DumpRenderTree/win/DumpRenderTree.cpp:
      (substringFromIndex):
      (urlSuitableForTestResult):
      (lastPathComponent):
      (sharedCFURLCache):
      * DumpRenderTree/win/ImageDiffCairo.cpp:
      (createImageFromStdin):
      (main):
      * DumpRenderTree/win/PixelDumpSupportWin.cpp:
      (createBitmapContextFromWebView):
      * DumpRenderTree/win/TestRunnerWin.cpp:
      (TestRunner::setUserStyleSheetLocation):
      (TestRunner::setPersistentUserStyleSheetLocation):
      * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
      (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
      * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
      (TestWebKitAPI::createWindow):
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
      (TestWebKitAPI::AcceptsFirstMouse::runTest):
      * TestWebKitAPI/Tests/mac/AttributedString.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/BackForwardList.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
      (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
      * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
      (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
      * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/InspectorBar.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
      (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
      * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
      (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
      * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
      (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
      (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
      * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
      (WTR::testPathFromURL):
      * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
      (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
      * WebKitTestRunner/cg/TestInvocationCG.cpp:
      (WTR::createCGContextFromImage):
      (WTR::dumpBitmap):
      (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
      * WebKitTestRunner/mac/EventSenderProxy.mm:
      (WTR::EventSenderProxy::mouseScrollBy):
      * WebKitTestRunner/mac/PlatformWebViewMac.mm:
      (WTR::PlatformWebView::windowSnapshotImage):
      * WebKitTestRunner/win/TestControllerWin.cpp:
      (WTR::TestController::initializeTestPluginDirectory):
      Use adoptCF and adoptNS.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f00480b5
  3. 07 May, 2013 10 commits
    • benjamin@webkit.org's avatar
      Make CanvasStyle's CMYKAValues allocated on the heap and move the pointer in the union. · 54b4e509
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115764
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-07
      Reviewed by Andreas Kling.
      
      CMYKA input is uncommon enough that we should not pay the price for
      every CanvasStyle.
      Make those values heap allocated and put the pointer in the union. Since
      the RGBA32 values are needed for CMYKA, a RGBA32 value is added to the structure.
      
      * html/canvas/CanvasStyle.cpp:
      (WebCore::CanvasStyle::CanvasStyle):
      (WebCore::CanvasStyle::~CanvasStyle):
      (WebCore::CanvasStyle::isEquivalentColor):
      (WebCore::CanvasStyle::isEquivalentCMYKA):
      (WebCore::CanvasStyle::applyStrokeColor):
      (WebCore::CanvasStyle::applyFillColor):
      * html/canvas/CanvasStyle.h:
      (CanvasStyle):
      (CMYKAValues):
      (WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
      (WebCore::CanvasStyle::color):
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54b4e509
    • darin@apple.com's avatar
      Use OwnPtr instead of deleteAllValues for requests in PluginView · 448297a2
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115731
      
      Reviewed by Sam Weinig.
      
      * plugins/PluginView.cpp:
      (WebCore::PluginView::~PluginView): Removed the call to deleteAllValues.
      (WebCore::PluginView::requestTimerFired): Use release to remove an OwnPtr
      from m_requests rather than an explicit delete. Also use !isEmpty instead
      of size > 0.
      (WebCore::PluginView::scheduleRequest): Changed argument type to PassOwnPtr.
      (WebCore::PluginView::load): Use adoptPtr to call scheduleRequest.
      
      * plugins/PluginView.h: Changed argument type of scheduleRequest to
      PassOwnPtr, and m_requests to a Vector<OwnPtr>.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      448297a2
    • antti@apple.com's avatar
      Remove SelectRuleFeatureSet · d77f33af
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115757
      
      Reviewed by Benjamin Poulain.
      
      This is dead code.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/Element.cpp:
      (WebCore::Element::attributeChanged):
      (WebCore):
      (WebCore::Element::didAffectSelector):
      * dom/Element.h:
      (Element):
      * dom/ElementShadow.h:
      (WebCore::ElementShadow::invalidateDistribution):
      * html/shadow/ContentDistributor.cpp:
      (WebCore::ContentDistributor::ContentDistributor):
      (WebCore):
      * html/shadow/ContentDistributor.h:
      (ContentDistributor):
      * html/shadow/InsertionPoint.cpp:
      (WebCore::InsertionPoint::insertedInto):
      (WebCore::InsertionPoint::removedFrom):
      * html/shadow/InsertionPoint.h:
      (InsertionPoint):
      * html/shadow/SelectRuleFeatureSet.cpp: Removed.
      * html/shadow/SelectRuleFeatureSet.h: Removed.
      * testing/Internals.cpp:
      (WebCore):
      * testing/Internals.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d77f33af
    • andersca@apple.com's avatar
      Store the quotes in the same allocation as the QuotesData object · 0d63a87b
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115768
      
      Reviewed by Andreas Kling.
      
      Since the QuotesData object is immutable we don't need a Vector to store the quote pairs,
      they can just be stored after the class data.
      
      * rendering/style/QuotesData.cpp:
      (WebCore::sizeForQuotesDataWithQuoteCount):
      Helper function for computing the allocation size.
      
      (WebCore::QuotesData::create):
      Use fastMalloc + placement new.
      
      (WebCore::QuotesData::QuotesData):
      Use placement new to allocate the quote pairs.
      
      (WebCore::QuotesData::~QuotesData):
      Destroy the quote pairs.
      
      (WebCore::QuotesData::openQuote):
      Stop using Vector.
      
      (WebCore::QuotesData::closeQuote):
      Ditto.
      
      (WebCore::operator==):
      Ditto.
      
      * rendering/style/QuotesData.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d63a87b
    • benjamin@webkit.org's avatar
      We should not ref() the RefPtr twice in CanvasStyle · e7f0b639
      benjamin@webkit.org authored
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-07
      Reviewed by Darin Adler.
      
      * html/canvas/CanvasStyle.cpp:
      (WebCore::CanvasStyle::CanvasStyle):
      We leak the ref of PassRefPtr, we should not ref() it a second time.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7f0b639
    • rniwa@webkit.org's avatar
      Devirtualize Document class type checking · d18be865
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115755
      
      Reviewed by Benjamin Poulain.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/dae5adc768d5ce6bff301df6515745da8ea24950
      
      Document has a bunch of virtual bool is*Document() methods on it, but it also has
      two bools for XHTML and HTML documents which is silly. We can merge them all
      together into an enum of values and devirtualize the type checking methods.
      
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::createElement):
      * dom/Document.h:
      (WebCore::Document::create):
      (WebCore::Document::createXHTML):
      (WebCore::Document::isHTMLDocument):
      (WebCore::Document::isXHTMLDocument):
      (WebCore::Document::isImageDocument):
      (WebCore::Document::isSVGDocument):
      (WebCore::Document::isPluginDocument):
      (WebCore::Document::isMediaDocument):
      (WebCore::Document):
      * html/HTMLDocument.cpp:
      (WebCore::HTMLDocument::HTMLDocument):
      * html/HTMLDocument.h:
      (WebCore::HTMLDocument):
      * html/ImageDocument.cpp:
      (WebCore::ImageDocument::ImageDocument):
      * html/ImageDocument.h:
      (WebCore::ImageDocument):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocument::MediaDocument):
      * html/MediaDocument.h:
      (WebCore::MediaDocument):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocument::PluginDocument):
      * html/PluginDocument.h:
      (WebCore::PluginDocument):
      * loader/PlaceholderDocument.h:
      (WebCore::PlaceholderDocument::PlaceholderDocument):
      * svg/SVGDocument.cpp:
      (WebCore::SVGDocument::SVGDocument):
      * svg/SVGDocument.h:
      (WebCore::SVGDocument):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d18be865
    • andersca@apple.com's avatar
      Begin unraveling the mess that is QuotesData · ba10727a
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115765
      
      Reviewed by Andreas Kling.
      
      Change QuotesData to be an immutable object and fix other things that are broken.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::applyProperty):
      QuotesData::addPair is gone. Instead, create the Vector up front and pass it to QuotesData.
      
      * rendering/RenderQuote.cpp:
      (WebCore::RenderQuote::originalText):
      Update for renames.
      
      * rendering/style/QuotesData.cpp:
      (WebCore::QuotesData::create):
      Remove the create overload that wasn't used. Add a new create overload that takes a Vector.
      
      (WebCore::QuotesData::openQuote):
      Rename this from getOpenQuote and clean it up.
      
      (WebCore::QuotesData::closeQuote):
      Rename this from getCloseQuote and clean it up.
      
      (WebCore::operator==):
      Replace the equals member function with a proper equality operator.
      
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::diff):
      Stop calling QuotesData::equals. Use the same idiom as used for other properties.
      
      (WebCore::RenderStyle::setQuotes):
      * rendering/style/StyleRareInheritedData.cpp:
      Use operator==.
      
      (WebCore::quotesDataEquivalent):
      Add helper function.
      
      (WebCore::StyleRareInheritedData::operator==):
      Call quotesDataEquivalent.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba10727a
    • enrica@apple.com's avatar
    • benjamin@webkit.org's avatar
      Move CanvasGradient and CanvasPattern in the union of CanvasStyle · 823186b9
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115759
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-07
      Reviewed by Andreas Kling.
      
      The Gradient and Pattern are exclusive with the other values, but they
      were left out of the union because they are ref-counted.
      
      This patch moves them in the union, and simply does the ref-counting manually.
      
      * html/canvas/CanvasStyle.cpp:
      (WebCore::CanvasStyle::CanvasStyle):
      (WebCore::CanvasStyle::~CanvasStyle):
      * html/canvas/CanvasStyle.h:
      (CanvasStyle):
      (WebCore::CanvasStyle::canvasGradient):
      (WebCore::CanvasStyle::canvasPattern):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      823186b9
    • andersca@apple.com's avatar
      Remove custom allocator support from PODArena · 31e74f71
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115762
      
      Reviewed by Andreas Kling.
      
      Nobody uses PODArena with a custom allocator, so just get rid of it and always use fastMalloc/fastFree.
      
      * platform/PODArena.h:
      (WebCore::PODArena::PODArena):
      (WebCore::PODArena::allocateBase):
      (WebCore::PODArena::Chunk::Chunk):
      (WebCore::PODArena::Chunk::~Chunk):
      (Chunk):
      * platform/PODFreeListArena.h:
      (WebCore::PODFreeListArena::allocate):
      (WebCore::PODFreeListArena::FreeListChunk::FreeListChunk):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31e74f71