1. 09 May, 2013 5 commits
    • ch.dumez@sisa.samsung.com's avatar
      Add support for [NoInterfaceObject] Web IDL extended attribute · 077c4e77
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115714
      
      Reviewed by Kentaro Hara.
      
      .:
      
      Update GENERATE_BINDINGS macro to take an additional _window_constructors_file
      optional argument.
      
      * Source/cmake/WebKitMacros.cmake:
      
      Source/WebCore:
      
      *Constructor attributes on the global DOMWindow object are now automatically
      generated for each non-callback interface that is not declared with the
      [NoInterfaceObject] extended attribute. It is thus no longer needed for
      developers to manually add *Constructor attributes for their new interfaces
      unless they wish to register an "extra" constructor for their interface.
      
      This patch does not modify at all the behavior on JS side. To achieve this,
      [NoInterfaceObject] extended attribute is added to interfaces that should
      not have it according to specification (e.g. History, Location, ...).
      This can be improved later as the behavior should not change with this
      patch.
      
      No new tests, no behavior change.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * Modules/battery/BatteryManager.idl:
      * Modules/encryptedmedia/MediaKeyMessageEvent.idl:
      * Modules/encryptedmedia/MediaKeyNeededEvent.idl:
      * Modules/encryptedmedia/MediaKeySession.idl:
      * Modules/encryptedmedia/MediaKeys.idl:
      * Modules/filesystem/DOMFileSystem.idl:
      * Modules/filesystem/DOMFileSystemSync.idl:
      * Modules/filesystem/DirectoryEntry.idl:
      * Modules/filesystem/DirectoryEntrySync.idl:
      * Modules/filesystem/DirectoryReader.idl:
      * Modules/filesystem/DirectoryReaderSync.idl:
      * Modules/filesystem/Entry.idl:
      * Modules/filesystem/EntryArray.idl:
      * Modules/filesystem/EntryArraySync.idl:
      * Modules/filesystem/EntrySync.idl:
      * Modules/filesystem/FileEntry.idl:
      * Modules/filesystem/FileEntrySync.idl:
      * Modules/filesystem/FileWriter.idl:
      * Modules/filesystem/FileWriterSync.idl:
      * Modules/filesystem/Metadata.idl:
      * Modules/gamepad/Gamepad.idl:
      * Modules/gamepad/GamepadList.idl:
      * Modules/geolocation/Coordinates.idl:
      * Modules/geolocation/Geolocation.idl:
      * Modules/geolocation/Geoposition.idl:
      * Modules/geolocation/PositionError.idl:
      * Modules/indexeddb/DOMWindowIndexedDatabase.idl:
      * Modules/indexeddb/IDBAny.idl:
      * Modules/mediasource/MediaSource.idl:
      * Modules/mediasource/SourceBuffer.idl:
      * Modules/mediasource/SourceBufferList.idl:
      * Modules/mediastream/DOMWindowMediaStream.idl: Removed.
      * Modules/mediastream/MediaStream.idl:
      * Modules/mediastream/MediaStreamTrack.idl:
      * Modules/mediastream/MediaStreamTrackEvent.idl:
      * Modules/mediastream/NavigatorUserMediaError.idl:
      * Modules/mediastream/RTCDTMFSender.idl:
      * Modules/mediastream/RTCDTMFToneChangeEvent.idl:
      * Modules/mediastream/RTCDataChannel.idl:
      * Modules/mediastream/RTCDataChannelEvent.idl:
      * Modules/mediastream/RTCIceCandidateEvent.idl:
      * Modules/mediastream/RTCPeerConnection.idl:
      * Modules/mediastream/RTCStatsReport.idl:
      * Modules/mediastream/RTCStatsResponse.idl:
      * Modules/networkinfo/NetworkInfoConnection.idl:
      * Modules/notifications/DOMWindowNotifications.idl:
      * Modules/notifications/NotificationCenter.idl:
      * Modules/quota/StorageInfo.idl:
      * Modules/quota/StorageQuota.idl:
      * Modules/speech/DOMWindowSpeech.idl: Removed.
      * Modules/speech/DOMWindowSpeechSynthesis.idl:
      * Modules/speech/SpeechGrammar.idl:
      * Modules/speech/SpeechGrammarList.idl:
      * Modules/speech/SpeechRecognition.idl:
      * Modules/speech/SpeechRecognitionAlternative.idl:
      * Modules/speech/SpeechRecognitionError.idl:
      * Modules/speech/SpeechRecognitionEvent.idl:
      * Modules/speech/SpeechRecognitionResult.idl:
      * Modules/speech/SpeechRecognitionResultList.idl:
      * Modules/speech/SpeechSynthesis.idl:
      * Modules/speech/SpeechSynthesisVoice.idl:
      * Modules/webaudio/AnalyserNode.idl:
      * Modules/webaudio/AudioBuffer.idl:
      * Modules/webaudio/AudioBufferSourceNode.idl:
      * Modules/webaudio/AudioContext.idl:
      * Modules/webaudio/AudioDestinationNode.idl:
      * Modules/webaudio/AudioListener.idl:
      * Modules/webaudio/AudioNode.idl:
      * Modules/webaudio/AudioParam.idl:
      * Modules/webaudio/AudioSourceNode.idl:
      * Modules/webaudio/BiquadFilterNode.idl:
      * Modules/webaudio/ChannelMergerNode.idl:
      * Modules/webaudio/ChannelSplitterNode.idl:
      * Modules/webaudio/ConvolverNode.idl:
      * Modules/webaudio/DOMWindowWebAudio.idl: Removed.
      * Modules/webaudio/DelayNode.idl:
      * Modules/webaudio/DynamicsCompressorNode.idl:
      * Modules/webaudio/GainNode.idl:
      * Modules/webaudio/MediaElementAudioSourceNode.idl:
      * Modules/webaudio/MediaStreamAudioDestinationNode.idl:
      * Modules/webaudio/MediaStreamAudioSourceNode.idl:
      * Modules/webaudio/OfflineAudioContext.idl:
      * Modules/webaudio/OscillatorNode.idl:
      * Modules/webaudio/PannerNode.idl:
      * Modules/webaudio/ScriptProcessorNode.idl:
      * Modules/webaudio/WaveShaperNode.idl:
      * Modules/webaudio/WaveTable.idl:
      * Modules/webdatabase/DOMWindowWebDatabase.idl:
      * Modules/webdatabase/Database.idl:
      * Modules/webdatabase/DatabaseSync.idl:
      * Modules/webdatabase/SQLError.idl:
      * Modules/webdatabase/SQLResultSet.idl:
      * Modules/webdatabase/SQLResultSetRowList.idl:
      * Modules/webdatabase/SQLTransaction.idl:
      * Modules/webdatabase/SQLTransactionSync.idl:
      * Modules/websockets/DOMWindowWebSocket.idl: Removed.
      * Modules/websockets/WebSocket.idl:
      * PlatformBlackBerry.cmake:
      * UseJSC.cmake:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/scripts/IDLAttributes.txt:
      * bindings/scripts/IDLParser.pm:
      (parseTypedef):
      * bindings/scripts/preprocess-idls.pl:
      (GenerateConstructorAttribute):
      (getFileContents):
      (getPartialInterfaceNameFromIDL):
      (isCallbackInterfaceFromIDL):
      (trim):
      (getInterfaceExtendedAttributesFromIDL):
      * css/CSSFontFaceLoadEvent.idl:
      * css/CSSFontFaceRule.idl:
      * css/CSSSupportsRule.idl:
      * css/CSSUnknownRule.idl:
      * css/DOMWindowCSS.idl:
      * css/FontLoader.idl:
      * css/MediaQueryList.idl:
      * css/MediaQueryListListener.idl:
      * css/StyleMedia.idl:
      * dom/CustomElementConstructor.idl:
      * dom/DOMError.idl:
      * dom/DOMNamedFlowCollection.idl:
      * dom/DataTransferItem.idl:
      * dom/DataTransferItemList.idl:
      * dom/EventListener.idl:
      * dom/EventTarget.idl:
      * dom/NodeIterator.idl:
      * dom/ShadowRoot.idl:
      * dom/TreeWalker.idl:
      * dom/WebKitNamedFlow.idl:
      * fileapi/FileException.idl:
      * fileapi/FileReaderSync.idl:
      * html/HTMLAudioElement.idl:
      * html/HTMLDetailsElement.idl:
      * html/HTMLOptionElement.idl:
      * html/MediaError.idl:
      * html/MediaKeyError.idl:
      * html/MicroDataItemValue.idl:
      * html/RadioNodeList.idl:
      * html/ValidityState.idl:
      * html/canvas/CanvasRenderingContext.idl:
      * html/canvas/DOMPath.idl:
      * html/canvas/EXTDrawBuffers.idl:
      * html/canvas/EXTTextureFilterAnisotropic.idl:
      * html/canvas/OESElementIndexUint.idl:
      * html/canvas/OESStandardDerivatives.idl:
      * html/canvas/OESTextureFloat.idl:
      * html/canvas/OESTextureHalfFloat.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/WebGLCompressedTextureATC.idl:
      * html/canvas/WebGLCompressedTexturePVRTC.idl:
      * html/canvas/WebGLCompressedTextureS3TC.idl:
      * html/canvas/WebGLContextAttributes.idl:
      * html/canvas/WebGLDebugRendererInfo.idl:
      * html/canvas/WebGLDebugShaders.idl:
      * html/canvas/WebGLDepthTexture.idl:
      * html/canvas/WebGLLoseContext.idl:
      * html/canvas/WebGLVertexArrayObjectOES.idl:
      * html/track/AudioTrack.idl:
      * html/track/AudioTrackList.idl:
      * html/track/TextTrackRegionList.idl:
      * html/track/VideoTrack.idl:
      * html/track/VideoTrackList.idl:
      * inspector/InjectedScriptHost.idl:
      * inspector/InspectorFrontendHost.idl:
      * inspector/JavaScriptCallFrame.idl:
      * inspector/ScriptProfile.idl:
      * inspector/ScriptProfileNode.idl:
      * loader/appcache/DOMApplicationCache.idl:
      * page/AbstractView.idl:
      * page/BarInfo.idl:
      * page/Console.idl:
      * page/Crypto.idl:
      * page/DOMSecurityPolicy.idl:
      * page/DOMWindow.idl:
      * page/History.idl:
      * page/Location.idl:
      * page/MemoryInfo.idl:
      * page/Navigator.idl:
      * page/PagePopupController.idl:
      * page/Performance.idl:
      * page/PerformanceEntry.idl:
      * page/PerformanceEntryList.idl:
      * page/PerformanceMark.idl:
      * page/PerformanceMeasure.idl:
      * page/PerformanceNavigation.idl:
      * page/PerformanceResourceTiming.idl:
      * page/PerformanceTiming.idl:
      * page/Screen.idl:
      * page/SpeechInputResult.idl:
      * page/SpeechInputResultList.idl:
      * page/WorkerNavigator.idl:
      * page/make_settings.pl:
      (generateInternalSettingsIdlFile):
      * svg/ElementTimeControl.idl:
      * svg/SVGAnimationElement.idl:
      * svg/SVGExternalResourcesRequired.idl:
      * svg/SVGFilterPrimitiveStandardAttributes.idl:
      * svg/SVGFitToViewBox.idl:
      * svg/SVGLangSpace.idl:
      * svg/SVGLocatable.idl:
      * svg/SVGStyledElement.idl:
      * svg/SVGTests.idl:
      * svg/SVGTransformable.idl:
      * svg/SVGURIReference.idl:
      * testing/InternalSettings.idl:
      * testing/Internals.idl:
      * testing/MallocStatistics.idl:
      * testing/TypeConversions.idl:
      * workers/AbstractWorker.idl:
      * workers/DedicatedWorkerContext.idl:
      * workers/SharedWorker.idl:
      * workers/SharedWorkerContext.idl:
      * workers/WorkerContext.idl:
      * workers/WorkerLocation.idl:
      * xml/XPathExpression.idl:
      * xml/XPathNSResolver.idl:
      
      Tools:
      
      Update BindingsTests.generate_supplemental_dependency() to pass an
      additional windowConstructorsFile argument to preprocess-idls.pl.
      
      * Scripts/webkitpy/bindings/main.py:
      (BindingsTests.generate_supplemental_dependency):
      (BindingsTests.main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      077c4e77
    • commit-queue@webkit.org's avatar
      [GTK][AC] Buildfix after r149694 · 5802dccc
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115797
      
      Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-05-09
      Reviewed by Gustavo Noronha Silva.
      
      Source/WebCore:
      
      Some interfaces, such as a return value and parameters of functions are changed.
      
      No new tests since no functionality changed.
      
      * platform/graphics/clutter/GraphicsLayerClutter.cpp:
      (WebCore::animationHasStepsTimingFunction):
      (WebCore::GraphicsLayerClutter::timingFunctionForAnimationValue):
      (WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
      (WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
      (WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
      (WebCore::GraphicsLayerClutter::setAnimationEndpoints):
      (WebCore::GraphicsLayerClutter::setAnimationKeyframes):
      * platform/graphics/clutter/GraphicsLayerClutter.h:
      (GraphicsLayerClutter):
      
      Tools:
      
      Add CLUTTER_LIBS for linking TestWebCore.
      
      * TestWebKitAPI/GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5802dccc
    • commit-queue@webkit.org's avatar
      Fix some compiler warnings (miscellaneous) · f116f0e4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80790
      
      Patch by Rob Buis <rbuis@rim.com> on 2013-05-08
      Reviewed by Brent Fulgham.
      
      Get rid of the following warning for BlackBerry:
      
      NavigatorContentUtils.cpp:60:78: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      
      by not compiling any of the code to add protocols to the protocol whitelist.
      
      * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
      (WebCore::initProtocolHandlerWhitelist):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f116f0e4
    • commit-queue@webkit.org's avatar
      [Windows] The function seekFile() is not implemented. · 554c4caa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115246
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-05-08
      Reviewed by Brent Fulgham.
      
      Implemented seekFile() function for Windows.
      
      * platform/win/FileSystemWin.cpp:
      (WebCore::seekFile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      554c4caa
    • commit-queue@webkit.org's avatar
      Web Inspector: Fix a typo in Settings.js · 65771b50
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115849
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-08
      Reviewed by Joseph Pecoraro.
      
      No new tests, no behavior change.
      
      * inspector/front-end/Settings.js:
      (WebInspector.Settings):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65771b50
  2. 08 May, 2013 35 commits
    • rniwa@webkit.org's avatar
      SecurityOrigin doesn’t need to forward declare or include Document · 16042552
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115847
      
      Reviewed by Alexey Proskuryakov.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/fc7a88caa9c41f3471d8994a530643e5225f82fc.
      
      Removed unused Document forward declaration+include from SecurityOrigin.
      
      * page/SecurityOrigin.cpp:
      * page/SecurityOrigin.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16042552
    • gyuyoung.kim@samsung.com's avatar
      [EFL] Remove unnecessary pkgs in EFL jhbuild · ad890d75
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114908
      
      Reviewed by Laszlo Gombos.
      
      p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
      handle them using jhbuild. We can reduce build time when using --update-efl.
      
      * efl/jhbuild.modules:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad890d75
    • ddkilzer@apple.com's avatar
      BUILD FIX: Don't use adoptCF() with NSDictionary * object · 9ba121f5
      ddkilzer@apple.com authored
      Fixes the following build failure:
      
          In file included from Source/WebCore/platform/network/mac/ResourceErrorMac.mm:27:
          In file included from Source/WebCore/platform/network/cf/ResourceError.h:31:
          /usr/local/include/wtf/RetainPtr.h:81:13: error: static_assert failed "Don't use adoptCF with Objective-C pointer types, use adoptNS."
                      static_assert(!std::is_convertible<T, id>::value, "Don't use adoptCF with Objective-C pointer types, use adoptNS.");
                      ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          /usr/local/include/wtf/RetainPtr.h:274:16: note: in instantiation of member function 'WTF::RetainPtr<NSDictionary *>::RetainPtr' requested here
                  return RetainPtr<T>(AdoptCF, o);
                         ^
          Source/WebCore/platform/network/mac/ResourceErrorMac.mm:214:44: note: in instantiation of function template specialization 'WTF::adoptCF<NSDictionary *>' requested here
                  RetainPtr<NSDictionary> userInfo = adoptCF((NSDictionary *) CFErrorCopyUserInfo(error));
                                                     ^
          1 error generated.
      
      * platform/network/mac/ResourceErrorMac.mm:
      (WebCore::ResourceError::nsError): Switch from adoptCF() to
      adoptNS().  This is in USE(CFNETWORK) code, so it's not
      exercised on the Mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ba121f5
    • lforschler@apple.com's avatar
      Versioning. · eaa06c70
      lforschler@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaa06c70
    • commit-queue@webkit.org's avatar
      [EFL] Disable SHADOW DOM feature in FeatureList.pm · ca41670e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115834
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-08
      Reviewed by Gyuyoung Kim.
      
      * Scripts/webkitperl/FeatureList.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca41670e
    • rniwa@webkit.org's avatar
      Remove Editor::setSelectionOffsets · 730528a4
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115831
      
      Reviewed by Andreas Kling.
      
      Removed the function added in r120985 for Chromium Android port.
      
      * editing/Editor.cpp:
      * editing/Editor.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      730528a4
    • andersca@apple.com's avatar
      Fix a typo in a comment. · df30fd07
      andersca@apple.com authored
      Rubber-stamped by Darin Adler.
      
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeConnection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df30fd07
    • andersca@apple.com's avatar
      Remove bogus StorageAreaMap assertions · 38c4ae4f
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115838
      
      Reviewed by Sam Weinig.
      
      It is possible for didGetValues, and didClear to be called even if m_hasPendingClear is false so remove the assertions.
      
      * WebProcess/Storage/StorageAreaMap.cpp:
      (WebKit::StorageAreaMap::didGetValues):
      (WebKit::StorageAreaMap::didClear):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38c4ae4f
    • commit-queue@webkit.org's avatar
      [EFL] Get rid of duplicate entry line in TestExpectations · 6e173d29
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115828
      
      Unreviewed gardening.
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-08
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e173d29
    • andersca@apple.com's avatar
      Handle incoming clear operations · c5bc07e5
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115829
      
      Reviewed by Sam Weinig.
      
      Handle clear by building up a new storage map with our pending changes.
      
      * WebProcess/Storage/StorageAreaMap.cpp:
      (WebKit::StorageAreaMap::applyChange):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5bc07e5
    • rniwa@webkit.org's avatar
      Potential use-after-free of Frame · 6385f35f
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115774
      
      Reviewed by Simon Fraser.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/c5b4a6db82e8280c7fc55ee3dc3a84c6b026e66e.
      
      * page/Frame.cpp:
      (WebCore::Frame::setPrinting):
      (WebCore::Frame::setPageAndTextZoomFactors):
      (WebCore::Frame::deviceOrPageScaleFactorChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6385f35f
    • roger_fong@apple.com's avatar
      Unreviewed build fix, AppleWin port. · 8dfa4a97
      roger_fong@apple.com authored
      * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
      * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
      (WebCore::MediaPlayerPrivateAVFoundation::seek):
      (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
      (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
      (WebCore):
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
      (MediaPlayerPrivateAVFoundation):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dfa4a97
    • xingnan.wang@intel.com's avatar
      Heap-use-after-free in WebCore::AudioNodeOutput::pull · dc262021
      xingnan.wang@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111362
      
      Reviewed by Chris Rogers.
      
      * Modules/webaudio/AudioBuffer.cpp:
      (WebCore::AudioBuffer::createFromAudioFileData):
      * Modules/webaudio/AudioNodeInput.cpp:
      (WebCore::AudioNodeInput::AudioNodeInput):
      (WebCore::AudioNodeInput::updateInternalBus):
      * Modules/webaudio/AudioNodeInput.h:
      (AudioNodeInput):
      * Modules/webaudio/AudioNodeOutput.cpp:
      (WebCore::AudioNodeOutput::AudioNodeOutput):
      (WebCore::AudioNodeOutput::updateInternalBus):
      (WebCore::AudioNodeOutput::pull):
      (WebCore::AudioNodeOutput::bus):
      * Modules/webaudio/AudioNodeOutput.h:
      (AudioNodeOutput):
      * Modules/webaudio/OfflineAudioDestinationNode.cpp:
      (WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
      * Modules/webaudio/OfflineAudioDestinationNode.h:
      (OfflineAudioDestinationNode):
      * platform/audio/AudioBus.cpp:
      (WebCore::AudioBus::createBufferFromRange):
      (WebCore::AudioBus::createBySampleRateConverting):
      (WebCore::AudioBus::createByMixingToMono):
      * platform/audio/AudioBus.h:
      (AudioBus):
      * platform/audio/AudioFileReader.h:
      (WebCore):
      * platform/audio/AudioResampler.cpp:
      (WebCore::AudioResampler::AudioResampler):
      (WebCore::AudioResampler::configureChannels):
      * platform/audio/AudioResampler.h:
      (AudioResampler):
      * platform/audio/HRTFElevation.cpp:
      (WebCore::getConcatenatedImpulseResponsesForSubject):
      (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
      * platform/audio/MultiChannelResampler.cpp:
      * platform/audio/Reverb.cpp:
      (WebCore::Reverb::initialize):
      * platform/audio/Reverb.h:
      (Reverb):
      * platform/audio/efl/AudioBusEfl.cpp:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
      (AudioFileReader):
      (WebCore::AudioFileReader::createBus):
      (WebCore::createBusFromAudioFile):
      (WebCore::createBusFromInMemoryAudioFile):
      * platform/audio/gtk/AudioBusGtk.cpp:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/audio/mac/AudioBusMac.mm:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/audio/mac/AudioFileReaderMac.cpp:
      (WebCore::AudioFileReader::createBus):
      (WebCore::createBusFromAudioFile):
      (WebCore::createBusFromInMemoryAudioFile):
      * platform/audio/mac/AudioFileReaderMac.h:
      (AudioFileReader):
      * platform/audio/qt/AudioBusQt.cpp:
      (WebCore::AudioBus::loadPlatformResource):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc262021
    • andersca@apple.com's avatar
      Don't apply changes while we're clearing the database · a661e440
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115826
      
      Reviewed by Darin Adler.
      
      * UIProcess/Storage/LocalStorageDatabase.cpp:
      (WebKit::LocalStorageDatabase::openDatabase):
      Only call didOpenDatabaseWithOrigin if we actually did open the database.
      
      (WebKit::LocalStorageDatabase::updateDatabaseWithChangedItems):
      Create the database if needed.
      
      * UIProcess/Storage/StorageManager.cpp:
      (WebKit::StorageManager::getValues):
      Send back a DidGetValues message.
      
      * WebProcess/Storage/StorageAreaMap.cpp:
      (WebKit::StorageAreaMap::StorageAreaMap):
      Initialize m_hasPendingClear.
      
      (WebKit::StorageAreaMap::clear):
      Set m_hasPendingClear to true.
      
      (WebKit::StorageAreaMap::resetValues):
      Set m_hasPendingClear back to false.
      
      (WebKit::StorageAreaMap::loadValuesIfNeeded):
      Set m_hasPendingClear to true so we'll ignore any changes that are already part of the returned items.
      
      (WebKit::StorageAreaMap::didGetValues):
      Set m_hasPendingClear back to false.
      
      (WebKit::StorageAreaMap::didClear):
      Set m_hasPendingClear back to false.
      
      (WebKit::StorageAreaMap::applyChange):
      Don't apply the change if m_hasPendingClear is true.
      
      * WebProcess/Storage/StorageAreaMap.messages.in:
      Add DidGetValues message.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a661e440
    • lforschler@apple.com's avatar
      Add Scheduler for Mac MtnLion 32bit Release builder. · ea5ccf03
      lforschler@apple.com authored
              
      Unreviewed.
              
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea5ccf03
    • commit-queue@webkit.org's avatar
      Update JSCIdentifier pretty printer in Tools/gdb/webkit.py · 2f04738f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115808
      
      Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-05-08
      Reviewed by Darin Adler.
      
      The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
      was left outdated after r127191, when the m_string member was changed
      from UString to String. This patch calls the right pretty printer for it.
      
      * gdb/webkit.py:
      (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
      WTFImplPrettyPrinter.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f04738f
    • aestes@apple.com's avatar
      [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to... · 4fa77596
      aestes@apple.com authored
      [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
      https://bugs.webkit.org/show_bug.cgi?id=115790
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebKit2:
      
      NSMutableSet does not support adding or removing nil objects, and
      WTF::HashSet does not support adding, removing, or checking for null
      WTF::Strings.
      
      For the NSMutableSet case, make sure that we don't try to add or remove
      nil NSStrings.
      
      For the WTF::HashSet case, NSURL will return a nil NSString if we ask
      it for its scheme when it is invalid, which we will convert to a null
      WTF::String. Don't try to check if our HashSet of registered schemes
      contains a null String.
      
      * Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
      (WebKit::CustomProtocolManager::registerScheme): Assert that the scheme
      isn't null. We reject null schemes at the WKBrowsingContextController level.
      (WebKit::CustomProtocolManager::unregisterScheme): Ditto.
      (WebKit::CustomProtocolManager::supportsScheme): If scheme is null, return false.
      * UIProcess/API/mac/WKBrowsingContextController.mm:
      (+[WKBrowsingContextController registerSchemeForCustomProtocol:]): Do not register a nil scheme.
      (+[WKBrowsingContextController unregisterSchemeForCustomProtocol:]): Ditto.
      
      Tools:
      
      Added two API tests:
      
      1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
      2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
      (TestWebKitAPI):
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
      (TestWebKitAPI):
      (TestWebKitAPI::decidePolicyForNavigationAction):
      (CustomProtocolInvalidSchemeTest):
      (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fa77596
    • lforschler@apple.com's avatar
      Teach buildbot how to compile 32-bit on Mac. · 0dc2c8c0
      lforschler@apple.com authored
      Reviewed by Ryosuke Niwa.
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      (CompileWebKit.start):
      (ExtractTestResultsAndLeaks):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dc2c8c0
    • andersca@apple.com's avatar
      Apply remote changes to storage maps locally · a57ff209
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115825
      
      Reviewed by Beth Dakin.
      
      * WebProcess/Storage/StorageAreaMap.cpp:
      (WebKit::StorageAreaMap::resetValues):
      Clear the pending values map.
      
      (WebKit::StorageAreaMap::didSetItem):
      If we failed to set the item, forget everything we know about this storage map.
      Otherwise, remove the pending item.
      
      (WebKit::StorageAreaMap::didRemoveItem):
      Remove the pending item.
      
      (WebKit::StorageAreaMap::shouldApplyChangeForKey):
      Helper function that returns whether a change for a given key should be applied.
      
      (WebKit::StorageAreaMap::applyChange):
      Apply the change. Currently only adds and removes are handled.
      
      (WebKit::StorageAreaMap::dispatchStorageEvent):
      Apply the change locally as well if needed.
      
      * WebProcess/Storage/StorageAreaMap.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a57ff209
    • roger_fong@apple.com's avatar
      Update WebKitLibraries/win to handle different architectures properly. · f75482ab
      roger_fong@apple.com authored
      * win/lib32: Copied from win/lib.
      * win/tools/WinTools.make:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f75482ab
    • mikhail.pozdnyakov@intel.com's avatar
      Simplify RetainPtrObjectHashTraits · 54d14ed6
      mikhail.pozdnyakov@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115822
      
      Reviewed by Benjamin Poulain.
      
      RetainPtrObjectHashTraits is inherited from SimpleClassHashTraits
      instead of GenericHashTraits re-using more shared functionality.
      
      * wtf/RetainPtr.h:
      (WTF::RetainPtrObjectHashTraits::emptyValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54d14ed6
    • commit-queue@webkit.org's avatar
      [BlackBerry] Fix usage of BlackBerry::Platform::String · e7e3b6c9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115781
      
      Patch by Eli Fidler <efidler@blackberry.com> on 2013-05-08
      Reviewed by Rob Buis.
      
      BlackBerry PRs 304193 and 327181
      Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
      
      We currently have a problem where we're passing UTF-8 encoded data into
      the char* constructors of BlackBerry::Platform::String. This means the string
      thinks its data is not UTF-8.
      
      Source/WebCore:
      
      * platform/blackberry/ClipboardBlackBerry.cpp:
      (WebCore::ClipboardBlackBerry::setData):
      (WebCore::ClipboardBlackBerry::writeURL):
      (WebCore::ClipboardBlackBerry::writePlainText):
      * platform/blackberry/CookieManager.cpp:
      (WebCore::CookieManager::getRawCookies):
      (WebCore::CookieManager::getBackingStoreCookies):
      * platform/blackberry/CookieParser.cpp:
      (WebCore::CookieParser::CookieParser):
      (WebCore::CookieParser::parseOneCookie):
      * platform/blackberry/CursorBlackBerry.cpp:
      (WebCore::Cursor::Cursor):
      * platform/blackberry/PlatformBlob.cpp:
      (WebCore::PlatformBlob::nextDataItem):
      * platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
      (WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
      (WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):
      * platform/graphics/blackberry/ImageBlackBerry.cpp:
      (WebCore::Image::loadPlatformResource):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::MediaPlayerPrivate::load):
      (WebCore::MediaPlayerPrivate::notifyChallengeResult):
      (WebCore::toWebMediaStreamSource):
      (WebCore::toWebMediaStreamDescriptor):
      * platform/network/blackberry/NetworkManager.cpp:
      (WebCore::NetworkManager::startJob):
      * platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
      (WebCore::SocketStreamHandle::SocketStreamHandle):
      * platform/network/blackberry/rss/RSSFilterStream.cpp:
      (WebCore::RSSFilterStream::notifyStatusReceived):
      (WebCore::RSSFilterStream::notifyHeadersReceived):
      (WebCore::RSSFilterStream::convertContentToHtml):
      (WebCore::RSSFilterStream::charset):
      (WebCore::RSSFilterStream::removeHeader):
      (WebCore::RSSFilterStream::updateHeader):
      (WebCore::RSSFilterStream::updateRSSHeaders):
      * platform/network/blackberry/rss/RSSFilterStream.h:
      * platform/text/blackberry/StringBlackBerry.cpp:
      (WTF::String::operator BlackBerry::Platform::String):
      
      Source/WebKit/blackberry:
      
      * Api/JavaScriptVariant.cpp:
      (BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
      * Api/WebKitTextCodec.cpp:
      (BlackBerry::WebKit::base64Encode):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPage::loadFile):
      (BlackBerry::WebKit::WebPage::textEncoding):
      (BlackBerry::WebKit::WebPage::textHasAttribute):
      (BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
      * Api/WebPage.h:
      * Api/WebSettings.cpp:
      (BlackBerry::WebKit::WebSettings::standardSettings):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
      * WebKitSupport/DefaultTapHighlight.cpp:
      (WebKit):
      (BlackBerry::WebKit::DefaultTapHighlight::draw):
      (BlackBerry::WebKit::DefaultTapHighlight::hide):
      
      Tools:
      
      * DumpRenderTree/blackberry/DumpRenderTree.cpp:
      (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
      (BlackBerry::WebKit::dumpHistoryItem):
      * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
      (TestRunner::setUserStyleSheetLocation):
      * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
      (LoadHTMLStringItem::invoke):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7e3b6c9
    • andersca@apple.com's avatar
      Assert at compile time that we don't pass Objective-C object pointers to adoptCF · a9882265
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115823
      
      Reviewed by Geoffrey Garen.
      
      Source/WebCore:
      
      * platform/graphics/ca/mac/TileController.mm:
      (WebCore::TileController::TileController):
      Use adoptNS for CALayer.
      
      Source/WebKit2:
      
      Fix adoptNS/adoptCF mismatches. For the adopt(leakRef()) case we'd ideally want a static_pointer_cast overload for RetainPtr,
      but this will do for now.
      
      * Shared/mac/ArgumentCodersMac.mm:
      (CoreIPC::decode):
      
      Source/WTF:
      
      static_assert in adoptCF that the object passed in is not an Objective-C object.
      * wtf/RetainPtr.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9882265
    • commit-queue@webkit.org's avatar
      Tools: add new BlackBerry include dirs. · b4e3c8c3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115514
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-08
      Reviewed by Rob Buis.
      
      iType include dirs are missing, and HarfBuzz needs to be fixed.
      
      * Scripts/webkitdirs.pm:
      (blackberryCMakeArguments):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4e3c8c3
    • eric.carlson@apple.com's avatar
      TextTrackCue should support empty content · 9967e55e
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115821
      
      Reviewed by Jer Noble.
      
      Source/WebCore:
      
      Test: media/track/track-cue-empty-text-crash.html
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlTextTrackContainerElement::updateDisplay): Don't bother trying to render
          cues with no content.
      
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCue::getCueAsHTML): Return early if there isn't a node tree.
      (WebCore::TextTrackCue::createCueRenderingTree): Ditto.
      (WebCore::TextTrackCue::determineTextDirection): Ditto.
      (WebCore::TextTrackCue::updateDisplayTree): Return early if there isn't a cue rendering tree.
      
      LayoutTests:
      
      * media/track/track-cue-empty-text-crash-expected.txt: Added.
      * media/track/track-cue-empty-text-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9967e55e
    • weinig@apple.com's avatar
      Add SPI to determine if a plugin is sandboxed · 26fc34ac
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115810
      
      Reviewed by Anders Carlsson.
      
      * PluginProcess/mac/PluginProcessMac.mm:
      (WebKit::PluginProcess::initializeSandbox):
      * Shared/Plugins/mac/PluginSandboxProfile.h: Added.
      * Shared/Plugins/mac/PluginSandboxProfile.mm: Added.
      (WebKit::pluginSandboxProfileDefaultDirectory):
      (WebKit::pluginSandboxProfileDirectories):
      (WebKit::pluginSandboxProfileName):
      (WebKit::pluginSandboxCommonProfile):
      (WebKit::pluginSandboxProfileForDirectory):
      (WebKit::pluginSandboxProfile):
      (WebKit::pluginHasSandboxProfileForDirectory):
      (WebKit::pluginHasSandboxProfile):
      Move sandbox code to its own file and refactor to use cocoa. Also adds pluginHasSandboxProfile function
      which uses the newly refactored code.
      
      * UIProcess/API/C/mac/WKContextPrivateMac.h:
      * UIProcess/API/C/mac/WKContextPrivateMac.mm:
      (WKPlugInInfoIsSandboxedKey):
      (createInfoDictionary):
      Add WKPlugInInfoIsSandboxedKey.
      
      * WebKit2.xcodeproj/project.pbxproj:
      Add new files.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26fc34ac
    • roger_fong@apple.com's avatar
      Unreviewed AppleWin build fix. · ca5848fe
      roger_fong@apple.com authored
      * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
      (MediaPlayerPrivateAVFoundationCF):
      (WebCore::MediaPlayerPrivateAVFoundationCF::currentTrack):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca5848fe
    • rwlbuis@webkit.org's avatar
      Fix some compiler warnings (miscellaneous) · 8e613d4a
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80790
      
      Patch by Rob Buis <rbuis@rim.com> on 2013-05-08
      Reviewed by Philip Rogers.
      
      Get rid of the following warning for BlackBerry:
      
      BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]
      
      by using ASSERT_UNUSED instead of ASSERT.
      
      * WebKitSupport/BackingStoreClient.cpp:
      (BlackBerry::WebKit::BackingStoreClient::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e613d4a
    • andersca@apple.com's avatar
      Safari unexpectedly quits with invalid message from the web process with... · 7740b7b1
      andersca@apple.com authored
      Safari unexpectedly quits with invalid message from the web process with message ID 0x323002f (WebPageProxy.DecidePolicyForNavigationAction)
      https://bugs.webkit.org/show_bug.cgi?id=115814
      <rdar://problem/12331258>
      
      Reviewed by Andreas Kling.
      
      To ensure that any asynchronous messages are delivered to the UI process before
      synchronous messages (except when doing so would lead to a deadlock), Call
      setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage on the UI process connections.
      
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeConnection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7740b7b1
    • timothy_horton@apple.com's avatar
      Coalesce WKView visibleRect changes · 7f8b2660
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115792
      <rdar://problem/13776842>
      
      Reviewed by Simon Fraser.
      
      The system can call renewGState much more often than we actually want
      to update the WebProcess' notion of the exposed rect. Most importantly,
      within an autolayout pass it is called many times, and often sees
      [WKView visibleRect] be an intermediate value which will never be
      flushed to the screen. We only care about the final value, so we should
      wait until AppKit has finished - with a zero-delay timer - to inform the
      WebProcess of exposed rect changes.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy):
      Add exposedRectChangedTimer.
      (WebKit::WebPageProxy::close):
      Cancel exposedRectChangedTimer when tearing down the WebPageProxy.
      * UIProcess/WebPageProxy.h:
      (WebPageProxy):
      Add exposedRectChangedTimerFired, the timer itself, and two rects:
      the most recent exposed rect from the WKView, and the last one we actually
      sent across to the WebProcess.
      * UIProcess/mac/WebPageProxyMac.mm:
      (WebKit::WebPageProxy::viewExposedRectChanged):
      Instead of immediately sending exposed rect changes to the WebProcess,
      start a zero-delay timer to do so.
      (WebKit::WebPageProxy::exposedRectChangedTimerFired):
      Once the zero-delay timer fires, send the new exposed rect to the WebProcess.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f8b2660
    • andersca@apple.com's avatar
      Remove RetainPtr::adoptNS and RetainPtr::adoptCF · bdb9ac05
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115817
      
      Reviewed by Jessie Berlin.
      
      These functions are now unused so remove them. The preferred way to create a RetainPtr with an
      adopted reference is to use the adoptNS/adoptCF free functions.
      
      Rewrite the move assignment operators to just call CFRelease explicitly.
      
      * wtf/RetainPtr.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdb9ac05
    • zandobersek@gmail.com's avatar
      [GTK] Plumb the Automake build system for the Battery Status API feature · 90142ec9
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115718
      
      Reviewed by Martin Robinson.
      
      .: 
      
      * Source/autotools/FindDependencies.m4: Check for the upower-glib dependency if the feature is enabled.
      * Source/autotools/PrintBuildConfiguration.m4: Print out the feature status.
      * Source/autotools/ReadCommandLineArguments.m4: Check for the --enable-battery-status option. The deafult,
      when the option is not given, is to disable the feature.
      * Source/autotools/SetupWebKitFeatures.m4: Treat the ENABLE_BATTERY_STATUS define as configurable.
      * Source/autotools/symbols.filter: Export a couple of symbols that are used in the WebCore internals library.
      
      Source/WebCore: 
      
      No new tests - no new functionality. The feature is not enabled yet, though all the relevant tests
      pass when it is.
      
      * GNUmakefile.am: Add the Modules/battery directory to the list of search paths for header inclusions.
      Include the same directory under the IDL_PATH variable so the IDL files it contains are processed.
      List these IDL files using a wildcard under the EXTRA_DIST list.
      * GNUmakefile.list.am: Add the build targets for the module source files, IDLs and resulting JS bindings.
      * bindings/gobject/GNUmakefile.am: Add the build targets for the GObject DOM bindings.
      
      Tools: 
      
      * Scripts/webkitdirs.pm:
      (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
      through the --(enable|disable)-battery-status flag passed to configure.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90142ec9
    • ch.dumez@sisa.samsung.com's avatar
      Add layout test that lists all global constructors · b8bcf05d
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115724
      
      Reviewed by Ryosuke Niwa.
      
      Update fast/js/global-constructors-attributes.html so that it lists all
      global constructors instead of just a few.
      
      * fast/js/global-constructors-attributes-expected.txt:
      * fast/js/script-tests/global-constructors-attributes.js:
      (classNameForObject):
      (constructorPropertiesOnWindow):
      * platform/efl/fast/js/global-constructors-attributes-expected.txt: Added.
      * platform/gtk/fast/js/global-constructors-attributes-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8bcf05d
    • rniwa@webkit.org's avatar
      new-run-webkit-websocketserver doesn't work after Chromium removal · f068d3eb
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115816
      
      Reviewed by Joseph Pecoraro.
      
      Fix the bug by instantiating the correct port object.
      
      * Scripts/new-run-webkit-websocketserver:
      (main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f068d3eb
    • roger_fong@apple.com's avatar
      Unreviewed gardening, mac port. · 83d12ea6
      roger_fong@apple.com authored
      These tests should use testRunner, not layoutTestController.
      
      * fast/js/parse-error-external-script-in-eval.html:
      * fast/js/parse-error-external-script-in-new-Function.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83d12ea6