1. 26 Mar, 2008 27 commits
    • aroben@apple.com's avatar
      Turn on SVG animation on Windows · 06d35b9b
      aroben@apple.com authored
      JavaScriptCore:
      
              Force JSC headers to be copied by touching a file
      
              * kjs/array_instance.cpp:
              (KJS::ArrayInstance::getPropertyNames):
      
      WebCore:
      
              Turn on SVG animation on Windows
      
              Also touched some files to force things to rebuild/regenerate.
      
              * WebCore.vcproj/WebCore.vcproj: Added ENABLE_SVG_ANIMATION.
              * WebCore.vcproj/build-generated-files.sh: Ditto.
              * bindings/scripts/CodeGenerator.pm: Touched.
              * config.h: Touched.
              * svg/svgtags.in: Touched.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06d35b9b
    • justin.garcia@apple.com's avatar
      2008-03-26 Justin Garcia <justin.garcia@apple.com> · 1651e0fd
      justin.garcia@apple.com authored
              Reviewed by Harrison.
      
              <rdar://problem/5820749> REGRESSION (Safari 3.1): Mail's plain text reply omits blank line following the attribution
      
              * editing/markup.cpp:
              (WebCore::createFragmentFromText): When asked to create a fragment from "Attribution:\n"
              with a context from [html, 0] to [html, 0], we'd return "<html>Attribution</html><br>".
              Don't enclose paragraphs in clones of the context's enclosing block if that block is the
              html or body element.  Currently no way to test [DOMHTMLElement createFragmentFromText:].
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1651e0fd
    • aroben@apple.com's avatar
      Windows build fix after r31324 · cb9eeb2a
      aroben@apple.com authored
              Written with Darin.
      
              Added HashTable plumbing to support using wchar_t as a key type.
      
              * wtf/HashFunctions.h:
              * wtf/HashTraits.h:
              (WTF::):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb9eeb2a
    • antti@apple.com's avatar
      WebCore: · fbcbde35
      antti@apple.com authored
      2008-03-26  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Anders.
      
              http://bugs.webkit.org/show_bug.cgi?id=17077
              Bug 17077: SVG SMIL animation is currently broken (and turned off) (affects Acid3 tests 75 and 76)
      
              - enable SVG animation support.
              - basic implementation of beginElement()/endElement().
              
              Animation definitely will need more work than this, but it is a start!
      
              * Configurations/WebCore.xcconfig:
              * svg/SVGAnimationElement.cpp:
              (WebCore::SVGAnimationElement::SVGAnimationElement):
              (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
              (WebCore::SVGAnimationElement::beginElement):
              (WebCore::SVGAnimationElement::beginElementAt):
              (WebCore::SVGAnimationElement::endElement):
              (WebCore::SVGAnimationElement::endElementAt):
              * svg/SVGAnimationElement.h:
      
      WebKitTools:
      
      2008-03-26  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Anders.
              
              Enable SVG animation support by default.
      
              * Scripts/build-webkit:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbcbde35
    • mrowe@apple.com's avatar
      2008-03-26 Mark Rowe <mrowe@apple.com> · d7769da6
      mrowe@apple.com authored
              Reviewed by David Hyatt.
      
              Make the Ahem font antialias correctly on Acid3 on Tiger.
      
              * WebCore.Tiger.exp:
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformInit):
              * platform/mac/WebCoreSystemInterface.h:
              * platform/mac/WebCoreSystemInterface.mm:
      
      2008-03-26  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by David Hyatt.
      
              Make the Ahem font antialias correctly on Acid3 on Tiger.
      
              * WebKitSystemInterface.h:
              * libWebKitSystemInterfaceTiger.a:
      
      2008-03-26  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by David Hyatt.
      
              Make the Ahem font antialias correctly on Acid3 on Tiger.
      
              * WebCoreSupport/WebSystemInterface.m:
              (InitWebCoreSystemInterface):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7769da6
    • hausmann@webkit.org's avatar
      Attempt to fix the Qt build. · 156edb0e
      hausmann@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      156edb0e
    • slewis@apple.com's avatar
      2008-03-26 Stephanie Lewis <slewis@apple.com> · 7559dd88
      slewis@apple.com authored
              Not Reviewed.
      
              Move storage tests to Skipped list since they hang 80% of the time.  See <rdar://problem/5787763>.
      
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7559dd88
    • mitz@apple.com's avatar
      2008-03-26 Dan Bernstein <mitz@apple.com> · eb9c42cd
      mitz@apple.com authored
              Reviewed by Anders Carlsson.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=18104
                REGRESSION: LEAK: 2 InlineBox in editing/inserting/12882.html
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::layoutInlineChildren): When deciding to ditch
              old clean lines (due to changed or newly-added floats), keep the
              reference to those lines so they can be properly deleted in the end,
              and use a separate flag to signal that no matching should be attempted.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb9c42cd
    • mrowe@apple.com's avatar
      Speculative Windows build fix. · 1e7711b6
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e7711b6
    • sfalken@apple.com's avatar
      2008-03-25 Steve Falkenburg <sfalken@apple.com> · a42313d9
      sfalken@apple.com authored
              Turn on link-time-codegen in html and rendering related files.
      
              Reviewed by Oliver.
      
              * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a42313d9
    • mjs@apple.com's avatar
      2008-03-26 Maciej Stachowiak <mjs@apple.com> · 4e520749
      mjs@apple.com authored
              Reviewed by Darin.
      
              - JSC part of fix for "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
              http://bugs.webkit.org/show_bug.cgi?id=18118
      
              * wtf/HashFunctions.h:
              (WTF::):
              * wtf/HashTraits.h:
              (WTF::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e520749
    • mjs@apple.com's avatar
      WebCore: · 8e6b6191
      mjs@apple.com authored
      2008-03-26  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Darin.
      
              - fixed "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
              http://bugs.webkit.org/show_bug.cgi?id=18118
      
              * svg/SVGFont.cpp:
              (WebCore::SVGTextRunWalker::walk):
              * svg/SVGFontElement.cpp:
              (WebCore::SVGFontElement::SVGFontElement):
              (WebCore::SVGFontElement::addGlyphToCache):
              (WebCore::SVGFontElement::removeGlyphFromCache):
              (WebCore::SVGFontElement::ensureGlyphCache):
              (WebCore::SVGFontElement::getGlyphIdentifiersForString):
              * svg/SVGFontElement.h:
              * svg/SVGGlyphElement.h:
              (WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier):
              * svg/SVGGlyphMap.h: Added. New radix tree based glyph map.
              (WebCore::GlyphMapNode::GlyphMapNode):
              (WebCore::SVGGlyphMap::SVGGlyphMap):
              (WebCore::SVGGlyphMap::add):
              (WebCore::SVGGlyphMap::compareGlyphPriority):
              (WebCore::SVGGlyphMap::get):
              (WebCore::SVGGlyphMap::clear):
      
      LayoutTests:
      
      2008-03-26  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Darin.
      
              - test updates for "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
              http://bugs.webkit.org/show_bug.cgi?id=18118
      
              These test cases were already checking for this exact bug and now
              render correctly.
              
              * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e6b6191
    • hyatt@apple.com's avatar
      2008-03-26 David Hyatt <hyatt@apple.com> · 24ce0f2c
      hyatt@apple.com authored
              Fix build bustage on Tiger.  Tiger will not have the bug fix.
      
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              (WebCore::SimpleFontData::platformInit):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24ce0f2c
    • hyatt@apple.com's avatar
      2008-03-26 David Hyatt <hyatt@apple.com> · 78fa91f5
      hyatt@apple.com authored
              Make the Ahem font antialias correctly on Acid3.
      
              Reviewed by Dan
      
              * platform/graphics/SimpleFontData.h:
              * platform/graphics/mac/FontMac.mm:
              (WebCore::Font::drawGlyphs):
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/win/FontCGWin.cpp:
              (WebCore::Font::drawGlyphs):
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              (WebCore::SimpleFontData::platformInit):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78fa91f5
    • mrowe@apple.com's avatar
      Fix the Mac build. · cafd671f
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cafd671f
    • aroben@apple.com's avatar
      Fix Bug 17768: REGRESSION (r30146): Inspector no longer shows elements properties · 00a4d765
      aroben@apple.com authored
              <http://bugs.webkit.org/show_bug.cgi?id=17768>
      
              We were throwing an exception from Object.describe because of some
              undefined variables.
      
              Reviewed by Tim Hatcher.
      
              * page/inspector/utilities.js:
              (Object.describe): Reinstate the type1 and type2 variables that were
              removed in r30146. They're still used when formatting a function.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00a4d765
    • ap@webkit.org's avatar
      Reviewed by Darin. · d2923466
      ap@webkit.org authored
              Cache C string identifiers by address, not value, assuming that C strings can only
              be literals.
      
              1% speedup on Acid3 test 26.
      
              * kjs/identifier.cpp:
              (KJS::literalIdentifierTable):
              (KJS::Identifier::add):
              Added a new table to cache UString::Reps created from C strings by address. Elements are
              never removed from this cache, as only predefined identifiers can get there.
      
              * kjs/identifier.h:
              (KJS::Identifier::Identifier): Added a warning.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2923466
    • ap@webkit.org's avatar
      Rubber-stamped by Maciej. · eb0f0519
      ap@webkit.org authored
              An assertion was failing in function-toString-object-literals.html when parsing 1e-500.
              The condition existed before, and got uncovered by turning compiled-out dtoa checks into
              ASSERTs.
      
              The assertion was verifying that the caller wasn't constructing a Bigint from 0.
              This might have had some reason behind it originally, but I couldn't find any,
              and this doesn't look like a reasonable requirement.
      
              * kjs/dtoa.cpp: (d2b): Removed the assertion (two copies in different code paths).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb0f0519
    • eric@webkit.org's avatar
      Reviewed by darin. · d163494e
      eric@webkit.org authored
              Forgot to add braces darin asked for during review.
      
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::write):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d163494e
    • eric@webkit.org's avatar
      Reviewed by darin. · 4f9b2dd1
      eric@webkit.org authored
              Fix, makes us pass Test 70
              XML documents should be strict about encoding checks
              http://bugs.webkit.org/show_bug.cgi?id=17079
      
              Test: fast/encoding/invalid-xml.html
      
              * WebCore.base.exp:
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::write):
              * loader/CachedFont.cpp:
              (WebCore::CachedFont::ensureSVGFontData):
              * loader/TextResourceDecoder.cpp:
              (WebCore::TextResourceDecoder::TextResourceDecoder):
              (WebCore::TextResourceDecoder::decode):
              * loader/TextResourceDecoder.h:
              * platform/text/TextCodec.h:
              (WebCore::TextCodec::decode):
              * platform/text/TextCodecICU.cpp:
              (WebCore::TextCodecICU::decodeToBuffer):
              (WebCore::ErrorCallbackSetter::ErrorCallbackSetter):
              (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter):
              (WebCore::TextCodecICU::decode):
              * platform/text/TextCodecICU.h:
              * platform/text/TextCodecLatin1.cpp:
              * platform/text/TextCodecLatin1.h:
              * platform/text/TextCodecUTF16.cpp:
              * platform/text/TextCodecUTF16.h:
              * platform/text/TextCodecUserDefined.cpp:
              * platform/text/TextCodecUserDefined.h:
              * platform/text/TextDecoder.cpp:
              (WebCore::TextDecoder::checkForBOM):
              * platform/text/TextDecoder.h:
              (WebCore::TextDecoder::decode):
              * platform/text/TextEncoding.cpp:
              (WebCore::TextEncoding::decode):
              * platform/text/TextEncoding.h:
              (WebCore::TextEncoding::decode):
              * platform/text/mac/TextCodecMac.cpp:
              (WebCore::TextCodecMac::decode):
              * platform/text/mac/TextCodecMac.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f9b2dd1
    • antti@apple.com's avatar
      2008-03-26 Antti Koivisto <antti@apple.com> · 40701cbd
      antti@apple.com authored
              Reviewed by Adam.
      
              Add ElementTimeControl interface to SVGAnimationElement.
              Passes Acid3 test 75.
      
              * DerivedSources.make:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/scripts/CodeGeneratorObjC.pm:
              * svg/ElementTimeControl.h: Added.
              (WebCore::ElementTimeControl::~ElementTimeControl):
              * svg/ElementTimeControl.idl: Added.
              * svg/SVGAnimationElement.cpp:
              (WebCore::SVGAnimationElement::beginElement):
              (WebCore::SVGAnimationElement::beginElementAt):
              (WebCore::SVGAnimationElement::endElement):
              (WebCore::SVGAnimationElement::endElementAt):
              * svg/SVGAnimationElement.h:
              * svg/SVGAnimationElement.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40701cbd
    • kmccullough@apple.com's avatar
      2008-03-26 Kevin McCullough <kmccullough@apple.com> · 76e8c5cb
      kmccullough@apple.com authored
              - LayoutTest fix.  Null check.
      
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::send):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76e8c5cb
    • mitz@apple.com's avatar
      WebCore: · e3b1771f
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17994
                REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
              - fix http://bugs.webkit.org/show_bug.cgi?id=18063
                REGRESSION (r31250): Small bug that just cropped up in WebKit r31275
      
              Tests: fast/repaint/subtree-root-clip.html
                     fast/repaint/subtree-root-clip-2.html
                     fast/repaint/subtree-root-clip-3.html
      
              * rendering/LayoutState.cpp:
              (WebCore::LayoutState::LayoutState): Changed to not set an initial clip.
              Since the root is clipping, there is no need to set a clip, and setting
              the clip based on the container was wrong because often the root was
              not included in the container's overflow rect because it had its own
              layer.
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::absolutePosition): Removed code that added table
              cell's extra top offset only in the slow (recursive) code path.
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::absolutePosition): Added code to add the
              extra top offset in both code paths.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - tests for http://bugs.webkit.org/show_bug.cgi?id=17994
                REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
              - and http://bugs.webkit.org/show_bug.cgi?id=18063
                REGRESSION (r31250): Small bug that just cropped up in WebKit r31275
      
              * fast/repaint/subtree-root-clip-2.html: Added.
              * fast/repaint/subtree-root-clip-3.html: Added.
              * fast/repaint/subtree-root-clip.html: Added.
              * platform/mac/fast/repaint/subtree-root-clip-2-expected.checksum: Added.
              * platform/mac/fast/repaint/subtree-root-clip-2-expected.png: Added.
              * platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Added.
              * platform/mac/fast/repaint/subtree-root-clip-3-expected.checksum: Added.
              * platform/mac/fast/repaint/subtree-root-clip-3-expected.png: Added.
              * platform/mac/fast/repaint/subtree-root-clip-3-expected.txt: Added.
              * platform/mac/fast/repaint/subtree-root-clip-expected.checksum: Added.
              * platform/mac/fast/repaint/subtree-root-clip-expected.png: Added.
              * platform/mac/fast/repaint/subtree-root-clip-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3b1771f
    • hausmann@webkit.org's avatar
      Fix the Qt build. · 8729d052
      hausmann@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8729d052
    • mjs@apple.com's avatar
      Fixed reviewer in WebCore/ChangeLog and LayoutTests/ChangeLog · 95f24856
      mjs@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95f24856
    • mjs@apple.com's avatar
      WebCore: · 4c5f4478
      mjs@apple.com authored
      2008-03-24  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Maciej.
      
              - fixed "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs"
              http://bugs.webkit.org/show_bug.cgi?id=18046
      
              * platform/graphics/Font.cpp:
              (WebCore::Font::floatWidth): Allow expressing a run that has extra "context" characters beyond the end,
              and reporting of how many characters were actually consumed, to support multichar glyphs in SVG fonts.
              * platform/graphics/Font.h:
              * rendering/SVGInlineTextBox.cpp:
              (WebCore::SVGInlineTextBox::calculateGlyphWidth): Pass along extra chars in argument and chars consumed out
              argument.
              (WebCore::SVGInlineTextBox::calculateGlyphHeight): Pass along extra chars in argument.
              (WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Add boilerplate; may not handle multichar glyphs
              right but I don't know what effects this would have.
              * rendering/SVGInlineTextBox.h:
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::cummulatedWidthOrHeightOfTextChunk): Add boilerplate; may not handle multichar glyphs right
              but again I am not sure what effect this would have.
              (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): Account for multichar glyphs - let glyph
              selection consider extra chars, and account for the fact that a glyph may have consumed multiple chars.
              * rendering/SVGRootInlineBox.h:
              * svg/SVGFont.cpp:
              (WebCore::SVGTextRunWalker::walk): This is the place where glyph selection happens, so this is where
              we accout for multichar glyphs (both looking at extra chars past the end of the run, and reporting how
              many chars were consumed).
              (WebCore::floatWidthOfSubStringUsingSVGFont): Pass aforementioned info through the layers.
              (WebCore::Font::floatWidthUsingSVGFont): ditto
              (WebCore::Font::drawTextUsingSVGFont): ditto
              (WebCore::Font::selectionRectForTextUsingSVGFont): ditto
              * svg/SVGTextContentElement.cpp:
              (WebCore::cummulatedCharacterRangeLength): ditto
              (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): ditto
      
      LayoutTests:
      
      2008-03-24  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Maciej.
      
              - test case and new results for "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs"
              http://bugs.webkit.org/show_bug.cgi?id=18046
      
              * svg/text/multichar-glyph.svg: Added. New test case for both rendering and getStartPositionOfChar
              access of multichar glyphs.
              * platform/mac/svg/text/multichar-glyph-expected.txt: Added.
      
              The following test results changed, all appear to be improvements.
              
              * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
              * platform/mac/svg/text/text-altglyph-01-b-expected.txt:
              * platform/mac/svg/text/text-text-06-t-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c5f4478
    • bdakin@apple.com's avatar
      WebCore: · 2d15955c
      bdakin@apple.com authored
      2008-03-25  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Oliver.
      
              Fix for <rdar://problem/5811826> CSSValueList::item() does not 
              range-check index
      
              Check bounds before accessing the item to avoid a crash. 
              itemWithoutBoundsCheck() is still inlined and not bounds-checked to 
              avoid slowing down our internal callers of item().
              * css/CSSValueList.cpp:
              (WebCore::CSSValueList::item):
              * css/CSSValueList.h:
              (WebCore::CSSValueList::itemWithoutBoundsCheck):
      
              Call itemWithoutBoundsCheck() to avoid slowing down these internal 
              callers.
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::addFontFaceRule):
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
              * css/CSSStyleSelector.cpp:
              (WebCore::applyCounterList):
              (WebCore::CSSStyleSelector::applyProperty):
              * css/MediaQueryEvaluator.cpp:
              (WebCore::parseAspectRatio):
              * svg/SVGFontFaceElement.cpp:
              (WebCore::SVGFontFaceElement::rebuildFontFace):
              * svg/graphics/SVGPaintServer.cpp:
              (WebCore::dashArrayFromRenderingStyle):
      
      LayoutTests:
      
      2008-03-25  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Oliver.
      
              Test for <rdar://problem/5811826> CSSValueList::item() does not 
              range-check index
      
              * fast/css/resources/bikes.bmp: Added.
              * fast/css/value-list-out-of-bounds-crash.html: Added.
              * platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum: Added.
              * platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
              * platform/mac/fast/css/value-list-out-of-bounds-crash-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d15955c
  2. 25 Mar, 2008 13 commits