1. 28 Sep, 2009 20 commits
    • hausmann@webkit.org's avatar
      [Qt] Implement XSLT support with QtXmlPatterns. · 06b7e555
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28303
      
      Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
      Reviewed by Simon Hausmann.
      
      JavaScriptCore:
      
      * wtf/Platform.h: Add a WTF_USE_QXMLQUERY #define.
      
      WebCore:
      
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCoreSources.bkl:
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::~Document):
      (WebCore::Document::setTransformSource):
      * dom/Document.h:
      (WebCore::Document::transformSource):
      * dom/TransformSource.h: Added.
      (WebCore::TransformSource::platformSource):
      * dom/TransformSourceLibxslt.cpp: Added.
      (WebCore::TransformSource::TransformSource): Wraps a libxml2 document.
      (WebCore::TransformSource::~TransformSource):
      * dom/TransformSourceQt.cpp: Added.
      (WebCore::TransformSource::TransformSource): Wraps a plain string.
      (WebCore::TransformSource::~TransformSource):
      * dom/XMLTokenizerLibxml2.cpp:
      (WebCore::XMLTokenizer::doEnd):
      * dom/XMLTokenizerQt.cpp:
      (WebCore::XMLTokenizer::doEnd):
      (WebCore::XMLTokenizer::parseProcessingInstruction):
      * xml/XSLStyleSheet.h:
      (WebCore::XSLStyleSheet::sheetString):
      * xml/XSLStyleSheetLibxslt.cpp:
      (WebCore::XSLStyleSheet::document):
      * xml/XSLStyleSheetQt.cpp: Added.
      * xml/XSLTProcessor.h:
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::xmlDocPtrFromNode):
      * xml/XSLTProcessorQt.cpp: Added.
      (WebCore::XSLTMessageHandler::XSLTMessageHandler): A subclass of QAbstractMessageHandler.
      (WebCore::XSLTMessageHandler::handleMessage): Forwards all processor messages to the Console.
      (WebCore::XSLTProcessor::transformToString): Uses QXmlQuery.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06b7e555
    • eric@webkit.org's avatar
      2009-09-28 Yongjun Zhang <yongjun.zhang@nokia.com> · f1a58635
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=28054
      
              Use derefInNotNull() to work around winscw compiler forward declaration bug
              regarding templated classes.
      
              The compiler bug is reported at
              https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.
      
              The change should be reverted when the above bug is fixed in winscw compiler.
      
              Add parenthesis around (RefPtr::*UnspecifiedBoolType) to make winscw compiler
              work with the default UnSpecifiedBoolType() operator, which removes the winscw hack.
      
              * wtf/RefPtr.h:
              (WTF::RefPtr::~RefPtr):
              (WTF::RefPtr::clear):
              (WTF::RefPtr::operator UnspecifiedBoolType):
      2009-09-28  Yongjun Zhang  <yongjun.zhang@nokia.com>
      
              Reviewed by Eric Seidel.
      
              Make JObjectWrapper::ref() and deref() public accessible to derefIfNull().
      
              Will be reverted when the following winscw compiler bug is fixed.
              https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812
      
              * bridge/jni/jni_instance.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1a58635
    • hausmann@webkit.org's avatar
      Remove __clear_cache which is an internal function of GCC · ce6c608e
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28886
      
      Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-09-28
      Reviewed by Simon Hausmann.
      
      Although __clear_cache is exported from GCC, this is an internal
      function. GCC makes no promises about it.
      
      * jit/ExecutableAllocator.h:
      (JSC::ExecutableAllocator::cacheFlush):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce6c608e
    • eric@webkit.org's avatar
      2009-09-28 Shinichiro Hamaji <hamaji@chromium.org> · 59443ae6
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Move message-port-multi.js from resources to script-tests
              https://bugs.webkit.org/show_bug.cgi?id=29798
      
              * fast/events/message-port-multi-expected.txt:
              * fast/events/message-port-multi.html:
              * fast/events/resources/message-port-multi.js: Removed.
              * fast/events/script-tests/message-port-multi.js: Added.
              (channel.port2.onmessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59443ae6
    • eric@webkit.org's avatar
      2009-09-28 Andrew Scherkus <scherkus@chromium.org> · 65ab9de1
      eric@webkit.org authored
              Reviewed by Eric Carlson.
      
              Delegate implementation of rendererIsNeeded() for media control elements to RenderTheme.
      
              https://bugs.webkit.org/show_bug.cgi?id=28689
      
              Covered by LayoutTests/media/video-no-audio.html
      
              * rendering/MediaControlElements.cpp: Removed subclass implementations of rendererIsNeeded().
              (WebCore::MediaControlElement::rendererIsNeeded): Include calling shouldRenderMediaControlPart().
              (WebCore::MediaControlInputElement::rendererIsNeeded): Include calling shouldRenderMediaControlPart().
              * rendering/MediaControlElements.h:
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::shouldRenderMediaControlPart): New method.  Contains logic moved from subclass implementations of rendererIsNeeded().
              * rendering/RenderTheme.h:
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Override to always render mute button.
              * rendering/RenderThemeChromiumSkia.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65ab9de1
    • jianli@chromium.org's avatar
      [chromium] DragData::asURL should return file URL. · 08568b5a
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=29109
      
      Reviewed by David Levin.
      
      Tested by LayoutTests/fast/events/drag-to-navigate.html.
      
      * platform/FileSystem.h:
      * platform/chromium/ChromiumBridge.h:
      * platform/chromium/DragDataChromium.cpp:
      (WebCore::DragData::asURL):
      * platform/chromium/FileSystemChromium.cpp:
      (WebCore::getAbsolutePath):
      (WebCore::isDirectory):
      (WebCore::filePathToURL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08568b5a
    • dglazkov@chromium.org's avatar
      2009-09-28 Dimitri Glazkov <dglazkov@chromium.org> · dbc15cc1
      dglazkov@chromium.org authored
              Reviewed by David Levin.
      
              [V8] Add a special case to handle index arguments, because we need to be
              able to see if they're < 0.
              https://bugs.webkit.org/show_bug.cgi?id=29810
      
              Test: LayoutTests/dom/html/level1/core/hc_characterdataindexsizeerrdeletedatacountnegative.html
      
              * bindings/scripts/CodeGeneratorV8.pm: Added special case (matching CodeGeneratorJS.pm)
                for index arguments.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbc15cc1
    • weinig@apple.com's avatar
      Fix an absolute path to somewhere in Oliver's machine to a relative path · 635d20da
      weinig@apple.com authored
      for derived JSONObject.lut.h.
      
      Reviewed by Oliver Hunt.
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      635d20da
    • mitz@apple.com's avatar
      Extend the MediaWiki/KHTMLFixes.css workaround to cover older MediaWiki versions · 9545758d
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29792
      
      Reviewed by Darin Adler.
      
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::setCSSStyleSheet): If site specific hacks are
      enabled, check if the linked style sheet is one of two versions of the
      MediaWiki KHTMLFixes.css. If so, remove the offending rule.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9545758d
    • dglazkov@chromium.org's avatar
      2009-09-28 Dimitri Glazkov <dglazkov@chromium.org> · 20b9693e
      dglazkov@chromium.org authored
              Reviewed by Adam Barth.
      
              [V8] Fix an error in type logic in CodeGeneratorV8.pm, where
              unsigned ints are accidentally used as signed.
              https://bugs.webkit.org/show_bug.cgi?id=29810
      
              Test: LayoutTests/fast/forms/textarea-maxlength.html
      
              * bindings/scripts/CodeGeneratorV8.pm: Made sure "unsigned long" in IDL is
                properly generates on "unsigned" return value.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20b9693e
    • simon.fraser@apple.com's avatar
      2009-09-25 Simon Fraser <simon.fraser@apple.com> · dcacba1e
      simon.fraser@apple.com authored
              Reviewed by Darin Adler.
      
              ASSERTION FAILED: !repaintContainer || repaintContainer == this
              https://bugs.webkit.org/show_bug.cgi?id=29755
      
              It's possible for RenderObject::container() to return an object that is higher
              in the hierarchy than the repaintContainer that is being used to repaint an
              object. For example, this can happen when running an accelerated opacity
              transition on an element with a position:absolute parent, and a position:absolute child.
      
              In this case we need to detect when RenderObject::container() will skip over
              repaintContainer, and in that case adjust the coords to shift into repaintContainer's space.
      
              Test: compositing/repaint/opacity-between-absolute.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::mapLocalToContainer):
              (WebCore::RenderBox::computeRectForRepaint):
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::computeRectForRepaint):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::container):
              * rendering/RenderObject.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcacba1e
    • hausmann@webkit.org's avatar
      Rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp. · 4d535766
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28303
      
      Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
      Reviewed by Simon Hausmann.
      
      In preparation for adding XSLT support with QtXmlPatterns to the Qt
      port, rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp as we will
      have our own implementation which most likely will not share any code
      with the current one.
      
      Additionally, fix some coding style issues.
      
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * WebCoreSources.bkl:
      * xml/XSLStyleSheet.cpp: Renamed to XSLStyleSheetLibxslt.cpp.
      * xml/XSLStyleSheetLibxslt.cpp: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d535766
    • hausmann@webkit.org's avatar
      Prospective build fix for r48812. · af34fe77
      hausmann@webkit.org authored
      Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-28
      Forgot to remove the inline reset() implementation when reverting the indentation
      changes in the file.
      
      * xml/XSLTProcessor.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af34fe77
    • pfeldman@chromium.org's avatar
      2009-09-28 Pavel Feldman <pfeldman@chromium.org> · 68ec544c
      pfeldman@chromium.org authored
              Reviewed by nobody (trivial follow up fix), Joseph Pecoraro LGTM-ed.
      
              Web Inspector: Follow up to r48809.
              InspectorController.wrapObject should only be called on the inspectable page side.
      
              https://bugs.webkit.org/show_bug.cgi?id=17429
      
              * inspector/front-end/EventListenersSidebarPane.js:
              (WebInspector.EventListenersSidebarPane.prototype.update.callback):
              (WebInspector.EventListenersSidebarPane.prototype.update):
              (WebInspector.EventListenersSection):
              (WebInspector.EventListenersSection.prototype.update):
              (WebInspector.EventListenerBar):
              (WebInspector.EventListenerBar.prototype.update):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68ec544c
    • hausmann@webkit.org's avatar
      Move the libxslt specific part of XSLTProcessor to a separate file. · 34a3f963
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28303
      
      Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
      Reviewed by Simon Hausmann.
      
      In preparation for adding XSLT support with QtXmlPatterns to the Qt
      port, move the libxslt part of the XSLTProcessor implementation into
      another file and leave the part that can be reused and shared.
      
      Additionally, fix some coding style issues.
      
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * WebCoreSources.bkl:
      * xml/XSLTProcessor.cpp:
      (WebCore::XSLTProcessor::createDocumentFromSource): Remove trailing whitespaces.
      (WebCore::createFragmentFromSource): Remove trailing whitespaces.
      (WebCore::XSLTProcessor::transformToFragment): Remove trailing whitespaces.
      (WebCore::XSLTProcessor::reset): Moved out of the class definition.
      * xml/XSLTProcessorLibxslt.cpp: Added.
      (WebCore::XSLTProcessor::genericErrorFunc): Moved.
      (WebCore::XSLTProcessor::parseErrorFunc): Moved.
      (WebCore::docLoaderFunc): Moved.
      (WebCore::setXSLTLoadCallBack): Moved.
      (WebCore::writeToVector): Moved.
      (WebCore::saveResultToString): Moved.
      (WebCore::xsltParamArrayFromParameterMap): Moved.
      (WebCore::freeXsltParamArray): Moved.
      (WebCore::xsltStylesheetPointer): Moved.
      (WebCore::xmlDocPtrFromNode): Moved.
      (WebCore::resultMIMEType): Moved.
      (WebCore::XSLTProcessor::transformToString): Moved.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34a3f963
    • staikos@webkit.org's avatar
      Minor correction to Copyright notice. Not reviewed. · 3ed36f52
      staikos@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ed36f52
    • eric@webkit.org's avatar
      2009-09-28 Charles Wei <charles.wei@torchmobile.com.cn> · 31958da0
      eric@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              Fix the crash of SVG that crashes when use a non-exist symbol
              https://bugs.webkit.org/show_bug.cgi?id=27693
      
              * svg/custom/use-non-existing-symbol-crash-expected.txt: Added.
              * svg/custom/use-non-existing-symbol-crash.svg: Added.
      2009-09-28  Charles Wei  <charles.wei@torchmobile.com.cn>
      
              Reviewed by Nikolas Zimmermann.
      
              Fix the crash of SVG that crashes when use a non-exist symbol
              https://bugs.webkit.org/show_bug.cgi?id=27693
      
              Test: svg/custom/use-non-existing-symbol-crash.svg
      
              * svg/SVGUseElement.cpp:
              (WebCore::shadowTreeContainsChangedNodes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31958da0
    • pfeldman@chromium.org's avatar
      2009-09-28 Joseph Pecoraro <joepeck@webkit.org> · a5c785e8
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Inspector Should Show Event Listeners/Handlers Registered on each Node
              https://bugs.webkit.org/show_bug.cgi?id=17429
              
                Extracted a method from dispatchEvent to get the event ancestor chain
              
              * dom/Node.cpp:
              (WebCore::Node::eventAncestors): the extracted method
              (WebCore::Node::dispatchGenericEvent): use eventAncestors
              * dom/Node.h:
      
                Asynchronous Flow For the Inspector, Backend -> DOM Agent -> Frontend
                The DOMAgent's getEventListenersForNode handles the logic of finding
                all the relevant listeners in the event flow.
      
              * inspector/InspectorBackend.cpp:
              (WebCore::InspectorBackend::getEventListenersForNode):
              * inspector/InspectorBackend.h:
              * inspector/InspectorBackend.idl:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::getEventListenersForNode):
              (WebCore::InspectorDOMAgent::buildObjectForEventListener):
              (WebCore::InspectorDOMAgent::buildObjectForNode): added localName
              * inspector/InspectorDOMAgent.h:
              (WebCore::EventListenerInfo::EventListenerInfo):
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::didGetEventListenersForNode):
              * inspector/InspectorFrontend.h:
              (WebCore::InspectorFrontend::scriptState):
              * inspector/front-end/DOMAgent.js: added localName to WebInspector.DOMNode from payload
              (WebInspector.EventListeners.getEventListenersForNodeAsync.mycallback):
              (WebInspector.EventListeners.getEventListenersForNodeAsync):
      
                New Sidebar Pane in the Element's Panel
                Includes Gear Menu for filtering the Event Listeners on the
                "Selected Node Only" or "All Nodes"
      
              * inspector/front-end/ElementsPanel.js: Handles refreshing the Pane when necessary
              (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
              (WebInspector.ElementsPanel):
              (WebInspector.ElementsPanel.prototype.updateEventListeners):
              * inspector/front-end/EventListenersSidebarPane.js: Added. 
              (WebInspector.EventListenersSidebarPane): The 1st level in the Pane
              (WebInspector.EventListenersSidebarPane.prototype.update.callback):
              (WebInspector.EventListenersSidebarPane.prototype.update):
              (WebInspector.EventListenersSection): The 2nd level in the Pane
              (WebInspector.EventListenersSection.prototype.update): filters on Preference
              (WebInspector.EventListenersSection.prototype.addListener):
              (WebInspector.EventListenerBar): The 3rd level in the Pane
              (WebInspector.EventListenerBar.prototype._getNodeDisplayName):
              (WebInspector.EventListenerBar.prototype._getFunctionDisplayName):
              (WebInspector.EventListenersSidebarPane.prototype._changeSetting): For the Gear Menu
              
                Consolidated "appropriateSelectorForNode"
      
              * inspector/front-end/StylesSidebarPane.js:
              * inspector/front-end/utilities.js:
      
                Miscellaneous Updates
      
              * English.lproj/localizedStrings.js: "Event Listeners", "No Event Listeners", "Selected Node Only", "All Nodes"
              * WebCore.gypi: included the new inspector files
              * WebCore.vcproj/WebCore.vcproj: included source files that were missing
              * inspector/front-end/Images/grayConnectorPoint.png: Added. Thanks to Timothy Hatcher.
              * inspector/front-end/Images/whiteConnectorPoint.png: Added. Thanks to Timothy Hatcher.
              * inspector/front-end/inspector.js: Preferences for the Gear Menu Event Listeners filter
              * inspector/front-end/inspector.css: reused as much as possible
              * inspector/front-end/inspector.html: include the new script
              * inspector/front-end/WebKit.qrc: included the new inspector files
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5c785e8
    • hausmann@webkit.org's avatar
      Compile fix with namespaced Qt. · 75b3d3a0
      hausmann@webkit.org authored
      Patch by Andre Poenitz <andre.poenitz@trolltech.com> on 2009-09-28
      Reviewed by Simon Hausmann.
      
      * Api/qwebinspector_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75b3d3a0
    • hausmann@webkit.org's avatar
      Add ARM version detection for Windows CE. · d7c6229f
      hausmann@webkit.org authored
      Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-28
      Reviewed by Simon Hausmann.
      
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7c6229f
  2. 27 Sep, 2009 10 commits
    • weinig@apple.com's avatar
      WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29760 · a09f5201
      weinig@apple.com authored
      Implement CSSOM Range.getClientRects/getBoundingClientRect 
      
      Reviewed by Dan Bernstein.
      
      Tests: fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport.html
             fast/dom/Range/getBoundingClientRect.html
             fast/dom/Range/getClientRects.html
      
      * dom/Range.cpp:
      (WebCore::Range::getClientRects):
      (WebCore::Range::getBoundingClientRect):
      (WebCore::adjustFloatQuadsForScrollAndAbsoluteZoom):
      (WebCore::Range::getBorderAndTextQuads):
      * dom/Range.h:
      * dom/Range.idl:
      Implement Range.getClientRects/getBoundingClientRect.
      
      * dom/Element.cpp:
      * rendering/RenderObject.h: 
      (WebCore::adjustForAbsoluteZoom):
      (WebCore::adjustIntRectForAbsoluteZoom):
      (WebCore::adjustFloatPointForAbsoluteZoom):
      (WebCore::adjustFloatQuadForAbsoluteZoom):
      Move point/quad adjustment methods from Element.cpp to RenderObject.h
      so that Range.cpp can use them as well.
      
      LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=29760
      Implement CSSOM Range.getClientRects/getBoundingClientRect 
      
      Reviewed by Dan Bernstein.
      
      * fast/dom/Element/getBoundingClientRect-expected.txt: Copied from LayoutTests/fast/dom/getBoundingClientRect-expected.txt.
      * fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Copied from LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt.
      * fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport.html: Copied from LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html.
      * fast/dom/Element/getBoundingClientRect.html: Copied from LayoutTests/fast/dom/getBoundingClientRect.html.
      * fast/dom/Element/getClientRects-expected.txt: Copied from LayoutTests/fast/dom/getClientRects-expected.txt.
      * fast/dom/Element/getClientRects.html: Copied from LayoutTests/fast/dom/getClientRects.html.
      * fast/dom/Range/getBoundingClientRect-expected.txt: Added.
      * fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Added.
      * fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport.html: Added.
      * fast/dom/Range/getBoundingClientRect.html: Added.
      * fast/dom/Range/getClientRects-expected.txt: Added.
      * fast/dom/Range/getClientRects.html: Added.
      * fast/dom/Window/window-properties-expected.txt:
      * fast/dom/getBoundingClientRect-expected.txt: Removed.
      * fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Removed.
      * fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html: Removed.
      * fast/dom/getBoundingClientRect.html: Removed.
      * fast/dom/getClientRects-expected.txt: Removed.
      * fast/dom/getClientRects.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a09f5201
    • eric@webkit.org's avatar
      2009-09-27 Joe Ligman <joseph.ligman@mindspring.com> · ea151061
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Adding API setFocus and hasFocus to QWebElement. This API is needed for
              clients that want to check/set the focus node of the document.
              https://bugs.webkit.org/show_bug.cgi?id=29682
      
              * Api/qwebelement.cpp:
              (QWebElement::hasFocus):
              (QWebElement::setFocus):
              * Api/qwebelement.h:
              * tests/qwebelement/tst_qwebelement.cpp:
              (tst_QWebElement::hasSetFocus):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea151061
    • hausmann@webkit.org's avatar
      Unreviewed fix for WebInspector with Qt build. · c66ece35
      hausmann@webkit.org authored
      Patch by Simon Hausmann <hausmann@webkit.org> on 2009-09-27
      Simply re-generate the Qt resource file by running
      WebKitTools/Scripts/generate-qt-inspector-resource
      
      * inspector/front-end/WebKit.qrc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c66ece35
    • eric@webkit.org's avatar
      2009-09-27 Jakub Wieczorek <faw217@gmail.com> · 154ff8cb
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
              https://bugs.webkit.org/show_bug.cgi?id=29771
      
              * Scripts/run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      154ff8cb
    • eric@webkit.org's avatar
      2009-09-27 Jakub Wieczorek <faw217@gmail.com> · 3dd3a289
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Remove tests that are passing from the Skipped list after implementing
              the waitForPolicyDelegate() function in LayoutTestController.
              https://bugs.webkit.org/show_bug.cgi?id=25037
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3dd3a289
    • eric@webkit.org's avatar
      2009-09-27 Jakub Wieczorek <faw217@gmail.com> · d524163b
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Implement layoutTestController.waitForPolicyDelegate.
              https://bugs.webkit.org/show_bug.cgi?id=25037
      
              * DumpRenderTree/qt/DumpRenderTree.cpp:
              (WebCore::WebPage::acceptNavigationRequest):
              * DumpRenderTree/qt/DumpRenderTree.pro:
              * DumpRenderTree/qt/jsobjects.cpp:
              (LayoutTestController::reset):
              (LayoutTestController::notifyDone):
              (LayoutTestController::waitForPolicyDelegate):
              * DumpRenderTree/qt/jsobjects.h:
              (LayoutTestController::waitForPolicy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d524163b
    • pfeldman@chromium.org's avatar
      2009-09-27 Pavel Feldman <pfeldman@chromium.org> · da096d58
      pfeldman@chromium.org authored
              Reviewed by nobody (trivial ChangeLog fix).
      
              Restore WebCore/ChangeLog truncated in r48778.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da096d58
    • pfeldman@chromium.org's avatar
      2009-09-27 Pavel Feldman <pfeldman@chromium.org> · 6cf9e180
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: DOM store is being unbound twice, leading to assertion failure.
      
              https://bugs.webkit.org/show_bug.cgi?id=29770
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::didOpenDatabase):
              (WebCore::InspectorController::didUseDOMStorage):
              * inspector/InspectorDOMStorageResource.cpp:
              (WebCore::InspectorDOMStorageResource::unbind):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cf9e180
    • pfeldman@chromium.org's avatar
      2009-09-26 Pavel Feldman <pfeldman@chromium.org> · b8105144
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Do not track DOM changes while inspector window is closed.
      
              https://bugs.webkit.org/show_bug.cgi?id=29769
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
              (WebCore::InspectorController::populateScriptObjects):
              (WebCore::InspectorController::resetScriptObjects):
              (WebCore::InspectorController::didCommitLoad):
              * inspector/InspectorController.h:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::setDocument):
              * inspector/InspectorDOMAgent.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::dispatchWindowObjectAvailable):
              * page/android/InspectorControllerAndroid.cpp:
              (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8105144
    • pfeldman@chromium.org's avatar
      2009-09-26 Pavel Feldman <pfeldman@chromium.org> · 89f7ae77
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: [REGRESSION] Double Clicking Resources Fails to Open in New Window
      
              https://bugs.webkit.org/show_bug.cgi?id=29762
      
              * inspector/front-end/InjectedScript.js:
              (InjectedScript.setStyleText):
              (InjectedScript.openInInspectedWindow):
              * inspector/front-end/InjectedScriptAccess.js:
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89f7ae77
  3. 26 Sep, 2009 10 commits
    • ddkilzer@apple.com's avatar
      GTK BUILD FIX: add ENABLE_ORIENTATION_EVENTS support to configure.ac · 66a29530
      ddkilzer@apple.com authored
              * configure.ac: Added support for ENABLE_ORIENTATION_EVENTS.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66a29530
    • ddkilzer@apple.com's avatar
      Part 2 of 2: <http://webkit.org/b/29753> DerivedSources.make broken for non-Mac targets · 881bafc0
      ddkilzer@apple.com authored
              Reviewed by Darin Adler.
      
              Fix ENABLE_ORIENTATION_EVENTS for non-Mac platforms.
      
      WebCore:
      
              * DerivedSources.make: Moved Platform.h check for
              ENABLE_ORIENTATION_EVENTS into Mac-only section and added
              default of ENABLE_ORIENTATION_EVENTS = 0 to non-Mac section.
              Added ifndef test to make it possible to override both
              ENABLE_DASHBOARD_SUPPORT and ENABLE_ORIENTATION_EVENTS external
              to the makefile.  Moved addition of ENABLE_ORIENTATION_EVENTS to
              ADDITIONAL_IDL_DEFINES to common section.
              * GNUmakefile.am: Added support for ENABLE_ORIENTATION_EVENTS if
              it is ever used.
              * WebCore.pro: Ditto.
      
      WebKit:
      
              * chromium/features.gypi: Added 'ENABLE_ORIENTATION_EVENTS=0' to
              disable this feature by default.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      881bafc0
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch · 9f9c7097
      ddkilzer@apple.com authored
              Reviewed by Eric Seidel.
      
              The -o|--open switch uses the open(1) command on Mac OS X to
              open the bug URL in the default web browser.  If there are
              similar mechanisms on other platforms, they may be added later.
      
              * Scripts/mark-bug-fixed:
              (MarkBugFixed.__init__): Added -o|--open switch to list of parse
              options.
              (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
              code into main() and extracted prompting code into
              _prompt_user_for_correctness().
              (MarkBugFixed._open_bug_in_web_browser): Added.
              (MarkBugFixed._prompt_user_for_correctness): Added.
              (MarkBugFixed.main): Added logging code from
              _determine_bug_id_and_svn_revision().  Added code to call
              _open_bug_in_web_browser() if the switch is set.  Added code to
              call _prompt_user_for_correctness() when needed.
              * Scripts/modules/bugzilla.py:
              (Bugzilla.short_bug_url_for_bug_id): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f9c7097
    • ddkilzer@apple.com's avatar
      svn-unapply and svn-apply don't work when used outside multiple svn working directories · 33e4fbc9
      ddkilzer@apple.com authored
              <http://webkit.org/b/29744>
              <rdar://problem/7252905>
      
              Reviewed by Eric Seidel.
      
              Some users have a workflow where svn-create-patch, svn-apply and
              svn-unapply are used outside of multiple svn working
              directories.  Instead of aborting the scripts in these cases,
              print a warning and assume that Subversion is being used.
      
              * Scripts/VCSUtils.pm:
              (determineVCSRoot): Call warn() instead of die() if both isGit()
              and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
              to enforce the assumption about Subversion, then return
              determineSVNRoot().
              * Scripts/svn-apply: Switch to using isGit() and isSVN() from
              VCSUtils.pm.  They both already cache their values and checking
              here is redundant since determineVCSRoot() is called later.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33e4fbc9
    • eric@webkit.org's avatar
      2009-09-26 Kent Tamura <tkent@chromium.org> · e6cd79ca
      eric@webkit.org authored
              Reviewed by David Kilzer.
      
              Move placeholder-related code to HTMLTextFormControlElement from
              HTMLInputElement, WMLInputElement, InputElement, and
              HTMLTextAreaElement.
              https://bugs.webkit.org/show_bug.cgi?id=28703
      
              * dom/InputElement.cpp:
              (WebCore::InputElement::dispatchFocusEvent):
              (WebCore::InputElement::dispatchBlurEvent):
              (WebCore::InputElement::setValueFromRenderer):
              * dom/InputElement.h:
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement):
              (WebCore::HTMLTextFormControlElement::~HTMLTextFormControlElement):
              (WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
              (WebCore::HTMLTextFormControlElement::dispatchBlurEvent):
              (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
              (WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
              * html/HTMLFormControlElement.h:
              (WebCore::HTMLTextFormControlElement::handleFocusEvent):
              (WebCore::HTMLTextFormControlElement::handleBlurEvent):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::HTMLInputElement):
              (WebCore::HTMLInputElement::handleFocusEvent):
              (WebCore::HTMLInputElement::handleBlurEvent):
              (WebCore::HTMLInputElement::parseMappedAttribute):
              (WebCore::HTMLInputElement::createRenderer):
              (WebCore::HTMLInputElement::setValue):
              (WebCore::HTMLInputElement::setValueFromRenderer):
              * html/HTMLInputElement.h:
              (WebCore::HTMLInputElement::supportsPlaceholder):
              (WebCore::HTMLInputElement::isEmptyValue):
              * html/HTMLIsIndexElement.cpp:
              (WebCore::HTMLIsIndexElement::parseMappedAttribute):
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
              (WebCore::HTMLTextAreaElement::createRenderer):
              * html/HTMLTextAreaElement.h:
              (WebCore::HTMLTextAreaElement::supportsPlaceholder):
              (WebCore::HTMLTextAreaElement::isEmptyValue):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::RenderTextControl):
              * rendering/RenderTextControl.h:
              * rendering/RenderTextControlMultiLine.cpp:
              (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
              * rendering/RenderTextControlMultiLine.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              * rendering/RenderTextControlSingleLine.h:
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::setValue):
              (WebCore::WMLInputElement::createRenderer):
              * wml/WMLInputElement.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6cd79ca
    • eric@webkit.org's avatar
      2009-09-26 Zan Dobersek <zandobersek@gmail.com> · a100fd7b
      eric@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
              https://bugs.webkit.org/show_bug.cgi?id=29689
      
              Load test fonts through FontConfig before each test.
              This ensures a more proper rendering of the tests.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (initializeFonts):
              (runTest):
              (main):
              * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a100fd7b
    • eric@webkit.org's avatar
      2009-09-26 Shu Chang <Chang.Shu@nokia.com> · e967f240
      eric@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Optimize the code so only the text from start to end is scanned.
              https://bugs.webkit.org/show_bug.cgi?id=29092
      
              On a platform with webkit+Qt+Symbian, the parsing time for a 600K text
              file improved from 400ms to 40ms (10x faster).
      
              * dom/Text.cpp:
              (WebCore::Text::createWithLengthLimit):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e967f240
    • eric@webkit.org's avatar
      2009-09-26 Xiaomei Ji <xji@chromium.org> · 087ef480
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              This Patch fixes [chromium] the drop-down is always left-aligned even
              for RTL element.
              https://bugs.webkit.org/show_bug.cgi?id=29612
      
              For auto-complete, the items in drop-down should be right-aligned if
              the directionality of <input> field is RTL.
              For <select><option>, the items in drop-down should be right-aligned
              if the directionality of <select> is RTL.
      
              No automatic test is possible. Manual tests are added.
      
              * manual-tests/autofill_alignment.html: Added.
              * manual-tests/select_alignment.html: Added.
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupListBox::paintRow): Adjust the starting x-axis of text to
              be paint if it should be right-aligned.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      087ef480
    • hausmann@webkit.org's avatar
      Add MarkStackSymbian.cpp to build JavascriptCore for Symbian. · 1d0814dd
      hausmann@webkit.org authored
      Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-09-26
      Reviewed by Simon Hausmann.
      
      Re-use Windows shrinkAllocation implementation because Symbian doesn't
      support releasing part of memory region.
      
      Use fastMalloc and fastFree to implement allocateStack and releaseStack
      for Symbian port.
      
      * JavaScriptCore.pri:
      * runtime/MarkStack.h:
      (JSC::MarkStack::MarkStackArray::shrinkAllocation):
      * runtime/MarkStackSymbian.cpp: Added.
      (JSC::MarkStack::initializePagesize):
      (JSC::MarkStack::allocateStack):
      (JSC::MarkStack::releaseStack):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d0814dd
    • mitz@apple.com's avatar
      REGRESSION (r48775) FontList.plist written by TOT WebKit causes Safari 4 · e91eb57e
      mitz@apple.com authored
      to crash on launch
      https://bugs.webkit.org/show_bug.cgi?id=29759
      
      Reviewed by Sam Weinig.
      
      * platform/graphics/win/FontDatabase.cpp:
      (WebCore::writeFontDatabaseToPlist): Reverted to saving the CG font DB
      property list at the root of FontList.plist, but with an additional
      key for the last value of the Fonts registry key.
      (WebCore::populateFontDatabase): Pass the FontList.plist in its entirety
      to populatFontDatabaseFromPlist.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e91eb57e