1. 09 Jan, 2003 1 commit
    • darin's avatar
      WebKit: · 066636cc
      darin authored
              Reviewed by Maciej.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      WebBrowser:
      
              Reviewed by Maciej.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
              * English.lproj/Localizable.strings: Regenerate.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      066636cc
  2. 02 Jan, 2003 1 commit
    • darin's avatar
      Reviewed by John and Ken. · bbd1f7da
      darin authored
      	- fixed 3135548 -- exception in Internet Explorer bookmark import code at first startup
      
              * Bookmarks.subproj/WebBookmarkImporter.m:
              (_breakStringIntoLines): Break lines before a <DT> or </DL>.
              (_HREFTextFromSpec): Rewrite to simplify, search in a case-insensitive manner.
              (-[WebBookmarkImporter initWithPath:]): Change prefix checks to be case-insensitive.
      	Don't discard folders altogether if the name can't be parsed as that would mess up
      	nesting w.r.t the next </DL>. Make the </DL> handling robust so we misparse, but don't
      	crash the whole application by raising an exception.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for this change and recent changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbd1f7da
  3. 31 Dec, 2002 1 commit
  4. 23 Dec, 2002 1 commit
    • kocienda's avatar
      Reviewed by Darin and Gramps · 60fef03f
      kocienda authored
      	Workaround for this bug:
      
      	Radar 3134219 (MPEG-4 files don't work with the QuickTime plugin in Safari,
      	work fine in Mozilla, IE)
      
      	For beta 1, we For beta 1, when getting the MIME information for the QuickTime
      	plugin, we directly insert the information to handle MP4.
      
      	In the future, we will use the additional plugin entry points to dynamically load
      	this information from the plugin itself.
      
              * Plugins.subproj/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage getMIMEInformation])
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60fef03f
  5. 19 Dec, 2002 1 commit
    • sullivan's avatar
      WebKit: · 68d6d24d
      sullivan authored
      	- WebKit part of fix for 3124949 -- Alexander recreates the
      	default set of bookmarks every time a separate app copy is launched
      
              Reviewed by Darin
      
              * Bookmarks.subproj/WebBookmarkGroup.h:
      	new _tag ivar and -tag method.
      
              * Bookmarks.subproj/WebBookmarkGroup.m:
              (-[WebBookmarkGroup dealloc]):
      	release _tag
              (-[WebBookmarkGroup tag]):
      	return _tag
              (-[WebBookmarkGroup _loadBookmarkGroupGuts]):
      	read _tag from the dictionary in the file (or leave it at
      	nil if there's no value in the file).
      
              * English.lproj/StringsNotToBeLocalized.txt:
      	kept this file up to date
      
      WebBrowser:
      
      	- WebBrowser part of fix for 3124949 -- Alexander recreates the
      	default set of bookmarks every time a separate app copy is launched
      
              Reviewed by Darin
      
              * BookmarksController.m:
              (-[BookmarksController mergeBuiltInBookmarksIfNecessary]):
      	if the mod date has changed since the last time this was
      	checked, check the tag in the bookmarks	group (loaded from the
      	file) to see if it has changed. If the tag hasn't changed, then
      	don't merge the built-in bookmarks.
      
              * PreferenceKeys.h:
      	new #define BuiltInBookmarksTagPreferenceKey
      
              * English.lproj/BuiltInBookmarks.plist:
      	Added tag (happens to be string that looks like a date) to
      	this file. We'll update this whenever we update the contents.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68d6d24d
  6. 18 Dec, 2002 3 commits
    • darin's avatar
      Reviewed by Richard. · e95b8af8
      darin authored
      	- fixed 3127490 -- pages w/frames sometimes show up blank
      
              * WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
      	Updated the optimization where we draw the entire view if we did a layout
      	so that it works properly for the case where the clip is narrower because of
      	the parent WebHTMLView.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e95b8af8
    • cblu's avatar
      WebKit: · fe1a76e0
      cblu authored
      	Reject the RealPlayer plug-in because we know it doesn't work.
      
              Reviewed by sullivan.
      
              * English.lproj/StringsNotToBeLocalized.txt:
              * Plugins.subproj/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage initWithPath:]): reject the RealPlayer plug-in
      
      WebBrowser:
      
      	Fixed: 3103603 - Safari becomes unresponsive while launching DiskCopy
      	Special case RealPlayer and WMP plug-ins. Provide the option to open the content in the apps.
      
              Reviewed by sullivan.
      
              * BrowserNSWorkspaceExtras.m:
              (-[NSWorkspace launchApplicationAtPath:processSerialNumber:makeFrontmost:event:]): enable async launching of DiskCopy
              * English.lproj/Localizable.strings:
              * English.lproj/StringsNotToBeLocalized.txt:
              * LoadProgressMonitor.m:
              (-[LoadProgressMonitor pluginFailedWithError:dataSource:]): special case RealPlayer and WMP plug-ins. Provide the option to open the content in the apps.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe1a76e0
    • mjs's avatar
      WebFoundation: · b1432259
      mjs authored
              Reviewed by Trey and Darin.
      
      	Minor fixes required to fix these bugs:
      
      	3124933 - abcnews.com leads to empty window with sheet complaining about javascript: URL
      	3091248 - picture does not show up in window from epinions
      
      	* CacheLoader.subproj/WebResourceResponse.h: Don't include uninstalled headers
      	in this private but installed header.
              * ProtocolHandlers.subproj/WebAboutProtocolHandler.m:
              (-[WebAboutProtocolHandler setResponseMetadata:]): "about:blank"
      	should be a blank html document, not a blank plain text document.
              * Misc.subproj/WebNSURLExtras.h:
              * Misc.subproj/WebNSURLExtras.m:
              (-[NSString _web_shouldLoadAsEmptyDocument]): New method.
      	* English.lproj/StringsNotToBeLocalized.txt: Updated.
      
      WebCore:
      
              Reviewed by Trey and Darin.
      
      	- fixed 3124933 - abcnews.com leads to empty window with sheet complaining about javascript: URL
      	- fixed 3091248 - picture does not show up in window from epinions
      
      
              * khtml/ecma/kjs_window.cpp:
              (Window::get): Put back document-creating code that was in #if
      	!APPLE_CHANGES.
      	(Window::isSafeScript): Extend access to a window that was opened
      	to no URL or to about:blank by the active window.
              (shouldLoadAsEmptyDocument): Helper for the above.
              (WindowFunc::tryCall): Update APPLE_CHANGES comments - now it's
      	clear we don't need to create a document in a fresh window
      	(accessing document will take care of that), and that it will be
      	counter-productive, possibly adding a useless entry to the
      	back/forward list.
              * khtml/khtml_part.cpp:
              (KHTMLPart::begin): If we're not loading a URL, make a dummy
      	document (the call will check if we have a dummy document
      	already).
              * kwq/KWQKHTMLPart.mm:
      	(KWQKHTMLPart::createEmptyDocument): Isntead of setting up a
      	half-assed document, ask bridge to synchronously load a fully
      	assed (but empty) document. Renamed from createDummyDocument.
              * kwq/KWQKHTMLPartBrowserExtension.mm:
              (KHTMLPartBrowserExtension::openURLRequest): Decode script. Also,
      	check if return value is a string - if so, write it into the
      	document. Maybe we want this to be more general.
              * kwq/KWQKURL.mm:
              (KURL::KURL): Changed to successfully resolve absolute URLs
      	against an empty base URL.
              * kwq/WebCoreBridge.h: prototyped new
      	loadEmptyDocumentSynchronously method.
      
      WebKit:
      
              Reviewed by Darin and Trey.
      
      	- fixed 3124933 - abcnews.com leads to empty window with sheet complaining about javascript: URL
      	- fixed 3091248 - picture does not show up in window from epinions
      	- made "about:blank" load synchronously, which I'm told is required by some sites.
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge createWindowWithURL:frameName:]): If the URL is nil
      	or empty, pass a nil request - otherwise WebBrowser will try to
      	load it, resulting in an extra back/forward list entry.
              (-[WebBridge loadEmptyDocumentSynchronously]): Tell the frame to
      	load a request with an empty URL - this will cause a synchronous
      	load of an empty html document
              * WebView.subproj/WebBaseResourceHandleDelegate.h:
              * WebView.subproj/WebBaseResourceHandleDelegate.m:
      	(-[WebBaseResourceHandleDelegate loadWithRequest:]): Split off
      	startLoading: part of method to allow behavior to be subclassed.
              (-[WebBaseResourceHandleDelegate startLoading:]):
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSource _commitIfReady:]): Lie and claim the URL is
      	"about:blank" if it's really empty to avoid confusing WebCore.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _transitionToCommitted:]): Don't put the empty URL in
      	global history.
              (-[WebFrame
      	_checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
      	Don't check policy if URL is empty - this is likely to confuse the
      	client and we know what the right behavior here is.
              * WebView.subproj/WebMainResourceClient.m:
      	(-[WebMainResourceClient startLoading:]): Try to load
      	"about:blank" and the empty URL synchronously, bypassing
      	WebFoundation.
              (-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto.
              (-[WebMainResourceClient setDefersCallbacks:]): Ditto.
              * English.lproj/StringsNotToBeLocalized.txt: Updated.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1432259
  7. 17 Dec, 2002 1 commit
    • trey's avatar
      WebKit: · 2113543f
      trey authored
      	Reworking the code to update the page icon led me to roll the WebIconDB API
      	for URL to NSString.  In addition, the vestigial "Site" was removed.
      
      	Everything below is renaming, except where noted.
      
              Reviewed by Darin
      
              * English.lproj/StringsNotToBeLocalized.txt:
              * History.subproj/WebHistoryItem.m:
              (-[WebHistoryItem _retainIconInDatabase:]):
              (-[WebHistoryItem icon]):
              * Misc.subproj/WebIconDatabase.h:
              * Misc.subproj/WebIconDatabase.m:
              (-[WebIconDatabase init]):
              (-[WebIconDatabase iconForURL:withSize:cache:]):  Use _web_isFileURL.
              (-[WebIconDatabase iconForURL:withSize:]):
              (-[WebIconDatabase retainIconForURL:]):
              (-[WebIconDatabase releaseIconForURL:]):
              (-[WebIconDatabase _iconDictionariesAreGood]):
              (-[WebIconDatabase _loadIconDictionaries]):
              (-[WebIconDatabase _updateFileDatabase]):
              (-[WebIconDatabase _iconForFileURL:withSize:]):  Cons up a NSURL to get the path.
      	Test explicitly for .htm and .html suffixes.
              (-[WebIconDatabase _setIcon:forIconURL:]):
              (-[WebIconDatabase _setIconURL:forURL:]):
              (-[WebIconDatabase _releaseIconForIconURLString:]):
              (-[WebIconDatabase _retainFutureIconForURL:]):
              (-[WebIconDatabase _releaseFutureIconForURL:]):
              (-[WebIconDatabase _sendNotificationForURL:]):
              * Misc.subproj/WebIconDatabasePrivate.h:
              * Misc.subproj/WebIconLoader.m:
              (-[WebIconLoader handleDidFinishLoading:]):
              * WebKit.exp:
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSource _updateIconDatabaseWithURL:]):
              (-[WebDataSource _loadIcon]):
      
      WebBrowser:
      
      	3127109 - REGRESSION: generic favicon shown while page from same domain is loading
      
      	We now avoid jumping to the generic icon when we're loading and are moving
      	to a URL within the same domain as the current one.
      
      	In addition, some name changes for the URL->NSString changes in the WebIconDB API.
      
              Reviewed by John
      
              * BookmarkSource.m:
              (-[BookmarkSource imageForContentItem:]):  Adopt API change.
              * BrowserWindowController.h:  New ivar, _acceptsGenericIcon.
              * BrowserWindowController.m:
              (-[BrowserWindowController windowDidLoad]):  Init new ivar.
              (-[BrowserWindowController acceptsGenericIcon]):  New getter.
              (-[BrowserWindowController setAcceptsGenericIcon:]):  New setter.
              (-[BrowserWindowController updateLocationFieldIcon]):  Obey new ivar as to
      	we will accept a generic icon when updating.
              * LocationChangeHandler.m:
              (-[LocationChangeHandler locationChangeStartedForDataSource:]):  If the new URL
      	is in the same site as the old one, avoid accepting a generic icon.
              (-[LocationChangeHandler locationChangeDone:forDataSource:]):  Reset _acceptsGenericIcon
              * NewBookmarksController.m:
              (-[NewBookmarksController awakeFromNib]):  Adopt API change.
              * TitleBarButton.m:
              (-[TitleBarButton drawPathRepresentingPopUpMenuForEvent:URL:]):  Adopt API change.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2113543f
  8. 15 Dec, 2002 2 commits
    • darin's avatar
      Reviewed by Dave. · cda39631
      darin authored
      	- implemented user-agent spoofing as described in bug 3044569
      
              * WebView.subproj/WebController.m: (-[WebController userAgentForURL:]):
      	Find the suffix of the host name that contains exactly one dot, lower-case it,
      	and look it up in the user-agent spoof table. For now, anything in the table
      	pretends to be MacIE. Don't fret that this table is simple. We will complicate it
      	as needed. The technique is flexible, even though it may not look it now.
      
              * WebView.subproj/WebControllerPrivate.h: Add userAgentWhenPretendingToBeMacIE field.
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebControllerPrivate dealloc]): Release userAgentWhenPretendingToBeMacIE.
              (-[WebController _defaultsDidChange]): Release and nil userAgentWhenPretendingToBeMacIE.
      
              * Makefile.am: Added rules to build WebUserAgentSpoofTable.c using gperf.
              * WebView.subproj/WebUserAgentSpoofTable.c: Added. Generated file.
              * WebView.subproj/WebUserAgentSpoofTable.gperf: Added. Table
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for above changes.
      
      	- fixed a crash I saw in a simplistic way
      
              * WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):
      	Don't assert if the webFrame is nil, just return a partial dictionary.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cda39631
    • gramps's avatar
      Reviewed by darin · 041757b8
      gramps authored
      * Debug/DebugUtilities.m:
      (-[DebugUtilities userAgentSubmenuItem]):
      
      Changed "PPC" in one user agent string to "PPC Mac OS X" used for
      debugging.
      
      Fixed 3127173 -- REGRESSION: fboweb.com renders incorrectly
      
      Reviewed by darin
      
      * English.lproj/StringsNotToBeLocalized.txt:
      * WebView.subproj/WebController.m:
      (-[WebController userAgentForURL:]):
      
      Changed "PPC" in our user agent string to "PPC Mac OS X" in order to
      match Mozilla and make the silly server-side user agent string checking
      work at fboweb.com.  Actually, just "PPC " would work fine at
      fboweb.com.  Go figure.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      041757b8
  9. 13 Dec, 2002 2 commits
    • darin's avatar
      Reviewed by Don. · f491b7c3
      darin authored
              * WebView.subproj/WebController.m: (-[WebController userAgentForURL:]):
      	Add "(like Gecko)" string and change "WebKit" to "AppleWebKit".
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for these changes.
              * Misc.subproj/WebUnicode.h: No need for & 0xFF since we cast to unsigned char.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f491b7c3
    • darin's avatar
      WebKit: · 345fb614
      darin authored
              Reviewed by Maciej.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      WebBrowser:
      
              Reviewed by Maciej.
      
      	- fix some relatively new messages to use curly apostrophes
      
              * AppController.m: (-[AppController confirmEmptyCache:]): One in here.
              * LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:]): Two in here.
              * English.lproj/Localizable.strings: Generated this.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      345fb614
  10. 11 Dec, 2002 3 commits
    • darin's avatar
      WebFoundation: · 039a8a81
      darin authored
              Reviewed by Richard.
      
      	- fixed 3124837 -- Crash trying to handle weird javascript URL in page address field
      
              * Misc.subproj/WebNSURLExtras.h: Added _web_scriptIfJavaScriptURL for both NSURL and NSString,
      	and _web_stringByReplacingValidPercentEscapes.
              * Misc.subproj/WebNSURLExtras.m:
              (-[NSURL _web_scriptIfJavaScriptURL]): Added. Call the NSString version on our absoluteString.
              (isHexDigit): Added.
              (hexDigitValue): Added.
              (-[NSString _web_stringByReplacingValidPercentEscapes]): Added. Converts the sequences into
      	character, and then re-encodes as UTF-8. Added a FIXME about doing even better.
              (-[NSString _web_scriptIfJavaScriptURL]): Check for a javascript: prefix, then turn the suffix
      	into a script by replacing percent escapes.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated.
      
      WebCore:
      
              Reviewed by Richard.
      
      	- fixed 3124263 -- REGRESSION: Crash running development build of PLT
      
              * kwq/KWQWidget.mm:
              (QWidget::~QWidget): Don't worry about the outer view here, since we can never hit one of those.
      	Just pass the view to KWQKHTMLPart::widgetWillReleaseView.
              (QWidget::getOuterView): Re-add the assertion I had removed.
      
      	- fixed 3124837 -- Crash trying to handle weird javascript URL in page address field
      
              * kwq/KWQKURL.mm: (KURL::decode_string): Made this function return the URL still encoded
      	rather than a null string (actually, crashing) when CFURLCreateStringByReplacingPercentEscapes
      	rejects the passed-in string. Also updated the FIXME.
              (appendEscapingBadChars): Fixed problem with high-bit-set characters.
              * kwq/KWQString.mm: (QString::setBufferFromCFString): Made this tolerant of NULL.
      
      WebKit:
      
              Reviewed by Richard.
      
      	- fixed 3124837 -- Crash trying to handle weird javascript URL in page address field
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
      	Use the new _web_scriptIfJavaScriptURL to simplify the check for JavaScript URLs,
      	and to use a more tolerant unescaper.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated.
      
      WebBrowser:
      
              Reviewed by Richard.
      
      	- fixed 3124837 -- Crash trying to handle weird javascript URL in page address field
      
              * BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]):
              * BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocation:]):
      	Use the new _web_scriptIfJavaScriptURL to simplify the check for JavaScript URLs,
      	and to use a more tolerant unescaper.
      
              * BrowserWebController.m: (-[BrowserWebController mouseoverTextForElement:modifierFlags:]):
      	Use _web_stringByReplacingValidPercentEscapes, since it is more tolerant than
      	CFURLCreateStringByReplacingPercentEscapes.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      039a8a81
    • darin's avatar
      Reviewed by John. · 19bd5e70
      darin authored
      	- fixed 3117611 -- REGRESSION: exception in mouseoverTextForElement with accented characters in status
      
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]):
      	Remove the object from the dictionary rather than just leaving the dictionary alone if it's nil.
      	This is needed since we now are reusing an already-existing dictionary.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19bd5e70
    • trey's avatar
      WebKit: · 94f4668f
      trey authored
      	3092966 - going back goes to different page (can't go back to a POST page)
      
      	We will rePOST data upon back/forward/refresh if our caches fail us.  The policy delegate
      	gets a crack at confirming this operation.  Latent bugs where the policy delegate was double
      	queried are fixed.  A bug in the b/f cursor when a page failed to load is fixed.
      
              Reviewed by Maciej.
      
              * English.lproj/StringsNotToBeLocalized.txt:  Usual suspects.
              * History.subproj/WebHistoryItem.h:  Add state for reposting forms.
              * History.subproj/WebHistoryItem.m:  Boilerplate changes for new state.
              (-[WebHistoryItem dealloc]):
              (-[WebHistoryItem setFormData:]):
              (-[WebHistoryItem setFormContentType:]):
              (-[WebHistoryItem formData]):
              (-[WebHistoryItem formContentType]):
              (-[WebHistoryItem description]):
              * WebView.subproj/WebController.m:
              (-[WebController _goToItem:withLoadType:]):  Tighten up an assert as I clarified an
      	assumption as I worked through this task.
              * WebView.subproj/WebControllerPolicyDelegate.h:  New WebNavigationType's for back/forward,
      	refresh, and repost.
              * WebView.subproj/WebFrame.m:
              (-[WebFrame loadRequest:]):  Eliminate extra copy of a request.
              (-[WebFrame reload]):  Eliminate extra copy of a request.  Setup triggeringAction properly
      	if we're about to rePOST.
              * WebView.subproj/WebFramePrivate.h:  Started moving some private methods into the .m file.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _createItem]):  Save form state with history items.
              (-[WebFrame _isLoadComplete]):  Fix up b/f cursor on page error before commit succeeds.
              (-[WebFrame _loadItem:fromItem:withLoadType:]):  Set up request to rePOST if that's what the
      	HistoryItem demands.  Add call to _addExtraFieldsToRequest so we don't do a double
      	query of the policy delegate.  Pre-flight the form post vs. WF cache to setup triggering
      	action properly.
              (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]):
      	New utility method to help build action dict.
              (-[WebFrame _continueAfterNavigationPolicy:]):  Comment only.
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):  Call new utility method
      	instead (just code factoring).
              (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):  Call new utility method
      	instead (just code factoring).  Add call to _addExtraFieldsToRequest so we don't do a double
      	query of the policy delegate.
              (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):  Whitespace only.
              (-[WebFrame _resetBackForwardListToCurrent]):  Utility routine to fix up b/f cursor on page error.
              (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]):  Fix up b/f cursor on page
      	error before commit succeeds.
      
      WebBrowser:
      
      	3092966 - going back goes to different page (can't go back to a POST page)
      
      	The app now puts up a confirmation sheet when the user tries to return to a
      	page resulting from a POST, if all of our caches failed.
      
              Reviewed by Maciej.
      
              * BrowserWebController.m:
              (-[BrowserWebController confirmSendSheetDidEnd:returnCode:contextInfo:]):  Changed name of
      	existing routine to be more generic, as its used for two sheets.
              (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
      	Put up the sheet if we're about to rePOST.
              * English.lproj/Localizable.strings:  The usual.
              * English.lproj/StringsNotToBeLocalized.txt:  The usual.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94f4668f
  11. 09 Dec, 2002 1 commit
    • darin's avatar
      Tools: · 030cad4c
      darin authored
              Reviewed by Maciej.
      
              * Scripts/set-alex-version: Make it bump the source version and marketing version
      	of all our subprojects, because that's what we need up until Alex 1.0.
      
      JavaScriptCore:
      
              Reviewed by Maciej.
      
              * JavaScriptCore.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
      	* English.lproj/InfoPlist.strings: In here too.
      
      WebFoundation:
      
              Reviewed by Maciej.
      
      	- fixed problems I noticed in my review of Chris's change (which came in too late)
      
              * CacheLoader.subproj/WebResourceLoad.m: (_guessMIMEType): Fix && vs. || confusion that
      	will make CR, LF, and tab not qualify as text characters. Also take end of loop check
      	out of the loop.
      
      	- added a method for use in user-agent computations
      
              * Misc.subproj/WebNSUserDefaultsExtras.h: Added _web_preferredLanguageCode.
              * Misc.subproj/WebNSUserDefaultsExtras.m:
              (+[NSUserDefaults _web_preferredLanguageCode]): Use _web_HTTPStyleLanguageCode on the
      	first element of the AppleLanguages array.
      
              * WebFoundation.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
      	Make WebNSUserDefaultsExtras.h SPI so we can use it in WebKit. Re-sort things a bit.
      	* English.lproj/InfoPlist.strings: Bump versions in here too.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes.
      
      WebCore:
      
              Reviewed by Maciej.
      
              * WebCore.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
      
      WebKit:
      
              Reviewed by Maciej.
      
      	- fixed 3028664 -- change user agent string to include application name and version
      
              * WebView.subproj/WebController.m:
              (-[WebController setApplicationNameForUserAgent:]): Remove locking, unneeded since we changed
      	how WebFoundation handles user agent.
              (-[WebController setCustomUserAgent:]): Ditto.
              (-[WebController resetUserAgent]): Ditto.
              (-[WebController userAgentForURL:]): Remove locking. Also add new algorithm for computing the
      	user agent which takes the preferred language into account, and incorporates the WebKit version
      	and the application name.
      
              * WebView.subproj/WebControllerPrivate.h: No need for a lock.
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebControllerPrivate init]): Don't create a lock.
              (-[WebControllerPrivate dealloc]): Don't release a lock.
      
              * WebKit.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
      	* English.lproj/InfoPlist.strings: In here too.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes.
      
      WebBrowser:
      
              Reviewed by Maciej.
      
      	- pass properly-formatted application name string to WebKit so it can make a good user-agent
      
              * BrowserWebController.m: (-[BrowserWebController initWithBrowserDocument:]):
      	Instead of passing "Mr. Poopypants", pass Sherlock, augmented with version strings,
      	to setApplicationNameForUserAgent:. Later we will pass Safari instead.
      
              * WebBrowser.pbproj/project.pbxproj: Bump version to 35u (we won't use " unofficial" any more).
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for these changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      030cad4c
  12. 08 Dec, 2002 1 commit
    • darin's avatar
      WebFoundation: · 70b6438f
      darin authored
              Reviewed by Don and Dave.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
              * WebFoundation.pbproj/project.pbxproj: Let Electron be Electron.
      
      WebCore:
      
              Reviewed by Don and Dave.
      
      	- fixed 3115845 -- bad-pointer crash destroying DOM tree reproducible at a particular site
      
      	All hail libgmalloc, without which this would just be another bug I can't reproduce!
      
      	This memory trasher bug was caused bug calling setChildrenLoaded after casting a node to
      	HTMLObjectElementImpl, when the node wasn't always an object element. It turns out that this
              fix was made obsolete a while back when I changed close on renderers to be delivered even for
              cases where the renderer is not created yet at close time.
      
              * khtml/html/htmlparser.cpp: (KHTMLParser::processCloseTag): Remove the special case for
      	</object>. Now that this is fixed another way we don't need this at all.
      
              * khtml/html/html_objectimpl.h: Remove setChildrenLoaded and m_childrenLoaded.
              * khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl):
      	Remove code that sets m_childrenLoaded to false.
              (HTMLObjectElementImpl::attach): Remove code that looks at m_childrenLoaded, since we don't
      	need it any more (and in fact there's no way to set it any more).
      
      	- fixed 3120578 -- REGRESSION: going to about:blank creates null view
      
      	If no tokens are ever sent to the parser, then we end up without a render tree.
      
              * khtml/html/htmlparser.h: Add finished() function.
              * khtml/html/htmlparser.cpp: (KHTMLParser::finished): Make an HTML element if the document is still
      	empty at this point. This is identical to what KHTMLParser::insertNode does when you insert any kind
      	of element other than an HTML element.
      
              * khtml/html/htmltokenizer.cpp: (HTMLTokenizer::end): Call finished() to let the parser know.
      
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): Turn on the "paint red" feature in development builds.
      	Null view problems are particularly hard to debug without something like this, and we don't care
      	if development builds are ever-so-slightly slower. No change in deployment.
      
      	- fixed 3121527 -- crash in WebCoreBridge frameBorderStyle
      
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge frameBorderStyle]): Handle case where this is called and
      	we don't have a KHTMLView yet.
      
      	- other changes
      
              * WebCore.pbproj/project.pbxproj: Electron is doing his thing.
      
      WebKit:
      
              Reviewed by Don and Dave.
      
      	- fixed 3120578 -- REGRESSION: going to about:blank creates null view
      
      	This part of the fix makes sure that a renderer is created, even when there are no bytes
      	of data passed through. This makes the empty document about:blank case work just like the
      	"document with just whitespace in it case". There's another part of the fix in WebCore that
      	takes care of the remaining problem.
      
              * WebView.subproj/WebHTMLRepresentation.m:
              (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
      	Call receivedData:withDataSource: on the bridge with nil for the data. It would be even more
      	elegant to add a new call for the case where we finish, but it's not necessary, since the
      	existing receivedData: call does all the right things if passed nil.
      
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _finishedLoading]):
      	Call finishedLoadingWithDataSource: here, to make sure it's done after committing.
      	This parallels what we already do for the didReceiveData call.
              * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]):
      	Remove the call to finishedLoadingWithDataSource: because it's handled by _finishedLoading now.
      	This parallels what we already do for the didReceiveData call.
      
      	- fixed long standing problem where resizing could make you see a "null view"
      
              * WebView.subproj/WebView.m:
              (-[WebView drawRect:]): Add a "paint cyan" feature in development builds.
      	Null view problems are particularly hard to debug without something like this,
      	and we don't care if development builds are slightly slower. No change in deployment.
              (-[WebView setFrameSize:]): Tell the scroll view to draw the background if we are
      	resized. We can't do our "let the old bits show through" thing any more if we have to
      	redraw because of resizing.
      
      	- other changes
      
              * WebKit.pbproj/project.pbxproj: Remove the old -DAPPLE_CHANGES and -DHAVE_CONFIG_H that we
              once needed when WebKit used to compile  C++ headers from the KHTML part of WebCore.
              We haven't needed those for ages. Also sort things a bit, using the new Electron feature for
      	sorting lists of files alphabetically, and some by hand.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      WebBrowser:
      
      	Reviewed by Don and Dave.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70b6438f
  13. 05 Dec, 2002 1 commit
    • darin's avatar
      WebFoundation: · 5d390593
      darin authored
              Reviewed by Chris.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      WebKit:
      
              Reviewed by Chris.
      
              * Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler initWithDataSource:]):
      	Add WebGZipDecoder to the list.
      
              * Downloads.subproj/WebGZipDecoder.h: Finished this.
              * Downloads.subproj/WebGZipDecoder.m: Finished this.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      WebBrowser:
      
              Reviewed by Chris.
      
              * BugReportController.m: Removed obsolete FIXME.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
              * English.lproj/Localizable.strings: Regenerated this, some string somewhere changed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d390593
  14. 03 Dec, 2002 1 commit
    • darin's avatar
      WebFoundation: · 1b0078cc
      darin authored
      	Reviewed by Maciej.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      WebKit:
      
      	Reviewed by Maciej.
      
              * WebView.subproj/WebView.m: Fixed a pair of strings that conflict.
              * English.lproj/Localizable.strings: Regenerated.
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b0078cc
  15. 02 Dec, 2002 1 commit
    • trey's avatar
      WebKit: · edb8fdb4
      trey authored
      	Refined bookmark notifications to be more detailed.  We now have added, removed,
      	willChange and didChange.
      
              * Bookmarks.subproj/WebBookmarkGroup.h:   New API.
              * Bookmarks.subproj/WebBookmarkGroup.m:
              (-[WebBookmarkGroup _sendNotification:forBookmark:children:]):
              (-[WebBookmarkGroup _setTopBookmark:]):
              (-[WebBookmarkGroup _bookmarkWillChange:]):
              (-[WebBookmarkGroup _bookmarkDidChange:]):
              (-[WebBookmarkGroup _bookmarkChildren:wereAddedToParent:]):
              (-[WebBookmarkGroup _bookmarkChildren:wereRemovedToParent:]):
      	All just small pieces of flow control for posting the notes.
              * Bookmarks.subproj/WebBookmarkGroupPrivate.h:  Internal methods for posting the notes.
              * Bookmarks.subproj/WebBookmarkLeaf.m:
              (-[WebBookmarkLeaf setTitle:]):  Post da note
              (-[WebBookmarkLeaf setURLString:]):  Post da note
              (-[WebBookmarkLeaf description]):  Added for debugging.
              * Bookmarks.subproj/WebBookmarkList.m:
              (-[WebBookmarkList setTitle:]):  Post da note
              (-[WebBookmarkList removeChild:]):  Post da note
              (-[WebBookmarkList insertChild:atIndex:]):  Post da note
              * Bookmarks.subproj/WebBookmarkProxy.m:
              (-[WebBookmarkProxy setTitle:]):  Post da note
              * English.lproj/StringsNotToBeLocalized.txt:  New strings.
              * WebKit.exp:   New strings.
      
      WebBrowser:
      
      	The auto-complete DB properly tracks HistoryItems and Bookmarks coming and going.
      	We have only one DB entry for a given URL, with a ref count.  HistoryItems replace
      	Bookmarks in the DB, so we have a well-defined place to keep stats like visitCount
      	or recent times accessed.
      
              * BookmarksController.m:
              (-[BookmarksController awakeFromNib]):  Adopt new API for bookmark notifications.
              * BookmarksViewController.m:    Adopt new API for bookmark notifications.
              * CompletionController.m:
              (+[CompletionController _tree_create]):  Set refCount of root node.
              (_keyStringFromItem):  Nuke redundant code.
              (_keyStringFromNode):  Deleted nodes must retain their key string to function
      	properly in the DB.
              (_findPotentialNode):  Test for deleted nodes using new bit.
              (+[CompletionController _tree_addItem:]):  New rules for handing a collision on
      	add.  Bump ref count, replace Bookmarks with HistoryItems.
              (+[CompletionController _tree_deleteItem:]):  Obey refcounting.
              (+[CompletionController _tree_nextItemUsingCursor:]):  Test for deleted nodes using new bit.
              (DumpAutoCompleteTree):  Debugging nit.
              (+[CompletionController _removeBookmarkTree:]):  New utility routine.
              (+[CompletionController _loadDB]):  Debugging nits.
              (-[CompletionController _executeQuery]):  Bandaid fix for user typing "www.".
              (+[CompletionController _registerForNotifications]):  Register for bookmark notes.
              (+[CompletionController _bookmarksAdded:]):  Receive bookmark note.
              (+[CompletionController _bookmarksRemoved:]):  Receive bookmark note.
              (+[CompletionController _bookmarkWillChange:]):  Receive bookmark note.
              (+[CompletionController _bookmarkDidChange:]):  Receive bookmark note.
              (-[CompletionController _positionWindow]):  Small code rearranging.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edb8fdb4
  16. 24 Nov, 2002 2 commits
    • cblu's avatar
      WebCore: · 9f027be0
      cblu authored
      	Added element keys for the image ALT and link TITLE attributes. This will eventually be used to fix other bugs. Also made WebKit and WebCore use the same element keys to simplify the conversion of the element dictionary.
      
              * kwq/WebCoreBridge.h:
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge elementAtPoint:]):
      
      WebKit:
      
      	Added element keys for the image ALT and link TITLE attributes. This will eventually be used to fix other bugs. Also made WebKit and WebCore use the same element keys to simplify the conversion of the element dictionary.
      
              * WebView.subproj/WebController.h:
              * WebView.subproj/WebController.m:
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebHTMLView _elementAtPoint:]):
      
      WebBrowser:
      
      	Fixed: 3053342 - Dragging URL to address field with favicon should clear favicon
      
              * BrowserWindowController.m:
              (-[BrowserWindowController locationFieldReceivedDroppedURL:]):
              * English.lproj/StringsNotToBeLocalized.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f027be0
    • cblu's avatar
      Fixed: 3109945 - Assertion failure in -[WebIconDatabase_largestIconFromDictionary:] · 8187a466
      cblu authored
      	Added error strings for download decoding errors.
      
              * English.lproj/Localizable.strings: Added error strings for download decoding errors
              * English.lproj/StringsNotToBeLocalized.txt:
              * Misc.subproj/WebIconDatabase.m:
              (-[WebIconDatabase _loadIconDictionaries]): tweak
              (-[WebIconDatabase _updateFileDatabase]): more error checking to prevent assert
              (-[WebIconDatabase _setIconURL:forSiteURL:]): added asserts to prevent a site URL <-> icon URL mapping without a icon URL -> icon mapping
              (-[WebIconDatabase _largestIconFromDictionary:]): tweak
              * Misc.subproj/WebNSPasteboardExtras.m:
              (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): declare pboard types if none have been declared, else append types
              * WebView.subproj/WebView.m:
              (+[WebView initialize]): Added error strings for download decoding errors
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8187a466
  17. 22 Nov, 2002 1 commit
    • trey's avatar
      WebKit: · 9b70c8f5
      trey authored
      	Added more detailed notifications on history changes.
      	All changes below are just posting the new notes at the right time.
      
              * English.lproj/StringsNotToBeLocalized.txt:
              * History.subproj/WebHistory.h:
              * History.subproj/WebHistory.m:
              (-[WebHistory _sendNotification:entries:]):
              (-[WebHistory addEntry:]):
              (-[WebHistory removeEntry:]):
              (-[WebHistory removeEntries:]):
              (-[WebHistory removeAllEntries]):
              (-[WebHistory addEntries:]):
              (-[WebHistory loadHistory]):
              * WebKit.exp:
      
      WebBrowser:
      
      	Autocomplete is working with a decent DB behind it.  We use a Patricia tree with the added
      	capability of enumerating forward from a cursor.
      
      	Things that work at this point:
      	- Anything in your history or bookmarks (except from AB or Rendezvous) is findable
      	- autocomplete DB tracks changes to history
      	- results are ordered lexographically (not fancy, but at least the shortest things are first)
      
      	Here's what's getting fixed next:
      
      	- Matching doesn't work if you type http:// or www. as part of your partial string (we only match ignoring the boilerplate).
      	- Changes to bookmarks are not reflected in the autocomplete DB
      	- Results will be ranked so the one you want is always the first one selected, like it's reading your mind.
      	- Reduce conversions from NString to NSURL to NSString to NSURL to...
      
              * BrowserWindowController.m:
              (-[BrowserWindowController windowDidLoad]):  Re-enable feature.
              * CompletionController.m:
              (leftPointsUpward):  Patricia utility function.
              (rightPointsUpward):  Patricia utility function.
              (leftmostChild):  Patricia utility function.
              (+[CompletionController _tree_create]):  Initialize the root node.
              (destroyTree):  recursively free up the tree
              (+[CompletionController _tree_destroy]):  Free the tree.
              (_bitOfString):  Patricia utility function.
              (_leftmostBitOfUnichar):  Patricia utility function.
              (_leftmostDiffBit):  Patricia utility function.
              (_stringFromKey):  Extract the string we index from an item we put in the db (calls _cookedURLString)
              (_findInsertionPoint):  Search the tree for place we would insert a node.
              (_findPotentialNode):  Search for a match in the tree.
              (+[CompletionController _tree_addItem:]):   Add an item.
              (+[CompletionController _tree_deleteItem:]):   Delete an item.
              (+[CompletionController _tree_findItem:cursor:]):   Find and item, setting cursor.
              (+[CompletionController _tree_nextItemUsingCursor:]):  Get next item.
              (+[CompletionController _tree_setCursorAtStart:]):  Set cursor (only for debug now)
              (DumpAutoCompleteTree):  Debugding dump.
              (_cookedURLString):  Strips off boilerplate like "http://www." from a URL
              (+[CompletionController _addBookmarkTree:]):  Recursively adds bookmarks to the tree.
              (+[CompletionController _loadDB]):  Adds bookmarks and history to the tree.
              (-[CompletionController _executeQuery]):  Looks up a result set given a user's partial string.
              (+[CompletionController _registerForNotifications]):  Listen for history changes.
              (+[CompletionController _historyAdded:]):  Update db on history change.
              (+[CompletionController _historyRemoved:]):  Update db on history change.
              (+[CompletionController _reloadDB:]):  Update db on history change.
              (-[CompletionController _buildUI]):  Make popdown window slightly transparent.
              (-[CompletionController _reflectSelectedRow]):  Properly add completion text to user's partial
      	text.  ("http://www." no longer hardwired)
              (-[CompletionController tableView:objectValueForTableColumn:row:]):  Handle bookmarks as
      	well as WebHistoyItems.
              * GlobalHistory.m:
              (-[GlobalHistory _registerForHistoryNotifications]):  Register for new WebHistory notifications.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b70c8f5
  18. 21 Nov, 2002 1 commit
    • darin's avatar
      WebFoundation: · 660071d4
      darin authored
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
      WebCore:
      
      	- fixed 3107383 -- clicking link on cnet.com leads to assertion failure
      
      	When we removed a frame, we were leaving behind an empty WebView. Yuck.
      
              * kwq/KWQScrollView.mm:
              (QScrollView::addChild): Use the new getOuterView.
              (QScrollView::removeChild): Ditto. This was the bug fix.
              * kwq/KWQWidget.h: Add getOuterView.
              * kwq/KWQWidget.mm:
              (QWidget::frameGeometry): Use the new getOuterView.
              (QWidget::setFrameGeometry): Ditto.
              (QWidget::getOuterView): Added. Does the WebCoreFrameView magic to find
      	the WebView instead of the WebHTMLView. Yuck.
              (QWidget::paint): Use the new getOuterView.
      
      WebKit:
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
      	Unescape the string before executing it, so we don't suffer from bug 3083043
      	here in the javascript: URLs that come from plug-ins.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
      WebBrowser:
      
              * Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]):
      	Fix typo. "Import" the favorites, don't "Imported" them.
      
              * English.lproj/StringsNotToBeLocalized.txt: Let the update
      	script sort this file.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      660071d4
  19. 20 Nov, 2002 1 commit
    • darin's avatar
      WebFoundation: · d076e32b
      darin authored
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      WebKit:
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      WebBrowser:
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
              * Test/PageLoadTestController.m: (-[PageLoadTestController browserWindowClosed]):
      	Explain the world leak check a bit more.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d076e32b
  20. 18 Nov, 2002 1 commit
    • kocienda's avatar
      WebKit: · 357eb7e0
      kocienda authored
      	Added feature to import bookmarks/favorites from MSIE. This
      	fixes Radar 2961230 (import Mac IE bookmarks).
      
              * Bookmarks.subproj/WebBookmarkImporter.h: Added.
              * Bookmarks.subproj/WebBookmarkImporter.m: Added.
              (_breakStringIntoLines):
              (_HREFRangeFromSpec):
              (_HREFTextFromSpec):
              (_linkTextRangeFromSpec):
              (_linkTextFromSpec):
              (-[WebBookmarkImporter initWithPath:group:]):
              (-[WebBookmarkImporter topBookmark]):
              (-[WebBookmarkImporter error]):
              (-[WebBookmarkImporter dealloc]):
              * Bookmarks.subproj/WebBookmarkList.m:
              (-[WebBookmarkList init]): Create the bookmark list object. This
      	was not created with the -init initializer, causing bookmark lists
      	to fail.
              * English.lproj/Localizable.strings:
              * English.lproj/StringsNotToBeLocalized.txt:
              * WebKit.exp:
              * WebKit.pbproj/project.pbxproj:
      
      WebBrowser:
      
      	Added calls in Debug menu to import IE Favorites.
      	No doubt that this code will move somewhere else once
      	we figure out the interaction design for importing
      	bookmarks.
      
              * Debug/DebugUtilities.m:
              (-[DebugUtilities createDebugMenu]):
              (-[BrowserDocument importInteretExplorerBookmarks:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      357eb7e0
  21. 11 Nov, 2002 1 commit
    • darin's avatar
      WebFoundation: · 6172da0a
      darin authored
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
      WebCore:
      
              * kwq/KWQWidget.mm: (QWidget::setCursor): Remove printf I left
      	in by accident.
      
      WebKit:
      
              * Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
              Use fileSystemRepresentationWithPath, not cString, to turn a path into something
              to pass to FSPathMakeRef.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
      WebBrowser:
      
              * BrowserNSStringExtras.m: (-[NSString compareVersionString:]):
      	Use lossyCString so we don't get an exception if a string is bad.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6172da0a
  22. 10 Nov, 2002 2 commits
    • darin's avatar
      WebFoundation: · 3cf5d7ad
      darin authored
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      WebKit:
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      WebBrowser:
      
              * BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]):
      	Add call to _setAutoreleaseDuringLiveResize: so we can live with a smaller
      	footprint when running under SUJagGreen or newer.
      
              * Preferences.subproj/DefaultBrowserController.m:
              (keyValuesMatch): Fix comparison of nils.
              (-[DefaultBrowserController handleApplicationPopUp:withSheetDidEndSelector:]):
      	Fix typo in localization comment.
              * English.lproj/Localizable.strings: Update.
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
              * TextFieldWithControls.m: (-[TextFieldWithControls selectText:]):
      	Add a comment explaining Chris's bug fix.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cf5d7ad
    • darin's avatar
      * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes. · f69a3586
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f69a3586
  23. 06 Nov, 2002 1 commit
  24. 03 Nov, 2002 1 commit
    • darin's avatar
      Tools: · 2bffd8d0
      darin authored
              * Scripts/extract-localizable-strings: Add printf to the list of
      	functions to ignore when finding localizable strings.
      
      WebKit:
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent
      	changes both to the code here and to the extract script.
      
      WebBrowser:
      
              * English.lproj/StringsNotToBeLocalized.txt: Remove some now-unneeded
      	exceptions for strings that don't appear in our code any more.
      
              * English.lproj/Localizable.strings: Re-generated. It appears that
      	John removed two more localizable strings after he generated it.
      	(I had to check because last time I did this I clobbered John's
      	change, and I didn't want to do that again.)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bffd8d0
  25. 01 Nov, 2002 1 commit
    • darin's avatar
      JavaScriptCore: · d9713704
      darin authored
              * kjs/object.cpp: Make the same change Maciej just did, but to the
      	other constructor right next to the one he changed.
      
      WebFoundation:
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      WebKit:
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9713704
  26. 30 Oct, 2002 1 commit
    • darin's avatar
      WebFoundation: · 73831ae6
      darin authored
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      WebKit:
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      WebBrowser:
      
              * English.lproj/Localizable.strings: Regenerated this file.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73831ae6
  27. 26 Oct, 2002 2 commits
    • darin's avatar
      WebCore: · a8052be3
      darin authored
      	- fixed 3068404 -- eliminate all user-visible messages from WebCore
      
              * khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Use runJavaScriptPrompt
      	function instead of the more generic QInputDialog.
      
              * khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::altText): Get
      	submit alt text for input element from the view factory, rather than using
      	i18n, since we don't support that.
              * khtml/html/htmlparser.cpp: (KHTMLParser::handleIsindex): Ditto, for the
      	intro that says "This is a searchable index".
              * khtml/rendering/render_form.cpp:
              (RenderSubmitButton::defaultLabel): Ditto, for "Submit".
              (RenderResetButton::defaultLabel): Ditto, for "Reset".
              (RenderFileButton::slotClicked): Ifdef'd out this unused code that had i18n text in it.
      
              * khtml/xml/xml_tokenizer.cpp:
              (XMLHandler::errorString): Put in an ifdef and a FIXME to avoid i18n.
              (XMLHandler::fatalError): Ditto.
              (XMLTokenizer::finish): Ditto.
      
              * khtml/misc/decoder.cpp: (Decoder::decode): Ifdef'd the check for the first
      	language being "ja", since that's not how we're going to trigger Japanese
      	auto-detect.
      
              * khtml/rendering/render_applet.cpp: (RenderEmptyApplet::RenderEmptyApplet):
      	Turned off the code that does the empty applet label. I don't think it worked,
      	and it used i18n. We'll have to tackle this eventually.
      
              * kwq/KWQKHTMLPartImpl.h: Added runJavaScriptPrompt.
              * kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::runJavaScriptPrompt): Moved the code
      	here that used to be in KWQInputDialog.
      
              * kwq/kdecore/klocale.h: Remove i18n() and KLocale::languageList(), added the functions
      	that are listed below.
              * kwq/KWQKLocale.mm:
              (inputElementAltText): Added specific function for getting one of the very few
      	translated strings that we need in WebCore.
              (resetButtonDefaultLabel): Ditto.
              (searchableIndexIntroduction): Ditto.
              (submitButtonDefaultLabel): Ditto.
              (KLocale::language): Use the view factory to ask for the language code, since there's no
      	public API to get it that WebCore can use.
      
              * kwq/WebCoreViewFactory.h: Add new API for above.
      
              * ForwardingHeaders/qinputdialog.h: Added empty file.
      
              * kwq/qt/qinputdialog.h: Removed.
              * kwq/KWQInputDialog.mm: Removed.
              * WebCore.pbproj/project.pbxproj: Removed QInputDialog files.
      
      WebKit:
      
              * WebCoreSupport.subproj/WebViewFactory.m:
              (-[WebViewFactory inputElementAltText]): Added.
              (-[WebViewFactory resetButtonDefaultLabel]): Added.
              (-[WebViewFactory searchableIndexIntroduction]): Added.
              (-[WebViewFactory submitButtonDefaultLabel]): Added.
              (-[WebViewFactory defaultLanguageCode]): Added.
      
              * English.lproj/Localizable.strings: Update.
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8052be3
    • darin's avatar
      WebCore: · db9d82e2
      darin authored
      	Remove some user-visible strings. We can't have any strings that need
      	localization in WebCore, given our translation strategy.
      
              * khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::encoding):
      	Put APPLE_CHANGES around some i18n dialog code.
              * khtml/khtml_part.cpp: (KHTMLPart::submitForm): Ditto.
              * khtml/rendering/render_frames.cpp:
              (RenderPartObject::slotPartLoadingErrorNotify): Ditto.
              * khtml/ecma/kjs_window.cpp:
              (Window::get): Ditto.
              (Window::scheduleClose): Ditto.
              (WindowFunc::tryCall): Put APPLE_CHANGES in to use JavaScript-specific methods
              in the part of calling the generic ones from KMessageBox.
      
              * ForwardingHeaders/kmessagebox.h: Added (empty file).
      
              * kwq/KWQKHTMLPartImpl.h: Added new runJavaScript functions.
              * kwq/KWQKHTMLPartImpl.mm:
              (KWQKHTMLPartImpl::runJavaScriptAlert): Added.
              (KWQKHTMLPartImpl::runJavaScriptConfirm): Added.
      
              * kwq/WebCoreViewFactory.h: Added runJavaScriptAlertPanelWithMessage and
      	runJavaScriptConfirmPanelWithMessage.
      
              * kwq/kdeui/kmessagebox.h: Removed.
              * kwq/KWQKMessageBox.mm: Removed.
              * WebCore.pbproj/project.pbxproj: Removed the KMessageBox files.
      
      WebKit:
      
              * WebCoreSupport.subproj/WebViewFactory.m:
              (-[WebViewFactory runJavaScriptAlertPanelWithMessage:]): Added.
              (-[WebViewFactory runJavaScriptConfirmPanelWithMessage:]): Added.
      
              * English.lproj/Localizable.strings: Update.
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db9d82e2
  28. 24 Oct, 2002 1 commit
    • darin's avatar
      WebFoundation: · cf5ceb15
      darin authored
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      WebKit:
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      WebBrowser:
      
              * WebBrowser.pbproj/project.pbxproj: Move the new pltsuite
      	into the Test group.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf5ceb15
  29. 23 Oct, 2002 2 commits
    • darin's avatar
      - fix bug where plugins crashed closing a stream that was never opened · 7a3a4bb3
      darin authored
              * Plugins.subproj/WebBaseNetscapePluginStream.h: Change type for parameter of
      	receivedError: to NPReason. It's not NPError.
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream dealloc]): Assert that stream is destroyed by
      	checking stream.ndata.
              (-[WebBaseNetscapePluginStream setResponse:]): Set stream.ndata to nil if the
      	stream is not successfully created by NPP_NewStream.
              (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): Added. Destroys the
      	stream, but only if it's present. Also set stream.ndata to nil. This was the bug fix.
              (-[WebBaseNetscapePluginStream receivedError:]): Call destroyStreamWithReason:.
              (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Call destroyStreamWithReason:.
      
              * English.lproj/Localizable.strings: Update.
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a3a4bb3
    • mjs's avatar
      - fixed 2876448 - The authentication panel should give a note when · 123511fe
      mjs authored
      	the user tried to log in and failed
      
      	Also, made the message different (and more helpful) when the
      	authentication is for a proxy server.
      
              * Panels.subproj/WebAuthenticationPanel.m:
              (-[WebAuthenticationPanel setUpForRequest:]): Use different
      	messages depending on proxy and previous failure count.
      
      	Updated localized strings:
      
      	* English.lproj/Localizable.strings:
              * English.lproj/StringsNotToBeLocalized.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      123511fe
  30. 22 Oct, 2002 1 commit
    • darin's avatar
      Make the panel position itself above the main window. · 0c93b3dd
      darin authored
      	Too bad we can't use a sheet, but this is better than a random position.
      
              * WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m:
              (-[WebJavaScriptTextInputPanel initWithPrompt:text:]):
      	Use the new [NSWindow sizeToFitAndAdjustWindowHeight]
      	and [NSControl sizeToFitAndAdjustWindowHeight].
      
              * Misc.subproj/WebNSControlExtras.h: Added.
              * Misc.subproj/WebNSControlExtras.m: Added.
              * Misc.subproj/WebNSWindowExtras.h: Added.
              * Misc.subproj/WebNSWindowExtras.m: Added.
              * WebKit.pbproj/project.pbxproj: Added above files.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c93b3dd