1. 13 Nov, 2002 6 commits
    • mjs's avatar
      WebKit: · 065a97f9
      mjs authored
      	Pass mime type instead of full response to content policy delegate
      	method, in preparation for merging it with the file URL policy.
      
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient handle:didReceiveResponse:]):
      
      WebBrowser:
      
      	Pass mime type instead of full response to content policy delegate
      	method, in preparation for merging it with the file URL policy.
      
              * BrowserWebController.m:
              (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      065a97f9
    • darin's avatar
      WebCore: · aa70db1b
      darin authored
      	- fixed 3083982 -- Logging into AOL gives null view
      
      	Turns out AOL was using a refresh header, which we were not supporting.
      
              * khtml/khtml_part.h: Declare receivedFirstData, a private member function.
              * khtml/khtml_part.cpp:
              (KHTMLPart::receivedFirstData): Separate out the part of slotData we
      	want to share, which really seems kinda separate anyway.
              (KHTMLPart::slotData): More of the same.
      
              * kwq/KWQKHTMLPart.h: Declare addMetaData.
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::slotData): Call receivedFirstData instead of doing the same
      	thing ourselves.
              (KWQKHTMLPart::addMetaData): Added. Puts metadata into the job.
      
              * kwq/KWQKHTMLPartBrowserExtension.mm:
              (KHTMLPartBrowserExtension::createNewWindow): Fix bug where this was calling
      	openURL: but meant to call loadURL:.
      
              * kwq/WebCoreBridge.h: Add headers to openURL method. Remove setContentType.
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge openURL:withHeaders:]): Handle Content-Type and Refresh.
      	This method is big enough that I should probably move the guts to KWQKHTMLPart.
      
      	- other things
      
              * kwq/KWQListImpl.mm: (KWQListImpl::~KWQListImpl): I overlooked something
      	while doing my "bug fix" in here a while back. Change an assignment statement
      	to an assert.
      
      WebKit:
      
      	- fixed 3083982 -- Logging into AOL gives null view
      
      	Turns out AOL was using a refresh header, which we were not supporting.
      
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
      	Call openURL: and pass headers in.
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]):
      	Pass nil for headers in this case, since we know it's just an anchor change.
      
      	- other things
      
              * WebCoreSupport.subproj/WebBridge.h: Remove dataSourceChanged and dataSource
      	methods. We try to keep the bridge methods down to actual bridging.
              * WebCoreSupport.subproj/WebBridge.m: Remove dataSourceChanged altogether,
      	and move dataSource up in the file.
      
              * WebView.subproj/WebHTMLRepresentation.m:
              (-[WebHTMLRepresentation setDataSource:]): Keep the data source around, so we
      	don't need to ask the bridge for it.
              (-[WebHTMLRepresentation documentSource]): Use it here.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa70db1b
    • trey's avatar
      Fixed 3100084 - REGRESSION: web page is not first responder after visiting web page · 3795ae7e
      trey authored
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSource _commitIfReady]):  Make the rep before _transitionToCommitted.  This is the way it used to be.
              (-[WebDataSource _makeRepresentation]):  Don't make the docView here.
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _transitionToCommitted]):  Make the docView here, after we save the scroll state but before notifying the delegate.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3795ae7e
    • darin's avatar
      - fixed 3100013 -- REGRESSION: Can't get results from i-Bench anymore · 6208ff60
      darin authored
              * WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]):
      	Don't set the state to WebFrameStateComplete if it has already been set
      	to WebFrameStateProvisional. If it has, that means we already began a new
      	load; that one is not yet complete.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6208ff60
    • sullivan's avatar
      2002-11-13 John Sullivan <sullivan@apple.com> · ce6f6df4
      sullivan authored
      	- fixed 3099922 -- REGRESSION: Back button always pops up menu
      
              * Misc.subproj/WebNSViewExtras.h:
              * Misc.subproj/WebNSViewExtras.m:
              (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]:
      	Fixed a copy/paste error I made yesterday -- this method was never
      	noticing the mouse-up events because it was checking the event type
      	against the wrong number. Also changed the hysteresis values from
      	unsigneds to floats (unsigned was just wrong).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce6f6df4
    • mjs's avatar
      WebCore: · 368154da
      mjs authored
      	- fixed 3050447 - Policy handlers have no way of telling client
      	that the proposed navigation is a form post
      
              * khtml/khtml_part.cpp:
              (KHTMLPart::submitForm): Call kwq->submitForm
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::openURL): Adjusted for bridge API change.
              (KWQKHTMLPart::openURLRequest): Removed POST handling.
      	(KWQKHTMLPart::submitForm): Added this back, because we need to
      	know what URL navigations are caused by form submission, even if
      	they are not POSTs.
              (KWQKHTMLPart::urlSelected): Adjusted for bridge API change.
              * kwq/WebCoreBridge.h: Add triggeringEvent: parameter to postURL:
      	and isFormSubmission: parameter to loadURL:.
      
      WebKit:
      
      	- fixed 3050447 - Policy handlers have no way of telling client
      	that the proposed navigation is a form post
      
      	Now we pass form submissions through all the normal policy steps.
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]):
              (-[WebBridge postWithURL:data:contentType:triggeringEvent:]):
              (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
              * WebView.subproj/WebDataSourcePrivate.h:
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSourcePrivate dealloc]):
              (-[WebDataSource _setTriggeringAction:]):
              (-[WebDataSource _triggeringAction]):
              (-[WebDataSource _lastCheckedRequest]):
              (-[WebDataSource _setLastCheckedRequest:]):
              * WebView.subproj/WebFrame.m:
              (-[WebFrame setProvisionalDataSource:]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _shouldShowRequest:]):
              (-[WebFrame _loadRequest:triggeringAction:]):
              (-[WebFrame _actionInformationForNavigationType:event:]):
              (-[WebFrame _continueAfterNavigationPolicyForRequest:dataSource:]):
              (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]):
              (-[WebFrame _loadURL:intoChild:]):
              (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      368154da
  2. 12 Nov, 2002 10 commits
    • mjs's avatar
      WebKit: · 8e4ec943
      mjs authored
      	Combine click policy and URL policy into navigation policy.
      
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              (-[WebDefaultPolicyDelegate navigationPolicyForAction:andRequest:inFrame:]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _shouldShowRequest:]):
              (-[WebFrame _actionInformationForNavigationType:event:]):
              (-[WebFrame _continueAfterFileURLPolicyForRequest:]):
              (-[WebFrame _continueAfterNavigationPolicyForRequest:event:]):
              (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
      
      WebBrowser:
      
      	Combined click policy and URL policy into navigation policy.
      
              * BrowserDocument.m:
              (-[BrowserDocument goToRequest:]):
              * BrowserWebController.m:
              (-[BrowserWebController navigationPolicyForAction:andRequest:inFrame:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e4ec943
    • trey's avatar
      fixed 3096030 - Crash in -[WebBackForwardList goToEntry:] when playing with... · b613789e
      trey authored
      	fixed 3096030 - Crash in -[WebBackForwardList goToEntry:] when playing with SnapBack and dictionary.com
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _isLoadComplete]):  Set state=completed only after we tell the bridge to
      	end the load.  This allows client redirects to be processed before we think we're complete.
              (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
      	Only process client redirects as such if we are not already complete.  This makes JS driven
      	navigations after load-time work like the user would expect, as normal navigations.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b613789e
    • mjs's avatar
      - fixed 3099487 - REGRESSION: dragging an image always puts it in · f07e9c04
      mjs authored
      	the download directory
      
              * WebView.subproj/WebControllerPrivate.h:
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebController _downloadURL:]): Call _downloadURL:toPath: with nil path.
      	(-[WebController _downloadURL:toPath:]): New method that
      	predetermines the path to download to (needed for DnD).
              * WebView.subproj/WebHTMLView.m:
      	(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use
      	_downloadURL:toPath:
              * WebView.subproj/WebImageView.m:
      	(-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): Use
      	_downloadURL:toPath:
              * WebView.subproj/WebMainResourceClient.m:
      	(-[WebMainResourceClient handle:didReceiveResponse:]): Don't ask
      	delegate for download path if we already have one.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f07e9c04
    • rjw's avatar
      Fixed likely cause of 3099047 (and others). Width buffer could underrun in · b4635089
      rjw authored
              some situations.
      
              * WebCoreSupport.subproj/WebTextRenderer.m:
              (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4635089
    • sullivan's avatar
      WebKit: · 8518f7bc
      sullivan authored
              * Misc.subproj/WebNSViewExtras.h:
              * Misc.subproj/WebNSViewExtras.m:
              (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]):
      	new method
              (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:]):
      	now calls the new method, passing the default hysteresis values
      
      WebBrowser:
      
      	- fixed 3096528 -- don't let initially-horizontal drags of
      	toolbar bookmarks escape from toolbar
      
      	Unfortunately I left behind a drawing glitch, recorded as
      	bug 3099488. Ideas to fix this are hereby solicited.
      
              * FavoritesBar.m:
              (-[FavoritesBar slideButtonsIntoPlace]):
      	renamed from repositionButtons for clarity
              (-[FavoritesBar maxButtonX]):
      	new method, extracted from _layOutButtons
              (-[FavoritesBar _layOutButtons]):
      	now calls maxButtonX
              (-[FavoritesBar setDropIndex:]):
      	updated for name change
              (-[FavoritesBar specialBookmarkSourcesCount]):
      	new method, extracted from duplicated code
              (-[FavoritesBar lastNonFavoriteIndex]):
      	new method, extracted from dropIndexFromDraggingInfo:
              (-[FavoritesBar dropIndexFromLocalPoint:]):
      	new method, extracted from dropIndexFromDraggingInfo:
              (-[FavoritesBar dropIndexFromDraggingInfo:]):
      	now calls dropIndexFromLocalPoint:
              (-[FavoritesBar addDroppedBookmarks:atIndex:]):
      	new method, extracted from performDragOperation:
              (-[FavoritesBar performDragOperation:]):
      	now calls addDroppedBookmarks:atIndex:
              (-[FavoritesBar _lastDraggedEventFollowing:]),
              (-[FavoritesBar _lastDraggedOrUpEventFollowing:]):
      	new methods, cribbed from AppKit
              (-[FavoritesBar constrainProposedButtonFrame:]):
      	new method
              (-[FavoritesBar reorderFavoriteButton:fromMouseDownEvent:]):
      	new method, drags (but not using CoreDragging stuff) button
      	horizontally within bar only
      
              * FavoritesBarView.h:
      	added definition of FavoritesBarReorderingDelegate informal protocol
              * FavoritesBarView.m:
              (-[FavoritesBarView reorderFavoriteButton:fromMouseDownEvent:]):
      	pass call through to delegate (FavoritesBar)
      
              * FavoriteButton.m:
              (-[FavoriteButton currentEventOffsetFromEvent:]):
      	new method, extracted from performDragFromEvent:
              (-[FavoriteButton performDragFromEvent:]):
      	now calls extracted method
              (-[FavoriteButton canDrag]):
      	renamed from canDragButton; now checks whether superview is a
      	FavoritesBarView
              (-[FavoriteButton mouseDown:]):
      	checks whether initial dragging movement was primarily vertical or
      	horizontal; if horizontal, calls new reordering code; if vertical,
      	uses larger hysteresis to minimize accidental poofing
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8518f7bc
    • rjw's avatar
      Implemented letter-spacing and word-spacing CSS properties. · 16de6614
      rjw authored
              * khtml/rendering/font.cpp:
              (Font::drawText):
              (Font::floatWidth):
              (Font::floatCharacterWidths):
              * kwq/KWQFontMetrics.h:
              * kwq/KWQFontMetrics.mm:
              (QFontMetrics::width):
              (QFontMetrics::floatWidth):
              (QFontMetrics::floatCharacterWidths):
              * kwq/KWQPainter.h:
              * kwq/KWQPainter.mm:
              (QPainter::drawText):
              * kwq/WebCoreTextRenderer.h:
      
              Implemented letter-spacing and word-spacing CSS properties.
      
              * Misc.subproj/WebStringTruncator.m:
              (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
              (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
              * WebCoreSupport.subproj/WebTextRenderer.h:
              * WebCoreSupport.subproj/WebTextRenderer.m:
              (-[WebTextRenderer widthForCharacters:length:]):
              (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:letterSpacing:wordSpacing:]):
              (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]):
              (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]):
              (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:]):
              (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):
      
              Changed to reflect method name change.
      
              * EtchedStringView.m:
              (-[EtchedStringView drawRect:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16de6614
    • mjs's avatar
      WebKit: · ee9af3e5
      mjs authored
      	Removed policy classes and instead use the policy enums directly,
      	since we no longer hold the path in the enum.
      
              * Downloads.subproj/WebDownloadHandler.m:
              * WebKit.exp:
              * WebKit.pbproj/project.pbxproj:
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebControllerPolicyDelegate.m:
              * WebView.subproj/WebControllerPolicyDelegatePrivate.h: Removed.
              * WebView.subproj/WebControllerPrivate.m:
              * WebView.subproj/WebDefaultPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              (+[WebDefaultPolicyDelegate defaultURLPolicyForRequest:]):
              (-[WebDefaultPolicyDelegate URLPolicyForRequest:inFrame:]):
              (-[WebDefaultPolicyDelegate fileURLPolicyForMIMEType:andRequest:inFrame:]):
              (-[WebDefaultPolicyDelegate unableToImplementPolicy:error:forURL:inFrame:]):
              (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame handleUnimplementablePolicy:errorCode:forURL:]):
              (-[WebFrame _shouldShowRequest:]):
              (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient handle:didReceiveResponse:]):
      
      WebBrowser:
      
      	Adjusted for WebKit API changes.
      
              * BrowserDocument.m:
              (-[BrowserDocument goToRequest:]):
              * BrowserWebController.m:
              (-[BrowserWebController URLPolicyForRequest:inFrame:]):
              (-[BrowserWebController unableToImplementPolicy:error:forURL:inFrame:]):
              (-[BrowserWebController fileURLPolicyForMIMEType:andRequest:inFrame:]):
              (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:]):
              (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee9af3e5
    • mjs's avatar
      Keep the triggering event around on the data source, so it can be · 8f95bacf
      mjs authored
      	used with redirects.
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadRequest:triggeringEvent:]):
              (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
              (-[WebFrame _postWithURL:data:contentType:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f95bacf
    • darin's avatar
      WebCore: · c26ab578
      darin authored
      	- fixed 3083043 -- Alex doesn't decode % sequences in javascript: URLs
      
      	Some places here did KURL::decode_string, but others didn't.
      
              * khtml/khtml_part.cpp:
              (KHTMLPart::slotShowDocument): Added call to KURL::decode_string.
              (KHTMLPart::overURL): Ditto.
              (KHTMLPart::urlSelected): Ditto.
              (KHTMLPart::requestFrame): Ditto.
              (KHTMLPart::slotChildURLRequest): Ditto.
      
      WebKit:
      
      	- improved the code that manages observing the window and superview
      
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView addSuperviewObservers]): Added.
              (-[WebHTMLView removeSuperviewObservers]): Added.
              (-[WebHTMLView addWindowObservers]): Added.
              (-[WebHTMLView removeWindowObservers]): Added.
              (-[WebHTMLView viewWillMoveToSuperview:]): Call removeSuperviewObservers.
              (-[WebHTMLView viewDidMoveToSuperview]): Call addSuperviewObservers.
              (-[WebHTMLView viewWillMoveToWindow:]): Call removeWindowObservers and
      	removeSuperviewObservers.
              (-[WebHTMLView viewDidMoveToWindow]): Call addWindowObservers and
      	addSuperviewObservers.
      
      WebBrowser:
      
      	- fixed 3083043 -- Alex doesn't decode % sequences in javascript: URLs
      
              * BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]):
      	Call CFURLCreateStringByReplacingPercentEscapes on the URL fragment before
      	passing it to stringByEvaluatingJavaScriptFromString:.
              * BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocation:]):
      	Ditto.
      
      	- fixed world leaks seen when playing with the snippet window
      
              * Debug/SnippetController.m:
              (-[SnippetController dealloc]): Release the location change delegate to avoid a leak.
      	Also release the data source now that we retain it.
              (-[SnippetController windowWillClose:]): Release everything here. If we don't we get
      	a world leak. Also remove the WebView from the superview. If we don't, it leaks.
      	At some point we should look into this because it may indicate a WebKit problem, so
      	I marked it with a FIXME.
              (-[SnippetController load]): Retain the data source.
              (-[SnippetController loadComplete]): Release the old text storage.
      
              * Debug/SnippetController.h: Tweaks.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c26ab578
    • mjs's avatar
      WebKit: · f774070a
      mjs authored
      	Remove contentPolicy parameter from _downloadURL, and remove
      	remaining traces of path from policy object.
      
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebControllerPolicyDelegate.m:
              (-[WebPolicyPrivate dealloc]):
              (+[WebURLPolicy webPolicyWithURLAction:]):
              (+[WebFileURLPolicy webPolicyWithFileAction:]):
              (+[WebContentPolicy webPolicyWithContentAction:]):
              (+[WebClickPolicy webPolicyWithClickAction:]):
              * WebView.subproj/WebControllerPolicyDelegatePrivate.h:
              * WebView.subproj/WebControllerPrivate.h:
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebController _downloadURL:]):
              * WebView.subproj/WebDefaultContextMenuDelegate.m:
              (-[WebDefaultContextMenuDelegate downloadURL:]):
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
              * WebView.subproj/WebImageView.m:
              (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]):
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient handle:didReceiveResponse:]):
      
      WebBrowser:
      
      	Don't pass path when making policy objects.
      
              * BrowserWebController.m:
              (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:]):
              (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f774070a
  3. 11 Nov, 2002 8 commits
    • darin's avatar
      WebFoundation: · 6172da0a
      darin authored
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
      WebCore:
      
              * kwq/KWQWidget.mm: (QWidget::setCursor): Remove printf I left
      	in by accident.
      
      WebKit:
      
              * Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
              Use fileSystemRepresentationWithPath, not cString, to turn a path into something
              to pass to FSPathMakeRef.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
      WebBrowser:
      
              * BrowserNSStringExtras.m: (-[NSString compareVersionString:]):
      	Use lossyCString so we don't get an exception if a string is bad.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6172da0a
    • darin's avatar
      WebCore: · 3d0b472f
      darin authored
      	- tighten up cursor handling a bit more
      
              * kwq/KWQWidget.mm:
              (QWidget::setCursor): Use setDocumentCursor: instead of our own protocol.
              (QWidget::cursor): Use documentCursor instead of storing our own cursor.
      
              * kwq/WebCoreFrameView.h: Remove setCursor: method.
      
      WebKit:
      
      	- tighten up cursor handling a bit more
      
              * WebView.subproj/WebDynamicScrollBarsView.m:
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView addMouseMovedObserver]): Call _frameOrBoundsChanged
      	so we emit a mouse moved event right away.
              (-[WebHTMLView viewWillMoveToSuperview:]): Remove the colon since I
      	removed the parameter from _frameOrBoundsChanged.
      
              * WebView.subproj/WebHTMLViewPrivate.h: Declare _frameOrBoundsChanged.
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebHTMLView _frameOrBoundsChanged]): Remove parameter.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d0b472f
    • trey's avatar
      Fixed 3015884 - Reloading a page should remember the scroll position · c854feb0
      trey authored
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _transitionToCommitted]):  Save scroll position on reload
              (-[WebFrame _isLoadComplete]):  Restore position on reload
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c854feb0
    • trey's avatar
      First checkin of making frames work with the back forward list, restoring... · 9ca0d00f
      trey authored
      First checkin of making frames work with the back forward list, restoring scroll position and form state.  Fixing:
      
      3014555 Lose frameset context going back/forward
      3078151 History inconsistency after loading frame content
      3089551 REGRESSION: www.bmwusa.com frames don't load in alex-30
      3095878 refresh doesn't preserve frame state
      
      WebCore:
      
              * khtml/khtml_part.cpp:
              (KHTMLPart::requestFrameName):  Call through bridge to get generated frame name.
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::generateFrameName):  New call that just forwards through the bridge.
              * kwq/WebCoreBridge.h:
      
      WebKit:
      
              * History.subproj/WebBackForwardList.m:
              (-[WebBackForwardList addEntry:]):  Yank code to avoid adding a duplicate entry, to catch the
      	refresh case.  That's dealt with in WebFramePrivate now.
              (-[WebBackForwardList description]):  Enhanced to print more info.
      
              * History.subproj/WebHistoryItem.h:
      	History items now hold an array of subitems to mirror the frame tree.  One item in the tree
      	is designated the target of the navigation.
              * History.subproj/WebHistoryItem.m:
              (-[WebHistoryItem dealloc]):  Release new ivars.
              (-[WebHistoryItem isTargetItem]):
              (-[WebHistoryItem setIsTargetItem:]):
      	New setter and setter.
              (-[WebHistoryItem _recurseToFindTargetItem]):
              (-[WebHistoryItem targetItem]):
      	Search the tree to find the target item.
              (-[WebHistoryItem children]):
              (-[WebHistoryItem addChildItem:]):
              (-[WebHistoryItem childItemWithName:]):
      	Maintain and search new child item list.
              (-[WebHistoryItem description]):
      	Enhanced to print out the tree of items.
              (-[WebHistoryItem dictionaryRepresentation]):
              (-[WebHistoryItem initFromDictionaryRepresentation:]):
      	Save and load the new state.
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge generateFrameName]):  New call from KWQ, just forwards to Frame.
              (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
      	Call new frame method dedicated to this case.
              (-[WebBridge saveDocumentState:]):
              (-[WebBridge documentState]):
      	Call frame methods to get the right item to save/restore to/from.
      
              * WebView.subproj/WebController.m:
              (-[WebController _goToItem:withLoadType:]):  Stop any current loading before going to a new item.
              (-[WebController goBack]):
              (-[WebController goForward]):
              (-[WebController goBackOrForwardToItem:]):  Name change of private method (for consistency)
      
              * WebView.subproj/WebDataSourcePrivate.h:
      	ProvisionalItem and PreviousItem are moved back up to WebFrame, where we know more about the
      	state transitions that happen during loading.
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSourcePrivate dealloc]): Don't release removed ivars.
              (-[WebDataSource _commitIfReady]): Make the view representations -after- the transition to committed.
      	This allows us to save away the scroll location successfully, since making the view was resetting it.
              * WebView.subproj/WebFrame.h:
              * WebView.subproj/WebFrame.m:
              (-[WebFrame setProvisionalDataSource:]):  Saving the scroll location has moved elsewhere to handle frames.
              (-[WebFrame stopLoading]):  Skip all the work if we're already state=complete.
      
              * WebView.subproj/WebFramePrivate.h:
      	The frame now holds a ref to the current, previous and provisional back-forward items.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFramePrivate dealloc]):  Release new state.
              (-[WebFramePrivate setProvisionalItem:]):
              (-[WebFramePrivate setPreviousItem:]):
              (-[WebFramePrivate setCurrentItem:]):	New setters (1 line getters were missed by script)
              (-[WebFrame _addBackForwardItemClippedAtTarget:]):  Adds a BF item to the top of the BF list.
              (-[WebFrame _createItem]):  Create a single BF item.
              (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):  Create a tree of BF items, which
      	mirror the frame tree.
              (-[WebFrame _immediateChildFrameNamed:]):  New frame search utility (doesn't recurse)
              (-[WebFrame _detachFromParent]):  Save the scroll position when detaching a frame.
              (-[WebFrame _transitionToCommitted]):  Maintain new item ivars.  Save scroll position when
      	appropriate.  Hook up items for child frames to their parent, as they are created.
              (-[WebFrame _setState:]):  Clear previousItem whenever we reach committed.
              (-[WebFrame _isLoadComplete]):  Clear previousItem if we are committed.
              (-[WebFrame _childFramesMatchItem:]):  Does the frame's frame tree match the one held by the item?
              (-[WebFrame _loadItem:fromItem:withLoadType:]):  Only do simple anchor navigation if the frame
      	has no children (fixes oddball corner case with a frame reloading itself).  Set provisional item.
              (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):  Heart of returning to an item that had
      	frames.  We either find that the existing content is good, or initiate a load.
              (-[WebFrame _goToItem:withLoadType:]):  Adjust the BF list cursor, and recurse to do the work.
              (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):  Only do anchor-style nav if
      	the destination URL has a fragment.  Save scroll position.
              (-[WebFrame _loadURL:intoChild:]):  If returning to an item with frames, possibly replace the
      	new content with the stuff that was there at the time, substituting the URL.
              (-[WebFrame _saveScrollPositionToItem:]):  Don't croak on nil item or view.
              (-[WebFrame _restoreScrollPosition]):  Do croak (ASSERT) on nil item.
              (-[WebFrame _scrollToTop]):  Nit cleanup.
              (-[WebFrame _addFramePathToString:]):  Add a component for our frame to the frame name we're generating.
              (-[WebFrame _generateFrameName]):  Generate a frame name that is repeatable.
              (-[WebFrame _itemForSavingDocState]):  Returns correct item to use for formstate save.
              (-[WebFrame _itemForRestoringDocState]):  Returns correct item to use for formstate restore
      
      WebBrowser:
      
              * BrowserDocument.m:
              (-[BrowserDocument _addItem:toMenu:]):
      	For a back-forward item that's a tree because its for a frameset, use the
      	right item of the tree to generate the menu contents.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ca0d00f
    • mjs's avatar
      WebKit: · 6bf718ab
      mjs authored
      	Store path and the fact that we're downloading in the data source,
      	instead of storing the content policy.
      
              * Downloads.subproj/WebDownloadHandler.m:
              (-[WebDownloadHandler cleanUpAfterFailure]):
              (-[WebDownloadHandler createFileIfNecessary]):
              (-[WebDownloadHandler finishedLoading]):
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebController _downloadURL:withContentPolicy:]):
              * WebView.subproj/WebDataSource.h:
              * WebView.subproj/WebDataSource.m:
              (+[WebDataSource registerRepresentationClass:forMIMEType:]):
              (-[WebDataSource isDownloading]):
              (-[WebDataSource downloadPath]):
              * WebView.subproj/WebDataSourcePrivate.h:
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSourcePrivate dealloc]):
              (-[WebDataSource _commitIfReady]):
              (-[WebDataSource _setIsDownloading:]):
              (-[WebDataSource _setDownloadPath:]):
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient receivedError:]):
              (-[WebMainResourceClient handle:didReceiveResponse:]):
              (-[WebMainResourceClient handleDidFinishLoading:]):
      
      WebBrowser:
      
      	Adjusted for WebKit API changes.
      
              * DownloadProgressEntry.m:
              (+[DownloadProgressEntry entryWithDataSource:]):
              (-[DownloadProgressEntry path]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bf718ab
    • mjs's avatar
      WebKit: · 5fa22083
      mjs authored
      	Don't ask for the content policy any more if the previous policies
      	said to save - in effect this means to ask only if the previous
      	policies said to use the content policy. Also, remove now-useless
      	previous content policy parameter from content policy delegate.
      
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebDataSourcePrivate.m:
      	(-[WebDataSource _setContentPolicy:]): Retain new policy before
      	releasing the old one.
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              * WebView.subproj/WebMainResourceClient.m:
      	(-[WebMainResourceClient handle:didReceiveResponse:]): Don't ask
      	for content policy if the delegate already decided to save.
      
      WebBrowser:
      
      	Adjusted for WebKit API change.
      
              * BrowserWebController.m:
              (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fa22083
    • mjs's avatar
      WebKit: · df04e848
      mjs authored
      	Added new policy delegate callback to get the filename - this
      	won't be up to the content policy any more.
      
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              (-[WebDefaultPolicyDelegate saveFilenameForResponse:andRequest:]):
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient handle:didReceiveResponse:]):
      
      WebBrowser:
      
      	Added new policy delegate callback to get the filename - this
      	won't be up to the content policy any more.
      
              * BrowserWebController.m:
              (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]):
              (-[BrowserWebController saveFilenameForResponse:andRequest:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df04e848
    • darin's avatar
      WebCore: · 0770f3e6
      darin authored
              * kwq/WebCoreBridge.h: Remove unused modifierTrackingEnabled method.
      
      WebKit:
      
      	- made some improvements to cursor setting for greater speed and correctness
      
              * WebView.subproj/WebDynamicScrollBarsView.m:
              (-[WebDynamicScrollBarsView setCursor:]): Just use setDocumentCursor: instead of
      	our own logic. This allows us to remove code and may fix some bugs or anomalies as well.
              (-[WebDynamicScrollBarsView dealloc]): Release the cursor. I think we were leaking before.
      
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView viewWillMoveToSuperview:]): Use _frameOrBoundsChanged: method now, which
      	has been moved into the private file.
              (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Don't bother finding
      	topmost WebHTMLView to call _updateMouseoverWithEvent: on; now it works fine no matter
      	which level it's called at.
      
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebHTMLView _frameOrBoundsChanged:]): Moved the code here that was formerly in the
      	_setNeedsLayoutIfSizeChanged method, also added code that does _updateMouseoverWithEvent:
      	so that we get properly updated cursor when we scroll.
              (-[WebHTMLView _updateMouseoverWithEvent:]): Remove unneeded assert. This method works
      	equally well no matter which WebHTMLView calls it; everything is done at the window and
      	controller level.
      
              * WebView.subproj/WebControllerPrivate.h: Added lastElementWasNotNil field and
      	_mouseDidMoveOverElement:modifierFlags: method.
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebController _mouseDidMoveOverElement:modifierFlags:]): Call through to the delegate,
      	but don't do multiple calls if they are all nil.
      
              * WebCoreSupport.subproj/WebBridge.m: Remove unused modifierTrackingEnabled method.
              * WebView.subproj/WebHTMLViewPrivate.h: Remove unused _setModifierTrackingEnabled and
      	_modifierTrackingEnabled methods.
      
      WebBrowser:
      
              * AppController.m: (-[AppController awakeFromNib]): Remove unneeded call to set
      	unused modifierTrackingEnabled flag. The code that used to care about this flag
              is now in WebBrowser and there's no need to inform WebCore and WebKit about whether
              we are passing in flags-changed events.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0770f3e6
  4. 10 Nov, 2002 3 commits
    • darin's avatar
      WebFoundation: · 3cf5d7ad
      darin authored
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      WebKit:
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      WebBrowser:
      
              * BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]):
      	Add call to _setAutoreleaseDuringLiveResize: so we can live with a smaller
      	footprint when running under SUJagGreen or newer.
      
              * Preferences.subproj/DefaultBrowserController.m:
              (keyValuesMatch): Fix comparison of nils.
              (-[DefaultBrowserController handleApplicationPopUp:withSheetDidEndSelector:]):
      	Fix typo in localization comment.
              * English.lproj/Localizable.strings: Update.
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      
              * TextFieldWithControls.m: (-[TextFieldWithControls selectText:]):
      	Add a comment explaining Chris's bug fix.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cf5d7ad
    • cblu's avatar
      WebFoundation: · 76ee1a37
      cblu authored
      	Made WebCacheObject and WebResourceResponse methods that refer to specific dates set and return NSDates rather than NSTimeIntervals. Our public methods now only use NSTimeIntervals when referring to differences in time. Made the methods that use NSTimeIntervals when referring to specific dates private.
      
              * CacheLoader.subproj/WebCacheObject.h:
              * CacheLoader.subproj/WebCacheObject.m:
              (-[WebCacheObject createdDate]):
              (-[WebCacheObject setCreatedDate:]):
              (-[WebCacheObject expiresDate]):
              (-[WebCacheObject setExpiresDate:]):
              (-[WebCacheObject lastModifiedDate]):
              (-[WebCacheObject setLastModifiedDate:]):
              (-[WebCacheObject maxAgeValue]):
              (-[WebCacheObject isExpired]):
              (-[WebCacheObject age]):
              (-[WebCacheObject freshnessLifetime]):
              (-[WebCacheObject dealloc]):
              (-[WebCacheObject _createdTime]):
              (-[WebCacheObject _setCreatedTime:]):
              (-[WebCacheObject _expiresTime]):
              (-[WebCacheObject _setExpiresTime:]):
              (-[WebCacheObject _lastModifiedTime]):
              (-[WebCacheObject _setLastModifiedTime:]):
              * CacheLoader.subproj/WebCacheObjectPrivate.h: Added.
              * CacheLoader.subproj/WebResourceResponse.h:
              * CacheLoader.subproj/WebResourceResponse.m:
              (-[WebResourceResponse createdDate]):
              (-[WebResourceResponse lastModifiedDate]):
              (-[WebResourceResponse _createdTime]):
              (-[WebResourceResponse _lastModifiedTime]):
              (-[WebResourceResponse _takePersistentValuesFrom:]):
              * CacheLoader.subproj/WebResourceResponsePrivate.h:
              * ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m:
              (-[WebCFNetworkHTTPProtocolHandler addIfModifiedSinceHeader:]):
              (-[WebCFNetworkHTTPProtocolHandler continueHeaderReadAfter3xxResponseAndCall:]):
              * ProtocolHandlers.subproj/WebHTTPProtocolHandler.m:
              (-[WebHTTPProtocolHandler willCacheObject:]):
              * ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m:
              (-[WebSimpleHTTPProtocolHandler _createHTTPRequest]):
              (-[WebSimpleHTTPProtocolHandler _examineHeaders]):
              * WebFoundation.pbproj/project.pbxproj:
      
      WebKit:
      
      	Fixed: 3021681 - downloaded files' creation and modification dates are not set
      
              * Downloads.subproj/WebDownloadHandler.m:
              (-[WebDownloadHandler createFileIfNecessary]): call [response creationDate] and [response lastModifiedDate] when setting file attributes.
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream setResponse:]): call [response lastModifiedDate] when giving content to plug-ins.
      
      WebBrowser:
      
      	Possible fix for: 3096071 - Button under "Proxy settings" in preferences window needs implementation
      
      	With the new Network Pref root, the proxy button seems to work %50 of the time. 3096071 may be fixed if the current problem is just a bug in the network pref.
      
              * Preferences.subproj/GeneralPreferences.m:
              (-[GeneralPreferences _launchNetworkPrefs]): code from Robert Ulrich
              (-[GeneralPreferences openProxyPreferences:]): call _launchNetworkPrefs
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76ee1a37
    • darin's avatar
      * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes. · f69a3586
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f69a3586
  5. 09 Nov, 2002 4 commits
    • darin's avatar
      - fixed 3095156 -- reproducible leak of WebDataSource due to bad URL in stylesheet · fe7bfc7b
      darin authored
              * WebCoreSupport.subproj/WebSubresourceClient.m:
              (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
      	Check for errors by looking at the return value from loadWithRequest: rather than
      	making a separate call to canInitWithRequest.
      
              * WebView.subproj/WebBaseResourceHandleDelegate.h: Add boolean success/failure result
      	loadWithRequest:.
              * WebView.subproj/WebBaseResourceHandleDelegate.m:
              (-[WebBaseResourceHandleDelegate loadWithRequest:]): Return NO if we fail to make a handle.
      
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]):
      	Check result of loadWithRequest: and complain if it's NO.
      
              * WebView.subproj/WebMainResourceClient.m: Tweak whitespace.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe7bfc7b
    • cblu's avatar
      WebKit: · 9e186994
      cblu authored
      	Fixed: 2991610 - Alexander should support services, including Speech
      
              * WebView.subproj/WebHTMLView.m:
              (+[WebHTMLView initialize]): register for service types
              (-[WebHTMLView dealloc]): moved to top of file
              (-[WebHTMLView copy:]): call _writeSelectionToPasteboard
              (-[WebHTMLView writeSelectionToPasteboard:types:]): call _writeSelectionToPasteboard
              (-[WebHTMLView validRequestorForSendType:returnType:]): return self for our pboard types
              * WebView.subproj/WebHTMLViewPrivate.h:
              * WebView.subproj/WebHTMLViewPrivate.m:
              (+[WebHTMLView _pasteboardTypes]): new, returns the array of supported pboard types
              (-[WebHTMLView _writeSelectionToPasteboard:]): new, adds data to pboard
              * WebView.subproj/WebImageView.m:
              (-[WebImageView initialize]): register for service types
              (-[WebImageView validateUserInterfaceItem:]): respond to copy
              (-[WebImageView validRequestorForSendType:returnType:]): return self for images
              (-[WebImageView writeImageToPasteboard:]): writes image data to pboard
              (-[WebImageView copy:]): calls writeImageToPasteboard
              (-[WebImageView writeSelectionToPasteboard:types:]): calls writeImageToPasteboard
      
      WebBrowser:
      
      	Open the URL in a new window as we do for other externally opened URLs.
      
              * ServicesProvider.m:
              (-[ServicesProvider openURL:userData:error:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e186994
    • darin's avatar
      * History.subproj/WebHistoryItem.m: · 15aa01ee
      darin authored
              (-[WebHistoryItem setTitle:]): Use display title if it matches, so
      	we don't end up with two identical strings, as when reading from
      	the property list.
              (-[WebHistoryItem setDisplayTitle:]): The same thing, the other way round.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15aa01ee
    • darin's avatar
      - fixed 3095078 -- image loop counts still not handled right · a04f2e3b
      darin authored
              * WebCoreSupport.subproj/WebImageRenderer.m:
              (-[WebImageRenderer blockHasGIFExtensionSignature:length:]): Look for the tag
      	"NETSCAPE2.0", not "NETSCAPE1.0".
              (-[WebImageRenderer nextFrame:]): Remove special handling for last frames with
      	a duration of 0. That was just a misunderstanding.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a04f2e3b
  6. 08 Nov, 2002 8 commits
    • darin's avatar
      * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]): · dd47b022
      darin authored
      	Slightly better fix. Essentially just take out the assert.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd47b022
    • darin's avatar
      - fixed an assert I am seeing a lot · 8e256d0b
      darin authored
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]): Oops.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e256d0b
    • rjw's avatar
      Solved missing glyph problem, but it's very slow, so · 5df5cc5f
      rjw authored
              it's disabled for now.  I'll turn back on after extending
              the character to glyph map in each renderer to include
              substituted font.
      
              * WebCoreSupport.subproj/WebTextRenderer.m:
              (-[WebTextRenderer substituteFontForString:]):
              (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):
      
              Coalesce items, and add a count to title when appropriate.  Useful for
              condensing multiple item, like spacer.gif.
      
              * LoadProgressMonitor.m:
              (-[LoadProgressMonitor _createProgressEntryWithRequest:dataSource:]):
              * ResourceProgressEntry.h:
              * ResourceProgressEntry.m:
              (-[ResourceProgressEntry count]):
              (-[ResourceProgressEntry setCount:]):
              (-[ResourceProgressEntry title]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5df5cc5f
    • darin's avatar
      - separate WebBaseNetscapePluginStream more cleanly from its subclasses · decd52be
      darin authored
      	by making most fields private
      
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream setResponse:]):
              * Plugins.subproj/WebNetscapePluginStream.h:
              * Plugins.subproj/WebNetscapePluginStream.m:
              (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):
              (-[WebNetscapePluginStream dealloc]):
              (-[WebNetscapePluginStream start]):
              (-[WebNetscapePluginStream handle:didReceiveData:]):
              (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
              * WebCoreSupport.subproj/WebSubresourceClient.m:
              (-[WebSubresourceClient handle:didReceiveResponse:]):
              (-[WebSubresourceClient handle:didReceiveData:]):
              (-[WebSubresourceClient handleDidFinishLoading:]):
              (-[WebSubresourceClient handle:didFailLoadingWithError:]):
              (-[WebSubresourceClient cancel]):
              * WebView.subproj/WebBaseResourceHandleDelegate.h:
              * WebView.subproj/WebBaseResourceHandleDelegate.m:
              (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):
              (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]):
              (-[WebBaseResourceHandleDelegate _cancelWithError:]):
              (-[WebBaseResourceHandleDelegate cancel]):
              (-[WebBaseResourceHandleDelegate cancelQuietly]):
              (-[WebBaseResourceHandleDelegate cancelledError]):
              (-[WebBaseResourceHandleDelegate notifyDelegatesOfInterruptionByPolicyChange]):
              * WebView.subproj/WebMainResourceClient.h:
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient cancel]):
              (-[WebMainResourceClient handle:willSendRequest:]):
              (-[WebMainResourceClient notifyDelegatesOfInterruptionByPolicyChange]):
              (-[WebMainResourceClient handle:didReceiveResponse:]):
              (-[WebMainResourceClient handle:didReceiveData:]):
              (-[WebMainResourceClient handleDidFinishLoading:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      decd52be
    • darin's avatar
      Tools: · f4fe8b9e
      darin authored
              * Scripts/blame-malloc-history: Added.
              * Scripts/count-malloc-history: Added.
              * Scripts/diff-malloc-history: Added.
      
      WebFoundation:
      
              * CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle description]):
      	Used a description in a more-standard format.
              * CacheLoader.subproj/WebResourceLoad.m:
              (-[WebResourceLoad _cleanup]): Changed so it no longer uses autorelease.
              (-[WebResourceLoad description]): Use a description in a more-standard format.
              * CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest description]):
      	Used a description that includes the URL.
              * Misc.subproj/WebError.m: (-[WebError description]): Used a description in a
      	more-standard format.
              * Misc.subproj/WebKeyValuePair.m: (-[WebKeyValuePair description]): Used a
      	description in a more-standard format.
              * Misc.subproj/WebMonitor.m: Removed a description method that did the same as
      	what NSObject already does.
      
              * English.lproj/Localizable.strings: Regenerated.
              * English.lproj/StringsNotToBeLocalized.txt: Updated for above changes.
      
      WebKit:
      
      	- changed persistent dictionaries to use NSString instead of NSURL
      	because of impact on memory footprint
      
      	Also changed WebIconDatabase code to verify what it reads from disk,
      	and ignore it if it can't verify the format.
      
              * Misc.subproj/WebIconDatabase.m:
              (-[WebIconDatabase iconForSiteURL:withSize:cache:]):
              (-[WebIconDatabase retainIconForSiteURL:]):
              (-[WebIconDatabase releaseIconForSiteURL:]):
              (-[WebIconDatabase _iconDictionariesAreGood]):
              (-[WebIconDatabase _loadIconDictionaries]):
              (-[WebIconDatabase _updateFileDatabase]):
              (-[WebIconDatabase _hasIconForSiteURL:]):
              (-[WebIconDatabase _iconsForIconURLString:]):
              (-[WebIconDatabase _setIcon:forIconURL:]):
              (-[WebIconDatabase _setIconURL:forSiteURL:]):
              (-[WebIconDatabase _setBuiltInIconAtPath:forHost:]):
              (-[WebIconDatabase _retainIconForIconURLString:]):
              (-[WebIconDatabase _releaseIconForIconURLString:]):
              (-[WebIconDatabase _retainFutureIconForSiteURL:]):
              (-[WebIconDatabase _releaseFutureIconForSiteURL:]):
              (-[WebIconDatabase _retainOriginalIconsOnDisk]):
              (-[WebIconDatabase _releaseOriginalIconsOnDisk]):
              (-[NSEnumerator _web_isAllStrings]):
              * Panels.subproj/WebStandardPanels.m:
              (-[WebStandardPanels didStartLoadingURL:inWindow:]):
              (-[WebStandardPanels didStopLoadingURL:inWindow:]):
              (-[WebStandardPanels _didStartLoadingURL:inController:]):
              (-[WebStandardPanels _didStopLoadingURL:inController:]):
              (-[WebStandardPanels frontmostWindowLoadingURL:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4fe8b9e
    • darin's avatar
      - fixed crash on boot that Don was seeing · 2f8db7c7
      darin authored
              * History.subproj/WebHistoryItem.m:
              (-[WebHistoryItem URL]): Make this work when _URLString is nil.
              (-[WebHistoryItem initFromDictionaryRepresentation:]): Make this work for nil URL.
      
      	- my own private war on the cString method
      
              * Downloads.subproj/WebDownloadHandler.m:
              (-[WebDownloadHandler initWithDataSource:]): Use %@ in LOG to avoid cString.
              (-[WebDownloadHandler finishedLoading]): Ditto.
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSource _commitIfReady]): Ditto.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _timedLayout:]): Ditto.
              (-[WebFrame _setState:]): More of the same.
              (-[WebFrame _isLoadComplete]): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f8db7c7
    • kocienda's avatar
      Fix deployment build breaker: a variable was used only in a · afa44628
      kocienda authored
      	LOG statement, causing the variable to become usused when
      	building with the Deployment build style.
      
              * Downloads.subproj/WebDownloadHandler.m:
              (-[WebDownloadHandler finishedLoading])
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afa44628
    • darin's avatar
      * History.subproj/WebHistoryItem.h: Replace _URL with _URLString. · 86a7a23d
      darin authored
              * History.subproj/WebHistoryItem.m:
              (-[WebHistoryItem _retainIconInDatabase:]): Get the URL with [self URL].
              (-[WebHistoryItem initWithURL:target:parent:title:]): Set up _URLString.
              (-[WebHistoryItem dealloc]): Release _URLString.
              (-[WebHistoryItem URL]): Make a URL from _URLString.
              (-[WebHistoryItem icon]): Use [self URL] instead of _URL.
              (-[WebHistoryItem setURL:]): Store a URL string.
              (-[WebHistoryItem hash]): Use the URL string's hash.
              (-[WebHistoryItem isEqual:]): Compare the URL strings.
              (-[WebHistoryItem description]): Use _URLString.
              (-[WebHistoryItem dictionaryRepresentation]): Use _URLString.
              (-[WebHistoryItem initFromDictionaryRepresentation:]): Call through to
      	the other init functions so we have only one designated initializer.
      	Leave the date as nil if there's no date in the dictionary instead of
      	setting the date to 0.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86a7a23d
  7. 07 Nov, 2002 1 commit
    • mjs's avatar
      WebKit: · 24b8a9b5
      mjs authored
      	Removed SaveAndOpenExternally policy.
      
              * Downloads.subproj/WebDownloadHandler.m:
              (-[WebDownloadHandler finishedLoading]):
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient receivedError:]):
              (-[WebMainResourceClient handle:didReceiveResponse:]):
              (-[WebMainResourceClient handleDidFinishLoading:]):
      
      WebBrowser:
      
      	Removed all uses of SaveAndOpenExternally policy.
      
              * BrowserDocument.m:
              (-[BrowserDocument _stopNonDownloadingDataSource:]):
              * BrowserWebController.m:
              (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24b8a9b5