1. 18 Nov, 2002 11 commits
  2. 17 Nov, 2002 9 commits
    • hyatt's avatar
      More refinements to immediate painting code. Still doesn't · 0394b747
      hyatt authored
      	fix the scrollbar problem though. :(
      
              * khtml/html/html_documentimpl.cpp:
              (HTMLDocumentImpl::close):
              * khtml/khtmlview.cpp:
              (KHTMLView::init):
              (KHTMLView::timerEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0394b747
    • hyatt's avatar
      Make immediate repainting of the root element more robust. · 177a8b90
      hyatt authored
              * khtml/html/html_documentimpl.cpp:
              (HTMLDocumentImpl::close):
              * khtml/khtmlview.cpp:
              (KHTMLView::unscheduleRepaint):
              * khtml/khtmlview.h:
              * khtml/rendering/render_root.cpp:
              (RenderRoot::repaint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      177a8b90
    • darin's avatar
      WebCore: · b1961817
      darin authored
      	- moved all NSURL and CFURL use out of WebCore
      
              * kwq/KWQKURL.h: Remove getNSURL() and getNSURLFromString().
              * kwq/KWQKURL.mm: Ditto.
      
              * kwq/KWQKCookieJar.mm:
              (KWQKCookieJar::cookie): Pass an NSString instead of an NSURL.
              (KWQKCookieJar::setCookie): Ditto.
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::openURL): Ditto.
              (KWQKHTMLPart::openURLRequest): Ditto.
              (KWQKHTMLPart::submitForm): Ditto.
              (KWQKHTMLPart::urlSelected): Ditto.
              (KWQKHTMLPart::createPart): Ditto.
              (KWQKHTMLPart::redirectionTimerStartedOrStopped): Ditto.
              (KWQKHTMLPart::userAgent): Ditto.
              (KWQKHTMLPart::requestedURLString): Receive an NSString instead of an NSURL.
              * kwq/KWQKHTMLPartBrowserExtension.mm:
              (KHTMLPartBrowserExtension::createNewWindow): Pass an NSString instead of an NSURL.
              (KHTMLPartBrowserExtension::setIconURL): Ditto.
              (KHTMLPartBrowserExtension::setTypedIconURL): Ditto.
              * kwq/KWQKJavaAppletWidget.h: Remove use of NSURL, just use QString instead.
              * kwq/KWQKJavaAppletWidget.mm:
              (KJavaAppletWidget::KJavaAppletWidget): No need to set the QString to nil.
              (KJavaAppletWidget::~KJavaAppletWidget): No need to release the QString.
              (KJavaAppletWidget::showApplet): Pass an NSString instead of an NSURL.
              * kwq/KWQLoader.mm:
              (KWQServeRequest): Pass an NSString instead of an NSURL.
              (KWQCheckCacheObjectStatus): Ditto.
              * kwq/WebCoreBridge.h: Change all methods to use NSString instead of NSURL.
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge openURL:reload:headers:]): Receive an NSString instead of an NSURL.
              (-[WebCoreBridge completeURLForDOMString:]): Return an NSString instead of an NSURL.
              (-[WebCoreBridge elementAtPoint:]): WebCoreElementLinkURL and WebCoreElementImageURL
      	are now strings.
              (-[WebCoreBridge URL]): Return an NSString instead of an NSURL.
              * kwq/WebCoreCookieAdapter.h: Change all methods to use NSString instead of NSURL.
              * kwq/WebCoreCookieAdapter.m:
              (-[WebCoreCookieAdapter cookiesForURL:]): Ditto.
              (-[WebCoreCookieAdapter setCookies:forURL:policyBaseURL:]): Ditto.
      
              * khtml/rendering/render_applet.cpp: (RenderApplet::processArguments):
      	Tweaked this file a tiny bit, mainly because header dependencies weren't working
      	and we need this file to be recompiled due to inline function changes.
      
      WebKit:
      
      	- update for change to WebCore API so it never uses NSURL
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge createWindowWithURL:frameName:]): Take NSString instead of NSURL.
              (-[WebBridge startLoadingResource:withURL:]): Ditto.
              (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): Ditto.
              (-[WebBridge reportClientRedirectToURL:delay:fireDate:]): Ditto.
              (-[WebBridge setIconURL:]): Ditto.
              (-[WebBridge setIconURL:withType:]): Ditto.
              (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]): Ditto.
              (-[WebBridge postWithURL:data:contentType:triggeringEvent:]): Ditto.
              (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Ditto.
              (-[WebBridge userAgentForURL:]): Ditto.
              (-[WebBridge requestedURL]): Return NSString instead of NSURL.
              (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): Take NSString instead of NSURL.
              (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): Take NSString instead of NSURL.
      
              * WebCoreSupport.subproj/WebCookieAdapter.m:
              (-[WebCookieAdapter cookiesForURL:]): Take NSString instead of NSURL.
              (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]): Ditto.
      
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSource _commitIfReady]): Pass NSString instead of NSURL.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Pass NSString instead of NSURL
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Turn bridge URL into NSURL so we
      	can call _web_URLByRemovingFragment on it.
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebHTMLView _elementAtPoint:]): Convert NSString to NSURL when making the WebKit element dictionary.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1961817
    • hyatt's avatar
      Add support for specifying whether repaint should be immediate or · 7d5a4793
      hyatt authored
      	not.  Default to async for now to maintain current behavior.
      
      	For clipped object repainting (e.g., livepage.apple.com and mrskin)
      	switch to immediate repainting, since this makes the marquees
      	faster, stops dropping updates, and keeps the hover effects and
      	painting on the rest of the page fast (since the marquee rect doesn't
      	get unioned with links or images that you roll over).
      
              * khtml/rendering/render_box.cpp:
              (RenderBox::repaint):
              (RenderBox::repaintRectangle):
              * khtml/rendering/render_box.h:
              * khtml/rendering/render_html.cpp:
              (RenderHtml::repaint):
              * khtml/rendering/render_html.h:
              * khtml/rendering/render_object.cpp:
              (RenderObject::setLayouted):
              (RenderObject::repaintRectangle):
              * khtml/rendering/render_object.h:
              * khtml/rendering/render_root.cpp:
              (RenderRoot::repaintRectangle):
              (RenderRoot::repaint):
              * khtml/rendering/render_root.h:
              * khtml/rendering/render_table.cpp:
              (RenderTableRow::repaint):
              (RenderTableCell::repaintRectangle):
              (RenderTableCell::repaint):
              * khtml/rendering/render_table.h:
              * khtml/rendering/render_text.cpp:
              (RenderText::repaint):
              * khtml/rendering/render_text.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d5a4793
    • mjs's avatar
      WebCore: · bb798fe2
      mjs authored
      	- fixed 2949193 - implement onKeyDown, onKeyPress, and onKeyUp event handlers
      
              * khtml/html/html_formimpl.cpp:
              (HTMLGenericFormElementImpl::defaultEventHandler):
              * kwq/KWQEvent.h:
              * kwq/KWQEvent.mm:
              (QKeyEvent::QKeyEvent): Implemented.
              (QKeyEvent::key): Likewise.
              (QKeyEvent::state): Likewise.
              (QKeyEvent::accept): Likewise.
              (QKeyEvent::ignore): Likewise.
              (QKeyEvent::isAutoRepeat): Likewise.
              (QKeyEvent::text): Likewise.
              (QKeyEvent::ascii): Likewise.
              (QKeyEvent::count): Likewise.
              (QKeyEvent::isAccepted): Likewise.
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::keyEvent): Translate the event to a QEvent and send
      	it through the DOM event mechanism.
              * kwq/WebCoreBridge.h:
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge interceptKeyEvent:toView:]): Pass event to the
      	KWQ part.
      	* kwq/WebCoreBridgePrivate.h: Added.
              * WebCore.pbproj/project.pbxproj: Added new file.
      
      WebKit:
      
      	- fixed 2949193 - implement onKeyDown, onKeyPress, and onKeyUp event handlers
      
              * WebView.subproj/WebHTMLViewPrivate.h:
              * WebView.subproj/WebHTMLViewPrivate.m:
              (+[WebHTMLView load]): Pose as NSWindow too now.
              (-[WebHTMLView _interceptKeyEvent:toView:]): Pass event to WebCore and
      	see if WebCore wants to block it.
              (-[WebNSWindow sendEvent:]): For all key events that would go to a
      	subview of a WebHTMLView, let the WebHTMLView take a first crack
      	at it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb798fe2
    • hyatt's avatar
      Don't discard linefeeds after elements with no close tag · dd93668d
      hyatt authored
      	(e.g., <img> or <input>).
      
              * khtml/html/htmltokenizer.cpp:
              (HTMLTokenizer::parseTag):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd93668d
    • hyatt's avatar
      Fix for slashdot table mispositioning in the upper right. · bb3e43a4
      hyatt authored
      	Now that we fixed <td> to set to -konq-center when align="center"
      	is specified, the style rules are no longer necessary in
      	html4.css (and are in fact harmful).
      
              * khtml/css/html4.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb3e43a4
    • hyatt's avatar
      Fix for 3038168. Duh. Remember to be case-insensitive when · 047a8b3b
      hyatt authored
      	checking the type of the <style> attribute.
      
              * khtml/html/html_headimpl.cpp:
              (HTMLStyleElementImpl::parseAttribute):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      047a8b3b
    • hyatt's avatar
      This is a fix for bug 3058470. The bug was that replaced elements · c84035d7
      hyatt authored
      	were computing their min and max widths wrong.  Specifically they
      	were not adding in borders and padding!  This means that any image
      	with a border around it would potentially break to another line
      	too early.
      
      	Once I fixed this for replaced elements I then went in and
      	fixed form controls.  I added two APPLE_CHANGES features for
      	our form controls.  First I overrode the border/padding functions
      	to always return 0 for all form controls, since no Aqua control
      	honors border/padding (nor should it).  This fixes the menulist
      	at the top of wired.com.
      
      	Second I made sure that certain controls will ignore CSS-specified
      	heights and always use their intrinsic heights.  These include
      	<select size=1> (combobox), single line text fields, and buttons.
      	I allow listboxes and textareas to honor height.
      
              * khtml/rendering/render_box.cpp:
              (RenderBox::contentWidth):
              (RenderBox::contentHeight):
              (RenderBox::calcWidth):
              (RenderBox::calcHeight):
              * khtml/rendering/render_form.h:
              * khtml/rendering/render_image.h:
              * khtml/rendering/render_object.h:
              * khtml/rendering/render_replaced.cpp:
              (RenderReplaced::calcMinMaxWidth):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c84035d7
  3. 16 Nov, 2002 7 commits
  4. 15 Nov, 2002 13 commits
    • hyatt's avatar
      Fix the problem where the last lines of paragrpahs were getting · d20075d4
      hyatt authored
      	justified incorrectly.
      
              * khtml/rendering/bidi.cpp:
              (RenderFlow::findNextLineBreak):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d20075d4
    • hyatt's avatar
      Fix bustage with <nobr> tags. Inline nowrap elements were · d6e471b6
      hyatt authored
      	breaking on images when they shouldn't have.
      
              * khtml/rendering/render_flow.cpp:
              (RenderFlow::calcInlineMinMaxWidth):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6e471b6
    • kocienda's avatar
      Fix for this bug: · 4ea6a4b6
      kocienda authored
      	Radar 3102708 (REGRESSION: assertion failure backing up to page)
      
      	KWQCheckCacheObjectStatus did not create an NSURL in a way that
      	dealt with the fact that we handle non-NSURL-compliant URL strings.
      	I have fixed it so it does, and in the process, factored out
      	the code to do it into a new KURL static function (KURL::getNSURLFromString).
      
              * kwq/KWQKURL.h:
              * kwq/KWQKURL.mm:
              (KURL::getNSURL): Now calls through to KURL::getNSURLFromString
              (KURL::encode_string)
              (KURL::getNSURLFromString): New function to handle NSURL creation
              * kwq/KWQLoader.mm:
              (KWQCheckCacheObjectStatus)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ea6a4b6
    • hyatt's avatar
      Fix asserts in tables. · b1bda391
      hyatt authored
              * khtml/rendering/render_table.cpp:
              (RenderTableRow::layout):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1bda391
    • hyatt's avatar
      Fix for whitespace regressions that caused text overlapping · eb003b81
      hyatt authored
      	and text spilling.
      
              * khtml/rendering/bidi.cpp:
              (appendRunsForObject):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb003b81
    • hyatt's avatar
      Fix newlines getting stripped out of textareas by not making · c30857cf
      hyatt authored
      	rendertext objects for children of textareas.
      
              * khtml/rendering/render_form.h:
              * khtml/rendering/render_object.h:
              * khtml/xml/dom_textimpl.cpp:
              (TextImpl::attach):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c30857cf
    • hyatt's avatar
      Make <form> inside <table> stay inside the <table> but demote · c6ba7979
      hyatt authored
      	itself to a leaf.  Then the children of the <form> are treated
      	as though they occurred underneath the <table> itself.  Everything
      	KHTML does with this is completely wrong but this band-aid should
      	hopefully suffice until 1.0.
      
      	Also allowing <input type="hidden"> to be constructed and attached
      	under <table>s.  Since they have no render objects this is safe.
      	Again, total hack, since CSS2 anonymous table construction should be
      	implemented and that would have fixed all this.
      
      	This collection of hacks makes travelocity render correctly on the
      	PLT.
      
              * khtml/css/html4.css:
              * khtml/html/dtd.cpp:
              (DOM::checkChild):
              * khtml/html/html_tableimpl.cpp:
              (HTMLTableElementImpl::addChild):
              * khtml/html/htmlparser.cpp:
              (KHTMLParser::parseToken):
              (KHTMLParser::insertNode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6ba7979
    • hyatt's avatar
      Fix Hixie's blog. Background images can be transparent, so · 53f3dec7
      hyatt authored
      	if the root's color isn't valid always do a fixup even if you
      	have a valid background image.
      
              * khtml/rendering/render_html.cpp:
              (RenderHtml::printBoxDecorations):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53f3dec7
    • darin's avatar
      * kwq/KWQWindowWidget.mm: (KWQWindowWidget::setFrameGeometry): · df95e87e
      darin authored
      	Oops. Make that display:YES.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df95e87e
    • darin's avatar
      - fixed 3090219 -- Window jumps up and down when loading nikon page · 3cbec6d6
      darin authored
              * kwq/KWQWindowWidget.mm: (KWQWindowWidget::setFrameGeometry):
      	Don't pass display:NO when resizing the window.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cbec6d6
    • kocienda's avatar
      Remove characters RFC 2396 describes as "unwise" from the · c911ccf5
      kocienda authored
      	BadChar character class. This causes them to remain unescaped
      	in KURL objects. As a result, some extra escaping needed to
      	be added into the getNSURL() function to enable NSURL
      	objects to be created using a KURL.
      
      	This enables me to fix this bug:
      	Radar 3050437 (Clicking link leads to page with garbled content)
      
      	Note, however, that my fix for 3050437 relies on this bug remaining unfixed:
      
      	Radar 3102332 (Square bracket characters "sneak through" CFURL illegal character checks)
      
              * kwq/KWQKURL.mm:
              (KURL::getNSURL)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c911ccf5
    • darin's avatar
      Tools: · 56fdc7dc
      darin authored
              * Scripts/update-alex-localizable-strings: Fix it so that the line
      	numbers in error messages will be accurate.
      
      WebCore:
      
      	- fixed 3027460 -- text areas don't have focus rectangles
      	- fixed 2937204 -- text areas have solid black borders
      
              * kwq/KWQSignal.mm: (KWQSignal::disconnect):
      	Add a special case so we don't hear about finishedParsing all the time.
      
              * kwq/KWQTextArea.mm:
              (-[KWQTextArea initWithFrame:]): Use a bezel border, not a line border.
              (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): Fix bug where it would
      	return a bogus value for an empty text area.
              (-[KWQTextArea setCursorPositionToIndex:inParagraph:]): Use setSelectedRange:
      	ratherr than setMarkedText:selectedRange:.
              (-[KWQTextArea drawRect:]): Draw a focus ring if our text view is first responder.
              (-[KWQTextArea _KWQ_setKeyboardFocusRingNeedsDisplay]): Added.
              (-[KWQTextAreaTextView becomeFirstResponder]): Call _KWQ_setKeyboardFocusRingNeedsDisplay.
              (-[KWQTextAreaTextView resignFirstResponder]): Call _KWQ_setKeyboardFocusRingNeedsDisplay.
              (-[NSView _KWQ_setKeyboardFocusRingNeedsDisplay]): Calls the same thing on parent.
      
              * WebCore.pbproj/project.pbxproj: PB is a cruel master.
      
      WebBrowser:
      
      	- fixed problem I introduced where text would get too close to the right button
      
              * LocationTextField.m: (-[LocationTextField didShowOrHideRightButton]):
      	Add back logic to adjust the right border. I removed this because it was incompatible
      	with my changes, but now I made a new compatible version by adding a new method.
      
              * TextFieldWithControls.h: Rename showRightButton: to setIsShowingRightButton:,
      	and added isShowingRightButton, and didShowOrHideRightButton methods.
              * TextFieldWithControls.m:
              (-[TextFieldWithControls isShowingRightButton]): Added.
              (-[TextFieldWithControls didShowOrHideRightButton]): Added.
              (-[TextFieldWithControls setIsShowingRightButton:]): Call didShowOrHideRightButton at
      	the right moment so we can properly respond to any changes it makes to the cell.
      
              * BrowserWindowController.m: (-[BrowserWindowController updateSnapBackButtons]):
      	Update for method name change.
      
              * WebBrowser.pbproj/project.pbxproj: PB is a cruel master.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56fdc7dc
    • mjs's avatar
      * khtml/html/html_formimpl.cpp: · ab1f48ef
      mjs authored
              (HTMLInputElementImpl::attach): Removed a stray printf.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab1f48ef