1. 05 Aug, 2013 7 commits
    • fpizlo@apple.com's avatar
      Copied space should be able to handle more than one copied backing store per JSCell · 05937580
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119471
      
      Reviewed by Mark Hahnenberg.
              
      This allows a cell to call copyLater() multiple times for multiple different
      backing stores, and then have copyBackingStore() called exactly once for each
      of those. A token tells it which backing store to copy. All backing stores
      must be named using the CopyToken, an enumeration which currently cannot
      exceed eight entries.
              
      When copyBackingStore() is called, it's up to the callee to (a) use the token
      to decide what to copy and (b) call its base class's copyBackingStore() in
      case the base class had something that needed copying. The only exception is
      that JSCell never asks anything to be copied, and so if your base is JSCell
      then you don't have to do anything.
      
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * heap/CopiedBlock.h:
      * heap/CopiedBlockInlines.h:
      (JSC::CopiedBlock::reportLiveBytes):
      * heap/CopyToken.h: Added.
      * heap/CopyVisitor.cpp:
      (JSC::CopyVisitor::copyFromShared):
      * heap/CopyVisitor.h:
      * heap/CopyVisitorInlines.h:
      (JSC::CopyVisitor::visitItem):
      * heap/CopyWorkList.h:
      (JSC::CopyWorklistItem::CopyWorklistItem):
      (JSC::CopyWorklistItem::cell):
      (JSC::CopyWorklistItem::token):
      (JSC::CopyWorkListSegment::get):
      (JSC::CopyWorkListSegment::append):
      (JSC::CopyWorkListSegment::data):
      (JSC::CopyWorkListIterator::get):
      (JSC::CopyWorkListIterator::operator*):
      (JSC::CopyWorkListIterator::operator->):
      (JSC::CopyWorkList::append):
      * heap/SlotVisitor.h:
      * heap/SlotVisitorInlines.h:
      (JSC::SlotVisitor::copyLater):
      * runtime/ClassInfo.h:
      * runtime/JSCell.cpp:
      (JSC::JSCell::copyBackingStore):
      * runtime/JSCell.h:
      * runtime/JSObject.cpp:
      (JSC::JSObject::visitButterfly):
      (JSC::JSObject::copyBackingStore):
      * runtime/JSObject.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05937580
    • vivek.vg@samsung.com's avatar
      XMLTreeViewer should be created only in the XML viewer mode · 184ac0f2
      vivek.vg@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119483
      
      Reviewed by Alexey Proskuryakov.
      
      XMLTreeViewer is created even for the XSL transform which is avoided by the patch.
      The XMLTreeViewer::hasNoStyleInformation() is moved to XMLDocumentParserLibxml2.cpp
      as static inline method as XMLTreeViewer should not have the responsibility for it.
      Also removes an unnecessary conditional check while deciding for XML viewer mode.
      
      Blink patch review links:
      https://codereview.chromium.org/19552003/
      https://codereview.chromium.org/22150003/
      
      No new tests as the patch is about code refactoring.
      
      * xml/XMLTreeViewer.cpp:
      * xml/XMLTreeViewer.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::hasNoStyleInformation):
      (WebCore::XMLDocumentParser::doEnd):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      184ac0f2
    • jer.noble@apple.com's avatar
      Loading a video with a custom URL scheme will result in stalling playback · cb468459
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119469
      
      Reviewed by Eric Carlson.
      
      Break the assumption that only one AVAssetResourceRequest will be outstanding simultaneously
      by storing a HashMap of AVAssetResourceRequests and their resulting WebCoreAVFResourceLoader.
      When loading is stopped (due to completion or error), notify the MediaPlayerPrivateAVFoundation
      parent so that the map can be emptied.
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource): Store the request
          in m_resourceLoaderMap.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::didCancelLoadingRequest): Pull the request from
          m_resourceLoaderMap.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::didStopLoadingRequest): Remove the requset from
          m_resourceLoaderMap.
      * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
      * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
      (WebCore::WebCoreAVFResourceLoader::create): Return a PassRefPtr, rather than a PassOwnPtr.
      (WebCore::WebCoreAVFResourceLoader::stopLoading): Call didStopLoadingRequest.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb468459
    • commit-queue@webkit.org's avatar
      Make tests platform agnostic, fix async tests, remove broken blend modes: hue,... · 7887c4d8
      commit-queue@webkit.org authored
      Make tests platform agnostic, fix async tests, remove broken blend modes: hue, saturation, color, luminosity, soft-light.
      The test suite should now pass on windows.
      
      https://bugs.webkit.org/show_bug.cgi?id=119463
      
      Patch by Mihai Tica <mitica@adobe.com> on 2013-08-05
      Reviewed by Dirk Schulze.
      
      * fast/canvas/canvas-blending-clipping-expected.txt:
      * fast/canvas/canvas-blending-clipping.html:
      * fast/canvas/canvas-blending-color-over-color-expected.txt:
      * fast/canvas/canvas-blending-color-over-color.html:
      * fast/canvas/canvas-blending-color-over-gradient-expected.txt:
      * fast/canvas/canvas-blending-color-over-gradient.html:
      * fast/canvas/canvas-blending-color-over-image-expected.txt:
      * fast/canvas/canvas-blending-color-over-image.html:
      * fast/canvas/canvas-blending-color-over-pattern-expected.txt:
      * fast/canvas/canvas-blending-color-over-pattern.html:
      * fast/canvas/canvas-blending-fill-style-expected.txt:
      * fast/canvas/canvas-blending-fill-style.html:
      * fast/canvas/canvas-blending-global-alpha-expected.txt:
      * fast/canvas/canvas-blending-global-alpha.html:
      * fast/canvas/canvas-blending-gradient-over-color-expected.txt:
      * fast/canvas/canvas-blending-gradient-over-color.html:
      * fast/canvas/canvas-blending-gradient-over-gradient-expected.txt:
      * fast/canvas/canvas-blending-gradient-over-gradient.html:
      * fast/canvas/canvas-blending-gradient-over-image-expected.txt:
      * fast/canvas/canvas-blending-gradient-over-image.html:
      * fast/canvas/canvas-blending-gradient-over-pattern-expected.txt:
      * fast/canvas/canvas-blending-gradient-over-pattern.html:
      * fast/canvas/canvas-blending-helpers.js:
      (separateBlendFunctions.hardLight):
      (nonSeparateBlendFunctions.hue):
      (nonSeparateBlendFunctions.saturation):
      (nonSeparateBlendFunctions.color):
      (nonSeparateBlendFunctions.luminosity):
      * fast/canvas/canvas-blending-image-over-color-expected.txt:
      * fast/canvas/canvas-blending-image-over-color.html:
      * fast/canvas/canvas-blending-image-over-gradient-expected.txt:
      * fast/canvas/canvas-blending-image-over-gradient.html:
      * fast/canvas/canvas-blending-image-over-image-expected.txt:
      * fast/canvas/canvas-blending-image-over-image.html:
      * fast/canvas/canvas-blending-image-over-pattern-expected.txt:
      * fast/canvas/canvas-blending-image-over-pattern.html:
      * fast/canvas/canvas-blending-pattern-over-color-expected.txt:
      * fast/canvas/canvas-blending-pattern-over-color.html:
      * fast/canvas/canvas-blending-pattern-over-gradient-expected.txt:
      * fast/canvas/canvas-blending-pattern-over-gradient.html:
      * fast/canvas/canvas-blending-pattern-over-image-expected.txt:
      * fast/canvas/canvas-blending-pattern-over-image.html:
      * fast/canvas/canvas-blending-pattern-over-pattern-expected.txt:
      * fast/canvas/canvas-blending-pattern-over-pattern.html:
      * fast/canvas/canvas-blending-shadow-expected.txt:
      * fast/canvas/canvas-blending-shadow.html:
      * fast/canvas/canvas-blending-text-expected.txt:
      * fast/canvas/canvas-blending-text.html:
      * fast/canvas/canvas-blending-transforms-expected.txt:
      * fast/canvas/canvas-blending-transforms.html:
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7887c4d8
    • commit-queue@webkit.org's avatar
      Spatial Navigation should avoid unwanted calculation while deciding focus candidate. · 3a7e0bb2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117265
      
      Patch by Abhijeet Kandalkar <abhijeet.k@samsung.com> on 2013-08-05
      Reviewed by Antonio Gomes.
      
      Source/WebCore:
      
      Spatial Navigation should consider only those nodes as candidate which are exactly in the focus-direction.
      e.g. If we are moving down then the nodes that are above CURRENT focused node should be considered as invalid.
      Added isValidCandidate() which checks whether node is exactly in the focus-direction.
      
      Test: fast/spatial-navigation/snav-search-optimization.html
      
      * page/FocusController.cpp:
      (WebCore::FocusController::findFocusCandidateInContainer):
      (WebCore::FocusController::advanceFocusDirectionally):
      * page/Page.cpp:
      (WebCore::Page::Page):
      * page/Page.h:
      (WebCore::Page::setLastSpatialNavigationCandidateCount):
      (WebCore::Page::lastSpatialNavigationCandidateCount):
      * page/SpatialNavigation.cpp:
      (WebCore::isValidCandidate):
      * page/SpatialNavigation.h:
      * testing/Internals.cpp:
      (WebCore::Internals::lastSpatialNavigationCandidateCount):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      LayoutTests:
      
      Added testcases to count how many target nodes were tested before choosing a final target.
      
      * fast/spatial-navigation/snav-search-optimization-expected.txt: Added.
      * fast/spatial-navigation/snav-search-optimization.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a7e0bb2
    • zandobersek@gmail.com's avatar
      [Automake] Define ENABLE_JIT through the Autoconf header · a56af6cd
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119445
      
      Reviewed by Martin Robinson.
      
      .: 
      
      Instead of defining the ENABLE_JIT value through JSC_CPPFLAGS, the feature define is
      set to be either enabled or disabled through the Autoconf header, based on the value
      passed through the configuration flag. The 'auto' value is used as default, meaning
      that the feature is enabled or disabled in the Platform.h header based on the platform
      configuration (OS, architecture etc.).
      
      * Source/autotools/FindDependencies.m4: Remove the JSC_CPPFLAGS definition.
      * Source/autotools/ReadCommandLineArguments.m4: Change the default value to 'auto' instead
      of 'autodetect', as used by other configuration options that take a similar approach to enabling
      a specific feature.
      * Source/autotools/SetupAutoconfHeader.m4: Set a strict value for the ENABLE_JIT define through
      the Autoconf header if the feature was specifically enabled or disabled.
      
      Source/JavaScriptCore: 
      
      * GNUmakefile.am: Remove JSC_CPPFLAGS from the cpp flags for the JSC library.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a56af6cd
    • commit-queue@webkit.org's avatar
      Source/WebCore: [CSS Background Blending] Specifying background-image and background-color · 5b54a1ec
      commit-queue@webkit.org authored
      with opaque image doesn't trigger blending. The fix consists of adding a
      check whether blend mode is set in hasOpaqueImage.
      
      https://bugs.webkit.org/show_bug.cgi?id=119434
      
      Patch by Mihai Tica <mitica@adobe.com> on 2013-08-05
      Reviewed by Dirk Schulze.
      
      Test: css3/compositing/background-blend-mode-separate-layer-declaration.html
      
      * rendering/style/FillLayer.cpp:
      (WebCore::FillLayer::hasOpaqueImage):
      
      LayoutTests: [CSS Background Blending] Specifying background-image and background-color with opaque
      image doesn't trigger blending. Adding ref test to validate the fix.
      
      https://bugs.webkit.org/show_bug.cgi?id=119434i
      
      Patch by Mihai Tica <mitica@adobe.com> on 2013-08-05
      Reviewed by Dirk Schulze.
      
      * css3/compositing/background-blend-mode-separate-layer-declaration-expected.html: Added.
      * css3/compositing/background-blend-mode-separate-layer-declaration.html: Added.
      * css3/compositing/resources/gray_square.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b54a1ec
  2. 04 Aug, 2013 6 commits
    • zalan@apple.com's avatar
      Background doesn't fully repaint when body has margins. · f0b7adf7
      zalan@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119033
      
      Reviewed by Simon Fraser.
      
      Ensure that background-color changes do not leave unpainted areas when
      body has margins.
      
      Both <body> and <html> background-color get propagated up to the viewport.
      If <body> has background-color attribute set, while <html> doesn't, the color is
      applied not only on the <body> but on both the <html> and the viewport. However,
      it's not enough to mark the RenderView dirty because with tiles backing on,
      there could be areas outside of the viewport that need repaint. By marking
      the RenderView's graphics layer dirty instead, we ensure that all the related
      tiles get marked dirty too and the new background color covers all areas.
      
      Manual test added. When forcing top-level composition on (even with embedded iframe to
      make sure we don't do paintsIntoWindow rendering), the test case execution changes so much,
      that the repaint rects don't reflect the functionality difference anymore.
      
      .:
      
      Reviewed by Simon Fraser.
      
      * ManualTests/compositing/background-color-change-on-body-with-margin.html: Added.
      
      Source/WebCore:
      
      * page/FrameView.cpp:
      (WebCore::FrameView::reset):
      (WebCore::FrameView::layout):
      * page/FrameView.h:
      (WebCore::FrameView::needsFullRepaint):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::styleWillChange):
      * rendering/RenderObjectChildList.cpp:
      (WebCore::RenderObjectChildList::removeChildNode):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::repaintRootContents):
      (WebCore::RenderView::repaintViewAndCompositedLayers):
      * rendering/RenderView.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0b7adf7
    • akling@apple.com's avatar
      Document needn't expose its active element. · dad025bb
      akling@apple.com authored
      <http://webkit.org/b/119466>
      
      Reviewed by Antonio Gomes.
      
      The Document::m_activeElement pointer is only used inside updateHoverActiveState(),
      so we can remove the activeElement()/setActiveElement() accessors.
      
      * dom/Document.h:
      * dom/Document.cpp:
      (WebCore::Document::updateHoverActiveState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dad025bb
    • akling@apple.com's avatar
      Inserting a rule into an empty style sheet shouldn't trigger style recalc unless necessary. · de6fc08c
      akling@apple.com authored
      <http://webkit.org/b/119475>
      <rdar://problem/14643481>
      
      Reviewed by Antti Koivisto.
      
      This is kind of a cheesy optimization, but it turns out that the use case is quite common.
      The pattern goes like this:
      
          (1) Create <style> element.
          (2) Add it to the document's <head>.
          (3) .addRule() one rule through the CSSOM API.
      
      Prior to this patch, (3) would always cause a full (deferred) style recalc.
      
      Now that we exclude empty style sheets from the document's (effective) active set,
      we can piggyback on the style invalidation analysis when transitioning from an empty
      sheet to a single-rule sheet.
      
      In other words, add a special code path for the first rule insertion into an empty,
      in-document style sheet to minimize the amount of invalidation that happens.
      
      * css/CSSStyleSheet.cpp:
      (WebCore::CSSStyleSheet::didMutateRules):
      (WebCore::CSSStyleSheet::insertRule):
      * css/CSSStyleSheet.h:
      (WebCore::CSSStyleSheet::RuleMutationScope::RuleMutationScope):
      (WebCore::CSSStyleSheet::RuleMutationScope::~RuleMutationScope):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de6fc08c
    • csaavedra@igalia.com's avatar
      [GTK] Fix a C++11 warning. · 536afa8b
      csaavedra@igalia.com authored
      Rubber-stamped by Martin Robinson.
      
      * platform/gtk/FileSystemGtk.cpp:
      (WebCore::sharedResourcesPath): Fix a C++11 warning.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      536afa8b
    • commit-queue@webkit.org's avatar
      [GTK] Remove legacy hack in CodeGeneratorGObject.pm · fbc7b812
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117545
      
      Patch by Diego Pino Garcia <dpino@igalia.com> on 2013-08-04
      Reviewed by Carlos Garcia Campos.
      
      There's a checking that sets gtype to uint in case it's ushort. gtype
      is a value obtained from GetGValueTypeName(), which never returns
      ushort.
      
      * bindings/scripts/CodeGeneratorGObject.pm:
      (GenerateProperty): remove unnecessary glitch
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbc7b812
    • akling@apple.com's avatar
      [Mac] Disable screen font substitution at WebCore-level in OS X 10.9+ · 35261640
      akling@apple.com authored
      <http://webkit.org/b/119474>
      <rdar://problem/14643349>
      
      Reviewed by Dan Bernstein.
      
      Disable screen font substitution by default in Settings so internal WebCore clients
      such as SVG-as-image will get the right default setting.
      
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      (WebCore::Settings::shouldEnableScreenFontSubstitutionByDefault):
      (WebCore::Settings::setScreenFontSubstitutionEnabled):
      * page/Settings.h:
      (WebCore::Settings::screenFontSubstitutionEnabled):
      * page/Settings.in:
      * page/mac/SettingsMac.mm:
      (WebCore::Settings::shouldEnableScreenFontSubstitutionByDefault):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35261640
  3. 03 Aug, 2013 8 commits
    • timothy_horton@apple.com's avatar
      Refine the unavailable plug-in indicator · 1a575c3d
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119400
      <rdar://problem/14616012>
      
      Reviewed by Oliver Hunt.
      
      Add a border, flip the text and background colors, and make the indicator
      much higher contrast, to be more visible on a variety of sites.
      Also, refine the arrow to be less blocky and inlaid inside a circle.
      
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::replacementTextRoundedRectPressedColor):
      (WebCore::replacementTextRoundedRectColor):
      (WebCore::replacementTextColor):
      (WebCore::unavailablePluginBorderColor):
      (WebCore::drawReplacementArrow):
      (WebCore::RenderEmbeddedObject::paintReplaced):
      (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
      (WebCore::RenderEmbeddedObject::unavailablePluginIndicatorBounds):
      (WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
      * rendering/RenderEmbeddedObject.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a575c3d
    • timothy_horton@apple.com's avatar
      Unreviewed, build and style fix for r153693. · 09520713
      timothy_horton@apple.com authored
      * UIProcess/WebProcessProxy.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.h:
      * WebProcess/WebPage/WebPage.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09520713
    • timothy_horton@apple.com's avatar
      Remove SimplePDFPlugin · ad693605
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119437
      
      Reviewed by Alexey Proskuryakov.
      
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::getPlugins):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin):
      Don't add SimplePDFPlugin, nor try to instantiate it.
      
      * WebProcess/Plugins/PDF/PDFPlugin.h:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      Merge previously inherited behavior in from SimplePDFPlugin.
      
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/Plugins/PDF/SimplePDFPlugin.h: Removed.
      * WebProcess/Plugins/PDF/SimplePDFPlugin.mm: Removed.
      Remove SimplePDFPlugin.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad693605
    • timothy_horton@apple.com's avatar
      Remove pageOverlayShouldApplyFadeWhenPainting() and adopt composited fade for the Mac port · 8de467bf
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119411
      
      Reviewed by Simon Fraser.
      
      Mac is the only holdout that performs non-composited fades of page
      overlays. We should adopt that mechanism (as a precursor to doing a
      CA-accelerated fade) and remove the now-unnecessary property.
      
      * WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
      (WKBundlePageOverlayFractionFadedIn):
      Always return 1 (fully-faded-in) so that clients who attempt to use this
      to bake the fade opacity into their painting will paint at full opacity,
      allowing us to do the composited fade separately.
      
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
      * WebProcess/WebPage/DrawingArea.h:
      * WebProcess/WebPage/DrawingAreaImpl.cpp:
      * WebProcess/WebPage/DrawingAreaImpl.h:
      * WebProcess/WebPage/LayerTreeHost.h:
      * WebProcess/WebPage/PageOverlay.cpp:
      (WebKit::PageOverlay::PageOverlay):
      (WebKit::PageOverlay::setPage):
      (WebKit::PageOverlay::setNeedsDisplay):
      (WebKit::PageOverlay::fadeAnimationTimerFired):
      * WebProcess/WebPage/PageOverlay.h:
      Remove pageOverlayShouldApplyFadeWhenPainting and fractionFadedIn().
      
      * WebProcess/WebPage/FindController.cpp:
      (WebKit::FindController::drawRect):
      Draw the find overlay without taking the PageOverlay's fade into account.
      
      * WebProcess/WebPage/TapHighlightController.cpp:
      (WebKit::TapHighlightController::drawRect):
      Remove pageOverlayShouldApplyFadeWhenPainting. Since it's always
      "false" for all ports now, take the second path here.
      
      * WebProcess/WebPage/mac/LayerTreeHostMac.h:
      * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
      (WebKit::LayerTreeHostMac::setPageOverlayOpacity):
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::setPageOverlayOpacity):
      Implement setPageOverlayOpacity for DrawingAreaImpl
      and TiledCoreAnimationDrawingArea.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8de467bf
    • fpizlo@apple.com's avatar
      hasIndexingHeader() ought really to be a property of an object and its... · 557c3d06
      fpizlo@apple.com authored
      hasIndexingHeader() ought really to be a property of an object and its structure, not just its structure
      https://bugs.webkit.org/show_bug.cgi?id=119470
      
      Reviewed by Oliver Hunt.
              
      Structure can still tell you if the object "could" (in the conservative sense)
      have an indexing header; that's used by the compiler.
              
      Most of the time if you want to know if there's an indexing header, you ask the
      JSObject.
              
      In some cases, the JSObject wants to know if it would have an indexing header if
      it had a different structure; then it uses Structure::hasIndexingHeader(JSCell*).
      
      * dfg/DFGRepatch.cpp:
      (JSC::DFG::tryCachePutByID):
      (JSC::DFG::tryBuildPutByIdList):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
      (JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
      * runtime/ButterflyInlines.h:
      (JSC::Butterfly::create):
      (JSC::Butterfly::growPropertyStorage):
      (JSC::Butterfly::growArrayRight):
      (JSC::Butterfly::resizeArray):
      * runtime/JSObject.cpp:
      (JSC::JSObject::copyButterfly):
      (JSC::JSObject::visitButterfly):
      * runtime/JSObject.h:
      (JSC::JSObject::hasIndexingHeader):
      (JSC::JSObject::setButterfly):
      * runtime/Structure.h:
      (JSC::Structure::couldHaveIndexingHeader):
      (JSC::Structure::hasIndexingHeader):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      557c3d06
    • simon.fraser@apple.com's avatar
      webaudio/audiobuffersource-loop-points.html always times out · 9c8b9629
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119467
      
      Skip this test.
      
      * platform/mac-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c8b9629
    • commit-queue@webkit.org's avatar
      PreloadScanner preloads external CSS with non-matching media attribute · da08655f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106198
      
      Patch by Yoav Weiss <yoav@yoav.ws> on 2013-08-03
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Test: http/tests/loading/preload-css-test.html
      
      * html/parser/HTMLPreloadScanner.cpp:
      Remove m_linkMediaAttributeIsScreen
      Remove MediaQueryEvaluator calls
      Add m_mediaAttribute that gets the value of the "media" attribute
      Pass m_mediaAttribute to PreloadRequest
      (WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
      (WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
      (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
      (WebCore::TokenPreloadScanner::StartTagScanner::resourceType):
      (WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
      * html/parser/HTMLResourcePreloader.cpp:
      Add MediaQueryEvaluator calls to see if "media" matches
      Perform preload only to resource with a matching media (if media exists)
      (WebCore::PreloadRequest::isSafeToSendToAnotherThread):
      (WebCore::mediaAttributeMatches):
      (WebCore::HTMLResourcePreloader::preload):
      * html/parser/HTMLResourcePreloader.h:
      Add a constructor with a mediaAttribute value
      Add m_mediaAttribute & its getter.
      (WebCore::PreloadRequest::create):
      (WebCore::PreloadRequest::media):
      (WebCore::PreloadRequest::PreloadRequest):
      
      LayoutTests:
      
      * http/tests/loading/preload-css-test-expected.txt: Added.
      * http/tests/loading/preload-css-test.html: Added.
      * http/tests/loading/resources/big_mq.css: Added.
      * http/tests/loading/resources/small_mq.css: Added.
      * http/tests/local/link-stylesheet-load-order-preload-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da08655f
    • akling@apple.com's avatar
      RenderBoxModelObject::firstLetterRemainingText should be a RenderTextFragment*. · a4df5a15
      akling@apple.com authored
      <http://webkit.org/b/119181>
      
      Reviewed by Sam Weinig.
      
      De-generalize this code a bit since we know that the firstLetterRemainingText() is always
      going to be a RenderTextFragment.
      
      * rendering/RenderBoxModelObject.h:
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::firstLetterRemainingText):
      (WebCore::RenderBoxModelObject::setFirstLetterRemainingText):
      
          Make these two deal in RenderTextFragment*.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::updateFirstLetterStyle):
      
          Tighten up some pointer types so we don't have to cast as much.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4df5a15
  4. 02 Aug, 2013 19 commits