1. 27 Mar, 2013 40 commits
    • commit-queue@webkit.org's avatar
      cache parsed interfaces in CodeGenerator.pm · 05240e15
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113446
      
      Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-27
      Reviewed by Kentaro Hara.
      
      When generating binding for an interface, informations about parent
      interfaces are sometimes needed several times. This patch caches
      those the parsed interface. When generating all WebCore bindings, this
      results in a speedup of about 40% for JavaScriptCore and about 80% for
      V8.
      
      No new tests: no change in behaviour.
      
      * bindings/scripts/CodeGenerator.pm:
      (ParseInterface):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05240e15
    • csaavedra@igalia.com's avatar
      Explicitly set editingBehavior in some tests. · e4ebde0a
      csaavedra@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113383
      
      Reviewed by Ryosuke Niwa.
      
      These tests make assumptions on how word selection works.
      Actually, word selection will work differently depending on the
      editingBehavior in place, see bug 110487, so the only way to
      ensure the following tests will do word selection as expected is
      to use Mac editing behavior.
      
      * editing/deleting/delete-by-word-001.html: Call setEditingBehavior("mac").
      * editing/deleting/list-item-1.html: ditto.
      * editing/deleting/non-smart-delete.html: ditto.
      * editing/deleting/smart-delete-002.html: ditto.
      * editing/deleting/smart-delete-across-editable-boundaries.html: ditto.
      * editing/execCommand/hilitecolor.html: ditto.
      * editing/execCommand/remove-formatting-2.html: ditto.
      * editing/inserting/4960120-2.html: ditto.
      * editing/inserting/insert-paragraph-02.html: ditto. ditto.
      * editing/inserting/insert-paragraph-03.html: ditto.
      * editing/inserting/insert-paragraph-04.html: ditto.
      * editing/inserting/paragraph-outside-nested-divs.html: ditto.
      * editing/inserting/paragraph-separator-01.html: ditto.
      * editing/inserting/paragraph-separator-02.html: ditto.
      * editing/inserting/paragraph-separator-03.html: ditto.
      * editing/pasteboard/4242293-1.html: ditto.
      * editing/pasteboard/4806874.html: ditto.
      * editing/pasteboard/5006779.html: ditto.
      * editing/pasteboard/8145-2.html: ditto.
      * editing/pasteboard/bad-placeholder.html: ditto.
      * editing/pasteboard/copy-text-with-backgroundcolor.html: ditto.
      * editing/pasteboard/drag-drop-modifies-page.html: ditto.
      * editing/pasteboard/get-data-text-plain-drop.html: ditto.
      * editing/pasteboard/insert-div-text-into-text.html: ditto.
      * editing/pasteboard/merge-end-3.html: ditto.
      * editing/pasteboard/merge-end-5.html: ditto.
      * editing/pasteboard/merge-end-borders.html: ditto.
      * editing/pasteboard/paste-blockquote-3.html: ditto.
      * editing/pasteboard/paste-list-004.html: ditto.
      * editing/pasteboard/pasting-object.html: ditto.
      * editing/selection/4932260-2.html: ditto.
      * editing/selection/extend-by-word-002.html: ditto.
      * editing/selection/extend-forward-by-word-over-non-editable.html: ditto.
      * editing/selection/transformed-selection-rects.html: ditto.
      * editing/style/5046875-1.html: ditto.
      * editing/style/5046875-2.html: ditto.
      * editing/style/fore-color-by-name.html: ditto.
      * editing/style/relative-font-size-change-002.html: ditto.
      * editing/style/relative-font-size-change-003.html: ditto.
      * editing/style/relative-font-size-change-004.html: ditto.
      * editing/style/style-boundary-005.html: ditto.
      * editing/text-iterator/first-letter-word-boundary.html: ditto.
      * editing/undo/undo-combined-delete-boundary.html: ditto.
      * editing/undo/undo-combined-delete.html: ditto.
      * editing/undo/undo-delete-boundary.html: ditto.
      * editing/undo/undo-delete.html: ditto.
      * editing/undo/undo-forward-delete-boundary.html: ditto.
      * editing/undo/undo-forward-delete.html: ditto.
      * fast/dom/34176.html: ditto.
      * platform/chromium-win/editing/deleting/non-smart-delete-expected.txt: Updated.
      * platform/efl/editing/deleting/non-smart-delete-expected.txt: Updated.
      * platform/gtk/editing/deleting/non-smart-delete-expected.txt: Updated.
      * platform/qt/editing/deleting/non-smart-delete-expected.txt: Updated.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4ebde0a
    • csaavedra@igalia.com's avatar
      Rename Editing tests whose expectations are Mac specific · 871b3544
      csaavedra@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113414
      
      Reviewed by Ryosuke Niwa.
      
      These tests have expectations that assume that word selection
      works always as in Mac and therefore will break when ran with
      editingBehavior set, for instance, to Windows (see bug
      110487). Rename them to have the suffix -mac and explicitly set
      editingBehavior to Mac.
      
      When the fix for 110487 lands, counterparts to these tests with
      suffix -win, editingBehavior set to win, and updated expectations
      will be added.
      
      * editing/deleting/smart-editing-disabled-mac-expected.txt:
      Renamed from
      LayoutTests/editing/deleting/smart-editing-disabled-expected.txt.
      * editing/deleting/smart-editing-disabled-mac.html: Renamed from
      LayoutTests/editing/deleting/smart-editing-disabled.html.
      * editing/execCommand/remove-format-multiple-elements-mac-expected.txt:
      Renamed from
      LayoutTests/editing/execCommand/remove-format-multiple-elements-expected.txt.
      * editing/execCommand/remove-format-multiple-elements-mac.html:
      Renamed from
      LayoutTests/editing/execCommand/remove-format-multiple-elements.html.
      * editing/execCommand/script-tests/remove-format-multiple-elements-mac.js:
      Renamed from
      LayoutTests/editing/execCommand/script-tests/remove-format-multiple-elements.js.
      * editing/execCommand/script-tests/toggle-link-mac.js: Renamed
      from LayoutTests/editing/execCommand/script-tests/toggle-link.js.
      * editing/execCommand/toggle-link-mac-expected.txt: Renamed from
      LayoutTests/editing/execCommand/toggle-link-expected.txt.
      * editing/execCommand/toggle-link-mac.html: Renamed from
      LayoutTests/editing/execCommand/toggle-link.html.
      * editing/style/make-text-writing-direction-inline-mac-expected.txt:
      Renamed from
      LayoutTests/editing/style/make-text-writing-direction-inline-expected.txt.
      * editing/style/make-text-writing-direction-inline-mac.html:
      Renamed from
      LayoutTests/editing/style/make-text-writing-direction-inline.html.
      * editing/style/push-down-font-styles-mac-expected.txt: Renamed
      from LayoutTests/editing/style/push-down-font-styles-expected.txt.
      * editing/style/push-down-font-styles-mac.html: Renamed from
      LayoutTests/editing/style/push-down-implicit-styles.html.
      * editing/style/push-down-implicit-styles-around-list-mac-expected.txt:
      Renamed from
      LayoutTests/editing/style/push-down-implicit-styles-around-list-expected.txt.
      * editing/style/push-down-implicit-styles-around-list-mac.html:
      Renamed from
      LayoutTests/editing/style/push-down-implicit-styles-around-list.html.
      * editing/style/push-down-implicit-styles-mac-expected.txt:
      Renamed from
      LayoutTests/editing/style/push-down-implicit-styles-expected.txt.
      * editing/style/push-down-implicit-styles-mac.html: Renamed from
      LayoutTests/editing/style/push-down-font-styles.html.
      * editing/style/script-tests/make-text-writing-direction-inline-mac.js:
      Renamed from
      LayoutTests/editing/style/script-tests/make-text-writing-direction-inline.js.
      * editing/style/script-tests/push-down-font-styles-mac.js: Renamed
      from
      LayoutTests/editing/style/script-tests/push-down-font-styles.js.
      * editing/style/script-tests/push-down-implicit-styles-around-list-mac.js:
      Renamed from
      LayoutTests/editing/style/script-tests/push-down-implicit-styles-around-list.js.
      * editing/style/script-tests/push-down-implicit-styles-mac.js:
      Renamed from
      LayoutTests/editing/style/script-tests/push-down-implicit-styles.js.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      871b3544
    • commit-queue@webkit.org's avatar
      Add a settings to disallow initializing background-size if background shorthand doesn't include it. · 27d6ce71
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113363
      
      Source/WebCore:
      
      Patch by KyungTae Kim <ktf.kim@samsung.com> and Yongjun Zhang <yongjun_zhang@apple.com> on 2013-03-27
      Reviewed by David Kilzer.
      
      This is based on KyungTae Kim's patch in https://bugs.webkit.org/show_bug.cgi?id=97761.  Many legacy sites set
      background-size first and then set background for setting background-image.  For backward-compatibility
      in some WebKit based clients, if 'background' shorthand have no 'background-size' attribute, we could add
      a settings to let the css parser not initialize 'background-size'.
      
      Test: fast/backgrounds/background-shorthand-after-set-backgroundSize.html
      
      * css/CSSParser.cpp:
      (WebCore::CSSParserContext::CSSParserContext): initialize useLegacyBackgroundSizeShorthandBehavior.
      (WebCore::operator==):
      (WebCore::CSSParser::useLegacyBackgroundSizeShorthandBehavior): add a method to return if we want background-size
          to be initialized by background shorthand.
      (WebCore):
      (WebCore::CSSParser::parseFillShorthand): don't initialize background-size in background shorthand if we have
          useLegacyBackgroundSizeShorthandBehavior set to true.
      * css/CSSParser.h:
      (CSSParser):
      * css/CSSParserMode.h: add member useLegacyBackgroundSizeShorthandBehavior to CSSParserContext.
      (CSSParserContext):
      * page/Settings.in: initialize useLegacyBackgroundSizeShorthandBehavior to false.
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::Backup::Backup): add the new settings useLegacyBackgroundSizeShorthandBehavior to Backup.
      (WebCore::InternalSettings::Backup::restoreTo): restore useLegacyBackgroundSizeShorthandBehavior from Backup.
      (WebCore::InternalSettings::setUseLegacyBackgroundSizeShorthandBehavior):
      (WebCore):
      * testing/InternalSettings.h:
      (Backup):
      (InternalSettings):
      * testing/InternalSettings.idl: add a JS testing API setUseLegacyBackgroundSizeShorthandBehavior to turn on/off
          the new settings.
      
      LayoutTests:
      
      Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-03-27
      Reviewed by David Kilzer.
      
      Add test for the new settings useLegacyBackgroundSizeShorthandBehavior.
      
      * fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt: Added.
      * fast/backgrounds/background-shorthand-after-set-backgroundSize.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27d6ce71
    • fmalita@chromium.org's avatar
      Remove unused RenderLayer::renderBox{X,Y} methods · 09211e93
      fmalita@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113408
      
      Reviewed by Simon Fraser.
      
      Minor cleanup - renderBoxX() and renderBox() are no longer used.
      
      No new tests: no functional changes.
      
      * rendering/RenderLayer.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09211e93
    • commit-queue@webkit.org's avatar
      [BlackBerry] Show compositing on the Inspector timeline properly · 64c0435a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113416
      
      Patch by Eli Fidler <efidler@blackberry.com> on 2013-03-27
      Reviewed by Rob Buis.
      
      The call to willComposite was too early and encompased the paint calls
      as well.  Moving it lower will no longer encompass the paints.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64c0435a
    • commit-queue@webkit.org's avatar
      Web Inspector: Plumb and expose cookie clearing options throughout the... · 7dfe1335
      commit-queue@webkit.org authored
      Web Inspector: Plumb and expose cookie clearing options throughout the Resources Cookies tree and views
      https://bugs.webkit.org/show_bug.cgi?id=87140
      
      Patch by PhistucK <phistuck@chromium.org> on 2013-03-27
      Reviewed by Vsevolod Vlasov.
      
      Added cookie clearing buttons and context menu options
      throughout the tree and views.
      Drive by -
      - Made sure the delete button is only visible
      when a cookie is selected.
      - Fixed a wrong JSDoc comment.
      
      * inspector/front-end/CookieItemsView.js:
      (WebInspector.CookieItemsView):
      (WebInspector.CookieItemsView.prototype.statusBarItems):
      (WebInspector.CookieItemsView.prototype._updateWithCookies):
      (WebInspector.CookieItemsView.prototype.clear):
      Added. Clears the entire cookie view.
      (WebInspector.CookieItemsView.prototype._clearButtonClicked):
      Added. Ditto (when clicking on the button).
      (WebInspector.CookieItemsView.prototype._showDeleteButton):
      Added. Shows the delete button when selecting a cookie row.
      * inspector/CookiesTable.js:
      (WebInspector.CookiesTable):
      (WebInspector.CookiesTable.prototype._clearAndRefresh):
      Added. Clears the cookies of the current table and updates it.
      (WebInspector.CookiesTable.prototype._handleContextMenuEvent):
      Added. Manages the context menu within the table.
      (WebInspector.CookiesTable.prototype.clear):
      Added. Clears the cookies of the current table.
      (WebInspector.CookiesTable.prototype.setCookies):
       Fixed a wrong JSDoc comment structure.
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel.prototype.clearCookies):
      Added. Clears the cookies of the given domain view.
      (WebInspector.CookieTreeElement.prototype.onattach):
      Added. Adds a contextmenu handler.
      (WebInspector.CookieTreeElement.prototype._handleContextMenuEvent):
      Added. Manages the context menu within cookie tree.
      (WebInspector.CookieTreeElement.prototype._clearCookies):
      Added. Clears the cookies of the view of the tree item.
      * inspector/front-end/treeoutline.js:
      (TreeOutline): Fixed a wrong JSDoc comment.
      
      * English.lproj/localizedStrings.js:
      Added strings for the context menu options.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dfe1335
    • commit-queue@webkit.org's avatar
      Web Inspector: [DTE] implement "tokenAtTextPosition" method · fa0f4dde
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113390
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Test: inspector/editor/text-editor-token-at-position.html
      
      - Add TextEditor.tokenAtTextPosition method
      - Implement tokenAtTextPosition method in DefaultTextEditor
      
      * inspector/front-end/DefaultTextEditor.js:
      (WebInspector.DefaultTextEditor.prototype.tokenAtTextPosition):
      (WebInspector.TextEditorMainPanel.prototype.compare):
      (WebInspector.TextEditorMainPanel.prototype.tokenAtTextPosition):
      (WebInspector.TextEditorMainPanel.prototype._tokenAtUnhighlightedLine):
      (WebInspector.TextEditorMainPanel.prototype.set mimeType):
      (WebInspector.TextEditorMainPanel.prototype.get mimeType):
      * inspector/front-end/TextEditor.js:
      (WebInspector.TextEditor.prototype.tokenAtTextPosition):
      * inspector/front-end/TextEditorHighlighter.js:
      (WebInspector.TextEditorHighlighter):
      (WebInspector.TextEditorHighlighter.prototype.get mimeType):
      (WebInspector.TextEditorHighlighter.prototype.set mimeType):
      
      LayoutTests:
      
      Add a test to verify TextEditor.tokenAtTextPosition method.
      
      * inspector/editor/text-editor-token-at-position-expected.txt: Added.
      * inspector/editor/text-editor-token-at-position.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa0f4dde
    • charles.wei@torchmobile.com.cn's avatar
      Remove build warning for unused function parameters in indexeddb. · 7a8f3122
      charles.wei@torchmobile.com.cn authored
      https://bugs.webkit.org/show_bug.cgi?id=113043
      
      Reviewed by Tony Chang.
      
      No new tests, just remove build warning.
      
      * Modules/indexeddb/IDBCallbacks.h:
      (WebCore::IDBCallbacks::onBlocked):
      (WebCore::IDBCallbacks::onUpgradeNeeded):
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::stringToDirection):
      * Modules/indexeddb/IDBCursor.h:
      (IDBCursor):
      * Modules/indexeddb/IDBCursorBackendImpl.cpp:
      (WebCore::IDBCursorBackendImpl::prefetchReset):
      * Modules/indexeddb/IDBDatabase.cpp:
      (WebCore::IDBDatabase::transaction):
      * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
      (WebCore::IDBDatabaseBackendImpl::setIndexesReady):
      * Modules/indexeddb/IDBIndex.cpp:
      (WebCore::IDBIndex::openCursor):
      (WebCore::IDBIndex::openKeyCursor):
      * Modules/indexeddb/IDBLevelDBCoding.cpp:
      (IDBLevelDBCoding):
      * Modules/indexeddb/IDBObjectStore.cpp:
      (WebCore):
      (WebCore::IDBObjectStore::openCursor):
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::stringToMode):
      * Modules/indexeddb/IDBTransaction.h:
      (IDBTransaction):
      * inspector/InspectorIndexedDBAgent.cpp:
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a8f3122
    • commit-queue@webkit.org's avatar
      REGRESSION (r146588): Cannot correctly display Chinese SNS Renren · 77ca28ea
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113142
      
      Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-27
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Changed CSS grammar to be equivalent to pre-r146588.
      CSS error reporting disabled to prevent message overflow.
      
      * css/CSSGrammar.y.in:
      * css/CSSParser.cpp:
      (WebCore::CSSParser::isLoggingErrors):
      
      LayoutTests:
      
      * TestExpectations:
      * fast/css/parsing-error-recovery.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77ca28ea
    • commit-queue@webkit.org's avatar
      Web Inspector: enhance Popover.js to rely on hover element coordinates · 0aa0c237
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113340
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27
      Reviewed by Pavel Feldman.
      
      No new tests: no change in behaviour.
      
      Introduce a coordinates-based method that checks if mouse is inside hover
      element and use it in PopoverHelper instead of DOM hierarchy.
      
      * inspector/front-end/Popover.js:
      (WebInspector.PopoverHelper.prototype._eventInHoverElement): Added.
      (WebInspector.PopoverHelper.prototype._mouseDown):
      (WebInspector.PopoverHelper.prototype._mouseMove):
      (WebInspector.PopoverHelper.prototype._mouseOut):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0aa0c237
    • commit-queue@webkit.org's avatar
      Web Inspector: [CodeMirror] fix webinspector-css theme for CodeMirror · 2d127e99
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113399
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27
      Reviewed by Alexander Pavlov.
      
      Add style rule to highlight css properties for CodeMirror
      webinspector-css theme.
      
      No new tests: no change in behaviour.
      
      * inspector/front-end/cm/cmdevtools.css:
      (.cm-s-web-inspector-css span.cm-property):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d127e99
    • commit-queue@webkit.org's avatar
      Web Inspector: [DTE] paint overlay highlight for unhighlighted lines · 5b35d487
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113344
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27
      Reviewed by Pavel Feldman.
      
      No new tests.
      
      Remove fast-return condition from paintLine method that checked for
      highlight existence.
      
      * inspector/front-end/DefaultTextEditor.js:
      (WebInspector.TextEditorMainPanel.prototype._paintLine):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b35d487
    • anilsson@rim.com's avatar
      [BlackBerry] Populate the mime type of the WebContext for images · e02af71e
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113272
      
      Reviewed by George Staikos.
      
      PR 278967
      
      Populate the mime type using the file extension reported by the image
      decoder. This way we benefit from file type sniffing, instead of
      relying on the mime type reported by the resource response.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e02af71e
    • commit-queue@webkit.org's avatar
      Revision for the internal jhbuild is too old · c2deee04
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113324
      
      Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-03-27
      Reviewed by Martin Robinson.
      
      Update the minimum required version to a point where jhbuild won't
      fail installing packages when trying to remove a symlink to a directory.
      
      * jhbuild/jhbuild-wrapper: Updated revision.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2deee04
    • rniwa@webkit.org's avatar
      Shift clicking on an element with -webkit-user-select: all doesn't extend selection · 9e76e369
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113270
      
      Reviewed by Enrica Casucci.
      
      Source/WebCore:
      
      The bug was caused by updateSelectionForMouseDownDispatchingSelectStart always replacing selection whenever
      the target node was inside an element with -webkit-suer-select even when we were attemping to extend selection
      in handleMousePressEventSingleClick.
      
      Fixed the bug by extracting this logic as a separate function (expandSelectionToRespectUserSelectAll) and deploying
      it in handleMousePressEventSingleClick to extend selection as needed.
      
      Test: editing/selection/user-select-all-with-shift.html
      
      * page/EventHandler.cpp:
      (WebCore::expandSelectionToRespectUserSelectAll): Extracted from updateSelectionForMouseDownDispatchingSelectStart.
      (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
      (WebCore::EventHandler::selectClosestWordFromHitTestResult):
      (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
      (WebCore::EventHandler::handleMousePressEventTripleClick):
      (WebCore::EventHandler::handleMousePressEventSingleClick): Adjust "pos" as needed when extending selection.
      Also use shouldConsiderSelectionAsDirectional() instead of manually peeking editingBehaviorType while we're at it.
      
      LayoutTests:
      
      Added a regression test for shift clicking on an element with -webkit-user-select: all.
      Skip it on non-Mac platforms as -webkit-user-select: all hasn't been enabled on them.
      
      * editing/selection/user-select-all-with-shift-expected.txt: Added.
      * editing/selection/user-select-all-with-shift.html: Added.
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e76e369
    • commit-queue@webkit.org's avatar
      REGRESSION(r143102): iframe with percentage height within table with anonymous cell fails. · 6ead1357
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113077
      
      Source/WebCore:
      
      Patch by Zalan Bujtas <zalan@apple.com> on 2013-03-27
      Reviewed by Antti Koivisto.
      
      http://www.w3.org/TR/CSS21/visuren.html#anonymous-block-level
      "Anonymous block boxes are ignored when resolving percentage values that would refer to it:
      the closest non-anonymous ancestor box is used instead."
      When figuring out whether auto height needs to be applied on the current box, ignore anonymous
      ancestors until the first non-anonymous containing block is found. This matches both
      Firefox and Opera behaviour.
      
      Test: fast/replaced/iframe-with-percentage-height-within-table-with-anonymous-table-cell.html
      
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight): Switch from
      isAnonymousBlock() to isAnonymous() to make sure all anonymous boxes are ignored.
      Remove isTableCell() check which is a noop as table cell isn't an anonymous block.
      
      LayoutTests:
      
      Patch by Zalan Bujtas <zalan@apple.com> on 2013-03-27
      Reviewed by Antti Koivisto.
      
      * fast/replaced/iframe-with-percentage-height-within-table-with-anonymous-table-cell-expected.txt: Added.
      * fast/replaced/iframe-with-percentage-height-within-table-with-anonymous-table-cell.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ead1357
    • pierre.rossi@gmail.com's avatar
      [Qt] Add WOFF support when using zlib · 796b9ac7
      pierre.rossi@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112805
      
      Reviewed by Allan Sandfeld Jensen.
      
      Source/WebCore:
      
      Covered by existing test:
      fast/css/font-face-woff.html
      
      * Target.pri: Conditional inclusion of WOFFFileFormat
      * platform/graphics/qt/FontCustomPlatformDataQt.cpp:
      (WebCore::createFontCustomPlatformData): Try to unpack WOFF data, otherwise spit out a warning and bail.
      (WebCore::FontCustomPlatformData::supportsFormat): accept WOFF webfonts if USE(ZLIB).
      
      LayoutTests:
      
      * platform/qt-5.0-wk2/TestExpectations: keep skipped for WK2 due to a WTR bug.
      * platform/qt/TestExpectations: unskip font-face-woff.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      796b9ac7
    • robert@webkit.org's avatar
      Growing a position:absolute element in a position:relative one in a table does... · 4c91cc94
      robert@webkit.org authored
      Growing a position:absolute element in a position:relative one in a table does not update scrollHeight
      https://bugs.webkit.org/show_bug.cgi?id=111977
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      During simplified layout tables still need to know about overflow from positioned objects in any of
      their cells.
      
      Test: fast/table/cell-overflow-simplified-layout.html
      
      * rendering/RenderBlock.h:
      (RenderBlock):
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::simplifiedNormalFlowLayout):
      (WebCore):
      * rendering/RenderTable.h:
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::layoutRows):
      (WebCore):
      (WebCore::RenderTableSection::computeOverflowFromCells):
      * rendering/RenderTableSection.h:
      (RenderTableSection):
      
      LayoutTests:
      
      * fast/table/cell-overflow-simplified-layout-expected.html: Added.
      * fast/table/cell-overflow-simplified-layout.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c91cc94
    • ggaren@apple.com's avatar
      Honor the setting for whether JavaScript markup is enabled · 20c53674
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113122
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore: 
      
      * dom/ScriptableDocumentParser.cpp:
      (WebCore::ScriptableDocumentParser::ScriptableDocumentParser): Applied the
      setting here, so all document parsing would be covered. This is similar
      to what we do for plug-in stripping.
      
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::HTMLConstructionSite::insertForeignElement): Fixed a bug where
      we would insert an SVG script element into the document even in script
      markup disabled mode.
      
      (This bug has existed for copy/paste for a long time, but other bugs and
      quirks in SVG copy/paste papered over it. It's a serious issue now
      that non-paste clients will rely on this mode.)
      
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::processTokenInForeignContent): Fixed the same
      bug -- this time in the part of the parser that executes scripts as they
      parse.
      
      I adopted the toScriptElement() convention for testing for a script
      element to match the XML parser.
      
      LayoutTests: 
      
      * editing/unsupported-content/script-markup-enabled-setting-expected.txt: Added.
      * editing/unsupported-content/script-markup-enabled-setting.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20c53674
    • mhahnenberg@apple.com's avatar
      CodeCache::m_capacity can becoming negative, producing undefined results in pruneSlowCase · 62292722
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113453
      
      Reviewed by Geoffrey Garen.
      
      * runtime/CodeCache.cpp:
      (JSC::CodeCacheMap::pruneSlowCase): We make sure that m_minCapacity doesn't drop below zero now.
      This prevents m_capacity from doing the same.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62292722
    • kov@webkit.org's avatar
      [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup · 7d2e626c
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113203
      
      Reviewed by Philippe Normand.
      
      We build our libsoup without GNOME support. gst-plugins-good does separate
      pkg-config checks for libsoup-gnome and libsoup, causing the build to use
      libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
      build failures as the headers of those diverge. We do not use souphttpsrc, so
      disable it when building gst-plugins-good.
      
      * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d2e626c
    • kov@webkit.org's avatar
      Tamil translation for Gnome 3.6 · ecf4b6fa
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96995
      
      Patch by Shantha kumar <shkumar@redhat.com> on 2013-03-27
      Reviewed by Gustavo Noronha Silva (kov).
      
      * ta.po: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecf4b6fa
    • jer.noble@apple.com's avatar
      Going full screen and cancelling gets system into a weird state · fc205776
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113445
      
      Reviewed by Eric Carlson.
      
      Replace an array of BOOL member variables to track full screen state with a single enum, and
      add state tracking for the "waiting to enter" and "waiting to exit" states. Use this new,
      more specific enum to be more stringent about the state when responding to WebProcess
      messages. Also only set the placeholder view's target once in full screen mode.
      
      * UIProcess/mac/WKFullScreenWindowController.h:
      * UIProcess/mac/WKFullScreenWindowController.mm:
      (-[WKFullScreenWindowController isFullScreen]): Yes when in full screen, entering full screen,
          or waiting to enter full screen.
      (-[WKFullScreenWindowController cancelOperation:]): Only requestExitFullScreen() if a watchdog
          has not already been made active.
      (-[WKFullScreenWindowController enterFullScreen:]): Use the new state variable.
      (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Ditto.
      (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Ditto. Set the placeholder target.
      (-[WKFullScreenWindowController exitFullScreen]): Ditto. Clear the placeholder target.
      (-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Ditto.
      (-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]): Ditto.
      (-[WKFullScreenWindowController performClose:]): Ditto.
      (-[WKFullScreenWindowController close]): Ditto.
      (-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc205776
    • dino@apple.com's avatar
      Chromium Mac fails to build after r146995 because the new NSFont category · 6dcaced0
      dino@apple.com authored
      may conflict with the system. Add the WebCoreTheme category to the whitelist.
      
      Unreviewed.
      
      * WebCore.gyp/WebCore.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dcaced0
    • rniwa@webkit.org's avatar
      Build fix after r146852. Please another reference to the Lion leaks builder. · ea1d2800
      rniwa@webkit.org authored
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea1d2800
    • beidson@apple.com's avatar
      Blind attempt at fixing the release build. · 7703b5c8
      beidson@apple.com authored
      * NetworkProcess/mac/NetworkResourceLoaderMac.mm:
      (WebKit::NetworkResourceLoader::willCacheResponseAsync):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7703b5c8
    • rniwa@webkit.org's avatar
      Another Windows build fix attempt after r147004. · 3fb26566
      rniwa@webkit.org authored
      * WebKit.vcproj/WebKitExports.def.in:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fb26566
    • rniwa@webkit.org's avatar
      Selection code spends a lot of time in InlineTextBox::localSelectionRect · fe851a45
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113364
      
      Reviewed by Enrica Casucci.
      
      Avoid computing the font width when we're selecting the entire line box.
      
      This appears to be 25-26% improvement on Interactive/SelectAll:Time.
      
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::localSelectionRect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe851a45
    • timothy@apple.com's avatar
      Windows build fix attempt. · 79c34d60
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79c34d60
    • beidson@apple.com's avatar
      Mem mapped resource data improvements. · a42079b8
      beidson@apple.com authored
      <rdar://problem/13196481> and https://bugs.webkit.org/show_bug.cgi?id=113422
      
      Reviewed by Alexey Proskuryakov (and looked over by Geoff Garen).
      
      Remove timer-based approach support code:
      * NetworkProcess/NetworkResourceLoader.cpp:
      (WebKit::NetworkResourceLoader::NetworkResourceLoader):
      (WebKit::NetworkResourceLoader::abortInProgressLoad):
      (WebKit::NetworkResourceLoader::didFinishLoading):
      * NetworkProcess/NetworkResourceLoader.h:
      
      Add an object to encapsulate monitoring a resource going in to the disk cache.
      It listens for a callback on the cached response indicating it is disk backed
      and also sets a timeout so we don't keep the monitor alive and waiting forever.
      * NetworkProcess/mac/DiskCacheMonitor.h: Added.
      (WebKit::DiskCacheMonitor::destinationID):
      (WebKit::DiskCacheMonitor::connectionToWebProcess):
      (WebKit::DiskCacheMonitor::resourceRequest):
      * NetworkProcess/mac/DiskCacheMonitor.mm: Added.
      (CFCachedURLResponseSetBecameFileBackedCallBackBlock):
      (WebKit::monitorFileBackingStoreCreation):
      (WebKit::DiskCacheMonitor::DiskCachingMonitor):
      (WebKit::DiskCacheMonitor::connection):
      
      Refactoring and monitor certain cached responses:
      * NetworkProcess/mac/NetworkResourceLoaderMac.mm:
      (CFCachedURLResponseGetMemMappedData):
      (WebKit::NetworkResourceLoader::tryGetShareableHandleFromCFURLCachedResponse): Use CFCachedURLResponseGetMemMappedData
        to explicitly get an mem-mapped data object.
      (WebKit::NetworkResourceLoader::tryGetShareableHandleForResource):
      (WebKit::NetworkResourceLoader::willCacheResponseAsync): If the resource is over the minimum
        size then set up a disk caching monitor.
      
      * WebKit2.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a42079b8
    • timothy@apple.com's avatar
      Add missing images from my previous commit. · 933e8f5f
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      933e8f5f
    • timothy@apple.com's avatar
      Add support for dock-to-right of the Web Inspector in the Mac port. · 3e6451ee
      timothy@apple.com authored
      Unfortunately this requires Safari changes, so it is disabled in the nightly builds.
      
      https://webkit.org/b/113341
      rdar://problem/10368152
      
      Reviewed by Joseph Pecoraro.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * inspector/InspectorFrontendClient.h:
      (InspectorFrontendClient):
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore):
      (WebCore::InspectorFrontendClientLocal::frontendLoaded):
      (WebCore::InspectorFrontendClientLocal::requestSetDockSide):
      (WebCore::InspectorFrontendClientLocal::canAttachWindow):
      (WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
      (WebCore::InspectorFrontendClientLocal::setAttachedWindow):
      (WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowWidth):
      * inspector/InspectorFrontendClientLocal.h:
      (InspectorFrontendClientLocal):
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::InspectorFrontendHost::setAttachedWindowWidth):
      (WebCore):
      * inspector/InspectorFrontendHost.h:
      (InspectorFrontendHost):
      * inspector/InspectorFrontendHost.idl:
      * inspector/front-end/InspectorFrontendHostStub.js:
      (.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowWidth):
      * inspector/front-end/externs.js:
      (InspectorFrontendHostAPI.prototype.setAttachedWindowWidth):
      * testing/Internals.cpp:
      
      Source/WebKit/chromium:
      
      * src/InspectorFrontendClientImpl.cpp:
      (WebKit::InspectorFrontendClientImpl::changeAttachedWindowWidth):
      * src/InspectorFrontendClientImpl.h:
      (InspectorFrontendClientImpl):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/InspectorClientEfl.cpp:
      (WebCore::InspectorFrontendClientEfl::attachWindow):
      (WebCore::InspectorFrontendClientEfl::setAttachedWindowWidth):
      * WebCoreSupport/InspectorClientEfl.h:
      (InspectorFrontendClientEfl):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/InspectorClientGtk.cpp:
      (WebKit::InspectorFrontendClient::attachWindow):
      (WebKit::InspectorFrontendClient::setAttachedWindowWidth):
      * WebCoreSupport/InspectorClientGtk.h:
      (InspectorFrontendClient):
      
      Source/WebKit/mac:
      
      * Resources/Dock.pdf: Updated.
      * WebCoreSupport/WebInspectorClient.h:
      (WebInspectorFrontendClient):
      * WebCoreSupport/WebInspectorClient.mm:
      (WebInspectorFrontendClient::frontendLoaded):
      (WebInspectorFrontendClient::attachWindow):
      (WebInspectorFrontendClient::setAttachedWindowWidth):
      (-[WebInspectorWindowController attachWindow:]):
      (-[WebInspectorWindowController attach]):
      (-[WebInspectorWindowController detach]):
      * WebInspector/WebInspectorFrontend.mm:
      (-[WebInspectorFrontend attach]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/InspectorClientQt.cpp:
      (WebCore::InspectorFrontendClientQt::frontendLoaded):
      (WebCore::InspectorFrontendClientQt::attachWindow):
      (WebCore::InspectorFrontendClientQt::setAttachedWindowWidth):
      * WebCoreSupport/InspectorClientQt.h:
      (InspectorFrontendClientQt):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebInspectorClient.cpp:
      (WebInspectorFrontendClient::frontendLoaded):
      (WebInspectorFrontendClient::attachWindow):
      (WebInspectorFrontendClient::setAttachedWindowWidth):
      * WebCoreSupport/WebInspectorClient.h:
      (WebInspectorFrontendClient):
      
      Source/WebKit2:
      
      * Resources/Dock.pdf: Removed.
      * Resources/DockBottom.pdf: Added.
      * Resources/DockRight.pdf: Added.
      * Shared/WebPreferencesStore.h:
      * UIProcess/WebInspectorProxy.cpp:
      (WebKit::WebInspectorProxy::WebInspectorProxy):
      (WebKit::WebInspectorProxy::attachBottom):
      (WebKit::WebInspectorProxy::attachRight):
      (WebKit::WebInspectorProxy::attach):
      (WebKit::WebInspectorProxy::detach):
      (WebKit::WebInspectorProxy::setAttachedWindowWidth):
      (WebKit::WebInspectorProxy::createInspectorPage):
      (WebKit::WebInspectorProxy::canAttach):
      * UIProcess/WebInspectorProxy.h:
      (WebInspectorProxy):
      * UIProcess/WebInspectorProxy.messages.in:
      * UIProcess/mac/WebInspectorProxyMac.mm:
      (-[WKWebInspectorProxyObjCAdapter attachRight:]):
      (-[WKWebInspectorProxyObjCAdapter attachBottom:]):
      (-[WKWebInspectorWindow _cursorForResizeDirection:]):
      (-[WKWebInspectorWindow _customTitleFrame]):
      (WebKit::createDockButton):
      (WebKit::WebInspectorProxy::createInspectorWindow):
      (WebKit::WebInspectorProxy::platformCreateInspectorPage):
      (WebKit::WebInspectorProxy::platformAttachAvailabilityChanged):
      (WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
      (WebKit::WebInspectorProxy::platformInspectedWindowWidth):
      (WebKit::WebInspectorProxy::platformAttach):
      (WebKit::WebInspectorProxy::platformDetach):
      (WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
      (WebKit::WebInspectorProxy::platformSetAttachedWindowWidth):
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
      (WebKit::WebInspectorFrontendClient::attachWindow):
      (WebKit::WebInspectorFrontendClient::setAttachedWindowWidth):
      * WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
      (WebInspectorFrontendClient):
      * WebProcess/WebPage/WebInspector.cpp:
      (WebKit::WebInspector::attachBottom):
      (WebKit::WebInspector::attachRight):
      (WebKit::WebInspector::setAttachedWindowWidth):
      (WebKit::WebInspector::attachedBottom):
      (WebKit::WebInspector::attachedRight):
      (WebKit::WebInspector::detached):
      * WebProcess/WebPage/WebInspector.h:
      (WebInspector):
      * WebProcess/WebPage/WebInspector.messages.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e6451ee
    • kov@webkit.org's avatar
      Updated Slovenian translation · e7a292b3
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113151
      
      Patch by Matej Urbančič <mateju@svn.gnome.org> on 2013-03-27
      Reviewed by Gustavo Noronha Silva (kov).
      
      * sl.po: translation update.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7a292b3
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. Rebaselining after r146992. · 47eb06c7
      zandobersek@gmail.com authored
      * platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
      * platform/gtk/fast/layers/video-layer-expected.txt:
      * platform/gtk/media/audio-controls-rendering-expected.txt:
      * platform/gtk/media/audio-repaint-expected.txt:
      * platform/gtk/media/controls-after-reload-expected.txt:
      * platform/gtk/media/controls-strict-expected.txt:
      * platform/gtk/media/controls-styling-strict-expected.txt:
      * platform/gtk/media/controls-without-preload-expected.txt:
      * platform/gtk/media/video-controls-rendering-expected.txt:
      * platform/gtk/media/video-display-toggle-expected.txt:
      * platform/gtk/media/video-empty-source-expected.txt:
      * platform/gtk/media/video-no-audio-expected.txt:
      * platform/gtk/media/video-playing-and-pause-expected.txt:
      * platform/gtk/media/video-volume-slider-expected.txt:
      * platform/gtk/media/video-zoom-controls-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47eb06c7
    • eric.carlson@apple.com's avatar
      [Mac] webkitClosedCaptionsVisible doesn't work · 92907e15
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113417
      
      Reviewed by Jer Noble.
      
      Source/WebCore: 
      
      Test: media/track/track-in-band-legacy-api.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement): Delete m_disableCaptions, it is no longer used.
      (WebCore::HTMLMediaElement::configureTextTrackGroup): Pass this to textTrackSelectionScore.
      (WebCore::HTMLMediaElement::setClosedCaptionsVisible):  Delete m_disableCaptions, it is no longer used.
      * html/HTMLMediaElement.h: Ditto.
      
      * page/CaptionUserPreferences.cpp:
      (WebCore::CaptionUserPreferences::textTrackSelectionScore): Add an HTMLMediaElement parameter.
      * page/CaptionUserPreferences.h:
      
      * page/CaptionUserPreferencesMac.h:
      * page/CaptionUserPreferencesMac.mm:
      (WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Return a score if the media element
          is showing captions, even if the preference says captions are disabled.
      
      LayoutTests: 
      
      * media/track/track-in-band-legacy-api-expected.txt: Added.
      * media/track/track-in-band-legacy-api.html: Added.
      
      * platform/chromium/TestExpectations: Skip new test.
      * platform/efl/TestExpectations: Ditto.
      * platform/gtk/TestExpectations: Ditto.
      * platform/mac/TestExpectations: Ditto.
      * platform/qt/TestExpectations: Ditto.
      * platform/win/TestExpectations: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92907e15
    • eric.carlson@apple.com's avatar
      [Mac] Text track menu items sometimes labeled incorrectly · d0daea36
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113406
      
      Reviewed by Jer Noble.
      
      Source/WebCore: 
      
      media/video-controls-captions-trackmenu-localized.html was updated to test this.
      
      * page/CaptionUserPreferencesMac.mm:
      (WebCore::trackDisplayName): Use the 'label' attribute for the menu text when necessary.
      
      LayoutTests: 
      
      * media/video-controls-captions-trackmenu-localized.html:
      * platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0daea36
    • sergio@webkit.org's avatar
      Inserting a blank (" ") at the end of a line does not insert anything in Overtype mode · 147de161
      sergio@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113413
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Perform a "normal" insert instead of a replace when there is
      nothing to replace (like at the end of a line) as this case is not
      supported by the replacing code path. This will allow us to
      properly rebalance whitespaces in those cases.
      
      Updated the editing/execCommand/overtype.html test to check also
      this use case.
      
      * editing/InsertTextCommand.cpp:
      (WebCore::InsertTextCommand::setEndingSelectionWithoutValidation):
      (WebCore::InsertTextCommand::performTrivialReplace):
      (WebCore::InsertTextCommand::performOverwrite):
      (WebCore::InsertTextCommand::doApply): use the recently added
      setEndingSelectionWithoutValidation() to avoid code duplication.
      * editing/InsertTextCommand.h:
      (InsertTextCommand):
      
      LayoutTests:
      
      Updated the test to include the case of inserting a whitespace
      both in the middle or at the end of a line.
      
      * editing/execCommand/overtype-expected.txt:
      * editing/execCommand/overtype.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      147de161
    • zandobersek@gmail.com's avatar
      [GTK][webkitpy] A huge list of warnings about missing bugs in expectations... · dd1d9f54
      zandobersek@gmail.com authored
      [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
      https://bugs.webkit.org/show_bug.cgi?id=113421
      
      Reviewed by Dirk Pranke.
      
      When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
      This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
      equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
      in the GTK-specific TestExpectations files.
      
      To avoid this only enable the warnings only when not using WKTR.
      
      * Scripts/webkitpy/layout_tests/port/gtk.py:
      (GtkPort.warn_if_bug_missing_in_test_expectations):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd1d9f54
    • rniwa@webkit.org's avatar
      Add a performance tests for selecting all content in a document · 4fffc657
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113358
      
      Reviewed by Levi Weintraub.
      
      Add a performance test for selecting all. We wait for paint to happen by setTimeout(~, 0).
      
      Example outputs:
          RESULT Interactive: SelectAll: Time= 652.6 ms
          median= 644.5 ms, stdev= 54.6177144967 ms, min= 599.0 ms, max= 773.0 ms
      
          RESULT Interactive: SelectAll: Time= 654.4 ms
          median= 633.5 ms, stdev= 55.9223145368 ms, min= 600.0 ms, max= 769.0 ms
      
          RESULT Interactive: SelectAll: Time= 657.9 ms
          median= 640.0 ms, stdev= 54.1420159833 ms, min= 604.0 ms, max= 774.0 ms
      
      * Interactive/SelectAll.html: Added.
      * Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fffc657