- 13 Jun, 2011 2 commits
-
-
morrita@google.com authored
Unreviewed, rolling out r88625. http://trac.webkit.org/changeset/88625 https://bugs.webkit.org/show_bug.cgi?id=61073 Breaks SL Webkit2 Tests * platform/mac-wk2/Skipped: 2011-06-12 MORITA Hajime <morrita@google.com> Unreviewed, rolling out r88625. http://trac.webkit.org/changeset/88625 https://bugs.webkit.org/show_bug.cgi?id=61073 Breaks SL Webkit2 Tests * WebKit.vcproj/WebKit.sln: 2011-06-12 MORITA Hajime <morrita@google.com> Unreviewed, rolling out r88625. http://trac.webkit.org/changeset/88625 https://bugs.webkit.org/show_bug.cgi?id=61073 Breaks SL Webkit2 Tests * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jer.noble@apple.com authored
Reviewed by Darin Adler. REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page https://bugs.webkit.org/show_bug.cgi?id=62507 No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling webkitWillExitFullScreenForElement() to be able to test this. If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their containsFullScreenElement property removed. To protect against this, reset the property by calling setContainsFullScreenElementRecursively() from within fullScreenElementRemoved(). * dom/Document.cpp: (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 12 Jun, 2011 18 commits
-
-
abarth@webkit.org authored
Reviewed by Alexey Proskuryakov. Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense https://bugs.webkit.org/show_bug.cgi?id=62516 As requested by Alexey in https://bugs.webkit.org/show_bug.cgi?id=62510. * loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::interruptedForPolicyChangeError): * loader/FrameLoaderClient.h: * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptedForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy): * loader/MainResourceLoader.h: 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense https://bugs.webkit.org/show_bug.cgi?id=62516 * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::interruptedForPolicyChangeError): * src/FrameLoaderClientImpl.h: 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense https://bugs.webkit.org/show_bug.cgi?id=62516 * WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError): * WebCoreSupport/FrameLoaderClientEfl.h: 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense https://bugs.webkit.org/show_bug.cgi?id=62516 * WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::interruptedForPolicyChangeError): * WebCoreSupport/FrameLoaderClientGtk.h: 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense https://bugs.webkit.org/show_bug.cgi?id=62516 * WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::interruptedForPolicyChangeError): * WebCoreSupport/FrameLoaderClientHaiku.h: 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense https://bugs.webkit.org/show_bug.cgi?id=62516 * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::interruptedForPolicyChangeError): 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense https://bugs.webkit.org/show_bug.cgi?id=62516 * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError): * WebCoreSupport/FrameLoaderClientQt.h: 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense https://bugs.webkit.org/show_bug.cgi?id=62516 * WebFrame.cpp: (WebFrame::interruptedForPolicyChangeError): * WebFrame.h: 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense https://bugs.webkit.org/show_bug.cgi?id=62516 * WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::interruptedForPolicyChangeError): * WebCoreSupport/FrameLoaderClientWinCE.h: 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense https://bugs.webkit.org/show_bug.cgi?id=62516 * WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::interruptedForPolicyChangeError): * WebKitSupport/FrameLoaderClientWx.h: 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense https://bugs.webkit.org/show_bug.cgi?id=62516 * WebProcess/WebCoreSupport/WebErrors.h: * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::interruptedForPolicyChangeError): * WebProcess/WebCoreSupport/WebFrameLoaderClient.h: * WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: (WebKit::interruptedForPolicyChangeError): * WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp: (WebKit::interruptedForPolicyChangeError): * WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: (WebKit::interruptedForPolicyChangeError): * WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: (WebKit::interruptedForPolicyChangeError): * WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: (WebKit::interruptedForPolicyChangeError): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Hajime Morita. Add null checks to HTMLTextAreaElement::removeSpellcheckRange(). https://bugs.webkit.org/show_bug.cgi?id=62526 This change adds null checks to the following function to prevent crashes when calling removeSpellcheckRange() with null: HTMLTextAreaElement::removeSpellcheckRange(), HTMLInputElement::removeSpellcheckRange(), and HTMLDivElement::removeSpellcheckRange(). * editing/spelling/spellcheck-api-crash-expected.txt: Added. * editing/spelling/spellcheck-api-crash.html: Added. 2011-06-12 Hironori Bono <hbono@chromium.org> Reviewed by Hajime Morita. Add null checks to HTMLTextAreaElement::removeSpellcheckRange(). https://bugs.webkit.org/show_bug.cgi?id=62526 This change adds null checks to the following function to prevent crashes when calling removeSpellcheckRange() with null: HTMLTextAreaElement::removeSpellcheckRange(), HTMLInputElement::removeSpellcheckRange(), and HTMLDivElement::removeSpellcheckRange(). Test: editing/spelling/spellcheck-api-crash.html * html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::removeSpellcheckRange): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::removeSpellcheckRange): * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::removeSpellcheckRange): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mahesh.kulkarni@nokia.com authored
Reviewed by Antonio Gomes. [Qt] LayoutTestController needs setTextDirection implementation https://bugs.webkit.org/show_bug.cgi?id=62442 Implements LayoutController.setTextDirection. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setTextDirection): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> Reviewed by Antonio Gomes. [Qt] LayoutTestController needs setTextDirection implementation https://bugs.webkit.org/show_bug.cgi?id=62442 Unskipping fast/html/set-text-direction.html. * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dominicc@chromium.org authored
Reviewed by Hajime Morita. Add window.internals to WebKit2's WebKitTestRunner. https://bugs.webkit.org/show_bug.cgi?id=61073 * platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html 2011-06-12 Dominic Cooney <dominicc@chromium.org> Reviewed by Hajime Morita. Add window.internals to WebKit2's WebKitTestRunner. https://bugs.webkit.org/show_bug.cgi?id=61073 * WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport 2011-06-12 Dominic Cooney <dominicc@chromium.org> Reviewed by Hajime Morita. Add window.internals to WebKit2's WebKitTestRunner. https://bugs.webkit.org/show_bug.cgi?id=61073 Test: fast/harness/internals-object.html * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Attempt to fix Qt build. * WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Darin Adler. DocumentParser::appendBytes should use size_t for length instead of int https://bugs.webkit.org/show_bug.cgi?id=62508 size_t is the proper type for distances in memory, especially on 64 bit machines. * dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes): * dom/DecodedDataDocumentParser.h: * dom/DocumentParser.h: * html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes): * html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes): * html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes): * loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Eric Seidel. Remove FrameLoader::isProcessingUserGesture https://bugs.webkit.org/show_bug.cgi?id=62519 This function is a remnant of the old user gesture design, which involved per-frame state stored on FrameLoader. Now that we're using static state, we don't need this function anymore. This function used to check whether JavaScript was enabled for the top-level frame, but that check doesn't make any sense (like much of the old user gesture code). * WebCore.exp.in: * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture): * loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): * loader/FrameLoader.h: * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click): 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. Remove FrameLoader::isProcessingUserGesture https://bugs.webkit.org/show_bug.cgi?id=62519 * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isProcessingUserGesture): 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. Remove FrameLoader::isProcessingUserGesture https://bugs.webkit.org/show_bug.cgi?id=62519 * WebView/WebView.mm: (-[WebView _isProcessingUserGesture]): 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. Remove FrameLoader::isProcessingUserGesture https://bugs.webkit.org/show_bug.cgi?id=62519 * WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus): 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. Remove FrameLoader::isProcessingUserGesture https://bugs.webkit.org/show_bug.cgi?id=62519 Instead of asking the gesture indicator directly, ask the ScriptController, like everyone else. The gesture indicator is just one of the piece of information we use to determine whether we're processing a user gesture. * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::isProcessingUserGesture): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Reviewed by Martin Robinson. [GTK] Remove webkit_web_view_get_selected_text https://bugs.webkit.org/show_bug.cgi?id=62512 It's no longer used and it's a private method, so it can be removed. * webkit/webkitwebview.cpp: kill it. * webkit/webkitwebviewprivate.h: ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Unreviewed, rolling out r88616. http://trac.webkit.org/changeset/88616 https://bugs.webkit.org/show_bug.cgi?id=62517 It broke editing/text-iterator/findString.html (Requested by tonikitoo on #webkit). * platform/qt/Skipped: 2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r88616. http://trac.webkit.org/changeset/88616 https://bugs.webkit.org/show_bug.cgi?id=62517 It broke editing/text-iterator/findString.html (Requested by tonikitoo on #webkit). * DumpRenderTree/qt/LayoutTestControllerQt.cpp: * DumpRenderTree/qt/LayoutTestControllerQt.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Fix fullscreen/full-screen-iframe-legacy.html. * html/HTMLVideoElement.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Alexey Proskuryakov. Remove trival "forward-to-client" member functions from FrameLoader https://bugs.webkit.org/show_bug.cgi?id=62510 Update to call the FrameLoaderClient directly. Also, remove cargo-cult code that checks whether FrameLoader is null. * webkit/webkitwebview.cpp: (webkit_web_view_stop_loading): (webkit_web_view_can_show_mime_type): 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Remove trival "forward-to-client" member functions from FrameLoader https://bugs.webkit.org/show_bug.cgi?id=62510 * WebCoreSupport/WebFrameNetworkingContext.cpp: (WebFrameNetworkingContext::blockedError): 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Remove trival "forward-to-client" member functions from FrameLoader https://bugs.webkit.org/show_bug.cgi?id=62510 * WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::blockedError): 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Remove trival "forward-to-client" member functions from FrameLoader https://bugs.webkit.org/show_bug.cgi?id=62510 Originally, FrameLoader was supposed to abstract FrameLoaderClient, but we lost that battle log ago. Nowadays, it's easier if folks just call into FrameLoaderClient directly. Many of these functions have direct callers already anyway. * WebCore.exp.in: * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::attach): * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::setupForReplaceByMIMEType): * loader/FrameLoader.cpp: (WebCore::FrameLoader::didFirstLayout): * loader/FrameLoader.h: - cancelledError is slightly more delicate, so I'm going to move it in a separate patch. * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::handleEmptyLoad): (WebCore::MainResourceLoader::loadNow): * loader/MainResourceLoader.h: * loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): * loader/PingLoader.cpp: (WebCore::PingLoader::PingLoader): * loader/PolicyChecker.cpp: (WebCore::PolicyChecker::continueAfterNavigationPolicy): * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::blockedError): (WebCore::ResourceLoader::cannotShowURLError): (WebCore::ResourceLoader::shouldUseCredentialStorage): (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): * page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate): 2011-06-12 Adam Barth <abarth@webkit.org> Reviewed by Alexey Proskuryakov. Remove trival "forward-to-client" member functions from FrameLoader https://bugs.webkit.org/show_bug.cgi?id=62510 * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: (WebKit::WebFrameNetworkingContext::blockedError): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/9513180mitz@apple.com authored
<rdar://problem/9513180> REGRESSION (r84166): recalcStyle for display:inline to display:none transition has complexity N^2 where N is the number of child Text nodes https://bugs.webkit.org/show_bug.cgi?id=61557 Reviewed by Darin Adler. Replaced the fix for bug 58500 with a refined version. * rendering/RenderText.cpp: (WebCore::RenderText::clippedOverflowRectForRepaint): Use the containing block unless it is across a layer boundary. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mahesh.kulkarni@nokia.com authored
https://bugs.webkit.org/show_bug.cgi?id=62442 Reviewed by Antonio Gomes. Tools: Implements LayoutController.setTextDirection. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setTextDirection): * DumpRenderTree/qt/LayoutTestControllerQt.h: LayoutTests: Unskipping fast/html/set-text-direction.html. * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Andreas Kling. Minor user-gesture related cleanup https://bugs.webkit.org/show_bug.cgi?id=62511 In reading the user gesture code, I noticed that these lines of code should be deleted because they don't do anything. * bindings/v8/NPV8Object.cpp: * html/HTMLAnchorElement.cpp: * html/HTMLVideoElement.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Unreviewed. Build fix for !ENABLE(JIT) after r88604. * bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
Reviewed by Dirk Schulze. Add TextRun charactersLength member https://bugs.webkit.org/show_bug.cgi?id=62501 Preparation patch 2: Propagate the maximum length of the characters buffer the TextRun operates on, even when we're only measuring a substring. For example: In RenderText when we're measuring 'len' characters starting from "text()->characters() + start", there's a portion of "textLength() - start" characters that we're not processing. In order to support ligatures when integrating SVG Fonts within the GlyphPage concept, we need this extra information, to lookup ligatures even when single chars are measured. If a font defines an eg "ffl" ligature, and we're measuring the "f" of "ffl", it shall looukp the "ffl" glyph from the font, and skip the next two characters (this will be done in WidthIterator). This doesn't yet affect any test, the new SVG Fonts code is not merged yet, this is the preparaion patch 2. * platform/graphics/Font.h: Add yet-unused "const TextRun&" parameter to drawGlyphBuffer/drawEmphasisMarks. * platform/graphics/FontFastPath.cpp: Ditto. This parameter will be used to looukp the TextRunRenderingContext in a follow-up patch. (WebCore::Font::drawSimpleText): (WebCore::Font::drawEmphasisMarksForSimpleText): (WebCore::Font::drawGlyphBuffer): (WebCore::Font::drawEmphasisMarks): * platform/graphics/TextRun.h: Add "int m_charactersLength", similar to "int m_len". It denotes the maximum length of the characters buffer that we're holding. It defaults to the passed "len" value, but is overriden by explicit setCharactersLength calls. (WebCore::TextRun::TextRun): (WebCore::TextRun::charactersLength): (WebCore::TextRun::setCharactersLength): * platform/graphics/mac/FontComplexTextMac.cpp: Pass TextRun do drawGlyphBuffer/drawEmphasisMarks. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText): * platform/graphics/win/FontWin.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText): * platform/graphics/wx/FontWx.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText): * rendering/InlineTextBox.cpp: Call setCharactersLength on the processed TextRun. (WebCore::InlineTextBox::constructTextRun): * rendering/RenderBlockLineLayout.cpp: Ditto. (WebCore::textWidth): (WebCore::tryHyphenating): * rendering/RenderText.cpp: Ditto. (WebCore::RenderText::widthFromCache): (WebCore::RenderText::computePreferredLogicalWidths): (WebCore::RenderText::width): * rendering/svg/SVGInlineTextBox.cpp: Ditto. (WebCore::SVGInlineTextBox::constructTextRun): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
robert@webkit.org authored
Reviewed by Andreas Kling. [Qt] Fix methods.html and methods-lower-case.html https://bugs.webkit.org/show_bug.cgi?id=62221 Our expectations for the unskipped tests have the following differences from the mac platform: - POST requests with no data get a default Content-Type of 'application/octet-stream' in Qt 4.8 and 'application/x-www-form-urlencoded' in Qt 4.7.3. This is Qt-defined behaviour in QNetworkAccessManager (see QHttpNetworkRequestPrivate::header in qhttpnetworkrequest.cpp) - DELETE and HEAD requests get their ContentType and ContentLength headers (if present) removed by QNetworkReplyHandler. QtWebKit does not send data for either of these request types. * platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Added. * platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added. * platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Added. * platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added. * platform/qt/Skipped: Unskip: http/tests/xmlhttprequest/methods.html http/tests/xmlhttprequest/methods-lower-case.html http/tests/xmlhttprequest/workers/methods-async.html http/tests/xmlhttprequest/workers/methods.html http/tests/xmlhttprequest/workers/shared-worker-methods-async.html * platform/qt/http/tests/xmlhttprequest/methods-expected.txt: Added. * platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added. * platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt: Added. * platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added. 2011-06-12 Robert Hogan <robert@webkit.org> Reviewed by Andreas Kling. [Qt] Fix methods.html and methods-lower-case.html https://bugs.webkit.org/show_bug.cgi?id=62221 * platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::clearContentsHeaders): Refactor code from sendNetworkRequest (WebCore::QNetworkReplyHandler::getIODevice): ditto (WebCore::QNetworkReplyHandler::sendNetworkRequest): - Remove ContentType and ContentLength headers from GET, DELETE and HEAD requests since we do not send data with any of these requests. - If a custom HTTP operation contains data, send it. * platform/network/qt/QNetworkReplyHandler.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
msaboff@apple.com authored
Reviewed by James Robinson. REGRESSION(88260): 10-50% performance regression across many page cyclers https://bugs.webkit.org/show_bug.cgi?id=62349 Made CHROMIUM platform specific values for cMaxInactiveFontData and cTargetInactiveFontData to mitigate the current performance issue on Chromium page cycler tests. Made the chromium value for cMaxInactiveFontData 250 based on recommendation from James Robinson. Changed cTargetInactiveFontData to 200 so that 50 inactive fonts will be cleaned up at a time. Change made to address existing Chromium performance test regression. * platform/graphics/FontCache.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 11 Jun, 2011 13 commits
-
-
abarth@webkit.org authored
Reviewed by Darin Adler. Remove unnecessary strlen from DocumentWriter https://bugs.webkit.org/show_bug.cgi?id=62505 This ugly piece of code appears not to be needed. Rejoice. * WebCore.exp.in: * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData): * loader/DocumentLoader.h: * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData): * loader/DocumentWriter.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Darin Adler. DocumentParser::appendBytes shouldn't have a "flush" boolean parameter https://bugs.webkit.org/show_bug.cgi?id=62499 This patch removes the "flush" Boolean parameter from DocumentParser::appendBytes in favor of a new flush method. This makes some code in DocumentWriter look less ridiculous. There's still lots of on contorting to do here, but it's a start. * dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes): (WebCore::DecodedDataDocumentParser::flush): * dom/DecodedDataDocumentParser.h: * dom/DocumentParser.h: * dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::flush): * html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes): * html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes): * html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes): * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::reportDataReceived): (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource): * loader/DocumentWriter.h: * loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Chromium rebaseline after r85560. Also update test expectation for svg/W3C-SVG-1.1/text-intro-05-t.svg because it has been passing on Mac. * platform/chromium-linux/fast/forms/input-placeholder-text-indent-expected.png: Added. * platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.png: Added. * platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
slewis@apple.com authored
part of <rdar://problem/8675177> Add API to launch the WebProcess. Launching it earlier can save time when loading the first page. Reviewed by Sam Weinig. * UIProcess/API/C/WKContext.cpp: (WKContextWarmInitialProcess): * UIProcess/API/C/WKContextPrivate.h: * UIProcess/WebContext.cpp: (WebKit::WebContext::warmInitialProcess): * UIProcess/WebContext.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dglazkov@chromium.org authored
Unreviewed, rolling out r88569. http://trac.webkit.org/changeset/88569 https://bugs.webkit.org/show_bug.cgi?id=62398 Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest * storage/indexeddb/database-name-undefined-expected.txt: Removed. * storage/indexeddb/database-name-undefined.html: Removed. 2011-06-11 Dimitri Glazkov <dglazkov@chromium.org> Unreviewed, rolling out r88569. http://trac.webkit.org/changeset/88569 https://bugs.webkit.org/show_bug.cgi?id=62398 Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest * storage/IDBFactory.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by Darin Adler. Remove #define NaN per Darin's comments. * runtime/JSGlobalObjectFunctions.cpp: (JSC::parseIntOverflow): (JSC::parseInt): (JSC::jsStrDecimalLiteral): (JSC::jsToNumber): (JSC::parseFloat): * wtf/DateMath.cpp: (WTF::equivalentYearForDST): (WTF::parseES5DateFromNullTerminatedCharacters): (WTF::parseDateFromNullTerminatedCharacters): (WTF::timeClip): (JSC::parseDateFromNullTerminatedCharacters): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Remove JIT_OPTIMIZE_* switches Rubber stamped by Geoff Garen. The alternative code paths are untested, and not well maintained. These were useful when there was more churn in the JIT, but now are a maintenance overhead. Time to move on, removing. * bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate): * jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::linkConstruct): * jit/JIT.h: * jit/JITCall.cpp: * jit/JITCall32_64.cpp: * jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall): * jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::softModulo): * jit/JITPropertyAccess.cpp: * jit/JITPropertyAccess32_64.cpp: * jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): * runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot): * runtime/Lookup.h: * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dglazkov@chromium.org authored
Remove expectation of failure after clobber. https://bugs.webkit.org/show_bug.cgi?id=62364 * platform/chromium/test_expectations.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dglazkov@chromium.org authored
Unreviewed, rolling out r88565. http://trac.webkit.org/changeset/88565 https://bugs.webkit.org/show_bug.cgi?id=62401 Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest * storage/indexeddb/setVersion-undefined-expected.txt: Removed. * storage/indexeddb/setVersion-undefined.html: Removed. 2011-06-11 Dimitri Glazkov <dglazkov@chromium.org> Unreviewed, rolling out r88565. http://trac.webkit.org/changeset/88565 https://bugs.webkit.org/show_bug.cgi?id=62401 Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest * storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): * storage/IDBDatabase.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
inferno@chromium.org authored
Reviewed by Simon Fraser. Null parent element sheet pointers in CSSMutableStyleDeclaration consumers when removed from document, set them when reinserted into document. https://bugs.webkit.org/show_bug.cgi?id=62230 When a HTMLBodyElement, StyledElement are removed from document, we didn't clear out the parent pointers from their link, style declarations. These parent pointers pointed to the document's element sheet which will get removed when document is getting destroyed. It does make sense to clear out parent pointers when we are getting removed from document and readd them when we get inserted again. Tests: fast/dom/body-link-decl-parent-crash.html fast/dom/styled-inline-style-decl-parent-crash.html * dom/StyledElement.cpp: (WebCore::StyledElement::insertedIntoDocument): (WebCore::StyledElement::removedFromDocument): * dom/StyledElement.h: * html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): (WebCore::HTMLBodyElement::insertedIntoDocument): (WebCore::HTMLBodyElement::removedFromDocument): (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument): * html/HTMLBodyElement.h: 2011-06-10 Abhishek Arya <inferno@chromium.org> Reviewed by Simon Fraser. Tests that accessing the parent element sheet of an inline style, link declaration of styled, body elements which are removed from document, does not result in crash. https://bugs.webkit.org/show_bug.cgi?id=62230 * fast/dom/body-link-decl-parent-crash-expected.txt: Added. * fast/dom/body-link-decl-parent-crash.html: Added. * fast/dom/styled-inline-style-decl-parent-crash-expected.txt: Added. * fast/dom/styled-inline-style-decl-parent-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Remove bogus ASSERTs. These ASSERTs used to be correct before I changed DocumentWriter to put the onus for ignoring empty writes onto the parser. This patch should stop these test from triggering ASSERTs: plugins/plugin-document-back-forward.html plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html userscripts/user-script-plugin-document.html * html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes): * html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jer.noble@apple.com authored
Reviewed by Darin Adler. AVPlayerLayer is adding a "fade" animation during Safari full-screen https://bugs.webkit.org/show_bug.cgi?id=62433 CoreAnimation will add default animations when certain properties are changed, unless those changes are wrapped in a CATransaction which has had its disableActions property set to true. Wrap each of these three property changes in a CATransaction and disable its actions, so that the default "fade" animation is not created in response. * UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController enterFullScreen:]): Wrap with CATransaction. (-[WKFullScreenWindowController _swapView:with:]): Ditto: * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Reviewed by Ojan Vafai. new-run-webkit-tests: 'images' links on results.html don't work https://bugs.webkit.org/show_bug.cgi?id=62194 Use relative path when generating images-diffs.html * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added _output_testname. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 10 Jun, 2011 7 commits
-
-
rniwa@webkit.org authored
Skip inspector/profiler/cpu-profiler-profiling-without-inspector.html and svg/custom/focus-event-handling-keyboard.html on Mac WebKit2 because they use DRT features not supported by WebKitTestRunner. * platform/mac-wk2/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
GTK and Qt rebaselines after r88555. * platform/gtk/svg/custom/focus-ring-expected.txt: * platform/qt/svg/custom/focus-ring-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
[chromium] Update chromium gpu baselines * platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Removed. * platform/chromium-gpu-linux/compositing/geometry/clip-expected.txt: Removed. * platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.png: Removed. * platform/chromium-gpu-linux/compositing/geometry/repaint-foreground-layer-expected.png: Removed. * platform/chromium-gpu-linux/compositing/iframes/iframe-content-flipping-expected.png: Removed. * platform/chromium-gpu-linux/compositing/overflow/zero-size-overflow-expected.png: Removed. * platform/chromium-gpu-linux/compositing/reflections/backface-hidden-reflection-expected.png: Removed. * platform/chromium-gpu-linux/compositing/repaint/content-into-overflow-expected.png: Removed. * platform/chromium-gpu-linux/compositing/repaint/overflow-into-content-expected.png: Removed. * platform/chromium-gpu-win/compositing/geometry/clip-expected.txt: Removed. * platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png: * platform/chromium-gpu-win/compositing/geometry/foreground-layer-expected.txt: Added. * platform/chromium-gpu-win/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added. * platform/chromium-gpu-win/compositing/overflow/clip-descendents-expected.txt: * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png: * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png: * platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.png: * platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.png: * platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png: * platform/chromium-gpu-win/compositing/tiling/huge-layer-add-remove-child-expected.txt: * platform/chromium-gpu-win/compositing/tiling/huge-layer-expected.txt: * platform/chromium-gpu-win/compositing/tiling/huge-layer-resize-expected.txt: * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Windows and Chromium rebaselines after r88592. Apparently, some tests are failing on Windows. * platform/chromium/fast/harness/results-expected.txt: * platform/win/fast/harness/results-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Add fail expectation to fast/dom/navigator-detached-no-crash.htm on Chromium Mac because it has been failing on the bot; the failure is tracked by the bug 62364. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Reviewed by Ojan Vafai. new-run-webkit-tests: results.html don't list the same list of failed tests as bots do https://bugs.webkit.org/show_bug.cgi?id=62425 Fixed the bug by hiding expected crash, timeout, pass, etc... by default. * fast/harness/resources/results-test.js: * fast/harness/results-expected.txt: * fast/harness/results.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jer.noble@apple.com authored
Reviewed by Darin Adler. REGRESSION: End of apple.com video in full-screen mode leads to unusable page. https://bugs.webkit.org/show_bug.cgi?id=62411 * fullscreen/full-screen-remove-ancestor-after-expected.txt: Added. * fullscreen/full-screen-remove-ancestor-after.html: Added. * platform/mac/fullscreen/full-screen-remove-ancestor-after-expected.png: Added. 2011-06-09 Jer Noble <jer.noble@apple.com> Reviewed by Darin Adler. REGRESSION: End of apple.com video in full-screen mode leads to unusable page. https://bugs.webkit.org/show_bug.cgi?id=62411 Test: fullscreen/full-screen-remove-ancestor-after.html The placeholder for RenderFullScreen was being created as a non-anonymous object, which led to the document's renderer being set to 0 when the placeholder was removed due to its parent being removed. Setting the placeholder to be anonymous, however, means that it will be coalesced with sibling anonymous blocks, so added the RenderFullScreenPlaceholder to the list of anonymous objects that are not considered anonymous blocks, to avoid the placeholder being so coalesced. To do so, made the placeholder object a true subclass, and add and override its destroy() function to notify the RenderFullScreen object that it has been destroyed. * rendering/RenderFullScreen.cpp: (RenderFullScreenPlaceholder::RenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::~RenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::isRenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::destroy): Notify the owner renderer that its placeholder has been destroyed. (RenderFullScreen::destroy): Assert that the m_placeholder ivar is 0 after destroying it. (RenderFullScreen::setPlaceholder): Added. (RenderFullScreen::createPlaceholder): Do not make the placeholder anonymous. * rendering/RenderFullScreen.h: * rendering/RenderObject.h: (WebCore::RenderObject::isRenderFullScreenPlaceholder): Added. (WebCore::RenderObject::isAnonymousBlock): Added the placeholder class to the list of objects which are not anonymous blocks. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-