1. 20 Feb, 2008 10 commits
    • weinig@apple.com's avatar
      WebCore: · 04346b10
      weinig@apple.com authored
              Reviewed by Darin and Geoff.
      
              - <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
      
              * WebCore.base.exp: Updated.
      
              * bindings/js/kjs_navigator.cpp:
              (WebCore::needsYouTubeQuirk): Added. Return true on Windows only when the quirk is needed.
              (WebCore::Navigator::getValueProperty): For the appVersion property, if needsYouTubeQuirk
              return true, then return the empty string.
      
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Set m_needsSiteSpecificQuirks to false.
              (WebCore::Settings::setNeedsSiteSpecificQuirks): Added.
              * page/Settings.h: Added m_needsSiteSpecificQuirks.
              (WebCore::Settings::needsSiteSpecificQuirks): Added.
      
      WebKit/mac:
      
              Reviewed by Darin and Geoff.
      
              - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
      
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks.
              There are currently no site-specific quirks on Mac, but we will propagate the state
              to WebCore to avoid possible mistakes later.
      
      WebKit/win:
      
              Reviewed by Darin and Geoff.
      
              - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
      
              * WebView.cpp:
              (WebView::notifyPreferencesChanged): Added a call to Settings::setNeedsSiteSpecificQuirks.
              (WebView::setAllowSiteSpecificHacks): Added a comment about the problem Darin noticed, where
              after you disable the site-specific hacks they persist until you open a new window or tweak
              some other preference.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04346b10
    • hyatt@apple.com's avatar
      Land additional doctype piece. toString fix of doctype. · 93d0c99d
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93d0c99d
    • hyatt@apple.com's avatar
      Fix for bug 12751, doctype nodes aren't part of the Document (Acid3). · 4258307c
      hyatt@apple.com authored
              Reviewed by Sam Weinig
      
              Many tests added in fast/doctypes.
      
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::createDocument):
              (WebCore::DOMImplementation::createHTMLDocument):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::setDocType):
              (WebCore::Document::attach):
              (WebCore::Document::getImageMap):
              * dom/Document.h:
              (WebCore::Document::doctype):
              (WebCore::Document::):
              (WebCore::Document::determineParseMode):
              (WebCore::Document::setParseMode):
              (WebCore::Document::parseMode):
              (WebCore::Document::inCompatMode):
              (WebCore::Document::inAlmostStrictMode):
              (WebCore::Document::inStrictMode):
              * dom/DocumentType.cpp:
              (WebCore::DocumentType::cloneNode):
              (WebCore::DocumentType::insertedIntoDocument):
              (WebCore::DocumentType::removedFromDocument):
              * dom/DocumentType.h:
              * dom/Node.cpp:
              (WebCore::Node::childAllowed):
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::attributeChanged):
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::internalSubset):
              (WebCore::):
              * editing/markup.cpp:
              (WebCore::appendStartMarkup):
              * html/HTMLAppletElement.cpp:
              (WebCore::HTMLAppletElement::createRenderer):
              * html/HTMLDocument.cpp:
              (WebCore::HTMLDocument::HTMLDocument):
              (WebCore::HTMLDocument::childAllowed):
              (WebCore::HTMLDocument::determineParseMode):
              * html/HTMLDocument.h:
              * html/HTMLMapElement.cpp:
              (WebCore::HTMLMapElement::parseMappedAttribute):
              * html/HTMLParamElement.cpp:
              (WebCore::HTMLParamElement::parseMappedAttribute):
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::parseDoctypeToken):
              * html/HTMLParser.h:
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::reset):
              (WebCore::HTMLTokenizer::parseDoctype):
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::write):
              (WebCore::HTMLTokenizer::finish):
              (WebCore::HTMLTokenizer::processDoctypeToken):
              * html/HTMLTokenizer.h:
              (WebCore::):
              (WebCore::DoctypeToken::DoctypeToken):
              (WebCore::DoctypeToken::reset):
              (WebCore::DoctypeToken::state):
              (WebCore::DoctypeToken::setState):
              (WebCore::HTMLTokenizer::State::inDoctype):
              (WebCore::HTMLTokenizer::State::setInDoctype):
              (WebCore::HTMLTokenizer::State::needsSpecialWriteHandling):
              (WebCore::HTMLTokenizer::State::):
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::addViewSourceToken):
              (WebCore::HTMLViewSourceDocument::addViewSourceDoctypeToken):
              * html/HTMLViewSourceDocument.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::write):
              (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
              * page/Frame.cpp:
              (WebCore::Frame::documentTypeString):
              * page/inspector/utilities.js:
              * xml/XSLTProcessor.cpp:
              (WebCore::XSLTProcessor::createDocumentFromSource):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4258307c
    • andersca@apple.com's avatar
      Reviewed by Darin. · d2a7e8d1
      andersca@apple.com authored
              Change most SVG related classes to start out with a ref count of 1.
              
              * bindings/js/JSSVGPointListCustom.cpp:
              (WebCore::JSSVGPointList::initialize):
              (WebCore::JSSVGPointList::insertItemBefore):
              (WebCore::JSSVGPointList::replaceItem):
              (WebCore::JSSVGPointList::appendItem):
              * bindings/js/JSSVGTransformListCustom.cpp:
              (WebCore::JSSVGTransformList::initialize):
              (WebCore::JSSVGTransformList::insertItemBefore):
              (WebCore::JSSVGTransformList::replaceItem):
              (WebCore::JSSVGTransformList::appendItem):
              * rendering/SVGCharacterLayoutInfo.h:
              (WebCore::SVGCharOnPath::create):
              (WebCore::SVGCharOnPath::SVGCharOnPath):
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
              * svg/SVGAnimationElement.cpp:
              (WebCore::SVGAnimationElement::parseBeginOrEndValue):
              * svg/SVGClipPathElement.cpp:
              (WebCore::SVGClipPathElement::canvasResource):
              * svg/SVGElementInstance.cpp:
              (WebCore::SVGElementInstance::childNodes):
              * svg/SVGElementInstanceList.cpp:
              (WebCore::SVGElementInstanceList::SVGElementInstanceList):
              * svg/SVGElementInstanceList.h:
              (WebCore::SVGElementInstanceList::create):
              * svg/SVGFitToViewBox.cpp:
              (WebCore::SVGFitToViewBox::SVGFitToViewBox):
              * svg/SVGGradientElement.cpp:
              (WebCore::SVGGradientElement::SVGGradientElement):
              (WebCore::SVGGradientElement::canvasResource):
              * svg/SVGImageElement.cpp:
              (WebCore::SVGImageElement::SVGImageElement):
              * svg/SVGLengthList.h:
              (WebCore::SVGLengthList::create):
              * svg/SVGList.h:
              (WebCore::SVGList::SVGList):
              (WebCore::SVGPODListItem::create):
              (WebCore::SVGPODListItem::copy):
              (WebCore::SVGPODListItem::SVGPODListItem):
              (WebCore::SVGPODList::initialize):
              (WebCore::SVGPODList::insertItemBefore):
              (WebCore::SVGPODList::replaceItem):
              (WebCore::SVGPODList::appendItem):
              (WebCore::SVGPODList::SVGPODList):
              * svg/SVGMarkerElement.cpp:
              (WebCore::SVGMarkerElement::canvasResource):
              * svg/SVGMaskElement.cpp:
              (WebCore::SVGMaskElement::canvasResource):
              * svg/SVGNumberList.h:
              (WebCore::SVGNumberList::create):
              * svg/SVGPathElement.cpp:
              (WebCore::SVGPathElement::createSVGPathSegClosePath):
              (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
              (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
              (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
              (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
              (WebCore::SVGPathElement::createSVGPathSegArcAbs):
              (WebCore::SVGPathElement::createSVGPathSegArcRel):
              (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
              (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
              (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
              (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
              (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
              (WebCore::SVGPathElement::pathSegList):
              * svg/SVGPathElement.h:
              * svg/SVGPathSeg.h:
              (WebCore::SVGPathSeg::SVGPathSeg):
              * svg/SVGPathSegArc.h:
              (WebCore::SVGPathSegArcAbs::create):
              (WebCore::SVGPathSegArcRel::create):
              * svg/SVGPathSegClosePath.h:
              (WebCore::SVGPathSegClosePath::create):
              * svg/SVGPathSegCurvetoCubic.h:
              (WebCore::SVGPathSegCurvetoCubicAbs::create):
              (WebCore::SVGPathSegCurvetoCubicRel::create):
              * svg/SVGPathSegCurvetoCubicSmooth.h:
              (WebCore::SVGPathSegCurvetoCubicSmoothAbs::create):
              (WebCore::SVGPathSegCurvetoCubicSmoothRel::create):
              * svg/SVGPathSegCurvetoQuadratic.h:
              (WebCore::SVGPathSegCurvetoQuadraticAbs::create):
              (WebCore::SVGPathSegCurvetoQuadraticRel::create):
              * svg/SVGPathSegCurvetoQuadraticSmooth.h:
              (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create):
              (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create):
              * svg/SVGPathSegLineto.h:
              (WebCore::SVGPathSegLinetoAbs::create):
              (WebCore::SVGPathSegLinetoRel::create):
              * svg/SVGPathSegLinetoHorizontal.h:
              (WebCore::SVGPathSegLinetoHorizontalAbs::create):
              (WebCore::SVGPathSegLinetoHorizontalRel::create):
              * svg/SVGPathSegLinetoVertical.h:
              (WebCore::SVGPathSegLinetoVerticalAbs::create):
              (WebCore::SVGPathSegLinetoVerticalRel::create):
              * svg/SVGPathSegList.h:
              (WebCore::SVGPathSegList::create):
              * svg/SVGPathSegMoveto.h:
              (WebCore::SVGPathSegMovetoAbs::create):
              (WebCore::SVGPathSegMovetoRel::create):
              * svg/SVGPatternElement.cpp:
              (WebCore::SVGPatternElement::SVGPatternElement):
              (WebCore::SVGPatternElement::canvasResource):
              * svg/SVGPointList.h:
              (WebCore::SVGPointList::create):
              * svg/SVGPolyElement.cpp:
              (WebCore::SVGPolyElement::points):
              * svg/SVGPreserveAspectRatio.cpp:
              (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
              * svg/SVGPreserveAspectRatio.h:
              (WebCore::SVGPreserveAspectRatio::create):
              * svg/SVGRenderingIntent.h:
              (WebCore::SVGRenderingIntent::SVGRenderingIntent):
              * svg/SVGStringList.h:
              (WebCore::SVGStringList::create):
              * svg/SVGStyledTransformableElement.cpp:
              (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
              * svg/SVGTests.cpp:
              (WebCore::SVGTests::requiredFeatures):
              (WebCore::SVGTests::requiredExtensions):
              (WebCore::SVGTests::systemLanguage):
              * svg/SVGTextElement.cpp:
              (WebCore::SVGTextElement::SVGTextElement):
              * svg/SVGTextPositioningElement.cpp:
              (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
              * svg/SVGTransformList.h:
              (WebCore::SVGTransformList::create):
              * svg/SVGUnitTypes.h:
              (WebCore::SVGUnitTypes::SVGUnitTypes):
              * svg/SVGViewElement.cpp:
              (WebCore::SVGViewElement::viewTarget):
              * svg/SVGViewSpec.cpp:
              (WebCore::SVGViewSpec::SVGViewSpec):
              * svg/graphics/SVGPaintServer.cpp:
              (WebCore::SVGPaintServer::sharedSolidPaintServer):
              * svg/graphics/SVGPaintServer.h:
              * svg/graphics/SVGPaintServerGradient.h:
              (WebCore::SVGPaintServerGradient::SharedStopCache::create):
              (WebCore::SVGPaintServerGradient::SharedStopCache::SharedStopCache):
              * svg/graphics/SVGPaintServerLinearGradient.h:
              (WebCore::SVGPaintServerLinearGradient::create):
              * svg/graphics/SVGPaintServerPattern.h:
              (WebCore::SVGPaintServerPattern::create):
              * svg/graphics/SVGPaintServerRadialGradient.h:
              (WebCore::SVGPaintServerRadialGradient::create):
              * svg/graphics/SVGPaintServerSolid.h:
              (WebCore::SVGPaintServerSolid::create):
              * svg/graphics/SVGResource.cpp:
              (WebCore::SVGResource::SVGResource):
              * svg/graphics/SVGResource.h:
              * svg/graphics/SVGResourceClipper.h:
              (WebCore::SVGResourceClipper::create):
              * svg/graphics/SVGResourceMarker.h:
              (WebCore::SVGResourceMarker::create):
              * svg/graphics/SVGResourceMasker.h:
              (WebCore::SVGResourceMasker::create):
              * svg/graphics/cg/SVGPaintServerGradientCg.cpp:
              (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2a7e8d1
    • darin@apple.com's avatar
      Reviewed by Sam. · 7904b730
      darin@apple.com authored
              - make conversion from CSS ParseString to String and AtomicString
                automatic and remove all the explicit calls to do the conversion
      
              - fix CSS parsing to do fewer allocations, mostly by using the
                equalIgnoringCase function in CSSParser
      
              * css/CSSGrammar.y: Take out all the explicit atomicString and
              domString calls now that ParseString knows how to convert itself.
      
              * css/CSSParser.cpp:
              (WebCore::equal): Added.
              (WebCore::equalIgnoringCase): Allow non-lettters.
              (WebCore::ParseString::lower): Used charactersAreAllASCII.
              (WebCore::unitFromString): Use equal.
              (WebCore::CSSParser::parseValue): Removed unneeded call to domString.
              (WebCore::CSSParser::parseContent): Use equalIgnoringCase.
              (WebCore::CSSParser::parseBackgroundImage): Removed unneeded call to domString.
              (WebCore::CSSParser::parseTransitionTimingFunction): Use equalIgnoringCase.
              (WebCore::CSSParser::parseDashboardRegions): More of the same.
              (WebCore::CSSParser::parseCounterContent): Ditto.
              (WebCore::CSSParser::parseShape): Use equalIgnoringCase.
              (WebCore::CSSParser::parseFontFamily): Removed unneeded calls to domString.
              (WebCore::CSSParser::parseFontFaceSrc): More.
              (WebCore::CSSParser::parseFontFaceUnicodeRange): More.
              (WebCore::CSSParser::parseColor): Don't lowercase here -- setNamedColor now
              handles the case folding.
              (WebCore::CSSParser::parseColorFromValue): More.
              (WebCore::CSSParser::parseBorderImage): More.
              (WebCore::CSSParser::parseCounter): More.
              (WebCore::TransformOperationInfo::TransformOperationInfo): More.
              (WebCore::CSSParser::parseTransform): More.
              (WebCore::CSSParser::createCharsetRule): More.
              (WebCore::CSSParser::createImportRule): More.
      
              * css/CSSParser.h: Removed domString and atomicString functions.
              (WebCore::ParseString::operator String): Added. Allows conversion to String
              without an explicit function call.
              (WebCore::ParseString::operator AtomicString): Ditto.
      
              * css/MediaQueryExp.cpp:
              (WebCore::MediaQueryExp::MediaQueryExp): Removed a call to domString.
              * css/SVGCSSParser.cpp:
              (WebCore::CSSParser::parseSVGValue): Removed calls to domString.
      
              * platform/graphics/Color.cpp:
              (WebCore::findNamedColor): Call toASCIILower on each character as we copy
              it into the 8-bit character buffer to make the operation fold case.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7904b730
    • hyatt@apple.com's avatar
      Fix a bug in this SVG test harness. Make sure it uses... · b67493ca
      hyatt@apple.com authored
      Fix a bug in this SVG test harness.  Make sure it uses document.documentElement instead of document.firstChild.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b67493ca
    • justin.garcia@apple.com's avatar
      Reviewed by Darin Adler. · 64125517
      justin.garcia@apple.com authored
              <rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore changes
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd): The common case here
              is where there are no special elements.  Avoid creating VisiblePositions in
              that case.  Additionally, this change postpones the more expensive creation
              of an upstream VisiblePosition until the last possible moment.
              (WebCore::DeleteSelectionCommand::saveTypingStyleState):
              (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Add an 
              early return for a common case: deleting characters that are all inside the 
              same text node. In that case the style at the start of the selection will 
              not change during the delete, so there is no need to save/recompute it.
              (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Early return
              before VisiblePosition creation if the ends of the selection aren't enclosed
              by an anchor.
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::markMisspellingsAfterTyping): Early return if spell
              checking isn't enabled.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64125517
    • ap@webkit.org's avatar
      Incorporates some improvements made by Dan Bernstein. · a2fef130
      ap@webkit.org authored
              Reviewed by Darin.
      
              http://bugs.webkit.org/show_bug.cgi?id=17106
              <rdar://problem/5750722> Debug build ASSERTs on page load
      
              Test: fast/encoding/GBK/close-gbk-converter.html
      
              * platform/text/TextCodecICU.cpp:
              (WebCore::getGbkEscape): Changed to use a switch instead of a HashMap, as there
              are only four values.
              (WebCore::gbkCallbackEscape): Check the reason why the function is called, and do not attempt
              getting an escape character if it's not UCNV_UNASSIGNED.
              (WebCore::gbkCallbackSubstitute): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2fef130
    • ap@webkit.org's avatar
      Build fix. · ac0d86f0
      ap@webkit.org authored
              * xml/XMLHttpRequest.cpp:
              (WebCore::isSafeRequestHeader):
              (WebCore::XMLHttpRequest::setRequestHeader):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac0d86f0
    • ap@webkit.org's avatar
      Reviewed by Darin. · 2e1f7240
      ap@webkit.org authored
              <rdar://problem/5749455> Unable to set the Referer header in Dashboard using XMLHttpRequest
      
              Cannot be tested in DRT.
      
              * xml/XMLHttpRequest.cpp: (WebCore::canSetRequestHeader): Assume that a request that can load
              local files can also set any headers.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e1f7240
  2. 19 Feb, 2008 21 commits
    • darin@apple.com's avatar
      Reviewed by Sam. · 7f932cb6
      darin@apple.com authored
              - removed use of DeprecatedString for font family names
      
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::addFontFaceRule): Update for name change.
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseFontFamily): Update to use new appendSpaceSeparated
              function and String rather than DeprecatedString.
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty): Updated for name change.
              * css/FontFamilyValue.cpp:
              (WebCore::FontFamilyValue::FontFamilyValue): Replaced code using a regular
              expression with code that does the same thing more efficiently.
              (WebCore::FontFamilyValue::appendSpaceSeparated): Added.
              (WebCore::FontFamilyValue::cssText): Updated for name change.
              * css/FontFamilyValue.h: Changed DeprecatedString to String. Renamed fontName
              to familyName and parsedFontName to m_familyName. Removed unused genericFamilyType
              and m_genericFamilyType. Added appendSpaceSeparated so that m_familyName can
              be private instead of public.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f932cb6
    • darin@apple.com's avatar
      - fix build when SVG is not enabled · e71596c3
      darin@apple.com authored
              * rendering/RenderTreeAsText.cpp: Added include of "TextStream.h".
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e71596c3
    • andersca@apple.com's avatar
      Reviewed by Darin. · c442c15a
      andersca@apple.com authored
              Change all classes in xml/ to start out with a ref count of 1.
              
              * bindings/js/JSCustomXPathNSResolver.h:
              * bindings/js/JSXMLHttpRequest.cpp:
              (WebCore::JSXMLHttpRequest::JSXMLHttpRequest):
              * bindings/js/JSXSLTProcessor.cpp:
              (WebCore::JSXSLTProcessor::JSXSLTProcessor):
              * bindings/objc/DOMCustomXPathNSResolver.h:
              (WebCore::DOMCustomXPathNSResolver::create):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorObjC.pm:
              * dom/Document.cpp:
              (WebCore::Document::applyXSLTransform):
              (WebCore::Document::createExpression):
              (WebCore::Document::createNSResolver):
              (WebCore::Document::evaluate):
              * xml/DOMParser.h:
              (WebCore::DOMParser::create):
              (WebCore::DOMParser::DOMParser):
              * xml/NativeXPathNSResolver.h:
              (WebCore::NativeXPathNSResolver::create):
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::XMLHttpRequest):
              * xml/XMLHttpRequest.h:
              (WebCore::XMLHttpRequest::create):
              * xml/XMLSerializer.h:
              (WebCore::XMLSerializer::create):
              (WebCore::XMLSerializer::XMLSerializer):
              * xml/XPathEvaluator.cpp:
              (WebCore::XPathEvaluator::createNSResolver):
              * xml/XPathEvaluator.h:
              (WebCore::XPathEvaluator::create):
              (WebCore::XPathEvaluator::XPathEvaluator):
              * xml/XPathExpression.cpp:
              (WebCore::XPathExpression::createExpression):
              (WebCore::XPathExpression::evaluate):
              * xml/XPathExpression.h:
              (WebCore::XPathExpression::create):
              (WebCore::XPathExpression::XPathExpression):
              * xml/XPathNSResolver.h:
              * xml/XPathResult.cpp:
              (WebCore::XPathResult::XPathResult):
              * xml/XPathResult.h:
              (WebCore::XPathResult::create):
              * xml/XPathValue.cpp:
              (WebCore::XPath::Value::modifiableNodeSet):
              * xml/XPathValue.h:
              (WebCore::XPath::ValueData::create):
              (WebCore::XPath::ValueData::ValueData):
              (WebCore::XPath::Value::Value):
              * xml/XSLTProcessor.h:
              (WebCore::XSLTProcessor::create):
              (WebCore::XSLTProcessor::XSLTProcessor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c442c15a
    • darin@apple.com's avatar
      WebCore: · 8c8f0842
      darin@apple.com authored
              Reviewed by Sam.
      
              - Trimmed down TextStream and weaned it from DeprecatedString.
      
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge renderTreeAsExternalRepresentation]):
              Removed now-unneeded call to getNSString.
      
              * platform/text/TextStream.cpp: Removed unused functions.
              Use snprintf instead of sprintf, for better security.
              (WebCore::TextStream::release): Added.
              * platform/text/TextStream.h: Removed lots of unneeded stuff.
      
              * rendering/RenderTreeAsText.cpp:
              (WebCore::externalRepresentation): Changed to use String instead
              of DeprecatedString.
              * rendering/RenderTreeAsText.h: Ditto.
      
              * rendering/SVGRenderTreeAsText.cpp:
              (WebCore::writeSVGInlineTextBox): Use "\n" instead of endl.
              (WebCore::write): Ditto.
              (WebCore::writeRenderResources): Ditto.
      
      WebKit/win:
      
              Reviewed by Sam.
      
              * WebFrame.cpp:
              (WebFrame::renderTreeAsExternalRepresentation): Changed to use String instead
              of DeprecatedString.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c8f0842
    • justin.garcia@apple.com's avatar
      Reviewed by Darin Adler. · ca5feada
      justin.garcia@apple.com authored
              <rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore changes
              
              This brings performance on the phone back to old levels.  Andre and I are doing
              some formal testing to see exactly where we stand.
      
              * dom/Position.cpp:
              (WebCore::enclosingBlockIgnoringEditability): Added.  This is enclosingBlock
              without the expensive editability checks. upstream and downstream can avoid 
              those because they do their own editability checking.
              (WebCore::Position::upstream):
              (WebCore::Position::downstream):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca5feada
    • harrison@apple.com's avatar
      Reviewed by Darin. · 4965b45f
      harrison@apple.com authored
              <rdar://problem/3663560> AXLink for a "name" (anchor) on same page should include an AXLinkedUIElementAttribute
      
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject linkedUIElement]):
              Returns the linked-to AX object (if the specified one is ignored by accessibility, returns the next un-ignored one by traversing the DOM).
              
              (-[WebCoreAXObject accessibilityAttributeNames]):
              (-[WebCoreAXObject accessibilityAttributeValue:]):
              Support NSAccessibilityLinkedUIElementsAttribute.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4965b45f
    • darin@apple.com's avatar
      Reviewed by Sam. · d694331c
      darin@apple.com authored
              - Removed old debugging aids, Node::dump, RenderObject::dump, and
                RenderObject::information, that used DeprecatedString.
      
              * dom/CharacterData.cpp: Removed override of Node::dump.
              * dom/CharacterData.h: Ditto.
              * dom/Element.cpp: Ditto.
              * dom/Element.h: Ditto.
              * dom/EventTargetNode.cpp: Ditto.
              * dom/EventTargetNode.h: Ditto.
              * dom/Node.cpp: Removed Node::dump.
              * dom/Node.h: Ditto.
      
              * rendering/RenderBlock.cpp: Removed override of RenderObject::dump.
              * rendering/RenderBlock.h: Ditto.
              * rendering/RenderFrameSet.cpp: Ditto.
              * rendering/RenderFrameSet.h: Ditto.
              * rendering/RenderObject.cpp: Removed RenderObject::dump and
              RenderObject::information.
              * rendering/RenderObject.h: Ditto.
              * rendering/RenderTable.cpp: Removed override of RenderObject::dump.
              * rendering/RenderTable.h: Ditto.
              * rendering/RenderTableCell.cpp: Ditto.
              * rendering/RenderTableCell.h: Ditto.
              * rendering/RenderTableCol.cpp: Ditto.
              * rendering/RenderTableCol.h: Ditto.
              * rendering/RenderTableSection.cpp: Ditto.
              * rendering/RenderTableSection.h: Ditto.
      
              * rendering/RenderTreeAsText.h: Removed unneeded include of TextStream.h
              and added forward declarations as appropriate.
      
              * svg/SVGSVGElement.cpp: Removed unneeded include of TextStream.h.
              * svg/graphics/SVGResourceClipper.cpp: And here.
              * svg/graphics/SVGResourceFilter.cpp: Ditto.
              * svg/graphics/filters/SVGFEBlend.cpp: Ditto.
              * svg/graphics/filters/SVGFEComponentTransfer.cpp: Ditto.
              * svg/graphics/filters/SVGFEComposite.cpp: Ditto.
              * svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto.
              * svg/graphics/filters/SVGFEGaussianBlur.cpp: Ditto.
              * svg/graphics/filters/SVGFEImage.cpp: Ditto.
              * svg/graphics/filters/SVGFEMerge.cpp: Ditto.
              * svg/graphics/filters/SVGFEMorphology.cpp: Ditto.
              * svg/graphics/filters/SVGFEOffset.cpp: Ditto.
              * svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto.
              * svg/graphics/filters/SVGFETurbulence.cpp: Ditto.
              * svg/graphics/filters/SVGFilterEffect.cpp: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d694331c
    • bdakin@apple.com's avatar
      WebCore: · ff39ce21
      bdakin@apple.com authored
              Reviewed by Sam.
      
              Fix for <rdar://problem/5729674> Seed: Crash in 
              RenderButton::setStyle at http://www.dinorpg.com
      
              Inputs should not honor first-letter.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::updateFirstLetter):
      
      LayoutTests:
      
              Reviewed by Sam.
      
              Test for <rdar://problem/5729674> Seed: Crash in 
              RenderButton::setStyle at http://www.dinorpg.com
      
              * fast/forms/input-first-letter.html: Added.
              * platform/mac/fast/forms/input-first-letter-expected.checksum: Added.
              * platform/mac/fast/forms/input-first-letter-expected.png: Added.
              * platform/mac/fast/forms/input-first-letter-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff39ce21
    • andersca@apple.com's avatar
      Reviewed by Darin. · a292f5de
      andersca@apple.com authored
              Change OpaqueJSClass and RootObject to start with a ref count of 1.
              
              * API/JSClassRef.cpp:
              (OpaqueJSClass::OpaqueJSClass):
              (OpaqueJSClass::createNoAutomaticPrototype):
              (OpaqueJSClass::create):
              * API/JSClassRef.h:
              * API/JSObjectRef.cpp:
              (JSClassCreate):
              * bindings/runtime_root.cpp:
              (KJS::Bindings::RootObject::create):
              (KJS::Bindings::RootObject::RootObject):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a292f5de
    • mitz@apple.com's avatar
      WebCore: · fb8da4e3
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15
      
              Test: fast/text/wbr-styled.html
      
              Changed RenderWordBreak to inherit from RenderText instead of
              RenderInline.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::calcInlinePrefWidths):
              * rendering/RenderFlow.h:
              * rendering/RenderText.cpp:
              (WebCore::RenderText::renderName):
              (WebCore::RenderText::isTextFragment):
              (WebCore::RenderText::isWordBreak):
              * rendering/RenderText.h:
              * rendering/RenderWordBreak.cpp:
              (WebCore::RenderWordBreak::RenderWordBreak):
              * rendering/RenderWordBreak.h:
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::findNextLineBreak):
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test for <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15
      
              * fast/text/wbr-styled.html: Added.
              * platform/mac-leopard/fast/text/wbr-styled-expected.checksum: Added.
              * platform/mac-leopard/fast/text/wbr-styled-expected.png: Added.
              * platform/mac/fast/css-generated-content/wbr-with-before-content-expected.txt:
              * platform/mac/fast/text/wbr-pre-expected.txt:
              * platform/mac/fast/text/wbr-styled-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb8da4e3
    • andersca@apple.com's avatar
      Fix ChangeLog · 54dd2575
      andersca@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54dd2575
    • andersca@apple.com's avatar
      WebCore: · ec4eab69
      andersca@apple.com authored
              Reviewed by Darin.
      
              WARNING: NO TEST CASES ADDED OR CHANGED
      
              * ChangeLog:
              * WebCore.base.exp:
              * loader/mac/LoaderNSURLExtras.h:
              * loader/mac/LoaderNSURLExtras.m:
              Move unused functions to WebKit (where they are used)
              
              (vectorContainsString):
              Use const references.
              
              * platform/mac/WebCoreSystemInterface.h:
              * platform/mac/WebCoreSystemInterface.mm:
              Remove wkNSURLProtocolClassForReqest.
      
      WebKit/mac:
      
              Reviewed by Darin.
      
              Move back WebKit methods that were unused in WebCore.
              
              * Misc/WebNSURLExtras.mm:
              (+[NSURL _web_URLWithData:]):
              (+[NSURL _web_URLWithData:relativeToURL:]):
              (-[NSURL _web_originalData]):
              (-[NSURL _web_originalDataAsString]):
              (-[NSURL _web_isEmpty]):
              (-[NSURL _webkit_canonicalize]):
              (-[NSURL _webkit_URLByRemovingComponent:]):
              (-[NSURL _webkit_URLByRemovingFragment]):
              (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
              (-[NSURL _webkit_isFileURL]):
              (-[NSString _webkit_isFileURL]):
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::setTitle):
              * WebCoreSupport/WebSystemInterface.m:
              (InitWebCoreSystemInterface):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec4eab69
    • justin.garcia@apple.com's avatar
      Reviewed by Darin Adler. · bb9758d9
      justin.garcia@apple.com authored
              <rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore 
              
              These changes bring deleting performance back to old levels on the phone
              except for deleting the first space to the right of a word, which we are
              still working on.
      
              * dom/Position.cpp:
              (WebCore::Position::upstream): Avoid the use of enclosingBlock when determining
              if we have left the original enclosing block or entered a new one, and avoid
              rootEditableElement for determining if we have changed editability.  These
              operations are expensive.
              (WebCore::Position::downstream): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb9758d9
    • darin@apple.com's avatar
      JavaScriptCore: · f2d6d947
      darin@apple.com authored
              Rubber stamped by Anders.
      
              - removed explicit initialization to 1 for RefCounted; that's now the default
      
              * kjs/regexp.cpp:
              (KJS::RegExp::RegExp): Removed RefCounted initializer.
      
      WebCore:
      
              Rubber stamped by Anders.
      
              - removed explicit initialization to 1 for RefCounted; that's now the default
      
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::ResourceLoader): Removed RefCounted initializer.
              * platform/network/ResourceHandle.cpp:
              (WebCore::ResourceHandle::ResourceHandle): Ditto.
              * platform/text/StringImpl.cpp:
              (WebCore::StringImpl::StringImpl): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2d6d947
    • beidson@apple.com's avatar
      Reviewed by Geoff · 3b3e8c4c
      beidson@apple.com authored
              Fixed a bug in DRT --threaded mode
      
              * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
              (startJavaScriptThreads): Don't detach the newly created thread.  The later call to stopJavaScriptThreads() tries
                to pthread_join() each thread that had been created, but you can't join a detached thread!
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b3e8c4c
    • darin@apple.com's avatar
      Reviewed by Anders. · 650ffecd
      darin@apple.com authored
              - next step for http://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * wtf/RefCounted.h:
              (WTF::RefCounted::RefCounted): Have refcounts default to 1. This allows us to start
              removing the explicit initialization of RefCounted from classes and eventually we
              can remove the ability to have the initial count of 0 entirely.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      650ffecd
    • andersca@apple.com's avatar
      Reviewed by Darin. · 27b46305
      andersca@apple.com authored
              Make ResourceLoader and ResourceHandle start out with a refcount of 1.
      
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::create):
              * loader/NetscapePlugInStreamLoader.cpp:
              (WebCore::NetscapePlugInStreamLoader::create):
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::ResourceLoader):
              * loader/SubresourceLoader.cpp:
              (WebCore::SubresourceLoader::create):
              * platform/network/ResourceHandle.cpp:
              (WebCore::ResourceHandle::ResourceHandle):
              (WebCore::ResourceHandle::create):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27b46305
    • alp@webkit.org's avatar
      2008-02-19 Alp Toker <alp@atoker.com> · 656a8b9b
      alp@webkit.org authored
              Reviewed by Mark Rowe.
      
              http://bugs.webkit.org/show_bug.cgi?id=16863
              [GTK] tab focusing doesn't work
      
              GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
              the meta key state.
      
              Use GDK_META_MASK where available, otherwise do not support the meta
              key. This matches the behaviour of other applications.
      
              Also add a comment noting that the platform event constructors need to
              be kept in sync (it's not obvious that there are multiple places that
              check the key state).
      
              * platform/gtk/KeyEventGtk.cpp:
              (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
              * platform/gtk/MouseEventGtk.cpp:
              (WebCore::PlatformMouseEvent::PlatformMouseEvent):
              * platform/gtk/WheelEventGtk.cpp:
              (WebCore::PlatformWheelEvent::PlatformWheelEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      656a8b9b
    • beidson@apple.com's avatar
      Reviewed by Sam Weinig's white rhino tusk stamp · f193e3f7
      beidson@apple.com authored
              SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase
      
              * platform/sql/SQLiteTransaction.cpp:
              (WebCore::SQLiteTransaction::stop):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f193e3f7
    • beidson@apple.com's avatar
      Reviewed by Sam Weinig's rubberstamp · 77625ece
      beidson@apple.com authored
              SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase
      
              * platform/sql/SQLiteTransaction.cpp:
              (WebCore::SQLiteTransaction::stop):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77625ece
    • sfalken@apple.com's avatar
      Make Drosera work on Vista. · bbfa7a63
      sfalken@apple.com authored
              
              Runtime type library registration on Vista requires use of two new call:
              RegisterTypeLibraryForUser and UnRegisterTypeLibraryForUser, which write to
              HKCU.  LoadTypeLib[Ex] registers under HKLM, which fails under vista due to UAC.
              
              Reviewed by Adam.
      
              * WebKitDLL.cpp:
              (DllUnregisterServer): Call UnRegisterTypeLibraryForUser if available. Fix version number.
              (DllRegisterServer): Call RegisterTypeLibraryForUser if available.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbfa7a63
  3. 18 Feb, 2008 9 commits
    • mitz@apple.com's avatar
      Reviewed by Adam Roben in California. · 5708d149
      mitz@apple.com authored
              - remove unnecessary and erroneous layoutTestController calls from a test
      
              * fast/css/font-face-multiple-remote-sources.html:
              * platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5708d149
    • beidson@apple.com's avatar
      WebCore: · 1f0ec491
      beidson@apple.com authored
              Reviewed by Darin
      
              Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
      
              Test: platform/mac/plugins/webScriptObject-exception-deadlock.html
      
              * bindings/objc/WebScriptObject.mm:
              (-[WebScriptObject valueForKey:]): The line `resultObj = [super valueForKey:key];    // defaults to throwing an exception` 
                says it all - it throws an exception.  This method also happens to hold the JSLock.  Problematically, when the exeception
                is thrown and the method exited, the JSLock is never released.  Fix that without otherwise changing behavior by holding the 
                JSLock in two individual scopes - Right before the exception and right after.  
      
      WebKitTools:
      
              Changes by Geoff Garen, Reviewed by Darin
      
              Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
      
              DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
      
              [WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
              This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread.  If the lock has leaked,
              this series of method calls will deadlock.  If things are good, it will complete successfully.
      
              * DumpRenderTree/mac/ObjCController.m:
              (runJavaScriptThread):
              (+[ObjCController isSelectorExcludedFromWebScript:]):
              (+[ObjCController webScriptNameForSelector:]):
              (-[ObjCController testValueForKey]):
      
      LayoutTests:
      
              Reviewed by Darin
      
              Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
      
              * platform/mac-tiger/Skipped: Removed 2 hanging tests that now don't hang
              * platform/mac/plugins/webScriptObject-exception-deadlock-expected.txt: Added.
              * platform/mac/plugins/webScriptObject-exception-deadlock.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f0ec491
    • pewtermoose@webkit.org's avatar
      Remove FindSafari's Release configuration. · 9705b9e2
      pewtermoose@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9705b9e2
    • darin@apple.com's avatar
      WebCore: · 9413c168
      darin@apple.com authored
              Reviewed by Sam.
      
              - reduce use of DeprecatedString and memory allocations in processing of CSS
              - remove unnecessary double -> float -> double trip in the CSS parser
              - cleaned up names and structure in CSS grammar
      
              * css/CSSGrammar.y: Remove getPropertyID and getValueID. Both are now in CSSParser.cpp
              instead, and they now work on ParseString and String objects and don't require the caller
              to put the string into a char*. Gave members of the %union more sensible names, removed
              duplicates, and sorted into a logical order. Put the %expect back in, rather than leaving
              it commented out.
              * css/CSSParser.cpp:
              (WebCore::equalIgnoringCase): Added.
              (WebCore::hasPrefix): Added.
              (WebCore::CSSParser::parseTransitionProperty): Changed to call the new cssPropertyID,
              which obviates the need to call lower() and utf8() or to allocate memory at all. Also
              used equalIgnoringCase rather than putting the value into a String just to compare it.
              (WebCore::CSSParser::lex): Replaced convertASCIIToFloat with charactersToDouble. This change
              along with the CSSGrammar.y change, removes the double -> float -> double round trip, and
              affects the result of one layout test.
              (WebCore::cssPropertyID): Added. Gets the property ID from the gperf hash table, but
              without allocating any memory.
              (WebCore::cssValueKeywordID): Ditto.
              * css/CSSParser.h: Removed declaration for deprecatedString function (now used only in
              CSSParser.cpp; soon to be deleted). Added cssPropertyID and cssValueKeywordID functions.
      
              * css/CSSStyleDeclaration.cpp:
              (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Call cssPropertyID instead of propertyID.
              (WebCore::CSSStyleDeclaration::getPropertyValue): Ditto.
              (WebCore::CSSStyleDeclaration::getPropertyPriority): Ditto.
              (WebCore::CSSStyleDeclaration::getPropertyShorthand): Ditto.
              (WebCore::CSSStyleDeclaration::isPropertyImplicit): Ditto.
              (WebCore::CSSStyleDeclaration::setProperty): Ditto.
              (WebCore::CSSStyleDeclaration::removeProperty): Ditto.
              (WebCore::CSSStyleDeclaration::isPropertyName): Ditto.
              * css/CSSStyleDeclaration.h: Removed unnecessary includes, unnecessary Noncopyable boilerplate,
              and the getPropertyID function declaration along with its associated apology comment.
      
              * css/makevalues.pl: Generate constants instead of macros for CSS value numbers (but not an
              enumeration, like properties, since you rarely have any reason to handle all values, but
              often have a reason to handle all properties). Renamed the constant for the number of CSS
              value keywords from CSS_VAL_TOTAL to numCSSValueKeywords, and added maxCSSValueKeywordLength.
      
              * platform/text/String.cpp:
              (WebCore::charactersToDouble): Made this function more efficient by using a stack buffer
              rather than a CString.
      
      LayoutTests:
      
              Reviewed by Sam.
      
              - generate new results for the one test that was altered by the
                double -> float -> double trip taken by numeric values in the
                CSS parser
      
              This test appears under three different names in three different
              parts of our test suite.
      
              * platform/mac/css1/box_properties/acid_test-expected.checksum: Updated.
              * platform/mac/css1/box_properties/acid_test-expected.png: Ditto.
              * platform/mac/css1/box_properties/acid_test-expected.txt: Ditto.
              * platform/mac/css2.1/t09-c5526c-display-00-e-expected.checksum: Ditto.
              * platform/mac/css2.1/t09-c5526c-display-00-e-expected.png: Ditto.
              * platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt: Ditto.
              * platform/mac/fast/block/basic/011-expected.checksum: Ditto.
              * platform/mac/fast/block/basic/011-expected.png: Ditto.
              * platform/mac/fast/block/basic/011-expected.txt: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9413c168
    • mitz@apple.com's avatar
      WebCore: · b37f3bb2
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms
      
              Test: fast/css/font-face-multiple-remote-sources.html
      
              * css/CSSFontFace.cpp:
              (WebCore::CSSFontFace::fontLoaded):
              * css/CSSSegmentedFontFace.cpp:
              (WebCore::CSSSegmentedFontFace::fontLoaded):
      
      LayoutTests:
      
              - test for <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms
      
              * fast/css/font-face-multiple-remote-sources.html: Added.
              * platform/mac/fast/css/font-face-multiple-remote-sources-expected.checksum: Added.
              * platform/mac/fast/css/font-face-multiple-remote-sources-expected.png: Added.
              * platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b37f3bb2
    • darin@apple.com's avatar
      Reviewed by Sam. · fc52f18d
      darin@apple.com authored
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              (WebCore::hasCSSPropertyNamePrefix): Added.
              (WebCore::cssPropertyName): Reimplement to not use DeprecatedString. Also made faster
              by using a Vector<UChar> and eliminating all the string operations.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc52f18d
    • darin@apple.com's avatar
      Reviewed by Sam. · b5dac216
      darin@apple.com authored
              * Misc/WebNSAttributedStringExtras.mm:
              (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of
              DeprecatedString.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5dac216
    • slewis@apple.com's avatar
      2008-02-18 Stephanie Lewis <slewis@apple.com> · 2ac18971
      slewis@apple.com authored
              Reviewed by Adam.
      
      Remove workaround for <rdar://problem/5695848>.
              
              * platform/network/cf/ResourceResponseCFNet.cpp:
              (WebCore::ResourceResponse::doUpdateResourceResponse):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ac18971
    • darin@apple.com's avatar
      Reviewed by Sam. · 0ef41bef
      darin@apple.com authored
              * Api/qwebnetworkinterface.cpp:
              (QWebNetworkRequestPrivate::init): Removed use of DeprecatedString.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ef41bef