1. 20 May, 2010 1 commit
    • morrita@google.com's avatar
      2010-05-20 MORITA Hajime <morrita@google.com> · 034e133e
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              2x execCommand ReadAV@NULL
              https://bugs.webkit.org/show_bug.cgi?id=35791
      
              This test passes if it doesn't crash.
      
              * editing/execCommand/35791-expected.txt: Added.
              * editing/execCommand/35791.html: Added.
      2010-05-20  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Kent Tamura.
      
              2x execCommand ReadAV@NULL
              https://bugs.webkit.org/show_bug.cgi?id=35791
      
              In applyBlockStyle(), a node which is referred from
              nextParagraphStart sometimes removed from the document and goes
              orphan, and that causes an assertion failed. This is because
              moveParagraphs() replaces the node with a new one with some new
              styles applied. So we re-compute nextParagraphStart in that case.
      
              Test: editing/execCommand/35791.html
      
              * dom/Position.h:
              (WebCore::Position::isOrphan):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle):
              * editing/VisiblePosition.h:
              (WebCore::VisiblePosition::isOrphan):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      034e133e
  2. 01 Apr, 2010 1 commit
  3. 25 Jan, 2010 1 commit
    • dbates@webkit.org's avatar
      2010-01-25 Daniel Bates <dbates@webkit.org> · ef42d386
      dbates@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=34073
      
              Fixes misspelled words in comments.
      
              * accessibility/AccessibilityListBox.cpp:
              (WebCore::AccessibilityListBox::addChildren):
              (WebCore::AccessibilityListBox::doAccessibilityHitTest):
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper detach]):
              (AXAttributeStringSetElement):
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::completeURL):
              * bindings/js/JSDOMWindowBase.cpp:
              * bindings/js/JSDOMWindowBase.h:
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::getOwnPropertySlot):
              * bindings/js/JSSVGPODTypeWrapper.h:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInWorld):
              * bridge/NP_jsobject.cpp:
              (_NPN_SetException):
              * bridge/jni/jsc/JavaInstanceJSC.cpp:
              (JavaInstance::invokeMethod):
              (JObjectWrapper::JObjectWrapper):
              * bridge/objc/objc_instance.mm:
              (ObjcInstance::setValueOfUndefinedField):
              (ObjcInstance::getValueOfUndefinedField):
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::addFontFaceRule):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector):
              (WebCore::CSSStyleSelector::sortMatchedRules):
              (WebCore::CSSStyleSelector::applyDeclarations):
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/Document.cpp:
              (WebCore::Document::updateLayoutIgnorePendingStylesheets):
              (WebCore::Document::detach):
              * dom/Document.h:
              * dom/Element.cpp:
              (WebCore::Element::updateFocusAppearance):
              * dom/Element.h:
              * dom/MessagePortChannel.h:
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::receivedTarget):
              * dom/Node.cpp:
              (WebCore::Node::isFocusable):
              (WebCore::Node::shadowAncestorNode):
              * dom/Node.h:
              * dom/Position.cpp:
              (WebCore::Position::upstream):
              * dom/Position.h:
              * dom/Range.cpp:
              (WebCore::Range::processContents):
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::addCSSColor):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::StyleChange::reconcileTextDecorationProperties):
              (WebCore::StyleChange::extractTextStyles):
              (WebCore::prepareEditingStyleToApplyAt):
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd):
              * editing/Editor.cpp:
              (WebCore::Editor::learnSpelling):
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleMessage.prototype._format):
              * loader/Cache.cpp:
              (WebCore::Cache::pruneLiveResources):
              (WebCore::Cache::pruneDeadResources):
              * loader/Cache.h:
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::makePurgeable):
              * loader/CachedResource.h:
              * loader/CachedResourceHandle.h:
              * loader/DocumentLoader.h:
              * loader/FTPDirectoryParser.cpp:
              (WebCore::parseOneFTPLine):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didExplicitOpen):
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::didCancel):
              * loader/WorkerThreadableLoader.h:
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::spaceNeeded):
              * notifications/NotificationPresenter.h:
              (WebCore::NotificationPresenter::):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationController::updateAnimations):
              * platform/LinkHash.cpp:
              (WebCore::cleanPath):
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::calculateDrawingMode):
              * platform/graphics/cg/PatternCG.cpp:
              (WebCore::Pattern::createPlatformPattern):
              * platform/graphics/mac/ComplexTextController.cpp:
              (WebCore::ComplexTextController::offsetForPosition):
              * platform/graphics/mac/GraphicsLayerCA.h:
              * platform/graphics/mac/GraphicsLayerCA.mm:
              (WebCore::GraphicsLayerCA::ensureStructuralLayer):
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::doSeek):
              (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
              (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeSelection):
              (WebCore::Pasteboard::writePlainText):
              (WebCore::Pasteboard::writeURL):
              * platform/text/TextCodecICU.cpp:
              (WebCore::TextCodecICU::registerExtendedEncodingNames):
              * platform/text/TextEncodingDetectorICU.cpp:
              (WebCore::detectTextEncoding):
              * rendering/AutoTableLayout.cpp:
              (WebCore::AutoTableLayout::calcEffectiveWidth):
              (WebCore::AutoTableLayout::layout):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcAbsoluteHorizontalValues):
              (WebCore::RenderBox::calcAbsoluteVerticalValues):
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
              (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollByRecursively):
              (WebCore::RenderLayer::paintLayer):
              (WebCore::RenderLayer::hitTestLayer):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::destroy):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::setInnerTextValue):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::stateChanged):
              * rendering/SVGRenderSupport.cpp:
              (WebCore::SVGRenderBase::mapLocalToContainer):
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBox::buildTextChunks):
              * rendering/TransformState.cpp:
              (WebCore::TransformState::flattenWithTransform):
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::dispatchBlurEvent):
              (WebCore::WMLInputElement::suggestedValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef42d386
  4. 30 Nov, 2009 1 commit
    • enrica@apple.com's avatar
      WebCore: Can focus but not type into content editable block that contains only... · 429c6e2b
      enrica@apple.com authored
      WebCore: Can focus but not type into content editable block that contains only non-editable content.
      <rdar://problem/5982901>
      https://bugs.webkit.org/show_bug.cgi?id=31750
              
      Reviewed by Darin Adler.
      
      The goal is to change the way we choose a visible position
      after hit detection, by preferring a visually equivalent editable
      position if available. By doing this, it is possible to add content
      to an editable block that initially contains only non editable elements.
      
      Test: editing/selection/mixed-editability-10.html
      
      * WebCore.base.exp: Changed to match the new signature of downstream
      and upstream in the Position class.
      * dom/Position.cpp:
      (WebCore::Position::atEditingBoundary): Added.
      (WebCore::Position::upstream): Modified to allow to cross the boundary
      between editable and non editable content if required.
      (WebCore::Position::downstream): Modified to allow to cross the boundary
      between editable and non editable content if required.
      (WebCore::Position::isCandidate): Modified to qualify as candidates positions
      that are at the editability boundary.
      (WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box
      to be used in calculating the caret rectangle.
      * dom/Position.h:
      (WebCore::Position::):
      * dom/PositionIterator.cpp:
      (WebCore::PositionIterator::atEditingBoundary): Added.
      (WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions
      that are at the editability boundary.
      * dom/PositionIterator.h:
      * editing/htmlediting.cpp:
      (WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only
      descendants of the editable container, but the container itself.
      (WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only
      descendants of the editable container, but the container itself.
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position,
      if available.
      * rendering/RenderText.cpp:
      (WebCore::RenderText::isAllCollapsibleWhitespace): Added.
      * rendering/RenderText.h:
      
      LayoutTests: Can focus but not type into content editable block that contains only non-editable content.
      <rdar://problem/5982901>
      https://bugs.webkit.org/show_bug.cgi?id=31750
      
      Reviewed by Darin Adler.
      
      * editing/selection/5825350-1-expected.txt:
      * editing/selection/5825350-1.html: Modified to use caret rectangle.
      * editing/selection/5825350-2-expected.txt:
      * editing/selection/5825350-2.html: Modified to use caret rectangle.
      * editing/selection/mixed-editability-10-expected.txt: Added.
      * editing/selection/mixed-editability-10.html: Added.
      * platform/mac/editing/deleting/5390681-2-expected.txt: Re-baselined
      to account for the new possible caret position.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      429c6e2b
  5. 09 Sep, 2009 3 commits
    • eric@webkit.org's avatar
      2009-07-30 Eric Seidel <eric@webkit.org> · 50790ad2
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Add more position constructors
              positionBeforeNode, positionAfterNode
              firstPositionInNode, lastPositionInNode
              https://bugs.webkit.org/show_bug.cgi?id=25494
      
              I also added a lastOffsetInNode and deployed it to a couple places.
      
              There are no callers to these new constructors yet, but those
              will be coming in future patches.
      
              * dom/Position.cpp:
              (WebCore::Position::computeOffsetInContainerNode):
              * dom/Position.h:
              (WebCore::positionBeforeNode):
              (WebCore::positionAfterNode):
              (WebCore::lastOffsetInNode):
              (WebCore::firstPositionInNode):
              (WebCore::lastPositionInNode):
              * editing/ApplyStyleCommand.cpp:
              * editing/TextIterator.cpp:
              (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
              * editing/htmlediting.cpp:
              (WebCore::lastOffsetForEditing):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50790ad2
    • eric@webkit.org's avatar
      2009-07-30 Eric Seidel <eric@webkit.org> · f74ae5cf
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Rename positionBeforeNode to positionInParentBeforeNode
              and positionAfterNode to positionInParentAfterNode
              in preparation for adding a positionBeforeNode
              which returns a neighbor-anchored position.
              https://bugs.webkit.org/show_bug.cgi?id=25494
      
              No functional changes, thus no tests.
      
              * dom/PositionConstructors.h:
              (WebCore::positionInParentBeforeNode):
              (WebCore::positionInParentAfterNode):
              * dom/PositionIterator.cpp:
              (WebCore::PositionIterator::operator Position):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyInlineStyle):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::positionOutsideTabSpan):
              (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
              (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
              * editing/CreateLinkCommand.cpp:
              (WebCore::CreateLinkCommand::doApply):
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::deleteTarget):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd):
              (WebCore::updatePositionForNodeRemoval):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::input):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent):
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
              * editing/htmlediting.cpp:
              (WebCore::firstEditablePositionAfterPositionInRoot):
              (WebCore::lastEditablePositionBeforePositionInRoot):
              (WebCore::rangeCompliantEquivalent):
              (WebCore::positionBeforeContainingSpecialElement):
              (WebCore::positionAfterContainingSpecialElement):
              (WebCore::positionBeforeTabSpan):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f74ae5cf
    • eric@webkit.org's avatar
      2009-07-30 Eric Seidel <eric@webkit.org> · 47dd0e7b
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Re-organize position creation functions in preparation for adding more
              https://bugs.webkit.org/show_bug.cgi?id=25494
      
              Make position functions inline to avoid ref-churn.
              Remove startPosition/endPosition as they were only used in one place.
      
              No functional changes, thus no tests.
      
              * dom/Position.cpp:
              * dom/Position.h:
              (WebCore::positionBeforeNode):
              (WebCore::positionAfterNode):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::moveTo):
              * editing/TypingCommand.cpp:
              * editing/htmlediting.cpp:
              * editing/htmlediting.h:
              (WebCore::firstDeepEditingPositionForNode):
              (WebCore::lastDeepEditingPositionForNode):
              * rendering/RenderObject.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47dd0e7b
  6. 21 Jul, 2009 1 commit
  7. 30 Apr, 2009 1 commit
    • eric@webkit.org's avatar
      Reviewed by Darin Adler. · ec7202e8
      eric@webkit.org authored
              Change Position to pre-compute the AnchorType and store it.
              Also store a "legacy editing mode" bit on the Position.
              https://bugs.webkit.org/show_bug.cgi?id=24763
      
              The old Postion(node, offset) constructor creates legacy positions
              but there are new constructors to create explicitly anchored positions
              which the next patch will use.
      
              Once we fix all the "position-fixup" functions (like rangeCompliantEquivalent) to
              only affect legacy positions, we will be able to distinguish
              between [table, 1] and [table, after] in the code correctly!
      
              * WebCore.base.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/Position.cpp:
              (WebCore::Position::Position):
              (WebCore::Position::moveToPosition):
              (WebCore::Position::moveToOffset):
              (WebCore::Position::anchorTypeForLegacyEditingPosition):
              (WebCore::Position::element):
              * dom/Position.h:
              (WebCore::Position::):
              (WebCore::Position::Position):
              (WebCore::Position::anchorType):
              (WebCore::Position::deprecatedEditingOffset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec7202e8
  8. 29 Apr, 2009 1 commit
    • eric@webkit.org's avatar
      Reviewed by Darin Adler. · 4e32ebc3
      eric@webkit.org authored
              Make m_offset private and change all callers to use deprecatedEditingOffset().
              https://bugs.webkit.org/show_bug.cgi?id=25472
      
              Per Darin's suggestion, this was just a simple search replace
              of .m_offset with .deprecatedEditingOffset().
      
              There was one change in InsertParagraphSeparatorCommand::doApply to use
              Position::moveToOffset(0) instead of .m_offset = 0;
      
              * dom/Position.cpp:
              (WebCore::Position::rendersInDifferentPosition):
              (WebCore::Position::leadingWhitespacePosition):
              * dom/Position.h:
              (WebCore::Position::deprecatedEditingOffset):
              (WebCore::Position::moveToOffset):
              (WebCore::operator==):
              * dom/PositionIterator.h:
              (WebCore::PositionIterator::PositionIterator):
              * dom/Range.cpp:
              (WebCore::Range::create):
              (WebCore::Range::compareBoundaryPoints):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
              (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
              (WebCore::ApplyStyleCommand::removeInlineStyle):
              (WebCore::ApplyStyleCommand::nodeFullySelected):
              (WebCore::ApplyStyleCommand::nodeFullyUnselected):
              (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
              (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
              (WebCore::ApplyStyleCommand::joinChildTextNodes):
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::insertNodeAt):
              (WebCore::CompositeEditCommand::positionOutsideTabSpan):
              (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
              (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
              (WebCore::CompositeEditCommand::deleteInsignificantText):
              (WebCore::CompositeEditCommand::moveParagraphs):
              (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::updatePositionForNodeRemoval):
              (WebCore::updatePositionForTextRemoval):
              (WebCore::DeleteSelectionCommand::handleGeneralDelete):
              (WebCore::DeleteSelectionCommand::fixupWhitespace):
              * editing/Editor.cpp:
              (WebCore::Editor::setComposition):
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::getCompositionSelection):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::performTrivialReplace):
              (WebCore::InsertTextCommand::input):
              (WebCore::InsertTextCommand::insertTab):
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::doApply):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::debugRenderer):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::rangeFromLocationAndLength):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::characterAfter):
              (WebCore::VisiblePosition::debugPosition):
              (WebCore::makeRange):
              (WebCore::setStart):
              (WebCore::setEnd):
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::toNormalizedRange):
              (WebCore::makeSearchRange):
              (WebCore::VisibleSelection::debugPosition):
              (WebCore::VisibleSelection::showTreeForThis):
              * editing/htmlediting.cpp:
              (WebCore::comparePositions):
              (WebCore::rangeCompliantEquivalent):
              * editing/visible_units.cpp:
              (WebCore::previousBoundary):
              (WebCore::nextBoundary):
              (WebCore::startPositionForLine):
              (WebCore::startOfLine):
              (WebCore::endPositionForLine):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              (WebCore::logicalStartPositionForLine):
              (WebCore::logicalEndPositionForLine):
              * page/AccessibilityObject.cpp:
              (WebCore::updateAXLineStartForVisiblePosition):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::anchorOffset):
              (WebCore::DOMSelection::focusOffset):
              (WebCore::DOMSelection::baseOffset):
              (WebCore::DOMSelection::extentOffset):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              * page/Frame.cpp:
              (WebCore::Frame::selectionLayoutChanged):
              * page/mac/AccessibilityObjectWrapper.mm:
              (textMarkerForVisiblePosition):
              (visiblePositionForTextMarker):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::indexForVisiblePosition):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e32ebc3
  9. 07 Apr, 2009 2 commits
    • eric@webkit.org's avatar
      Reviewed by Darin Adler. · b9aaf595
      eric@webkit.org authored
              Move RangeBoundaryPoint off of Position, per Darin's suggestion
              https://bugs.webkit.org/show_bug.cgi?id=24966
      
              Rename setToChild to setToBeforeChild (since that's what the method does)
      
              * dom/Position.h:
              (WebCore::Position::offsetInContainerNode):
              * dom/Range.cpp:
              (WebCore::Range::insertNode):
              (WebCore::Range::selectNodeContents):
              (WebCore::boundaryNodeWillBeRemoved):
              * dom/Range.h:
              (WebCore::Range::startPosition):
              (WebCore::Range::endPosition):
              * dom/RangeBoundaryPoint.h:
              (WebCore::RangeBoundaryPoint::RangeBoundaryPoint):
              (WebCore::RangeBoundaryPoint::container):
              (WebCore::RangeBoundaryPoint::childBefore):
              (WebCore::RangeBoundaryPoint::position):
              (WebCore::RangeBoundaryPoint::offset):
              (WebCore::RangeBoundaryPoint::clear):
              (WebCore::RangeBoundaryPoint::set):
              (WebCore::RangeBoundaryPoint::setOffset):
              (WebCore::RangeBoundaryPoint::setToBeforeChild):
              (WebCore::RangeBoundaryPoint::setToStartOfNode):
              (WebCore::RangeBoundaryPoint::setToEndOfNode):
              (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
              (WebCore::RangeBoundaryPoint::invalidateOffset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9aaf595
    • eric@webkit.org's avatar
      Reviewed by Darin Adler. · b4c2e6c9
      eric@webkit.org authored
              Add containerNode(), computeOffsetInContainerNode(),
              computeNodeBeforePosition() and computeNodeAfterPosition().
              https://bugs.webkit.org/show_bug.cgi?id=24763
      
              These functions will replace uses of rangeCompliantPosition()
              in future patches.
      
              No changes in behavior, thus no tests.
      
              * dom/Position.cpp:
              (WebCore::Position::containerNode):
              (WebCore::Position::computeOffsetInContainerNode):
              (WebCore::Position::computeNodeBeforePosition):
              (WebCore::Position::computeNodeAfterPosition):
              (WebCore::Position::anchorType):
              * dom/Position.h:
              (WebCore::Position::):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4c2e6c9
  10. 23 Mar, 2009 1 commit
    • eric@webkit.org's avatar
      Reviewed by Darin Adler. · 0f8de539
      eric@webkit.org authored
              Rename Position::container to m_anchorNode and make it private
              https://bugs.webkit.org/show_bug.cgi?id=24760
      
              More code cleanup for Position.
      
              Change all uses of m_container to node()
              Eventually most uses of node() should change to anchorNode() to designate
              that it's the node the Position is anchored to, but not necessarily the
              container of the position (it could be the before/after neighbor).
      
              Remove any code which sets m_container, and change it to use a new
              Position::moveToPosition function which takes a node and offset.
              It never makes sense to change the node and leave the offset.
      
              * dom/Position.h:
              (WebCore::Position::Position):
              (WebCore::Position::clear):
              (WebCore::Position::anchorNode):
              (WebCore::Position::node):
              (WebCore::Position::moveToPosition):
              (WebCore::Position::moveToOffset):
              (WebCore::Position::isNull):
              (WebCore::Position::isNotNull):
              (WebCore::operator==):
              * dom/Range.cpp:
              (WebCore::Range::create):
              (WebCore::Range::compareBoundaryPoints):
              * dom/RangeBoundaryPoint.h:
              (WebCore::RangeBoundaryPoint::container):
              (WebCore::RangeBoundaryPoint::set):
              (WebCore::RangeBoundaryPoint::setOffset):
              (WebCore::RangeBoundaryPoint::setToChild):
              (WebCore::RangeBoundaryPoint::setToStart):
              (WebCore::RangeBoundaryPoint::setToEnd):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f8de539
  11. 20 Mar, 2009 1 commit
    • eric@webkit.org's avatar
      Reviewed by Justin Garcia. · f3a1881c
      eric@webkit.org authored
              maxDeepOffset is confusing and should be removed
              https://bugs.webkit.org/show_bug.cgi?id=24586
      
              Abstract some hard-to-read (but shared) logic into a new renderedAsNonInlineTableOrHR function.
              Add first/lastDeepEditingPositionForNode Position creation functions
              and deploy them to places we used to call maxDeepOffset.
      
              Rename Position::atStart and atEnd to atStartOfTree atEndOfTree
              Add a new Position::atFirst/atLastEditingPositionForNode() and use these
              to replace a few more callers for maxDeepOffset()
      
              Rename maxDeepOffset to lastEditingOffsetForNode (so that we mere mortals have some clue what it does)
      
              "Editing positions" are confusing because they have one
              of two behaviors, depending on if the container node is ignored
              by editing (if editingIgnoresContent(node) returns true) or not.
              Positions referring to nodes ignored by editing are
              neighbor-relative (they are before or after the node) where as
              positions reffering to other nodes are container-relative
              (they are between two child nodes of the container, identified
              by the offset() member).  I will be fixing this confusion in
              future patches.  These renames hopefully make the current behavior clearer.
      
              * dom/Position.cpp:
              (WebCore::Position::previous):
              (WebCore::Position::next):
              (WebCore::Position::atFirstEditingPositionForNode):
              (WebCore::Position::atLastEditingPositionForNode):
              (WebCore::Position::atStartOfTree):
              (WebCore::Position::atEndOfTree):
              (WebCore::Position::previousCharacterPosition):
              (WebCore::Position::nextCharacterPosition):
              (WebCore::Position::upstream):
              (WebCore::Position::isCandidate):
              (WebCore::firstDeepEditingPositionForNode):
              (WebCore::lastDeepEditingPositionForNode):
              * dom/Position.h:
              * dom/PositionIterator.cpp:
              (WebCore::PositionIterator::operator Position):
              (WebCore::PositionIterator::increment):
              (WebCore::PositionIterator::decrement):
              (WebCore::PositionIterator::atEnd):
              (WebCore::PositionIterator::atEndOfNode):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::isTableCellEmpty):
              (WebCore::DeleteSelectionCommand::removeNode):
              (WebCore::DeleteSelectionCommand::handleGeneralDelete):
              * editing/Editor.cpp:
              (WebCore::Editor::advanceToNextMisspelling):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::doApply):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::previous):
              (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::left):
              (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::right):
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::selectionFromContentsOfNode):
              (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
              * editing/htmlediting.cpp:
              (WebCore::nextVisuallyDistinctCandidate):
              (WebCore::previousVisuallyDistinctCandidate):
              (WebCore::firstEditablePositionAfterPositionInRoot):
              (WebCore::lastEditablePositionBeforePositionInRoot):
              (WebCore::lastOffsetForEditing):
              (WebCore::isFirstPositionAfterTable):
              (WebCore::isLastPositionBeforeTable):
              (WebCore::positionBeforeNode):
              (WebCore::positionAfterNode):
              (WebCore::enclosingEmptyListItem):
              (WebCore::caretMaxOffset):
              * editing/htmlediting.h:
              * editing/visible_units.cpp:
              (WebCore::renderedAsNonInlineTableOrHR):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              (WebCore::startOfEditableContent):
              (WebCore::endOfEditableContent):
              * page/AccessibilityObject.cpp:
              (WebCore::endOfStyleRange):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::visiblePositionRange):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::positionForPoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3a1881c
  12. 10 Mar, 2009 1 commit
    • xan@webkit.org's avatar
      2009-03-10 Xan Lopez <xlopez@igalia.com> · 72434b27
      xan@webkit.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=24491
              Rename posOffset to m_offset, get rid of accessor
      
              As suggested in dom/Position.h, this patch gets rid of the
              'offset()' accessor and renames posOffset to m_offset. I've used
              m_offset instead of offset to follow the style guide lines, since
              Position is still a class and not a structure. If the long term
              plan is still to make it a structure it would be pretty easy to
              just s/m_offset/offset/ globally when that is achieved.
      
              * dom/Position.cpp:
              (WebCore::Position::previous):
              (WebCore::Position::next):
              (WebCore::Position::atStart):
              (WebCore::Position::atEnd):
              (WebCore::Position::renderedOffset):
              (WebCore::Position::isCandidate):
              (WebCore::Position::inRenderedText):
              (WebCore::Position::isRenderedCharacter):
              (WebCore::Position::rendersInDifferentPosition):
              (WebCore::Position::leadingWhitespacePosition):
              (WebCore::Position::debugPosition):
              (WebCore::Position::formatForDebugger):
              * dom/Position.h:
              (WebCore::Position::Position):
              * dom/PositionIterator.h:
              (WebCore::PositionIterator::PositionIterator):
              * dom/Range.cpp:
              * dom/RangeBoundaryPoint.h:
              (WebCore::RangeBoundaryPoint::position):
              (WebCore::RangeBoundaryPoint::set):
              (WebCore::RangeBoundaryPoint::setOffset):
              (WebCore::RangeBoundaryPoint::setToChild):
              (WebCore::RangeBoundaryPoint::setToStart):
              (WebCore::RangeBoundaryPoint::setToEnd):
              (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
              (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
              (WebCore::ApplyStyleCommand::removeInlineStyle):
              (WebCore::ApplyStyleCommand::nodeFullySelected):
              (WebCore::ApplyStyleCommand::nodeFullyUnselected):
              (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
              (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
              (WebCore::ApplyStyleCommand::joinChildTextNodes):
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::insertNodeAt):
              (WebCore::CompositeEditCommand::positionOutsideTabSpan):
              (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
              (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
              (WebCore::CompositeEditCommand::deleteInsignificantText):
              (WebCore::CompositeEditCommand::removePlaceholderAt):
              (WebCore::CompositeEditCommand::moveParagraphs):
              (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::updatePositionForNodeRemoval):
              (WebCore::updatePositionForTextRemoval):
              (WebCore::DeleteSelectionCommand::handleGeneralDelete):
              (WebCore::DeleteSelectionCommand::fixupWhitespace):
              * editing/Editor.cpp:
              (WebCore::Editor::setComposition):
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::getCompositionSelection):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::performTrivialReplace):
              (WebCore::InsertTextCommand::input):
              (WebCore::InsertTextCommand::insertTab):
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::doApply):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::debugRenderer):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::rangeFromLocationAndLength):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::characterAfter):
              (WebCore::VisiblePosition::debugPosition):
              (WebCore::makeRange):
              (WebCore::setStart):
              (WebCore::setEnd):
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::toNormalizedRange):
              (WebCore::makeSearchRange):
              (WebCore::VisibleSelection::debugPosition):
              (WebCore::VisibleSelection::showTreeForThis):
              * editing/htmlediting.cpp:
              (WebCore::comparePositions):
              (WebCore::rangeCompliantEquivalent):
              (WebCore::isFirstPositionAfterTable):
              (WebCore::isLastPositionBeforeTable):
              * editing/visible_units.cpp:
              (WebCore::previousBoundary):
              (WebCore::nextBoundary):
              (WebCore::startPositionForLine):
              (WebCore::startOfLine):
              (WebCore::endPositionForLine):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              * page/AccessibilityObject.cpp:
              (WebCore::updateAXLineStartForVisiblePosition):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::anchorOffset):
              (WebCore::DOMSelection::baseOffset):
              (WebCore::DOMSelection::focusOffset):
              (WebCore::DOMSelection::extentOffset):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              * page/Frame.cpp:
              (WebCore::Frame::selectionLayoutChanged):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::indexForVisiblePosition):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72434b27
  13. 06 Feb, 2009 1 commit
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 73ecea19
      ap@webkit.org authored
              <rdar://problem/6438271> Improve backspace handling of accented characters
      
              Test: platform/mac/editing/deleting/backward-delete.html
      
              This change makes WebKit behave like AppKit on the Mac. Other platforms are not affected,
              because the current behavior matches their standards (tested on Windows, assumed elsewhere).
      
              * dom/Position.cpp:
              (WebCore::Position::previous):
              (WebCore::Position::next):
              (WebCore::Position::uncheckedPreviousOffsetForBackwardDeletion):
              * dom/Position.h:
              Added a new option for previous(), used to move to a next position for backward deletion.
              Renamed EUsingComposedCharacters to PositionMoveType.
      
              * editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
              Use previous(BackwardDeletion) to find a proper range to delete. Also, simplified a check
              surrounding this code a little.
      
              * editing/htmlediting.cpp:
              (WebCore::nextVisuallyDistinctCandidate):
              (WebCore::previousVisuallyDistinctCandidate):
              Adjusted for renamed enum values.
      
              * rendering/RenderObject.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderText.h:
              Added previousOffsetForBackwardDeletion().
      
              * rendering/RenderText.cpp: (WebCore::RenderText::previousOffsetForBackwardDeletion):
              On PLATFORM(MAC), use an algorithm that matches the one AppKit has for backward deletion.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73ecea19
  14. 24 Apr, 2008 1 commit
    • mitz@apple.com's avatar
      WebCore: · 576e84e8
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
                <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
      
              The three main changes in this patch are:
      
              1) Making all inline boxes know their bidi level, instead of just text
                 boxes knowing whether their bidi level is odd or even. This is
                 required for the next change.
      
              2) Replacing RenderObject::inlineBox() with
                 Position::getInlineBoxAndOffset() in recognition of the fact that the
                 inline box containing the primary caret for a position in a given
                 node may belong to a different node's renderer.
      
              3) Changing RenderObject::caretRect() to take an InlineBox parameter,
                 and changing callers to call VisiblePosition::caretRect(), which
                 locates the inline box, then calls caretRect() on the renderer for
                 that box. This, combined with the previous change, ensures that the
                 primary caret is rendered at the right place for positions that
                 lie on a directionality boundary.
      
              Test: platform/mac/editing/input/caret-primary-bidi.html
      
              * WebCore.base.exp: Added the VisiblePosition(Node*, int, EAffinity)
              constructor and VisiblePosition::caretRect(), and sorted.
      
              * dom/Position.cpp:
              (WebCore::nextRenderedEditable): Adjusted for the removal of
              RenderObject::inlineBox().
              (WebCore::previousRenderedEditable): Ditto.
              (WebCore::Position::rendersInDifferentPosition): Ditto.
              (WebCore::Position::getInlineBoxAndOffset): Added. Gets the inline box
              and the offset within that box at which the primary caret for this
              position should render.
      
              * dom/Position.h:
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::mergeParagraphs): Changed to call
              VisiblePosition::caretRect() instead of calling the RenderObject method.
      
              * editing/SelectionController.cpp:
              (WebCore::caretY): Ditto.
              (WebCore::SelectionController::xPosForVerticalArrowNavigation): Ditto.
              (WebCore::SelectionController::layout): Ditto.
      
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::caretRect): Changed to call
              getInlineBoxAndOffset() to get the correct inline box and call the
              renderer for that box.
      
              * editing/VisiblePosition.h:
              (WebCore::VisiblePosition::getInlineBoxAndOffset): Added convenience
              methods for getting the inline box and caret offset for a visible
              position, accounting for its affinity.
      
              * editing/visible_units.cpp:
              (WebCore::rootBoxForLine): Changed to use getInlineBoxAndOffset()
              instead of RenderObject::inlineBox().
              (WebCore::startPositionForLine):
              (WebCore::endPositionForLine):
              (WebCore::previousLinePosition): Ditto.
              (WebCore::nextLinePosition): Ditto.
      
              * page/AccessibilityObject.cpp:
              (WebCore::updateAXLineStartForVisiblePosition): Ditto.
      
              * page/Frame.cpp:
              (WebCore::Frame::firstRectForRange): Ditto.
      
              * rendering/InlineBox.cpp:
              (WebCore::InlineBox::caretMinOffset): Changed to forward to the
              renderer.
              (WebCore::InlineBox::caretMaxOffset): Ditto.
              * rendering/InlineBox.h: Replaced the m_reversed bit, intended for use
              in InlineTextBox only, with six bits of the bidi level of the box,
              intended for use in all leaf inline boxes.
              (WebCore::InlineBox::InlineBox): Added missing initializer for
              m_dirOverride and initialized the bidi level.
              (WebCore::InlineBox::bidiLevel): Added this accessor.
              (WebCore::InlineBox::setBidiLevel): Ditto.
              (WebCore::InlineBox::direction): Ditto.
              (WebCore::InlineBox::caretLeftmostOffset): Added this convenience
              method.
              (WebCore::InlineBox::caretRightmostOffset): Ditto.
      
              * rendering/InlineTextBox.cpp: Replaced all references to m_reversed
              with checking of direction().
              (WebCore::InlineTextBox::selectionRect):
              (WebCore::InlineTextBox::placeEllipsisBox):
              (WebCore::InlineTextBox::paint):
              (WebCore::InlineTextBox::paintSelection):
              (WebCore::InlineTextBox::paintCompositionBackground):
              (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
              (WebCore::InlineTextBox::paintTextMatchMarker):
              (WebCore::InlineTextBox::textPos):
              (WebCore::InlineTextBox::offsetForPosition):
              (WebCore::InlineTextBox::positionForOffset):
      
              * rendering/RenderBR.cpp: Removed inlineBox().
              * rendering/RenderBR.h: Ditto.
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::caretRect): Changed to take an inline box and
              account for the direction of the box (or the renderer) in positioning
              the caret: in right-to-left boxes, the "before" position is to the right
              while "after" is to the left.
              * rendering/RenderBox.h:
      
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::caretRect): Updated the signature.
              * rendering/RenderFlow.h:
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::caretRect): Updated the signature.
              (WebCore::RenderObject::caretMaxOffset): Changed to return the child
              node count (or 1 if there are no children) for replaced elements, such
              as <select>s.
              * rendering/RenderObject.h:
      
              * rendering/RenderReplaced.cpp: Removed caretMinOffset() and
              caretMaxOffset() because the base class implementation does the right
              thing for replaced objects now.
              * rendering/RenderReplaced.h:
      
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::caretRect): Updated the signature.
              (WebCore::RenderSVGInlineText::positionForCoordinates): Updated for
              the change from m_reversed to direction().
              * rendering/RenderSVGInlineText.h:
      
              * rendering/RenderText.cpp:
              (WebCore::RenderText::caretRect): Changed to take an inline box and
              removed the code that used to find the inline for the given position.
              Changed use of m_reversed to use direction().
              (WebCore::RenderText::position): Changed use of m_reversed to use
              direction().
              * rendering/RenderText.h:
      
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::textWithHardLineBreaks): Adjusted for the
              removal of RenderObject::inlineBox().
      
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeTextRun): Changed to use direction() instead of
              m_reversed.
      
              * rendering/SVGInlineTextBox.cpp: Ditto.
              (WebCore::SVGInlineTextBox::calculateGlyphBoundaries):
              (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
              (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
      
              * rendering/SVGRenderTreeAsText.cpp: Ditto.
              (WebCore::writeSVGInlineTextBox):
      
              * rendering/SVGRootInlineBox.cpp: Ditto.
              (WebCore::svgTextRunForInlineTextBox):
              (WebCore::cummulatedWidthOrHeightOfTextChunk):
              (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::constructLine): Made this function set the
              bidi level on all leaf boxes.
      
              * svg/SVGTextContentElement.cpp: Changed to use direction() instead of
              m_reversed.
              (WebCore::cumulativeCharacterRangeLength):
              (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
      
      WebKit/mac:
      
              Reviewed by Darin Adler.
      
              - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
                <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
      
              * WebView/WebFrame.mm:
              (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
              VisiblePosition::caretRect() instead of the RenderObject method which
              was removed.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test the visual position of the primary caret in bidirectional text
      
              * platform/mac/editing/input/caret-primary-bidi-expected.txt: Added.
              * platform/mac/editing/input/caret-primary-bidi.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      576e84e8
  15. 19 Mar, 2008 1 commit
    • justin.garcia@apple.com's avatar
      WebCore: · 14613b12
      justin.garcia@apple.com authored
      2008-03-19  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Oliver.
      
              <rdar://problem/5794920> Acid3: Assertion failure in VisiblePosition::previous when clicking on results (17004)
              
              The position inside an empty inline-block was a candidate, but upstream and downstream
              would move across it without stopping.  This confused canonicalPosition, since no more
              than two candidates should have the same upstream/downstream (be visually equivalent).
              
              Code was added intentionally in isCandidate to make VisiblePositions inside empty 
              inline-blocks, so we need to make upstream/downstream understand that.
      
              * dom/Position.cpp:
              (WebCore::endsOfNodeAreVisuallyDistinctPositions): upstream and downstream used to only
              stop when entering or leaving a non-inline element (referred to as a "block").  We must also 
              avoid entering or leaving an empty inline-block.  This will allow a VisiblePosition there, to 
              match up with what the code in isCandidate intended.
              (WebCore::enclosingVisualBoundary): Removed enclosingBlock and replaced it with this.
              (WebCore::Position::upstream): Added better comments, called the new functions.
              (WebCore::Position::downstream): Ditto.
              * dom/Position.h:
      
      LayoutTests:
      
      2008-03-19  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Oliver.
              
              <rdar://problem/5794920> Acid3: Assertion failure in VisiblePosition::previous when clicking on results (17004)
      
              * editing/pasteboard/4989774.html: Updated to wait for the images to load before trying to copy it.
              * editing/selection/5794920-1-expected.txt: Added.
              * editing/selection/5794920-1.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14613b12
  16. 11 Mar, 2008 1 commit
    • darin@apple.com's avatar
      WebCore: · b7bf13ad
      darin@apple.com authored
              Reviewed by Mitz.
      
              - make some Range improvements (preparation for Range support for DOM mutation)
      
              Made constructors private, added create functions.
              Made refcount start at 1 rather than starting at 0 and being incremented.
              Made Range use two Position objects for the start/end container/offset pairs.
      
              * WebCore.base.exp: Updated.
      
              * dom/Document.cpp:
              (WebCore::Document::createRange): Changed to use Range::create.
              (WebCore::Document::removeMarkers): Updated for Range::first/pastLastNode name change.
      
              * dom/Position.cpp:
              (WebCore::Position::formatForDebugger): Updated for member variable name change.
              (WebCore::Position::showTreeForThis): Ditto.
              (WebCore::startPosition): Changed to use Range::startPosition.
              (WebCore::endPosition): Changed to use Range::endPosition.
      
              * dom/Position.h: Made the data members public and renamed them to container
              and offset. But since offset() is already a function, temporarily used posOffset
              for the data member. Later we'll get rid of offset(). Made more functions inline.
              Removed the constructor that takes a PositionIterator.
      
              * dom/PositionIterator.cpp:
              (WebCore::PositionIterator::operator Position): Added. Replaces the constructor
              that used to be in Position.
              * dom/PositionIterator.h: Added conversion operator to produce a Position.
              Removed friend declaration for Position.
      
              * dom/Range.cpp:
              (WebCore::Range::Range): Updated constructors for data member changes and made
              them use a refcount of 1.
              (WebCore::Range::create): Added.
              (WebCore::Range::startContainer): Updated to eliminate use of m_detached; detached
              is now indicated by m_start.container of 0. Also updated to use m_start instead
              of the old m_startContainer.
              (WebCore::Range::startOffset): Ditto.
              (WebCore::Range::endContainer): Ditto.
              (WebCore::Range::endOffset): Ditto.
              (WebCore::Range::commonAncestorContainer): Ditto.
              (WebCore::Range::collapsed): Ditto.
              (WebCore::Range::setStart): Ditto.
              (WebCore::Range::setEnd): Ditto.
              (WebCore::Range::collapse): Ditto.
              (WebCore::Range::isPointInRange): Ditto.
              (WebCore::Range::comparePoint): Ditto.
              (WebCore::Range::compareNode): Ditto.
              (WebCore::Range::compareBoundaryPoints): Ditto.
              (WebCore::Range::boundaryPointsValid): Ditto.
              (WebCore::Range::deleteContents): Ditto.
              (WebCore::Range::intersectsNode): Ditto.
              (WebCore::Range::processContents): Ditto.
              (WebCore::Range::extractContents): Ditto.
              (WebCore::Range::cloneContents): Ditto.
              (WebCore::Range::insertNode): Ditto.
              (WebCore::Range::toString): Ditto.
              (WebCore::Range::text): Ditto.
              (WebCore::Range::createContextualFragment): Ditto.
              (WebCore::Range::detach): Ditto.
              (WebCore::Range::checkNodeBA): Changed to use switch statements instead of
              multiple calls to the virtual nodeType() function.
              (WebCore::Range::cloneRange): Ditto.
              (WebCore::Range::setStartAfter): Ditto.
              (WebCore::Range::setEndBefore): Ditto.
              (WebCore::Range::setEndAfter): Ditto.
              (WebCore::Range::selectNode): Ditto.
              (WebCore::Range::selectNodeContents): Ditto.
              (WebCore::Range::surroundContents): Ditto.
              (WebCore::Range::setStartBefore): Ditto.
              (WebCore::Range::checkDeleteExtract): Ditto.
              (WebCore::Range::containedByReadOnly): Ditto.
              (WebCore::Range::firstNode): Ditto.
              (WebCore::Range::editingStartPosition): Ditto.
              (WebCore::Range::pastLastNode): Ditto.
              (WebCore::Range::addLineBoxRects): Ditto.
              (WebCore::Range::formatForDebugger): Ditto.
              (WebCore::operator==): Ditto.
              (WebCore::rangeOfContents): Ditto.
              (WebCore::Range::maxStartOffset): Ditto.
              (WebCore::Range::maxEndOffset): Ditto.
      
              * dom/Range.h: Made constructors private. Added create functions.
              Added getters for startContainer/Offset and endContainer/Offset that
              return 0 instead of an exception for detached ranges that are inline
              and don't require an ExceptionCode out parameter. Changed the parameters
              to setStart and setEnd to PassRefPtr. Removed isDetached function.
              Made ActionType and processContents private. Made startPosition and
              endPosition inlines and have then return const&. Renamed startNode and
              pastEndNode to firstNode and pastLastNode to reduce the chance of
              confusion with startContainer/endContainer. Used Position for m_start
              and m_end instead of separate container and offset members. Changed
              maxStartOffset and maxEndOffset into int to match other offsets.
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle): Changed to use Range::create.
              (WebCore::ApplyStyleCommand::applyInlineStyle): Ditto.
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::inputText): Ditto.
              (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::mergeParagraphs): Ditto.
              * editing/Editor.cpp:
              (WebCore::Editor::fontForSelection): Changed for pastLastNode name change.
              (WebCore::Editor::setComposition): Changed to use Range::create.
              (WebCore::paragraphAlignedRangeForRange): Ditto.
              (WebCore::markMisspellingsOrBadGrammar): Changed to get rid of check for
              isDetached and check for 0 from startContainer instead.
              (WebCore::Editor::compositionRange): Changed to use Range::create.
              * editing/EditorCommand.cpp:
              (WebCore::unionDOMRanges): Ditto.
              * editing/Selection.cpp:
              (WebCore::Selection::toRange): Ditto.
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::TextIterator): Changed for firstNode and pastLastNode
              name change.
              (WebCore::TextIterator::range): Changed to use Range::create.
              (WebCore::SimplifiedBackwardsTextIterator::range): Ditto.
              (WebCore::TextIterator::subrange): Ditto.
              * editing/VisiblePosition.cpp:
              (WebCore::makeRange): Ditto.
              * editing/VisiblePosition.h: Added now-needed include.
              * editing/htmlediting.cpp:
              (WebCore::indexForVisiblePosition): Changed to use Range::create.
              (WebCore::avoidIntersectionWithNode): Changed to get rid of check for
              isDetached and check for 0 instead and to use Range::create.
              * editing/markup.cpp:
              (WebCore::renderedText): Changed to use Range::create.
              (WebCore::createMarkup): Changed to no longer use isDetached and also
              for new firstNode/pastEndNode names.
              (WebCore::createFragmentFromText): Ditto.
              * editing/visible_units.cpp:
              (WebCore::previousBoundary): Changed to use Range::create.
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge convertToNSRange:]): Changed to no longer use
              isDetached().
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::visiblePositionForIndex): Changed to use Range::create.
              (WebCore::RenderTextControl::indexForVisiblePosition): Ditto.
      
      WebKit/mac:
      
              Reviewed by Mitz.
      
              - update code affected by Range changes
      
              * Misc/WebNSAttributedStringExtras.mm:
              (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
              * WebView/WebHTMLRepresentation.mm:
              (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
              Use Range::create.
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView attributedString]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7bf13ad
  17. 11 Nov, 2007 1 commit
    • ap@webkit.org's avatar
      Reviewed by Darin. · ff51b523
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=15896
              More editing cleanup
      
              No functionality changes.
      
              * dom/Node.h: Moved several editing-related methods elsewhere.
              * dom/Node.cpp: (WebCore::Node::maxCharacterOffset): Renamed from maxOffset()
              to highlight that it is a match to offsetInCharacters(), and much different from other
              offset-related methods. Added ASSERT_NOT_REACHED(), as callers are supposed to check
              offsetInCharacters() before calling this.
      
              * dom/CharacterData.cpp: (WebCore::CharacterData::maxCharacterOffset):
              * dom/CharacterData.h: (WebCore::CharacterData::isCharacterDataNode):
              Updated for above renamings.
      
              * dom/Comment.{h,cpp}: Removed an override for offsetInCharacters(), which is already present in CharacterData.
      
              * dom/Document.{h,cpp}: Folded updateSelection() into Frame::selectionLayoutChanged().
      
              * dom/Position.h:
              * dom/Position.cpp:
              (WebCore::Position::uncheckedPreviousOffset): Moved from Node::previousOffset().
              (WebCore::Position::uncheckedNextOffset): Moved from Node::NextOffset().
              (WebCore::Position::previous): Adapted to the above move.
              (WebCore::Position::next): Ditto.
              (WebCore::Position::upstream): Removed an isBR() check, since a non-BR element cannot have a BR renderer (I think),
              and BR elements are covered by editingIgnoresContent().
              (WebCore::Position::downstream): Ditto.
              (WebCore::caretMaxRenderedOffset): Moved from Node::caretMaxRenderedOffset().
              (WebCore::Position::rendersInDifferentPosition): Updated for the above moves.
      
              * dom/PositionIterator.h: Added a comment describing this class from the original check-in.
              * dom/PositionIterator.cpp:
              (WebCore::PositionIterator::increment): Updated for the above moves.
              (WebCore::PositionIterator::decrement): Ditto.
      
              * dom/ProcessingInstruction.h:
              * dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::maxCharacterOffset):
              ProcessingInstruction was already returning true from offsetInCharacters(), but didn't override maxCharacterOffset().
              I think that implementing it has no actual effect, as PIs are not rendered, but it looks cleaner this way.
      
              * dom/Range.cpp:
              (WebCore::Range::selectNodeContents):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
              (WebCore::ApplyStyleCommand::applyInlineStyle):
              (WebCore::maxRangeOffset):
              (WebCore::ApplyStyleCommand::removeInlineStyle):
              (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::insertNodeAt):
              (WebCore::CompositeEditCommand::positionOutsideTabSpan):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::handleGeneralDelete):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::insertTab):
              * editing/visible_units.cpp:
              (WebCore::previousLinePosition):
              (WebCore::nextLinePosition):
              Updated for the above moves.
      
              * editing/Editor.cpp:
              (WebCore::Editor::advanceToNextMisspelling): Added a missing rangeCompliantEquivalent() call.
      
              * editing/TextIterator.cpp:
              (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Changed the condition to obviously
              match a maxCharacterOffset() call made after it; hopefully, this doesn't break any border cases.
              (WebCore::SimplifiedBackwardsTextIterator::advance): Updated for the above moves.
      
              * editing/htmlediting.h:
              * editing/htmlediting.cpp:
              (WebCore::canHaveChildrenForEditing): Removed a bogus comment: I don't thin BRs have a special ability to accept
              child nodes, other than via DOM manipulation, which is not specific to BRs.
              (WebCore::rangeCompliantEquivalent): Removed a check for BR, which is already covered by editingIgnoresContent().
              (WebCore::maxDeepOffset): Ditto.
              (WebCore::caretMinOffset): Moved from Node. Changed some runtime checks that seemingly cannot fail into assertions.
              (WebCore::caretMaxOffset): Ditto.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick): Pass 0 to VisiblePosition constructor instead of
              caretMinOffset. I didn't want to include htmlediting.h here, and I think that VisiblePosition constructor
              will take care of adjusting the offset.
      
              * page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Folded Document::updateSelection() here.
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]): Added missing rangeCompliantEquivalent() calls.
              * rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForRenderer): Changed to not round-trip via editing.
              Changed some runtime checks that seemingly cannot fail into assertions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff51b523
  18. 20 Feb, 2007 1 commit
    • weinig's avatar
      Reviewed by Darin and then Sam. · 346f9e37
      weinig authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=10735
                Clicking in SVG results causes WebKit to consume 100% CPU for several minutes
      
              No test since there is no change in functionality.
      
              * CMakeLists.txt:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj: Added PositionIterator.{cpp,h}.
              * WebCoreSources.bkl:
              * dom/Position.cpp:
              (WebCore::Position::Position): Added converting constructor from
              PositionIterator.
              (WebCore::Position::previous): Changed assert() to ASSERT().
              (WebCore::Position::next): Ditto.
              (WebCore::isStreamer): Changed the argument to a PositionIterator.
              (WebCore::Position::upstream): Changed to use PositionIterator.
              (WebCore::Position::downstream): Ditto.
              (WebCore::Position::inRenderedText): Made public.
              (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Changed
              into a static member function.
              (WebCore::Position::nodeIsUserSelectNone): Ditto.
              * dom/Position.h:
              * dom/PositionIterator.cpp: Added. A Position iterator with constant-time
              increment, decrement, and several predicates on the Position it is at.
              Conversion to/from Position is O(n) in the offset.
              (WebCore::PositionIterator::increment):
              (WebCore::PositionIterator::decrement):
              (WebCore::PositionIterator::atStart):
              (WebCore::PositionIterator::atEnd):
              (WebCore::PositionIterator::atStartOfNode):
              (WebCore::PositionIterator::atEndOfNode):
              (WebCore::PositionIterator::isCandidate):
              * dom/PositionIterator.h: Added.
              (WebCore::PositionIterator::PositionIterator):
              (WebCore::PositionIterator::node):
              (WebCore::PositionIterator::offsetInLeafNode):
              * editing/htmlediting.cpp:
              (WebCore::nextCandidate): Changed to use PositionIterator.
              (WebCore::previousCandidate): Changed to use PositionIterator.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      346f9e37
  19. 15 Jan, 2007 1 commit
    • eseidel's avatar
      2007-01-15 Eric Seidel <eric@webkit.org> · 8eddecf9
      eseidel authored
              Reviewed by bdash.
      
              Update header guards to follow new style guidelines using new clean-header-guards script.
      
              * bindings/js/JSHTMLElementWrapperFactory.h:
              * bindings/js/JSHTMLInputElementBase.h:
              * bindings/js/JSHTMLOptionElementConstructor.h:
              * bindings/js/JSSVGElementWrapperFactory.h:
              * bindings/js/JSSVGPODTypeWrapper.h:
              * bindings/js/JSXMLHttpRequest.h:
              * bindings/js/JSXSLTProcessor.h:
              * bindings/js/kjs_binding.h:
              * bindings/js/kjs_css.h:
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_domnode.h:
              * bindings/js/kjs_events.h:
              * bindings/js/kjs_html.h:
              * bindings/js/kjs_navigator.h:
              * bindings/js/kjs_proxy.h:
              * bindings/js/kjs_traversal.h:
              * bindings/js/kjs_window.h:
              * bridge/EditorClient.h:
              * bridge/History.h:
              * css/CSSStyleSheet.h:
              * css/CSSValue.h:
              * css/CSSValueList.h:
              * css/DashboardRegion.h:
              * css/FontFamilyValue.h:
              * css/FontValue.h:
              * css/MediaFeatureNames.h:
              * css/MediaList.h:
              * css/Pair.h:
              * css/RectImpl.h:
              * css/ShadowValue.h:
              * css/StyleBase.h:
              * css/StyleList.h:
              * css/StyleSheet.h:
              * css/StyleSheetList.h:
              * css/cssstyleselector.h:
              * dom/BeforeTextInsertedEvent.h:
              * dom/CDATASection.h:
              * dom/CharacterData.h:
              * dom/ChildNodeList.h:
              * dom/Comment.h:
              * dom/DOMImplementation.h:
              * dom/DocPtr.h:
              * dom/Document.h:
              * dom/DocumentFragment.h:
              * dom/DocumentMarker.h:
              * dom/DocumentType.h:
              * dom/EditingText.h:
              * dom/Entity.h:
              * dom/EntityReference.h:
              * dom/EventNames.h:
              * dom/EventTargetNode.h:
              * dom/NameNodeList.h:
              * dom/NamedNodeMap.h:
              * dom/Node.h:
              * dom/NodeList.h:
              * dom/Notation.h:
              * dom/Position.h:
              * dom/ProcessingInstruction.h:
              * dom/Range.h:
              * dom/StyleElement.h:
              * dom/Text.h:
              * editing/AppendNodeCommand.h:
              * editing/ApplyStyleCommand.h:
              * editing/BreakBlockquoteCommand.h:
              * editing/CommandByName.h:
              * editing/CompositeEditCommand.h:
              * editing/DeleteButton.h:
              * editing/DeleteButtonController.h:
              * editing/DeleteFromTextNodeCommand.h:
              * editing/DeleteSelectionCommand.h:
              * editing/InsertIntoTextNodeCommand.h:
              * editing/InsertLineBreakCommand.h:
              * editing/InsertNodeBeforeCommand.h:
              * editing/InsertParagraphSeparatorCommand.h:
              * editing/InsertTextCommand.h:
              * editing/JoinTextNodesCommand.h:
              * editing/MergeIdenticalElementsCommand.h:
              * editing/ModifySelectionListLevel.h:
              * editing/MoveSelectionCommand.h:
              * editing/RemoveCSSPropertyCommand.h:
              * editing/RemoveNodeAttributeCommand.h:
              * editing/RemoveNodeCommand.h:
              * editing/RemoveNodePreservingChildrenCommand.h:
              * editing/ReplaceSelectionCommand.h:
              * editing/SetNodeAttributeCommand.h:
              * editing/SplitElementCommand.h:
              * editing/SplitTextNodeCommand.h:
              * editing/SplitTextNodeContainingElementCommand.h:
              * editing/TextGranularity.h:
              * editing/TypingCommand.h:
              * editing/WrapContentsInDummySpanCommand.h:
              * history/BackForwardList.h:
              * history/HistoryItem.h:
              * history/HistoryItemTimer.h:
              * history/PageCache.h:
              * html/CanvasGradient.h:
              * html/CanvasPattern.h:
              * html/CanvasRenderingContext2D.h:
              * html/CanvasStyle.h:
              * html/FormDataList.h:
              * html/HTMLAnchorElement.h:
              * html/HTMLAppletElement.h:
              * html/HTMLAreaElement.h:
              * html/HTMLBRElement.h:
              * html/HTMLBaseElement.h:
              * html/HTMLBaseFontElement.h:
              * html/HTMLBlockquoteElement.h:
              * html/HTMLBodyElement.h:
              * html/HTMLButtonElement.h:
              * html/HTMLCanvasElement.h:
              * html/HTMLCollection.h:
              * html/HTMLDListElement.h:
              * html/HTMLDirectoryElement.h:
              * html/HTMLDivElement.h:
              * html/HTMLElement.h:
              * html/HTMLElementFactory.h:
              * html/HTMLEmbedElement.h:
              * html/HTMLFieldSetElement.h:
              * html/HTMLFontElement.h:
              * html/HTMLFormCollection.h:
              * html/HTMLFormElement.h:
              * html/HTMLFrameSetElement.h:
              * html/HTMLGenericFormElement.h:
              * html/HTMLHRElement.h:
              * html/HTMLHeadElement.h:
              * html/HTMLHeadingElement.h:
              * html/HTMLHtmlElement.h:
              * html/HTMLImageElement.h:
              * html/HTMLImageLoader.h:
              * html/HTMLInputElement.h:
              * html/HTMLIsIndexElement.h:
              * html/HTMLKeygenElement.h:
              * html/HTMLLIElement.h:
              * html/HTMLLabelElement.h:
              * html/HTMLLegendElement.h:
              * html/HTMLLinkElement.h:
              * html/HTMLMapElement.h:
              * html/HTMLMarqueeElement.h:
              * html/HTMLMenuElement.h:
              * html/HTMLMetaElement.h:
              * html/HTMLModElement.h:
              * html/HTMLNameCollection.h:
              * html/HTMLOListElement.h:
              * html/HTMLObjectElement.h:
              * html/HTMLOptGroupElement.h:
              * html/HTMLOptionElement.h:
              * html/HTMLOptionsCollection.h:
              * html/HTMLParagraphElement.h:
              * html/HTMLParamElement.h:
              * html/HTMLParser.h:
              * html/HTMLPlugInElement.h:
              * html/HTMLPreElement.h:
              * html/HTMLQuoteElement.h:
              * html/HTMLScriptElement.h:
              * html/HTMLSelectElement.h:
              * html/HTMLStyleElement.h:
              * html/HTMLTableCaptionElement.h:
              * html/HTMLTableCellElement.h:
              * html/HTMLTableColElement.h:
              * html/HTMLTableElement.h:
              * html/HTMLTablePartElement.h:
              * html/HTMLTableRowElement.h:
              * html/HTMLTableSectionElement.h:
              * html/HTMLTextAreaElement.h:
              * html/HTMLTextFieldInnerElement.h:
              * html/HTMLTitleElement.h:
              * html/HTMLUListElement.h:
              * ksvg2/css/SVGRenderStyle.h:
              * ksvg2/css/SVGRenderStyleDefs.h:
              * ksvg2/events/JSSVGLazyEventListener.h:
              * ksvg2/events/SVGZoomEvent.h:
              * ksvg2/misc/KCanvasRenderingStyle.h:
              * ksvg2/misc/PointerEventsHitRules.h:
              * ksvg2/misc/SVGDocumentExtensions.h:
              * ksvg2/misc/SVGImageLoader.h:
              * ksvg2/misc/TimeScheduler.h:
              * ksvg2/svg/GradientAttributes.h:
              * ksvg2/svg/LinearGradientAttributes.h:
              * ksvg2/svg/PatternAttributes.h:
              * ksvg2/svg/RadialGradientAttributes.h:
              * ksvg2/svg/SVGAElement.h:
              * ksvg2/svg/SVGAngle.h:
              * ksvg2/svg/SVGAnimateColorElement.h:
              * ksvg2/svg/SVGAnimateElement.h:
              * ksvg2/svg/SVGAnimateMotionElement.h:
              * ksvg2/svg/SVGAnimateTransformElement.h:
              * ksvg2/svg/SVGAnimatedPathData.h:
              * ksvg2/svg/SVGAnimatedPoints.h:
              * ksvg2/svg/SVGAnimatedTemplate.h:
              * ksvg2/svg/SVGAnimationElement.h:
              * ksvg2/svg/SVGCircleElement.h:
              * ksvg2/svg/SVGClipPathElement.h:
              * ksvg2/svg/SVGColor.h:
              * ksvg2/svg/SVGComponentTransferFunctionElement.h:
              * ksvg2/svg/SVGCursorElement.h:
              * ksvg2/svg/SVGDOMImplementation.h:
              * ksvg2/svg/SVGDefsElement.h:
              * ksvg2/svg/SVGDescElement.h:
              * ksvg2/svg/SVGDocument.h:
              * ksvg2/svg/SVGElement.h:
              * ksvg2/svg/SVGElementInstance.h:
              * ksvg2/svg/SVGElementInstanceList.h:
              * ksvg2/svg/SVGEllipseElement.h:
              * ksvg2/svg/SVGExternalResourcesRequired.h:
              * ksvg2/svg/SVGFEBlendElement.h:
              * ksvg2/svg/SVGFEColorMatrixElement.h:
              * ksvg2/svg/SVGFEComponentTransferElement.h:
              * ksvg2/svg/SVGFECompositeElement.h:
              * ksvg2/svg/SVGFEDiffuseLightingElement.h:
              * ksvg2/svg/SVGFEDisplacementMapElement.h:
              * ksvg2/svg/SVGFEDistantLightElement.h:
              * ksvg2/svg/SVGFEFloodElement.h:
              * ksvg2/svg/SVGFEFuncAElement.h:
              * ksvg2/svg/SVGFEFuncBElement.h:
              * ksvg2/svg/SVGFEFuncGElement.h:
              * ksvg2/svg/SVGFEFuncRElement.h:
              * ksvg2/svg/SVGFEGaussianBlurElement.h:
              * ksvg2/svg/SVGFEImageElement.h:
              * ksvg2/svg/SVGFELightElement.h:
              * ksvg2/svg/SVGFEMergeElement.h:
              * ksvg2/svg/SVGFEMergeNodeElement.h:
              * ksvg2/svg/SVGFEOffsetElement.h:
              * ksvg2/svg/SVGFEPointLightElement.h:
              * ksvg2/svg/SVGFESpecularLightingElement.h:
              * ksvg2/svg/SVGFESpotLightElement.h:
              * ksvg2/svg/SVGFETileElement.h:
              * ksvg2/svg/SVGFETurbulenceElement.h:
              * ksvg2/svg/SVGFilterElement.h:
              * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
              * ksvg2/svg/SVGFitToViewBox.h:
              * ksvg2/svg/SVGForeignObjectElement.h:
              * ksvg2/svg/SVGGElement.h:
              * ksvg2/svg/SVGGradientElement.h:
              * ksvg2/svg/SVGImageElement.h:
              * ksvg2/svg/SVGLangSpace.h:
              * ksvg2/svg/SVGLength.h:
              * ksvg2/svg/SVGLengthList.h:
              * ksvg2/svg/SVGLineElement.h:
              * ksvg2/svg/SVGLinearGradientElement.h:
              * ksvg2/svg/SVGList.h:
              * ksvg2/svg/SVGListTraits.h:
              * ksvg2/svg/SVGLocatable.h:
              * ksvg2/svg/SVGMarkerElement.h:
              * ksvg2/svg/SVGMaskElement.h:
              * ksvg2/svg/SVGMetadataElement.h:
              * ksvg2/svg/SVGNumberList.h:
              * ksvg2/svg/SVGPaint.h:
              * ksvg2/svg/SVGParserUtilities.h:
              * ksvg2/svg/SVGPathElement.h:
              * ksvg2/svg/SVGPathSeg.h:
              * ksvg2/svg/SVGPathSegArc.h:
              * ksvg2/svg/SVGPathSegClosePath.h:
              * ksvg2/svg/SVGPathSegCurvetoCubic.h:
              * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
              * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
              * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
              * ksvg2/svg/SVGPathSegLineto.h:
              * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
              * ksvg2/svg/SVGPathSegLinetoVertical.h:
              * ksvg2/svg/SVGPathSegList.h:
              * ksvg2/svg/SVGPathSegMoveto.h:
              * ksvg2/svg/SVGPatternElement.h:
              * ksvg2/svg/SVGPointList.h:
              * ksvg2/svg/SVGPolyElement.h:
              * ksvg2/svg/SVGPolygonElement.h:
              * ksvg2/svg/SVGPolylineElement.h:
              * ksvg2/svg/SVGPreserveAspectRatio.h:
              * ksvg2/svg/SVGRadialGradientElement.h:
              * ksvg2/svg/SVGRectElement.h:
              * ksvg2/svg/SVGRenderingIntent.h:
              * ksvg2/svg/SVGSVGElement.h:
              * ksvg2/svg/SVGScriptElement.h:
              * ksvg2/svg/SVGSetElement.h:
              * ksvg2/svg/SVGStopElement.h:
              * ksvg2/svg/SVGStringList.h:
              * ksvg2/svg/SVGStylable.h:
              * ksvg2/svg/SVGStyleElement.h:
              * ksvg2/svg/SVGStyledElement.h:
              * ksvg2/svg/SVGStyledLocatableElement.h:
              * ksvg2/svg/SVGStyledTransformableElement.h:
              * ksvg2/svg/SVGSwitchElement.h:
              * ksvg2/svg/SVGSymbolElement.h:
              * ksvg2/svg/SVGTRefElement.h:
              * ksvg2/svg/SVGTSpanElement.h:
              * ksvg2/svg/SVGTests.h:
              * ksvg2/svg/SVGTextContentElement.h:
              * ksvg2/svg/SVGTextElement.h:
              * ksvg2/svg/SVGTextPositioningElement.h:
              * ksvg2/svg/SVGTitleElement.h:
              * ksvg2/svg/SVGTransform.h:
              * ksvg2/svg/SVGTransformList.h:
              * ksvg2/svg/SVGTransformable.h:
              * ksvg2/svg/SVGURIReference.h:
              * ksvg2/svg/SVGUnitTypes.h:
              * ksvg2/svg/SVGUseElement.h:
              * ksvg2/svg/SVGViewElement.h:
              * ksvg2/svg/SVGZoomAndPan.h:
              * loader/CachedCSSStyleSheet.h:
              * loader/CachedImage.h:
              * loader/CachedXSLStyleSheet.h:
              * loader/DocumentLoader.h:
              * loader/Request.h:
              * loader/SubresourceLoader.h:
              * loader/icon/IconDataCache.h:
              * loader/icon/IconDatabase.h:
              * loader/icon/IconLoader.h:
              * loader/icon/SQLDatabase.h:
              * loader/icon/SQLStatement.h:
              * loader/icon/SQLTransaction.h:
              * page/Frame.h:
              * page/FrameLoadRequest.h:
              * page/FrameTree.h:
              * page/FrameView.h:
              * page/PageState.h:
              * page/Plugin.h:
              * page/qt/FrameQt.h:
              * page/qt/FrameQtClient.h:
              * platform/Arena.h:
              * platform/ArrayImpl.h:
              * platform/Cursor.h:
              * platform/DeprecatedArray.h:
              * platform/DeprecatedCString.h:
              * platform/FileChooser.h:
              * platform/Font.h:
              * platform/FontCache.h:
              * platform/FontData.h:
              * platform/FontDescription.h:
              * platform/FontFamily.h:
              * platform/GlyphBuffer.h:
              * platform/GlyphMap.h:
              * platform/GlyphWidthMap.h:
              * platform/Logging.h:
              * platform/Pasteboard.h:
              * platform/PlatformString.h:
              * platform/PlugInInfoStore.h:
              * platform/PopupMenu.h:
              * platform/PopupMenuClient.h:
              * platform/ScrollBar.h:
              * platform/ScrollView.h:
              * platform/SearchPopupMenu.h:
              * platform/Shared.h:
              * platform/Sound.h:
              * platform/SystemTime.h:
              * platform/Timer.h:
              * platform/Widget.h:
              * platform/cf/RetainPtr.h:
              * platform/gdk/ChromeClientGdk.h:
              * platform/gdk/FontPlatformData.h:
              * platform/gdk/FrameGdk.h:
              * platform/gdk/KeyboardCodes.h:
              * platform/gdk/RenderPopupMenuGdk.h:
              * platform/gdk/RenderThemeGdk.h:
              * platform/graphics/BitmapImage.h:
              * platform/graphics/Color.h:
              * platform/graphics/FloatPoint.h:
              * platform/graphics/FloatPoint3D.h:
              * platform/graphics/FloatRect.h:
              * platform/graphics/Icon.h:
              * platform/graphics/Image.h:
              * platform/graphics/ImageAnimationObserver.h:
              * platform/graphics/ImageBuffer.h:
              * platform/graphics/ImageSource.h:
              * platform/graphics/IntPoint.h:
              * platform/graphics/IntRect.h:
              * platform/graphics/IntSize.h:
              * platform/graphics/IntSizeHash.h:
              * platform/graphics/PathTraversalState.h:
              * platform/graphics/Pen.h:
              * platform/graphics/qt/ImageDecoderQt.h:
              * platform/graphics/svg/SVGImage.h:
              * platform/graphics/svg/SVGImageEmptyClients.h:
              * platform/graphics/svg/SVGPaintServer.h:
              * platform/graphics/svg/SVGPaintServerGradient.h:
              * platform/graphics/svg/SVGPaintServerLinearGradient.h:
              * platform/graphics/svg/SVGPaintServerPattern.h:
              * platform/graphics/svg/SVGPaintServerRadialGradient.h:
              * platform/graphics/svg/SVGPaintServerSolid.h:
              * platform/graphics/svg/SVGResource.h:
              * platform/graphics/svg/SVGResourceClipper.h:
              * platform/graphics/svg/SVGResourceFilter.h:
              * platform/graphics/svg/SVGResourceMarker.h:
              * platform/graphics/svg/SVGResourceMasker.h:
              * platform/graphics/svg/cg/CgSupport.h:
              * platform/graphics/svg/filters/SVGDistantLightSource.h:
              * platform/graphics/svg/filters/SVGFEBlend.h:
              * platform/graphics/svg/filters/SVGFEColorMatrix.h:
              * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
              * platform/graphics/svg/filters/SVGFEComposite.h:
              * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
              * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
              * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
              * platform/graphics/svg/filters/SVGFEFlood.h:
              * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
              * platform/graphics/svg/filters/SVGFEImage.h:
              * platform/graphics/svg/filters/SVGFEMerge.h:
              * platform/graphics/svg/filters/SVGFEMorphology.h:
              * platform/graphics/svg/filters/SVGFEOffset.h:
              * platform/graphics/svg/filters/SVGFESpecularLighting.h:
              * platform/graphics/svg/filters/SVGFETile.h:
              * platform/graphics/svg/filters/SVGFETurbulence.h:
              * platform/graphics/svg/filters/SVGFilterEffect.h:
              * platform/graphics/svg/filters/SVGLightSource.h:
              * platform/graphics/svg/filters/SVGPointLightSource.h:
              * platform/graphics/svg/filters/SVGSpotLightSource.h:
              * platform/mac/FontPlatformData.h:
              * platform/mac/PlatformScrollBar.h:
              * platform/network/AuthenticationChallenge.h:
              * platform/network/Credential.h:
              * platform/network/HTTPHeaderMap.h:
              * platform/network/ProtectionSpace.h:
              * platform/network/ResourceError.h:
              * platform/network/ResourceRequest.h:
              * platform/network/ResourceResponse.h:
              * platform/network/cf/FormDataStreamCFNet.h:
              * platform/network/cf/ResourceRequestCFNet.h:
              * platform/network/cf/ResourceResponseCFNet.h:
              * platform/network/gdk/ResourceHandleManager.h:
              * platform/network/mac/AuthenticationMac.h:
              * platform/network/mac/FormDataStreamMac.h:
              * platform/network/qt/ResourceHandleManagerKDE.h:
              * platform/network/qt/ResourceHandleManagerQt.h:
              * platform/network/win/ResourceHandleWin.h:
              * platform/qt/FontPlatformData.h:
              * platform/qt/KeyboardCodes.h:
              * platform/qt/PlatformScrollBar.h:
              * platform/qt/ScrollViewCanvasQt.h:
              * platform/qt/SharedTimerQt.h:
              * platform/win/FontPlatformData.h:
              * platform/win/PlatformScrollBar.h:
              * rendering/AutoTableLayout.h:
              * rendering/HitTestRequest.h:
              * rendering/HitTestResult.h:
              * rendering/InlineBox.h:
              * rendering/InlineFlowBox.h:
              * rendering/Length.h:
              * rendering/ListMarkerBox.h:
              * rendering/RenderBox.h:
              * rendering/RenderMenuList.h:
              * rendering/RenderPart.h:
              * rendering/RenderPartObject.h:
              * rendering/RenderPath.h:
              * rendering/RenderReplaced.h:
              * rendering/RenderSVGContainer.h:
              * rendering/RenderSVGImage.h:
              * rendering/RenderSVGInline.h:
              * rendering/RenderSVGInlineText.h:
              * rendering/RenderSVGTSpan.h:
              * rendering/RenderSVGText.h:
              * rendering/RenderStyle.h:
              * rendering/RenderTableCol.h:
              * rendering/RenderThemeWin.h:
              * rendering/bidi.h:
              * xml/DOMParser.h:
              * xml/XPathEvaluator.h:
              * xml/XPathExpression.h:
              * xml/XPathExpressionNode.h:
              * xml/XPathFunctions.h:
              * xml/XPathNSResolver.h:
              * xml/XPathNamespace.h:
              * xml/XPathParser.h:
              * xml/XPathPath.h:
              * xml/XPathPredicate.h:
              * xml/XPathResult.h:
              * xml/XPathStep.h:
              * xml/XPathUtil.h:
              * xml/XPathValue.h:
              * xml/XPathVariableReference.h:
              * xml/XSLImportRule.h:
              * xml/XSLStyleSheet.h:
              * xml/XSLTProcessor.h:
              * xml/xmlhttprequest.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8eddecf9
  20. 14 Dec, 2006 1 commit
    • justing's avatar
      LayoutTests: · 53f27743
      justing authored
              Reviewed by harrison
      
              <rdar://problem/4866671>
              CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()
      
              * editing/deleting/4866671-expected.checksum: Added.
              * editing/deleting/4866671-expected.png: Added.
              * editing/deleting/4866671-expected.txt: Added.
              * editing/deleting/4866671.html: Added.
              * editing/pasteboard/4866671-expected.checksum: Added.
              * editing/pasteboard/4866671-expected.png: Added.
              * editing/pasteboard/4866671-expected.txt: Added.
              * editing/pasteboard/4866671.html: Added.
      
      WebCore:
      
              Reviewed by harrison
      
              <rdar://problem/4866671>
              CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()
              
              Don't allow VisiblePositions inside -webkit-user-select:none regions.
              Renamed inRenderedContent to isCandidate.
      
              * dom/Document.cpp:
              (WebCore::Document::updateSelection):
              * dom/Position.cpp:
              (WebCore::Position::previousCharacterPosition):
              (WebCore::Position::nextCharacterPosition):
              (WebCore::nodeIsUserSelectNone):
              (WebCore::Position::isCandidate):
              (WebCore::Position::rendersInDifferentPosition):
              * dom/Position.h:
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::input):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::canonicalPosition):
              * editing/htmlediting.cpp:
              (WebCore::nextCandidate):
              (WebCore::nextVisuallyDistinctCandidate):
              (WebCore::previousCandidate):
              (WebCore::previousVisuallyDistinctCandidate):
              * editing/visible_units.cpp:
              (WebCore::previousLinePosition):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              * page/Frame.cpp:
              (WebCore::Frame::styleForSelectionStart):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53f27743
  21. 30 Nov, 2006 1 commit
    • sullivan's avatar
      LayoutTests: · 9413c17c
      sullivan authored
              Reviewed by Justin
      
              * editing/execCommand/create-list-from-range-selection-expected.checksum:
              * editing/execCommand/create-list-from-range-selection-expected.png:
              * editing/execCommand/create-list-from-range-selection-expected.txt:
              * editing/execCommand/create-list-from-range-selection.html:
              This test's results were broken by using rangeCompliantEquivalent at
              appropriate places in CompositeEditCommand.cpp::moveParagraphs(), presumably
              by revealing a different bug. Justin is going to look into this; for now I've
              updated the result so that it won't appear to fail for others.
              
              * editing/execCommand/create-list-with-hr-expected.checksum:
              * editing/execCommand/create-list-with-hr-expected.png:
              * editing/execCommand/create-list-with-hr-expected.txt:
              * editing/execCommand/create-list-with-hr.html:
              This test's results were improved by using rangeCompliantEquivalent at
              appropriate places in CompositeEditCommand.cpp::moveParagraphs() -- it used
              to create an extra <div>, and now it does not.
      
      WebCore:
      
              Reviewed by Justin
      
              With Darin, fixed a problem in the Range constructors found while implementing grammar checking.
              That revealed another problem in the layout tests involving bad parameters passed to the Range
              constructors.
              
              With these fixes in place, one layout test (editing/execCommand/create-list-from-range-selection.html)
              no longer works as intended. This is apparently due to yet another bug being flushed out somewhere.
              I'm going to update the results for that test and file a separate radar about it, which Justin will
              investigate.
      
              * dom/Position.h:
              removed equivalentRangeCompliantPosition(), which was declared but not implemented or called.
              
              * dom/Range.cpp:
              (WebCore::Range::Range):
              Call setStart and setEnd in the two Range constructors that take parameters, rather than just 
              directly setting the instance variables. This makes Range perform the boundary checks and
              compensations that the DOM spec requires.
              
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs):
              Use rangeCompliantEquivalent() on "editing-style" Positions before creating Ranges from them.
              
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::TextIterator):
              Assert that the boundary points of the range are valid.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9413c17c
  22. 09 Jul, 2006 1 commit
    • darin's avatar
      Reviewed by Tim Hatcher. · f4b05b29
      darin authored
              - put more into the WebCore namespace
              - removed unused code for plain text fields
      
              Put more classes, class templates, enums, functions, and constants into
              the WebCore namespace, including all the headers in the platform directory.
      
              Removed lots of unneeded "WebCore::" qualifiers and "using" directives.
      
              Added some "WebCore::" qualifiers in a few places.
      
              Removed "uses WebCore::" in headers that we said we'd remove "when
              everything is in the WebCore namespace".
      
              * bindings/js/JSDOMParser.cpp:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/JSXSLTProcessor.cpp:
              * bindings/js/kjs_binding.cpp:
              * bindings/js/kjs_css.cpp:
              * bindings/js/kjs_dom.cpp:
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_events.cpp:
              * bindings/js/kjs_proxy.h:
              * bindings/js/kjs_window.h:
              * bindings/objc/DOM.mm:
              * bridge/History.h:
              * bridge/JavaAppletWidget.h:
              * bridge/mac/FormDataMac.h:
              * bridge/mac/FormDataMac.mm:
              * bridge/mac/WebCoreAXObject.mm:
              * bridge/mac/WebCoreEncodings.mm:
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreIconDatabaseBridge.mm:
              * bridge/mac/WebCorePageState.h:
              * bridge/mac/WebCoreScriptDebugger.mm:
              * bridge/mac/WebCoreSettings.h:
              * css/CSSGrammar.y:
              * css/CSSPageRule.cpp:
              * css/CSSPageRule.h:
              * css/MediaList.cpp:
              * css/cssstyleselector.h:
              * dom/Clipboard.h:
              * dom/Document.cpp:
              * dom/Document.h:
              * dom/EventTargetNode.h:
              * dom/Node.cpp:
              * dom/Node.h:
              * dom/Position.h:
              * dom/Range.cpp:
              * dom/XMLTokenizer.cpp:
              * editing/AppendNodeCommand.h:
              * editing/ApplyStyleCommand.cpp:
              * editing/BreakBlockquoteCommand.cpp:
              * editing/BreakBlockquoteCommand.h:
              * editing/CompositeEditCommand.cpp:
              * editing/CompositeEditCommand.h:
              * editing/CreateLinkCommand.h:
              * editing/DeleteFromTextNodeCommand.h:
              * editing/DeleteSelectionCommand.h:
              * editing/FormatBlockCommand.h:
              * editing/HTMLInterchange.cpp:
              * editing/HTMLInterchange.h:
              * editing/IndentOutdentCommand.h:
              * editing/InsertIntoTextNodeCommand.h:
              * editing/InsertLineBreakCommand.h:
              * editing/InsertListCommand.h:
              * editing/InsertNodeBeforeCommand.h:
              * editing/InsertTextCommand.cpp:
              * editing/InsertTextCommand.h:
              * editing/JSEditor.cpp:
              * editing/JSEditor.h:
              * editing/JoinTextNodesCommand.h:
              * editing/MergeIdenticalElementsCommand.cpp:
              * editing/MergeIdenticalElementsCommand.h:
              * editing/ModifySelectionListLevel.h:
              * editing/MoveSelectionCommand.h:
              * editing/RebalanceWhitespaceCommand.h:
              * editing/RemoveNodeAttributeCommand.h:
              * editing/RemoveNodeCommand.h:
              * editing/RemoveNodePreservingChildrenCommand.h:
              * editing/ReplaceSelectionCommand.h:
              * editing/SetNodeAttributeCommand.h:
              * editing/SplitElementCommand.cpp:
              * editing/SplitElementCommand.h:
              * editing/SplitTextNodeCommand.cpp:
              * editing/SplitTextNodeCommand.h:
              * editing/SplitTextNodeContainingElementCommand.h:
              * editing/TypingCommand.cpp:
              * editing/TypingCommand.h:
              * editing/UnlinkCommand.h:
              * editing/VisiblePosition.cpp:
              * editing/WrapContentsInDummySpanCommand.cpp:
              * editing/WrapContentsInDummySpanCommand.h:
              * editing/markup.cpp:
              * editing/markup.h:
              * html/HTMLAnchorElement.cpp:
              * html/HTMLBodyElement.cpp:
              * html/HTMLButtonElement.h:
              * html/HTMLCollection.h:
              * html/HTMLDocument.h:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLFormElement.cpp:
              * html/HTMLFormElement.h:
              * html/HTMLFrameElement.cpp:
              * html/HTMLFrameSetElement.cpp:
              * html/HTMLKeygenElement.cpp:
              * html/HTMLLabelElement.cpp:
              * html/HTMLObjectElement.cpp:
              * html/HTMLObjectElement.h:
              * html/HTMLTableElement.cpp:
              * html/HTMLTablePartElement.cpp:
              * icon/IconDatabase.h:
              * kcanvas/KCanvasPath.h:
              * kcanvas/KCanvasResources.cpp:
              * kcanvas/KCanvasResources.h:
              * kcanvas/KCanvasTreeDebug.cpp:
              * kcanvas/KCanvasTreeDebug.h:
              * kcanvas/RenderSVGContainer.cpp:
              * kcanvas/RenderSVGText.h:
              * kcanvas/device/KRenderingPaintServer.h:
              * kcanvas/device/KRenderingPaintServerGradient.h:
              * kcanvas/device/KRenderingPaintServerSolid.cpp:
              * ksvg2/misc/SVGImageLoader.cpp:
              * ksvg2/svg/SVGElement.cpp:
              * ksvg2/svg/SVGElement.h:
              * ksvg2/svg/SVGForeignObjectElement.cpp:
              * ksvg2/svg/SVGForeignObjectElement.h:
              * ksvg2/svg/SVGImageElement.cpp:
              * ksvg2/svg/SVGPoint.h:
              * ksvg2/svg/SVGStylable.h:
              * ksvg2/svg/SVGTRefElement.cpp:
              * ksvg2/svg/SVGTRefElement.h:
              * ksvg2/svg/SVGTSpanElement.cpp:
              * ksvg2/svg/SVGTSpanElement.h:
              * ksvg2/svg/SVGTextElement.h:
              * ksvg2/svg/svgpathparser.cpp:
              * ksvg2/svg/svgpathparser.h:
              * loader/Cache.h:
              * loader/DocLoader.h:
              * loader/LoaderFunctions.h:
              * loader/mac/LoaderFunctionsMac.mm:
              * page/Frame.h:
              * page/FrameView.h:
              * page/Page.h:
              * page/Settings.h:
              * platform/AffineTransform.cpp:
              * platform/AffineTransform.h:
              * platform/Arena.cpp:
              * platform/Arena.h:
              * platform/CookieJar.h:
              * platform/DeprecatedCString.cpp:
              * platform/DeprecatedCString.h:
              * platform/DeprecatedPtrList.h:
              * platform/DeprecatedPtrListImpl.cpp:
              * platform/DeprecatedPtrListImpl.h:
              * platform/DeprecatedPtrQueue.h:
              * platform/DeprecatedString.cpp:
              * platform/DeprecatedString.h:
              * platform/DeprecatedStringList.cpp:
              * platform/DeprecatedStringList.h:
              * platform/DeprecatedValueList.h:
              * platform/DeprecatedValueListImpl.cpp:
              * platform/DeprecatedValueListImpl.h:
              * platform/FileButton.h:
              * platform/FloatPoint.h:
              * platform/FloatRect.h:
              * platform/FloatSize.h:
              * platform/FontData.h:
              * platform/FontFallbackList.h:
              * platform/GraphicsContext.h:
              * platform/IntPoint.h:
              * platform/IntRect.h:
              * platform/IntSize.h:
              * platform/KURL.cpp:
              * platform/KURL.h:
              * platform/ListBox.h:
              * platform/Logging.cpp:
              * platform/Logging.h:
              * platform/Pen.h:
              * platform/PopUpButton.h:
              * platform/RegularExpression.cpp:
              * platform/RegularExpression.h:
              * platform/SSLKeyGenerator.h:
              * platform/ScrollBar.h:
              * platform/SegmentedString.h:
              * platform/Shared.h:
              * platform/Slider.h:
              * platform/StringImpl.h:
              * platform/TextBox.h:
              * platform/TextField.h:
              * platform/TextStream.cpp:
              * platform/TextStream.h:
              * platform/TransferJob.h:
              * platform/TransferJobClient.h:
              * platform/Widget.h:
              * platform/cg/AffineTransformCG.cpp:
              * platform/mac/ClipboardMac.h:
              * platform/mac/ClipboardMac.mm:
              * platform/mac/DeprecatedStringListMac.mm:
              * platform/mac/FontCacheMac.mm:
              * platform/mac/KURLMac.mm:
              * platform/mac/ListBoxMac.mm:
              * platform/mac/PopUpButtonMac.mm:
              * platform/mac/SSLKeyGeneratorMac.mm:
              * platform/mac/TextBoxMac.mm:
              * platform/mac/TextFieldMac.mm:
              * platform/mac/WebCoreTextArea.h:
              * platform/mac/WebCoreTextArea.mm:
              * platform/mac/WebCoreTextField.h:
              * platform/mac/WebCoreTextField.mm:
              * rendering/DeprecatedRenderSelect.h:
              * rendering/RenderArena.cpp:
              * rendering/RenderArena.h:
              * rendering/RenderBlock.cpp:
              * rendering/RenderBox.cpp:
              * rendering/RenderContainer.cpp:
              * rendering/RenderFlexibleBox.cpp:
              * rendering/RenderFlow.cpp:
              * rendering/RenderLayer.cpp:
              * rendering/RenderLineEdit.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderStyle.cpp:
              * rendering/RenderStyle.h:
              * rendering/RenderText.cpp:
              * rendering/RenderTextFragment.cpp:
              * rendering/RenderTheme.h:
              * rendering/RenderTreeAsText.cpp:
              * rendering/RenderTreeAsText.h:
              * rendering/RenderView.h:
              * rendering/bidi.h:
              * xml/XSLStyleSheet.cpp:
              * xml/XSLTProcessor.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4b05b29
  23. 11 Apr, 2006 1 commit
    • darin's avatar
      JavaScriptCore: · 36d1136a
      darin authored
              Rubber-stamped by John Sullivan.
      
              - switched from a shell script to a makefile for generated files
              - removed lots of unneeded includes
              - added new Forward.h and HashForward.h headers that allow compiling with
                fewer unneeded templates
      
              * DerivedSources.make: Added.
              * generate-derived-sources: Removed.
              * JavaScriptCore.xcodeproj/project.pbxproj: Added new files, changed to use
              DerivedSources.make.
      
              * kxmlcore/Forward.h: Added.
              * kxmlcore/HashForward.h: Added.
      
              * kxmlcore/HashCountedSet.h: Include HashForward for default args.
              * kxmlcore/HashMap.h: Ditto.
              * kxmlcore/HashSet.h: Ditto.
      
              * kjs/object.h:
              * kjs/object.cpp:
              Moved KJS_MAX_STACK into the .cpp file.
      
              * bindings/NP_jsobject.cpp:
              * bindings/c/c_instance.h:
              * bindings/jni/jni_class.h:
              * bindings/jni/jni_runtime.h:
              * bindings/jni/jni_utility.h:
              * bindings/objc/WebScriptObject.mm:
              * bindings/objc/WebScriptObjectPrivate.h:
              * bindings/objc/objc_class.h:
              * bindings/objc/objc_class.mm:
              * bindings/objc/objc_instance.h:
              * bindings/objc/objc_instance.mm:
              * bindings/objc/objc_runtime.mm:
              * bindings/objc/objc_utility.mm:
              * bindings/runtime.h:
              * bindings/runtime_array.cpp:
              * bindings/runtime_array.h:
              * bindings/runtime_method.cpp:
              * bindings/runtime_method.h:
              * bindings/runtime_object.cpp:
              * bindings/runtime_root.h:
              * kjs/JSImmediate.cpp:
              * kjs/Parser.h:
              * kjs/array_object.cpp:
              * kjs/array_object.h:
              * kjs/bool_object.cpp:
              * kjs/bool_object.h:
              * kjs/collector.h:
              * kjs/context.h:
              * kjs/debugger.cpp:
              * kjs/error_object.h:
              * kjs/function_object.h:
              * kjs/internal.h:
              * kjs/lexer.cpp:
              * kjs/math_object.cpp:
              * kjs/math_object.h:
              * kjs/nodes.cpp:
              * kjs/nodes.h:
              * kjs/number_object.cpp:
              * kjs/number_object.h:
              * kjs/object_object.cpp:
              * kjs/operations.cpp:
              * kjs/protected_reference.h:
              * kjs/reference.h:
              * kjs/reference_list.h:
              * kjs/regexp_object.h:
              * kjs/string_object.cpp:
              * kjs/string_object.h:
              * kjs/testkjs.cpp:
              * kjs/value.cpp:
              * kjs/value.h:
              * kxmlcore/HashTable.h:
              * kxmlcore/ListRefPtr.h:
              * kxmlcore/TCPageMap.h:
              * kxmlcore/Vector.h:
              Removed unneeded header includes.
      
      JavaScriptGlue:
      
              Rubber-stamped by John Sullivan.
      
              - added forwarding headers for the new Forward.h and HashForward.h files
      
              * kxmlcore/Forward.h: Added.
              * kxmlcore/HashForward.h: Added.
      
      WebCore:
      
              Rubber-stamped by John Sullivan (except for pbxproj change).
      
              - updated to use the new Forward.h and HashForward.h headers
              - moved the showTree debugging functions out of the WebCore
                namespace so they are easier to call from gdb, and renamed
                the showTree member functions so they don't get in the way;
                now you can do "call showTree(x)" in gdb and it just works
              - removed a lot of unneeded includes
      
              * WebCore.xcodeproj/project.pbxproj: Fixed a lot of paths that
              were not relative to the enclosing group.
      
              * ForwardingHeaders/kxmlcore/Forward.h: Added.
              * ForwardingHeaders/kxmlcore/HashForward.h: Added.
              * bindings/js/JSCanvasRenderingContext2DBase.cpp:
              * bindings/js/JSXMLHttpRequest.cpp:
              * bindings/js/JSXMLHttpRequest.h:
              * bindings/js/JSXSLTProcessor.h:
              * bindings/js/kjs_binding.h:
              * bindings/js/kjs_dom.cpp:
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_events.cpp:
              * bindings/js/kjs_events.h:
              * bindings/js/kjs_html.cpp:
              * bindings/js/kjs_navigator.cpp:
              * bindings/js/kjs_navigator.h:
              * bindings/js/kjs_proxy.cpp:
              * bindings/js/kjs_traversal.h:
              * bindings/js/kjs_window.cpp:
              * bindings/js/kjs_window.h:
              * bindings/objc/DOM.mm:
              * bindings/objc/DOMCSS.mm:
              * bindings/objc/DOMCore.h:
              * bindings/objc/DOMEvents.mm:
              * bindings/objc/DOMHTML.mm:
              * bindings/objc/DOMImplementationFront.h:
              * bindings/objc/DOMInternal.mm:
              * bindings/objc/DOMUtility.mm:
              * bindings/objc/DOMViews.mm:
              * bridge/BrowserExtension.h:
              * bridge/mac/BrowserExtensionMac.mm:
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              * bridge/mac/WebCoreFrameBridge.mm:
              * bridge/mac/WebCoreFrameNamespaces.mm:
              * bridge/mac/WebCoreJavaScript.mm:
              * bridge/win/PageWin.cpp:
              * css/CSSComputedStyleDeclaration.cpp:
              * css/css_base.h:
              * css/css_ruleimpl.h:
              * css/css_valueimpl.cpp:
              * css/cssparser.cpp:
              * css/cssparser.h:
              * css/cssstyleselector.cpp:
              * css/cssstyleselector.h:
              * dom/AbstractView.h:
              * dom/AtomicStringList.h:
              * dom/Attribute.cpp:
              * dom/Attribute.h:
              * dom/Comment.cpp:
              * dom/ContainerNode.cpp:
              * dom/DOMImplementation.cpp:
              * dom/DOMImplementation.h:
              * dom/Document.cpp:
              * dom/Document.h:
              * dom/Element.h:
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dump):
              (WebCore::forbidEventDispatch):
              (WebCore::allowEventDispatch):
              (WebCore::eventDispatchForbidden):
              * dom/EventTargetNode.h:
              (WebCore::EventTargetNode::postDispatchEventHandler):
              * dom/NamedAttrMap.h:
              * dom/Node.cpp:
              (WebCore::Node::showNode):
              (WebCore::Node::showTree):
              (WebCore::Node::showTreeAndMark):
              (showTree):
              * dom/Node.h:
              * dom/NodeList.cpp:
              * dom/NodeList.h:
              * dom/Position.cpp:
              (showTree):
              * dom/Position.h:
              * dom/Range.cpp:
              * dom/Range.h:
              * dom/StyledElement.cpp:
              * dom/StyledElement.h:
              * dom/dom2_eventsimpl.cpp:
              * dom/dom2_eventsimpl.h:
              * dom/dom2_traversalimpl.h:
              * dom/dom_xmlimpl.cpp:
              * dom/xml_tokenizer.cpp:
              * dom/xml_tokenizer.h:
              * editing/AppendNodeCommand.cpp:
              * editing/ApplyStyleCommand.cpp:
              * editing/ApplyStyleCommand.h:
              * editing/BreakBlockquoteCommand.cpp:
              * editing/CompositeEditCommand.cpp:
              * editing/CreateLinkCommand.cpp:
              * editing/DeleteFromTextNodeCommand.cpp:
              * editing/DeleteFromTextNodeCommand.h:
              * editing/DeleteSelectionCommand.cpp:
              * editing/EditCommand.cpp:
              * editing/EditCommand.h:
              * editing/HTMLInterchange.cpp:
              * editing/InsertIntoTextNodeCommand.cpp:
              * editing/InsertIntoTextNodeCommand.h:
              * editing/InsertLineBreakCommand.cpp:
              * editing/InsertNodeBeforeCommand.cpp:
              * editing/InsertParagraphSeparatorCommand.cpp:
              * editing/InsertTextCommand.cpp:
              * editing/JSEditor.cpp:
              * editing/JoinTextNodesCommand.cpp:
              * editing/MergeIdenticalElementsCommand.cpp:
              * editing/ModifySelectionListLevelCommand.cpp:
              * editing/MoveSelectionCommand.cpp:
              * editing/RebalanceWhitespaceCommand.h:
              * editing/RemoveCSSPropertyCommand.h:
              * editing/ReplaceSelectionCommand.cpp:
              * editing/ReplaceSelectionCommand.h:
              * editing/Selection.cpp:
              (WebCore::Selection::formatForDebugger):
              (WebCore::Selection::showTree):
              (showTree):
              * editing/Selection.h:
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::formatForDebugger):
              (WebCore::SelectionController::showTree):
              (showTree):
              * editing/SelectionController.h:
              * editing/TextIterator.cpp:
              * editing/TextIterator.h:
              * editing/TypingCommand.cpp:
              * editing/TypingCommand.h:
              * editing/UnlinkCommand.cpp:
              * editing/VisiblePosition.cpp:
              (WebCore::isEqualIgnoringAffinity):
              (WebCore::VisiblePosition::formatForDebugger):
              (WebCore::VisiblePosition::showTree):
              (showTree):
              * editing/VisiblePosition.h:
              (WebCore::VisiblePosition::VisiblePosition):
              (WebCore::operator==):
              * editing/WrapContentsInDummySpanCommand.cpp:
              * editing/htmlediting.h:
              * editing/markup.cpp:
              * editing/markup.h:
              (WebCore::):
              * editing/visible_units.cpp:
              * html/CanvasGradient.cpp:
              * html/CanvasRenderingContext2D.h:
              * html/CanvasStyle.cpp:
              * html/CanvasStyle.h:
              * html/FormDataList.cpp:
              * html/FormDataList.h:
              * html/HTMLCollection.cpp:
              * html/HTMLCollection.h:
              * html/HTMLDocument.cpp:
              * html/HTMLDocument.h:
              * html/HTMLElement.cpp:
              * html/HTMLElementFactory.cpp:
              * html/HTMLElementFactory.h:
              * html/HTMLFormCollection.cpp:
              * html/HTMLFormElement.cpp:
              * html/HTMLFormElement.h:
              * html/HTMLInputElement.cpp:
              * html/HTMLParser.cpp:
              * html/HTMLSelectElement.cpp:
              * html/HTMLSelectElement.h:
              * html/HTMLTokenizer.cpp:
              * html/HTMLTokenizer.h:
              * html/html_baseimpl.cpp:
              * html/html_headimpl.h:
              * kcanvas/KCanvasCreator.cpp:
              * kcanvas/KCanvasFilters.h:
              * kcanvas/KCanvasPath.h:
              * kcanvas/KCanvasResources.h:
              * kcanvas/KCanvasTreeDebug.cpp:
              * kcanvas/RenderPath.cpp:
              * kcanvas/RenderPath.h:
              * kcanvas/device/KRenderingDevice.h:
              * kcanvas/device/KRenderingPaintServerGradient.h:
              * kcanvas/device/KRenderingPaintServerPattern.h:
              * kcanvas/device/KRenderingPaintServerSolid.h:
              * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
              * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
              * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
              * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
              * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
              * khtml/misc/decoder.cpp:
              * khtml/misc/decoder.h:
              * khtml/xsl/XSLStyleSheet.cpp:
              * khtml/xsl/XSLTProcessor.cpp:
              * khtml/xsl/XSLTProcessor.h:
              * ksvg2/css/SVGRenderStyle.h:
              * ksvg2/ecma/GlobalObject.cpp:
              * ksvg2/misc/KCanvasRenderingStyle.h:
              * ksvg2/misc/SVGDocumentExtensions.h:
              * ksvg2/svg/SVGAngle.h:
              * ksvg2/svg/SVGAnimateColorElement.h:
              * ksvg2/svg/SVGAnimatedColor.h:
              * ksvg2/svg/SVGAnimatedLengthList.h:
              * ksvg2/svg/SVGAnimatedNumberList.h:
              * ksvg2/svg/SVGAnimatedString.h:
              * ksvg2/svg/SVGAnimatedTransformList.h:
              * ksvg2/svg/SVGAnimationElement.h:
              * ksvg2/svg/SVGColor.h:
              * ksvg2/svg/SVGCursorElement.h:
              * ksvg2/svg/SVGHelper.h:
              * ksvg2/svg/SVGLength.h:
              * ksvg2/svg/SVGList.h:
              * ksvg2/svg/SVGPaint.h:
              * ksvg2/svg/SVGPathSeg.h:
              * ksvg2/svg/SVGPatternElement.h:
              * ksvg2/svg/SVGSVGElement.cpp:
              * ksvg2/svg/SVGSVGElement.h:
              * ksvg2/svg/SVGStringList.h:
              * ksvg2/svg/SVGTransform.h:
              * kwq/AccessibilityObjectCache.mm:
              * kwq/ClipboardMac.mm:
              * kwq/JavaAppletWidget.mm:
              * kwq/KWQComboBox.mm:
              * kwq/KWQEditCommand.mm:
              * kwq/KWQFileButton.mm:
              * kwq/KWQKHTMLSettings.h:
              * kwq/KWQKSSLKeyGen.mm:
              * kwq/KWQLoader.mm:
              * kwq/KWQPageState.mm:
              * kwq/KWQTextEdit.mm:
              * kwq/RegularExpression.h:
              * kwq/RenderTreeAsText.cpp:
              * kwq/RenderTreeAsText.h:
              * kwq/WebCoreAXObject.mm:
              * loader/Cache.cpp:
              * loader/Cache.h:
              * loader/CachedCSSStyleSheet.cpp:
              * loader/CachedObject.h:
              * loader/CachedScript.cpp:
              * loader/CachedXBLDocument.cpp:
              * loader/CachedXBLDocument.h:
              * loader/CachedXSLStyleSheet.cpp:
              * loader/CachedXSLStyleSheet.h:
              * loader/DocLoader.cpp:
              * page/Frame.cpp:
              * page/Frame.h:
              * page/FramePrivate.h:
              * page/FrameTree.cpp:
              * page/FrameTree.h:
              * page/FrameView.cpp:
              * page/FrameView.h:
              * page/Page.cpp:
              * page/Page.h:
              * page/Plugin.h:
              (WebCore::Plugin::Plugin):
              (WebCore::Plugin::view):
              * platform/Color.cpp:
              * platform/FloatRect.h:
              * platform/Font.cpp:
              * platform/Font.h:
              * platform/FontFamily.cpp:
              * platform/GraphicsContext.cpp:
              * platform/Image.cpp:
              * platform/Image.h:
              * platform/IntRect.h:
              * platform/KURL.cpp:
              * platform/KURL.h:
              * platform/SegmentedString.h:
              * platform/Shared.h:
              * platform/StreamingTextDecoder.cpp:
              * platform/StringImpl.cpp:
              * platform/StringImpl.h:
              * platform/TextEncoding.h:
              * platform/Timer.cpp:
              * platform/Timer.h:
              * platform/TransferJob.cpp:
              * platform/TransferJob.h:
              * platform/TransferJobInternal.h:
              * platform/cairo/GraphicsContextCairo.cpp:
              * platform/cairo/ImageCairo.cpp:
              * platform/cairo/ImageSourceCairo.cpp:
              * platform/image-decoders/gif/GIFImageReader.cpp:
              * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
              * platform/mac/FontFamilyMac.mm:
              * platform/mac/FontMac.mm:
              * platform/mac/ImageMac.mm:
              * platform/mac/TextEncodingMac.cpp:
              * platform/mac/TransferJobMac.mm:
              * platform/win/FontPlatformDataWin.cpp:
              * platform/win/TransferJobWin.cpp:
              * rendering/RenderBlock.cpp:
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              * rendering/RenderBox.h:
              * rendering/RenderCanvas.cpp:
              * rendering/RenderCanvas.h:
              * rendering/RenderContainer.cpp:
              * rendering/RenderFlexibleBox.h:
              * rendering/RenderFlow.cpp:
              * rendering/RenderFlow.h:
              * rendering/RenderImage.cpp:
              * rendering/RenderImage.h:
              * rendering/RenderLayer.cpp:
              * rendering/RenderLayer.h:
              * rendering/RenderObject.cpp:
              (showTree):
              * rendering/RenderObject.h:
              * rendering/RenderTableCell.h:
              * rendering/RenderTableSection.h:
              * rendering/RenderText.cpp:
              * rendering/RenderText.h:
              * rendering/RenderTextField.cpp:
              * rendering/RenderTextFragment.h:
              * rendering/RenderTheme.h:
              * rendering/RenderThemeMac.mm:
              * rendering/RenderThemeWin.cpp:
              * rendering/bidi.cpp:
              * rendering/render_form.h:
              * rendering/render_line.cpp:
              (showTree):
              * rendering/render_line.h:
              * rendering/render_list.cpp:
              * rendering/render_replaced.cpp:
              * rendering/render_replaced.h:
              * rendering/render_style.cpp:
              * rendering/render_style.h:
              * xml/xmlhttprequest.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36d1136a
  24. 20 Mar, 2006 1 commit
    • justing's avatar
      Reviewed by darin · a198c590
      justing authored
              
              <rdar://problem/3997958> 
              REGRESSION (Mail): Mail takes half of forever to paste >1500 lines - replaceSelectionWithNode
      
              * dom/Position.cpp:
              (WebCore::Position::upstream): Avoid calling previous() when we know that 
              it will 1) end the search and 2) be expensive to compute.
              (WebCore::Position::downstream): Removed some dead code.
              (WebCore::Position::inRenderedText): Return false for offsets inside composed characters.
              * dom/Position.h:
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::init): If there are two visually equivalent candidates, we choose
              the one that occurs first in document order.  Using upstream() to find the one that occurs first is
              much faster than the old code.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a198c590
  25. 19 Mar, 2006 1 commit
  26. 17 Mar, 2006 1 commit
    • ggaren's avatar
      LayoutTests: · 42e58c6d
      ggaren authored
              Reviewed by Darin.
      
              * fast/dom/prototype-chain-expected.txt: Updated to reflect new
              prototype chain.
      
      WebCore:
      
              Reviewed by Darin.
      
              - Fixed some crashes in event dispatch and settled the question of 
              when getDocument() can return NULL, removing superfluous NULL checks.
      
              I promise to check in a test case soon, but I need to land this before
              the global rename happens, and I left the test file on my other machine.
      
              Here's what I did:
      
              (1) Removed NULL checks for getDocument() in cases where we know it
              should not return NULL (which turned out to be all but one). Replaced 
              with ASSERT inside getDocument(). Tested to ensure there was no 
              regression @ albertsons.com.
      
              (2) Added the EventTargetNode class, which represents Nodes that
              implement the DOM EventTarget interface. Discussed this design with
              Maciej and Hyatt. The previous dsign -- assuming that all Nodes were 
              EventTargets -- made it possible to crash WebKit by, for example, 
              dispatching a mouse event to a documentType node that was not 
              associated with a document.
      
              (3) Reflected (2) into the JS bindings and touched JSDOMCore.cpp to 
              force a re-build.
      
              (4) Using classInfo checking, strengthened type constraints on 
              JavaScript method dispatch so that you can't finagle JavaScript into, 
              for example, invoking a document-dependent method belonging to a
              node type that's guaranteed to have a document on a node type that may
              not have one. 
      
              (5) Pushed some IE-specific JS bindings that depend on a node having a 
              document down from DOMNode to DOMElement. (An element always has a 
              document.) Tested that Firefox's behavior matched. Confirmed with MSDN.
      
              (6) Updated Objc bindigns to throw an exception if you try to use
              the event interface on a node that doesn't support it. Discussed this
              design with Maciej and TimH.
      
              (7) Consolidated repeated documentElement-finding code in the Position 
              class into the Position::documentElement() method. Did the same for
              repeated top-level document finding and DocumentImpl::topDocument().
              
              * WebCore+SVG/KDOMHeaders.h:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSDOMCore.cpp:
              * bindings/objc/DOM.mm:
              (-[DOMNode addEventListener:::]):
              (-[DOMNode removeEventListener:::]):
              (-[DOMNode dispatchEvent:]):
              (-[DOMNode KJS::Bindings::]):
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::keyEvent):
              (WebCore::MacFrame::dispatchCPPEvent):
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]):
              (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
              * css/css_base.cpp:
              (WebCore::StyleBaseImpl::baseURL):
              * css/css_computedstyle.cpp:
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
              * css/css_valueimpl.cpp:
              (WebCore::CSSMutableStyleDeclarationImpl::removeProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::setProperty):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/Attr.idl:
              * dom/CharacterData.idl:
              * dom/CharacterDataImpl.cpp:
              (WebCore::CharacterDataImpl::CharacterDataImpl):
              (WebCore::CharacterDataImpl::rendererIsNeeded):
              (WebCore::CharacterDataImpl::dump):
              * dom/CharacterDataImpl.h:
              * dom/ContainerNodeImpl.cpp:
              (WebCore::ContainerNodeImpl::ContainerNodeImpl):
              (WebCore::ContainerNodeImpl::removeChild):
              (WebCore::ContainerNodeImpl::attach):
              (WebCore::ContainerNodeImpl::detach):
              (WebCore::ContainerNodeImpl::insertedIntoDocument):
              (WebCore::ContainerNodeImpl::removedFromDocument):
              (WebCore::ContainerNodeImpl::insertedIntoTree):
              (WebCore::ContainerNodeImpl::removedFromTree):
              (WebCore::ContainerNodeImpl::setFocus):
              (WebCore::ContainerNodeImpl::setActive):
              (WebCore::ContainerNodeImpl::setHovered):
              (WebCore::dispatchChildInsertionEvents):
              (WebCore::dispatchChildRemovalEvents):
              * dom/ContainerNodeImpl.h:
              * dom/DOMImplementationImpl.cpp:
              (WebCore::DOMImplementationImpl::createDocument):
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::removeAllEventListenersFromAllNodes):
              (WebCore::DocumentImpl::removeAllDisconnectedNodeEventListeners):
              (WebCore::DocumentImpl::getAccObjectCache):
              (WebCore::DocumentImpl::setFocusNode):
              (WebCore::DocumentImpl::topDocument):
              * dom/Element.idl:
              * dom/EventTargetNodeImpl.cpp: Added.
              (WebCore::EventTargetNodeImpl::EventTargetNodeImpl):
              (WebCore::EventTargetNodeImpl::~EventTargetNodeImpl):
              (WebCore::EventTargetNodeImpl::insertedIntoDocument):
              (WebCore::EventTargetNodeImpl::removedFromDocument):
              (WebCore::EventTargetNodeImpl::addEventListener):
              (WebCore::EventTargetNodeImpl::removeEventListener):
              (WebCore::EventTargetNodeImpl::removeAllEventListeners):
              (WebCore::EventTargetNodeImpl::handleLocalEvents):
              (WebCore::EventTargetNodeImpl::dispatchGenericEvent):
              (WebCore::EventTargetNodeImpl::dispatchEvent):
              (WebCore::EventTargetNodeImpl::dispatchSubtreeModifiedEvent):
              (WebCore::EventTargetNodeImpl::dispatchWindowEvent):
              (WebCore::EventTargetNodeImpl::dispatchUIEvent):
              (WebCore::EventTargetNodeImpl::dispatchKeyEvent):
              (WebCore::EventTargetNodeImpl::dispatchMouseEvent):
              (WebCore::EventTargetNodeImpl::dispatchSimulatedMouseEvent):
              (WebCore::EventTargetNodeImpl::dispatchWheelEvent):
              (WebCore::EventTargetNodeImpl::dispatchHTMLEvent):
              (WebCore::EventTargetNodeImpl::removeHTMLEventListener):
              (WebCore::EventTargetNodeImpl::setHTMLEventListener):
              (WebCore::EventTargetNodeImpl::getHTMLEventListener):
              (WebCore::EventTargetNodeImpl::disabled):
              (WebCore::EventTargetNodeImpl::defaultEventHandler):
              (WebCore::EventTargetNodeImpl::dump):
              * dom/EventTargetNodeImpl.h: Added.
              (WebCore::EventTargetNodeImpl::isEventTargetNode):
              (WebCore::EventTargetNodeImpl::preDispatchEventHandler):
              (WebCore::EventTargetNodeImpl::postDispatchEventHandler):
              (WebCore::EventTarget):
              (WebCore::forbidEventDispatch):
              (WebCore::allowEventDispatch):
              (WebCore::eventDispatchForbidden):
              * dom/NodeImpl.cpp:
              (WebCore::NodeImpl::NodeImpl):
              (WebCore::NodeImpl::~NodeImpl):
              (WebCore::NodeImpl::dump):
              (WebCore::NodeImpl::detach):
              (WebCore::NodeImpl::insertedIntoDocument):
              (WebCore::NodeImpl::removedFromDocument):
              * dom/NodeImpl.h:
              (WebCore::NodeImpl::isEventTargetNode):
              (WebCore::NodeImpl::isLink):
              (WebCore::NodeImpl::getDocument):
              (WebCore::NodeImpl::inDocument):
              * dom/dom2_eventsimpl.cpp:
              (WebCore::MouseRelatedEventImpl::receivedTarget):
              * dom/dom2_rangeimpl.cpp:
              (WebCore::RangeImpl::commonAncestorContainer):
              * dom/dom_elementimpl.cpp:
              (WebCore::inHTMLDocument):
              (WebCore::ElementImpl::focus):
              (WebCore::ElementImpl::blur):
              (WebCore::StyledElementImpl::parseMappedAttribute):
              * dom/dom_position.cpp:
              (WebCore::Position::documentElement):
              * dom/dom_position.h:
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::computeAndStoreNodeDesiredStyle):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::needsCaretRepaint):
              * editing/visible_units.cpp:
              (WebCore::previousBoundary):
              (WebCore::nextBoundary):
              (WebCore::previousLinePosition):
              (WebCore::nextLinePosition):
              (WebCore::startOfDocument):
              (WebCore::endOfDocument):
              * khtml/ecma/kjs_dom.cpp:
              (KJS::DOMNode::mark):
              (KJS::DOMNode::getValueProperty):
              (KJS::DOMNode::putValueProperty):
              (KJS::DOMNodeProtoFunc::callAsFunction):
              (KJS::DOMEventTargetNode::DOMEventTargetNode):
              (KJS::DOMEventTargetNode::getOwnPropertySlot):
              (KJS::DOMEventTargetNode::getValueProperty):
              (KJS::DOMEventTargetNode::put):
              (KJS::DOMEventTargetNode::putValueProperty):
              (KJS::DOMEventTargetNode::setListener):
              (KJS::DOMEventTargetNode::getListener):
              (KJS::DOMEventTargetNode::pushEventHandlerScope):
              (KJS::DOMEventTargetNodeProtoFunc::callAsFunction):
              (KJS::):
              (KJS::DOMDocument::DOMDocument):
              (KJS::DOMDocument::getOwnPropertySlot):
              (KJS::DOMDocument::put):
              (KJS::DOMDocument::putValueProperty):
              (KJS::DOMDocumentProtoFunc::callAsFunction):
              (KJS::DOMElement::DOMElement):
              (KJS::DOMElement::getValueProperty):
              (KJS::DOMElement::put):
              (KJS::DOMElement::putValueProperty):
              (KJS::DOMElement::getOwnPropertySlot):
              (KJS::DOMElementProtoFunc::callAsFunction):
              (KJS::checkNodeSecurity):
              * khtml/ecma/kjs_dom.h:
              (KJS::DOMNode::):
              (KJS::DOMEventTargetNode::):
              (KJS::DOMElement::):
              * khtml/ecma/kjs_events.cpp:
              (KJS::JSLazyEventListener::parseCode):
              (KJS::getNodeEventListener):
              * khtml/ecma/kjs_html.cpp:
              (KJS::HTMLElement::bodyGetter):
              (KJS::HTMLElement::anchorGetter):
              (KJS::HTMLElement::getValueProperty):
              (KJS::HTMLElement::bodySetter):
              * khtml/ecma/kjs_views.cpp:
              (KJS::DOMAbstractViewProtoFunc::callAsFunction):
              * khtml/html/HTMLFormElementImpl.cpp:
              (WebCore::HTMLFormElementImpl::registerFormElement):
              (WebCore::HTMLFormElementImpl::removeFormElement):
              * khtml/html/HTMLGenericFormElementImpl.cpp:
              (WebCore::HTMLGenericFormElementImpl::insertedIntoTree):
              * khtml/html/HTMLInputElementImpl.cpp:
              (WebCore::HTMLInputElementImpl::~HTMLInputElementImpl):
              (WebCore::HTMLInputElementImpl::focus):
              * khtml/html/HTMLOptionElementImpl.cpp:
              (WebCore::HTMLOptionElementImpl::text):
              * khtml/html/HTMLSelectElementImpl.cpp:
              (WebCore::HTMLSelectElementImpl::~HTMLSelectElementImpl):
              * khtml/html/HTMLTextAreaElementImpl.cpp:
              (WebCore::HTMLTextAreaElementImpl::~HTMLTextAreaElementImpl):
              * khtml/html/html_baseimpl.cpp:
              (WebCore::HTMLBodyElementImpl::insertedIntoDocument):
              (WebCore::HTMLFrameElementImpl::isURLAllowed):
              (WebCore::HTMLFrameElementImpl::openURL):
              (WebCore::HTMLFrameElementImpl::frameWidth):
              (WebCore::HTMLFrameElementImpl::frameHeight):
              * khtml/html/html_imageimpl.cpp:
              (WebCore::HTMLImageLoader::~HTMLImageLoader):
              (WebCore::HTMLImageLoader::updateFromElement):
              (WebCore::HTMLImageLoader::notifyFinished):
              (WebCore::HTMLImageElementImpl::width):
              (WebCore::HTMLImageElementImpl::height):
              (WebCore::HTMLMapElementImpl::~HTMLMapElementImpl):
              * khtml/html/html_inlineimpl.cpp:
              (WebCore::HTMLAnchorElementImpl::defaultEventHandler):
              * khtml/html/htmltokenizer.cpp:
              (WebCore::HTMLTokenizer::notifyFinished):
              * ksvg2/svg/SVGAnimateColorElementImpl.cpp:
              (SVGAnimateColorElementImpl::handleTimerEvent):
              * ksvg2/svg/SVGAnimateElementImpl.cpp:
              (SVGAnimateElementImpl::handleTimerEvent):
              * ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
              (SVGAnimateTransformElementImpl::handleTimerEvent):
              * ksvg2/svg/SVGAnimationElementImpl.cpp:
              (SVGAnimationElementImpl::closeRenderer):
              * ksvg2/svg/SVGDOMImplementationImpl.cpp:
              * ksvg2/svg/SVGDocumentImpl.cpp:
              (WebCore::SVGDocumentImpl::dispatchRecursiveEvent):
              * ksvg2/svg/SVGDocumentImpl.h:
              * ksvg2/svg/SVGImageElementImpl.cpp:
              * ksvg2/svg/SVGSetElementImpl.cpp:
              (SVGSetElementImpl::handleTimerEvent):
              * kwq/KWQAccObject.mm:
              (-[KWQAccObject mouseButtonListener]):
              (-[KWQAccObject accessibilityPerformAction:]):
              * kwq/KWQTextArea.mm:
              (-[KWQTextAreaTextView dispatchHTMLEvent:]):
              * page/Frame.cpp:
              (WebCore::dispatchKHTMLEditableContentChanged):
              * page/FrameView.cpp:
              (WebCore::FrameView::dispatchDragEvent):
              (WebCore::FrameView::dispatchMouseEvent):
              (WebCore::FrameView::viewportWheelEvent):
              * rendering/render_layer.cpp:
              (WebCore::RenderLayer::scrollToOffset):
              * rendering/render_object.cpp:
              (WebCore::RenderObject::shouldSelect):
              (WebCore::RenderObject::backslashAsCurrencySymbol):
              * rendering/render_replaced.cpp:
              (WebCore::RenderWidget::sendConsumedMouseUp):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42e58c6d
  27. 16 Feb, 2006 1 commit
    • darin's avatar
      Reviewed by Eric and Justin. · 85c3a50e
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7310
                fix leaks by using RefPtr more
      
              * bindings/objc/DOM.mm:
              (-[DOMDocument adoptNode:]):
              (-[DOMDocument createElement:]):
              (-[DOMDocument createDocumentFragment]):
              (-[DOMDocument createTextNode:]):
              (-[DOMDocument createComment:]):
              (-[DOMDocument createCDATASection:]):
              (-[DOMDocument createProcessingInstruction::]):
              (-[DOMDocument createEntityReference:]):
              (-[DOMDocument importNode::]):
              (-[DOMDocument createElementNS::]):
              (-[DOMDocument createRange]):
              (-[DOMDocument createCSSStyleDeclaration]):
              (-[DOMDocument createNodeIterator::::]):
              (-[DOMDocument createTreeWalker::::]):
              * bindings/objc/DOMCSS.mm:
              (-[DOMCSSStyleDeclaration getPropertyCSSValue:]):
              * bindings/objc/DOMEvents.mm:
              (-[DOMDocument createEvent:]):
              * bridge/mac/MacFrame.h:
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::MacFrame):
              (WebCore::MacFrame::freeClipboard):
              (WebCore::MacFrame::setView):
              (WebCore::MacFrame::wheelEvent):
              (WebCore::MacFrame::openURLFromPageCache):
              (WebCore::MacFrame::mouseDownViewIfStillGood):
              (WebCore::MacFrame::khtmlMouseMoveEvent):
              (WebCore::MacFrame::dispatchCPPEvent):
              (WebCore::MacFrame::mouseDown):
              (WebCore::MacFrame::mouseDragged):
              (WebCore::MacFrame::mouseUp):
              (WebCore::MacFrame::mouseMoved):
              (WebCore::MacFrame::sendContextMenuEvent):
              (WebCore::MacFrame::dispatchDragSrcEvent):
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge convertToDOMRange:]):
              (-[WebCoreFrameBridge convertNSRangeToDOMRange:]):
              (-[WebCoreFrameBridge selectNSRange:]):
              (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
              (-[WebCoreFrameBridge typingStyle]):
              (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
              (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
              (-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
              * css/css_computedstyle.cpp:
              (WebCore::CSSComputedStyleDeclarationImpl::CSSComputedStyleDeclarationImpl):
              (WebCore::CSSComputedStyleDeclarationImpl::cssText):
              (WebCore::CSSComputedStyleDeclarationImpl::setCssText):
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyValue):
              (WebCore::CSSComputedStyleDeclarationImpl::removeProperty):
              (WebCore::CSSComputedStyleDeclarationImpl::setProperty):
              (WebCore::CSSComputedStyleDeclarationImpl::item):
              (WebCore::CSSComputedStyleDeclarationImpl::copyInheritableProperties):
              (WebCore::CSSComputedStyleDeclarationImpl::copy):
              (WebCore::CSSComputedStyleDeclarationImpl::makeMutable):
              * css/css_computedstyle.h:
              * css/css_grammar.y:
              * css/css_ruleimpl.cpp:
              (WebCore::CSSStyleRuleImpl::~CSSStyleRuleImpl):
              (WebCore::CSSStyleRuleImpl::setDeclaration):
              * css/css_ruleimpl.h:
              (DOM::CSSStyleRuleImpl::style):
              (DOM::CSSStyleRuleImpl::declaration):
              * css/css_valueimpl.cpp:
              (WebCore::propertyID):
              (WebCore::quoteStringIfNeeded):
              (WebCore::CSSStyleDeclarationImpl::getPropertyCSSValue):
              (WebCore::CSSStyleDeclarationImpl::getPropertyValue):
              (WebCore::CSSStyleDeclarationImpl::getPropertyPriority):
              (WebCore::CSSStyleDeclarationImpl::getPropertyShorthand):
              (WebCore::CSSStyleDeclarationImpl::isPropertyImplicit):
              (WebCore::CSSStyleDeclarationImpl::setProperty):
              (WebCore::CSSStyleDeclarationImpl::removeProperty):
              (WebCore::CSSStyleDeclarationImpl::isPropertyName):
              (WebCore::CSSMutableStyleDeclarationImpl::getPropertyValue):
              (WebCore::CSSMutableStyleDeclarationImpl::get4Values):
              (WebCore::CSSMutableStyleDeclarationImpl::getShortHandValue):
              (WebCore::CSSMutableStyleDeclarationImpl::getPropertyCSSValue):
              (WebCore::CSSMutableStyleDeclarationImpl::removeProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::setProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::setStringProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::setImageProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::parseDeclaration):
              (WebCore::CSSMutableStyleDeclarationImpl::setLengthProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::item):
              (WebCore::CSSMutableStyleDeclarationImpl::cssText):
              (WebCore::CSSMutableStyleDeclarationImpl::setCssText):
              (WebCore::CSSMutableStyleDeclarationImpl::copyBlockProperties):
              (WebCore::CSSStyleDeclarationImpl::copyPropertiesInSet):
              (WebCore::CSSMutableStyleDeclarationImpl::removePropertiesInSet):
              (WebCore::CSSMutableStyleDeclarationImpl::makeMutable):
              (WebCore::CSSMutableStyleDeclarationImpl::copy):
              (WebCore::CSSInheritedValueImpl::cssText):
              (WebCore::CSSInitialValueImpl::cssText):
              (WebCore::CSSValueListImpl::append):
              (WebCore::CSSValueListImpl::cssText):
              (WebCore::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl):
              (WebCore::CSSPrimitiveValueImpl::cleanup):
              (WebCore::CSSPrimitiveValueImpl::setStringValue):
              (WebCore::CSSPrimitiveValueImpl::getStringValue):
              (WebCore::CSSPrimitiveValueImpl::parseString):
              (WebCore::CSSPrimitiveValueImpl::cssText):
              (WebCore::CSSImageValueImpl::CSSImageValueImpl):
              (WebCore::CSSBorderImageValueImpl::CSSBorderImageValueImpl):
              (WebCore::CSSBorderImageValueImpl::cssText):
              (WebCore::FontFamilyValueImpl::FontFamilyValueImpl):
              (WebCore::FontFamilyValueImpl::cssText):
              (WebCore::FontValueImpl::cssText):
              (WebCore::ShadowValueImpl::ShadowValueImpl):
              (WebCore::ShadowValueImpl::cssText):
              (WebCore::CSSProperty::cssText):
              * css/css_valueimpl.h:
              (WebCore::CSSValueImpl::setCssText):
              (WebCore::CSSValueListImpl::item):
              (WebCore::CSSPrimitiveValueImpl::getFloatValue):
              (WebCore::CSSPrimitiveValueImpl::getCounterValue):
              (WebCore::CSSPrimitiveValueImpl::getRectValue):
              (WebCore::CSSPrimitiveValueImpl::getRGBColorValue):
              (WebCore::CSSPrimitiveValueImpl::getPairValue):
              (WebCore::CSSPrimitiveValueImpl::getDashboardRegionValue):
              (WebCore::CSSPrimitiveValueImpl::):
              (WebCore::CSSQuirkPrimitiveValueImpl::CSSQuirkPrimitiveValueImpl):
              (WebCore::CounterImpl::identifier):
              (WebCore::CounterImpl::listStyle):
              (WebCore::CounterImpl::separator):
              (WebCore::RectImpl::top):
              (WebCore::RectImpl::right):
              (WebCore::RectImpl::bottom):
              (WebCore::RectImpl::left):
              (WebCore::RectImpl::setTop):
              (WebCore::RectImpl::setRight):
              (WebCore::RectImpl::setBottom):
              (WebCore::RectImpl::setLeft):
              (WebCore::PairImpl::first):
              (WebCore::PairImpl::second):
              (WebCore::PairImpl::setFirst):
              (WebCore::PairImpl::setSecond):
              (WebCore::DashboardRegionImpl::DashboardRegionImpl):
              (WebCore::FontFamilyValueImpl::fontName):
              (WebCore::CSSProperty::CSSProperty):
              (WebCore::CSSProperty::value):
              (WebCore::CSSMutableStyleDeclarationImpl::setNode):
              (WebCore::CSSMutableStyleDeclarationImpl::setProperty):
              (WebCore::CSSMutableStyleDeclarationImpl::removeProperty):
              * css/cssparser.cpp:
              (CSSParser::createStyleDeclaration):
              (CSSParser::parseDashboardRegions):
              * css/cssparser.h:
              (WebCore::Value::):
              (WebCore::qString):
              (WebCore::domString):
              (WebCore::atomicString):
              (WebCore::ValueList::current):
              (WebCore::ValueList::next):
              (WebCore::CSSParser::current):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/DOMImplementationImpl.cpp:
              (DOM::DOMImplementationImpl::createDocument):
              (DOM::DOMImplementationImpl::instance):
              * dom/DOMImplementationImpl.h:
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::DocumentImpl):
              (WebCore::DocumentImpl::~DocumentImpl):
              (WebCore::DocumentImpl::setDocType):
              (WebCore::DocumentImpl::createElement):
              (WebCore::DocumentImpl::createDocumentFragment):
              (WebCore::DocumentImpl::createTextNode):
              (WebCore::DocumentImpl::createComment):
              (WebCore::DocumentImpl::createCDATASection):
              (WebCore::DocumentImpl::createProcessingInstruction):
              (WebCore::DocumentImpl::createEntityReference):
              (WebCore::DocumentImpl::createEditingTextNode):
              (WebCore::DocumentImpl::createCSSStyleDeclaration):
              (WebCore::DocumentImpl::importNode):
              (WebCore::DocumentImpl::adoptNode):
              (WebCore::DocumentImpl::createElementNS):
              (WebCore::DocumentImpl::setTitle):
              (WebCore::DocumentImpl::createRange):
              (WebCore::DocumentImpl::createNodeIterator):
              (WebCore::DocumentImpl::createTreeWalker):
              (WebCore::DocumentImpl::setStyleSheet):
              (WebCore::DocumentImpl::setHoverNode):
              (WebCore::DocumentImpl::setActiveNode):
              (WebCore::DocumentImpl::setFocusNode):
              (WebCore::DocumentImpl::defaultView):
              (WebCore::DocumentImpl::createEvent):
              (WebCore::DocumentImpl::setHTMLWindowEventListener):
              (WebCore::DocumentImpl::addWindowEventListener):
              (WebCore::DocumentImpl::createHTMLEventListener):
              (WebCore::DocumentImpl::images):
              (WebCore::DocumentImpl::applets):
              (WebCore::DocumentImpl::embeds):
              (WebCore::DocumentImpl::objects):
              (WebCore::DocumentImpl::links):
              (WebCore::DocumentImpl::forms):
              (WebCore::DocumentImpl::anchors):
              (WebCore::DocumentImpl::all):
              (WebCore::DocumentImpl::windowNamedItems):
              (WebCore::DocumentImpl::documentNamedItems):
              (WebCore::DocumentImpl::getElementsByName):
              * dom/DocumentImpl.h:
              (WebCore::DocumentImpl::realDocType):
              (WebCore::DocumentImpl::createAttribute):
              (WebCore::DocumentImpl::title):
              (WebCore::DocumentImpl::styleSelector):
              (WebCore::DocumentImpl::setRestoreState):
              (WebCore::DocumentImpl::restoreState):
              (WebCore::DocumentImpl::view):
              (WebCore::DocumentImpl::docLoader):
              (WebCore::DocumentImpl::tokenizer):
              (WebCore::DocumentImpl::focusNode):
              (WebCore::DocumentImpl::hoverNode):
              (WebCore::DocumentImpl::activeNode):
              (WebCore::DocumentImpl::policyBaseURL):
              (WebCore::DocumentImpl::setPolicyBaseURL):
              (WebCore::DocumentImpl::):
              (WebCore::DocumentImpl::transformSourceDocument):
              (WebCore::DocumentImpl::domTreeVersion):
              (WebCore::DocumentImpl::decoder):
              * dom/NodeListImpl.cpp:
              (DOM::NodeListImpl::NodeListImpl):
              (DOM::NodeListImpl::~NodeListImpl):
              (DOM::NodeListImpl::recursiveLength):
              (DOM::NodeListImpl::recursiveItem):
              (DOM::NodeListImpl::itemById):
              * dom/NodeListImpl.h:
              * dom/dom2_eventsimpl.cpp:
              (WebCore::RegisteredEventListener::RegisteredEventListener):
              * dom/dom2_eventsimpl.h:
              (WebCore::operator!=):
              * dom/dom2_traversalimpl.cpp:
              (DOM::TraversalImpl::TraversalImpl):
              (DOM::NodeIteratorImpl::NodeIteratorImpl):
              (DOM::TreeWalkerImpl::TreeWalkerImpl):
              * dom/dom2_traversalimpl.h:
              (WebCore::TraversalImpl::root):
              (WebCore::TraversalImpl::filter):
              (WebCore::NodeIteratorImpl::referenceNode):
              (WebCore::NodeIteratorImpl::setPointerBeforeReferenceNode):
              (WebCore::NodeIteratorImpl::setDetached):
              (WebCore::NodeIteratorImpl::document):
              (WebCore::TreeWalkerImpl::currentNode):
              * dom/dom_position.cpp:
              (WebCore::Position::computedStyle):
              * dom/dom_position.h:
              * dom/xml_tokenizer.cpp:
              (WebCore::XMLTokenizer::insertErrorMessageBlock):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::createFontElement):
              (WebCore::createStyleSpanElement):
              (WebCore::ApplyStyleCommand::ApplyStyleCommand):
              (WebCore::ApplyStyleCommand::updateStartEnd):
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
              (WebCore::ApplyStyleCommand::extractTextDecorationStyle):
              (WebCore::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
              (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
              (WebCore::ApplyStyleCommand::removeInlineStyle):
              (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
              (WebCore::ApplyStyleCommand::computedFontSize):
              * editing/ApplyStyleCommand.h:
              (WebCore::ApplyStyleCommand::style):
              * editing/EditCommand.cpp:
              (WebCore::EditCommandPtr::setTypingStyle):
              (WebCore::EditCommand::setTypingStyle):
              (WebCore::EditCommand::styleAtPosition):
              * editing/EditCommand.h:
              (WebCore::EditCommand::document):
              (WebCore::EditCommand::typingStyle):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::InsertLineBreakCommand):
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::prepareForTextInsertion):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::computeAndStoreNodeDesiredStyle):
              (WebCore::NodeDesiredStyle::NodeDesiredStyle):
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/ReplaceSelectionCommand.h:
              (WebCore::NodeDesiredStyle::node):
              (WebCore::NodeDesiredStyle::style):
              (WebCore::ReplacementFragment::root):
              * editing/WrapContentsInDummySpanCommand.cpp:
              (WebCore::WrapContentsInDummySpanCommand::doApply):
              * editing/htmlediting.cpp:
              (WebCore::createDefaultParagraphElement):
              (WebCore::createBreakElement):
              * editing/markup.cpp:
              (WebCore::createFragmentFromMarkup):
              (WebCore::createParagraphContentsFromString):
              * editing/visible_text.cpp:
              (khtml::TextIterator::rangeFromLocationAndLength):
              * editing/visible_text.h:
              (WebCore::isCollapsibleWhitespace):
              (WebCore::WordAwareIterator::range):
              * khtml/ecma/kjs_css.cpp:
              (KJS::DOMCSSStyleDeclaration::cssPropertyGetter):
              (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
              * khtml/ecma/kjs_dom.cpp:
              (KJS::DOMDocumentProtoFunc::callAsFunction):
              * khtml/ecma/kjs_html.cpp:
              (KJS::KJS::HTMLSelectCollection::put):
              (KJS::OptionConstructorImp::construct):
              * khtml/html/HTMLElementImpl.cpp:
              (WebCore::HTMLElementImpl::createContextualFragment):
              (WebCore::HTMLElementImpl::setInnerHTML):
              (WebCore::HTMLElementImpl::setOuterHTML):
              (WebCore::HTMLElementImpl::setOuterText):
              * khtml/html/HTMLElementImpl.h:
              * khtml/html/HTMLNameCollectionImpl.cpp:
              (WebCore::HTMLNameCollectionImpl::HTMLNameCollectionImpl):
              (WebCore::HTMLNameCollectionImpl::traverseNextItem):
              * khtml/html/HTMLNameCollectionImpl.h:
              * khtml/html/html_documentimpl.cpp:
              (WebCore::HTMLDocumentImpl::createElement):
              * khtml/html/html_documentimpl.h:
              (WebCore::HTMLDocumentImpl::collectionInfo):
              * khtml/html/htmlfactory.cpp:
              (DOM::htmlConstructor):
              (DOM::headConstructor):
              (DOM::bodyConstructor):
              (DOM::baseConstructor):
              (DOM::linkConstructor):
              (DOM::metaConstructor):
              (DOM::styleConstructor):
              (DOM::titleConstructor):
              (DOM::frameConstructor):
              (DOM::framesetConstructor):
              (DOM::iframeConstructor):
              (DOM::formConstructor):
              (DOM::buttonConstructor):
              (DOM::inputConstructor):
              (DOM::isindexConstructor):
              (DOM::fieldsetConstructor):
              (DOM::labelConstructor):
              (DOM::legendConstructor):
              (DOM::optgroupConstructor):
              (DOM::optionConstructor):
              (DOM::selectConstructor):
              (DOM::textareaConstructor):
              (DOM::dlConstructor):
              (DOM::ulConstructor):
              (DOM::olConstructor):
              (DOM::dirConstructor):
              (DOM::menuConstructor):
              (DOM::liConstructor):
              (DOM::blockquoteConstructor):
              (DOM::divConstructor):
              (DOM::headingConstructor):
              (DOM::hrConstructor):
              (DOM::paragraphConstructor):
              (DOM::preConstructor):
              (DOM::basefontConstructor):
              (DOM::fontConstructor):
              (DOM::modConstructor):
              (DOM::anchorConstructor):
              (DOM::imageConstructor):
              (DOM::mapConstructor):
              (DOM::areaConstructor):
              (DOM::canvasConstructor):
              (DOM::appletConstructor):
              (DOM::embedConstructor):
              (DOM::objectConstructor):
              (DOM::paramConstructor):
              (DOM::scriptConstructor):
              (DOM::tableConstructor):
              (DOM::tableCaptionConstructor):
              (DOM::tableColConstructor):
              (DOM::tableRowConstructor):
              (DOM::tableCellConstructor):
              (DOM::tableSectionConstructor):
              (DOM::brConstructor):
              (DOM::quoteConstructor):
              (DOM::marqueeConstructor):
              (DOM::HTMLElementFactory::createHTMLElement):
              * khtml/html/htmlfactory.h:
              * khtml/html/htmlparser.cpp:
              (HTMLParser::parseToken):
              (HTMLParser::textCreateErrorCheck):
              (HTMLParser::commentCreateErrorCheck):
              (HTMLParser::headCreateErrorCheck):
              (HTMLParser::bodyCreateErrorCheck):
              (HTMLParser::framesetCreateErrorCheck):
              (HTMLParser::iframeCreateErrorCheck):
              (HTMLParser::formCreateErrorCheck):
              (HTMLParser::isindexCreateErrorCheck):
              (HTMLParser::selectCreateErrorCheck):
              (HTMLParser::ddCreateErrorCheck):
              (HTMLParser::dtCreateErrorCheck):
              (HTMLParser::nestedCreateErrorCheck):
              (HTMLParser::nestedStyleCreateErrorCheck):
              (HTMLParser::tableCellCreateErrorCheck):
              (HTMLParser::tableSectionCreateErrorCheck):
              (HTMLParser::noembedCreateErrorCheck):
              (HTMLParser::noframesCreateErrorCheck):
              (HTMLParser::noscriptCreateErrorCheck):
              (HTMLParser::mapCreateErrorCheck):
              (HTMLParser::getNode):
              * khtml/html/htmlparser.h:
              * khtml/html/htmltokenizer.cpp:
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::processToken):
              * khtml/html/htmltokenizer.h:
              * ksvg2/misc/SVGDocumentExtensions.cpp:
              (WebCore::SVGDocumentExtensions::createSVGEventListener):
              * ksvg2/misc/SVGDocumentExtensions.h:
              * ksvg2/svg/SVGDOMImplementationImpl.cpp:
              (SVGDOMImplementationImpl::createDocumentType):
              (SVGDOMImplementationImpl::createDocument):
              (SVGDOMImplementationImpl::createCSSStyleSheet):
              * ksvg2/svg/SVGDOMImplementationImpl.h:
              * ksvg2/svg/SVGDocumentImpl.cpp:
              (WebCore::SVGDocumentImpl::createElement):
              (WebCore::SVGDocumentImpl::dispatchZoomEvent):
              (WebCore::SVGDocumentImpl::dispatchKeyEvent):
              (WebCore::SVGDocumentImpl::dispatchUIEvent):
              (WebCore::SVGDocumentImpl::dispatchMouseEvent):
              * ksvg2/svg/SVGDocumentImpl.h:
              * ksvg2/svg/SVGElementImpl.cpp:
              (WebCore::SVGElementImpl::addSVGEventListener):
              * ksvg2/svg/SVGSVGElementImpl.cpp:
              (WebCore::SVGSVGElementImpl::addSVGWindowEventListner):
              * page/Frame.cpp:
              (WebCore::Frame::view):
              (WebCore::Frame::begin):
              (WebCore::Frame::computeAndSetTypingStyle):
              (WebCore::Frame::selectionHasStyle):
              (WebCore::Frame::selectionStartHasStyle):
              (WebCore::Frame::selectionStartStylePropertyValue):
              (WebCore::Frame::selectionComputedStyle):
              (WebCore::Frame::forceLayout):
              (WebCore::Frame::sendResizeEvent):
              (WebCore::Frame::sendScrollEvent):
              (WebCore::Frame::clearTimers):
              (WebCore::Frame::styleForSelectionStart):
              * page/FramePrivate.h:
              * page/FrameTree.h:
              (WebCore::FrameTree::name):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85c3a50e
  28. 09 Feb, 2006 1 commit
    • mjs's avatar
      Rubber-stamped by Hyatt. · b1742373
      mjs authored
              
              - moved khtml/xml to dom
      
              * dom: moved from khtml/xml
              * WebCore.xcodeproj/project.pbxproj: Updated for new file locations.
              * WebCore+SVG/KDOMHeaders.h: Updated for new header locations.
              * dom/dom2_rangeimpl.cpp: ditto
              * dom/dom2_traversalimpl.cpp: ditto
              * dom/dom_textimpl.cpp: ditto
              * dom/dom_xmlimpl.cpp: ditto
              * khtml/dom/dom2_events.cpp: ditto
              * khtml/ecma/kjs_binding.cpp: ditto
              * khtml/ecma/kjs_dom.cpp: ditto
              * khtml/ecma/kjs_events.cpp: ditto
              * khtml/ecma/kjs_html.cpp: ditto
              * khtml/ecma/kjs_range.cpp: ditto
              * khtml/ecma/kjs_views.cpp: ditto
              * khtml/editing/Selection.cpp: ditto
              * khtml/editing/SelectionController.cpp: ditto
              * khtml/editing/delete_from_text_node_command.cpp: ditto
              * khtml/editing/edit_command.cpp: ditto
              * khtml/editing/insert_into_text_node_command.cpp: ditto
              * khtml/editing/insert_line_break_command.cpp: ditto
              * khtml/editing/insert_paragraph_separator_command.cpp: ditto
              * khtml/editing/insert_text_command.cpp: ditto
              * khtml/editing/join_text_nodes_command.cpp: ditto
              * khtml/editing/markup.cpp: ditto
              * khtml/editing/merge_identical_elements_command.cpp: ditto
              * khtml/editing/rebalance_whitespace_command.cpp: ditto
              * khtml/editing/remove_node_attribute_command.cpp: ditto
              * khtml/editing/set_node_attribute_command.cpp: ditto
              * khtml/editing/split_element_command.cpp: ditto
              * khtml/editing/split_text_node_command.cpp: ditto
              * khtml/editing/split_text_node_containing_element.cpp: ditto
              * khtml/editing/visible_position.cpp: ditto
              * khtml/editing/visible_position.h: ditto
              * khtml/editing/visible_text.cpp: ditto
              * khtml/editing/visible_text.h: ditto
              * khtml/editing/visible_units.cpp: ditto
              * khtml/editing/wrap_contents_in_dummy_span_command.cpp: ditto
              * khtml/html/HTMLElementImpl.h: ditto
              * khtml/html/html_documentimpl.cpp: ditto
              * khtml/html/html_headimpl.cpp: ditto
              * khtml/xbl/xbl_binding_manager.cpp: ditto
              * khtml/xbl/xbl_tokenizer.cpp: ditto
              * khtml/xbl/xbl_tokenizer.h: ditto
              * ksvg2/svg/SVGAElementImpl.cpp: ditto
              * rendering/InlineTextBox.cpp: ditto
              * rendering/RenderContainer.cpp: ditto
              * rendering/RenderText.h: ditto
              * rendering/RenderTextField.cpp: ditto
              * rendering/render_frames.cpp: ditto
              * rendering/render_layer.cpp: ditto
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1742373
  29. 26 Jan, 2006 1 commit
    • eseidel's avatar
      2006-01-26 Eric Seidel <eseidel@apple.com> · 5645aa8f
      eseidel authored
              Reviewed by mjs.
      
              Deploy RefPtr throughout more of WebCore
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6754
      
              * bridge/mac/MacFrame.mm:
              (MacFrame::shouldClose): no need to call .get()
              * khtml/html/HTMLElementImpl.cpp:
              (WebCore::HTMLElementImpl::createContextualFragment):
              * khtml/html/HTMLSelectElementImpl.cpp:
              (WebCore::HTMLSelectElementImpl::remove):
              * khtml/html/HTMLTextAreaElementImpl.cpp:
              (WebCore::HTMLTextAreaElementImpl::setDefaultValue):
              * khtml/html/html_baseimpl.cpp:
              (WebCore::HTMLBodyElementImpl::HTMLBodyElementImpl):
              (WebCore::HTMLBodyElementImpl::~HTMLBodyElementImpl):
              (WebCore::HTMLBodyElementImpl::createLinkDecl):
              (WebCore::HTMLBodyElementImpl::parseMappedAttribute):
              * khtml/html/html_baseimpl.h:
              * khtml/html/html_headimpl.cpp:
              (WebCore::HTMLLinkElementImpl::HTMLLinkElementImpl):
              (WebCore::HTMLLinkElementImpl::~HTMLLinkElementImpl):
              (WebCore::HTMLLinkElementImpl::process):
              (WebCore::HTMLLinkElementImpl::setStyleSheet):
              (WebCore::HTMLLinkElementImpl::isLoading):
              (WebCore::HTMLStyleElementImpl::HTMLStyleElementImpl):
              (WebCore::HTMLStyleElementImpl::childrenChanged):
              (WebCore::HTMLStyleElementImpl::isLoading):
              * khtml/html/html_headimpl.h:
              (DOM::HTMLLinkElementImpl::sheet):
              (DOM::HTMLStyleElementImpl::sheet):
              * khtml/html/html_tableimpl.cpp:
              (WebCore::HTMLTableElementImpl::parseMappedAttribute):
              (WebCore::HTMLTableSectionElementImpl::insertRow):
              (WebCore::HTMLTableSectionElementImpl::deleteRow):
              (WebCore::HTMLTableRowElementImpl::deleteCell):
              * khtml/xml/NodeImpl.cpp:
              (WebCore::NodeImpl::dispatchEvent):
              (WebCore::NodeImpl::dispatchGenericEvent):
              (WebCore::NodeImpl::dispatchWindowEvent):
              (WebCore::NodeImpl::dispatchMouseEvent):
              (WebCore::NodeImpl::dispatchKeyEvent):
              (WebCore::NodeImpl::createRendererIfNeeded):
              * khtml/xml/NodeImpl.h:
              * khtml/xml/dom_elementimpl.cpp:
              (WebCore::MappedAttributeImpl::clone):
              (WebCore::StyledElementImpl::StyledElementImpl):
              (WebCore::StyledElementImpl::createInlineStyleDecl):
              (WebCore::StyledElementImpl::destroyInlineStyleDecl):
              (WebCore::StyledElementImpl::getInlineStyleDecl):
              * khtml/xml/dom_elementimpl.h:
              (DOM::MappedAttributeImpl::MappedAttributeImpl):
              (DOM::MappedAttributeImpl::style):
              (DOM::MappedAttributeImpl::decl):
              (DOM::MappedAttributeImpl::setDecl):
              (DOM::StyledElementImpl::inlineStyleDecl):
              * khtml/xml/dom_position.cpp:
              (DOM::Position::Position):
              (DOM::Position::clear):
              * khtml/xml/dom_position.h:
              (DOM::Position::node):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5645aa8f
  30. 25 Jan, 2006 1 commit
    • harrison's avatar
      Reviewed by Justin. · dec5e09b
      harrison authored
              <rdar://problem/3907635> copy/paste of list item text moves list item up one <LI>
              <rdar://problem/3907647> Enhance list editing: return inserts <li></li>
              <rdar://problem/4060158> deleting selection within table deletes more than intended
              <rdar://problem/4061232> Deleting a list can delete unselected content
              <rdar://problem/4062212> after pasting in contents of web.apple.com, typing before start adds to table instead of before table
              <rdar://problem/4064437> After copy/paste from bugweb cannot go back to entering text at left side of page
              <rdar://problem/4259845> Table editing in design mode is broken
              <rdar://problem/4287667> Insertion point goes before table instead of inside first cell
              <rdar://problem/4345749> Editing HTML - Enter at end of <LI> inserts uneditable blank <LI>
              <rdar://problem/4345794> HTML editing: Enter at end of last <LI> does not add new <LI>
              <rdar://problem/4345825> HTML Editing: editing first <LI> element removes first <LI> and more
              <rdar://problem/4345835> HTML editing: editing last <LI> removes everything within <BODY>
              <rdar://problem/4345879> HTML editing: editing first <TD> moves data out of table
      
              ...also added showTree() static functions because switch to gcc 4.0 makes calling instance methods unreliable
      
              - numerous small changes to handle empty list items
              - fix numeric list marker updating when adding/deleting list items
              - start to decompose "special element" handling, replacing it with appropriate handling of the different
                kinds of special elements in various situations, rather than giving a blanket treatment.  I will do more
                of this in subsequent checkins.
              - numerous small editing/selection changes to handle VisiblePosition at table offset childNodeCount()
              - simplify and fix equivalentRangeCompliantPosition, rename it to rangeCompliantEquivalent and make it static
              - some minor reformatting to current standards
              - the comments in the list below are for changes not covered by the above comments
              
              * khtml/editing/Selection.cpp:
              (WebCore::Selection::toRange):
              (WebCore::Selection::validate):
              * khtml/editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyExtendingLeftBackward):
              - character selection backward from after table selects the table
              (WebCore::showTree):
              * khtml/editing/composite_edit_command.cpp:
              (WebCore::CompositeEditCommand::removeFullySelectedNode):
              - make sure empty cell has some height
              (WebCore::CompositeEditCommand::positionOutsideTabSpan):
              - check for !isTabSpanTextNode() to make calling this function easier
              (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
              * khtml/editing/delete_selection_command.cpp:
              (WebCore::positionBeforePossibleContainingSpecialElement):
              (WebCore::positionAfterPossibleContainingSpecialElement):
              (WebCore::DeleteSelectionCommand::initializeStartEnd):
              - new.  more consistent handling of special element boundaries.
              (WebCore::DeleteSelectionCommand::initializePositionData):
              (WebCore::DeleteSelectionCommand::handleGeneralDelete):
              - handle childless block (e.g. empty table cell)
              - allow merging across list items
              (WebCore::DeleteSelectionCommand::moveNodesAfterNode):
              - use new isEmpty() method for renderers, to handle empty list items
              * khtml/editing/delete_selection_command.h:
              * khtml/editing/htmlediting.cpp:
              (WebCore::isAtomicNode):
              (WebCore::editingIgnoresContent):
              - new.  smarter check than isReplaced()
              (WebCore::rangeCompliantEquivalent):
              (WebCore::maxDeepOffset):
              (WebCore::isFirstVisiblePositionInSpecialElement):
              (WebCore::positionBeforeContainingSpecialElement):
              (WebCore::isLastVisiblePositionInSpecialElement):
              (WebCore::positionAfterContainingSpecialElement):
              (WebCore::positionOutsideContainingSpecialElement):
              (WebCore::positionBeforeNode):
              (WebCore::positionAfterNode):
              (WebCore::isListElement):
              (WebCore::isTableElement):
              (WebCore::isFirstVisiblePositionAfterTableElement):
              (WebCore::positionBeforePrecedingTableElement):
              (WebCore::positionAvoidingSpecialElementBoundary):
              * khtml/editing/htmlediting.h:
              * khtml/editing/insert_line_break_command.cpp:
              (khtml::InsertLineBreakCommand::doApply):
              * khtml/editing/insert_paragraph_separator_command.cpp:
              (khtml::InsertParagraphSeparatorCommand::doApply):
              * khtml/editing/insert_text_command.cpp:
              (khtml::InsertTextCommand::prepareForTextInsertion):
              (khtml::InsertTextCommand::input):
              * khtml/editing/replace_selection_command.cpp:
              (WebCore::isMailPasteAsQuotationNode):
              (WebCore::ReplacementFragment::countRenderedBlocks):
              (WebCore::ReplaceSelectionCommand::doApply):
              - allow for fact that fragments have no VisiblePositions
              * khtml/editing/visible_position.cpp:
              (khtml::VisiblePosition::isCandidate):
              (khtml::showTree):
              (khtml::makeRange):
              (khtml::setStart):
              (khtml::setEnd):
              * khtml/editing/visible_position.h:
              * khtml/editing/visible_units.cpp:
              (khtml::previousBoundary):
              (khtml::nextBoundary):
              (khtml::startOfLine):
              - allow for fact that renderers for list markers and other generated content
                have no corresponding NodeImpl.
              (khtml::endOfLine):
              - ditto
              (khtml::nextLinePosition):
              (khtml::startOfParagraph):
              (khtml::endOfParagraph):
              * khtml/xml/ContainerNodeImpl.cpp:
              (WebCore::ContainerNodeImpl::getUpperLeftCorner):
              (WebCore::ContainerNodeImpl::childNode):
              * khtml/xml/ContainerNodeImpl.h:
              * khtml/xml/NodeImpl.cpp:
              (WebCore::NodeImpl::childNode):
              (WebCore::NodeImpl::traversePreviousNode):
              (WebCore::NodeImpl::nextEditable):
              (WebCore::showTree):
              * khtml/xml/NodeImpl.h:
              * khtml/xml/dom_position.cpp:
              (DOM::Position::upstream):
              (DOM::Position::downstream):
              (DOM::Position::inRenderedContent):
              (DOM::showTree):
              * khtml/xml/dom_position.h:
              * rendering/render_canvas.cpp:
              (RenderCanvas::selectionRect):
              * rendering/render_list.cpp:
              (RenderListItem::calcListValue):
              (RenderListItem::isEmpty):
              (getParentOfFirstLineBox):
              (RenderListItem::resetMarkerValue):
              (RenderListItem::updateMarkerLocation):
              * rendering/render_list.h:
              (khtml::RenderListMarker::isListMarker):
              * rendering/render_object.cpp:
              (WebCore::RenderObject::nextRenderer):
              (WebCore::RenderObject::previousRenderer):
              (WebCore::showTree):
              * rendering/render_object.h:
              (WebCore::RenderObject::getBaselineOfLastLineBox):
              (WebCore::RenderObject::isEmpty):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dec5e09b
  31. 11 Jan, 2006 1 commit
    • justing's avatar
      Reviewed by darin · 0c7f1d7b
      justing authored
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=5870>
              Double-clicking on an SVG dies in HTML editing code
              <rdar://problem/4393815>
              Assertion failure: result != *this (khtml::VisiblePosition::previous())
              + build bustage fix from previous checkin
      
              Tests added (+ expected results):
              * editing/selection/iframe.html: Added.
              * editing/selection/inline-table.html: Added.
              * editing/selection/select-box.html: Added.
              
              Test results changed (change looks funny but is correct):
              * editing/inserting/editing-empty-divs.html
              
              Account for replaced elements with children in isCandidate and maxDeepOffset
              Stop at candidates in VisiblePosition::deepEquivalent, descending will
              yield positions that aren't visually equivalent.
              Fixed a caret painting regression (removed downstreamDeepEquivalent)
              Moved isAtomicNode and maxDeepOffset out of NodeImpl
              Removed redundant code
              
              Todo: 
              Move more editing functions out of NodeImpl
              Improve the selection of VP candidates to fix 6476
      
              * khtml/editing/SelectionController.cpp:
              (khtml::SelectionController::SelectionController):
              (khtml::SelectionController::xPosForVerticalArrowNavigation):
              (khtml::SelectionController::getRangeAt):
              (khtml::SelectionController::layout):
              (khtml::SelectionController::adjustForEditableContent):
              * khtml/editing/apply_style_command.cpp:
              (khtml::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
              (khtml::ApplyStyleCommand::mergeEndWithNextIfIdentical):
              * khtml/editing/delete_selection_command.cpp:
              (khtml::DeleteSelectionCommand::handleSpecialCaseBRDelete):
              (khtml::DeleteSelectionCommand::handleGeneralDelete):
              * khtml/editing/htmlediting.cpp:
              (khtml::isAtomicNode):
              (khtml::maxDeepOffset):
              (khtml::isLastVisiblePositionInSpecialElement):
              (khtml::positionAfterContainingSpecialElement):
              * khtml/editing/htmlediting.h:
              * khtml/editing/insert_line_break_command.cpp:
              (khtml::InsertLineBreakCommand::doApply):
              * khtml/editing/replace_selection_command.cpp:
              (khtml::ReplaceSelectionCommand::fixupNodeStyles):
              (khtml::ReplaceSelectionCommand::doApply):
              * khtml/editing/visible_position.cpp:
              (khtml::VisiblePosition::previousVisiblePosition):
              (khtml::VisiblePosition::isCandidate):
              (khtml::VisiblePosition::deepEquivalent):
              (khtml::VisiblePosition::character):
              (khtml::makeRange):
              (khtml::setStart):
              (khtml::setEnd):
              (khtml::enclosingBlockFlowElement):
              (khtml::isFirstVisiblePositionInNode):
              (khtml::isLastVisiblePositionInNode):
              * khtml/editing/visible_position.h:
              (khtml::VisiblePosition::setAffinity):
              * khtml/editing/visible_units.cpp:
              (khtml::previousLinePosition):
              (khtml::nextLinePosition):
              * khtml/xml/dom2_rangeimpl.cpp:
              (DOM::RangeImpl::editingStartPosition):
              * khtml/xml/dom_nodeimpl.cpp:
              (DOM::NodeImpl::previousNodeConsideringAtomicNodes):
              (DOM::NodeImpl::nextNodeConsideringAtomicNodes):
              (DOM::NodeImpl::previousLeafNode):
              (DOM::NodeImpl::nextLeafNode):
              (DOM::NodeImpl::isBlockFlowOrBlockTable):
              (DOM::NodeImpl::enclosingBlockFlowOrTableElement):
              * khtml/xml/dom_nodeimpl.h:
              * khtml/xml/dom_position.cpp:
              (DOM::Position::previous):
              (DOM::Position::next):
              (DOM::Position::atEnd):
              (DOM::isStreamer):
              (DOM::Position::upstream):
              (DOM::Position::downstream):
              * khtml/xml/dom_position.h:
              * kwq/KWQAccObject.mm:
              (-[KWQAccObject doAXUIElementForTextMarker:]):
              * page/Frame.cpp:
              (Frame::selectContentsOfNode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c7f1d7b
  32. 16 Sep, 2005 1 commit
    • adele's avatar
      JavaScriptCore: · 704e8bb4
      adele authored
              Change by Darin, reviewed by me and Maciej.
      
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547
              use int instead of long for 32-bit (to prepare for LP64 compiling)
      
              * bindings/c/c_class.h:
              (KJS::Bindings::CClass::constructorAt):
              (KJS::Bindings::CClass::numConstructors):
              * bindings/c/c_runtime.h:
              (KJS::Bindings::CMethod::numParameters):
              * bindings/jni/jni_class.cpp:
              (JavaClass::JavaClass):
              * bindings/jni/jni_class.h:
              (KJS::Bindings::JavaClass::constructorAt):
              (KJS::Bindings::JavaClass::numConstructors):
              * bindings/jni/jni_instance.cpp:
              (JavaInstance::invokeMethod):
              * bindings/jni/jni_jsobject.cpp:
              (JSObject::convertJObjectToValue):
              (JSObject::listFromJArray):
              * bindings/jni/jni_runtime.cpp:
              (JavaMethod::JavaMethod):
              * bindings/jni/jni_runtime.h:
              (KJS::Bindings::JavaConstructor::_commonCopy):
              (KJS::Bindings::JavaConstructor::parameterAt):
              (KJS::Bindings::JavaConstructor::numParameters):
              (KJS::Bindings::JavaMethod::_commonCopy):
              (KJS::Bindings::JavaMethod::parameterAt):
              (KJS::Bindings::JavaMethod::numParameters):
              * bindings/npapi.h:
              * bindings/objc/WebScriptObject.mm:
              (listFromNSArray):
              * bindings/objc/objc_class.h:
              (KJS::Bindings::ObjcClass::constructorAt):
              (KJS::Bindings::ObjcClass::numConstructors):
              * bindings/objc/objc_instance.h:
              * bindings/objc/objc_runtime.h:
              * bindings/objc/objc_runtime.mm:
              (ObjcMethod::numParameters):
              * bindings/runtime.h:
              * kjs/identifier.h:
              * kjs/internal.h:
              * kjs/property_slot.h:
              (KJS::PropertySlot::setCustomIndex):
              (KJS::PropertySlot::index):
              (KJS::PropertySlot::):
              * kjs/regexp_object.cpp:
              (RegExpObjectImp::backrefGetter):
              (RegExpObjectImp::getOwnPropertySlot):
              * kjs/simple_number.h:
              (KJS::SimpleNumber::):
              (KJS::SimpleNumber::value):
              (KJS::SimpleNumber::fits):
              (KJS::SimpleNumber::integerFits):
              (KJS::SimpleNumber::make):
              * kjs/string_object.cpp:
              (substituteBackreferences):
              * kjs/ustring.cpp:
              (KJS::UString::from):
              (KJS::UString::toUInt32):
              (KJS::UString::find):
              (KJS::UString::rfind):
              * kjs/ustring.h:
              * kjs/value.cpp:
              (KJS::jsNumber):
              * kjs/value.h:
      
      WebCore:
      
              Change by Darin, reviewed by me and Maciej.
      
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547
              use int instead of long for 32-bit (to prepare for LP64 compiling)
      
              Changed longs (which IDL files use as 32-bit) to ints
      
              * ForwardingHeaders/khtml_pagecache.h:
              * khtml/css/css_base.h:
              (DOM::StyleListImpl::length):
              (DOM::StyleListImpl::item):
              * khtml/css/css_computedstyle.cpp:
              (DOM::CSSComputedStyleDeclarationImpl::length):
              (DOM::CSSComputedStyleDeclarationImpl::item):
              * khtml/css/css_computedstyle.h:
              * khtml/css/css_ruleimpl.cpp:
              (CSSMediaRuleImpl::append):
              (CSSMediaRuleImpl::insertRule):
              (CSSMediaRuleImpl::cssText):
              (CSSRuleListImpl::CSSRuleListImpl):
              (CSSRuleListImpl::deleteRule):
              (CSSRuleListImpl::insertRule):
              * khtml/css/css_ruleimpl.h:
              (DOM::CSSRuleListImpl::length):
              (DOM::CSSRuleListImpl::item):
              (DOM::CSSMediaRuleImpl::deleteRule):
              * khtml/css/css_stylesheetimpl.cpp:
              (CSSStyleSheetImpl::insertRule):
              (CSSStyleSheetImpl::addRule):
              (CSSStyleSheetImpl::deleteRule):
              (StyleSheetListImpl::length):
              (StyleSheetListImpl::item):
              * khtml/css/css_stylesheetimpl.h:
              (DOM::MediaListImpl::length):
              (DOM::MediaListImpl::item):
              * khtml/css/css_valueimpl.cpp:
              (DOM::CSSMutableStyleDeclarationImpl::length):
              (DOM::CSSMutableStyleDeclarationImpl::item):
              * khtml/css/css_valueimpl.h:
              (DOM::CSSValueListImpl::length):
              (DOM::CSSValueListImpl::item):
              * khtml/dom/css_rule.h:
              * khtml/dom/css_stylesheet.h:
              * khtml/dom/css_value.h:
              * khtml/dom/dom2_events.cpp:
              (DOM::UIEvent::detail):
              (DOM::UIEvent::initUIEvent):
              (DOM::MouseEvent::screenX):
              (DOM::MouseEvent::screenY):
              (DOM::MouseEvent::clientX):
              (DOM::MouseEvent::clientY):
              (DOM::MouseEvent::initMouseEvent):
              (DOM::KeyboardEvent::keyLocation):
              (DOM::KeyboardEvent::initKeyboardEvent):
              * khtml/dom/dom2_events.h:
              * khtml/dom/dom2_range.h:
              * khtml/dom/dom2_traversal.cpp:
              (DOM::NodeIterator::whatToShow):
              (DOM::TreeWalker::whatToShow):
              * khtml/dom/dom2_traversal.h:
              * khtml/dom/dom_node.h:
              * khtml/ecma/kjs_css.cpp:
              (KJS::DOMCSSStyleDeclaration::getOwnPropertySlot):
              (KJS::DOMStyleSheetList::getOwnPropertySlot):
              (KJS::DOMMediaList::getOwnPropertySlot):
              (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction):
              (KJS::DOMCSSRuleList::getOwnPropertySlot):
              (KJS::DOMCSSValueList::getOwnPropertySlot):
              * khtml/ecma/kjs_dom.cpp:
              (KJS::DOMNodeList::getOwnPropertySlot):
              (KJS::DOMNodeList::callAsFunction):
              (KJS::DOMNamedNodeMap::getOwnPropertySlot):
              (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
              * khtml/ecma/kjs_events.cpp:
              (KJS::DOMEvent::getValueProperty):
              * khtml/ecma/kjs_html.cpp:
              (KJS::HTMLElement::getOwnPropertySlot):
              (KJS::KJS::HTMLElement::put):
              (KJS::HTMLCollection::getOwnPropertySlot):
              (KJS::KJS::HTMLCollection::callAsFunction):
              (KJS::KJS::HTMLSelectCollection::put):
              * khtml/ecma/kjs_navigator.cpp:
              (KJS::Plugins::getOwnPropertySlot):
              (KJS::MimeTypes::getOwnPropertySlot):
              (KJS::Plugin::getOwnPropertySlot):
              * khtml/editing/apply_style_command.cpp:
              (khtml::ApplyStyleCommand::splitTextAtStartIfNeeded):
              (khtml::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
              (khtml::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
              * khtml/editing/break_blockquote_command.cpp:
              (khtml::BreakBlockquoteCommand::doApply):
              * khtml/editing/composite_edit_command.cpp:
              (khtml::CompositeEditCommand::insertNodeAt):
              (khtml::CompositeEditCommand::splitTextNode):
              (khtml::CompositeEditCommand::splitTextNodeContainingElement):
              (khtml::CompositeEditCommand::insertTextIntoNode):
              (khtml::CompositeEditCommand::deleteTextFromNode):
              (khtml::CompositeEditCommand::replaceTextInNode):
              (khtml::CompositeEditCommand::deleteInsignificantText):
              * khtml/editing/composite_edit_command.h:
              * khtml/editing/delete_from_text_node_command.cpp:
              (khtml::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
              * khtml/editing/delete_from_text_node_command.h:
              (khtml::DeleteFromTextNodeCommand::offset):
              (khtml::DeleteFromTextNodeCommand::count):
              * khtml/editing/insert_into_text_node_command.cpp:
              (khtml::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
              * khtml/editing/insert_into_text_node_command.h:
              (khtml::InsertIntoTextNodeCommand::offset):
              * khtml/editing/insert_paragraph_separator_command.cpp:
              (khtml::InsertParagraphSeparatorCommand::doApply):
              * khtml/editing/insert_text_command.cpp:
              (khtml::InsertTextCommand::input):
              (khtml::InsertTextCommand::insertSpace):
              * khtml/editing/insert_text_command.h:
              (khtml::InsertTextCommand::charactersAdded):
              * khtml/editing/join_text_nodes_command.h:
              * khtml/editing/markup.cpp:
              (khtml::startMarkup):
              (khtml::completeURLs):
              * khtml/editing/move_selection_command.cpp:
              (khtml::MoveSelectionCommand::doApply):
              * khtml/editing/rebalance_whitespace_command.cpp:
              (khtml::RebalanceWhitespaceCommand::doApply):
              * khtml/editing/rebalance_whitespace_command.h:
              * khtml/editing/replace_selection_command.cpp:
              (khtml::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
              * khtml/editing/replace_selection_command.h:
              * khtml/editing/selection.cpp:
              (khtml::Selection::debugPosition):
              * khtml/editing/split_text_node_command.cpp:
              (khtml::SplitTextNodeCommand::SplitTextNodeCommand):
              * khtml/editing/split_text_node_command.h:
              (khtml::SplitTextNodeCommand::offset):
              * khtml/editing/split_text_node_containing_element.cpp:
              (khtml::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
              * khtml/editing/split_text_node_containing_element_command.h:
              * khtml/editing/visible_position.cpp:
              (khtml::VisiblePosition::VisiblePosition):
              (khtml::VisiblePosition::deepEquivalent):
              (khtml::VisiblePosition::rangeCompliantEquivalent):
              (khtml::VisiblePosition::maxOffset):
              (khtml::VisiblePosition::character):
              (khtml::VisiblePosition::debugPosition):
              * khtml/editing/visible_position.h:
              * khtml/editing/visible_range.h:
              * khtml/editing/visible_text.cpp:
              (khtml::CircularSearchBuffer::length):
              (khtml::TextIterator::TextIterator):
              (khtml::TextIterator::handleTextNode):
              (khtml::TextIterator::handleTextBox):
              (khtml::TextIterator::emitCharacter):
              (khtml::TextIterator::range):
              (khtml::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
              (khtml::SimplifiedBackwardsTextIterator::handleReplacedElement):
              (khtml::SimplifiedBackwardsTextIterator::emitCharacter):
              (khtml::SimplifiedBackwardsTextIterator::emitNewlineForBROrText):
              (khtml::CharacterIterator::range):
              (khtml::CharacterIterator::advance):
              (khtml::CharacterIterator::string):
              (khtml::WordAwareIterator::length):
              (khtml::CircularSearchBuffer::append):
              (khtml::CircularSearchBuffer::neededCharacters):
              (khtml::CircularSearchBuffer::isMatch):
              (khtml::TextIterator::rangeLength):
              (khtml::TextIterator::rangeFromLocationAndLength):
              (khtml::plainText):
              (khtml::findPlainText):
              * khtml/editing/visible_text.h:
              (khtml::TextIterator::length):
              (khtml::SimplifiedBackwardsTextIterator::length):
              (khtml::CharacterIterator::length):
              (khtml::CharacterIterator::characterOffset):
              * khtml/editing/visible_units.cpp:
              (khtml::startOfLine):
              (khtml::endOfLine):
              (khtml::startOfParagraph):
              (khtml::endOfParagraph):
              * khtml/html/html_blockimpl.cpp:
              (HTMLPreElementImpl::width):
              (HTMLPreElementImpl::setWidth):
              * khtml/html/html_blockimpl.h:
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLFormElementImpl::length):
              (DOM::HTMLGenericFormElementImpl::tabIndex):
              (DOM::HTMLGenericFormElementImpl::setTabIndex):
              (DOM::HTMLInputElementImpl::selectionStart):
              (DOM::HTMLInputElementImpl::selectionEnd):
              (DOM::HTMLInputElementImpl::setSelectionStart):
              (DOM::HTMLInputElementImpl::setSelectionEnd):
              (DOM::HTMLInputElementImpl::setSelectionRange):
              (DOM::HTMLInputElementImpl::setMaxLength):
              (DOM::HTMLInputElementImpl::setSize):
              (DOM::HTMLSelectElementImpl::selectedIndex):
              (DOM::HTMLSelectElementImpl::setSelectedIndex):
              (DOM::HTMLSelectElementImpl::length):
              (DOM::HTMLSelectElementImpl::remove):
              (DOM::HTMLSelectElementImpl::setSize):
              (DOM::HTMLOptionElementImpl::index):
              (DOM::HTMLOptionElementImpl::setIndex):
              (DOM::HTMLTextAreaElementImpl::selectionStart):
              (DOM::HTMLTextAreaElementImpl::selectionEnd):
              (DOM::HTMLTextAreaElementImpl::setSelectionStart):
              (DOM::HTMLTextAreaElementImpl::setSelectionEnd):
              (DOM::HTMLTextAreaElementImpl::setSelectionRange):
              (DOM::HTMLTextAreaElementImpl::setCols):
              (DOM::HTMLTextAreaElementImpl::setRows):
              (DOM::HTMLOptionsCollectionImpl::length):
              (DOM::HTMLOptionsCollectionImpl::setLength):
              (DOM::HTMLOptionsCollectionImpl::item):
              * khtml/html/html_formimpl.h:
              (DOM::HTMLInputElementImpl::maxLength):
              (DOM::HTMLInputElementImpl::maxResults):
              (DOM::HTMLSelectElementImpl::minWidth):
              (DOM::HTMLSelectElementImpl::size):
              (DOM::HTMLTextAreaElementImpl::cols):
              (DOM::HTMLTextAreaElementImpl::rows):
              * khtml/html/html_imageimpl.cpp:
              (HTMLImageElementImpl::width):
              (HTMLImageElementImpl::height):
              (HTMLImageElementImpl::border):
              (HTMLImageElementImpl::setBorder):
              (HTMLImageElementImpl::setHeight):
              (HTMLImageElementImpl::hspace):
              (HTMLImageElementImpl::setHspace):
              (HTMLImageElementImpl::vspace):
              (HTMLImageElementImpl::setVspace):
              (HTMLImageElementImpl::setWidth):
              (HTMLImageElementImpl::x):
              (HTMLImageElementImpl::y):
              (HTMLAreaElementImpl::tabIndex):
              (HTMLAreaElementImpl::setTabIndex):
              * khtml/html/html_imageimpl.h:
              * khtml/html/html_inlineimpl.cpp:
              (DOM::HTMLAnchorElementImpl::tabIndex):
              (DOM::HTMLAnchorElementImpl::setTabIndex):
              * khtml/html/html_inlineimpl.h:
              * khtml/html/html_listimpl.cpp:
              (DOM::HTMLOListElementImpl::setStart):
              (DOM::HTMLLIElementImpl::value):
              (DOM::HTMLLIElementImpl::setValue):
              * khtml/html/html_listimpl.h:
              (DOM::HTMLUListElementImpl::start):
              (DOM::HTMLOListElementImpl::start):
              * khtml/html/html_miscimpl.cpp:
              (DOM::HTMLCollectionImpl::calcLength):
              (DOM::HTMLCollectionImpl::length):
              (DOM::HTMLCollectionImpl::item):
              (DOM::HTMLFormCollectionImpl::calcLength):
              (DOM::HTMLFormCollectionImpl::item):
              * khtml/html/html_miscimpl.h:
              * khtml/html/html_objectimpl.cpp:
              (DOM::HTMLObjectElementImpl::tabIndex):
              (DOM::HTMLObjectElementImpl::setTabIndex):
              * khtml/html/html_objectimpl.h:
              * khtml/html/html_tableimpl.cpp:
              (DOM::HTMLTableElementImpl::insertRow):
              (DOM::HTMLTableElementImpl::deleteRow):
              (DOM::HTMLTableSectionElementImpl::insertRow):
              (DOM::HTMLTableSectionElementImpl::deleteRow):
              (DOM::HTMLTableRowElementImpl::rowIndex):
              (DOM::HTMLTableRowElementImpl::sectionRowIndex):
              (DOM::HTMLTableRowElementImpl::insertCell):
              (DOM::HTMLTableRowElementImpl::deleteCell):
              (DOM::HTMLTableCellElementImpl::cellIndex):
              (DOM::HTMLTableCellElementImpl::setColSpan):
              (DOM::HTMLTableCellElementImpl::setRowSpan):
              (DOM::HTMLTableColElementImpl::setSpan):
              * khtml/html/html_tableimpl.h:
              (DOM::HTMLTableColElementImpl::span):
              * khtml/html/htmlparser.cpp:
              (HTMLParser::handleError):
              * khtml/html/htmltokenizer.cpp:
              (khtml::HTMLTokenizer::processToken):
              * khtml/khtml_events.cpp:
              (khtml::MouseEvent::offset):
              * khtml/khtml_events.h:
              (khtml::MouseReleaseEvent::MouseReleaseEvent):
              * khtml/khtml_part.cpp:
              (KHTMLPart::restoreURL):
              (KHTMLPart::stopLoading):
              (KHTMLPart::receivedFirstData):
              (KHTMLPart::slotFinished):
              (KHTMLPart::begin):
              (KHTMLPart::slotViewFrameSource):
              (KHTMLPart::selectFrameElementInParentIfFullySelected):
              * khtml/khtml_part.h:
              * khtml/khtmlpart_p.h:
              (KHTMLPartPrivate::KHTMLPartPrivate):
              * khtml/misc/loader.h:
              * khtml/rendering/render_block.cpp:
              (khtml::RenderBlock::positionForRenderer):
              * khtml/rendering/render_br.cpp:
              (RenderBR::caretMinOffset):
              (RenderBR::caretMaxOffset):
              (RenderBR::caretMaxRenderedOffset):
              (RenderBR::inlineBox):
              * khtml/rendering/render_br.h:
              * khtml/rendering/render_form.cpp:
              (RenderLineEdit::selectionStart):
              (RenderLineEdit::selectionEnd):
              (RenderLineEdit::setSelectionStart):
              (RenderLineEdit::setSelectionEnd):
              (RenderLineEdit::setSelectionRange):
              (RenderTextArea::calcMinMaxWidth):
              (RenderTextArea::selectionStart):
              (RenderTextArea::selectionEnd):
              (RenderTextArea::setSelectionStart):
              (RenderTextArea::setSelectionEnd):
              (RenderTextArea::setSelectionRange):
              * khtml/rendering/render_form.h:
              * khtml/rendering/render_frames.cpp:
              (RenderPartObject::updateWidget):
              * khtml/rendering/render_line.cpp:
              (khtml::InlineBox::caretMinOffset):
              (khtml::InlineBox::caretMaxOffset):
              (khtml::InlineBox::caretMaxRenderedOffset):
              * khtml/rendering/render_line.h:
              * khtml/rendering/render_list.cpp:
              (RenderListMarker::calcMinMaxWidth):
              * khtml/rendering/render_list.h:
              (khtml::RenderListItem::value):
              (khtml::RenderListItem::setValue):
              * khtml/rendering/render_object.cpp:
              (RenderObject::caretMinOffset):
              (RenderObject::caretMaxOffset):
              (RenderObject::caretMaxRenderedOffset):
              (RenderObject::previousOffset):
              (RenderObject::nextOffset):
              (RenderObject::inlineBox):
              * khtml/rendering/render_object.h:
              * khtml/rendering/render_replaced.cpp:
              (RenderReplaced::caretMinOffset):
              (RenderReplaced::caretMaxOffset):
              (RenderReplaced::caretMaxRenderedOffset):
              * khtml/rendering/render_replaced.h:
              * khtml/rendering/render_table.h:
              (khtml::RenderTableCell::cellIndex):
              (khtml::RenderTableCell::setCellIndex):
              * khtml/rendering/render_text.cpp:
              (InlineTextBox::paintMarker):
              (InlineTextBox::paintMarkedTextUnderline):
              (InlineTextBox::caretMinOffset):
              (InlineTextBox::caretMaxOffset):
              (InlineTextBox::caretMaxRenderedOffset):
              (RenderText::previousOffset):
              (RenderText::nextOffset):
              (InlineTextBox::positionForOffset):
              (RenderText::caretMinOffset):
              (RenderText::caretMaxOffset):
              (RenderText::caretMaxRenderedOffset):
              (RenderText::inlineBox):
              * khtml/rendering/render_text.h:
              * khtml/xml/dom2_eventsimpl.cpp:
              (DOM::EventImpl::timeStamp):
              (DOM::UIEventImpl::UIEventImpl):
              (DOM::UIEventImpl::initUIEvent):
              (DOM::UIEventImpl::layerX):
              (DOM::UIEventImpl::layerY):
              (DOM::UIEventImpl::pageX):
              (DOM::UIEventImpl::pageY):
              (DOM::UIEventImpl::which):
              (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl):
              (DOM::MouseRelatedEventImpl::pageX):
              (DOM::MouseRelatedEventImpl::pageY):
              (DOM::MouseEventImpl::MouseEventImpl):
              (DOM::MouseEventImpl::initMouseEvent):
              (DOM::MouseEventImpl::which):
              (DOM::KeyboardEventImpl::KeyboardEventImpl):
              (DOM::KeyboardEventImpl::initKeyboardEvent):
              (DOM::KeyboardEventImpl::which):
              (DOM::WheelEventImpl::WheelEventImpl):
              * khtml/xml/dom2_eventsimpl.h:
              (DOM::UIEventImpl::detail):
              (DOM::UIEventWithKeyStateImpl::UIEventWithKeyStateImpl):
              (DOM::MouseRelatedEventImpl::screenX):
              (DOM::MouseRelatedEventImpl::screenY):
              (DOM::MouseRelatedEventImpl::clientX):
              (DOM::MouseRelatedEventImpl::clientY):
              (DOM::MouseRelatedEventImpl::layerX):
              (DOM::MouseRelatedEventImpl::layerY):
              (DOM::KeyboardEventImpl::keyLocation):
              (DOM::WheelEventImpl::wheelDelta):
              * khtml/xml/dom2_rangeimpl.cpp:
              (DOM::RangeImpl::RangeImpl):
              (DOM::RangeImpl::startOffset):
              (DOM::RangeImpl::endOffset):
              (DOM::RangeImpl::setStart):
              (DOM::RangeImpl::setEnd):
              (DOM::RangeImpl::compareBoundaryPoints):
              (DOM::RangeImpl::processContents):
              (DOM::RangeImpl::checkNodeWOffset):
              * khtml/xml/dom2_rangeimpl.h:
              * khtml/xml/dom2_traversalimpl.cpp:
              (DOM::TraversalImpl::TraversalImpl):
              (DOM::TreeWalkerImpl::TreeWalkerImpl):
              * khtml/xml/dom2_traversalimpl.h:
              (DOM::TraversalImpl::whatToShow):
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::createNodeIterator):
              (DocumentImpl::createTreeWalker):
              (DocumentImpl::processHttpEquiv):
              (DocumentImpl::removeMarkers):
              (DocumentImpl::copyMarkers):
              (DocumentImpl::markersForNode):
              (DocumentImpl::shiftMarkers):
              * khtml/xml/dom_docimpl.h:
              * khtml/xml/dom_elementimpl.cpp:
              (ElementImpl::openTagStartToString):
              (NamedAttrMapImpl::item):
              (NamedAttrMapImpl::getAttributeItem):
              (NamedAttrMapImpl::removeAttribute):
              * khtml/xml/dom_elementimpl.h:
              (DOM::NamedAttrMapImpl::length):
              (DOM::NamedAttrMapImpl::attributeItem):
              (DOM::NamedMappedAttrMapImpl::attributeItem):
              * khtml/xml/dom_nodeimpl.cpp:
              (DOM::NodeImpl::normalize):
              (DOM::NodeImpl::nodeIndex):
              (DOM::NodeImpl::childNodeCount):
              (DOM::NodeImpl::childNode):
              (DOM::NodeImpl::maxOffset):
              (DOM::NodeImpl::maxDeepOffset):
              (DOM::NodeImpl::caretMinOffset):
              (DOM::NodeImpl::caretMaxOffset):
              (DOM::NodeImpl::caretMaxRenderedOffset):
              (DOM::NodeImpl::previousOffset):
              (DOM::NodeImpl::nextOffset):
              (DOM::ContainerNodeImpl::childNodeCount):
              (DOM::ContainerNodeImpl::childNode):
              (DOM::NodeListImpl::recursiveLength):
              (DOM::NodeListImpl::recursiveItem):
              (DOM::NodeListImpl::itemById):
              (DOM::ChildNodeListImpl::length):
              (DOM::ChildNodeListImpl::item):
              (DOM::TagNodeListImpl::length):
              (DOM::TagNodeListImpl::item):
              (DOM::NameNodeListImpl::length):
              (DOM::NameNodeListImpl::item):
              * khtml/xml/dom_nodeimpl.h:
              * khtml/xml/dom_position.cpp:
              (DOM::Position::Position):
              (DOM::Position::previous):
              (DOM::Position::next):
              (DOM::Position::renderedOffset):
              (DOM::Position::equivalentRangeCompliantPosition):
              (DOM::Position::rendersInDifferentPosition):
              (DOM::Position::trailingWhitespacePosition):
              (DOM::Position::debugPosition):
              * khtml/xml/dom_position.h:
              (DOM::Position::offset):
              * khtml/xml/dom_textimpl.cpp:
              (CharacterDataImpl::length):
              (CharacterDataImpl::substringData):
              (CharacterDataImpl::insertData):
              (CharacterDataImpl::deleteData):
              (CharacterDataImpl::replaceData):
              (CharacterDataImpl::checkCharDataOperation):
              (CharacterDataImpl::maxOffset):
              (CharacterDataImpl::caretMinOffset):
              (CharacterDataImpl::caretMaxOffset):
              (CharacterDataImpl::caretMaxRenderedOffset):
              (TextImpl::splitText):
              * khtml/xml/dom_textimpl.h:
              * kwq/DOM-CSS.mm:
              (-[DOMStyleSheetList length]):
              (-[DOMStyleSheetList item:]):
              (-[DOMCSSStyleSheet insertRule::]):
              (-[DOMCSSStyleSheet deleteRule:]):
              (-[DOMMediaList length]):
              (-[DOMMediaList item:]):
              (-[DOMCSSRuleList length]):
              (-[DOMCSSRuleList item:]):
              (-[DOMCSSMediaRule insertRule::]):
              (-[DOMCSSMediaRule deleteRule:]):
              (-[DOMCSSStyleDeclaration length]):
              (-[DOMCSSStyleDeclaration item:]):
              (-[DOMCSSValueList length]):
              (-[DOMCSSValueList item:]):
              * kwq/DOM.mm:
              (-[DOMNamedNodeMap item:]):
              (-[DOMNamedNodeMap length]):
              (-[DOMNodeList item:]):
              (-[DOMNodeList length]):
              (-[DOMCharacterData length]):
              (-[DOMCharacterData substringData::]):
              (-[DOMCharacterData insertData::]):
              (-[DOMCharacterData deleteData::]):
              (-[DOMCharacterData replaceData:::]):
              (-[DOMText splitText:]):
              (-[DOMRange description]):
              (-[DOMRange startOffset]):
              (-[DOMRange endOffset]):
              (-[DOMRange setStart::]):
              (-[DOMRange setEnd::]):
              (-[DOMNodeIterator whatToShow]):
              (-[DOMTreeWalker whatToShow]):
              (-[DOMDocument createNodeIterator::::]):
              (-[DOMDocument createTreeWalker::::]):
              * kwq/DOMCSS.h:
              * kwq/DOMCore.h:
              * kwq/DOMEvents.h:
              (-[DOMMouseEvent initMouseEvent:::::::::::::::]):
              * kwq/DOMEvents.mm:
              (-[DOMMouseEvent screenX]):
              (-[DOMMouseEvent screenY]):
              (-[DOMMouseEvent clientX]):
              (-[DOMMouseEvent clientY]):
              (-[DOMMouseEvent initMouseEvent:::::::::::::::]):
              (-[DOMUIEvent detail]):
              (-[DOMUIEvent initUIEvent:::::]):
              * kwq/DOMExtensions.h:
              * kwq/DOMHTML.h:
              * kwq/DOMHTML.mm:
              (-[DOMHTMLCollection length]):
              (-[DOMHTMLCollection item:]):
              (-[DOMHTMLOptionsCollection length]):
              (-[DOMHTMLOptionsCollection setLength:]):
              (-[DOMHTMLOptionsCollection item:]):
              (-[DOMHTMLFormElement length]):
              (-[DOMHTMLSelectElement selectedIndex]):
              (-[DOMHTMLSelectElement setSelectedIndex:]):
              (-[DOMHTMLSelectElement length]):
              (-[DOMHTMLSelectElement setLength:]):
              (-[DOMHTMLSelectElement size]):
              (-[DOMHTMLSelectElement setSize:]):
              (-[DOMHTMLSelectElement tabIndex]):
              (-[DOMHTMLSelectElement setTabIndex:]):
              (-[DOMHTMLSelectElement remove:]):
              (-[DOMHTMLOptionElement index]):
              (-[DOMHTMLInputElement maxLength]):
              (-[DOMHTMLInputElement setMaxLength:]):
              (-[DOMHTMLInputElement size]):
              (-[DOMHTMLInputElement setSize:]):
              (-[DOMHTMLInputElement tabIndex]):
              (-[DOMHTMLInputElement setTabIndex:]):
              (-[DOMHTMLTextAreaElement cols]):
              (-[DOMHTMLTextAreaElement setCols:]):
              (-[DOMHTMLTextAreaElement rows]):
              (-[DOMHTMLTextAreaElement setRows:]):
              (-[DOMHTMLTextAreaElement tabIndex]):
              (-[DOMHTMLTextAreaElement setTabIndex:]):
              (-[DOMHTMLButtonElement tabIndex]):
              (-[DOMHTMLButtonElement setTabIndex:]):
              (-[DOMHTMLOListElement start]):
              (-[DOMHTMLOListElement setStart:]):
              (-[DOMHTMLLIElement value]):
              (-[DOMHTMLLIElement setValue:]):
              (-[DOMHTMLPreElement width]):
              (-[DOMHTMLPreElement setWidth:]):
              (-[DOMHTMLAnchorElement tabIndex]):
              (-[DOMHTMLAnchorElement setTabIndex:]):
              (-[DOMHTMLImageElement height]):
              (-[DOMHTMLImageElement setHeight:]):
              (-[DOMHTMLImageElement hspace]):
              (-[DOMHTMLImageElement setHspace:]):
              (-[DOMHTMLImageElement vspace]):
              (-[DOMHTMLImageElement setVspace:]):
              (-[DOMHTMLImageElement width]):
              (-[DOMHTMLImageElement setWidth:]):
              (-[DOMHTMLObjectElement hspace]):
              (-[DOMHTMLObjectElement setHspace:]):
              (-[DOMHTMLObjectElement tabIndex]):
              (-[DOMHTMLObjectElement setTabIndex:]):
              (-[DOMHTMLObjectElement vspace]):
              (-[DOMHTMLObjectElement setVspace:]):
              (-[DOMHTMLAppletElement hspace]):
              (-[DOMHTMLAppletElement setHspace:]):
              (-[DOMHTMLAppletElement vspace]):
              (-[DOMHTMLAppletElement setVspace:]):
              (-[DOMHTMLAreaElement tabIndex]):
              (-[DOMHTMLAreaElement setTabIndex:]):
              (-[DOMHTMLTableSectionElement insertRow:]):
              (-[DOMHTMLTableSectionElement deleteRow:]):
              (-[DOMHTMLTableElement insertRow:]):
              (-[DOMHTMLTableElement deleteRow:]):
              (-[DOMHTMLTableColElement span]):
              (-[DOMHTMLTableColElement setSpan:]):
              (-[DOMHTMLTableRowElement rowIndex]):
              (-[DOMHTMLTableRowElement sectionRowIndex]):
              (-[DOMHTMLTableRowElement insertCell:]):
              (-[DOMHTMLTableRowElement deleteCell:]):
              (-[DOMHTMLTableCellElement cellIndex]):
              (-[DOMHTMLTableCellElement colSpan]):
              (-[DOMHTMLTableCellElement setColSpan:]):
              (-[DOMHTMLTableCellElement rowSpan]):
              (-[DOMHTMLTableCellElement setRowSpan:]):
              (-[DOMHTMLEmbedElement height]):
              (-[DOMHTMLEmbedElement setHeight:]):
              (-[DOMHTMLEmbedElement width]):
              (-[DOMHTMLEmbedElement setWidth:]):
              * kwq/DOMRange.h:
              * kwq/DOMStylesheets.h:
              * kwq/DOMTraversal.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::advanceToNextMisspelling):
              (KWQKHTMLPart::openURLFromPageCache):
              (KWQKHTMLPart::markMisspellings):
              * kwq/KWQString.h:
              * kwq/KWQString.mm:
              (QString::toShort):
              (QString::toUShort):
              (QString::toInt):
              (QString::toUInt):
              * kwq/KWQTextEdit.h:
              * kwq/KWQTextEdit.mm:
              (QTextEdit::selectionStart):
              (QTextEdit::selectionEnd):
              (QTextEdit::setSelectionStart):
              (QTextEdit::setSelectionEnd):
              (QTextEdit::setSelectionRange):
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge convertToNSRange:DOM::]):
      
      WebKit:
      
              Change by Darin, reviewed by me and Maciej.
      
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547
              use int instead of long for 32-bit (to prepare for LP64 compiling)
      
              * Plugins.subproj/npapi.m: changed types to match those defined in npapi.h
              (NPN_MemAlloc):
              (NPN_MemFlush):
              (NPN_PostURLNotify):
              (NPN_PostURL):
              (NPN_Write):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      704e8bb4
  33. 21 Jun, 2005 1 commit
    • harrison's avatar
      Reviewed by Justin. · 8cf229c1
      harrison authored
              - show class and style attributes for element nodes
              - nil check the node being showTree'd
              - add Position::showTree()
      
              Test cases added: None needed for this debug-only utility code.
      
              * khtml/editing/selection.cpp:
              (khtml::Selection::showTree):
              - nil check the node
              * khtml/editing/visible_position.cpp:
              (khtml::VisiblePosition::previousVisiblePosition):
              - comments
              (khtml::VisiblePosition::showTree):
              - nil check the node
              * khtml/xml/dom_nodeimpl.cpp:
              (appendAttributeDesc):
              (NodeImpl::showNode):
              - show class and style attributes for element nodes
              * khtml/xml/dom_position.cpp:
              (DOM::Position::showTree):
              * khtml/xml/dom_position.h:
              - add Position::showTree()
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cf229c1
  34. 13 May, 2005 1 commit
    • darin's avatar
      Reviewed by Chris Blumenberg. · 1a76dc44
      darin authored
              - more "getting off the C++ DOM wrappers" changes
                This pass involves replacing uses of DOM::Range with use of DOM::RangeImpl
                plus some more use of DOM::DocumentImpl instead of DOM::Document.
      
              * khtml/dom/dom2_range.cpp:
              * khtml/dom/dom2_range.h:
              * khtml/ecma/kjs_window.cpp:
              (KJS::Window::get):
              (KJS::WindowFunc::tryCall):
              (KJS::Window::updateLayout):
              (KJS::ScheduledAction::execute):
              (KJS::Selection::toString):
              * khtml/ecma/xmlhttprequest.cpp:
              (KJS::XMLHttpRequestProtoFunc::tryCall):
              * khtml/editing/htmlediting.cpp:
              (khtml::InsertLineBreakCommand::doApply):
              * khtml/editing/selection.cpp:
              (khtml::Selection::Selection):
              (khtml::Selection::moveTo):
              (khtml::Selection::toRange):
              * khtml/editing/selection.h:
              * khtml/editing/visible_position.cpp:
              (khtml::makeRange):
              (khtml::startVisiblePosition):
              (khtml::endVisiblePosition):
              (khtml::setStart):
              (khtml::setEnd):
              * khtml/editing/visible_position.h:
              * khtml/editing/visible_range.h:
              * khtml/editing/visible_text.cpp:
              (khtml::TextIterator::TextIterator):
              (khtml::TextIterator::range):
              (khtml::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
              (khtml::SimplifiedBackwardsTextIterator::range):
              (khtml::CharacterIterator::CharacterIterator):
              (khtml::CharacterIterator::range):
              (khtml::WordAwareIterator::WordAwareIterator):
              (khtml::WordAwareIterator::advance):
              (khtml::TextIterator::rangeLength):
              (khtml::TextIterator::rangeFromLocationAndLength):
              (khtml::plainText):
              (khtml::findPlainText):
              * khtml/editing/visible_text.h:
              (khtml::WordAwareIterator::range):
              * khtml/editing/visible_units.cpp:
              (khtml::previousBoundary):
              (khtml::nextBoundary):
              * khtml/html/html_elementimpl.cpp:
              (HTMLElementImpl::innerText):
              * khtml/html/htmltokenizer.cpp:
              (khtml::HTMLTokenizer::scriptExecution):
              * khtml/khtml_part.cpp:
              (KHTMLPart::text):
              (KHTMLPart::selectedText):
              (KHTMLPart::shouldBeginEditing):
              (KHTMLPart::shouldEndEditing):
              (KHTMLPart::selectionComputedStyle):
              * khtml/khtml_part.h:
              * khtml/khtmlview.h:
              * khtml/rendering/render_text.cpp:
              (InlineTextBox::paint):
              * khtml/xml/dom2_rangeimpl.cpp:
              (DOM::operator==):
              (DOM::rangeOfContents):
              * khtml/xml/dom2_rangeimpl.h:
              (DOM::operator!=):
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::relinquishesEditingFocus):
              (DocumentImpl::acceptsEditingFocus):
              (DocumentImpl::addMarker):
              (DocumentImpl::removeMarker):
              * khtml/xml/dom_docimpl.h:
              * khtml/xml/dom_position.cpp:
              (DOM::startPosition):
              * khtml/xml/dom_position.h:
              * kwq/DOMHTML.mm:
              (-[DOMHTMLLinkElement href]):
              (-[DOMHTMLBaseElement href]):
              (-[DOMHTMLInputElement src]):
              (-[DOMHTMLAnchorElement href]):
              (-[DOMHTMLImageElement src]):
              (-[DOMHTMLAreaElement href]):
              * kwq/KWQAccObject.mm:
              (-[KWQAccObject textUnderElement]):
              (-[KWQAccObject value]):
              (-[KWQAccObject doAXStringForTextMarkerRange:]):
              (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]):
              * kwq/KWQKHTMLPart.h:
              (KWQKHTMLPart::markedTextRange):
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::findString):
              (KWQKHTMLPart::advanceToNextMisspelling):
              (KWQKHTMLPart::fontForSelection):
              (KWQKHTMLPart::markMisspellings):
              (KWQKHTMLPart::respondToChangedSelection):
              (KWQKHTMLPart::shouldBeginEditing):
              (KWQKHTMLPart::shouldEndEditing):
              (convertAttributesToUnderlines):
              (KWQKHTMLPart::setMarkedTextRange):
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge elementAtPoint:]):
              (-[WebCoreBridge rangeByExpandingSelectionWithGranularity:]):
              (-[WebCoreBridge rangeByAlteringCurrentSelection:direction:granularity:]):
              (-[WebCoreBridge rangeByAlteringCurrentSelection:verticalDistance:]):
              (-[WebCoreBridge selectedDOMRange]):
              (-[WebCoreBridge convertToNSRange:DOM::]):
              (-[WebCoreBridge convertToDOMRange:]):
              (-[WebCoreBridge convertToObjCDOMRange:]):
              (-[WebCoreBridge selectNSRange:]):
              (-[WebCoreBridge selectedNSRange]):
              (-[WebCoreBridge markDOMRange]):
              (-[WebCoreBridge markedTextDOMRange]):
              (-[WebCoreBridge markedTextNSRange]):
              (-[WebCoreBridge replaceMarkedTextWithText:]):
              (-[WebCoreBridge smartDeleteRangeForProposedRange:]):
              (-[WebCoreBridge dragCaretDOMRange]):
              (-[WebCoreBridge editableDOMRangeForPoint:]):
              (-[WebCoreBridge rangeOfCharactersAroundCaret]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a76dc44
  35. 09 May, 2005 1 commit
    • mjs's avatar
      Reviewed by Kevin. · 21a7f20d
      mjs authored
      	- remove code for DoNotStayInBlock variant of upstream/downstream and make
      	the methods take no parameters
      
              * khtml/editing/htmlediting.cpp:
              (khtml::CompositeEditCommand::deleteInsignificantTextDownstream):
              (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
              (khtml::ApplyStyleCommand::applyRelativeFontStyleChange):
              (khtml::ApplyStyleCommand::applyInlineStyle):
              (khtml::ApplyStyleCommand::removeInlineStyle):
              (khtml::ApplyStyleCommand::nodeFullySelected):
              (khtml::ApplyStyleCommand::nodeFullyUnselected):
              (khtml::DeleteSelectionCommand::initializePositionData):
              (khtml::DeleteSelectionCommand::fixupWhitespace):
              (khtml::InsertLineBreakCommand::insertNodeAfterPosition):
              (khtml::InsertLineBreakCommand::insertNodeBeforePosition):
              (khtml::InsertLineBreakCommand::doApply):
              (khtml::InsertParagraphSeparatorCommand::doApply):
              (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply):
              (khtml::InsertTextCommand::prepareForTextInsertion):
              (khtml::InsertTextCommand::input):
              (khtml::InsertTextCommand::insertSpace):
              (khtml::ReplaceSelectionCommand::doApply):
              * khtml/editing/selection.cpp:
              (khtml::Selection::toRange):
              (khtml::Selection::validate):
              * khtml/editing/visible_position.cpp:
              (khtml::VisiblePosition::previousVisiblePosition):
              (khtml::VisiblePosition::nextVisiblePosition):
              (khtml::VisiblePosition::downstreamDeepEquivalent):
              (khtml::isFirstVisiblePositionInParagraph):
              (khtml::isFirstVisiblePositionInBlock):
              (khtml::isLastVisiblePositionInParagraph):
              * khtml/xml/dom2_rangeimpl.cpp:
              (DOM::RangeImpl::editingStartPosition):
              * khtml/xml/dom_position.cpp:
              (DOM::isStreamer):
              (DOM::Position::upstream):
              (DOM::Position::downstream):
              (DOM::Position::leadingWhitespacePosition):
              (DOM::Position::trailingWhitespacePosition):
              * khtml/xml/dom_position.h:
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge smartDeleteRangeForProposedRange:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21a7f20d
  36. 07 May, 2005 1 commit
    • mjs's avatar
      Reviewed by Dave Harrison. · c238abeb
      mjs authored
      	- make StayInBlock vs DoNotStayInBlock explicit in all calls to
      	upstream/downstream, in preparation for phasing out the
      	DoNotStayInBlock variant.
      
              * khtml/editing/htmlediting.cpp:
              (khtml::ApplyStyleCommand::nodeFullySelected):
              (khtml::ApplyStyleCommand::nodeFullyUnselected):
              (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent):
              (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply):
              (khtml::InsertTextCommand::insertSpace):
              (khtml::ReplaceSelectionCommand::doApply):
              * khtml/editing/markup.cpp:
              (khtml::createMarkup):
              * khtml/editing/selection.cpp:
              (khtml::Selection::debugPosition):
              * khtml/xml/dom_position.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c238abeb
  37. 06 May, 2005 1 commit
    • harrison's avatar
      Reviewed by Maciej, Darin. · 08201e60
      harrison authored
              <rdar://problem/4103339> VisiblePosition and PositionIterator iterators do not return positions in order
      
              * WebCore.pbproj/project.pbxproj:
              Removed dom_positioniterator.h and dom_positioniterator.cpp.
      
              * khtml/editing/htmlediting.cpp:
              Removed unused include of dom_positioniterator.h and "using" of PositionIterator.
      
              * khtml/editing/selection.cpp:
              Removed unused include of dom_positioniterator.h.
      
              * khtml/editing/visible_position.h:
              * khtml/editing/visible_position.cpp:
              (khtml::VisiblePosition::previousVisiblePosition):
              (khtml::VisiblePosition::nextVisiblePosition):
              (khtml::VisiblePosition::downstreamDeepEquivalent):
              Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of duplicated code.
      
              * khtml/xml/dom_nodeimpl.h:
              * khtml/xml/dom_nodeimpl.cpp:
              (NodeImpl::maxDeepOffset):
              Added to support Position::next(), Position::previous(), Position::atStart(), Position::atEnd()
      
              * khtml/xml/dom_position.h:
              * khtml/xml/dom_position.cpp:
              (DOM::Position::previous):
              (DOM::Position::next):
              (DOM::Position::atStart):
              (DOM::Position::atEnd):
              Moved here, replacing VisiblePosition's duplicate and PositionIterator.  Fixed to
              return positions in order and not skip positions.
      
              (DOM::Position::previousCharacterPosition):
              (DOM::Position::nextCharacterPosition):
              Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of PositionIterator.
      
              (DOM::isStreamer):
              (DOM::Position::upstream):
              (DOM::Position::downstream):
              Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of PositionIterator.
      
              * khtml/xml/dom_positioniterator.cpp: Removed.
              * khtml/xml/dom_positioniterator.h: Removed.
              Removed in favor of Position::next(), Position::previous(), Position::atStart(), Position::atEnd()
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08201e60