1. 20 May, 2010 1 commit
    • morrita@google.com's avatar
      2010-05-20 MORITA Hajime <morrita@google.com> · 034e133e
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              2x execCommand ReadAV@NULL
              https://bugs.webkit.org/show_bug.cgi?id=35791
      
              This test passes if it doesn't crash.
      
              * editing/execCommand/35791-expected.txt: Added.
              * editing/execCommand/35791.html: Added.
      2010-05-20  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Kent Tamura.
      
              2x execCommand ReadAV@NULL
              https://bugs.webkit.org/show_bug.cgi?id=35791
      
              In applyBlockStyle(), a node which is referred from
              nextParagraphStart sometimes removed from the document and goes
              orphan, and that causes an assertion failed. This is because
              moveParagraphs() replaces the node with a new one with some new
              styles applied. So we re-compute nextParagraphStart in that case.
      
              Test: editing/execCommand/35791.html
      
              * dom/Position.h:
              (WebCore::Position::isOrphan):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle):
              * editing/VisiblePosition.h:
              (WebCore::VisiblePosition::isOrphan):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      034e133e
  2. 18 May, 2010 1 commit
  3. 03 May, 2010 1 commit
    • abarth@webkit.org's avatar
      2010-05-03 Abhishek Arya <inferno@chromium.org> · 616e41e4
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              Tests that javascript cannot access clipboard.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * editing/execCommand/clipboard-access-expected.txt: Added.
              * editing/execCommand/clipboard-access.html: Added.
              * editing/execCommand/script-tests/clipboard-access.js: Added.
              (enabled):
              (whenEnabled):
      2010-05-03  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is disabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              Test: editing/execCommand/clipboard-access.html
      
              * WebCore.base.exp:
              * editing/EditorCommand.cpp:
              (WebCore::supportedCopyCut):
              (WebCore::supportedPaste):
              (WebCore::createCommandMap):
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setJavaScriptCanAccessClipboard):
              * page/Settings.h:
              (WebCore::Settings::javaScriptCanAccessClipboard):
      2010-05-03  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is disabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * public/WebSettings.h:
              * src/WebSettingsImpl.cpp:
              (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
              * src/WebSettingsImpl.h:
      2010-05-03  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is disabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_class_init):
              (webkit_web_settings_set_property):
              (webkit_web_settings_get_property):
              (webkit_web_settings_copy):
              * webkit/webkitwebview.cpp:
              (webkit_web_view_update_settings):
              (webkit_web_view_settings_notify):
      2010-05-03  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is disabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              (-[WebPreferences javaScriptCanAccessClipboard]):
              (-[WebPreferences setJavaScriptCanAccessClipboard:]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      2010-05-03  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is disabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * Api/qwebsettings.cpp:
              (QWebSettingsPrivate::apply):
              * Api/qwebsettings.h:
      2010-05-03  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is disabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * Interfaces/IWebPreferencesPrivate.idl:
              * WebPreferenceKeysPrivate.h:
              * WebPreferences.cpp:
              (WebPreferences::initializeDefaultSettings):
              (WebPreferences::javaScriptCanAccessClipboard):
              (WebPreferences::setJavaScriptCanAccessClipboard):
              * WebPreferences.h:
              * WebView.cpp:
              (WebView::notifyPreferencesChanged):
      2010-05-03  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is enabled in test framework.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setJavaScriptCanAccessClipboardCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::setJavaScriptCanAccessClipboard):
              (LayoutTestController::overridePreference):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::resetWebSettings):
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setJavaScriptCanAccessClipboard):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setJavaScriptCanAccessClipboard):
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::WebPage):
              (WebCore::WebPage::resetSettings):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::setJavaScriptCanAccessClipboard):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setJavaScriptCanAccessClipboard):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setJavaScriptCanAccessClipboard):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      616e41e4
  4. 22 Apr, 2010 2 commits
    • abarth@webkit.org's avatar
      2010-04-22 Adam Barth <abarth@webkit.org> · bf00db5b
      abarth@webkit.org authored
              Unreviewed, rolling out r58069.
              http://trac.webkit.org/changeset/58069
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              Broke compile on Windows.
      
              * editing/execCommand/clipboard-access-expected.txt: Removed.
              * editing/execCommand/clipboard-access.html: Removed.
              * editing/execCommand/script-tests/clipboard-access.js: Removed.
      2010-04-22  Adam Barth  <abarth@webkit.org>
      
              Unreviewed, rolling out r58069.
              http://trac.webkit.org/changeset/58069
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              Broke compile on Windows.
      
              * WebCore.base.exp:
              * editing/EditorCommand.cpp:
              (WebCore::supportedPaste):
              (WebCore::createCommandMap):
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h:
      2010-04-22  Adam Barth  <abarth@webkit.org>
      
              Unreviewed, rolling out r58069.
              http://trac.webkit.org/changeset/58069
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              Broke compile on Windows.
      
              * public/WebSettings.h:
              * src/WebSettingsImpl.cpp:
              * src/WebSettingsImpl.h:
      2010-04-22  Adam Barth  <abarth@webkit.org>
      
              Unreviewed, rolling out r58069.
              http://trac.webkit.org/changeset/58069
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              Broke compile on Windows.
      
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_class_init):
              (webkit_web_settings_set_property):
              (webkit_web_settings_get_property):
              (webkit_web_settings_copy):
              * webkit/webkitwebview.cpp:
              (webkit_web_view_update_settings):
              (webkit_web_view_settings_notify):
      2010-04-22  Adam Barth  <abarth@webkit.org>
      
              Unreviewed, rolling out r58069.
              http://trac.webkit.org/changeset/58069
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              Broke compile on Windows.
      
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      2010-04-22  Adam Barth  <abarth@webkit.org>
      
              Unreviewed, rolling out r58069.
              http://trac.webkit.org/changeset/58069
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              Broke compile on Windows.
      
              * Api/qwebsettings.cpp:
              (QWebSettingsPrivate::apply):
              * Api/qwebsettings.h:
      2010-04-22  Adam Barth  <abarth@webkit.org>
      
              Unreviewed, rolling out r58069.
              http://trac.webkit.org/changeset/58069
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              Broke compile on Windows.
      
              * Interfaces/IWebPreferencesPrivate.idl:
              * WebPreferenceKeysPrivate.h:
              * WebPreferences.cpp:
              (WebPreferences::initializeDefaultSettings):
              * WebPreferences.h:
              * WebView.cpp:
              (WebView::notifyPreferencesChanged):
      2010-04-22  Adam Barth  <abarth@webkit.org>
      
              Unreviewed, rolling out r58069.
              http://trac.webkit.org/changeset/58069
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              Broke compile on Windows.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::overridePreference):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::resetWebSettings):
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::WebPage):
              (WebCore::WebPage::resetSettings):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf00db5b
    • abarth@webkit.org's avatar
      2010-04-22 Abhishek Arya <inferno@chromium.org> · dfeb70e5
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              Manual test to verify that javascript cannot access clipboard.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * editing/execCommand/clipboard-access-expected.txt: Added.
              * editing/execCommand/clipboard-access.html: Added.
              * editing/execCommand/script-tests/clipboard-access.js: Added.
              (enabled):
              (whenEnabled):
              (runTest):
      2010-04-22  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is disabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              Test: editing/execCommand/clipboard-access.html
      
              * WebCore.base.exp:
              * editing/EditorCommand.cpp:
              (WebCore::supportedCopyCut):
              (WebCore::supportedPaste):
              (WebCore::createCommandMap):
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setJavaScriptCanAccessClipboard):
              * page/Settings.h:
              (WebCore::Settings::javaScriptCanAccessClipboard):
      2010-04-22  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is disabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * public/WebSettings.h:
              * src/WebSettingsImpl.cpp:
              (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
              * src/WebSettingsImpl.h:
      2010-04-22  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is disabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_class_init):
              (webkit_web_settings_set_property):
              (webkit_web_settings_get_property):
              (webkit_web_settings_copy):
              * webkit/webkitwebview.cpp:
              (webkit_web_view_update_settings):
              (webkit_web_view_settings_notify):
      2010-04-22  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is disabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              (-[WebPreferences javaScriptCanAccessClipboard]):
              (-[WebPreferences setJavaScriptCanAccessClipboard:]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      2010-04-22  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is disabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * Api/qwebsettings.cpp:
              (QWebSettingsPrivate::apply):
              * Api/qwebsettings.h:
      2010-04-22  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is disabled by default.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * Interfaces/IWebPreferencesPrivate.idl:
              * WebPreferenceKeysPrivate.h:
              * WebPreferences.cpp:
              (WebPreferences::initializeDefaultSettings):
              (WebPreferences::javaScriptCanAccessClipboard):
              (WebPreferences::setJavaScriptCanAccessClipboard):
              * WebPreferences.h:
              * WebView.cpp:
              (WebView::notifyPreferencesChanged):
      2010-04-22  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Add support for controlling clipboard access from javascript.
              Clipboard access from javascript is enabled in test framework.
              https://bugs.webkit.org/show_bug.cgi?id=27751
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setJavaScriptCanAccessClipboardCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::setJavaScriptCanAccessClipboard):
              (LayoutTestController::overridePreference):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::resetWebSettings):
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setJavaScriptCanAccessClipboard):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setJavaScriptCanAccessClipboard):
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::WebPage):
              (WebCore::WebPage::resetSettings):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::setJavaScriptCanAccessClipboard):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setJavaScriptCanAccessClipboard):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setJavaScriptCanAccessClipboard):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfeb70e5
  5. 20 Apr, 2010 2 commits
    • rniwa@webkit.org's avatar
      Nested <ul>s are mishandled when converted to <ol> using execCommand('insertorderedlist') · dfb6424f
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=19539
      
      Reviewed by Justin Garcia.
      
      WebCore: 
      
      Fixes a bug where two consecutive lists are not merged if they have been converted
      from ordered/unordered lists inside another list.
      
      The bug was caused by InsertListCommand::doApply where it did not merge a newly inserted
      list element and its neighbors. This patch adds code to doApply so that after inserting
      the list element, it updates previousList and nextList to the outermost list elements around
      insertionPos under the same enclosing list. Because the next and the previous list elements
      are not necessarily visually next to the newly inserted element before moveParagraph moves
      the paragraph into the new list element, doApply merges lists after moveParagraph is called.
      
      Test: editing/execCommand/insert-lists-inside-another-list.html
      
      * editing/InsertListCommand.cpp:
      (WebCore::InsertListCommand::doApply): Modified as described above
      * editing/htmlediting.cpp:
      (WebCore::outermostEnclosingList): Added rootNode. Returns the outermost list element,
        which is a descendent of rootNode.
      * editing/htmlediting.h:
      
      LayoutTests: 
      
      Test to make sure InsertListCommand merges consecutive lists when converting
      ordered/unordered lists to the opposite type of lists inside another list.
      
      * editing/execCommand/insert-lists-inside-another-list-expected.txt: Added.
      * editing/execCommand/insert-lists-inside-another-list.html: Added.
      * editing/execCommand/script-tests/insert-lists-inside-another-list.js: Added.
      (testList):
      * platform/mac/editing/execCommand/create-list-from-range-selection-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfb6424f
    • hamaji@chromium.org's avatar
      2010-04-20 Shinichiro Hamaji <hamaji@chromium.org> · 359e1319
      hamaji@chromium.org authored
              Reviewed by Darin Adler and Alexey Proskuryakov.
      
              A backslash in EUC-JP becomes to a yen sign when it is copied
              https://bugs.webkit.org/show_bug.cgi?id=36419
      
              * editing/execCommand/transpose-backslash-with-euc-expected.txt: Added.
              * editing/execCommand/transpose-backslash-with-euc.html: Added.
              * editing/pasteboard/copy-backslash-with-euc-expected.txt: Added.
              * editing/pasteboard/copy-backslash-with-euc.html: Added.
              * editing/pasteboard/resources/copy-backslash-euc.html: Added.
      2010-04-20  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler and Alexey Proskuryakov.
      
              A backslash in EUC-JP becomes to a yen sign when it is copied
              https://bugs.webkit.org/show_bug.cgi?id=36419
      
              Tests: editing/execCommand/transpose-backslash-with-euc.html
                     editing/pasteboard/copy-backslash-with-euc.html
      
              * editing/Editor.cpp: Remove an unnecessary displayStringModifiedByEncoding calls.
              (WebCore::Editor::addToKillRing):
              * editing/TextIterator.cpp: TextIterator can use RenderText::textWithoutTranscoding and now plainText() uses this version
              (WebCore::TextIterator::TextIterator):
              (WebCore::TextIterator::init):
              (WebCore::TextIterator::emitText):
              (WebCore::plainTextToMallocAllocatedBuffer):
              * editing/TextIterator.h:
              (WebCore::):
              * platform/mac/PasteboardMac.mm: Remove an unnecessary displayStringModifiedByEncoding call.
              (WebCore::Pasteboard::writeSelection):
              * platform/text/TextEncoding.h: Make backslashAsCurrencySymbol public.
              * rendering/RenderText.cpp: Add RenderText::textWithoutTranscoding
              (WebCore::RenderText::RenderText):
              (WebCore::RenderText::updateNeedsTranscoding):
              (WebCore::RenderText::styleDidChange):
              (WebCore::isInlineFlowOrEmptyText):
              (WebCore::RenderText::previousCharacter):
              (WebCore::RenderText::setTextInternal):
              (WebCore::RenderText::textWithoutTranscoding):
              (WebCore::RenderText::transformText):
              * rendering/RenderText.h:
              * rendering/RenderTextControl.cpp: Remove an unnecessary displayStringModifiedByEncoding call.
              (WebCore::RenderTextControl::setInnerTextValue):
              (WebCore::RenderTextControl::finishText):
              * rendering/RenderTextFragment.cpp:
              (WebCore::RenderTextFragment::previousCharacter):
              * rendering/RenderTextFragment.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      359e1319
  6. 08 Mar, 2010 1 commit
    • tony@chromium.org's avatar
      2010-03-08 Tony Chang <tony@chromium.org> · d3821d58
      tony@chromium.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=32131
              Work around a crash when inserting an ordered list.  This was caused
              by incorrect logic when trying to restore a range from a location.
              We compute the offset using TextIterator, but were sometimes using
              VisiblePosition::next() to iterate instead.
      
              * editing/execCommand/insert-ordered-list-expected.txt: Added.
              * editing/execCommand/insert-ordered-list.html: Added.
      2010-03-08  Tony Chang  <tony@chromium.org>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=32131
              Crash when inserting an ordered list.
      
              Test: editing/execCommand/insert-ordered-list.html
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::rangeFromLocationAndLength):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3821d58
  7. 06 Mar, 2010 1 commit
  8. 26 Feb, 2010 1 commit
    • ossy@webkit.org's avatar
      Unreviewed. Roll-out r55263 because it broke fast/forms/textarea-type-spaces-pretty-diff.html. · 713375e0
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=30946
      
      WebCore: 
      
      * editing/CompositeEditCommand.cpp:
      (WebCore::isWhitespace):
      (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
      * editing/InsertTextCommand.cpp:
      (WebCore::InsertTextCommand::input):
      * editing/InsertTextCommand.h:
      * editing/htmlediting.cpp:
      * editing/htmlediting.h:
      
      LayoutTests: 
      
      * editing/execCommand/5142012-3-expected.txt:
      * editing/inserting/rebalance-whitespace-1-expected.txt: Removed.
      * editing/inserting/rebalance-whitespace-1.html: Removed.
      * editing/pasteboard/5521237-expected.txt:
      * platform/mac/editing/execCommand/5482023-expected.checksum:
      * platform/mac/editing/execCommand/5482023-expected.png: Added.
      * platform/mac/editing/execCommand/5482023-expected.txt:
      * platform/mac/editing/execCommand/remove-formatting-2-expected.checksum:
      * platform/mac/editing/execCommand/remove-formatting-2-expected.png: Added.
      * platform/mac/editing/execCommand/remove-formatting-expected.checksum:
      * platform/mac/editing/execCommand/remove-formatting-expected.png: Added.
      * platform/mac/editing/execCommand/remove-formatting-expected.txt:
      * platform/mac/editing/inserting/editable-html-element-expected.checksum:
      * platform/mac/editing/inserting/editable-html-element-expected.png: Added.
      * platform/mac/editing/inserting/editable-html-element-expected.txt:
      * platform/mac/editing/pasteboard/4989774-expected.checksum:
      * platform/mac/editing/pasteboard/4989774-expected.png: Added.
      * platform/mac/editing/pasteboard/4989774-expected.txt:
      * platform/mac/editing/selection/4983858-expected.checksum:
      * platform/mac/editing/selection/4983858-expected.png: Added.
      * platform/mac/editing/selection/4983858-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      713375e0
  9. 25 Feb, 2010 1 commit
    • enrica@apple.com's avatar
      Extra layout on keypress after a space (problem with rebalanceWhitespaceAt in InsertTextCommand). · b5adb4e2
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30946
      <rdar://problem/7639184>
      
      Reviewed by Adele Peterson.
      
      WebCore: 
      
      Do text insertion and whitespace rebalancing around the insertion in one step so that there's only one layout.
      This patch was originally made by Justin Garcia.
              
      Test: editing/inserting/rebalance-whitespace-1.html
      
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): No behavior changes here,
      just pushed the code that determined the extent of whitespace surrounding a position
      to its own helper function.
      * editing/InsertTextCommand.cpp:
      (WebCore::InsertTextCommand::insertTextIntoNodeAndRebalanceWhitespace): Added.  Find 
      whitespace surrounding the insertion position, add the text to insert, rebalance that entire
      string, then insert it into the document.
      (WebCore::InsertTextCommand::input):
      * editing/InsertTextCommand.h:
      * editing/htmlediting.cpp:
      (WebCore::isWhitespace): Moved from CompositeEditCommand.cpp.
      (WebCore::extentOfWhitespaceForRebalancingAt): Moved code from rebalanceWhitespaceAt into this helper
      function.  Obtains the offset of the start and end of whitespace around a particular position.
      * editing/htmlediting.h:
      
      LayoutTests: 
      
      There are now regular spaces where nbsps were used unnecessarily before.  Also,
      multi-character insertions now have their whitespace rebalanced, and this is
      reflected in a few tests.
      
      * editing/execCommand/5142012-3-expected.txt:
      * editing/inserting/rebalance-whitespace-1-expected.txt: Added.
      * editing/inserting/rebalance-whitespace-1.html: Added.
      * editing/pasteboard/5521237-expected.txt:
      * platform/mac/editing/execCommand/5482023-expected.checksum:
      * platform/mac/editing/execCommand/5482023-expected.png: Removed.
      * platform/mac/editing/execCommand/5482023-expected.txt:
      * platform/mac/editing/execCommand/remove-formatting-2-expected.checksum:
      * platform/mac/editing/execCommand/remove-formatting-2-expected.png: Removed.
      * platform/mac/editing/execCommand/remove-formatting-expected.checksum:
      * platform/mac/editing/execCommand/remove-formatting-expected.png: Removed.
      * platform/mac/editing/execCommand/remove-formatting-expected.txt:
      * platform/mac/editing/inserting/editable-html-element-expected.checksum:
      * platform/mac/editing/inserting/editable-html-element-expected.png: Removed.
      * platform/mac/editing/inserting/editable-html-element-expected.txt:
      * platform/mac/editing/pasteboard/4989774-expected.checksum:
      * platform/mac/editing/pasteboard/4989774-expected.png: Removed.
      * platform/mac/editing/pasteboard/4989774-expected.txt:
      * platform/mac/editing/selection/4983858-expected.checksum:
      * platform/mac/editing/selection/4983858-expected.png: Removed.
      * platform/mac/editing/selection/4983858-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5adb4e2
  10. 23 Feb, 2010 2 commits
  11. 18 Feb, 2010 1 commit
    • tony@chromium.org's avatar
      2010-02-17 Tony Chang <tony@chromium.org> · 2509fab1
      tony@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=26937
              No longer allow span styles to surround block elements like
              divs when pasting (see paste-text-012 and 5065605 which had divs in
              spans).  This also causes a few cases of empty spans to be removed
              (see 19089 and 5245519).
      
              * editing/execCommand/19089-expected.txt:
              * editing/pasteboard/5245519-expected.txt:
              * editing/pasteboard/5245519.html:
              * platform/mac/editing/pasteboard/5065605-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-011-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-012-expected.txt:
      2010-02-17  Tony Chang  <tony@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Copying and pasting into a contenteditable area can create <div>s surrounded by <span>s
              https://bugs.webkit.org/show_bug.cgi?id=26937
      
              This happens because of a span added when we copy that is used to
              preserve styles.  To avoid this, when we paste, make sure to apply
              the styles to the span's children and then remove the style span.
      
              This change is covered by existing layout tests.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::handleStyleSpans):
              (WebCore::ReplaceSelectionCommand::copyStyleToChildren):
              * editing/ReplaceSelectionCommand.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2509fab1
  12. 08 Feb, 2010 1 commit
  13. 27 Jan, 2010 1 commit
    • eric@webkit.org's avatar
      2010-01-27 Tony Chang <tony@chromium.org> · 1d23c496
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Fix a crash when trying to indent a block element that was contained
              in a list.  This was happening because enclosingBlock() in
              htmlediting.cpp can return the current the same Node when a block
              element (like an <hr> or a <table>) is passed in.  This causes
              the indent command to think that it is not in a list item.
      
              Work around this by checking to see if enclosingBlock returned the
              same Node.
      
              https://bugs.webkit.org/show_bug.cgi?id=32390
      
              * editing/execCommand/indent-block-in-list-expected.txt: Added.
              * editing/execCommand/indent-block-in-list.html: Added.
      2010-01-27  Tony Chang  <tony@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Fix a crash when trying to indent a block element that was contained
              in a list.  This was happening because enclosingBlock() in
              htmlediting.cpp can return the current the same Node when a block
              element (like an <hr> or a <table>) is passed in.  This causes
              the indent command to think that it is not in a list item.
      
              Work around this by checking to see if enclosingBlock returned the
              same Node.
      
              https://bugs.webkit.org/show_bug.cgi?id=32390
      
              Test: editing/execCommand/indent-block-in-list.html
      
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::tryIndentingAsListItem):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d23c496
  14. 21 Jan, 2010 1 commit
  15. 11 Jan, 2010 1 commit
  16. 21 Dec, 2009 1 commit
  17. 10 Dec, 2009 1 commit
    • enrica@apple.com's avatar
      REGRESSION(4.0.4-42a12): With 2 highlighted lines of text in gmail/hotmail... · d2ac1039
      enrica@apple.com authored
      REGRESSION(4.0.4-42a12): With 2 highlighted lines of text in gmail/hotmail selecting Bold selects other 2 edit buttons automatically.
      <rdar://problem/7442065>
      https://bugs.webkit.org/show_bug.cgi?id=32285
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      When examining the styles of the nodes after the first in a range selection, we take into
      cosideration differences in style of txt nodes only.
              
      Test: editing/execCommand/queryCommandState-02.html
      
      * editing/Editor.cpp:
      (WebCore::Editor::selectionHasStyle):
      
      LayoutTests: 
      
      * editing/execCommand/queryCommandState-02-expected.txt: Added.
      * editing/execCommand/queryCommandState-02.html: Added.
      * editing/execCommand/script-tests/toggle-compound-styles.js: Fixed typo in text.
      * platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
      * platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
      * platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2ac1039
  18. 07 Dec, 2009 1 commit
  19. 04 Dec, 2009 1 commit
  20. 04 Nov, 2009 1 commit
    • enrica@apple.com's avatar
      WebCore: Hang in Mail on attempting to change indent level. · e2bfdba3
      enrica@apple.com authored
      <rdar://problem/7131805>
      https://bugs.webkit.org/show_bug.cgi?id=31127
      
      Reviewed by Adele Peterson.
      
      The hang was caused by an infinite loop inside outdentRegion.
      The code did not account for the fact that, when a list item
      cointains multiple paragraphs, outdent moves all paragraphs at
      once, invalidating some of the position we keep track of in the loop.
      Some code refactoring has also been done to minimize duplicate code.
              
      Test: editing/execCommand/outdent-multiparagraph-list.html
      
      * editing/IndentOutdentCommand.cpp:
      (WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
      outdentRegion to doApply.
      (WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
      (WebCore::IndentOutdentCommand::doApply): Some code refactoring.
      * editing/IndentOutdentCommand.h: Added VisiblePosition parameters to
      indentRegion and outdentRegion.
      
      LayoutTests: Hang in Mail on attempting to change indent level
      <rdar://problem/7131805>
      https://bugs.webkit.org/show_bug.cgi?id=31127
              
      Reviewed by Adele Peterson.
      
      Added test to cover all the different code paths.
      
      * editing/execCommand/outdent-multiparagraph-list-expected.txt: Added.
      * editing/execCommand/outdent-multiparagraph-list.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2bfdba3
  21. 02 Nov, 2009 1 commit
  22. 23 Oct, 2009 1 commit
    • adele@apple.com's avatar
      REGRESSION: Copy is copying incorrect background-color · 4e6db62c
      adele@apple.com authored
      <rdar://problem/7248529>
      https://bugs.webkit.org/show_bug.cgi?id=29697
      
      Patch by Enrica Casucci <enrica@apple.com> on 2009-10-23
      Reviewed by Adele Peterson.
      
      WebCore: 
      
      Test: editing/execCommand/indent-paragraphs.html
      
      This change removes the BackgroundColor from the list 
      of inheritable CSS properties and changes significantly
      the way we perform indentation.
      The new implementation of IndentOutdentCommand uses a new method
      defined in CompositeEditCommand called moveParagraphWithClones.
      This is an improved version of the original moveParagraph that
      is aimed at preserving the original markup of the paragraph being
      moved.
      
      * editing/ApplyStyleCommand.cpp:
      (WebCore::): removed CSSPropertyBackgroundColor from editingStyleProperties.
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::CompositeEditCommand): Removed trailing blanks.
      (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Removed trailing blanks.
      (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added.
      (WebCore::CompositeEditCommand::cleanupAfterDeletion): Added.
      (WebCore::CompositeEditCommand::moveParagraphWithClones): Added.
      (WebCore::CompositeEditCommand::moveParagraphs): Modified to use cleanupAfterDeletion.
      (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Removed trailing blanks.
      (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Removed trailing blanks.
      (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Removed trailing blanks.
      * editing/CompositeEditCommand.h: Added three new methods.
      * editing/IndentOutdentCommand.cpp:
      (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Changed to use moveParagraphWithClones.
      (WebCore::IndentOutdentCommand::indentIntoBlockquote): Changed to use moveParagraphWithClones.
      (WebCore::IndentOutdentCommand::indentRegion): Removed comment.
      * editing/IndentOutdentCommand.h: Removed prepareBlockquoteLevelForInsertion method.
      
      LayoutTests: 
      
      All the following tests have been re-baselined because
      the indent command now preserves the original markup.
      A new test (indent-paragraph.html) has been added to test
      several indent combinations not covered by the existing tests.
              
      * editing/execCommand/19087-expected.txt:
      * editing/execCommand/19653-1-expected.txt:
      * editing/execCommand/indent-div-inside-list-expected.txt:
      * editing/execCommand/indent-nested-blockquotes-expected.txt:
      * editing/execCommand/indent-nested-div-expected.txt:
      * editing/execCommand/indent-paragraphs.html: Added.
      * editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt:
      * editing/execCommand/indent-with-style-expected.txt:
      * editing/inserting/5994480-2-expected.txt:
      * platform/mac/editing/execCommand/4641880-2-expected.txt:
      * platform/mac/editing/execCommand/4916541-expected.txt:
      * platform/mac/editing/execCommand/5138441-expected.txt:
      * platform/mac/editing/execCommand/5481523-expected.txt:
      * platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Added.
      * platform/mac/editing/execCommand/indent-selection-expected.txt:
      * platform/mac/editing/pasteboard/select-element-1-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e6db62c
  23. 14 Oct, 2009 1 commit
    • jparent@chromium.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=30269 · 9fc336da
      jparent@chromium.org authored
      Use onload to detect iframe load, rather than setTimeout.
      This will give more consistent test results and hopefully faster run times.
      
      Patch by Julie Parent <jparent@chromium.org> on 2009-10-13
      Reviewed by Darin Adler.
      
      * editing/execCommand/paste-1.html:
      * editing/execCommand/paste-2.html:
      * editing/pasteboard/subframe-dragndrop-1.html:
      * editing/selection/4776665.html:
      * editing/selection/4975120.html:
      * editing/selection/5136696.html:
      * editing/selection/drag-to-contenteditable-iframe.html:
      * platform/mac/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
      * platform/qt/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
      * platform/win/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fc336da
  24. 09 Oct, 2009 2 commits
    • rniwa@webkit.org's avatar
      ApplyStyleCommand removes presentational tags even when not necessary · e7d601d0
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28091
      
      Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-09
      Reviewed by Eric Seidel.
      
      WebCore: 
      
      This patch updates implicitlyStyledElementShouldBeRemovedWhenApplyingStyle to return true
      (triggering removal of tag) only if the style implicitly added by the element is not present in
      the new style to apply. It also changes surroundNodeRangeWithElement so that it merges the
      surrounding element when possible. applyTextDecorationStyle is modified so that it does not add
      style span when the style attribute is empty.
      
      Test: editing/execCommand/toggle-style-3.html
      
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::shouldRemoveTextDecorationTag): Returns true if specified text
      decoration is not present in the style to apply
      (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): No longer
      returns true if the tag is used in new style
      (WebCore::ApplyStyleCommand::applyTextDecorationStyle): Does not add style-span when redundant
      (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Merges the newly created element
      with the surrounding identical elements
      * editing/ApplyStyleCommand.h:
      
      LayoutTests: 
      
      This patch adds test to make sure to preserve presentational tag
      (u, s, strike, i, em, sup, sub, b, & strong) when the corresponding style is present in
      the final computed style. i.e. avoid removing tag and re-applying the style later
      
      * editing/execCommand/19653-2-expected.txt: Two b elements are merged.
      * editing/execCommand/createLink-expected.txt: Two anchor elements are merged.
      * editing/execCommand/script-tests/toggle-style-3.js: Added.
      (testSingleToggle):
      * editing/execCommand/strikethroughSelection-expected.txt: Redundant style spans are no longer added.
      * editing/execCommand/toggle-style-3-expected.txt: Added.
      * editing/execCommand/toggle-style-3.html: Added.
      * editing/execCommand/unlink-expected.txt: Two anchor elements are merged.
      * platform/mac/editing/style/5228141-expected.txt: Two b elements are merged.
      * platform/mac/editing/style/style-boundary-001-expected.txt: Two b elements are merged.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7d601d0
    • eric@webkit.org's avatar
      2009-10-09 Enrica Casucci <enrica@apple.com> · bdccb1c7
      eric@webkit.org authored
              Reviewed by Adele Peterson.
      
              Undoing a indent removes text instead of it's formatting.
              <rdar://problem/7169206>
              https://bugs.webkit.org/show_bug.cgi?id=28722
              Added test case for https://bugs.webkit.org/show_bug.cgi?id=23995
      
              * editing/execCommand/19653-1-expected.txt: Re-baselined.
              * editing/execCommand/indent-div-inside-list-expected.txt: Re-baselined.
              * editing/execCommand/indent-nested-blockquotes-expected.txt: Re-baselined.
              * editing/execCommand/indent-nested-div-expected.txt: Re-baselined.
              * editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Re-baselined.
              * editing/execCommand/indent-with-style-expected.txt: Added.
              * editing/execCommand/indent-with-style.html: Added.
              * editing/undo/undo-indent-expected.txt: Added.
              * editing/undo/undo-indent.html: Added.
              * platform/mac/editing/execCommand/4641880-2-expected.txt: Re-baselined.
              * platform/mac/editing/execCommand/4916541-expected.txt: Re-baselined.
              * platform/mac/editing/execCommand/5138441-expected.txt: Re-baselined.
              * platform/mac/editing/execCommand/5481523-expected.txt: Re-baselined.
              * platform/mac/editing/execCommand/indent-selection-expected.txt: Re-baselined.
      2009-10-09  Enrica Casucci  <enrica@apple.com>
      
              Reviewed by Adele Peterson.
      
              Undoing a indent removes text instead of it's formatting.
              <rdar://problem/7169206>
              https://bugs.webkit.org/show_bug.cgi?id=28722
              Restored the behavior prior to http://trac.webkit.org/changeset/46143. This change implemented the
              indent command making simple DOM operation, without using moveParagraph which cause undo to be broken.
      
              Added editing/undo/undo-indent.html test.
      
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Restored.
              (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Merged changes.
              (WebCore::IndentOutdentCommand::indentIntoBlockquote): Restored.
              (WebCore::IndentOutdentCommand::indentRegion): Restored and added call to updateLayout to
              ensure TextIterator could correctly calculate the position starting from the index.
              * editing/IndentOutdentCommand.h: Restored.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdccb1c7
  25. 19 Sep, 2009 1 commit
    • hamaji@chromium.org's avatar
      2009-09-19 Shinichiro Hamaji <hamaji@chromium.org> · 9f29ed39
      hamaji@chromium.org authored
              Rubber-stamped by Eric Seidel.
      
              js tests should move into jstests subdirectory instead of resources/
              https://bugs.webkit.org/show_bug.cgi?id=25880
      
              Attempt to split the huge patch as I failed to commit it...
      
              * editing/execCommand/break-out-of-empty-list-item.html:
              * editing/execCommand/convert-style-elements-to-spans.html:
              * editing/execCommand/empty-span-removal.html:
              * editing/execCommand/enabling-and-selection-2.html:
              * editing/execCommand/enabling-and-selection.html:
              * editing/execCommand/inline-style-after-indentoutdent.html:
              * editing/execCommand/resources/TEMPLATE.html: Removed.
              * editing/execCommand/resources/break-out-of-empty-list-item.js: Removed.
              * editing/execCommand/resources/convert-style-elements-to-spans.js: Removed.
              * editing/execCommand/resources/empty-span-removal.js: Removed.
              * editing/execCommand/resources/enabling-and-selection-2.js: Removed.
              * editing/execCommand/resources/enabling-and-selection.js: Removed.
              * editing/execCommand/resources/inline-style-after-indentoutdent.js: Removed.
              * editing/execCommand/resources/toggle-compound-styles.js: Removed.
              * editing/execCommand/resources/toggle-style-2.js: Removed.
              * editing/execCommand/resources/toggle-styles.js: Removed.
              * editing/execCommand/resources/toggle-text-decorations.js: Removed.
              * editing/execCommand/script-tests: Added.
              * editing/execCommand/script-tests/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
              * editing/execCommand/script-tests/break-out-of-empty-list-item.js: Copied from LayoutTests/editing/execCommand/resources/break-out-of-empty-list-item.js.
              * editing/execCommand/script-tests/convert-style-elements-to-spans.js: Copied from LayoutTests/editing/execCommand/resources/convert-style-elements-to-spans.js.
              * editing/execCommand/script-tests/empty-span-removal.js: Copied from LayoutTests/editing/execCommand/resources/empty-span-removal.js.
              * editing/execCommand/script-tests/enabling-and-selection-2.js: Copied from LayoutTests/editing/execCommand/resources/enabling-and-selection-2.js.
              * editing/execCommand/script-tests/enabling-and-selection.js: Copied from LayoutTests/editing/execCommand/resources/enabling-and-selection.js.
              * editing/execCommand/script-tests/inline-style-after-indentoutdent.js: Copied from LayoutTests/editing/execCommand/resources/inline-style-after-indentoutdent.js.
              * editing/execCommand/script-tests/toggle-compound-styles.js: Copied from LayoutTests/editing/execCommand/resources/toggle-compound-styles.js.
              * editing/execCommand/script-tests/toggle-style-2.js: Copied from LayoutTests/editing/execCommand/resources/toggle-style-2.js.
              * editing/execCommand/script-tests/toggle-styles.js: Copied from LayoutTests/editing/execCommand/resources/toggle-styles.js.
              * editing/execCommand/script-tests/toggle-text-decorations.js: Copied from LayoutTests/editing/execCommand/resources/toggle-text-decorations.js.
              * editing/execCommand/toggle-compound-styles.html:
              * editing/execCommand/toggle-style-2.html:
              * editing/execCommand/toggle-styles.html:
              * editing/execCommand/toggle-text-decorations.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f29ed39
  26. 02 Sep, 2009 1 commit
    • rniwa@webkit.org's avatar
      WebCore: Cannot pres Enter to escape from bulleted list when <ul> is a child of <li>. · e71f23ff
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=24866
      
      Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-09-02
      Reviewed by Eric Seidel.
      
      This patch modifies breakOutOfEmptyListItem to break out of a properly nested list
      (a list to break out of is inside another list item).
      
      When the empty list item appears at the end of another list item, WebKit breaks out of
      the outer list item, and adds new item below the outer list item.
      Otherwise, WebKit breaks out of the the inner list item and inserts new paragraph.
      
      Test: editing/execCommand/break-out-of-empty-list-item.html
      
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
      
      LayoutTests: Cannot press Enter to escape from bulleted list when <ul> is a child of <li>.
      https://bugs.webkit.org/show_bug.cgi?id=24866
      
      Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-09-02
      Reviewed by Eric Seidel.
      
      This patch adds a test to make sure WebKit break out of an empty list item.
      
      * editing/execCommand/break-out-of-empty-list-item-expected.txt: Added.
      * editing/execCommand/break-out-of-empty-list-item.html: Added.
      * editing/execCommand/resources/break-out-of-empty-list-item.js: Added.
      (pressKey):
      (enterAtTarget):
      (testBreakOutOfEmptyListItem):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e71f23ff
  27. 21 Aug, 2009 1 commit
    • rniwa@webkit.org's avatar
      WebCore: execCommand("Underline") uses CSS even when styleWithCSS has been turned off · a5f95a15
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=23892
      
      Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-21
      Reviewed by Eric Seidel.
      
      This patch adds support for u and s in StyleChange and addInlineStyleIfNeeded so that
      WebKit does not use CSS to decorate texts when styleWithCSS is set to false.
      
      * css/CSSValueList.cpp:
      (WebCore::CSSValueList::copy): Added.
      * css/CSSValueList.h: Added copy.
      * editing/ApplyStyleCommand.cpp:
      (WebCore::StyleChange::applyUnderline):
      (WebCore::StyleChange::applyLineThrough):
      (WebCore::StyleChange::StyleChange): Added a boolean trimTextDecorations argument.
      (WebCore::StyleChange::init): Ditto.
      (WebCore::StyleChange::extractTextStyles): Handles text decorations.
      (WebCore::getPropertiesNotInComputedStyle): Handles text decorations properly.
      (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Adds u and s if needed.
      
      LayoutTests: execCommand("Underline") uses CSS even when styleWithCSS has been turned off
      https://bugs.webkit.org/show_bug.cgi?id=23892
      
      Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-21
      Reviewed by Eric Seidel.
      
      This patch rebaselines tests contained spans to decorate texts even though styleWithCSS is turned off.
      It replaces those spans with either u or s accordingly.
      
      It modifies the order in which tag appear in toggle-style-2 to match the actual result
      since the original ordering was rather arbitrary.
      
      This patch breaks /editing/style/font-family-with-space.html for Qt platform.
      Manual rebaseline is required once the patch is landed.
      
      * editing/execCommand/resources/toggle-style-2.js: Modified the order in which tag appear
      * editing/execCommand/resources/toggle-text-decorations.js: execCommand('styleWithCSS') is called after selection is set
      (testSingleToggle):
      * editing/execCommand/strikethroughSelection-expected.txt: span with line-through was replaced by s
      * editing/execCommand/toggle-style-2-expected.txt: Passes all but the last two tests.
      * editing/style/remove-underline-across-paragraph-expected.txt: Underline is added by u instead of CSS.
      * editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Ditto.
      * editing/style/remove-underline-after-paragraph-expected.txt: Ditto.
      * editing/style/remove-underline-after-paragraph-in-bold-expected.txt: Ditto.
      * editing/style/remove-underline-expected.txt: Ditto.
      * editing/style/remove-underline-in-bold-expected.txt: Ditto.
      * editing/style/underline-expected.txt: Ditto.
      * platform/mac/editing/execCommand/5190926-expected.txt: Ditto.
      * platform/mac/editing/pasteboard/5075944-expected.txt: Ditto.
      * platform/mac/editing/style/font-family-with-space-expected.txt: Ditto.
      * platform/qt/editing/execCommand/5190926-expected.txt: Ditto.
      * platform/qt/editing/pasteboard/5075944-expected.txt: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5f95a15
  28. 20 Aug, 2009 2 commits
    • rniwa@webkit.org's avatar
      Some tests using editing.js in editing/execCommand should use runDumpAsTextEditingTest · 30764870
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28494
      
      Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-20
      Reviewed by Eric Seidel.
      
      This patch modifies the following tests to use runDumpAsTextEditingTest
      
      * editing/editing.js: Fixed typo and added foreColorCommand.
      (execBackColorCommand):
      * editing/execCommand/italicizeByCharacter-expected.txt: Added.
      * editing/execCommand/italicizeByCharacter.html:
      * editing/execCommand/modifyForeColorByCharacter-expected.txt: Added.
      * editing/execCommand/modifyForeColorByCharacter.html:
      * editing/execCommand/strikethroughSelection-expected.txt: Added.
      * editing/execCommand/strikethroughSelection.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30764870
    • eric@webkit.org's avatar
      2009-08-20 Ryosuke Niwa <rniwa@webkit.org> · c36cc498
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              REGESSION(r45316), Crash: WebKit crashes in Google Sites when indenting a table
              https://bugs.webkit.org/show_bug.cgi?id=28474
      
              This patch adds a test to make sure WebKit does not crash when indenting immediately right to a table.
      
              * editing/execCommand/indent-right-after-table-expected.txt: Added.
              * editing/execCommand/indent-right-after-table.html: Added.
      2009-08-20  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              REGESSION(r45316), Crash: WebKit crashes in Google Sites when indenting a table
              https://bugs.webkit.org/show_bug.cgi?id=28474
      
              This patch fixes a crash when indenting at right after a table.
              The bug was caused by Node* blockNode = enclosingBlock(endOfCurrentParagraph.deepEquivalent().node());
              where node() is equal to blockNode. Because blockNode is the enclosing block node, this patch changes it to
              enclosingBlock(endOfCurrentParagraph.deepEquivalent().node()->parentNode());
      
              Test: editing/execCommand/indent-right-after-table.html
      
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::indentRegion): Fixed so that blockNode != endOfCurrentParagraph.deepEquivalent().node()
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c36cc498
  29. 16 Aug, 2009 1 commit
  30. 07 Aug, 2009 1 commit
    • rniwa@webkit.org's avatar
      WebCore: selectionHasStyle doesn't handle text-specific properties properly · 2cbc4b64
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=27858
      
      Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
      Reviewed by Justin Garcia.
      
      This patch modifies selectionHasStyle so that it returns TrueTriState when text styles
      (text-decoration, font-style, font-weight, & color) are present in all text nodes,
      regardless of whether the style is also present in their ancestor nodes or not.
      e.g. New behavior concludes that <b><i>hello</i><i>world</i></b> has italic style.
      
      WebKit now applies the text styles (bold, italic, etc) if the specified style was not present on
      at least one text node, rather than at the beginning of selection except on Mac.
      On Mac, WebKit applies the text style if the style was not present at the beginning of style.
      
      Test: editing/execCommand/toggle-compound-styles.html
      
      * editing/ApplyStyleCommand.cpp:
      (WebCore::getPropertiesNotInComputedStyle): bug fix, must use copy instead of makeMutable for a mutable style.
      * editing/Editor.cpp:
      (WebCore::):
      (WebCore::triStateOfStyleInComputedStyle): Added a boolean type to ignore text-specific styles
      (WebCore::Editor::selectionHasStyle): Ignores text-specific styles for all but text nodes
      * editing/EditorCommand.cpp:
      (WebCore::executeToggleStyle): Uses selectionHasStyle instead of selectionStartHasStyle
      
      LayoutTests: selectionHasStyle doesn't handle text-specific properties properly
      https://bugs.webkit.org/show_bug.cgi?id=27858
      
      Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
      Reviewed by Justin Garcia.
      
      This patch adds toggle-compound-styles to make sure WebKit can handle nested text styles
      such as <b><i>hello</i>world</b> (italicized) and <b><i>hello</i>world</b> (not italicized)
      on all platforms except on Mac (to match TextEdit's behavior).
      
      * editing/execCommand/resources/toggle-compound-styles.js: Added.
      (testSingleToggle):
      * editing/execCommand/toggle-compound-styles.html: Added.
      * platform/gtk/editing/execCommand: Added.
      * platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt: Added.
      * platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Added.
      * platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Added.
      * platform/win/editing/execCommand: Added.
      * platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cbc4b64
  31. 06 Aug, 2009 1 commit
    • rniwa@webkit.org's avatar
      2009-08-06 Ryosuke Niwa <rniwa@webkit.org> · b3015e41
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              LayoutTests/editing/execCommand/boldSelection.html must be a dumpAsText test
              https://bugs.webkit.org/show_bug.cgi?id=28055
      
              This patch converts boldSelection.html to a dumpAsText and adds description on what it tests.
              Namely, it tests bolding the first 21 letters  of a sentence.
              Since bolding must be done by adding b tag instead of a style span, we print innerHTML of the result.
      
              * editing/execCommand/boldSelection-expected.txt: Added.
              * editing/execCommand/boldSelection.html:
              * platform/mac/editing/execCommand/boldSelection-expected.checksum: Removed.
              * platform/mac/editing/execCommand/boldSelection-expected.png: Removed.
              * platform/mac/editing/execCommand/boldSelection-expected.txt: Removed.
              * platform/qt/editing/execCommand/boldSelection-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3015e41
  32. 27 Jul, 2009 1 commit
    • rniwa@webkit.org's avatar
      WebCore: · 1a36737c
      rniwa@webkit.org authored
      2009-07-27  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Justin Garcia.
      
              createMarkup does not handle CSS properly
              https://bugs.webkit.org/show_bug.cgi?id=27660
      
              This patch isolates code that creates markup for styles in addStyleMarkup
              It also makes all presentational elements (u, s, strike, i, em, b, strong) special ancestor in createMarkup
              so that we can assume no text decoration style is passed to addStyleMarkup.
      
              * editing/markup.cpp:
              (WebCore::propertyMissingOrEqualToNone): Changed the first argument from CSSMutableStyleDecleration to CSSStyleDeclaration
              (WebCore::isElementPresentational): Used to be elementHasTextDecorationProperty, now supports presentational tags
              (WebCore::addStyleMarkup): Adds markup for style span and div
              (WebCore::createMarkup): Uses isElementPresentational and addStyleMarkup
      
      LayoutTests:
      
      2009-07-27  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Justin Garcia.
      
              createMarkup does not handle CSS properly
              https://bugs.webkit.org/show_bug.cgi?id=27660
              
              inline-style-after-indentoutdent tests whether the original inline style is preserved after outdentation
              immediately after indentation.
      
              * editing/deleting/pruning-after-merge-2.html: Replaced b that contains div with a div with font-weight
              * editing/execCommand/inline-style-after-indentoutdent-expected.txt: Added.
              * editing/execCommand/inline-style-after-indentoutdent.html: Added.
              * editing/execCommand/resources/inline-style-after-indentoutdent.js: Added.
              (testCreateMarkup):
              (shouldBeSameAfterCreateMarkup):
              * platform/mac/editing/deleting/delete-3857753-fix-expected.txt: extra i tag is added (still passes pixel tests)
              * platform/mac/editing/deleting/pruning-after-merge-2-expected.txt: extra div as explained above
              * platform/mac/editing/pasteboard/display-block-on-spans-expected.txt: bug 26483 appearing
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a36737c
  33. 23 Jul, 2009 2 commits
    • mrowe@apple.com's avatar
      Fix layout tests that incorrectly attempt to detect whether they're running... · b5cf863a
      mrowe@apple.com authored
      Fix layout tests that incorrectly attempt to detect whether they're running inside DumpRenderTree using "if (layoutTestController)".
      
      Rubber-stamped by Brady Eidson.
      
      * editing/execCommand/25256.html:
      * editing/execCommand/25320.html:
      * fast/canvas/arc-crash.html:
      * fast/css/emptyStyleTag.html:
      * fast/events/js-keyboard-event-creation.html:
      * fast/events/scrollbar-double-click.html:
      * fast/forms/select-no-name.html:
      * fast/history/window-open.html:
      * platform/mac/fast/events/objc-event-api.html:
      * platform/mac/fast/events/objc-keyboard-event-creation.html:
      * scrollbars/scrollbar-miss-mousemove-disabled.html:
      * scrollbars/scrollbar-miss-mousemove.html:
      * storage/domstorage/localstorage/clear.html:
      * storage/domstorage/localstorage/delete-removal.html:
      * storage/domstorage/localstorage/enumerate-storage.html:
      * storage/domstorage/localstorage/index-get-and-set.html:
      * storage/domstorage/localstorage/onstorage-attribute-markup.html:
      * storage/domstorage/localstorage/onstorage-attribute-setattribute.html:
      * storage/domstorage/localstorage/private-browsing-affects-storage.html:
      * storage/domstorage/localstorage/resources/window-open-second.html:
      * storage/domstorage/localstorage/simple-events.html:
      * storage/domstorage/localstorage/simple-usage.html:
      * storage/domstorage/localstorage/string-conversion.html:
      * storage/domstorage/localstorage/window-open.html:
      * storage/domstorage/sessionstorage/clear.html:
      * storage/domstorage/sessionstorage/delete-removal.html:
      * storage/domstorage/sessionstorage/enumerate-storage.html:
      * storage/domstorage/sessionstorage/index-get-and-set.html:
      * storage/domstorage/sessionstorage/onstorage-attribute-markup.html:
      * storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html:
      * storage/domstorage/sessionstorage/private-browsing-affects-storage.html:
      * storage/domstorage/sessionstorage/resources/window-open-second.html:
      * storage/domstorage/sessionstorage/simple-events.html:
      * storage/domstorage/sessionstorage/simple-usage.html:
      * storage/domstorage/sessionstorage/string-conversion.html:
      * storage/domstorage/sessionstorage/window-open.html:
      * storage/domstorage/window-attributes-exist.html:
      * svg/custom/stop-crash.svg:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5cf863a
    • rniwa@webkit.org's avatar
      WebCore: · 5bd84ef3
      rniwa@webkit.org authored
      2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              execCommand('underline') can't remove <U> underlines
              https://bugs.webkit.org/show_bug.cgi?id=20215
      
              This patch adds support for u, s, and strike to implicitlyStyledElementShouldBeRemovedWhenApplyingStyle so that
              WebKit can remove those presentational tags when necessary.
              It also modifies StyleChange::init not to add "text-decoration: none".  Not only is this style meaningless
              (does not override inherited styles) but it was also causing WebKit to generate extra spans with this style.
      
              * css/CSSValueList.cpp:
              (WebCore::CSSValueList::hasValue): True if the property contains the specified value
              * css/CSSValueList.h: Updated prototype
              * editing/ApplyStyleCommand.cpp:
              (WebCore::StyleChange::init): No longer adds "text-decoration: none"
              (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): Supports text-decoration-related elements
      
      LayoutTests:
      
      2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              execCommand('underline') can't remove <U> underlines
              https://bugs.webkit.org/show_bug.cgi?id=20215
      
              This patch rebaselines toggle-styles.html because WebKit now passes three tests it used to fail.
              toggle-style-2.html is added to test cases in which multiple styles are specified with tags.
              We still fail some tests because WebKit doesn't properly support non-CSS mode but they are visually correct.
      
              * editing/execCommand/resources/toggle-style-2.js: Added.
              (testSingleToggle):
              (testDoubleToggle):
              * editing/execCommand/toggle-style-2-expected.txt: Added.
              * editing/execCommand/toggle-style-2.html: Added.
              * editing/execCommand/toggle-styles-expected.txt: Passes all the tests
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bd84ef3
  34. 22 Jul, 2009 1 commit
    • rniwa@webkit.org's avatar
      WebCore: · 076531a0
      rniwa@webkit.org authored
      2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
              https://bugs.webkit.org/show_bug.cgi?id=27476
      
              executeStrikethrough and executeUnderline were toggling between "line-through" / "underline" and "none".
              This patch adds executeToggleStyleInList that toggles a style in CSSValueList instead of toggling the entire value.
              It modifies CSSComputedStyleDeclaration to return CSSValueList instead of CSSPrimitiveValue for text decorations,
              and adds removeAll member function to CSSValueList.
      
              Tests: editing/execCommand/toggle-text-decorations.html
                     fast/css/getComputedStyle/getComputedStyle-text-decoration.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::renderTextDecorationFlagsToCSSValue): Creates a CSSValueList
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Returns a CSSValueList instead of CSSValue
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue): Text decorations are space separated instead of comma separated
              * css/CSSValueList.cpp:
              (WebCore::CSSValueList::removeAll): Removes all values that match the specified value
              * css/CSSValueList.h:
              * editing/EditorCommand.cpp:
              (WebCore::applyCommandToFrame): Apply style to a frame using specified command
              (WebCore::executeApplyStyle): Uses applyCommandToFrame
              (WebCore::executeToggleStyleInList): Uses applyCommandToFrame
              (WebCore::executeToggleStyle): Toggles a style in CSSValueList
              (WebCore::executeStrikethrough): Uses executeToggleStyleInList
              (WebCore::executeUnderline): Uses executeToggleStyleInList
      
      LayoutTests:
      
      2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
              https://bugs.webkit.org/show_bug.cgi?id=27476
      
              toggle-text-decorations checks whether we can toggle text decorations with multiple styles properly.
              e.g. execCommand("underline") should modify "text-decoration: underline overline" to "text-decoration: overline"
      
              getComputedStyle-text-decorations checks whether the CSS value of text decoration and its computed style are
              both space-separated CSSValueList instead of CSSPrimitiveValue or comma-separated CSSValueList.
      
              * editing/execCommand/resources/toggle-text-decorations.js: Added.
              (testSingleToggle):
              * editing/execCommand/toggle-text-decorations-expected.txt: Added.
              * editing/execCommand/toggle-text-decorations.html: Added.
              * fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt: Added.
              * fast/css/getComputedStyle/getComputedStyle-text-decoration.html: Added.
              * fast/css/getComputedStyle/resources: Added.
              * fast/css/getComputedStyle/resources/TEMPLATE.html: Added.
              * fast/css/getComputedStyle/resources/getComputedStyle-text-decoration.js: Added.
              (expect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      076531a0