1. 02 Dec, 2013 23 commits
    • fpizlo@apple.com's avatar
      Stores to local captured variables should be intercepted · 0309686b
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124883
      
      Source/JavaScriptCore: 
      
      Reviewed by Mark Hahnenberg.
              
      Previously, in bytecode, you could assign to a captured variable just as you would
      assign to any other kind of variable. This complicates closure variable constant
      inference because we don't have any place where we can intercept stores to captured
      variables in the LLInt.
              
      This patch institutes a policy that only certain instructions can store to captured
      variables. If you interpret those instructions and you are required to notifyWrite()
      then you need to check if the relevant variable is captured. Those instructions are
      tracked in CodeBlock.cpp's VerifyCapturedDef. The main one is simply op_captured_mov.
      In the future, we'll probably modify those instructions to have a pointer directly to
      the VariableWatchpointSet; but for now we just introduce the captured instructions as
      placeholders.
              
      In order to validate that the placeholders are inserted correctly, this patch improves
      the CodeBlock validation to be able to inspect every def in the bytecode. To do that,
      this patch refactors the liveness analysis' use/def calculator to be reusable; it now
      takes a functor for each use or def.
              
      In the process of refactoring the liveness analysis, I noticed that op_enter was
      claiming to def all callee registers. That's wrong; it only defs the non-temporary
      variables. Making that change revealed preexisting bugs in the liveness analysis, since
      now the validator would pick up cases where the bytecode claimed to use a temporary and
      the def calculator never noticed the definition (or the converse - where the bytecode
      was actually not using a temporary but the liveness analysis thought that it was a
      use). This patch fixes a few of those bugs.
      
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * bytecode/BytecodeLivenessAnalysis.cpp:
      (JSC::stepOverInstruction):
      * bytecode/BytecodeUseDef.h: Added.
      (JSC::computeUsesForBytecodeOffset):
      (JSC::computeDefsForBytecodeOffset):
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::dumpBytecode):
      (JSC::CodeBlock::isCaptured):
      (JSC::CodeBlock::validate):
      * bytecode/CodeBlock.h:
      * bytecode/Opcode.h:
      (JSC::padOpcodeName):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::BytecodeGenerator):
      (JSC::BytecodeGenerator::resolveCallee):
      (JSC::BytecodeGenerator::emitMove):
      (JSC::BytecodeGenerator::isCaptured):
      (JSC::BytecodeGenerator::local):
      (JSC::BytecodeGenerator::constLocal):
      (JSC::BytecodeGenerator::emitNewFunction):
      (JSC::BytecodeGenerator::emitLazyNewFunction):
      (JSC::BytecodeGenerator::emitNewFunctionInternal):
      * bytecompiler/BytecodeGenerator.h:
      (JSC::Local::Local):
      (JSC::Local::isCaptured):
      (JSC::Local::captureMode):
      (JSC::BytecodeGenerator::captureMode):
      (JSC::BytecodeGenerator::emitNode):
      (JSC::BytecodeGenerator::pushOptimisedForIn):
      * bytecompiler/NodesCodegen.cpp:
      (JSC::PostfixNode::emitResolve):
      (JSC::PrefixNode::emitResolve):
      (JSC::ReadModifyResolveNode::emitBytecode):
      (JSC::AssignResolveNode::emitBytecode):
      (JSC::ConstDeclNode::emitCodeSingle):
      (JSC::ForInNode::emitBytecode):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGCapabilities.cpp:
      (JSC::DFG::capabilityLevel):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompileMainPass):
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      * runtime/SymbolTable.h:
      (JSC::SymbolTable::isCaptured):
      
      LayoutTests: 
      
      Reviewed by Mark Hahnenberg.
      
      * js/regress/captured-assignments-expected.txt: Added.
      * js/regress/captured-assignments.html: Added.
      * js/regress/script-tests/captured-assignments.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0309686b
    • fpizlo@apple.com's avatar
      Instead of watchpointing activation allocation, we should watchpoint entry... · a4ea0663
      fpizlo@apple.com authored
      Instead of watchpointing activation allocation, we should watchpoint entry into functions that have captured variables
      https://bugs.webkit.org/show_bug.cgi?id=125052
      
      Reviewed by Mark Hahnenberg.
              
      This makes us watch function entry rather than activation creation. We only incur the
      costs of doing so for functions that have captured variables, and only on the first two
      entries into the function. This means that closure variable constant inference will
      naturally work even for local uses of the captured variable, like:
              
          (function(){
              var blah = 42;
              ... // stuff
              function () { ... blah /* we can fold this to 42 */ }
              ... blah // we can also fold this to 42.
          })();
              
      Previously, only the nested use would have been foldable.
      
      * bytecode/BytecodeLivenessAnalysis.cpp:
      (JSC::computeUsesForBytecodeOffset):
      (JSC::computeDefsForBytecodeOffset):
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::dumpBytecode):
      * bytecode/Opcode.h:
      (JSC::padOpcodeName):
      * bytecode/Watchpoint.h:
      (JSC::WatchpointSet::touch):
      (JSC::InlineWatchpointSet::touch):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::BytecodeGenerator):
      * dfg/DFGAbstractInterpreterInlines.h:
      (JSC::DFG::::executeEffects):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGCapabilities.cpp:
      (JSC::DFG::capabilityLevel):
      * dfg/DFGClobberize.h:
      (JSC::DFG::clobberize):
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::fixupNode):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::hasSymbolTable):
      * dfg/DFGNodeType.h:
      * dfg/DFGPredictionPropagationPhase.cpp:
      (JSC::DFG::PredictionPropagationPhase::propagate):
      * dfg/DFGSafeToExecute.h:
      (JSC::DFG::safeToExecute):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGWatchpointCollectionPhase.cpp:
      (JSC::DFG::WatchpointCollectionPhase::handle):
      * ftl/FTLCapabilities.cpp:
      (JSC::FTL::canCompile):
      * ftl/FTLLowerDFGToLLVM.cpp:
      (JSC::FTL::LowerDFGToLLVM::compileNode):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompileMainPass):
      * jit/JIT.h:
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_touch_entry):
      * llint/LowLevelInterpreter.asm:
      * runtime/CommonSlowPaths.cpp:
      (JSC::SLOW_PATH_DECL):
      * runtime/CommonSlowPaths.h:
      * runtime/JSActivation.h:
      (JSC::JSActivation::create):
      * runtime/SymbolTable.cpp:
      (JSC::SymbolTable::SymbolTable):
      * runtime/SymbolTable.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4ea0663
    • bfulgham@apple.com's avatar
      [Win] WebKit Project doesn't copy resource bundle · 4e2662cd
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125078
      
      Reviewed by Jer Noble.
      
      * WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Correct post-build step
      to copy WebKit.resources to build target.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e2662cd
    • commit-queue@webkit.org's avatar
      [JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros · 7ca12a53
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125075
      
      Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-02
      Reviewed by Michael Saboff.
      
      * llint/LLIntSlowPaths.cpp:
      (JSC::LLInt::handleHostCall): added UNUSED_PARAM(pc).
      (JSC::LLInt::setUpCall): Doesn't pass 'pc' to LLINT_CALL macros.
      (JSC::LLInt::LLINT_SLOW_PATH_DECL): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ca12a53
    • commit-queue@webkit.org's avatar
      [GTK] Fails to build with freetype 2.5.1 · 171588c7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125074
      
      Patch by Andres Gomez <agomez@igalia.com> on 2013-12-02
      Reviewed by Carlos Garcia Campos.
      
      FreeType specifies a canonical way of including their own
      headers. Now, we are following this recommendation so the
      compilation won't be broken again due to an upgrade in FeeType's
      including paths.
      
      * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
      * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
      * platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      171588c7
    • lauro.neto@openbossa.org's avatar
      [MediaStream] Update layout tests to newer spec. · 1aa1edc8
      lauro.neto@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124985
      
      Reviewed by Eric Carlson.
      
      * TestExpectations:
      * fast/mediastream/MediaStream-onended-expected.txt: Removed.
      * fast/mediastream/MediaStreamTrack-onended-expected.txt: Added.
      * fast/mediastream/MediaStreamTrack-onended.html: Renamed from LayoutTests/fast/mediastream/MediaStream-onended.html.
      * fast/mediastream/RTCPeerConnection-ice-expected.txt:
      * fast/mediastream/RTCPeerConnection-state-expected.txt:
      * fast/mediastream/RTCSessionDescription-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1aa1edc8
    • commit-queue@webkit.org's avatar
      Remove stdio.h from JSC files. · 5e2fce2c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125066
      
      Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-02
      Reviewed by Michael Saboff.
      
      Remove stdio.h, when it is not necessary to be included.
      
      * bytecode/CodeBlock.cpp:
      * bytecode/StructureSet.h:
      * profiler/LegacyProfiler.cpp:
      * profiler/Profile.cpp:
      * profiler/ProfileNode.cpp:
      * yarr/YarrInterpreter.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e2fce2c
    • commit-queue@webkit.org's avatar
      Unused include files when building without JIT. · d334b757
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125062
      
      Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-02
      Reviewed by Michael Saboff.
      
      We should organize the includes, and guard JIT methods
      in ValueRecovery.
      
      * bytecode/ValueRecovery.cpp: Guard include files.
      * bytecode/ValueRecovery.h: Guard JIT methods.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d334b757
    • commit-queue@webkit.org's avatar
      [MIPS] Small stack frame causes regressions. · 13da9276
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124945
      
      Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-12-02
      Reviewed by Michael Saboff.
      
      Fix stack space for LLInt on MIPS.
      
      * llint/LowLevelInterpreter32_64.asm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13da9276
    • commit-queue@webkit.org's avatar
      jsc: implement a native readFile function · d296f384
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125059
      
      Patch by Brian J. Burg <burg@cs.washington.edu> on 2013-12-02
      Reviewed by Filip Pizlo.
      
      This adds a native readFile() function to jsc, used to slurp
      an entire file into a JavaScript string.
      
      * jsc.cpp:
      (GlobalObject::finishCreation): Add readFile() to globals.
      (functionReadFile): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d296f384
    • commit-queue@webkit.org's avatar
      JSC does not build if OPCODE_STATS is enabled. · 2f00452d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125011
      
      Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-02
      Reviewed by Filip Pizlo.
      
      * bytecode/Opcode.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f00452d
    • cfleizach@apple.com's avatar
      AX: Crash at WebCore::commonTreeScope · 0fb724ec
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125042
      
      Reviewed by Mario Sanchez Prada.
      
      Source/WebCore:
      
      When an AX text marker that references a node in a detached document is used to create a text marker range, a crash occurs
      because the method to determine commonTreeScopes does not account for when there are no common tree scopes.
      
      Test: platform/mac/accessibility/ordered-textmarker-crash.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions):
      * dom/TreeScope.cpp:
      (WebCore::commonTreeScope):
      
      LayoutTests:
      
      * platform/mac/accessibility/ordered-textmarker-crash-expected.txt: Added.
      * platform/mac/accessibility/ordered-textmarker-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fb724ec
    • commit-queue@webkit.org's avatar
      Fix a crash in the webaudio source provider when the audio track is going away. · 8e68aab3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124975
      
      Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-02
      Reviewed by Philippe Normand.
      
      Merged https://chromium.googlesource.com/chromium/blink/+/b21838b32bf11b1a972dfc449ddde71115490c23
      
      Before this patch, it was hitting a use-after-free crash  when the audio
      track in the media stream is going away and the webaudio mediastreamsourcenode
      is still running.
      
      * Modules/webaudio/AudioContext.cpp:
      (WebCore::AudioContext::createMediaStreamSource): Passing audio track
      pointer to MediaStreamAudioSourceNode constructor.
      * Modules/webaudio/MediaStreamAudioSourceNode.cpp:
      (WebCore::MediaStreamAudioSourceNode::create):
      (WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
      * Modules/webaudio/MediaStreamAudioSourceNode.h: Added
      MediaStreamTrack class variable and change the constructor to receive
      it as parameter.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e68aab3
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 5560f092
      zandobersek@gmail.com authored
      * platform/gtk/TestExpectations: Adding failure expectations for the
      fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html reftest.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5560f092
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed, EFL rebaseline since r159915. · a49d17aa
      gyuyoung.kim@samsung.com authored
      Error messages are changed. So, test results need to be updated.
      
      * platform/efl/fast/forms/validation-message-appearance-expected.txt:
      * platform/efl/fast/forms/validationMessage-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a49d17aa
    • commit-queue@webkit.org's avatar
      [GTK] Remove unneeded autoconf macros · 0590b072
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125044
      
      Compilers that do not support const/inline/volatile and
      systems with pre-C89-headers are anyway not supported.
      
      Patch by Adrian Bunk <bunk@stusta.de> on 2013-12-02
      Reviewed by Gustavo Noronha Silva.
      
      * Source/autotools/CheckSystemAndBasicDependencies.m4:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0590b072
    • gns@gnome.org's avatar
      [GTK] GTK2 paint code path does not render AC layers · d6072972
      gns@gnome.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124967
      
      Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-12-02
      Reviewed by Carlos Garcia Campos.
      
      * webkit/webkitwebview.cpp:
      (webkit_web_view_expose_event): also paint AC layers when painting the widget,
      when AC is on.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6072972
    • commit-queue@webkit.org's avatar
      [ATK] Support active state for listbox elements. · c4299267
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125009
      
      Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-12-02
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Added support for ATK_STATE_ACTIVE for listbox elements.
      
      * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
      (setAtkStateSetFromCoreObject):
      
      Tools:
      
      Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
      
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (AccessibilityUIElement::isSelectedOptionActive):
      * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
      (WTR::AccessibilityUIElement::isSelectedOptionActive):
      * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
      * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::AccessibilityUIElement::isSelectedOptionActive):
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
      (WTR::AccessibilityUIElement::isSelectedOptionActive):
      
      LayoutTests:
      
      Establish expectations for the test (all PASS).
      
      * accessibility/multiselect-list-reports-active-option-expected.txt: Added.
      * platform/efl-wk1/TestExpectations:
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4299267
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · f966db34
      zandobersek@gmail.com authored
      * Scripts/run-gtk-tests:
      (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f966db34
    • seokju@webkit.org's avatar
      Web Inspector: Remove unused functions from InspectorAgent · 6efb4b68
      seokju@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125061
      
      Reviewed by Antoine Quint.
      
      Get rid of unused functions, redundant inclusion and forward declaration.
      
      No new tests, no behavior changes.
      
      * inspector/InspectorAgent.cpp:
      * inspector/InspectorAgent.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6efb4b68
    • commit-queue@webkit.org's avatar
      Fix build warning in EventHandler.cpp · 7fa2cb82
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125010
      
      Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-12-02
      Reviewed by Csaba Osztrogonác.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fa2cb82
    • commit-queue@webkit.org's avatar
      HTML5 required attribute validation messages implemented. · 1a6f0e2c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125003
      
      Patch by Attila Dusnoki <adusnoki@inf.u-szeged.hu> on 2013-12-02
      Reviewed by Gyuyoung Kim.
      
      * platform/efl/LocalizedStringsEfl.cpp:
      (WebCore::validationMessagePatternMismatchText):
      (WebCore::validationMessageValueMissingText):
      (WebCore::validationMessageValueMissingForCheckboxText):
      (WebCore::validationMessageValueMissingForFileText):
      (WebCore::validationMessageValueMissingForMultipleFileText):
      (WebCore::validationMessageValueMissingForRadioText):
      (WebCore::validationMessageValueMissingForSelectText):
      (WebCore::validationMessageBadInputForNumberText):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a6f0e2c
    • changseok.oh@collabora.com's avatar
      Unreviewed Gtk port Build fix after r159903 · 4bc671cd
      changseok.oh@collabora.com authored
      * UIProcess/DrawingAreaProxyImpl.cpp:
      (WebKit::DrawingAreaProxyImpl::layerHostingModeDidChange):
      (WebKit::DrawingAreaProxyImpl::update):
      (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
      (WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
      (WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):
      * UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
      (WebKit::WebFullScreenManagerProxy::invalidate):
      * UIProcess/gtk/WebInspectorProxyGtk.cpp:
      (WebKit::WebInspectorProxy::platformCreateInspectorPage):
      * UIProcess/gtk/WebPageProxyGtk.cpp:
      (WebKit::WebPageProxy::setAcceleratedCompositingWindowId):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bc671cd
  2. 01 Dec, 2013 16 commits
  3. 30 Nov, 2013 1 commit
    • weinig@apple.com's avatar
      [CTTE] The WebPageProxy's WebPageGroup is never null so it should be stored in a Ref · 3b9444bb
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125038
      
      Reviewed by Dan Bernstein.
      
      * UIProcess/API/C/WKPage.cpp:
      (WKPageGetPageGroup):
      * UIProcess/API/C/mac/WKPagePrivateMac.cpp:
      (WKPageIsURLKnownHSTSHost):
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
      (-[WKBrowsingContextController browsingContextGroup]):
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _preferencesDidChange]):
      (-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::WebContext):
      (WebKit::WebContext::createWebPage):
      * UIProcess/WebContext.h:
      * UIProcess/WebInspectorProxy.cpp:
      (WebKit::WebInspectorPageGroups::inspectorLevel):
      (WebKit::WebInspectorPageGroups::isInspectorPageGroup):
      (WebKit::WebInspectorPageGroups::inspectorPageGroupLevel):
      (WebKit::WebInspectorProxy::isInspectorPage):
      * UIProcess/WebInspectorProxy.h:
      * UIProcess/WebPageGroup.cpp:
      (WebKit::WebPageGroup::createNonNull):
      * UIProcess/WebPageGroup.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::create):
      (WebKit::WebPageProxy::WebPageProxy):
      (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
      (WebKit::WebPageProxy::preferencesDidChange):
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::pageGroup):
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::createWebPage):
      * UIProcess/WebProcessProxy.h:
      * UIProcess/mac/WebInspectorProxyMac.mm:
      (WebKit::WebInspectorProxy::createInspectorWindow):
      (WebKit::WebInspectorProxy::platformCreateInspectorPage):
      (WebKit::WebInspectorProxy::windowFrameDidChange):
      * UIProcess/mac/WebProcessProxyMac.mm:
      (WebKit::WebProcessProxy::pageIsProcessSuppressible):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b9444bb