1. 27 Sep, 2010 40 commits
    • hclam@chromium.org's avatar
      Build fix. Not reviewed. · 026746c5
      hclam@chromium.org authored
      Add a default for unhandled cases for switch statement.
      
      * src/VideoFrameChromiumImpl.cpp:
      (WebKit::VideoFrameChromiumImpl::requiredTextureSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      026746c5
    • morrita@google.com's avatar
      2010-09-27 MORITA Hajime <morrita@google.com> · d90eac0f
      morrita@google.com authored
              Unreviewed, add an expectation.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d90eac0f
    • tony@chromium.org's avatar
      2010-09-27 Tony Chang <tony@chromium.org> · 8fb4773d
      tony@chromium.org authored
              Reviewed by David Levin.
      
              [chromium] fix a warning when compiling DRT on 32-bit linux
              https://bugs.webkit.org/show_bug.cgi?id=46641
      
              * DumpRenderTree/chromium/TestEventPrinter.cpp:
              (DRTPrinter::handleImage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fb4773d
    • rniwa@webkit.org's avatar
      2010-09-27 Ryosuke Niwa <rniwa@webkit.org> · 06f1791f
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              queryCommandState with justifyCenter, justifyLeft, and justifyRight always return false
              https://bugs.webkit.org/show_bug.cgi?id=45910
      
              Implemented queryCommandState for justifyCenter, justifyLeft, and justifyRight commands.
              Added getTextAlignment to convert -webkit-center, -webkit-left, and -webkit-right to
              center, left, and right respectively because they can be treated equally for editing purposes.
      
              Test: editing/execCommand/query-text-alignment.html
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::getTextAlignment): Added.
              (WebCore::getPropertiesNotIn): Uses getTextAlignment.
              * editing/EditorCommand.cpp:
              (WebCore::stateJustifyCenter): Added.
              (WebCore::stateJustifyLeft): Added.
              (WebCore::stateJustifyRight): Added.
              (WebCore::createCommandMap): Refers to stateJustifyCenter, stateJustifyLeft, and stateJustifyRight.
      2010-09-27  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              queryCommandState with justifyCenter, justifyLeft, and justifyRight always return false
              https://bugs.webkit.org/show_bug.cgi?id=45910
      
              Added tests for queryCommandState with justifyCenter, justifyLeft, and justifyRight commands.
      
              * editing/execCommand/query-text-alignment-expected.txt: Added.
              * editing/execCommand/query-text-alignment.html: Added.
              * editing/execCommand/script-tests/query-text-alignment.js: Added.
              (queryTextAlignment):
              (selectFirstPosition):
              (selectMiddleOfHelloWorld):
              (runRangeTests):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06f1791f
    • hclam@chromium.org's avatar
      Unreviewed. Build fix. · e97883b2
      hclam@chromium.org authored
      Reorder member declarations and fix other warnings.
      
      * platform/graphics/chromium/VideoLayerChromium.cpp:
      (WebCore::VideoLayerChromium::VideoLayerChromium):
      (WebCore::VideoLayerChromium::~VideoLayerChromium):
      (WebCore::VideoLayerChromium::updateContents):
      (WebCore::VideoLayerChromium::determineTextureFormat):
      (WebCore::VideoLayerChromium::allocateTexturesIfNeeded):
      * platform/graphics/chromium/VideoLayerChromium.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e97883b2
    • jamesr@google.com's avatar
      2010-09-27 James Robinson <jamesr@chromium.org> · b480a817
      jamesr@google.com authored
              Update baselines for fast/repaint/repaint-svg-after-style-change.html
      
              * fast/repaint/repaint-svg-after-style-change-expected.txt:
              * platform/chromium/fast/repaint/repaint-svg-after-style-change-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b480a817
    • kbr@google.com's avatar
      2010-09-27 Kenneth Russell <kbr@google.com> · fc98bc36
      kbr@google.com authored
              Unreviewed, Qt build fix. Stub out CanvasRenderingContext::checkOrigin(const HTMLVideoElement*)
              on platforms that don't support video after r68460.
      
              * html/canvas/CanvasRenderingContext.cpp:
              (WebCore::CanvasRenderingContext::checkOrigin):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc98bc36
    • cfleizach@apple.com's avatar
      CrashTracer: 1,803 crashes in Safari at com.apple.WebCore:... · b38d055e
      cfleizach@apple.com authored
      CrashTracer: 1,803 crashes in Safari at com.apple.WebCore: -[AccessibilityObjectWrapper accessibilityIsIgnored] + 56
      https://bugs.webkit.org/show_bug.cgi?id=46662
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      Before calling updateBackingStore(), the wrapper object needs to be retained, lest it be invalidated during
      the updateBackingStore call. This consolidates all calls to updateBackingStore().
      
      Test: platform/mac/accessibility/removing-textarea-after-edit-crash.html
      
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::postPlatformNotification):
          Use an ASSERT here to catch the crash because DRT won't cause AppKit to post notifications.
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper prepareAccessibilityMethod]):
      (-[AccessibilityObjectWrapper accessibilityActionNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
      (-[AccessibilityObjectWrapper accessibilityHitTest:]):
      (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
      (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
      (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
      (-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
      (-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
      (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
      (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
      (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
      (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
      (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/removing-textarea-after-edit-crash-expected.txt: Added.
      * platform/mac/accessibility/removing-textarea-after-edit-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b38d055e
    • kbr@google.com's avatar
      2010-09-27 Adrienne Walker <enne@google.com> · 3b5c5818
      kbr@google.com authored
              Reviewed by Adam Barth.
      
              WebGL's readPixels doesn't respect origin-clean flag
      
              Push CanvasRenderingContext2D checkOrigin logic into base class so it can be shared between different kinds of canvas contexts.
              https://bugs.webkit.org/show_bug.cgi?id=45718
      
              Test: LayoutTests/http/tests/canvas/webgl/origin-clean-conformance.html
      
              * html/canvas/CanvasRenderingContext.cpp:
              (WebCore::CanvasRenderingContext::checkOrigin):
              * html/canvas/CanvasRenderingContext.h:
              (WebCore::CanvasRenderingContext::~CanvasRenderingContext):
              (WebCore::CanvasRenderingContext::canvas):
              (WebCore::CanvasRenderingContext::is2d):
              (WebCore::CanvasRenderingContext::is3d):
              (WebCore::CanvasRenderingContext::isAccelerated):
              (WebCore::CanvasRenderingContext::paintRenderingResultsToCanvas):
              (WebCore::CanvasRenderingContext::paintsIntoCanvasBuffer):
              (WebCore::CanvasRenderingContext::platformLayer):
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::setStrokeStyle):
              (WebCore::CanvasRenderingContext2D::setFillStyle):
              (WebCore::CanvasRenderingContext2D::drawImage):
              (WebCore::CanvasRenderingContext2D::drawImageFromRect):
              * html/canvas/CanvasRenderingContext2D.h:
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::readPixels):
              (WebCore::WebGLRenderingContext::texImage2D):
              (WebCore::WebGLRenderingContext::videoFrameToImage):
              (WebCore::WebGLRenderingContext::texSubImage2D):
              * html/canvas/WebGLRenderingContext.h:
              * html/canvas/WebGLRenderingContext.idl:
      2010-09-27  Adrienne Walker  <enne@google.com>
      
              Reviewed by Adam Barth.
      
              WebGL's readPixels doesn't respect origin-clean flag
      
              Add new test by converting Khronos conformance test to be able to run within LayoutTests/http.
              https://bugs.webkit.org/show_bug.cgi?id=45718
      
              * http/tests/canvas/webgl/origin-clean-conformance-expected.txt: Added.
              * http/tests/canvas/webgl/origin-clean-conformance.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b5c5818
    • darin@apple.com's avatar
      2010-09-27 Darin Adler <darin@apple.com> · cef22f3f
      darin@apple.com authored
              Reviewed by Dan Bernstein.
      
              REGRESSION (r68054): Buttons no longer render at correct sizes
              https://bugs.webkit.org/show_bug.cgi?id=46513
      
              Test: fast/forms/input-button-sizes.html
      
              The setUpButtonCell function was running only once, but needed to run every time
              through the button function.
      
              * platform/mac/ThemeMac.mm:
              (WebCore::leakButtonCell): Added. Separate one-time initialization code.
              (WebCore::setUpButtonCell): Removed the first-time initialization part of this function.
              (WebCore::button): Merged the three functions back into one.
      2010-09-27  Darin Adler  <darin@apple.com>
      
              Reviewed by Dan Bernstein.
      
              REGRESSION (r68054): Buttons no longer render at correct sizes
              https://bugs.webkit.org/show_bug.cgi?id=46513
      
              * fast/forms/input-button-sizes.html: Copied from LayoutTests/fast/forms/button-sizes.html.
              Turned into a distinct test of <input type=button>; old test was for <button>.
      
              * platform/mac/fast/forms/input-button-sizes-expected.checksum: Added.
              * platform/mac/fast/forms/input-button-sizes-expected.png: Added.
              * platform/mac/fast/forms/input-button-sizes-expected.txt: Added.
      
              * platform/mac/fast/forms/disabled-select-change-index-expected.checksum: Added.
              * platform/mac/fast/forms/disabled-select-change-index-expected.png: Added.
              * platform/mac/fast/forms/file-input-disabled-expected.checksum: Added.
              * platform/mac/fast/forms/file-input-disabled-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cef22f3f
    • zmo@google.com's avatar
      2010-09-27 Zhenyao Mo <zmo@google.com> · 94aa1af1
      zmo@google.com authored
              Unreviewed, fix a typo.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94aa1af1
    • kenneth@webkit.org's avatar
      [Qt] Remove setDeviceSize methods · 07f151e1
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=46347
      
      Reviewed by Antonio Gomes.
      
      Remove our setDeviceHeight() API and obtain it automatically from the
      system. Also for testing purposes, make it possible to override the
      values via two newly introduced environment variables.
      
      * Api/qgraphicswebview.cpp:
      * Api/qgraphicswebview.h:
      * Api/qwebpage.cpp:
      (getintenv):
      (queryDeviceSizeForScreenContainingWidget):
      (QWebPage::viewportConfigurationForSize):
      * WebCoreSupport/PageClientQt.cpp:
      (WebCore::PageClientQGraphicsWidget::windowRect):
      * symbian/eabi/QtWebKitu.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07f151e1
    • andersca@apple.com's avatar
      Turns out people other than me might want to build this thing. · 6827cc89
      andersca@apple.com authored
      * WebKit2.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6827cc89
    • barraclough@apple.com's avatar
      Bug 46680 - Inlining string concatenation can regress interpreter performance · 5be406f5
      barraclough@apple.com authored
      <rdar://problem/8362752> REGRESSION: ~6.4% sunspider regression in interpreter
      Do not inline calls to string concatenation in the interpret loop.
      
      Reviewed by Darin Adler.
      
      * interpreter/Interpreter.cpp:
      (JSC::concatenateStrings):
      (JSC::Interpreter::privateExecute):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5be406f5
    • darin@apple.com's avatar
      * Scripts/webkit2: Added property svn:ignore. · 449bb335
      darin@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      449bb335
    • eric@webkit.org's avatar
      2010-09-27 Eric Seidel <eric@webkit.org> · 9ab03757
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              queue-status should report when the patch was last locked to a queue
              https://bugs.webkit.org/show_bug.cgi?id=46674
      
              This isn't necessarily the best way to expose this information
              but having this accessible via the web interface is very
              useful until we come up with a nicer way to display this.
      
              I also cleaned up the code in activeworkitems.py a little
              to use list comprehensions and to have the code work with
              pairs instead of two lists at once.  Eventually I think those
              item/time pairs need to be their own little helper class.
      
              * QueueStatusServer/handlers/queuestatus.py:
              * QueueStatusServer/model/activeworkitems.py:
              * QueueStatusServer/templates/queuestatus.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ab03757
    • andersca@apple.com's avatar
      * Platform/CoreIPC/Connection.h: · ae7b6f54
      andersca@apple.com authored
      (CoreIPC::Connection::sendSync):
      Add new sendSync overload that takes a message struct.
      
      Reviewed by Sam Weinig.
      
      * PluginProcess/WebProcessConnection.cpp:
      (WebKit::WebProcessConnection::didReceiveSyncMessage):
      Call didReceiveSyncWebProcessConnectionMessage.
      
      * WebProcess/Plugins/PluginProcessConnection.cpp:
      (WebKit::PluginProcessConnection::addPluginProxy):
      Add the plug-in proxy to the map.
      
      (WebKit::PluginProcessConnection::removePluginProxy):
      Remove the plug-in proxy from the map. If the map is empty, disconnect from the
      plug-in process.
      
      * WebProcess/Plugins/PluginProxy.cpp:
      (WebKit::generatePluginInstanceID):
      Generate a unique plug-in instance ID.
      
      (WebKit::PluginProxy::PluginProxy):
      Add the plug-in proxy to the map.
      
      (WebKit::PluginProxy::~PluginProxy):
      Remove the plug-in proxy from the map.
      
      (WebKit::PluginProxy::initialize):
      Ask the plug-in process to create a plug-in.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae7b6f54
    • tony@chromium.org's avatar
      2010-09-27 Tony Chang <tony@chromium.org> · 14981dd0
      tony@chromium.org authored
              Reviewed by David Levin.
      
              [chromium] fix detection of missing fonts on DRT
              https://bugs.webkit.org/show_bug.cgi?id=46651
      
              * DumpRenderTree/chromium/TestShellGtk.cpp:
              (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14981dd0
    • tony@chromium.org's avatar
      2010-09-27 Tony Chang <tony@chromium.org> · effb21d9
      tony@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              add webkit unit tests to the chromium testers
              https://bugs.webkit.org/show_bug.cgi?id=46669
      
              * BuildSlaveSupport/build.webkit.org-config/master.cfg:
              * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      effb21d9
    • kseo@webkit.org's avatar
      Unreviewed. · aa5cec22
      kseo@webkit.org authored
      Adding myself to the committers list.
      
      * Scripts/webkitpy/common/config/committers.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa5cec22
    • zmo@google.com's avatar
      2010-09-27 Zhenyao Mo <zmo@google.com> · 3116573f
      zmo@google.com authored
              Unreviewed.  Three webgl tests TIMEOUT after hooking up ANGLE with in-process-webgl port.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3116573f
    • commit-queue@webkit.org's avatar
      2010-09-27 Victoria Kirst <vrk@google.com> · 3dc04877
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              Modifies VideoLayerChromium to do YUV to RGB color conversion in the
              GPU. Also adds support for RGBA video frame formats, though this code
              path is currently never run because the video frames are in YV12
              format.
              https://bugs.webkit.org/show_bug.cgi?id=45069
      
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::initializeSharedObjects):
              (WebCore::LayerRendererChromium::cleanupSharedObjects):
              * platform/graphics/chromium/LayerRendererChromium.h:
              (WebCore::LayerRendererChromium::videoLayerSharedValues):
              * platform/graphics/chromium/VideoLayerChromium.cpp:
              (WebCore::VideoLayerChromium::SharedValues::SharedValues):
              (WebCore::VideoLayerChromium::SharedValues::~SharedValues):
              (WebCore::VideoLayerChromium::VideoLayerChromium):
              (WebCore::VideoLayerChromium::~VideoLayerChromium):
              (WebCore::VideoLayerChromium::updateContents):
              (WebCore::VideoLayerChromium::updateYUVContents):
              (WebCore::VideoLayerChromium::allocateYUVTextures):
              (WebCore::VideoLayerChromium::updateYUVTextures):
              (WebCore::VideoLayerChromium::updateRGBAContents):
              (WebCore::VideoLayerChromium::allocateTexture):
              (WebCore::VideoLayerChromium::updateTexture):
              (WebCore::VideoLayerChromium::updateContentsCompleted):
              (WebCore::VideoLayerChromium::draw):
              (WebCore::VideoLayerChromium::drawYUV):
              (WebCore::VideoLayerChromium::drawRGBA):
              * platform/graphics/chromium/VideoLayerChromium.h:
              (WebCore::VideoLayerChromium::drawsContent):
              (WebCore::VideoLayerChromium::SharedValues::yuvShaderProgram):
              (WebCore::VideoLayerChromium::SharedValues::rgbaShaderProgram):
              (WebCore::VideoLayerChromium::SharedValues::yuvShaderMatrixLocation):
              (WebCore::VideoLayerChromium::SharedValues::rgbaShaderMatrixLocation):
              (WebCore::VideoLayerChromium::SharedValues::yuvWidthScaleFactorLocation):
              (WebCore::VideoLayerChromium::SharedValues::rgbaWidthScaleFactorLocation):
              (WebCore::VideoLayerChromium::SharedValues::yTextureLocation):
              (WebCore::VideoLayerChromium::SharedValues::uTextureLocation):
              (WebCore::VideoLayerChromium::SharedValues::vTextureLocation):
              (WebCore::VideoLayerChromium::SharedValues::yuvAlphaLocation):
              (WebCore::VideoLayerChromium::SharedValues::rgbaTextureLocation):
              (WebCore::VideoLayerChromium::SharedValues::ccMatrixLocation):
              (WebCore::VideoLayerChromium::SharedValues::initialized):
      2010-09-27  Victoria Kirst  <vrk@google.com>
      
              Reviewed by James Robinson.
      
              Fixing constants in VideoFrameChromiumImpl so that it overloads the
              VideoFrameChromium const declarations. Also adding logic such that a
              VideoFrameChromium understands what size its texture should be based
              on frame format.
              https://bugs.webkit.org/show_bug.cgi?id=45069
      
              * src/VideoFrameChromiumImpl.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3dc04877
    • pkasting@chromium.org's avatar
      WebCore: ImageDecoderSkia.cpp needs to check for allocator failure when copying · 10802e28
      pkasting@chromium.org authored
      bitmaps.
      https://bugs.webkit.org/show_bug.cgi?id=46437
      
      Reviewed by James Robinson.
      
      * manual-tests/large-size-image-crash.html: Added.
      * manual-tests/resources/large-size-image-crash.gif: Added.
      * platform/image-decoders/ImageDecoder.cpp:
      (WebCore::RGBA32Buffer::copyBitmapData):
      * platform/image-decoders/ImageDecoder.h:
      * platform/image-decoders/gif/GIFImageDecoder.cpp:
      (WebCore::GIFImageDecoder::initFrameBuffer):
      * platform/image-decoders/qt/RGBA32BufferQt.cpp:
      (WebCore::RGBA32Buffer::copyBitmapData):
      * platform/image-decoders/skia/ImageDecoderSkia.cpp:
      (WebCore::RGBA32Buffer::copyBitmapData):
      
      LayoutTests: This resource should have been in r62399; without it the test no-ops.
      https://bugs.webkit.org/show_bug.cgi?id=41487
      
      Reviewed by James Robinson.
      
      * fast/images/resources/large-size-image-crash.jpeg: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10802e28
    • andersca@apple.com's avatar
      Add WebProcessConnection CreatePlugin message · 3633661a
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=46668
      
      Reviewed by Adam Roben.
      
      * DerivedSources.make:
      Add WebProcessConnection.
      
      * Platform/CoreIPC/HandleMessage.h:
      Add handleMessage overload for a sync message with two input parameters
      and one output parameter.
      
      (CoreIPC::handleMessage):
      * Platform/CoreIPC/MessageID.h:
      Add MessageClassWebProcessConnection.
      
      * PluginProcess/WebProcessConnection.cpp:
      (WebKit::WebProcessConnection::createPlugin):
      Add stub.
      
      * PluginProcess/WebProcessConnection.messages.in: Added.
      * Scripts/webkit2/messages.py:
      Include headers directly for types that we believe are nested structs.
      
      * Scripts/webkit2/messages_unittest.py:
      Update expected results.
      
      * WebKit2.xcodeproj/project.pbxproj:
      Add new files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3633661a
    • jamesr@google.com's avatar
      2010-09-27 James Robinson <jamesr@chromium.org> · 5863c84d
      jamesr@google.com authored
              Reviewed by Simon Fraser.
      
              Repaint test for dynamically changing an SVG element's style attribute
              https://bugs.webkit.org/show_bug.cgi?id=46499
      
              * fast/repaint/repaint-svg-after-style-change-expected.checksum: Added.
              * fast/repaint/repaint-svg-after-style-change-expected.png: Added.
              * fast/repaint/repaint-svg-after-style-change-expected.txt: Added.
              * fast/repaint/repaint-svg-after-style-change.html: Added.
      2010-09-27  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Revert r63307, it broke repainting dynamically changed SVG content
              https://bugs.webkit.org/show_bug.cgi?id=46499
      
              This patch reverts r63307 and adds a regression test for what broke.
      
              Test: fast/repaint/repaint-svg-after-style-change.html
      
              * rendering/RenderForeignObject.cpp:
              (WebCore::RenderForeignObject::layout):
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::layout):
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::layout):
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::layout):
              * rendering/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::layout):
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::layout):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5863c84d
    • mrobinson@webkit.org's avatar
      2010-09-27 Martin Robinson <mrobinson@igalia.com> · b5960def
      mrobinson@webkit.org authored
              Unskip a test that just needed a platform-specific baseline and add a baseline for it.
      
              * platform/gtk/Skipped: Unskip test with new baseline.
              * platform/gtk/editing/selection/extend-selection-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5960def
    • vangelis@chromium.org's avatar
      2010-09-27 Vangelis Kokkevis <vangelis@chromium.org> · 3c78c631
      vangelis@chromium.org authored
              Reviewed by James Robinson.
      
              [chromium] WebViewImpl now holds a ref counted pointer to the LayerRendererChromium
              to ensure that the compositor does not get destroyed before the layers used
              by it do. This was done to ensure that layers properly clean up their texture
              resources on destruction.
              https://bugs.webkit.org/show_bug.cgi?id=46139
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
              * src/WebViewImpl.h:
      2010-09-27  Vangelis Kokkevis  <vangelis@chromium.org>
      
              Reviewed by James Robinson.
      
              [chromium] Making LayerChromium's destructor virtual so that the appropriate
              derived class destructors get called when the layer tree is taken down.
              ContentLayerChromium and its derived types (ImageLayerChromium for now) will
              free up the texture allocated for their contents upon destruction. To avoid
              having the LayerRendererChromium destructor getting called before the layers
              are destroyed and thus leaving their textures orphaned, the layers now hold
              a ref counted pointer to the renderer that uses them.
              https://bugs.webkit.org/show_bug.cgi?id=46139
      
              * platform/graphics/chromium/ContentLayerChromium.cpp:
              (WebCore::ContentLayerChromium::~ContentLayerChromium):
              (WebCore::ContentLayerChromium::setLayerRenderer):
              (WebCore::ContentLayerChromium::cleanupResources):
              * platform/graphics/chromium/ContentLayerChromium.h:
              * platform/graphics/chromium/LayerChromium.cpp:
              (WebCore::LayerChromium::setLayerRenderer):
              * platform/graphics/chromium/LayerChromium.h:
              (WebCore::LayerChromium::layerRenderer):
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::create):
              (WebCore::LayerRendererChromium::deleteLayerTexture):
              (WebCore::LayerRendererChromium::cleanupSharedObjects):
              * platform/graphics/chromium/LayerRendererChromium.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c78c631
    • commit-queue@webkit.org's avatar
      2010-09-27 Alexey Marinichev <amarinichev@chromium.org> · 3186f638
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Test that scrolls a checkerboard pattern.  If the hardware compositor
              miscalculates texture coordinates, corruption is very likely to occur.
      
              * compositing/checkerboard.html: Added.
              * compositing/checkerboard-expected.checksum: Added.
              * compositing/checkerboard-expected.png: Added.
              * compositing/checkerboard-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3186f638
    • arv@chromium.org's avatar
      2010-09-27 Erik Arvidsson <arv@chromium.org> · e4f1cb58
      arv@chromium.org authored
              Reviewed by Darin Adler.
      
              Implement HTML 5's HTMLElement.classList property
              https://bugs.webkit.org/show_bug.cgi?id=20709
      
              * fast/dom/HTMLElement/class-list-expected.txt: Added.
              * fast/dom/HTMLElement/class-list-gc-expected.txt: Added.
              * fast/dom/HTMLElement/class-list-gc.html: Added.
              * fast/dom/HTMLElement/class-list-quirks-expected.txt: Added.
              * fast/dom/HTMLElement/class-list-quirks.html: Added.
              * fast/dom/HTMLElement/class-list.html: Added.
              * fast/dom/HTMLElement/script-tests/class-list-gc.js: Added.
              (gc):
              * fast/dom/HTMLElement/script-tests/class-list.js: Added.
              (createElement):
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/Window/window-property-descriptors-expected.txt:
              * fast/dom/prototype-inheritance-2-expected.txt:
              * fast/dom/prototype-inheritance-expected.txt:
              * fast/js/global-constructors-expected.txt:
              * perf/class-list-remove-expected.txt: Added.
              * perf/class-list-remove.html: Added.
      2010-09-27  Erik Arvidsson  <arv@chromium.org>
      
              Reviewed by Darin Adler.
      
              Implement HTML 5's HTMLElement.classList property
              https://bugs.webkit.org/show_bug.cgi?id=20709
      
              This adds a DOMTokenList class that is used for the classList property. DOMTokenList uses a SpaceSplitString for fast
              contains check. In standards mode the existing classNames is used but in quirks mode we use an internal SpaceSplitString
              because classList is always case sensitive.
      
              Tests: fast/dom/HTMLElement/class-list-gc.html
                     fast/dom/HTMLElement/class-list-quirks.html
                     fast/dom/HTMLElement/class-list.html
                     perf/class-list-remove.html
      
              * Android.derived.jscbindings.mk:
              * Android.derived.v8bindings.mk:
              * Android.jscbindings.mk:
              * CMakeLists.txt:
              * DerivedSources.cpp:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pri:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/gobject/GNUmakefile.am:
              * bindings/js/JSElementCustom.cpp:
              (WebCore::JSElement::markChildren): Make sure that we keep the wrapper while the element is alive.
              * bindings/scripts/CodeGeneratorJS.pm: DOMTokenList has a string indexed getter.
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/custom/V8DOMTokenListCustom.cpp: Added.
              (WebCore::toV8):
              * dom/Element.cpp:
              (WebCore::Element::classList):
              (WebCore::Element::optionalClassList):
              * dom/Element.h:
              * dom/ElementRareData.h: This now has an OwnPtr to a ClassList if the Element::classList is ever called.
              * dom/SpaceSplitString.h:
              (WebCore::SpaceSplitString::isNull):
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::classAttributeChanged): Update the classList if it exists.
              * dom/StyledElement.h:
              * html/DOMTokenList.cpp: Added.
              (WebCore::validateToken):
              (WebCore::DOMTokenList::DOMTokenList):
              (WebCore::DOMTokenList::ref):
              (WebCore::DOMTokenList::deref):
              (WebCore::DOMTokenList::length):
              (WebCore::DOMTokenList::item):
              (WebCore::DOMTokenList::contains):
              (WebCore::DOMTokenList::containsInternal): The internal methods do no validation of the token.
              (WebCore::DOMTokenList::add):
              (WebCore::DOMTokenList::addInternal):
              (WebCore::DOMTokenList::remove):
              (WebCore::DOMTokenList::removeInternal):
              (WebCore::DOMTokenList::toggle):
              (WebCore::DOMTokenList::toString):
              (WebCore::DOMTokenList::reset):
              (WebCore::DOMTokenList::classNames):
              * html/DOMTokenList.h: Added.
              (WebCore::DOMTokenList::create):
              (WebCore::DOMTokenList::element):
              * html/DOMTokenList.idl: Added.
              * html/HTMLElement.idl:
              * page/DOMWindow.cpp:
              * page/DOMWindow.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4f1cb58
    • kbr@google.com's avatar
      2010-09-27 Kenneth Russell <kbr@google.com> · 786785b0
      kbr@google.com authored
              Reviewed by James Robinson.
      
              Add local triangulation of cubic curve control points
              https://bugs.webkit.org/show_bug.cgi?id=45252
      
              (Re-landing; I neglected to actually add the new files in
              http://trac.webkit.org/changeset/68045 .)
      
              Adding a localized triangulation algorithm which takes as input
              the four control points of a cubic curve segment and provides both
              triangles as well as the ability to walk the interior edges. The
              latter will be used later to fill the interior of shapes bounded
              by these cubic curves, quadratic curves and line segments.
      
              * platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp: Added.
              (WebCore::LoopBlinnLocalTriangulator::Triangle::contains):
              (WebCore::LoopBlinnLocalTriangulator::Triangle::nextVertex):
              (WebCore::LoopBlinnLocalTriangulator::Triangle::indexForVertex):
              (WebCore::LoopBlinnLocalTriangulator::Triangle::makeCounterClockwise):
              (WebCore::LoopBlinnLocalTriangulator::LoopBlinnLocalTriangulator):
              (WebCore::LoopBlinnLocalTriangulator::reset):
              (WebCore::LoopBlinnLocalTriangulator::triangulate):
              (WebCore::LoopBlinnLocalTriangulator::triangulateHelper):
              (WebCore::LoopBlinnLocalTriangulator::addTriangle):
              (WebCore::LoopBlinnLocalTriangulator::addInteriorVertex):
              (WebCore::LoopBlinnLocalTriangulator::isSharedEdge):
              * platform/graphics/gpu/LoopBlinnLocalTriangulator.h: Added.
              (WebCore::LoopBlinnLocalTriangulator::Vertex::Vertex):
              (WebCore::LoopBlinnLocalTriangulator::Vertex::xyCoordinates):
              (WebCore::LoopBlinnLocalTriangulator::Vertex::klmCoordinates):
              (WebCore::LoopBlinnLocalTriangulator::Vertex::set):
              (WebCore::LoopBlinnLocalTriangulator::Vertex::end):
              (WebCore::LoopBlinnLocalTriangulator::Vertex::setEnd):
              (WebCore::LoopBlinnLocalTriangulator::Vertex::marked):
              (WebCore::LoopBlinnLocalTriangulator::Vertex::setMarked):
              (WebCore::LoopBlinnLocalTriangulator::Vertex::interior):
              (WebCore::LoopBlinnLocalTriangulator::Vertex::setInterior):
              (WebCore::LoopBlinnLocalTriangulator::Vertex::resetFlags):
              (WebCore::LoopBlinnLocalTriangulator::Triangle::Triangle):
              (WebCore::LoopBlinnLocalTriangulator::Triangle::getVertex):
              (WebCore::LoopBlinnLocalTriangulator::Triangle::setVertices):
              (WebCore::LoopBlinnLocalTriangulator::getVertex):
              (WebCore::LoopBlinnLocalTriangulator::numberOfTriangles):
              (WebCore::LoopBlinnLocalTriangulator::getTriangle):
              (WebCore::LoopBlinnLocalTriangulator::numberOfInteriorVertices):
              (WebCore::LoopBlinnLocalTriangulator::getInteriorVertex):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      786785b0
    • crogers@google.com's avatar
      2010-09-27 Chris Rogers <crogers@google.com> · b73519d4
      crogers@google.com authored
              Reviewed by Kenneth Russell.
      
              Add AudioNode files
              https://bugs.webkit.org/show_bug.cgi?id=45571
      
              No new tests since audio API is not yet implemented.
      
              * webaudio/AudioNode.cpp: Added.
              (WebCore::AudioNode::AudioNode):
              (WebCore::AudioNode::~AudioNode):
              (WebCore::AudioNode::setType):
              (WebCore::AudioNode::lazyInitialize):
              (WebCore::AudioNode::addInput):
              (WebCore::AudioNode::addOutput):
              (WebCore::AudioNode::input):
              (WebCore::AudioNode::output):
              (WebCore::AudioNode::connect):
              (WebCore::AudioNode::disconnect):
              (WebCore::AudioNode::processIfNecessary):
              (WebCore::AudioNode::pullInputs):
              (WebCore::AudioNode::ref):
              (WebCore::AudioNode::deref):
              (WebCore::AudioNode::finishDeref):
              (WebCore::AudioNode::printNodeCounts):
              * webaudio/AudioNode.h: Added.
              (WebCore::AudioNode::context):
              (WebCore::AudioNode::type):
              (WebCore::AudioNode::isInitialized):
              (WebCore::AudioNode::numberOfInputs):
              (WebCore::AudioNode::numberOfOutputs):
              (WebCore::AudioNode::sampleRate):
              (WebCore::AudioNode::checkNumberOfChannelsForInput):
              * webaudio/AudioNode.idl: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b73519d4
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=46665 · 7c593709
      hyatt@apple.com authored
      Reviewed by Sam Weinig.
      
      Patch RenderView's layout and computeLogicalWidth/Height methods to be block-flow-aware.
      
      Added fast/root-lr-basic.html
      
      WebCore: 
      
      * rendering/RenderView.cpp:
      (WebCore::RenderView::computeLogicalHeight):
      (WebCore::RenderView::computeLogicalWidth):
      (WebCore::RenderView::layout):
      * rendering/RenderView.h:
      (WebCore::RenderView::viewLogicalWidth):
      (WebCore::RenderView::viewLogicalHeight):
      
      LayoutTests: 
      
      * fast/blockflow/root-lr-basic.html: Added.
      * platform/mac/fast/blockflow: Added.
      * platform/mac/fast/blockflow/root-lr-basic-expected.checksum: Added.
      * platform/mac/fast/blockflow/root-lr-basic-expected.png: Added.
      * platform/mac/fast/blockflow/root-lr-basic-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c593709
    • weinig@apple.com's avatar
      Add remaining event handlers to WKView. · f7ab856a
      weinig@apple.com authored
      Reviewed by Anders Carlsson.
      
      Also fixes <rdar://problem/8467058>
      Does not get decidePolicyForNavigationAction callback when middle clicking a link
      
      - Adds otherButton and rightButton NSResponder event handlers to WKView.
      - Renames WebPageProxy event handlers to use the handle prefix.
      - Uses a macro to reduce duplicate code for WKView event handlers.
      - Add view parameter to WebEventFactory::createWebKeyboardEvent on the mac
        for uniformity.
      
      * Shared/mac/WebEventFactory.h:
      * Shared/mac/WebEventFactory.mm:
      (WebKit::WebEventFactory::createWebKeyboardEvent):
      * UIProcess/API/mac/WKView.mm:
      * UIProcess/API/qt/qwkpage.cpp:
      (QWKPagePrivate::keyPressEvent):
      (QWKPagePrivate::keyReleaseEvent):
      (QWKPagePrivate::mouseMoveEvent):
      (QWKPagePrivate::mousePressEvent):
      (QWKPagePrivate::mouseReleaseEvent):
      (QWKPagePrivate::mouseDoubleClickEvent):
      (QWKPagePrivate::wheelEvent):
      (QWKPagePrivate::touchEvent):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::handleMouseEvent):
      (WebKit::WebPageProxy::handleWheelEvent):
      (WebKit::WebPageProxy::handleKeyboardEvent):
      (WebKit::WebPageProxy::handleTouchEvent):
      * UIProcess/WebPageProxy.h:
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::onMouseEvent):
      (WebKit::WebView::onWheelEvent):
      (WebKit::WebView::onKeyEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7ab856a
    • zmo@google.com's avatar
      2010-09-24 Zhenyao Mo <zmo@google.com> · f7700b22
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              Hook up ANGLE with chromium --in-process-webgl port
              https://bugs.webkit.org/show_bug.cgi?id=44309
      
              * WebKit.gyp: Add angle dependency.
              * src/WebGraphicsContext3DDefaultImpl.cpp: Using angle for shader validation and translation.
              (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
              (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl):
              (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
              (WebKit::WebGraphicsContext3DDefaultImpl::compileShader):
              (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): Using defined const instead.
              (WebKit::WebGraphicsContext3DDefaultImpl::getShaderiv):
              (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog):
              (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource):
              (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource):
              (WebKit::WebGraphicsContext3DDefaultImpl::createShader):
              (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader):
              (WebKit::WebGraphicsContext3DDefaultImpl::angleCreateCompilers):
              (WebKit::WebGraphicsContext3DDefaultImpl::angleDestroyCompilers):
              (WebKit::WebGraphicsContext3DDefaultImpl::angleValidateShaderSource):
              * src/WebGraphicsContext3DDefaultImpl.h: Add necessary data and functions for angle stuff.
              (WebKit::WebGraphicsContext3DDefaultImpl::ShaderSourceEntry::ShaderSourceEntry):
              (WebKit::WebGraphicsContext3DDefaultImpl::ShaderSourceEntry::~ShaderSourceEntry):
      2010-09-24  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              Hook up ANGLE with chromium --in-process-webgl port
              https://bugs.webkit.org/show_bug.cgi?id=44309
      
              * platform/graphics/GraphicsContext3D.h: Move Angle stuff inside MAC only section.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7700b22
    • mihaip@chromium.org's avatar
      2010-09-27 Mihai Parparita <mihaip@chromium.org> · 41ead96a
      mihaip@chromium.org authored
              Reviewed by Eric Seidel.
      
              webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
              https://bugs.webkit.org/show_bug.cgi?id=46634
      
              Use OutputCapture to prevent console spam (and also check for expected
              output).
      
              * Scripts/webkitpy/common/system/user_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41ead96a
    • zmo@google.com's avatar
      2010-09-27 Zhenyao Mo <zmo@google.com> · 950d3b36
      zmo@google.com authored
              Unreviewed, add fast/canvas/webgl/object-deletion-behaviour.html to test_expectations.txt (failing on Win/Linux).
      
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      950d3b36
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=46659 · 3796edf7
      hyatt@apple.com authored
      Reviewed by Sam Weinig.
      
      Patch the width/height/x/y calls in layoutBlock() to be their logical equivalents instead.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::layoutBlock):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3796edf7
    • mrowe@apple.com's avatar
      <rdar://problem/8348990> / <http://webkit.org/b/46633> Make it possible to disable sandboxing of · e1a5ce68
      mrowe@apple.com authored
      web process via runtime flag.
      
      Patch by Ivan Krstić <ike@apple.com> on 2010-09-27
      Reviewed by Mark Rowe.
      
      Enable sandboxing of the web process only if the DisableSandbox user default is not set for the
      web process.
      
      * WebProcess/mac/WebProcessMainMac.mm:
      (WebKit::WebProcessMain):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1a5ce68
    • andersca@apple.com's avatar
      Add support for autogenerating synchronous message handlers · 2be95fe9
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=46654
      
      Reviewed by Adam Roben.
      
      * Scripts/webkit2/messages.py:
      (reply_type): Renamed from reply_base_class.
      (delayed_reply_type): Renamed from delayed_reply_base_class.
      (message_to_struct_declaration): Add a Reply type typedef.
      (async_case_statement): Rename from case_statement.
      (generate_message_handler): Generate a sync message handler as well.
      
      * Scripts/webkit2/messages_unittest.py:
      Update expected results.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2be95fe9
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=46649, fix failing layout tests. · 5fe64f05
      hyatt@apple.com authored
      Reviewed by Sam Weinig.
      
      The implementation of setting the before/after margins was wrong and poking the wrong margin values.
              
      Once I made them set the correct values, it revealed that one of the new block flow tests wasn't
      actually working.  In order to fix it, I had to make the block direction margin computation actually
      use the containing block's block-flow in order to return the right answer.  This involved cleaning
      up computeBlockDirectionMargins to be more like computeInlineDirectionMargins.
              
      fast/css/logical-property-resolution.html also caught the bug.  Its results are now correct.
      
      WebCore: 
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::adjustPositionedBlock):
      (WebCore::RenderBlock::determineHorizontalPosition):
      (WebCore::RenderBlock::layoutBlockChild):
      (WebCore::RenderBlock::insertFloatingObject):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::setMarginBeforeUsing):
      (WebCore::RenderBox::setMarginAfterUsing):
      (WebCore::RenderBox::computeLogicalWidth):
      (WebCore::RenderBox::computeInlineDirectionMargins):
      (WebCore::RenderBox::computeLogicalHeight):
      (WebCore::RenderBox::computeBlockDirectionMargins):
      * rendering/RenderBox.h:
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::layoutHorizontalBox):
      (WebCore::RenderFlexibleBox::layoutVerticalBox):
      * rendering/RenderObject.h:
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::computeLogicalWidth):
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::layout):
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::marginBeforeUsing):
      (WebCore::RenderStyle::marginAfterUsing):
      * rendering/style/RenderStyle.h:
      
      LayoutTests: 
      
      * fast/css/logical-property-resolution-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fe64f05