1. 14 Feb, 2013 40 commits
    • tony@chromium.org's avatar
      Unreviewed, set svn:eol-style CRLF for .sln files. · 01bc5fd2
      tony@chromium.org authored
      Source/JavaScriptCore: 
      
      * JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
      * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property svn:eol-style.
      
      Source/ThirdParty: 
      
      * gtest/msvc/gtest-md.sln: Added property svn:eol-style.
      * gtest/msvc/gtest.sln: Added property svn:eol-style.
      
      Source/WebCore: 
      
      * WebCore.vcproj/WebCore.sln: Modified property svn:eol-style.
      * WebCore.vcproj/WebCore.submit.sln: Modified property svn:eol-style.
      
      Source/WebKit: 
      
      * WebKit.vcxproj/WebKit.sln: Modified property svn:eol-style.
      
      Source/WebKit/win: 
      
      * WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
      * WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.
      
      Source/WTF: 
      
      * WTF.vcproj/WTF.sln: Added property svn:eol-style.
      
      Tools: 
      
      * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
      * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
      * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
      * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01bc5fd2
    • aelias@chromium.org's avatar
      [chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try · 016d4d4f
      aelias@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109671
      
      Reviewed by James Robinson.
      
      My patch 142571 broke a bunch of things in handleGestureEvent that
      assumed the event came in scaled, most notably tap highlight and
      double-tap zoom. Switch those to PlatformGestureEvent.
      
      142808 was an earlier version of this patch that was reverted
      due to fling events asserting they can't be converted to
      PlatformGestureEvent. This version moves fling earlier in the
      function to avoid that.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::handleGestureEvent):
      (WebKit::WebViewImpl::bestTapNode):
      (WebKit::WebViewImpl::enableTapHighlight):
      * src/WebViewImpl.h:
      (WebViewImpl):
      * tests/LinkHighlightTest.cpp:
      (WebCore::TEST):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      016d4d4f
    • dpranke@chromium.org's avatar
      Unreviewed, rolling out r142901. · 5c0aa8e3
      dpranke@chromium.org authored
      http://trac.webkit.org/changeset/142901
      
      r182258 introduces a dependency on chrome.gyp that breaks the win
      build. Rolling back to r182150 until I can work up a workaround.
      
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c0aa8e3
    • eric.carlson@apple.com's avatar
      [Mac] adjust caption color user preference calculation · 73b9cb52
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109840
      
      Reviewed by Dean Jackson.
      
      No new tests, it isn't possible to test this with DRT.
      
      * page/CaptionUserPreferencesMac.mm:
      (WebCore::CaptionUserPreferencesMac::captionsWindowCSS): The color is "important" if either the
          color or opacity are supposed to override.
      (WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Ditto.
      (WebCore::CaptionUserPreferencesMac::captionsTextColor): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73b9cb52
    • commit-queue@webkit.org's avatar
      Numeric identifiers of events are not guaranteed to be unique · 9e648e75
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103259
      
      Patch by Cosmin Truta <ctruta@rim.com> on 2013-02-14
      Reviewed by Alexey Proskuryakov.
      
      The results of setTimeout, setInterval and navigator.geolocation.watchPosition
      are positive integer values extracted from a simple circular sequential number
      generator, whose uniqueness can be guaranteed for no more than 2^31 calls to
      any of these functions. In order to provide this guarantee beyond this limit,
      we repeatedly ask for the next sequential id until we get one that's not used
      already.
      
      This solution works instantly under normal circumstances, when there are few
      live timeout ids or geolocation ids at any given moment. Handling millions of
      live ids will require another solution.
      
      No new tests. Brief tests of uniqueness already exist.
      Moreover, reproducing this particular issue would require 2^31 set/clear
      function calls, which is prohibitively expensive.
      
      * Modules/geolocation/Geolocation.cpp:
      (WebCore::Geolocation::Watchers::add): Rename from Watchers::set; return false if watch id already exists.
      (WebCore::Geolocation::watchPosition): Repeat until the new watch id is unique.
      * Modules/geolocation/Geolocation.h:
      (Watchers): Rename Watchers::set to Watchers::add.
      * Modules/geolocation/Geolocation.idl: Rename the argument of Geolocation::clearWatch to WatchID.
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::ScriptExecutionContext): Update initialization.
      (WebCore::ScriptExecutionContext::circularSequentialID): Rename from newUniqueID; remove FIXME note.
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext): Rename ScriptExecutionContext::newUniqueID to ScriptExecutionContext::circularSequentialID.
      (WebCore::ScriptExecutionContext::addTimeout): Return false (do not assert) if timeout id already exists.
      * page/DOMTimer.cpp:
      (WebCore::DOMTimer::DOMTimer): Repeat until the new timeout id is unique.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e648e75
    • zandobersek@gmail.com's avatar
      [GTK] Errors when building WebKit2 with Clang · f16cfde5
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109603
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebKit2: 
      
      * UIProcess/API/gtk/WebKitUIClient.cpp:
      (setWindowFrame): Cast the position parameters to the integer type when constructing the GdkRectangle.
      * UIProcess/Authentication/WebCredential.cpp: Add an empty implementation of the newly specified destructor.
      * UIProcess/Authentication/WebCredential.h: Work around the incomplete WebCertificateInfo type errors thrown in the inline
      RefPtr destructor of the m_certificateInfo class member by defining a destructor in the class.
      * WebProcess/WebCoreSupport/WebEditorClient.h: The GTK-specific methods are not virtual and as such cannot be overriden.
      The OVERRIDE keywords are thus unnecessary.
      
      Tools: 
      
      * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
      (WTR::PlatformWebView::resizeTo): Cast the width and height parameters to the integer
      type when constructing the GtkAllocation.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f16cfde5
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r142825. · 42f2b060
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/142825
      https://bugs.webkit.org/show_bug.cgi?id=109856
      
      Causes some inspector tests to time out (Requested by anttik
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14
      
      * platform/mac/SharedTimerMac.mm:
      (WebCore):
      (WebCore::PowerObserver::restartSharedTimer):
      (WebCore::setSharedTimerFireInterval):
      (WebCore::stopSharedTimer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42f2b060
    • commit-queue@webkit.org's avatar
      Support the ch unit from css3-values · 24185cd0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85755
      
      Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-02-14
      Reviewed by David Hyatt.
      
      Original patch by Sumedha Widyadharma <sumedha.widyadharma@basyskom.com>.
      
      Source/WebCore:
      
      Test: fast/css/css3-ch-unit.html
      
      * css/CSSCalculationValue.cpp:
      (WebCore::unitCategory):
      * css/CSSGrammar.y.in:
      * css/CSSParser.cpp:
      (WebCore::CSSParser::validUnit):
      (WebCore::CSSParser::createPrimitiveNumericValue):
      (WebCore::CSSParser::parseValidPrimitive):
      (WebCore::CSSParser::detectNumberToken):
      * css/CSSParserValues.cpp:
      (WebCore::CSSParserValue::createCSSValue):
      * css/CSSPrimitiveValue.cpp:
      (WebCore::isValidCSSUnitTypeForDoubleConversion):
      (WebCore::CSSPrimitiveValue::cleanup):
      (WebCore::CSSPrimitiveValue::computeLengthDouble):
      (WebCore::CSSPrimitiveValue::customCssText):
      (WebCore::CSSPrimitiveValue::cloneForCSSOM):
      * css/CSSPrimitiveValue.h:
      (WebCore::CSSPrimitiveValue::isFontRelativeLength):
      (WebCore::CSSPrimitiveValue::isLength):
      * platform/graphics/FontMetrics.h:
      (WebCore::FontMetrics::FontMetrics):
      (WebCore::FontMetrics::zeroWidth):
      (WebCore::FontMetrics::setZeroWidth):
      (FontMetrics):
      (WebCore::FontMetrics::hasZeroWidth):
      (WebCore::FontMetrics::setHasZeroWidth):
      * platform/graphics/SimpleFontData.cpp:
      (WebCore::SimpleFontData::platformGlyphInit):
      * platform/graphics/SimpleFontData.h:
      (WebCore::SimpleFontData::zeroGlyph):
      (WebCore::SimpleFontData::setZeroGlyph):
      (SimpleFontData):
      * platform/graphics/qt/SimpleFontDataQt.cpp:
      (WebCore::SimpleFontData::platformInit):
      
      LayoutTests:
      
      * fast/css/css3-ch-unit-expected.txt: Added.
      * fast/css/css3-ch-unit.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24185cd0
    • ddkilzer@apple.com's avatar
      [Mac] Clean up WARNING_CFLAGS · f8d0ba4d
      ddkilzer@apple.com authored
      <http://webkit.org/b/109747>
      <rdar://problem/13208373>
      
      Reviewed by Mark Rowe.
      
      Source/JavaScriptCore:
      
      * Configurations/Base.xcconfig: Use
      GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
      -Wshorten-64-to-32 rather than WARNING_CFLAGS.
      
      Source/WebCore:
      
      * Configurations/Base.xcconfig: Use
      GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
      -Wshorten-64-to-32 rather than WARNING_CFLAGS.
      
      Source/WebKit/mac:
      
      * Configurations/Base.xcconfig: Use
      GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
      -Wshorten-64-to-32 rather than WARNING_CFLAGS.
      
      Source/WebKit2:
      
      * Configurations/Base.xcconfig: Use
      GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
      -Wshorten-64-to-32 rather than WARNING_CFLAGS.
      
      Source/WTF:
      
      * Configurations/Base.xcconfig: Use
      GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
      -Wshorten-64-to-32 rather than WARNING_CFLAGS.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8d0ba4d
    • ch.dumez@sisa.samsung.com's avatar
      Add addHTTPHeaderField() method to ResourceResponse · 2400450a
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109844
      
      Reviewed by Adam Barth.
      
      ResourceRequestBase provides both setHTTPHeaderField() and addHTTPHeaderField(). However,
      ResourceResponseBase only provides setHTTPHeaderField(). This is a bit inconsistent. As a
      result, the addHTTPHeaderField() functionality's implementation is duplicated in several
      ports (at least chromium and soup).
      
      This patch introduces addHTTPHeaderField() to ResourceResponseBase and makes use of it
      in Chromium and Soup backends.
      
      No new tests, no behavior change.
      
      * platform/chromium/support/WebURLResponse.cpp:
      (WebKit::WebURLResponse::addHTTPHeaderField): Use ResourceResponseBase::addHTTPHeaderField().
      * platform/network/ResourceResponseBase.cpp:
      (WebCore::ResourceResponseBase::updateHeaderParsedState): Move headers' parsed state update code
      from setHTTPHeaderField() to a new updateHeaderParsedState() method to avoid code duplication.
      (WebCore):
      (WebCore::ResourceResponseBase::setHTTPHeaderField):
      (WebCore::ResourceResponseBase::addHTTPHeaderField):
      * platform/network/ResourceResponseBase.h:
      (ResourceResponseBase):
      * platform/network/soup/ResourceResponseSoup.cpp:
      (WebCore::ResourceResponse::updateFromSoupMessageHeaders): Use ResourceResponseBase::addHTTPHeaderField().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2400450a
    • dpranke@chromium.org's avatar
      Unreviewed, chromium roll 182150 -> 182448 · 8d785628
      dpranke@chromium.org authored
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d785628
    • weinig@apple.com's avatar
      Add conversions between ObjC and C DOM wrappers · 7ace5457
      weinig@apple.com authored
      <rdar://problem/13205468>
      https://bugs.webkit.org/show_bug.cgi?id=109851
      
      Reviewed by Anders Carlsson.
      
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:
      (WKBundleRangeHandleCreate):
      * WebProcess/InjectedBundle/API/c/WKBundleRangeHandlePrivate.h: Added.
      * WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
      (-[WKDOMNode _copyBundleNodeHandleRef]):
      * WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h: Added.
      * WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:
      (-[WKDOMRange _copyBundleRangeHandleRef]):
      * WebProcess/InjectedBundle/API/mac/WKDOMRangePrivate.h: Added.
      * WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
      (WebKit::InjectedBundleRangeHandle::getOrCreate):
      * WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
      (InjectedBundleRangeHandle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ace5457
    • pdr@google.com's avatar
      Prevent inconsistent firstChild during document destruction · a5f0b5a9
      pdr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106530
      
      Reviewed by Abhishek Arya.
      
      Source/WebCore:
      
      During document destruction, addChildNodesToDeletionQueue can allow a container
      node to have an invalid first child, causing a crash. This patch updates
      addChildNodesToDeletionQueue to maintain a valid value for firstChild() even
      while updating its children.
      
      Test: svg/custom/animateMotion-path-change-crash.svg
      
      * dom/ContainerNodeAlgorithms.h:
      (WebCore::Private::addChildNodesToDeletionQueue):
          To ensure prevoiusSibling() is also valid, this code was slightly refactored
          to call setPreviousSibling(0) on the next node instead of the current node.
      
      LayoutTests:
      
      * svg/custom/animateMotion-path-change-crash-expected.txt: Added.
      * svg/custom/animateMotion-path-change-crash.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5f0b5a9
    • jchaffraix@webkit.org's avatar
      [CSS Grid Layout] Add an internal 2D grid representation to RenderGrid · 2cfde574
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109714
      
      Reviewed by Ojan Vafai.
      
      This change introduces a 2D grid representation of the grid areas. Our implementation
      is a straight Vector of Vectors for the grid areas, each grid area able to hold an
      arbitrary number of RenderBox* so they hold a Vector of RenderBoxes. As an optimization,
      each grid area has enough inline storage to hold one grid item which should cover
      most cases.
      
      In order to keep the code readable, a GridIterator was introduced to hide the new grid.
      
      Refactoring, covered by existing tests.
      
      * rendering/RenderGrid.cpp:
      (RenderGrid::GridIterator):
      (WebCore::RenderGrid::GridIterator::GridIterator):
      (WebCore::RenderGrid::GridIterator::nextGridItem):
      Added a mono-directional iterator. In order to be more aligned with the rest of the code,
      this iterator actually walks orthogonally to the |direction| (ie fixing the |direction|'s track).
      
      * rendering/RenderGrid.cpp:
      (WebCore::RenderGrid::computePreferredLogicalWidths):
      (WebCore::RenderGrid::layoutGridItems):
      Updated these 2 functions to place the items on the grid and clear it at the end.
      
      (WebCore::RenderGrid::computePreferredTrackWidth):
      (WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
      Updated to use the GridIterator to walk over the rows / columns.
      
      (WebCore::RenderGrid::placeItemsOnGrid):
      Added this function that inserts the grid items into the right grid area.
      
      * rendering/RenderGrid.h:
      (WebCore::RenderGrid::gridColumnCount):
      (WebCore::RenderGrid::gridRowCount):
      Added these helper functions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cfde574
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r141990. · 824be1aa
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/141990
      https://bugs.webkit.org/show_bug.cgi?id=109850
      
      ~5% regression on intl2 page cycler (Requested by kling on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14
      
      * platform/graphics/GlyphPage.h:
      (WebCore::GlyphPage::create):
      (WebCore::GlyphPage::glyphDataForCharacter):
      (WebCore::GlyphPage::glyphDataForIndex):
      (WebCore::GlyphPage::fontDataForCharacter):
      (WebCore::GlyphPage::setGlyphDataForIndex):
      (GlyphPage):
      (WebCore::GlyphPage::copyFrom):
      (WebCore::GlyphPage::clear):
      (WebCore::GlyphPage::clearForFontData):
      (WebCore::GlyphPage::GlyphPage):
      * platform/graphics/GlyphPageTreeNode.cpp:
      (WebCore::GlyphPageTreeNode::initializePage):
      * rendering/svg/SVGTextRunRenderingContext.cpp:
      (WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      824be1aa
    • pilgrim@chromium.org's avatar
      [Chromium] Move PlatformMessagePortChannel to WebCore · 9adbd4be
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109845
      
      Reviewed by Adam Barth.
      
      Part of a larger refactoring series; see tracking bug 106829.
      
      Source/WebCore:
      
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      * dom/default/chromium: Added.
      * dom/default/chromium/PlatformMessagePortChannelChromium.cpp: Added.
      (WebCore):
      (WebCore::MessagePortChannel::create):
      (WebCore::MessagePortChannel::createChannel):
      (WebCore::MessagePortChannel::MessagePortChannel):
      (WebCore::MessagePortChannel::~MessagePortChannel):
      (WebCore::MessagePortChannel::entangleIfOpen):
      (WebCore::MessagePortChannel::disentangle):
      (WebCore::MessagePortChannel::postMessageToRemote):
      (WebCore::MessagePortChannel::tryGetMessageFromRemote):
      (WebCore::MessagePortChannel::close):
      (WebCore::MessagePortChannel::isConnectedTo):
      (WebCore::MessagePortChannel::hasPendingActivity):
      (WebCore::MessagePortChannel::locallyEntangledPort):
      (WebCore::PlatformMessagePortChannel::create):
      (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
      (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel):
      (WebCore::PlatformMessagePortChannel::createChannel):
      (WebCore::PlatformMessagePortChannel::messageAvailable):
      (WebCore::PlatformMessagePortChannel::entangleIfOpen):
      (WebCore::PlatformMessagePortChannel::disentangle):
      (WebCore::PlatformMessagePortChannel::postMessageToRemote):
      (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
      (WebCore::PlatformMessagePortChannel::close):
      (WebCore::PlatformMessagePortChannel::isConnectedTo):
      (WebCore::PlatformMessagePortChannel::hasPendingActivity):
      (WebCore::PlatformMessagePortChannel::setEntangledChannel):
      (WebCore::PlatformMessagePortChannel::webChannelRelease):
      * dom/default/chromium/PlatformMessagePortChannelChromium.h: Added.
      (WebKit):
      (WebCore):
      (PlatformMessagePortChannel):
      
      Source/WebKit/chromium:
      
      * WebKit.gyp:
      * src/PlatformMessagePortChannel.cpp: Removed.
      * src/PlatformMessagePortChannel.h: Removed.
      * src/SharedWorkerRepository.cpp:
      * src/WebDOMMessageEvent.cpp:
      * src/WebFrameImpl.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * src/WebWorkerClientImpl.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9adbd4be
    • cfleizach@apple.com's avatar
      Remove Leopard Accessibility support from WebCore (now that no port builds on Leopard) · a59d8e4e
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=90250
      
      Reviewed by Eric Seidel.
      
      The Leopard era checks for accessibility lists and accessibility tables can be removed now.
      
      * accessibility/AccessibilityARIAGrid.cpp:
      (WebCore):
      * accessibility/AccessibilityARIAGrid.h:
      (AccessibilityARIAGrid):
      (WebCore::AccessibilityARIAGrid::isTableExposableThroughAccessibility):
      * accessibility/AccessibilityList.cpp:
      (WebCore::AccessibilityList::computeAccessibilityIsIgnored):
      * accessibility/AccessibilityList.h:
      * accessibility/AccessibilityTable.cpp:
      (WebCore::AccessibilityTable::AccessibilityTable):
      (WebCore::AccessibilityTable::init):
      * accessibility/AccessibilityTable.h:
      (AccessibilityTable):
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::postPlatformNotification):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a59d8e4e
    • eric@webkit.org's avatar
      String(Vector) behaves differently from String(vector.data(), vector.size())... · 42660c4a
      eric@webkit.org authored
      String(Vector) behaves differently from String(vector.data(), vector.size()) for vectors with inline capacity in the size=0 case
      https://bugs.webkit.org/show_bug.cgi?id=109784
      
      Reviewed by Darin Adler.
      
      This makes String(Vector) never return null strings.
      Which matches behavior of String(UChar*, size_t)
      for vectors with inlineCapacity, but differs from
      String(UChar*, size_t) in the no-inlineCapacity case.
      
      This incidentally will fix a behavioral regression
      in the html threaded parser which came from converting
      many String(UChar*, size_t) callsites to using String(Vector).
      
      * wtf/text/WTFString.h:
      (String):
      (WTF::String::String):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42660c4a
    • commit-queue@webkit.org's avatar
      Make outside-shape the default value for shape-inside · 0d7257c9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109605
      
      Patch by Bear Travis <betravis@adobe.com> on 2013-02-14
      Reviewed by Levi Weintraub.
      
      Source/WebCore:
      
      Creating a single reference outside-shape value and setting it as the default
      for shape-inside.
      
      Existing tests cover the default value, just updating them to use outside-shape.
      
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::initialShapeInside): Define a local static outside-shape
      value.
      (WebCore):
      * rendering/style/RenderStyle.h: Move the initialShapeInside method to the .cpp
      file.
      
      LayoutTests:
      
      Updating tests to account for the new default value of shape-inside.
      
      * fast/exclusions/css-exclusions-disabled-expected.txt:
      * fast/exclusions/css-exclusions-disabled.html:
      * fast/exclusions/parsing-wrap-shape-inside-expected.txt:
      * fast/exclusions/parsing-wrap-shape-lengths-expected.txt:
      * fast/exclusions/parsing-wrap-shape-lengths.html:
      * fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
      (negative_test):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d7257c9
    • roger_fong@apple.com's avatar
      Add eol-style=native to solution files. Add a new solution file. · 21893f99
      roger_fong@apple.com authored
      * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added property svn:eol-style.
      * TestWebKitAPI/TestWebKitAPI.vcxproj: Added property svn:eol-style. Modified property svn:ignore.
      * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21893f99
    • commit-queue@webkit.org's avatar
      Passing alpha to DeferredImageDecoder once decoding completes · 24acf7b1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108892
      
      Patch by Min Qin <qinmin@chromium.org> on 2013-02-14
      Reviewed by Stephen White.
      
      Source/WebCore:
      
      We should pass hasAlpha value back to the DeferredImageDecoder once decoding is completed
      Added unit tests in ImageFrameGeneratorTest.
      
      * platform/graphics/chromium/DeferredImageDecoder.cpp:
      (WebCore::DeferredImageDecoder::frameHasAlphaAtIndex):
      * platform/graphics/chromium/ImageFrameGenerator.cpp:
      (WebCore::ImageFrameGenerator::tryToScale):
      (WebCore::ImageFrameGenerator::decode):
      * platform/graphics/chromium/LazyDecodingPixelRef.cpp:
      (WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
      (WebCore::LazyDecodingPixelRef::onUnlockPixels):
      * platform/graphics/chromium/LazyDecodingPixelRef.h:
      (WebCore::LazyDecodingPixelRef::hasAlpha):
      (LazyDecodingPixelRef):
      * platform/graphics/chromium/ScaledImageFragment.cpp:
      (WebCore::ScaledImageFragment::ScaledImageFragment):
      * platform/graphics/chromium/ScaledImageFragment.h:
      (WebCore::ScaledImageFragment::create):
      (ScaledImageFragment):
      (WebCore::ScaledImageFragment::hasAlpha):
      
      Source/WebKit/chromium:
      
      Add test to check that alpha value is passed from the decoder to ImageFrameGenerator.
      
      * tests/ImageFrameGeneratorTest.cpp:
      (WebCore::MockImageDecoderFactory::create):
      (WebCore::TEST_F):
      * tests/MockImageDecoder.h:
      (WebCore::MockImageDecoder::MockImageDecoder):
      (WebCore::MockImageDecoder::setFrameHasAlpha):
      (MockImageDecoder):
      (WebCore::MockImageDecoder::frameHasAlphaAtIndex):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24acf7b1
    • dgrogan@chromium.org's avatar
      IndexedDB: Add a few more histogram calls · b951d742
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109762
      
      Reviewed by Tony Chang.
      
      A few places where commits could fail weren't being logged.
      
      * Modules/indexeddb/IDBBackingStore.cpp:
      (WebCore::IDBBackingStore::deleteDatabase):
      (WebCore::IDBBackingStore::Transaction::commit):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b951d742
    • tony@chromium.org's avatar
      Padding and border changes doesn't trigger relayout of children · 04668f1c
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109639
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      In RenderBlock::layoutBlock, we only relayout our children if our logical width
      changes. This misses cases where our logical width doesn't change (i.e., padding
      or border changes), but our content width does change.
      
      This is a more general case of bug 104997.
      
      Test: fast/block/dynamic-padding-border.html
      
      * rendering/RenderBox.cpp:
      (WebCore::borderOrPaddingLogicalWidthChanged): Only check if the logical width changed.
      (WebCore::RenderBox::styleDidChange): Drop the border-box condition since this can happen
      even without border-box box sizing.
      
      LayoutTests:
      
      * fast/block/dynamic-padding-border-expected.txt: Added.
      * fast/block/dynamic-padding-border.html: Added.
      * fast/table/border-collapsing/cached-change-row-border-width-expected.txt: We should have been relaying
      out the table when the border changed. The pixel results in this case is the same, but the
      render tree shows the difference.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04668f1c
    • commit-queue@webkit.org's avatar
      Web Inspector: fix closure compilation warnings caused by setVariableValue change · b2635efd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109488
      
      Patch by Peter Rybin <prybin@chromium.org> on 2013-02-14
      Reviewed by Pavel Feldman.
      
      Annotations are fixed as required by closure compiler.
      Parameters in Inspector.json are reordered as required.
      
      * inspector/InjectedScriptExterns.js:
      (InjectedScriptHost.prototype.setFunctionVariableValue):
      (JavaScriptCallFrame.prototype.setVariableValue):
      * inspector/InjectedScriptSource.js:
      (.):
      * inspector/Inspector.json:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::setVariableValue):
      * inspector/InspectorDebuggerAgent.h:
      (InspectorDebuggerAgent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2635efd
    • tommyw@google.com's avatar
      MediaStream API: RTCDataChannel triggers a use-after-free · b7a86401
      tommyw@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109806
      
      Reviewed by Adam Barth.
      
      Making sure RTCPeerConnection::stop() is always called at least once.
      Also making sure that RTCDataChannels state gets set to Closed correctly.
      
      Hard to test in WebKit but covered by Chromium tests.
      
      * Modules/mediastream/RTCDataChannel.cpp:
      (WebCore::RTCDataChannel::stop):
      * Modules/mediastream/RTCPeerConnection.cpp:
      (WebCore::RTCPeerConnection::~RTCPeerConnection):
      (WebCore::RTCPeerConnection::stop):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7a86401
    • vsevik@chromium.org's avatar
      Web Inspector: [Regression] When several consecutive characters are typed each... · 7bb3b4ce
      vsevik@chromium.org authored
      Web Inspector: [Regression] When several consecutive characters are typed each of them is marked as undoable state.
      https://bugs.webkit.org/show_bug.cgi?id=109823
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      * inspector/front-end/TextEditorModel.js:
      (WebInspector.TextEditorModel.endsWithBracketRegex.):
      
      LayoutTests:
      
      * inspector/editor/text-editor-undo-redo-expected.txt:
      * inspector/editor/text-editor-undo-redo.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bb3b4ce
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r142820. · afe3ed1f
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/142820
      https://bugs.webkit.org/show_bug.cgi?id=109839
      
      Causing crashes on chromium canaries (Requested by atwilson_
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14
      
      Source/WebCore:
      
      * dom/Document.cpp:
      (WebCore::Document::updateLayout):
      (WebCore::Document::implicitClose):
      * rendering/RenderQuote.h:
      (RenderQuote):
      * rendering/RenderView.cpp:
      * rendering/RenderView.h:
      
      LayoutTests:
      
      * fast/block/float/float-not-removed-from-pre-block-expected.txt:
      * fast/css-generated-content/quote-layout-focus-crash-expected.txt: Removed.
      * fast/css-generated-content/quote-layout-focus-crash.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afe3ed1f
    • mifenton@rim.com's avatar
      [BlackBerry] Update keyboard event details to match platform details. · acd37203
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109693
      
      Reviewed by Yong Li.
      
      PR 220170.
      
      When re-creating the Platform::Keyboard event ensure
      all values are updated.
      
      Reviewed Internally by Nima Ghanavatian.
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::updateFormState):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acd37203
    • mario@webkit.org's avatar
      [GTK] Missing call to g_object_ref while retrieving accessible table cells · e184198d
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106903
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Add missing extra ref to implementation of atk_table_ref_at().
      
      Test: accessibility/table-cell-for-column-and-row-crash.html
      
      * accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
      (webkitAccessibleTableRefAt): This method transfers full ownership
      over the returned AtkObject, so an extra reference is needed here.
      
      Tools:
      
      Both DRT and WKTR need to call g_object_unref() now that an extra
      reference is added in the implementation of atk_table_ref_at().
      
      * DumpRenderTree/atk/AccessibilityUIElementGtk.cpp:
      (AccessibilityUIElement::cellForColumnAndRow): Call g_object_unref
      before returning the new instance of AccessibilityUIElement.
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
      
      LayoutTests:
      
      Added new test. It should work fine at least in Mac and GTK ports,
      but will need specific results for chromium and windows.
      
      * accessibility/table-cell-for-column-and-row-crash.html: Added.
      * accessibility/table-cell-for-column-and-row-crash-expected.txt: Added.
      * platform/chromium/TestExpectations: Skipped test.
      * platform/win/TestExpectations: Ditto.
      * platform/wincairo/TestExpectations: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e184198d
    • mifenton@rim.com's avatar
      [BlackBerry] Update keyboard event details to match platform details. · ff473659
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109693
      
      Reviewed by Yong Li.
      
      PR 220170.
      
      Source/WebCore:
      
      Update the keyboard event details to match the
      platform details available.
      
      Rename helper function to better describe the conversion.
      
      Reviewed Internally by Nima Ghanavatian and Gen Mak.
      
      * platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
      (WebCore::windowsKeyCodeForBlackBerryKeycode):
      (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
      
      Source/WebKit/blackberry:
      
      Update keyboard event details.
      
      Reviewed Internally by Nima Ghanavatian and Gen Mak.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPage::keyEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff473659
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Reviewing TestExpectations. Added platform specific expected files and unskip them. · c3a07935
      kadam@inf.u-szeged.hu authored
      https://bugs.webkit.org/show_bug.cgi?id=59334.
      
      * platform/qt-5.0-wk2/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
      * platform/qt/TestExpectations:
      * platform/qt/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
      * platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
      * platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3a07935
    • fmalita@chromium.org's avatar
      [Chromium] Unreviewed rebaseline after brightness filter update. · 3e049119
      fmalita@chromium.org authored
      * platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png:
      * platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.png:
      * platform/chromium-linux/css3/filters/effect-brightness-expected.png:
      * platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png:
      * platform/chromium-linux/css3/filters/effect-combined-hw-expected.png:
      * platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png:
      * platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png:
      * platform/chromium-mac/css3/filters/effect-brightness-expected.png:
      * platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
      * platform/chromium-mac/css3/filters/effect-combined-expected.png:
      * platform/chromium-mac/css3/filters/effect-combined-hw-expected.png:
      * platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png:
      * platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png:
      * platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.png:
      * platform/chromium-win/css3/filters/effect-brightness-expected.png:
      * platform/chromium-win/css3/filters/effect-brightness-hw-expected.png:
      * platform/chromium-win/css3/filters/effect-combined-expected.png:
      * platform/chromium-win/css3/filters/effect-combined-hw-expected.png:
      * platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e049119
    • caseq@chromium.org's avatar
      Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToolsAgent · d50549ee
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109192
      
      Reviewed by Pavel Feldman.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      - remove frame and compositing instrumentation methods from InspectorInstrumentation;
      - expose those methods on InspectorController instead.
      
      * WebCore.exp.in:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::didBeginFrame):
      (WebCore):
      (WebCore::InspectorController::didCancelFrame):
      (WebCore::InspectorController::willComposite):
      (WebCore::InspectorController::didComposite):
      * inspector/InspectorController.h:
      (InspectorController):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      * testing/Internals.cpp:
      (WebCore::Internals::emitInspectorDidBeginFrame):
      (WebCore::Internals::emitInspectorDidCancelFrame):
      
      Source/WebKit/blackberry:
      
      - invoke frame instrumentation methods on InspectorController, not on InspectorInstrumentation.
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
      (BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
      
      Source/WebKit/chromium:
      
      - expose frame and compositing insturmentation methods on WebDevToolsAgent;
      - temporarily route them from WebViewImpl to WebDevToolsAgent;
      
      * public/WebDevToolsAgent.h:
      (WebDevToolsAgent):
      * src/WebDevToolsAgentImpl.cpp:
      (WebKit::WebDevToolsAgentImpl::didBeginFrame):
      (WebKit):
      (WebKit::WebDevToolsAgentImpl::didCancelFrame):
      (WebKit::WebDevToolsAgentImpl::willComposite):
      (WebKit::WebDevToolsAgentImpl::didComposite):
      * src/WebDevToolsAgentImpl.h:
      (WebDevToolsAgentImpl):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::instrumentBeginFrame):
      (WebKit::WebViewImpl::instrumentCancelFrame):
      (WebKit::WebViewImpl::didBeginFrame):
      (WebKit::WebViewImpl::willCommit):
      
      Source/WebKit/win:
      
      * WebKit.vcproj/WebKitExports.def.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d50549ee
    • commit-queue@webkit.org's avatar
      Web Inspector: Fixed a layout regression in CanvasProfileView. · aca986a8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109835
      
      Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-14
      Reviewed by Pavel Feldman.
      
      Changed splitView.css to supported nested SplitView instances.
      
      * inspector/front-end/splitView.css:
      (.split-view-vertical > .split-view-contents):
      (.split-view-vertical > .split-view-contents-first):
      (.split-view-vertical > .split-view-contents-first.maximized):
      (.split-view-vertical > .split-view-contents-second):
      (.split-view-vertical > .split-view-contents-second.maximized):
      (.split-view-horizontal > .split-view-contents):
      (.split-view-horizontal > .split-view-contents-first):
      (.split-view-horizontal > .split-view-contents-first.maximized):
      (.split-view-horizontal > .split-view-contents-second):
      (.split-view-horizontal > .split-view-contents-second.maximized):
      (.split-view-vertical > .split-view-sidebar.split-view-contents-first:not(.maximized)):
      (.split-view-vertical > .split-view-sidebar.split-view-contents-second:not(.maximized)):
      (.split-view-horizontal > .split-view-sidebar.split-view-contents-first:not(.maximized)):
      (.split-view-horizontal > .split-view-sidebar.split-view-contents-second:not(.maximized)):
      (.split-view-vertical > .split-view-resizer):
      (.split-view-horizontal > .split-view-resizer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aca986a8
    • jochen@chromium.org's avatar
      Unskip mediastream tests that are passing after webkit_support update · 89381cf3
      jochen@chromium.org authored
      Unreviewed gardening.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89381cf3
    • commit-queue@webkit.org's avatar
      Web Inspector: Color picker should not be available in Computed Styles pane. · 9456b619
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109697
      
      Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-14
      Reviewed by Alexander Pavlov.
      
      Changed the parentPane parameter of WebInspector.ComputedStylePropertiesSection to the correct value
      (the ComputedStyleSidebarPane instance).
      
      * inspector/front-end/StylesSidebarPane.js:
      (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9456b619
    • mnaganov@chromium.org's avatar
      [Chromium] Add a setting to control scaling content to fit viewport · 08f21f96
      mnaganov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109584
      
      Adds a setting called 'initializeAtMinimumPageScale'. By default,
      it is set to 'true' which corresponds to Chrome on Android behavior--
      adjust the page scale to make the content fit into the viewport
      by width. When set to false, the setting instructs ChromeClientImpl to
      set page scale to 1.0, unless the scale value is set by the page
      in the viewport meta-tag.
      
      Reviewed by Adam Barth.
      
      * public/WebSettings.h:
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::WebSettingsImpl):
      (WebKit::WebSettingsImpl::setInitializeAtMinimumPageScale):
      (WebKit):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl):
      (WebKit::WebSettingsImpl::initializeAtMinimumPageScale):
      * tests/WebFrameTest.cpp:
      * tests/data/viewport-2x-initial-scale.html: Added.
      * tests/data/viewport-auto-initial-scale.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08f21f96
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Skip flaky test after r140689. · 1ec0f099
      kadam@inf.u-szeged.hu authored
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ec0f099
    • yurys@chromium.org's avatar
      Web Inspector: don't create static local string for program literal in InspectorTimelineAgent · cae42196
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109811
      
      Reviewed by Pavel Feldman.
      
      Use const char* constant value instead of creating String from it in thread-unsafe
      static local variable.
      
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cae42196
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r142808. · 4cff3c97
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/142808
      https://bugs.webkit.org/show_bug.cgi?id=109816
      
      Crashes on chromium webkit canary bots (Requested by atwilson_
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::handleGestureEvent):
      (WebKit::WebViewImpl::bestTouchLinkNode):
      (WebKit::WebViewImpl::enableTouchHighlight):
      * src/WebViewImpl.h:
      (WebViewImpl):
      * tests/LinkHighlightTest.cpp:
      (WebCore::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cff3c97