1. 18 Apr, 2012 39 commits
    • benjamin@webkit.org's avatar
      Remove m_subclassData from JSArray, move the attribute to subclass as needed · 01a43ea1
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84249
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-18
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      JSArray's m_subclassData is only used by WebCore's RuntimeArray. This patch moves
      the attribute to RuntimeArray to avoid allocating memory for the pointer in the common
      case.
      
      This gives ~1% improvement in JSArray creation microbenchmark thanks to fewer allocations
      of CopiedSpace.
      
      * jit/JITInlineMethods.h:
      (JSC::JIT::emitAllocateJSArray):
      * runtime/JSArray.cpp:
      (JSC::JSArray::JSArray):
      * runtime/JSArray.h:
      
      Source/WebCore: 
      
      * bridge/runtime_array.cpp:
      (JSC::RuntimeArray::RuntimeArray):
      (JSC::RuntimeArray::finishCreation):
      * bridge/runtime_array.h:
      (JSC::RuntimeArray::getLength):
      (JSC::RuntimeArray::getConcreteArray):
      (RuntimeArray):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01a43ea1
    • antti@apple.com's avatar
      matchMedia() MediaQueryList not updating · ef75e9e9
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75903
      
      Patch by Luiz Agostini <luiz.agostini@palm.com> on 2012-04-18
      Reviewed by Antti Koivisto.
      
      Source/WebCore: 
      
      Test: fast/media/media-query-list-08.html
      
      Viewport related MediaQueryList listeners were not triggered and the value
      of matches were not updated if the document's style selector were not
      affected by viewport changes.
      
      The new method evaluateMediaQueries() is now called by FrameView instead of
      styleSelectorChanged() if the style selector is not affected by viewport changes.
      
      * dom/Document.cpp:
      (WebCore::Document::evaluateMediaQueries):
      (WebCore):
      (WebCore::Document::styleSelectorChanged):
      * dom/Document.h:
      (Document):
      * page/FrameView.cpp:
      (WebCore::FrameView::layout):
      
      LayoutTests: 
      
      Testing MediaQueryLists listeners related to viewport changes.
      
      * fast/media/media-query-list-08-expected.txt: Added.
      * fast/media/media-query-list-08.html: Added.
      
      Skipping the new test in Mac and Qt due to an issue in its DumpRenderTree.
      
      * platform/qt/Skipped:
      * platform/mac/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef75e9e9
    • eae@chromium.org's avatar
      Use explicit casts for size_t to unsigned conversion · 21eb8999
      eae@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83602
      
      Reviewed by Eric Seidel.
      
      No new tests, no change in functinality.
      
      Not all platforms have implicit casts from size_t to unsigned and we
      can't add size_t versions of the operators to FractionalLayoutUnit for
      all platforms as it would conflict with the unsigned versions of same.
      
      Change support methods to take unsigned instead of size_t and use
      explicit casts when multiplying or dividing a FractionalLayoutUnit with
      a size_t and the other way around.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::adjustForColumns):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::initialPackingOffset):
      (WebCore::packingSpaceBetweenChildren):
      (WebCore::initialLinePackingOffset):
      (WebCore::linePackingSpaceBetweenChildren):
      (WebCore::RenderFlexibleBox::packFlexLines):
      * rendering/RenderFrameSet.cpp:
      (WebCore::RenderFrameSet::layout):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21eb8999
    • philn@webkit.org's avatar
      Unreviewed, GTK test_expectations update. · e65320a4
      philn@webkit.org authored
      * platform/gtk/test_expectations.txt: Skip some failing tests and
      mark 3 more frame flattening tests flaky.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e65320a4
    • pfeldman@chromium.org's avatar
      Source/WebCore: Web Inspector: [Chromium] Module's require injects scripts... · 46849f81
      pfeldman@chromium.org authored
      Source/WebCore: Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
      https://bugs.webkit.org/show_bug.cgi?id=84166
      
      Re-applying r114497.
      
      * bindings/v8/V8IsolatedContext.cpp:
      (WebCore::setInjectedScriptContextDebugId):
      (WebCore):
      (WebCore::V8IsolatedContext::V8IsolatedContext):
      * bindings/v8/V8Proxy.cpp:
      (WebCore::V8Proxy::evaluateInIsolatedWorld):
      * bindings/v8/V8Proxy.h:
      (V8Proxy):
      
      LayoutTests: Unreviewed, rolling out r114506.
      http://trac.webkit.org/changeset/114506
      https://bugs.webkit.org/show_bug.cgi?id=84254
      
      Seems to be making gtk's DumpRenderTree crash occasionally
      (Requested by tomz on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18
      
      * platform/gtk/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46849f81
    • achicu@adobe.com's avatar
      Unreviewed, trying to fix QT build. · 209a76a2
      achicu@adobe.com authored
      It was using a FilterEffectRenderer::prepare that changed to allocateBackingStoreIfNeeded in 114529.
      
      * platform/graphics/texmap/TextureMapperImageBuffer.cpp:
      (WebCore::BitmapTextureImageBuffer::applyFilters):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      209a76a2
    • enne@google.com's avatar
      [chromium] Unreviewed, rebaseline compositing tests after r114283. · 6017295a
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84083
      
      * platform/chromium-linux/compositing/overflow/overflow-positioning-expected.png:
      * platform/chromium-mac-leopard/compositing/overflow/overflow-positioning-expected.png: Added.
      * platform/chromium-mac-snowleopard/compositing/overflow/overflow-positioning-expected.png:
      * platform/chromium-mac/compositing/overflow/overflow-positioning-expected.png:
      * platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt: Added.
      * platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
      * platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt: Added.
      * platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
      * platform/chromium-win/compositing/overflow/overflow-positioning-expected.png:
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6017295a
    • pfeldman@chromium.org's avatar
      Web Inspector: extract script navigator overlay logic into the scripts navigator controller. · e4771a06
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84244
      
      Reviewed by Vsevolod Vlasov.
      
      Overlay logic is well separable from the scripts panel and does not belong there.
      Extracting it into a separate class.
      
      * inspector/front-end/ScriptsNavigator.js:
      (WebInspector.ScriptsNavigatorController.prototype.wasShown):
      (WebInspector.ScriptsNavigatorController.prototype._createNavigatorControlButton):
      (WebInspector.ScriptsNavigatorController.prototype._escDownWhileNavigatorOverlayOpen):
      (WebInspector.ScriptsNavigatorController.prototype._toggleNavigator):
      (WebInspector.ScriptsNavigatorController.prototype._hidePinnedNavigator):
      (WebInspector.ScriptsNavigatorController.prototype.set _pinNavigator):
      (WebInspector.ScriptsNavigatorController.prototype.set showNavigatorOverlay):
      (WebInspector.ScriptsNavigatorController.prototype.hideNavigatorOverlay):
      (WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown):
      * inspector/front-end/ScriptsPanel.js:
      (WebInspector.ScriptsPanel.prototype.wasShown):
      (WebInspector.ScriptsPanel.prototype._editorClosed):
      (WebInspector.ScriptsPanel.prototype._editorSelected):
      (WebInspector.ScriptsPanel.prototype._scriptSelected):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4771a06
    • tomz@codeaurora.org's avatar
      Unreviewed, rolling out r114506. · eb66fc4a
      tomz@codeaurora.org authored
      http://trac.webkit.org/changeset/114506
      https://bugs.webkit.org/show_bug.cgi?id=84254
      
      Seems to be making gtk's DumpRenderTree crash occasionally
      (Requested by tomz on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebsettings.cpp:
      (webkit_web_settings_class_init):
      (webkit_web_settings_set_property):
      (webkit_web_settings_get_property):
      * webkit/webkitwebsettingsprivate.h:
      * webkit/webkitwebview.cpp:
      (webkit_web_view_update_settings):
      (webkit_web_view_settings_notify):
      
      Tools:
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (resetDefaultsToConsistentValues):
      
      LayoutTests:
      
      * platform/gtk/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb66fc4a
    • dimich@chromium.org's avatar
      Unreviewed, rolling out r114497. · 6a599372
      dimich@chromium.org authored
      http://trac.webkit.org/changeset/114497
      https://bugs.webkit.org/show_bug.cgi?id=84253
      
      Broke compile on Win, including stdio did not help (Requested
      by dimich on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18
      
      * bindings/v8/V8IsolatedContext.cpp:
      (WebCore::V8IsolatedContext::V8IsolatedContext):
      * bindings/v8/V8Proxy.cpp:
      (WebCore::V8Proxy::evaluateInIsolatedWorld):
      (WebCore::V8Proxy::setInjectedScriptContextDebugId):
      (WebCore):
      * bindings/v8/V8Proxy.h:
      (V8Proxy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a599372
    • achicu@adobe.com's avatar
      [CSS Filters] Drop-shadow and blur can avoid using full source image · ce81a179
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=81263
      
      Reviewed by Dean Jackson.
      
      Instead of using the full bounding box of the RenderLayer we now compute the exact rectangle that is needed to
      compute filter inside the dirty rectangle on screen. That's easy to calculate by reversing the filter outsets.
      Even if the element is completely offscreen, but its shadow is in the viewport, we can still compute the source
      rectangle that needs to be drawn in order to update the shadow correctly.
      
      No new tests, this change doesn't have visible results and the functionality should
      already be covered by previous filter tests.
      
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::FilterEffectRenderer):
      (WebCore::FilterEffectRenderer::build): Save the outsets of the filters, so that we can use them in computeSourceImageRectForDirtyRect.
      (WebCore::FilterEffectRenderer::updateBackingStoreRect): Only allocate a new source image if the size of the source rectangle changed.
      (WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded): There's no need to call clearIntermediateResults() in this function. We do that after
      the filter is computed.
      (WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):
      (WebCore):
      (WebCore::FilterEffectRendererHelper::prepareFilterEffect):
      (WebCore::FilterEffectRendererHelper::beginFilterEffect):
      * rendering/FilterEffectRenderer.h:
      (FilterEffectRendererHelper):
      (WebCore::FilterEffectRendererHelper::repaintRect):
      (FilterEffectRenderer):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::paintLayerContents):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce81a179
    • commit-queue@webkit.org's avatar
      [EFL][DRT] @font-face support fails on EFL · 13ac23e9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83264
      
      Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-18
      Reviewed by Dimitri Glazkov.
      
      STORE_FONT_CUSTOM_PLATFORM_DATA was not defined for EFL.
      Fixing that by removing a long standing FIXME with the intention
      to turn the whitelist for this switch into a blacklist.
      
      * loader/cache/CachedFont.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13ac23e9
    • benjamin@webkit.org's avatar
      replaceUsingStringSearch: delay the creation of the replace string until needed · bf3b56fb
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83841
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-18
      Reviewed by Geoffrey Garen.
      
      We do not need to obtain the replaceValue until we have a match. By moving the intialization
      of replaceValue when needed, we save a few instructions when there is no match.
      
      * runtime/StringPrototype.cpp:
      (JSC::replaceUsingRegExpSearch):
      (JSC::replaceUsingStringSearch):
      (JSC::stringProtoFuncReplace):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf3b56fb
    • leviw@chromium.org's avatar
      Convert ShadowData and DropShadowFilterOperation to use IntPoint · 021cace4
      leviw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84098
      
      Reviewed by Eric Seidel.
      
      Shadows do not flow with the page, so sub-pixel layout doesn't actually offer any benefit that
      couldn't have been attained before that conversion. With that in mind, this patch reverts
      drop shadow offsets to integers, but also cleans up the code by switching the x/y location pair
      to be an IntPoint.
      
      No new tests. No change in behavior.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::valueForFilter):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::collectMatchingRulesForList):
      * css/SVGCSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applySVGProperty):
      * page/animation/AnimationBase.cpp:
      (WebCore::blendFunc):
      (WebCore::shadowForBlending):
      * platform/animation/AnimationUtilities.h:
      (WebCore::blend): New blend function that operates on IntPoints.
      (WebCore):
      * platform/chromium/support/WebFilterOperations.cpp:
      (WebKit::WebDropShadowFilterOperation):
      * platform/graphics/filters/FilterOperation.cpp:
      (WebCore::DropShadowFilterOperation::blend):
      * platform/graphics/filters/FilterOperation.h:
      (WebCore::DropShadowFilterOperation::clone):
      (WebCore::DropShadowFilterOperation::x):
      (WebCore::DropShadowFilterOperation::y):
      (WebCore::DropShadowFilterOperation::location): Preserved the comment about lengths.
      (WebCore::DropShadowFilterOperation::operator==):
      (WebCore::DropShadowFilterOperation::DropShadowFilterOperation):
      (DropShadowFilterOperation):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::areaCastingShadowInHole): Reverted to integers since this operates on the IntRect from
      a RoundedRect.
      (WebCore::RenderBoxModelObject::paintBoxShadow): Reduced the complexity and unnecessary conversion
      between LayoutUnits and integers by using all integers after we calculate the pixel-snapped
      RoundedRect that we use for painting.
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::getShadowExtent):
      (WebCore::RenderStyle::getShadowHorizontalExtent):
      (WebCore::RenderStyle::getShadowVerticalExtent):
      * rendering/style/ShadowData.cpp:
      (WebCore::ShadowData::ShadowData):
      (WebCore::ShadowData::operator==):
      (WebCore::calculateShadowExtent):
      (WebCore::ShadowData::adjustRectForShadow):
      * rendering/style/ShadowData.h:
      (WebCore::ShadowData::ShadowData):
      (WebCore::ShadowData::x):
      (WebCore::ShadowData::y):
      (WebCore::ShadowData::location):
      (ShadowData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      021cace4
    • haraken@chromium.org's avatar
      [V8] Add an optional Isolate argument to wrap() · 405e386d
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84202
      
      Reviewed by Nate Chapin.
      
      The final objective is to pass Isolate around in V8 bindings.
      This patch adds an optional Isolate argument to wrap().
      After rewriting all wrap() callers so that they pass Isolate
      to wrap(), I'll make the Isolate argument non-optional.
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
      (GenerateHeader):
      * bindings/v8/custom/V8DocumentCustom.cpp: Ditto.
      (WebCore::toV8):
      * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Ditto.
      (WebCore::toV8):
      * bindings/v8/custom/V8NodeCustom.cpp: Ditto.
      (WebCore::toV8Slow):
      * bindings/v8/custom/V8SVGDocumentCustom.cpp: Ditto.
      (WebCore::toV8):
      * dom/make_names.pl: Ditto.
      (printWrapperFactoryCppFile):
      
      * bindings/scripts/test/V8/V8Float64Array.h:
      Updated run-bindings-tests results.
      (V8Float64Array):
      (WebCore::V8Float64Array::wrap):
      * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
      (V8TestActiveDOMObject):
      (WebCore::V8TestActiveDOMObject::wrap):
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
      (V8TestCustomNamedGetter):
      (WebCore::V8TestCustomNamedGetter::wrap):
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestEventConstructor.h:
      (V8TestEventConstructor):
      (WebCore::V8TestEventConstructor::wrap):
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestEventTarget.h:
      (V8TestEventTarget):
      (WebCore::V8TestEventTarget::wrap):
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestInterface.h:
      (V8TestInterface):
      (WebCore::V8TestInterface::wrap):
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
      (V8TestMediaQueryListListener):
      (WebCore::V8TestMediaQueryListListener::wrap):
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestNamedConstructor.h:
      (V8TestNamedConstructor):
      (WebCore::V8TestNamedConstructor::wrap):
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestNode.h:
      (V8TestNode):
      (WebCore::V8TestNode::wrap):
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestObj.h:
      (V8TestObj):
      (WebCore::V8TestObj::wrap):
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
      (V8TestSerializedScriptValueInterface):
      (WebCore::V8TestSerializedScriptValueInterface::wrap):
      (WebCore::toV8):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      405e386d
    • achicu@adobe.com's avatar
      [CSS Filters] Do not use clipping rect when calculating the bounds of a layer · c316136c
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83960
      
      Reviewed by Simon Fraser.
      
      The local clip rect should not be used when calculating the bounds of a filter area. Otherwise
      drop-shadow might not know about the pixels outside the clipping rectangle, even though the actual shadow might
      be inside it.
      
      No new tests added in this patch, but this patch fixes two existing tests that fail.
      LayoutTests/css3/filters/filter-repaint-shadow-clipped.html
      LayoutTests/css3/filters/filter-repaint-shadow-rotated.html
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::paintLayerContents):
      (WebCore::RenderLayer::calculateLayerBounds):
      * rendering/RenderLayer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c316136c
    • pilgrim@chromium.org's avatar
      Followup to "Call incrementStatsCounter directly" · 4e5d8f96
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83109
      
      Reviewed by Kentaro Hara.
      
      Now that incrementStatsCounter has been moved from
      PlatformSupport.h to Platform.h, we need to be able to call it directly
      from WebCore/bindings/v8/v8Proxy.h (for the INC_STATS macro). That
      means we need a new StatsCounter class in WebCore/platform/ and an
      implementation in
      WebCore/platform/chromium/StatsCounterChromium.cpp. Other ports
      are welcome to implement their own stats counters if they
      wish. This pattern was based on the
      HistogramSupport/HistogramSupportChromium classes.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/v8/V8Proxy.h:
      * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
      (WebCore::V8DedicatedWorkerContext::postMessageCallback):
      (WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):
      * bindings/v8/custom/V8NotificationCenterCustom.cpp:
      (WebCore::V8NotificationCenter::createHTMLNotificationCallback):
      (WebCore::V8NotificationCenter::createNotificationCallback):
      (WebCore::V8NotificationCenter::requestPermissionCallback):
      * bindings/v8/custom/V8WorkerContextCustom.cpp:
      (WebCore::V8WorkerContext::importScriptsCallback):
      (WebCore::V8WorkerContext::setTimeoutCallback):
      (WebCore::V8WorkerContext::setIntervalCallback):
      * platform/StatsCounter.cpp: Added.
      (WebCore):
      (WebCore::StatsCounter::incrementStatsCounter):
      * platform/StatsCounter.h: Added.
      (WebCore):
      (StatsCounter):
      * platform/chromium/StatsCounterChromium.cpp: Added.
      (WebCore):
      (WebCore::StatsCounter::incrementStatsCounter):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e5d8f96
    • apavlov@chromium.org's avatar
      [Chromium] REGRESSION: Popup shrinks because of autocomplete · e03fde26
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84139
      http://code.google.com/p/chromium/issues/detail?id=123432
      
      Source/WebCore:
      
      Do not update the window rect on the wrong client but instead return the popup widget's
      new screen coordinates from the refresh() method.
      
      Reviewed by Kent Tamura.
      
      * platform/chromium/PopupContainer.cpp:
      (WebCore::PopupContainer::refresh):
      * platform/chromium/PopupContainer.h:
      (PopupContainer):
      
      Source/WebKit/chromium:
      
      Do not use the PopupContainer's frameRect() to update the popup client's window rect,
      since PopupContainer is always positioned at (0, 0) inside the client's window rect,
      and the latter one is positioned relative to the screen origin.
      
      Reviewed by Kent Tamura.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::refreshAutofillPopup):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e03fde26
    • mhahnenberg@apple.com's avatar
      GC activity timer should be tied to allocation, not collection · 2b64eec0
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83919
      
      Reviewed by Geoffrey Garen.
      
      * API/JSContextRef.cpp: Used the new didAbandonObjectGraph callback to indicate that now that we've
      released a global object, we're abandoning a potentially large number of objects that JSC might want
      to collect.
      * heap/CopiedSpace.cpp:
      (JSC::CopiedSpace::tryAllocateSlowCase): Added the call to timer's willAllocate function to indicate
      that we've hit a slow path and are allocating now, so schedule the timer.
      * heap/Heap.cpp:
      (JSC::Heap::Heap):
      (JSC::Heap::collectAllGarbage): Removed the call to discardAllCompiledCode because it was causing us to
      throw away too much code during our benchmarks (especially vp8, which is very large and thus has large
      amounts of compiled code).
      (JSC::Heap::collect): Added the new call to didCollect at the conclusion of a collection so that we
      can cancel the timer if we no longer need to run a collection. Also added a check at the beginning of a
      collection to see if we should throw away our compiled code. Currently this is set to happen about once
      every minute.
      * heap/Heap.h: Added field to keep track of the last time we threw away our compiled code.
      * heap/MarkedAllocator.cpp:
      (JSC::MarkedAllocator::allocateSlowCase): Added call to willAllocate on the allocation slow path, just like
      in CopiedSpace.
      * runtime/GCActivityCallback.cpp: Added default stubs for non-CF platforms.
      (JSC::DefaultGCActivityCallback::willAllocate):
      (JSC):
      (JSC::DefaultGCActivityCallback::didCollect):
      (JSC::DefaultGCActivityCallback::didAbandonObjectGraph):
      * runtime/GCActivityCallback.h: Added new functions to make JSC's GC timer less arcane. This includes replacing
      the operator () with willAllocate() and adding an explicit didCollect() to cancel the timer after a collection
      occurs rather than relying on the way the timer is invoked to cancel itself. Also added a callback for
      when somebody else (e.g. WebCore or the JSC API) to notify JSC that they have just abandoned an entire graph of
      objects and that JSC might want to clean them up.
      (JSC::GCActivityCallback::~GCActivityCallback):
      (JSC::GCActivityCallback::willAllocate):
      (JSC::GCActivityCallback::didCollect):
      (JSC::GCActivityCallback::didAbandonObjectGraph):
      (JSC::GCActivityCallback::synchronize):
      (DefaultGCActivityCallback):
      * runtime/GCActivityCallbackCF.cpp: Re-wired all the run loop stuff to implement the aforementioned functions.
      We added a flag to check whether the timer was active because the call to CFRunLoopTimerSetNextFireDate actually
      turned out to be quite expensive (although Instruments couldn't tell us this).
      (DefaultGCActivityCallbackPlatformData):
      (JSC):
      (JSC::DefaultGCActivityCallbackPlatformData::timerDidFire):
      (JSC::DefaultGCActivityCallback::commonConstructor):
      (JSC::scheduleTimer):
      (JSC::cancelTimer):
      (JSC::DefaultGCActivityCallback::willAllocate):
      (JSC::DefaultGCActivityCallback::didCollect):
      (JSC::DefaultGCActivityCallback::didAbandonObjectGraph):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b64eec0
    • simon.fraser@apple.com's avatar
      ASSERT when a layer with a foreground layer is in 'paint into ancestor' mode · c0fc313a
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84221
      
      Source/WebCore:
      
      Reviewed by Dean Jackson.
      
      When a RenderLayerBacking doesn't require its own backing store, and is
      in "paintIntoCompositingAncestor" mode, we would assert when trying to
      paint its m_foregroundLayer if it had one (because of a negative z-index child).
      
      The fix is to set the 'drawsContent' state on the m_foregroundLayer
      as well as m_graphicsLayer.
      
      Test: compositing/backing/no-backing-foreground-layer.html
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateDrawsContent):
      
      LayoutTests:
      
      Reviewed by Dean Jackson.
      
      New testcase.
      
      * compositing/backing/no-backing-foreground-layer-expected.txt: Added.
      * compositing/backing/no-backing-foreground-layer.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0fc313a
    • commit-queue@webkit.org's avatar
      [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE · a2d33a01
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84229
      
      CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
      subsequent builds, stopping WebCore from being built ever again.
      
      Instead of trying to emulate a build target using command line options,
      just build the existing jsc target directly.
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-18
      Reviewed by Rob Buis.
      
      .:
      
      * CMakeLists.txt:
      
      Tools:
      
      * Scripts/build-jsc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2d33a01
    • commit-queue@webkit.org's avatar
      [GTK] r114021 triggered media flakyness · 49ee4cd4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83874
      
      Patch by Simon Pena <spena@igalia.com> on 2012-04-18
      Reviewed by Philippe Normand.
      
      Source/WebKit/gtk:
      
      When the MediaPlaybackRequiresUserGesture setting was added, no gtk
      API was implemented to access it.
      
      This adds a property to gtk WebKit WebSettings, and connects it to
      WebKit WebView, thus allowing clients to programmatically modify it.
      
      * webkit/webkitwebsettings.cpp:
      (webkit_web_settings_class_init):
      (webkit_web_settings_set_property):
      (webkit_web_settings_get_property):
      * webkit/webkitwebsettingsprivate.h:
      * webkit/webkitwebview.cpp:
      (webkit_web_view_update_settings):
      (webkit_web_view_settings_notify):
      
      Tools:
      
      Now that there is gtk API to update the
      MediaPlaybackRequiresUserGesture property, set it to false from the
      DumpRenderTree tool when resetting defaults to consistent values.
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (resetDefaultsToConsistentValues):
      
      LayoutTests:
      
      media/video-load-require-user-gesture.html and
      media/video-play-require-user-gesture.html where enabling
      MediaPlaybackRequiresUserGesture when run, so tests running
      concurrently would fail -they would pass when run independently.
      
      Since new API is added to ensure DumpRenderTree is able to reset
      that setting, having media/video-load-require-user-gesture.html and
      media/video-play-require-user-gesture.html no longer causes
      flakiness.
      
      * platform/gtk/test_expectations.txt: Unskip
      media/video-load-require-user-gesture.html and
      media/video-play-require-user-gesture.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49ee4cd4
    • yurys@chromium.org's avatar
      Web Inspector: DataGrid should use explicit root node · 9afdfc33
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84240
      
      DataGrid now has an explicit root node. All children are added/removed
      to that node.
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      * inspector/front-end/ApplicationCacheItemsView.js:
      (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):
      (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
      * inspector/front-end/CSSSelectorProfileView.js:
      (WebInspector.CSSSelectorProfileView):
      (WebInspector.CSSSelectorProfileView.prototype.rebuildGridItems):
      (WebInspector.CSSSelectorProfileView.prototype.refreshData):
      * inspector/front-end/CookieItemsView.js:
      (WebInspector.SimpleCookiesTable):
      (WebInspector.SimpleCookiesTable.prototype.setCookies):
      * inspector/front-end/CookiesTable.js:
      (WebInspector.CookiesTable):
      (WebInspector.CookiesTable.prototype._rebuildTable):
      * inspector/front-end/DOMStorageItemsView.js:
      (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
      * inspector/front-end/DataGrid.js:
      (WebInspector.DataGrid):
      (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
      (WebInspector.DataGrid.createSortableDataGrid):
      (WebInspector.DataGrid.prototype.setRootNode):
      (WebInspector.DataGrid.prototype.rootNode):
      (WebInspector.DataGrid.prototype.autoSizeColumns):
      (WebInspector.DataGrid.prototype._enumerateChildren):
      (WebInspector.DataGrid.prototype._keyDown):
      (WebInspector.DataGrid.prototype._contextMenuInDataTable):
      (WebInspector.DataGridNode.prototype.get revealed):
      (WebInspector.DataGridNode.prototype.get depth):
      (WebInspector.DataGridNode.prototype.appendChild):
      (WebInspector.DataGridNode.prototype.insertChild):
      (WebInspector.DataGridNode.prototype.removeChild):
      (WebInspector.DataGridNode.prototype.removeChildren):
      (WebInspector.DataGridNode.prototype.collapse):
      (WebInspector.DataGridNode.prototype.expand):
      (WebInspector.DataGridNode.prototype.reveal):
      (WebInspector.DataGridNode.prototype.revealAndSelect):
      (WebInspector.DataGridNode.prototype.traverseNextNode):
      (WebInspector.DataGridNode.prototype.traversePreviousNode):
      * inspector/front-end/HeapSnapshotDataGrids.js:
      (WebInspector.HeapSnapshotSortableDataGrid):
      (WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
      (WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
      (WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
      (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
      (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
      (WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
      (WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
      (WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
      (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
      (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
      (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
      (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
      (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
      (WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
      (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
      * inspector/front-end/HeapSnapshotGridNodes.js:
      (WebInspector.HeapSnapshotGenericObjectNode):
      * inspector/front-end/HeapSnapshotView.js:
      (WebInspector.HeapSnapshotView.prototype.performSearch):
      (WebInspector.HeapSnapshotView.prototype.refreshVisibleData):
      * inspector/front-end/IndexedDBViews.js:
      (WebInspector.IDBDataView.prototype._createDataGrid):
      (WebInspector.IDBDataView.prototype._updateData.callback):
      (WebInspector.IDBDataView.prototype._updateData):
      (WebInspector.IDBDataView.prototype.clear):
      * inspector/front-end/NetworkPanel.js:
      (WebInspector.NetworkLogView.prototype._createTable):
      (WebInspector.NetworkLogView.prototype.refresh):
      (WebInspector.NetworkLogView.prototype._reset):
      * inspector/front-end/ProfileDataGridTree.js:
      (WebInspector.ProfileDataGridNode.prototype.insertChild):
      (WebInspector.ProfileDataGridNode.prototype.removeChild):
      (WebInspector.ProfileDataGridNode.prototype.removeChildren):
      * inspector/front-end/ProfileView.js:
      (WebInspector.CPUProfileView.prototype.refresh):
      * inspector/front-end/treeoutline.js:
      
      LayoutTests:
      
      * inspector/profiler/heap-snapshot-test.js:
      (initialize_HeapSnapshotTest):
      * inspector/storage-panel-dom-storage.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9afdfc33
    • schenney@chromium.org's avatar
      Layout Test svg/transforms/transform-origin-css-property.xhtml is failing · c0d9c8d2
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84203
      
      Unreviewed test expectation fix.
      
      The svg/transforms/transform-origin-css-property.xhtml test has a
      ref-test for it, so there should not be any image expectations. If the
      test if failing, we need to look at why the ref test is not valid, or
      why we differ.
      
      The expectations file update here is just some cleanup for
      https://bugs.webkit.org/show_bug.cgi?id=84230.
      
      * platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Removed.
      * platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Removed.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0d9c8d2
    • commit-queue@webkit.org's avatar
      Add PassThis=* to support the callbacks which requires to pass "this" value. · d8d2757f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84232
      
      Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-04-18
      Reviewed by Kentaro Hara.
      
      Adding PassThisToCallback=XXX to attributes will be useful for the callbacks which requires to pass "this".
      This will help to identify the type(XXX) of "this" value in codegenerator.
      
      Tests: bindings/scripts/test/TestCallback.idl
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateCallbackImplementation): Modified codegenerator to support [PassThisToCallback]
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateCallbackImplementation): Ditto.
      * bindings/scripts/IDLAttributes.txt: Added PassThisToCallback=*
      * bindings/scripts/test/CPP/WebDOMTestCallback.cpp: Modofied results from run-bindings-tests.
      (WebDOMTestCallback::callbackWithBoolean):
      (WebDOMTestCallback::callbackRequiresThisToPass):
      * bindings/scripts/test/CPP/WebDOMTestCallback.h: Ditto.
      (WebDOMTestCallback):
      * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Ditto.
      (webkit_dom_test_callback_callback_with_boolean):
      (webkit_dom_test_callback_callback_requires_this_to_pass):
      * bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Ditto.
      * bindings/scripts/test/JS/JSTestCallback.cpp: Ditto.
      (WebCore::JSTestCallback::callbackWithBoolean):
      (WebCore):
      (WebCore::JSTestCallback::callbackRequiresThisToPass):
      * bindings/scripts/test/JS/JSTestCallback.h: Ditto.
      (JSTestCallback):
      * bindings/scripts/test/ObjC/DOMTestCallback.h: Ditto.
      * bindings/scripts/test/ObjC/DOMTestCallback.mm: Ditto.
      (-[DOMTestCallback callbackWithBoolean:]):
      (-[DOMTestCallback callbackRequiresThisToPass:thisClassParam:]):
      * bindings/scripts/test/TestCallback.idl: Added test to verify generated code.
      * bindings/scripts/test/V8/V8TestCallback.cpp: Ditto.
      (WebCore::V8TestCallback::callbackWithBoolean):
      (WebCore):
      (WebCore::V8TestCallback::callbackRequiresThisToPass):
      * bindings/scripts/test/V8/V8TestCallback.h: Ditto.
      (V8TestCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8d2757f
    • pfeldman@chromium.org's avatar
      Not reviewed: fixing Chromium win compilation. · 7abf47e0
      pfeldman@chromium.org authored
      * bindings/v8/V8IsolatedContext.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7abf47e0
    • macpherson@chromium.org's avatar
      Remove unnecessary variable reassignment in CSSParser::parseImageSet(). · eef07d24
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84204
      
      Reviewed by Kentaro Hara.
      
      Code calls next and then current instead of reusing the result of next.
      
      No new tests / no functionality changed.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseImageSet):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eef07d24
    • commit-queue@webkit.org's avatar
      Web Inspector: Disabling Inspector causes build failure on Windows · cd728636
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83557
      
      Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-18
      Reviewed by Pavel Feldman.
      
      The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
      This change brings all such API calls under the guard.
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebInspectorClient.cpp:
      * WebInspector.cpp:
      * WebNodeHighlight.cpp:
      (WebNodeHighlight::WebNodeHighlight):
      (WebNodeHighlight::update):
      * WebNodeHighlight.h:
      (WebNodeHighlight):
      * WebView.cpp:
      (WebView::WebView):
      (WebView::close):
      (WebView::initWithFrame):
      (WebView::inspector):
      * WebView.h:
      (WebView):
      
      Tools:
      
      * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
      (WTR::LayoutTestController::showWebInspector):
      (WTR::LayoutTestController::closeWebInspector):
      (WTR::LayoutTestController::evaluateInWebInspector):
      (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
      * WebKitTestRunner/TestInvocation.cpp:
      (WTR::TestInvocation::invoke):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd728636
    • commit-queue@webkit.org's avatar
      [BlackBerry] HTTP GET header has a "Cookie" when refreshing a page after cookies have been cleared. · e5dfd3d1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84223
      
      Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
      Reviewed by George Staikos.
      
      .:
      
      * ManualTests/blackberry/clear-cookie-refresh-result.php: Added.
      * ManualTests/blackberry/clear-cookie-refresh.php: Added.
      
      Source/WebCore:
      
      Webkit uses the old ResourceRequest when refreshing. Its cookies' header isn't removed after clicking
      "clear cookies" button. We need to set cookies for this request again.
      
      We must click "clear button" to test, so have to write a manual test case.
      
      Test: ManualTests/blackberry/clear-cookie-refresh.php
      
      * platform/network/blackberry/ResourceRequestBlackBerry.cpp:
      (WebCore::ResourceRequest::initializePlatformRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5dfd3d1
    • pfeldman@chromium.org's avatar
      Web Inspector: [Chromium] Module's require injects scripts before the debug id... · 2e5e6a3d
      pfeldman@chromium.org authored
      Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
      https://bugs.webkit.org/show_bug.cgi?id=84166
      
      Reviewed by Yury Semikhatsky.
      
      V8IsolatedContext was getting debug id assigned post-construction. At the same time, it was compiling all
      its module scripts within the constructor. As a result, scripts ended up in the main world's list.
      
      * bindings/v8/V8IsolatedContext.cpp:
      (WebCore::setInjectedScriptContextDebugId):
      (WebCore):
      (WebCore::V8IsolatedContext::V8IsolatedContext):
      * bindings/v8/V8Proxy.cpp:
      (WebCore::V8Proxy::evaluateInIsolatedWorld):
      * bindings/v8/V8Proxy.h:
      (V8Proxy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e5e6a3d
    • commit-queue@webkit.org's avatar
      [Qt][WK2] Minibrowser asserts on startup at... · 3a976b10
      commit-queue@webkit.org authored
      [Qt][WK2] Minibrowser asserts on startup at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
      https://bugs.webkit.org/show_bug.cgi?id=84172
      
      Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-18
      Reviewed by Simon Hausmann.
      
      After the viewport computing refactor, ensureContentWithinViewportBoundary() can be called
      with resumed page. QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
      functionality does not necessarily require the page to be suspended. It's the caller's context
      that determines whether the page needs to be suspended, so it's the caller's responsibility
      to enforce the ASSERT().
      Remove the invalid ASSERT on m_suspendCount at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
      
      * UIProcess/qt/QtViewportInteractionEngine.cpp:
      (WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a976b10
    • toyoshim@chromium.org's avatar
      Unreviewed, update expectations · 975e96e5
      toyoshim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84230
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      975e96e5
    • pfeldman@chromium.org's avatar
      Web Inspector: document.open removes the documentElement, but does not clear the elements panel. · 21ca2f19
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84179
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Perform total update upon modifications of the document node.
      
      Test: inspector/elements/delete-from-document.html
      
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::didRemoveDOMNode):
      * inspector/front-end/ElementsTreeOutline.js:
      
      LayoutTests:
      
      * http/tests/inspector/elements-test.js:
      (initialize_ElementTest.InspectorTest.dumpElementsTree.print):
      (initialize_ElementTest.InspectorTest.dumpElementsTree):
      * inspector/elements/delete-from-document-expected.txt: Added.
      * inspector/elements/delete-from-document.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21ca2f19
    • commit-queue@webkit.org's avatar
      Source/WebCore: [BlackBerry] Tab awareness for HTML5 concurrent audio · 1ed2613e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82930
      Support for concurrent HTML5 audio improvements being made in
      the platform library, which need to be aware of tabs and tab
      visibility. PR96004.
      
      Patch by Max Feil <mfeil@rim.com> on 2012-04-18
      Reviewed by George Staikos.
      
      Test: media/audio-concurrent-supported.html
      
      * platform/blackberry/PageClientBlackBerry.h:
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
      (WebCore::MediaPlayerPrivate::showErrorDialog):
      (WebCore::MediaPlayerPrivate::isTabVisible):
      (WebCore):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
      (MediaPlayerPrivate):
      
      Source/WebKit/blackberry: [BlackBerry] Tab awareness for HTML5 concurrent audio
      https://bugs.webkit.org/show_bug.cgi?id=82930
      Support for concurrent HTML5 audio improvements being made in
      the platform library, which need to be aware of tabs and tab
      visibility. PR96004.
      
      Patch by Max Feil <mfeil@rim.com> on 2012-04-18
      Reviewed by George Staikos.
      
      * Api/WebPageClient.h:
      * Api/WebPage_p.h:
      (BlackBerry::WebKit::WebPagePrivate::isVisible):
      
      LayoutTests: [BlackBerry] Tab awareness for HTML5 concurrent audio
      https://bugs.webkit.org/show_bug.cgi?id=82930
      Layout test for concurrent HTML5 audio. This is a simple test
      to confirm that multiple audio elements can play at the same time.
      
      Patch by Max Feil <mfeil@rim.com> on 2012-04-18
      Reviewed by George Staikos.
      
      * media/audio-concurrent-supported-expected.txt: Added.
      * media/audio-concurrent-supported.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ed2613e
    • kkristof@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening, skipping test that uses disabled feature SHADOW_DOM · a97b6fb9
      kkristof@inf.u-szeged.hu authored
      Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-18
      
      * platform/qt/Skipped: fast/dom/shadow/adopt-node-with-shadow-root.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a97b6fb9
    • noel.gordon@gmail.com's avatar
      [CG] ImageBuffer: check getPremultipliedImageData() error return · c9fedddb
      noel.gordon@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84022
      
      Reviewed by Eric Seidel.
      
      ImageBuffer::getPremultipliedImageData() can fail. toDataURL() should check for a
      failure return, and return "data:," if so.
      
      No new tests. Covered by existing toDataURL tests, in particular:
        canvas/philip/tests/toDataURL.jpeg.alpha.html
      
      * platform/graphics/cg/ImageBufferCG.cpp:
      (WebCore::ImageBuffer::toDataURL): Rename |arr| variable to premultipliedData and
      return "data:," if premultipliedData is empty. Clean up whitespace and a comment.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9fedddb
    • mario@webkit.org's avatar
      [GTK] atk/textChangedNotifications API test fails · 34bbd7a4
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84010
      
      Unreviewed, unskipping test after bug being fixed by r114311.
      
      * Scripts/run-gtk-tests:
      (TestRunner): Unskip now passing test.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34bbd7a4
    • commit-queue@webkit.org's avatar
      [BlackBerry] Viewport metatag doesn't disable double-tap zoom · a4014236
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84199
      
      Patch by Jacky Jiang <zhajiang@rim.com> on 2012-04-17
      Reviewed by George Staikos.
      
      Source/WebKit/blackberry:
      
      PR: 148279
      When we set "user-scalable=no" in viewport meta-tag and change any
      other WebSettings, the WebPage can turn to be scalable.
      This is a regression of the change master_32/SHA:fa0f8ee9. In that
      change, we used setUserScalable(webSettings->isUserScalable())
      in WebPagePrivate::didChangeSettings which was incorrect for non-DRT
      case, as webSettings->isUserScalable() would always return true by
      default.
      Create a new API WebPage::setUserScalable which will be used in
      DumpRenderTree.cpp.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPage::setUserScalable):
      (WebKit):
      (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
      * Api/WebPage.h:
      
      Tools:
      
      Revert a part of the change master_32/SHA:fa0f8ee9 and use
      WebPage::setUserScalable instead.
      
      * DumpRenderTree/blackberry/DumpRenderTree.cpp:
      (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4014236
    • commit-queue@webkit.org's avatar
      Skia OOM error when upscaling small subsets of images by large quantities · 5cffa9e8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84225
      
      Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
      Reviewed by David Levin.
      
      Tested with manual tests.
      
      * platform/graphics/skia/NativeImageSkia.cpp:
      (WebCore::NativeImageSkia::shouldCacheResampling):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cffa9e8
  2. 17 Apr, 2012 1 commit