1. 27 Aug, 2013 28 commits
    • commit-queue@webkit.org's avatar
      [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation · 018efa13
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119883
      
      Tools:
      
      Implemented the notification listener for AccessibilityUIElement. The signal is generated
      by AXObjectCache::postPlatformNotification() and received by axObjectEventListener().
      axObjectEventListener will then invoke JSObjectCallAsFunction() with the respective
      callback function. The global callback function and callbacks for specific elements are
      stored in a HashMap in AccessibilityCallbacksAtk.cpp.
      
      Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-08-27
      Reviewed by Chris Fleizach.
      
      * DumpRenderTree/AccessibilityUIElement.h: Added a notification handler for GTK+
      * DumpRenderTree/atk/AccessibilityCallbacks.h: Added addAccessibilityNotificationListener()
      and removeAccessibilityNotificationListener()
      * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
      (axObjectEventListener): Call JS callback for global notification or for a specific element
      (disconnectAccessibilityCallbacks): Only disconnect if logging is off and there is no
      notification handler
      (addAccessibilityNotificationHandler): Add notification listener to the list
      (removeAccessibilityNotificationHandler): Remove notification listener from the list
      * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
      (AccessibilityController::setLogAccessibilityEvents): Set logging off before disconnecting
      * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
      (AccessibilityNotificationHandler::AccessibilityNotificationHandler): Create handler
      (AccessibilityNotificationHandler::~AccessibilityNotificationHandler): Destroy handler.
      Remove handler from the list and disconnect callbacks
      (AccessibilityNotificationHandler::setNotificationFunctionCallback): Set the notification
      callback and connect callbacks to signals
      * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Added.
      (AccessibilityNotificationHandler::setPlatformElement): Set platform element
      (AccessibilityNotificationHandler::platformElement): Get platform element
      (AccessibilityNotificationHandler::notificationFunctionCallback): Get notification callback
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (AccessibilityUIElement::addNotificationListener): Create notification handler, set the
      platform element and the notification callback
      (AccessibilityUIElement::removeNotificationListener):
      * DumpRenderTree/efl/CMakeLists.txt: Added AccessibilityNotificationHandlerAtk.cpp/h
      * GNUmakefile.am: Added AccessibilityNotificationHandlerAtk.cpp/h
      
      LayoutTests:
      
      Unskipped the checkbox notification test in a11y and added the expected results.
      
      Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-08-27
      Reviewed by Chris Fleizach.
      
      * platform/gtk/TestExpectations: Unskipped the checkbox notification test in a11y.
      * platform/gtk/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      018efa13
    • bfulgham@apple.com's avatar
      [Windows] Correct method call for characteristic update. · ba1f6989
      bfulgham@apple.com authored
      Reviewed by Eric Carlson.
      
      * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
      (WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
      [Windows] Correct method call (should have been "characteristicsChanged", not
      "player()->characteristicChanged()"
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba1f6989
    • bfulgham@apple.com's avatar
      [Windows] some track language tags are not recognized · 3cdc77bf
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120335
      
      Reviewed by Eric Carlson.
      
      * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Revise implementation
      to match logic in platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjc.mm
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cdc77bf
    • akling@apple.com's avatar
      Clumsily fix Gtk+ build. Not my proudest moment. · 39206f75
      akling@apple.com authored
      * rendering/svg/RenderSVGResourceFilter.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39206f75
    • akling@apple.com's avatar
      Fix Qt build. · 4cb13f39
      akling@apple.com authored
      * rendering/svg/RenderSVGResourceFilter.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cb13f39
    • akling@apple.com's avatar
      RenderView::availableLogicalHeight() should be self-contained. · 71dd4b2a
      akling@apple.com authored
      <https://webkit.org/b/120356>
      
      Reviewed by Antti Koivisto.
      
      Instead of checking isRenderView() in RenderBox::availableLogicalHeightUsing()
      and doing an early return, do everything needed without leaving RenderView instead.
      Document style never has min-/max-height so there's no need to apply constraints.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::availableLogicalHeightUsing):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::availableLogicalHeight):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71dd4b2a
    • akling@apple.com's avatar
      Simplify some more Settings access where we have a Frame in reach. · 300a8929
      akling@apple.com authored
      <https://webkit.org/b/120256>
      
      Reviewed by Darin Adler.
      
      RenderObjects can always find Settings through the Frame.
      
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paint):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      * rendering/svg/RenderSVGResourceFilter.cpp:
      (WebCore::RenderSVGResourceFilter::applyResource):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      300a8929
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Delete unnecessary empty directory. · 7b9e3522
      kadam@inf.u-szeged.hu authored
      Unreviewed gardening.
      
      * platform/qt-5.0-wk2/tables: Removed.
      * platform/qt-5.0-wk2/tables/layering: Removed.
      * platform/qt-5.0-wk2/tables/mozilla: Removed.
      * platform/qt-5.0-wk2/tables/mozilla/bugs: Removed.
      * platform/qt-5.0-wk2/tables/mozilla/collapsing_borders: Removed.
      * platform/qt-5.0-wk2/tables/mozilla/core: Removed.
      * platform/qt-5.0-wk2/tables/mozilla/dom: Removed.
      * platform/qt-5.0-wk2/tables/mozilla/marvin: Removed.
      * platform/qt-5.0-wk2/tables/mozilla/other: Removed.
      * platform/qt-5.0-wk2/tables/mozilla_expected_failures: Removed.
      * platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs: Removed.
      * platform/qt-5.0-wk2/tables/mozilla_expected_failures/collapsing_borders: Removed.
      * platform/qt-5.0-wk2/tables/mozilla_expected_failures/core: Removed.
      * platform/qt-5.0-wk2/tables/mozilla_expected_failures/dom: Removed.
      * platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin: Removed.
      * platform/qt-5.0-wk2/tables/mozilla_expected_failures/other: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b9e3522
    • akling@apple.com's avatar
      RenderView::flowThreadController() should return a reference. · ad1a31b9
      akling@apple.com authored
      <https://webkit.org/b/120363>
      
      Reviewed by Antti Koivisto.
      
      This function does lazy construction and always returns an object.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad1a31b9
    • akling@apple.com's avatar
      HTMLAppletElement: Use child iterator to walk <param> children. · f343e23a
      akling@apple.com authored
      <https://webkit.org/b/120361>
      
      Reviewed by Antti Koivisto.
      
      Take Antti's fancy new child iterator for a quick spin.
      
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::updateWidget):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f343e23a
    • commit-queue@webkit.org's avatar
      [EFL] Added new accessibility expectations after r154332 · 5d00ef30
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120359
      
      Unreviewed EFL gardening.
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-08-27
      
      * platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt: Added.
      * platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d00ef30
    • commit-queue@webkit.org's avatar
      [gstreamer] Make sure gstreamer source element is thread-safe · 069420f5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115352
      
      Patch by Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk> on 2013-08-27
      Reviewed by Philippe Normand.
      
      Source/WebCore:
      
      GStreamer source element may be created by any gstreamer element on any thread by calling
      gst_element_make_from_uri with the URIs handled by the source element.
      This patch makes sure the gstreamer source element is thread-safe to avoid issues with it
      being created outside the main thread.
      
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      (webkit_web_src_init):
      (webKitWebSrcDispose):
      (webKitWebSrcFinalize):
      (webKitWebSrcSetProperty):
      (webKitWebSrcGetProperty):
      (removeTimeoutSources):
      (webKitWebSrcStop):
      (webKitWebSrcStart):
      (webKitWebSrcChangeState):
      (webKitWebSrcQueryWithParent):
      (webKitWebSrcGetUri):
      (webKitWebSrcSetUri):
      (webKitWebSrcNeedDataMainCb):
      (webKitWebSrcNeedDataCb):
      (webKitWebSrcEnoughDataMainCb):
      (webKitWebSrcEnoughDataCb):
      (webKitWebSrcSeekMainCb):
      (webKitWebSrcSeekDataCb):
      (webKitWebSrcSetMediaPlayer):
      (StreamingClient::StreamingClient):
      (StreamingClient::~StreamingClient):
      (StreamingClient::createReadBuffer):
      (StreamingClient::handleResponseReceived):
      (StreamingClient::handleDataReceived):
      (StreamingClient::handleNotifyFinished):
      (CachedResourceStreamingClient::CachedResourceStreamingClient):
      (CachedResourceStreamingClient::~CachedResourceStreamingClient):
      (CachedResourceStreamingClient::loadFailed):
      (CachedResourceStreamingClient::setDefersLoading):
      (CachedResourceStreamingClient::getOrCreateReadBuffer):
      (CachedResourceStreamingClient::responseReceived):
      (CachedResourceStreamingClient::dataReceived):
      (CachedResourceStreamingClient::notifyFinished):
      (ResourceHandleStreamingClient::ResourceHandleStreamingClient):
      (ResourceHandleStreamingClient::~ResourceHandleStreamingClient):
      (ResourceHandleStreamingClient::loadFailed):
      (ResourceHandleStreamingClient::setDefersLoading):
      (ResourceHandleStreamingClient::getOrCreateReadBuffer):
      (ResourceHandleStreamingClient::willSendRequest):
      (ResourceHandleStreamingClient::didReceiveResponse):
      (ResourceHandleStreamingClient::didReceiveData):
      (ResourceHandleStreamingClient::didFinishLoading):
      (ResourceHandleStreamingClient::didFail):
      (ResourceHandleStreamingClient::wasBlocked):
      (ResourceHandleStreamingClient::cannotShowURL):
      Make element thread-safe, add support to use the element without a player associated (e.g.
      the DASH plugin using the webkitsrc to download fragments), use GMutexLocker to simplify
      locks and other general improvements.
      
      Source/WTF:
      
      Add convenience class that simplifies locking and unlocking a GMutex.
      
      * GNUmakefile.list.am:
      * wtf/gobject/GMutexLocker.h: Added.
      (WebCore::GMutexLocker::GMutexLocker):
      (WebCore::GMutexLocker::~GMutexLocker):
      (WebCore::GMutexLocker::lock):
      (WebCore::GMutexLocker::unlock):
      (WebCore::GMutexLocker::mutex):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      069420f5
    • antti@apple.com's avatar
      Remove branch from DescendantIteratorAdapter::begin() when invoking for ContainerNode · 4e851ef4
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120358
      
      Reviewed by Andreas Kling.
      
      * dom/ContainerNode.h:
              
          Delete isContainerNode() so it can't be called if there is static knowledge that the object is a ContainerNode.
      
      * dom/DescendantIterator.h:
      (WebCore::::DescendantIterator):
      
          Make DescendantIterator use Node* as root instead of ContainerNode*. It is only used for equality comparison.
      
      (WebCore::::begin):
              
          Remove branch. Rely on ElementTraversal specialization for ContainerNodes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e851ef4
    • commit-queue@webkit.org's avatar
      Web Inspector: Column Breakpoint not working, may be off by 1 · 979f0e61
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120334
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-08-27
      Reviewed by David Kilzer.
      
      Source/WebCore:
      
      JavaScriptCore changed to 1-based column numbers at some point. We
      need to update the ScriptDebugger assumption that they were 0-based.
      
      Test: inspector-protocol/debugger/column-breakpoint.html
      
      * bindings/js/ScriptDebugServer.cpp:
      (WebCore::ScriptDebugServer::createCallFrame):
      (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
      
      LayoutTests:
      
      Write a protocol test for setting a breakpoint at a line:column.
      
      * inspector-protocol/debugger/column-breakpoint-expected.txt: Added.
      * inspector-protocol/debugger/column-breakpoint.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      979f0e61
    • commit-queue@webkit.org's avatar
      [EFL] Added new accessibility expectations after r153798. · fae8c8a4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120354
      
      Unreviewed EFL gardening.
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-08-27
      
      * platform/efl-wk1/accessibility/image-link-expected.txt: Added.
      * platform/efl-wk1/accessibility/image-map2-expected.txt: Added.
      * platform/efl-wk1/accessibility/table-cell-spans-expected.txt: Added.
      * platform/efl-wk1/accessibility/table-cells-expected.txt: Added.
      * platform/efl-wk2/accessibility/image-link-expected.txt: Added.
      * platform/efl-wk2/accessibility/image-map2-expected.txt: Added.
      * platform/efl-wk2/accessibility/table-cell-spans-expected.txt:
      * platform/efl-wk2/accessibility/table-cells-expected.txt:
      * platform/efl/TestExpectations:
      * platform/efl/accessibility/image-link-expected.txt: Removed.
      * platform/efl/accessibility/image-map2-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fae8c8a4
    • antti@apple.com's avatar
      Switch some more code to element child/descendant iterators · 39d6d4a6
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120355
      
      Reviewed by Andreas Kling.
      
      Move from Traversal<ElementType>::next() and Traversal<ElementType>::nextSibling() to iterators.
      
      * css/CSSFontFaceSource.cpp:
      (WebCore::CSSFontFaceSource::getFontData):
      * dom/Document.cpp:
      (WebCore::Document::removeTitle):
      (WebCore::Document::updateBaseURL):
      (WebCore::Document::processBaseElement):
      * dom/TreeScope.cpp:
      (WebCore::TreeScope::labelElementForId):
      (WebCore::TreeScope::findAnchor):
      * html/HTMLFieldSetElement.cpp:
      (WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
      (WebCore::HTMLFieldSetElement::childrenChanged):
      * html/HTMLLabelElement.cpp:
      (WebCore::HTMLLabelElement::control):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::parametersForPlugin):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::buildReferenceFilter):
      * svg/SVGFilterPrimitiveStandardAttributes.h:
      (WebCore::isSVGFilterPrimitiveStandardAttributes):
      (WebCore::SVGFilterPrimitiveStandardAttributes):
      * svg/animation/SMILTimeContainer.cpp:
      (WebCore::SMILTimeContainer::updateDocumentOrderIndexes):
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::hasSingleSecurityOrigin):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39d6d4a6
    • akling@apple.com's avatar
      FocusController::focusedOrMainFrame() should return a reference. · ef7cefa6
      akling@apple.com authored
      <https://webkit.org/b/120339>
      
      Reviewed by Antti Koivisto.
      
      Now that Page::mainFrame() returns a reference, we can make this return a reference
      too, since there's always either a focused or a main frame.
      
      One hectogram of null checks removed as a result.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef7cefa6
    • kov@webkit.org's avatar
      [l10n] Updated Polish translation of WebKitGTK+ · a5dea8b3
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119986
      
      Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-08-27
      Reviewed by Gustavo Noronha Silva.
      
      * pl.po: updated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5dea8b3
    • akling@apple.com's avatar
      Document's renderer is always a RenderView. · fa64c887
      akling@apple.com authored
      <https://webkit.org/b/120304>
      
      Reviewed by Darin Adler.
      
      Let's enforce this better by storing a RenderView* instead of a plain RenderObject*.
      We should switch callers that grab at Document::renderer() to calling renderView()
      instead, but that's better done separately.
      
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::~Document):
      (WebCore::Document::setRenderView):
      (WebCore::Document::createRenderTree):
      (WebCore::Document::detach):
      (WebCore::Document::setInPageCache):
      * dom/Document.h:
      (WebCore::Document::renderView):
      (WebCore::Document::renderer):
      * html/parser/HTMLResourcePreloader.cpp:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::setStyle):
      * rendering/RenderView.h:
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::updateCurrentTranslate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa64c887
    • g.czajkowski@samsung.com's avatar
      grammar-markers.html and grammar-markers-hidpi.html pass even if element does... · d2a110f7
      g.czajkowski@samsung.com authored
      grammar-markers.html and grammar-markers-hidpi.html pass even if element does not have grammar marker
      https://bugs.webkit.org/show_bug.cgi?id=119797
      
      Reviewed by Ryosuke Niwa.
      
      After tenth attempts of verifying the grammar marker, the tests call'notifyDone'
      even if grammar marker was not be found.
      
      Both grammar-marker.html and grammar-marker-hidpi.html call the text checker
      asynchronously. Therefore, we need to wait until either the grammar marker
      is found or number of attempts is reached.
      
      Dump more information whether the grammar marker was found to be sure that
      the tests do not pass when the element does not have the marker.
      
      * editing/spelling/grammar-markers-expected.txt:
      * editing/spelling/grammar-markers-hidpi-expected.txt:
      Update the expectations.
      
      * editing/spelling/grammar-markers-hidpi.html:
      * editing/spelling/grammar-markers.html:
      Dump more information.
      Additionally, pass 'document' to hasGrammarMarker instead of
      'target' as the method does not work for target/source elements.
      
      * platform/mac/editing/spelling/grammar-markers-expected.png:
      * platform/mac/editing/spelling/grammar-markers-hidpi-expected.png: Added.
      Update the expectations for Mac.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2a110f7
    • allan.jensen@digia.com's avatar
      Font's fast code path doesn't handle partial runs correctly when kerning or ligatures are enabled · 5fb0af8e
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100050
      
      Reviewed by Darin Adler.
      
      Renamed m_characterIndex to m_characterIndexOfGlyph and gave it an inline size of 10,
      which covers around 66% of all cases. The rest of the cases are now preallocated to the
      upper limit which is length of the original TextRun.
      
      * platform/graphics/FontFastPath.cpp:
      (WebCore::Font::getGlyphsAndAdvancesForSimpleText):
      (WebCore::Font::selectionRectForSimpleText):
      (WebCore::Font::offsetForPositionForSimpleText):
      * platform/graphics/WidthIterator.cpp:
      (WebCore::WidthIterator::WidthIterator):
      (WebCore::WidthIterator::advanceInternal):
      * platform/graphics/WidthIterator.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fb0af8e
    • ch.dumez@sisa.samsung.com's avatar
      Implement DOM3 wheel event · 181483e1
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=94081
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Add support for DOM Level 3 WheelEvent:
      http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent
      
      Firefox, IE10 and since recently Blink already support it so
      it increases our cross-browser compatibility.
      
      The non-standard 'mousewheel' event is still supported for backward
      compatibility. Note that the deltas returned by the mousewheel and
      the wheel events are not identical:
      - They have opposite signs.
      - The wheel event reports the actual amount of pixels that should be
      scrolled while the legacy mousewheel event reports a factor of the
      number of mouse wheel ticks (using a constant multiplier).
      
      Tests: fast/events/wheelevent-basic.html
             fast/events/wheelevent-constructor.html
             fast/events/wheelevent-mousewheel-interaction.html
      
      * dom/Document.h:
      * dom/Document.idl:
      * dom/Element.h:
      * dom/Element.idl:
      * dom/EventNames.h:
      * dom/EventTarget.cpp:
      (WebCore::legacyType):
      (WebCore::EventTarget::shouldObserveLegacyType):
      (WebCore::EventTarget::setupLegacyTypeObserverIfNeeded):
      (WebCore::EventTarget::fireEventListeners):
      * dom/EventTarget.h:
      * dom/Node.cpp:
      (WebCore::Node::didMoveToNewDocument):
      (WebCore::tryAddEventListener):
      (WebCore::tryRemoveEventListener):
      (WebCore::Node::defaultEventHandler):
      * dom/WheelEvent.cpp:
      (WebCore::WheelEventInit::WheelEventInit):
      (WebCore::WheelEvent::WheelEvent):
      (WebCore::WheelEvent::initWheelEvent):
      * dom/WheelEvent.h:
      (WebCore::WheelEvent::deltaX):
      (WebCore::WheelEvent::deltaY):
      (WebCore::WheelEvent::deltaZ):
      (WebCore::WheelEvent::wheelDelta):
      (WebCore::WheelEvent::wheelDeltaX):
      (WebCore::WheelEvent::wheelDeltaY):
      * dom/WheelEvent.idl:
      * html/HTMLAttributeNames.in:
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::eventNameForAttributeName):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::addEventListener):
      (WebCore::DOMWindow::removeEventListener):
      * page/DOMWindow.h:
      * page/DOMWindow.idl:
      * page/EventHandler.cpp:
      (WebCore::EventHandler::defaultWheelEventHandler):
      * plugins/blackberry/PluginViewBlackBerry.cpp:
      (WebCore::PluginView::handleWheelEvent):
      * svg/SVGElementInstance.cpp:
      * svg/SVGElementInstance.h:
      * svg/SVGElementInstance.idl:
      
      LayoutTests:
      
      Add several layout tests to check support for DOM3 wheel event.
      
      * fast/events/wheelevent-basic-expected.txt: Added.
      * fast/events/wheelevent-basic.html: Added.
      * fast/events/wheelevent-constructor-expected.txt: Added.
      * fast/events/wheelevent-constructor.html: Added.
      * fast/events/wheelevent-mousewheel-interaction-expected.txt: Added.
      * fast/events/wheelevent-mousewheel-interaction.html: Added.
      * platform/efl/fast/events/wheelevent-basic-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      181483e1
    • allan.jensen@digia.com's avatar
      Assertion while scrolling news.google.com · e57434c7
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115303
      
      Reviewed by Anders Carlsson.
      
      Do not relayout when accessing script elements during painting.
      
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::renderWidgetForJSBindings):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e57434c7
    • hausmann@webkit.org's avatar
      [Qt] Let Page create the main Frame. · 754dada6
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120349
      
      Adjust to latest changes in WebCore::Page to create the main frame.
      
      Patch by Arunprasad Rajkumar <arurajku@cisco.com> on 2013-08-27
      Reviewed by Simon Hausmann.
      
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameData::QWebFrameData):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::initializeWebCorePage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      754dada6
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix GTK+ build after r154601. · b9bb159e
      carlosgc@webkit.org authored
      * TestWebKitAPI/GNUmakefile.am: Remove mac specific file from
      compilation added by mistake in r154601.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9bb159e
    • benjamin@webkit.org's avatar
      Remove DOMSettableTokenList's overload of add() and remove() · a52d31f9
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120341
      
      Reviewed by Ryosuke Niwa.
      
      Little refactoring to make other cleanups easier. Instead of modifying
      SpaceSplitString directly, rely on DOMTokenList ultimately changing
      the value, which in turn updates the tokens.
      
      * html/DOMSettableTokenList.cpp:
      * html/DOMSettableTokenList.h:
      * html/DOMTokenList.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a52d31f9
    • calvaris@igalia.com's avatar
      [GTK] Volume slider shows incorrect track when muted · d4c93624
      calvaris@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120253
      
      Reviewed by Philippe Normand.
      
      When painting the volume bar, consider that it could be muted even
      then volume is different than zero.
      
      * platform/gtk/RenderThemeGtk.cpp:
      (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Asign
      painted volume as 0 when media is muted.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4c93624
    • zandobersek@gmail.com's avatar
      Unreviewed GTK build fix. · 5fec8e3d
      zandobersek@gmail.com authored
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::FrameLoaderClient): Remove an assertion that was not removed in r154658.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fec8e3d
  2. 26 Aug, 2013 12 commits