1. 23 Jan, 2012 23 commits
    • hayato@chromium.org's avatar
      Fix crash when a focused node is removed while in processing focusin event. · 0159d533
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76656
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      Test: fast/events/focus-remove-focuesed-node.html
      
      * dom/Document.cpp:
      (WebCore::Document::setFocusedNode):
      
      LayoutTests:
      
      * fast/events/focus-remove-focuesed-node-expected.txt: Added.
      * fast/events/focus-remove-focuesed-node.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0159d533
    • scherkus@chromium.org's avatar
      Switch media/audio-data-url.html layout test to base64-encoded WAV data. · 52410747
      scherkus@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76759
      
      Reviewed by Eric Carlson.
      
      * media/audio-data-url-expected.txt:
      * media/audio-data-url.html:
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52410747
    • rniwa@webkit.org's avatar
      REGRESSION(r105396): drag state is not cleared after each drag · d22c03e2
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76878
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore: 
      
      Revert a part of r105396 that made performDragAndDrop not call clearDragState
      when the default action was not prevented since it caused a regression.
      
      I'm pretty certain always calling clearDragState in performDragAndDrop is wrong
      but I can't think of a test case where this becomes a problem at the moment.
      Since this area is not well tested, revert the change instead of making further
      changes to the code base.
      
      Tests: fast/events/clear-drag-state.html
             fast/events/clear-edit-drag-state.html
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::performDragAndDrop):
      
      LayoutTests: 
      
      Add a regression test to ensure we don't fire extra dragenter event
      on the second drag at an element that contains the dragged content.
      
      * fast/events/clear-drag-state-expected.txt: Added.
      * fast/events/clear-drag-state.html: Added.
      * fast/events/clear-edit-drag-state-expected.txt: Added.
      * fast/events/clear-edit-drag-state.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d22c03e2
    • commit-queue@webkit.org's avatar
      Reduce throttling on video-buffering-repaints-controls test to prevent timeout. · 4de9c3dd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76113
      
      Also reduces flakiness by checking for a repaint between progress and
      suspend events versus just between progress events.
      
      Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-23
      Reviewed by Adam Barth.
      
      * http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
      * http/tests/media/video-buffering-repaints-controls.html:
      * platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png:
      * platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
      * platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
      * platform/chromium/test_expectations.txt:
      * platform/gtk/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4de9c3dd
    • commit-queue@webkit.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=75799 · 5f5c5f30
      commit-queue@webkit.org authored
      Calling intersectsNode on a detached range should throw.
      
      Source/WebCore:
      
      INVALID_STATE_ERR exception should be thrown if intersectsNode is called on a detached Range.
      
      Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
      Reviewed by Darin Adler.
      
      Test: fast/dom/Range/range-intersectsNode-exception.html
      
      * dom/Range.cpp:
      (WebCore::Range::intersectsNode): Throwing INVALID_STATE_ERR exception if the range is detached.
      
      LayoutTests:
      
      Added test case to verify the exception thrown while calling intersectsNode on a detached range.
      
      Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
      Reviewed by Darin Adler.
      
      * fast/dom/Range/range-intersectsNode-exception-expected.txt: Added.
      * fast/dom/Range/range-intersectsNode-exception.html: Added.
      * fast/dom/Range/range-intersectsNode-expected.txt:
      * fast/dom/Range/resources/intersectsNode.js:  Modified the test case to catch the exception.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f5c5f30
    • mikelawther@chromium.org's avatar
      getComputedStyle margin percentage test for CSS calc · 26421928
      mikelawther@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76130
      
      Reviewed by Darin Adler.
      
      Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
      
      These tests are expected to 'fail', and will pass once calc() functionality is landed.
      For now, they serve to demonstrate that the current code doesn't crash on these tests.
      
      * css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
      * css3/calc/getComputedStyle-margin-percentage.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26421928
    • abarth@webkit.org's avatar
      Update the baselines for a number of tests that use gradients. The new · ee769d43
      abarth@webkit.org authored
      results are just slightly different than the old results.
      
      * fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
      * fast/gradients/border-image-gradient-expected.txt: Added.
      * fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Added.
      * platform/chromium-linux-x86/fast/gradients: Removed.
      * platform/chromium-linux/fast/canvas/fillrect_gradient-expected.png:
      * platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
      * platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
      * platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
      * platform/chromium-linux/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
      * platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Removed.
      * platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png:
      * platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
      * platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
      * platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
      * platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
      * platform/chromium-mac-leopard/fast/canvas/fillrect_gradient-expected.png:
      * platform/chromium-mac-leopard/fast/gradients/generated-gradients-expected.png:
      * platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
      * platform/chromium-mac-snowleopard/fast/canvas/fillrect_gradient-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement: Added.
      * platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png:
      * platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added.
      * platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-2-expected.png:
      * platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-expected.png: Added.
      * platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
      * platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
      * platform/chromium-mac/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
      * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
      * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/chromium-mac/fast/gradients/border-image-gradient-expected.png: Removed.
      * platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
      * platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png: Removed.
      * platform/chromium-mac/fast/gradients/generated-gradients-expected.png: Removed.
      * platform/chromium-mac/fast/gradients/simple-gradients-expected.png: Removed.
      * platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Removed.
      * platform/chromium-mac/svg/filters/big-sized-filter-expected.png: Removed.
      * platform/chromium-win-vista/fast/gradients: Removed.
      * platform/chromium-win-xp/svg/as-background-image: Removed.
      * platform/chromium-win/fast/canvas/fillrect_gradient-expected.png:
      * platform/chromium-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png:
      * platform/chromium-win/fast/gradients/border-image-gradient-expected.png:
      * platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
      * platform/chromium-win/fast/gradients/css3-color-stops-expected.png:
      * platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png:
      * platform/chromium-win/fast/gradients/generated-gradients-expected.png:
      * platform/chromium-win/fast/gradients/simple-gradients-expected.png:
      * platform/chromium-win/fast/reflections/reflection-masks-expected.png:
      * platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
      * platform/chromium-win/svg/filters/big-sized-filter-expected.png:
      * platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
      * platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
      * platform/gtk/fast/gradients/border-image-gradient-expected.txt: Removed.
      * platform/gtk/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
      * platform/mac/fast/gradients/border-image-gradient-expected.txt: Removed.
      * platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
      * platform/qt/fast/gradients/border-image-gradient-expected.txt: Removed.
      * platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee769d43
    • philn@webkit.org's avatar
      Unreviewed, unskip now passing tests on GTK. Spotted by Zan Dobersek. · 28cbe9ee
      philn@webkit.org authored
      * platform/gtk/Skipped: Unskip tests 5 tests using ArrayBuffer
      which is no longer tied to 3D_CANVAS.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28cbe9ee
    • philn@webkit.org's avatar
      Unreviewed, mark another test as flaky crash. · dd959658
      philn@webkit.org authored
      * platform/gtk/test_expectations.txt:
      editing/execCommand/19455.html is flaky, sometimes hitting an ASSERT.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd959658
    • philn@webkit.org's avatar
      Unreviewed, GTK gardening. Rebaseline after r105613, marked 3 svg · b6fe8cbe
      philn@webkit.org authored
      flaky tests and added baselines for 15 tests.
      
      * platform/gtk/css3/images/cross-fade-background-size-expected.txt: Added.
      * platform/gtk/fast/backgrounds/mask-box-image-expected.txt: Added.
      * platform/gtk/fast/borders/scaled-border-image-expected.txt: Added.
      * platform/gtk/fast/css/text-overflow-input-expected.txt: Added.
      * platform/gtk/fast/line-grid/line-grid-floating-expected.txt: Added.
      * platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
      * platform/gtk/fast/line-grid/line-grid-into-floats-expected.txt: Added.
      * platform/gtk/fast/line-grid/line-grid-positioned-expected.txt: Added.
      * platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
      * platform/gtk/svg/custom/relative-sized-image-expected.txt: Added.
      * platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt: Added.
      * platform/gtk/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
      * platform/gtk/svg/text/append-text-node-to-tspan-expected.txt: Added.
      * platform/gtk/svg/text/modify-text-node-in-tspan-expected.txt: Added.
      * platform/gtk/svg/text/remove-text-node-from-tspan-expected.txt: Added.
      * platform/gtk/svg/text/remove-tspan-from-text-expected.txt: Added.
      * platform/gtk/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6fe8cbe
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening after r105613. · 8e6c1b2c
      ossy@webkit.org authored
      * platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Updated.
      * platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Updated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e6c1b2c
    • pfeldman@chromium.org's avatar
      Web Inspector: Inspecting an element inside an iframe no longer works · 80167912
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76808
      
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      Test: http/tests/inspector/inspect-element.html
      
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::innerParentNode):
      * inspector/front-end/DOMAgent.js:
      (WebInspector.DOMNode.prototype.getChildNodes.mycallback):
      (WebInspector.DOMNode.prototype.getChildNodes):
      (WebInspector.DOMNode.prototype._setChildrenPayload):
      * inspector/front-end/ElementsTreeOutline.js:
      (WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged):
      
      LayoutTests:
      
      * http/tests/inspector/inspect-element-expected.txt: Added.
      * http/tests/inspector/inspect-element.html: Added.
      * http/tests/inspector/resources/inspect-element-iframe.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80167912
    • antonm@chromium.org's avatar
      Unreviewed tweaking of test expectations: it should be IMAGE instead of IMAGE+TEXT. · 45e09340
      antonm@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45e09340
    • antonm@chromium.org's avatar
      Unreviewed rebaseline after r105613 (SVG animation repaint issue...). · 4bb94b2e
      antonm@chromium.org authored
      * platform/chromium-mac-leopard/svg/custom/relative-sized-image-expected.png: Added.
      * platform/chromium-mac-snowleopard/svg/custom/relative-sized-image-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bb94b2e
    • zimmermann@webkit.org's avatar
      SVG animation repaint issue with image and dynamic clipPath · 6ec5f2fb
      zimmermann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76559
      
      Reviewed by Zoltan Herczeg.
      
      Source/WebCore:
      
      Based on patch by Kelly Norton <knorton@google.com>. I extended the patch
      to correctly handle relative length resolution as well.
      
      RenderSVGImage doesn't react on setNeedsBoundariesUpdate() calls
      and thus fails to update its boundaries in some cases.
      
      The logic is also inconsistent, compared to the other renderers.
      Fix that properly, by reusing the method used in RenderSVGViewportContainer.
      Call calculateImageViewport() immediately, after initializing the LayoutRepainter.
      Previously we resolved the image viewport in RenderSVGImage::updateFromElement. This is
      wrong, as it queries the frameRect() of the RenderSVGRoot in a state, where the renderer
      still needs layout, leading to wrong results.
      
      I turned Kellys manual testcase into a predictable test, see svg/repaint/image-with-clip-path.svg
      Relative sized image handling is tested in svg/custom/relative-sized-image.xhtml now.
      
      Tests: svg/custom/relative-sized-image.xhtml
             svg/repaint/image-with-clip-path.svg
      
      * rendering/svg/RenderSVGImage.cpp:
      (WebCore::RenderSVGImage::RenderSVGImage):
      (WebCore::RenderSVGImage::updateImageViewport):
      (WebCore::RenderSVGImage::layout):
      * rendering/svg/RenderSVGImage.h:
      (WebCore::RenderSVGImage::setNeedsBoundariesUpdate):
      * svg/SVGImageElement.cpp:
      (WebCore::SVGImageElement::svgAttributeChanged):
      
      LayoutTests:
      
      Update results after fixing RenderSVGImage repainting.
      
      * platform/chromium-win/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
      * platform/chromium/test_expectations.txt:
      * platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
      * platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
      * platform/mac/svg/custom/relative-sized-image-expected.png: Added.
      * platform/mac/svg/custom/relative-sized-image-expected.txt: Added.
      * platform/mac/svg/repaint/image-with-clip-path-expected.png: Added.
      * svg/custom/relative-sized-image.xhtml: Added.
      * svg/repaint/image-with-clip-path-expected.txt: Added.
      * svg/repaint/image-with-clip-path.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ec5f2fb
    • zimmermann@webkit.org's avatar
      <feImage> has problems referencing local elements · cf042420
      zimmermann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76800
      
      Reviewed by Zoltan Herczeg.
      
      Source/WebCore:
      
      <feImage> referencing local elements are currently rendered into an ImageBuffer
      by SVGFEImageElement, using the local coordinates of the referenced renderer.
      
      This approach is buggy and should be avoided, by moving the rendering fully
      into SVGFEImage, which takes care of respecting the correct transformations.
      
      This fixes <feImage> + local references, which currently breaks two tests in trunk.
      Covered by existing tests.
      
      * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
      (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
      * svg/SVGFEImageElement.cpp:
      (WebCore::SVGFEImageElement::build):
      * svg/graphics/filters/SVGFEImage.cpp:
      (WebCore::FEImage::FEImage):
      (WebCore::FEImage::createWithImage):
      (WebCore::FEImage::createWithIRIReference):
      (WebCore::FEImage::determineAbsolutePaintRect):
      (WebCore::FEImage::referencedRenderer):
      (WebCore::FEImage::platformApplySoftware):
      (WebCore::FEImage::externalRepresentation):
      * svg/graphics/filters/SVGFEImage.h:
      (WebCore::FEImage::~FEImage):
      * svg/graphics/filters/SVGFilter.h:
      (WebCore::SVGFilter::absoluteTransform):
      
      LayoutTests:
      
      Update svg/filters/feImage-reference-* results, which are fixed now.
      
      * platform/chromium/test_expectations.txt : Updated.
      * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Update for marginal change.
      * svg/filters/feImage-reference-invalidation-expected.png:
      * svg/filters/feImage-reference-svg-primitive-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf042420
    • ossy@webkit.org's avatar
      WebKit fails IETC composition event types · 500ff25a
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76690
      
      Unreviewed gardening after r105605.
      
      * fast/events/ime-composition-events-001-expected.txt: Updated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      500ff25a
    • bashi@chromium.org's avatar
    • caseq@chromium.org's avatar
      Unreviewed follow-up to r105596, added missing test resources. · 072b921d
      caseq@chromium.org authored
      * http/tests/inspector/resources/har-pages-iframe.html: Added.
      * http/tests/inspector/resources/har-pages-navigation-target.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      072b921d
    • philn@webkit.org's avatar
      Unreviewed, GTK rebaseline after r101742. · 78e4c0f9
      philn@webkit.org authored
      * platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
      * platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
      * platform/gtk/fast/forms/placeholder-position-expected.txt:
      * platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
      * platform/gtk/fast/forms/search-styled-expected.txt:
      * platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
      * platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
      * platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78e4c0f9
    • philn@webkit.org's avatar
      Unreviewed, GTK gardening, marked 2 tests as flaky on Debug and · e2d4ff47
      philn@webkit.org authored
      unskipped another needing new baselines.
      
      * platform/gtk/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2d4ff47
    • caseq@chromium.org's avatar
      Web Inspector: HAR pageref attributes are wrong and inconsistent with pages array · cb63aefe
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76398
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      - introduce a notion of LoadPage;
      - move page load times to LoadPage;
      - associate network resources with LoadPage;
      - export pages for all available resoruces to HAR, not just the last page;
      - use page ids, not document URLs in HAR entries to refer to pages;
      - use page URL as a title field of a HAR page;
      
      * inspector/front-end/AuditsPanel.js:
      (WebInspector.AuditsPanel):
      * inspector/front-end/HAREntry.js:
      (WebInspector.HAREntry.prototype.build):
      (WebInspector.HAREntry.prototype.get responseCompression):
      (WebInspector.HARLog.prototype._buildPages):
      (WebInspector.HARLog.prototype._convertPage):
      (WebInspector.HARLog.prototype._pageEventTime):
      * inspector/front-end/NetworkLog.js:
      (WebInspector.NetworkLog):
      (WebInspector.NetworkLog.prototype._mainFrameNavigated):
      (WebInspector.NetworkLog.prototype._onResourceStarted):
      (WebInspector.Page):
      (WebInspector.Page.prototype.get id):
      (WebInspector.Page.prototype.get url):
      (WebInspector.Page.prototype.get contentLoadTime):
      (WebInspector.Page.prototype.set contentLoadTime):
      (WebInspector.Page.prototype.get loadTime):
      (WebInspector.Page.prototype.set loadTime):
      (WebInspector.Page.prototype.get startTime):
      (WebInspector.Page.prototype._bindResource):
      * inspector/front-end/NetworkManager.js:
      (WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
      * inspector/front-end/Resource.js:
      (WebInspector.Resource.prototype.get page):
      (WebInspector.Resource.prototype.set page):
      * inspector/front-end/ResourceTreeModel.js:
      (WebInspector.ResourceTreeFrame):
      (WebInspector.ResourceTreeFrame.prototype.get page):
      (WebInspector.PageDispatcher.prototype.domContentEventFired):
      (WebInspector.PageDispatcher.prototype.loadEventFired):
      
      LayoutTests:
      
      * http/tests/inspector/resource-har-headers-expected.txt:
      * http/tests/inspector/resource-parameters-expected.txt:
      * platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb63aefe
    • philn@webkit.org's avatar
      Unreviewed, GTK gardening, marked a test as flaky and unskipped · 321c8a00
      philn@webkit.org authored
      several needing new baselines.
      
      * platform/gtk/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      321c8a00
  2. 22 Jan, 2012 4 commits
  3. 21 Jan, 2012 8 commits
    • abarth@webkit.org's avatar
      Add baselines for test after http://trac.webkit.org/changeset/105575. · 83c7daf5
      abarth@webkit.org authored
      This baseline looks very similar to the existing non-Chromium baseline.
      
      * platform/chromium-mac-snowleopard/svg/filters/feImage-preserveAspectratio-expected.png: Added.
      * platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83c7daf5
    • commit-queue@webkit.org's avatar
      Add .url attribute alongside .URL in EventSource and WebSocket to comply with... · ac5e5167
      commit-queue@webkit.org authored
      Add .url attribute alongside .URL in EventSource and WebSocket to comply with the specs but not break existing usage.
      https://bugs.webkit.org/show_bug.cgi?id=40899
      
      Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-21
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Tests: fast/eventsource/eventsource-url-attribute.html
             http/tests/websocket/tests/hixie76/url-attribute.html
             http/tests/websocket/tests/hybi/url-attribute.html
      
      * page/EventSource.idl:
      * websockets/WebSocket.idl:
      
      LayoutTests:
      
      * fast/eventsource/eventsource-url-attribute-expected.txt: Added.
      * fast/eventsource/eventsource-url-attribute.html: Added.
      * http/tests/websocket/tests/hixie76/url-attribute-expected.txt: Added.
      * http/tests/websocket/tests/hixie76/url-attribute.html: Added.
      * http/tests/websocket/tests/hybi/url-attribute-expected.txt: Added.
      * http/tests/websocket/tests/hybi/url-attribute.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac5e5167
    • ossy@webkit.org's avatar
      [Qt] Unreviewed weekend gardening. Skip the new failing tests to paint the bots green. · 1382e97e
      ossy@webkit.org authored
      * platform/qt-wk2/Skipped:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1382e97e
    • cmarrin@apple.com's avatar
      Implement hardware accelerated Brightness and contrast filters · 0b88a94b
      cmarrin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75521
      https://bugs.webkit.org/show_bug.cgi?id=76719
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Implemented hardware accelerated brightness and contrast filters. This also fixes
      the bug where grayscale filter was accidentally never getting hardware accelerated.
      It also complies with proposed spec changes for the brightness filter to be additive
      rather than multiplicative, according to https://bugs.webkit.org/show_bug.cgi?id=76719.
      Had to make both fixes in the same patch because I had to change the allowed brightness
      values for the hardware version, so I had to change the software version as well.
      
      Tests: css3/filters/effect-brightness-hw.html
             css3/filters/effect-contrast-hw.html
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseBuiltinFilterArguments):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::createFilterOperations):
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      (PlatformCALayer::setFilters):
      (PlatformCALayer::filtersCanBeComposited):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::build):
      
      LayoutTests:
      
      New tests for hardware accelerated brightness and contrast filters. Also
      added brightness and contrast values to effect-combined-hw test. And changed
      brightness values in effect-brightness.html to reflect new spec.
      Also fixed parsing and computed style tests to reflect new brightness spec.
      
      * css3/filters/effect-brightness-expected.png:
      * css3/filters/effect-brightness-hw-expected.png: Added.
      * css3/filters/effect-brightness-hw-expected.txt: Added.
      * css3/filters/effect-brightness-hw.html: Added.
      * css3/filters/effect-brightness.html:
      * css3/filters/effect-combined-expected.png:
      * css3/filters/effect-combined-hw-expected.png:
      * css3/filters/effect-combined-hw-expected.txt:
      * css3/filters/effect-combined-hw.html:
      * css3/filters/effect-combined.html:
      * css3/filters/effect-contrast-hw-expected.png: Added.
      * css3/filters/effect-contrast-hw-expected.txt: Added.
      * css3/filters/effect-contrast-hw.html: Added.
      * css3/filters/filter-property-computed-style-expected.txt:
      * css3/filters/filter-property-parsing-expected.txt:
      * css3/filters/filter-property-parsing-invalid-expected.txt:
      * css3/filters/script-tests/filter-property-computed-style.js:
      * css3/filters/script-tests/filter-property-parsing-invalid.js:
      * css3/filters/script-tests/filter-property-parsing.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b88a94b
    • zimmermann@webkit.org's avatar
      2012-01-21 Nikolas Zimmermann <nzimmermann@rim.com> · a31d0f89
      zimmermann@webkit.org authored
              <feImage> ignores preserveAspectRatio="none"
              https://bugs.webkit.org/show_bug.cgi?id=76780
      
              Reviewed by Antti Koivisto.
      
              Add new testcase covering preserveAspectRatio="none" + <feImage>, which is now fixed.
      
              * platform/chromium/test_expectations.txt: Add new test, that needs a rebaseline.
              * platform/mac/svg/filters/feImage-preserveAspectratio-expected.png: Added.
              * platform/mac/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
              * svg/filters/feImage-preserveAspectratio.svg: Added.
      
      2012-01-21  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              <feImage> ignores preserveAspectRatio="none"
              https://bugs.webkit.org/show_bug.cgi?id=76780
      
              Reviewed by Antti Koivisto.
      
              preserveAspectRatio="none" was ignored in SVGFEImage. It always called transformRect() w/o checking
              whether it was supposed to transform the rect or not - move code from RenderSVGImage right into
              transformRect(), to do nothing if preserveAspectRatio="none" was given.
      
              Test: svg/filters/feImage-preserveAspectratio.svg
      
              * rendering/svg/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::paint):
              * svg/SVGPreserveAspectRatio.cpp:
              (WebCore::SVGPreserveAspectRatio::transformRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a31d0f89
    • jochen@chromium.org's avatar
      history.replaceState should update the HistoryItem to use a GET method if previously non-GET (POST) · 55c7a7f6
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76721
      
      Reviewed by Mihai Parparita.
      
      Source/WebCore:
      
      Tests: http/tests/history/replacestate-post-to-get-2.html
             http/tests/history/replacestate-post-to-get.html
      
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::replaceState):
      
      LayoutTests:
      
      * http/tests/history/replacestate-post-to-get-2-expected.txt: Added.
      * http/tests/history/replacestate-post-to-get-2.html: Added.
      * http/tests/history/replacestate-post-to-get-expected.txt: Added.
      * http/tests/history/replacestate-post-to-get.html: Added.
      * http/tests/history/resources/replacestate-current.php: Added.
      * http/tests/history/resources/replacestate-forward-back.php: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55c7a7f6
    • commit-queue@webkit.org's avatar
      Null dereference in SVGDocumentExtensions::removePendingResource when updating <use>'s href · 0dcb8ba8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69284
      
      Patch by Florin Malita <fmalita@google.com> on 2012-01-21
      Reviewed by Nikolas Zimmermann.
      
      Source/WebCore:
      
      Test: svg/custom/use-crash-pending-resource.svg
      
      The crash is caused by assumptions in SVGUseElement that xlink:href is the only
      pending resource. This patch adds support for dealing with multiple pending resources.
      
      * rendering/svg/RenderSVGResourceContainer.cpp:
      (WebCore::RenderSVGResourceContainer::registerResource):
      * svg/SVGDocumentExtensions.cpp:
      (WebCore::SVGDocumentExtensions::hasPendingResource):
      (WebCore::SVGDocumentExtensions::isElementPendingResources):
      (WebCore::SVGDocumentExtensions::isElementPendingResource):
      (WebCore::SVGDocumentExtensions::removePendingResourceForElement):
      * svg/SVGDocumentExtensions.h:
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
      (WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible):
      Renamed SVGDocumentExtensions::hasPendingResources -> Renamed SVGDocumentExtensions::hasPendingResource.
      Renamed SVGDocumentExtensions::isElementInPendingResources -> SVGDocumentExtensions::isElementPendingResources.
      Added support for querying and removing pending resources for a specific element.
      
      * svg/SVGUseElement.cpp:
      (WebCore::SVGUseElement::svgAttributeChanged):
      (WebCore::SVGUseElement::buildPendingResource):
      Refactored to support multiple pending resources.
      
      LayoutTests:
      
      * svg/custom/use-crash-pending-resource-expected.txt: Added.
      * svg/custom/use-crash-pending-resource.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dcb8ba8
    • commit-queue@webkit.org's avatar
      REGRESSION (Safari 5.0.5 - ToT): crash in SVG test... · ba91e069
      commit-queue@webkit.org authored
      REGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/animate-elem-39-t.html
      https://bugs.webkit.org/show_bug.cgi?id=64671
      
      Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-21
      Reviewed by Nikolas Zimmermann.
      
      Source/WebCore:
      
      No new tests. This change is to fix crashes in existing tests.
      
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::beginListChanged): If the new begin time is
      later than the current end time, and the event time is also after then
      end time (but we have not yet updated to that time) and the animation
      is active, we need to make the animation inactive explicitly.
      
      LayoutTests:
      
      * platform/chromium/test_expectations.txt: Marking all svg/W3C-SVG-1.1/animate-elem* tests
      as flakey pending this change being committed and new results.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba91e069
  4. 20 Jan, 2012 5 commits