Commit ffa57415 authored by mrowe@apple.com's avatar mrowe@apple.com

Don't treat the misnamed NSAccessibilitySortButtonRole as an accessibility role.

It is really a subrole of NSAccessibilityButtonRole.  As it is not used inside WebCore
there is no change in behaviour as a result of doing this. This fixes <rdar://problem/5866444>.

Reviewed by Jon Honeycutt.

* page/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::canSetFocusAttribute): Remove SortButtonRole as it is unused.
* page/AccessibilityObject.h: Ditto.
(WebCore::):
* page/mac/AccessibilityObjectWrapper.mm:
(RoleEntry::):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent b9e5d1cf
2008-04-15 Mark Rowe <mrowe@apple.com>
Reviewed by Jon Honeycutt.
Don't treat the misnamed NSAccessibilitySortButtonRole as an accessibility role. It is really
a subrole of NSAccessibilityButtonRole. As it is not used inside WebCore there is no change in
behaviour as a result of doing this. This fixes <rdar://problem/5866444>.
* page/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::canSetFocusAttribute): Remove SortButtonRole as it is unused.
* page/AccessibilityObject.h: Ditto.
(WebCore::):
* page/mac/AccessibilityObjectWrapper.mm:
(RoleEntry::):
2008-04-15 Anders Carlsson <andersca@apple.com> 2008-04-15 Anders Carlsson <andersca@apple.com>
Fix leaks seen on bot. Fix leaks seen on bot.
...@@ -1751,7 +1751,6 @@ bool AccessibilityObject::canSetFocusAttribute() const ...@@ -1751,7 +1751,6 @@ bool AccessibilityObject::canSetFocusAttribute() const
case MatteRole: case MatteRole:
case RulerRole: case RulerRole:
case RulerMarkerRole: case RulerMarkerRole:
case SortButtonRole:
case LinkRole: case LinkRole:
case DisclosureTriangleRole: case DisclosureTriangleRole:
case GridRole: case GridRole:
......
...@@ -125,10 +125,12 @@ enum AccessibilityRole { ...@@ -125,10 +125,12 @@ enum AccessibilityRole {
MatteRole, MatteRole,
RulerRole, RulerRole,
RulerMarkerRole, RulerMarkerRole,
SortButtonRole,
LinkRole, LinkRole,
DisclosureTriangleRole, DisclosureTriangleRole,
GridRole, GridRole,
// AppKit includes SortButtonRole but it is misnamed and really a subrole of ButtonRole so we do not include it here.
// WebCore-specific roles // WebCore-specific roles
WebCoreLinkRole, WebCoreLinkRole,
ImageMapRole, ImageMapRole,
......
...@@ -669,7 +669,6 @@ static const AccessibilityRoleMap& createAccessibilityRoleMap() ...@@ -669,7 +669,6 @@ static const AccessibilityRoleMap& createAccessibilityRoleMap()
{ MatteRole, NSAccessibilityMatteRole }, { MatteRole, NSAccessibilityMatteRole },
{ RulerRole, NSAccessibilityRulerRole }, { RulerRole, NSAccessibilityRulerRole },
{ RulerMarkerRole, NSAccessibilityRulerMarkerRole }, { RulerMarkerRole, NSAccessibilityRulerMarkerRole },
{ SortButtonRole, NSAccessibilitySortButtonRole },
{ LinkRole, NSAccessibilityLinkRole }, { LinkRole, NSAccessibilityLinkRole },
#ifndef BUILDING_ON_TIGER #ifndef BUILDING_ON_TIGER
{ DisclosureTriangleRole, NSAccessibilityDisclosureTriangleRole }, { DisclosureTriangleRole, NSAccessibilityDisclosureTriangleRole },
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment