Commit fd84b4d1 authored by commit-queue@webkit.org's avatar commit-queue@webkit.org
Browse files

2011-01-17 Helder Correia <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
        https://bugs.webkit.org/show_bug.cgi?id=52556

        The shadow color opacity needs to be set on the shadow painter.
        Additionally, the gradient brush should be transformed.

        * platform/qt/Skipped: Remove test from skipped list.
2011-01-17  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
        https://bugs.webkit.org/show_bug.cgi?id=52556

        The shadow color opacity needs to be set on the shadow painter.
        Additionally, the gradient brush should be transformed.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillPath):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 6cbc9242
2011-01-17 Helder Correia <helder@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
https://bugs.webkit.org/show_bug.cgi?id=52556
The shadow color opacity needs to be set on the shadow painter.
Additionally, the gradient brush should be transformed.
* platform/qt/Skipped: Remove test from skipped list.
2011-01-17 Philippe Normand <pnormand@igalia.com>
 
Unreviewed, rolling out r75914.
......
......@@ -2372,7 +2372,6 @@ fast/text/large-text-composed-char-dos.html
fast/text/international/002.html
fast/block/positioning/absolute-in-inline-rtl-4.html
fast/canvas/canvas-gradient-addStop-error.html
fast/canvas/canvas-fillPath-gradient-shadow.html
fast/css/zoom-body-scroll.html
fast/dom/Element/getBoundingClientRect.html
fast/dom/Element/getClientRects.html
......
2011-01-17 Helder Correia <helder@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
https://bugs.webkit.org/show_bug.cgi?id=52556
The shadow color opacity needs to be set on the shadow painter.
Additionally, the gradient brush should be transformed.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
2011-01-17 No'am Rosenthal <noam.rosenthal@nokia.com>
 
Reviewed by Kenneth Rohde Christiansen.
......
......@@ -496,8 +496,13 @@ void GraphicsContext::fillPath(const Path& path)
{
QPainter* shadowPainter = shadow->beginShadowLayer(this, platformPath.controlPointRect());
if (shadowPainter) {
shadowPainter->setCompositionMode(QPainter::CompositionMode_Source);
shadowPainter->fillPath(platformPath, QColor(m_data->shadow.m_color));
if (m_state.fillGradient) {
QBrush brush(*m_state.fillGradient->platformGradient());
brush.setTransform(m_state.fillGradient->gradientSpaceTransform());
shadowPainter->setOpacity(static_cast<qreal>(shadow->m_color.alpha()) / 255);
shadowPainter->fillPath(platformPath, brush);
} else
shadowPainter->fillPath(platformPath, QColor(shadow->m_color));
shadow->endShadowLayer(this);
}
} else {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment