Commit f930d000 authored by adele@apple.com's avatar adele@apple.com

WebCore:

2008-07-07  Adele Peterson  <adele@apple.com>

        Reviewed by Beth.

        Fix for <rdar://problem/5860507> <AUDIO> playback noticeably more quiet than QuickTime

        Change default volume setting to 1.0.

        * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):
        * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer):

LayoutTests:

2008-07-07  Adele Peterson  <adele@apple.com>

        Reviewed by Beth.

        Test for <rdar://problem/5860507> <AUDIO> playback noticeably more quiet than QuickTime

        * media/video-volume-expected.txt:
        * media/video-volume.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent d006497c
2008-07-07 Adele Peterson <adele@apple.com>
Reviewed by Beth.
Test for <rdar://problem/5860507> <AUDIO> playback noticeably more quiet than QuickTime
* media/video-volume-expected.txt:
* media/video-volume.html:
2008-07-07 Beth Dakin <bdakin@apple.com>
Reviewed by Anders.
Test 'volume' attribute
TEST(video.volume == 1.0) OK
RUN(video.volume = 0.5)
TEST(video.volume == 0.5) OK
RUN(video.volume = 1)
TEST(video.volume == 1) OK
RUN(video.volume = 0)
TEST(video.volume == 0) OK
TEST(video.volume = 1.5) THROWS(DOMException.INDEX_SIZE_ERR) OK
......
......@@ -2,9 +2,9 @@
<p>Test 'volume' attribute<p>
<script src=video-test.js></script>
<script>
test("video.volume == 1.0");
run("video.volume = 0.5");
test("video.volume == 0.5");
run("video.volume = 1");
test("video.volume == 1");
run("video.volume = 0");
test("video.volume == 0");
testException("video.volume = 1.5", "DOMException.INDEX_SIZE_ERR");
......
2008-07-07 Adele Peterson <adele@apple.com>
Reviewed by Beth.
Fix for <rdar://problem/5860507> <AUDIO> playback noticeably more quiet than QuickTime
Change default volume setting to 1.0.
* html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):
* platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer):
2008-07-07 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
......@@ -68,7 +68,7 @@ HTMLMediaElement::HTMLMediaElement(const QualifiedName& tagName, Document* doc)
, m_loadedFirstFrame(false)
, m_autoplaying(true)
, m_currentLoop(0)
, m_volume(0.5f)
, m_volume(1.0f)
, m_muted(false)
, m_paused(true)
, m_seeking(false)
......
......@@ -49,7 +49,7 @@ namespace WebCore {
, m_frameView(0)
, m_visible(false)
, m_rate(1.0f)
, m_volume(0.5f)
, m_volume(1.0f)
{
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment