Commit f9194859 authored by commit-queue@webkit.org's avatar commit-queue@webkit.org
Browse files

2011-01-17 Jarred Nicholls <jarred@sencha.com>

        Reviewed by Csaba Osztrogonác.

        REGRESSION(r75709): Return value of fscanf() shouldn't be ignored.
        https://bugs.webkit.org/show_bug.cgi?id=52585

        gcc 4.4.4+ has warn_unused_value attribute on fscanf, so we should check
        the return value to get around the gcc warning

        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::maybeModifyVMPoolSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent b1155bd1
2011-01-17 Jarred Nicholls <jarred@sencha.com>
Reviewed by Csaba Osztrogonác.
REGRESSION(r75709): Return value of fscanf() shouldn't be ignored.
https://bugs.webkit.org/show_bug.cgi?id=52585
gcc 4.4.4+ has warn_unused_value attribute on fscanf, so we should check
the return value to get around the gcc warning
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::maybeModifyVMPoolSize):
2011-01-17 Michael Saboff <msaboff@apple.com>
 
Reviewed by Oliver Hunt.
......
......@@ -461,10 +461,11 @@ static void maybeModifyVMPoolSize()
return;
unsigned overcommit = 0;
fscanf(fp, "%u", &overcommit);
if (overcommit == 1) {
vmPoolSize = vmPoolSizeOvercommit;
coalesceLimit = coalesceLimitOvercommit;
if (fscanf(fp, "%u", &overcommit) == 1) {
if (overcommit == 1) {
vmPoolSize = vmPoolSizeOvercommit;
coalesceLimit = coalesceLimitOvercommit;
}
}
fclose(fp);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment