Commit f6d51be3 authored by ossy@webkit.org's avatar ossy@webkit.org

Style Checker false pass.

https://bugs.webkit.org/show_bug.cgi?id=112456

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-03
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/style/checkers/changelog.py:
(ChangeLogChecker.check_entry):
simple regex fix to check "No new tests (...)."
* Scripts/webkitpy/style/checkers/changelog_unittest.py:
(ChangeLogCheckerTest.test_no_new_tests):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent ae72d2a1
2013-12-03 Gergo Balogh <geryxyz@inf.u-szeged.hu>
Style Checker false pass.
https://bugs.webkit.org/show_bug.cgi?id=112456
Reviewed by Csaba Osztrogonác.
* Scripts/webkitpy/style/checkers/changelog.py:
(ChangeLogChecker.check_entry):
simple regex fix to check "No new tests (...)."
* Scripts/webkitpy/style/checkers/changelog_unittest.py:
(ChangeLogCheckerTest.test_no_new_tests):
2013-12-02 Filip Pizlo <fpizlo@apple.com>
run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
......
......@@ -65,11 +65,11 @@ class ChangeLogChecker(object):
"changelog/filechangedescriptionwhitespace", 5,
"Need whitespace between colon and description")
# check for a lingering "No new tests. (OOPS!)" left over from prepare-changeLog.
# check for a lingering "No new tests (OOPS!)." left over from prepare-changeLog.
line_no = first_line_checked - 1
for line in entry_lines:
line_no = line_no + 1
if match('\s*No new tests. \(OOPS!\)$', line):
if match('\s*No new tests \(OOPS!\)\.$', line):
self.handle_style_error(line_no,
"changelog/nonewtests", 5,
"You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.")
......
......@@ -125,7 +125,7 @@ class ChangeLogCheckerTest(unittest.TestCase):
' ExampleBug\n'
' http://bugs.webkit.org/show_bug.cgi?id=12345\n'
'\n'
' No new tests. (OOPS!)\n'
' No new tests (OOPS!).\n'
' * Source/Tools/random-script.py: Fixed')
def test_no_error(self):
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment