Commit f5c9a5cc authored by timothy@apple.com's avatar timothy@apple.com
Browse files

Fix singular labels for test failures.

https://bugs.webkit.org/show_bug.cgi?id=122200

Reviewed by Joseph Pecoraro.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 11657937
......@@ -77,13 +77,13 @@ BuildbotTesterQueueView.prototype = {
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "layout test failure" : "layout test failures", layoutTestResults.tooManyFailures ? layoutTestResults.failureCount + "\uff0b" : layoutTestResults.failureCount, url);
} else if (!layoutTestResults.failureCount && javascriptTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.failureCount) {
var url = iteration.queue.buildbot.javascriptTestResultsURLForIteration(iteration);
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "javascript test failure" : "javascript test failures", javascriptTestResults.failureCount, url);
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, javascriptTestResults.failureCount === 1 ? "javascript test failure" : "javascript test failures", javascriptTestResults.failureCount, url);
} else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.failureCount) {
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "webkitpy test failure" : "webkitpy test failures", pythonTestResults.failureCount);
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, pythonTestResults.failureCount === 1 ? "webkitpy test failure" : "webkitpy test failures", pythonTestResults.failureCount);
} else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !pythonTestResults.failureCount && perlTestResults.failureCount && !bindingTestResults.failureCount) {
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "webkitperl test failure" : "webkitperl test failures", perlTestResults.failureCount);
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, perlTestResults.failureCount === 1 ? "webkitperl test failure" : "webkitperl test failures", perlTestResults.failureCount);
} else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && bindingTestResults.failureCount) {
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "binding test failure" : "binding test failures", bindingTestResults.failureCount);
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, bindingTestResults.failureCount === 1 ? "binding test failure" : "binding test failures", bindingTestResults.failureCount);
} else {
var totalFailures = layoutTestResults.failureCount + javascriptTestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.failureCount;
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, totalFailures === 1 ? "test failure" : "test failures");
......
2013-10-01 Timothy Hatcher <timothy@apple.com>
Fix singular labels for test failures.
https://bugs.webkit.org/show_bug.cgi?id=122200
Reviewed by Joseph Pecoraro.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2013-10-01 Timothy Hatcher <timothy@apple.com>
Don't keep appending iterations each time the queue updates.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment