Commit f5c7bd6c authored by jer.noble@apple.com's avatar jer.noble@apple.com
Browse files

2011-06-12 Jer Noble <jer.noble@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
        https://bugs.webkit.org/show_bug.cgi?id=62507

        No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
        webkitWillExitFullScreenForElement() to be able to test this.

        If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
        fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
        containsFullScreenElement property removed.  To protect against this, reset the property by calling
        setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().

        * dom/Document.cpp:
        (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 4fc62a9e
2011-06-12 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=62507
No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
webkitWillExitFullScreenForElement() to be able to test this.
If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
containsFullScreenElement property removed. To protect against this, reset the property by calling
setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().
* dom/Document.cpp:
(WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
......
......@@ -4916,6 +4916,7 @@ void Document::fullScreenChangeDelayTimerFired(Timer<Document>*)
void Document::fullScreenElementRemoved()
{
setContainsFullScreenElementRecursively(m_fullScreenElement->parentElement() ? m_fullScreenElement->parentElement() : ownerElement(), false);
webkitCancelFullScreen();
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment