fix build warning(unused parameter)

https://bugs.webkit.org/show_bug.cgi?id=114855

Patch by Xuefei Ren <xren@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.

Source/WebCore:

remove warning(unused parameter) in
Source/WebCore/platform/graphics/blackberry

* platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(WebCore::CanvasLayerCompositingThreadClient::drawTextures):
(WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
(WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
* platform/graphics/blackberry/FontBlackBerry.cpp:
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getTraitsInFamily):
* platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp:
(WebCore::GlyphPage::fill):
* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
* platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
* platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::flushAndDraw):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::platformTransformColorSpace):
* platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::drawTile):
* platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::clipPath):
* platform/graphics/blackberry/PatternBlackBerry.cpp:
(WebCore::Pattern::platformPattern):

Source/WebKit/blackberry:

remove warning(unused parameter) in
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::extractedTextRequest):

Tools:

remove warning(unused parameter) in
Tools/DumpRenderTree/blackberry/EventSender.cpp

* DumpRenderTree/blackberry/EventSender.cpp:
(getDragModeCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 90b768b0
2013-04-22 Xuefei Ren <xren@blackberry.com>
fix build warning(unused parameter)
https://bugs.webkit.org/show_bug.cgi?id=114855
Reviewed by Rob Buis.
remove warning(unused parameter) in
Source/WebCore/platform/graphics/blackberry
* platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(WebCore::CanvasLayerCompositingThreadClient::drawTextures):
(WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
(WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
* platform/graphics/blackberry/FontBlackBerry.cpp:
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getTraitsInFamily):
* platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp:
(WebCore::GlyphPage::fill):
* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
* platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
* platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::flushAndDraw):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::platformTransformColorSpace):
* platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::drawTile):
* platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::clipPath):
* platform/graphics/blackberry/PatternBlackBerry.cpp:
(WebCore::Pattern::platformPattern):
2013-04-22 Mike Fenton <mifenton@rim.com>
[BlackBerry] Add additional datalist support.
......@@ -58,7 +58,7 @@ CanvasLayerCompositingThreadClient::CanvasLayerCompositingThreadClient(BlackBerr
{
}
void CanvasLayerCompositingThreadClient::drawTextures(LayerCompositingThread* layer, double scale, const GLES2Program&)
void CanvasLayerCompositingThreadClient::drawTextures(LayerCompositingThread* layer, double, const GLES2Program&)
{
if (!m_buffer)
return;
......@@ -70,12 +70,12 @@ void CanvasLayerCompositingThreadClient::drawTextures(LayerCompositingThread* la
BlackBerry::Platform::Graphics::SourceOver, static_cast<unsigned char>(layer->drawOpacity() * 255));
}
void CanvasLayerCompositingThreadClient::deleteTextures(LayerCompositingThread* layer)
void CanvasLayerCompositingThreadClient::deleteTextures(LayerCompositingThread*)
{
// Nothing to do here, the buffer is not owned by us.
}
void CanvasLayerCompositingThreadClient::commitPendingTextureUploads(LayerCompositingThread* layer)
void CanvasLayerCompositingThreadClient::commitPendingTextureUploads(LayerCompositingThread*)
{
if (!m_buffer)
return;
......
......@@ -62,7 +62,7 @@ float Font::floatWidthForComplexText(const TextRun& run, HashSet<const SimpleFon
}
// Return the code point index for the given |x| offset into the text run.
int Font::offsetForPositionForComplexText(const TextRun& run, float position, bool includePartialGlyphs) const
int Font::offsetForPositionForComplexText(const TextRun& run, float position, bool) const
{
// FIXME: This truncation is not a problem for HTML, but only affects SVG, which passes floating-point numbers
// to Font::offsetForPosition(). Bug http://webkit.org/b/40673 tracks fixing this problem.
......
......@@ -178,7 +178,7 @@ PassRefPtr<SimpleFontData> FontCache::getFontDataForCharacters(const Font& font,
return getCachedFontData(&platformData, DoNotRetain);
}
PassRefPtr<SimpleFontData> FontCache::getSimilarFontPlatformData(const Font& font)
PassRefPtr<SimpleFontData> FontCache::getSimilarFontPlatformData(const Font&)
{
return 0;
}
......@@ -212,7 +212,7 @@ PassRefPtr<SimpleFontData> FontCache::getLastResortFallbackFont(const FontDescri
return getCachedFontData(fontPlatformData);
}
void FontCache::getTraitsInFamily(const AtomicString& familyName, Vector<unsigned>& traitsMasks)
void FontCache::getTraitsInFamily(const AtomicString&, Vector<unsigned>&)
{
notImplemented();
}
......
......@@ -47,7 +47,7 @@ private:
DestroyFunction m_destroy;
};
bool GlyphPage::fill(unsigned offset, unsigned length, UChar* buffer, unsigned bufferLength, const SimpleFontData* fontData)
bool GlyphPage::fill(unsigned offset, unsigned, UChar* buffer, unsigned bufferLength, const SimpleFontData* fontData)
{
bool haveGlyphs = false;
unsigned position = 0;
......
......@@ -386,7 +386,7 @@ GraphicsContext3D::ImageExtractor::~ImageExtractor()
{
}
bool GraphicsContext3D::ImageExtractor::extractImage(bool premultiplyAlpha, bool ignoreGammaAndColorProfile)
bool GraphicsContext3D::ImageExtractor::extractImage(bool premultiplyAlpha, bool)
{
if (!m_image)
return false;
......
......@@ -174,7 +174,7 @@ void GraphicsContext::strokeArc(const IntRect& rect, int startAngle, int angleSp
platformContext()->addArc(rect, startAngle, angleSpan);
}
void GraphicsContext::drawConvexPolygon(size_t numPoints, const FloatPoint* points, bool shouldAntialias)
void GraphicsContext::drawConvexPolygon(size_t numPoints, const FloatPoint* points, bool)
{
if (paintingDisabled())
return;
......@@ -200,7 +200,7 @@ void GraphicsContext::fillRect(const FloatRect& rect)
platformContext()->addFillRect(rect, platformGradient, platformPattern);
}
void GraphicsContext::fillRect(const FloatRect& rect, const Color& color, ColorSpace colorSpace)
void GraphicsContext::fillRect(const FloatRect& rect, const Color& color, ColorSpace)
{
if (paintingDisabled())
return;
......@@ -234,7 +234,7 @@ void GraphicsContext::strokeRect(const FloatRect& rect, float lineWidth)
platformContext()->addStrokeRect(rect, lineWidth);
}
void GraphicsContext::fillRoundedRect(const IntRect& rect, const IntSize& topLeft, const IntSize& topRight, const IntSize& bottomLeft, const IntSize& bottomRight, const Color& color, ColorSpace colorSpace)
void GraphicsContext::fillRoundedRect(const IntRect& rect, const IntSize& topLeft, const IntSize& topRight, const IntSize& bottomLeft, const IntSize& bottomRight, const Color& color, ColorSpace)
{
if (paintingDisabled())
return;
......@@ -245,12 +245,12 @@ void GraphicsContext::fillRoundedRect(const IntRect& rect, const IntSize& topLef
platformContext()->setFillColor(m_state.fillColor.rgb());
}
FloatRect GraphicsContext::roundToDevicePixels(const FloatRect& rect, RoundingMode roundingMode)
FloatRect GraphicsContext::roundToDevicePixels(const FloatRect& rect, RoundingMode)
{
return rect;
}
void GraphicsContext::setPlatformShadow(const FloatSize& offset, float blur, const Color& color, ColorSpace colorSpace)
void GraphicsContext::setPlatformShadow(const FloatSize& offset, float blur, const Color& color, ColorSpace)
{
if (paintingDisabled())
return;
......@@ -353,7 +353,7 @@ void GraphicsContext::clipOut(const IntRect& rect)
platformContext()->clipOut(FloatRect(rect));
}
void GraphicsContext::clipConvexPolygon(size_t numPoints, const FloatPoint* points, bool antialias)
void GraphicsContext::clipConvexPolygon(size_t numPoints, const FloatPoint* points, bool)
{
if (paintingDisabled())
return;
......@@ -395,7 +395,7 @@ IntRect GraphicsContext::clipBounds() const
return IntRect(IntPoint(INT_MIN / 2, INT_MIN / 2), IntSize(INT_MAX, INT_MAX));
}
void GraphicsContext::setURLForRect(const KURL& link, const IntRect& destRect)
void GraphicsContext::setURLForRect(const KURL&, const IntRect&)
{
}
......@@ -407,7 +407,7 @@ void GraphicsContext::setPlatformTextDrawingMode(TextDrawingModeFlags mode)
platformContext()->setTextDrawingMode(mode);
}
void GraphicsContext::setPlatformStrokeColor(const Color& color, ColorSpace colorSpace)
void GraphicsContext::setPlatformStrokeColor(const Color& color, ColorSpace)
{
if (paintingDisabled())
return;
......@@ -431,7 +431,7 @@ void GraphicsContext::setPlatformStrokeThickness(float thickness)
platformContext()->setStrokeThickness(thickness);
}
void GraphicsContext::setPlatformFillColor(const Color& color, ColorSpace colorSpace)
void GraphicsContext::setPlatformFillColor(const Color& color, ColorSpace)
{
if (paintingDisabled())
return;
......@@ -439,7 +439,7 @@ void GraphicsContext::setPlatformFillColor(const Color& color, ColorSpace colorS
platformContext()->setFillColor(color.rgb());
}
void GraphicsContext::setPlatformCompositeOperation(CompositeOperator op, BlendMode blendMode)
void GraphicsContext::setPlatformCompositeOperation(CompositeOperator op, BlendMode)
{
if (paintingDisabled())
return;
......
......@@ -124,7 +124,7 @@ void BitmapImage::draw(GraphicsContext* context, const FloatRect& dstRect, const
draw(context, dstRect, srcRect, styleColorSpace, op, DoNotRespectImageOrientation);
}
void BitmapImage::draw(GraphicsContext* context, const FloatRect& dstRect, const FloatRect& srcRect, ColorSpace styleColorSpace, CompositeOperator op, RespectImageOrientationEnum shouldRespectImageOrientation)
void BitmapImage::draw(GraphicsContext* context, const FloatRect& dstRect, const FloatRect& srcRect, ColorSpace, CompositeOperator op, RespectImageOrientationEnum shouldRespectImageOrientation)
{
startAnimation();
......@@ -172,7 +172,7 @@ void BitmapImage::draw(GraphicsContext* context, const FloatRect& dstRect, const
observer->didDraw(this);
}
void Image::drawPattern(GraphicsContext* context, const FloatRect& srcRect, const AffineTransform& patternTransformation, const FloatPoint& phase, ColorSpace styleColorSpace, CompositeOperator op, const FloatRect& dstRect, BlendMode blendMode)
void Image::drawPattern(GraphicsContext* context, const FloatRect& srcRect, const AffineTransform& patternTransformation, const FloatPoint& phase, ColorSpace, CompositeOperator op, const FloatRect& dstRect, BlendMode)
{
NativeImagePtr image = nativeImageForCurrentFrame();
if (!image)
......
......@@ -113,7 +113,7 @@ void ImageBufferData::getImageData(GraphicsContext* context, const IntRect& rect
getImageDataInternal(context, rect, size, result, unmultiply, m_window);
}
static bool flushAndDraw(const ImageBufferData* object, GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator op, bool useLowQualityScale)
static bool flushAndDraw(const ImageBufferData* object, GraphicsContext* context, ColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator op, bool)
{
if (!makeBufferCurrent(object->m_window)) {
BlackBerry::Platform::logAlways(BlackBerry::Platform::LogLevelWarn,
......@@ -153,7 +153,7 @@ void ImageBufferData::draw(GraphicsContext* thisContext, GraphicsContext* otherC
}
}
ImageBuffer::ImageBuffer(const IntSize& size, float resolutionScale, ColorSpace colorSpace, RenderingMode renderingMode, HostWindow* window, bool& success)
ImageBuffer::ImageBuffer(const IntSize& size, float, ColorSpace, RenderingMode renderingMode, HostWindow* window, bool& success)
: m_size(size)
, m_logicalSize(size)
, m_resolutionScale(1)
......@@ -207,7 +207,7 @@ PlatformLayer* ImageBuffer::platformLayer() const
return m_data.m_platformLayer.get();
}
PassRefPtr<Image> ImageBuffer::copyImage(BackingStoreCopy copyBehavior, ScaleBehavior) const
PassRefPtr<Image> ImageBuffer::copyImage(BackingStoreCopy, ScaleBehavior) const
{
// FIXME respect copyBehaviour enum.
unsigned* imageData = new unsigned[m_size.width() * m_size.height()];
......@@ -224,7 +224,7 @@ void ImageBuffer::clip(GraphicsContext* context, const FloatRect& rect) const
context->platformContext()->addMaskLayer(rect, nativeImage);
}
void ImageBuffer::draw(GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator op, BlendMode blendMode, bool useLowQualityScale)
void ImageBuffer::draw(GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator op, BlendMode, bool useLowQualityScale)
{
m_data.draw(m_context.get(), context, styleColorSpace, destRect, srcRect, op, useLowQualityScale);
}
......@@ -235,7 +235,7 @@ void ImageBuffer::drawPattern(GraphicsContext* context, const FloatRect& srcRect
image->drawPattern(context, srcRect, patternTransform, phase, styleColorSpace, op, destRect);
}
void ImageBuffer::platformTransformColorSpace(const Vector<int>& lookUpTable)
void ImageBuffer::platformTransformColorSpace(const Vector<int>&)
{
}
......
......@@ -446,7 +446,7 @@ void LayerTiler::performTileJob(LayerTile* tile, const TextureJob& job)
ASSERT_NOT_REACHED();
}
bool LayerTiler::drawTile(LayerCompositingThread* layer, double scale, const TileIndex& index, const FloatRect& dst, const GLES2Program& program)
bool LayerTiler::drawTile(LayerCompositingThread* layer, double scale, const TileIndex& index, const FloatRect& dst, const GLES2Program&)
{
TransformationMatrix drawTransform = layer->drawTransform();
float vertices[4 * 4];
......
......@@ -231,12 +231,12 @@ void GraphicsContext::strokePath(const Path& path)
}
}
void GraphicsContext::drawFocusRing(const Vector<IntRect>& rects, int width, int offset, const Color& color)
void GraphicsContext::drawFocusRing(const Vector<IntRect>&, int, int, const Color&)
{
notImplemented();
}
void GraphicsContext::drawFocusRing(const Path& path, int width, int offset, const Color& color)
void GraphicsContext::drawFocusRing(const Path&, int, int, const Color&)
{
notImplemented();
}
......@@ -263,7 +263,7 @@ void GraphicsContext::clip(const Path& path, WindRule)
pp->applyAsClip(platformContext());
}
void GraphicsContext::clipPath(const Path& path, WindRule clipRule)
void GraphicsContext::clipPath(const Path& path, WindRule)
{
if (path.platformPath()->isRectangular())
platformContext()->clip(path.boundingRect());
......
......@@ -36,7 +36,7 @@ void Pattern::platformDestroy()
m_pattern = 0;
}
PlatformPatternPtr Pattern::platformPattern(const AffineTransform& patternTransform)
PlatformPatternPtr Pattern::platformPattern(const AffineTransform&)
{
if (m_pattern)
return m_pattern;
......
2013-04-22 Xuefei Ren <xren@blackberry.com>
fix build warning(unused parameter)
https://bugs.webkit.org/show_bug.cgi?id=114855
Reviewed by Rob Buis.
remove warning(unused parameter) in
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::extractedTextRequest):
2013-04-22 Xan Lopez <xlopez@igalia.com>
[BlackBerry] ASSERT in FrameLoaderClient::convertMainResourceLoadToDownload
......
......@@ -2232,7 +2232,7 @@ spannable_string_t* InputHandler::textAfterCursor(int32_t length, int32_t flags)
return spannableTextInRange(start, end, flags);
}
extracted_text_t* InputHandler::extractedTextRequest(extracted_text_request_t* request, int32_t flags)
extracted_text_t* InputHandler::extractedTextRequest(extracted_text_request_t*, int32_t flags)
{
if (!isActiveTextEdit())
return 0;
......
2013-04-22 Xuefei Ren <xren@blackberry.com>
fix build warning(unused parameter)
https://bugs.webkit.org/show_bug.cgi?id=114855
Reviewed by Rob Buis.
remove warning(unused parameter) in
Tools/DumpRenderTree/blackberry/EventSender.cpp
* DumpRenderTree/blackberry/EventSender.cpp:
(getDragModeCallback):
2013-04-22 Alberto Garcia <agarcia@igalia.com>
[BlackBerry] Add dummy implementation of AccessibilityController::accessibleElementById()
......@@ -47,7 +47,7 @@ void sendTouchEvent(BlackBerry::Platform::TouchEvent::Type);
// Callbacks
static JSValueRef getDragModeCallback(JSContextRef context, JSObjectRef, JSStringRef, JSValueRef* exception)
static JSValueRef getDragModeCallback(JSContextRef context, JSObjectRef, JSStringRef, JSValueRef*)
{
notImplemented();
return JSValueMakeUndefined(context);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment